pull_requests
Data license: AGPL · Data source: ACEmulator Project
3,817 rows sorted by closed_at
This data as json, CSV (advanced)
Suggested facets: state, assignee, draft, author_association, created_at (date), updated_at (date), closed_at (date), merged_at (date)
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at ▼ | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
330776748 | MDExOlB1bGxSZXF1ZXN0MzMwNzc2NzQ4 | 2345 | open | 0 | [WIP] adding preliminary calcs for allegiance passup xp realtime and gametime factors | gmriggs 8909245 | Still left to solve: how to best handle players who have already been sworn for quite some time, but no swear timestamps were saved for Setting the current timestamp/age would be easy, but also would also not be beneficial to players who have been in established allegiances. I would give these players the benefit of the doubt, and set their data to the server established timestamp. | 2019-10-22T02:25:44Z | 2019-10-22T10:33:06Z | d50170f46850bf03a0d7739abe7093a179e6635c | 0 | f90bad155c241c4789dd38f9fbf7eee53a13650c | e0b22c65509b19459e7c35239289f63f233c0082 | COLLABORATOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/2345 | ||||||
362790116 | MDExOlB1bGxSZXF1ZXN0MzYyNzkwMTE2 | 2616 | open | 0 | improved database persistence for biota_properties_generator | gmriggs 8909245 | I did a search through all the weenie_properties_generators, and for every object except 31986, the probabilities are always in ascending order. However, this is not 100% foolproof, and there are a few caveats with this: some generators contain spans with the same probabilities, usually a bunch of -1's... these will still be sorted into a non-guaranteed order This should cover 99.9%+ of the scenarios though, and let us get away with restoring the biota_properties_generator in the original weenie_properties_generator ordering, without an explicit 'order' column | 2020-01-14T19:02:08Z | 2020-08-09T23:59:51Z | bd5f2769e7104f864e50eafd0bda97ed58243210 | 0 | 08c7fa8a8e26ea515b5e7481477bc7ebd8c826b0 | 0de3dfb6bbec332dbaeeb3ca09300afa734dd869 | COLLABORATOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/2616 | ||||||
386978488 | MDExOlB1bGxSZXF1ZXN0Mzg2OTc4NDg4 | 2809 | open | 0 | [TEST] network relogin | gmriggs 8909245 | Repro steps: - In your Config.js, set DefaultSessionTimeout to 999 for easier testing - In your log4net.config, set the Console threshold to DEBUG for easier testing - Connect to your local server in ThwargLauncher advanced mode. Make sure your server name in ThwargLauncher does NOT match up with your local server name, so that if ThwargLauncher is left open, it automatically disconnects you in ~30s - Log into the game world - Wait for ThwargLauncher to automatically close the AC window - Try to reconnect Expected: - Existing character is booted out of the game world Actual: - Existing character is never booted out of the game world. New session cannot connect. There are some odd issues with this PR, namely if you try this multiple times, the existing Player state will get into an odd loop, where the Session is disconnected, but the Player is still saving on the landblock or something.. This can be seen after multiple retries, or using /pktimer sometimes helps. The previous session will go into 'SessionTerminating' state, and then be dropped, while the previous player still seems to be in the world. This allows the new session to connect to the char select screen, but then gets into an automatic loop when trying to log into the world, until the existing player is finally logged out. Could use @fartwhif 's help on this one | 2020-03-12T00:15:23Z | 2020-09-05T07:04:39Z | 4ac49b9e6cbb3331f58ce7af9bb416209ab60794 | 0 | d25ab818f8cdb779c2c7e34674bad615ce52d416 | 0c25ae21cb76f77c1dfb56f4077bd339969589ba | COLLABORATOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/2809 | ||||||
447837872 | MDExOlB1bGxSZXF1ZXN0NDQ3ODM3ODcy | 3074 | open | 0 | wip: recklessness updates | gmriggs 8909245 | - Fixes an issue with recklessness ratings from both attacker and defender being combined as multipliers, instead of additives. With 2 players that have recklessness speced, this provided a 44% damage increase, instead of 40% - Starts to fix some issues with Recklessness! combat message prefixes, although still needs to be investigated more: Scenario A: a non-reckless player attacks a player currently in reckless mode. Both players currently receive the Recklessness! prefix for the combat message, as the attack received a bonus from the defender being in reckless mode. This is confusing for the attacker, since they might not even have recklessness trained. Scenario B: a reckless player attacks a monster. When the monster hits the player, the combat message is currently prefixed with Recklessness!, since the monster received a damage bonus from the player being in reckless mode. Should this message only have been sent if the attacker was in reckless mode? | 2020-07-12T01:28:17Z | 2020-07-12T01:34:05Z | cb182b49f67c8bb7670bfef5925bea7ed0be727a | 0 | 3af224b330eb5daaa04c9c0642babd93b0f19c5d | 9897501ad357ba84ac60461bcc9c066904a2d86f | COLLABORATOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/3074 | ||||||
567367834 | MDExOlB1bGxSZXF1ZXN0NTY3MzY3ODM0 | 3446 | open | 0 | Add support for servers to periodically communicate with external services | amoeba 563 | Hey all, I was talking about something I've built with @LtRipley36706 the other day and he thought other devs would be interested in seeing a PR so here it is: It would be really interesting if ACE servers could communicate with external services. There's been a ton of discussion about _how_ to do this, going back to https://github.com/ACEmulator/ACE/issues/718. Providing an HTTP API is a really powerful idea but presents a ton of problems such as rate limiting, running read-only replicas of the database, and so on. A lighter weight and simpler approach is to have ACE servers _send_ any information to external services periodically. The biggest downside here is that the feature only works if the external service stays available. What I've done here is created a new `*Manager` class called `HeartbeatManager` that based on code that already existed in ACE that sends a JSON payload to a configurable HTTP endpoint at a configurable interval. Think [webhook](https://en.wikipedia.org/wiki/Webhook). The immediate thing ACE servers could do with this is broadcast whether the server is up and how many players are online to services such as https://treestats.net. People are very interested in how many players are on each server but the TreeStats way of tracking [server populations](https://treestats.net/player_counts/) requires players on each server to run my Decal plugin. And even then, the temporal resolution of the population data depends on how many players are running the plugin. With my system here, ACE servers could send their `OnlineCount` to TreeStats at intervals and we'd all have much better data to look at. Some notes: 1. This PR isn't done, I'm having some issues figuring out default values in the config 2. The payload is hardcoded to send `WorldName` and `OnlineCount` but I think we could find some easy way to let users configure the Manager to send more info such as any config properties (xp rate, pk/npk, etc) or even information obtained from database queries such as total characters. 3… | 2021-02-04T06:18:53Z | 2021-02-09T00:23:06Z | ba6b69b64db09829c7d198ce7d83d19326b63737 | 1 | 52fb5cb89ccef5304f6b9f3b3ef00acefd226843 | 9b1086786f619f11383bb16737c63acc2ce5ba8b | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/3446 | ||||||
647222458 | MDExOlB1bGxSZXF1ZXN0NjQ3MjIyNDU4 | 3547 | open | 0 | [TEST] add option to enable constraint manager on server | gmriggs 8909245 | 2021-05-19T02:37:30Z | 2021-06-10T23:05:04Z | 1159c8a4fb9e11897f4c65faf9175558ecb9d093 | 0 | 27c68e8ce2dbe6e3d662bac88cc0883c3cd71f68 | 0ba331a3d39637b983d4900af5ffe89d74e9b363 | COLLABORATOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/3547 | |||||||
1023212133 | PR_kwDOBLalGM48_Ppl | 3888 | open | 0 | Add audit trail to Destroy, TryRemoveFromInventory, TryDequipObject | LtRipley36706 11369233 | This disables wieldable item deletion from database except upon startup orphan purge. PurgeOrphanedBiotas should be disabled to gather test data. This will consume GUIDs at a significantly higher rate as any item not deleted cannot be recycled | 2022-08-10T21:13:04Z | 2024-03-21T03:56:44Z | 65450fcb358c2cba89161f35b426e89ddda6eba0 | 1 | 9fa3437477e185574ddac2818c977d6a1ef69047 | af867f4422d7174ef96977fc4a02a3681cb32a0a | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/3888 | ||||||
1176871111 | PR_kwDOBLalGM5GJaDH | 3944 | open | 0 | Server setting to enable substituting legendary key rewards emotes | Gordian3 1765994 | This PR provides a server setting "award_wcid_for_legendary" that allows for substitution of legendary keys with the provided WCID. For instance, a server offering legendary keys for sale on a vendor for 1 MMD per pull may set this to 20630. This allows players to not have to deal with large numbers of unstackable legendary keys from Kill Tasks and other quests. Another option would be Promissory Notes (43901). The server operator can provide any WCID but generally it would be something stackable. This change only impacts emote based giving. It does not change any looting of legendary keys from corpses or chests such as at the casinos. The default option is "0" which is interpreted as disabled so there is no substitution. The actual rewards to users depend a bit on how the quest emotes are configured. If they offer 5 rewards, each of 1 Aged Legendary Key, then the player would get 5 different of the substituted item. You can see this in the Tou Tou KTs. For Frozen Valley Gurog, it is a singe reward of multiple keys. In this case the new items (promissory notes in this case) are stacked. At Hoshino's the Durable keys become stacks of 10 of the item. ![AgedLegendaries_grp_5](https://user-images.githubusercontent.com/1765994/209414274-24b34a21-ab7f-4838-baeb-87143fe3fbd7.png) ![AgedLegendaries_grp_5_log](https://user-images.githubusercontent.com/1765994/209414281-f149e9c3-ebca-45df-8d93-a9afd0d24e03.png) ![DurableKey_subst_reward](https://user-images.githubusercontent.com/1765994/209414291-5aa9c23e-2d14-4c4f-9d55-b86dba5d88aa.png) ![DurableKey_subst_reward_log](https://user-images.githubusercontent.com/1765994/209414298-ef95ec1e-d45e-4011-89ae-6dad5529f34a.png) | 2022-12-23T23:57:20Z | 2023-07-15T16:30:00Z | 50021489967051b8ab186ba93c8071f472660358 | 0 | 4637cdd903e61c48e789675c074fb306054ef19c | 654842057768f242ad17f401adc4e42009f6f18c | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/3944 | ||||||
1607706611 | PR_kwDOBLalGM5f06fz | 4059 | open | 0 | Switch to net8 | LtRipley36706 11369233 | Switches net6 projects to net8 projects net6 LTS ends in one year per [https://dotnet.microsoft.com/en-us/platform/support/policy](https://dotnet.microsoft.com/en-us/platform/support/policy) | 2023-11-18T21:07:00Z | 2024-04-05T17:20:38Z | a64684d199e2ec010a71e92c9f997fa9192caa89 | 1 | b51138d5511761c27b295cbfce2ff6398e167623 | 1fe5cd48bf00dc9d61613be8bbbc24d96216d386 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4059 | ||||||
1609992318 | PR_kwDOBLalGM5f9oh- | 4063 | open | 0 | Bump System.Text.Encoding.CodePages from 6.0.0 to 8.0.0 in /Source | dependabot[bot] 49699333 | Bumps [System.Text.Encoding.CodePages](https://github.com/dotnet/runtime) from 6.0.0 to 8.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dotnet/runtime/releases">System.Text.Encoding.CodePages's releases</a>.</em></p> <blockquote> <h2>.NET 8.0.0</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0">Release</a></p> <h2>.NET 8.0 RC 2</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-rc.2">Release</a></p> <h2>.NET 8.0 RC 1</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-rc.1">Release</a></p> <h2>.NET 8.0 Preview 7</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.7">Release</a></p> <h2>.NET 8.0 Preview 6</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.6">Release</a></p> <h2>.NET 8.0 Preview 5</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.5">Release</a></p> <h2>.NET 8.0 Preview 4</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.4">Release</a></p> <h2>.NET 8.0 Preview 3</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.3">Release</a></p> <h2>.NET 8.0 Preview 2</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.2">Release</a></p> <h2>.NET 8.0 Preview 1</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.1">Release</a></p> <h2>.NET 7.0.14</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v7.0.14">Release</a></p> <h2>What's Changed</h2> <ul> <li>[release/7.0-staging] Check for <!-- raw HTML omitted -->.deps.json when enumerating framework paths by <a href="https://github.com/elinor-fung"><code>@elinor-fung</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92033">dotnet/runtime#92033</a></li> <li>[release/7.0] Update Ubuntu 16.04 amd64 queues to 22.04 by <a href="https://github.com/carlossanlop"><code>@carlossanlop</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92796">dotnet/runtime… | 2023-11-20T23:33:23Z | 2023-12-21T19:00:08Z | f230bf3497c408e1879fa3cdb8e0ebfe7d8beb2b | 0 | e53feb9835028cdfe75ce60ca9fb60c4d4decdb8 | 0122e3cd55f80133281f9798adbafc3a1889533a | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4063 | ||||||
1724766204 | PR_kwDOBLalGM5mzdf8 | 4111 | open | 0 | Use a non buffering partioner for Parallel.ForEach | Mag-nus 10608427 | No idea if this will help or hurt high load servers like CE | 2024-02-13T23:31:19Z | 2024-03-13T02:47:39Z | 520557be5c17825d4522831f4e1507a5c8abfc64 | 0 | e5483afe878ff48a669dfe44f525f2ec40894bbd | 39592f281c35b09d3d549ba54688c6af7654a091 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4111 | ||||||
1731791318 | PR_kwDOBLalGM5nOQnW | 4114 | open | 0 | Encounter Adjustments | LtRipley36706 11369233 | 2024-02-18T18:43:08Z | 2024-02-25T19:08:01Z | 2471a790bc3f3ac782bc3101625e9c09e2ae5db2 | 1 | b3daac3af3c1c21f9b596ae8e1f247a17a6ef329 | f03c542f9108ce655d2ac695976af5cda19df566 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4114 | |||||||
1733699284 | PR_kwDOBLalGM5nVibU | 4115 | open | 0 | Bump dotnet/sdk from 6.0 to 8.0.101 | dependabot[bot] 49699333 | Bumps dotnet/sdk from 6.0 to 8.0.101. <details> <summary>Most Recent Ignore Conditions Applied to This Pull Request</summary> | Dependency Name | Ignore Conditions | | --- | --- | | dotnet/sdk | [>= 7.a, < 8] | </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dotnet/sdk&package-manager=docker&previous-version=6.0&new-version=8.0.101)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop D… | 2024-02-19T23:13:39Z | 2024-02-19T23:13:50Z | 1ac2aedb36f47cd395d559a09877fbe1b4e9a789 | 0 | c9c464649564be0faf520b99391e6a40494f8f9a | f03c542f9108ce655d2ac695976af5cda19df566 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4115 | ||||||
1773427822 | PR_kwDOBLalGM5ptFxu | 4130 | open | 0 | Bump System.Drawing.Common from 6.0.0 to 8.0.3 in /Source | dependabot[bot] 49699333 | [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=System.Drawing.Common&package-manager=nuget&previous-version=6.0.0&new-version=8.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> | 2024-03-15T05:07:48Z | 2024-03-26T04:31:44Z | 987d11e812bd2d93fce5337a7b9a5994c22f5696 | 0 | 318fa5b6737c454d8a625121110d03be0b5ac4fd | 80a9e8275411108e9e9a58620956e3df82305a37 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4130 | ||||||
1778729314 | PR_kwDOBLalGM5qBUFi | 4135 | open | 0 | Bump System.Text.Json from 6.0.9 to 8.0.3 in /Source | dependabot[bot] 49699333 | Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 6.0.9 to 8.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dotnet/runtime/releases">System.Text.Json's releases</a>.</em></p> <blockquote> <h2>.NET 8.0.3</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.3">Release</a></p> <h2>.NET 8.0.2</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.2">Release</a></p> <h2>.NET 8.0.1</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.1">Release</a></p> <h2>.NET 8.0.0</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0">Release</a></p> <h2>What's Changed</h2> <ul> <li>[release/8.0-rc1] [release/8.0] Events for IL methods without IL headers by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92317">dotnet/runtime#92317</a></li> <li>[release/8.0] Update dependencies from dotnet/source-build-externals by <a href="https://github.com/dotnet-maestro"><code>@dotnet-maestro</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92340">dotnet/runtime#92340</a></li> <li>[release/8.0-rc1] [release/8.0] Fix wasi build. by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92368">dotnet/runtime#92368</a></li> <li>[automated] Merge branch 'release/8.0-rc2' => 'release/8.0' by <a href="https://github.com/dotnet-maestro-bot"><code>@dotnet-maestro-bot</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92325">dotnet/runtime#92325</a></li> <li>[release/8.0] Update dependencies from dotnet/roslyn by <a href="https://github.com/dotnet-maestro"><code>@dotnet-maestro</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92303">dotnet/runtime#92303</a></li> <li>[automated] Merge branch 'release/8.0-rc1' => 'release/8.0' by <a href="https://github.com/dotnet-maestro-bot"><code>@dotnet-maestro-bo… | 2024-03-18T23:32:22Z | 2024-03-18T23:32:33Z | f31ffd67270510d744979927e2f218d0a71e306f | 0 | cc3e83a54fd2d2ebd13648cdf0c8a4760edd977d | 250f0fc31be5d14aae44f19078653950a4387f58 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4135 | ||||||
1781226232 | PR_kwDOBLalGM5qK1r4 | 4136 | open | 0 | Crude periodic GC | Mag-nus 10608427 | 2024-03-20T02:20:57Z | 2024-03-24T14:30:48Z | 7240f3f875a84b98219ee6f425763d921d863716 | 0 | 434ccdc1aff68ec682ae54db32417362853e995b | 250f0fc31be5d14aae44f19078653950a4387f58 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4136 | |||||||
1782493957 | PR_kwDOBLalGM5qPrMF | 4137 | open | 0 | Add option for unlimited GUID sequence gaps | LtRipley36706 11369233 | This allows servers to load *all* possible GUID sequence gaps instead of hard coded limit of 10,000,000. | 2024-03-20T16:22:37Z | 2024-03-24T12:45:12Z | 9e08cf436d5d8646c2baf987dabb353b7f19192b | 0 | 1b7b36de71909b24b80e5cbf0220f283c4498b21 | a1b41584ed7a385ba10d8fa77d792a37cd66a268 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/4137 | ||||||
102959085 | MDExOlB1bGxSZXF1ZXN0MTAyOTU5MDg1 | 1 | closed | 0 | Updates to database and underlying code | xanxin887 6705011 | Updates to database and underlying code | 2017-01-24T16:55:13Z | 2017-01-24T18:24:10Z | 2017-01-24T18:24:10Z | dce6693ebf2125dccfaf02a0b0328031a16815b2 | 0 | 5c139c0bcee1fabf0c959c196a932a938df17f19 | 3c13cc6acacd9d3a208503b5c5e5e2f0d44cf4c9 | NONE | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/1 | |||||
102981430 | MDExOlB1bGxSZXF1ZXN0MTAyOTgxNDMw | 2 | closed | 0 | Updates for DB 1/24/17 | xanxin887 6705011 | Updates for DB to prep for creating associated tables | 2017-01-24T18:58:40Z | 2017-02-01T12:50:46Z | 2017-02-01T12:50:46Z | b53a9f175617206d2d805f6f38657e0d038ff651 | 0 | 72e524a4667fda86bc42371c8a65ec1b8a956d66 | 3c13cc6acacd9d3a208503b5c5e5e2f0d44cf4c9 | NONE | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/2 | |||||
104196635 | MDExOlB1bGxSZXF1ZXN0MTA0MTk2NjM1 | 10 | closed | 0 | Client and Server expects account in ace_auth to be lowercase only. | LtRipley36706 11369233 | This is my first pull request, please let me know if I'm doing this incorrectly. Simple change I made to the accountcreate command to correct and prevent the issue I experienced when setting up ACE. The client always sends accounts as lowercase regardless of what the user types in the command line. The server itself resolves the difference and connects as well. The issue surfaces when attempting to create a character. That packet is sent, but no response is ever recv'd. | 2017-02-01T18:45:44Z | 2017-02-02T16:36:57Z | 2017-02-02T16:36:53Z | 2017-02-02T16:36:53Z | 77932b57355c6283b67052f448e2b041794f76ad | 0 | 3cee156a52d1385c06ee7553248b6aed8442ae0c | 95910918de3356f10cf5e519dd4cb7dfd7a731b8 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/10 | ||||
104288490 | MDExOlB1bGxSZXF1ZXN0MTA0Mjg4NDkw | 11 | closed | 0 | Run faster, jump higher, teleport to coordinates (rather than XYZ position) | sbaum23 22650655 | These values are hardcoded and need to be replaced with actual values from the Player object. This is mainly to let people run around faster in the emu until code it put in to send all player skills to client. I'm Xen on Discord. | 2017-02-02T07:42:55Z | 2017-02-03T20:59:39Z | 2017-02-03T20:59:39Z | 0d76d44ad9bc278db860ab38f71371230cb400d2 | 0 | 5282ba7507342911f331cac1657f4e7c00a2a487 | 77932b57355c6283b67052f448e2b041794f76ad | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/11 | |||||
104478851 | MDExOlB1bGxSZXF1ZXN0MTA0NDc4ODUx | 13 | closed | 0 | database layer encapsulation and abstraction | Mogwai-TheFurry 25351661 | Sorry about the solution file. I'm on VS 2015 pro and I've no idea why it changed. All I did was add the .gitignore as a solution item. Use Visual Studio to diff the files. Git isn't doing a good job with the compare. Mogwai in Discord. | 2017-02-03T05:44:27Z | 2017-02-04T05:55:04Z | 2017-02-04T05:54:55Z | 989f09a0a827e88373b6de9395d7427d5aaabb62 | 0 | 93e9a5ce54a01aa41de87bedb603161443a3d348 | e871785055353d86b12d57f0f6788cde43dfd994 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/13 | |||||
104650586 | MDExOlB1bGxSZXF1ZXN0MTA0NjUwNTg2 | 16 | closed | 0 | database abstraction and encapsulation. created character model and skill attribute models. | Mogwai-TheFurry 25351661 | 2017-02-04T05:57:10Z | 2017-02-04T06:42:11Z | 2017-02-04T06:42:11Z | 4ac9e65768aaeb926535ecaf6866fcf0f27a2c12 | 0 | 929481260c1f198cacd699c9561a2b43a8cfd62f | 86c9c58bc10d90d3fe792d0ca000e5cb46183abe | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/16 | ||||||
104651917 | MDExOlB1bGxSZXF1ZXN0MTA0NjUxOTE3 | 17 | closed | 0 | database encapsulation is done! yay! | Mogwai-TheFurry 25351661 | 2017-02-04T06:55:34Z | 2017-05-30T15:34:08Z | 2017-02-04T07:13:27Z | 2017-02-04T07:13:27Z | 264b760729df18b09fd82c5a543ffc5bd33efa8f | 0 | f3c21a6b6724344244f26a460e026159796941ff | 86c9c58bc10d90d3fe792d0ca000e5cb46183abe | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/17 | |||||
104668808 | MDExOlB1bGxSZXF1ZXN0MTA0NjY4ODA4 | 22 | closed | 0 | Teleloc loader fix and basic set of locations | ChrisAikman 10677293 | Fixed an index bug in `WorldDatabase.GetLocations` and added a basic set of telelocations to the `teleport_location` table for use with `teleloc`. Updated the `teleloc` command to accept multiple name locations, such as `Ayan Baqur`. | 2017-02-04T17:48:51Z | 2017-02-04T22:11:12Z | 2017-02-04T22:11:12Z | 2017-02-04T22:11:12Z | 7044ce63422bf70fe8118ef99967f93440e77f7e | 0 | 807116f0d6a16379dd3f2e1e7a07437ded090d2a | 264b760729df18b09fd82c5a543ffc5bd33efa8f | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/22 | ||||
104652614 | MDExOlB1bGxSZXF1ZXN0MTA0NjUyNjE0 | 18 | closed | 0 | Option to Enable Automatic Account Creation | LtRipley36706 11369233 | Added a configurable variable to Config.json for allowing the server to create an account for the client when one does not exist on the server. | 2017-02-04T07:23:37Z | 2017-03-20T02:59:13Z | 2017-02-04T22:14:16Z | b34024b2fce8032ab72784481d8caf22ffe654c6 | 0 | e590e18a645f0f87d218107f82829943b9254359 | 264b760729df18b09fd82c5a543ffc5bd33efa8f | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/18 | |||||
104675888 | MDExOlB1bGxSZXF1ZXN0MTA0Njc1ODg4 | 23 | closed | 0 | Add Config.json to .gitignore | zbuc 570040 | This also forces first-time configuration. Existing Config.json copied to Config.json.example README.md has been updated with instructions. | 2017-02-04T21:12:57Z | 2017-02-04T22:53:44Z | 2017-02-04T22:53:44Z | 2017-02-04T22:53:44Z | dc14891256be0e40fa4bf3db87217d159080b4cc | 0 | e9a903c165521e623cb81782104791b7b7c95052 | 264b760729df18b09fd82c5a543ffc5bd33efa8f | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/23 | ||||
104676562 | MDExOlB1bGxSZXF1ZXN0MTA0Njc2NTYy | 24 | closed | 0 | Fixed bug in CharacterCreate. | LtRipley36706 11369233 | It was not changing the AccountId in the database when saving leading to empty character list. | 2017-02-04T21:32:30Z | 2017-02-17T06:50:27Z | 2017-02-04T22:54:04Z | 2017-02-04T22:54:04Z | 1e84da7a438bd092c6d425e2090654e8e102f11e | 0 | 3252dc371f8de89d7fe5f1c1e89ae98f51d45466 | 264b760729df18b09fd82c5a543ffc5bd33efa8f | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/24 | ||||
104612473 | MDExOlB1bGxSZXF1ZXN0MTA0NjEyNDcz | 14 | closed | 0 | Added /teleto command | sbaum23 22650655 | My commit has the wrong command in it. I added the /teleto command for teleporting using coordinates. | 2017-02-03T21:12:15Z | 2017-02-05T06:37:44Z | 2017-02-05T02:21:27Z | 8bdb2d66e2170855dd67e479821befc3f6ebb33d | 0 | b5666aa832f6eb72defb3fe876cb5f0480fd3b89 | 77932b57355c6283b67052f448e2b041794f76ad | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/14 | |||||
104678600 | MDExOlB1bGxSZXF1ZXN0MTA0Njc4NjAw | 27 | closed | 0 | Corrected spelling in a few places. | LtRipley36706 11369233 | 2017-02-04T22:36:04Z | 2017-02-05T09:07:42Z | 2017-02-05T03:35:03Z | 2017-02-05T03:35:03Z | 50f190237620c104b7f142aef0508bdd4888da97 | 0 | 00aa9c5bc4fe1891e54c81cd1c5f7e615af9ce46 | 7044ce63422bf70fe8118ef99967f93440e77f7e | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/27 | |||||
104686397 | MDExOlB1bGxSZXF1ZXN0MTA0Njg2Mzk3 | 30 | closed | 0 | Fix for NAT issues on internal connections to WorldServer | LtRipley36706 11369233 | This should help alleviate the issue some people will see when configuring all IPs to external, but connecting to the server on internal IPs. | 2017-02-05T03:53:57Z | 2017-03-10T04:56:23Z | 2017-02-05T05:37:01Z | 074b40e9a820a16d22b31bec29d2d935e17080f4 | 0 | 2e4162f62030a6bcba396adf03ef74dbc77cb6a4 | 50f190237620c104b7f142aef0508bdd4888da97 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/30 | |||||
104684490 | MDExOlB1bGxSZXF1ZXN0MTA0Njg0NDkw | 29 | closed | 0 | Teleto command redo | sbaum23 22650655 | Fixed coding convention issues with my previous commit. | 2017-02-05T02:20:42Z | 2017-02-05T06:21:29Z | 2017-02-05T06:01:09Z | 246c972196717c17a45187a329bb5d2a891f5362 | 0 | 18332f3c69490e063489adceedf23cebe162703d | c5f72473010b292592e70daa174f48aa3ad55127 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/29 | |||||
104677809 | MDExOlB1bGxSZXF1ZXN0MTA0Njc3ODA5 | 25 | closed | 0 | Option to Enable Automatic Account Creation | LtRipley36706 11369233 | Added a configurable variable to Config.json for allowing the server to create an account for the client when one does not exist on the server. | 2017-02-04T22:11:38Z | 2017-03-20T02:59:21Z | 2017-02-05T08:52:58Z | 9da13efde6fbbb23bb1bc1aabb23afe8c4b56866 | 0 | edc656d67181398b24b5ac919391a267f19faaa6 | 7044ce63422bf70fe8118ef99967f93440e77f7e | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/25 | |||||
104677865 | MDExOlB1bGxSZXF1ZXN0MTA0Njc3ODY1 | 26 | closed | 0 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | 2017-02-04T22:13:24Z | 2017-03-10T04:56:27Z | 2017-02-05T09:03:41Z | f4dce31714f7a580da1d01aff9e554ba65b0bf68 | 0 | 0cdeaafe58516e82214cc149ee15a83cd6a2073b | 7044ce63422bf70fe8118ef99967f93440e77f7e | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/26 | |||||
104688734 | MDExOlB1bGxSZXF1ZXN0MTA0Njg4NzM0 | 32 | closed | 0 | Fix for NAT issues on internal connections to WorldServer | LtRipley36706 11369233 | This fix is meant help alleviate a NAT issue some people will see when configuring server IP to external address. Due to problematic NAT routing, connecting to external IP while on internal network leads to black screen on hand-off to world server. Others may not even be able to connect to server using external IP address. This fix should allow for external IP connection for those outside of network, and internal IP connection for those inside the network. | 2017-02-05T05:42:01Z | 2017-03-10T04:56:20Z | 2017-02-05T21:05:00Z | 42872992933c4e4982c2e46ffbaa90a7b0bb3e31 | 0 | e78024ecee915f1487bfcef2d20362dd0ffa85ab | 7b690552070222895d1de0aca5458c1cf02813e5 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/32 | |||||
104751331 | MDExOlB1bGxSZXF1ZXN0MTA0NzUxMzMx | 40 | closed | 0 | Adding in support for teleportation via clicking on the map panel. | LtRipley36706 11369233 | Go places faster! | 2017-02-06T08:06:40Z | 2017-02-07T18:34:48Z | 2017-02-06T12:12:46Z | 2017-02-06T12:12:46Z | 7f9e3cb35949e9638a51ff171a2e36e5b746bd23 | 0 | c00f94dbf77258ae28c9a7803447a9940e2401d3 | 33fcf1f196d7adfcfad2ebaa0640cb323592517e | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/40 | ||||
104689447 | MDExOlB1bGxSZXF1ZXN0MTA0Njg5NDQ3 | 33 | closed | 0 | Added /teleto command | sbaum23 22650655 | Z position needs to be calculated from a file but since that isn't in the code yet, I'm defaulting it to 200. For some places that is not high enough and you'll be in darkness, but at least this allows you to teleport using coordinates. | 2017-02-05T06:16:08Z | 2017-02-06T12:17:24Z | 2017-02-06T12:17:24Z | 2017-02-06T12:17:24Z | ec338cc5a505fbc3a3e93899b9b18d37f09805a3 | 0 | de5fe5205ce5084532a81466cb69ad81103120fe | 7b690552070222895d1de0aca5458c1cf02813e5 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/33 | ||||
104940626 | MDExOlB1bGxSZXF1ZXN0MTA0OTQwNjI2 | 47 | closed | 0 | Load saved characters | Mogwai-TheFurry 25351661 | 2017-02-07T05:43:40Z | 2017-05-30T15:34:10Z | 2017-02-07T16:49:01Z | 2017-02-07T16:49:01Z | 06880d3168925d78644bbef500caad641c683b7d | 0 | 4e071457e83a5b3ad8ab206a8e428f9c7e3416fb | ec338cc5a505fbc3a3e93899b9b18d37f09805a3 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/47 | |||||
104723892 | MDExOlB1bGxSZXF1ZXN0MTA0NzIzODky | 38 | closed | 0 | Fix for server crash when account does not exist for connecting client | LtRipley36706 11369233 | Please use this PR if rejecting PR #34. this contains the fix to the server crash when an account is not created and a client tried to connect to the server using the invalid account. this fix is already in PR #34 so if that one is accepted, reject this one. | 2017-02-06T01:04:32Z | 2017-02-07T18:34:41Z | 2017-02-07T16:49:41Z | 2017-02-07T16:49:41Z | 8fdbac59c65555a36ebb7642849539fbdda642bd | 0 | 9ab4e56179722ffb679514ab511c3dc24631dda4 | 7b690552070222895d1de0aca5458c1cf02813e5 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/38 | ||||
104692856 | MDExOlB1bGxSZXF1ZXN0MTA0NjkyODU2 | 34 | closed | 0 | Option to Enable Automatic Account Creation | LtRipley36706 11369233 | Added a configurable variable to Config.json.example for allowing the server to create an account for the client when one does not already exist on the server. | 2017-02-05T08:52:31Z | 2017-03-20T02:59:43Z | 2017-02-07T17:42:22Z | 6ecae5372114a08f7cb16ec99060ee7314cf317f | 0 | 8c577d5bbd5a93692e6e106eae596ac035ab0ee5 | 7b690552070222895d1de0aca5458c1cf02813e5 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/34 | |||||
105358446 | MDExOlB1bGxSZXF1ZXN0MTA1MzU4NDQ2 | 50 | closed | 0 | Spending XP in Abilities, Vitals, and Skills, Saving Property buckets… | Mogwai-TheFurry 25351661 | …. /grantxp command, moved persistence out of Player object for later refactoring of entity and data access project. | 2017-02-09T04:35:43Z | 2017-05-30T15:34:11Z | 2017-02-10T18:44:23Z | 2017-02-10T18:44:23Z | ca13a4fa1b0f044790c8373148715fabb2dd6527 | 0 | 82e9f29922b3e368b8c081019fb327769efe96d5 | 8fdbac59c65555a36ebb7642849539fbdda642bd | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/50 | ||||
104693108 | MDExOlB1bGxSZXF1ZXN0MTA0NjkzMTA4 | 35 | closed | 0 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json.example for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | 2017-02-05T09:03:13Z | 2017-03-10T04:56:13Z | 2017-02-11T05:46:23Z | e8a0449c7f2c303a2e01a4250fc6955c7b9073b0 | 0 | 2af29b0c51af56a712ed3905803e95879947be50 | 7b690552070222895d1de0aca5458c1cf02813e5 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/35 | |||||
104907637 | MDExOlB1bGxSZXF1ZXN0MTA0OTA3NjM3 | 46 | closed | 0 | Update create_mysql.sql | KochiroOfHG 25277356 | Added "IF NOT EXISTS" to the create statements so that if the database already exists then a warning will be thrown instead of an error. | 2017-02-06T23:46:04Z | 2017-02-12T11:36:42Z | 2017-02-12T11:36:42Z | 2017-02-12T11:36:42Z | 412806f7b20e82f5129e47b6009b028d766e7065 | 0 | b60bd334653b9ee57a22f78fb5ba374a82b5e644 | ec338cc5a505fbc3a3e93899b9b18d37f09805a3 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/46 | ||||
106032610 | MDExOlB1bGxSZXF1ZXN0MTA2MDMyNjEw | 61 | closed | 0 | project separation and xp chart files | Mogwai-TheFurry 25351661 | implements #43 and also moves all that xp chart data into json files loaded behind a database interface. | 2017-02-14T04:18:31Z | 2017-05-30T15:34:11Z | 2017-02-16T03:04:34Z | 2017-02-16T03:04:33Z | 0274077252de51711491f1be8a3a4f909509074e | 0 | 2cbc8487151dcd7e662c91cb36dc8a94837e3e63 | cc29606f674f5a46c768481e845edb63e48fdbfa | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/61 | ||||
106125642 | MDExOlB1bGxSZXF1ZXN0MTA2MTI1NjQy | 62 | closed | 0 | just adding stylecop as a style ruleset with very basic stuff | Mogwai-TheFurry 25351661 | the team can review the options and make changes as necessary. | 2017-02-14T15:19:35Z | 2017-05-30T15:34:12Z | 2017-02-16T03:14:13Z | 2017-02-16T03:14:13Z | 5567136fee3c8c1c4616341a9109d39113042d75 | 0 | 62baa4214bfef90e63b538ed3b04b2279e53febb | 0274077252de51711491f1be8a3a4f909509074e | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/62 | ||||
105919562 | MDExOlB1bGxSZXF1ZXN0MTA1OTE5NTYy | 60 | closed | 0 | Added automation script for dropping and creating databases. | damnubber 4389226 | 2017-02-13T15:46:59Z | 2017-02-16T03:16:56Z | 2017-02-16T03:16:56Z | 2017-02-16T03:16:56Z | 98875974bc31e7a51c5498c32c08b1bd79d62fbb | 0 | d0d5f157e808fcf3876c12595e71b7864691b68e | 5567136fee3c8c1c4616341a9109d39113042d75 | NONE | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/60 | |||||
105775228 | MDExOlB1bGxSZXF1ZXN0MTA1Nzc1MjI4 | 59 | closed | 0 | Handle setting title from client and updating title from server | LytelthorpeThistledown 25618389 | 2017-02-12T01:28:07Z | 2017-02-16T03:21:35Z | 2017-02-16T03:21:34Z | 2017-02-16T03:21:34Z | 63d531a47d985017ebab5c7d90fd6ed616bbbf8c | 0 | a1b5989211536b4c8b61f6e3343c6978c7e3a463 | cc29606f674f5a46c768481e845edb63e48fdbfa | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/59 | |||||
106448327 | MDExOlB1bGxSZXF1ZXN0MTA2NDQ4MzI3 | 64 | closed | 0 | fixing merge conflict | Mogwai-TheFurry 25351661 | 2017-02-16T03:26:33Z | 2017-02-16T03:26:38Z | 2017-02-16T03:26:38Z | 2017-02-16T03:26:38Z | 424278710f2755ed6b084694e936b9c23f9b21b1 | 0 | b44f56a83b0ff096acefcf4c19ea25fcf6c647d5 | 63d531a47d985017ebab5c7d90fd6ed616bbbf8c | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/64 | |||||
106448800 | MDExOlB1bGxSZXF1ZXN0MTA2NDQ4ODAw | 65 | closed | 0 | copy config.json as build step | Mogwai-TheFurry 25351661 | 2017-02-16T03:32:21Z | 2017-02-16T03:32:25Z | 2017-02-16T03:32:25Z | 2017-02-16T03:32:25Z | 877f3bf26dced9e6f54d937af8cd4b614aa35ef3 | 0 | c1f581f57f26a1909e1ef261d07a465448f43f6d | 424278710f2755ed6b084694e936b9c23f9b21b1 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/65 | |||||
105743042 | MDExOlB1bGxSZXF1ZXN0MTA1NzQzMDQy | 57 | closed | 0 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json.example for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | 2017-02-11T05:45:56Z | 2017-02-17T06:50:19Z | 2017-02-16T05:17:24Z | 4780877d08b0228e401a301592ed3ab0fa3f6c79 | 0 | 40ac5731fb816a87dc0fa0fda80192006300a2ee | 412806f7b20e82f5129e47b6009b028d766e7065 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/57 | |||||
106456643 | MDExOlB1bGxSZXF1ZXN0MTA2NDU2NjQz | 66 | closed | 0 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, character is marked deleted in database an hour after deleted from client via a server side SQL script running from event_scheduler. Later revisions to this code could address configuration variable(s) possibly in config.json.example for how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client, enable/disable this event check etc.. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | 2017-02-16T05:16:36Z | 2017-02-17T06:49:36Z | 2017-02-17T01:38:08Z | 2017-02-17T01:38:08Z | 64a76b56abf1712aceb85788c5d2093187d0f922 | 0 | b6a3741cddfe480d998abc783330e293aba853e9 | 877f3bf26dced9e6f54d937af8cd4b614aa35ef3 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/66 | ||||
105363346 | MDExOlB1bGxSZXF1ZXN0MTA1MzYzMzQ2 | 55 | closed | 0 | Stubbed CommandHandlers for known AdminCommands | LtRipley36706 11369233 | Stubbed known admin commands with expected usage. not all could eventually be needed. Some could example output could also be expanded upon. | 2017-02-09T05:41:21Z | 2017-02-17T06:50:21Z | 2017-02-17T06:30:40Z | 1f061c4e68d28d1924c18f33363a12fcf3aef702 | 0 | 7f22146776ba342d3be3b9498405d09ceffc5246 | 127dba77546682531dee465300c68e6a38e8a098 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/55 | |||||
106675759 | MDExOlB1bGxSZXF1ZXN0MTA2Njc1NzU5 | 67 | closed | 0 | Stubbed CommandHandlers for known AdminCommands | LtRipley36706 11369233 | Stubbed known admin commands with expected usage. not all could eventually be needed. Some example output could also be expanded upon as needed. | 2017-02-17T06:30:16Z | 2017-02-17T06:49:40Z | 2017-02-17T06:36:23Z | 2017-02-17T06:36:23Z | 5f10d5b1374e9853717c3bcdd9f4d67077396098 | 0 | b398c8980c6fe1989e70398156e0ab8057e9584c | e33fe98ff8da7871e4b51be8fdfeaee993b06fbb | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/67 | ||||
106677272 | MDExOlB1bGxSZXF1ZXN0MTA2Njc3Mjcy | 68 | closed | 0 | Fix for LoadCharacterProperties | LtRipley36706 11369233 | The PropertiesBools doesn't always get set on character upon login, this change should correct that issue. | 2017-02-17T06:47:15Z | 2017-02-17T06:49:45Z | 2017-02-17T06:47:29Z | 2017-02-17T06:47:29Z | 75721508e4ace60497a12c471404ed2d97c3504f | 0 | 9bb1142dc28b1f10e53c6ce4ddc932c937447915 | 5f10d5b1374e9853717c3bcdd9f4d67077396098 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/68 | ||||
105361307 | MDExOlB1bGxSZXF1ZXN0MTA1MzYxMzA3 | 54 | closed | 0 | Added friends list functionality. | sbaum23 22650655 | Friends load from database on login and add/removing friends also saves to the db. When a friend logs on, the player should see the status change to online but it's hard to test that completely right now. Changing the status to offline when a friend logs off is not yet implemented. I had to implement a couple methods in WorldManager to be able to query for connected clients. | 2017-02-09T05:14:37Z | 2017-02-17T08:00:32Z | 2017-02-17T08:00:32Z | cf9c0d5ca381e16ff9df8226e131c76326da43db | 0 | 38c537733780e16d1043785c7397c4e54bfa0644 | 8fdbac59c65555a36ebb7642849539fbdda642bd | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/54 | |||||
106802815 | MDExOlB1bGxSZXF1ZXN0MTA2ODAyODE1 | 70 | closed | 0 | code cleanup, plus introduction of a couple new world object heirarchy types | Mogwai-TheFurry 25351661 | 2017-02-17T20:06:05Z | 2017-05-30T15:34:17Z | 2017-02-17T20:20:43Z | 2017-02-17T20:20:43Z | f22695ac1b7e7aa89a335960d5a16bc24525b8e3 | 0 | 249628f48d298a8e002a153aaed26e3b3c4c6ece | 75721508e4ace60497a12c471404ed2d97c3504f | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/70 | |||||
106684356 | MDExOlB1bGxSZXF1ZXN0MTA2Njg0MzU2 | 69 | closed | 0 | Friends List | sbaum23 22650655 | Adds the ability to add/remove friends as well as see the list of friends when you log on. The status is also accurate and will change as friends log on/off. I added a Logout method to the Player class for putting stuff in there that needs to be done when a player logs off (like sending a packet to all your online friends that you are offline). The extra commits are due to rebasing. This resolves issue #39. | 2017-02-17T07:58:52Z | 2017-02-18T04:38:34Z | 2017-02-18T04:38:34Z | f207570aa52d0bd383ba9058d963a9463c9a0d23 | 0 | 7239c6a8c43272e9e507b4bceb4c6a3ccd84eb19 | 75721508e4ace60497a12c471404ed2d97c3504f | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/69 | |||||
106848125 | MDExOlB1bGxSZXF1ZXN0MTA2ODQ4MTI1 | 71 | closed | 0 | Issue 39 friends list | sbaum23 22650655 | Resolves #39 | 2017-02-18T04:40:22Z | 2017-02-18T04:46:34Z | 2017-02-18T04:46:34Z | 2017-02-18T04:46:34Z | 7ed6cd44ddaba15686f20374e3a8b22e5b195eff | 0 | 7239c6a8c43272e9e507b4bceb4c6a3ccd84eb19 | f22695ac1b7e7aa89a335960d5a16bc24525b8e3 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/71 | ||||
106853740 | MDExOlB1bGxSZXF1ZXN0MTA2ODUzNzQw | 74 | closed | 0 | Implemented "/friends remove -all", "/friends old" and Appear Offline. | sbaum23 22650655 | /friends old just sends a chat packet saying that the command isn't used in the emu. I also had to fix a bug in two WorldManager methods that I added in an earlier PR. There was a scenario where the Session.Player was null and it was causing the LINQ query to throw an exception. Appear Offline is actually part of a GameAction that is used for setting many different options. The Handle method for it now just has a switch in it (there are ~52 options) for now but we may want to go to something else in the future as we add new features. Resolves #72 | 2017-02-18T08:15:49Z | 2017-02-18T13:14:27Z | 2017-02-18T13:14:27Z | 2017-02-18T13:14:26Z | 8744cb1887673d28bb7f3c6b039cd6b6453b2613 | 0 | 76714d46e6138be302ee7d6134eaafd0b572992e | 7ed6cd44ddaba15686f20374e3a8b22e5b195eff | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/74 | ||||
106850209 | MDExOlB1bGxSZXF1ZXN0MTA2ODUwMjA5 | 73 | closed | 0 | Network Refactor | Zegeger 12808515 | Created GameMessage class. Currently GameEvent inherits from GameMessage. GameMessage just build MemoryStream for message. Moved all opcodes that are outside of GameEvent in protocol over to be a GameMessage. Created some basic (test) functions in NetworkManager to send the GameMessages. Lots more to do, but this compiles and logs in successfully. Need to move group to per message property. Need to create per session packet queue. Need to rewrite packet pipe to better process multifragment packets. Need to finish testing multifragment packets and get working. | 2017-02-18T06:02:43Z | 2017-02-18T15:08:24Z | 2017-02-18T15:08:24Z | 2017-02-18T15:08:24Z | 6255c4f2143a91eee2703a330ca5e177ac2ad5d1 | 0 | a145eafefd14a25a27aba164c5f35b5ca333be08 | 8744cb1887673d28bb7f3c6b039cd6b6453b2613 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/73 | ||||
106866864 | MDExOlB1bGxSZXF1ZXN0MTA2ODY2ODY0 | 75 | closed | 0 | Fixed update .sql file names to conform to documented standard. | Mag-nus 10608427 | 2017-02-18T16:20:28Z | 2017-02-18T16:20:49Z | 2017-02-18T16:20:49Z | 2017-02-18T16:20:49Z | 66bcd0823dee51156324dce5563487e0607b100b | 0 | e55c877ac418403e33a83da5cda9f039675c7dc5 | 6255c4f2143a91eee2703a330ca5e177ac2ad5d1 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/75 | |||||
106922129 | MDExOlB1bGxSZXF1ZXN0MTA2OTIyMTI5 | 78 | closed | 0 | Chat enums added. Say/Tell work, but names not clickable. Network Mes… …sage framework cosmetic cleanups. | Mag-nus 10608427 | 2017-02-19T23:26:00Z | 2017-02-19T23:27:05Z | 2017-02-19T23:27:04Z | 2017-02-19T23:27:04Z | a01929c6932511eb8b32dabd94e4d46256699e3b | 0 | 4145be7f2290694e2dc4e3f9d6b2e95fad6c2866 | 66bcd0823dee51156324dce5563487e0607b100b | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/78 | |||||
106892387 | MDExOlB1bGxSZXF1ZXN0MTA2ODkyMzg3 | 77 | closed | 0 | Add AccessLevel to Accounts | LtRipley36706 11369233 | This addresses issue #44 and also contains some of PR #58 rolled in. Of note, CommandManager will now respect AccessLevels specified where previously it didn't care. Set-AccountAccess will set the account's accesslevel Set-CharacterAccess will set the character's accesslevel CommandManager only cares about character's accesslevel as of this PR. Per discussion with @Mogwai-AC I think we should code up a SUDO like command which then references to Account's AccessLevel for privileges. This way we emulate how it seemed to work on AC live (per character) in addition to then allowing accounts to self-promote characters, as they did with the admin button on character creation, as well as other admin functions on non-admin characters. Probably something along the lines of "SUDO set-characteraccess [mynewcharacter] sentinel" which just does a check back to session.accesslevel. | 2017-02-19T07:51:49Z | 2017-02-20T05:30:22Z | 2017-02-20T05:09:09Z | 2017-02-20T05:09:09Z | 52cc792cc3731d07a9195a8aeea66f8b52782e08 | 0 | 3447c2c74dcfb639f2ed268fe2caa913562aa1df | a01929c6932511eb8b32dabd94e4d46256699e3b | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/77 | ||||
106869620 | MDExOlB1bGxSZXF1ZXN0MTA2ODY5NjIw | 76 | closed | 0 | Reworked Appear Offline functionality | sbaum23 22650655 | Reworked appear offline functionality so that it doesn't change IsOnline, which other things might depend on. Also fixed issue with sending friends list updates that was introduced with the network refactor merge. | 2017-02-18T17:33:27Z | 2017-02-20T05:17:46Z | 2017-02-20T05:17:46Z | 2017-02-20T05:17:46Z | e3236e4bd6138aea1f408e74761b27353dd0fb84 | 0 | 0ca1e2c8415da11198a81a380b0da0ec7fe3454a | 52cc792cc3731d07a9195a8aeea66f8b52782e08 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/76 | ||||
106941883 | MDExOlB1bGxSZXF1ZXN0MTA2OTQxODgz | 79 | closed | 0 | Fixing changes to Fragment and Session. | LtRipley36706 11369233 | 2017-02-20T05:27:58Z | 2017-02-20T05:30:11Z | 2017-02-20T05:28:12Z | 2017-02-20T05:28:12Z | 023ccf8f8f85c325c25e8c77c79ed1c8e990b382 | 0 | 87477bde65198d4455841b61dc1871a1120e834e | e3236e4bd6138aea1f408e74761b27353dd0fb84 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/79 | |||||
107108635 | MDExOlB1bGxSZXF1ZXN0MTA3MTA4NjM1 | 81 | closed | 0 | Changed Find fn's in WorldManager from InWorld to IsOnline.. fixed pl… | Mag-nus 10608427 | …ayer GUID, added GameEventDisplay events. | 2017-02-21T03:11:14Z | 2017-02-21T03:11:34Z | 2017-02-21T03:11:34Z | 2017-02-21T03:11:34Z | 68f0ef3c0bb2fed981c5e4fa4f97ea8388d7de53 | 0 | 38cfe5b504655b5739919b77c3f741048c7447c1 | 023ccf8f8f85c325c25e8c77c79ed1c8e990b382 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/81 | ||||
107122261 | MDExOlB1bGxSZXF1ZXN0MTA3MTIyMjYx | 82 | closed | 0 | Changed ParseCommand to support the use of quotes | LtRipley36706 11369233 | This change allows any command to work with quotes to better delimit some parameters. An example of this would be for commands that require the use of a character name which has spaces in it such as Maia the Lawyer. The change results in the following command working as expected: set-characteraccess "maia the laywer" admin Another example this change would fix would be the eventual problem with teleto which it gets wired-up. Without the change, the command reads like teleto maia the laywer and would try to teleport to the character named maia instead of the full name. teleto "maia the lawyer" then corrects this issue and finds the right player. | 2017-02-21T06:06:33Z | 2017-02-27T15:07:24Z | 2017-02-21T12:31:10Z | 2017-02-21T12:31:10Z | d9fcc07cd7e272c67dea8ff718d3a6e872910efb | 0 | 0c4db601a881dff3e5d84f657c258416289ae096 | 68f0ef3c0bb2fed981c5e4fa4f97ea8388d7de53 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/82 | ||||
107618205 | MDExOlB1bGxSZXF1ZXN0MTA3NjE4MjA1 | 85 | closed | 0 | Network Channels + Player Effect to Test @effect 20 | Forbiddenz 25387933 | Forgive my get newb.. I added a method of picking your channels on each message type.. Example of creating a message with channel can be found.. ``` public class GameMessageEffect : GameMessageOnChannel //using the ChannelMessages. //plays particle effect like spell casting or bleed etc.. public void PlayParticleEffect(uint effectid) { var effectevent = new GameMessageEffect(this.Guid, effectid); NetworkManager.SendWorldChannelMessages(Session, new GameMessageOnChannel[] { effectevent }); } ``` | 2017-02-23T12:51:12Z | 2017-02-23T13:41:57Z | 2017-02-23T13:41:57Z | 2017-02-23T13:41:57Z | 88aa39773126a28d788b901454f28e12d5cb68cf | 0 | af5e44e30b4e523c1c341ba9c937710719d5ca31 | d9fcc07cd7e272c67dea8ff718d3a6e872910efb | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/85 | ||||
107642912 | MDExOlB1bGxSZXF1ZXN0MTA3NjQyOTEy | 86 | closed | 0 | Group chat code added. Chat channels are currently hard coded. Chat i… | Mag-nus 10608427 | …s sent to all players, even if they aren't subscribed to a channel. Updated StatusMessageType enums. They need work still. | 2017-02-23T15:06:27Z | 2017-02-23T15:06:44Z | 2017-02-23T15:06:44Z | 2017-02-23T15:06:44Z | be6f728c328f8be17c3806d83cb2b3fe5d965fa1 | 0 | d272930b2b5f9c167dfe89569fd3ac60dc68324d | 88aa39773126a28d788b901454f28e12d5cb68cf | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/86 | ||||
107694772 | MDExOlB1bGxSZXF1ZXN0MTA3Njk0Nzcy | 87 | closed | 0 | DO NOT MERGE - for reviewing work in progress only | Mogwai-TheFurry 25351661 | work in progress, committing for others to review | 2017-02-23T19:27:26Z | 2017-02-24T02:57:35Z | 2017-02-24T02:57:35Z | 20f08d909129280d29b6cf40d8c232a734de1968 | 0 | e17e09cb0a2e12b459da7acaffada8a2fa02a5a1 | be6f728c328f8be17c3806d83cb2b3fe5d965fa1 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/87 | |||||
107945035 | MDExOlB1bGxSZXF1ZXN0MTA3OTQ1MDM1 | 88 | closed | 0 | DDD stub code, AllegianceUpdate stub, IdentifyObject stub | Mag-nus 10608427 | 2017-02-25T03:51:39Z | 2017-02-25T03:51:52Z | 2017-02-25T03:51:52Z | 2017-02-25T03:51:52Z | c78d073e7d9db6f4a15e2d8f0063ac01212b0b50 | 0 | 49576dee580cf3dc8a1cbae767f20cdc9f71cdd0 | be6f728c328f8be17c3806d83cb2b3fe5d965fa1 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/88 | |||||
107950473 | MDExOlB1bGxSZXF1ZXN0MTA3OTUwNDcz | 89 | closed | 0 | Corrected Teleloc command to work with exact numbers | LtRipley36706 11369233 | as provided by /loc command from client. | 2017-02-25T07:05:25Z | 2017-02-26T06:03:15Z | 2017-02-25T12:39:27Z | 2017-02-25T12:39:27Z | 7889b166b644281661a3ad99be129a5b318a6b0c | 0 | 3d51fa7dc1314601d7cd00ef2c98483065bc3be0 | c78d073e7d9db6f4a15e2d8f0063ac01212b0b50 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/89 | ||||
107950488 | MDExOlB1bGxSZXF1ZXN0MTA3OTUwNDg4 | 90 | closed | 0 | Rewrote network stack | Zegeger 12808515 | Rewrote network stack to support buffering messages and then dispatching as 1 or more combined or split packets. EncryptedChecksum seems to work across the board. Sending Packets with fragments from different groups does not seem to cause an issue. Packets are queued and sent based on calls from the Engine. Configurable delay (5ms currently) Reworked CachedPackets some, and now clear the list based on AckSeq packets from client. Sending AckSeq packets to the client seems to cause issues currently, need more testing. Moved some things around to fit this new model. Put message Group as a property on each message. And send this in fragment. Sounds now work again. Created new packet classes to encapsulate data in AuthenticationManager and CharacterManager and allow them to be send through the same model (though packets will never be manipulated). | 2017-02-25T07:06:09Z | 2017-02-27T11:28:37Z | 2017-02-27T11:28:37Z | 2017-02-27T11:28:37Z | 69dc8aef642f4f98682c2f99226f29d089d8624c | 0 | ed49ce86dc49ef0f97fd08d54bcedae47bbecc26 | c78d073e7d9db6f4a15e2d8f0063ac01212b0b50 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/90 | ||||
108022817 | MDExOlB1bGxSZXF1ZXN0MTA4MDIyODE3 | 93 | closed | 0 | Support easy permissions in ACEmulator | LtRipley36706 11369233 | Improved best of both worlds scenario. Server operators have the choice to emulate access permissions via more complicated system used on official worlds or they can choose to use simplified account based permissions which would become the default install option for ACEmulator. | 2017-02-26T21:25:56Z | 2017-02-27T15:04:36Z | 2017-02-27T13:51:26Z | 0d829822746b5a1e4784ee31dab23f5236bc6df3 | 0 | b978b3b010869e927675fff96d4f2932ebdb9542 | 7889b166b644281661a3ad99be129a5b318a6b0c | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/93 | |||||
108117640 | MDExOlB1bGxSZXF1ZXN0MTA4MTE3NjQw | 94 | closed | 0 | Support easy permissions in ACEmulator | LtRipley36706 11369233 | Improved best of both worlds scenario. Server operators have the choice to emulate access permissions via more complicated system used on official worlds or they can choose to use simplified account based permissions which would become the default install option for ACEmulator. | 2017-02-27T13:51:09Z | 2017-02-27T15:04:32Z | 2017-02-27T14:04:24Z | 2017-02-27T14:04:24Z | ded3c9a58125123d8e638aac0c15c285535a94e5 | 0 | 53e7b84da5e975d55b9a1ae6339c37357e4e6663 | 69dc8aef642f4f98682c2f99226f29d089d8624c | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/94 | ||||
107992120 | MDExOlB1bGxSZXF1ZXN0MTA3OTkyMTIw | 92 | closed | 0 | Add in support for the old global Admin channels | LtRipley36706 11369233 | Resurrected the various Admin global channels used by the Advocates, Sentinels, Envoys, and Admins, stubbed the @on and @off commands and added support for @index and @clist commands. Some TODOs have been put into the code for when we get a plan in place for for db loading/saving of channel subscriptions, as well as properly set subscriptions for that matter. | 2017-02-26T06:00:53Z | 2017-02-27T15:04:42Z | 2017-02-27T14:38:23Z | c133fcd9891411ed8570825f73d9b063877d3f6b | 0 | bf1cefbe1274459b1cbd1788f395b2bd51ab8170 | 7889b166b644281661a3ad99be129a5b318a6b0c | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/92 | |||||
108126542 | MDExOlB1bGxSZXF1ZXN0MTA4MTI2NTQy | 95 | closed | 0 | Add in support for the old global Admin channels | LtRipley36706 11369233 | Resurrected the various Admin global channels used by the Advocates, Sentinels, Envoys, and Admins, stubbed the @on and @off commands and added support for @index and @clist commands. Some TODOs have been put into the code for when we get a plan in place for for db loading/saving of channel subscriptions, as well as properly set subscriptions for that matter. | 2017-02-27T14:37:58Z | 2017-02-27T15:04:28Z | 2017-02-27T14:49:37Z | 2017-02-27T14:49:37Z | d32c6494668a2dac39d48f67e1772a8a8cb93dca | 0 | 90cf2a231adcc07fe3de77d223bde6be9db2dcac | ded3c9a58125123d8e638aac0c15c285535a94e5 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/95 | ||||
108263926 | MDExOlB1bGxSZXF1ZXN0MTA4MjYzOTI2 | 98 | closed | 0 | Correcting a few bugs with ChatChannel | LtRipley36706 11369233 | 2017-02-28T05:59:37Z | 2017-03-01T06:05:35Z | 2017-02-28T13:24:10Z | 2017-02-28T13:24:10Z | 990eb923e7488b898fc70babae251903cbc28c1f | 0 | e92f114685e6143ac3957b3ca9f848cf4f33bad9 | d32c6494668a2dac39d48f67e1772a8a8cb93dca | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/98 | |||||
108258291 | MDExOlB1bGxSZXF1ZXN0MTA4MjU4Mjkx | 97 | closed | 0 | Fix Account.Salt not being stored in DB | LtRipley36706 11369233 | 2017-02-28T04:51:54Z | 2017-03-01T06:05:39Z | 2017-02-28T14:46:45Z | 2017-02-28T14:46:45Z | 2e0b674c82aedabfb0cd04723a98a11d2a7fe0af | 0 | 72f098069d7484221b08041d1cae1d84086b1cda | d32c6494668a2dac39d48f67e1772a8a8cb93dca | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/97 | |||||
104715315 | MDExOlB1bGxSZXF1ZXN0MTA0NzE1MzE1 | 37 | closed | 0 | Add option to send different host address than external host address during world handoff | LtRipley36706 11369233 | The purpose of this code is to allow a server operator to configure their external IP for clients connecting from the internet as well as allowing clients connecting on the intranet to use the local network IP address of the server instead. The options are configurable via config.json and set to false by default. | 2017-02-05T21:04:40Z | 2017-03-10T04:56:11Z | 2017-03-01T05:51:04Z | 1fe95b96e105107c6b1d23f265fdf1997464ae24 | 0 | e1fda850dd64f81597cce77a2b9902d83ae0edd9 | 7b690552070222895d1de0aca5458c1cf02813e5 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/37 | |||||
108616423 | MDExOlB1bGxSZXF1ZXN0MTA4NjE2NDIz | 101 | closed | 0 | World object - Seralization with Example | Forbiddenz 25387933 | World Object with Example @spawntest. This will only work one time because ACE dont have any real way to increment guids properly. Still could use some cleanup, but this is a great start and very useful so I am PRing it now. | 2017-03-01T19:59:23Z | 2017-03-01T21:05:52Z | 2017-03-01T21:05:52Z | f56f81c9caef2a8f3b89f2da7260f77403ec93a5 | 0 | f8791e97784c689f6555f6e587462dab5bad8da1 | 2e0b674c82aedabfb0cd04723a98a11d2a7fe0af | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/101 | |||||
108463810 | MDExOlB1bGxSZXF1ZXN0MTA4NDYzODEw | 99 | closed | 0 | Character options are saving/loading from database. | sbaum23 22650655 | Resolves issue #80 | 2017-03-01T04:04:17Z | 2017-03-02T12:51:03Z | 2017-03-02T12:51:03Z | 2017-03-02T12:51:03Z | bde99ece02c9b0c6116aff4013a98a9d50fb3dc4 | 0 | 06de170aee121d9d949c21832accedc6c6f7b404 | 2e0b674c82aedabfb0cd04723a98a11d2a7fe0af | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/99 | ||||
108472067 | MDExOlB1bGxSZXF1ZXN0MTA4NDcyMDY3 | 100 | closed | 0 | Option to send Internal IP as World Host to client | LtRipley36706 11369233 | Allows a server operator to configure their external IP for clients connecting from the internet as well as allowing clients connecting on the intranet to use the local network IP address of the server remaining on local network instead of going out to come back in. The options are configurable via config.json and set to false by default. | 2017-03-01T05:50:28Z | 2017-03-06T06:38:50Z | 2017-03-02T12:51:47Z | 2017-03-02T12:51:47Z | 90b1967df4900475e6d686c36fac7654d0e740a7 | 0 | 59966588ee285749aac89e771adc68e9bdaa3c69 | 2e0b674c82aedabfb0cd04723a98a11d2a7fe0af | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/100 | ||||
108653372 | MDExOlB1bGxSZXF1ZXN0MTA4NjUzMzcy | 102 | closed | 0 | World object - Improvement + Lifestone Test Object | Forbiddenz 25387933 | Use @spawntest to spawn a life stone. | 2017-03-01T23:28:15Z | 2017-03-02T22:47:00Z | 2017-03-02T12:55:01Z | 2017-03-02T12:55:01Z | 856a8a192efdd020fb4983d3217f06d9dc2bb4ac | 0 | b60fa81ea4dd15d7eb0df4715fe7e9e083f267b4 | 90b1967df4900475e6d686c36fac7654d0e740a7 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/102 | ||||
107336448 | MDExOlB1bGxSZXF1ZXN0MTA3MzM2NDQ4 | 84 | closed | 0 | Skill spend upper bound check too prevent xp crash, also Max Skills! | fantoms 37453 | Added an Ability and Skill check in Source/ACE/Entity/Player.cs, too attempt in preventing server from crashing when spending XP points. | 2017-02-22T05:09:25Z | 2017-03-02T13:03:44Z | 2017-03-02T13:03:43Z | e77b4c04406237ec6e9d5c533160503bc2b9b60f | 0 | e9ce87ad8fb1dc1000f63b8618221b7f425762ae | d9fcc07cd7e272c67dea8ff718d3a6e872910efb | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/84 | |||||
108831238 | MDExOlB1bGxSZXF1ZXN0MTA4ODMxMjM4 | 103 | closed | 0 | Quick fixes 03022017 | LtRipley36706 11369233 | 2017-03-02T19:21:20Z | 2017-03-02T20:08:23Z | 2017-03-02T20:08:23Z | 2017-03-02T20:08:23Z | 033c6ca23ac00c9a1e0949ed7baf2c092e626a12 | 0 | 71e6469b853043b8f03202d329d3792eb4d984c3 | 856a8a192efdd020fb4983d3217f06d9dc2bb4ac | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/103 | |||||
108883111 | MDExOlB1bGxSZXF1ZXN0MTA4ODgzMTEx | 105 | closed | 0 | More WorldObject Fixes | LtRipley36706 11369233 | 2017-03-03T00:32:57Z | 2017-03-04T10:27:26Z | 2017-03-03T14:05:09Z | 2017-03-03T14:05:09Z | 7ce98a9f557f3a7ac0fe10e77891c57a72067a01 | 0 | 15306e9d0414bafc9c4b1b2ae3621d3584054c39 | 033c6ca23ac00c9a1e0949ed7baf2c092e626a12 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/105 | |||||
108840458 | MDExOlB1bGxSZXF1ZXN0MTA4ODQwNDU4 | 104 | closed | 0 | portal.dat and cell.dat loading (issue #3) | Mogwai-TheFurry 25351661 | 2017-03-02T20:09:02Z | 2017-05-30T15:34:36Z | 2017-03-04T12:59:37Z | 2017-03-04T12:59:37Z | c4793ec44fdbcbdfb15db3aa38d071c512375d3b | 0 | da3dca42a73e68e204bbc908c984aba9398909e4 | 7ce98a9f557f3a7ac0fe10e77891c57a72067a01 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/104 | |||||
109111509 | MDExOlB1bGxSZXF1ZXN0MTA5MTExNTA5 | 106 | closed | 0 | Continuing SO's WorldObject rework | Mogwai-TheFurry 25351661 | 2017-03-04T15:39:17Z | 2017-05-30T15:34:35Z | 2017-03-06T12:33:26Z | 2017-03-06T12:33:26Z | f3f26a22dff18a649afc727c6d66e5acacd1d494 | 0 | 02d91aa2e90dbd530ac8151071b6466498013689 | c4793ec44fdbcbdfb15db3aa38d071c512375d3b | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/106 | |||||
109324275 | MDExOlB1bGxSZXF1ZXN0MTA5MzI0Mjc1 | 109 | closed | 0 | World Object Fix | Forbiddenz 25387933 | 2017-03-06T18:55:41Z | 2017-03-06T22:38:36Z | 2017-03-06T22:38:36Z | ac4848e6f4db25a59c5588ac068882a06bf50259 | 0 | 331d37a061a4270da1c09f356cf82849f1c98bb4 | f3f26a22dff18a649afc727c6d66e5acacd1d494 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/109 | ||||||
109342066 | MDExOlB1bGxSZXF1ZXN0MTA5MzQyMDY2 | 110 | closed | 0 | A fix to Prevent Skill Spend server crash and allow for max Ranked Skills (Infinity!) | fantoms 37453 | - Renamed abilityUpdate to skillUpdate, to reflect the correct function/variables. - Refactored the SpendXp skills function to send a gamemessage on failed skill updates that prevents client from locking up the Rank Up interface buttons. - Added an upper-bounds check to prevent skills from going out of bounds. - Created an offset variable to prevent +10 from going out of bounds when the rank is to high. - Changed the comment describing known issues on skillSpend | 2017-03-06T20:30:18Z | 2017-03-07T01:29:18Z | 2017-03-07T01:29:18Z | 2017-03-07T01:29:18Z | 2b59fc2d57dea3933a4467eda9b3dd03b1407cf0 | 0 | 352ce9c3143800214e5cb6ceed79ae53b237fad3 | f3f26a22dff18a649afc727c6d66e5acacd1d494 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/110 | ||||
109192396 | MDExOlB1bGxSZXF1ZXN0MTA5MTkyMzk2 | 108 | closed | 0 | Time returns to Dereth | LtRipley36706 11369233 | Rain rain go away... Added time to Dereth. Once the server starts, the clock is set and is hardcoded at this point to start at the current Lore corrected DerethDateTime. @time command wired up. Time progresses as it did on retail and does not reset in between sessions as long as server remains running. There are several functions within DerethDateTime that could help enable some interesting ideas in the future such as "dynamic seasons" and changing spawns based on TimeOfDay (like Graveyard) for examples. It would depend on if we're able to build in time-checking logic to spawnable/generator objects, which I assume we would be doing, especially once we get around to rebuilding the GY area. TODO: Save the progression of ServerTime periodically to be recalled when server is offline'd/online'd. TODO: Setup a variable in Config.json and ConfigManager to allow the server operator to pick a date to start the server from. | 2017-03-06T05:28:29Z | 2017-03-10T04:55:10Z | 2017-03-07T01:29:35Z | 2017-03-07T01:29:34Z | de9636f9e7211b60ecf0ac0654268039ff1c8383 | 0 | 3010f28575580b47581943c98fe5d5efac7e98e9 | c4793ec44fdbcbdfb15db3aa38d071c512375d3b | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/108 | ||||
109174375 | MDExOlB1bGxSZXF1ZXN0MTA5MTc0Mzc1 | 107 | closed | 0 | Add DAT loading into main process | ghost 10137 | Obtains the two DAT file locations from the config.json file. Code also handles file not found exceptions and prints out an error. | 2017-03-06T00:43:14Z | 2017-10-18T14:07:36Z | 2017-03-07T01:30:51Z | 2017-03-07T01:30:51Z | c7653a3c812479a9e053105c82df0c7792b86e72 | 0 | 5b9ec8db5042f64407e260a6483dde57ef1a4443 | c4793ec44fdbcbdfb15db3aa38d071c512375d3b | NONE | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/107 | ||||
109367076 | MDExOlB1bGxSZXF1ZXN0MTA5MzY3MDc2 | 111 | closed | 0 | Life stone Fix = World Object Fix Usable | Forbiddenz 25387933 | Adding proper flags to World Object Usable. | 2017-03-06T22:47:12Z | 2017-03-07T09:40:25Z | 2017-03-07T01:31:04Z | 2017-03-07T01:31:04Z | 4113108b99df8b49ed819b78bcfbcff469bf810d | 0 | c48f8645e8e789cfa066b1e84332b5dfe104c3f0 | f3f26a22dff18a649afc727c6d66e5acacd1d494 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/111 | ||||
109402490 | MDExOlB1bGxSZXF1ZXN0MTA5NDAyNDkw | 112 | closed | 0 | Save default character options when creating a character. | sbaum23 22650655 | When creating a character this will set several character options to true and save to the database. The options set to true are the same ones when you click the "Default" button in the options tab. | 2017-03-07T04:00:31Z | 2017-03-07T13:14:03Z | 2017-03-07T13:14:03Z | 2017-03-07T13:14:03Z | 93b5d5b4c0494c6008833d6fabf96b7d43c5228e | 0 | cea950f9db3847a64f71bc6613371230b6504878 | 4113108b99df8b49ed819b78bcfbcff469bf810d | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/112 | ||||
109408343 | MDExOlB1bGxSZXF1ZXN0MTA5NDA4MzQz | 113 | closed | 0 | Max Rank Fireworks and Correct Skill Rank Up text Color | fantoms 37453 | - I could not find a way to check the skill rank after it was set, so I added a function to check max rank. If the function returns a Boolean true, then the server will play fireworks when reached max rank - Changed the message type to Advancement when increasing skills too reflect the correct skill advancement chat color. - Added a few summary comments and fixed remarks/known issues. | 2017-03-07T05:17:04Z | 2017-05-23T15:53:42Z | 2017-03-07T13:45:27Z | 2017-03-07T13:45:27Z | 555c39fb937d85f8317a21730a693ea8e57115a8 | 0 | 99077ee9b008312f8e7ff33ccb05f1fe5346d98d | 4113108b99df8b49ed819b78bcfbcff469bf810d | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/113 | ||||
109819570 | MDExOlB1bGxSZXF1ZXN0MTA5ODE5NTcw | 115 | closed | 0 | Add host & port to connect messages | Zorgle 26289176 | 2017-03-09T01:04:31Z | 2017-03-09T01:26:45Z | 2017-03-09T01:26:45Z | 2017-03-09T01:26:45Z | 0850963d9efadbccd0de6f9dd990f61c5076b854 | 0 | bc0a5f343e22295662067adf2039d8f6322ac4bc | 555c39fb937d85f8317a21730a693ea8e57115a8 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/115 | |||||
105771805 | MDExOlB1bGxSZXF1ZXN0MTA1NzcxODA1 | 58 | closed | 0 | Added support on ACE console for setting per character admin rights and character renaming | LtRipley36706 11369233 | Also included in this PR is a fix for the propertybools (IsAdmin, etc) not always being set from database when a character logs in. | 2017-02-11T23:19:23Z | 2017-03-10T04:56:08Z | 2017-03-09T07:44:47Z | 561d4e6469bf3d3f523c8d3c5fbda6625f0417c4 | 0 | 659a5ebafdbdf3d70098a30b91df69fc358c8108 | 412806f7b20e82f5129e47b6009b028d766e7065 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/58 | |||||
109856539 | MDExOlB1bGxSZXF1ZXN0MTA5ODU2NTM5 | 116 | closed | 0 | Character Rename command added | LtRipley36706 11369233 | Works via console and client. | 2017-03-09T07:43:33Z | 2017-03-10T04:54:58Z | 2017-03-09T13:34:36Z | 2017-03-09T13:34:36Z | 1b50e79491689978e981f30f386e999129a61fa0 | 0 | 08fe3303623b35f5476ed864580ee9d12e1c3b68 | 0850963d9efadbccd0de6f9dd990f61c5076b854 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/116 | ||||
110325636 | MDExOlB1bGxSZXF1ZXN0MTEwMzI1NjM2 | 120 | closed | 0 | Logoff works. | Mag-nus 10608427 | Save character position implemented. Character position is not updated in-game yet. | 2017-03-13T01:22:21Z | 2017-03-13T01:22:32Z | 2017-03-13T01:22:32Z | 2017-03-13T01:22:32Z | d1c9f1182daaa71e4447b17056c296a695e0eeea | 0 | de6ba9b67c5335bc178306cac6615e2169d3c6fe | 1b50e79491689978e981f30f386e999129a61fa0 | MEMBER | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/120 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [pull_requests] ( [id] INTEGER PRIMARY KEY, [node_id] TEXT, [number] INTEGER, [state] TEXT, [locked] INTEGER, [title] TEXT, [user] INTEGER REFERENCES [users]([id]), [body] TEXT, [created_at] TEXT, [updated_at] TEXT, [closed_at] TEXT, [merged_at] TEXT, [merge_commit_sha] TEXT, [assignee] INTEGER REFERENCES [users]([id]), [milestone] INTEGER REFERENCES [milestones]([id]), [draft] INTEGER, [head] TEXT, [base] TEXT, [author_association] TEXT, [auto_merge] TEXT, [repo] INTEGER REFERENCES [repos]([id]), [url] TEXT, [merged_by] INTEGER REFERENCES [users]([id]) ); CREATE INDEX [idx_pull_requests_merged_by] ON [pull_requests] ([merged_by]); CREATE INDEX [idx_pull_requests_repo] ON [pull_requests] ([repo]); CREATE INDEX [idx_pull_requests_milestone] ON [pull_requests] ([milestone]); CREATE INDEX [idx_pull_requests_assignee] ON [pull_requests] ([assignee]); CREATE INDEX [idx_pull_requests_user] ON [pull_requests] ([user]);