pull_requests: 106456643
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
106456643 | MDExOlB1bGxSZXF1ZXN0MTA2NDU2NjQz | 66 | closed | 0 | Fixing up Character Delete and Restore functions | 11369233 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, character is marked deleted in database an hour after deleted from client via a server side SQL script running from event_scheduler. Later revisions to this code could address configuration variable(s) possibly in config.json.example for how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client, enable/disable this event check etc.. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | 2017-02-16T05:16:36Z | 2017-02-17T06:49:36Z | 2017-02-17T01:38:08Z | 2017-02-17T01:38:08Z | 64a76b56abf1712aceb85788c5d2093187d0f922 | 0 | b6a3741cddfe480d998abc783330e293aba853e9 | 877f3bf26dced9e6f54d937af8cd4b614aa35ef3 | MEMBER | 79078680 | https://github.com/ACEmulator/ACE/pull/66 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests