pull_requests: 386978488
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
386978488 | MDExOlB1bGxSZXF1ZXN0Mzg2OTc4NDg4 | 2809 | open | 0 | [TEST] network relogin | 8909245 | Repro steps: - In your Config.js, set DefaultSessionTimeout to 999 for easier testing - In your log4net.config, set the Console threshold to DEBUG for easier testing - Connect to your local server in ThwargLauncher advanced mode. Make sure your server name in ThwargLauncher does NOT match up with your local server name, so that if ThwargLauncher is left open, it automatically disconnects you in ~30s - Log into the game world - Wait for ThwargLauncher to automatically close the AC window - Try to reconnect Expected: - Existing character is booted out of the game world Actual: - Existing character is never booted out of the game world. New session cannot connect. There are some odd issues with this PR, namely if you try this multiple times, the existing Player state will get into an odd loop, where the Session is disconnected, but the Player is still saving on the landblock or something.. This can be seen after multiple retries, or using /pktimer sometimes helps. The previous session will go into 'SessionTerminating' state, and then be dropped, while the previous player still seems to be in the world. This allows the new session to connect to the char select screen, but then gets into an automatic loop when trying to log into the world, until the existing player is finally logged out. Could use @fartwhif 's help on this one | 2020-03-12T00:15:23Z | 2020-09-05T07:04:39Z | 4ac49b9e6cbb3331f58ce7af9bb416209ab60794 | 0 | d25ab818f8cdb779c2c7e34674bad615ce52d416 | 0c25ae21cb76f77c1dfb56f4077bd339969589ba | COLLABORATOR | 79078680 | https://github.com/ACEmulator/ACE/pull/2809 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests