issues
Data license: AGPL · Data source: ACEmulator Project
4,138 rows sorted by reactions
This data as json, CSV (advanced)
Suggested facets: state, assignee, comments, author_association, draft, state_reason, type, created_at (date), updated_at (date), closed_at (date)
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions ▼ | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
202877062 | MDExOlB1bGxSZXF1ZXN0MTAyOTU5MDg1 | 1 | Updates to database and underlying code | xanxin887 6705011 | closed | 0 | 0 | 2017-01-24T16:55:13Z | 2017-01-24T18:24:10Z | 2017-01-24T18:24:10Z | NONE | 0 | ACEmulator/ACE/pulls/1 | Updates to database and underlying code | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
204670023 | MDExOlB1bGxSZXF1ZXN0MTA0MTk2NjM1 | 10 | Client and Server expects account in ace_auth to be lowercase only. | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-01T18:45:44Z | 2017-02-02T16:36:57Z | 2017-02-02T16:36:53Z | MEMBER | 0 | ACEmulator/ACE/pulls/10 | This is my first pull request, please let me know if I'm doing this incorrectly. Simple change I made to the accountcreate command to correct and prevent the issue I experienced when setting up ACE. The client always sends accounts as lowercase regardless of what the user types in the command line. The server itself resolves the difference and connects as well. The issue surfaces when attempting to create a character. That packet is sent, but no response is ever recv'd. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/10/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
210986292 | MDExOlB1bGxSZXF1ZXN0MTA4NDcyMDY3 | 100 | Option to send Internal IP as World Host to client | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-01T05:50:28Z | 2017-03-06T06:38:50Z | 2017-03-02T12:51:47Z | MEMBER | 0 | ACEmulator/ACE/pulls/100 | Allows a server operator to configure their external IP for clients connecting from the internet as well as allowing clients connecting on the intranet to use the local network IP address of the server remaining on local network instead of going out to come back in. The options are configurable via config.json and set to false by default. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/100/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
356692682 | MDExOlB1bGxSZXF1ZXN0MjEyODg1MzQ5 | 1000 | Fix serialization of the critical hit field. | Slushnas 19214857 | closed | 0 | 0 | 2018-09-04T07:53:44Z | 2018-09-04T14:04:22Z | 2018-09-04T14:04:22Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1000 | This fixes the serialization of the AttackerNotification message. Critical hit messages will now be displayed properly in the client. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1000/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
357116064 | MDExOlB1bGxSZXF1ZXN0MjEzMjA2NDk4 | 1001 | Adding weapon speed mod | gmriggs 8909245 | closed | 0 | 0 | 2018-09-05T08:19:10Z | 2020-09-25T06:52:09Z | 2018-09-06T15:26:07Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1001 | This patch adjusts the attack animation speed for Players and monsters to match the quickness / weapon speed / enchantments for melee weapons - Fixed a bug with indoor scatter generators not getting the new cell - Fixed an issue with invisible objects broadcasting to players | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1001/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
357320250 | MDExOlB1bGxSZXF1ZXN0MjEzMzY0NjE2 | 1002 | Adding player housing network packet structure | gmriggs 8909245 | closed | 0 | 0 | 2018-09-05T17:02:10Z | 2018-09-06T15:26:27Z | 2018-09-06T15:26:27Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1002 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1002/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
358206938 | MDExOlB1bGxSZXF1ZXN0MjE0MDM2MDk3 | 1003 | Adding the ability for players to buy houses | gmriggs 8909245 | closed | 0 | 1 | 2018-09-07T20:49:12Z | 2018-09-09T16:11:26Z | 2018-09-09T16:11:26Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1003 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1003/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
358361586 | MDExOlB1bGxSZXF1ZXN0MjE0MTM1MTU3 | 1004 | Trade cleanup | mcreedjr 25518589 | closed | 0 | 0 | 2018-09-09T08:49:26Z | 2018-09-11T16:06:42Z | 2018-09-09T08:49:32Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1004 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1004/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
358362004 | MDExOlB1bGxSZXF1ZXN0MjE0MTM1NDI5 | 1005 | Secure trade pass 2 | mcreedjr 25518589 | closed | 0 | 1 | 2018-09-09T08:57:17Z | 2018-09-09T17:46:56Z | 2018-09-09T17:46:56Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1005 | Polishing up secure trade from my last PR. Sorry for the messy commit history. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1005/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
358397146 | MDExOlB1bGxSZXF1ZXN0MjE0MTU2NDY0 | 1006 | Revised pass at secure trade | mcreedjr 25518589 | closed | 0 | 0 | 2018-09-09T17:51:18Z | 2018-09-11T16:06:41Z | 2018-09-10T20:36:53Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1006 | This is an update to my previous PR where basic secure trade functionality was implemented. This PR does the following: - Verifies that trade partner is in range - Honors ignore all trade requests character option - Does not initiate when either party is in combat mode - Adds a few messages based on what I saw in retail PCAPs - Implemented GameEventDeclineTrade per PCAPs - Implements turn to when approaching trade partner Probably a few other minor tweaks. Again, sorry for all of the open and closing PR noise. Git and I are often not friends. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1006/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
358419154 | MDExOlB1bGxSZXF1ZXN0MjE0MTY4NjE3 | 1007 | Implement a basic House Portal class | ghost 10137 | closed | 0 | 0 | 2018-09-09T22:29:04Z | 2018-09-10T23:03:44Z | 2018-09-09T22:50:03Z | NONE | 0 | ACEmulator/ACE/pulls/1007 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1007/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
358459781 | MDExOlB1bGxSZXF1ZXN0MjE0MTkyNDMy | 1008 | Added random Scroll functionality | dgatewood 10187880 | closed | 0 | 0 | 2018-09-10T03:57:30Z | 2018-11-24T06:25:40Z | 2018-11-24T06:25:40Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1008 | This is not all the scrolls that can be found from loot, but it is roughly half of them. I will add the rest very soon, or they could be added from a new contributor looking to get their feet wet. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1008/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
358493996 | MDExOlB1bGxSZXF1ZXN0MjE0MjE2NjY3 | 1009 | Portal Updates, plus fix IsWithinUseRadiusOf() | ghost 10137 | closed | 0 | 0 | 2018-09-10T07:07:24Z | 2018-09-10T23:03:42Z | 2018-09-10T20:36:35Z | NONE | 0 | ACEmulator/ACE/pulls/1009 | Seems to fix the MoveTo when using a Portal | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1009/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211191210 | MDExOlB1bGxSZXF1ZXN0MTA4NjE2NDIz | 101 | World object - Seralization with Example | Forbiddenz 25387933 | closed | 0 | 0 | 2017-03-01T19:59:23Z | 2017-03-01T21:05:52Z | 2017-03-01T21:05:52Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/101 | World Object with Example @spawntest. This will only work one time because ACE dont have any real way to increment guids properly. Still could use some cleanup, but this is a great start and very useful so I am PRing it now. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
358663130 | MDExOlB1bGxSZXF1ZXN0MjE0MzQ0Njg0 | 1010 | WorldObject Position Updates | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-10T14:59:24Z | 2018-09-11T00:49:24Z | 2018-09-11T00:49:00Z | MEMBER | 0 | ACEmulator/ACE/pulls/1010 | WorldObject.Positions was misused. The code has been cleaned up so that Position access passes through the Get/Set/Remove functions. Furthermore, on save, we make sure that the positions in the biota have the latest up to date values from the cache. We must do this because we don't wrap Positions like we do attributes/skills/vitals. Also added a very important note regarding use of SetPosition: /// !!! VERY IMPORTANT NOTE REGARDING SetPosition !!!<para /> /// Position objects are reference types. Lets say you want to create a new object and give it the location of a player, /// If you do LandscapeItem.SetPosition(PositionType.Location, Player.Location), you've now set the Location position /// for both the player and the LandscapeItem to the same exact object. Modifying one will affect the other.<para /> /// The proper way to would be: LandscapeItem.SetPosition(PositionType.Location, (Position)Player.Location.Clone())<para /> /// Any time you want to set a position of a different PositionType, or, positions between WorldObjects, you should use the above Clone method. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1010/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
358696319 | MDExOlB1bGxSZXF1ZXN0MjE0MzcwMjM4 | 1011 | Fix the picking up of open and in use packs | mcreedjr 25518589 | closed | 0 | 0 | 2018-09-10T16:19:52Z | 2018-09-11T16:06:14Z | 2018-09-11T12:19:54Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1011 | This PR should address both concerns raised by @OptimShi as noted in issue #866. The messages returned when a user attempts to place pack being viewed by another user were what I remembered of retail. I couldn't find anything in PCAPs to support what I remembered. I'm open to suggestions if those messages should be something else. I'd be happy to update with the consensus. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1011/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
358825100 | MDExOlB1bGxSZXF1ZXN0MjE0NDY3NzA3 | 1012 | Player housing - adding the ability to place and save items on floor/wall/ceiling hooks | gmriggs 8909245 | closed | 0 | 0 | 2018-09-10T22:59:19Z | 2018-09-13T22:00:16Z | 2018-09-13T22:00:16Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1012 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1012/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
358859176 | MDExOlB1bGxSZXF1ZXN0MjE0NDkyNDk2 | 1013 | Ephemeral Property Dictionaries should be private and readonly | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-11T02:08:34Z | 2018-09-11T02:11:22Z | 2018-09-11T02:11:05Z | MEMBER | 0 | ACEmulator/ACE/pulls/1013 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1013/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
359345267 | MDExOlB1bGxSZXF1ZXN0MjE0ODU3Njcy | 1014 | Adding proficiency points, and skills increasing through usage | gmriggs 8909245 | closed | 0 | 0 | 2018-09-12T07:15:07Z | 2018-09-17T05:57:53Z | 2018-09-17T05:57:53Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1014 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1014/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
359855662 | MDExOlB1bGxSZXF1ZXN0MjE1MjUxMDE2 | 1015 | Fixed bug where excess WeenieError.TradeCancelled was sent | mcreedjr 25518589 | closed | 0 | 0 | 2018-09-13T11:31:15Z | 2018-09-13T13:59:22Z | 2018-09-13T13:57:19Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1015 | Fixed a bug @gmriggs found where where an erroneous WeenieError.TradeCancelled was sent to client when a character entered combat mode, whether or not the character was trading. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1015/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
359925472 | MDExOlB1bGxSZXF1ZXN0MjE1MzA1ODEz | 1016 | Usage of DateTime/PhysicsTimer cleaned up across the board | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-13T14:37:46Z | 2018-09-15T20:26:55Z | 2018-09-15T20:26:11Z | MEMBER | 0 | ACEmulator/ACE/pulls/1016 | We use a StopWatch in 2 places for guaranteed < 1ms precision: ACE.Server.Managers.WorldManager.PortalYearTicks - This is tied directly to our UpdateWorld loop. - It can be used for precise timing outside of the physics framework ACE.Server.Physics.Common.PhysicsTimer - This should be used only for physics and physics related work - This helps isolate the physics code from ACE.Server and WorldManager Many places that were using the existing Stopwatch based timers have been migrated to DateTime.UtcNow. - Non-physics related work done in isolation should use DateTime - Time.GetUnixTime() is used when we want to save the timestamp to the database Fixed a performance issue with how WorldObject.Tick was checking for HeartBeatInterval and HeartBeatTimestamp Added external system calls for windows to help improve the accuracy of Thread.Sleep. - On my windows 10 dev box, on the host OS, running in VS 2017, Thread.Sleep provided 1ms resolution by default - On my Windows Server 2016 virtualized box, Thread.Sleep provided 15.6ms resolution by default. This fix brings it down to 1ms. - This is important for UpdateWorld performance where we Thread.Sleep(1) every loop. UpdateWorld will now sleep for longer when no sessions are connected. Shutdown command was using 100% CPU. This has been fixed with a Thread.Sleep(1) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1016/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
360503793 | MDExOlB1bGxSZXF1ZXN0MjE1NzQ3NTg4 | 1017 | Skill redistribution functionality | mcreedjr 25518589 | closed | 0 | 2 | 2018-09-15T03:42:28Z | 2018-09-21T13:31:33Z | 2018-09-21T04:24:52Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1017 | This PR implements basic skill redistribution functionality as required by the Skill Redistribution Quest (http://asheron.wikia.com/wiki/Attribute_and_Skill_Redistribution) The dungeon works based on previous Emote work accomplished by others. It appears that our database does not spawn the "Wardens" as described in the quest outline above. In order to test the functionality you will have to spawn the appropriate Enlightenment/Forgetfulness gems through the /ci developer command. Here is a listing of the Weenie IDs for those gems (https://github.com/ACEmulator/ACE-World-16PY/tree/master/Database/3-Core/9%20WeenieDefaults/SQL/SkillAlterationDevice/GEM) This PR should take into account most or all of the following scenarios: - Advancing a trained skill to a specialized skill - Demoting a specialized skill to a trained skill with both skill credit and invested XP refunds - Demoting a trained skill to an untrained skill with both skill credit and invested XP refunds - Prevents specializing a skill if doing so would exceed the 70+ credit specialization limit in retail - Prevents demoting a skill if an equipped item used the skill to be demoted This PR does not: - Account for quest limits imposed by this quest in retail (should honestly be part of the emote functionality anyways) - Does not spawn the missing "Wardens" in the Inner Sanctum dungeon(s) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1017/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
360530617 | MDExOlB1bGxSZXF1ZXN0MjE1NzY0MDU1 | 1018 | Adding TreasureWielded randomized armor/clothing for mobs | gmriggs 8909245 | closed | 0 | 0 | 2018-09-15T11:08:46Z | 2018-09-17T05:57:15Z | 2018-09-17T05:57:15Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1018 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1018/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
360583947 | MDExOlB1bGxSZXF1ZXN0MjE1NzkzODg4 | 1019 | Don't throw warnings on CICMDCommand packets | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-15T23:12:06Z | 2018-09-16T12:23:37Z | 2018-09-16T12:22:26Z | MEMBER | 0 | ACEmulator/ACE/pulls/1019 | CICMDCommand packets always have a Header.Id of 0. We cannot use the Header.Id as a session index to process these packets. We need to process them separately. They represent some sort of command. You can see these in AC Log View. Open a pcap as fragments and search for an ICmd header. They will be all by themselves. I have yet to see them actually contain a payload. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1019/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211242008 | MDExOlB1bGxSZXF1ZXN0MTA4NjUzMzcy | 102 | World object - Improvement + Lifestone Test Object | Forbiddenz 25387933 | closed | 0 | 0 | 2017-03-01T23:28:15Z | 2017-03-02T22:47:00Z | 2017-03-02T12:55:01Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/102 | Use @spawntest to spawn a life stone. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
360588776 | MDExOlB1bGxSZXF1ZXN0MjE1Nzk2MzEx | 1020 | Adding Recklessness combat skill | gmriggs 8909245 | closed | 0 | 0 | 2018-09-16T00:35:32Z | 2018-09-19T03:42:01Z | 2018-09-19T03:42:01Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1020 | - Added Ratings formulas - Fixed a bug where player couldn't appraise items equipped by players or creatures | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1020/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
360591625 | MDExOlB1bGxSZXF1ZXN0MjE1Nzk3NzI4 | 1021 | Session connecting log level improvements | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-16T01:32:27Z | 2018-09-16T12:23:25Z | 2018-09-16T12:21:58Z | MEMBER | 0 | ACEmulator/ACE/pulls/1021 | The info log level shouldn't be too verbose. Info sould just have 1 record for a connect and disconnect. The other debugging messages have been moved to the Debug log level. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1021/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
360659801 | MDExOlB1bGxSZXF1ZXN0MjE1ODM0ODk2 | 1022 | Fix connection failures on initial account auto create session. | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-16T17:24:39Z | 2018-09-16T23:26:02Z | 2018-09-16T23:25:39Z | MEMBER | 0 | ACEmulator/ACE/pulls/1022 | Because AuthenticationHandler was passing the connection session to AccountCommand to do the account creation, AccountCommand would then try to send a status message to the session. This would corrupt the clients session because the client wasn't ready to accept such messages. The simple fix would have been to change this: AccountCommands.HandleAccountCreate(session, parameters); to this: AccountCommands.HandleAccountCreate(null, parameters); However, I don't like that a very vital piece of code, AuthenticationHandler was using a client input parser to do the actual work, AccountCommand. Now, AuthenticationHandler does the work that it needs locally. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1022/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
360690512 | MDExOlB1bGxSZXF1ZXN0MjE1ODUyMzIw | 1023 | Adding Sneak Attack skill for player combat | gmriggs 8909245 | closed | 0 | 0 | 2018-09-16T23:40:47Z | 2018-09-20T08:31:53Z | 2018-09-20T08:31:53Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1023 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1023/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
360731846 | MDExOlB1bGxSZXF1ZXN0MjE1ODc5NjY0 | 1024 | Fixing appveyor build | gmriggs 8909245 | closed | 0 | 0 | 2018-09-17T06:02:38Z | 2018-09-17T11:04:44Z | 2018-09-17T11:04:44Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1024 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1024/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
361139578 | MDExOlB1bGxSZXF1ZXN0MjE2MTg1Nzcx | 1025 | Adding Dirty Fighting skill to combat | gmriggs 8909245 | closed | 0 | 0 | 2018-09-18T05:20:15Z | 2018-09-21T04:25:10Z | 2018-09-21T04:25:10Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1025 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1025/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
362976710 | MDExOlB1bGxSZXF1ZXN0MjE3NTMwNzY0 | 1026 | Update SQL Scripts | LtRipley36706 11369233 | closed | 0 | 1 | 2018-09-23T20:56:44Z | 2019-01-05T23:23:02Z | 2018-09-29T04:28:56Z | MEMBER | 0 | ACEmulator/ACE/pulls/1026 | Rebased and updated for MySQL 8.0 Should be backwards compatible as well. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1026/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
362978190 | MDExOlB1bGxSZXF1ZXN0MjE3NTMxNzc2 | 1027 | CommandHandlerHelper (Yum!) Added | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-23T21:17:15Z | 2018-09-24T12:05:19Z | 2018-09-24T12:04:58Z | MEMBER | 0 | ACEmulator/ACE/pulls/1027 | There were a ton of commands that worked both on the console, and from a player session. These commands had conditions like the following to determine if the output should be sent to the console or to the sesion: if (session != null) sendToSession() else SendToConsole() CommandHandlerHelper cleans up this. In addition, there were places in the code that were doing Console.WriteLine that should have been using the logger instead. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1027/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
363088054 | MDExOlB1bGxSZXF1ZXN0MjE3NjExMjAz | 1028 | Adding Void magic | gmriggs 8909245 | closed | 0 | 0 | 2018-09-24T10:25:35Z | 2018-09-28T07:55:33Z | 2018-09-28T07:55:33Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1028 | - Adding complete Void Magic system w/ all spells - Major refactoring to game code that uses SpellBase and Spell: - a new Spell class has been added for gameplay code, wrapping SpellBase and the database Spell class. All game code that deals with Spells is much easier to write, with significantly less to manage - Added both server and client formulas for determining spell levels - Added proper spellcasting wind-up animations based on spell formula scarabs - Improved the spellcasting wind-up animations to use the exact animation timings - Improved the damage over time system - Added Damage Rating and Damage Resistance Rating to all damage formulas (physical and magic combat) - Fixed a bug where projectiles wouldn't trigger environment collisions for some objects Note: this patch requires the DB to be updated with Spells and Weenies from https://github.com/ACEmulator/ACE-World-16PY-Patches/pull/4 Thanks to everyone on the ACE development team, and in the Discord development channel for helping with this patch! | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1028/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
364788336 | MDExOlB1bGxSZXF1ZXN0MjE4ODg5MTQw | 1029 | Improved monster timing / server animation sync | gmriggs 8909245 | closed | 0 | 0 | 2018-09-28T08:21:40Z | 2018-09-30T16:44:13Z | 2018-09-30T16:44:13Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1029 | - Added direct visibility / line-of-sight test - Added ExecuteMotion, which plays the animation on both the client and server. - EmoteManager - EmoteType.Motion now goes through ExecuteMotion, so animations like monsters going to sleep (skeletons/golems) will now be simulated properly on the server. This fixes the bug where monsters would start moving while they were still transitioning from sleep->wakeup - Added more robust logic for animation timing while switching combat stances, for both players and creatures - Added randomized stack size variances to mob projectiles, based on WieldedTreasure tables - Improved timing for all monster animation transitions (combat stance, missile launches, spellcasting) - Added randomized variance to monster melee attack delay (0.5-2s) - Fixed a bug where monsters selected combat maneuvers that didn't exist in their motion table - Fixed a bug where monsters would sometimes walk instead of run, when re-chasing targets - Fixed a bug where CreateObject network messages would be re-sent when monsters swapped inventory items | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1029/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211490314 | MDExOlB1bGxSZXF1ZXN0MTA4ODMxMjM4 | 103 | Quick fixes 03022017 | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-02T19:21:20Z | 2017-03-02T20:08:23Z | 2017-03-02T20:08:23Z | MEMBER | 0 | ACEmulator/ACE/pulls/103 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
364919791 | MDExOlB1bGxSZXF1ZXN0MjE4OTkxODU3 | 1030 | Centralize ACE Timers | Mag-nus 10608427 | closed | 0 | 0 | 2018-09-28T14:43:41Z | 2018-09-28T21:12:32Z | 2018-09-28T21:12:11Z | MEMBER | 0 | ACEmulator/ACE/pulls/1030 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1030/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
365092685 | MDExOlB1bGxSZXF1ZXN0MjE5MTIyNTkz | 1031 | PlayerFactory | Mag-nus 10608427 | closed | 0 | 1 | 2018-09-29T03:36:27Z | 2018-10-01T14:23:46Z | 2018-10-01T14:23:09Z | MEMBER | 0 | ACEmulator/ACE/pulls/1031 | Player/Character creation has been pulled out of CharacterHandler and added to a new PlayerFactory. PlayerFactory includes a Create275HeavyWeapons function to help with load testing. SpendAllXp has been added to Player_Xp.cs. A command handler can be added to allow use of this feature from in-game. SpendAttributeXp, SpendVitalXp and SpendSkillXp no longer perform the work unless SpendXp was successful. Player ctor from weenie no longer takes a Session object. Instead, only the AccountId is passed. This allows player creation without needing a session. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1031/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
365096164 | MDU6SXNzdWUzNjUwOTYxNjQ= | 1032 | Stop sending Burden of WeenieType.Creature to everyone in CreateObject | LtRipley36706 11369233 | closed | 0 | LtRipley36706 11369233 | 1 | 2018-09-29T04:35:10Z | 2019-03-23T05:38:40Z | 2019-03-23T05:38:40Z | MEMBER | ### Bug Report or Feature Request (mark with an `x`) ``` - [ x ] bug report -> please search issues before submitting - [ ] feature request ``` All creatures CreateObject messages currently include their burden. This was not the case for retail AC. Burden for creatures was only sent to that object, not broadcast. This behavior is different for other weenietypes as other objects should include burden when they have that data. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1032/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
365125396 | MDExOlB1bGxSZXF1ZXN0MjE5MTQzNjE1 | 1033 | Adding detection for post-PY16 skills, installation instructions on player login | gmriggs 8909245 | closed | 0 | 0 | 2018-09-29T11:47:16Z | 2018-09-29T17:40:40Z | 2018-09-29T17:40:40Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1033 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1033/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
365244017 | MDExOlB1bGxSZXF1ZXN0MjE5MjE2NTEw | 1034 | Updating September changelog | gmriggs 8909245 | closed | 0 | 0 | 2018-09-30T17:34:00Z | 2018-10-31T23:01:26Z | 2018-09-30T18:09:34Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1034 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1034/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
365466565 | MDExOlB1bGxSZXF1ZXN0MjE5Mzc5NzE5 | 1035 | PropertyDump added | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-01T13:40:00Z | 2018-10-01T13:52:05Z | 2018-10-01T13:51:34Z | MEMBER | 0 | ACEmulator/ACE/pulls/1035 | Properties are no longer spit out on ident in debug builds. Now, you can use /propertydump to spit out all the properties of the last item you identified. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1035/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
365477115 | MDExOlB1bGxSZXF1ZXN0MjE5Mzg3OTY2 | 1036 | Fix DamageType for Boost spells | ghost 10137 | closed | 0 | 1 | 2018-10-01T14:03:40Z | 2018-10-03T13:56:30Z | 2018-10-01T14:18:43Z | NONE | 0 | ACEmulator/ACE/pulls/1036 | Change DamageType to DamageType2 for LifeMagic Boost spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1036/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
365535879 | MDExOlB1bGxSZXF1ZXN0MjE5NDMzNDkx | 1037 | Rename DamageType2 to VitalDamageType | ghost 10137 | closed | 0 | 0 | 2018-10-01T16:13:51Z | 2018-10-03T13:56:31Z | 2018-10-01T18:12:09Z | NONE | 0 | ACEmulator/ACE/pulls/1037 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1037/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
365620857 | MDExOlB1bGxSZXF1ZXN0MjE5NDk4NDgz | 1038 | Landblock Preloading PoC | ghost 10137 | closed | 0 | 0 | 2018-10-01T20:04:32Z | 2018-10-03T13:56:32Z | 2018-10-02T16:53:24Z | NONE | 0 | ACEmulator/ACE/pulls/1038 | -Add functionality for preloading landblocks and making them perma-loaded | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1038/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
365673956 | MDExOlB1bGxSZXF1ZXN0MjE5NTM5NDQ5 | 1039 | Alleg Fixes plus fix for No Default SQL | acriaf 33154637 | closed | 0 | 1 | 2018-10-01T22:52:06Z | 2018-10-03T18:00:33Z | 2018-10-03T18:00:33Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1039 | Fixes an issue where a new characters will not show as joining an allegiance until a server restart. If the new character is the patron the server will crash, also fixed. During testing of the latest server code found that character creation was broken. Added that fix here by setting up Character.IsPlussed to 'true' in ..ACE\Source\ACE.Server\WorldObjects\Player.cs. I am not sure if it should be 'true' or 'false'. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1039/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211502816 | MDExOlB1bGxSZXF1ZXN0MTA4ODQwNDU4 | 104 | portal.dat and cell.dat loading (issue #3) | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-02T20:09:02Z | 2017-05-30T15:34:36Z | 2017-03-04T12:59:37Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/104 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
365698485 | MDExOlB1bGxSZXF1ZXN0MjE5NTU3Mzg2 | 1040 | Preventing RegenLocationType.Specific from spawning in another landblock | gmriggs 8909245 | closed | 0 | 0 | 2018-10-02T00:57:03Z | 2018-10-02T01:39:34Z | 2018-10-02T01:39:33Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1040 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1040/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
365924820 | MDExOlB1bGxSZXF1ZXN0MjE5NzI0Mzk2 | 1041 | Refactored generators, improved RNG selection formula | gmriggs 8909245 | closed | 0 | 0 | 2018-10-02T14:28:10Z | 2018-10-03T19:02:00Z | 2018-10-03T19:02:00Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1041 | - This fixes various bugs with generators, including: - Generators spawning too many objects - Generators RNG selecting the wrong objects - Generators missing various RNG formulas === - InitCreate and MaxCreate should be ints instead of uints (still needs fixed for SQL output) - Generators now use RegenInterval heartbeats === - Improved MotionRange broadcast performance slightly w/ distance squared - Improved performance for landblock objects by staggering the heartbeat offsets - Added default values for Generator properties - Moved HandlePhysics and ActiveLandblocks to UpdateGameWorld(), targeted to run @ 60hz - Updated SessionHandler for improved performance in common low usage scenarios. This needs to be re-evalulated to find the threshold where Parallel.ForEach improves performance - Removed calls to legacy Landblock.UpdateStatus() methods - Fixed a bug where resisted spells weren't alerting monsters - Fixed a crash for landblocks with no Info record | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1041/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
366014809 | MDExOlB1bGxSZXF1ZXN0MjE5Nzk0NDY1 | 1042 | Fix Generator Ints | LtRipley36706 11369233 | closed | 0 | 0 | 2018-10-02T18:04:46Z | 2019-01-05T23:23:01Z | 2018-10-03T01:34:59Z | MEMBER | 0 | ACEmulator/ACE/pulls/1042 | InitCreate and MaxCreate were incorrectly set as uint. Changed to int ### **You will need to delete and re-create your shard and world databases** | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1042/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
366127181 | MDExOlB1bGxSZXF1ZXN0MjE5ODgyMDQx | 1043 | Adding multistrike weapons | gmriggs 8909245 | closed | 0 | 0 | 2018-10-03T00:15:40Z | 2018-10-03T17:59:18Z | 2018-10-03T17:59:18Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1043 | - There are a bunch of Bandit weapons that can be used for testing. https://github.com/ACEmulator/ACE-World-16PY/search?q=TripleSlash will show a bunch of multistrike weapons. /ci 12053 for a Bandit Lightning Dagger - The animation hit frames were synced up reasonably well, but I am still looking for something in the data that can tell us exactly which animation frames to strike on. - Two-handed weapons are temporarily double-striking, while cleaving is still being added - Fixed a bug with fist combat mode being broken - Improved dual wielding combat so that the stats from the offhand weapon are used on the offhand attacks - Added more comments to Player_Melee - Fixed a bug where melee combat was not sending the 'AttackDone' network message when 'Auto-repeat' attacks option was disabled, with the power bar refilling (but not attacking again) - Fixed a bug where players could poke things with a staff, and other melee weapons that weren't supposed to thrust - Multistrike anomalies: shieldless combat cannot thrust, shield combat cannot slash (no animation links for these stances) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1043/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
366395059 | MDExOlB1bGxSZXF1ZXN0MjIwMDc5MzQ4 | 1044 | Adding two-handed weapons cleaving | gmriggs 8909245 | closed | 0 | 0 | 2018-10-03T15:23:42Z | 2018-10-03T19:03:06Z | 2018-10-03T19:03:06Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1044 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1044/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
366447892 | MDExOlB1bGxSZXF1ZXN0MjIwMTE5MzY1 | 1045 | Updating the 'item is low on mana / out of mana' system | gmriggs 8909245 | closed | 0 | 0 | 2018-10-03T17:31:46Z | 2018-10-03T19:02:23Z | 2018-10-03T19:02:23Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1045 | - Added the 'ItemManaDepleted' sound effect - Added a small delay between 'ItemManaDepleted' sound and 'SpellExpired' messages/sound effects. Not sure if retail just purged the item enchantments invisibly? - Changed the low mana warning timer from 30s -> 2m - Added commas to all numbers >= 1,000 - Added /givemana developer function - Changed the wording of some messages to match retail: - mana -> Mana for low/depleted messages - added a missing . to the end of item lists | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1045/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
366824733 | MDExOlB1bGxSZXF1ZXN0MjIwNDA0MjY2 | 1046 | Timing | Mag-nus 10608427 | closed | 0 | 1 | 2018-10-04T14:42:38Z | 2018-10-09T01:17:14Z | 2018-10-06T23:45:02Z | MEMBER | 0 | ACEmulator/ACE/pulls/1046 | gmriggs, if you could please use your timing utils to verify that UpdateGameWorld is averaging 60fps. Also, I think checking if the session count >= 5 just to save 1ms for this line of code is wasteful: Parallel.ForEach(sessions, s => s.TickInParallel()); On my system, the average overhead for the Parallel.ForEach call was 1ms to 2ms. TickInParallel takes on average, .1ms to .3ms but can spike to 5ms to 15ms. I think adding extra optimizations to ACE for player ranges of < 10 are a bit unnecessary. The server will already be extremely fast in such a scenario. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1046/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
367418617 | MDExOlB1bGxSZXF1ZXN0MjIwODYxNjg1 | 1047 | WeeniePrecaching | Mag-nus 10608427 | closed | 0 | 2 | 2018-10-06T03:21:29Z | 2018-10-09T23:55:11Z | 2018-10-09T15:52:01Z | MEMBER | 0 | ACEmulator/ACE/pulls/1047 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1047/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
367428898 | MDExOlB1bGxSZXF1ZXN0MjIwODY4Mzk2 | 1048 | Adding support for level 8 spells | gmriggs 8909245 | closed | 0 | 0 | 2018-10-06T06:26:43Z | 2018-10-09T15:47:27Z | 2018-10-09T15:47:27Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1048 | - Updated Spell enum to have consistent casing between spell levels - Fixed a bug in the spell DAT reader for component loss (uint -> float) - Fixed a 'collection was modified' error during player death while removing enchantments - Added /dispel developer command - Added /showstats debug command to show all player attribute and skill levels from server - Improved /buff command with an optional spell level # parameter = Fixed a bug where /buff command was applying multiple versions of the same spells - Fixed a bug where level 8 spells had their minimum power set to 350 instead of 400 - Fixed a bug where level 8 spell effects were too small - Added TransferFlags enum for life magic transfer spells - Fixed a bug where no death message was displayed for death blows from DamageType.Health (harm, drain, life projectiles) - Fixed a bug where item enchantments were having their ticks applied twice - Fixed a bug where mages would cast spells before rotating completely to target - Added level 8 item auras to EnchantmentManager.GetModifier() - Player magic refactoring - Fixed a bug where players would windup / fizzle if they didn't have enough mana - Updated text messages for life magic transfer and boost spells to match retail more closely - Fixed a bug where life projectiles were getting the target stats instead of the source stats - Updated life magic transfer spells to use TransferFlags | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1048/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
367500789 | MDExOlB1bGxSZXF1ZXN0MjIwOTE0NjY5 | 1049 | Improved death messages for PK battles | gmriggs 8909245 | closed | 0 | 0 | 2018-10-06T22:18:31Z | 2018-10-09T21:05:41Z | 2018-10-09T21:05:41Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1049 | Improved death message system to include death messages from other perspectives: the attacker, the victim, and nearby players - Added /sticky command - prevents players from leaving corpses and losing items on death - Fixed /heal to use max vitals - Added /deathxp command - Added randomized death messages for monsters killing players, based on damage type - Fixed a bug where spell projectiles weren't triggering the critical death messages - Improved the generic creature -> player death pipeline - Fixed a bug where monsters would continually attack players while still materializing at the lifestone | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1049/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211561301 | MDExOlB1bGxSZXF1ZXN0MTA4ODgzMTEx | 105 | More WorldObject Fixes | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-03T00:32:57Z | 2017-03-04T10:27:26Z | 2017-03-03T14:05:09Z | MEMBER | 0 | ACEmulator/ACE/pulls/105 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
367589881 | MDExOlB1bGxSZXF1ZXN0MjIwOTcwODgw | 1050 | Improved player movement when using items (corpses/chests/doors) | gmriggs 8909245 | closed | 0 | 0 | 2018-10-07T20:18:29Z | 2018-10-09T15:50:05Z | 2018-10-09T15:50:05Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1050 | - Fixed a bug where player would switch to Peace mode to open containers - Fixed a bug where player would return to an open container for closing - Fixed a bug with arbitrary delays for using / rotating towards items (0.5s/1.0s) - Improved animation timing when using consumables (food/drink) - Fixed various bugs with player switching to Peace mode to perform various actions, instead of using the current stance - Fixed a bug where NPCs were running Actions before completing rotation towards player - Refactored MoveToChain a bit | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1050/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
367888292 | MDU6SXNzdWUzNjc4ODgyOTI= | 1051 | Jump not seen by others | Warloxx01 38050842 | closed | 0 | 1 | 2018-10-08T17:38:22Z | 2018-10-26T21:55:16Z | 2018-10-26T21:55:16Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> Login any 2 Characters and stand face to face, Go thru the Emotes U,I,j and so on. They all can be seen by the other player... all but Jump. When one player jumps the other player see nothing happen. ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1051/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
367917194 | MDExOlB1bGxSZXF1ZXN0MjIxMjE1NDg4 | 1052 | Adding methods to QuestManager | gmriggs 8909245 | closed | 0 | 1 | 2018-10-08T19:10:16Z | 2018-10-13T07:57:05Z | 2018-10-13T07:57:04Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1052 | - Added quest solve timers to item pickups - More methods added to QuestManager - Fixed a bug where recipe items could be combined with themselves - Added ConvertToMoASkill() to recipe skill checks - Added Item Tinkering to skill updates | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1052/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
367978629 | MDU6SXNzdWUzNjc5Nzg2Mjk= | 1053 | Cannot send tells to non-players | OptimShi 26606778 | closed | 0 | gmriggs 8909245 | 0 | 2018-10-08T22:46:47Z | 2019-01-25T23:17:33Z | 2019-01-25T23:17:33Z | COLLABORATOR | ### Bug Report or Feature Request (mark with an `x`) ``` - [ X ] bug report - [ X ] feature request ``` ### Desired functionality. In GameActionTell.cs, the only "object" you can send a @tell to is another player. You need to be allowed to send @tell to NPCs. Specifically, the Professors of Magic responded to @tell commands and there were also others, as well. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1053/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
368245519 | MDExOlB1bGxSZXF1ZXN0MjIxNDY2NjEx | 1054 | Fix Landblock loading. Portaling collisions are now much more responsive | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-09T14:40:13Z | 2018-10-09T23:54:53Z | 2018-10-09T20:53:10Z | MEMBER | 0 | ACEmulator/ACE/pulls/1054 | Before, landblocks were loading all their assets in the ctor on the same thread. Now, we off-load that loading onto separate threads and use an actionQueue to perform the resulting work in the landblock Tick. Cleaned up the IsTeleporting flag. This should only be set/managed by the function that actually does the teleportation. NetworkSession has timers that control how often we send messages to the client. The check was > but should have been >=. If an end-user wants to set a time of 0, > would not have worked. Removed undeveloped/legacy LandBlockStatus code. This was used for our WinForms diagnostics app. We can redevelop this for the current state of ACE in the future if/when we have a diagnostics API. Fixed a crash in EmoteManager from player being null (after teleportation) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1054/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
368473317 | MDExOlB1bGxSZXF1ZXN0MjIxNjQzNTc1 | 1055 | Add teleloc to SQL writers | LtRipley36706 11369233 | closed | 0 | 0 | 2018-10-10T02:51:24Z | 2019-01-05T23:23:01Z | 2018-10-10T02:54:25Z | MEMBER | 0 | ACEmulator/ACE/pulls/1055 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1055/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
368684054 | MDExOlB1bGxSZXF1ZXN0MjIxODAzNjUx | 1056 | GameMessagePlayerTeleport was malformed | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-10T14:07:15Z | 2018-10-11T00:40:31Z | 2018-10-10T16:59:33Z | MEMBER | 0 | ACEmulator/ACE/pulls/1056 | Furthermore, in retail, the sequence sent in GameMessagePlayerTeleport is always the PREVIOUS sequence value, and then the sequence get's incremented AFTER the message is actually secent (and thus, sent in the next UpdatePosition message). For simplicity, ACE just increments the sequence BEFORE this message is sent. It doesn't seem to affect the client or decal and is cleaner this way. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1056/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
368908889 | MDExOlB1bGxSZXF1ZXN0MjIxOTc0OTI5 | 1057 | Proper GameMessagePlayerTeleport fix. | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-11T00:48:31Z | 2018-10-11T00:51:13Z | 2018-10-11T00:50:59Z | MEMBER | 0 | ACEmulator/ACE/pulls/1057 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1057/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
369424808 | MDExOlB1bGxSZXF1ZXN0MjIyMzY4ODI3 | 1058 | Adding more quest emotes | gmriggs 8909245 | closed | 0 | 0 | 2018-10-12T07:04:55Z | 2018-10-15T07:49:35Z | 2018-10-15T07:49:35Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1058 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1058/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
369592271 | MDExOlB1bGxSZXF1ZXN0MjIyNDk3ODcy | 1059 | VitalHeartBeat performance optimizations | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-12T15:07:29Z | 2018-10-13T12:21:28Z | 2018-10-13T07:57:58Z | MEMBER | 0 | ACEmulator/ACE/pulls/1059 | These changes are the result of profiling. VitalHeartBeat (formerly VitalTick) had code that iterated over all enchantments several times. This reduces the number of times those collections are iterated over on each heartbeat. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1059/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211886644 | MDExOlB1bGxSZXF1ZXN0MTA5MTExNTA5 | 106 | Continuing SO's WorldObject rework | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-04T15:39:17Z | 2017-05-30T15:34:35Z | 2017-03-06T12:33:26Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/106 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/106/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
369744049 | MDExOlB1bGxSZXF1ZXN0MjIyNjExNjQ5 | 1060 | LaunchMissile check for null (fix exception) | Mag-nus 10608427 | closed | 0 | 1 | 2018-10-12T23:48:19Z | 2018-10-13T12:21:40Z | 2018-10-13T07:58:24Z | MEMBER | 0 | ACEmulator/ACE/pulls/1060 | Should this even be wrapped in an actionchain? We shouldn't wrap things in action chains now unless we really need to. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1060/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
369789091 | MDU6SXNzdWUzNjk3ODkwOTE= | 1061 | Olthoi Swarm Eviscerator badly attempting to wield Quarter Staff | ghost 10137 | closed | 0 | 0 | 2018-10-13T10:26:45Z | 2018-10-15T07:50:20Z | 2018-10-15T07:50:20Z | NONE | ### Bug Report or Feature Request (mark with an `x`) ``` - [x ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. Issue visible by teleporting to the following coordinates... @teleloc 0x574E0103 [9.067720 -11.236900 -29.995001] -0.966798 0.000000 0.000000 -0.255542 ### Desired functionality. Olthoi mobs shouldn't be wielding items | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1061/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
369789762 | MDU6SXNzdWUzNjk3ODk3NjI= | 1062 | @adminvision on not revealing hidden items, such as generators | ghost 10137 | closed | 0 | 0 | 2018-10-13T10:35:34Z | 2018-10-15T07:50:50Z | 2018-10-15T07:50:50Z | NONE | ### Bug Report or Feature Request (mark with an `x`) ``` - [x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. Should be a Linkable Item Generator at this location... @teleloc 0x574E0103 [9.067720 -11.236900 -29.995001] -0.966798 0.000000 0.000000 -0.255542 Another location of a Linkable Item Generator: @teleloc 0x01560130 [19.643900 -73.242100 -11.995000] 0.282177 0.000000 0.000000 -0.959362 ### Desired functionality. Toggling @adminvision to the on state, with an admin account, should reveal the placement of generators. ### Mention any other details that might be useful. Specifically for generator weenie 15759, which is the generator type at the above locations, modifying the Visibility bool property does reveal the generator. However, the issue appears to apply to all generators, as they also do not become visible when toggling on @adminvision, when traveling to their locations given in the SQL data files. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1062/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
369790544 | MDU6SXNzdWUzNjk3OTA1NDQ= | 1063 | Linkable Item Generators failing to spawn their linked items | ghost 10137 | closed | 0 | 0 | 2018-10-13T10:45:56Z | 2018-10-15T07:50:58Z | 2018-10-15T07:50:58Z | NONE | ### Bug Report or Feature Request (mark with an `x`) ``` - [x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. Example of issue: Generator at this location, @teleloc 0x01560130 [19.643900 -73.242100 -11.995000] 0.282177 0.000000 0.000000 -0.959362, should be spawning a Hard Cove Apple Cider at this location @teleloc 0x01560102 [-2.692260 -73.242500 -17.955000] 0.956172 0.000000 0.000000 -0.292804 ### Desired functionality. Linked items should be spawned by Linked Item Generators ### Mention any other details that might be useful. https://github.com/ACEmulator/ACE-World-16PY/blob/master/Database/3-Core/6%20LandBlockExtendedData/SQL/0156.sql has the data points for the example given of the bug in this issue report https://github.com/ACEmulator/ACE-World-16PY/blob/master/Database/3-Core/6%20LandBlockExtendedData/SQL/545C.sql has another Linkable Item Generator type that is also not spawning its items | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1063/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
369877590 | MDExOlB1bGxSZXF1ZXN0MjIyNjk5MjY4 | 1064 | Some bug fixes - Resolves #1061, #1062 & #1063 | gmriggs 8909245 | closed | 0 | 0 | 2018-10-14T07:48:03Z | 2018-10-15T07:50:19Z | 2018-10-15T07:50:18Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1064 | - Fixed a bug where Olthoi Swarm Eviscerator would spawn a quarter staff in its inventory, and attempt to wield it - Fixed a bug where some linkable generators were not being classified correctly, and not spawning all of their objects - Fixed a bug where '/adminvision on' would not take effect immediately - Fixed a bug where larger monsters were not being detected as within melee range of player Thanks @kdmxp256 for finding and reporting these bugs | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1064/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
369887702 | MDExOlB1bGxSZXF1ZXN0MjIyNzA1ODE5 | 1065 | Adding more quest emotes, refactoring EmoteManager | gmriggs 8909245 | closed | 0 | 0 | 2018-10-14T10:16:11Z | 2018-10-15T17:06:56Z | 2018-10-15T17:06:56Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1065 | - Started to add @qst command to match admin client. - Added Home position for all Creatures, and support for the MoveHome emote - Removed the redundant delay adding code from the individual emotes. - Removed most of the ActionChain code from the inner ExecuteEmote function. These are both now handled consistently by the calling function, ExecuteEmoteSet. - The EmoteManager refactoring is geared towards supporting an important feature, the concept of queueing and blocking emote sets. - Added support for NPCs in the busy state while executing an emote chain - Added support for monster AiOptions. Currently the only known option is the ability to open doors. Monsters such as Olthoi will now open the squishy doors when they touch them - Fixed a bug where instant healthbar updates for the player's attack target were not correctly reporting the death blow - Fixed a bug where some ethereal objects such as portals were blocking the movement of some creatures - Fixed a possible null pointer exception with ActionChain.AddChain() being passed an empty chain - Fixed a bug where TurnToHeading in the movement packet was not sending the DesiredHeading | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1065/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
369948356 | MDExOlB1bGxSZXF1ZXN0MjIyNzQ2MTA3 | 1066 | Command verb "list" for developer command /telepoi | fartwhif 3317737 | closed | 0 | 0 | 2018-10-14T22:00:00Z | 2018-10-19T00:47:30Z | 2018-10-19T00:04:30Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1066 | (re)caches and lists all POIs | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1066/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
369957103 | MDExOlB1bGxSZXF1ZXN0MjIyNzUyMDE1 | 1067 | More profiling based improvements | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-14T23:46:08Z | 2018-10-16T03:32:57Z | 2018-10-16T03:06:54Z | MEMBER | 0 | ACEmulator/ACE/pulls/1067 | There are 2 major changes in this PR. 1) NetworkSession GameMessageGroup based bundles have been switched from a concurrent dictionary to an array. An array will be many times more performant as there are only 12 elements and they're aligned to a 64bit boundary, thus making get/sets atomic. As such, we can simplify the way we lock access to each element. 2) Landblock ctor async code has been grouped up into a single thread. Furthermore, the database work being performed inside that thread will no longer spawn more threads by using parallel calls. This makes sure that landblock construction an obtaining assets doesn't eat up the applications idle threads from the pool. We want to save those threads for more important work that will help keep UpdateGameWorld running smoothly. Renamed the Session tick functions to be more appropriate. Removed the unnecessary check/recheck code from LandblockManager.GetLandblock. This is a common routine for a pattern we used to be using but are no longer, thus, there is no need for the check/recheck. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1067/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
370030253 | MDExOlB1bGxSZXF1ZXN0MjIyODA0Nzgy | 1068 | Some SQL Writer tweaks | LtRipley36706 11369233 | closed | 0 | 0 | 2018-10-15T07:21:46Z | 2019-01-05T23:23:00Z | 2018-10-15T07:51:50Z | MEMBER | 0 | ACEmulator/ACE/pulls/1068 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1068/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
370048771 | MDExOlB1bGxSZXF1ZXN0MjIyODE4NTc2 | 1069 | Adding dispels and pressure plates | gmriggs 8909245 | closed | 0 | 0 | 2018-10-15T08:18:49Z | 2018-10-16T03:07:42Z | 2018-10-16T03:07:42Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1069 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1069/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
211999671 | MDExOlB1bGxSZXF1ZXN0MTA5MTc0Mzc1 | 107 | Add DAT loading into main process | ghost 10137 | closed | 0 | 3 | 2017-03-06T00:43:14Z | 2017-10-18T14:07:36Z | 2017-03-07T01:30:51Z | NONE | 0 | ACEmulator/ACE/pulls/107 | Obtains the two DAT file locations from the config.json file. Code also handles file not found exceptions and prints out an error. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
371833824 | MDExOlB1bGxSZXF1ZXN0MjI0MTkxMTI5 | 1070 | Fixing jump in multiplayer, refactoring movement and animation systems for network and game layers | gmriggs 8909245 | closed | 0 | 1 | 2018-10-19T07:14:22Z | 2018-10-23T04:16:53Z | 2018-10-23T04:16:53Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1070 | - UniversalMotion has been replaced with a new Motion class, which has a much simpler API - Fixed a multiplayer bug where jumping couldn't be seen by other players - Added Network structures for all movement and animation related packets in Network.Motion namespace - Fixed a bug where players performing standing longjumps would repeatedly appear to run ahead and snapback in multiplayer - Improved parsing of contact/isgrounded/sticky/standinglongjump/ flags in movement packets - Added network reader alignment - Fixed a bug where creatures were broadcasting UpdatePosition messages when performing emotes while standing still - Improved performance of GfxObjCache | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1070/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
372221192 | MDExOlB1bGxSZXF1ZXN0MjI0NDgwNjYy | 1071 | Landblock item saving + Much more | Mag-nus 10608427 | closed | 0 | 1 | 2018-10-20T15:13:44Z | 2018-10-23T23:56:15Z | 2018-10-23T20:52:10Z | MEMBER | 0 | ACEmulator/ACE/pulls/1071 | * Server Shutdown - Improved shutdown process. - More status messages are sent to the logger - The server now waits for database operations to complete * Landblocks - Fixed a bug where landblocks were loading equipped items as objects owned by the landblock (they're owned by the player, who in turn is owned by the landblock) - Fixed a crash when trying to add a bad WO to the landblock * WorldObject Decay - Now controlled by the landblock - WorldObject_Decay.cs added to manage decay of all decayable objects - WorldObject_Database now has functions to determine what static objects and what dynamic objects should be saved to the shard * WorldObject Database Persistence - To/From player inventory actions no longer trigger database actions. Single database actions are costly - Players are saved to the database on a per player 5 minute interval. This collects all of their items and saves them in parallel - Landblocks save their items to the database on a per landblock 5 minute interval. This collects all of their items and saves them in parallel. - Only items that do not exist in the database but should, or, exist and have changes are saved. - Static objects like housing, etc.. should now properly save/restore as well * WorldObject.Destroy - Now destroys all contained items (if any exist) - Now destroys all equipped items, (if any exist) * Shard Database - Fixed a bug when a biota was removed and then resaved to the db. * Positions - PositionType moved to the ACE.Entity.Enum.Properties folder, and set to a : ushort - PositionType Ephemeral support aded. - PositionType.Home set to Ephemeral | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1071/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
372298057 | MDExOlB1bGxSZXF1ZXN0MjI0NTMwMjE0 | 1072 | Improving monster animation sync between server and client | gmriggs 8909245 | closed | 0 | 1 | 2018-10-21T09:57:59Z | 2018-10-23T04:21:10Z | 2018-10-23T04:21:09Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1072 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1072/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
372492578 | MDExOlB1bGxSZXF1ZXN0MjI0NjU4NzU4 | 1073 | DatDatabase ReadFromDat thread safety added | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-22T12:04:49Z | 2018-10-23T13:48:06Z | 2018-10-23T12:27:51Z | MEMBER | 0 | ACEmulator/ACE/pulls/1073 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1073/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
372721165 | MDExOlB1bGxSZXF1ZXN0MjI0ODMwMDA2 | 1074 | changing @portal_bypass to also ignore quest restrictions | fartwhif 3317737 | closed | 0 | 0 | 2018-10-22T22:08:16Z | 2018-12-07T02:14:50Z | 2018-10-23T12:31:07Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1074 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1074/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
372839354 | MDExOlB1bGxSZXF1ZXN0MjI0OTE5Mzc4 | 1075 | Lugian animation / stance improvements | gmriggs 8909245 | closed | 0 | 0 | 2018-10-23T07:06:21Z | 2018-10-24T23:52:43Z | 2018-10-24T23:52:43Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1075 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1075/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
374027900 | MDU6SXNzdWUzNzQwMjc5MDA= | 1076 | Inventory items reapearing in Backpack after log out/in | Warloxx01 38050842 | closed | 0 | Mag-nus 10608427 | 8 | 2018-10-25T16:19:48Z | 2018-10-31T20:01:35Z | 2018-10-31T20:01:35Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> I got the latest ACE Build. deleted the old Database. Installed the latest 16PY v0.0.20. Created my Player account created my Charactor got teleported out to Holtburg with my started gear ( Academy coat, 2x oil, Starter wand, bread, Letter, book, and so on. I lifestoned and went to drop the junk on the Town Crier. Dropped the Bread, Coat, Oils Letter and so on on the Town Crier. I kept the Tapers, Scarab, ust and Blue Gem. Ran down and grabbed a Faran Robe and went back to the LS. Logged out and back in and I got the Bread, Calling Stone (Originally given to the Society Agent) letter and book back in my backpack. I did this experiment because I had the same issue appear with the last player I was working with testing things. It put the Harvester Pincer and the heal kits as well as the ring and C note back in my pack. Even though I had done the Quest the day before, Logged out wne tot work did my daily running and so on. ( I also had left the server running after the quest) I never shut it down. It was running for like 15 Hours straight. Sorry to babble. BTW it started with the Completed issue fix that stated something about and many more fixs. Sorry I can't remember what number it was, I think it was the one before the Lugian fix. ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1076/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
374225737 | MDExOlB1bGxSZXF1ZXN0MjI1OTc1NDkx | 1077 | Landblock async physics loading + some physics profiling improvements *NEEDS TESTING* | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-26T04:49:58Z | 2018-10-28T14:11:51Z | 2018-10-28T04:29:36Z | MEMBER | 0 | ACEmulator/ACE/pulls/1077 | * Vertex/Polygon/BSP cache disabled by default * GfxObjCache is now thread safe * DBObj boxing/unboxing improvements With the above changes, landblock physics loading uses about 30% less CPU. * Landblock now loads physics assets in the async worker created in the landblock ctor. There might still be some bugs from this, will need some testing. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1077/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
374657877 | MDExOlB1bGxSZXF1ZXN0MjI2MzAyNjk2 | 1078 | Give item fix | Mag-nus 10608427 | closed | 0 | 0 | 2018-10-27T15:35:35Z | 2018-10-28T14:11:30Z | 2018-10-28T04:29:58Z | MEMBER | 0 | ACEmulator/ACE/pulls/1078 | Fixed corpses not decaying at Corpse.EmptyDecayTime after they were looted. Fixed items given to NPC's reappearing back in your inventory. Item.Destroy() was not being called on the object after it was processed. Destroy() will remove the item from the database, thus, breaking the link from the player. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1078/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
374713088 | MDExOlB1bGxSZXF1ZXN0MjI2MzQwMjE2 | 1079 | Refactoring LandblockManager, improving VitalTick performance | gmriggs 8909245 | closed | 0 | 0 | 2018-10-28T03:29:54Z | 2018-10-28T13:56:49Z | 2018-10-28T13:56:49Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1079 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1079/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
212027453 | MDExOlB1bGxSZXF1ZXN0MTA5MTkyMzk2 | 108 | Time returns to Dereth | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-06T05:28:29Z | 2017-03-10T04:55:10Z | 2017-03-07T01:29:35Z | MEMBER | 0 | ACEmulator/ACE/pulls/108 | Rain rain go away... Added time to Dereth. Once the server starts, the clock is set and is hardcoded at this point to start at the current Lore corrected DerethDateTime. @time command wired up. Time progresses as it did on retail and does not reset in between sessions as long as server remains running. There are several functions within DerethDateTime that could help enable some interesting ideas in the future such as "dynamic seasons" and changing spawns based on TimeOfDay (like Graveyard) for examples. It would depend on if we're able to build in time-checking logic to spawnable/generator objects, which I assume we would be doing, especially once we get around to rebuilding the GY area. TODO: Save the progression of ServerTime periodically to be recalled when server is offline'd/online'd. TODO: Setup a variable in Config.json and ConfigManager to allow the server operator to pick a date to start the server from. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
374841068 | MDExOlB1bGxSZXF1ZXN0MjI2NDI1NjIz | 1080 | remove redundant dictionary in sql writer | LtRipley36706 11369233 | closed | 0 | 0 | 2018-10-29T03:07:19Z | 2019-01-05T23:22:59Z | 2018-11-01T06:54:42Z | MEMBER | 0 | ACEmulator/ACE/pulls/1080 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1080/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
375517888 | MDExOlB1bGxSZXF1ZXN0MjI2OTQ0MTcw | 1081 | More item destruction fixes | Mag-nus 10608427 | closed | 0 | 2 | 2018-10-30T14:26:50Z | 2018-11-11T02:24:13Z | 2018-10-31T19:35:01Z | MEMBER | 0 | ACEmulator/ACE/pulls/1081 | Retain TimeToRot magic values of 0 and -1. They may have come from the weenie. Destroy stacks that are consumed. Destroy consumables when they're consumed. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1081/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
375627064 | MDExOlB1bGxSZXF1ZXN0MjI3MDI5NDcy | 1082 | Adding particle emitters | gmriggs 8909245 | closed | 0 | 0 | 2018-10-30T18:14:36Z | 2018-11-01T06:55:12Z | 2018-11-01T06:55:12Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1082 | Much thanks to Pea and parad0x for their pioneering work to RE these systems | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1082/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
375962769 | MDU6SXNzdWUzNzU5NjI3Njk= | 1083 | Able to drop Attune and Bonded items | Warloxx01 38050842 | closed | 0 | Mag-nus 10608427 | 1 | 2018-10-31T13:29:58Z | 2019-01-04T01:58:57Z | 2019-01-04T01:58:57Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> add a Attune, Bonded item... /ci 22080 (Imp Staff) Attempt to drop it from your inventory. (Can't) Equip the staff. Now drag and drop it to the ground (Have not tried to give to another character) you WILL be allowed to drop it to the ground. Another character CAN pick it up ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1083/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
376084064 | MDU6SXNzdWUzNzYwODQwNjQ= | 1084 | Items Dissapearing immediately when dropped | Warloxx01 38050842 | closed | 0 | gmriggs 8909245 | 3 | 2018-10-31T17:42:37Z | 2018-12-14T17:27:42Z | 2018-12-14T17:27:42Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [x ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> Ok I noticed this issue when starting a new "Player" Character for testing. 1)Drop item, Logout 2) Log back in, pick up item. 3) Log out/Log in Drop item (item disappears immediately) ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1084/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
376192416 | MDExOlB1bGxSZXF1ZXN0MjI3NDY3NDA0 | 1085 | Updating October changelog | gmriggs 8909245 | closed | 0 | 0 | 2018-10-31T23:01:59Z | 2018-11-30T23:04:48Z | 2018-11-01T06:58:07Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1085 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1085/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
376275136 | MDExOlB1bGxSZXF1ZXN0MjI3NTI5MTQx | 1086 | Fixes for Anniversary Event emotes | LtRipley36706 11369233 | closed | 0 | 3 | 2018-11-01T06:52:03Z | 2019-01-05T23:22:58Z | 2018-11-02T00:10:54Z | MEMBER | 0 | ACEmulator/ACE/pulls/1086 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1086/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
377643053 | MDExOlB1bGxSZXF1ZXN0MjI4NTM4Mjk3 | 1087 | correcting bug causing server crash when using pools | fartwhif 3317737 | closed | 0 | 0 | 2018-11-06T00:33:54Z | 2018-12-07T02:15:02Z | 2018-11-06T12:43:01Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1087 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1087/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
377675016 | MDExOlB1bGxSZXF1ZXN0MjI4NTYxNjUy | 1088 | adding @netstats admin command | fartwhif 3317737 | closed | 0 | 0 | 2018-11-06T03:12:52Z | 2018-11-07T17:40:26Z | 2018-11-07T17:40:26Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1088 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1088/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issues] ( [id] INTEGER PRIMARY KEY, [node_id] TEXT, [number] INTEGER, [title] TEXT, [user] INTEGER REFERENCES [users]([id]), [state] TEXT, [locked] INTEGER, [assignee] INTEGER REFERENCES [users]([id]), [milestone] INTEGER REFERENCES [milestones]([id]), [comments] INTEGER, [created_at] TEXT, [updated_at] TEXT, [closed_at] TEXT, [author_association] TEXT, [active_lock_reason] TEXT, [draft] INTEGER, [pull_request] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [state_reason] TEXT, [repo] INTEGER REFERENCES [repos]([id]), [type] TEXT ); CREATE INDEX [idx_issues_repo] ON [issues] ([repo]); CREATE INDEX [idx_issues_milestone] ON [issues] ([milestone]); CREATE INDEX [idx_issues_assignee] ON [issues] ([assignee]); CREATE INDEX [idx_issues_user] ON [issues] ([user]);