issues
Data license: AGPL · Data source: ACEmulator Project
4,138 rows sorted by closed_at
This data as json, CSV (advanced)
Suggested facets: state, assignee, comments, author_association, draft, state_reason, type, created_at (date), updated_at (date), closed_at (date)
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at ▼ | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
220952882 | MDU6SXNzdWUyMjA5NTI4ODI= | 234 | Create Test Script and add to project | ogmage78 25460553 | open | 0 | 3 | 2017-04-11T13:32:35Z | 2019-08-27T00:11:54Z | CONTRIBUTOR | As each of us is working on different parts at different times, it would be useful to have a document like our read me or change log where we could put tests and expected results for our areas. That way prior to submitting a PR you could run through the test to make sure your change did not break the world. Quick example: Test item pickup and drop 1. Log in on 2 characters ( we need to test what other clients are seeing) 2. On client 1 in the chat window type @ctw me 3. Take the wand and drop it to the ground. a. Did both clients see and here the drop? Do you see the wand on the ground from both clients. Did client 1 do the animation to set the wand on the ground. Is the item out of the backpack for client 1? 4. Pick up the wand. Is the wand gone for client 2 and in the backpack of client 1. Did you see the animation from both clients. Did you hear the pickup sound. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/234/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
289819550 | MDU6SXNzdWUyODk4MTk1NTA= | 591 | Agreement to change licence to AGPL V3. | cydrith 24561337 | open | 0 | 1 | 2018-01-19T00:04:55Z | 2023-11-23T01:50:26Z | CONTRIBUTOR | ### Bug Report or Feature Request (mark with an `x`) ``` - [ ] bug report -> please search issues before submitting - [x] feature request ``` ### Desired functionality. Change licence to AGPL, from existing GPL. Changes proposed in [this pull request](https://github.com/ACEmulator/ACE/pull/589). ### Express Consent from following contributors has been provided - [x] [LtRipley36706](https://github.com/LtRipley36706) - [x] [Mogwai-TheFurry](https://github.com/Mogwai-TheFurry) - [x] [ogmage78](https://github.com/ogmage78) - [ ] [fantoms](https://github.com/fantoms) - [x] [OptimShi](https://github.com/OptimShi) - [x] [Rawaho](https://github.com/Rawaho) - [x] [Zegeger](https://github.com/Zegeger) - [x] [kdmxp256](https://github.com/kdmxp256) - [x] [Forbiddenz](https://github.com/Forbiddenz) - [ ] [Lidefeath](https://github.com/Lidefeath) - [x] [ddevec](https://github.com/ddevec) - [x] [BrainBucket](https://github.com/BrainBucket) - [x] [TigrisOfGaul](https://github.com/TigrisOfGaul) - [x] [Mag-nus](https://github.com/Mag-nus) - [x] [lurker-mcdoogle](https://github.com/lurker-mcdoogle) - [x] [MiachofTD](https://github.com/MiachofTD) - [ ] [LytelthorpeThistledown](https://github.com/LytelthorpeThistledown) - [ ] [ChrisAikman](https://github.com/ChrisAikman) - [ ] [delasteve](https://github.com/delasteve) - [x] [immortalbob](https://github.com/immortalbob) - [ ] [kaos00723](https://github.com/kaos00723) - [ ] [sbaum23](https://github.com/sbaum23) - [x] [Verbal-AC](https://github.com/Verbal-AC) - [x] [zbuc](https://github.com/zbuc) - [ ] [TheMentor](https://github.com/TheMentor) - [x] [Cydrith](https://github.com/Cydrith) - [ ] [KochiroOfHG](https://github.com/KochiroOfHG) - [x] [Zorgle](https://github.com/Zorgle) - [x] [Jyard1](https://github.com/Jyard1) - [x] [rtmruczek](https://github.com/rtmruczek) - [x] [Slushnas](https://github.com/Slushnas) - [x] [dworkin](https://github.com/dworkin) - [x] [spazmodica](https://github.com/spazmodica) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
294216436 | MDU6SXNzdWUyOTQyMTY0MzY= | 617 | ACE.DatLoader unsupported file types | Mag-nus 10608427 | open | 0 | 1 | 2018-02-04T17:59:57Z | 2018-05-23T16:16:05Z | MEMBER | We don't parse all the file types in the .dat files. While the ones remaining likely aren't needed now, it might be a fun project for someone to take on, and may also prove useful for someone down the road. You can see a list of incomplete file types here, in the UnpackPortalDatFiles_NoExceptions(): https://github.com/ACEmulator/ACE/blob/master/Source/ACE.DatLoader.Tests/DatTests.cs | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/617/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
295860010 | MDU6SXNzdWUyOTU4NjAwMTA= | 630 | ACE.Entity.Position | Mag-nus 10608427 | open | 0 | Mag-nus 10608427 | 0 | 2018-02-09T12:48:29Z | 2019-04-01T17:58:06Z | MEMBER | I think LandCell and Frame should be sub properties of ACE.Entity, similar to how it's done in ACE.DatLoader. I haven't figured out the exact pattern yet, but this is something I'll be looking into. It may end up that what we have now is ideal. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/630/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | |||||||
310644605 | MDU6SXNzdWUzMTA2NDQ2MDU= | 718 | ACE.Server needs to expose an API for diagnostics and other information | Mag-nus 10608427 | open | 0 | gmriggs 8909245 | 7 | 2018-04-02T23:33:08Z | 2021-10-02T16:41:40Z | MEMBER | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ ] bug report -> please search issues before submitting - [ X] feature request ``` ### Desired functionality. The ACE project is growing rapidly and we need the ability to expose diagnostic information from ACE.Server for 3rd party tools to access. Such data exposed might be: Number of players connected Player locations Landblock states Chat Physics Information Debugging We used to have an ACE.Diagnostics project that collected information from ACE.Server, but that was removed because the implementation required ACE.Server to have a direct reference to the ACE.Diagnostics project. ACE.Server should not require a direct reference to the 3rd party tools collecting the information. Perhaps an ACE.Diagnostics library is created that is used for the API. We need someone to help us model the base implementation so that we can build on it as the project grows. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/718/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | |||||||
349837464 | MDU6SXNzdWUzNDk4Mzc0NjQ= | 950 | Improve Player EnterWorld Process | Mag-nus 10608427 | open | 0 | Mag-nus 10608427 | 0 | 2018-08-12T19:27:44Z | 2019-04-01T17:58:06Z | MEMBER | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ ] bug report -> please search issues before submitting - [X ] feature request ``` ### Repro steps. Currently, when a user clicks the enter button on the client to enter the world with a selected player, before the users player enters portal space, first the server must gather the character object and all inventory biotas from the database. While the recent improvements have improved this time greatly, there could still be observable latency in the future when the database is being used more heavily. ### Desired functionality. When a user clicks the Enter button, the server should: 1. Request the Character object from the databases 2. Send enough info back to the user to enter the selected player into portal space 3. Request the full list of owned biotas from the database 4. If the player enters the world before the biotas are received, the user should stay in pink bubble state. 5. Once all the biotas are received and sent to the user, the player should exit pink bubbles and be playable. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/950/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | |||||||
426208459 | MDU6SXNzdWU0MjYyMDg0NTk= | 1577 | Extra data is sent during appraisals | OptimShi 26606778 | open | 0 | 0 | 2019-03-27T22:18:40Z | 2020-07-14T21:55:05Z | COLLABORATOR | ``` - [ X ] bug report -> please search issues before submitting ``` ### Repro steps. When appraising an item, the resulting APPRAISAL_INFO_EVENT is sending back more properties than the client needs. ### Desired functionality. Reduce the size of the message and only send data that the client needs/wants/expects. ### Mention any other details that might be useful. Create a new attribute on the different property enums to signify if the property is sent directly during appraisals. (Note that some data is sent via a different list, e.g. PropertyInt.Damage is not sent with the intStats, but within the weaponProfile list.) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1577/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
433058204 | MDU6SXNzdWU0MzMwNTgyMDQ= | 1734 | combat uninterrupted by heal | fartwhif 3317737 | open | 0 | gmriggs 8909245 | 0 | 2019-04-15T01:16:25Z | 2019-05-22T00:49:39Z | COLLABORATOR | ### Bug Report or Feature Request (mark with an `x`) ``` - [ X ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. during melee combat heal after the blade swing animation before the next "power-up" ### Visualized result after heal combat has resumed as if no heal has taken place ### Expected result combat interrupted and player forced to re-initiate combat after the heal | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1734/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | |||||||
437208346 | MDU6SXNzdWU0MzcyMDgzNDY= | 1806 | Spells on Stave of Palenqual and Puppeteer's Skull not implemented yet | DrudgeRobber 46425530 | open | 0 | 7 | 2019-04-25T13:45:41Z | 2019-05-21T05:19:08Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [x] bug report -> please search issues before submitting - [x] feature request ``` The [Stave of Palenqual](http://acpedia.org/wiki/Stave_of_Palenqual) (using the version with Avalanche added) and [Puppeteer's Skull](http://acpedia.org/wiki/Puppeteer's_Skull) both throw "Avalanche/Wrath of the Puppeteer not implemented, yet!" errors on attempting to use their respective built in spells. The Stave of Palenqual also seems to fizzle when attempting to cast it on monsters or NPCs. It only follows through to the "* not implemented, yet!" when attempting to cast it on another player character. The [Virindi Implant (Purple)](http://acpedia.org/wiki/Virindi_Implant_(Purple)) seems to have a similar problem with fizzling on targets other than players. ### Repro steps. <!-- Please list the steps to reproduce a bug here --> ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1806/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
510394469 | MDExOlB1bGxSZXF1ZXN0MzMwNzc2NzQ4 | 2345 | [WIP] adding preliminary calcs for allegiance passup xp realtime and gametime factors | gmriggs 8909245 | open | 0 | 0 | 2019-10-22T02:25:44Z | 2019-10-22T10:33:06Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/2345 | Still left to solve: how to best handle players who have already been sworn for quite some time, but no swear timestamps were saved for Setting the current timestamp/age would be easy, but also would also not be beneficial to players who have been in established allegiances. I would give these players the benefit of the doubt, and set their data to the server established timestamp. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2345/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
549757792 | MDExOlB1bGxSZXF1ZXN0MzYyNzkwMTE2 | 2616 | improved database persistence for biota_properties_generator | gmriggs 8909245 | open | 0 | 2 | 2020-01-14T19:02:08Z | 2020-08-09T23:59:51Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/2616 | I did a search through all the weenie_properties_generators, and for every object except 31986, the probabilities are always in ascending order. However, this is not 100% foolproof, and there are a few caveats with this: some generators contain spans with the same probabilities, usually a bunch of -1's... these will still be sorted into a non-guaranteed order This should cover 99.9%+ of the scenarios though, and let us get away with restoring the biota_properties_generator in the original weenie_properties_generator ordering, without an explicit 'order' column | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2616/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
579615639 | MDExOlB1bGxSZXF1ZXN0Mzg2OTc4NDg4 | 2809 | [TEST] network relogin | gmriggs 8909245 | open | 0 | 2 | 2020-03-12T00:15:23Z | 2020-09-05T07:04:39Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/2809 | Repro steps: - In your Config.js, set DefaultSessionTimeout to 999 for easier testing - In your log4net.config, set the Console threshold to DEBUG for easier testing - Connect to your local server in ThwargLauncher advanced mode. Make sure your server name in ThwargLauncher does NOT match up with your local server name, so that if ThwargLauncher is left open, it automatically disconnects you in ~30s - Log into the game world - Wait for ThwargLauncher to automatically close the AC window - Try to reconnect Expected: - Existing character is booted out of the game world Actual: - Existing character is never booted out of the game world. New session cannot connect. There are some odd issues with this PR, namely if you try this multiple times, the existing Player state will get into an odd loop, where the Session is disconnected, but the Player is still saving on the landblock or something.. This can be seen after multiple retries, or using /pktimer sometimes helps. The previous session will go into 'SessionTerminating' state, and then be dropped, while the previous player still seems to be in the world. This allows the new session to connect to the char select screen, but then gets into an automatic loop when trying to log into the world, until the existing player is finally logged out. Could use @fartwhif 's help on this one | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2809/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
655310664 | MDExOlB1bGxSZXF1ZXN0NDQ3ODM3ODcy | 3074 | wip: recklessness updates | gmriggs 8909245 | open | 0 | 0 | 2020-07-12T01:28:17Z | 2020-07-12T01:34:05Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/3074 | - Fixes an issue with recklessness ratings from both attacker and defender being combined as multipliers, instead of additives. With 2 players that have recklessness speced, this provided a 44% damage increase, instead of 40% - Starts to fix some issues with Recklessness! combat message prefixes, although still needs to be investigated more: Scenario A: a non-reckless player attacks a player currently in reckless mode. Both players currently receive the Recklessness! prefix for the combat message, as the attack received a bonus from the defender being in reckless mode. This is confusing for the attacker, since they might not even have recklessness trained. Scenario B: a reckless player attacks a monster. When the monster hits the player, the combat message is currently prefixed with Recklessness!, since the monster received a damage bonus from the player being in reckless mode. Should this message only have been sent if the attacker was in reckless mode? | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3074/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
800971195 | MDExOlB1bGxSZXF1ZXN0NTY3MzY3ODM0 | 3446 | Add support for servers to periodically communicate with external services | amoeba 563 | open | 0 | 4 | 2021-02-04T06:18:53Z | 2021-02-09T00:23:06Z | CONTRIBUTOR | 1 | ACEmulator/ACE/pulls/3446 | Hey all, I was talking about something I've built with @LtRipley36706 the other day and he thought other devs would be interested in seeing a PR so here it is: It would be really interesting if ACE servers could communicate with external services. There's been a ton of discussion about _how_ to do this, going back to https://github.com/ACEmulator/ACE/issues/718. Providing an HTTP API is a really powerful idea but presents a ton of problems such as rate limiting, running read-only replicas of the database, and so on. A lighter weight and simpler approach is to have ACE servers _send_ any information to external services periodically. The biggest downside here is that the feature only works if the external service stays available. What I've done here is created a new `*Manager` class called `HeartbeatManager` that based on code that already existed in ACE that sends a JSON payload to a configurable HTTP endpoint at a configurable interval. Think [webhook](https://en.wikipedia.org/wiki/Webhook). The immediate thing ACE servers could do with this is broadcast whether the server is up and how many players are online to services such as https://treestats.net. People are very interested in how many players are on each server but the TreeStats way of tracking [server populations](https://treestats.net/player_counts/) requires players on each server to run my Decal plugin. And even then, the temporal resolution of the population data depends on how many players are running the plugin. With my system here, ACE servers could send their `OnlineCount` to TreeStats at intervals and we'd all have much better data to look at. Some notes: 1. This PR isn't done, I'm having some issues figuring out default values in the config 2. The payload is hardcoded to send `WorldName` and `OnlineCount` but I think we could find some easy way to let users configure the Manager to send more info such as any config properties (xp rate, pk/npk, etc) or even information obtained from database queries such as total characters. 3… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3446/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
841507292 | MDU6SXNzdWU4NDE1MDcyOTI= | 3511 | Composite bow handle mob doesnt spawn. | cloistere 78412023 | open | 0 | 1 | 2021-03-26T01:25:10Z | 2021-03-26T04:08:59Z | NONE | The mob which drops the exquisite composite bow handle does not spawn. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
894932214 | MDExOlB1bGxSZXF1ZXN0NjQ3MjIyNDU4 | 3547 | [TEST] add option to enable constraint manager on server | gmriggs 8909245 | open | 0 | 0 | 2021-05-19T02:37:30Z | 2021-06-10T23:05:04Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/3547 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3547/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||||
1227923647 | I_kwDOBLalGM5JMKC_ | 3841 | "You can only move or use one item at a time" - vendor bug | Schneebs 27392240 | open | 0 | 0 | 2022-05-06T14:14:23Z | 2022-05-06T14:14:23Z | CONTRIBUTOR | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ X ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. 1) get a char to max burden (I'm at 299%) where they cannot hold any more 2) open vendor 3) spam click buy prismatic tapers 4) try to move something (should be unable to move any item in inventory at this point) character remains busy until you buy the item it got stuck trying to buy ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3841/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
1323158799 | I_kwDOBLalGM5O3c0P | 3880 | Invisible players | fartwhif 3317737 | open | 0 | 1 | 2022-07-30T15:06:49Z | 2023-02-15T15:26:44Z | COLLABORATOR | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [ X ] bug report -> please search issues before submitting (searched) - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> unsure, after a while it starts happening and people have to relog to be seen and sometimes to see others. If someone has a reliable way to reproduce it that would be excellent. ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> the game and the server aren't exhibiting any additional information AFAIK ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> sometimes i can see a player but they can't see me, or vice versa. invisible player doesn't appear on radar either | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
1335207489 | PR_kwDOBLalGM48_Ppl | 3888 | Add audit trail to Destroy, TryRemoveFromInventory, TryDequipObject | LtRipley36706 11369233 | open | 0 | 0 | 2022-08-10T21:13:04Z | 2024-03-21T03:56:44Z | MEMBER | 1 | ACEmulator/ACE/pulls/3888 | This disables wieldable item deletion from database except upon startup orphan purge. PurgeOrphanedBiotas should be disabled to gather test data. This will consume GUIDs at a significantly higher rate as any item not deleted cannot be recycled | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3888/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
1509861293 | PR_kwDOBLalGM5GJaDH | 3944 | Server setting to enable substituting legendary key rewards emotes | Gordian3 1765994 | open | 0 | 4 | 2022-12-23T23:57:20Z | 2023-07-15T16:30:00Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/3944 | This PR provides a server setting "award_wcid_for_legendary" that allows for substitution of legendary keys with the provided WCID. For instance, a server offering legendary keys for sale on a vendor for 1 MMD per pull may set this to 20630. This allows players to not have to deal with large numbers of unstackable legendary keys from Kill Tasks and other quests. Another option would be Promissory Notes (43901). The server operator can provide any WCID but generally it would be something stackable. This change only impacts emote based giving. It does not change any looting of legendary keys from corpses or chests such as at the casinos. The default option is "0" which is interpreted as disabled so there is no substitution. The actual rewards to users depend a bit on how the quest emotes are configured. If they offer 5 rewards, each of 1 Aged Legendary Key, then the player would get 5 different of the substituted item. You can see this in the Tou Tou KTs. For Frozen Valley Gurog, it is a singe reward of multiple keys. In this case the new items (promissory notes in this case) are stacked. At Hoshino's the Durable keys become stacks of 10 of the item. ![AgedLegendaries_grp_5](https://user-images.githubusercontent.com/1765994/209414274-24b34a21-ab7f-4838-baeb-87143fe3fbd7.png) ![AgedLegendaries_grp_5_log](https://user-images.githubusercontent.com/1765994/209414281-f149e9c3-ebca-45df-8d93-a9afd0d24e03.png) ![DurableKey_subst_reward](https://user-images.githubusercontent.com/1765994/209414291-5aa9c23e-2d14-4c4f-9d55-b86dba5d88aa.png) ![DurableKey_subst_reward_log](https://user-images.githubusercontent.com/1765994/209414298-ef95ec1e-d45e-4011-89ae-6dad5529f34a.png) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3944/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
1533142831 | I_kwDOBLalGM5bYecv | 3950 | Abyssal Olthoi Chasm exit portal is not spawning at the bottom of the chasm. | Hermit-Lord 122661571 | open | 0 | 1 | 2023-01-14T05:19:45Z | 2023-08-18T02:30:23Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. Ascend to bottom of the Abyssal Olthoi Chasm to find that the exit portal is not spawning ### The log given by the failure. Normally this include a stack trace and some other information about the failure. ### Desired functionality. It would be nice to have the exit portal at the bottom of the Abyssal Olthoi Chasm so that you can leave the dungeon, like what you could do during retail. ### Mention any other details that might be useful. <!-- The exit portal is suppose to spawn in the middle of the back wall--> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3950/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
1586050584 | I_kwDOBLalGM5eiTYY | 3954 | Invisible Monsters | KevGenJr 90426958 | open | 0 | 0 | 2023-02-15T15:25:08Z | 2023-02-15T15:25:08Z | NONE | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [X ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. <!-- Please list the steps to reproduce a bug here --> Egg Orchard East > First Ramp Down [Right] || Abayar's Laboratory > Down Ramp > Left Side of Dungeon ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> No Log was triggered at time of occurrence. ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> All monsters should be visible. ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> I would like to be able to select the monster hitting me then hit it. I was not able to select the monster hitting me with mouse or keyboard keys. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3954/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | issue | ||||||||
2000580365 | PR_kwDOBLalGM5f06fz | 4059 | Switch to net8 | LtRipley36706 11369233 | open | 0 | 6 | 2023-11-18T21:07:00Z | 2024-04-05T17:20:38Z | MEMBER | 1 | ACEmulator/ACE/pulls/4059 | Switches net6 projects to net8 projects net6 LTS ends in one year per [https://dotnet.microsoft.com/en-us/platform/support/policy](https://dotnet.microsoft.com/en-us/platform/support/policy) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4059/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
2003188853 | PR_kwDOBLalGM5f9oh- | 4063 | Bump System.Text.Encoding.CodePages from 6.0.0 to 8.0.0 in /Source | dependabot[bot] 49699333 | open | 0 | 0 | 2023-11-20T23:33:23Z | 2023-12-21T19:00:08Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/4063 | Bumps [System.Text.Encoding.CodePages](https://github.com/dotnet/runtime) from 6.0.0 to 8.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dotnet/runtime/releases">System.Text.Encoding.CodePages's releases</a>.</em></p> <blockquote> <h2>.NET 8.0.0</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0">Release</a></p> <h2>.NET 8.0 RC 2</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-rc.2">Release</a></p> <h2>.NET 8.0 RC 1</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-rc.1">Release</a></p> <h2>.NET 8.0 Preview 7</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.7">Release</a></p> <h2>.NET 8.0 Preview 6</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.6">Release</a></p> <h2>.NET 8.0 Preview 5</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.5">Release</a></p> <h2>.NET 8.0 Preview 4</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.4">Release</a></p> <h2>.NET 8.0 Preview 3</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.3">Release</a></p> <h2>.NET 8.0 Preview 2</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.2">Release</a></p> <h2>.NET 8.0 Preview 1</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0-preview.1">Release</a></p> <h2>.NET 7.0.14</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v7.0.14">Release</a></p> <h2>What's Changed</h2> <ul> <li>[release/7.0-staging] Check for <!-- raw HTML omitted -->.deps.json when enumerating framework paths by <a href="https://github.com/elinor-fung"><code>@elinor-fung</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92033">dotnet/runtime#92033</a></li> <li>[release/7.0] Update Ubuntu 16.04 amd64 queues to 22.04 by <a href="https://github.com/carlossanlop"><code>@carlossanlop</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92796">dotnet/runtime… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4063/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
2133300485 | PR_kwDOBLalGM5mzdf8 | 4111 | Use a non buffering partioner for Parallel.ForEach | Mag-nus 10608427 | open | 0 | 0 | 2024-02-13T23:31:19Z | 2024-03-13T02:47:39Z | MEMBER | 0 | ACEmulator/ACE/pulls/4111 | No idea if this will help or hurt high load servers like CE | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4111/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
2141133016 | PR_kwDOBLalGM5nOQnW | 4114 | Encounter Adjustments | LtRipley36706 11369233 | open | 0 | 0 | 2024-02-18T18:43:08Z | 2024-02-25T19:08:01Z | MEMBER | 1 | ACEmulator/ACE/pulls/4114 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||||
2143271807 | PR_kwDOBLalGM5nVibU | 4115 | Bump dotnet/sdk from 6.0 to 8.0.101 | dependabot[bot] 49699333 | open | 0 | 0 | 2024-02-19T23:13:39Z | 2024-02-19T23:13:50Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/4115 | Bumps dotnet/sdk from 6.0 to 8.0.101. <details> <summary>Most Recent Ignore Conditions Applied to This Pull Request</summary> | Dependency Name | Ignore Conditions | | --- | --- | | dotnet/sdk | [>= 7.a, < 8] | </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dotnet/sdk&package-manager=docker&previous-version=6.0&new-version=8.0.101)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop D… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4115/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
2187733412 | PR_kwDOBLalGM5ptFxu | 4130 | Bump System.Drawing.Common from 6.0.0 to 8.0.3 in /Source | dependabot[bot] 49699333 | open | 0 | 0 | 2024-03-15T05:07:48Z | 2024-03-26T04:31:44Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/4130 | [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=System.Drawing.Common&package-manager=nuget&previous-version=6.0.0&new-version=8.0.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4130/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
2193665606 | PR_kwDOBLalGM5qBUFi | 4135 | Bump System.Text.Json from 6.0.9 to 8.0.3 in /Source | dependabot[bot] 49699333 | open | 0 | 0 | 2024-03-18T23:32:22Z | 2024-03-18T23:32:33Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/4135 | Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 6.0.9 to 8.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dotnet/runtime/releases">System.Text.Json's releases</a>.</em></p> <blockquote> <h2>.NET 8.0.3</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.3">Release</a></p> <h2>.NET 8.0.2</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.2">Release</a></p> <h2>.NET 8.0.1</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.1">Release</a></p> <h2>.NET 8.0.0</h2> <p><a href="https://github.com/dotnet/core/releases/tag/v8.0.0">Release</a></p> <h2>What's Changed</h2> <ul> <li>[release/8.0-rc1] [release/8.0] Events for IL methods without IL headers by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92317">dotnet/runtime#92317</a></li> <li>[release/8.0] Update dependencies from dotnet/source-build-externals by <a href="https://github.com/dotnet-maestro"><code>@dotnet-maestro</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92340">dotnet/runtime#92340</a></li> <li>[release/8.0-rc1] [release/8.0] Fix wasi build. by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92368">dotnet/runtime#92368</a></li> <li>[automated] Merge branch 'release/8.0-rc2' => 'release/8.0' by <a href="https://github.com/dotnet-maestro-bot"><code>@dotnet-maestro-bot</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92325">dotnet/runtime#92325</a></li> <li>[release/8.0] Update dependencies from dotnet/roslyn by <a href="https://github.com/dotnet-maestro"><code>@dotnet-maestro</code></a> in <a href="https://redirect.github.com/dotnet/runtime/pull/92303">dotnet/runtime#92303</a></li> <li>[automated] Merge branch 'release/8.0-rc1' => 'release/8.0' by <a href="https://github.com/dotnet-maestro-bot"><code>@dotnet-maestro-bo… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4135/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
2196544788 | PR_kwDOBLalGM5qK1r4 | 4136 | Crude periodic GC | Mag-nus 10608427 | open | 0 | 0 | 2024-03-20T02:20:57Z | 2024-03-24T14:30:48Z | MEMBER | 0 | ACEmulator/ACE/pulls/4136 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||||
2197965378 | PR_kwDOBLalGM5qPrMF | 4137 | Add option for unlimited GUID sequence gaps | LtRipley36706 11369233 | open | 0 | 1 | 2024-03-20T16:22:37Z | 2024-03-24T12:45:12Z | MEMBER | 0 | ACEmulator/ACE/pulls/4137 | This allows servers to load *all* possible GUID sequence gaps instead of hard coded limit of 10,000,000. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4137/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
202877062 | MDExOlB1bGxSZXF1ZXN0MTAyOTU5MDg1 | 1 | Updates to database and underlying code | xanxin887 6705011 | closed | 0 | 0 | 2017-01-24T16:55:13Z | 2017-01-24T18:24:10Z | 2017-01-24T18:24:10Z | NONE | 0 | ACEmulator/ACE/pulls/1 | Updates to database and underlying code | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
202908658 | MDExOlB1bGxSZXF1ZXN0MTAyOTgxNDMw | 2 | Updates for DB 1/24/17 | xanxin887 6705011 | closed | 0 | 1 | 2017-01-24T18:58:40Z | 2017-02-01T12:50:46Z | 2017-02-01T12:50:46Z | NONE | 0 | ACEmulator/ACE/pulls/2 | Updates for DB to prep for creating associated tables | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
204670023 | MDExOlB1bGxSZXF1ZXN0MTA0MTk2NjM1 | 10 | Client and Server expects account in ace_auth to be lowercase only. | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-01T18:45:44Z | 2017-02-02T16:36:57Z | 2017-02-02T16:36:53Z | MEMBER | 0 | ACEmulator/ACE/pulls/10 | This is my first pull request, please let me know if I'm doing this incorrectly. Simple change I made to the accountcreate command to correct and prevent the issue I experienced when setting up ACE. The client always sends accounts as lowercase regardless of what the user types in the command line. The server itself resolves the difference and connects as well. The issue surfaces when attempting to create a character. That packet is sent, but no response is ever recv'd. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/10/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
204803198 | MDExOlB1bGxSZXF1ZXN0MTA0Mjg4NDkw | 11 | Run faster, jump higher, teleport to coordinates (rather than XYZ position) | sbaum23 22650655 | closed | 0 | 2 | 2017-02-02T07:42:55Z | 2017-02-03T20:59:39Z | 2017-02-03T20:59:39Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/11 | These values are hardcoded and need to be replaced with actual values from the Player object. This is mainly to let people run around faster in the emu until code it put in to send all player skills to client. I'm Xen on Discord. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/11/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205077117 | MDExOlB1bGxSZXF1ZXN0MTA0NDc4ODUx | 13 | database layer encapsulation and abstraction | Mogwai-TheFurry 25351661 | closed | 0 | 1 | 2017-02-03T05:44:27Z | 2017-02-04T05:55:04Z | 2017-02-04T05:54:55Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/13 | Sorry about the solution file. I'm on VS 2015 pro and I've no idea why it changed. All I did was add the .gitignore as a solution item. Use Visual Studio to diff the files. Git isn't doing a good job with the compare. Mogwai in Discord. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/13/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205326043 | MDExOlB1bGxSZXF1ZXN0MTA0NjUwNTg2 | 16 | database abstraction and encapsulation. created character model and skill attribute models. | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-04T05:57:10Z | 2017-02-04T06:42:11Z | 2017-02-04T06:42:11Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/16 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/16/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
205328952 | MDExOlB1bGxSZXF1ZXN0MTA0NjUxOTE3 | 17 | database encapsulation is done! yay! | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-04T06:55:34Z | 2017-05-30T15:34:08Z | 2017-02-04T07:13:27Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/17 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/17/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
205362379 | MDExOlB1bGxSZXF1ZXN0MTA0NjY4ODA4 | 22 | Teleloc loader fix and basic set of locations | ChrisAikman 10677293 | closed | 0 | 0 | 2017-02-04T17:48:51Z | 2017-02-04T22:11:12Z | 2017-02-04T22:11:12Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/22 | Fixed an index bug in `WorldDatabase.GetLocations` and added a basic set of telelocations to the `teleport_location` table for use with `teleloc`. Updated the `teleloc` command to accept multiple name locations, such as `Ayan Baqur`. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/22/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205330194 | MDExOlB1bGxSZXF1ZXN0MTA0NjUyNjE0 | 18 | Option to Enable Automatic Account Creation | LtRipley36706 11369233 | closed | 0 | 2 | 2017-02-04T07:23:37Z | 2017-03-20T02:59:13Z | 2017-02-04T22:14:16Z | MEMBER | 0 | ACEmulator/ACE/pulls/18 | Added a configurable variable to Config.json for allowing the server to create an account for the client when one does not exist on the server. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/18/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205377812 | MDExOlB1bGxSZXF1ZXN0MTA0Njc1ODg4 | 23 | Add Config.json to .gitignore | zbuc 570040 | closed | 0 | 1 | 2017-02-04T21:12:57Z | 2017-02-04T22:53:44Z | 2017-02-04T22:53:44Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/23 | This also forces first-time configuration. Existing Config.json copied to Config.json.example README.md has been updated with instructions. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/23/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205379026 | MDExOlB1bGxSZXF1ZXN0MTA0Njc2NTYy | 24 | Fixed bug in CharacterCreate. | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-04T21:32:30Z | 2017-02-17T06:50:27Z | 2017-02-04T22:54:04Z | MEMBER | 0 | ACEmulator/ACE/pulls/24 | It was not changing the AccountId in the database when saving leading to empty character list. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/24/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205270553 | MDExOlB1bGxSZXF1ZXN0MTA0NjEyNDcz | 14 | Added /teleto command | sbaum23 22650655 | closed | 0 | 1 | 2017-02-03T21:12:15Z | 2017-02-05T02:21:27Z | 2017-02-05T02:21:27Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/14 | My commit has the wrong command in it. I added the /teleto command for teleporting using coordinates. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/14/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205383343 | MDExOlB1bGxSZXF1ZXN0MTA0Njc4NjAw | 27 | Corrected spelling in a few places. | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-04T22:36:04Z | 2017-02-05T03:35:03Z | 2017-02-05T03:35:03Z | MEMBER | 0 | ACEmulator/ACE/pulls/27 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/27/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
205389442 | MDU6SXNzdWUyMDUzODk0NDI= | 28 | Change way mysql databases are accessed | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-05T00:29:45Z | 2017-02-05T04:28:54Z | 2017-02-05T04:28:54Z | MEMBER | Should we be "internalizing" the connections to the mysql servers? Even with strong username/passwords is there as technical reason why we need to expose the sql server externally to the internet? | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/28/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
205398529 | MDExOlB1bGxSZXF1ZXN0MTA0Njg2Mzk3 | 30 | Fix for NAT issues on internal connections to WorldServer | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-05T03:53:57Z | 2017-03-10T04:56:23Z | 2017-02-05T05:37:01Z | MEMBER | 0 | ACEmulator/ACE/pulls/30 | This should help alleviate the issue some people will see when configuring all IPs to external, but connecting to the server on internal IPs. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/30/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205394658 | MDExOlB1bGxSZXF1ZXN0MTA0Njg0NDkw | 29 | Teleto command redo | sbaum23 22650655 | closed | 0 | 1 | 2017-02-05T02:20:42Z | 2017-02-05T06:01:09Z | 2017-02-05T06:01:09Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/29 | Fixed coding convention issues with my previous commit. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/29/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205381602 | MDExOlB1bGxSZXF1ZXN0MTA0Njc3ODA5 | 25 | Option to Enable Automatic Account Creation | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-04T22:11:38Z | 2017-03-20T02:59:21Z | 2017-02-05T08:52:58Z | MEMBER | 0 | ACEmulator/ACE/pulls/25 | Added a configurable variable to Config.json for allowing the server to create an account for the client when one does not exist on the server. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/25/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205381707 | MDExOlB1bGxSZXF1ZXN0MTA0Njc3ODY1 | 26 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-04T22:13:24Z | 2017-03-10T04:56:27Z | 2017-02-05T09:03:41Z | MEMBER | 0 | ACEmulator/ACE/pulls/26 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/26/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205403112 | MDExOlB1bGxSZXF1ZXN0MTA0Njg4NzM0 | 32 | Fix for NAT issues on internal connections to WorldServer | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-05T05:42:01Z | 2017-03-10T04:56:20Z | 2017-02-05T21:05:00Z | MEMBER | 0 | ACEmulator/ACE/pulls/32 | This fix is meant help alleviate a NAT issue some people will see when configuring server IP to external address. Due to problematic NAT routing, connecting to external IP while on internal network leads to black screen on hand-off to world server. Others may not even be able to connect to server using external IP address. This fix should allow for external IP connection for those outside of network, and internal IP connection for those inside the network. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/32/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205511450 | MDExOlB1bGxSZXF1ZXN0MTA0NzUxMzMx | 40 | Adding in support for teleportation via clicking on the map panel. | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-06T08:06:40Z | 2017-02-06T12:12:46Z | 2017-02-06T12:12:46Z | MEMBER | 0 | ACEmulator/ACE/pulls/40 | Go places faster! | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/40/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205404593 | MDExOlB1bGxSZXF1ZXN0MTA0Njg5NDQ3 | 33 | Added /teleto command | sbaum23 22650655 | closed | 0 | 0 | 2017-02-05T06:16:08Z | 2017-02-06T12:17:24Z | 2017-02-06T12:17:24Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/33 | Z position needs to be calculated from a file but since that isn't in the code yet, I'm defaulting it to 200. For some places that is not high enough and you'll be in darkness, but at least this allows you to teleport using coordinates. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/33/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205792049 | MDExOlB1bGxSZXF1ZXN0MTA0OTQwNjI2 | 47 | Load saved characters | Mogwai-TheFurry 25351661 | closed | 0 | 1 | 2017-02-07T05:43:40Z | 2017-05-30T15:34:10Z | 2017-02-07T16:49:01Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/47 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/47/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
205468852 | MDExOlB1bGxSZXF1ZXN0MTA0NzIzODky | 38 | Fix for server crash when account does not exist for connecting client | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-06T01:04:32Z | 2017-02-07T16:49:41Z | 2017-02-07T16:49:41Z | MEMBER | 0 | ACEmulator/ACE/pulls/38 | Please use this PR if rejecting PR #34. this contains the fix to the server crash when an account is not created and a client tried to connect to the server using the invalid account. this fix is already in PR #34 so if that one is accepted, reject this one. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/38/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205411721 | MDExOlB1bGxSZXF1ZXN0MTA0NjkyODU2 | 34 | Option to Enable Automatic Account Creation | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-05T08:52:31Z | 2017-03-20T02:59:43Z | 2017-02-07T17:42:22Z | MEMBER | 0 | ACEmulator/ACE/pulls/34 | Added a configurable variable to Config.json.example for allowing the server to create an account for the client when one does not already exist on the server. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/34/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
206401863 | MDExOlB1bGxSZXF1ZXN0MTA1MzU4NDQ2 | 50 | Spending XP in Abilities, Vitals, and Skills, Saving Property buckets… | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-09T04:35:43Z | 2017-05-30T15:34:11Z | 2017-02-10T18:44:23Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/50 | …. /grantxp command, moved persistence out of Player object for later refactoring of entity and data access project. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/50/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205882786 | MDU6SXNzdWUyMDU4ODI3ODY= | 49 | XP expenditure on skills/stats | Mogwai-TheFurry 25351661 | closed | 0 | Mogwai-TheFurry 25351661 | 1 | 2017-02-07T13:10:24Z | 2017-02-10T19:06:01Z | 2017-02-10T19:06:01Z | CONTRIBUTOR | Spend unused xp on skills/stats, save to database. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/49/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
205882576 | MDU6SXNzdWUyMDU4ODI1NzY= | 48 | Add all other properties to Character persistence model | Mogwai-TheFurry 25351661 | closed | 0 | Mogwai-TheFurry 25351661 | 1 | 2017-02-07T13:09:34Z | 2017-02-10T19:06:40Z | 2017-02-10T19:06:40Z | CONTRIBUTOR | All the other things that go in the property buckets. Read from client on char create (or not, as the augments should all be unset), save to the DB, and load them up on login. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/48/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
204489997 | MDU6SXNzdWUyMDQ0ODk5OTc= | 6 | Characters aren't saved or loaded properly yet from the DB | Mag-nus 10608427 | closed | 0 | TigrisOfGaul 25125434 | 4 | 2017-02-01T03:37:48Z | 2017-02-11T02:28:13Z | 2017-02-11T02:28:13Z | MEMBER | Per Rawaho. This needs looking into. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/6/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
205412246 | MDExOlB1bGxSZXF1ZXN0MTA0NjkzMTA4 | 35 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-05T09:03:13Z | 2017-03-10T04:56:13Z | 2017-02-11T05:46:23Z | MEMBER | 0 | ACEmulator/ACE/pulls/35 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json.example for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/35/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205742481 | MDExOlB1bGxSZXF1ZXN0MTA0OTA3NjM3 | 46 | Update create_mysql.sql | KochiroOfHG 25277356 | closed | 0 | 0 | 2017-02-06T23:46:04Z | 2017-02-12T11:36:42Z | 2017-02-12T11:36:42Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/46 | Added "IF NOT EXISTS" to the create statements so that if the database already exists then a warning will be thrown instead of an error. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/46/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
207414071 | MDExOlB1bGxSZXF1ZXN0MTA2MDMyNjEw | 61 | project separation and xp chart files | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-14T04:18:31Z | 2017-05-30T15:34:11Z | 2017-02-16T03:04:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/61 | implements #43 and also moves all that xp chart data into json files loaded behind a database interface. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/61/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
207544982 | MDExOlB1bGxSZXF1ZXN0MTA2MTI1NjQy | 62 | just adding stylecop as a style ruleset with very basic stuff | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-14T15:19:35Z | 2017-05-30T15:34:12Z | 2017-02-16T03:14:13Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/62 | the team can review the options and make changes as necessary. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/62/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
207255861 | MDExOlB1bGxSZXF1ZXN0MTA1OTE5NTYy | 60 | Added automation script for dropping and creating databases. | damnubber 4389226 | closed | 0 | 0 | 2017-02-13T15:46:59Z | 2017-02-16T03:16:56Z | 2017-02-16T03:16:56Z | NONE | 0 | ACEmulator/ACE/pulls/60 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/60/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
207021510 | MDExOlB1bGxSZXF1ZXN0MTA1Nzc1MjI4 | 59 | Handle setting title from client and updating title from server | LytelthorpeThistledown 25618389 | closed | 0 | 0 | 2017-02-12T01:28:07Z | 2017-02-16T03:21:35Z | 2017-02-16T03:21:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/59 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/59/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
208003996 | MDExOlB1bGxSZXF1ZXN0MTA2NDQ4MzI3 | 64 | fixing merge conflict | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-16T03:26:33Z | 2017-02-16T03:26:38Z | 2017-02-16T03:26:38Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/64 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/64/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
205645250 | MDU6SXNzdWUyMDU2NDUyNTA= | 43 | Move Database Access and object models to a separate C# project | Mogwai-TheFurry 25351661 | closed | 0 | Mogwai-TheFurry 25351661 | 2 | 2017-02-06T16:55:25Z | 2017-02-16T03:26:54Z | 2017-02-16T03:26:54Z | CONTRIBUTOR | for reuse in other components such as: * Item Editor * Vendor Editor * GLS replacment * other Server Admin tools | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/43/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
208004873 | MDExOlB1bGxSZXF1ZXN0MTA2NDQ4ODAw | 65 | copy config.json as build step | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-16T03:32:21Z | 2017-02-16T03:32:25Z | 2017-02-16T03:32:25Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/65 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/65/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
206960724 | MDExOlB1bGxSZXF1ZXN0MTA1NzQzMDQy | 57 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | closed | 0 | 2 | 2017-02-11T05:45:56Z | 2017-02-17T06:50:19Z | 2017-02-16T05:17:24Z | MEMBER | 0 | ACEmulator/ACE/pulls/57 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json.example for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/57/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
204490371 | MDU6SXNzdWUyMDQ0OTAzNzE= | 8 | Client Launcher needed | Mag-nus 10608427 | closed | 0 | 5 | 2017-02-01T03:41:07Z | 2017-02-16T21:49:46Z | 2017-02-16T21:49:40Z | MEMBER | We need a client launcher. Perhaps we use a modified thwarglauncher. https://thwarglauncher.codeplex.com/ For decal to work: "for emu, you should make a launcher that injects OR a shim client that loads the client and injects" "just stuff inject.dll in the process space early enough and it will do its thing" | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/8/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
208019575 | MDExOlB1bGxSZXF1ZXN0MTA2NDU2NjQz | 66 | Fixing up Character Delete and Restore functions | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-16T05:16:36Z | 2017-02-17T06:49:36Z | 2017-02-17T01:38:08Z | MEMBER | 0 | ACEmulator/ACE/pulls/66 | In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, character is marked deleted in database an hour after deleted from client via a server side SQL script running from event_scheduler. Later revisions to this code could address configuration variable(s) possibly in config.json.example for how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client, enable/disable this event check etc.. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/66/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
206410568 | MDExOlB1bGxSZXF1ZXN0MTA1MzYzMzQ2 | 55 | Stubbed CommandHandlers for known AdminCommands | LtRipley36706 11369233 | closed | 0 | 2 | 2017-02-09T05:41:21Z | 2017-02-17T06:50:21Z | 2017-02-17T06:30:40Z | MEMBER | 0 | ACEmulator/ACE/pulls/55 | Stubbed known admin commands with expected usage. not all could eventually be needed. Some could example output could also be expanded upon. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/55/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208349568 | MDExOlB1bGxSZXF1ZXN0MTA2Njc1NzU5 | 67 | Stubbed CommandHandlers for known AdminCommands | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-17T06:30:16Z | 2017-02-17T06:49:40Z | 2017-02-17T06:36:23Z | MEMBER | 0 | ACEmulator/ACE/pulls/67 | Stubbed known admin commands with expected usage. not all could eventually be needed. Some example output could also be expanded upon as needed. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/67/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208352404 | MDExOlB1bGxSZXF1ZXN0MTA2Njc3Mjcy | 68 | Fix for LoadCharacterProperties | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-17T06:47:15Z | 2017-02-17T06:49:45Z | 2017-02-17T06:47:29Z | MEMBER | 0 | ACEmulator/ACE/pulls/68 | The PropertiesBools doesn't always get set on character upon login, this change should correct that issue. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/68/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
206407101 | MDExOlB1bGxSZXF1ZXN0MTA1MzYxMzA3 | 54 | Added friends list functionality. | sbaum23 22650655 | closed | 0 | 1 | 2017-02-09T05:14:37Z | 2017-02-17T08:00:32Z | 2017-02-17T08:00:32Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/54 | Friends load from database on login and add/removing friends also saves to the db. When a friend logs on, the player should see the status change to online but it's hard to test that completely right now. Changing the status to offline when a friend logs off is not yet implemented. I had to implement a couple methods in WorldManager to be able to query for connected clients. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/54/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208542386 | MDExOlB1bGxSZXF1ZXN0MTA2ODAyODE1 | 70 | code cleanup, plus introduction of a couple new world object heirarchy types | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-17T20:06:05Z | 2017-05-30T15:34:17Z | 2017-02-17T20:20:43Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/70 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/70/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
208364550 | MDExOlB1bGxSZXF1ZXN0MTA2Njg0MzU2 | 69 | Friends List | sbaum23 22650655 | closed | 0 | 0 | 2017-02-17T07:58:52Z | 2017-02-18T04:38:34Z | 2017-02-18T04:38:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/69 | Adds the ability to add/remove friends as well as see the list of friends when you log on. The status is also accurate and will change as friends log on/off. I added a Logout method to the Player class for putting stuff in there that needs to be done when a player logs off (like sending a packet to all your online friends that you are offline). The extra commits are due to rebasing. This resolves issue #39. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/69/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205511107 | MDU6SXNzdWUyMDU1MTExMDc= | 39 | Friends list functionality | sbaum23 22650655 | closed | 0 | sbaum23 22650655 | 0 | 2017-02-06T08:04:22Z | 2017-02-18T04:46:34Z | 2017-02-18T04:46:34Z | CONTRIBUTOR | + Persist/read friends from db table + Send full friends list on login + Respond to Add friend client message + Respond to Remove friend client message Likely not able to add yet until multiplayer support added: + When player logs on or off, send friend status update to their friends. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/39/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
208612243 | MDExOlB1bGxSZXF1ZXN0MTA2ODQ4MTI1 | 71 | Issue 39 friends list | sbaum23 22650655 | closed | 0 | 0 | 2017-02-18T04:40:22Z | 2017-02-18T04:46:34Z | 2017-02-18T04:46:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/71 | Resolves #39 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/71/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208614354 | MDU6SXNzdWUyMDg2MTQzNTQ= | 72 | Additional Friends Commands and Appear Offline | sbaum23 22650655 | closed | 0 | sbaum23 22650655 | 0 | 2017-02-18T05:29:14Z | 2017-02-18T13:14:26Z | 2017-02-18T13:14:26Z | CONTRIBUTOR | Implement the following @friends commands: 1. @friends remove -all 2. @friends old (show a message that this command is no longer used) Also implement the "Appear Offline" option so that it shows you as offline to your friends. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/72/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
208624156 | MDExOlB1bGxSZXF1ZXN0MTA2ODUzNzQw | 74 | Implemented "/friends remove -all", "/friends old" and Appear Offline. | sbaum23 22650655 | closed | 0 | 0 | 2017-02-18T08:15:49Z | 2017-02-18T13:14:27Z | 2017-02-18T13:14:27Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/74 | /friends old just sends a chat packet saying that the command isn't used in the emu. I also had to fix a bug in two WorldManager methods that I added in an earlier PR. There was a scenario where the Session.Player was null and it was causing the LINQ query to throw an exception. Appear Offline is actually part of a GameAction that is used for setting many different options. The Handle method for it now just has a switch in it (there are ~52 options) for now but we may want to go to something else in the future as we add new features. Resolves #72 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/74/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208616825 | MDExOlB1bGxSZXF1ZXN0MTA2ODUwMjA5 | 73 | Network Refactor | Zegeger 12808515 | closed | 0 | 2 | 2017-02-18T06:02:43Z | 2017-02-18T15:08:24Z | 2017-02-18T15:08:24Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/73 | Created GameMessage class. Currently GameEvent inherits from GameMessage. GameMessage just build MemoryStream for message. Moved all opcodes that are outside of GameEvent in protocol over to be a GameMessage. Created some basic (test) functions in NetworkManager to send the GameMessages. Lots more to do, but this compiles and logs in successfully. Need to move group to per message property. Need to create per session packet queue. Need to rewrite packet pipe to better process multifragment packets. Need to finish testing multifragment packets and get working. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/73/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208651560 | MDExOlB1bGxSZXF1ZXN0MTA2ODY2ODY0 | 75 | Fixed update .sql file names to conform to documented standard. | Mag-nus 10608427 | closed | 0 | 0 | 2017-02-18T16:20:28Z | 2017-02-18T16:20:49Z | 2017-02-18T16:20:49Z | MEMBER | 0 | ACEmulator/ACE/pulls/75 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/75/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
208755889 | MDExOlB1bGxSZXF1ZXN0MTA2OTIyMTI5 | 78 | Chat enums added. Say/Tell work, but names not clickable. Network Mes… …sage framework cosmetic cleanups. | Mag-nus 10608427 | closed | 0 | 0 | 2017-02-19T23:26:00Z | 2017-02-19T23:27:05Z | 2017-02-19T23:27:04Z | MEMBER | 0 | ACEmulator/ACE/pulls/78 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/78/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
208701617 | MDExOlB1bGxSZXF1ZXN0MTA2ODkyMzg3 | 77 | Add AccessLevel to Accounts | LtRipley36706 11369233 | closed | 0 | 3 | 2017-02-19T07:51:49Z | 2017-02-20T05:30:22Z | 2017-02-20T05:09:09Z | MEMBER | 0 | ACEmulator/ACE/pulls/77 | This addresses issue #44 and also contains some of PR #58 rolled in. Of note, CommandManager will now respect AccessLevels specified where previously it didn't care. Set-AccountAccess will set the account's accesslevel Set-CharacterAccess will set the character's accesslevel CommandManager only cares about character's accesslevel as of this PR. Per discussion with @Mogwai-AC I think we should code up a SUDO like command which then references to Account's AccessLevel for privileges. This way we emulate how it seemed to work on AC live (per character) in addition to then allowing accounts to self-promote characters, as they did with the admin button on character creation, as well as other admin functions on non-admin characters. Probably something along the lines of "SUDO set-characteraccess [mynewcharacter] sentinel" which just does a check back to session.accesslevel. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/77/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
205646390 | MDU6SXNzdWUyMDU2NDYzOTA= | 44 | Add column to authenticationDB.account for access rights | LtRipley36706 11369233 | closed | 0 | LtRipley36706 11369233 | 3 | 2017-02-06T16:59:10Z | 2017-02-20T05:10:32Z | 2017-02-20T05:10:32Z | MEMBER | Need to add a column for access rights so to allow accounts to be able to create characters with IsAdmin or IsEnvoy bools set. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/44/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
208656503 | MDExOlB1bGxSZXF1ZXN0MTA2ODY5NjIw | 76 | Reworked Appear Offline functionality | sbaum23 22650655 | closed | 0 | 1 | 2017-02-18T17:33:27Z | 2017-02-20T05:17:46Z | 2017-02-20T05:17:46Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/76 | Reworked appear offline functionality so that it doesn't change IsOnline, which other things might depend on. Also fixed issue with sending friends list updates that was introduced with the network refactor merge. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/76/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
208787114 | MDExOlB1bGxSZXF1ZXN0MTA2OTQxODgz | 79 | Fixing changes to Fragment and Session. | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-20T05:27:58Z | 2017-02-20T05:30:11Z | 2017-02-20T05:28:12Z | MEMBER | 0 | ACEmulator/ACE/pulls/79 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/79/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
209030863 | MDExOlB1bGxSZXF1ZXN0MTA3MTA4NjM1 | 81 | Changed Find fn's in WorldManager from InWorld to IsOnline.. fixed pl… | Mag-nus 10608427 | closed | 0 | 0 | 2017-02-21T03:11:14Z | 2017-02-21T03:11:34Z | 2017-02-21T03:11:34Z | MEMBER | 0 | ACEmulator/ACE/pulls/81 | …ayer GUID, added GameEventDisplay events. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/81/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
209050525 | MDExOlB1bGxSZXF1ZXN0MTA3MTIyMjYx | 82 | Changed ParseCommand to support the use of quotes | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-21T06:06:33Z | 2017-02-27T15:07:24Z | 2017-02-21T12:31:10Z | MEMBER | 0 | ACEmulator/ACE/pulls/82 | This change allows any command to work with quotes to better delimit some parameters. An example of this would be for commands that require the use of a character name which has spaces in it such as Maia the Lawyer. The change results in the following command working as expected: set-characteraccess "maia the laywer" admin Another example this change would fix would be the eventual problem with teleto which it gets wired-up. Without the change, the command reads like teleto maia the laywer and would try to teleport to the character named maia instead of the full name. teleto "maia the lawyer" then corrects this issue and finds the right player. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/82/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
204506877 | MDU6SXNzdWUyMDQ1MDY4Nzc= | 9 | Rework packet pipe | Rawaho 6111341 | closed | 0 | 3 | 2017-02-01T06:26:07Z | 2017-02-21T12:34:45Z | 2017-02-21T12:34:45Z | CONTRIBUTOR | Rewrite packet and fragment handling to delay and allow for combining outgoing fragments. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/9/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
209752794 | MDExOlB1bGxSZXF1ZXN0MTA3NjE4MjA1 | 85 | Network Channels + Player Effect to Test @effect 20 | Forbiddenz 25387933 | closed | 0 | 0 | 2017-02-23T12:51:12Z | 2017-02-23T13:41:57Z | 2017-02-23T13:41:57Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/85 | Forgive my get newb.. I added a method of picking your channels on each message type.. Example of creating a message with channel can be found.. ``` public class GameMessageEffect : GameMessageOnChannel //using the ChannelMessages. //plays particle effect like spell casting or bleed etc.. public void PlayParticleEffect(uint effectid) { var effectevent = new GameMessageEffect(this.Guid, effectid); NetworkManager.SendWorldChannelMessages(Session, new GameMessageOnChannel[] { effectevent }); } ``` | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/85/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
209787790 | MDExOlB1bGxSZXF1ZXN0MTA3NjQyOTEy | 86 | Group chat code added. Chat channels are currently hard coded. Chat i… | Mag-nus 10608427 | closed | 0 | 0 | 2017-02-23T15:06:27Z | 2017-02-23T15:06:44Z | 2017-02-23T15:06:44Z | MEMBER | 0 | ACEmulator/ACE/pulls/86 | …s sent to all players, even if they aren't subscribed to a channel. Updated StatusMessageType enums. They need work still. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/86/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
209859327 | MDExOlB1bGxSZXF1ZXN0MTA3Njk0Nzcy | 87 | DO NOT MERGE - for reviewing work in progress only | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-02-23T19:27:26Z | 2017-02-24T02:57:35Z | 2017-02-24T02:57:35Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/87 | work in progress, committing for others to review | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/87/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
210208094 | MDExOlB1bGxSZXF1ZXN0MTA3OTQ1MDM1 | 88 | DDD stub code, AllegianceUpdate stub, IdentifyObject stub | Mag-nus 10608427 | closed | 0 | 0 | 2017-02-25T03:51:39Z | 2017-02-25T03:51:52Z | 2017-02-25T03:51:52Z | MEMBER | 0 | ACEmulator/ACE/pulls/88 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/88/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
210217121 | MDExOlB1bGxSZXF1ZXN0MTA3OTUwNDcz | 89 | Corrected Teleloc command to work with exact numbers | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-25T07:05:25Z | 2017-02-26T06:03:15Z | 2017-02-25T12:39:27Z | MEMBER | 0 | ACEmulator/ACE/pulls/89 | as provided by /loc command from client. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/89/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
210217148 | MDExOlB1bGxSZXF1ZXN0MTA3OTUwNDg4 | 90 | Rewrote network stack | Zegeger 12808515 | closed | 0 | 3 | 2017-02-25T07:06:09Z | 2017-02-27T11:28:37Z | 2017-02-27T11:28:37Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/90 | Rewrote network stack to support buffering messages and then dispatching as 1 or more combined or split packets. EncryptedChecksum seems to work across the board. Sending Packets with fragments from different groups does not seem to cause an issue. Packets are queued and sent based on calls from the Engine. Configurable delay (5ms currently) Reworked CachedPackets some, and now clear the list based on AckSeq packets from client. Sending AckSeq packets to the client seems to cause issues currently, need more testing. Moved some things around to fit this new model. Put message Group as a property on each message. And send this in fragment. Sounds now work again. Created new packet classes to encapsulate data in AuthenticationManager and CharacterManager and allow them to be send through the same model (though packets will never be manipulated). | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/90/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
210350061 | MDExOlB1bGxSZXF1ZXN0MTA4MDIyODE3 | 93 | Support easy permissions in ACEmulator | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-26T21:25:56Z | 2017-02-27T15:04:36Z | 2017-02-27T13:51:26Z | MEMBER | 0 | ACEmulator/ACE/pulls/93 | Improved best of both worlds scenario. Server operators have the choice to emulate access permissions via more complicated system used on official worlds or they can choose to use simplified account based permissions which would become the default install option for ACEmulator. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/93/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
210488807 | MDExOlB1bGxSZXF1ZXN0MTA4MTE3NjQw | 94 | Support easy permissions in ACEmulator | LtRipley36706 11369233 | closed | 0 | 0 | 2017-02-27T13:51:09Z | 2017-02-27T15:04:32Z | 2017-02-27T14:04:24Z | MEMBER | 0 | ACEmulator/ACE/pulls/94 | Improved best of both worlds scenario. Server operators have the choice to emulate access permissions via more complicated system used on official worlds or they can choose to use simplified account based permissions which would become the default install option for ACEmulator. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/94/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
210289130 | MDExOlB1bGxSZXF1ZXN0MTA3OTkyMTIw | 92 | Add in support for the old global Admin channels | LtRipley36706 11369233 | closed | 0 | 1 | 2017-02-26T06:00:53Z | 2017-02-27T15:04:42Z | 2017-02-27T14:38:23Z | MEMBER | 0 | ACEmulator/ACE/pulls/92 | Resurrected the various Admin global channels used by the Advocates, Sentinels, Envoys, and Admins, stubbed the @on and @off commands and added support for @index and @clist commands. Some TODOs have been put into the code for when we get a plan in place for for db loading/saving of channel subscriptions, as well as properly set subscriptions for that matter. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/92/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issues] ( [id] INTEGER PRIMARY KEY, [node_id] TEXT, [number] INTEGER, [title] TEXT, [user] INTEGER REFERENCES [users]([id]), [state] TEXT, [locked] INTEGER, [assignee] INTEGER REFERENCES [users]([id]), [milestone] INTEGER REFERENCES [milestones]([id]), [comments] INTEGER, [created_at] TEXT, [updated_at] TEXT, [closed_at] TEXT, [author_association] TEXT, [active_lock_reason] TEXT, [draft] INTEGER, [pull_request] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [state_reason] TEXT, [repo] INTEGER REFERENCES [repos]([id]), [type] TEXT ); CREATE INDEX [idx_issues_repo] ON [issues] ([repo]); CREATE INDEX [idx_issues_milestone] ON [issues] ([milestone]); CREATE INDEX [idx_issues_assignee] ON [issues] ([assignee]); CREATE INDEX [idx_issues_user] ON [issues] ([user]);