issues: 358397146
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
358397146 | MDExOlB1bGxSZXF1ZXN0MjE0MTU2NDY0 | 1006 | Revised pass at secure trade | 25518589 | closed | 0 | 0 | 2018-09-09T17:51:18Z | 2018-09-11T16:06:41Z | 2018-09-10T20:36:53Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1006 | This is an update to my previous PR where basic secure trade functionality was implemented. This PR does the following: - Verifies that trade partner is in range - Honors ignore all trade requests character option - Does not initiate when either party is in combat mode - Adds a few messages based on what I saw in retail PCAPs - Implemented GameEventDeclineTrade per PCAPs - Implements turn to when approaching trade partner Probably a few other minor tweaks. Again, sorry for all of the open and closing PR noise. Git and I are often not friends. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1006/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |