issues: 368245519
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
368245519 | MDExOlB1bGxSZXF1ZXN0MjIxNDY2NjEx | 1054 | Fix Landblock loading. Portaling collisions are now much more responsive | 10608427 | closed | 0 | 0 | 2018-10-09T14:40:13Z | 2018-10-09T23:54:53Z | 2018-10-09T20:53:10Z | MEMBER | 0 | ACEmulator/ACE/pulls/1054 | Before, landblocks were loading all their assets in the ctor on the same thread. Now, we off-load that loading onto separate threads and use an actionQueue to perform the resulting work in the landblock Tick. Cleaned up the IsTeleporting flag. This should only be set/managed by the function that actually does the teleportation. NetworkSession has timers that control how often we send messages to the client. The check was > but should have been >=. If an end-user wants to set a time of 0, > would not have worked. Removed undeveloped/legacy LandBlockStatus code. This was used for our WinForms diagnostics app. We can redevelop this for the current state of ACE in the future if/when we have a diagnostics API. Fixed a crash in EmoteManager from player being null (after teleportation) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1054/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |