issues: 365092685
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
365092685 | MDExOlB1bGxSZXF1ZXN0MjE5MTIyNTkz | 1031 | PlayerFactory | 10608427 | closed | 0 | 1 | 2018-09-29T03:36:27Z | 2018-10-01T14:23:46Z | 2018-10-01T14:23:09Z | MEMBER | 0 | ACEmulator/ACE/pulls/1031 | Player/Character creation has been pulled out of CharacterHandler and added to a new PlayerFactory. PlayerFactory includes a Create275HeavyWeapons function to help with load testing. SpendAllXp has been added to Player_Xp.cs. A command handler can be added to allow use of this feature from in-game. SpendAttributeXp, SpendVitalXp and SpendSkillXp no longer perform the work unless SpendXp was successful. Player ctor from weenie no longer takes a Session object. Instead, only the AccountId is passed. This allows player creation without needing a session. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1031/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |