issue_comments
Data license: AGPL · Data source: ACEmulator Project
1,646 rows
This data as json, CSV (advanced)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
285880346 | https://github.com/ACEmulator/ACE/issues/53#issuecomment-285880346 | https://api.github.com/repos/ACEmulator/ACE/issues/53 | MDEyOklzc3VlQ29tbWVudDI4NTg4MDM0Ng== | fantoms 37453 | 2017-03-11T16:52:00Z | 2017-03-11T16:52:00Z | CONTRIBUTOR | Added skill credits and ability to grant Skill credits on level up, in Pull Request #119. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill Credits: saving, loading, spending 206403348 | |
285907205 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285907205 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkwNzIwNQ== | Mag-nus 10608427 | 2017-03-11T22:59:59Z | 2017-03-11T22:59:59Z | MEMBER | Is this a modified version of mogwais code? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285913728 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285913728 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkxMzcyOA== | lurker-mcdoogle 26334665 | 2017-03-12T01:18:42Z | 2017-03-12T01:18:42Z | CONTRIBUTOR | no, he was talking about event systems of some sort. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285913800 | https://github.com/ACEmulator/ACE/pull/119#issuecomment-285913800 | https://api.github.com/repos/ACEmulator/ACE/issues/119 | MDEyOklzc3VlQ29tbWVudDI4NTkxMzgwMA== | fantoms 37453 | 2017-03-12T01:20:16Z | 2017-03-12T05:23:25Z | CONTRIBUTOR | -Added the max level effect -Moved the effects to after the level-up network message sequence -I believe made the /grantxp now command work properly. Please let me know if this is correct: There was an issue where the max xp was not locking to Infinity, so I had to add another GrantXp command to add Additional XP for skill leveling, for after max level is achieved. -Moved the available credit update to the end so it doesn't spam the message until all credits are achieved, this fixed a bug I added. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Level up on xp change, PropertyInt Message Types and skill credits 213538178 | |
285917933 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285917933 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkxNzkzMw== | lurker-mcdoogle 26334665 | 2017-03-12T02:54:11Z | 2017-03-12T02:54:11Z | CONTRIBUTOR | Updated with: 1) basic object factories 2) log4net - not having console output was killing me and we needed a logging framework anyway. nuget to the rescue. 3) moved "in front of" calculations to hang off the Position object for better reuse 4) fixed various landblock object cache bugs 5) added even more // TODO | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285923241 | https://github.com/ACEmulator/ACE/pull/119#issuecomment-285923241 | https://api.github.com/repos/ACEmulator/ACE/issues/119 | MDEyOklzc3VlQ29tbWVudDI4NTkyMzI0MQ== | fantoms 37453 | 2017-03-12T05:20:00Z | 2017-03-12T05:20:00Z | CONTRIBUTOR | Known issue: No formal name or label on skills. Examples: "VoidMagic" or "SneakAttack". | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Level up on xp change, PropertyInt Message Types and skill credits 213538178 | |
285928441 | https://github.com/ACEmulator/ACE/pull/117#issuecomment-285928441 | https://api.github.com/repos/ACEmulator/ACE/issues/117 | MDEyOklzc3VlQ29tbWVudDI4NTkyODQ0MQ== | LtRipley36706 11369233 | 2017-03-12T07:49:11Z | 2017-03-12T07:49:11Z | MEMBER | Working on a few changes | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Marketplace Recall + some other changes 213281968 | |
285936751 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285936751 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkzNjc1MQ== | Mag-nus 10608427 | 2017-03-12T10:53:22Z | 2017-03-12T10:53:22Z | MEMBER | Ahh ok. I'll have to review this today. Talking with mogwai in private, his initial plan was event based, but it didn't pan out, so he scrapped that and was working on a different system, so I wasn't sure if this was that. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285966645 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285966645 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk2NjY0NQ== | Mag-nus 10608427 | 2017-03-12T19:04:57Z | 2017-03-12T19:04:57Z | MEMBER | I loaded this up. Broadcasting works which is nice. Seems to be a bit of client and server instability issues though. Will have to look at it more in depth. Also, it would be cleaner to review if the log4net changes weren't combined with the landblock code. Landblock management is already complex enough. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285994516 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285994516 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk5NDUxNg== | lurker-mcdoogle 26334665 | 2017-03-13T01:18:29Z | 2017-03-13T01:18:29Z | CONTRIBUTOR | I can gut the log4net stuff if you want, but I couldn't have debugged this without it. Either way. And yeah, I had stability issues as well, but it wasn't anything consistently reproducible. There was a comment about the update having to be sent after the client entered portal space, but I didn't do anything explicit to account for it. Let me know if you find anything specific. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285997814 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285997814 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk5NzgxNA== | Mag-nus 10608427 | 2017-03-13T01:53:40Z | 2017-03-13T01:53:40Z | MEMBER | At this point, might as well keep the log4net in there. It makes sense moving forward, and no sense in duplicating the work later. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285998186 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285998186 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk5ODE4Ng== | lurker-mcdoogle 26334665 | 2017-03-13T01:57:25Z | 2017-03-13T01:57:25Z | CONTRIBUTOR | Merge conflicts now. Closing - will rebase when i can. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
286009596 | https://github.com/ACEmulator/ACE/pull/117#issuecomment-286009596 | https://api.github.com/repos/ACEmulator/ACE/issues/117 | MDEyOklzc3VlQ29tbWVudDI4NjAwOTU5Ng== | LtRipley36706 11369233 | 2017-03-13T03:48:59Z | 2017-03-13T03:48:59Z | MEMBER | moving stuff around and redoing PR | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Marketplace Recall + some other changes 213281968 | |
286120297 | https://github.com/ACEmulator/ACE/issues/19#issuecomment-286120297 | https://api.github.com/repos/ACEmulator/ACE/issues/19 | MDEyOklzc3VlQ29tbWVudDI4NjEyMDI5Nw== | Mag-nus 10608427 | 2017-03-13T14:18:26Z | 2017-03-13T14:18:26Z | MEMBER | Still need to add the movement event that gets sent to the client putting the client in the logoff animation. Hopefully this stops the sounds from continuing through to character selection screen. Also need to broadcast the event to others. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Support logging off to the character selection screen. 205346915 | |
286124129 | https://github.com/ACEmulator/ACE/issues/51#issuecomment-286124129 | https://api.github.com/repos/ACEmulator/ACE/issues/51 | MDEyOklzc3VlQ29tbWVudDI4NjEyNDEyOQ== | fantoms 37453 | 2017-03-13T14:30:57Z | 2017-03-13T14:30:57Z | CONTRIBUTOR | A small portion of saving the character is available in Pull Request #125, as it will save the character properties to the database. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Saving a Character to the DB 206403228 | |
286517825 | https://github.com/ACEmulator/ACE/pull/126#issuecomment-286517825 | https://api.github.com/repos/ACEmulator/ACE/issues/126 | MDEyOklzc3VlQ29tbWVudDI4NjUxNzgyNQ== | lurker-mcdoogle 26334665 | 2017-03-14T18:32:43Z | 2017-03-14T18:32:43Z | CONTRIBUTOR | Reopening with squashed commits. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | improved dat file content exporting 213875928 | |
286959999 | https://github.com/ACEmulator/ACE/pull/131#issuecomment-286959999 | https://api.github.com/repos/ACEmulator/ACE/issues/131 | MDEyOklzc3VlQ29tbWVudDI4Njk1OTk5OQ== | ogmage78 25460553 | 2017-03-16T05:13:40Z | 2017-03-16T05:13:40Z | CONTRIBUTOR | I think I did something wrong. Going to close this for now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Create Training Wand 214596925 | |
287145676 | https://github.com/ACEmulator/ACE/pull/136#issuecomment-287145676 | https://api.github.com/repos/ACEmulator/ACE/issues/136 | MDEyOklzc3VlQ29tbWVudDI4NzE0NTY3Ng== | ogmage78 25460553 | 2017-03-16T18:13:36Z | 2017-03-16T18:13:36Z | CONTRIBUTOR | Ok - thanks for checking it out. I had to get a toe wet somehow ... ;) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Create Training Wand - Demo work for item creation. 214781043 | |
287150964 | https://github.com/ACEmulator/ACE/pull/137#issuecomment-287150964 | https://api.github.com/repos/ACEmulator/ACE/issues/137 | MDEyOklzc3VlQ29tbWVudDI4NzE1MDk2NA== | Forbiddenz 25387933 | 2017-03-16T18:32:12Z | 2017-03-16T18:32:12Z | CONTRIBUTOR | Cleaned up | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World object fixes 214784803 | |
287152244 | https://github.com/ACEmulator/ACE/pull/137#issuecomment-287152244 | https://api.github.com/repos/ACEmulator/ACE/issues/137 | MDEyOklzc3VlQ29tbWVudDI4NzE1MjI0NA== | Mogwai-TheFurry 25351661 | 2017-03-16T18:36:49Z | 2017-03-16T18:36:49Z | CONTRIBUTOR | MutableWorldObject xml doc header.... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World object fixes 214784803 | |
287183202 | https://github.com/ACEmulator/ACE/pull/125#issuecomment-287183202 | https://api.github.com/repos/ACEmulator/ACE/issues/125 | MDEyOklzc3VlQ29tbWVudDI4NzE4MzIwMg== | fantoms 37453 | 2017-03-16T20:35:43Z | 2017-03-16T20:35:43Z | CONTRIBUTOR | Network Conflicts resolved. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Save Player Properties to db 213680800 | |
287223448 | https://github.com/ACEmulator/ACE/pull/136#issuecomment-287223448 | https://api.github.com/repos/ACEmulator/ACE/issues/136 | MDEyOklzc3VlQ29tbWVudDI4NzIyMzQ0OA== | ogmage78 25460553 | 2017-03-16T23:29:38Z | 2017-03-16T23:29:38Z | CONTRIBUTOR | Closing and resubmitting | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Create Training Wand - Demo work for item creation. 214781043 | |
287223477 | https://github.com/ACEmulator/ACE/pull/136#issuecomment-287223477 | https://api.github.com/repos/ACEmulator/ACE/issues/136 | MDEyOklzc3VlQ29tbWVudDI4NzIyMzQ3Nw== | ogmage78 25460553 | 2017-03-16T23:29:47Z | 2017-03-16T23:29:47Z | CONTRIBUTOR | Closing and resubmitting | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Create Training Wand - Demo work for item creation. 214781043 | |
287252812 | https://github.com/ACEmulator/ACE/pull/121#issuecomment-287252812 | https://api.github.com/repos/ACEmulator/ACE/issues/121 | MDEyOklzc3VlQ29tbWVudDI4NzI1MjgxMg== | lurker-mcdoogle 26334665 | 2017-03-17T02:51:34Z | 2017-03-17T02:51:34Z | CONTRIBUTOR | Known Issue: Adjacency matrix has issues broadcasting to the correct adjacencies. Shouldn't be a big deal - I'll fix it later. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks, logging, object factory prep work 213657914 | |
287511136 | https://github.com/ACEmulator/ACE/pull/121#issuecomment-287511136 | https://api.github.com/repos/ACEmulator/ACE/issues/121 | MDEyOklzc3VlQ29tbWVudDI4NzUxMTEzNg== | Mag-nus 10608427 | 2017-03-18T02:44:38Z | 2017-03-18T02:44:38Z | MEMBER | Landblock.cs, line 289. Needs to be changed from > to >= movedObjects = movedObjects.Where(p => p.LastUpdatedTicks > p.LastMovementBroadcastTicks).ToList(); // flag them as updated now in order to reduce chance of missing an update movedObjects.ForEach(m => m.LastMovementBroadcastTicks = WorldManager.PortalYearTicks); What's happening is a player is moving on the same PortalYearTick, right before Landblock.UseTime is called. When this happens, the > fails, and the cobject isn't processed as a move. That move gets skipped over. Even though you set the LastMove to PortalYearTicks to indicate the object as processed, the next time UseTime is called, it's impossible for PortalYearTicks to have the same value as the previous call, thus, the >= won't be called in duplicate/error. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks, logging, object factory prep work 213657914 | |
287548109 | https://github.com/ACEmulator/ACE/pull/119#issuecomment-287548109 | https://api.github.com/repos/ACEmulator/ACE/issues/119 | MDEyOklzc3VlQ29tbWVudDI4NzU0ODEwOQ== | fantoms 37453 | 2017-03-18T13:59:42Z | 2017-03-18T13:59:42Z | CONTRIBUTOR | Closing now, this was merged into PR #141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Level up on xp change, PropertyInt Message Types and skill credits 213538178 | |
287548140 | https://github.com/ACEmulator/ACE/pull/125#issuecomment-287548140 | https://api.github.com/repos/ACEmulator/ACE/issues/125 | MDEyOklzc3VlQ29tbWVudDI4NzU0ODE0MA== | fantoms 37453 | 2017-03-18T14:00:13Z | 2017-03-18T14:00:13Z | CONTRIBUTOR | Closing now, this was merged into PR #141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Save Player Properties to db 213680800 | |
287548162 | https://github.com/ACEmulator/ACE/pull/134#issuecomment-287548162 | https://api.github.com/repos/ACEmulator/ACE/issues/134 | MDEyOklzc3VlQ29tbWVudDI4NzU0ODE2Mg== | fantoms 37453 | 2017-03-18T14:00:37Z | 2017-03-18T14:00:37Z | CONTRIBUTOR | Closing now, since this was merged into PR #141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added attribute upper bounds check and max attribute fireworks and special text 214728678 | |
287548276 | https://github.com/ACEmulator/ACE/pull/121#issuecomment-287548276 | https://api.github.com/repos/ACEmulator/ACE/issues/121 | MDEyOklzc3VlQ29tbWVudDI4NzU0ODI3Ng== | Mag-nus 10608427 | 2017-03-18T14:02:39Z | 2017-03-18T14:02:39Z | MEMBER | Landblock.cs UseTime() needs a Thread.Sleep(1) as the last line of the While() loop. We also have variables that are being referenced across multiple threads. WorldObject.LastUpdateTicks and MutableWorldObject.LastMovementBroadcastTicks... I'm gonna think about this some more today. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks, logging, object factory prep work 213657914 | |
287569603 | https://github.com/ACEmulator/ACE/pull/141#issuecomment-287569603 | https://api.github.com/repos/ACEmulator/ACE/issues/141 | MDEyOklzc3VlQ29tbWVudDI4NzU2OTYwMw== | LtRipley36706 11369233 | 2017-03-18T19:40:04Z | 2017-03-18T19:40:04Z | MEMBER | I broke this PR in an attempt to rebase off of current master.. My git-fu needs improvement. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Saving Character to Database 215172361 | |
287586760 | https://github.com/ACEmulator/ACE/issues/53#issuecomment-287586760 | https://api.github.com/repos/ACEmulator/ACE/issues/53 | MDEyOklzc3VlQ29tbWVudDI4NzU4Njc2MA== | fantoms 37453 | 2017-03-19T01:10:40Z | 2017-03-19T01:10:40Z | CONTRIBUTOR | If PR #143 gets accepted, then I have a follow-up PR that will allow skill credits to be spent. I've already tested the code and it should allow for skill credit spending, saving, and loading. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill Credits: saving, loading, spending 206403348 | |
287591909 | https://github.com/ACEmulator/ACE/pull/146#issuecomment-287591909 | https://api.github.com/repos/ACEmulator/ACE/issues/146 | MDEyOklzc3VlQ29tbWVudDI4NzU5MTkwOQ== | ogmage78 25460553 | 2017-03-19T03:37:25Z | 2017-03-19T03:37:25Z | CONTRIBUTOR | Jesus - I tried to squash it down to 1 commit and it went from 7 to 9. I will get git - but damn it is kicking my ass right now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Create Training Wand Demo code and start inventory management Drop/Equip/pickup 215238775 | |
287667143 | https://github.com/ACEmulator/ACE/pull/148#issuecomment-287667143 | https://api.github.com/repos/ACEmulator/ACE/issues/148 | MDEyOklzc3VlQ29tbWVudDI4NzY2NzE0Mw== | Mogwai-TheFurry 25351661 | 2017-03-20T02:13:35Z | 2017-03-20T02:13:35Z | CONTRIBUTOR | So, here's the thing... Devs that know what to do with Docker don't need this - we can run scripts just fine. Players that want to host their own servers don't even have a clue what Docker is. Plus, you're linking to a docker image offsite that we can't control. We don't think this is necessary, but in the end we might host a db image on acemulator.org when we cut releases. I just don't think we're at a point where this is needed. Thanks! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add a link to ace-db docker image in the README 215282644 | |
287667649 | https://github.com/ACEmulator/ACE/pull/21#issuecomment-287667649 | https://api.github.com/repos/ACEmulator/ACE/issues/21 | MDEyOklzc3VlQ29tbWVudDI4NzY2NzY0OQ== | Mogwai-TheFurry 25351661 | 2017-03-20T02:20:14Z | 2017-03-20T02:20:14Z | CONTRIBUTOR | closing due to being outdated plus inability to merge. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change password hashing to use scrypt 205361124 | |
287670049 | https://github.com/ACEmulator/ACE/issues/51#issuecomment-287670049 | https://api.github.com/repos/ACEmulator/ACE/issues/51 | MDEyOklzc3VlQ29tbWVudDI4NzY3MDA0OQ== | LtRipley36706 11369233 | 2017-03-20T02:53:25Z | 2017-03-20T02:53:25Z | MEMBER | Saving intermittently and on logout is in. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Saving a Character to the DB 206403228 | |
287670070 | https://github.com/ACEmulator/ACE/pull/148#issuecomment-287670070 | https://api.github.com/repos/ACEmulator/ACE/issues/148 | MDEyOklzc3VlQ29tbWVudDI4NzY3MDA3MA== | maxc0c0s 8466632 | 2017-03-20T02:53:36Z | 2017-03-20T02:53:36Z | NONE | No problem, Since i'm using it, i thought maybe you guys might find it useful. I'll find other way to contribute :) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add a link to ace-db docker image in the README 215282644 | |
287670094 | https://github.com/ACEmulator/ACE/issues/52#issuecomment-287670094 | https://api.github.com/repos/ACEmulator/ACE/issues/52 | MDEyOklzc3VlQ29tbWVudDI4NzY3MDA5NA== | LtRipley36706 11369233 | 2017-03-20T02:54:03Z | 2017-03-20T02:54:03Z | MEMBER | @fantoms completed this and it was merged in. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Leveling up when granted xp 206403292 | |
287852886 | https://github.com/ACEmulator/ACE/pull/156#issuecomment-287852886 | https://api.github.com/repos/ACEmulator/ACE/issues/156 | MDEyOklzc3VlQ29tbWVudDI4Nzg1Mjg4Ng== | fantoms 37453 | 2017-03-20T18:23:52Z | 2017-03-20T18:23:52Z | CONTRIBUTOR | Tested this utilizing multiple characters and passes were successful. Aside from this code, your command really helps points out the bug/non-issue in the client, where your total health is greater than the actual health - Example - In-game action sequence after Spending one rank up, for endurance (Total 61): 1. Health Total: `1/31` 2. type: `@heal` 3. Health Total: `30/31` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Heal: Update Player object, then send its data 215484872 | |
287964793 | https://github.com/ACEmulator/ACE/pull/148#issuecomment-287964793 | https://api.github.com/repos/ACEmulator/ACE/issues/148 | MDEyOklzc3VlQ29tbWVudDI4Nzk2NDc5Mw== | Gordian3 1765994 | 2017-03-21T03:14:49Z | 2017-03-21T03:14:49Z | CONTRIBUTOR | If we had the actual source and wanted to move it away from SQL Server and Windows Server, then deploying each piece (Database, GLS, etc) in a docker would have provided a great way to link all of the components. Then have a VM OVF/OVA with CentOS or similar OS and have it load the dockers would have been a decent deployment model. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add a link to ace-db docker image in the README 215282644 | |
288315607 | https://github.com/ACEmulator/ACE/pull/163#issuecomment-288315607 | https://api.github.com/repos/ACEmulator/ACE/issues/163 | MDEyOklzc3VlQ29tbWVudDI4ODMxNTYwNw== | LtRipley36706 11369233 | 2017-03-22T07:05:10Z | 2017-03-22T07:05:10Z | MEMBER | Now, really, all good here 👍 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Support for specific server host binding 215964624 | |
288825995 | https://github.com/ACEmulator/ACE/pull/167#issuecomment-288825995 | https://api.github.com/repos/ACEmulator/ACE/issues/167 | MDEyOklzc3VlQ29tbWVudDI4ODgyNTk5NQ== | LtRipley36706 11369233 | 2017-03-23T18:56:54Z | 2017-03-23T18:56:54Z | MEMBER | Client currently crashes when the db objects are sent to it... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | weenies weenies everywhere. object structure pass for review. 216282064 | |
289094900 | https://github.com/ACEmulator/ACE/pull/167#issuecomment-289094900 | https://api.github.com/repos/ACEmulator/ACE/issues/167 | MDEyOklzc3VlQ29tbWVudDI4OTA5NDkwMA== | LtRipley36706 11369233 | 2017-03-24T17:46:38Z | 2017-03-24T17:46:38Z | MEMBER | Lifestones.. Lifestones everywhere! ![139vy](https://cloud.githubusercontent.com/assets/11369233/24306810/442826f4-1098-11e7-827d-edb4621c05e5.jpg) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | weenies weenies everywhere. object structure pass for review. 216282064 | |
289177445 | https://github.com/ACEmulator/ACE/pull/167#issuecomment-289177445 | https://api.github.com/repos/ACEmulator/ACE/issues/167 | MDEyOklzc3VlQ29tbWVudDI4OTE3NzQ0NQ== | mcreedjr 25518589 | 2017-03-25T01:13:54Z | 2017-03-25T01:13:54Z | CONTRIBUTOR | Works for me, too Mogwai. Exciting to see this materialize through the process. Generalized object factory is going to quickly open a lot of other doors as well. Thanks for the effort! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | weenies weenies everywhere. object structure pass for review. 216282064 | |
289435283 | https://github.com/ACEmulator/ACE/pull/160#issuecomment-289435283 | https://api.github.com/repos/ACEmulator/ACE/issues/160 | MDEyOklzc3VlQ29tbWVudDI4OTQzNTI4Mw== | Mogwai-TheFurry 25351661 | 2017-03-27T12:12:32Z | 2017-03-27T12:12:32Z | CONTRIBUTOR | Sat down to review all this, but there's 5 merge conflicts. If you could take a look at rebasing with the big item / database overhaul that would be great. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Monster factory 215897071 | |
289553473 | https://github.com/ACEmulator/ACE/pull/160#issuecomment-289553473 | https://api.github.com/repos/ACEmulator/ACE/issues/160 | MDEyOklzc3VlQ29tbWVudDI4OTU1MzQ3Mw== | Lidefeath 26508216 | 2017-03-27T19:06:37Z | 2017-03-27T19:06:37Z | CONTRIBUTOR | Thanks for the review. I'll redo this with the new database. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Monster factory 215897071 | |
289575765 | https://github.com/ACEmulator/ACE/issues/166#issuecomment-289575765 | https://api.github.com/repos/ACEmulator/ACE/issues/166 | MDEyOklzc3VlQ29tbWVudDI4OTU3NTc2NQ== | ogmage78 25460553 | 2017-03-27T20:28:27Z | 2017-03-27T20:28:27Z | CONTRIBUTOR | This is inprogress | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Give Characters a set of positions 216250810 | |
289590239 | https://github.com/ACEmulator/ACE/pull/172#issuecomment-289590239 | https://api.github.com/repos/ACEmulator/ACE/issues/172 | MDEyOklzc3VlQ29tbWVudDI4OTU5MDIzOQ== | Lidefeath 26508216 | 2017-03-27T21:22:33Z | 2017-03-27T21:22:33Z | CONTRIBUTOR | The last commit (b5480f2) has the requested changes | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Implements GameAction/Event for Update Health 217055250 | |
289746755 | https://github.com/ACEmulator/ACE/issues/180#issuecomment-289746755 | https://api.github.com/repos/ACEmulator/ACE/issues/180 | MDEyOklzc3VlQ29tbWVudDI4OTc0Njc1NQ== | Mogwai-TheFurry 25351661 | 2017-03-28T11:57:18Z | 2017-03-28T11:57:18Z | CONTRIBUTOR | Problem is we don't have anything in place to differentiate between walking and TPing within a landblock. Shouldn't be hard, though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Objects need to be re-sent to client if teleported within same landblock 217470832 | |
290084445 | https://github.com/ACEmulator/ACE/pull/182#issuecomment-290084445 | https://api.github.com/repos/ACEmulator/ACE/issues/182 | MDEyOklzc3VlQ29tbWVudDI5MDA4NDQ0NQ== | ogmage78 25460553 | 2017-03-29T13:09:24Z | 2017-03-29T13:09:24Z | CONTRIBUTOR | In looking at this this morning - I think I see what the issue is. I was working on this right before someone was doing some work on animation. I had started down a path that I needed to create a properly formed F74C MovementEvent. He and I both created objects and enums that were the same but named differently. Both are in here and I am now sending a bogus F74 message. That is why my neckid dude will not bend down to drop the wand. I won't be able to untangle this until later today - but anyone that has time, other than that message being fubar - the implementation of the container inventory dictionary, the landblock logic for dropping an item - it would be helpful to know if I am on the right track with how it is implemented. Thanks | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Drop Item - REVIEW ONLY Do not merge 217729589 | |
290238147 | https://github.com/ACEmulator/ACE/pull/182#issuecomment-290238147 | https://api.github.com/repos/ACEmulator/ACE/issues/182 | MDEyOklzc3VlQ29tbWVudDI5MDIzODE0Nw== | ogmage78 25460553 | 2017-03-29T21:53:56Z | 2017-03-29T21:53:56Z | CONTRIBUTOR | This is fubar. Going to fix it and resubmit. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Drop Item - REVIEW ONLY Do not merge 217729589 | |
290313862 | https://github.com/ACEmulator/ACE/pull/183#issuecomment-290313862 | https://api.github.com/repos/ACEmulator/ACE/issues/183 | MDEyOklzc3VlQ29tbWVudDI5MDMxMzg2Mg== | LtRipley36706 11369233 | 2017-03-30T06:22:39Z | 2017-03-30T06:22:39Z | MEMBER | Getting several crashes with the current db load in, needs a bit more pruning of objects as there are lots of player created objects in this db in addition to static objects, which probably leads to crashing in some of housing settlements or towns | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | all the database things! 217957579 | |
290456123 | https://github.com/ACEmulator/ACE/pull/184#issuecomment-290456123 | https://api.github.com/repos/ACEmulator/ACE/issues/184 | MDEyOklzc3VlQ29tbWVudDI5MDQ1NjEyMw== | fantoms 37453 | 2017-03-30T15:56:12Z | 2017-03-30T15:56:12Z | CONTRIBUTOR | I am going to close this PR, untill I work the Positions and CharacterPositions in too the same object and the code ready for another look. Thanks For your reviews so far! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Feature: ORM Driven Character Positions for Issue #166 218060844 | |
290590681 | https://github.com/ACEmulator/ACE/pull/186#issuecomment-290590681 | https://api.github.com/repos/ACEmulator/ACE/issues/186 | MDEyOklzc3VlQ29tbWVudDI5MDU5MDY4MQ== | ogmage78 25460553 | 2017-03-31T01:28:25Z | 2017-03-31T01:28:25Z | CONTRIBUTOR | I made the requested changes. Let me know if you see anything else. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Animation - fix and enhancement 218255708 | |
290596235 | https://github.com/ACEmulator/ACE/pull/186#issuecomment-290596235 | https://api.github.com/repos/ACEmulator/ACE/issues/186 | MDEyOklzc3VlQ29tbWVudDI5MDU5NjIzNQ== | ogmage78 25460553 | 2017-03-31T02:11:37Z | 2017-03-31T02:11:37Z | CONTRIBUTOR | Done. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Animation - fix and enhancement 218255708 | |
290756995 | https://github.com/ACEmulator/ACE/pull/187#issuecomment-290756995 | https://api.github.com/repos/ACEmulator/ACE/issues/187 | MDEyOklzc3VlQ29tbWVudDI5MDc1Njk5NQ== | Forbiddenz 25387933 | 2017-03-31T16:11:52Z | 2017-03-31T16:11:52Z | CONTRIBUTOR | Updated | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World fix and fireball test 218334549 | |
290764066 | https://github.com/ACEmulator/ACE/pull/187#issuecomment-290764066 | https://api.github.com/repos/ACEmulator/ACE/issues/187 | MDEyOklzc3VlQ29tbWVudDI5MDc2NDA2Ng== | Forbiddenz 25387933 | 2017-03-31T16:38:58Z | 2017-03-31T16:38:58Z | CONTRIBUTOR | Removed some useless comments I noticed too. - Spell is now a mutable object | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World fix and fireball test 218334549 | |
290821532 | https://github.com/ACEmulator/ACE/pull/187#issuecomment-290821532 | https://api.github.com/repos/ACEmulator/ACE/issues/187 | MDEyOklzc3VlQ29tbWVudDI5MDgyMTUzMg== | Forbiddenz 25387933 | 2017-03-31T20:28:58Z | 2017-03-31T20:28:58Z | CONTRIBUTOR | Spells ! We have some fun spells.. I will work to improve it but this is worth it to submit it now as it should works in multiplayer for giggles.. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World fix and fireball test 218334549 | |
290918730 | https://github.com/ACEmulator/ACE/pull/187#issuecomment-290918730 | https://api.github.com/repos/ACEmulator/ACE/issues/187 | MDEyOklzc3VlQ29tbWVudDI5MDkxODczMA== | Forbiddenz 25387933 | 2017-04-01T13:00:41Z | 2017-04-01T13:00:41Z | CONTRIBUTOR | Closing this, I found some issues with it. I also am thinking we need some kind of naming convention between Entity and Enum.. Starting to Get confusing.. IE PlayerEntity, SpellEntity, Etc as we build more entitys.. enums should just be Spell, Player, etc as needed. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World fix and fireball test 218334549 | |
290962833 | https://github.com/ACEmulator/ACE/pull/191#issuecomment-290962833 | https://api.github.com/repos/ACEmulator/ACE/issues/191 | MDEyOklzc3VlQ29tbWVudDI5MDk2MjgzMw== | ogmage78 25460553 | 2017-04-02T03:47:07Z | 2017-04-02T03:47:07Z | CONTRIBUTOR | No conflicts now and this does fix a serious bug. Let me know what you think. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed bug / incomplete implementation of instance_time stamp 218735283 | |
290962849 | https://github.com/ACEmulator/ACE/pull/189#issuecomment-290962849 | https://api.github.com/repos/ACEmulator/ACE/issues/189 | MDEyOklzc3VlQ29tbWVudDI5MDk2Mjg0OQ== | ogmage78 25460553 | 2017-04-02T03:47:46Z | 2017-04-02T03:47:46Z | CONTRIBUTOR | I will fix this first thing in the morning. I looked they are easy to resolve. Thanks for checking it over. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory Phase 1 and Drop Item 218616162 | |
290963680 | https://github.com/ACEmulator/ACE/pull/194#issuecomment-290963680 | https://api.github.com/repos/ACEmulator/ACE/issues/194 | MDEyOklzc3VlQ29tbWVudDI5MDk2MzY4MA== | fantoms 37453 | 2017-04-02T04:18:08Z | 2017-04-02T04:18:08Z | CONTRIBUTOR | In my defense, here is the previously requested change: https://github.com/ACEmulator/ACE/pull/184/files/0fda5e079b51c574b0565d7e01fa51e8548d5d0b | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix: Reverted SQL syntax to use AFTER, instead of BEFORE 218740683 | |
290970418 | https://github.com/ACEmulator/ACE/pull/190#issuecomment-290970418 | https://api.github.com/repos/ACEmulator/ACE/issues/190 | MDEyOklzc3VlQ29tbWVudDI5MDk3MDQxOA== | Lidefeath 26508216 | 2017-04-02T07:41:29Z | 2017-04-02T07:41:29Z | CONTRIBUTOR | Fixed the merge conflict. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Spawn creatures from DB 218690610 | |
290985538 | https://github.com/ACEmulator/ACE/pull/189#issuecomment-290985538 | https://api.github.com/repos/ACEmulator/ACE/issues/189 | MDEyOklzc3VlQ29tbWVudDI5MDk4NTUzOA== | ogmage78 25460553 | 2017-04-02T13:12:04Z | 2017-04-02T13:12:04Z | CONTRIBUTOR | I fixed the merge issues. When you get a chance to review this - if you look at: public void HandleDropItem(ObjectGuid objectGuid, Session session) - I am not sure if it needs to be on world object or player. I cannot remember if any NPC's would drop anything as part of a quest. I put in in WO just in case. That might be a mistake. If it needs to go into player - I need to create a method on world object to update containerId. Anyway - any feedback is appreciated. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory Phase 1 and Drop Item 218616162 | |
291004035 | https://github.com/ACEmulator/ACE/pull/191#issuecomment-291004035 | https://api.github.com/repos/ACEmulator/ACE/issues/191 | MDEyOklzc3VlQ29tbWVudDI5MTAwNDAzNQ== | ogmage78 25460553 | 2017-04-02T18:15:44Z | 2017-04-02T18:15:44Z | CONTRIBUTOR | Fixed last conflict | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed bug / incomplete implementation of instance_time stamp 218735283 | |
291013240 | https://github.com/ACEmulator/ACE/issues/144#issuecomment-291013240 | https://api.github.com/repos/ACEmulator/ACE/issues/144 | MDEyOklzc3VlQ29tbWVudDI5MTAxMzI0MA== | ogmage78 25460553 | 2017-04-02T20:37:35Z | 2017-04-02T20:37:35Z | CONTRIBUTOR | If the first part gets checked in - I will implement pickup item - then add saving your inventory to the database for persistence. I will add inscription next. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add the Ability to drop an item from your backpack. 215224510 | |
291120839 | https://github.com/ACEmulator/ACE/pull/190#issuecomment-291120839 | https://api.github.com/repos/ACEmulator/ACE/issues/190 | MDEyOklzc3VlQ29tbWVudDI5MTEyMDgzOQ== | Mogwai-TheFurry 25351661 | 2017-04-03T11:49:54Z | 2017-04-03T11:49:54Z | CONTRIBUTOR | I accepted Og's inventory PR which created conflicts again. Good news is you're now at the top of the queue this time! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Spawn creatures from DB 218690610 | |
291122387 | https://github.com/ACEmulator/ACE/pull/183#issuecomment-291122387 | https://api.github.com/repos/ACEmulator/ACE/issues/183 | MDEyOklzc3VlQ29tbWVudDI5MTEyMjM4Nw== | Mogwai-TheFurry 25351661 | 2017-04-03T11:58:02Z | 2017-04-03T11:58:02Z | CONTRIBUTOR | Ok, I'll do the rebase without all the changes and go from there. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | all the database things! 217957579 | |
291123944 | https://github.com/ACEmulator/ACE/issues/4#issuecomment-291123944 | https://api.github.com/repos/ACEmulator/ACE/issues/4 | MDEyOklzc3VlQ29tbWVudDI5MTEyMzk0NA== | Mogwai-TheFurry 25351661 | 2017-04-03T12:06:09Z | 2017-04-03T12:06:09Z | CONTRIBUTOR | mostly done last week. closing this for lack of more descriptive requirements. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE World DB Design 204489832 | |
291271293 | https://github.com/ACEmulator/ACE/pull/198#issuecomment-291271293 | https://api.github.com/repos/ACEmulator/ACE/issues/198 | MDEyOklzc3VlQ29tbWVudDI5MTI3MTI5Mw== | Mogwai-TheFurry 25351661 | 2017-04-03T20:55:57Z | 2017-04-03T20:55:57Z | CONTRIBUTOR | Any chance you can concat the portal files down to a single file for purposes of the PR? In the script directory, you should be able to do this (on Windows command line): copy *.sql AllPortals.sql We'd just need to know to run that via the SqlYog import tool rather than the query editor. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add portals to ACE_World tables 219018504 | |
291571075 | https://github.com/ACEmulator/ACE/pull/190#issuecomment-291571075 | https://api.github.com/repos/ACEmulator/ACE/issues/190 | MDEyOklzc3VlQ29tbWVudDI5MTU3MTA3NQ== | Lidefeath 26508216 | 2017-04-04T17:22:04Z | 2017-04-04T17:22:04Z | CONTRIBUTOR | Fixed the merge conflicts | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Spawn creatures from DB 218690610 | |
292063770 | https://github.com/ACEmulator/ACE/issues/209#issuecomment-292063770 | https://api.github.com/repos/ACEmulator/ACE/issues/209 | MDEyOklzc3VlQ29tbWVudDI5MjA2Mzc3MA== | fantoms 37453 | 2017-04-06T04:08:59Z | 2017-04-06T04:08:59Z | CONTRIBUTOR | After testing a few times, I believe that your commit b52abcd is the culprit. When I revert this change, rotations are restored. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character rotation 219614446 | |
292071321 | https://github.com/ACEmulator/ACE/issues/209#issuecomment-292071321 | https://api.github.com/repos/ACEmulator/ACE/issues/209 | MDEyOklzc3VlQ29tbWVudDI5MjA3MTMyMQ== | fantoms 37453 | 2017-04-06T05:17:17Z | 2017-04-06T05:17:17Z | CONTRIBUTOR | PR #214 seems to also fix the issue for me. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character rotation 219614446 | |
292333744 | https://github.com/ACEmulator/ACE/pull/211#issuecomment-292333744 | https://api.github.com/repos/ACEmulator/ACE/issues/211 | MDEyOklzc3VlQ29tbWVudDI5MjMzMzc0NA== | ogmage78 25460553 | 2017-04-06T21:47:06Z | 2017-04-06T21:47:06Z | CONTRIBUTOR | I regressed with my latest changes. Going to close this for now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | WIP Inventory - Good place for review - Do not merge yet 219773627 | |
292709120 | https://github.com/ACEmulator/ACE/pull/218#issuecomment-292709120 | https://api.github.com/repos/ACEmulator/ACE/issues/218 | MDEyOklzc3VlQ29tbWVudDI5MjcwOTEyMA== | Lidefeath 26508216 | 2017-04-08T10:26:18Z | 2017-04-08T10:26:18Z | CONTRIBUTOR | I'll close this one and will open a clean PR where I merged the master branch beforehand. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature stats 220357495 | |
292803359 | https://github.com/ACEmulator/ACE/issues/209#issuecomment-292803359 | https://api.github.com/repos/ACEmulator/ACE/issues/209 | MDEyOklzc3VlQ29tbWVudDI5MjgwMzM1OQ== | LtRipley36706 11369233 | 2017-04-09T18:31:16Z | 2017-04-09T18:31:16Z | MEMBER | agreed, this issue seems resolved. Closing for now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character rotation 219614446 | |
292815154 | https://github.com/ACEmulator/ACE/pull/169#issuecomment-292815154 | https://api.github.com/repos/ACEmulator/ACE/issues/169 | MDEyOklzc3VlQ29tbWVudDI5MjgxNTE1NA== | LtRipley36706 11369233 | 2017-04-09T21:39:23Z | 2017-04-09T21:39:23Z | MEMBER | See #223 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Updated Marketplace Recall 216958720 | |
292830199 | https://github.com/ACEmulator/ACE/pull/224#issuecomment-292830199 | https://api.github.com/repos/ACEmulator/ACE/issues/224 | MDEyOklzc3VlQ29tbWVudDI5MjgzMDE5OQ== | ogmage78 25460553 | 2017-04-10T01:40:28Z | 2017-04-10T01:40:28Z | CONTRIBUTOR | Forgot to give a shoutout to Lidefeath for helping me with the lambda expression. ;) | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory Part 2 - Create, Drop and Pickup 220517521 | |
293031394 | https://github.com/ACEmulator/ACE/pull/226#issuecomment-293031394 | https://api.github.com/repos/ACEmulator/ACE/issues/226 | MDEyOklzc3VlQ29tbWVudDI5MzAzMTM5NA== | fantoms 37453 | 2017-04-10T18:07:14Z | 2017-04-10T18:07:14Z | CONTRIBUTOR | After pulling this patch, I was able to perform animations on different integers. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for Animations 220709475 | |
293108786 | https://github.com/ACEmulator/ACE/issues/228#issuecomment-293108786 | https://api.github.com/repos/ACEmulator/ACE/issues/228 | MDEyOklzc3VlQ29tbWVudDI5MzEwODc4Ng== | LtRipley36706 11369233 | 2017-04-10T23:38:10Z | 2017-04-10T23:38:10Z | MEMBER | Players that disconnect cleanly also persist in world | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Better Handling for Disconnects 220798868 | |
293122342 | https://github.com/ACEmulator/ACE/issues/231#issuecomment-293122342 | https://api.github.com/repos/ACEmulator/ACE/issues/231 | MDEyOklzc3VlQ29tbWVudDI5MzEyMjM0Mg== | LtRipley36706 11369233 | 2017-04-11T01:18:52Z | 2017-04-11T01:18:52Z | MEMBER | To reproduce: Connect two or more clients to same server teleport both to same location outdoors teleport one away to another outdoor location client disappears return client to original outdoor location @mp both clients from mp, teleport to another dungeon @teleloc 013A01E2 21.68 -50.02 6.11 -0.70 0.00 0.00 -0.71 (for example) the client that is supposed to portal away is left on the remaining client screen. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Teleporting players are not removed from client if player teleports to another dungeon 220811945 | |
293149021 | https://github.com/ACEmulator/ACE/issues/232#issuecomment-293149021 | https://api.github.com/repos/ACEmulator/ACE/issues/232 | MDEyOklzc3VlQ29tbWVudDI5MzE0OTAyMQ== | LtRipley36706 11369233 | 2017-04-11T04:49:50Z | 2017-04-11T04:49:59Z | MEMBER | Your location is: 0x2B110028 [104.277939 191.119308 48.005001] 0.221541 0.000000 0.000000 -0.975151 Your location is: 0x2B120021 [103.705467 0.314215 48.005001] 0.221541 0.000000 0.000000 -0.975151 locations of interest | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Objects don't appear correctly until on top of them 220838658 | |
293284237 | https://github.com/ACEmulator/ACE/pull/227#issuecomment-293284237 | https://api.github.com/repos/ACEmulator/ACE/issues/227 | MDEyOklzc3VlQ29tbWVudDI5MzI4NDIzNw== | Mogwai-TheFurry 25351661 | 2017-04-11T14:38:41Z | 2017-04-11T14:38:41Z | CONTRIBUTOR | changelog... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix GameActionType.QueryHealth for targets in adjacent landblocks and… 220749461 | |
293324955 | https://github.com/ACEmulator/ACE/issues/233#issuecomment-293324955 | https://api.github.com/repos/ACEmulator/ACE/issues/233 | MDEyOklzc3VlQ29tbWVudDI5MzMyNDk1NQ== | LtRipley36706 11369233 | 2017-04-11T16:48:24Z | 2017-04-11T16:48:24Z | MEMBER | I think this is a symptom of a lack of broadcasting of several things related to movement.. My guess it to resolve it queues will need to be built out for MoveToState and likely a change for UpdatePosition... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Issues with second client 220951042 | |
293329824 | https://github.com/ACEmulator/ACE/issues/233#issuecomment-293329824 | https://api.github.com/repos/ACEmulator/ACE/issues/233 | MDEyOklzc3VlQ29tbWVudDI5MzMyOTgyNA== | LtRipley36706 11369233 | 2017-04-11T17:04:38Z | 2017-04-11T17:04:38Z | MEMBER | AutonomousPosition might be another event needing a queue as well to help smooth things out | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Issues with second client 220951042 | |
293478980 | https://github.com/ACEmulator/ACE/pull/227#issuecomment-293478980 | https://api.github.com/repos/ACEmulator/ACE/issues/227 | MDEyOklzc3VlQ29tbWVudDI5MzQ3ODk4MA== | Lidefeath 26508216 | 2017-04-12T05:38:47Z | 2017-04-12T05:38:47Z | CONTRIBUTOR | Fixed changelog.md | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix GameActionType.QueryHealth for targets in adjacent landblocks and… 220749461 | |
293739770 | https://github.com/ACEmulator/ACE/pull/235#issuecomment-293739770 | https://api.github.com/repos/ACEmulator/ACE/issues/235 | MDEyOklzc3VlQ29tbWVudDI5MzczOTc3MA== | fantoms 37453 | 2017-04-12T23:58:29Z | 2017-04-12T23:58:29Z | CONTRIBUTOR | Just pulled the latest changes and tested again; all functions were working as expected. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Dat reader - creating a PR so I can comment. 220965499 | |
293753308 | https://github.com/ACEmulator/ACE/pull/229#issuecomment-293753308 | https://api.github.com/repos/ACEmulator/ACE/issues/229 | MDEyOklzc3VlQ29tbWVudDI5Mzc1MzMwOA== | ogmage78 25460553 | 2017-04-13T01:40:46Z | 2017-04-13T01:40:46Z | CONTRIBUTOR | Updated and ready for merge upon approval. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update to use Action Queue - Requested Changes Made 4/14/2017 220806148 | |
293918593 | https://github.com/ACEmulator/ACE/pull/236#issuecomment-293918593 | https://api.github.com/repos/ACEmulator/ACE/issues/236 | MDEyOklzc3VlQ29tbWVudDI5MzkxODU5Mw== | Zegeger 12808515 | 2017-04-13T14:52:58Z | 2017-04-13T14:53:45Z | CONTRIBUTOR | I have a thought on this, but will require some refactor work. I think we need to move all GameMessage/GameEvents to store inputted data, and then we add a byte[] GetPayload(Session session) function which actually writes the content for sending. Then a single event can be used repeatedly to broadcast to many sessions. I need to take a closer look at this to think out the details. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Concept review: Broadcast Generic Messages for Effects and Sounds 221393225 | |
294036680 | https://github.com/ACEmulator/ACE/pull/237#issuecomment-294036680 | https://api.github.com/repos/ACEmulator/ACE/issues/237 | MDEyOklzc3VlQ29tbWVudDI5NDAzNjY4MA== | Lidefeath 26508216 | 2017-04-13T22:20:45Z | 2017-04-13T22:20:45Z | CONTRIBUTOR | As discussed with fantoms, I'll redo this as a proper commit. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature kill corpse - For review - NOT ready for a merge 221690158 | |
294223013 | https://github.com/ACEmulator/ACE/pull/229#issuecomment-294223013 | https://api.github.com/repos/ACEmulator/ACE/issues/229 | MDEyOklzc3VlQ29tbWVudDI5NDIyMzAxMw== | ogmage78 25460553 | 2017-04-14T19:47:35Z | 2017-04-14T19:47:35Z | CONTRIBUTOR | Stackoverflow pointed out a part of code that was not checking for existence prior to usage - I made that fix. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update to use Action Queue - Requested Changes Made 4/14/2017 220806148 | |
294299000 | https://github.com/ACEmulator/ACE/pull/238#issuecomment-294299000 | https://api.github.com/repos/ACEmulator/ACE/issues/238 | MDEyOklzc3VlQ29tbWVudDI5NDI5OTAwMA== | Lidefeath 26508216 | 2017-04-15T15:09:00Z | 2017-04-15T15:09:00Z | CONTRIBUTOR | I fixed and improved this according to your suggestions and will submit a new PR. Thanks all for the help! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature kill and corpse spawn 221699510 | |
294642122 | https://github.com/ACEmulator/ACE/pull/243#issuecomment-294642122 | https://api.github.com/repos/ACEmulator/ACE/issues/243 | MDEyOklzc3VlQ29tbWVudDI5NDY0MjEyMg== | fantoms 37453 | 2017-04-18T01:14:36Z | 2017-04-18T01:14:36Z | CONTRIBUTOR | I've made changes to each of the commented sections - the code is now ready for another review. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix: Position missing update and LandblockId db object fix 222023780 | |
294742418 | https://github.com/ACEmulator/ACE/pull/239#issuecomment-294742418 | https://api.github.com/repos/ACEmulator/ACE/issues/239 | MDEyOklzc3VlQ29tbWVudDI5NDc0MjQxOA== | Lidefeath 26508216 | 2017-04-18T09:20:50Z | 2017-04-18T09:20:50Z | CONTRIBUTOR | I removed the smite command as requested - although I don't see why implementing it was so bad if it's in the client. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature kill corpse v2 221953958 | |
294856575 | https://github.com/ACEmulator/ACE/pull/247#issuecomment-294856575 | https://api.github.com/repos/ACEmulator/ACE/issues/247 | MDEyOklzc3VlQ29tbWVudDI5NDg1NjU3NQ== | ogmage78 25460553 | 2017-04-18T14:09:58Z | 2017-04-18T14:09:58Z | CONTRIBUTOR | I also really like the container class container -> creature -> player We will be able to do container -> chest. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | major restructuring of object heirarchy. please review. 222409472 | |
294861667 | https://github.com/ACEmulator/ACE/pull/236#issuecomment-294861667 | https://api.github.com/repos/ACEmulator/ACE/issues/236 | MDEyOklzc3VlQ29tbWVudDI5NDg2MTY2Nw== | fantoms 37453 | 2017-04-18T14:26:25Z | 2017-04-18T14:26:25Z | CONTRIBUTOR | Thanks for taking a look! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Concept review: Broadcast Generic Messages for Effects and Sounds 221393225 | |
294962639 | https://github.com/ACEmulator/ACE/pull/251#issuecomment-294962639 | https://api.github.com/repos/ACEmulator/ACE/issues/251 | MDEyOklzc3VlQ29tbWVudDI5NDk2MjYzOQ== | Lidefeath 26508216 | 2017-04-18T20:02:20Z | 2017-04-18T20:02:20Z | CONTRIBUTOR | I like this structure. 👍 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added Folders to Project Structure to make maintaining and developing easier 222524134 | |
294980138 | https://github.com/ACEmulator/ACE/pull/251#issuecomment-294980138 | https://api.github.com/repos/ACEmulator/ACE/issues/251 | MDEyOklzc3VlQ29tbWVudDI5NDk4MDEzOA== | Mogwai-TheFurry 25351661 | 2017-04-18T20:56:44Z | 2017-04-18T20:56:44Z | CONTRIBUTOR | Folders should match namespaces, it's even a StyleCop rule. This type of object organization is not normal practice in industry and I'm not a fan. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added Folders to Project Structure to make maintaining and developing easier 222524134 | |
294980500 | https://github.com/ACEmulator/ACE/pull/250#issuecomment-294980500 | https://api.github.com/repos/ACEmulator/ACE/issues/250 | MDEyOklzc3VlQ29tbWVudDI5NDk4MDUwMA== | Mogwai-TheFurry 25351661 | 2017-04-18T20:57:49Z | 2017-04-18T20:57:49Z | CONTRIBUTOR | What's the use case for this? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Misc Object 222487087 | |
295009469 | https://github.com/ACEmulator/ACE/pull/250#issuecomment-295009469 | https://api.github.com/repos/ACEmulator/ACE/issues/250 | MDEyOklzc3VlQ29tbWVudDI5NTAwOTQ2OQ== | LtRipley36706 11369233 | 2017-04-18T22:59:12Z | 2017-04-18T22:59:12Z | MEMBER | Use case is for house objects but per our discussion I should look further at this to refine to a more specific object | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Misc Object 222487087 | |
295032015 | https://github.com/ACEmulator/ACE/issues/254#issuecomment-295032015 | https://api.github.com/repos/ACEmulator/ACE/issues/254 | MDEyOklzc3VlQ29tbWVudDI5NTAzMjAxNQ== | Gordian3 1765994 | 2017-04-19T01:10:33Z | 2017-04-19T01:10:33Z | CONTRIBUTOR | Some info on the Natural Regen rates can be seen at: http://acpedia.org/wiki/Natural_Resistances#Natural_Resistance_Bonus Mostly this references the modifiers to the natural rates due to attributes (and spells). I'm not sure where to find the actual natural rate. Perhaps some math can be done on some pcaps showing vital restoration and we can work back from the characters stats and spells? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for vitals regeneration 222587429 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);