issue_comments: 290985538
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/189#issuecomment-290985538 | https://api.github.com/repos/ACEmulator/ACE/issues/189 | 290985538 | MDEyOklzc3VlQ29tbWVudDI5MDk4NTUzOA== | 25460553 | 2017-04-02T13:12:04Z | 2017-04-02T13:12:04Z | CONTRIBUTOR | I fixed the merge issues. When you get a chance to review this - if you look at: public void HandleDropItem(ObjectGuid objectGuid, Session session) - I am not sure if it needs to be on world object or player. I cannot remember if any NPC's would drop anything as part of a quest. I put in in WO just in case. That might be a mistake. If it needs to go into player - I need to create a method on world object to update containerId. Anyway - any feedback is appreciated. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 218616162 |