issues: 218255708
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
218255708 | MDExOlB1bGxSZXF1ZXN0MTEzNDcxNzg4 | 186 | Animation - fix and enhancement | 25460553 | closed | 0 | 2 | 2017-03-30T16:33:24Z | 2017-03-31T18:49:25Z | 2017-03-31T03:42:17Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/186 | In this PR - I extended on the work Zegeger did. His work was for animations only. The system supports a 0 to N animation sequence. If 0, you are doing a basic motion. Moving forward, sidestep, turnto. They use the same message F74C but are intelligently coded depending on what you want to do. TODO: I have not looked to see if you can have a motion followed by an animation(s) I coded it so it supports it, but I did not have a ready pcap to confirm. Easy enough to fix if they are mutually exclusive. I cleaned up some emums. Still to do is to refactor the autonomous position message - I think we have some overlap and duplication there. To test - use the debug command @amimation <animation> to see that Zegeger's work still functions as expected. Use debug command @movement to see the drop sequence. You can look at the produced pcaps and see the delta and that they match live servers. As usual - any coding faxpas are not by design. Feedback is wanted and welcome. If there is a better way to do what I did - please let me know. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/186/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |