issue_comments
Data license: AGPL · Data source: ACEmulator Project
1,646 rows
This data as json, CSV (advanced)
Suggested facets: author_association, reactions, created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
274909744 | https://github.com/ACEmulator/ACE/pull/2#issuecomment-274909744 | https://api.github.com/repos/ACEmulator/ACE/issues/2 | MDEyOklzc3VlQ29tbWVudDI3NDkwOTc0NA== | xanxin887 6705011 | 2017-01-24T19:26:10Z | 2017-01-24T19:26:10Z | NONE | characters_database.sql that is included had a bad PK this one fixes that. [characters_database.sql.txt](https://github.com/ACEmulator/ACE/files/727740/characters_database.sql.txt) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Updates for DB 1/24/17 202908658 | |
276565884 | https://github.com/ACEmulator/ACE/issues/6#issuecomment-276565884 | https://api.github.com/repos/ACEmulator/ACE/issues/6 | MDEyOklzc3VlQ29tbWVudDI3NjU2NTg4NA== | TigrisOfGaul 25125434 | 2017-02-01T03:51:47Z | 2017-02-01T03:51:47Z | CONTRIBUTOR | Characters are saved to the database upon creation, just not fully. Appearance, stats, and skills still need to be persisted. I will try to finish this asap. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Characters aren't saved or loaded properly yet from the DB 204489997 | |
277009368 | https://github.com/ACEmulator/ACE/pull/10#issuecomment-277009368 | https://api.github.com/repos/ACEmulator/ACE/issues/10 | MDEyOklzc3VlQ29tbWVudDI3NzAwOTM2OA== | Rawaho 6111341 | 2017-02-02T16:36:57Z | 2017-02-02T16:36:57Z | CONTRIBUTOR | Additional checks will be added on account login as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client and Server expects account in ace_auth to be lowercase only. 204670023 | |
277143116 | https://github.com/ACEmulator/ACE/issues/12#issuecomment-277143116 | https://api.github.com/repos/ACEmulator/ACE/issues/12 | MDEyOklzc3VlQ29tbWVudDI3NzE0MzExNg== | firesickle 25497527 | 2017-02-03T01:52:42Z | 2017-02-03T01:52:42Z | NONE | As an alternative, You can run it in its current state with a scheduled task, which I think you can set up to execute upon start up. Additionally, you can set a scheduled task to run again if it is not already running, to get the client to start back up if it threw an exception and ended. Not sure myself what extra steps would need to make this into a service. In my past experience, I have had never-ending problems with custom built windows services that do web interactions, had a lot more success when switching to scheduled tasks | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Converting ACE to run as a Windows service 205040357 | |
277153067 | https://github.com/ACEmulator/ACE/issues/12#issuecomment-277153067 | https://api.github.com/repos/ACEmulator/ACE/issues/12 | MDEyOklzc3VlQ29tbWVudDI3NzE1MzA2Nw== | Mogwai-TheFurry 25351661 | 2017-02-03T03:05:38Z | 2017-02-03T03:05:38Z | CONTRIBUTOR | Windows services are a real pain for development. This won't need to be done for a really long time. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Converting ACE to run as a Windows service 205040357 | |
277183931 | https://github.com/ACEmulator/ACE/pull/11#issuecomment-277183931 | https://api.github.com/repos/ACEmulator/ACE/issues/11 | MDEyOklzc3VlQ29tbWVudDI3NzE4MzkzMQ== | sbaum23 22650655 | 2017-02-03T07:40:42Z | 2017-02-03T07:40:42Z | CONTRIBUTOR | Added /teleto debug command to teleport to coordinates. Z value is currently hard coded to 200 because it needs to be read from a file (dat?). Also, the two methods to convert Coordinates to XYZ are in DebugCommands.cs because I'm not sure where you want to put them. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Run faster, jump higher, teleport to coordinates (rather than XYZ position) 204803198 | |
277360874 | https://github.com/ACEmulator/ACE/pull/11#issuecomment-277360874 | https://api.github.com/repos/ACEmulator/ACE/issues/11 | MDEyOklzc3VlQ29tbWVudDI3NzM2MDg3NA== | sbaum23 22650655 | 2017-02-03T20:59:39Z | 2017-02-03T20:59:39Z | CONTRIBUTOR | I blew away my fork. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Run faster, jump higher, teleport to coordinates (rather than XYZ position) 204803198 | |
277421543 | https://github.com/ACEmulator/ACE/pull/13#issuecomment-277421543 | https://api.github.com/repos/ACEmulator/ACE/issues/13 | MDEyOklzc3VlQ29tbWVudDI3NzQyMTU0Mw== | Mogwai-TheFurry 25351661 | 2017-02-04T05:55:04Z | 2017-02-04T05:55:04Z | CONTRIBUTOR | Closing, new PR coming. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | database layer encapsulation and abstraction 205077117 | |
277444904 | https://github.com/ACEmulator/ACE/issues/6#issuecomment-277444904 | https://api.github.com/repos/ACEmulator/ACE/issues/6 | MDEyOklzc3VlQ29tbWVudDI3NzQ0NDkwNA== | TigrisOfGaul 25125434 | 2017-02-04T13:09:21Z | 2017-02-04T13:09:21Z | CONTRIBUTOR | Character persistence after creation is complete but work still needs to be done to load character stats, skills and appearance from the database for world entry. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Characters aren't saved or loaded properly yet from the DB 204489997 | |
277454303 | https://github.com/ACEmulator/ACE/issues/20#issuecomment-277454303 | https://api.github.com/repos/ACEmulator/ACE/issues/20 | MDEyOklzc3VlQ29tbWVudDI3NzQ1NDMwMw== | zbuc 570040 | 2017-02-04T15:48:45Z | 2017-02-04T15:48:45Z | CONTRIBUTOR | I suggest a reasonable first version of this might look like: 1) an update to the core .sql file and `Config.json` to add a new `ace_global` database with a table `schema_revisions` tracking database schema versions The columns might be something like: `id int(auto increment), schema_name varchar, schema_version int` also insert initial values into the `schema_revisions` table to set the current `schema_version` at 0 on all databases (`ace_auth`, `ace_character`, `ace_world`). 2) add a task that runs during server startup that uses the database names from `Config.json` and compares the .sql files found on the filesystem against the results from `ace_global.schema_revisions` and runs the new ones, and updates the database. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server should have a way to apply DB migrations 205353528 | |
277461220 | https://github.com/ACEmulator/ACE/pull/21#issuecomment-277461220 | https://api.github.com/repos/ACEmulator/ACE/issues/21 | MDEyOklzc3VlQ29tbWVudDI3NzQ2MTIyMA== | zbuc 570040 | 2017-02-04T17:29:13Z | 2017-02-04T17:29:13Z | CONTRIBUTOR | Fixes Issue #15 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change password hashing to use scrypt 205361124 | |
277475417 | https://github.com/ACEmulator/ACE/pull/18#issuecomment-277475417 | https://api.github.com/repos/ACEmulator/ACE/issues/18 | MDEyOklzc3VlQ29tbWVudDI3NzQ3NTQxNw== | LtRipley36706 11369233 | 2017-02-04T20:34:39Z | 2017-02-04T20:34:39Z | MEMBER | In looking at the character deletion and restore section it made sense to me that name in ace_character shouldn't be made a unique value At present in master, even if that character was marked as deleted, the character name is held. I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores. As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client. Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Option to Enable Automatic Account Creation 205330194 | |
277481983 | https://github.com/ACEmulator/ACE/pull/18#issuecomment-277481983 | https://api.github.com/repos/ACEmulator/ACE/issues/18 | MDEyOklzc3VlQ29tbWVudDI3NzQ4MTk4Mw== | LtRipley36706 11369233 | 2017-02-04T22:14:16Z | 2017-02-04T22:14:16Z | MEMBER | Closing this PR as I have split up the several changes I made into separate PRs per request. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Option to Enable Automatic Account Creation 205330194 | |
277483519 | https://github.com/ACEmulator/ACE/pull/23#issuecomment-277483519 | https://api.github.com/repos/ACEmulator/ACE/issues/23 | MDEyOklzc3VlQ29tbWVudDI3NzQ4MzUxOQ== | LtRipley36706 11369233 | 2017-02-04T22:42:06Z | 2017-02-04T22:42:06Z | MEMBER | Makes a lot of sense to me. Resetting the current config.json for each branch/pull is a bit of a hassle currently, this way you only have to reset when the file NEEDS to change | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add Config.json to .gitignore 205377812 | |
277485102 | https://github.com/ACEmulator/ACE/issues/20#issuecomment-277485102 | https://api.github.com/repos/ACEmulator/ACE/issues/20 | MDEyOklzc3VlQ29tbWVudDI3NzQ4NTEwMg== | zbuc 570040 | 2017-02-04T23:12:57Z | 2017-02-04T23:12:57Z | CONTRIBUTOR | Almost done with this... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server should have a way to apply DB migrations 205353528 | |
277488613 | https://github.com/ACEmulator/ACE/issues/8#issuecomment-277488613 | https://api.github.com/repos/ACEmulator/ACE/issues/8 | MDEyOklzc3VlQ29tbWVudDI3NzQ4ODYxMw== | Oykib 25472382 | 2017-02-05T00:35:02Z | 2017-02-05T00:35:02Z | NONE | [ACEmuLauncher.zip](https://github.com/ACEmulator/ACE/files/752670/ACEmuLauncher.zip) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client Launcher needed 204490371 | |
277492721 | https://github.com/ACEmulator/ACE/pull/14#issuecomment-277492721 | https://api.github.com/repos/ACEmulator/ACE/issues/14 | MDEyOklzc3VlQ29tbWVudDI3NzQ5MjcyMQ== | sbaum23 22650655 | 2017-02-05T02:21:27Z | 2017-02-05T02:21:27Z | CONTRIBUTOR | I wasn't following coding conventions. Fixed that on a new branch and submitted a new PR. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added /teleto command 205270553 | |
277496824 | https://github.com/ACEmulator/ACE/issues/28#issuecomment-277496824 | https://api.github.com/repos/ACEmulator/ACE/issues/28 | MDEyOklzc3VlQ29tbWVudDI3NzQ5NjgyNA== | LtRipley36706 11369233 | 2017-02-05T04:28:54Z | 2017-02-05T04:28:54Z | MEMBER | Ignore this issue.. I was not fully understanding how the IPs were being used in config.json. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change way mysql databases are accessed 205389442 | |
277497148 | https://github.com/ACEmulator/ACE/issues/31#issuecomment-277497148 | https://api.github.com/repos/ACEmulator/ACE/issues/31 | MDEyOklzc3VlQ29tbWVudDI3NzQ5NzE0OA== | zbuc 570040 | 2017-02-05T04:39:10Z | 2017-02-05T04:39:10Z | CONTRIBUTOR | I think this would involve: 1) Add the log path and verbosity flags to the `Config.json` 2) Create a new persistent logging thread that can operate off a queue of log message tasks, sending them to the filesystem 3) Create a new window to display log messages, streamed from the filesystem 4) Replace `Console.WriteLine` messages used for logging with calls to queue log message tasks on the logging thread I'm not a .NET developer, but it looks like these classes might be useful: https://msdn.microsoft.com/en-us/library/microsoft.visualbasic.logging.filelogtracelistener.aspx | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Logs should go to separate window, and filesystem 205400067 | |
277498912 | https://github.com/ACEmulator/ACE/pull/30#issuecomment-277498912 | https://api.github.com/repos/ACEmulator/ACE/issues/30 | MDEyOklzc3VlQ29tbWVudDI3NzQ5ODkxMg== | LtRipley36706 11369233 | 2017-02-05T05:37:01Z | 2017-02-05T05:37:01Z | MEMBER | Did the merge wrong again, apologies.. sending new PR shortly. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for NAT issues on internal connections to WorldServer 205398529 | |
277499579 | https://github.com/ACEmulator/ACE/pull/29#issuecomment-277499579 | https://api.github.com/repos/ACEmulator/ACE/issues/29 | MDEyOklzc3VlQ29tbWVudDI3NzQ5OTU3OQ== | sbaum23 22650655 | 2017-02-05T06:01:09Z | 2017-02-05T06:01:09Z | CONTRIBUTOR | Going to do a clean PR. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Teleto command redo 205394658 | |
277505687 | https://github.com/ACEmulator/ACE/pull/25#issuecomment-277505687 | https://api.github.com/repos/ACEmulator/ACE/issues/25 | MDEyOklzc3VlQ29tbWVudDI3NzUwNTY4Nw== | LtRipley36706 11369233 | 2017-02-05T08:52:53Z | 2017-02-05T08:52:53Z | MEMBER | See PR #34 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Option to Enable Automatic Account Creation 205381602 | |
277506132 | https://github.com/ACEmulator/ACE/pull/26#issuecomment-277506132 | https://api.github.com/repos/ACEmulator/ACE/issues/26 | MDEyOklzc3VlQ29tbWVudDI3NzUwNjEzMg== | LtRipley36706 11369233 | 2017-02-05T09:03:41Z | 2017-02-05T09:03:41Z | MEMBER | Closing this due to conflicts, see PR #35 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing up Character Delete and Restore functions 205381707 | |
277545133 | https://github.com/ACEmulator/ACE/pull/36#issuecomment-277545133 | https://api.github.com/repos/ACEmulator/ACE/issues/36 | MDEyOklzc3VlQ29tbWVudDI3NzU0NTEzMw== | zbuc 570040 | 2017-02-05T20:06:01Z | 2017-02-05T20:06:01Z | CONTRIBUTOR | I'm not a C# guy and there are some stylistic things I don't like, mainly calling out to `DatabaseManager.Global` in the main `Database` class is very hacky, as is what I had to do with the `Global` prepared statements. But, it all works and I think is good for a first pass. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add automatic database migrations to startup 205449659 | |
277549255 | https://github.com/ACEmulator/ACE/pull/32#issuecomment-277549255 | https://api.github.com/repos/ACEmulator/ACE/issues/32 | MDEyOklzc3VlQ29tbWVudDI3NzU0OTI1NQ== | LtRipley36706 11369233 | 2017-02-05T21:05:00Z | 2017-02-05T21:05:00Z | MEMBER | See PR #37 instead | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for NAT issues on internal connections to WorldServer 205403112 | |
277551247 | https://github.com/ACEmulator/ACE/pull/36#issuecomment-277551247 | https://api.github.com/repos/ACEmulator/ACE/issues/36 | MDEyOklzc3VlQ29tbWVudDI3NzU1MTI0Nw== | zbuc 570040 | 2017-02-05T21:32:29Z | 2017-02-05T21:32:29Z | CONTRIBUTOR | Fixes #20 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add automatic database migrations to startup 205449659 | |
277572855 | https://github.com/ACEmulator/ACE/issues/8#issuecomment-277572855 | https://api.github.com/repos/ACEmulator/ACE/issues/8 | MDEyOklzc3VlQ29tbWVudDI3NzU3Mjg1NQ== | Oykib 25472382 | 2017-02-06T02:24:53Z | 2017-02-06T02:24:53Z | NONE | [ACEmuLauncher v0.0.0.3 source.zip](https://github.com/ACEmulator/ACE/files/753512/ACEmuLauncher.v0.0.0.3.source.zip) Latest version that has profiles. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client Launcher needed 204490371 | |
277735330 | https://github.com/ACEmulator/ACE/issues/42#issuecomment-277735330 | https://api.github.com/repos/ACEmulator/ACE/issues/42 | MDEyOklzc3VlQ29tbWVudDI3NzczNTMzMA== | Mogwai-TheFurry 25351661 | 2017-02-06T16:30:40Z | 2017-02-06T16:30:40Z | CONTRIBUTOR | This is low priority. Wanted it logged as legit to-do, though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Subscription data model concept + GLS replacement 205637204 | |
277744701 | https://github.com/ACEmulator/ACE/issues/5#issuecomment-277744701 | https://api.github.com/repos/ACEmulator/ACE/issues/5 | MDEyOklzc3VlQ29tbWVudDI3Nzc0NDcwMQ== | Forbiddenz 25387933 | 2017-02-06T17:01:51Z | 2017-02-06T17:01:51Z | CONTRIBUTOR | Working on it, but going to need a landblock system I think before we can get very far on this.. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE Chat System 204489878 | |
277752941 | https://github.com/ACEmulator/ACE/issues/44#issuecomment-277752941 | https://api.github.com/repos/ACEmulator/ACE/issues/44 | MDEyOklzc3VlQ29tbWVudDI3Nzc1Mjk0MQ== | Mogwai-TheFurry 25351661 | 2017-02-06T17:30:14Z | 2017-02-06T17:30:14Z | CONTRIBUTOR | Kaos: We just need a simple rank system and /setrank command or similar that flows through. 1=registered, 2=envoy, 3=sentinel, 4=admin, etc... Everyone goes under 1 automatically and an admin can use the /setrank command to give out any additional ranks. Value should be stored in DB. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add column to authenticationDB.account for access rights 205646390 | |
277754381 | https://github.com/ACEmulator/ACE/issues/44#issuecomment-277754381 | https://api.github.com/repos/ACEmulator/ACE/issues/44 | MDEyOklzc3VlQ29tbWVudDI3Nzc1NDM4MQ== | LtRipley36706 11369233 | 2017-02-06T17:35:16Z | 2017-02-06T17:35:16Z | MEMBER | for reference, values assigned to characters: SetPropertyBool(PropertyBool.IsPsr, false); SetPropertyBool(PropertyBool.IsAdmin, true); SetPropertyBool(PropertyBool.IsArch, false); SetPropertyBool(PropertyBool.IsSentinel, false); SetPropertyBool(PropertyBool.IsAdvocate, false); would think it goes like this: 0=player 1=advocate (isAdvocate) 2=sentinel (isSentinel) 3=envoy (isPSR) 4=developer? (IsArch) 5=admin (isAdmin) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add column to authenticationDB.account for access rights 205646390 | |
277760878 | https://github.com/ACEmulator/ACE/issues/5#issuecomment-277760878 | https://api.github.com/repos/ACEmulator/ACE/issues/5 | MDEyOklzc3VlQ29tbWVudDI3Nzc2MDg3OA== | kaos00723 8607407 | 2017-02-06T17:57:58Z | 2017-02-06T17:57:58Z | CONTRIBUTOR | From Rawaho: "The chat really needs broadcast support and to do that we need a working grid system and to do that we need to load the dat files I am working on handling the dat files but haven't had much time the last few days" | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE Chat System 204489878 | |
277778434 | https://github.com/ACEmulator/ACE/issues/6#issuecomment-277778434 | https://api.github.com/repos/ACEmulator/ACE/issues/6 | MDEyOklzc3VlQ29tbWVudDI3Nzc3ODQzNA== | TigrisOfGaul 25125434 | 2017-02-06T19:00:52Z | 2017-02-06T19:00:52Z | CONTRIBUTOR | Mogwai is working on loading character data from the db. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Characters aren't saved or loaded properly yet from the DB 204489997 | |
277875015 | https://github.com/ACEmulator/ACE/issues/43#issuecomment-277875015 | https://api.github.com/repos/ACEmulator/ACE/issues/43 | MDEyOklzc3VlQ29tbWVudDI3Nzg3NTAxNQ== | Mogwai-TheFurry 25351661 | 2017-02-07T01:43:41Z | 2017-02-07T01:43:41Z | CONTRIBUTOR | In progress. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Move Database Access and object models to a separate C# project 205645250 | |
277889298 | https://github.com/ACEmulator/ACE/issues/43#issuecomment-277889298 | https://api.github.com/repos/ACEmulator/ACE/issues/43 | MDEyOklzc3VlQ29tbWVudDI3Nzg4OTI5OA== | Mogwai-TheFurry 25351661 | 2017-02-07T03:13:54Z | 2017-02-07T03:13:54Z | CONTRIBUTOR | As I'm working on this, it quickly turned into a major mess. In order to extract this stuff I need to extract serialization and configuration from the data tier. I couldn't do this to my satisfaction in 2 hours tonight and really need to talk to Rawaho about it before continuing. Back burnering for now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Move Database Access and object models to a separate C# project 205645250 | |
277907609 | https://github.com/ACEmulator/ACE/issues/6#issuecomment-277907609 | https://api.github.com/repos/ACEmulator/ACE/issues/6 | MDEyOklzc3VlQ29tbWVudDI3NzkwNzYwOQ== | Mogwai-TheFurry 25351661 | 2017-02-07T05:46:32Z | 2017-02-07T06:39:31Z | CONTRIBUTOR | #47 has the rest of this issue done. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Characters aren't saved or loaded properly yet from the DB 204489997 | |
277907896 | https://github.com/ACEmulator/ACE/issues/44#issuecomment-277907896 | https://api.github.com/repos/ACEmulator/ACE/issues/44 | MDEyOklzc3VlQ29tbWVudDI3NzkwNzg5Ng== | Mogwai-TheFurry 25351661 | 2017-02-07T05:48:38Z | 2017-02-07T05:48:38Z | CONTRIBUTOR | Had a discussion about this in Discord tonight. The client sends 2 uints for IsEnvoy and IsAdmin. Need to clarify if this is 1 field with a bitmask, 1 field with tiered elevation, or multiple fields. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add column to authenticationDB.account for access rights 205646390 | |
277995357 | https://github.com/ACEmulator/ACE/issues/31#issuecomment-277995357 | https://api.github.com/repos/ACEmulator/ACE/issues/31 | MDEyOklzc3VlQ29tbWVudDI3Nzk5NTM1Nw== | Mogwai-TheFurry 25351661 | 2017-02-07T13:11:47Z | 2017-02-07T13:11:47Z | CONTRIBUTOR | .Net guy recommendation: use NLog or Log4Net. both are well known, reliable frameworks for logging. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Logs should go to separate window, and filesystem 205400067 | |
278051575 | https://github.com/ACEmulator/ACE/pull/47#issuecomment-278051575 | https://api.github.com/repos/ACEmulator/ACE/issues/47 | MDEyOklzc3VlQ29tbWVudDI3ODA1MTU3NQ== | Mogwai-TheFurry 25351661 | 2017-02-07T16:22:46Z | 2017-02-07T16:22:46Z | CONTRIBUTOR | Closing PR: sql script does not specify unsigned types | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Load saved characters 205792049 | |
278546199 | https://github.com/ACEmulator/ACE/issues/49#issuecomment-278546199 | https://api.github.com/repos/ACEmulator/ACE/issues/49 | MDEyOklzc3VlQ29tbWVudDI3ODU0NjE5OQ== | Mogwai-TheFurry 25351661 | 2017-02-09T04:46:14Z | 2017-02-09T04:46:14Z | CONTRIBUTOR | in PR #50 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | XP expenditure on skills/stats 205882786 | |
278546228 | https://github.com/ACEmulator/ACE/issues/48#issuecomment-278546228 | https://api.github.com/repos/ACEmulator/ACE/issues/48 | MDEyOklzc3VlQ29tbWVudDI3ODU0NjIyOA== | Mogwai-TheFurry 25351661 | 2017-02-09T04:46:26Z | 2017-02-09T04:46:26Z | CONTRIBUTOR | in PR #50 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add all other properties to Character persistence model 205882576 | |
278870195 | https://github.com/ACEmulator/ACE/issues/51#issuecomment-278870195 | https://api.github.com/repos/ACEmulator/ACE/issues/51 | MDEyOklzc3VlQ29tbWVudDI3ODg3MDE5NQ== | Rawaho 6111341 | 2017-02-10T06:44:43Z | 2017-02-10T06:44:43Z | CONTRIBUTOR | Should be a combination of the first 2, we can't just have only on logout, if a player is in a long play session and the server crashes for whatever reason it would be a massive rollback. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Saving a Character to the DB 206403228 | |
279123506 | https://github.com/ACEmulator/ACE/pull/35#issuecomment-279123506 | https://api.github.com/repos/ACEmulator/ACE/issues/35 | MDEyOklzc3VlQ29tbWVudDI3OTEyMzUwNg== | LtRipley36706 11369233 | 2017-02-11T05:46:23Z | 2017-02-11T05:46:23Z | MEMBER | See PR #57 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing up Character Delete and Restore functions 205412246 | |
279125244 | https://github.com/ACEmulator/ACE/pull/55#issuecomment-279125244 | https://api.github.com/repos/ACEmulator/ACE/issues/55 | MDEyOklzc3VlQ29tbWVudDI3OTEyNTI0NA== | LtRipley36706 11369233 | 2017-02-11T06:27:53Z | 2017-02-11T06:27:53Z | MEMBER | resolved merge conflict | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Stubbed CommandHandlers for known AdminCommands 206410568 | |
279128317 | https://github.com/ACEmulator/ACE/issues/51#issuecomment-279128317 | https://api.github.com/repos/ACEmulator/ACE/issues/51 | MDEyOklzc3VlQ29tbWVudDI3OTEyODMxNw== | LtRipley36706 11369233 | 2017-02-11T07:49:45Z | 2017-02-11T07:49:45Z | MEMBER | Old school AC showed a message each time a character was saved. "[charactername] has been saved." it was probably on a 5 or 10 minute interval. They later just hid the message. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Saving a Character to the DB 206403228 | |
279195536 | https://github.com/ACEmulator/ACE/pull/36#issuecomment-279195536 | https://api.github.com/repos/ACEmulator/ACE/issues/36 | MDEyOklzc3VlQ29tbWVudDI3OTE5NTUzNg== | zbuc 570040 | 2017-02-12T04:10:14Z | 2017-02-12T04:10:14Z | CONTRIBUTOR | I cleaned up and simplified some of the code, and rebased against `master`. All current migrations run and the database is in a working state after compiling and running off this branch. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add automatic database migrations to startup 205449659 | |
279196637 | https://github.com/ACEmulator/ACE/pull/57#issuecomment-279196637 | https://api.github.com/repos/ACEmulator/ACE/issues/57 | MDEyOklzc3VlQ29tbWVudDI3OTE5NjYzNw== | LtRipley36706 11369233 | 2017-02-12T04:44:40Z | 2017-02-12T04:49:15Z | MEMBER | Latest commit finishes up the character deletion function and replicates how deletions occurred on the retail worlds. To my knowledge, characters were never truly deleted beyond this stage and were always left in the database to be restored via /bornagain if warranted. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing up Character Delete and Restore functions 206960724 | |
279226754 | https://github.com/ACEmulator/ACE/pull/36#issuecomment-279226754 | https://api.github.com/repos/ACEmulator/ACE/issues/36 | MDEyOklzc3VlQ29tbWVudDI3OTIyNjc1NA== | Forbiddenz 25387933 | 2017-02-12T15:43:24Z | 2017-02-12T15:43:24Z | CONTRIBUTOR | This is s great idea but I do wonder if this entire process should be separated into its own project in the solution. I.e. Patcher because this is not really a server process but more so a patcher / installer issue | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add automatic database migrations to startup 205449659 | |
279227233 | https://github.com/ACEmulator/ACE/issues/7#issuecomment-279227233 | https://api.github.com/repos/ACEmulator/ACE/issues/7 | MDEyOklzc3VlQ29tbWVudDI3OTIyNzIzMw== | Forbiddenz 25387933 | 2017-02-12T15:50:35Z | 2017-02-12T15:50:35Z | CONTRIBUTOR | It's not just world object movement but it's the entire world object. It needs implemented correctly before any major feature can be added or else the rework will be awful. The current world object needs uncoupled and it should be broken down into multiple sub objects to handle the correct sub object layers like sub models etc . If dive right it could be combined with database tables to generate objects correctly based on sql table data | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World object movement / animation needs proper implementing 204490022 | |
279281301 | https://github.com/ACEmulator/ACE/issues/51#issuecomment-279281301 | https://api.github.com/repos/ACEmulator/ACE/issues/51 | MDEyOklzc3VlQ29tbWVudDI3OTI4MTMwMQ== | spikeone83 20557688 | 2017-02-13T02:39:40Z | 2017-02-13T02:39:40Z | NONE | best is to save characters routinely, characters not saving often server side is one of the easy ways of duping in any online game | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Saving a Character to the DB 206403228 | |
279350491 | https://github.com/ACEmulator/ACE/issues/8#issuecomment-279350491 | https://api.github.com/repos/ACEmulator/ACE/issues/8 | MDEyOklzc3VlQ29tbWVudDI3OTM1MDQ5MQ== | damnubber 4389226 | 2017-02-13T10:37:53Z | 2017-02-13T10:37:53Z | NONE | Any specific reason this isn't in the ACE solution? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client Launcher needed 204490371 | |
279395678 | https://github.com/ACEmulator/ACE/issues/8#issuecomment-279395678 | https://api.github.com/repos/ACEmulator/ACE/issues/8 | MDEyOklzc3VlQ29tbWVudDI3OTM5NTY3OA== | Oykib 25472382 | 2017-02-13T13:43:20Z | 2017-02-13T13:43:20Z | NONE | This can be deleted. I was informed that they do not need a launcher developed and have one in mind already. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client Launcher needed 204490371 | |
280018556 | https://github.com/ACEmulator/ACE/issues/31#issuecomment-280018556 | https://api.github.com/repos/ACEmulator/ACE/issues/31 | MDEyOklzc3VlQ29tbWVudDI4MDAxODU1Ng== | Zegeger 12808515 | 2017-02-15T14:03:38Z | 2017-02-15T14:03:38Z | CONTRIBUTOR | I think ideally it should be written such that different logging listeners could be swapped in allowing a logger of ones choice. My recommendation would be to do ETW logging. Its more cumbersome to handle the resulting logs, but there is a very low perf overhead, allowing you to hit 10k+ entries per second without stealing perf. This is what things like Exchange/Skype for Business servers use. I could work on something like this. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Logs should go to separate window, and filesystem 205400067 | |
280233728 | https://github.com/ACEmulator/ACE/pull/57#issuecomment-280233728 | https://api.github.com/repos/ACEmulator/ACE/issues/57 | MDEyOklzc3VlQ29tbWVudDI4MDIzMzcyOA== | LtRipley36706 11369233 | 2017-02-16T05:17:24Z | 2017-02-16T05:17:24Z | MEMBER | See PR #66 for fixes. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing up Character Delete and Restore functions 206960724 | |
280469751 | https://github.com/ACEmulator/ACE/issues/20#issuecomment-280469751 | https://api.github.com/repos/ACEmulator/ACE/issues/20 | MDEyOklzc3VlQ29tbWVudDI4MDQ2OTc1MQ== | Mogwai-TheFurry 25351661 | 2017-02-16T21:39:47Z | 2017-02-16T21:39:47Z | CONTRIBUTOR | this was recently done with a powershell script that was merged. if you're ok with using that, please close the issue. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server should have a way to apply DB migrations 205353528 | |
280472468 | https://github.com/ACEmulator/ACE/issues/8#issuecomment-280472468 | https://api.github.com/repos/ACEmulator/ACE/issues/8 | MDEyOklzc3VlQ29tbWVudDI4MDQ3MjQ2OA== | Mogwai-TheFurry 25351661 | 2017-02-16T21:49:40Z | 2017-02-16T21:49:40Z | CONTRIBUTOR | Thwargle has one, hoping to release it today. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client Launcher needed 204490371 | |
280479110 | https://github.com/ACEmulator/ACE/issues/4#issuecomment-280479110 | https://api.github.com/repos/ACEmulator/ACE/issues/4 | MDEyOklzc3VlQ29tbWVudDI4MDQ3OTExMA== | Mogwai-TheFurry 25351661 | 2017-02-16T22:13:18Z | 2017-02-16T22:13:18Z | CONTRIBUTOR | Elaborate? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE World DB Design 204489832 | |
280565958 | https://github.com/ACEmulator/ACE/pull/55#issuecomment-280565958 | https://api.github.com/repos/ACEmulator/ACE/issues/55 | MDEyOklzc3VlQ29tbWVudDI4MDU2NTk1OA== | LtRipley36706 11369233 | 2017-02-17T06:30:40Z | 2017-02-17T06:30:40Z | MEMBER | See #67 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Stubbed CommandHandlers for known AdminCommands 206410568 | |
280581225 | https://github.com/ACEmulator/ACE/pull/54#issuecomment-280581225 | https://api.github.com/repos/ACEmulator/ACE/issues/54 | MDEyOklzc3VlQ29tbWVudDI4MDU4MTIyNQ== | sbaum23 22650655 | 2017-02-17T08:00:32Z | 2017-02-17T08:00:32Z | CONTRIBUTOR | Closing this PR because so much stuff had changed since this was submitted. Just opened a new PR. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added friends list functionality. 206407101 | |
280604951 | https://github.com/ACEmulator/ACE/pull/21#issuecomment-280604951 | https://api.github.com/repos/ACEmulator/ACE/issues/21 | MDEyOklzc3VlQ29tbWVudDI4MDYwNDk1MQ== | Mag-nus 10608427 | 2017-02-17T09:47:21Z | 2017-02-17T09:47:21Z | MEMBER | I like the idea, but, i don't feel it's necessary to visit until we know how account create will actually work. Merging it into current though seems fine. Probably better sooner rather than later as I assume accounts will have to be recreated. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change password hashing to use scrypt 205361124 | |
280605128 | https://github.com/ACEmulator/ACE/pull/36#issuecomment-280605128 | https://api.github.com/repos/ACEmulator/ACE/issues/36 | MDEyOklzc3VlQ29tbWVudDI4MDYwNTEyOA== | Mag-nus 10608427 | 2017-02-17T09:48:15Z | 2017-02-17T09:48:15Z | MEMBER | I'm not fond of the complexity for this. What i'd like to see instead is us merge our updates down into the base sql file at some point, and, in the future, when new updates are added, also update the base sql file as well, so a new install wouldn't need to apply the updates, as they'd be.. up to date. (i'm by no means a db person so i don't know if this is against the norm) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add automatic database migrations to startup 205449659 | |
280605245 | https://github.com/ACEmulator/ACE/pull/37#issuecomment-280605245 | https://api.github.com/repos/ACEmulator/ACE/issues/37 | MDEyOklzc3VlQ29tbWVudDI4MDYwNTI0NQ== | Mag-nus 10608427 | 2017-02-17T09:48:46Z | 2017-02-17T09:48:46Z | MEMBER | rawaho made a change that might have fixed the issue you were trying to fix. I think IP binding should be explicit. We might get a case where a user has 2 ip addresses on the same box and choses to bind each ip to a unique world, using the same port. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add option to send different host address than external host address during world handoff 205454231 | |
280639466 | https://github.com/ACEmulator/ACE/pull/36#issuecomment-280639466 | https://api.github.com/repos/ACEmulator/ACE/issues/36 | MDEyOklzc3VlQ29tbWVudDI4MDYzOTQ2Ng== | Forbiddenz 25387933 | 2017-02-17T12:43:40Z | 2017-02-17T12:43:40Z | CONTRIBUTOR | Hi Mag-nus, The problem with your idea is some asshat will figure out how to screw up their original db. I worked on many production level database patches and they pretty much all start at step x and move forward where x can be the current software version. Your right as a new installer needs to run from version 0 and then if version 50 removes a table in version 0 it will be a useless step and take more time. But the benefits of the system far outweigh the useless garbage. With a design that goes by version and up you can guarantee that the database is always standard and it eliminates the room for error with things getting out of sync or even missed. When you have the step process it's a little more work and sometimes seems dumb but it keeps all the db updates on a forward track even if they seem to be doing things the slow way. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add automatic database migrations to startup 205449659 | |
280717424 | https://github.com/ACEmulator/ACE/pull/37#issuecomment-280717424 | https://api.github.com/repos/ACEmulator/ACE/issues/37 | MDEyOklzc3VlQ29tbWVudDI4MDcxNzQyNA== | LtRipley36706 11369233 | 2017-02-17T17:42:37Z | 2017-02-17T17:42:37Z | MEMBER | it makes sense to me add variables for each ip address we explicitly send. It wouldn't really fix what this PR intention was which is to basically let me set up an external ip for external clients, and an internal ip for internal clients. I understand if its not something we want to put in to the master code, I'll just end up keeping a branch off my fork to roll in each time i update my server. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add option to send different host address than external host address during world handoff 205454231 | |
280844895 | https://github.com/ACEmulator/ACE/pull/73#issuecomment-280844895 | https://api.github.com/repos/ACEmulator/ACE/issues/73 | MDEyOklzc3VlQ29tbWVudDI4MDg0NDg5NQ== | Mogwai-TheFurry 25351661 | 2017-02-18T13:14:51Z | 2017-02-18T13:14:51Z | CONTRIBUTOR | I like it, but you need to resolve the merge conflicts first. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Network Refactor 208616825 | |
280846918 | https://github.com/ACEmulator/ACE/pull/73#issuecomment-280846918 | https://api.github.com/repos/ACEmulator/ACE/issues/73 | MDEyOklzc3VlQ29tbWVudDI4MDg0NjkxOA== | Mag-nus 10608427 | 2017-02-18T13:53:06Z | 2017-02-18T13:53:06Z | MEMBER | Also, double check your namespaces. It looks like GameMessageOpcode isn't in the correct namespace. Namespaces should match the folder depth of the file. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Network Refactor 208616825 | |
280874242 | https://github.com/ACEmulator/ACE/issues/45#issuecomment-280874242 | https://api.github.com/repos/ACEmulator/ACE/issues/45 | MDEyOklzc3VlQ29tbWVudDI4MDg3NDI0Mg== | LtRipley36706 11369233 | 2017-02-18T20:54:14Z | 2017-02-18T20:54:14Z | MEMBER | completed known admin commands. not sure if we need to stub client commands just to protect them from being used as the client handles them already | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Stub CommandHandlers for in-game commands 205647107 | |
280902049 | https://github.com/ACEmulator/ACE/pull/58#issuecomment-280902049 | https://api.github.com/repos/ACEmulator/ACE/issues/58 | MDEyOklzc3VlQ29tbWVudDI4MDkwMjA0OQ== | LtRipley36706 11369233 | 2017-02-19T07:36:04Z | 2017-02-19T07:36:04Z | MEMBER | Ignore this PR, will close shortly. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added support on ACE console for setting per character admin rights and character renaming 207015535 | |
280936571 | https://github.com/ACEmulator/ACE/issues/9#issuecomment-280936571 | https://api.github.com/repos/ACEmulator/ACE/issues/9 | MDEyOklzc3VlQ29tbWVudDI4MDkzNjU3MQ== | Zegeger 12808515 | 2017-02-19T18:09:45Z | 2017-02-19T18:09:45Z | CONTRIBUTOR | You can assign this to me | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rework packet pipe 204506877 | |
280954420 | https://github.com/ACEmulator/ACE/pull/77#issuecomment-280954420 | https://api.github.com/repos/ACEmulator/ACE/issues/77 | MDEyOklzc3VlQ29tbWVudDI4MDk1NDQyMA== | LtRipley36706 11369233 | 2017-02-19T22:20:47Z | 2017-02-20T01:39:40Z | MEMBER | Added functionality for /sudo as described above. example: sudo othercommand othercommandsparamters sudo set-characteraccess charactername admin sudo telepoi arwic the above examples would work on characters not set as admins as long as the account you're logged in as is set with admin privileges. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add AccessLevel to Accounts 208701617 | |
280956235 | https://github.com/ACEmulator/ACE/pull/77#issuecomment-280956235 | https://api.github.com/repos/ACEmulator/ACE/issues/77 | MDEyOklzc3VlQ29tbWVudDI4MDk1NjIzNQ== | LtRipley36706 11369233 | 2017-02-19T22:46:04Z | 2017-02-19T22:46:04Z | MEMBER | Adjusted the set commands to work on both the console and in-game. The first account has to be created via console and also set as an admin for these to work in game. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add AccessLevel to Accounts 208701617 | |
280959920 | https://github.com/ACEmulator/ACE/issues/5#issuecomment-280959920 | https://api.github.com/repos/ACEmulator/ACE/issues/5 | MDEyOklzc3VlQ29tbWVudDI4MDk1OTkyMA== | Mag-nus 10608427 | 2017-02-19T23:44:32Z | 2017-02-19T23:44:32Z | MEMBER | Local (say), and tell now work. Fix: The names are not clickable. Not sure why. Fix: Local (say) is world global for now. It needs a range restriction of some sort. Need to add joining and using of the chat channels (general, trade, etc...) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE Chat System 204489878 | |
280978914 | https://github.com/ACEmulator/ACE/pull/76#issuecomment-280978914 | https://api.github.com/repos/ACEmulator/ACE/issues/76 | MDEyOklzc3VlQ29tbWVudDI4MDk3ODkxNA== | Mogwai-TheFurry 25351661 | 2017-02-20T03:19:57Z | 2017-02-20T03:19:57Z | CONTRIBUTOR | Resolve the conflicts and we'll approve as is. We'll deal with persistence later. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Reworked Appear Offline functionality 208656503 | |
280989331 | https://github.com/ACEmulator/ACE/pull/77#issuecomment-280989331 | https://api.github.com/repos/ACEmulator/ACE/issues/77 | MDEyOklzc3VlQ29tbWVudDI4MDk4OTMzMQ== | LtRipley36706 11369233 | 2017-02-20T05:08:23Z | 2017-02-20T05:08:23Z | MEMBER | @fantoms rightly pointed out that the most recent master changes changed SendSystemMessage to SendServerMessage with an enum argument for message type. Corrected that issue as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add AccessLevel to Accounts 208701617 | |
281144852 | https://github.com/ACEmulator/ACE/issues/9#issuecomment-281144852 | https://api.github.com/repos/ACEmulator/ACE/issues/9 | MDEyOklzc3VlQ29tbWVudDI4MTE0NDg1Mg== | kaos00723 8607407 | 2017-02-20T17:58:04Z | 2017-02-20T17:58:04Z | CONTRIBUTOR | @Zegeger , issues can only be assigned to the issue starter or a member of the org. You're the only person working on this currently so when you submit the PR just reference issue #9 and it will close automatically after being merged. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rework packet pipe 204506877 | |
281223009 | https://github.com/ACEmulator/ACE/issues/20#issuecomment-281223009 | https://api.github.com/repos/ACEmulator/ACE/issues/20 | MDEyOklzc3VlQ29tbWVudDI4MTIyMzAwOQ== | zbuc 570040 | 2017-02-21T01:51:53Z | 2017-02-21T01:51:53Z | CONTRIBUTOR | The script can only recreate the initial database table state completely so it won't be useful for server operators. If it were extended with a second script solely for running upgrades that could keep track of the currently run database upgrades somewhere, for example in a flat-file in a temporary directory, so they wouldn't be run again that would be useful. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server should have a way to apply DB migrations 205353528 | |
281332628 | https://github.com/ACEmulator/ACE/issues/9#issuecomment-281332628 | https://api.github.com/repos/ACEmulator/ACE/issues/9 | MDEyOklzc3VlQ29tbWVudDI4MTMzMjYyOA== | Mogwai-TheFurry 25351661 | 2017-02-21T12:34:45Z | 2017-02-21T12:34:45Z | CONTRIBUTOR | Zegeger's work is now merged. Closing the issue. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rework packet pipe 204506877 | |
281333010 | https://github.com/ACEmulator/ACE/issues/20#issuecomment-281333010 | https://api.github.com/repos/ACEmulator/ACE/issues/20 | MDEyOklzc3VlQ29tbWVudDI4MTMzMzAxMA== | Mogwai-TheFurry 25351661 | 2017-02-21T12:36:41Z | 2017-02-21T12:36:41Z | CONTRIBUTOR | The scripts would need to be altered to be re-run safe. MySQL's support for this is spotty, but it could be done. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server should have a way to apply DB migrations 205353528 | |
281344829 | https://github.com/ACEmulator/ACE/issues/20#issuecomment-281344829 | https://api.github.com/repos/ACEmulator/ACE/issues/20 | MDEyOklzc3VlQ29tbWVudDI4MTM0NDgyOQ== | zbuc 570040 | 2017-02-21T13:31:44Z | 2017-02-21T13:31:44Z | CONTRIBUTOR | For a solution that doesn't require migration authors to worry about that, do something similar to the pull request I created where it tracks the database migrations that have run and only runs them once, in sequential order. That is relatively standard for database-backed applications. You will also run into difficulty with migrations where they are interdependent, i.e. one migration needs to run before another one can be run, because it creates or alters tables used by the other migration. My pull request took all this into account. With your PowerShell solution you could probably track the migrations that have run in a text file or registry key. > On Feb 21, 2017, at 7:36 AM, Mogwai-AC <notifications@github.com> wrote: > > The scripts would need to be altered to be re-run safe. MySQL's support for this is spotty, but it could be done. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or mute the thread. > | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server should have a way to apply DB migrations 205353528 | |
282458956 | https://github.com/ACEmulator/ACE/pull/84#issuecomment-282458956 | https://api.github.com/repos/ACEmulator/ACE/issues/84 | MDEyOklzc3VlQ29tbWVudDI4MjQ1ODk1Ng== | fantoms 37453 | 2017-02-25T04:23:07Z | 2017-02-25T04:23:07Z | CONTRIBUTOR | I was able to get the skills to lock into Infinity!, but the Abilities do not continue to spend after clicking 12 times on the +10 button; in other words - once you spend more then 121 points on abilities specificially, you can't spend anymore on abilities. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill spend upper bound check too prevent xp crash, also Max Skills! 209354215 | |
282489796 | https://github.com/ACEmulator/ACE/issues/5#issuecomment-282489796 | https://api.github.com/repos/ACEmulator/ACE/issues/5 | MDEyOklzc3VlQ29tbWVudDI4MjQ4OTc5Ng== | Mag-nus 10608427 | 2017-02-25T15:09:21Z | 2017-02-25T15:09:21Z | MEMBER | Fix: Local chat still broadcasts globally Test/Fix: Chat Channels (General, LFG, ...) are broadcast to everyone. We should probably check if the recipient subscribes to the channel first before sending the message to them. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE Chat System 204489878 | |
282491222 | https://github.com/ACEmulator/ACE/pull/90#issuecomment-282491222 | https://api.github.com/repos/ACEmulator/ACE/issues/90 | MDEyOklzc3VlQ29tbWVudDI4MjQ5MTIyMg== | Mag-nus 10608427 | 2017-02-25T15:32:31Z | 2017-02-25T15:32:31Z | MEMBER | GameMessageF7E5 should be named GameMessageDDD_Interrogation There's a lot of hard coded group types still: 0x5, 0x9, 0xA, etc.. We should use an enum for the groups. NetworkSession.cs, and anywhere else, should use DateTime.UtcNow instead of DateTime.Now This is a big PR so it will require further review.. I like what I see so far though, can't wait to get this merged.. I'll have to look at it a bit more later, and will want Mogwai to look at it as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rewrote network stack 210217148 | |
282501819 | https://github.com/ACEmulator/ACE/pull/90#issuecomment-282501819 | https://api.github.com/repos/ACEmulator/ACE/issues/90 | MDEyOklzc3VlQ29tbWVudDI4MjUwMTgxOQ== | Mag-nus 10608427 | 2017-02-25T18:14:35Z | 2017-02-25T18:14:35Z | MEMBER | Another thing I'm noticing is that if you connect, close the client with the X when you're in portal space, and reconnect again.. repeat this a few times, the client will eventually crash, and the server seems to stop listening to new connections. Even after the server forcibly removes the clients, new connections are still not being accepted. his happens with DateTime.Now and DateTime.UtcNow I am unable to reproduce these steps on the current main branch. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rewrote network stack 210217148 | |
282635696 | https://github.com/ACEmulator/ACE/pull/90#issuecomment-282635696 | https://api.github.com/repos/ACEmulator/ACE/issues/90 | MDEyOklzc3VlQ29tbWVudDI4MjYzNTY5Ng== | Zegeger 12808515 | 2017-02-27T06:03:32Z | 2017-02-27T06:03:32Z | CONTRIBUTOR | Applied requested changes and I believe fixed the crash issues. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rewrote network stack 210217148 | |
282724765 | https://github.com/ACEmulator/ACE/pull/93#issuecomment-282724765 | https://api.github.com/repos/ACEmulator/ACE/issues/93 | MDEyOklzc3VlQ29tbWVudDI4MjcyNDc2NQ== | LtRipley36706 11369233 | 2017-02-27T13:51:26Z | 2017-02-27T13:51:26Z | MEMBER | see #94 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Support easy permissions in ACEmulator 210350061 | |
282728268 | https://github.com/ACEmulator/ACE/pull/84#issuecomment-282728268 | https://api.github.com/repos/ACEmulator/ACE/issues/84 | MDEyOklzc3VlQ29tbWVudDI4MjcyODI2OA== | Mogwai-TheFurry 25351661 | 2017-02-27T14:03:07Z | 2017-02-27T14:03:07Z | CONTRIBUTOR | Fantoms, we had that giant changeset for the Network overhaul. Rebase this and give it another go and we'll merge it in. | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill spend upper bound check too prevent xp crash, also Max Skills! 209354215 | |
282737851 | https://github.com/ACEmulator/ACE/pull/92#issuecomment-282737851 | https://api.github.com/repos/ACEmulator/ACE/issues/92 | MDEyOklzc3VlQ29tbWVudDI4MjczNzg1MQ== | LtRipley36706 11369233 | 2017-02-27T14:38:23Z | 2017-02-27T14:38:23Z | MEMBER | See #95 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add in support for the old global Admin channels 210289130 | |
282738707 | https://github.com/ACEmulator/ACE/issues/83#issuecomment-282738707 | https://api.github.com/repos/ACEmulator/ACE/issues/83 | MDEyOklzc3VlQ29tbWVudDI4MjczODcwNw== | Zegeger 12808515 | 2017-02-27T14:41:26Z | 2017-02-27T14:41:26Z | CONTRIBUTOR | Completed in PR 90 NetworkBuffer became NetworkSession | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add message buffering and send as multifragment packet 209201688 | |
283558190 | https://github.com/ACEmulator/ACE/pull/84#issuecomment-283558190 | https://api.github.com/repos/ACEmulator/ACE/issues/84 | MDEyOklzc3VlQ29tbWVudDI4MzU1ODE5MA== | fantoms 37453 | 2017-03-02T05:11:09Z | 2017-03-02T05:11:09Z | CONTRIBUTOR | I believe this is ready for a another eye if it is worth having Skills raise to max skill level. The abilities are not working; example: when you go above 221 on strength. Here is a packet capture showing the abilities issue: http://pastebin.com/Bn5Sjew6 Thanks! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill spend upper bound check too prevent xp crash, also Max Skills! 209354215 | |
283644641 | https://github.com/ACEmulator/ACE/pull/84#issuecomment-283644641 | https://api.github.com/repos/ACEmulator/ACE/issues/84 | MDEyOklzc3VlQ29tbWVudDI4MzY0NDY0MQ== | Mogwai-TheFurry 25351661 | 2017-03-02T12:47:49Z | 2017-03-02T12:47:49Z | CONTRIBUTOR | 102 files changed? I can't tell what's your PR vs what was a merge. Can you create a new branch and cherry pick the commits that have your code and resubmit? I just have no way of telling what was yours versus what was merged stuff. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill spend upper bound check too prevent xp crash, also Max Skills! 209354215 | |
283647919 | https://github.com/ACEmulator/ACE/pull/84#issuecomment-283647919 | https://api.github.com/repos/ACEmulator/ACE/issues/84 | MDEyOklzc3VlQ29tbWVudDI4MzY0NzkxOQ== | fantoms 37453 | 2017-03-02T13:03:43Z | 2017-03-02T13:03:43Z | CONTRIBUTOR | I will start over on this PR, the changes are minimal but a rebase did not work as expected. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill spend upper bound check too prevent xp crash, also Max Skills! 209354215 | |
284311511 | https://github.com/ACEmulator/ACE/pull/107#issuecomment-284311511 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | MDEyOklzc3VlQ29tbWVudDI4NDMxMTUxMQ== | ghost 10137 | 2017-03-06T06:13:51Z | 2017-03-06T06:13:51Z | NONE | So the file names themselves would be hard-coded and just pull in the directory location from the config file, thereby allowing the two config directives to condense into one. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add DAT loading into main process 211999671 | |
284312826 | https://github.com/ACEmulator/ACE/pull/107#issuecomment-284312826 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | MDEyOklzc3VlQ29tbWVudDI4NDMxMjgyNg== | LtRipley36706 11369233 | 2017-03-06T06:25:16Z | 2017-03-06T06:25:16Z | MEMBER | Exactly. I can't imagine a reason why the file names couldn't or shouldn't be hardcoded, but I can think of a few reasons why one might want to change the directory location. One of which could be having multiple versions of DAT patches to switch between perhaps? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add DAT loading into main process 211999671 | |
284313391 | https://github.com/ACEmulator/ACE/issues/56#issuecomment-284313391 | https://api.github.com/repos/ACEmulator/ACE/issues/56 | MDEyOklzc3VlQ29tbWVudDI4NDMxMzM5MQ== | LtRipley36706 11369233 | 2017-03-06T06:29:28Z | 2017-03-06T06:29:28Z | MEMBER | This issue possibly links with a TODO in #108 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Background maintenance thread 206955987 | |
284326453 | https://github.com/ACEmulator/ACE/pull/107#issuecomment-284326453 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | MDEyOklzc3VlQ29tbWVudDI4NDMyNjQ1Mw== | ghost 10137 | 2017-03-06T07:59:00Z | 2017-03-06T07:59:00Z | NONE | Stupid tab vs spaces kept tripping me up. I also noticed that I missed a whole file that should have been included in the original commit. 'git add <filename>, ftw. It has now been added into the PR with the changes to the config variable(s). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add DAT loading into main process 211999671 | |
284556139 | https://github.com/ACEmulator/ACE/pull/109#issuecomment-284556139 | https://api.github.com/repos/ACEmulator/ACE/issues/109 | MDEyOklzc3VlQ29tbWVudDI4NDU1NjEzOQ== | Forbiddenz 25387933 | 2017-03-06T22:33:12Z | 2017-03-06T22:33:12Z | CONTRIBUTOR | Fixed, | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World Object Fix 212215798 | |
285084104 | https://github.com/ACEmulator/ACE/pull/21#issuecomment-285084104 | https://api.github.com/repos/ACEmulator/ACE/issues/21 | MDEyOklzc3VlQ29tbWVudDI4NTA4NDEwNA== | Thwargle 25650194 | 2017-03-08T16:07:10Z | 2017-03-08T16:07:10Z | NONE | Technically; we DO have a launcher. I will work with whoever necessary to implement this into the launcher when ready. It's currently stable and fully featured as far as i can tell; so it's at a stage where implementing true password passing between server and client launch is reasonable. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change password hashing to use scrypt 205361124 | |
285278550 | https://github.com/ACEmulator/ACE/pull/58#issuecomment-285278550 | https://api.github.com/repos/ACEmulator/ACE/issues/58 | MDEyOklzc3VlQ29tbWVudDI4NTI3ODU1MA== | LtRipley36706 11369233 | 2017-03-09T07:44:47Z | 2017-03-09T07:44:47Z | MEMBER | PR #116 addresses the last change this PR was working on. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added support on ACE console for setting per character admin rights and character renaming 207015535 | |
285877915 | https://github.com/ACEmulator/ACE/issues/52#issuecomment-285877915 | https://api.github.com/repos/ACEmulator/ACE/issues/52 | MDEyOklzc3VlQ29tbWVudDI4NTg3NzkxNQ== | fantoms 37453 | 2017-03-11T16:13:01Z | 2017-03-11T16:53:37Z | CONTRIBUTOR | Please review Pull Request #119, which should now close most of the requirements for this issue. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Leveling up when granted xp 206403292 | |
285880069 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285880069 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTg4MDA2OQ== | lurker-mcdoogle 26334665 | 2017-03-11T16:47:30Z | 2017-03-11T16:47:30Z | CONTRIBUTOR | Hrm, noticed some bugs around objects not getting into the landblock collection. Not mergeworthy yet, but feel free to comment. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);