issue_comments
Data license: AGPL · Data source: ACEmulator Project
1,646 rows sorted by author_association
This data as json, CSV (advanced)
Suggested facets: author_association, reactions, created_at (date), updated_at (date)
id | html_url | issue_url | node_id | user | created_at | updated_at | author_association ▼ | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
298197186 | https://github.com/ACEmulator/ACE/pull/305#issuecomment-298197186 | https://api.github.com/repos/ACEmulator/ACE/issues/305 | MDEyOklzc3VlQ29tbWVudDI5ODE5NzE4Ng== | OptimShi 26606778 | 2017-04-29T22:00:40Z | 2017-04-29T22:00:40Z | COLLABORATOR | Per discussion, I modified this to only spit out debug info on "DebugObjects" (as opposed to proper WorldObjects, which as of now are players, life stones and portals.) Also added the WeenieClassId for further debugging fun (which required modifying how this works a little bit, but all for the best) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Hooked up the IdentifyObject event and returned a debug string. 225231282 | |
299530392 | https://github.com/ACEmulator/ACE/pull/329#issuecomment-299530392 | https://api.github.com/repos/ACEmulator/ACE/issues/329 | MDEyOklzc3VlQ29tbWVudDI5OTUzMDM5Mg== | OptimShi 26606778 | 2017-05-05T17:46:23Z | 2017-05-05T17:46:23Z | COLLABORATOR | A couple of pushes later, and the whitespace issues seems to be resolved in this PR. (Note that the bulk of the differences in the existing files are now indentation related, which is by design) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Dat Updates 226473134 | |
303568386 | https://github.com/ACEmulator/ACE/pull/347#issuecomment-303568386 | https://api.github.com/repos/ACEmulator/ACE/issues/347 | MDEyOklzc3VlQ29tbWVudDMwMzU2ODM4Ng== | OptimShi 26606778 | 2017-05-23T23:43:12Z | 2017-05-23T23:43:12Z | COLLABORATOR | I fixed the merge errors to crept into this PR... Should be good-to-go now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Spell Tables 230115789 | |
306667274 | https://github.com/ACEmulator/ACE/pull/369#issuecomment-306667274 | https://api.github.com/repos/ACEmulator/ACE/issues/369 | MDEyOklzc3VlQ29tbWVudDMwNjY2NzI3NA== | OptimShi 26606778 | 2017-06-07T02:21:08Z | 2017-06-07T02:21:08Z | COLLABORATOR | The requested changes have been made. Thanks for the feedback, I didn't dive that deep into how the AceObject/AceCharacter functioned, so your requests made me do that and learn a little more about how it works (which will be useful for when we need to take these visual properties and add them to the overrides on load) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Read character creation values from client_portal.dat 234029220 | |
312965275 | https://github.com/ACEmulator/ACE/pull/448#issuecomment-312965275 | https://api.github.com/repos/ACEmulator/ACE/issues/448 | MDEyOklzc3VlQ29tbWVudDMxMjk2NTI3NQ== | fartwhif 3317737 | 2017-07-04T23:10:37Z | 2017-07-04T23:10:37Z | COLLABORATOR | tried it out, very cool | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Barber 240497866 | |
313542058 | https://github.com/ACEmulator/ACE/pull/448#issuecomment-313542058 | https://api.github.com/repos/ACEmulator/ACE/issues/448 | MDEyOklzc3VlQ29tbWVudDMxMzU0MjA1OA== | OptimShi 26606778 | 2017-07-06T23:00:29Z | 2017-07-06T23:00:29Z | COLLABORATOR | I moved the Barber functions into an ActionChain, as requested. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Barber 240497866 | |
313568781 | https://github.com/ACEmulator/ACE/pull/452#issuecomment-313568781 | https://api.github.com/repos/ACEmulator/ACE/issues/452 | MDEyOklzc3VlQ29tbWVudDMxMzU2ODc4MQ== | OptimShi 26606778 | 2017-07-07T02:14:20Z | 2017-07-07T02:14:20Z | COLLABORATOR | Note that this requires an updated `vw_ace_character` view. SQL is in the "Database/Updates/Shard" folder. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character list will automatically select your last played character. 241137628 | |
317060514 | https://github.com/ACEmulator/ACE/pull/470#issuecomment-317060514 | https://api.github.com/repos/ACEmulator/ACE/issues/470 | MDEyOklzc3VlQ29tbWVudDMxNzA2MDUxNA== | OptimShi 26606778 | 2017-07-21T17:19:36Z | 2017-07-21T17:19:36Z | COLLABORATOR | I approve this. (Except I can't actually "approve" it.) Confirmed it works and fixes the issue we were running into. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for SetupModel Crash 244724119 | |
321631507 | https://github.com/ACEmulator/ACE/pull/490#issuecomment-321631507 | https://api.github.com/repos/ACEmulator/ACE/issues/490 | MDEyOklzc3VlQ29tbWVudDMyMTYzMTUwNw== | OptimShi 26606778 | 2017-08-10T18:14:27Z | 2017-08-10T18:14:27Z | COLLABORATOR | Would this not cause a conflict if I actually added an inscription to a book item? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Minor changes to Book weenie 249430547 | |
321637432 | https://github.com/ACEmulator/ACE/pull/490#issuecomment-321637432 | https://api.github.com/repos/ACEmulator/ACE/issues/490 | MDEyOklzc3VlQ29tbWVudDMyMTYzNzQzMg== | OptimShi 26606778 | 2017-08-10T18:37:31Z | 2017-08-10T18:37:31Z | COLLABORATOR | What if I write in a Parchment (wcid 36), then give it to someone who adds an inscription? (Note that the handful of prewritten books I quickly checked were not inscribable, but blank ones are) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Minor changes to Book weenie 249430547 | |
321961409 | https://github.com/ACEmulator/ACE/pull/493#issuecomment-321961409 | https://api.github.com/repos/ACEmulator/ACE/issues/493 | MDEyOklzc3VlQ29tbWVudDMyMTk2MTQwOQ== | OptimShi 26606778 | 2017-08-12T06:34:02Z | 2017-08-12T06:34:02Z | COLLABORATOR | I believe I got that bug with the spells with extended characters in their names/description sorted out, too. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Spell Formula 249519682 | |
322932143 | https://github.com/ACEmulator/ACE/pull/495#issuecomment-322932143 | https://api.github.com/repos/ACEmulator/ACE/issues/495 | MDEyOklzc3VlQ29tbWVudDMyMjkzMjE0Mw== | OptimShi 26606778 | 2017-08-17T00:03:04Z | 2017-08-17T00:03:04Z | COLLABORATOR | All feedback implemented except the one I noted. Thanks for the help with this, I've learned a little bit about some C# workings--which is always good! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Added Animation parsing from the client_portal.dat and all relevant hooks and properties. 250506086 | |
323408769 | https://github.com/ACEmulator/ACE/pull/496#issuecomment-323408769 | https://api.github.com/repos/ACEmulator/ACE/issues/496 | MDEyOklzc3VlQ29tbWVudDMyMzQwODc2OQ== | OptimShi 26606778 | 2017-08-18T17:07:19Z | 2017-08-18T17:07:19Z | COLLABORATOR | I ran this and everything appeared to work as expected. Fixed the intermittent "garbled" book data we were experiencing, as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix multifragment packetization logic 250743171 | |
330713090 | https://github.com/ACEmulator/ACE/pull/511#issuecomment-330713090 | https://api.github.com/repos/ACEmulator/ACE/issues/511 | MDEyOklzc3VlQ29tbWVudDMzMDcxMzA5MA== | OptimShi 26606778 | 2017-09-20T00:45:49Z | 2017-09-20T00:45:49Z | COLLABORATOR | I believe this is it. It worked for me, at least. ShardDatabase.cs, line 935... Should be transaction.AddPreparedDeleteStatement<ShardPreparedStatement, AceObjectPropertiesInstanceId>(ShardPreparedStatement.DeleteAceObjectPropertyIid, prop); DeleteAceObjectPropertyIid, singular, not Properties, plural. (Might as well fix line 905 while you're at it, same issue I would think with Did | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Don't bend the knee - Wielded items persisted and a few old bugs squashed. READY TO MERGE 258986168 | |
350334794 | https://github.com/ACEmulator/ACE/pull/577#issuecomment-350334794 | https://api.github.com/repos/ACEmulator/ACE/issues/577 | MDEyOklzc3VlQ29tbWVudDM1MDMzNDc5NA== | Nalindar 14854251 | 2017-12-08T18:20:27Z | 2017-12-08T18:20:27Z | COLLABORATOR | yup, wasn't meant to be an end-all fix :p kill the pr if you'd like, just learning the process. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Account name check at creation 279835071 | |
360358183 | https://github.com/ACEmulator/ACE/pull/600#issuecomment-360358183 | https://api.github.com/repos/ACEmulator/ACE/issues/600 | MDEyOklzc3VlQ29tbWVudDM2MDM1ODE4Mw== | dgatewood 10187880 | 2018-01-25T04:32:48Z | 2018-01-25T04:32:48Z | COLLABORATOR | will try to reopen as a fork/branch when I have time to mess with it | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Typo with that last one 291082473 | |
360881791 | https://github.com/ACEmulator/ACE/pull/602#issuecomment-360881791 | https://api.github.com/repos/ACEmulator/ACE/issues/602 | MDEyOklzc3VlQ29tbWVudDM2MDg4MTc5MQ== | dgatewood 10187880 | 2018-01-26T19:30:37Z | 2018-01-26T19:30:37Z | COLLABORATOR | I will change this later on tonight and fix the appveyor issues. Didn't check it last night before bed | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | UpdateEnchantment/Gem OnUse 291799764 | |
386069320 | https://github.com/ACEmulator/ACE/pull/777#issuecomment-386069320 | https://api.github.com/repos/ACEmulator/ACE/issues/777 | MDEyOklzc3VlQ29tbWVudDM4NjA2OTMyMA== | dgatewood 10187880 | 2018-05-02T18:08:21Z | 2018-05-02T18:08:21Z | COLLABORATOR | Looks good to me. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding monster movement 319384596 | |
387702390 | https://github.com/ACEmulator/ACE/issues/784#issuecomment-387702390 | https://api.github.com/repos/ACEmulator/ACE/issues/784 | MDEyOklzc3VlQ29tbWVudDM4NzcwMjM5MA== | gmriggs 8909245 | 2018-05-09T10:59:12Z | 2018-05-09T10:59:12Z | COLLABORATOR | Objects loading from DAT should reference a static immutable instance by default. Only when fields are changed should a new mutable property be created. See the ModelMesh class for an example Vertex indices / buffers should also be utilized where appropriate | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks use a lot of memory 321519680 | |
388520872 | https://github.com/ACEmulator/ACE/issues/780#issuecomment-388520872 | https://api.github.com/repos/ACEmulator/ACE/issues/780 | MDEyOklzc3VlQ29tbWVudDM4ODUyMDg3Mg== | gmriggs 8909245 | 2018-05-12T01:29:59Z | 2018-05-12T01:29:59Z | COLLABORATOR | This issue has been fixed in https://github.com/ACEmulator/ACE/pull/787 Thanks for the bug report! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Single cast Double damage/Attack 320807124 | |
388587011 | https://github.com/ACEmulator/ACE/pull/790#issuecomment-388587011 | https://api.github.com/repos/ACEmulator/ACE/issues/790 | MDEyOklzc3VlQ29tbWVudDM4ODU4NzAxMQ== | gmriggs 8909245 | 2018-05-12T22:13:59Z | 2018-05-12T22:13:59Z | COLLABORATOR | Tested everything, looks good | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | @nudge @nudge, got some @crack 322522831 | |
388863475 | https://github.com/ACEmulator/ACE/pull/791#issuecomment-388863475 | https://api.github.com/repos/ACEmulator/ACE/issues/791 | MDEyOklzc3VlQ29tbWVudDM4ODg2MzQ3NQ== | gmriggs 8909245 | 2018-05-14T15:41:38Z | 2018-05-14T15:41:38Z | COLLABORATOR | Looks good for the success case For the non success case, no text message is sent, and client gets perma hourglass Still should be good to merge... | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | lockpicking doors 322650543 | |
389036956 | https://github.com/ACEmulator/ACE/pull/789#issuecomment-389036956 | https://api.github.com/repos/ACEmulator/ACE/issues/789 | MDEyOklzc3VlQ29tbWVudDM4OTAzNjk1Ng== | dgatewood 10187880 | 2018-05-15T04:10:58Z | 2018-05-15T04:10:58Z | COLLABORATOR | This looks good to go for me. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding monster melee combat 322496552 | |
389637736 | https://github.com/ACEmulator/ACE/pull/793#issuecomment-389637736 | https://api.github.com/repos/ACEmulator/ACE/issues/793 | MDEyOklzc3VlQ29tbWVudDM4OTYzNzczNg== | gmriggs 8909245 | 2018-05-16T19:28:29Z | 2018-05-16T19:28:29Z | COLLABORATOR | Tested, works great! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | EmoteTable Stuff 323325896 | |
390083160 | https://github.com/ACEmulator/ACE/pull/794#issuecomment-390083160 | https://api.github.com/repos/ACEmulator/ACE/issues/794 | MDEyOklzc3VlQ29tbWVudDM5MDA4MzE2MA== | dgatewood 10187880 | 2018-05-18T03:24:56Z | 2018-05-18T03:25:13Z | COLLABORATOR | Yep, these should be approved | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding monster spell casting 323359446 | |
390408611 | https://github.com/ACEmulator/ACE/pull/796#issuecomment-390408611 | https://api.github.com/repos/ACEmulator/ACE/issues/796 | MDEyOklzc3VlQ29tbWVudDM5MDQwODYxMQ== | gmriggs 8909245 | 2018-05-19T14:27:27Z | 2018-05-19T14:27:27Z | COLLABORATOR | Basics tested, looks good to me | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creating salvage from items... 324593612 | |
390457070 | https://github.com/ACEmulator/ACE/pull/798#issuecomment-390457070 | https://api.github.com/repos/ACEmulator/ACE/issues/798 | MDEyOklzc3VlQ29tbWVudDM5MDQ1NzA3MA== | gmriggs 8909245 | 2018-05-20T04:32:16Z | 2018-05-20T04:34:00Z | COLLABORATOR | hey mcreedjr, Thanks for the awesome PR! This is definitely a very useful admin command, and should help a lot with testing :) I've thought about adding a similar command, as well as something to help with managing spell components... ie., something to add components for all known spells, or perhaps a way to disable the spell component requirement when casting spells This PR surely seems great to me, and I have set it to approved for merging Some additional notes: - Should the command add spells for magic schools the player is not trained in? I guess a player could always train additional magic skills later, so this should still be fine - When running this command, I started to receive WARN : [Unverified] Packet # received again messages in the log. I had to disconnect the character by closing the client, and restart to fix the messages. I assume this is an issue with the networking code, and not anything with the new code... perhaps something to do with sending such a large # of packets? Just some notes, everything in the PR still looks great to me :) Thanks for the great contribution! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | @addallspells dev command 324681949 | |
391195980 | https://github.com/ACEmulator/ACE/issues/782#issuecomment-391195980 | https://api.github.com/repos/ACEmulator/ACE/issues/782 | MDEyOklzc3VlQ29tbWVudDM5MTE5NTk4MA== | fartwhif 3317737 | 2018-05-23T01:59:26Z | 2018-05-23T01:59:26Z | COLLABORATOR | To Reproduce at baff0fa 1. Go to Yaraq. 2. Buy an empty flask from the shopkeep. 3. Use the empty flask on the pool outside. *you get an additional item water, (not sure if this is supposed to consume the flask, unrelated?)* - the guid for the new item is being duplicated? (just a hunch) 4. Put the empty flask you just used in the shortcut bar. 5. do /save-now, you get an exception (Exception 1) 6. do /save-now again, you get a different exception (Exception 2) **Exception 1** 2018-05-22 21:41:08,629 ERROR: SaveBiota failed with exception: Microsoft.EntityFrameworkCore.DbUpdateException: An error occurred while updating the entries. See the inner exception for details. ---> MySql.Data.MySqlClient.MySqlException: Cannot add or update a child row: a foreign key constraint fails (`ace_shard`.`biota_properties_shortcut_bar`, CONSTRAINT `wcid_shortcut_objectId` FOREIGN KEY (`shortcut_Object_Id`) REFERENCES `biota` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION) ---> MySql.Data.MySqlClient.MySqlException: Cannot add or update a child row: a foreign key constraint fails (`ace_shard`.`biota_properties_shortcut_bar`, CONSTRAINT `wcid_shortcut_objectId` FOREIGN KEY (`shortcut_Object_Id`) REFERENCES `biota` (`id`) ON DELETE CASCADE ON UPDATE NO ACTION) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult() at MySqlConnector.Core.ResultSet.<ReadResultSetHeaderAsync>d__1.MoveNext() in C:\projects\mysqlconnector\src\MySqlConnector\Core\ResultSet.cs:line 43 --- End of inner exception stack trace --- at MySql.Data.MySqlClient.MySqlDataReader.ActivateResultSet(ResultSet resultSet) in C:\projects\mysqlconnector\src\MySqlConnector\MySql.Data.MySqlClient\MySqlDataReader.cs:line 92 at MySql.Data.MySqlClient.MySqlDataReader.<NextResultAsync>d__5.MoveNext() in C:\projects\mysqlconnector\… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Shortcuts can cause db exceptions with foreign keys 321517937 | |
391407306 | https://github.com/ACEmulator/ACE/issues/617#issuecomment-391407306 | https://api.github.com/repos/ACEmulator/ACE/issues/617 | MDEyOklzc3VlQ29tbWVudDM5MTQwNzMwNg== | fartwhif 3317737 | 2018-05-23T16:16:05Z | 2018-05-23T16:16:05Z | COLLABORATOR | SurfaceTexture #802 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE.DatLoader unsupported file types 294216436 | |
392999492 | https://github.com/ACEmulator/ACE/pull/810#issuecomment-392999492 | https://api.github.com/repos/ACEmulator/ACE/issues/810 | MDEyOklzc3VlQ29tbWVudDM5Mjk5OTQ5Mg== | fartwhif 3317737 | 2018-05-30T01:19:22Z | 2018-05-30T01:19:22Z | COLLABORATOR | Refreshing Fountain: 0x01340104 [9.932210 -30.072201 0.005000] -0.926829 0.000000 0.000000 0.375485 acid pit: 0x526E0136 [35.630459 -70.951530 -35.994999] 0.544062 0.000000 0.000000 0.839045 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | added Hotspot WorldObject 327142346 | |
394328496 | https://github.com/ACEmulator/ACE/pull/815#issuecomment-394328496 | https://api.github.com/repos/ACEmulator/ACE/issues/815 | MDEyOklzc3VlQ29tbWVudDM5NDMyODQ5Ng== | fartwhif 3317737 | 2018-06-04T11:53:06Z | 2018-06-04T11:53:06Z | COLLABORATOR | very nice | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Switch Refactor 328928199 | |
396208314 | https://github.com/ACEmulator/ACE/pull/820#issuecomment-396208314 | https://api.github.com/repos/ACEmulator/ACE/issues/820 | MDEyOklzc3VlQ29tbWVudDM5NjIwODMxNA== | gmriggs 8909245 | 2018-06-11T11:14:57Z | 2018-06-11T11:14:57Z | COLLABORATOR | Hey deadlyelectron, Thanks for the PR! There is a lot to review here, but I will be checking everything out over the course of the next day or so :) Thanks again for all the help, it is much appreciated :) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add a configurable property storing database to resolve issue #753 330991743 | |
396216413 | https://github.com/ACEmulator/ACE/pull/820#issuecomment-396216413 | https://api.github.com/repos/ACEmulator/ACE/issues/820 | MDEyOklzc3VlQ29tbWVudDM5NjIxNjQxMw== | gmriggs 8909245 | 2018-06-11T11:50:17Z | 2018-06-11T11:50:17Z | COLLABORATOR | Tested and looks good to me from a functionality and coding standpoint The only issue I ran into was the Config.json.example file had to be manually updated to include the new Config database Other than that, looks good to me! @LtRipley36706 or @Mag-nus could maybe offer some better insights as to if the database implementation matches up with everything as expected Thanks again, great work :) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add a configurable property storing database to resolve issue #753 330991743 | |
397153672 | https://github.com/ACEmulator/ACE/pull/823#issuecomment-397153672 | https://api.github.com/repos/ACEmulator/ACE/issues/823 | MDEyOklzc3VlQ29tbWVudDM5NzE1MzY3Mg== | fartwhif 3317737 | 2018-06-14T02:53:41Z | 2018-06-14T02:53:41Z | COLLABORATOR | work in progress | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | add ability to /tele players by name 332229599 | |
397154738 | https://github.com/ACEmulator/ACE/pull/823#issuecomment-397154738 | https://api.github.com/repos/ACEmulator/ACE/issues/823 | MDEyOklzc3VlQ29tbWVudDM5NzE1NDczOA== | gmriggs 8909245 | 2018-06-14T02:58:46Z | 2018-06-14T03:00:14Z | COLLABORATOR | tested /tele <coords> <player> command, functionality looks good | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | add ability to /tele players by name 332229599 | |
397956847 | https://github.com/ACEmulator/ACE/pull/825#issuecomment-397956847 | https://api.github.com/repos/ACEmulator/ACE/issues/825 | MDEyOklzc3VlQ29tbWVudDM5Nzk1Njg0Nw== | gmriggs 8909245 | 2018-06-18T06:44:49Z | 2018-06-18T06:47:59Z | COLLABORATOR | Initial Allegiance system completed Todo: - the AllPlayers / offline players system in WorldManager needs to be revised - Player_Allegance still has a couple of lingering fields (CPTithed, CPCached) that i haven't been able to find a place for the in DB | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding Allegiance system 333031903 | |
398159860 | https://github.com/ACEmulator/ACE/pull/826#issuecomment-398159860 | https://api.github.com/repos/ACEmulator/ACE/issues/826 | MDEyOklzc3VlQ29tbWVudDM5ODE1OTg2MA== | gmriggs 8909245 | 2018-06-18T18:59:11Z | 2018-06-18T18:59:11Z | COLLABORATOR | looks good! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Unequip and burden correction 333377752 | |
399084907 | https://github.com/ACEmulator/ACE/issues/718#issuecomment-399084907 | https://api.github.com/repos/ACEmulator/ACE/issues/718 | MDEyOklzc3VlQ29tbWVudDM5OTA4NDkwNw== | gmriggs 8909245 | 2018-06-21T12:22:52Z | 2018-06-21T12:23:26Z | COLLABORATOR | Possible technologies / libraries mentioned: **System.Reactive / ReactiveUI** - http://reactivex.io/ (gmriggs, initial investigation seemed like Dictionary support w/ updates was not an exact fit) **LINQ expressions** - https://msdn.microsoft.com/en-us/library/system.linq.expressions.expression(v=vs.110).aspx, https://jacksondunstan.com/articles/3199 (fartwhif, mentioned that he used these to build a similar API) **WCF** - https://docs.microsoft.com/en-us/dotnet/framework/wcf/whats-wcf (Magnus, contract-based model) **OData Open Data Protocol** - https://en.wikipedia.org/wiki/Open_Data_Protocol, https://stackoverflow.com/questions/15154469/is-there-a-odata-query-to-linq-where-expression-odata-to-linq (parad0x, looks very promising. LINQ support, and starts to add more functionality for REST WebAPI) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE.Server needs to expose an API for diagnostics and other information 310644605 | |
402034105 | https://github.com/ACEmulator/ACE/pull/842#issuecomment-402034105 | https://api.github.com/repos/ACEmulator/ACE/issues/842 | MDEyOklzc3VlQ29tbWVudDQwMjAzNDEwNQ== | OptimShi 26606778 | 2018-07-03T07:02:05Z | 2018-07-03T07:02:05Z | COLLABORATOR | This resolves issue #691 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Save Window Position 337754401 | |
402220730 | https://github.com/ACEmulator/ACE/pull/842#issuecomment-402220730 | https://api.github.com/repos/ACEmulator/ACE/issues/842 | MDEyOklzc3VlQ29tbWVudDQwMjIyMDczMA== | OptimShi 26606778 | 2018-07-03T16:43:15Z | 2018-07-03T16:43:15Z | COLLABORATOR | Added the null check so newbs shouldn't crash the server by having the audacity of logging in! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Save Window Position 337754401 | |
403174120 | https://github.com/ACEmulator/ACE/issues/807#issuecomment-403174120 | https://api.github.com/repos/ACEmulator/ACE/issues/807 | MDEyOklzc3VlQ29tbWVudDQwMzE3NDEyMA== | gmriggs 8909245 | 2018-07-07T00:09:18Z | 2018-07-07T00:09:45Z | COLLABORATOR | Fixed: https://github.com/ACEmulator/ACE/pull/851/commits/a37fa697dc5a5dd1796a6fb6a8a0486830a29294 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | melee damage amount anomaly 326754834 | |
403179294 | https://github.com/ACEmulator/ACE/issues/691#issuecomment-403179294 | https://api.github.com/repos/ACEmulator/ACE/issues/691 | MDEyOklzc3VlQ29tbWVudDQwMzE3OTI5NA== | gmriggs 8909245 | 2018-07-07T01:24:55Z | 2018-07-07T01:24:55Z | COLLABORATOR | Fixed by @OptimShi: https://github.com/ACEmulator/ACE/pull/842/files | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE doesn't restore the clients UI window positions 306272888 | |
403237875 | https://github.com/ACEmulator/ACE/pull/851#issuecomment-403237875 | https://api.github.com/repos/ACEmulator/ACE/issues/851 | MDEyOklzc3VlQ29tbWVudDQwMzIzNzg3NQ== | gmriggs 8909245 | 2018-07-07T19:27:00Z | 2018-07-07T19:27:00Z | COLLABORATOR | - Fixed an issue with monsters spawning outside of cell boundaries - Fixed another issue with monsters freezing and not re-chasing player | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improved monster transitions between landblocks and cell boundaries 339086874 | |
403251992 | https://github.com/ACEmulator/ACE/pull/852#issuecomment-403251992 | https://api.github.com/repos/ACEmulator/ACE/issues/852 | MDEyOklzc3VlQ29tbWVudDQwMzI1MTk5Mg== | OptimShi 26606778 | 2018-07-08T00:26:59Z | 2018-07-08T00:27:21Z | COLLABORATOR | To test, you can export all the images like this: `image-export <export-directory-without-spaces> [id]` There will be ~21,000, more if you load the highres dat. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Image Export 339118553 | |
403373270 | https://github.com/ACEmulator/ACE/pull/852#issuecomment-403373270 | https://api.github.com/repos/ACEmulator/ACE/issues/852 | MDEyOklzc3VlQ29tbWVudDQwMzM3MzI3MA== | gmriggs 8909245 | 2018-07-09T06:29:44Z | 2018-07-09T06:29:44Z | COLLABORATOR | Tested image-export command. Worked as expected Very cool, this will definitely be useful! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Image Export 339118553 | |
403378655 | https://github.com/ACEmulator/ACE/pull/857#issuecomment-403378655 | https://api.github.com/repos/ACEmulator/ACE/issues/857 | MDEyOklzc3VlQ29tbWVudDQwMzM3ODY1NQ== | gmriggs 8909245 | 2018-07-09T06:57:00Z | 2018-07-09T06:57:00Z | COLLABORATOR | Tested, functionality worked as expected Before patching, I logged in with a character who had a magical item already equipped, and verified that the mana was not being depleted (pre-patch) Still pre-patch, I dequipped and re-equipped the sword, and verified that the mana was indeed being depleted after re-equipping. I also noticed that equipping magic items instantly used 1 mana upon wielding, not sure if that is intended / matches retail? After patching, I logged in with the character while they had the magic sword already equipped, and the mana started ticking properly. The spells for the wielded item also appeared in the player's enchantments properly The 'IsAffecting' nomenclanture seems a bit non-standard to me (IsActivated?) but that is just a personal preference Nice job with this patch, it really makes things feel more consistent! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | persistent tracking of item affectance 339260691 | |
403551335 | https://github.com/ACEmulator/ACE/pull/857#issuecomment-403551335 | https://api.github.com/repos/ACEmulator/ACE/issues/857 | MDEyOklzc3VlQ29tbWVudDQwMzU1MTMzNQ== | fartwhif 3317737 | 2018-07-09T17:10:45Z | 2018-07-09T17:39:39Z | COLLABORATOR | Thanks for the testing and critique! If I remember correctly retail did have items burn 1 point of mana immediately upon equipping (and successfully activating) it. I actually went and changed ACE to match that pattern (mana stone PR). Hopefully the "affecting" nomenclature doesn't collide with any concepts in the questing systems. maybe it was for questing, and "hot" or something else is actually for this concept, we will see. I came up with "activated" in the mana stone PR because there is no property with that name and I needed something non-persistent and unique to hold out until the persistence PR. "affecting" is part of the WorldObject property lists which is why I chose it for persistence, a guess that it's the correct one as there are a few others that have plausibly compatible names. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | persistent tracking of item affectance 339260691 | |
403591666 | https://github.com/ACEmulator/ACE/issues/784#issuecomment-403591666 | https://api.github.com/repos/ACEmulator/ACE/issues/784 | MDEyOklzc3VlQ29tbWVudDQwMzU5MTY2Ng== | OptimShi 26606778 | 2018-07-09T19:21:50Z | 2018-07-09T19:21:50Z | COLLABORATOR | For reference, the console command is "loadalllandblocks" - Loads all Landblocks. This is VERY crude. Do NOT use it on a live server!!! It will likely crash the server. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks use a lot of memory 321519680 | |
404075495 | https://github.com/ACEmulator/ACE/pull/850#issuecomment-404075495 | https://api.github.com/repos/ACEmulator/ACE/issues/850 | MDEyOklzc3VlQ29tbWVudDQwNDA3NTQ5NQ== | gmriggs 8909245 | 2018-07-11T07:41:30Z | 2018-07-11T07:41:30Z | COLLABORATOR | Test instructions from https://github.com/ACEmulator/ACE/pull/843: Create a new 22754 (for the specialization dungeon) keep clicking through the replies and watch for Jevak... when he asks for essence of jevak, give him @ci 777 Tested in-game, looks great from a functionality perspective! For the requested code changes, I think it would be best if we merged this PR now, and I can help with refactoring the EmoteManager code in the future | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Emote/Quests 338900517 | |
404319286 | https://github.com/ACEmulator/ACE/pull/867#issuecomment-404319286 | https://api.github.com/repos/ACEmulator/ACE/issues/867 | MDEyOklzc3VlQ29tbWVudDQwNDMxOTI4Ng== | OptimShi 26606778 | 2018-07-11T21:39:57Z | 2018-07-11T21:39:57Z | COLLABORATOR | Test Recipe on Wielded Items /ci 6127 (Stone Tool) /ci 6128 (Peerless Shivering Atlan Staff) Equip Peerless Shivering Atlan Staff Use Stone Tool on Peerless Shivering Atlan Staff (Note that enchantments applied by the staff will not be removed) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for using recipe items located in Packs 339985807 | |
404323469 | https://github.com/ACEmulator/ACE/pull/867#issuecomment-404323469 | https://api.github.com/repos/ACEmulator/ACE/issues/867 | MDEyOklzc3VlQ29tbWVudDQwNDMyMzQ2OQ== | gmriggs 8909245 | 2018-07-11T21:56:42Z | 2018-07-11T21:56:42Z | COLLABORATOR | Tested both scenarios in-game, looks good | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for using recipe items located in Packs 339985807 | |
404325061 | https://github.com/ACEmulator/ACE/pull/867#issuecomment-404325061 | https://api.github.com/repos/ACEmulator/ACE/issues/867 | MDEyOklzc3VlQ29tbWVudDQwNDMyNTA2MQ== | gmriggs 8909245 | 2018-07-11T22:03:30Z | 2018-07-11T22:03:30Z | COLLABORATOR | @Warloxx01 - thanks for the info! When trying to merge stacks, this is a bug with the existing inventory system. @Mag-nus will be taking a look at these inventory bugs and fixing that system up very soon! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix for using recipe items located in Packs 339985807 | |
404395126 | https://github.com/ACEmulator/ACE/pull/868#issuecomment-404395126 | https://api.github.com/repos/ACEmulator/ACE/issues/868 | MDEyOklzc3VlQ29tbWVudDQwNDM5NTEyNg== | gmriggs 8909245 | 2018-07-12T05:38:00Z | 2018-07-12T05:38:00Z | COLLABORATOR | Fixed the double rotation bug: Player rotates toward target, and target rotates toward player are 2 separate events Give chain waits for just the player rotation, and receive chain waits for both | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | EmoteManager refactoring 340465938 | |
404928752 | https://github.com/ACEmulator/ACE/issues/811#issuecomment-404928752 | https://api.github.com/repos/ACEmulator/ACE/issues/811 | MDEyOklzc3VlQ29tbWVudDQwNDkyODc1Mg== | OptimShi 26606778 | 2018-07-13T19:19:34Z | 2018-07-13T19:19:34Z | COLLABORATOR | I am currently working on this. Fixed the reported bug, but others presented themselves that I am attempting to solve while I'm knee deep in it. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Selling 327815589 | |
405519727 | https://github.com/ACEmulator/ACE/pull/875#issuecomment-405519727 | https://api.github.com/repos/ACEmulator/ACE/issues/875 | MDEyOklzc3VlQ29tbWVudDQwNTUxOTcyNw== | gmriggs 8909245 | 2018-07-17T09:28:08Z | 2018-07-17T09:28:08Z | COLLABORATOR | Tested, looks good | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Redirect Impen/Banes from player to equipped armor and undergarments 341574678 | |
409785453 | https://github.com/ACEmulator/ACE/pull/917#issuecomment-409785453 | https://api.github.com/repos/ACEmulator/ACE/issues/917 | MDEyOklzc3VlQ29tbWVudDQwOTc4NTQ1Mw== | gmriggs 8909245 | 2018-08-02T02:28:41Z | 2018-08-02T02:28:41Z | COLLABORATOR | Code looks good, tested this functionality in-game: Animation looks good, multi-spell projectile angles and speeds looks good, and I was able to cast the various volley spells and thousand fists to hit multiple targets simultaneously Great PR, definitely looking forward to using these spells when battling many mobs! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add support for Volley spells 346717556 | |
410425743 | https://github.com/ACEmulator/ACE/pull/919#issuecomment-410425743 | https://api.github.com/repos/ACEmulator/ACE/issues/919 | MDEyOklzc3VlQ29tbWVudDQxMDQyNTc0Mw== | gmriggs 8909245 | 2018-08-04T05:44:42Z | 2018-08-04T05:44:42Z | COLLABORATOR | Hey @mcreedjr, Could you explain this patch a bit more? It looks like it's just skipping over the fist index in PlayerSpellID, which is SpellID=1 (StrengthOther1)? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Resolve apparent logic error in learnspellsinbulk method which caused… 347590172 | |
412240988 | https://github.com/ACEmulator/ACE/pull/941#issuecomment-412240988 | https://api.github.com/repos/ACEmulator/ACE/issues/941 | MDEyOklzc3VlQ29tbWVudDQxMjI0MDk4OA== | gmriggs 8909245 | 2018-08-11T01:19:47Z | 2018-08-11T01:19:47Z | COLLABORATOR | Tested, ~10x performance improvement for GetPlayerBiotas during login | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Major Shard Performance Improvements 349693656 | |
412268840 | https://github.com/ACEmulator/ACE/issues/944#issuecomment-412268840 | https://api.github.com/repos/ACEmulator/ACE/issues/944 | MDEyOklzc3VlQ29tbWVudDQxMjI2ODg0MA== | gmriggs 8909245 | 2018-08-11T11:19:36Z | 2018-08-11T11:19:36Z | COLLABORATOR | Thanks for the detailed write-up! The combat formulas are WIP, and we are definitely interested in gathering as much info as possible to figure out how everything worked on the retail servers. This information is very useful and will be reviewed so that the gameplay is accurate. For anything we are uncertain about, there could also be some easy configuration settings for server operators to customize different aspects of the game | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Melee attack penalty is not accurate for zero stamina 349725535 | |
412269187 | https://github.com/ACEmulator/ACE/issues/944#issuecomment-412269187 | https://api.github.com/repos/ACEmulator/ACE/issues/944 | MDEyOklzc3VlQ29tbWVudDQxMjI2OTE4Nw== | gmriggs 8909245 | 2018-08-11T11:27:06Z | 2018-08-11T11:27:06Z | COLLABORATOR | This is some very good evidence to take into consideration.. even though the sample size isn't huge (as mentioned), this thread would be good place to collect any 0-stamina combat videos for reference The PCAPs would also be a good resource for this, although the search capabilities in aclogview are rather limited currently, and could really use a 'spatial search / querying' feature that takes the full state of the game session into evaluation | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Melee attack penalty is not accurate for zero stamina 349725535 | |
413815442 | https://github.com/ACEmulator/ACE/issues/887#issuecomment-413815442 | https://api.github.com/repos/ACEmulator/ACE/issues/887 | MDEyOklzc3VlQ29tbWVudDQxMzgxNTQ0Mg== | gmriggs 8909245 | 2018-08-17T09:47:34Z | 2018-08-17T09:47:34Z | COLLABORATOR | Fixed by https://github.com/ACEmulator/ACE/pull/929 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblock Double+ Spawns 343428456 | |
413815927 | https://github.com/ACEmulator/ACE/issues/784#issuecomment-413815927 | https://api.github.com/repos/ACEmulator/ACE/issues/784 | MDEyOklzc3VlQ29tbWVudDQxMzgxNTkyNw== | gmriggs 8909245 | 2018-08-17T09:49:26Z | 2018-08-17T09:49:26Z | COLLABORATOR | Fixed by https://github.com/ACEmulator/ACE/pull/936 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks use a lot of memory 321519680 | |
413817635 | https://github.com/ACEmulator/ACE/issues/234#issuecomment-413817635 | https://api.github.com/repos/ACEmulator/ACE/issues/234 | MDEyOklzc3VlQ29tbWVudDQxMzgxNzYzNQ== | gmriggs 8909245 | 2018-08-17T09:56:14Z | 2018-08-17T09:56:14Z | COLLABORATOR | These should be handled by automated tests imo | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Create Test Script and add to project 220952882 | |
413994809 | https://github.com/ACEmulator/ACE/issues/663#issuecomment-413994809 | https://api.github.com/repos/ACEmulator/ACE/issues/663 | MDEyOklzc3VlQ29tbWVudDQxMzk5NDgwOQ== | gmriggs 8909245 | 2018-08-17T21:38:13Z | 2018-08-17T21:38:13Z | COLLABORATOR | This bug has been fixed for quite some time now | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client does not send GameActionLoginComplete after Entering World 301553721 | |
414022856 | https://github.com/ACEmulator/ACE/issues/744#issuecomment-414022856 | https://api.github.com/repos/ACEmulator/ACE/issues/744 | MDEyOklzc3VlQ29tbWVudDQxNDAyMjg1Ng== | gmriggs 8909245 | 2018-08-18T01:28:13Z | 2018-08-18T01:28:13Z | COLLABORATOR | This has been addressed in https://github.com/ACEmulator/ACE/pull/956 Open questions: - When dragging main hand weapon to empty offhand slot, were the wield requirements re-checked, and were the weapon item spells re-applied? - With 2 weapons equipped, when dragging 1 wielded weapon to the other slot, did retail actually swap the weapons inline? This would seem natural, but I am seeing some weird messages being sent from the client. The client seems to be sending 2 duplicate messages to 'PutItemInContainer' for the item already in the destination slot. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | weapon movement between hands 314423449 | |
414592397 | https://github.com/ACEmulator/ACE/pull/963#issuecomment-414592397 | https://api.github.com/repos/ACEmulator/ACE/issues/963 | MDEyOklzc3VlQ29tbWVudDQxNDU5MjM5Nw== | gmriggs 8909245 | 2018-08-21T08:22:11Z | 2018-08-21T08:22:11Z | COLLABORATOR | We should probably look into using a command line parsing library from nuget eventually | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update the 'accountcreate' command from Console only to Console and G… 352307420 | |
415447590 | https://github.com/ACEmulator/ACE/pull/967#issuecomment-415447590 | https://api.github.com/repos/ACEmulator/ACE/issues/967 | MDEyOklzc3VlQ29tbWVudDQxNTQ0NzU5MA== | gmriggs 8909245 | 2018-08-23T14:53:43Z | 2018-08-23T14:53:43Z | COLLABORATOR | Fixing a bunch of different things in the physics engine and with monster movement, it could possibly resolve this issue | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing some issues with stuck / falling monsters 353367488 | |
417830649 | https://github.com/ACEmulator/ACE/pull/982#issuecomment-417830649 | https://api.github.com/repos/ACEmulator/ACE/issues/982 | MDEyOklzc3VlQ29tbWVudDQxNzgzMDY0OQ== | gmriggs 8909245 | 2018-09-01T03:58:13Z | 2018-09-01T03:58:13Z | COLLABORATOR | Reviewed code and playtested | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Weapon Bonuses 354939195 | |
417882738 | https://github.com/ACEmulator/ACE/pull/987#issuecomment-417882738 | https://api.github.com/repos/ACEmulator/ACE/issues/987 | MDEyOklzc3VlQ29tbWVudDQxNzg4MjczOA== | gmriggs 8909245 | 2018-09-01T19:44:18Z | 2018-09-01T19:44:18Z | COLLABORATOR | Tested, this appears to fix the window position saving issue | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character gameplay_Options fix 356227307 | |
417883589 | https://github.com/ACEmulator/ACE/pull/987#issuecomment-417883589 | https://api.github.com/repos/ACEmulator/ACE/issues/987 | MDEyOklzc3VlQ29tbWVudDQxNzg4MzU4OQ== | gmriggs 8909245 | 2018-09-01T19:57:48Z | 2018-09-01T19:57:48Z | COLLABORATOR | Re-tested, confirmed window positions saved | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Character gameplay_Options fix 356227307 | |
418187773 | https://github.com/ACEmulator/ACE/pull/994#issuecomment-418187773 | https://api.github.com/repos/ACEmulator/ACE/issues/994 | MDEyOklzc3VlQ29tbWVudDQxODE4Nzc3Mw== | gmriggs 8909245 | 2018-09-03T20:20:33Z | 2018-09-03T20:20:33Z | COLLABORATOR | Code looks great, tested in-game with some allegiance chat I noticed some oddities with the 'chat' button, and which options were lit up in there. The patron/monarch had 'Tell to Trade Chat' lit up, and the 'Tell to Vassals' options didn't become available until the vassal relogged. For the scope of the code in this PR, I think this looks good and should be merged. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Chat functions 356326342 | |
418189086 | https://github.com/ACEmulator/ACE/pull/996#issuecomment-418189086 | https://api.github.com/repos/ACEmulator/ACE/issues/996 | MDEyOklzc3VlQ29tbWVudDQxODE4OTA4Ng== | gmriggs 8909245 | 2018-09-03T20:31:46Z | 2018-09-03T20:31:46Z | COLLABORATOR | Tested, looks great! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Implement secure trade 356422598 | |
418189758 | https://github.com/ACEmulator/ACE/pull/996#issuecomment-418189758 | https://api.github.com/repos/ACEmulator/ACE/issues/996 | MDEyOklzc3VlQ29tbWVudDQxODE4OTc1OA== | gmriggs 8909245 | 2018-09-03T20:37:40Z | 2018-09-03T20:38:45Z | COLLABORATOR | A few questions, just some minor stuff: - did retail have any messages like 'You give <item> to player', 'Player gives you <item>' once the transaction goes through? - if 1 player closes the trade window, the window seems to remain open for the other player, although the name of the other player disappears from the window, sort of indicating that they backed out of the trade. Is this the same as retail, or should the window automatically close? - 'Ignore all trade requests' character option doesn't work, but maybe outside of the scope for current PR, just to get the functionality going Still looks good for merging imo | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Implement secure trade 356422598 | |
418232228 | https://github.com/ACEmulator/ACE/pull/998#issuecomment-418232228 | https://api.github.com/repos/ACEmulator/ACE/issues/998 | MDEyOklzc3VlQ29tbWVudDQxODIzMjIyOA== | gmriggs 8909245 | 2018-09-04T03:40:35Z | 2018-09-04T03:40:35Z | COLLABORATOR | lots of error messages: 2018-09-03 23:27:13,552 WARN : requested object description for an item I do not know about - 8000C020 i get that message almost immediately when loading in now never saw that message once before also a ton of these error messages: System.InvalidOperationException: Collection was modified; enumeration operation may not execute. at System.Collections.Generic.Dictionary`2.ValueCollection.Enumerator.MoveNext() at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext() at ACE.Server.Managers.WorldManager.HandlePhysicsLandblock(Landblock landblock, Double timeTick, ConcurrentQueue`1 movedObjects) in C:\dev\gmriggs\ACE\Source\ACE.Server\Managers\WorldManager.cs:line 600 at ACE.Server.Managers.WorldManager.HandlePhysics(Double timeTick) in C:\dev\gmriggs\ACE\Source\ACE.Server\Managers\WorldManager.cs:line 585 this was in the first few mins of testing definitely a lot of bugs that need ironed out with this PR | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ActionQueue/Tick updates 356595026 | |
418250575 | https://github.com/ACEmulator/ACE/pull/993#issuecomment-418250575 | https://api.github.com/repos/ACEmulator/ACE/issues/993 | MDEyOklzc3VlQ29tbWVudDQxODI1MDU3NQ== | gmriggs 8909245 | 2018-09-04T06:02:36Z | 2018-09-04T06:02:36Z | COLLABORATOR | Reviewed code, and tested formulas for bow elemental damage modifier | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add missile launcher Elemental damage modifier 356320062 | |
418946396 | https://github.com/ACEmulator/ACE/pull/998#issuecomment-418946396 | https://api.github.com/repos/ACEmulator/ACE/issues/998 | MDEyOklzc3VlQ29tbWVudDQxODk0NjM5Ng== | gmriggs 8909245 | 2018-09-06T02:47:44Z | 2018-09-06T02:47:44Z | COLLABORATOR | I have confirmed the above errors are now fixed Playtested, everything else looks good | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ActionQueue/Tick updates 356595026 | |
426091120 | https://github.com/ACEmulator/ACE/pull/1039#issuecomment-426091120 | https://api.github.com/repos/ACEmulator/ACE/issues/1039 | MDEyOklzc3VlQ29tbWVudDQyNjA5MTEyMA== | gmriggs 8909245 | 2018-10-01T22:55:51Z | 2018-10-01T22:55:51Z | COLLABORATOR | Hey Riaf, Thanks for this patch! This has been a known issue for quite awhile The root cause is indeed the AllPlayers list not being maintained properly. This AllPlayers structure was admittedly quite a large hack, and there have been discussions about refactoring this into a better architecture since it was created. This will fix a lot of issues with AllPlayers in the meantime, great patch | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Alleg Fixes plus fix for No Default SQL 365673956 | |
427592748 | https://github.com/ACEmulator/ACE/pull/1046#issuecomment-427592748 | https://api.github.com/repos/ACEmulator/ACE/issues/1046 | MDEyOklzc3VlQ29tbWVudDQyNzU5Mjc0OA== | gmriggs 8909245 | 2018-10-06T17:37:48Z | 2018-10-06T17:37:48Z | COLLABORATOR | Looks good, locked to 60 fps | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Timing 366824733 | |
428768833 | https://github.com/ACEmulator/ACE/pull/1052#issuecomment-428768833 | https://api.github.com/repos/ACEmulator/ACE/issues/1052 | MDEyOklzc3VlQ29tbWVudDQyODc2ODgzMw== | gmriggs 8909245 | 2018-10-10T23:40:49Z | 2018-10-10T23:40:49Z | COLLABORATOR | - Fixed a bug where /smite all would kill nearby NPCs - Fixed a bug where teleporting / dying in hotspots would not trigger hotspot.OnCollideEnd - Fixed a bug where ethereal objects could prevent creatures from spawning - Added portal summons to monster item magic / emotes | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding methods to QuestManager 367917194 | |
431268477 | https://github.com/ACEmulator/ACE/issues/1051#issuecomment-431268477 | https://api.github.com/repos/ACEmulator/ACE/issues/1051 | MDEyOklzc3VlQ29tbWVudDQzMTI2ODQ3Nw== | gmriggs 8909245 | 2018-10-19T07:17:24Z | 2018-10-19T07:17:24Z | COLLABORATOR | Thanks for the bug report! This issue has been fixed in PR 1070: https://github.com/ACEmulator/ACE/pull/1070 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Jump not seen by others 367888292 | |
441377549 | https://github.com/ACEmulator/ACE/pull/1102#issuecomment-441377549 | https://api.github.com/repos/ACEmulator/ACE/issues/1102 | MDEyOklzc3VlQ29tbWVudDQ0MTM3NzU0OQ== | dgatewood 10187880 | 2018-11-24T16:02:49Z | 2018-11-25T06:02:22Z | COLLABORATOR | Dont merge yet. I need to test some things. Now it is ready. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding scrolls to loot profiles 383966681 | |
441768928 | https://github.com/ACEmulator/ACE/pull/1099#issuecomment-441768928 | https://api.github.com/repos/ACEmulator/ACE/issues/1099 | MDEyOklzc3VlQ29tbWVudDQ0MTc2ODkyOA== | fartwhif 3317737 | 2018-11-26T19:36:01Z | 2018-11-26T19:37:15Z | COLLABORATOR | impressive! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Appending client lib 383329969 | |
442847103 | https://github.com/ACEmulator/ACE/pull/1104#issuecomment-442847103 | https://api.github.com/repos/ACEmulator/ACE/issues/1104 | MDEyOklzc3VlQ29tbWVudDQ0Mjg0NzEwMw== | fartwhif 3317737 | 2018-11-29T14:12:11Z | 2018-11-29T14:15:25Z | COLLABORATOR | Primary work is complete. Ready for approval or suggested changes. This update will bring the network layer into the reliable category, at least according to the longevity with synthetic harshness WAN testing I've been doing. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | fixing networking bugs 384161840 | |
442935379 | https://github.com/ACEmulator/ACE/issues/718#issuecomment-442935379 | https://api.github.com/repos/ACEmulator/ACE/issues/718 | MDEyOklzc3VlQ29tbWVudDQ0MjkzNTM3OQ== | fartwhif 3317737 | 2018-11-29T18:09:15Z | 2018-11-29T18:09:42Z | COLLABORATOR | For remotely querying EF and EF core with System.Linq [Remote.Linq (MIT) has been amazing](https://github.com/6bee/Remote.Linq). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE.Server needs to expose an API for diagnostics and other information 310644605 | |
443684667 | https://github.com/ACEmulator/ACE/pull/1115#issuecomment-443684667 | https://api.github.com/repos/ACEmulator/ACE/issues/1115 | MDEyOklzc3VlQ29tbWVudDQ0MzY4NDY2Nw== | gmriggs 8909245 | 2018-12-03T11:53:34Z | 2018-12-03T11:53:34Z | COLLABORATOR | Bow: 0 Mace: 0 Sword: 0 UnarmedCombat: 0 These skills are showing up in Player.Skills as 'untrained', instead of 'inactive' | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Profiling based improvements 386616346 | |
444608917 | https://github.com/ACEmulator/ACE/pull/1117#issuecomment-444608917 | https://api.github.com/repos/ACEmulator/ACE/issues/1117 | MDEyOklzc3VlQ29tbWVudDQ0NDYwODkxNw== | gmriggs 8909245 | 2018-12-05T19:19:26Z | 2018-12-05T19:19:26Z | COLLABORATOR | @LtRipley36706 The database objects have been moved to 16py repo as suggested | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding summoning from @mcreedjr 387236335 | |
447420521 | https://github.com/ACEmulator/ACE/issues/1129#issuecomment-447420521 | https://api.github.com/repos/ACEmulator/ACE/issues/1129 | MDEyOklzc3VlQ29tbWVudDQ0NzQyMDUyMQ== | OptimShi 26606778 | 2018-12-14T18:56:29Z | 2018-12-14T18:56:29Z | COLLABORATOR | This is a data related issue. PropertyInt.Locations (9) is set to 16 (LowerArmWear) when it should be 4096 (LowerArmArmor) No item should have just "upper/lower arm wear" set without ChestWear also set. Similarly for underpants, which I believe should always have AdbomenWear set. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Leather and Studded Leather Bracers not showing in "Slots" screen 389097376 | |
447561161 | https://github.com/ACEmulator/ACE/issues/1128#issuecomment-447561161 | https://api.github.com/repos/ACEmulator/ACE/issues/1128 | MDEyOklzc3VlQ29tbWVudDQ0NzU2MTE2MQ== | gmriggs 8909245 | 2018-12-15T11:20:16Z | 2018-12-15T11:20:27Z | COLLABORATOR | Still looking for a way to replicate the floating NPC bug For the players being located in inconsistent locations, this should be resolved in https://github.com/ACEmulator/ACE/pull/1132. It's possible this same patch could resolve the floating NPC issue, although since I have been unable to repro the bug, I can't say for certain | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Floating NPC multiple clients 389076663 | |
447573535 | https://github.com/ACEmulator/ACE/issues/1125#issuecomment-447573535 | https://api.github.com/repos/ACEmulator/ACE/issues/1125 | MDEyOklzc3VlQ29tbWVudDQ0NzU3MzUzNQ== | gmriggs 8909245 | 2018-12-15T14:45:30Z | 2018-12-15T14:45:30Z | COLLABORATOR | Fixed in https://github.com/ACEmulator/ACE/pull/1141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | couldn't spawn Door 389068221 | |
447611781 | https://github.com/ACEmulator/ACE/issues/944#issuecomment-447611781 | https://api.github.com/repos/ACEmulator/ACE/issues/944 | MDEyOklzc3VlQ29tbWVudDQ0NzYxMTc4MQ== | gmriggs 8909245 | 2018-12-16T02:00:37Z | 2018-12-16T02:00:37Z | COLLABORATOR | This has been updated: https://github.com/ACEmulator/ACE/pull/1142 | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Melee attack penalty is not accurate for zero stamina 349725535 | |
447985290 | https://github.com/ACEmulator/ACE/issues/1145#issuecomment-447985290 | https://api.github.com/repos/ACEmulator/ACE/issues/1145 | MDEyOklzc3VlQ29tbWVudDQ0Nzk4NTI5MA== | gmriggs 8909245 | 2018-12-17T20:21:43Z | 2018-12-17T20:21:43Z | COLLABORATOR | Fixed in https://github.com/ACEmulator/ACE/pull/1148 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't unselect spell categories 391531272 | |
448776000 | https://github.com/ACEmulator/ACE/pull/1146#issuecomment-448776000 | https://api.github.com/repos/ACEmulator/ACE/issues/1146 | MDEyOklzc3VlQ29tbWVudDQ0ODc3NjAwMA== | dgatewood 10187880 | 2018-12-19T22:57:39Z | 2018-12-19T22:57:39Z | COLLABORATOR | This looks good to me | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improving housing system 391597401 | |
448976765 | https://github.com/ACEmulator/ACE/issues/1158#issuecomment-448976765 | https://api.github.com/repos/ACEmulator/ACE/issues/1158 | MDEyOklzc3VlQ29tbWVudDQ0ODk3Njc2NQ== | gmriggs 8909245 | 2018-12-20T12:08:34Z | 2018-12-20T12:08:34Z | COLLABORATOR | Updated in https://github.com/ACEmulator/ACE/pull/1159 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Critical: Redesign Sequence system 392985817 | |
449249758 | https://github.com/ACEmulator/ACE/pull/1162#issuecomment-449249758 | https://api.github.com/repos/ACEmulator/ACE/issues/1162 | MDEyOklzc3VlQ29tbWVudDQ0OTI0OTc1OA== | fartwhif 3317737 | 2018-12-21T04:55:08Z | 2018-12-21T04:55:27Z | COLLABORATOR | ` OldRandom.RollDice(int min, int max): 00:00:10.0000056, iterations: 134002807 OldRandom.RollDice(float min, float max): 00:00:10.0000075, iterations: 137180787 OldRandom.RollDice(uint min, uint max): 00:00:10.0000001, iterations: 136066119 ThreadSafeRandom.Next(int min, int max): 00:00:10.0000001, iterations: 225691575 ThreadSafeRandom.Next(float min, float max): 00:00:10.0000003, iterations: 231988872 ThreadSafeRandom.Next(uint min, uint max): 00:00:10.0000002, iterations: 228039807` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Moving ACE.Server.Physics.Common.Random to ACE.Common.Random 393271794 | |
449388245 | https://github.com/ACEmulator/ACE/pull/1162#issuecomment-449388245 | https://api.github.com/repos/ACEmulator/ACE/issues/1162 | MDEyOklzc3VlQ29tbWVudDQ0OTM4ODI0NQ== | fartwhif 3317737 | 2018-12-21T13:27:30Z | 2018-12-21T13:29:18Z | COLLABORATOR | No problem. Actually, I just noticed that I accidentally included one of your branches. I'll submit a new PR tonight after I remove your branch concerning melee combat and refactor ACE.Common.ThreadSafeRandom to just ACE.ThreadSafeRandom | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Moving ACE.Server.Physics.Common.Random to ACE.Common.Random 393271794 | |
449522375 | https://github.com/ACEmulator/ACE/pull/1167#issuecomment-449522375 | https://api.github.com/repos/ACEmulator/ACE/issues/1167 | MDEyOklzc3VlQ29tbWVudDQ0OTUyMjM3NQ== | fartwhif 3317737 | 2018-12-21T23:24:38Z | 2018-12-21T23:24:38Z | COLLABORATOR | ` OldRandom.RollDice(int min, int max): 00:00:10.0000056, iterations: 134002807 OldRandom.RollDice(float min, float max): 00:00:10.0000075, iterations: 137180787 OldRandom.RollDice(uint min, uint max): 00:00:10.0000001, iterations: 136066119 ThreadSafeRandom.Next(int min, int max): 00:00:10.0000001, iterations: 225691575 ThreadSafeRandom.Next(float min, float max): 00:00:10.0000003, iterations: 231988872 ThreadSafeRandom.Next(uint min, uint max): 00:00:10.0000002, iterations: 228039807` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Moving class ACE.Server.Physics.Common.Random to ACE.ThreadSafeRandom in project ACE.Common 393617284 | |
449587064 | https://github.com/ACEmulator/ACE/issues/1170#issuecomment-449587064 | https://api.github.com/repos/ACEmulator/ACE/issues/1170 | MDEyOklzc3VlQ29tbWVudDQ0OTU4NzA2NA== | dgatewood 10187880 | 2018-12-22T17:46:55Z | 2018-12-22T17:46:55Z | COLLABORATOR | This is corrected by PR 1171. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature snuck into loot 393689057 | |
449604979 | https://github.com/ACEmulator/ACE/issues/1172#issuecomment-449604979 | https://api.github.com/repos/ACEmulator/ACE/issues/1172 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNDk3OQ== | gmriggs 8909245 | 2018-12-22T23:59:47Z | 2018-12-22T23:59:47Z | COLLABORATOR | This should be fixed in https://github.com/ACEmulator/ACE/pull/1168 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Null exception in combat, on an evade of incoming attack 393691682 | |
449605056 | https://github.com/ACEmulator/ACE/issues/1173#issuecomment-449605056 | https://api.github.com/repos/ACEmulator/ACE/issues/1173 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNTA1Ng== | gmriggs 8909245 | 2018-12-23T00:01:24Z | 2018-12-23T00:01:24Z | COLLABORATOR | This should be fixed in https://github.com/ACEmulator/ACE/pull/1168 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server box rapid errors when attacking Crystal Spur 393696449 | |
449605369 | https://github.com/ACEmulator/ACE/issues/1128#issuecomment-449605369 | https://api.github.com/repos/ACEmulator/ACE/issues/1128 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNTM2OQ== | gmriggs 8909245 | 2018-12-23T00:09:48Z | 2018-12-23T00:09:48Z | COLLABORATOR | Thanks for the update, very useful info ! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Floating NPC multiple clients 389076663 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);