issue_comments
Data license: AGPL · Data source: ACEmulator Project
1,646 rows sorted by issue_url
This data as json, CSV (advanced)
Suggested facets: author_association, reactions, created_at (date), updated_at (date)
id | html_url | issue_url ▼ | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
277009368 | https://github.com/ACEmulator/ACE/pull/10#issuecomment-277009368 | https://api.github.com/repos/ACEmulator/ACE/issues/10 | MDEyOklzc3VlQ29tbWVudDI3NzAwOTM2OA== | Rawaho 6111341 | 2017-02-02T16:36:57Z | 2017-02-02T16:36:57Z | CONTRIBUTOR | Additional checks will be added on account login as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Client and Server expects account in ace_auth to be lowercase only. 204670023 | |
419594557 | https://github.com/ACEmulator/ACE/pull/1003#issuecomment-419594557 | https://api.github.com/repos/ACEmulator/ACE/issues/1003 | MDEyOklzc3VlQ29tbWVudDQxOTU5NDU1Nw== | mcreedjr 25518589 | 2018-09-07T23:51:41Z | 2018-09-07T23:51:41Z | CONTRIBUTOR | FWIW I play tested this and the functionality being merged in this PR (purchasing a dwelling) looks good to me. Nice and exciting work @gmriggs! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding the ability for players to buy houses 358206938 | |
419732480 | https://github.com/ACEmulator/ACE/pull/1005#issuecomment-419732480 | https://api.github.com/repos/ACEmulator/ACE/issues/1005 | MDEyOklzc3VlQ29tbWVudDQxOTczMjQ4MA== | mcreedjr 25518589 | 2018-09-09T17:46:53Z | 2018-09-09T17:46:53Z | CONTRIBUTOR | Closing to re-open a new PR with a cleaner commit history. Sorry for all of the PR activity. Git and I are not friends. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Secure trade pass 2 358362004 | |
421660273 | https://github.com/ACEmulator/ACE/pull/1017#issuecomment-421660273 | https://api.github.com/repos/ACEmulator/ACE/issues/1017 | MDEyOklzc3VlQ29tbWVudDQyMTY2MDI3Mw== | mcreedjr 25518589 | 2018-09-16T00:24:25Z | 2018-09-16T00:24:25Z | CONTRIBUTOR | @kdmxp256 Sorry to dismiss your review, but felt I should fix this rather large oversight on my part before it was merged. I'm done messing with it now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill redistribution functionality 360503793 | |
423381367 | https://github.com/ACEmulator/ACE/pull/1017#issuecomment-423381367 | https://api.github.com/repos/ACEmulator/ACE/issues/1017 | MDEyOklzc3VlQ29tbWVudDQyMzM4MTM2Nw== | mcreedjr 25518589 | 2018-09-21T01:05:36Z | 2018-09-21T01:05:36Z | CONTRIBUTOR | I think this is finally good to go. Special thanks to @gmriggs for the guidance, and the assistance tightening up some methods as part of this PR. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Skill redistribution functionality 360503793 | |
423853226 | https://github.com/ACEmulator/ACE/pull/1026#issuecomment-423853226 | https://api.github.com/repos/ACEmulator/ACE/issues/1026 | MDEyOklzc3VlQ29tbWVudDQyMzg1MzIyNg== | Mag-nus 10608427 | 2018-09-23T22:36:54Z | 2018-09-23T22:36:54Z | MEMBER | This looks fine. My only question is if the DirtyFighting.sql changes will be added to the ACE-World-16PY-Patches repo. They should be at the same time this PR is merged. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update SQL Scripts 362976710 | |
425874447 | https://github.com/ACEmulator/ACE/pull/1031#issuecomment-425874447 | https://api.github.com/repos/ACEmulator/ACE/issues/1031 | MDEyOklzc3VlQ29tbWVudDQyNTg3NDQ0Nw== | Mag-nus 10608427 | 2018-10-01T11:28:12Z | 2018-10-01T11:28:12Z | MEMBER | spendallxp developer command added fixed SpendSkillXp so that the rankup is only applied if the SpendXp was successful | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | PlayerFactory 365092685 | |
450724806 | https://github.com/ACEmulator/ACE/issues/1032#issuecomment-450724806 | https://api.github.com/repos/ACEmulator/ACE/issues/1032 | MDEyOklzc3VlQ29tbWVudDQ1MDcyNDgwNg== | gmriggs 8909245 | 2019-01-01T12:02:23Z | 2019-01-01T12:02:23Z | COLLABORATOR | We could exclude Burden specifically for Creatures, but I think this is 1 instance of a larger design issue Property filters in AppraiseInfo (in that, there are none...) Is there any data that determines which Properties should be sent for each object type? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Stop sending Burden of WeenieType.Creature to everyone in CreateObject 365096164 | |
425924705 | https://github.com/ACEmulator/ACE/pull/1036#issuecomment-425924705 | https://api.github.com/repos/ACEmulator/ACE/issues/1036 | MDEyOklzc3VlQ29tbWVudDQyNTkyNDcwNQ== | Mag-nus 10608427 | 2018-10-01T14:17:53Z | 2018-10-01T14:17:53Z | MEMBER | Tested revitalize and it works. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix DamageType for Boost spells 365477115 | |
426091120 | https://github.com/ACEmulator/ACE/pull/1039#issuecomment-426091120 | https://api.github.com/repos/ACEmulator/ACE/issues/1039 | MDEyOklzc3VlQ29tbWVudDQyNjA5MTEyMA== | gmriggs 8909245 | 2018-10-01T22:55:51Z | 2018-10-01T22:55:51Z | COLLABORATOR | Hey Riaf, Thanks for this patch! This has been a known issue for quite awhile The root cause is indeed the AllPlayers list not being maintained properly. This AllPlayers structure was admittedly quite a large hack, and there have been discussions about refactoring this into a better architecture since it was created. This will fix a lot of issues with AllPlayers in the meantime, great patch | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Alleg Fixes plus fix for No Default SQL 365673956 | |
427592748 | https://github.com/ACEmulator/ACE/pull/1046#issuecomment-427592748 | https://api.github.com/repos/ACEmulator/ACE/issues/1046 | MDEyOklzc3VlQ29tbWVudDQyNzU5Mjc0OA== | gmriggs 8909245 | 2018-10-06T17:37:48Z | 2018-10-06T17:37:48Z | COLLABORATOR | Looks good, locked to 60 fps | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Timing 366824733 | |
427569748 | https://github.com/ACEmulator/ACE/pull/1047#issuecomment-427569748 | https://api.github.com/repos/ACEmulator/ACE/issues/1047 | MDEyOklzc3VlQ29tbWVudDQyNzU2OTc0OA== | Mag-nus 10608427 | 2018-10-06T12:25:59Z | 2018-10-06T12:25:59Z | MEMBER | I think I'm going to add more world db precaching, spells, cookbooks, treasures, etc.. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | WeeniePrecaching 367418617 | |
427876997 | https://github.com/ACEmulator/ACE/pull/1047#issuecomment-427876997 | https://api.github.com/repos/ACEmulator/ACE/issues/1047 | MDEyOklzc3VlQ29tbWVudDQyNzg3Njk5Nw== | Mag-nus 10608427 | 2018-10-08T15:24:17Z | 2018-10-08T15:24:17Z | MEMBER | This precaches (optional, off by default) most/all world database (non landblock) entities. Precaching uses about 400MB. This will be useful for heavy populated servers. Servers for individuals probably wont want to use this if they are short on RAM. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | WeeniePrecaching 367418617 | |
431268477 | https://github.com/ACEmulator/ACE/issues/1051#issuecomment-431268477 | https://api.github.com/repos/ACEmulator/ACE/issues/1051 | MDEyOklzc3VlQ29tbWVudDQzMTI2ODQ3Nw== | gmriggs 8909245 | 2018-10-19T07:17:24Z | 2018-10-19T07:17:24Z | COLLABORATOR | Thanks for the bug report! This issue has been fixed in PR 1070: https://github.com/ACEmulator/ACE/pull/1070 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Jump not seen by others 367888292 | |
428768833 | https://github.com/ACEmulator/ACE/pull/1052#issuecomment-428768833 | https://api.github.com/repos/ACEmulator/ACE/issues/1052 | MDEyOklzc3VlQ29tbWVudDQyODc2ODgzMw== | gmriggs 8909245 | 2018-10-10T23:40:49Z | 2018-10-10T23:40:49Z | COLLABORATOR | - Fixed a bug where /smite all would kill nearby NPCs - Fixed a bug where teleporting / dying in hotspots would not trigger hotspot.OnCollideEnd - Fixed a bug where ethereal objects could prevent creatures from spawning - Added portal summons to monster item magic / emotes | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding methods to QuestManager 367917194 | |
429491998 | https://github.com/ACEmulator/ACE/pull/1060#issuecomment-429491998 | https://api.github.com/repos/ACEmulator/ACE/issues/1060 | MDEyOklzc3VlQ29tbWVudDQyOTQ5MTk5OA== | Mag-nus 10608427 | 2018-10-12T23:53:17Z | 2018-10-12T23:53:17Z | MEMBER | Looks like the action chain is required if we have more ammo, but can probably be refactored out for ammo.StackSize == 1. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | LaunchMissile check for null (fix exception) 369744049 | |
284311511 | https://github.com/ACEmulator/ACE/pull/107#issuecomment-284311511 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | MDEyOklzc3VlQ29tbWVudDI4NDMxMTUxMQ== | ghost 10137 | 2017-03-06T06:13:51Z | 2017-03-06T06:13:51Z | NONE | So the file names themselves would be hard-coded and just pull in the directory location from the config file, thereby allowing the two config directives to condense into one. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add DAT loading into main process 211999671 | |
284312826 | https://github.com/ACEmulator/ACE/pull/107#issuecomment-284312826 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | MDEyOklzc3VlQ29tbWVudDI4NDMxMjgyNg== | LtRipley36706 11369233 | 2017-03-06T06:25:16Z | 2017-03-06T06:25:16Z | MEMBER | Exactly. I can't imagine a reason why the file names couldn't or shouldn't be hardcoded, but I can think of a few reasons why one might want to change the directory location. One of which could be having multiple versions of DAT patches to switch between perhaps? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add DAT loading into main process 211999671 | |
284326453 | https://github.com/ACEmulator/ACE/pull/107#issuecomment-284326453 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | MDEyOklzc3VlQ29tbWVudDI4NDMyNjQ1Mw== | ghost 10137 | 2017-03-06T07:59:00Z | 2017-03-06T07:59:00Z | NONE | Stupid tab vs spaces kept tripping me up. I also noticed that I missed a whole file that should have been included in the original commit. 'git add <filename>, ftw. It has now been added into the PR with the changes to the config variable(s). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Add DAT loading into main process 211999671 | |
431687683 | https://github.com/ACEmulator/ACE/pull/1070#issuecomment-431687683 | https://api.github.com/repos/ACEmulator/ACE/issues/1070 | MDEyOklzc3VlQ29tbWVudDQzMTY4NzY4Mw== | Mag-nus 10608427 | 2018-10-21T17:30:13Z | 2018-10-21T17:30:13Z | MEMBER | Play tested with 32 clients actively running around the world. Seems ok. Performance seems the same. I can now see others jump. Players appear to move the same as they did before. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing jump in multiplayer, refactoring movement and animation systems for network and game layers 371833824 | |
432225314 | https://github.com/ACEmulator/ACE/pull/1071#issuecomment-432225314 | https://api.github.com/repos/ACEmulator/ACE/issues/1071 | MDEyOklzc3VlQ29tbWVudDQzMjIyNTMxNA== | Mag-nus 10608427 | 2018-10-23T12:27:08Z | 2018-10-23T12:27:08Z | MEMBER | You will now see every item you've dropped in the past. For a long time in ACE, items you've dropped on the landscape were saved to the database. Just now though, do those items get restored to the landblock on server restart or landblock load. In addition, only now do those items also start to decay. Now, they will decay normally and disappear and be removed from the database. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblock item saving + Much more 372221192 | |
431699804 | https://github.com/ACEmulator/ACE/pull/1072#issuecomment-431699804 | https://api.github.com/repos/ACEmulator/ACE/issues/1072 | MDEyOklzc3VlQ29tbWVudDQzMTY5OTgwNA== | Mag-nus 10608427 | 2018-10-21T20:08:40Z | 2018-10-21T20:08:40Z | MEMBER | playtested with 32 clients, seems ok. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improving monster animation sync between server and client 372298057 | |
433554616 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433554616 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzU1NDYxNg== | Mag-nus 10608427 | 2018-10-26T21:58:35Z | 2018-10-26T21:58:35Z | MEMBER | To clarify. Items you give to the town crier reappear on your character. Can you test that items dropped on the landblock do not reappear on your character? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
433584372 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433584372 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzU4NDM3Mg== | Warloxx01 38050842 | 2018-10-27T02:37:20Z | 2018-10-27T02:37:20Z | NONE | If I drop them on them on the Quest giver( if quest item ) or Town Crier they reappear in my inventory. They also reappear if dropped on the ground. Odd thing is, if dropped on the ground. When you log back in They are back in your inventory and on the ground, here is the odd part, if you Click on the item on the ground the Corresponding item in your backpack Highlights. Also if you Double click the item on the ground you can not pick it up. You have to drag it to your inventory. Then you have two of the same items. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
433630807 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433630807 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzYzMDgwNw== | Mag-nus 10608427 | 2018-10-27T15:35:51Z | 2018-10-27T15:35:51Z | MEMBER | Can you test #1078, i think it has the fix. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
433634488 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433634488 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzYzNDQ4OA== | Warloxx01 38050842 | 2018-10-27T16:23:19Z | 2018-10-27T16:25:35Z | NONE | Okay, Kinda works, if i give items to the town crier it appears to work correctly now, But... If I drop the item on the ground, it is removed from the Inventory. But if I log out and back in, it is back in my inventory and also on the ground. I cant pick it up but if I click on it on the ground it Highlights in my Inventory. I can no longer drag and drop it from the ground to my pack and get 2 of the same item (that changed), but if I drop the item from my back pack on the town crier... THEN I can pick up the item on the ground... Also I now get this in the Server window.. 2018-10-27`` 12:17:04,762 ERROR: SaveBiota failed with exception: Microsoft.EntityFrameworkCore.DbUpdateException: An error occurred while updating the entries. See the inner exception for details. ---> MySql.Data.MySqlClient.MySqlException: Cannot add or update a child row: a foreign key constraint fails (`ace_shard`.`biota_properties_bool`, CONSTRAINT `wcid_bool` FOREIGN KEY (`object_Id`) REFERENCES `biota` (`id`) ON DELETE CASCADE) ---> MySql.Data.MySqlClient.MySqlException: Cannot add or update a child row: a foreign key constraint fails (`ace_shard`.`biota_properties_bool`, CONSTRAINT `wcid_bool` FOREIGN KEY (`object_Id`) REFERENCES `biota` (`id`) ON DELETE CASCADE) at MySqlConnector.Core.ResultSet.ReadResultSetHeaderAsync(IOBehavior ioBehavior) in C:\projects\mysqlconnector\src\MySqlConnector\Core\ResultSet.cs:line 44 --- End of inner exception stack trace --- at MySql.Data.MySqlClient.MySqlDataReader.ActivateResultSet(ResultSet resultSet) in C:\projects\mysqlconnector\src\MySqlConnector\MySql.Data.MySqlClient\MySqlDataReader.cs:line 93 at MySql.Data.MySqlClient.MySqlDataReader.ReadFirstResultSetAsync(IOBehavior ioBehavior) in C:\projects\mysqlconnector\src\MySqlConnector\MySql.Data.MySqlClient\MySqlDataReader.cs:line 328 at MySql.Data.MySqlClient.MySqlDataReader.CreateAsync(MySqlCommand command, CommandBehavior behavior, IOBehavior ioBehavior) in C:\projects\mysqlconnector\src\MySqlConnector\MySql.Data.MySqlClient\… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
433636172 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433636172 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzYzNjE3Mg== | Warloxx01 38050842 | 2018-10-27T16:44:43Z | 2018-10-27T16:45:25Z | NONE | OK, WOW, If I double click the item on the ground once nothing happens, but if I double click it twice ( im using s ring) it equips it from the ground and moves the one in my back pack to my finger location. But leaves the ring on the ground. if I remove the ring from my finger and then re-equip it again from my pack and then remove it again. The ring on the ground disappears. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
433653945 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433653945 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzY1Mzk0NQ== | Mag-nus 10608427 | 2018-10-27T20:46:38Z | 2018-10-27T20:46:38Z | MEMBER | I think I know what the drop item bug is. I'll push a fix later. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
433669003 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-433669003 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzMzY2OTAwMw== | Mag-nus 10608427 | 2018-10-28T01:35:36Z | 2018-10-28T01:35:36Z | MEMBER | Ok, i just pushed what I believe is the fix. It's possible you may have some items that have been corrupted between the drop/give. The client won't let you give or drop these items. Not even sure you can drop them on a TC. I'll have to look into how we solve this later. Now, when you drop and give an item, the item is saved to the database. It was done this way before a recent change, but, I removed that to avoid a performance hit. They must be added back for now until I can figure out how to update just the ContainerId and WielderId properties for efficiency. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
434322528 | https://github.com/ACEmulator/ACE/issues/1076#issuecomment-434322528 | https://api.github.com/repos/ACEmulator/ACE/issues/1076 | MDEyOklzc3VlQ29tbWVudDQzNDMyMjUyOA== | Mag-nus 10608427 | 2018-10-30T14:27:13Z | 2018-10-30T14:27:13Z | MEMBER | I believe #1081 addresses the issues you messaged me about. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Inventory items reapearing in Backpack after log out/in 374027900 | |
434685058 | https://github.com/ACEmulator/ACE/pull/1081#issuecomment-434685058 | https://api.github.com/repos/ACEmulator/ACE/issues/1081 | MDEyOklzc3VlQ29tbWVudDQzNDY4NTA1OA== | Warloxx01 38050842 | 2018-10-31T13:24:23Z | 2018-10-31T13:33:16Z | NONE | I have tested the 14 files and it seems to have cured the items reappearing in my inventory... But, I also want to let you know there are other issues. NOT caused by this fix. Ill post them in a Bug report. But it looks like this fixed the reappearing issue. Ill do more testing. This did not fix the... 1)Drop item, Logout 2) Log back in, pick up item. 3) Log out/Log in Drop item (item still disappears immediately) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | More item destruction fixes 375517888 | |
434758041 | https://github.com/ACEmulator/ACE/pull/1081#issuecomment-434758041 | https://api.github.com/repos/ACEmulator/ACE/issues/1081 | MDEyOklzc3VlQ29tbWVudDQzNDc1ODA0MQ== | Mag-nus 10608427 | 2018-10-31T16:36:17Z | 2018-10-31T16:36:17Z | MEMBER | Can you please create an issue for that as well? I am able to duplicate it. I think it's an issue with the notification system. I tested two of the same items, one through the process you mentioned and one just held in my inventory the whole time. The item properties were the same for all properties that mattered, between the two. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | More item destruction fixes 375517888 | |
450532294 | https://github.com/ACEmulator/ACE/issues/1083#issuecomment-450532294 | https://api.github.com/repos/ACEmulator/ACE/issues/1083 | MDEyOklzc3VlQ29tbWVudDQ1MDUzMjI5NA== | Mag-nus 10608427 | 2018-12-30T01:11:48Z | 2018-12-30T01:11:48Z | MEMBER | Should be fixed in #1197 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Able to drop Attune and Bonded items 375962769 | |
434827583 | https://github.com/ACEmulator/ACE/issues/1084#issuecomment-434827583 | https://api.github.com/repos/ACEmulator/ACE/issues/1084 | MDEyOklzc3VlQ29tbWVudDQzNDgyNzU4Mw== | Mag-nus 10608427 | 2018-10-31T20:00:53Z | 2018-10-31T20:00:53Z | MEMBER | I can duplicate this. During this test, I created 2 items of the same wcid. I left one in my inventory the whole time and the other i used for your scenario. When the item gets dropped, the player will still have it selected, so you can just hit the R key and the player will pick it back up (even when it's invisible). When the item is invisible, it is also invisible to any observers. If you pick the item back up in your inventory, and then id it. You can then use /propertydump to see its properties. Id the other item that has been in your pack the whole time and do a /propertydump. You'll see that all the important properties are the same. Note: /propertydump will spit out the properties for the last item you've identified. I didn't have time to propertydump the items while htey were both on the landblock (both the visible and non-visible ones). That will be the next step that may provide more clues. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Items Dissapearing immediately when dropped 376084064 | |
444703009 | https://github.com/ACEmulator/ACE/issues/1084#issuecomment-444703009 | https://api.github.com/repos/ACEmulator/ACE/issues/1084 | MDEyOklzc3VlQ29tbWVudDQ0NDcwMzAwOQ== | Mag-nus 10608427 | 2018-12-06T00:28:09Z | 2018-12-06T00:28:09Z | MEMBER | Some notes: The sequence is as follows. - Bob and Kathy log in. Bob drops an item. They both see it. - Bob logs out. Bog logs in, picks up the item, logs out. Kathy sees it dissapear. - Bob logs in, drops the item. Neither Bob nor Kathy can see it, but Bob still has it selected and can pick the item back up. It's right at his feet. It appears back in his inventory like normal. - Bob drops the item again. This time both Bob and Kathy can see it just fine. When in the invisible item state: - If the observers log out and back in, they still cannot see it. - If the server is shut down properly and restarted, observers can see it sitting on the landblock just fine. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Items Dissapearing immediately when dropped 376084064 | |
444703240 | https://github.com/ACEmulator/ACE/issues/1084#issuecomment-444703240 | https://api.github.com/repos/ACEmulator/ACE/issues/1084 | MDEyOklzc3VlQ29tbWVudDQ0NDcwMzI0MA== | Mag-nus 10608427 | 2018-12-06T00:29:27Z | 2018-12-06T00:30:12Z | MEMBER | Some commands that may help track this down: /knownobjs /visibleobjs /destructionqueue Try to duplicate the scenario in a very empty landblock and use the above commands. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Items Dissapearing immediately when dropped 376084064 | |
435125994 | https://github.com/ACEmulator/ACE/pull/1086#issuecomment-435125994 | https://api.github.com/repos/ACEmulator/ACE/issues/1086 | MDEyOklzc3VlQ29tbWVudDQzNTEyNTk5NA== | LtRipley36706 11369233 | 2018-11-01T17:49:34Z | 2018-11-01T17:49:34Z | MEMBER | Further changes made to implement configurable preload system. Less than thrilled about not having an easy way to default load Hebian-To specifically if config file isn't updated as shown in example. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixes for Anniversary Event emotes 376275136 | |
435130432 | https://github.com/ACEmulator/ACE/pull/1086#issuecomment-435130432 | https://api.github.com/repos/ACEmulator/ACE/issues/1086 | MDEyOklzc3VlQ29tbWVudDQzNTEzMDQzMg== | LtRipley36706 11369233 | 2018-11-01T18:02:47Z | 2018-11-01T18:02:47Z | MEMBER | fixed my default fall back concern in the null check... | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixes for Anniversary Event emotes 376275136 | |
435138211 | https://github.com/ACEmulator/ACE/pull/1086#issuecomment-435138211 | https://api.github.com/repos/ACEmulator/ACE/issues/1086 | MDEyOklzc3VlQ29tbWVudDQzNTEzODIxMQ== | Mag-nus 10608427 | 2018-11-01T18:25:18Z | 2018-11-01T18:25:18Z | MEMBER | I'm not up to speed on the comments or the code in this PR. I'd just like to note that the landblock preloading was added when ACE had a very poor landblock ctor. Now, ACE is much more efficient at async loading landblocks. This means preloading them is less important. My point is, there may be landblocks in the list that may no longer need to be there. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixes for Anniversary Event emotes 376275136 | |
284556139 | https://github.com/ACEmulator/ACE/pull/109#issuecomment-284556139 | https://api.github.com/repos/ACEmulator/ACE/issues/109 | MDEyOklzc3VlQ29tbWVudDI4NDU1NjEzOQ== | Forbiddenz 25387933 | 2017-03-06T22:33:12Z | 2017-03-06T22:33:12Z | CONTRIBUTOR | Fixed, | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | World Object Fix 212215798 | |
437638693 | https://github.com/ACEmulator/ACE/pull/1090#issuecomment-437638693 | https://api.github.com/repos/ACEmulator/ACE/issues/1090 | MDEyOklzc3VlQ29tbWVudDQzNzYzODY5Mw== | Mag-nus 10608427 | 2018-11-11T02:38:17Z | 2018-11-11T02:38:17Z | MEMBER | I approve this, but, some comments would be nice to describe why we're simply returning immediately in AddPart and RemovePart. A dev will most likely stumble on this code eventually and ask the question. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improved ShadowPart performance 379052858 | |
439700449 | https://github.com/ACEmulator/ACE/pull/1097#issuecomment-439700449 | https://api.github.com/repos/ACEmulator/ACE/issues/1097 | MDEyOklzc3VlQ29tbWVudDQzOTcwMDQ0OQ== | Mag-nus 10608427 | 2018-11-18T15:17:55Z | 2018-11-18T15:17:55Z | MEMBER | Couple of quick tests: Dat's are on an intel NVME SSD. Reading every file (but not unpacking) from both dats **with** keep open: Elapsed: 12.93s Elapsed: 12.80s Elapsed: 12.78s Elapsed: 12.80s Elapsed: 13.14s Elapsed: 12.84s Elapsed: 12.82s Elapsed: 12.84s Reading every file (but not unpacking) from both dats **without** keep open: Elapsed: 68.01s Elapsed: 67.70s Elapsed: 67.26s Elapsed: 67.57s Elapsed: 67.35s Elapsed: 68.21s Elapsed: 67.60s Seems like this PR should add some performance to ACE. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | keepOpen option added to DatDatabase FileStream 381966627 | |
441768928 | https://github.com/ACEmulator/ACE/pull/1099#issuecomment-441768928 | https://api.github.com/repos/ACEmulator/ACE/issues/1099 | MDEyOklzc3VlQ29tbWVudDQ0MTc2ODkyOA== | fartwhif 3317737 | 2018-11-26T19:36:01Z | 2018-11-26T19:37:15Z | COLLABORATOR | impressive! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Appending client lib 383329969 | |
277183931 | https://github.com/ACEmulator/ACE/pull/11#issuecomment-277183931 | https://api.github.com/repos/ACEmulator/ACE/issues/11 | MDEyOklzc3VlQ29tbWVudDI3NzE4MzkzMQ== | sbaum23 22650655 | 2017-02-03T07:40:42Z | 2017-02-03T07:40:42Z | CONTRIBUTOR | Added /teleto debug command to teleport to coordinates. Z value is currently hard coded to 200 because it needs to be read from a file (dat?). Also, the two methods to convert Coordinates to XYZ are in DebugCommands.cs because I'm not sure where you want to put them. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Run faster, jump higher, teleport to coordinates (rather than XYZ position) 204803198 | |
277360874 | https://github.com/ACEmulator/ACE/pull/11#issuecomment-277360874 | https://api.github.com/repos/ACEmulator/ACE/issues/11 | MDEyOklzc3VlQ29tbWVudDI3NzM2MDg3NA== | sbaum23 22650655 | 2017-02-03T20:59:39Z | 2017-02-03T20:59:39Z | CONTRIBUTOR | I blew away my fork. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Run faster, jump higher, teleport to coordinates (rather than XYZ position) 204803198 | |
441377549 | https://github.com/ACEmulator/ACE/pull/1102#issuecomment-441377549 | https://api.github.com/repos/ACEmulator/ACE/issues/1102 | MDEyOklzc3VlQ29tbWVudDQ0MTM3NzU0OQ== | dgatewood 10187880 | 2018-11-24T16:02:49Z | 2018-11-25T06:02:22Z | COLLABORATOR | Dont merge yet. I need to test some things. Now it is ready. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding scrolls to loot profiles 383966681 | |
442847103 | https://github.com/ACEmulator/ACE/pull/1104#issuecomment-442847103 | https://api.github.com/repos/ACEmulator/ACE/issues/1104 | MDEyOklzc3VlQ29tbWVudDQ0Mjg0NzEwMw== | fartwhif 3317737 | 2018-11-29T14:12:11Z | 2018-11-29T14:15:25Z | COLLABORATOR | Primary work is complete. Ready for approval or suggested changes. This update will bring the network layer into the reliable category, at least according to the longevity with synthetic harshness WAN testing I've been doing. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | fixing networking bugs 384161840 | |
443552927 | https://github.com/ACEmulator/ACE/pull/1114#issuecomment-443552927 | https://api.github.com/repos/ACEmulator/ACE/issues/1114 | MDEyOklzc3VlQ29tbWVudDQ0MzU1MjkyNw== | LtRipley36706 11369233 | 2018-12-02T23:33:52Z | 2018-12-02T23:33:52Z | MEMBER | Wasn't able to move to automatic discovery of tests still due to issues with Appveyor dotnet test handling, but did improve output. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update appveyor.yml for tests 386608984 | |
443567171 | https://github.com/ACEmulator/ACE/pull/1115#issuecomment-443567171 | https://api.github.com/repos/ACEmulator/ACE/issues/1115 | MDEyOklzc3VlQ29tbWVudDQ0MzU2NzE3MQ== | Mag-nus 10608427 | 2018-12-03T02:06:08Z | 2018-12-03T02:06:08Z | MEMBER | Both issues have been addressed. For the unusable skills, they're still in the untrained state, so they're displayed with that list. They now just have the [Unusable] tag added to the end. They are sorted in the order as they appear in the client. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Profiling based improvements 386616346 | |
443684667 | https://github.com/ACEmulator/ACE/pull/1115#issuecomment-443684667 | https://api.github.com/repos/ACEmulator/ACE/issues/1115 | MDEyOklzc3VlQ29tbWVudDQ0MzY4NDY2Nw== | gmriggs 8909245 | 2018-12-03T11:53:34Z | 2018-12-03T11:53:34Z | COLLABORATOR | Bow: 0 Mace: 0 Sword: 0 UnarmedCombat: 0 These skills are showing up in Player.Skills as 'untrained', instead of 'inactive' | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Profiling based improvements 386616346 | |
444608917 | https://github.com/ACEmulator/ACE/pull/1117#issuecomment-444608917 | https://api.github.com/repos/ACEmulator/ACE/issues/1117 | MDEyOklzc3VlQ29tbWVudDQ0NDYwODkxNw== | gmriggs 8909245 | 2018-12-05T19:19:26Z | 2018-12-05T19:19:26Z | COLLABORATOR | @LtRipley36706 The database objects have been moved to 16py repo as suggested | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Adding summoning from @mcreedjr 387236335 | |
570936853 | https://github.com/ACEmulator/ACE/issues/1120#issuecomment-570936853 | https://api.github.com/repos/ACEmulator/ACE/issues/1120 | MDEyOklzc3VlQ29tbWVudDU3MDkzNjg1Mw== | Mag-nus 10608427 | 2020-01-05T18:46:25Z | 2020-01-05T18:46:25Z | MEMBER | I'm closing this. This is just one of the many things that will have to be addressed when multi-threading is expanded. When we get to that point, we can better define what systems will need adjustment. This could be done in a more generic issue or "Project" | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE.Server.Entity.Fellowship will need thread safety 387790815 | |
447392715 | https://github.com/ACEmulator/ACE/issues/1125#issuecomment-447392715 | https://api.github.com/repos/ACEmulator/ACE/issues/1125 | MDEyOklzc3VlQ29tbWVudDQ0NzM5MjcxNQ== | LtRipley36706 11369233 | 2018-12-14T17:21:27Z | 2018-12-14T17:21:27Z | MEMBER | This is a @gmriggs issue, door is in database, placement system fails to spawn it correctly. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | couldn't spawn Door 389068221 | |
447573535 | https://github.com/ACEmulator/ACE/issues/1125#issuecomment-447573535 | https://api.github.com/repos/ACEmulator/ACE/issues/1125 | MDEyOklzc3VlQ29tbWVudDQ0NzU3MzUzNQ== | gmriggs 8909245 | 2018-12-15T14:45:30Z | 2018-12-15T14:45:30Z | COLLABORATOR | Fixed in https://github.com/ACEmulator/ACE/pull/1141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | couldn't spawn Door 389068221 | |
447561161 | https://github.com/ACEmulator/ACE/issues/1128#issuecomment-447561161 | https://api.github.com/repos/ACEmulator/ACE/issues/1128 | MDEyOklzc3VlQ29tbWVudDQ0NzU2MTE2MQ== | gmriggs 8909245 | 2018-12-15T11:20:16Z | 2018-12-15T11:20:27Z | COLLABORATOR | Still looking for a way to replicate the floating NPC bug For the players being located in inconsistent locations, this should be resolved in https://github.com/ACEmulator/ACE/pull/1132. It's possible this same patch could resolve the floating NPC issue, although since I have been unable to repro the bug, I can't say for certain | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Floating NPC multiple clients 389076663 | |
449590157 | https://github.com/ACEmulator/ACE/issues/1128#issuecomment-449590157 | https://api.github.com/repos/ACEmulator/ACE/issues/1128 | MDEyOklzc3VlQ29tbWVudDQ0OTU5MDE1Nw== | MiachofTD 24981658 | 2018-12-22T18:41:12Z | 2018-12-22T18:41:12Z | CONTRIBUTOR | Think I found a way to recreate this issue. Log into Holt. Open a few NPC's. Go into drudge hideout for a little bit killing about half the dungeon. Exit drudge hideout via exit portal. Run back to the NPC's you recently opened. Some will float some may not. Take special not the ones you didn't open to start with will not be floating. Please see attached video. Updated to latest version since 10:15am CST 12-22-2018. Error log shown in video will be posted below. https://youtu.be/x72HvoIdnBA | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Floating NPC multiple clients 389076663 | |
449590161 | https://github.com/ACEmulator/ACE/issues/1128#issuecomment-449590161 | https://api.github.com/repos/ACEmulator/ACE/issues/1128 | MDEyOklzc3VlQ29tbWVudDQ0OTU5MDE2MQ== | MiachofTD 24981658 | 2018-12-22T18:41:21Z | 2018-12-22T18:41:21Z | CONTRIBUTOR | 2018-12-22 11:25:18,392 ERROR: System.InvalidOperationException: Nullable object must have a value. at ACE.Server.WorldObjects.Player.DamageTarget(Creature target, WorldObject d amageSource) in C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Server\Worl dObjects\Player_Combat.cs:line 149 at ACE.Server.WorldObjects.Projectile.OnCollideObject(WorldObject target) in C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Server\WorldObjects\Project ile.cs:line 52 at ACE.Server.Physics.Common.WeenieObject.DoCollision(AtkCollisionProfile pro f, ObjectGuid guid, PhysicsObj target) in C:\Users\Administrator\Desktop\ACE-mas ter\Source\ACE.Server\Physics\Common\WeenieObject.cs:line 106 at ACE.Server.Physics.PhysicsObj.report_object_collision(PhysicsObj obj, Bool ean prev_has_contact) in C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Se rver\Physics\PhysicsObj.cs:line 2963 at ACE.Server.Physics.PhysicsObj.handle_all_collisions(CollisionInfo collisio ns, Boolean prev_has_contact, Boolean prev_on_walkable) in C:\Users\Administrato r\Desktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj.cs:line 2347 at ACE.Server.Physics.PhysicsObj.SetPositionInternal(Transition transition) i n C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj .cs:line 1179 at ACE.Server.Physics.PhysicsObj.UpdateObjectInternal(Double quantum) in C:\U sers\Administrator\Desktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj.cs:li ne 1498 at ACE.Server.Physics.PhysicsObj.update_object() in C:\Users\Administrator\De sktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj.cs:line 3758 at ACE.Server.WorldObjects.WorldObject.UpdateObjectPhysics() in C:\Users\Admi nistrator\Desktop\ACE-master\Source\ACE.Server\WorldObjects\WorldObject_Tick.cs: line 196 at ACE.Server.Managers.WorldManager.HandlePhysicsLandblock(Landblock landbloc k, Double timeTick, ConcurrentQueue`1 movedObjects) in C:\Users\Administrator\De sktop\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:l… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Floating NPC multiple clients 389076663 | |
449605369 | https://github.com/ACEmulator/ACE/issues/1128#issuecomment-449605369 | https://api.github.com/repos/ACEmulator/ACE/issues/1128 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNTM2OQ== | gmriggs 8909245 | 2018-12-23T00:09:48Z | 2018-12-23T00:09:48Z | COLLABORATOR | Thanks for the update, very useful info ! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Floating NPC multiple clients 389076663 | |
447420521 | https://github.com/ACEmulator/ACE/issues/1129#issuecomment-447420521 | https://api.github.com/repos/ACEmulator/ACE/issues/1129 | MDEyOklzc3VlQ29tbWVudDQ0NzQyMDUyMQ== | OptimShi 26606778 | 2018-12-14T18:56:29Z | 2018-12-14T18:56:29Z | COLLABORATOR | This is a data related issue. PropertyInt.Locations (9) is set to 16 (LowerArmWear) when it should be 4096 (LowerArmArmor) No item should have just "upper/lower arm wear" set without ChestWear also set. Similarly for underpants, which I believe should always have AdbomenWear set. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Leather and Studded Leather Bracers not showing in "Slots" screen 389097376 | |
447591352 | https://github.com/ACEmulator/ACE/pull/1140#issuecomment-447591352 | https://api.github.com/repos/ACEmulator/ACE/issues/1140 | MDEyOklzc3VlQ29tbWVudDQ0NzU5MTM1Mg== | LtRipley36706 11369233 | 2018-12-15T19:15:55Z | 2018-12-15T19:16:29Z | MEMBER | Resolves #1126 Resolves #811 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update Vendor.cs, Resolves #1126 and Resolves #811 391233357 | |
447591204 | https://github.com/ACEmulator/ACE/pull/1141#issuecomment-447591204 | https://api.github.com/repos/ACEmulator/ACE/issues/1141 | MDEyOklzc3VlQ29tbWVudDQ0NzU5MTIwNA== | LtRipley36706 11369233 | 2018-12-15T19:13:22Z | 2018-12-15T19:13:22Z | MEMBER | Resolves #1125 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixing gfxobj placement, Resolves #1125 391365250 | |
447985290 | https://github.com/ACEmulator/ACE/issues/1145#issuecomment-447985290 | https://api.github.com/repos/ACEmulator/ACE/issues/1145 | MDEyOklzc3VlQ29tbWVudDQ0Nzk4NTI5MA== | gmriggs 8909245 | 2018-12-17T20:21:43Z | 2018-12-17T20:21:43Z | COLLABORATOR | Fixed in https://github.com/ACEmulator/ACE/pull/1148 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't unselect spell categories 391531272 | |
448776000 | https://github.com/ACEmulator/ACE/pull/1146#issuecomment-448776000 | https://api.github.com/repos/ACEmulator/ACE/issues/1146 | MDEyOklzc3VlQ29tbWVudDQ0ODc3NjAwMA== | dgatewood 10187880 | 2018-12-19T22:57:39Z | 2018-12-19T22:57:39Z | COLLABORATOR | This looks good to me | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improving housing system 391597401 | |
448976765 | https://github.com/ACEmulator/ACE/issues/1158#issuecomment-448976765 | https://api.github.com/repos/ACEmulator/ACE/issues/1158 | MDEyOklzc3VlQ29tbWVudDQ0ODk3Njc2NQ== | gmriggs 8909245 | 2018-12-20T12:08:34Z | 2018-12-20T12:08:34Z | COLLABORATOR | Updated in https://github.com/ACEmulator/ACE/pull/1159 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Critical: Redesign Sequence system 392985817 | |
449249758 | https://github.com/ACEmulator/ACE/pull/1162#issuecomment-449249758 | https://api.github.com/repos/ACEmulator/ACE/issues/1162 | MDEyOklzc3VlQ29tbWVudDQ0OTI0OTc1OA== | fartwhif 3317737 | 2018-12-21T04:55:08Z | 2018-12-21T04:55:27Z | COLLABORATOR | ` OldRandom.RollDice(int min, int max): 00:00:10.0000056, iterations: 134002807 OldRandom.RollDice(float min, float max): 00:00:10.0000075, iterations: 137180787 OldRandom.RollDice(uint min, uint max): 00:00:10.0000001, iterations: 136066119 ThreadSafeRandom.Next(int min, int max): 00:00:10.0000001, iterations: 225691575 ThreadSafeRandom.Next(float min, float max): 00:00:10.0000003, iterations: 231988872 ThreadSafeRandom.Next(uint min, uint max): 00:00:10.0000002, iterations: 228039807` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Moving ACE.Server.Physics.Common.Random to ACE.Common.Random 393271794 | |
449388245 | https://github.com/ACEmulator/ACE/pull/1162#issuecomment-449388245 | https://api.github.com/repos/ACEmulator/ACE/issues/1162 | MDEyOklzc3VlQ29tbWVudDQ0OTM4ODI0NQ== | fartwhif 3317737 | 2018-12-21T13:27:30Z | 2018-12-21T13:29:18Z | COLLABORATOR | No problem. Actually, I just noticed that I accidentally included one of your branches. I'll submit a new PR tonight after I remove your branch concerning melee combat and refactor ACE.Common.ThreadSafeRandom to just ACE.ThreadSafeRandom | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Moving ACE.Server.Physics.Common.Random to ACE.Common.Random 393271794 | |
449362857 | https://github.com/ACEmulator/ACE/pull/1165#issuecomment-449362857 | https://api.github.com/repos/ACEmulator/ACE/issues/1165 | MDEyOklzc3VlQ29tbWVudDQ0OTM2Mjg1Nw== | LtRipley36706 11369233 | 2018-12-21T11:20:35Z | 2018-12-21T11:20:35Z | MEMBER | This combined with ACEmulator/ACE-World-16PY-Patches#19 (ACE World Database v0.9.5) Resolves #1147 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Odds and ends, Resolves #1147 393394354 | |
449522375 | https://github.com/ACEmulator/ACE/pull/1167#issuecomment-449522375 | https://api.github.com/repos/ACEmulator/ACE/issues/1167 | MDEyOklzc3VlQ29tbWVudDQ0OTUyMjM3NQ== | fartwhif 3317737 | 2018-12-21T23:24:38Z | 2018-12-21T23:24:38Z | COLLABORATOR | ` OldRandom.RollDice(int min, int max): 00:00:10.0000056, iterations: 134002807 OldRandom.RollDice(float min, float max): 00:00:10.0000075, iterations: 137180787 OldRandom.RollDice(uint min, uint max): 00:00:10.0000001, iterations: 136066119 ThreadSafeRandom.Next(int min, int max): 00:00:10.0000001, iterations: 225691575 ThreadSafeRandom.Next(float min, float max): 00:00:10.0000003, iterations: 231988872 ThreadSafeRandom.Next(uint min, uint max): 00:00:10.0000002, iterations: 228039807` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Moving class ACE.Server.Physics.Common.Random to ACE.ThreadSafeRandom in project ACE.Common 393617284 | |
285928441 | https://github.com/ACEmulator/ACE/pull/117#issuecomment-285928441 | https://api.github.com/repos/ACEmulator/ACE/issues/117 | MDEyOklzc3VlQ29tbWVudDI4NTkyODQ0MQ== | LtRipley36706 11369233 | 2017-03-12T07:49:11Z | 2017-03-12T07:49:11Z | MEMBER | Working on a few changes | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Marketplace Recall + some other changes 213281968 | |
286009596 | https://github.com/ACEmulator/ACE/pull/117#issuecomment-286009596 | https://api.github.com/repos/ACEmulator/ACE/issues/117 | MDEyOklzc3VlQ29tbWVudDI4NjAwOTU5Ng== | LtRipley36706 11369233 | 2017-03-13T03:48:59Z | 2017-03-13T03:48:59Z | MEMBER | moving stuff around and redoing PR | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Marketplace Recall + some other changes 213281968 | |
449587064 | https://github.com/ACEmulator/ACE/issues/1170#issuecomment-449587064 | https://api.github.com/repos/ACEmulator/ACE/issues/1170 | MDEyOklzc3VlQ29tbWVudDQ0OTU4NzA2NA== | dgatewood 10187880 | 2018-12-22T17:46:55Z | 2018-12-22T17:46:55Z | COLLABORATOR | This is corrected by PR 1171. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature snuck into loot 393689057 | |
449591537 | https://github.com/ACEmulator/ACE/issues/1170#issuecomment-449591537 | https://api.github.com/repos/ACEmulator/ACE/issues/1170 | MDEyOklzc3VlQ29tbWVudDQ0OTU5MTUzNw== | MiachofTD 24981658 | 2018-12-22T19:05:55Z | 2018-12-22T19:05:55Z | CONTRIBUTOR | As follow up, also found a Yellow Topaz Chest in the loot for a drudge in Drudge Hideout. Did not grab a screenshot sorry and was before you corrected in PR 1171. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature snuck into loot 393689057 | |
458297307 | https://github.com/ACEmulator/ACE/issues/1170#issuecomment-458297307 | https://api.github.com/repos/ACEmulator/ACE/issues/1170 | MDEyOklzc3VlQ29tbWVudDQ1ODI5NzMwNw== | gmriggs 8909245 | 2019-01-28T20:54:37Z | 2019-01-28T20:54:37Z | COLLABORATOR | This has been resolved in https://github.com/ACEmulator/ACE/pull/1338 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Creature snuck into loot 393689057 | |
449604979 | https://github.com/ACEmulator/ACE/issues/1172#issuecomment-449604979 | https://api.github.com/repos/ACEmulator/ACE/issues/1172 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNDk3OQ== | gmriggs 8909245 | 2018-12-22T23:59:47Z | 2018-12-22T23:59:47Z | COLLABORATOR | This should be fixed in https://github.com/ACEmulator/ACE/pull/1168 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Null exception in combat, on an evade of incoming attack 393691682 | |
449614032 | https://github.com/ACEmulator/ACE/issues/1172#issuecomment-449614032 | https://api.github.com/repos/ACEmulator/ACE/issues/1172 | MDEyOklzc3VlQ29tbWVudDQ0OTYxNDAzMg== | ghost 10137 | 2018-12-23T04:41:26Z | 2018-12-23T04:41:26Z | NONE | Confirmed fixed by commit 1168 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Null exception in combat, on an evade of incoming attack 393691682 | |
449591847 | https://github.com/ACEmulator/ACE/issues/1173#issuecomment-449591847 | https://api.github.com/repos/ACEmulator/ACE/issues/1173 | MDEyOklzc3VlQ29tbWVudDQ0OTU5MTg0Nw== | MiachofTD 24981658 | 2018-12-22T19:11:30Z | 2018-12-22T19:11:30Z | CONTRIBUTOR | r\Desktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj.cs:line 2347 at ACE.Server.Physics.PhysicsObj.SetPositionInternal(Transition transition) i n C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj .cs:line 1179 at ACE.Server.Physics.PhysicsObj.UpdateObjectInternal(Double quantum) in C:\U sers\Administrator\Desktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj.cs:li ne 1498 at ACE.Server.Physics.PhysicsObj.update_object() in C:\Users\Administrator\De sktop\ACE-master\Source\ACE.Server\Physics\PhysicsObj.cs:line 3749 at ACE.Server.WorldObjects.WorldObject.UpdateObjectPhysics() in C:\Users\Admi nistrator\Desktop\ACE-master\Source\ACE.Server\WorldObjects\WorldObject_Tick.cs: line 196 at ACE.Server.Managers.WorldManager.HandlePhysicsLandblock(Landblock landbloc k, Double timeTick, ConcurrentQueue`1 movedObjects) in C:\Users\Administrator\De sktop\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:line 487 at ACE.Server.Managers.WorldManager.HandlePhysics(Double timeTick) in C:\User s\Administrator\Desktop\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:li ne 454 2018-12-22 12:47:20,887 ERROR: System.InvalidOperationException: Nullable object must have a value. at ACE.Server.WorldObjects.Player.DamageTarget(Creature target, WorldObject d amageSource) in C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Server\Worl dObjects\Player_Combat.cs:line 149 at ACE.Server.WorldObjects.Projectile.OnCollideObject(WorldObject target) in C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Server\WorldObjects\Project ile.cs:line 52 at ACE.Server.Physics.Common.WeenieObject.DoCollision(AtkCollisionProfile pro f, ObjectGuid guid, PhysicsObj target) in C:\Users\Administrator\Desktop\ACE-mas ter\Source\ACE.Server\Physics\Common\WeenieObject.cs:line 106 at ACE.Server.Physics.PhysicsObj.report_object_collision(PhysicsObj obj, Bool ean prev_has_contact) in C:\Users\Administrator\Desktop\ACE-master\Source\ACE.Se rver\Physics\PhysicsO… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server box rapid errors when attacking Crystal Spur 393696449 | |
449595026 | https://github.com/ACEmulator/ACE/issues/1173#issuecomment-449595026 | https://api.github.com/repos/ACEmulator/ACE/issues/1173 | MDEyOklzc3VlQ29tbWVudDQ0OTU5NTAyNg== | MiachofTD 24981658 | 2018-12-22T20:10:35Z | 2018-12-22T22:05:31Z | CONTRIBUTOR | Digging deeper show that when using a bow (haven't tested other missile yet) if your arrow misses there will be a "Creature evaded your attack" message once or multiple times and for each miss message there is the error in the server window. It stops as long as you don't miss. Miss too many times and the server crashes. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server box rapid errors when attacking Crystal Spur 393696449 | |
449605056 | https://github.com/ACEmulator/ACE/issues/1173#issuecomment-449605056 | https://api.github.com/repos/ACEmulator/ACE/issues/1173 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNTA1Ng== | gmriggs 8909245 | 2018-12-23T00:01:24Z | 2018-12-23T00:01:24Z | COLLABORATOR | This should be fixed in https://github.com/ACEmulator/ACE/pull/1168 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server box rapid errors when attacking Crystal Spur 393696449 | |
449606047 | https://github.com/ACEmulator/ACE/issues/1173#issuecomment-449606047 | https://api.github.com/repos/ACEmulator/ACE/issues/1173 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNjA0Nw== | MiachofTD 24981658 | 2018-12-23T00:29:17Z | 2018-12-23T00:29:17Z | CONTRIBUTOR | So far looks like this is fixed. Have not been able to recreate the issue. Thanks! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Server box rapid errors when attacking Crystal Spur 393696449 | |
449606994 | https://github.com/ACEmulator/ACE/issues/1174#issuecomment-449606994 | https://api.github.com/repos/ACEmulator/ACE/issues/1174 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNjk5NA== | MiachofTD 24981658 | 2018-12-23T00:56:55Z | 2018-12-23T00:56:55Z | CONTRIBUTOR | Meant to add, note the title of the bows. The specify frost and pierce in the title and I don;t think they should. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Bow icons incorrect for containing spells 393713858 | |
449607844 | https://github.com/ACEmulator/ACE/issues/1174#issuecomment-449607844 | https://api.github.com/repos/ACEmulator/ACE/issues/1174 | MDEyOklzc3VlQ29tbWVudDQ0OTYwNzg0NA== | MiachofTD 24981658 | 2018-12-23T01:22:14Z | 2018-12-23T01:22:14Z | CONTRIBUTOR | Atlatl appear to have the same issue. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Bow icons incorrect for containing spells 393713858 | |
449616896 | https://github.com/ACEmulator/ACE/issues/1175#issuecomment-449616896 | https://api.github.com/repos/ACEmulator/ACE/issues/1175 | MDEyOklzc3VlQ29tbWVudDQ0OTYxNjg5Ng== | gmriggs 8909245 | 2018-12-23T06:09:45Z | 2018-12-23T06:09:45Z | COLLABORATOR | Weapon speed and animation timing addressed in https://github.com/ACEmulator/ACE/pull/1177 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Heavy Weapon movement and kill speed +weapon stats 393715353 | |
449617290 | https://github.com/ACEmulator/ACE/issues/1175#issuecomment-449617290 | https://api.github.com/repos/ACEmulator/ACE/issues/1175 | MDEyOklzc3VlQ29tbWVudDQ0OTYxNzI5MA== | MiachofTD 24981658 | 2018-12-23T06:23:20Z | 2018-12-23T06:23:20Z | CONTRIBUTOR | https://youtu.be/7y9rws1V7wc | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Heavy Weapon movement and kill speed +weapon stats 393715353 | |
449620736 | https://github.com/ACEmulator/ACE/issues/1175#issuecomment-449620736 | https://api.github.com/repos/ACEmulator/ACE/issues/1175 | MDEyOklzc3VlQ29tbWVudDQ0OTYyMDczNg== | gmriggs 8909245 | 2018-12-23T08:01:37Z | 2018-12-23T08:01:37Z | COLLABORATOR | Item enchantments picking up some other enchantments by mistake (Heavy Weapons Mastery Other VII, in this case) should be fixed now in https://github.com/ACEmulator/ACE/pull/1177 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Heavy Weapon movement and kill speed +weapon stats 393715353 | |
449620654 | https://github.com/ACEmulator/ACE/issues/1178#issuecomment-449620654 | https://api.github.com/repos/ACEmulator/ACE/issues/1178 | MDEyOklzc3VlQ29tbWVudDQ0OTYyMDY1NA== | gmriggs 8909245 | 2018-12-23T07:59:53Z | 2018-12-23T07:59:53Z | COLLABORATOR | Patched in https://github.com/ACEmulator/ACE/pull/1177 @Mag-nus: the + name qualifiers need to be re-evaluated, maybe PlayerManager.GetOnlinePlayer() should be searching for both Player and +Player? For a lot of the client commands, if I type /tell +Player, the client automatically strips out the + before sending the player name to the server | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Can't chat in @tells with admin characters 393728396 | |
285880069 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285880069 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTg4MDA2OQ== | lurker-mcdoogle 26334665 | 2017-03-11T16:47:30Z | 2017-03-11T16:47:30Z | CONTRIBUTOR | Hrm, noticed some bugs around objects not getting into the landblock collection. Not mergeworthy yet, but feel free to comment. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285907205 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285907205 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkwNzIwNQ== | Mag-nus 10608427 | 2017-03-11T22:59:59Z | 2017-03-11T22:59:59Z | MEMBER | Is this a modified version of mogwais code? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285913728 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285913728 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkxMzcyOA== | lurker-mcdoogle 26334665 | 2017-03-12T01:18:42Z | 2017-03-12T01:18:42Z | CONTRIBUTOR | no, he was talking about event systems of some sort. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285917933 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285917933 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkxNzkzMw== | lurker-mcdoogle 26334665 | 2017-03-12T02:54:11Z | 2017-03-12T02:54:11Z | CONTRIBUTOR | Updated with: 1) basic object factories 2) log4net - not having console output was killing me and we needed a logging framework anyway. nuget to the rescue. 3) moved "in front of" calculations to hang off the Position object for better reuse 4) fixed various landblock object cache bugs 5) added even more // TODO | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285936751 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285936751 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTkzNjc1MQ== | Mag-nus 10608427 | 2017-03-12T10:53:22Z | 2017-03-12T10:53:22Z | MEMBER | Ahh ok. I'll have to review this today. Talking with mogwai in private, his initial plan was event based, but it didn't pan out, so he scrapped that and was working on a different system, so I wasn't sure if this was that. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285966645 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285966645 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk2NjY0NQ== | Mag-nus 10608427 | 2017-03-12T19:04:57Z | 2017-03-12T19:04:57Z | MEMBER | I loaded this up. Broadcasting works which is nice. Seems to be a bit of client and server instability issues though. Will have to look at it more in depth. Also, it would be cleaner to review if the log4net changes weren't combined with the landblock code. Landblock management is already complex enough. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285994516 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285994516 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk5NDUxNg== | lurker-mcdoogle 26334665 | 2017-03-13T01:18:29Z | 2017-03-13T01:18:29Z | CONTRIBUTOR | I can gut the log4net stuff if you want, but I couldn't have debugged this without it. Either way. And yeah, I had stability issues as well, but it wasn't anything consistently reproducible. There was a comment about the update having to be sent after the client entered portal space, but I didn't do anything explicit to account for it. Let me know if you find anything specific. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285997814 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285997814 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk5NzgxNA== | Mag-nus 10608427 | 2017-03-13T01:53:40Z | 2017-03-13T01:53:40Z | MEMBER | At this point, might as well keep the log4net in there. It makes sense moving forward, and no sense in duplicating the work later. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
285998186 | https://github.com/ACEmulator/ACE/pull/118#issuecomment-285998186 | https://api.github.com/repos/ACEmulator/ACE/issues/118 | MDEyOklzc3VlQ29tbWVudDI4NTk5ODE4Ng== | lurker-mcdoogle 26334665 | 2017-03-13T01:57:25Z | 2017-03-13T01:57:25Z | CONTRIBUTOR | Merge conflicts now. Closing - will rebase when i can. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Landblocks 213533094 | |
450373293 | https://github.com/ACEmulator/ACE/pull/1184#issuecomment-450373293 | https://api.github.com/repos/ACEmulator/ACE/issues/1184 | MDEyOklzc3VlQ29tbWVudDQ1MDM3MzI5Mw== | dgatewood 10187880 | 2018-12-28T15:06:08Z | 2018-12-28T15:06:08Z | COLLABORATOR | Looks good. I think we went about this the same way. I would say this is ready for merge. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Improving recipe manager, adding tinkering and imbues to crafting system 394244031 | |
285913800 | https://github.com/ACEmulator/ACE/pull/119#issuecomment-285913800 | https://api.github.com/repos/ACEmulator/ACE/issues/119 | MDEyOklzc3VlQ29tbWVudDI4NTkxMzgwMA== | fantoms 37453 | 2017-03-12T01:20:16Z | 2017-03-12T05:23:25Z | CONTRIBUTOR | -Added the max level effect -Moved the effects to after the level-up network message sequence -I believe made the /grantxp now command work properly. Please let me know if this is correct: There was an issue where the max xp was not locking to Infinity, so I had to add another GrantXp command to add Additional XP for skill leveling, for after max level is achieved. -Moved the available credit update to the end so it doesn't spam the message until all credits are achieved, this fixed a bug I added. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Level up on xp change, PropertyInt Message Types and skill credits 213538178 | |
285923241 | https://github.com/ACEmulator/ACE/pull/119#issuecomment-285923241 | https://api.github.com/repos/ACEmulator/ACE/issues/119 | MDEyOklzc3VlQ29tbWVudDI4NTkyMzI0MQ== | fantoms 37453 | 2017-03-12T05:20:00Z | 2017-03-12T05:20:00Z | CONTRIBUTOR | Known issue: No formal name or label on skills. Examples: "VoidMagic" or "SneakAttack". | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Level up on xp change, PropertyInt Message Types and skill credits 213538178 | |
287548109 | https://github.com/ACEmulator/ACE/pull/119#issuecomment-287548109 | https://api.github.com/repos/ACEmulator/ACE/issues/119 | MDEyOklzc3VlQ29tbWVudDI4NzU0ODEwOQ== | fantoms 37453 | 2017-03-18T13:59:42Z | 2017-03-18T13:59:42Z | CONTRIBUTOR | Closing now, this was merged into PR #141 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Level up on xp change, PropertyInt Message Types and skill credits 213538178 | |
450336130 | https://github.com/ACEmulator/ACE/pull/1190#issuecomment-450336130 | https://api.github.com/repos/ACEmulator/ACE/issues/1190 | MDEyOklzc3VlQ29tbWVudDQ1MDMzNjEzMA== | Warloxx01 38050842 | 2018-12-28T10:20:48Z | 2018-12-28T10:21:46Z | NONE | Seems to work ( animation and is Consumed ) but it now reads in the Message window "Candy Corn applies Sweet Speed on you." and also now reads out in Green instead of Blue. In Player.cs I found this line... buffMessage = new GameMessageSystemChat($"{consumableName} applies {spell.Name} on you.", ChatMessageType.Craft); around Line 886. Should that be changed to casts? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Updating consumables 394579015 | |
450346647 | https://github.com/ACEmulator/ACE/pull/1190#issuecomment-450346647 | https://api.github.com/repos/ACEmulator/ACE/issues/1190 | MDEyOklzc3VlQ29tbWVudDQ1MDM0NjY0Nw== | gmriggs 8909245 | 2018-12-28T11:42:32Z | 2018-12-28T11:42:32Z | COLLABORATOR | Yep, good catch Updated PR | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Updating consumables 394579015 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);