issues
Data license: AGPL · Data source: ACEmulator Project
4,138 rows
This data as json, CSV (advanced)
id ▼ | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
211191210 | MDExOlB1bGxSZXF1ZXN0MTA4NjE2NDIz | 101 | World object - Seralization with Example | Forbiddenz 25387933 | closed | 0 | 0 | 2017-03-01T19:59:23Z | 2017-03-01T21:05:52Z | 2017-03-01T21:05:52Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/101 | World Object with Example @spawntest. This will only work one time because ACE dont have any real way to increment guids properly. Still could use some cleanup, but this is a great start and very useful so I am PRing it now. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211242008 | MDExOlB1bGxSZXF1ZXN0MTA4NjUzMzcy | 102 | World object - Improvement + Lifestone Test Object | Forbiddenz 25387933 | closed | 0 | 0 | 2017-03-01T23:28:15Z | 2017-03-02T22:47:00Z | 2017-03-02T12:55:01Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/102 | Use @spawntest to spawn a life stone. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
211490314 | MDExOlB1bGxSZXF1ZXN0MTA4ODMxMjM4 | 103 | Quick fixes 03022017 | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-02T19:21:20Z | 2017-03-02T20:08:23Z | 2017-03-02T20:08:23Z | MEMBER | 0 | ACEmulator/ACE/pulls/103 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
211502816 | MDExOlB1bGxSZXF1ZXN0MTA4ODQwNDU4 | 104 | portal.dat and cell.dat loading (issue #3) | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-02T20:09:02Z | 2017-05-30T15:34:36Z | 2017-03-04T12:59:37Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/104 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
211561301 | MDExOlB1bGxSZXF1ZXN0MTA4ODgzMTEx | 105 | More WorldObject Fixes | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-03T00:32:57Z | 2017-03-04T10:27:26Z | 2017-03-03T14:05:09Z | MEMBER | 0 | ACEmulator/ACE/pulls/105 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
211886644 | MDExOlB1bGxSZXF1ZXN0MTA5MTExNTA5 | 106 | Continuing SO's WorldObject rework | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-04T15:39:17Z | 2017-05-30T15:34:35Z | 2017-03-06T12:33:26Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/106 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/106/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
211999671 | MDExOlB1bGxSZXF1ZXN0MTA5MTc0Mzc1 | 107 | Add DAT loading into main process | ghost 10137 | closed | 0 | 3 | 2017-03-06T00:43:14Z | 2017-10-18T14:07:36Z | 2017-03-07T01:30:51Z | NONE | 0 | ACEmulator/ACE/pulls/107 | Obtains the two DAT file locations from the config.json file. Code also handles file not found exceptions and prints out an error. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212027453 | MDExOlB1bGxSZXF1ZXN0MTA5MTkyMzk2 | 108 | Time returns to Dereth | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-06T05:28:29Z | 2017-03-10T04:55:10Z | 2017-03-07T01:29:35Z | MEMBER | 0 | ACEmulator/ACE/pulls/108 | Rain rain go away... Added time to Dereth. Once the server starts, the clock is set and is hardcoded at this point to start at the current Lore corrected DerethDateTime. @time command wired up. Time progresses as it did on retail and does not reset in between sessions as long as server remains running. There are several functions within DerethDateTime that could help enable some interesting ideas in the future such as "dynamic seasons" and changing spawns based on TimeOfDay (like Graveyard) for examples. It would depend on if we're able to build in time-checking logic to spawnable/generator objects, which I assume we would be doing, especially once we get around to rebuilding the GY area. TODO: Save the progression of ServerTime periodically to be recalled when server is offline'd/online'd. TODO: Setup a variable in Config.json and ConfigManager to allow the server operator to pick a date to start the server from. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212215798 | MDExOlB1bGxSZXF1ZXN0MTA5MzI0Mjc1 | 109 | World Object Fix | Forbiddenz 25387933 | closed | 0 | 1 | 2017-03-06T18:55:41Z | 2017-03-06T22:38:36Z | 2017-03-06T22:38:36Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/109 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/109/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
212240568 | MDExOlB1bGxSZXF1ZXN0MTA5MzQyMDY2 | 110 | A fix to Prevent Skill Spend server crash and allow for max Ranked Skills (Infinity!) | fantoms 37453 | closed | 0 | 0 | 2017-03-06T20:30:18Z | 2017-03-07T01:29:18Z | 2017-03-07T01:29:18Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/110 | - Renamed abilityUpdate to skillUpdate, to reflect the correct function/variables. - Refactored the SpendXp skills function to send a gamemessage on failed skill updates that prevents client from locking up the Rank Up interface buttons. - Added an upper-bounds check to prevent skills from going out of bounds. - Created an offset variable to prevent +10 from going out of bounds when the rank is to high. - Changed the comment describing known issues on skillSpend | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/110/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212274507 | MDExOlB1bGxSZXF1ZXN0MTA5MzY3MDc2 | 111 | Life stone Fix = World Object Fix Usable | Forbiddenz 25387933 | closed | 0 | 0 | 2017-03-06T22:47:12Z | 2017-03-07T09:40:25Z | 2017-03-07T01:31:04Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/111 | Adding proper flags to World Object Usable. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/111/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212324458 | MDExOlB1bGxSZXF1ZXN0MTA5NDAyNDkw | 112 | Save default character options when creating a character. | sbaum23 22650655 | closed | 0 | 0 | 2017-03-07T04:00:31Z | 2017-03-07T13:14:03Z | 2017-03-07T13:14:03Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/112 | When creating a character this will set several character options to true and save to the database. The options set to true are the same ones when you click the "Default" button in the options tab. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/112/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212333121 | MDExOlB1bGxSZXF1ZXN0MTA5NDA4MzQz | 113 | Max Rank Fireworks and Correct Skill Rank Up text Color | fantoms 37453 | closed | 0 | 0 | 2017-03-07T05:17:04Z | 2017-05-23T15:53:42Z | 2017-03-07T13:45:27Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/113 | - I could not find a way to check the skill rank after it was set, so I added a function to check max rank. If the function returns a Boolean true, then the server will play fireworks when reached max rank - Changed the message type to Advancement when increasing skills too reflect the correct skill advancement chat color. - Added a few summary comments and fixed remarks/known issues. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212898925 | MDExOlB1bGxSZXF1ZXN0MTA5ODE0OTQ4 | 114 | Added GetClientCommands and GetConsoleCommands | Thwargle 25650194 | closed | 0 | 0 | 2017-03-09T00:22:27Z | 2017-03-15T19:04:45Z | 2017-03-15T19:04:45Z | NONE | 0 | ACEmulator/ACE/pulls/114 | Added the ability to request a list of console commands and client commands from the console. Added the ability to request a list of client commands from the game's chat window. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
212905393 | MDExOlB1bGxSZXF1ZXN0MTA5ODE5NTcw | 115 | Add host & port to connect messages | Zorgle 26289176 | closed | 0 | 0 | 2017-03-09T01:04:31Z | 2017-03-09T01:26:45Z | 2017-03-09T01:26:45Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/115 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/115/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
212958805 | MDExOlB1bGxSZXF1ZXN0MTA5ODU2NTM5 | 116 | Character Rename command added | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-09T07:43:33Z | 2017-03-10T04:54:58Z | 2017-03-09T13:34:36Z | MEMBER | 0 | ACEmulator/ACE/pulls/116 | Works via console and client. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/116/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
213281968 | MDExOlB1bGxSZXF1ZXN0MTEwMDg2MjA1 | 117 | Marketplace Recall + some other changes | LtRipley36706 11369233 | closed | 0 | 2 | 2017-03-10T09:00:18Z | 2017-03-20T02:58:24Z | 2017-03-19T09:04:52Z | MEMBER | 0 | ACEmulator/ACE/pulls/117 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/117/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
213533094 | MDExOlB1bGxSZXF1ZXN0MTEwMjYxODY3 | 118 | Landblocks | lurker-mcdoogle 26334665 | closed | 0 | 9 | 2017-03-11T14:52:38Z | 2017-03-13T01:57:25Z | 2017-03-13T01:57:25Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/118 | there are a lot of // TODO comments all over this thing. here's what I know works: /telepoi town1 /createlifestone /telepoi town2 /telepoi town1 ... and the lifestone is still there. Looked like Mogwai bailed yesterday so I figured I'd upload this stuff just in case you wanted it. Local chat was started, but not done. I may or may not have broken it - I didn't test. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
213538178 | MDExOlB1bGxSZXF1ZXN0MTEwMjY0MDY3 | 119 | Level up on xp change, PropertyInt Message Types and skill credits | fantoms 37453 | closed | 0 | LtRipley36706 11369233 | 3 | 2017-03-11T16:08:42Z | 2017-05-23T15:53:44Z | 2017-03-18T13:59:42Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/119 | - Changed the Character.Level variable from an int to a uint. - Added leveling up on grantxp. Since we don't get XP anywhere else, this is the only way so far. - Added skill credits. You cannot spend them to add skills yet. AvailableSkillCredits. - Changed the /grantxp command to allow up too 999,999,999,999 xp. - Followed @Zegeger and created a Network Message Type for PropertyInt - Allow for Max Level locking, set from the XP chart. - Added effects on leveling up. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/119/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||
213652440 | MDExOlB1bGxSZXF1ZXN0MTEwMzI1NjM2 | 120 | Logoff works. | Mag-nus 10608427 | closed | 0 | 0 | 2017-03-13T01:22:21Z | 2017-03-13T01:22:32Z | 2017-03-13T01:22:32Z | MEMBER | 0 | ACEmulator/ACE/pulls/120 | Save character position implemented. Character position is not updated in-game yet. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/120/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
213657914 | MDExOlB1bGxSZXF1ZXN0MTEwMzI5MTQw | 121 | Landblocks, logging, object factory prep work | lurker-mcdoogle 26334665 | closed | 0 | Mogwai-TheFurry 25351661 | 3 | 2017-03-13T02:23:28Z | 2017-03-18T18:42:28Z | 2017-03-18T18:42:28Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/121 | there are a lot of // TODO comments all over this thing. here's what I know works: /telepoi town1 /createlifestone /telepoi town2 /telepoi town1 ... and the lifestone is still there. Features: * Landblock Management * Landblock Handoff of teleporting objects * Broadcasting of objects on a landblock based on existence * Update of objects in a landblock based on Movement * Landblock adjacency broadcasting * basic object factories * log4net - not having console output was killing me and we needed a logging framework anyway. nuget to the rescue. * moved "in front of" calculations to hang off the Position object for better reuse * PackedDWORD object * Delayed update of position after entering portal space seems to have helped porting stability. Known Issues * Adjacency matrix has issues broadcasting to the correct adjacencies. Shouldn't be a big deal - I'll fix it later. * local chat is untested and possibly/likely broken. Mag is showing up in the commit log because I squashed a commit with his name on it when attempting a rebase. Ended up just cherrypicking into a new branch. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/121/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||
213665597 | MDExOlB1bGxSZXF1ZXN0MTEwMzM0MjU3 | 122 | Minor tweaks 031217 | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-13T03:35:35Z | 2017-03-20T02:58:15Z | 2017-03-13T12:30:54Z | MEMBER | 0 | ACEmulator/ACE/pulls/122 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/122/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
213666871 | MDExOlB1bGxSZXF1ZXN0MTEwMzM1MTE0 | 123 | GameActionType renamed from GameActionOpcode | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-13T03:47:58Z | 2017-03-20T02:57:59Z | 2017-03-13T12:24:25Z | MEMBER | 0 | ACEmulator/ACE/pulls/123 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/123/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
213667290 | MDExOlB1bGxSZXF1ZXN0MTEwMzM1Mzcw | 124 | Bring Config.json.example into spec. | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-13T03:51:36Z | 2017-03-20T02:57:55Z | 2017-03-13T12:26:40Z | MEMBER | 0 | ACEmulator/ACE/pulls/124 | Should fix powershell script problem because our config.json was not in spec due to my comments. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/124/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
213680800 | MDExOlB1bGxSZXF1ZXN0MTEwMzQ0MjIx | 125 | Save Player Properties to db | fantoms 37453 | closed | 0 | LtRipley36706 11369233 | 2 | 2017-03-13T06:02:12Z | 2017-05-23T15:53:47Z | 2017-03-18T14:00:13Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/125 | -Saves every 60 "ticks". Please advise on the best stats saving interval. -Implemented database update functions for character properties. -Added a character save ticker. Please advise on the proper location for this, I did this quickly. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/125/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||
213875928 | MDExOlB1bGxSZXF1ZXN0MTEwNDgyMzkx | 126 | improved dat file content exporting | lurker-mcdoogle 26334665 | closed | 0 | 1 | 2017-03-13T19:42:02Z | 2017-03-14T18:32:43Z | 2017-03-14T18:32:43Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/126 | * improved cell.dat and portal.dat exporting * created admin server commands for exporting * unit tests that can be uncommented and run for exporting | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/126/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214166899 | MDExOlB1bGxSZXF1ZXN0MTEwNjg5MzEy | 127 | Dat File parsing | lurker-mcdoogle 26334665 | closed | 0 | 0 | 2017-03-14T18:33:48Z | 2017-03-15T12:12:22Z | 2017-03-15T12:12:22Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/127 | * improved cell.dat and portal.dat exporting, created admin server commands for them as well as unit tests that can be uncommented. * bug fix in DatFile with the FileOffset being wrong. started detailed documentation on dat file contents. * worked on some object parsing. found a bunch more object types in the client - now categorizes ALL portal files. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/127/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214495718 | MDExOlB1bGxSZXF1ZXN0MTEwOTIwNjg4 | 128 | Implement @acehelp and @acecommands | Thwargle 25650194 | closed | 0 | 0 | 2017-03-15T19:10:41Z | 2017-03-16T13:58:20Z | 2017-03-16T13:58:20Z | NONE | 0 | ACEmulator/ACE/pulls/128 | Implemented acehelp. Will work from console or client and inform the user of general help information. Implemented acecommands which will iterate through the list of commands based on the current accessLevel and dynamically list them on both the client and the server console. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/128/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214566929 | MDExOlB1bGxSZXF1ZXN0MTEwOTcxNzIy | 129 | Change ACE from clustered server to single server architecture. | Mag-nus 10608427 | closed | 0 | 0 | 2017-03-16T00:37:53Z | 2017-03-16T00:38:19Z | 2017-03-16T00:38:19Z | MEMBER | 0 | ACEmulator/ACE/pulls/129 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/129/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
214568342 | MDExOlB1bGxSZXF1ZXN0MTEwOTcyNzQw | 130 | This removes Host from the config. Servers are differentiated by the … | Mag-nus 10608427 | closed | 0 | 0 | 2017-03-16T00:48:57Z | 2017-03-16T00:49:04Z | 2017-03-16T00:49:04Z | MEMBER | 0 | ACEmulator/ACE/pulls/130 | …Port. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/130/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214596925 | MDExOlB1bGxSZXF1ZXN0MTEwOTkyMzE2 | 131 | Create Training Wand | ogmage78 25460553 | closed | 0 | 1 | 2017-03-16T04:37:15Z | 2017-03-16T05:13:40Z | 2017-03-16T05:13:40Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/131 | Added some test code to create a training wand. As part of this work, I put in some fixes in sizes, added AnimationFrame. While this is not all that spectacular - it perfectly matches live server pcaps in every field. I would like to work on persisting this out to the database. I assume we will need to implement a next object_id sequence as part of this. In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted. Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help. Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch. God this was fun. I forgot how much I used to love coding. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/131/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214601610 | MDExOlB1bGxSZXF1ZXN0MTEwOTk1NTMx | 132 | Fixed message fragmentation | Zegeger 12808515 | closed | 0 | 0 | 2017-03-16T05:19:55Z | 2017-03-16T12:15:40Z | 2017-03-16T12:15:40Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/132 | Fixed fragmentation logic; we should not fragment messages that do not fill a full packet. Removed NetworkSession.Flush as this change fixed all cases where that seemed needed. Fixed NETWORKDEBUG section which was missed by network refactor | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/132/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214688687 | MDExOlB1bGxSZXF1ZXN0MTExMDU2NzMx | 133 | Turbine Chat Channels description updates. ToD enabled. | Mag-nus 10608427 | closed | 0 | 0 | 2017-03-16T12:29:33Z | 2017-03-16T12:29:41Z | 2017-03-16T12:29:41Z | MEMBER | 0 | ACEmulator/ACE/pulls/133 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/133/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
214728678 | MDExOlB1bGxSZXF1ZXN0MTExMDg0NjA1 | 134 | Added attribute upper bounds check and max attribute fireworks and special text | fantoms 37453 | closed | 0 | LtRipley36706 11369233 | 1 | 2017-03-16T14:46:16Z | 2017-05-23T15:53:45Z | 2017-03-18T14:00:37Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/134 | -Added upper bounds checks for the Ranks so that Attributes will not crash the server. -Added fireworks and special text on max rank, too match skills. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/134/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||
214776568 | MDExOlB1bGxSZXF1ZXN0MTExMTE5OTYy | 135 | Implement @acehelp and @acecommands | Thwargle 25650194 | closed | 0 | 0 | 2017-03-16T17:14:02Z | 2017-03-17T13:32:54Z | 2017-03-17T13:32:54Z | NONE | 0 | ACEmulator/ACE/pulls/135 | Implement @acehelp which is a generic help command for use in the server console or client chat Implement @acecommands which iterates through all commands and dynamically shows the user the possible commands based on their current accesslevel Implemented a way to increase a characters accesslevel Stubbed out chat log writeouts for commands that are not implemented rather than have no feedback. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/135/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214781043 | MDExOlB1bGxSZXF1ZXN0MTExMTIzMjg3 | 136 | Create Training Wand - Demo work for item creation. | ogmage78 25460553 | closed | 0 | 3 | 2017-03-16T17:28:59Z | 2017-03-16T23:29:47Z | 2017-03-16T23:29:38Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/136 | Added some test code to create a training wand. As part of this work, I put in some fixes in sizes, added AnimationFrame. While this is not all that spectacular - it perfectly matches live server pcaps in every field. I would like to work on persisting this out to the database. I assume we will need to implement a next object_id sequence as part of this. In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted. Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help. Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch. God this was fun. I forgot how much I used to love coding. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214784803 | MDExOlB1bGxSZXF1ZXN0MTExMTI2MDMz | 137 | World object fixes | Forbiddenz 25387933 | closed | 0 | 2 | 2017-03-16T17:41:46Z | 2017-04-06T11:18:30Z | 2017-03-16T18:50:26Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/137 | World Object Fixes + Start of Global Guid Manager | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/137/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214820003 | MDExOlB1bGxSZXF1ZXN0MTExMTUxODk2 | 138 | police-mode /on | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-16T19:53:59Z | 2017-05-30T15:34:35Z | 2017-03-20T02:14:56Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/138 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/138/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
214868377 | MDExOlB1bGxSZXF1ZXN0MTExMTg2ODI0 | 139 | Updated for new wo changes - Create Training wand test implementation | ogmage78 25460553 | closed | 0 | 0 | 2017-03-16T23:31:14Z | 2017-03-19T03:28:36Z | 2017-03-19T03:28:36Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/139 | Added some test code to create a training wand. As part of this work, I put in some fixes in sizes, added AnimationFrame. While this is not all that spectacular - it perfectly matches live server pcaps in every field. I would like to work on persisting this out to the database. I assume we will need to implement a next object_id sequence as part of this. In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted. Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help. Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/139/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
214892739 | MDExOlB1bGxSZXF1ZXN0MTExMjAzNjcy | 140 | Fixed Hash32, which corrects Attribute raise issue | Zegeger 12808515 | closed | 0 | 0 | 2017-03-17T02:42:09Z | 2017-03-17T12:10:41Z | 2017-03-17T12:10:41Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/140 | Fixed error in shift logic of Hash32, preventing certain packets from calculating correct checksum | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/140/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215172361 | MDExOlB1bGxSZXF1ZXN0MTExNDAwNDQ1 | 141 | Saving Character to Database | LtRipley36706 11369233 | closed | 0 | 1 | 2017-03-18T07:16:07Z | 2017-03-20T02:58:10Z | 2017-03-18T19:47:13Z | MEMBER | 0 | ACEmulator/ACE/pulls/141 | "Ripley has been saved." This PR includes commits from the following PRs: #117 #119 #125 #134 This PR addresses issues: #51 #52 #53 Code work was done by @fantoms and myself Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues. Spending Skill Credits is not yet addressed. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/141/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215210864 | MDExOlB1bGxSZXF1ZXN0MTExNDE5NDI5 | 142 | Character will now level up on xp grants. Skill credits are also being assigned but are still not spendable. | damnubber 4389226 | closed | 0 | 0 | 2017-03-18T18:03:45Z | 2017-03-21T03:47:34Z | 2017-03-21T03:47:34Z | NONE | 0 | ACEmulator/ACE/pulls/142 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/142/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215216326 | MDExOlB1bGxSZXF1ZXN0MTExNDIyNTE4 | 143 | Saving Character to Database | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-18T19:35:31Z | 2017-03-20T02:57:39Z | 2017-03-20T02:46:55Z | MEMBER | 0 | ACEmulator/ACE/pulls/143 | "Ripley has been saved." This PR includes commits from the following PRs: #117 #119 #125 #134 #141 This PR addresses issues: #51 #52 #53 Code work was done by @fantoms and myself Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues. Spending Skill Credits is not yet addressed. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/143/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215224510 | MDU6SXNzdWUyMTUyMjQ1MTA= | 144 | Add the Ability to drop an item from your backpack. | ogmage78 25460553 | closed | 0 | ogmage78 25460553 | 1 | 2017-03-18T21:55:25Z | 2017-04-03T12:05:30Z | 2017-04-03T12:05:30Z | CONTRIBUTOR | I am working on this at the moment. Can it be assigned to me? | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/144/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
215229710 | MDExOlB1bGxSZXF1ZXN0MTExNDMwMzg4 | 145 | Change the AdminObjectFactory to LifestoneObjectFactory, add PortalOb… | ghost 10137 | closed | 0 | 0 | 2017-03-18T23:42:13Z | 2017-10-18T14:07:38Z | 2017-03-20T01:44:37Z | NONE | 0 | ACEmulator/ACE/pulls/145 | …jectFactory, add LifestoneType and PortalType Enums, remove unneeded GameMessageCreateLifestone, and remove the leftover DebugAssert command in ObjectGuid | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215238775 | MDExOlB1bGxSZXF1ZXN0MTExNDM1NjA5 | 146 | Create Training Wand Demo code and start inventory management Drop/Equip/pickup | ogmage78 25460553 | closed | 0 | 1 | 2017-03-19T03:36:14Z | 2017-03-19T13:24:51Z | 2017-03-19T13:24:51Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/146 | Added Test Code to create Training Wand Updated for new wo and landblock changes Started work to drop item. I want to add this interum work which compiles and works so that I might could get some assistance with the correct way to implement the event animation. Thanks Charles / Og II | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/146/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215266773 | MDExOlB1bGxSZXF1ZXN0MTExNDUxNTMy | 147 | Some minor cosmetic fixes. | Mag-nus 10608427 | closed | 0 | 0 | 2017-03-19T14:15:17Z | 2017-03-20T20:05:49Z | 2017-03-20T20:05:49Z | MEMBER | 0 | ACEmulator/ACE/pulls/147 | Some possible threading issues fixed. This also forces the build for ACE to x64 only. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215282644 | MDExOlB1bGxSZXF1ZXN0MTExNDYwODg4 | 148 | Add a link to ace-db docker image in the README | maxc0c0s 8466632 | closed | 0 | 3 | 2017-03-19T18:11:02Z | 2017-03-21T03:14:49Z | 2017-03-20T05:14:00Z | NONE | 0 | ACEmulator/ACE/pulls/148 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215315873 | MDExOlB1bGxSZXF1ZXN0MTExNDgwMjQ5 | 149 | added code for palettes to work correctly. PaletteGuid - corrected … | ogmage78 25460553 | closed | 0 | 0 | 2017-03-20T02:02:48Z | 2017-04-14T19:37:38Z | 2017-03-20T02:39:10Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/149 | Small PR to fix bug with Palette method. Added PaletteGuid and write it out as required. Fixed Spelling. The fix for this was originally implemented by @LytelthorpeThistledown Getting this in sooner rather than later will help a lot of people as they are starting to work on this area of the code. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/149/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215324894 | MDExOlB1bGxSZXF1ZXN0MTExNDg1ODQ2 | 150 | Wired up @heal command and conformed admincommands to stylecop rules | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-20T03:45:59Z | 2017-03-20T03:47:19Z | 2017-03-20T03:47:19Z | MEMBER | 0 | ACEmulator/ACE/pulls/150 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215325969 | MDExOlB1bGxSZXF1ZXN0MTExNDg2NTky | 151 | AdminCommands Code Style change | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-20T03:58:36Z | 2017-04-21T03:49:29Z | 2017-03-20T05:09:12Z | MEMBER | 0 | ACEmulator/ACE/pulls/151 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215328613 | MDExOlB1bGxSZXF1ZXN0MTExNDg4Mzc1 | 152 | Very basic animation | Zegeger 12808515 | closed | 0 | 0 | 2017-03-20T04:32:33Z | 2017-03-21T02:55:11Z | 2017-03-21T02:55:11Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/152 | Added basic animation message. Send logout animation when logging out. Created a sequence manager and related classes, trying to better structure the numerous sequences we must store/track. (Only started with animation sequences, but if we like this, can convert other sequences over) General cleanup | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/152/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215337062 | MDExOlB1bGxSZXF1ZXN0MTExNDkzODUz | 153 | Feature: Spend Skill Credits | fantoms 37453 | closed | 0 | 0 | 2017-03-20T06:11:56Z | 2017-05-23T15:53:56Z | 2017-03-20T12:08:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/153 | Within this request I've sent code that will allow the client to attempt too spend skill credits. If enough skill credits are available, the server will grant the skill to the the character. If the skill credits are not available or the skill has already been trained, then the server makes sure to send the correct game messages with Skill.None, to keep the client from locking up. On the bottom of the Skill.cs, I've added an extension that allows for skills with proper names, example: `Sneak Attack` instead of `SneakAttack`. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215393441 | MDExOlB1bGxSZXF1ZXN0MTExNTMyOTE1 | 154 | complete stylecop cleanup | lurker-mcdoogle 26334665 | closed | 0 | 0 | 2017-03-20T11:32:10Z | 2017-05-30T15:34:27Z | 2017-03-20T12:05:51Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/154 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/154/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215438276 | MDU6SXNzdWUyMTU0MzgyNzY= | 155 | Implement lifestone usage | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-20T14:30:48Z | 2017-04-10T11:35:50Z | 2017-04-10T11:35:50Z | CONTRIBUTOR | * Using a Lifestone * Implement /die or whatever the command was * Portal back to your position of the lifestone usage on death * [Bonus points] Vitae | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/155/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
215484872 | MDExOlB1bGxSZXF1ZXN0MTExNTk5MDcy | 156 | Heal: Update Player object, then send its data | LtRipley36706 11369233 | closed | 0 | 1 | 2017-03-20T16:51:50Z | 2017-04-21T03:49:12Z | 2017-03-20T20:06:39Z | MEMBER | 0 | ACEmulator/ACE/pulls/156 | Original code only made client aware of change, didn't update the server's player object. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/156/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215599908 | MDExOlB1bGxSZXF1ZXN0MTExNjgzMDUy | 157 | Line ending fixes | Mag-nus 10608427 | closed | 0 | 0 | 2017-03-21T01:03:59Z | 2017-03-21T01:04:04Z | 2017-03-21T01:04:04Z | MEMBER | 0 | ACEmulator/ACE/pulls/157 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/157/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215715644 | MDExOlB1bGxSZXF1ZXN0MTExNzYyODI1 | 158 | updating with documentation and a // TODO | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-03-21T12:06:10Z | 2017-05-30T15:34:34Z | 2017-03-21T12:06:16Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/158 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/158/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
215784686 | MDExOlB1bGxSZXF1ZXN0MTExODEwNTI5 | 159 | Added Path support for Mono applications (Linux) | fantoms 37453 | closed | 0 | 0 | 2017-03-21T15:44:06Z | 2017-06-28T19:47:34Z | 2017-03-22T04:49:19Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/159 | Added Mono Path compatibility (Linux support) to the following objects by removing the prefixed slashes in file paths: - ConfigManager - Charts - Dat Loading Note: This was tested and working correctly on `Ubuntu 16.04`. No bugs were observed when play testing. Installation Hint: The server currently requires _at least_ installing `mono-complete` with the `apt-get` package manager. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215897071 | MDExOlB1bGxSZXF1ZXN0MTExODkzNDI4 | 160 | Monster factory | Lidefeath 26508216 | closed | 0 | Mogwai-TheFurry 25351661 | 2 | 2017-03-21T22:24:40Z | 2017-05-02T12:14:08Z | 2017-03-27T19:06:37Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/160 | This fleshes out MonsterFactory to read the object data for a Drudge Sneaker from the database and spawn it next to the player. Thanks a ton @LytelthorpeThistledown for his work which helped alot to get this done. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/160/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||
215950513 | MDExOlB1bGxSZXF1ZXN0MTExOTMxMDAy | 161 | Animation fix | Zegeger 12808515 | closed | 0 | 0 | 2017-03-22T04:35:26Z | 2017-03-22T04:53:02Z | 2017-03-22T04:53:02Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/161 | Quick fix; had removed sequence initial value, but apparently it was needed. Testing fail. Also moved Logout Enqueue to correct place per comment. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/161/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
215950727 | MDU6SXNzdWUyMTU5NTA3Mjc= | 162 | Inbound fragment combining, sequence reordering, checksum validation | Zegeger 12808515 | closed | 0 | 0 | 2017-03-22T04:37:23Z | 2017-04-03T12:05:20Z | 2017-04-03T12:05:20Z | CONTRIBUTOR | Additional work needed in Network code. Please assign to me. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/162/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
215964624 | MDExOlB1bGxSZXF1ZXN0MTExOTM5ODkx | 163 | Support for specific server host binding | damnubber 4389226 | closed | 0 | 1 | 2017-03-22T06:21:14Z | 2017-03-22T12:42:14Z | 2017-03-22T12:42:14Z | NONE | 0 | ACEmulator/ACE/pulls/163 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/163/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
216098076 | MDExOlB1bGxSZXF1ZXN0MTEyMDMzMTIy | 164 | Dat Path Updates | fantoms 37453 | closed | 0 | 0 | 2017-03-22T15:09:55Z | 2017-05-23T15:50:58Z | 2017-03-22T15:15:35Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/164 | Update to Yesterday's Path support PR. The path support push broke the loading of dats without trailing slashes in the config. Here are the changes in this PR that address this issue: - Updated example DatFileDirectory with a trailing slash at the end of the value - Changed DatLoader to use Path.Combine, trailing slash is no longer needed. `ServerTime initialized to Date: Wintersebb 22, 28 P.Y. Time: Warmtide 2017-03-22 10:04:22,672 INFO : Successfully opened C:\ACE\client_cell_1.dat file, containing 1 records 2017-03-22 10:04:22,781 INFO : Successfully opened C:\ACE\client_portal.dat file, containing 1 records` | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/164/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
216142365 | MDExOlB1bGxSZXF1ZXN0MTEyMDYyOTU2 | 165 | Changes to Host configuration | LtRipley36706 11369233 | closed | 0 | 0 | 2017-03-22T17:10:17Z | 2017-04-21T03:49:09Z | 2017-03-23T12:58:11Z | MEMBER | 0 | ACEmulator/ACE/pulls/165 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/165/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
216250810 | MDU6SXNzdWUyMTYyNTA4MTA= | 166 | Give Characters a set of positions | Mogwai-TheFurry 25351661 | closed | 0 | 1 | 2017-03-23T00:40:45Z | 2017-04-03T12:05:11Z | 2017-04-03T12:05:11Z | CONTRIBUTOR | Make an enum for the following positions types: * Physical Location * Lifestone Used * Lifestone Tied * Portal Recall * Primary Portal Recall * Secondary Portal Recall * Allegiance Hometown (This should only apply to monarchs) * Mansion Recall Notes / Requirements * The character database model will need to change so that players have a set of positions rather than a single position * The character object will have 1 new property for each of the recall locations in the enumeration, where Allegiance Hometown will attempt to find the monarch's Allegiance Hometown. If you can't do this yet, just slap a // TODO and return null. * Each of these positions should save to the database whenever changed. * Hook up the /lifestone and /ls commands to go to the Lifestone position. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/166/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
216282064 | MDExOlB1bGxSZXF1ZXN0MTEyMTU2MTQ2 | 167 | weenies weenies everywhere. object structure pass for review. | Mogwai-TheFurry 25351661 | closed | 0 | 3 | 2017-03-23T03:34:09Z | 2017-05-30T15:34:34Z | 2017-03-25T05:22:52Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/167 | yeah, so this works.... | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/167/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
216649386 | MDExOlB1bGxSZXF1ZXN0MTEyMzg3ODA2 | 168 | Item Management | ogmage78 25460553 | closed | 0 | 0 | 2017-03-24T04:52:10Z | 2017-03-24T14:11:48Z | 2017-03-24T14:11:48Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/168 | Not ready to be pulled. @ctw me - creates a training wand in your backpack @ctw ground spawns a training wand on the ground Drag wand to the ground. It does drop the item and takes it out of the backpack. It does register with the landblock. I had the motion working (bending down to drop the wand and standing back up) but something I changed has got that not working. The wand does not appear in the visible field. - not sure why. I am way out of date on coding - and I am sure I have done stuff incorrectly. Any feedback on how to code this better or topics I should read up on will be greatly appreciated. I feel like this is really really close to working. Also, I know the hard coding of data will go away once we have the Weenie data in the database. I put in a number of comments and TODO's to follow up on. The PCAP is unless I am just blind - almost identical to this one I used as a template. Any help will be appreciated. Here is a link to the live server PCAP https://www.dropbox.com/s/q0l3wi4mhx0n7ce/drop_item.pcap?dl=0 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/168/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
216958720 | MDExOlB1bGxSZXF1ZXN0MTEyNTc4MzY1 | 169 | Updated Marketplace Recall | LtRipley36706 11369233 | closed | 0 | 1 | 2017-03-25T08:05:51Z | 2017-04-21T03:49:06Z | 2017-04-09T21:39:23Z | MEMBER | 0 | ACEmulator/ACE/pulls/169 | @mp command better reflects how it worked in AC1Live. The movement check/cancel is not yet implemented. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/169/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217025656 | MDExOlB1bGxSZXF1ZXN0MTEyNjEzNTg0 | 170 | Fixed bug in F748: Set Position and Motion | ogmage78 25460553 | closed | 0 | 0 | 2017-03-26T04:07:03Z | 2017-04-14T19:37:35Z | 2017-03-27T12:29:07Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/170 | There has been a bug in this code that was keeping me from being able to drop an item. - Fixed alignment problem and cleaned up the ability to report position with the correct flags - I moved and expanded an enum flag list for correct scoping - I put the position flag in the position object and initialized the flags correctly on player create. - Added another signature to Serialize - left the old one for backward compatibility - we may want to look at refactoring this. Please let me know if you anything that looks wrong. I am still learning. This is more of a plumbing fix. You should not notice anything new or anything new broken :) If this get's merged - I want to start looking at creating mutable objects next. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/170/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217028943 | MDExOlB1bGxSZXF1ZXN0MTEyNjE1MjI4 | 171 | Renamed the new db statement constructor label | fantoms 37453 | closed | 0 | 0 | 2017-03-26T05:29:12Z | 2017-05-23T15:54:40Z | 2017-03-26T12:16:24Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/171 | - Renamed a function to cut down on confusion. Fixes an assumed typo in name for new function `ConstructStatement`. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/171/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217055250 | MDExOlB1bGxSZXF1ZXN0MTEyNjI5MTAx | 172 | Implements GameAction/Event for Update Health | Lidefeath 26508216 | closed | 0 | 1 | 2017-03-26T14:21:05Z | 2017-04-20T20:03:58Z | 2017-03-28T20:45:21Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/172 | This is limited for Players currently but should be adjustable once creatures are in. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/172/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217099846 | MDExOlB1bGxSZXF1ZXN0MTEyNjUwMDA4 | 173 | Fixed Model write order and some spelling errors | OptimShi 26606778 | closed | 0 | 0 | 2017-03-26T23:24:48Z | 2017-03-27T01:03:46Z | 2017-03-27T01:03:46Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/173 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/173/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
217107233 | MDExOlB1bGxSZXF1ZXN0MTEyNjUyOTM2 | 174 | Update: Prevent Welcome Message/Motd when string is empty | fantoms 37453 | closed | 0 | 0 | 2017-03-27T00:37:32Z | 2017-03-27T02:36:34Z | 2017-03-27T01:06:25Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/174 | - Thanks to Miach for coding and testing this PR. - If the `Config.json` file includes an EMPTY `Welcome` config variable, then the server will not send the Popup dialog box, upon logging into a server. Example: ``` { "Server": { "WorldName": "Darktiphoid", "Welcome": "", "Network": { "Host": "0.0.0.0" }, }, } ``` | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/174/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217109932 | MDExOlB1bGxSZXF1ZXN0MTEyNjUzNjY1 | 175 | Created IF statement to remove Welcome popup box | MiachofTD 24981658 | closed | 0 | 0 | 2017-03-27T00:53:42Z | 2017-04-28T03:29:56Z | 2017-03-27T01:09:44Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/175 | When using this IF statement you can remove the Welcome to this ACE server!\nFor more information visit http://www.acemulator.org. from inside the quotes in the config.json file and the popup box does not appear. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/175/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217123739 | MDExOlB1bGxSZXF1ZXN0MTEyNjYwOTMy | 176 | Save Character Position to Database | fantoms 37453 | closed | 0 | 0 | 2017-03-27T02:56:31Z | 2017-05-23T15:54:38Z | 2017-03-27T12:34:05Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/176 | - Update Player.cs `SaveCharacter()` function to store the `Player.Position` in the Character data object, right before the object is is stored in the database. This allows the server to save the character's position on logout or after the player save interval has ended. - Added a summary comment for `SaveCharacter`. - Updated Code Style per StyleCop. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217338363 | MDExOlB1bGxSZXF1ZXN0MTEyODExNzU2 | 177 | Update: SQL Where Syntax for ConstructStatement | fantoms 37453 | closed | 0 | 0 | 2017-03-27T18:44:52Z | 2017-05-23T15:54:36Z | 2017-03-27T18:49:55Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/177 | - Updated the `wherelist` text to include the proper SQL syntax, for a WHERE clause. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/177/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217425388 | MDU6SXNzdWUyMTc0MjUzODg= | 178 | Primary keys too restrictive on some weenie tables | LytelthorpeThistledown 25618389 | closed | 0 | 0 | 2017-03-28T01:56:16Z | 2017-04-10T11:35:43Z | 2017-04-10T11:35:43Z | CONTRIBUTOR | Proposed fix: ALTER TABLE weenie_palette_changes DROP PRIMARY KEY, ADD PRIMARY KEY(weenieClassId, subPaletteId, offset, length); ALTER TABLE weenie_texture_map_changes DROP PRIMARY KEY, ADD PRIMARY KEY(weenieClassId, index, oldId); I think the weenie_palette_changes table needs a different primary index. Currently it is weenieClassId + subPaletteId. Here is the palette data for Narg. subPaletteId,offset,length 67116992,192,64 67109565,256,64 67114248,576,160 67114248,1088,192 67114248,320,192 67114248,928,160 67114248,0,192 67114248,768,96 67114248,928,96 67110336,2000,48 subPaletteId 67114248 appears 7 times, twice it has the same offset of 928 The same problem exists for weenie_texture_map_changes. Currently it is weenieClassId + index. Here is the texture data for the Aluvian Mid-Stakes Gamesmaster index,oldId,newId 16,83886232,83890685 16,83886668,83890262 16,83886837,83890287 16,83886684,83890353 9,83887070,83886781 9,83887062,83886686 0,83889072,83889072 0,83889342,83889342 5,83887064,83886241 1,83887064,83886241 3,83889344,83887054 7,83889344,83887054 4,83887068,83887054 8,83887068,83887054 index 16 apears 4 times | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/178/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
217443319 | MDExOlB1bGxSZXF1ZXN0MTEyODg2NjM3 | 179 | Fix remaining 6 StyleCop warnings | ghost 10137 | closed | 0 | 0 | 2017-03-28T04:13:55Z | 2017-10-18T14:07:39Z | 2017-03-28T11:55:01Z | NONE | 0 | ACEmulator/ACE/pulls/179 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/179/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
217470832 | MDU6SXNzdWUyMTc0NzA4MzI= | 180 | Objects need to be re-sent to client if teleported within same landblock | LtRipley36706 11369233 | closed | 0 | 1 | 2017-03-28T07:29:04Z | 2017-07-26T16:50:35Z | 2017-07-26T16:50:35Z | MEMBER | currently the client loses objects if teleported within same landblock | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/180/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
217539297 | MDU6SXNzdWUyMTc1MzkyOTc= | 181 | Parse pcaps for Doors and add them! | Mogwai-TheFurry 25351661 | closed | 0 | 2 | 2017-03-28T12:12:58Z | 2017-05-01T15:12:52Z | 2017-05-01T15:12:52Z | CONTRIBUTOR | * Parse pcaps for doors and emit them as SQL * Add the doors to the ace_world database * Add landblock logic to close/open doors | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/181/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
217729589 | MDExOlB1bGxSZXF1ZXN0MTEzMDk0MTU3 | 182 | Drop Item - REVIEW ONLY Do not merge | ogmage78 25460553 | closed | 0 | 2 | 2017-03-29T00:16:43Z | 2017-03-31T18:49:39Z | 2017-03-29T21:53:35Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/182 | This runs and works. If you want to test drop item do the following: Log in @ctw me (This will create a training wand in your backpack) OR @ctw ground (not very interesting - does the same thing but spawns it on the ground. Once you have the wand in your backpack from calling the first command - drop that bad boy. Down she goes with a thud and your radar lights up. Up until about an hour ago, he would do the correct animation and put the damn wand on the ground. I fell into git hell and between squash and revert - I am too tired to fix it. You can see it on the ground. I did not finish the complementary action to be able to pick it up. The problem is - something I did is messing up the packet stream. It looks like it all works, but I can't open the pcap file it creates. That tells me something is amiss. Hopefully someone can see it. ALSO Note - I started this a few weeks ago and I have learned a lot since then. If any of this is in the wrong namespace or I have made some other noobie mistake - it is not by design it is just a lack of knowledge on my part. Let me know the better way to do it and you won't have to tell me twice. :) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
217957579 | MDExOlB1bGxSZXF1ZXN0MTEzMjU3Mjk1 | 183 | all the database things! | Mogwai-TheFurry 25351661 | closed | 0 | 2 | 2017-03-29T17:56:09Z | 2017-05-30T15:34:32Z | 2017-04-03T11:58:02Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/183 | From PCAPs.. * All weenie objects * All static objects | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/183/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218060844 | MDExOlB1bGxSZXF1ZXN0MTEzMzMyMzc2 | 184 | Feature: ORM Driven Character Positions for Issue #166 | fantoms 37453 | closed | 0 | 1 | 2017-03-30T02:10:18Z | 2017-03-30T15:56:12Z | 2017-03-30T15:56:12Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/184 | This huge PR is related to Issue #166. The code has been changed to allow more then one position type. A class was added for Character position types that match the requirements listed in the issue. A secondary Position Type class was added to match the client, provided by @LtRipley36706. To work with the ORM code introduced during the developer meeting, I've attempted to copy the pseudo 1:1 mapping into `CharacterPosition.cs`. In order to allow for more then one position, the `Character.Position` member was changed to dictionary containing a list of character positions by type. `Player.Position` was changed to `Player.PhysicalPosition` and when the server decides to save the positions to the database, the data is saved through the ORM object in `CharacterPosition.cs`. There were a few things left to do, that were not accomplished for Issue #166: * Hook up /lifestone and /ls commands ChangeLog: * Changed the Player.Position to Player.PhysicalPosition to match the Developer meeting video and Issue #166. * Created `CharacterPostion` and `CharacterPositionType` classes to store the Database types requested in Issue #166. * Added `CharacterPostion` ORM logic. * Built out helper extension functions to serve the `StartingLocation`, until we pull from the database. Also included an Invalid location as a default (0). * Changed the `character_positions` table and Added `positionType` column. * Set the primary key to include `positionType` column. * Added `positionType` to required Critera for `character_positions`. * Added `CharacterPositionInsert` and `CharacterPositionUpdate` to the Character Database. * Created `CharacterPositionInsert` and `CharacterPositionUpdate` prepared SQL statements by utilizing the `ConstructStatement` function. * Added the required `positionType` clause to the `CharacterPositionSelect` prepared statement. * Added a position update statement for updating the player position. * Reworked GetPosition to include the `CharacterPositionType`. * Added function for getting a `C… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218226807 | MDExOlB1bGxSZXF1ZXN0MTEzNDQ5OTk3 | 185 | Network updates for packet/fragment reorder, fragment combining | Zegeger 12808515 | closed | 0 | 0 | 2017-03-30T14:59:45Z | 2017-04-02T01:01:50Z | 2017-04-02T01:01:50Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/185 | Added network session ID to WorldManager to lookup user's sessions and updated related components to handle this. Refactored GameAction handling to no longer used Activator instantiated objects, they are now delegates like the game message handlers. Added packet/fragment reorder queues and handling. Added fragment recombining. A complete fragment is sent upstream as a new ClientMessage object. Updated all locations where ClientPacketFragment was used. TODO checksum verification, improve some logging/comments | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/185/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218255708 | MDExOlB1bGxSZXF1ZXN0MTEzNDcxNzg4 | 186 | Animation - fix and enhancement | ogmage78 25460553 | closed | 0 | 2 | 2017-03-30T16:33:24Z | 2017-03-31T18:49:25Z | 2017-03-31T03:42:17Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/186 | In this PR - I extended on the work Zegeger did. His work was for animations only. The system supports a 0 to N animation sequence. If 0, you are doing a basic motion. Moving forward, sidestep, turnto. They use the same message F74C but are intelligently coded depending on what you want to do. TODO: I have not looked to see if you can have a motion followed by an animation(s) I coded it so it supports it, but I did not have a ready pcap to confirm. Easy enough to fix if they are mutually exclusive. I cleaned up some emums. Still to do is to refactor the autonomous position message - I think we have some overlap and duplication there. To test - use the debug command @amimation <animation> to see that Zegeger's work still functions as expected. Use debug command @movement to see the drop sequence. You can look at the produced pcaps and see the delta and that they match live servers. As usual - any coding faxpas are not by design. Feedback is wanted and welcome. If there is a better way to do what I did - please let me know. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/186/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218334549 | MDExOlB1bGxSZXF1ZXN0MTEzNTI5NzQ0 | 187 | World fix and fireball test | Forbiddenz 25387933 | closed | 0 | 4 | 2017-03-30T21:33:33Z | 2017-04-01T13:00:44Z | 2017-04-01T13:00:44Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/187 | World Object Fixes + My test Spell firewall - sorta.. so I could test it some more. New AceVector Object. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/187/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218609267 | MDExOlB1bGxSZXF1ZXN0MTEzNzI3MDA1 | 188 | Feature: ORM Driven Character Positions for Issue #166 | fantoms 37453 | closed | 0 | 0 | 2017-03-31T20:30:31Z | 2017-04-02T01:46:20Z | 2017-04-02T01:46:20Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/188 | This huge PR is related to Issue #166. The code has been changed to allow more then one position type. A class was added for Character position types that match the requirements listed in the issue. A secondary Position Type class was added to match the client, provided by @LtRipley36706. To work with the ORM code introduced during the developer meeting, I've attempted to copy the pseudo 1:1 mapping into `CharacterPosition.cs`. In order to allow for more then one position, the `Character.Position` member was changed to dictionary containing a list of character positions by type. `Player.Position` was changed to `Player.PhysicalPosition` and when the server decides to save the positions to the database, the data is saved through the ORM object in `CharacterPosition.cs`. There were a few things left to do, that were not accomplished for Issue #166: * Hook up /lifestone and /ls commands Changelog with this PR: ### 2017-03-31 [fantoms] * Added debug command to test positions. * Changed SQL syntax to use BEFORE instead of AFTER for the `positionType` column, in the `character_positions` table. * Removed the github friendly enums from the `PositionTypes`. * Changed a log4net debug line. * Changed the name class name `CharacterPositionType` to `PositionType` * Reworked `Position.cs` with ORM. ### 2017-03-29 [fantoms] * Changed the Player.Position to Player.PhysicalPosition to match the Developer meeting video and Issue #166. * Created `CharacterPostion` and `CharacterPositionType` classes to store the Database types requested in Issue #166. * Added `CharacterPostion` ORM logic. * Built out helper extension functions to serve the `StartingLocation`, until we pull from the database. Also included an Invalid location as a default (0). * Changed the `character_positions` table and Added `positionType` column. * Set the primary key to include `positionType` column. * Added `positionType` to required Critera for `character_positions`. * Added `CharacterPositionInsert` and `CharacterPositionUp… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218616162 | MDExOlB1bGxSZXF1ZXN0MTEzNzMyMDEw | 189 | Inventory Phase 1 and Drop Item | ogmage78 25460553 | closed | 0 | 2 | 2017-03-31T21:01:27Z | 2017-05-01T16:41:56Z | 2017-04-03T03:00:33Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/189 | This is at a good place for code review and possible merge. Once approved, this will allow others to start on the numerous tasks around inventory management. You can spawn a Training wand in your backpack or on the ground. That is just throw away code to test with. It is in the debug handler. usage: @ctw me OR @ctw ground Once the item is spawned, you can then drop it on the ground. Included in this PR. Starts to address Issue #144 World object now has inventory dictionary. Added this here as anything that can be a container needs to have this ability. Not all world objects are containers - so also added property IsContainer Added methods to: - Add to inventory - Remove from inventory - Lookup item in inventory - Handle Drop item: 1. Calls lookup 2. Update Container burden 3. Sets some properties in preparation for going 3D 4. GameMessageUpdatePosition. 5. Alerts Landblock to new arrival 6. Removes the item the player's inventory Added GameActionDropItem This handles the client's request to drop an item. Added GameMessagePutObjectIn3d As usual - any coding faux pas are not by design. Feedback is wanted and welcome. If there is a better way to do what I did - please let me know. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/189/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218690610 | MDExOlB1bGxSZXF1ZXN0MTEzNzc2MTcz | 190 | Spawn creatures from DB | Lidefeath 26508216 | closed | 0 | 3 | 2017-04-01T11:45:45Z | 2017-04-20T20:04:16Z | 2017-04-04T17:49:56Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/190 | Introduces a basic creature generator table layout with a static spawn of a Drudge Sneaker near the Holtburg Lifestone as a Test. The static spawns are loaded via the LandBlockManager from the DB. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/190/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218735283 | MDExOlB1bGxSZXF1ZXN0MTEzODAxNzMy | 191 | Fixed bug / incomplete implementation of instance_time stamp | ogmage78 25460553 | closed | 0 | 2 | 2017-04-02T01:46:53Z | 2017-04-14T19:37:28Z | 2017-04-03T01:17:28Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/191 | Small fix, but an important one. A lot of messages take an instance_sequence or timestamp. it is called timestamp in the client. I fixed the places where this was still being set to 1. If the instance_timestamp does not agree between calls it can cause you to hang in portal space or other bad things. The PhysicsData.Position structure passes 9 (0-8 ) unnamed timestamps. These were in place - two were set to 0 - however, they were out of order. I am not sure of the other 8, but the last one is the instance_timestamp. I verified this with live server pcaps. I have made it so with what we have implemented so far, we are consistent. It will be important that we get this information out to all contributors as we need to set it for all player messages to totalLogins. I also make the character load and save properly update the totalLogins value. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/191/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218736918 | MDExOlB1bGxSZXF1ZXN0MTEzODAyNTk2 | 192 | World fix and fireball test | Forbiddenz 25387933 | closed | 0 | 0 | 2017-04-02T02:31:30Z | 2017-04-02T12:11:56Z | 2017-04-02T12:11:56Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/192 | Spells - Cleaned up | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/192/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218737106 | MDExOlB1bGxSZXF1ZXN0MTEzODAyNjkz | 193 | Fix: Include missing CharacterPositionExtensions.cs | fantoms 37453 | closed | 0 | 0 | 2017-04-02T02:37:13Z | 2017-04-02T02:38:43Z | 2017-04-02T02:38:43Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/193 | My last PR did not include a necessary file, so I am including it now. The file is a helper for functions for positions that kept popping up everywhere. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/193/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218740683 | MDExOlB1bGxSZXF1ZXN0MTEzODA0NjYx | 194 | Fix: Reverted SQL syntax to use AFTER, instead of BEFORE | fantoms 37453 | closed | 0 | 1 | 2017-04-02T04:16:20Z | 2017-05-23T15:53:18Z | 2017-04-02T16:31:10Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/194 | - Changed `2017_03_27_character_positions_change.sql` and `2017_03_26_character_positions_positiontype.sql` to use AFTER instead of BEFORE, when aligning the column. The `positionType` column has been moved after the `id` column. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/194/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218760696 | MDExOlB1bGxSZXF1ZXN0MTEzODE1ODky | 195 | World fix and fireball test | Forbiddenz 25387933 | closed | 0 | 0 | 2017-04-02T12:13:13Z | 2017-05-01T16:42:14Z | 2017-04-03T17:21:16Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/195 | Clean up - Synced with Latest Prs | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/195/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
218914985 | MDU6SXNzdWUyMTg5MTQ5ODU= | 196 | Action queue for Player<->Landblock Interaction | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-04-03T12:16:42Z | 2017-04-10T11:35:57Z | 2017-04-10T11:35:57Z | CONTRIBUTOR | Use Cases: * Picking up an item off the ground * Casting a spell * Getting health of a monster * Using a Door * Using a Lifestone * Opening chests Other necessary changes: * Remove the exposure of WorldObjects from Landblock and LandblockManager Design thoughts: * The session/player object would have a List<Something> of queued actions. * As Actions arrive.... If they don't require Landblock interaction, just handle them and be done with it. If they do require Landblock / Object interaction, add them to the session/player queue. * In the main Landblock server control loop, process the top X actions from each player's queue. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/196/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | ||||||
218915428 | MDU6SXNzdWUyMTg5MTU0Mjg= | 197 | Continuous Integration, Code Analysis, and Unit Tests | Mogwai-TheFurry 25351661 | closed | 0 | Mogwai-TheFurry 25351661 | 0 | 2017-04-03T12:18:30Z | 2017-04-10T11:35:31Z | 2017-04-10T11:35:31Z | CONTRIBUTOR | We'll need an ACE admin to enable it for ACE, but somebody can get it working in their personal fork first. I found this project as a tool for running StyleCop from within Travis. https://github.com/Nylle/StyleCop.Console Unit tests will require switching to NUnit as well. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/197/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | ACE 79078680 | issue | |||||
219018504 | MDExOlB1bGxSZXF1ZXN0MTEzOTkxMDUz | 198 | Add portals to ACE_World tables | ghost 10137 | closed | 0 | 1 | 2017-04-03T18:18:18Z | 2017-04-04T04:33:55Z | 2017-04-04T04:33:43Z | NONE | 0 | ACEmulator/ACE/pulls/198 | * Add a fix to the current master ACE_World tables for weenie and ace objects to loosen the index restrictions * Add Portal weenie table data * Add Portal object table data --- Duplicate portal objects removed; Floating City, Orphanage, Golem Sanctum, and Humming Crystal portals removed as they are not static object placements | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/198/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | |||||
219058062 | MDExOlB1bGxSZXF1ZXN0MTE0MDIwMTI3 | 199 | generic cleanup | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-04-03T20:51:38Z | 2017-05-30T15:34:30Z | 2017-04-03T20:53:19Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/199 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/199/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull | ||||||
219115279 | MDExOlB1bGxSZXF1ZXN0MTE0MDU0NzQ5 | 200 | AppVeyor Implementation | Mogwai-TheFurry 25351661 | closed | 0 | 0 | 2017-04-04T01:24:41Z | 2017-05-30T15:34:38Z | 2017-04-04T21:48:11Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/200 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | ACE 79078680 | pull |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issues] ( [id] INTEGER PRIMARY KEY, [node_id] TEXT, [number] INTEGER, [title] TEXT, [user] INTEGER REFERENCES [users]([id]), [state] TEXT, [locked] INTEGER, [assignee] INTEGER REFERENCES [users]([id]), [milestone] INTEGER REFERENCES [milestones]([id]), [comments] INTEGER, [created_at] TEXT, [updated_at] TEXT, [closed_at] TEXT, [author_association] TEXT, [active_lock_reason] TEXT, [draft] INTEGER, [pull_request] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [state_reason] TEXT, [repo] INTEGER REFERENCES [repos]([id]), [type] TEXT ); CREATE INDEX [idx_issues_repo] ON [issues] ([repo]); CREATE INDEX [idx_issues_milestone] ON [issues] ([milestone]); CREATE INDEX [idx_issues_assignee] ON [issues] ([assignee]); CREATE INDEX [idx_issues_user] ON [issues] ([user]);