issues: 212333121
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
212333121 | MDExOlB1bGxSZXF1ZXN0MTA5NDA4MzQz | 113 | Max Rank Fireworks and Correct Skill Rank Up text Color | 37453 | closed | 0 | 0 | 2017-03-07T05:17:04Z | 2017-05-23T15:53:42Z | 2017-03-07T13:45:27Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/113 | - I could not find a way to check the skill rank after it was set, so I added a function to check max rank. If the function returns a Boolean true, then the server will play fireworks when reached max rank - Changed the message type to Advancement when increasing skills too reflect the correct skill advancement chat color. - Added a few summary comments and fixed remarks/known issues. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |