pull_requests: 231051721
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
231051721 | MDExOlB1bGxSZXF1ZXN0MjMxMDUxNzIx | 1094 | closed | 0 | Action queue remove dequeue | 10608427 | This is a small change, yet a big change. It removes a big feature of the ActionQueue system, the ability to dequeue pending acitons. This was added during the time when we had the idea of using micro transactions in ACE via these ActionQueues. We have since diverged from micro transactions, and thus, the ability to Dequeue is no longer needed. We also have no use case for the ability to dequeue a pending action before it's acted on in the future. By removing this requirement, we can switch the ActionQueue backing from a LinkedList to a ConcurrentQueue. This change reduces the CPU ActionQueues require by half. This adds up when you consider that every WorldObject is an Actor with their own action queues, and those action queues are ticked every UpdateGameWorld tick. | 2018-11-15T02:54:12Z | 2018-11-20T13:47:08Z | 2018-11-20T13:44:41Z | 2018-11-20T13:44:41Z | 72a1d30861329bc73acdd5b0c972a31cca6e8887 | 0 | 5b3503520a33c3329693898c0a2e136db68a895e | 390961ca7048e231f3d9e345d4fc59514b8c01d8 | MEMBER | 79078680 | https://github.com/ACEmulator/ACE/pull/1094 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests