pull_requests: 214156464
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
214156464 | MDExOlB1bGxSZXF1ZXN0MjE0MTU2NDY0 | 1006 | closed | 0 | Revised pass at secure trade | 25518589 | This is an update to my previous PR where basic secure trade functionality was implemented. This PR does the following: - Verifies that trade partner is in range - Honors ignore all trade requests character option - Does not initiate when either party is in combat mode - Adds a few messages based on what I saw in retail PCAPs - Implemented GameEventDeclineTrade per PCAPs - Implements turn to when approaching trade partner Probably a few other minor tweaks. Again, sorry for all of the open and closing PR noise. Git and I are often not friends. | 2018-09-09T17:51:18Z | 2018-09-11T16:06:41Z | 2018-09-10T20:36:53Z | 2018-09-10T20:36:52Z | 7df8b6ecebf65dd35dbf6b1a9524cba0feb274c7 | 0 | ff36da6754ac3b644d88474a1f376bb2da3797c4 | f1360a1e147f809de628d601369610e4f915d03d | CONTRIBUTOR | 79078680 | https://github.com/ACEmulator/ACE/pull/1006 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests