pull_requests: 168955101
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
168955101 | MDExOlB1bGxSZXF1ZXN0MTY4OTU1MTAx | 639 | closed | 0 | Implement CellLandblock geometry cache. | 8909245 | This pull request is for the 2 Trello tasks: https://trello.com/c/4ErxP7lc/90-implement-celllandblock-geometry-cache https://trello.com/c/TxnqEnBH/85-celllandblockgetz-needs-rework I'm still learning my way around the ACE project, so it's possible this code is not integrated in the correct location yet... A LoadMesh() method has been added to Landblock.cs, which uses the Region file to determine the correct heights for the vertices. It loads the landblock grid as a triangle mesh, using a snippet of code from AC2D to ensure the cells are split between the correct vertices. I have verified in a few different locations that these splitters are being generated correctly, but I have no automated way of ensuring 100% accuracy across the entire map yet. The GetZ() method has been implemented in Landblock.cs, which returns the correct Z-height information for any X/Y position on the map. There are no unit tests yet, but here is a video of the landblock grid mesh visualization: https://youtu.be/5yTTcMY-1Pw The video quality was unfortunately degraded when uploaded to Youtube, but in the right corner is a 'current landblock height' stat that is updated every time the camera moves. This shows the information returned by GetZ(). Since this mesh data is to eventually be consumed by other classes, it can be tailored to provide whatever public API would be most useful to these other classes. For now it just has some of the basics, but more can be added as needed. | 2018-02-13T21:02:50Z | 2018-02-14T04:56:18Z | 2018-02-14T04:56:18Z | 2018-02-14T04:56:18Z | 44129d99945af074626ccb11db63113fdb00e9b9 | 0 | b70663953b9a98a6a39d9792babb1b1fe9d70e3e | 96a62b7ede4438f582d7ed27ac83c1279d02a1a9 | COLLABORATOR | 79078680 | https://github.com/ACEmulator/ACE/pull/639 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests