issue_comments: 504680195
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/2028#issuecomment-504680195 | https://api.github.com/repos/ACEmulator/ACE/issues/2028 | 504680195 | MDEyOklzc3VlQ29tbWVudDUwNDY4MDE5NQ== | 10137 | 2019-06-22T16:35:57Z | 2019-06-22T16:35:57Z | NONE | Never mind. CalculateManaUsage() is still totaling the sum of the mana for an equivalent multiple spell casting, when a player is targeted for an impen/bane type item spell cast. "numTargetItems = targetPlayer.EquippedObjects.Values.Count(i => (i is Clothing || i.IsShield) && i.IsEnchantable);" is the line from Creature.CalculateManaUsage(). You are correct in that the Clothing check is missing. However, it should be able to be shortened from i.WeenieType == WeenieType.Clothing to 'i is Clothing'. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 459484118 |