issue_comments: 494550040
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/issues/1922#issuecomment-494550040 | https://api.github.com/repos/ACEmulator/ACE/issues/1922 | 494550040 | MDEyOklzc3VlQ29tbWVudDQ5NDU1MDA0MA== | 8909245 | 2019-05-21T20:41:07Z | 2019-05-21T20:52:11Z | COLLABORATOR | I agree in theory that the 'source' of the spell would be the item that cast it During initial dev/testing of ItemProc, this switched between item.TryCastSpell and wielder.TryCastSpell a few times. If I remember correctly, there were 1 or 2 bugs with item.TryCastSpell that need to be fixed One that I remember is the message that is broadcast to the target. It would say things like 'Sword cast spell on you' or 'Aetheria cast spell on you', which seemed very unclear (not sure how it was in retail). If the proc successfully landed, the wielder also would not receive any messages about it, without additional logic added I forget if that was the only thing that needed investigated, but I'm thinking there might also have been something with EnchantmentManager sources Anyway yeah this needs further investigated, just saying it's not as simple as changing wielder.TryCastSpell to TryCastSpell here, and to be aware of the other possible bugs that would need to be looked into for that | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 446766312 |