issue_comments: 494213315
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/issues/1806#issuecomment-494213315 | https://api.github.com/repos/ACEmulator/ACE/issues/1806 | 494213315 | MDEyOklzc3VlQ29tbWVudDQ5NDIxMzMxNQ== | 10137 | 2019-05-21T02:14:30Z | 2019-05-21T02:25:47Z | NONE | For Wrath of the Puppeteer spell, "|| spellID == 2998" needs to be added to the Volley else if branch in SpellProjectile.GetProjectileSpellType(), as it is a bolt/volley hybrid spell. Three projectiles are fired but in succession, rather than as a group together, so that effect needs to be accounted for in code. SpellIDs 1832 through 1838, which Avalanche is a part of, are spell projectile rain spells that are unique to other War Magic projectile spells, with nine or 12 projectiles that slam down from above the target in an area, and should only be usable outdoors. Those spell lines are a little wonky, as their spell.Power exceeds their item casters ItemSpellcrafts, so that probably needs to be accounted for, also. Paralyzing Fear spell on Virindi Implant also exceeds the ItemSpellcraft of the caster item. I imagine that ItemSpellcraft should probably only be used for resist checks and not for if an item has the "skill" to cast its spell. Setting magicSkill = 999, at line 334 in Player_Magic.cs, ensures that a caster item can successfully cast its own spells. Lastly, the two WarMagic() overloads are probably sending an extra GameEventUseDone(), in the case of "spell not implemented, yet", as the cursor goes into perma-hourglass. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 437208346 |