issue_comments: 485838415
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/1785#issuecomment-485838415 | https://api.github.com/repos/ACEmulator/ACE/issues/1785 | 485838415 | MDEyOklzc3VlQ29tbWVudDQ4NTgzODQxNQ== | 10608427 | 2019-04-23T14:54:34Z | 2019-04-23T14:54:34Z | MEMBER | I'm starting to go over your checklist, thank you for providing that. The first thing I notice is the combination of Session and NetworkSession. I was aware that you had done this, which is why I suggested the wrapper, but I was curious as to why. The reason for combining class does not apply here. Session and NetworkSession should be kept functionally separate. NetworkSession is designed to handle low level packet work. This includes: - Packet processing - Packet transmission Session is designed to handle higher level session management. This includes: - Dispatching received packets (through to NetworkSession) - Processing packet transmit requests (through to NetworkSession) - Managing server/client/world states - Managing the session:player relationship | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 435988213 |