issue_comments: 456261291
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/1204#issuecomment-456261291 | https://api.github.com/repos/ACEmulator/ACE/issues/1204 | 456261291 | MDEyOklzc3VlQ29tbWVudDQ1NjI2MTI5MQ== | 70647 | 2019-01-22T03:41:55Z | 2019-01-22T03:41:55Z | NONE | Couple of concerns... Generally speaking API's are meant to be utilized by machines not users. Therefor Basic Authentication isn't usually the best form of Auth for them. Not to mention Basic Auth provides no Authorization components. So if you plan on adding multiple administrative components directly to the server I would recommend also adding a proper RBAC and some sort of API token. The following concerns me 6. Target server downloads packaged snapshot from source server. 7. Source server permanently deletes character upon package download completion. 8. Target server performs cryptographic verification of the snapshot, and rejects it if it's been forged. 9. Target server adds the character to the requester's account. If there is any issue in steps 7 and 8 the user is out of luck. The origin server deleted the origin char and the destination server failed to extract the snapshot of the user's migration. I feel like before anything is deleted both sites are checked for consistency. Once verified drop origin, and toggle/enabled destination. It also seems like there are numerous requests made to both servers for the migration. It seems like there shouldn't need to be. If trust is established between the two servers, the client should only have to make one a single request origin or destination it doesn't matter. The servers can then communicate across their own common api and handle the workflow themselfs. It would also be helpful prior to merging in to the master branch to have this PR squashed to one commit. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 394923138 |