issue_comments: 1553000238
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/4003#issuecomment-1553000238 | https://api.github.com/repos/ACEmulator/ACE/issues/4003 | 1553000238 | IC_kwDOBLalGM5ckOcu | 10608427 | 2023-05-18T12:47:23Z | 2023-05-18T12:48:20Z | MEMBER | I haven't spent enough time to give a proper review, but it just feels wrong going from what is the de facto standard for .NET to a 3rd party lib to fix an issue. What I also found interesting is what we have in there now: ``` <Target Name="ChangeAliasesOfStrongNameAssemblies" BeforeTargets="FindReferenceAssembliesForReferences;ResolveReferences"> <ItemGroup> <ReferencePath Condition="'%(FileName)' == 'MySqlConnector'"> <Aliases>MySqlConnectorAlias</Aliases> </ReferencePath> </ItemGroup> </Target> ``` That also is worth a review. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1708670657 |