pull_requests
Data license: AGPL · Data source: ACEmulator Project
24 rows where "updated_at" is on date 2017-05-23
This data as json, CSV (advanced)
Suggested facets: user, created_at (date), updated_at (date), closed_at (date), merged_at (date)
id ▼ | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
109408343 | MDExOlB1bGxSZXF1ZXN0MTA5NDA4MzQz | 113 | closed | 0 | Max Rank Fireworks and Correct Skill Rank Up text Color | fantoms 37453 | - I could not find a way to check the skill rank after it was set, so I added a function to check max rank. If the function returns a Boolean true, then the server will play fireworks when reached max rank - Changed the message type to Advancement when increasing skills too reflect the correct skill advancement chat color. - Added a few summary comments and fixed remarks/known issues. | 2017-03-07T05:17:04Z | 2017-05-23T15:53:42Z | 2017-03-07T13:45:27Z | 2017-03-07T13:45:27Z | 555c39fb937d85f8317a21730a693ea8e57115a8 | 0 | 99077ee9b008312f8e7ff33ccb05f1fe5346d98d | 4113108b99df8b49ed819b78bcfbcff469bf810d | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/113 | ||||
110264067 | MDExOlB1bGxSZXF1ZXN0MTEwMjY0MDY3 | 119 | closed | 0 | Level up on xp change, PropertyInt Message Types and skill credits | fantoms 37453 | - Changed the Character.Level variable from an int to a uint. - Added leveling up on grantxp. Since we don't get XP anywhere else, this is the only way so far. - Added skill credits. You cannot spend them to add skills yet. AvailableSkillCredits. - Changed the /grantxp command to allow up too 999,999,999,999 xp. - Followed @Zegeger and created a Network Message Type for PropertyInt - Allow for Max Level locking, set from the XP chart. - Added effects on leveling up. | 2017-03-11T16:08:42Z | 2017-05-23T15:53:44Z | 2017-03-18T13:59:42Z | 909d35a12d2133bc90e7337fb12219cbf607c4c8 | LtRipley36706 11369233 | 0 | 86f527705a1810387ef8a78f2f2ac95c20869b0e | 2e24a5831a6cd587535bf24a15624d3e5df0f08e | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/119 | ||||
110344221 | MDExOlB1bGxSZXF1ZXN0MTEwMzQ0MjIx | 125 | closed | 0 | Save Player Properties to db | fantoms 37453 | -Saves every 60 "ticks". Please advise on the best stats saving interval. -Implemented database update functions for character properties. -Added a character save ticker. Please advise on the proper location for this, I did this quickly. | 2017-03-13T06:02:12Z | 2017-05-23T15:53:47Z | 2017-03-18T14:00:13Z | 1780ababf28b229a79b6701ce83c95a8fd06b659 | LtRipley36706 11369233 | 0 | 3806e1567851a6d3528df948c4b9319be1827da9 | faeeb6e919c8f418cd74f89a415d3280309aca0a | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/125 | ||||
111084605 | MDExOlB1bGxSZXF1ZXN0MTExMDg0NjA1 | 134 | closed | 0 | Added attribute upper bounds check and max attribute fireworks and special text | fantoms 37453 | -Added upper bounds checks for the Ranks so that Attributes will not crash the server. -Added fireworks and special text on max rank, too match skills. | 2017-03-16T14:46:16Z | 2017-05-23T15:53:45Z | 2017-03-18T14:00:37Z | 16741de7e597871b76fc3e1edf4df6a3244a9bac | LtRipley36706 11369233 | 0 | 1620a54d4dee4e6e74ead9cbc7d5bba34612b5f4 | cb0ab3997f9f1712a3c63efbb42c0c965652c81f | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/134 | ||||
111493853 | MDExOlB1bGxSZXF1ZXN0MTExNDkzODUz | 153 | closed | 0 | Feature: Spend Skill Credits | fantoms 37453 | Within this request I've sent code that will allow the client to attempt too spend skill credits. If enough skill credits are available, the server will grant the skill to the the character. If the skill credits are not available or the skill has already been trained, then the server makes sure to send the correct game messages with Skill.None, to keep the client from locking up. On the bottom of the Skill.cs, I've added an extension that allows for skills with proper names, example: `Sneak Attack` instead of `SneakAttack`. | 2017-03-20T06:11:56Z | 2017-05-23T15:53:56Z | 2017-03-20T12:08:34Z | 2017-03-20T12:08:34Z | c6bce625fc5d3576fe098fcb8b94ed0b091c5c92 | 0 | 85b3399f84610f68b6c7455c6a88fe761fbe922e | 55c6bb877d6cf9e4389580fffa485a228e486fcb | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/153 | ||||
112033122 | MDExOlB1bGxSZXF1ZXN0MTEyMDMzMTIy | 164 | closed | 0 | Dat Path Updates | fantoms 37453 | Update to Yesterday's Path support PR. The path support push broke the loading of dats without trailing slashes in the config. Here are the changes in this PR that address this issue: - Updated example DatFileDirectory with a trailing slash at the end of the value - Changed DatLoader to use Path.Combine, trailing slash is no longer needed. `ServerTime initialized to Date: Wintersebb 22, 28 P.Y. Time: Warmtide 2017-03-22 10:04:22,672 INFO : Successfully opened C:\ACE\client_cell_1.dat file, containing 1 records 2017-03-22 10:04:22,781 INFO : Successfully opened C:\ACE\client_portal.dat file, containing 1 records` | 2017-03-22T15:09:55Z | 2017-05-23T15:50:58Z | 2017-03-22T15:15:35Z | 2017-03-22T15:15:35Z | c066c1b0260ca427adef1d81bf310b00fc6944cd | 0 | a07a4182dc11acf3ee78a4db90f2fabc67bd6b39 | 92f4725b07bec9b5bb01fecbeaa6c0e9375c8461 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/164 | ||||
112615228 | MDExOlB1bGxSZXF1ZXN0MTEyNjE1MjI4 | 171 | closed | 0 | Renamed the new db statement constructor label | fantoms 37453 | - Renamed a function to cut down on confusion. Fixes an assumed typo in name for new function `ConstructStatement`. | 2017-03-26T05:29:12Z | 2017-05-23T15:54:40Z | 2017-03-26T12:16:24Z | 2017-03-26T12:16:24Z | d2942e2f47225744d53f96f22fa0d31550643995 | 0 | 3388c3de790e808a408ae0798493a08506dec7c1 | 49b42d1c073d772bcacd8c980c86e559c5e1d8a5 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/171 | ||||
112660932 | MDExOlB1bGxSZXF1ZXN0MTEyNjYwOTMy | 176 | closed | 0 | Save Character Position to Database | fantoms 37453 | - Update Player.cs `SaveCharacter()` function to store the `Player.Position` in the Character data object, right before the object is is stored in the database. This allows the server to save the character's position on logout or after the player save interval has ended. - Added a summary comment for `SaveCharacter`. - Updated Code Style per StyleCop. | 2017-03-27T02:56:31Z | 2017-05-23T15:54:38Z | 2017-03-27T12:34:05Z | 2017-03-27T12:34:05Z | b7850cf40d31a065de3afbe9664ea2ba47a14d4a | 0 | eb698f70c156742f5e385a1e82ad7eb050186bc4 | 5308d63adbc7fc9f74e9f67c60e1426562d6c7ad | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/176 | ||||
112811756 | MDExOlB1bGxSZXF1ZXN0MTEyODExNzU2 | 177 | closed | 0 | Update: SQL Where Syntax for ConstructStatement | fantoms 37453 | - Updated the `wherelist` text to include the proper SQL syntax, for a WHERE clause. | 2017-03-27T18:44:52Z | 2017-05-23T15:54:36Z | 2017-03-27T18:49:55Z | 2017-03-27T18:49:55Z | c2263d0af0857dc3cd9b9d767adc75b3e502c08b | 0 | 66832fdbdd59653171cac4c3bcac48b57669504b | b7850cf40d31a065de3afbe9664ea2ba47a14d4a | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/177 | ||||
113804661 | MDExOlB1bGxSZXF1ZXN0MTEzODA0NjYx | 194 | closed | 0 | Fix: Reverted SQL syntax to use AFTER, instead of BEFORE | fantoms 37453 | - Changed `2017_03_27_character_positions_change.sql` and `2017_03_26_character_positions_positiontype.sql` to use AFTER instead of BEFORE, when aligning the column. The `positionType` column has been moved after the `id` column. | 2017-04-02T04:16:20Z | 2017-05-23T15:53:18Z | 2017-04-02T16:31:10Z | 2017-04-02T16:31:10Z | fccfaa57c9f696a0da394bad77ee64492d4b5c9a | 0 | 1660911c80f39f12e061662d0d2cf594d1e9225d | 868f082200d7858037eef5cf2c64b6ef68c376c7 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/194 | ||||
114518939 | MDExOlB1bGxSZXF1ZXN0MTE0NTE4OTM5 | 213 | closed | 0 | Added lifestone attunment, @ls recall, and position fixes. | fantoms 37453 | Also worked out the log4net problems for debugging databases | 2017-04-06T04:14:54Z | 2017-05-23T15:54:21Z | 2017-04-06T13:43:07Z | 2017-04-06T13:43:07Z | 9f5aebcda63bdf1593c2d96912b6bf059a8d3180 | 0 | 1530d36122d3ead96d7dc4b8fd87f000667d38ab | 9e7acbfee832f5d0df7b527f8836d86a364b77be | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/213 | ||||
114746360 | MDExOlB1bGxSZXF1ZXN0MTE0NzQ2MzYw | 217 | closed | 0 | Reveresed the logic for the distance check on lifestone usage | fantoms 37453 | - After performing some empirical visual client testing with: ` float squaredDistance = player.Location.SquaredDistanceTo(obj.Location); player.Session.Network.EnqueueSend(new GameMessageSystemChat(squaredDistance.ToString(), ChatMessageType.Broadcast)); `, I found that a static use distance of at least `4.9f` worked _well_. I did not change this float, but I am noting it here. - I also changed the `Lifestone Use` text to blue. | 2017-04-07T05:32:33Z | 2017-05-23T15:53:05Z | 2017-04-07T18:45:50Z | 2017-04-07T18:45:50Z | 4e83cc56f38eb638960a344739cb8fa1d0d802ad | 0 | 79fe4ae2075e252f6d81619b3a4509c9573186b1 | 4d47d2e4dddb6dbac88d989ed9388880644e2c1a | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/217 | ||||
114995758 | MDExOlB1bGxSZXF1ZXN0MTE0OTk1NzU4 | 221 | closed | 0 | Feature: Added sound and visual effect broadcasting landblocks | fantoms 37453 | - Utilizes player `ActionQueue`, to play sounds. | 2017-04-09T18:14:14Z | 2017-05-23T15:52:49Z | 2017-04-10T11:17:19Z | 2017-04-10T11:17:18Z | d3e3c4f75320074148917251b250bac093dff6d7 | 0 | b1948f64dfb0aadd6fe8a8653d94e8ab711f00ff | c2f1105bef8824fb289121afd5a3552b5e297997 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/221 | ||||
116066000 | MDExOlB1bGxSZXF1ZXN0MTE2MDY2MDAw | 243 | closed | 0 | Fix: Position missing update and LandblockId db object fix | fantoms 37453 | This code was created to address issue #242. -Fixed bugs in `LandblockId` in position and server now resets the position if missing. -Added checks to prevent a missing location from crashing the server. -Removed unnecessary `lastportal` recall position save, this is set on demand, this also prevents invalid data from entering the database. Please give this a test by deleting a previously created character's position location (position type 1) and then try logging in, you should be at the current starting dungeon. | 2017-04-16T18:03:36Z | 2017-05-23T15:55:24Z | 2017-04-18T01:28:50Z | 2017-04-18T01:28:50Z | 7198ccbe725afeb2df3fe83143d611fa13db73eb | 0 | 1c8fd6487d24541cdf5e219ebaa479cbdda2a41c | 29a2721c628d3f14be2b506e2309575cf95288ce | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/243 | ||||
116971193 | MDExOlB1bGxSZXF1ZXN0MTE2OTcxMTkz | 269 | closed | 0 | Removed @reset-pos again | fantoms 37453 | The `@reset-pos` command was removed in pr #243, but was re-added back in with Ripley's command text update commit 679b0814. If this is needed, please close this request; but I would like to remove this command too prevent invalid positions from being set as the `Location` position in the database. | 2017-04-21T12:07:09Z | 2017-05-23T15:55:21Z | 2017-04-21T12:55:18Z | 2017-04-21T12:55:18Z | deefa02dd75187cf5e3af2dac6e678b914dd4f5c | 0 | e43add4d0dd82b18b7175bba2251f776b9fb3938 | 8969af90c78d8ec39a3bdaeaa430b2c07558e611 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/269 | ||||
117017377 | MDExOlB1bGxSZXF1ZXN0MTE3MDE3Mzc3 | 270 | closed | 0 | Fix IsDerivedPlayer logic to allow smite to work | fantoms 37453 | This was always true, due to a changes I made last night to the Creature Kill command. The changes made the Creatures also work like a player, but after I made this change, the types can now differentiate; allowing `@smite` and `@smite all` began to work correctly again. | 2017-04-21T16:02:26Z | 2017-05-23T15:55:19Z | 2017-04-23T17:32:14Z | 2017-04-23T17:32:14Z | 6da39d844bf182dd4439a0460d370ec8ed77d015 | 0 | 844da73e81aa451938135e94fef2431512acb167 | c141dd56429e911ed207ba68f3f15e9638b63057 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/270 | ||||
117176946 | MDExOlB1bGxSZXF1ZXN0MTE3MTc2OTQ2 | 280 | closed | 0 | Update: Vitals | fantoms 37453 | * Working on Vitals, Changed `Current` to `UnbuffedValue` for the `ICreatureStats` interface within `Character.cs` * Added a health update message for abilities, so endurance can properly change the health/steam, when increased. * `@heal` should now work again. | 2017-04-24T01:54:42Z | 2017-05-23T15:51:15Z | 2017-04-24T05:11:23Z | 2017-04-24T05:11:23Z | 1fa08e27c860caddaaa986d8991a107c173f0280 | 0 | 3c530c137f85a09274ba69171070678a4d728d21 | 2bf7398b8d8ff0982538536d81fd8d5f24b05c1c | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/280 | ||||
117806526 | MDExOlB1bGxSZXF1ZXN0MTE3ODA2NTI2 | 297 | closed | 0 | Feature: Admin `@boot` command | fantoms 37453 | This request should allow a player or account holder, too be kicked from the server. There is an assumption that when the player is sent boot packet, the server will then receive a disconnect message from the client, where finally the server can process the session's finally "log off". | 2017-04-26T20:49:05Z | 2017-05-23T15:52:06Z | 2017-05-01T12:00:56Z | 2017-05-01T12:00:56Z | d6c078286947bafbc65ec69cd679312240820985 | 0 | 181ce934e814914f6ff2c09fb435aa4737510385 | 535536102a634411b87a22df851dcc2a9f0a30d5 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/297 | ||||
117857988 | MDExOlB1bGxSZXF1ZXN0MTE3ODU3OTg4 | 299 | closed | 0 | Feature: Admin `@teleto` command | fantoms 37453 | 2017-04-27T04:39:59Z | 2017-05-23T15:51:18Z | 2017-04-27T19:22:59Z | 2017-04-27T19:22:59Z | b8c421f8ac8b54c88155ed88534a0f43b1dbf589 | 0 | 98418ecd26265c2f71a5cc32bec8eff0078ad524 | 573bd5d212be7a44ba67bccc2de6fd2a5a57c06d | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/299 | |||||
118645303 | MDExOlB1bGxSZXF1ZXN0MTE4NjQ1MzAz | 317 | closed | 0 | Feature: `@home` admin command | fantoms 37453 | * Built out the functionality for the `@home` admin command. * Fixed a bug in the `@teletype` command; the actual teleport function was missing/removed. | 2017-05-02T20:58:59Z | 2017-05-23T15:52:26Z | 2017-05-03T23:32:16Z | 2017-05-03T23:32:16Z | b1fafb77c2a2ebba01f32757243d53fc71154163 | 0 | 9234f5be473e76809e6dc37ef31fb53612b7f74a | cba96e15cfefdea8d5b69138365093ddc96c8657 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/317 | ||||
118682720 | MDExOlB1bGxSZXF1ZXN0MTE4NjgyNzIw | 319 | closed | 0 | Fix: Mana on XP Spend | fantoms 37453 | * Fixed character's total `Mana` points after spending experience points on `Self`. * Noticed that the `@heal` command may prevent vitals increasing. | 2017-05-03T02:38:13Z | 2017-05-23T15:52:41Z | 2017-05-04T17:03:41Z | 2017-05-04T17:03:41Z | 7109c9076baf6645e28892730a23ef626ae8a84d | 0 | 2eca77da94529ac4a4e500d408e5980eff1b998d | afdce36b2c71ab92895f5744260ad55d37148570 | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/319 | ||||
121545432 | MDExOlB1bGxSZXF1ZXN0MTIxNTQ1NDMy | 345 | closed | 0 | Added Configuration for Maximum Allowed Sessions | fantoms 37453 | * Changed the configuration sections to allow for the "MaxSessions" setting. * There is a default value of 128. * Check the Config.json.example for help. | 2017-05-19T17:17:20Z | 2017-05-23T15:52:30Z | 2017-05-20T00:47:15Z | 2017-05-20T00:47:15Z | bc15215b299c311e4be8ef07b70e24e967fc5a0c | 0 | 7dea228302ccf88553251679bb057bd52ce825ee | 2332cda0bb2142a95418b88f2131f1f506eb016a | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/345 | ||||
121564109 | MDExOlB1bGxSZXF1ZXN0MTIxNTY0MTA5 | 346 | closed | 0 | Added debug command @listplayers | fantoms 37453 | * Added a Helpful debug command for testing who is connected too your server. | 2017-05-19T19:09:06Z | 2017-05-23T15:52:32Z | 2017-05-20T00:48:18Z | 2017-05-20T00:48:18Z | 30e3a8691c0fb800133f81218b0e5eae4f9b09eb | 0 | 7ab1f832f4f9415ab2f00b920dd3e2a1bf5bd1aa | bc15215b299c311e4be8ef07b70e24e967fc5a0c | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/346 | ||||
121671615 | MDExOlB1bGxSZXF1ZXN0MTIxNjcxNjE1 | 349 | closed | 0 | Object overhaul - part two. Review and Comment | ogmage78 25460553 | I am having to refactor and touch a LOT of stuff. It is looking good to me - but I am concerned about how much I am modifying without review. Below is where I am at. ### 2017-05-21 * Continued work on Overhaul * re-enabled more constructed statements * Most of the work to use existence of data to set flags for both physics and weenieHeaderFlags - some cleanup remains - either logic issues or bad data * modified cirand to take an optional second parameter to spawn X items at a time. This speeds up testing. I set a default to 10 if you omit the second parameter. * base_ace_object and ace_object both seem to be loading. * updated or created several views. * have not tested with Ripley's new data export - I did not want to add a second variable to testing. * Next steps - use Ripley's data, create needed views, re-enable door, portal, NPC --- all the world things. | 2017-05-21T18:54:26Z | 2017-05-23T23:15:41Z | 2017-05-23T23:15:41Z | ae661fe8fe958e7d0e2aa7d99c16a78a3d92dd94 | 0 | 8af63306a63805424be6abba92f3de7a63752a8d | 502bdb907cea73b247cd5cd552378df72439847e | CONTRIBUTOR | ACE 79078680 | https://github.com/ACEmulator/ACE/pull/349 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [pull_requests] ( [id] INTEGER PRIMARY KEY, [node_id] TEXT, [number] INTEGER, [state] TEXT, [locked] INTEGER, [title] TEXT, [user] INTEGER REFERENCES [users]([id]), [body] TEXT, [created_at] TEXT, [updated_at] TEXT, [closed_at] TEXT, [merged_at] TEXT, [merge_commit_sha] TEXT, [assignee] INTEGER REFERENCES [users]([id]), [milestone] INTEGER REFERENCES [milestones]([id]), [draft] INTEGER, [head] TEXT, [base] TEXT, [author_association] TEXT, [auto_merge] TEXT, [repo] INTEGER REFERENCES [repos]([id]), [url] TEXT, [merged_by] INTEGER REFERENCES [users]([id]) ); CREATE INDEX [idx_pull_requests_merged_by] ON [pull_requests] ([merged_by]); CREATE INDEX [idx_pull_requests_repo] ON [pull_requests] ([repo]); CREATE INDEX [idx_pull_requests_milestone] ON [pull_requests] ([milestone]); CREATE INDEX [idx_pull_requests_assignee] ON [pull_requests] ([assignee]); CREATE INDEX [idx_pull_requests_user] ON [pull_requests] ([user]);