issue_comments
Data license: AGPL · Data source: ACEmulator Project
3 rows where issue = 561809561
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
583643989 | https://github.com/ACEmulator/ACE/pull/2697#issuecomment-583643989 | https://api.github.com/repos/ACEmulator/ACE/issues/2697 | MDEyOklzc3VlQ29tbWVudDU4MzY0Mzk4OQ== | Mag-nus 10608427 | 2020-02-07T22:28:31Z | 2020-02-07T22:28:31Z | MEMBER | The changes in ExecuteEmote are a step backwards. Prior, it was utilizing a linq query which was very efficient. The only issue was it would enumerate over more records when not using a keyed dictionary. Use linq to build the query, and the return emoteSet.FirstOrDefault() will perform the work and return only what's needed (a single element, or null), without creating any additional lists. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change EmoteManager to use dictionary lookup for Emotes 561809561 | |
583644271 | https://github.com/ACEmulator/ACE/pull/2697#issuecomment-583644271 | https://api.github.com/repos/ACEmulator/ACE/issues/2697 | MDEyOklzc3VlQ29tbWVudDU4MzY0NDI3MQ== | Mag-nus 10608427 | 2020-02-07T22:29:25Z | 2020-02-07T22:29:25Z | MEMBER | Also, I still stand by my statements that this will provide no measurable performance improvement. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change EmoteManager to use dictionary lookup for Emotes 561809561 | |
588267874 | https://github.com/ACEmulator/ACE/pull/2697#issuecomment-588267874 | https://api.github.com/repos/ACEmulator/ACE/issues/2697 | MDEyOklzc3VlQ29tbWVudDU4ODI2Nzg3NA== | Mag-nus 10608427 | 2020-02-19T14:42:26Z | 2020-02-19T14:42:26Z | MEMBER | I'm testing this against current master (that has the fixed orderby), and am not seeing a noticeable difference with the following setup: Landblocks: 1,415 active (3 dungeons), 635 dormant (1 dungeons), Landblock Groups: 14 - Players: 154, Creatures: 17,053, Missiles: 10, Other: 24,439, Total: 41,656 I still plan to do more controlled testing. Will report those results when I have them. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Change EmoteManager to use dictionary lookup for Emotes 561809561 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);