issue_comments
Data license: AGPL · Data source: ACEmulator Project
3 rows where issue = 523173039
This data as json, CSV (advanced)
Suggested facets: user, author_association, created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
554219328 | https://github.com/ACEmulator/ACE/pull/2419#issuecomment-554219328 | https://api.github.com/repos/ACEmulator/ACE/issues/2419 | MDEyOklzc3VlQ29tbWVudDU1NDIxOTMyOA== | LtRipley36706 11369233 | 2019-11-15T05:33:13Z | 2019-11-15T05:33:13Z | MEMBER | can this made to be -1? Why does a limit on storage need to exist? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | adding Storage.Default_ChestResetInterval override 523173039 | |
554223477 | https://github.com/ACEmulator/ACE/pull/2419#issuecomment-554223477 | https://api.github.com/repos/ACEmulator/ACE/issues/2419 | MDEyOklzc3VlQ29tbWVudDU1NDIyMzQ3Nw== | gmriggs 8909245 | 2019-11-15T05:53:02Z | 2019-11-15T05:58:04Z | COLLABORATOR | whatever is appropriate, just wanted to get the option in to set Storage separately ResetInterval is a PropertyFloat, and there is special logic to interpret ResetInterval <= 5 as ChestRegenOnClose, so infinite would be double.MaxValue or double.PositiveInfinity i guess actionChain.AddDelaySeconds(ChestResetInterval); actually setting extreme ChestResetInterval there would probably not be good, so maybe some kind of special value to indicate no automatic reset maybe it could interpret double.MaxValue or double.PositiveInfinity as not enqueuing any automatic reset chain | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | adding Storage.Default_ChestResetInterval override 523173039 | |
554396148 | https://github.com/ACEmulator/ACE/pull/2419#issuecomment-554396148 | https://api.github.com/repos/ACEmulator/ACE/issues/2419 | MDEyOklzc3VlQ29tbWVudDU1NDM5NjE0OA== | gmriggs 8909245 | 2019-11-15T15:10:29Z | 2019-11-15T15:10:57Z | COLLABORATOR | ok this has been updated for Storage to default to ResetInterval=double.PositiveInfinity, and special logic to skip queueing the action chain when ResetInterval is this value another way to do this might simply be for the check to be && !(this is Storage), however if someone does wish to modify their server for Storage chests to have ResetIntervals (such as 5 mins. or 10 mins.) then this code gives them the option to easily change the default value | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | adding Storage.Default_ChestResetInterval override 523173039 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);