issue_comments
Data license: AGPL · Data source: ACEmulator Project
2 rows where issue = 420424621
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
472519413 | https://github.com/ACEmulator/ACE/issues/1528#issuecomment-472519413 | https://api.github.com/repos/ACEmulator/ACE/issues/1528 | MDEyOklzc3VlQ29tbWVudDQ3MjUxOTQxMw== | gmriggs 8909245 | 2019-03-13T17:14:33Z | 2019-03-13T17:14:33Z | COLLABORATOR | Just tested this, I think the issue might be that one of the many checks when pledging allegiance fails without returning an error message In particular, retail had a check where the vassal must be within 4 distance of the patron. The server currently sends this error to the client: // check distance <= 4.0 if (Location.DistanceTo(target.Location) > 4.0f) { Session.Network.EnqueueSend(new GameEventWeenieError(Session, WeenieError.AllegianceMaxDistanceExceeded)); return false; } However, the client doesn't seem to display this 'allegiance max distance exceeded' message I can add some more visible error message for these cases | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | You can not swear to monarch after breaking from patron in same allegiance 420424621 | |
472541753 | https://github.com/ACEmulator/ACE/issues/1528#issuecomment-472541753 | https://api.github.com/repos/ACEmulator/ACE/issues/1528 | MDEyOklzc3VlQ29tbWVudDQ3MjU0MTc1Mw== | gmriggs 8909245 | 2019-03-13T18:09:30Z | 2019-03-13T18:09:30Z | COLLABORATOR | https://github.com/ACEmulator/ACE/pull/1530 is now in the queue The client should now display more descriptive error messages if something happens while swearing allegiance In addition, one of the more common and questionable cases that you experienced (guessing it was the distance > 4 check) should have the character now automatically walk over to the patron within range | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | You can not swear to monarch after breaking from patron in same allegiance 420424621 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);