issue_comments: 472519413
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/issues/1528#issuecomment-472519413 | https://api.github.com/repos/ACEmulator/ACE/issues/1528 | 472519413 | MDEyOklzc3VlQ29tbWVudDQ3MjUxOTQxMw== | 8909245 | 2019-03-13T17:14:33Z | 2019-03-13T17:14:33Z | COLLABORATOR | Just tested this, I think the issue might be that one of the many checks when pledging allegiance fails without returning an error message In particular, retail had a check where the vassal must be within 4 distance of the patron. The server currently sends this error to the client: // check distance <= 4.0 if (Location.DistanceTo(target.Location) > 4.0f) { Session.Network.EnqueueSend(new GameEventWeenieError(Session, WeenieError.AllegianceMaxDistanceExceeded)); return false; } However, the client doesn't seem to display this 'allegiance max distance exceeded' message I can add some more visible error message for these cases | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 420424621 |