github
Data license: AGPL · Data source: ACEmulator Project
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
725157249 | MDExOlB1bGxSZXF1ZXN0NTA2NDMzMTc2 | 3316 | Fix typo in @rename success message | 563 | closed | 0 | 0 | 2020-10-20T03:25:38Z | 2020-10-20T03:29:07Z | 2020-10-20T03:29:07Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/3316 | s/succesfully/successfully/g HT @Cyberkiller | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3316/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
800971195 | MDExOlB1bGxSZXF1ZXN0NTY3MzY3ODM0 | 3446 | Add support for servers to periodically communicate with external services | 563 | open | 0 | 4 | 2021-02-04T06:18:53Z | 2021-02-09T00:23:06Z | CONTRIBUTOR | 1 | ACEmulator/ACE/pulls/3446 | Hey all, I was talking about something I've built with @LtRipley36706 the other day and he thought other devs would be interested in seeing a PR so here it is: It would be really interesting if ACE servers could communicate with external services. There's been a ton of discussion about _how_ to do this, going back to https://github.com/ACEmulator/ACE/issues/718. Providing an HTTP API is a really powerful idea but presents a ton of problems such as rate limiting, running read-only replicas of the database, and so on. A lighter weight and simpler approach is to have ACE servers _send_ any information to external services periodically. The biggest downside here is that the feature only works if the external service stays available. What I've done here is created a new `*Manager` class called `HeartbeatManager` that based on code that already existed in ACE that sends a JSON payload to a configurable HTTP endpoint at a configurable interval. Think [webhook](https://en.wikipedia.org/wiki/Webhook). The immediate thing ACE servers could do with this is broadcast whether the server is up and how many players are online to services such as https://treestats.net. People are very interested in how many players are on each server but the TreeStats way of tracking [server populations](https://treestats.net/player_counts/) requires players on each server to run my Decal plugin. And even then, the temporal resolution of the population data depends on how many players are running the plugin. With my system here, ACE servers could send their `OnlineCount` to TreeStats at intervals and we'd all have much better data to look at. Some notes: 1. This PR isn't done, I'm having some issues figuring out default values in the config 2. The payload is hardcoded to send `WorldName` and `OnlineCount` but I think we could find some easy way to let users configure the Manager to send more info such as any config properties (xp rate, pk/npk, etc) or even information obtained from database queries such as total characters. 3… | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3446/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
211999671 | MDExOlB1bGxSZXF1ZXN0MTA5MTc0Mzc1 | 107 | Add DAT loading into main process | 10137 | closed | 0 | 3 | 2017-03-06T00:43:14Z | 2017-10-18T14:07:36Z | 2017-03-07T01:30:51Z | NONE | 0 | ACEmulator/ACE/pulls/107 | Obtains the two DAT file locations from the config.json file. Code also handles file not found exceptions and prints out an error. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
215229710 | MDExOlB1bGxSZXF1ZXN0MTExNDMwMzg4 | 145 | Change the AdminObjectFactory to LifestoneObjectFactory, add PortalOb… | 10137 | closed | 0 | 0 | 2017-03-18T23:42:13Z | 2017-10-18T14:07:38Z | 2017-03-20T01:44:37Z | NONE | 0 | ACEmulator/ACE/pulls/145 | …jectFactory, add LifestoneType and PortalType Enums, remove unneeded GameMessageCreateLifestone, and remove the leftover DebugAssert command in ObjectGuid | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
217443319 | MDExOlB1bGxSZXF1ZXN0MTEyODg2NjM3 | 179 | Fix remaining 6 StyleCop warnings | 10137 | closed | 0 | 0 | 2017-03-28T04:13:55Z | 2017-10-18T14:07:39Z | 2017-03-28T11:55:01Z | NONE | 0 | ACEmulator/ACE/pulls/179 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/179/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
219018504 | MDExOlB1bGxSZXF1ZXN0MTEzOTkxMDUz | 198 | Add portals to ACE_World tables | 10137 | closed | 0 | 1 | 2017-04-03T18:18:18Z | 2017-04-04T04:33:55Z | 2017-04-04T04:33:43Z | NONE | 0 | ACEmulator/ACE/pulls/198 | * Add a fix to the current master ACE_World tables for weenie and ace objects to loosen the index restrictions * Add Portal weenie table data * Add Portal object table data --- Duplicate portal objects removed; Floating City, Orphanage, Golem Sanctum, and Humming Crystal portals removed as they are not static object placements | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/198/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
219138560 | MDExOlB1bGxSZXF1ZXN0MTE0MDY5MjAw | 201 | Add portal objects to the ACE_World tables | 10137 | closed | 0 | 0 | 2017-04-04T04:41:21Z | 2017-10-18T14:07:42Z | 2017-04-04T11:28:07Z | NONE | 0 | ACEmulator/ACE/pulls/201 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/201/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
222469087 | MDExOlB1bGxSZXF1ZXN0MTE2MzY1Mzk5 | 249 | Usable portals | 10137 | closed | 0 | 0 | 2017-04-18T16:13:24Z | 2017-10-18T14:07:43Z | 2017-04-18T17:11:24Z | NONE | 0 | ACEmulator/ACE/pulls/249 | Includes the Drudge Hideout portal pair in the new portal destination DB table | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
223543981 | MDExOlB1bGxSZXF1ZXN0MTE3MDk3OTU2 | 272 | Fix the four Q variables to DB field mappings; Add 88 more working po… | 10137 | closed | 0 | 0 | 2017-04-22T06:22:17Z | 2017-10-18T14:07:45Z | 2017-04-23T01:21:22Z | NONE | 0 | ACEmulator/ACE/pulls/272 | …rtals | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/272/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
223672535 | MDExOlB1bGxSZXF1ZXN0MTE3MTY4NzYx | 279 | More portal work | 10137 | closed | 0 | 0 | 2017-04-23T22:33:32Z | 2017-04-24T04:09:50Z | 2017-04-24T04:09:27Z | NONE | 0 | ACEmulator/ACE/pulls/279 | Hope it isn't too much if-then'ing. I did use some switch statements, where it looked appropriate. Much of this UseItem for the portals, if not all, should eventually be moved into Portal.cs, within the OnCollide method. However, it may take passing more than just the player object into the OnCollide method to make it work, as I have constructed the statement block for making portals work. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/279/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
223702260 | MDExOlB1bGxSZXF1ZXN0MTE3MTg3Njcx | 283 | More portal work | 10137 | closed | 0 | 0 | 2017-04-24T04:37:59Z | 2017-04-24T05:26:01Z | 2017-04-24T05:25:22Z | NONE | 0 | ACEmulator/ACE/pulls/283 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/283/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
223708268 | MDExOlB1bGxSZXF1ZXN0MTE3MTkxNTY5 | 284 | Add portals, portal routing, and updates to 2 previous portals | 10137 | closed | 0 | 0 | 2017-04-24T05:36:34Z | 2017-04-24T13:46:19Z | 2017-04-24T13:45:56Z | NONE | 0 | ACEmulator/ACE/pulls/284 | As noted in the changelog, PHPMYADMIN does not like the ON DUPLICATE KEY UPDATE statements in the sql file; however, I personnally had success using SQLyog. From my reading MySQL ( MariaDB ) should be able to accept the commands, as they are valid MySQL statements, from its command line. I would guess that HeidiSQL supports them, also. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/284/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
223994300 | MDExOlB1bGxSZXF1ZXN0MTE3Mzg4NTQ3 | 289 | Move Portal and Lifestone logic into appropriate class; modify 3 port… | 10137 | closed | 0 | 0 | 2017-04-25T01:29:02Z | 2017-10-18T14:07:46Z | 2017-04-25T12:04:21Z | NONE | 0 | ACEmulator/ACE/pulls/289 | …als; add 7 new portals | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/289/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
225268144 | MDExOlB1bGxSZXF1ZXN0MTE4MjgwNTg1 | 306 | Portal class changes | 10137 | closed | 0 | 2 | 2017-04-29T16:26:53Z | 2017-05-02T14:04:12Z | 2017-05-02T14:03:52Z | NONE | 0 | ACEmulator/ACE/pulls/306 | * I did not combine base_ace_object, ace_object, ace_portal_object into one view at this juncture, as doing so would remove all portals that didn't have destinations set from the world, as the view would only show entries for portal objects that have data from all three tables present. * In the portal object table restructuring, I added a foreign key constraint to the weenieClassId field that points to that field in the ace_object table. This addition has the effect of not allowing the ace_portal_object table to be populated until the rest of the ace_world tables are filled. I also included a portal object that was missing from the ACE-World DB release that was preventing the ace_portal_object table data from being imported. * An apparent bug with the login position was revealed, when I added saving the PositionType.LastPortal position, when a portal was used. When a player logs in, the PositionType.LastPortal position gets used, rather than the one saved during the character save action. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/306/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
225891091 | MDExOlB1bGxSZXF1ZXN0MTE4Njk1NjEy | 320 | Portal class changes - Ready for review and possible merge | 10137 | closed | 0 | 1 | 2017-05-03T06:04:11Z | 2017-10-18T14:07:47Z | 2017-05-03T22:12:31Z | NONE | 0 | ACEmulator/ACE/pulls/320 | I need someone else(s) to look this code/SQL view over. It results in a crash in Database.cs because of NULL fields, as a result of the left outer join. System.DBNull cannot be converted to System.UInt32 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/320/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
226165263 | MDExOlB1bGxSZXF1ZXN0MTE4ODkxNTQy | 323 | Fix bug in Ace.Entity\Ace_portal_object.cs | 10137 | closed | 0 | 0 | 2017-05-04T02:45:58Z | 2017-10-18T14:07:49Z | 2017-05-04T05:59:16Z | NONE | 0 | ACEmulator/ACE/pulls/323 | Having these variables changed to private was preventing the Position object from being created correctly. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/323/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
226731648 | MDExOlB1bGxSZXF1ZXN0MTE5Mjg0MTE5 | 331 | Add new Portal constructor | 10137 | closed | 0 | 5 | 2017-05-06T02:37:56Z | 2017-10-18T14:07:50Z | 2017-05-07T19:37:52Z | NONE | 0 | ACEmulator/ACE/pulls/331 | * Add new Portal consructor that accepts a weenieClassId and Position object * Add PortalWeenie enum for Floating City, Golem Sanctum, Humming Crystal, and The Orphanage portals, for use with the new Portal constructor * Modified the /createportal debug command to use the new Portal constructor and the Humming Crystal weenie as a PoC TODO: add a TTL to the portal, so it gets removed after a length of time | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/331/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
238299521 | MDExOlB1bGxSZXF1ZXN0MTI3MzIwNDI1 | 412 | Handle non-static spawning portals | 10137 | closed | 0 | 0 | 2017-06-24T06:33:27Z | 2017-10-18T14:07:33Z | 2017-06-26T12:05:50Z | NONE | 0 | ACEmulator/ACE/pulls/412 | * Remove unneeded debug command CreateLifestone * Modified PortalObjectFactory class to create specialized portals that are temporary spawns, such as the Humming Crystal Portal * Created enums for the weenieclassID's for the special portals * Added the missing ObjectType to the CollidableObject class | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
238566912 | MDExOlB1bGxSZXF1ZXN0MTI3NDg3NzE0 | 416 | Add protection to SpawnPortal | 10137 | closed | 0 | 0 | 2017-06-26T14:45:58Z | 2017-10-18T14:07:31Z | 2017-06-26T15:09:28Z | NONE | 0 | ACEmulator/ACE/pulls/416 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/416/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
238711206 | MDExOlB1bGxSZXF1ZXN0MTI3NTk0MTk3 | 418 | Fix race in SpawnPortal when using ActionQueue and assign unique Id's to each Portal object | 10137 | closed | 0 | 0 | 2017-06-27T01:12:26Z | 2017-10-18T14:07:30Z | 2017-06-27T01:15:22Z | NONE | 0 | ACEmulator/ACE/pulls/418 | Someone other than me should check this PR in practice to see if it really is working, and that it isn't just a fluke that it works for me, before it is merged. Should be able to summon multiple portals and they all should individually disappear in 15 seconds. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/418/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
238876547 | MDExOlB1bGxSZXF1ZXN0MTI3NzEzMTUx | 422 | For Review and possible merge: Fix portal requirements | 10137 | closed | 0 | 0 | 2017-06-27T14:45:33Z | 2017-06-27T15:25:55Z | 2017-06-27T14:47:55Z | NONE | 0 | ACEmulator/ACE/pulls/422 | The code works during my functional test, but I don't know if it was the correct way to fix it. Also, there seems to be a slight delay when using a another portal, after having failed a different portal's activation requirements. Example, with a character that is lower than 80, try to use the Eastwatch portal in the TN Annex. Player gets denied because of being too low a level. Next use the Danby's Output portal next to the Eastwatch one. There is a slight delay before teleport. Subsequent portals that don't block do not have a delay, until the next time the player doesn't pass the requirements of another portal. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/422/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
238895606 | MDExOlB1bGxSZXF1ZXN0MTI3NzI3NTUy | 423 | Review and possible merge: Fix portal requirements | 10137 | closed | 0 | 1 | 2017-06-27T15:42:32Z | 2017-10-18T14:07:29Z | 2017-06-28T18:34:40Z | NONE | 0 | ACEmulator/ACE/pulls/423 | The code works during my functional test, but I don't know if it was the correct way to fix it. Also, there seems to be a slight delay when using a another portal, after having failed a different portal's activation requirements. Example, with a character that is lower than 80, try to use the Eastwatch portal in the TN Annex. Player gets denied because of being too low a level. Next use the Danby's Output portal next to the Eastwatch one. There is a slight delay before teleport. Subsequent portals that don't block do not have a delay, until the next time the player doesn't pass the requirements of another portal. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/423/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
239508182 | MDExOlB1bGxSZXF1ZXN0MTI4MTczMTAz | 433 | Auto closing Doors | 10137 | closed | 0 | 0 | 2017-06-29T14:57:04Z | 2017-10-18T14:07:27Z | 2017-06-29T15:13:57Z | NONE | 0 | ACEmulator/ACE/pulls/433 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
241291387 | MDU6SXNzdWUyNDEyOTEzODc= | 453 | Sending an unknown protocol to ACE causes a crash | 10137 | closed | 0 | 0 | 2017-07-07T15:02:10Z | 2018-02-10T04:55:31Z | 2018-02-10T04:55:31Z | NONE | ### Bug Report or Feature Request (mark with an `x`) ``` - [x] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. Send an unknown protocol to ACE, such as a SIP message ### The log given by the failure. ![clipboard01](https://user-images.githubusercontent.com/22699181/27963595-6b568442-62ea-11e7-8eaf-3d2322d9667e.jpg) ### Desired functionality. ACE should disregard protocol messages that don't pertain to it. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | ||||||
262979060 | MDExOlB1bGxSZXF1ZXN0MTQ0ODExNTk3 | 522 | Portals update | 10137 | closed | 0 | 0 | 2017-10-05T01:26:13Z | 2017-10-18T14:07:24Z | 2017-10-05T14:42:20Z | NONE | 0 | ACEmulator/ACE/pulls/522 | Moved handling of Portals into the HandleOnCollide method and implemented MoveTo for OnUse for Portals. Currently, OnUse also queues up portaling via a direct call to Portal.HandleOnCollide, which can be removed when collision is implemented. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
263621289 | MDExOlB1bGxSZXF1ZXN0MTQ1Mjc5OTI2 | 528 | Keys are key | 10137 | closed | 0 | 0 | 2017-10-07T06:41:32Z | 2017-10-18T14:07:56Z | 2017-10-12T13:15:25Z | NONE | 0 | ACEmulator/ACE/pulls/528 | An easy location to test is in the Training Academy Central Courtyard. The first door encountered is locked. Use @ci 30999, to spawn the Academy Library key. - Keys will decrement their usages. Examining the key shows the decreasing number of usages; usage icon overlay works. Key will be removed from both the Shard DB and the player's inventory on last usage. - KeyCode and LockCode are used in the code, but no data is loaded into the DB, yet, resulting in all keys working with all locked door, ie. each key is a AC master key. TODO: - Not sure if there should be a sound played when the door re-locks, and if so, what it would be. - The notification message for attempting to use a key on an open door needs to be corrected. Enum defined in StatusMessageType1.cs is not correct. - A notification message appropriate for using a key on an unlocked door that is closed does not appear to exist/defined in StatusMessageType1.cs. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/528/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
265852856 | MDExOlB1bGxSZXF1ZXN0MTQ2ODQ0NDI3 | 537 | Feed my people -- Ready for review and merge | 10137 | closed | 0 | 0 | 2017-10-16T17:36:55Z | 2018-03-11T14:34:54Z | 2017-10-17T11:35:44Z | NONE | 0 | ACEmulator/ACE/pulls/537 | * Implemented Food class for consuming food items * Stub created for handling Buffing food but implementation is not complete, as spellcasting has not been completed, yet * Implemented a method for removing an item from inventory that also handles item stacks. * Included a fix for stack splitting to create proper WorldObject, instead of defaulting everything to GenericObjects | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/537/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
266365347 | MDExOlB1bGxSZXF1ZXN0MTQ3MjEzMDU4 | 541 | Imbibing in the Starter Towns -- For review and merge | 10137 | closed | 0 | 0 | 2017-10-18T05:39:03Z | 2018-03-11T14:34:56Z | 2017-10-18T12:56:41Z | NONE | 0 | ACEmulator/ACE/pulls/541 | * Reconfigured and renamed functions to account for Potions being included in class Food * Wired up applying the chosen starting town to the Training Academy path used * Squashed some white space StyleCop warnings | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/541/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
267033815 | MDExOlB1bGxSZXF1ZXN0MTQ3Njk4NzY5 | 542 | Fix to Value and Burden | 10137 | closed | 0 | 0 | 2017-10-20T01:03:11Z | 2018-03-11T14:35:01Z | 2017-10-21T18:33:25Z | NONE | 0 | ACEmulator/ACE/pulls/542 | * Created WO.StackUnitValue and WO.StackUnitBurden to be initialized by Weenie.{Value,EncumbranceVal}, with builtin null to zero initialization * Moved WorldObject value and encumbrance calculations down to the WorldObject class, based upon WO.StackUnitValue and WO.StackUnitBurden vs WO.StackSize | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/542/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
267426458 | MDExOlB1bGxSZXF1ZXN0MTQ3OTcwMjE5 | 544 | Fix coin value and pickup of stack-able items from landblock | 10137 | closed | 0 | 2 | 2017-10-22T01:10:04Z | 2018-03-11T14:35:02Z | 2017-10-23T13:10:49Z | NONE | 0 | ACEmulator/ACE/pulls/544 | * Add the initial set of CoinValue in Container.cs to the value of contained Coins * Modified item move, drop, and pickup methods to account for Pyreal changes, using StackOverflow's UpdateCurrencyClientCalculations(); | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/544/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
267910444 | MDExOlB1bGxSZXF1ZXN0MTQ4MzA2NTQw | 547 | Fix TypeO in AuthApi.Host/Program.cs | 10137 | closed | 0 | 0 | 2017-10-24T06:19:59Z | 2018-03-11T14:35:04Z | 2017-10-24T11:40:14Z | NONE | 0 | ACEmulator/ACE/pulls/547 | * Fix a typeo in ACE.AuthApi.Host, as it was attempting to start the API host in place of the AuthAPI host; should be "var server = WebApp.Start<Startup>(url: ConfigManager.Config.AuthServer.Url);", not "var server = WebApp.Start<ACE.Api.Startup>(url: ConfigManager.Config.AuthServer.Url);" Credit to Slushnas | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/547/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
268271982 | MDExOlB1bGxSZXF1ZXN0MTQ4NTc0MzE4 | 553 | Service Installer - Phase one - Implement for game server | 10137 | closed | 0 | 1 | 2017-10-25T05:37:04Z | 2018-03-11T14:35:17Z | 2017-10-25T19:21:11Z | NONE | 0 | ACEmulator/ACE/pulls/553 | * Implemented phase one of enabling ACE to support running as a Windows service * Once this PR is accepted and merged, will work on converting the API Host and Auth API Host processes * TODO: convert console processes to some other means, as the console is not accessible when running as a service | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/553/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
308273826 | MDExOlB1bGxSZXF1ZXN0MTc3MjQzOTU2 | 697 | Enable MinMax Portal level enforcement | 10137 | closed | 0 | 0 | 2018-03-24T15:52:54Z | 2018-03-24T22:32:53Z | 2018-03-24T18:36:27Z | NONE | 0 | ACEmulator/ACE/pulls/697 | Changes the variables used for Portal level enforcement to those that are set in the database and retrieves and sets their values on Portal creation. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/697/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
308815461 | MDExOlB1bGxSZXF1ZXN0MTc3NjI2OTI2 | 704 | Lets make some magic :: WIP | 10137 | closed | 0 | 0 | 2018-03-27T04:08:52Z | 2018-03-27T19:16:30Z | 2018-03-27T19:16:08Z | NONE | 0 | ACEmulator/ACE/pulls/704 | Implements the two magic casting messages from the client to server and a basic default response - Still not ready yet. I will be closing this PR is favor of something a little bit different, ie. move the HandleAction methods into a partial Player class. WorldObject_Magic will have a set of CreateSpell methods that should work for both creature and player. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/704/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
309100984 | MDExOlB1bGxSZXF1ZXN0MTc3ODQwMzM1 | 706 | Lets Make Some Magic | 10137 | closed | 0 | 0 | 2018-03-27T19:23:52Z | 2018-03-28T00:32:06Z | 2018-03-27T23:27:05Z | NONE | 0 | ACEmulator/ACE/pulls/706 | Implements the two magic casting GameAction messages from the client to server, with handlers in the Player class, and a spell casting method in the WorldObject class,, with two basic initial results. All functions dealing the with player, such as movement, would stay within the Player class handler. Any functions dealing with creating spells and their effects should stay within the CreateSpell method. CreateSpell should remain generic enough that is can server for both Creature AI casting and player casting. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/706/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
309402390 | MDExOlB1bGxSZXF1ZXN0MTc4MDY1NTQ1 | 707 | Lets Make Some Magic Part 2 | 10137 | closed | 0 | 0 | 2018-03-28T14:52:37Z | 2018-03-31T15:52:35Z | 2018-03-28T20:15:58Z | NONE | 0 | ACEmulator/ACE/pulls/707 | This code submission is primarily to prevent a server crash, when an inventory item is selected as the target. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/707/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
309665495 | MDExOlB1bGxSZXF1ZXN0MTc4MjYwNjM0 | 708 | Spellcasting Visuals | 10137 | closed | 0 | 0 | 2018-03-29T08:34:13Z | 2018-03-31T15:51:52Z | 2018-03-29T22:54:30Z | NONE | 0 | ACEmulator/ACE/pulls/708 | Creature, Life, and Item magic are included; no target verification implemented, yet | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/708/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
310098264 | MDExOlB1bGxSZXF1ZXN0MTc4NTg0MDU4 | 710 | Casting reorg and busy state | 10137 | closed | 0 | 0 | 2018-03-30T15:45:02Z | 2018-03-31T15:51:56Z | 2018-03-30T18:49:50Z | NONE | 0 | ACEmulator/ACE/pulls/710 | Reorganize spell casting code and implement a busy casting state. Divided casting methods into separate Player and Creature casting methods. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/710/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
310294878 | MDExOlB1bGxSZXF1ZXN0MTc4NzEzNDMy | 715 | Magic Level 3 | 10137 | closed | 0 | 0 | 2018-04-01T05:01:27Z | 2018-04-07T04:13:31Z | 2018-04-01T18:55:50Z | NONE | 0 | ACEmulator/ACE/pulls/715 | Turning to target, range checking, switched busyCasting state bool to a more generic busyState status, and spell damage for two Life Magic spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/715/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
312035447 | MDExOlB1bGxSZXF1ZXN0MTc5OTkzMTYz | 723 | Move busy state flag from Creature to WO | 10137 | closed | 0 | 0 | 2018-04-06T16:16:17Z | 2018-04-07T04:13:33Z | 2018-04-07T02:02:48Z | NONE | 0 | ACEmulator/ACE/pulls/723 | Switch Busy state flag from Creature level to WO level that was created in a recent pull request. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/723/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
312349755 | MDExOlB1bGxSZXF1ZXN0MTgwMTg1MDIw | 725 | Implemented StatMod World DB usage | 10137 | closed | 0 | 0 | 2018-04-08T22:48:07Z | 2018-04-09T03:44:13Z | 2018-04-08T23:02:33Z | NONE | 0 | ACEmulator/ACE/pulls/725 | All of the Boost type Life spells and the Transfer spells damage portion implemented using the data from the StatMod World DB entries; applying the Transfer spell's drain amount to caster and vital transfer spells still to be implemented. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/725/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
312686324 | MDExOlB1bGxSZXF1ZXN0MTgwNDI2NTU4 | 729 | Transfer spells working | 10137 | closed | 0 | 0 | 2018-04-09T21:02:10Z | 2018-04-13T07:23:34Z | 2018-04-10T05:25:40Z | NONE | 0 | ACEmulator/ACE/pulls/729 | Next on the TODO list are the Life Bolt spells. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/729/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
313440045 | MDExOlB1bGxSZXF1ZXN0MTgwOTkxNjMw | 733 | Granting XP for killing with Magic | 10137 | closed | 0 | 0 | 2018-04-11T18:35:59Z | 2018-04-13T07:24:23Z | 2018-04-11T19:21:09Z | NONE | 0 | ACEmulator/ACE/pulls/733 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/733/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
313999052 | MDExOlB1bGxSZXF1ZXN0MTgxNDA4MTg2 | 734 | Magic :: Lesson 7 | 10137 | closed | 0 | 0 | 2018-04-13T07:36:58Z | 2018-04-13T13:53:43Z | 2018-04-13T12:46:08Z | NONE | 0 | ACEmulator/ACE/pulls/734 | Beginnings of casting projectile spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/734/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
314294979 | MDExOlB1bGxSZXF1ZXN0MTgxNjI3OTY4 | 737 | Magic :: Lesson 8 | 10137 | closed | 0 | 0 | 2018-04-14T03:23:59Z | 2018-04-14T15:36:15Z | 2018-04-14T11:10:47Z | NONE | 0 | ACEmulator/ACE/pulls/737 | Life and War projectiles now apply damage and XP | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/737/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
314342233 | MDExOlB1bGxSZXF1ZXN0MTgxNjU1NTc4 | 738 | Magic :: Lesson 8.5 | 10137 | closed | 0 | 0 | 2018-04-14T16:30:15Z | 2018-04-14T20:43:13Z | 2018-04-14T17:19:09Z | NONE | 0 | ACEmulator/ACE/pulls/738 | - Rename Resistance enum to ResistanceType to match other enums - Rename Creature.GetResistance() to Creature.GetNaturalResistance() to differentiate between natural resistances with Armor resistance ratings - Add Natural resistance scaling to War shell damage | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/738/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
314373283 | MDExOlB1bGxSZXF1ZXN0MTgxNjczNjI5 | 739 | Magic :: Lesson 8.7 | 10137 | closed | 0 | 0 | 2018-04-15T00:19:43Z | 2018-04-15T02:12:43Z | 2018-04-15T00:40:10Z | NONE | 0 | ACEmulator/ACE/pulls/739 | - Moved generic navigation functions from Player_Melee to a new Creature_Nagivation - Adjusted Player spell cast timings to account for both self cast and short TurnTo() - Added a temporary method for corpse cleanup, until more generalized cleanup management is implemented | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/739/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
314376938 | MDExOlB1bGxSZXF1ZXN0MTgxNjc1Njk4 | 740 | Limit Portal Spam from multiple collisions | 10137 | closed | 0 | 0 | 2018-04-15T01:34:05Z | 2018-04-15T02:12:41Z | 2018-04-15T01:56:28Z | NONE | 0 | ACEmulator/ACE/pulls/740 | - Use the Player.Teleporting flag to prevent Portal.HandleActionOnCollide() from doing any actions multiple times because of repeated collisions | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/740/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
314391768 | MDExOlB1bGxSZXF1ZXN0MTgxNjg0NTcy | 742 | Magic :: Lessen 9 :: Streaking | 10137 | closed | 0 | 0 | 2018-04-15T07:05:20Z | 2018-04-24T14:08:40Z | 2018-04-15T12:49:33Z | NONE | 0 | ACEmulator/ACE/pulls/742 | - Add fast casting - Increase projectile velocity for Streak war spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/742/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
317251974 | MDExOlB1bGxSZXF1ZXN0MTgzNzU1NDAy | 759 | Magic :: Lesson 10 :: Arc spells | 10137 | closed | 0 | 0 | 2018-04-24T14:26:54Z | 2018-04-25T00:30:21Z | 2018-04-24T23:26:19Z | NONE | 0 | ACEmulator/ACE/pulls/759 | - Add Arc spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/759/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
317652694 | MDExOlB1bGxSZXF1ZXN0MTg0MDU0ODE1 | 760 | Magic : Lesson 11 : No cheaters allowed | 10137 | closed | 0 | 0 | 2018-04-25T14:26:34Z | 2018-04-26T13:58:26Z | 2018-04-26T02:12:33Z | NONE | 0 | ACEmulator/ACE/pulls/760 | - Implement a magic skill check for the spell being cast, with a chance for failure based upon said skill level | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/760/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
318123541 | MDExOlB1bGxSZXF1ZXN0MTg0NDA5MzA0 | 761 | Magic :: Lesson 12 : Check PK status and implement Magic Defense | 10137 | closed | 0 | 0 | 2018-04-26T17:19:15Z | 2018-04-27T16:17:04Z | 2018-04-26T21:14:29Z | NONE | 0 | ACEmulator/ACE/pulls/761 | - If target is player, check for similar PK status before allowing casting of harmful spells - Implement target's Magic Defense vs caster's Magic Skill level | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/761/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
318282158 | MDExOlB1bGxSZXF1ZXN0MTg0NTI3Mzk3 | 765 | Magic :: Lesson 12.5 : Target validation and a few fixes | 10137 | closed | 0 | 0 | 2018-04-27T05:28:53Z | 2018-04-27T16:17:08Z | 2018-04-27T08:25:25Z | NONE | 0 | ACEmulator/ACE/pulls/765 | - Target validation : checks for hackery, even if the client disallows certain targets for specific spells - Workaround for spell projectiles in dungeons - Remove extra UseDone message in Enchantment code path | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/765/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
318433845 | MDExOlB1bGxSZXF1ZXN0MTg0NjQwNTk2 | 766 | Adjust invalid target message | 10137 | closed | 0 | 0 | 2018-04-27T14:36:32Z | 2018-04-27T16:17:09Z | 2018-04-27T15:42:48Z | NONE | 0 | ACEmulator/ACE/pulls/766 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/766/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
318468272 | MDExOlB1bGxSZXF1ZXN0MTg0NjY2NTYw | 767 | Add a few checks and minor changes | 10137 | closed | 0 | 0 | 2018-04-27T16:13:56Z | 2018-04-27T21:55:26Z | 2018-04-27T19:22:11Z | NONE | 0 | ACEmulator/ACE/pulls/767 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/767/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
318567103 | MDExOlB1bGxSZXF1ZXN0MTg0NzQwODg1 | 768 | Update fake collisions for magic :: WIP | 10137 | closed | 0 | 0 | 2018-04-27T22:25:41Z | 2018-04-28T01:05:43Z | 2018-04-27T23:50:34Z | NONE | 0 | ACEmulator/ACE/pulls/768 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/768/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
318599779 | MDExOlB1bGxSZXF1ZXN0MTg0NzYzNzk3 | 769 | Implement the Attuned functionality | 10137 | closed | 0 | 0 | 2018-04-28T04:38:35Z | 2018-04-29T01:27:04Z | 2018-04-28T16:59:11Z | NONE | 0 | ACEmulator/ACE/pulls/769 | - Add new GameEvent message for InventoryServerSaveFailed - Add attuned checking to HandleActionDropItem, with InventoryServerSaveFailed message response | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/769/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
318692465 | MDExOlB1bGxSZXF1ZXN0MTg0ODE5NzA5 | 774 | Fix IsAttuned method | 10137 | closed | 0 | 0 | 2018-04-29T05:57:47Z | 2018-05-04T07:19:28Z | 2018-04-29T06:10:49Z | NONE | 0 | ACEmulator/ACE/pulls/774 | As caught by Derrick, a null check was missing vs the Attuned property itself. However, the fist null check should remain, as there is a possibility that GetInventoryItem() might return a null, which would need to be handled in a manner to avoid a null pointer exception. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/774/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
320137967 | MDExOlB1bGxSZXF1ZXN0MTg1ODgxMjcw | 778 | Magic :: Lesson 14 :: Items casting spells | 10137 | closed | 0 | 0 | 2018-05-04T02:34:04Z | 2018-05-06T14:45:40Z | 2018-05-05T04:58:08Z | NONE | 0 | ACEmulator/ACE/pulls/778 | - Adds the ability for items with spells to cast them on players - Fixes the player combat with no weapons equipped, which previously had the potential to create a null exception is two locations - The refresh of spells in the Enchantment registry needs some work, as they currently don't work correctly, until the client is restarted. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/778/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
320827675 | MDExOlB1bGxSZXF1ZXN0MTg2MzY4OTc2 | 781 | Fix null cases and magic code rearrangement | 10137 | closed | 0 | 0 | 2018-05-07T14:32:30Z | 2018-07-04T19:42:37Z | 2018-05-07T20:48:23Z | NONE | 0 | ACEmulator/ACE/pulls/781 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/781/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
321591583 | MDExOlB1bGxSZXF1ZXN0MTg2OTM4MDQ2 | 785 | Fix a null exception and a couple of if statements | 10137 | closed | 0 | 0 | 2018-05-09T14:22:54Z | 2018-07-04T19:42:36Z | 2018-05-09T15:02:09Z | NONE | 0 | ACEmulator/ACE/pulls/785 | - Have HandleActionCastTargetedSpell method be more granular is deciding the target type to determine whether player rotation is needed - Change an two if statements in IsInvalidTarget, so the result is correct to allow casting Item enchants on valid targets | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/785/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
322481040 | MDExOlB1bGxSZXF1ZXN0MTg3NjAzNTc2 | 788 | Fix magic messaging and portal spells routing incorrectly | 10137 | closed | 0 | 0 | 2018-05-12T04:14:51Z | 2018-07-04T19:42:34Z | 2018-05-12T04:58:13Z | NONE | 0 | ACEmulator/ACE/pulls/788 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/788/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
337175570 | MDExOlB1bGxSZXF1ZXN0MTk4NDUyOTc4 | 834 | Migrate Gem spell casting to Spell System | 10137 | closed | 0 | 0 | 2018-06-30T01:25:49Z | 2018-07-04T19:42:33Z | 2018-06-30T02:05:28Z | NONE | 0 | ACEmulator/ACE/pulls/834 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/834/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
337304322 | MDExOlB1bGxSZXF1ZXN0MTk4NTMyMzQ4 | 836 | Add spells and a couple of other fixes | 10137 | closed | 0 | 0 | 2018-07-01T16:40:18Z | 2018-07-04T19:42:32Z | 2018-07-02T03:47:39Z | NONE | 0 | ACEmulator/ACE/pulls/836 | - Modify LearnSpellsInBulk() to use an uint array of player allowed spellIDs - Remove extra /addspell in DebugCommands, leaving renamed command in AdminCommands : use continue to use /addspell ( renamed to remove ambiguity about what is being added ) - Fix NPK vs other players, in regards to harmful spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/836/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
338407407 | MDExOlB1bGxSZXF1ZXN0MTk5MzQ1NzA4 | 846 | Adjusted Magic code :: WIP :: Testing needed before merge | 10137 | closed | 0 | 0 | 2018-07-05T02:25:03Z | 2018-07-07T16:25:39Z | 2018-07-06T00:58:20Z | NONE | 0 | ACEmulator/ACE/pulls/846 | -Rearranged code flow to remove some redundant code -Aligned Magic damage application with Physical damage -Added Crit and War skill bonus | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/846/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
338794196 | MDExOlB1bGxSZXF1ZXN0MTk5NjM3MTM1 | 849 | Remove Vital to Vital Other spells from player allowed list | 10137 | closed | 0 | 0 | 2018-07-06T03:36:07Z | 2018-07-07T16:25:36Z | 2018-07-06T21:20:19Z | NONE | 0 | ACEmulator/ACE/pulls/849 | -Remove Health to {Stamina,Mana} Other spells -Remove Stamina to {Health,Mana} Other spells -Remove Mana to {Health,Stamina} Other spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/849/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
339174733 | MDExOlB1bGxSZXF1ZXN0MTk5OTEzNDY0 | 853 | Fix Enchantment Registry duration | 10137 | closed | 0 | 0 | 2018-07-07T21:03:02Z | 2018-07-08T02:28:47Z | 2018-07-08T02:28:32Z | NONE | 0 | ACEmulator/ACE/pulls/853 | -Redirect Aura spells cast by items to the player -Fix item cast spell timers in the player's Enchantment Registry | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/853/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
339191091 | MDExOlB1bGxSZXF1ZXN0MTk5OTIyMjc0 | 856 | Fix Enchant Registry for duration and layering and Redirect Aura spells | 10137 | closed | 0 | 0 | 2018-07-08T02:39:15Z | 2018-07-10T03:51:25Z | 2018-07-09T19:06:18Z | NONE | 0 | ACEmulator/ACE/pulls/856 | -Redirect Aura spells cast by items to Player -Fix Enchantment Registry timers -Account for gems casting spells requiring a duration -Initial pass at Enchantment layering TODO: duplicate and overridden item enchants still show up on AppraisalInfo :: will fix in next PR | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/856/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
339297380 | MDExOlB1bGxSZXF1ZXN0MTk5OTg2MTM1 | 858 | Remove the five unneeded start items | 10137 | closed | 0 | 0 | 2018-07-09T03:59:05Z | 2018-07-10T03:51:26Z | 2018-07-09T17:43:02Z | NONE | 0 | ACEmulator/ACE/pulls/858 | -Remove the five unneeded start items from WeeniePropertiesCreateList that get generated for all characters. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/858/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
339653615 | MDExOlB1bGxSZXF1ZXN0MjAwMjU0ODU1 | 861 | Fix missing null check | 10137 | closed | 0 | 0 | 2018-07-10T00:39:58Z | 2018-07-10T03:51:22Z | 2018-07-10T01:50:50Z | NONE | 0 | ACEmulator/ACE/pulls/861 | -Add null check at end of CreateEnchantment() | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/861/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
339877453 | MDExOlB1bGxSZXF1ZXN0MjAwNDIzMTc1 | 863 | Fix spell reflection from Player to Item | 10137 | closed | 0 | 0 | 2018-07-10T14:49:14Z | 2018-07-11T14:00:52Z | 2018-07-11T01:04:36Z | NONE | 0 | ACEmulator/ACE/pulls/863 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/863/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
340657371 | MDExOlB1bGxSZXF1ZXN0MjAxMDE2MzUw | 869 | Rework AppraisalInfo for Enchants | 10137 | closed | 0 | 0 | 2018-07-12T14:15:40Z | 2018-07-16T15:48:35Z | 2018-07-13T01:35:57Z | NONE | 0 | ACEmulator/ACE/pulls/869 | Rework AppraisalInfo to differentiate between intrinsic spells and applied spells - "spellbook" data sent in AppraisalInfo packet uses highest bit of uint to indicated whether intrinsic spell of item or applied enchant - WeenieType.Cothing enchants are applied to the item - Account for debuffs applied to wielded weapons - Enchants applied to armor affecting armor stats fixed to display correctly ![image](https://user-images.githubusercontent.com/22699181/42639077-0bbc2ce8-85a4-11e8-82c1-292c516b7f66.png) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/869/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
341128088 | MDExOlB1bGxSZXF1ZXN0MjAxMzc1NDkz | 871 | Misc. Fixes | 10137 | closed | 0 | 0 | 2018-07-13T19:06:16Z | 2018-07-16T15:48:32Z | 2018-07-14T06:19:55Z | NONE | 0 | ACEmulator/ACE/pulls/871 | -Fix vendor buying -Change Enchantment removal type on item running out of mana from DispelEnchantment to RemoveEnchantment -Added removal of Enchantments when dropping or giving an item away straight from being wielded | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/871/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
341574678 | MDExOlB1bGxSZXF1ZXN0MjAxNjgwMzY3 | 875 | Redirect Impen/Banes from player to equipped armor and undergarments | 10137 | closed | 0 | 1 | 2018-07-16T15:47:45Z | 2018-07-23T03:28:18Z | 2018-07-17T14:13:22Z | NONE | 0 | ACEmulator/ACE/pulls/875 | - Adds functionality of redirecting Impen/Banes from a player to their equipped armor and undergarments. - Mana consumption appropriate for number of WeenieType.Clothing items spells cast on - Change damage calcs to point to armor pieces for enchants from the player wearing the items | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/875/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
341951227 | MDExOlB1bGxSZXF1ZXN0MjAxOTY2MjYy | 878 | Fix Aura redirection | 10137 | closed | 0 | 0 | 2018-07-17T14:43:35Z | 2018-07-23T03:28:19Z | 2018-07-18T00:26:00Z | NONE | 0 | ACEmulator/ACE/pulls/878 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/878/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
342622099 | MDExOlB1bGxSZXF1ZXN0MjAyNDc2OTgz | 880 | Enforce item wield requirements | 10137 | closed | 0 | 0 | 2018-07-19T08:08:00Z | 2018-07-23T03:28:20Z | 2018-07-19T14:26:43Z | NONE | 0 | ACEmulator/ACE/pulls/880 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
343343308 | MDExOlB1bGxSZXF1ZXN0MjAzMDE5NzU0 | 883 | Fix wield requirements and item enchant removals | 10137 | closed | 0 | 0 | 2018-07-21T17:44:41Z | 2018-07-23T03:28:21Z | 2018-07-22T01:00:16Z | NONE | 0 | ACEmulator/ACE/pulls/883 | -Add different wield requirement scenarios -Fix removal of impen/banes cast by items on themselves | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/883/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
343475782 | MDExOlB1bGxSZXF1ZXN0MjAzMTAwNjQ1 | 890 | Add PortalSending and PortalSummon functionality | 10137 | closed | 0 | 0 | 2018-07-23T03:30:02Z | 2018-07-25T23:47:05Z | 2018-07-23T07:57:46Z | NONE | 0 | ACEmulator/ACE/pulls/890 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/890/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
344053574 | MDExOlB1bGxSZXF1ZXN0MjAzNTM5NTYz | 892 | Three Emote Manager fixes/changes | 10137 | closed | 0 | 0 | 2018-07-24T14:06:52Z | 2018-07-25T23:47:03Z | 2018-07-24T19:07:14Z | NONE | 0 | ACEmulator/ACE/pulls/892 | -EmoteManager.Execute() moved to a new partial class of EmoteManager and Obsolete attribute and commenting added, as it may cause confusion as to which emote execute function to use -Implement EmoteType.Act -Change the target of the PlayScript in EmoteType.PhysScript from targetObject to the WorldObject that is using the emote | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/892/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
344598617 | MDExOlB1bGxSZXF1ZXN0MjAzOTU2NjQ3 | 893 | Add 2 second delay to Recall spells | 10137 | closed | 0 | 0 | 2018-07-25T20:39:30Z | 2018-07-27T23:47:01Z | 2018-07-25T23:47:25Z | NONE | 0 | ACEmulator/ACE/pulls/893 | A 2 second delay was added to the casting of the recall spells in patch Thorns of the Hopeslayer | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/893/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
345062436 | MDExOlB1bGxSZXF1ZXN0MjA0MzA5ODIz | 895 | Adjust Emote item interactions and Player and item interactions | 10137 | closed | 0 | 0 | 2018-07-27T01:50:27Z | 2018-07-27T23:47:03Z | 2018-07-27T13:48:57Z | NONE | 0 | ACEmulator/ACE/pulls/895 | Adjust Emote and Attuned item handling according to PCAP data findings | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/895/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
345406420 | MDExOlB1bGxSZXF1ZXN0MjA0NTY5NDM3 | 897 | Fix Null exception of dropping an item | 10137 | closed | 0 | 0 | 2018-07-28T01:34:51Z | 2018-07-28T05:59:57Z | 2018-07-28T01:41:49Z | NONE | 0 | ACEmulator/ACE/pulls/897 | Fix the missing PhysicsObj for items that start life as non-world objects, when item is dropped onto the 3D world | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/897/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
345409542 | MDExOlB1bGxSZXF1ZXN0MjA0NTcxMjcz | 898 | Move InitPhysicsObj call to Landblock.AddWorldObjectInternal() | 10137 | closed | 0 | 0 | 2018-07-28T02:21:08Z | 2018-07-28T05:59:55Z | 2018-07-28T02:23:51Z | NONE | 0 | ACEmulator/ACE/pulls/898 | -Move the creation of a WorldObject's PhysicsObj to a singular location in Landblock.AddWorldObjectInternal(), with a check for a preexisting PhysicsObj, so it is created when an object is placed in the world | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/898/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
345415647 | MDExOlB1bGxSZXF1ZXN0MjA0NTc0NzM3 | 900 | Partial Revert previous commit | 10137 | closed | 0 | 0 | 2018-07-28T03:55:08Z | 2018-07-28T05:59:53Z | 2018-07-28T03:58:39Z | NONE | 0 | ACEmulator/ACE/pulls/900 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/900/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
345421925 | MDExOlB1bGxSZXF1ZXN0MjA0NTc4NTQz | 901 | Allow giving Attuned items to appropriate NPCs | 10137 | closed | 0 | 0 | 2018-07-28T05:57:33Z | 2018-07-30T02:40:20Z | 2018-07-28T18:30:47Z | NONE | 0 | ACEmulator/ACE/pulls/901 | -Allow giving Attuned items to appropriate NPCs but still prevent passing attuned items to other players | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/901/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
345504242 | MDExOlB1bGxSZXF1ZXN0MjA0NjI2MDYw | 904 | Add check for target death before process Magic Damage | 10137 | closed | 0 | 0 | 2018-07-29T05:50:07Z | 2018-07-30T02:40:18Z | 2018-07-30T02:15:58Z | NONE | 0 | ACEmulator/ACE/pulls/904 | -Add checks before Magic Damage is calculated to ensure target isn't already dead -Change EarnXP on creature kill to sharable -Rearranged the flow of player spell casting, predominately moving the out-of-mana fizzle to after the spell windup animation and the speaking of the spell words | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/904/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
345643342 | MDExOlB1bGxSZXF1ZXN0MjA0NzE3NTQ3 | 909 | Various tweaks | 10137 | closed | 0 | 0 | 2018-07-30T07:34:06Z | 2018-08-04T17:29:37Z | 2018-07-31T07:02:34Z | NONE | 0 | ACEmulator/ACE/pulls/909 | -Add GameEventPopupString message function to EmoteType.PopUp, when no confirmation is requested, and finish the Confirmation functionality -Adjust the Welcome message to match retail, with a twist -Change two more Spell references to SpellBase, in EnchantmentManager.cs -Add GameEventCommunicationTransientString to Chest.cs, when chests are in the locked condition | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/909/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
347674433 | MDExOlB1bGxSZXF1ZXN0MjA2MjI1MTE5 | 921 | Move PK checks and spell damage messages and implement SpellType.PortalLink | 10137 | closed | 0 | 0 | 2018-08-05T06:50:14Z | 2018-08-05T21:54:09Z | 2018-08-05T14:44:01Z | NONE | 0 | ACEmulator/ACE/pulls/921 | -Move PK checks to after start of spell cast and one spell projectile collision -Move spell damage messages to be mutually exclusive with the death messages -Implement SpellType.PortalLink (Primary Portal, Secondary Portal, and LIfestone Tie) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/921/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
347709959 | MDExOlB1bGxSZXF1ZXN0MjA2MjQ1ODI0 | 922 | Randomize spell death messages | 10137 | closed | 0 | 0 | 2018-08-05T16:00:51Z | 2018-08-05T23:47:35Z | 2018-08-05T23:46:47Z | NONE | 0 | ACEmulator/ACE/pulls/922 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/922/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
347790778 | MDExOlB1bGxSZXF1ZXN0MjA2Mjk3NTMz | 923 | Change spell casting busy and Spell words ChatMessageType | 10137 | closed | 0 | 0 | 2018-08-06T06:09:57Z | 2018-08-07T00:53:56Z | 2018-08-06T07:14:32Z | NONE | 0 | ACEmulator/ACE/pulls/923 | -Rearrange spell casting busy state notifications to match PCAPs -Change ChatMessageType for spell words, allowing VT decal plugin to cast spells without any duplicate casts | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/923/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
347939675 | MDExOlB1bGxSZXF1ZXN0MjA2NDExMDAw | 925 | Update Readme.md with new minimum 16PY World DB version | 10137 | closed | 0 | 0 | 2018-08-06T14:09:10Z | 2018-08-07T00:58:30Z | 2018-08-06T14:12:38Z | NONE | 0 | ACEmulator/ACE/pulls/925 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/925/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
349748297 | MDExOlB1bGxSZXF1ZXN0MjA3NzgzMjYw | 945 | Fix WorldObject_Magic IsInvalidTarget() | 10137 | closed | 0 | 0 | 2018-08-11T16:57:05Z | 2018-08-24T15:46:02Z | 2018-08-11T19:58:38Z | NONE | 0 | ACEmulator/ACE/pulls/945 | -Allow for non-Admin and non-Sentinel players, as the target, to correctly pass through IsInvalidTarget() method for beneficial spell casting | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/945/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
349826944 | MDExOlB1bGxSZXF1ZXN0MjA3ODMwMDY3 | 949 | Fix casting spells on other's wielded items | 10137 | closed | 0 | 0 | 2018-08-12T16:51:21Z | 2018-08-24T15:45:59Z | 2018-08-12T22:14:37Z | NONE | 0 | ACEmulator/ACE/pulls/949 | -Fix casting spells on other's wielded items | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/949/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
353589588 | MDExOlB1bGxSZXF1ZXN0MjEwNjAxNzEx | 968 | Player giving items to other players fix | 10137 | closed | 0 | 0 | 2018-08-23T23:23:55Z | 2018-08-24T19:07:54Z | 2018-08-24T19:07:07Z | NONE | 0 | ACEmulator/ACE/pulls/968 | -Implement unsecure ability, ie. without Trade_ protocols, to give items to other players, given the status of their "Let Other Players Give You Items" CharacterOption -Bug fix by gmriggs in EmoteManager.cs for EmoteType.Turn and EmoteType.TurnToTarget | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/968/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
354044490 | MDExOlB1bGxSZXF1ZXN0MjEwOTIyMDAx | 971 | Couple of fixes | 10137 | closed | 0 | 0 | 2018-08-25T21:23:51Z | 2018-08-26T14:52:14Z | 2018-08-26T03:40:31Z | NONE | 0 | ACEmulator/ACE/pulls/971 | -Fix casting spells on WeenieType.Cow -Add EmoteManager.Heartbeat() call to Creature.Heartbeat() | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/971/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
354183279 | MDExOlB1bGxSZXF1ZXN0MjExMDA3OTcz | 978 | Weapon Bonuses | 10137 | closed | 0 | 0 | 2018-08-27T05:21:13Z | 2018-08-27T16:44:18Z | 2018-08-27T16:43:56Z | NONE | 0 | ACEmulator/ACE/pulls/978 | -Adds support for Biting Strike, Crushing Blow, Resistance Cleaving, Elemental Damage for casters, Mana conversion, and Melee Defense Mod bonuses -Adds single spell casting method for Sentinal run spell and food buffs | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/978/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
354939195 | MDExOlB1bGxSZXF1ZXN0MjExNTg2MTE5 | 982 | Weapon Bonuses | 10137 | closed | 0 | 1 | 2018-08-28T23:21:29Z | 2018-09-01T07:08:29Z | 2018-09-01T06:19:12Z | NONE | 0 | ACEmulator/ACE/pulls/982 | - Add support for bonuses on weapons: Melee Defense, Mana Conversion, Biting Strike, Crushing Blow, Resistance Cleaving, Elemental damage modifier on Casters, and Creature Slayer - Add support for unrestricted single spell casts for use by Sentinal run and food buff/debuff | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/982/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
356320062 | MDExOlB1bGxSZXF1ZXN0MjEyNjE1Mzk4 | 993 | Add missile launcher Elemental damage modifier | 10137 | closed | 0 | 1 | 2018-09-02T22:45:49Z | 2018-09-04T22:41:35Z | 2018-09-04T06:32:11Z | NONE | 0 | ACEmulator/ACE/pulls/993 | -Change 'Bonus' suffix to 'Modifier', in WorldObject_Weapons.cs -Add missile launcher Elemental damage modifier | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/993/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
358419154 | MDExOlB1bGxSZXF1ZXN0MjE0MTY4NjE3 | 1007 | Implement a basic House Portal class | 10137 | closed | 0 | 0 | 2018-09-09T22:29:04Z | 2018-09-10T23:03:44Z | 2018-09-09T22:50:03Z | NONE | 0 | ACEmulator/ACE/pulls/1007 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1007/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
358493996 | MDExOlB1bGxSZXF1ZXN0MjE0MjE2NjY3 | 1009 | Portal Updates, plus fix IsWithinUseRadiusOf() | 10137 | closed | 0 | 0 | 2018-09-10T07:07:24Z | 2018-09-10T23:03:42Z | 2018-09-10T20:36:35Z | NONE | 0 | ACEmulator/ACE/pulls/1009 | Seems to fix the MoveTo when using a Portal | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1009/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
365477115 | MDExOlB1bGxSZXF1ZXN0MjE5Mzg3OTY2 | 1036 | Fix DamageType for Boost spells | 10137 | closed | 0 | 1 | 2018-10-01T14:03:40Z | 2018-10-03T13:56:30Z | 2018-10-01T14:18:43Z | NONE | 0 | ACEmulator/ACE/pulls/1036 | Change DamageType to DamageType2 for LifeMagic Boost spells | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1036/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |