github
Data license: AGPL · Data source: ACEmulator Project
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/1864#issuecomment-490239070 | https://api.github.com/repos/ACEmulator/ACE/issues/1864 | 490239070 | MDEyOklzc3VlQ29tbWVudDQ5MDIzOTA3MA== | 2904834 | 2019-05-07T20:16:26Z | 2019-05-07T20:16:26Z | CONTRIBUTOR | Seems reasonable. Shall I introduce another static array and reuse it for all the coverage slots? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 441424285 | |
https://github.com/ACEmulator/ACE/pull/1864#issuecomment-490240333 | https://api.github.com/repos/ACEmulator/ACE/issues/1864 | 490240333 | MDEyOklzc3VlQ29tbWVudDQ5MDI0MDMzMw== | 10137 | 2019-05-07T20:20:27Z | 2019-05-07T20:20:27Z | NONE | If each armor piece has the same potential spells and/or cantrips, then those separate arrays should be compressed down to fewer. Jewelry obviously needs to have its own, as those items don't have impen/banes. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 441424285 | |
https://github.com/ACEmulator/ACE/pull/1864#issuecomment-490244973 | https://api.github.com/repos/ACEmulator/ACE/issues/1864 | 490244973 | MDEyOklzc3VlQ29tbWVudDQ5MDI0NDk3Mw== | 10137 | 2019-05-07T20:34:51Z | 2019-05-07T20:36:14Z | NONE | On the right track. ClothingCantrips looks to me to be much the same, also. I imagine that the normal spells are also in similar need of compression and standardization. Lastly, if those spell arrays are being condensed down to single arrays, the better option would be to remove the switch statements in LootGenerationFactory_Clothing.cs in favor of spells = LootTables.ArmorSpells and cantrips = LootTables.ArmorCantrips, rather than assigning the actual array to the others that are now unneeded. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 441424285 | |
https://github.com/ACEmulator/ACE/pull/1864#issuecomment-490251719 | https://api.github.com/repos/ACEmulator/ACE/issues/1864 | 490251719 | MDEyOklzc3VlQ29tbWVudDQ5MDI1MTcxOQ== | 2904834 | 2019-05-07T20:55:21Z | 2019-05-07T20:55:21Z | CONTRIBUTOR | Thanks for the feedback, Theran! Let me know if there's any more changes you'd recommend. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 441424285 | |
https://github.com/ACEmulator/ACE/pull/1864#issuecomment-490274515 | https://api.github.com/repos/ACEmulator/ACE/issues/1864 | 490274515 | MDEyOklzc3VlQ29tbWVudDQ5MDI3NDUxNQ== | 10137 | 2019-05-07T22:14:55Z | 2019-05-07T22:14:55Z | NONE | Looks good | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 441424285 | |
https://github.com/ACEmulator/ACE/pull/1864#issuecomment-490275410 | https://api.github.com/repos/ACEmulator/ACE/issues/1864 | 490275410 | MDEyOklzc3VlQ29tbWVudDQ5MDI3NTQxMA== | 2904834 | 2019-05-07T22:18:44Z | 2019-05-07T22:18:44Z | CONTRIBUTOR | Woops, didn't mean to close without merging. Didn't realize I have to wait for you to merge :-) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 441424285 |