github
Data license: AGPL · Data source: ACEmulator Project
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/107#issuecomment-284311511 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | 284311511 | MDEyOklzc3VlQ29tbWVudDI4NDMxMTUxMQ== | 10137 | 2017-03-06T06:13:51Z | 2017-03-06T06:13:51Z | NONE | So the file names themselves would be hard-coded and just pull in the directory location from the config file, thereby allowing the two config directives to condense into one. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 211999671 | |
https://github.com/ACEmulator/ACE/pull/107#issuecomment-284312826 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | 284312826 | MDEyOklzc3VlQ29tbWVudDI4NDMxMjgyNg== | 11369233 | 2017-03-06T06:25:16Z | 2017-03-06T06:25:16Z | MEMBER | Exactly. I can't imagine a reason why the file names couldn't or shouldn't be hardcoded, but I can think of a few reasons why one might want to change the directory location. One of which could be having multiple versions of DAT patches to switch between perhaps? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 211999671 | |
https://github.com/ACEmulator/ACE/pull/107#issuecomment-284326453 | https://api.github.com/repos/ACEmulator/ACE/issues/107 | 284326453 | MDEyOklzc3VlQ29tbWVudDI4NDMyNjQ1Mw== | 10137 | 2017-03-06T07:59:00Z | 2017-03-06T07:59:00Z | NONE | Stupid tab vs spaces kept tripping me up. I also noticed that I missed a whole file that should have been included in the original commit. 'git add <filename>, ftw. It has now been added into the PR with the changes to the config variable(s). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 211999671 |