issues: 517525522
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
517525522 | MDExOlB1bGxSZXF1ZXN0MzM2NTc4MDE5 | 2388 | add valid skills hashset, check valid skills entering godmode | 26235642 | closed | 0 | 2 | 2019-11-05T03:18:48Z | 2019-11-09T11:54:21Z | 2019-11-09T11:54:21Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2388 | added a valid skills hashset to the skillhelper so that it could be checked against when entering godmode. also added hard coded checks against the attribute and attribute 2nd types... figured they didnt need a helper this change will only add entries to the godstring if they are valid. According to ripley, the bug is with the GetOrAddSkill function that adds a skill to a players biota_properties_skill table when checking for invalid skill types. if a player had an invalid skill (typically this was a skill with type 0) the string would be too long and cause the error. now when entering godmode invalid skill and attribute values will be ignored and everything should work as intended the only way an error when attempting to god/ungod should happen now is if the db is externally corrupted or manually changed... or until the next bug is uncovered :) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |