issues: 2165534489
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2165534489 | PR_kwDOBLalGM5ohSMO | 4127 | Wire up GameEventMagicPurgeBadEnchantments | 11369233 | closed | 0 | 1 | 2024-03-03T20:06:24Z | 2024-03-15T04:54:32Z | 2024-03-15T04:54:31Z | MEMBER | 0 | ACEmulator/ACE/pulls/4127 | According to PCAPs GameEventMagicPurgeBadEnchantments was sent to clients for players with Enduring Enchantment augmentation. Client has slightly different check in CEnchantmentRegistry::PurgeBadEnchantmentList versus CEnchantmentRegistry::PurgeEnchantmentList ```cpp if ( v4->data._smod.type & 0x2000000 || v4->data._duration == -1.0 ) ``` vs ```cpp if ( v4->data._duration == -1.0 ) ``` | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/4127/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |