issues: 214781043
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
214781043 | MDExOlB1bGxSZXF1ZXN0MTExMTIzMjg3 | 136 | Create Training Wand - Demo work for item creation. | 25460553 | closed | 0 | 3 | 2017-03-16T17:28:59Z | 2017-03-16T23:29:47Z | 2017-03-16T23:29:38Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/136 | Added some test code to create a training wand. As part of this work, I put in some fixes in sizes, added AnimationFrame. While this is not all that spectacular - it perfectly matches live server pcaps in every field. I would like to work on persisting this out to the database. I assume we will need to implement a next object_id sequence as part of this. In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted. Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help. Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch. God this was fun. I forgot how much I used to love coding. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |