issues: 1523493320
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1523493320 | PR_kwDOBLalGM5G3fat | 3947 | Add server settings for quest xp and lum modifiers | 1765994 | closed | 0 | 0 | 2023-01-07T05:34:56Z | 2023-03-29T23:49:16Z | 2023-03-29T23:49:16Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/3947 | **Purpose:** - Allow server operator to be able to offer xp and luminance modifications explicitly for quests/emotes versus killing and other sources. - Gives the server operator more flexibility but my personal motivation is for a server operator to encourage questing. **Notes** - Available via 2 server properties. Will need to update the ACE Commands list if approved/merged. https://github.com/ACEmulator/ACE/wiki/ACE-Commands#in-gameclient-commands - The default is 1.0 for no change to existing server operators - Does not undo any XP changes from the existing "luminance_modifier" and "xp_modifier" properties. Those continue to work as before. - These new properties are multiplicative with the old properties but just for quest/emote based XP. **Example** A server operator wants 2.0 general XP and 3.0 quest xp. The operator would set "xp_modifier" to 2.0. The operator would set "quest_xp_modifier" to 1.5. **Testing** - **_Testing complete. Ready for Review_** - Verify creature killing based xp is not affected by the change - Verify skill xp is not affected by the change - Verify item XP IS affected by the change - Player::GrantXP() handles this for kill and quest xp and is unchanged. - Verify quest XP is multiplicative with "xp_modifier" and "quest_xp_modifier" for standard xp awards - Same as last with non-shared xp - Same as last with fractional level xp - includes real quests and things like colo ring xp - Similar as above tests but with Lum. The rules for lum are much simpler though. - Limits testing | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/3947/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |