id,node_id,number,title,user,user_label,state,locked,assignee,assignee_label,milestone,milestone_label,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,repo_label,type
202877062,MDExOlB1bGxSZXF1ZXN0MTAyOTU5MDg1,1,Updates to database and underlying code,6705011,xanxin887,closed,0,,,,,0,2017-01-24T16:55:13Z,2017-01-24T18:24:10Z,2017-01-24T18:24:10Z,NONE,,0,ACEmulator/ACE/pulls/1,Updates to database and underlying code,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/1/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
202908658,MDExOlB1bGxSZXF1ZXN0MTAyOTgxNDMw,2,Updates for DB 1/24/17,6705011,xanxin887,closed,0,,,,,1,2017-01-24T18:58:40Z,2017-02-01T12:50:46Z,2017-02-01T12:50:46Z,NONE,,0,ACEmulator/ACE/pulls/2,Updates for DB to prep for creating associated tables,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/2/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
204489692,MDU6SXNzdWUyMDQ0ODk2OTI=,3,ACE loading dat files,10608427,Mag-nus,closed,0,25351661,Mogwai-TheFurry,,,0,2017-02-01T03:34:33Z,2017-03-06T13:16:08Z,2017-03-06T13:16:08Z,MEMBER,,,,"It's needed for a lot of things
Even a basic packet broadcast will need it","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/3/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204489832,MDU6SXNzdWUyMDQ0ODk4MzI=,4,ACE World DB Design,10608427,Mag-nus,closed,0,,,,,2,2017-02-01T03:36:00Z,2017-04-03T12:06:09Z,2017-04-03T12:06:09Z,MEMBER,,,,"We need a core design, and then to work on population.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/4/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204489878,MDU6SXNzdWUyMDQ0ODk4Nzg=,5,ACE Chat System,10608427,Mag-nus,closed,0,10608427,Mag-nus,,,4,2017-02-01T03:36:34Z,2017-07-26T16:51:19Z,2017-07-26T16:51:19Z,MEMBER,,,,"StackOverflow had something working in chat, perhaps submit a pull request.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/5/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204489997,MDU6SXNzdWUyMDQ0ODk5OTc=,6,Characters aren't saved or loaded properly yet from the DB,10608427,Mag-nus,closed,0,25125434,TigrisOfGaul,,,4,2017-02-01T03:37:48Z,2017-02-11T02:28:13Z,2017-02-11T02:28:13Z,MEMBER,,,,Per Rawaho. This needs looking into.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/6/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204490022,MDU6SXNzdWUyMDQ0OTAwMjI=,7,World object movement / animation needs proper implementing,10608427,Mag-nus,closed,0,,,,,2,2017-02-01T03:38:06Z,2017-07-26T16:51:29Z,2017-07-26T16:51:29Z,MEMBER,,,,Per Rawaho,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/7/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204490371,MDU6SXNzdWUyMDQ0OTAzNzE=,8,Client Launcher needed,10608427,Mag-nus,closed,0,,,,,5,2017-02-01T03:41:07Z,2017-02-16T21:49:46Z,2017-02-16T21:49:40Z,MEMBER,,,,"We need a client launcher. Perhaps we use a modified thwarglauncher.
https://thwarglauncher.codeplex.com/

For decal to work:
""for emu, you should make a launcher that injects OR a shim client that loads the client and injects""
""just stuff inject.dll in the process space early enough and it will do its thing""","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/8/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204506877,MDU6SXNzdWUyMDQ1MDY4Nzc=,9,Rework packet pipe,6111341,Rawaho,closed,0,,,,,3,2017-02-01T06:26:07Z,2017-02-21T12:34:45Z,2017-02-21T12:34:45Z,CONTRIBUTOR,,,,Rewrite packet and fragment handling to delay and allow for combining outgoing fragments.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/9/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
204670023,MDExOlB1bGxSZXF1ZXN0MTA0MTk2NjM1,10,Client and Server expects account in ace_auth to be lowercase only.,11369233,LtRipley36706,closed,0,,,,,1,2017-02-01T18:45:44Z,2017-02-02T16:36:57Z,2017-02-02T16:36:53Z,MEMBER,,0,ACEmulator/ACE/pulls/10,"This is my first pull request, please let me know if I'm doing this incorrectly.

Simple change I made to the accountcreate command to correct and prevent the issue I experienced when setting up ACE.

The client always sends accounts as lowercase regardless of what the user types in the command line. The server itself resolves the difference and connects as well. The issue surfaces when attempting to create a character. That packet is sent, but no response is ever recv'd.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/10/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
204803198,MDExOlB1bGxSZXF1ZXN0MTA0Mjg4NDkw,11,"Run faster, jump higher, teleport to coordinates (rather than XYZ position)",22650655,sbaum23,closed,0,,,,,2,2017-02-02T07:42:55Z,2017-02-03T20:59:39Z,2017-02-03T20:59:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/11,"These values are hardcoded and need to be replaced with actual values from the Player object.  This is mainly to let people run around faster in the emu until code it put in to send all player skills to client.

I'm Xen on Discord.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/11/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205040357,MDU6SXNzdWUyMDUwNDAzNTc=,12,Converting ACE to run as a Windows service,25518589,mcreedjr,closed,0,,,,,3,2017-02-03T00:36:14Z,2017-12-04T14:28:36Z,2017-12-04T14:28:36Z,CONTRIBUTOR,,,,"Envisioning how this server will eventually be run and/or deployed, I suspect that most would like the opportunity to have the server run as a Windows service. This will allow automated starting of ACE at Windows startup. This will require a separate monitoring application to monitor any ""console"" output. I offer this only from a sysadmin point of view who has an aversion to having to interactively start applications which others use. I'm not sure what architectural changes will be required, but thought it would be worth mentioning early in the development process.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/12/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205077117,MDExOlB1bGxSZXF1ZXN0MTA0NDc4ODUx,13,database layer encapsulation and abstraction,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-02-03T05:44:27Z,2017-02-04T05:55:04Z,2017-02-04T05:54:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/13,"Sorry about the solution file.  I'm on VS 2015 pro and I've no idea why it changed.  All I did was add the .gitignore as a solution item.

Use Visual Studio to diff the files.  Git isn't doing a good job with the compare.  Mogwai in Discord.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/13/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205270553,MDExOlB1bGxSZXF1ZXN0MTA0NjEyNDcz,14,Added /teleto command,22650655,sbaum23,closed,0,,,,,1,2017-02-03T21:12:15Z,2017-02-05T02:21:27Z,2017-02-05T02:21:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/14,My commit has the wrong command in it.  I added the /teleto command for teleporting using coordinates.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/14/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205301887,MDU6SXNzdWUyMDUzMDE4ODc=,15,Password storage should use PBKDF2,570040,zbuc,closed,0,570040,zbuc,,,0,2017-02-03T23:56:22Z,2017-10-24T22:59:59Z,2017-10-24T22:59:59Z,CONTRIBUTOR,,,,"Right now it's using salted SHA256, which works for now but isn't suitable for real password storage, taking into considerations things like password reuse across services and the fact that inexperienced server admins will likely be operating poorly configured ACEmulator servers.

To minimize the damage of leaking any password hashes from the DB, the supported standard for password storage on .NET is PBKDF2.

I am already working on converting password storage to use PBKDF2 on my branch.

https://dusted.codes/sha-256-is-not-a-secure-password-hashing-algorithm","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/15/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205326043,MDExOlB1bGxSZXF1ZXN0MTA0NjUwNTg2,16,database abstraction and encapsulation.  created character model and skill attribute models.,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-04T05:57:10Z,2017-02-04T06:42:11Z,2017-02-04T06:42:11Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/16,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/16/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205328952,MDExOlB1bGxSZXF1ZXN0MTA0NjUxOTE3,17,database encapsulation is done!  yay!,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-04T06:55:34Z,2017-05-30T15:34:08Z,2017-02-04T07:13:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/17,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/17/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205330194,MDExOlB1bGxSZXF1ZXN0MTA0NjUyNjE0,18,Option to Enable Automatic Account Creation,11369233,LtRipley36706,closed,0,,,,,2,2017-02-04T07:23:37Z,2017-03-20T02:59:13Z,2017-02-04T22:14:16Z,MEMBER,,0,ACEmulator/ACE/pulls/18,Added a configurable variable to Config.json for allowing the server to create an account for the client when one does not exist on the server.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/18/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205346915,MDU6SXNzdWUyMDUzNDY5MTU=,19,Support logging off to the character selection screen. ,25125434,TigrisOfGaul,closed,0,10608427,Mag-nus,,,1,2017-02-04T13:07:05Z,2017-06-22T07:59:06Z,2017-06-22T07:59:06Z,CONTRIBUTOR,,,,Currently the only way to log into the world with a different character is to restart the client. ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/19/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205353528,MDU6SXNzdWUyMDUzNTM1Mjg=,20,Server should have a way to apply DB migrations,570040,zbuc,closed,0,,,,,7,2017-02-04T15:19:26Z,2017-12-04T14:30:37Z,2017-12-04T14:30:36Z,CONTRIBUTOR,,,,"The server should have a way to track which DB migrations it has applied, and automatically apply missing ones in the correct order.

@Mag-nus suggested a naming convention of `YYYY_MM_DD_tablename.sql`. This would work, but would make dealing with pull requests and merges annoying, if multiple came in one day.

I would suggest a naming scheme more along the lines of `$patchNumber + '_' + $YYYY_MM_DD + '_' + $descriptiveFeatureName`, for example `01_2017_02_03_add_monster_information.sql` and not limiting them to any particular tables.

Picking the second naming system will make dealing with pull requests easier and help developers understand what updates are for. Additionally, the leading number provides a good way of tracking our schema revision.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/20/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205361124,MDExOlB1bGxSZXF1ZXN0MTA0NjY4MTI0,21,Change password hashing to use scrypt,570040,zbuc,closed,0,,,,,4,2017-02-04T17:28:50Z,2017-03-20T02:20:14Z,2017-03-20T02:20:14Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/21,"I switched the password hashing over to use libsodium's scrypt
implementation. This involved adding a new migration.

I noticed that currently the password isn't checked. I started looking
into how to implement password checking and it looks like we will
probably need to have a launcher to do so.

The reason the commit touches so many files is because it also cleans up
the files with mixed line endings.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/21/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205362379,MDExOlB1bGxSZXF1ZXN0MTA0NjY4ODA4,22,Teleloc loader fix and basic set of locations,10677293,ChrisAikman,closed,0,,,,,0,2017-02-04T17:48:51Z,2017-02-04T22:11:12Z,2017-02-04T22:11:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/22,"Fixed an index bug in `WorldDatabase.GetLocations` and added a basic set of telelocations to the `teleport_location` table for use with `teleloc`. Updated the `teleloc` command to accept multiple name locations, such as `Ayan Baqur`.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/22/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205377812,MDExOlB1bGxSZXF1ZXN0MTA0Njc1ODg4,23,Add Config.json to .gitignore,570040,zbuc,closed,0,,,,,1,2017-02-04T21:12:57Z,2017-02-04T22:53:44Z,2017-02-04T22:53:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/23,"This also forces first-time configuration.

Existing Config.json copied to Config.json.example

README.md has been updated with instructions.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/23/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205379026,MDExOlB1bGxSZXF1ZXN0MTA0Njc2NTYy,24,Fixed bug in CharacterCreate.,11369233,LtRipley36706,closed,0,,,,,0,2017-02-04T21:32:30Z,2017-02-17T06:50:27Z,2017-02-04T22:54:04Z,MEMBER,,0,ACEmulator/ACE/pulls/24, It was not changing the AccountId in the database when saving leading to empty character list.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/24/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205381602,MDExOlB1bGxSZXF1ZXN0MTA0Njc3ODA5,25,Option to Enable Automatic Account Creation,11369233,LtRipley36706,closed,0,,,,,1,2017-02-04T22:11:38Z,2017-03-20T02:59:21Z,2017-02-05T08:52:58Z,MEMBER,,0,ACEmulator/ACE/pulls/25,Added a configurable variable to Config.json for allowing the server to create an account for the client when one does not exist on the server.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/25/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205381707,MDExOlB1bGxSZXF1ZXN0MTA0Njc3ODY1,26,Fixing up Character Delete and Restore functions,11369233,LtRipley36706,closed,0,,,,,1,2017-02-04T22:13:24Z,2017-03-10T04:56:27Z,2017-02-05T09:03:41Z,MEMBER,,0,ACEmulator/ACE/pulls/26,"In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value
At present in master, even if that character was marked as deleted, the character name is held.

I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores.

As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client.

Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/26/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205383343,MDExOlB1bGxSZXF1ZXN0MTA0Njc4NjAw,27,Corrected spelling in a few places.,11369233,LtRipley36706,closed,0,,,,,0,2017-02-04T22:36:04Z,2017-02-05T03:35:03Z,2017-02-05T03:35:03Z,MEMBER,,0,ACEmulator/ACE/pulls/27,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/27/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205389442,MDU6SXNzdWUyMDUzODk0NDI=,28,Change way mysql databases are accessed,11369233,LtRipley36706,closed,0,,,,,1,2017-02-05T00:29:45Z,2017-02-05T04:28:54Z,2017-02-05T04:28:54Z,MEMBER,,,,"Should we be ""internalizing"" the connections to the mysql servers? Even with strong username/passwords is there as technical reason why we need to expose the sql server externally to the internet?","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/28/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205394658,MDExOlB1bGxSZXF1ZXN0MTA0Njg0NDkw,29,Teleto command redo,22650655,sbaum23,closed,0,,,,,1,2017-02-05T02:20:42Z,2017-02-05T06:01:09Z,2017-02-05T06:01:09Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/29,Fixed coding convention issues with my previous commit.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/29/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205398529,MDExOlB1bGxSZXF1ZXN0MTA0Njg2Mzk3,30,Fix for NAT issues on internal connections to WorldServer,11369233,LtRipley36706,closed,0,,,,,1,2017-02-05T03:53:57Z,2017-03-10T04:56:23Z,2017-02-05T05:37:01Z,MEMBER,,0,ACEmulator/ACE/pulls/30,"This should help alleviate the issue some people will see when configuring all IPs to external, but connecting to the server on internal IPs.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/30/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205400067,MDU6SXNzdWUyMDU0MDAwNjc=,31,"Logs should go to separate window, and filesystem",570040,zbuc,closed,0,,,,,4,2017-02-05T04:33:21Z,2017-05-01T15:13:20Z,2017-05-01T15:13:20Z,CONTRIBUTOR,,,,"Logs should go in a separate window from the main `ACE >>` command prompt so admins aren't frustrated with information stomping commands as they're being typed.

Might as well add a `Config.json` option to log them to the filesystem and set verbosity at the same time.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/31/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205403112,MDExOlB1bGxSZXF1ZXN0MTA0Njg4NzM0,32,Fix for NAT issues on internal connections to WorldServer,11369233,LtRipley36706,closed,0,,,,,1,2017-02-05T05:42:01Z,2017-03-10T04:56:20Z,2017-02-05T21:05:00Z,MEMBER,,0,ACEmulator/ACE/pulls/32,"This fix is meant help alleviate a NAT issue some people will see when configuring server IP to external address. 

Due to problematic NAT routing, connecting to external IP while on internal network leads to black screen on hand-off to world server. Others may not even be able to connect to server using external IP address.

This fix should allow for external IP connection for those outside of network, and internal IP connection for those inside the network.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/32/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205404593,MDExOlB1bGxSZXF1ZXN0MTA0Njg5NDQ3,33,Added /teleto command,22650655,sbaum23,closed,0,,,,,0,2017-02-05T06:16:08Z,2017-02-06T12:17:24Z,2017-02-06T12:17:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/33,"Z position needs to be calculated from a file but since that isn't in the code yet, I'm defaulting it to 200.  For some places that is not high enough and you'll be in darkness, but at least this allows you to teleport using coordinates.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/33/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205411721,MDExOlB1bGxSZXF1ZXN0MTA0NjkyODU2,34,Option to Enable Automatic Account Creation,11369233,LtRipley36706,closed,0,,,,,0,2017-02-05T08:52:31Z,2017-03-20T02:59:43Z,2017-02-07T17:42:22Z,MEMBER,,0,ACEmulator/ACE/pulls/34,Added a configurable variable to Config.json.example for allowing the server to create an account for the client when one does not already exist on the server.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/34/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205412246,MDExOlB1bGxSZXF1ZXN0MTA0NjkzMTA4,35,Fixing up Character Delete and Restore functions,11369233,LtRipley36706,closed,0,,,,,1,2017-02-05T09:03:13Z,2017-03-10T04:56:13Z,2017-02-11T05:46:23Z,MEMBER,,0,ACEmulator/ACE/pulls/35,"In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value
At present in master, even if that character was marked as deleted, the character name is held.

I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores.

As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json.example for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client.

Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/35/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205449659,MDExOlB1bGxSZXF1ZXN0MTA0NzEyNjY4,36,Add automatic database migrations to startup,570040,zbuc,closed,0,,,,,6,2017-02-05T20:02:19Z,2017-04-06T12:11:16Z,2017-04-06T12:11:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/36,"Database migrations will automatically be run.
Name them according to the format (`#_YYYY-MM-DD-descriptive_name.sql`)
and put in the appropriate directory and it will run on the next server
startup.

Migrations are only run once, in ascending numeric order. The current
database state is tracked in a new database called `Global`.

This simplifies server setup: now the only step is to create the four
databases. The base SQL and migrations will be run automatically from
that point on.

This also simplifies migrations, which will no longer need to
incorporate complex conditional logic in order to be repeatable.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/36/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205454231,MDExOlB1bGxSZXF1ZXN0MTA0NzE1MzE1,37,Add option to send different host address than external host address during world handoff,11369233,LtRipley36706,closed,0,,,,,2,2017-02-05T21:04:40Z,2017-03-10T04:56:11Z,2017-03-01T05:51:04Z,MEMBER,,0,ACEmulator/ACE/pulls/37,"The purpose of this code is to allow a server operator to configure their external IP for clients connecting from the internet as well as allowing clients connecting on the intranet to use the local network IP address of the server instead.

The options are configurable via config.json and set to false by default.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/37/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205468852,MDExOlB1bGxSZXF1ZXN0MTA0NzIzODky,38,Fix for server crash when account does not exist for connecting client,11369233,LtRipley36706,closed,0,,,,,0,2017-02-06T01:04:32Z,2017-02-07T16:49:41Z,2017-02-07T16:49:41Z,MEMBER,,0,ACEmulator/ACE/pulls/38,"Please use this PR if rejecting PR #34. this contains the fix to the server crash when an account is not created and a client tried to connect to the server using the invalid account.

this fix is already in PR #34 so if that one is accepted, reject this one.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/38/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205511107,MDU6SXNzdWUyMDU1MTExMDc=,39,Friends list functionality,22650655,sbaum23,closed,0,22650655,sbaum23,,,0,2017-02-06T08:04:22Z,2017-02-18T04:46:34Z,2017-02-18T04:46:34Z,CONTRIBUTOR,,,,"+ Persist/read friends from db table
+ Send full friends list on login
+ Respond to Add friend client message
+ Respond to Remove friend client message

Likely not able to add yet until multiplayer support added:
+ When player logs on or off, send friend status update to their friends.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/39/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205511450,MDExOlB1bGxSZXF1ZXN0MTA0NzUxMzMx,40,Adding in support for teleportation via clicking on the map panel.,11369233,LtRipley36706,closed,0,,,,,0,2017-02-06T08:06:40Z,2017-02-06T12:12:46Z,2017-02-06T12:12:46Z,MEMBER,,0,ACEmulator/ACE/pulls/40,Go places faster!,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/40/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205579650,MDU6SXNzdWUyMDU1Nzk2NTA=,41,Basic Player Item Functionality,6111341,Rawaho,closed,0,,,,,1,2017-02-06T13:12:45Z,2017-12-04T14:29:14Z,2017-12-04T14:29:14Z,CONTRIBUTOR,,,,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/41/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205637204,MDU6SXNzdWUyMDU2MzcyMDQ=,42,Subscription data model concept + GLS replacement,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,1,2017-02-06T16:28:44Z,2017-10-24T22:59:32Z,2017-10-24T22:59:32Z,CONTRIBUTOR,,,,"Login == account
retail ""AC account"" == subscription (under the hood, as Turbine did it)
subscription == a set of characters on worlds

Old/retail paradigm: 1 login for every subscription
New paradigm: 1 master login, select a subscription

This will entail building a set of REST services and a new launcher with Thwargle.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/42/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205645250,MDU6SXNzdWUyMDU2NDUyNTA=,43,Move Database Access and object models to a separate C# project,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,2,2017-02-06T16:55:25Z,2017-02-16T03:26:54Z,2017-02-16T03:26:54Z,CONTRIBUTOR,,,,"for reuse in other components such as:
* Item Editor
* Vendor Editor
* GLS replacment
* other Server Admin tools","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/43/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205646390,MDU6SXNzdWUyMDU2NDYzOTA=,44,Add column to authenticationDB.account for access rights,11369233,LtRipley36706,closed,0,11369233,LtRipley36706,,,3,2017-02-06T16:59:10Z,2017-02-20T05:10:32Z,2017-02-20T05:10:32Z,MEMBER,,,,Need to add a column for access rights so to allow accounts to be able to create characters with IsAdmin or IsEnvoy bools set.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/44/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205647107,MDU6SXNzdWUyMDU2NDcxMDc=,45,Stub CommandHandlers for in-game commands,11369233,LtRipley36706,closed,0,11369233,LtRipley36706,,,1,2017-02-06T17:01:31Z,2017-04-23T18:14:09Z,2017-04-23T18:14:09Z,MEMBER,,,,"Create stubs for each @ command in-game with expected usage and output comments.

This should help prevent commands not working the way they did originally","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/45/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205742481,MDExOlB1bGxSZXF1ZXN0MTA0OTA3NjM3,46,Update create_mysql.sql,25277356,KochiroOfHG,closed,0,,,,,0,2017-02-06T23:46:04Z,2017-02-12T11:36:42Z,2017-02-12T11:36:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/46,"Added ""IF NOT EXISTS"" to the create statements so that if the database already exists then a warning will be thrown instead of an error.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/46/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205792049,MDExOlB1bGxSZXF1ZXN0MTA0OTQwNjI2,47,Load saved characters,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-02-07T05:43:40Z,2017-05-30T15:34:10Z,2017-02-07T16:49:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/47,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/47/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
205882576,MDU6SXNzdWUyMDU4ODI1NzY=,48,Add all other properties to Character persistence model,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,1,2017-02-07T13:09:34Z,2017-02-10T19:06:40Z,2017-02-10T19:06:40Z,CONTRIBUTOR,,,,"All the other things that go in the property buckets.  Read from client on char create (or not, as the augments should all be unset), save to the DB, and load them up on login.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/48/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
205882786,MDU6SXNzdWUyMDU4ODI3ODY=,49,XP expenditure on skills/stats,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,1,2017-02-07T13:10:24Z,2017-02-10T19:06:01Z,2017-02-10T19:06:01Z,CONTRIBUTOR,,,,"Spend unused xp on skills/stats, save to database.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/49/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
206401863,MDExOlB1bGxSZXF1ZXN0MTA1MzU4NDQ2,50,"Spending XP in Abilities, Vitals, and Skills, Saving Property buckets…",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-09T04:35:43Z,2017-05-30T15:34:11Z,2017-02-10T18:44:23Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/50,"….  /grantxp command, moved persistence out of Player object for later refactoring of entity and data access project.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/50/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
206403228,MDU6SXNzdWUyMDY0MDMyMjg=,51,Saving a Character to the DB,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,5,2017-02-09T04:47:27Z,2017-03-20T02:53:25Z,2017-03-20T02:53:25Z,CONTRIBUTOR,,,,intermittently?  on logout?  by command?  something,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/51/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
206403292,MDU6SXNzdWUyMDY0MDMyOTI=,52,Leveling up when granted xp,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,2,2017-02-09T04:47:53Z,2017-03-20T02:54:03Z,2017-03-20T02:54:03Z,CONTRIBUTOR,,,,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/52/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
206403348,MDU6SXNzdWUyMDY0MDMzNDg=,53,"Skill Credits: saving, loading, spending",25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,2,2017-02-09T04:48:15Z,2017-03-20T14:32:29Z,2017-03-20T14:31:26Z,CONTRIBUTOR,,,,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/53/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
206407101,MDExOlB1bGxSZXF1ZXN0MTA1MzYxMzA3,54,Added friends list functionality.,22650655,sbaum23,closed,0,,,,,1,2017-02-09T05:14:37Z,2017-02-17T08:00:32Z,2017-02-17T08:00:32Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/54,"Friends load from database on login and add/removing friends also saves to the db.  When a friend logs on, the player should see the status change to online but it's hard to test that completely right now.  Changing the status to offline when a friend logs off is not yet implemented.

I had to implement a couple methods in WorldManager to be able to query for connected clients.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/54/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
206410568,MDExOlB1bGxSZXF1ZXN0MTA1MzYzMzQ2,55,Stubbed CommandHandlers for known AdminCommands,11369233,LtRipley36706,closed,0,,,,,2,2017-02-09T05:41:21Z,2017-02-17T06:50:21Z,2017-02-17T06:30:40Z,MEMBER,,0,ACEmulator/ACE/pulls/55,Stubbed known admin commands with expected usage. not all could eventually be needed. Some could example output could also be expanded upon.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/55/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
206955987,MDU6SXNzdWUyMDY5NTU5ODc=,56,Background maintenance thread,25125434,TigrisOfGaul,closed,0,,,,,1,2017-02-11T04:03:13Z,2017-07-26T16:50:59Z,2017-07-26T16:50:59Z,CONTRIBUTOR,,,,We need some sort of low priority thread to run and periodically perform routine maintenance tasks such as removing characters marked for deletion.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/56/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
206960724,MDExOlB1bGxSZXF1ZXN0MTA1NzQzMDQy,57,Fixing up Character Delete and Restore functions,11369233,LtRipley36706,closed,0,,,,,2,2017-02-11T05:45:56Z,2017-02-17T06:50:19Z,2017-02-16T05:17:24Z,MEMBER,,0,ACEmulator/ACE/pulls/57,"In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value
At present in master, even if that character was marked as deleted, the character name is held.

I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores.

As is, no character is ever marked deleted so that is yet to be implemented, although I suspect that would be a server side SQL script or command within ACE running at an interval/manually via console as determined by a configuration variable(s) possibly in config.json.example for how often it checks, how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client.

Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/57/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
207015535,MDExOlB1bGxSZXF1ZXN0MTA1NzcxODA1,58,Added support on ACE console for setting per character admin rights and character renaming,11369233,LtRipley36706,closed,0,,,,,2,2017-02-11T23:19:23Z,2017-03-10T04:56:08Z,2017-03-09T07:44:47Z,MEMBER,,0,ACEmulator/ACE/pulls/58,"Also included in this PR is a fix for the propertybools (IsAdmin, etc) not always being set from database when a character logs in.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/58/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
207021510,MDExOlB1bGxSZXF1ZXN0MTA1Nzc1MjI4,59,Handle setting title from client and updating title from server,25618389,LytelthorpeThistledown,closed,0,,,,,0,2017-02-12T01:28:07Z,2017-02-16T03:21:35Z,2017-02-16T03:21:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/59,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/59/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
207255861,MDExOlB1bGxSZXF1ZXN0MTA1OTE5NTYy,60,Added automation script for dropping and creating databases.,4389226,damnubber,closed,0,,,,,0,2017-02-13T15:46:59Z,2017-02-16T03:16:56Z,2017-02-16T03:16:56Z,NONE,,0,ACEmulator/ACE/pulls/60,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/60/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
207414071,MDExOlB1bGxSZXF1ZXN0MTA2MDMyNjEw,61,project separation and xp chart files,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-14T04:18:31Z,2017-05-30T15:34:11Z,2017-02-16T03:04:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/61,implements #43 and also moves all that xp chart data into json files loaded behind a database interface.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/61/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
207544982,MDExOlB1bGxSZXF1ZXN0MTA2MTI1NjQy,62,just adding stylecop as a style ruleset with very basic stuff,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-14T15:19:35Z,2017-05-30T15:34:12Z,2017-02-16T03:14:13Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/62,the team can review the options and make changes as necessary.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/62/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
207616123,MDU6SXNzdWUyMDc2MTYxMjM=,63,Save & reload window positioning,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-14T19:42:36Z,2017-07-26T16:50:45Z,2017-07-26T16:50:45Z,CONTRIBUTOR,,,,"Chat window(s), character info / inventory panel, etc.

Logging this as people are constantly asking for stuff that can be done.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/63/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
208003996,MDExOlB1bGxSZXF1ZXN0MTA2NDQ4MzI3,64,fixing merge conflict,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-16T03:26:33Z,2017-02-16T03:26:38Z,2017-02-16T03:26:38Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/64,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/64/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208004873,MDExOlB1bGxSZXF1ZXN0MTA2NDQ4ODAw,65,copy config.json as build step,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-16T03:32:21Z,2017-02-16T03:32:25Z,2017-02-16T03:32:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/65,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/65/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208019575,MDExOlB1bGxSZXF1ZXN0MTA2NDU2NjQz,66,Fixing up Character Delete and Restore functions,11369233,LtRipley36706,closed,0,,,,,0,2017-02-16T05:16:36Z,2017-02-17T06:49:36Z,2017-02-17T01:38:08Z,MEMBER,,0,ACEmulator/ACE/pulls/66,"In looking at the character deletion and restore section it made sense to me that name in character database shouldn't be made a unique value
At present in master, even if that character was marked as deleted, the character name is held.

I've made changes to the code and database to better emulate how it worked before with respect to deletions and restores.

As is, character is marked deleted in database an hour after deleted from client via a server side SQL script running from event_scheduler.  Later revisions to this code could address configuration variable(s) possibly in config.json.example for how long the restore window is and if to mark characters deleted or not which would remove them from restoration via client, enable/disable this event check etc..

Going further than original design, perhaps it could be changed to hold the character name for that account only while the restoration window is active, as well as only allowing that account to create a brand new character with that deleted name.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/66/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208349568,MDExOlB1bGxSZXF1ZXN0MTA2Njc1NzU5,67,Stubbed CommandHandlers for known AdminCommands,11369233,LtRipley36706,closed,0,,,,,0,2017-02-17T06:30:16Z,2017-02-17T06:49:40Z,2017-02-17T06:36:23Z,MEMBER,,0,ACEmulator/ACE/pulls/67,Stubbed known admin commands with expected usage. not all could eventually be needed. Some example output could also be expanded upon as needed.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/67/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208352404,MDExOlB1bGxSZXF1ZXN0MTA2Njc3Mjcy,68,Fix for LoadCharacterProperties,11369233,LtRipley36706,closed,0,,,,,0,2017-02-17T06:47:15Z,2017-02-17T06:49:45Z,2017-02-17T06:47:29Z,MEMBER,,0,ACEmulator/ACE/pulls/68,"The PropertiesBools doesn't always get set on character upon login, this change should correct that issue.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/68/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208364550,MDExOlB1bGxSZXF1ZXN0MTA2Njg0MzU2,69,Friends List,22650655,sbaum23,closed,0,,,,,0,2017-02-17T07:58:52Z,2017-02-18T04:38:34Z,2017-02-18T04:38:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/69,"Adds the ability to add/remove friends as well as see the list of friends when you log on.  The status is also accurate and will change as friends log on/off.  I added a Logout method to the Player class for putting stuff in there that needs to be done when a player logs off (like sending a packet to all your online friends that you are offline).

The extra commits are due to rebasing.

This resolves issue #39.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/69/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208542386,MDExOlB1bGxSZXF1ZXN0MTA2ODAyODE1,70,"code cleanup, plus introduction of a couple new world object heirarchy types",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-17T20:06:05Z,2017-05-30T15:34:17Z,2017-02-17T20:20:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/70,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/70/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208612243,MDExOlB1bGxSZXF1ZXN0MTA2ODQ4MTI1,71,Issue 39 friends list,22650655,sbaum23,closed,0,,,,,0,2017-02-18T04:40:22Z,2017-02-18T04:46:34Z,2017-02-18T04:46:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/71,Resolves #39 ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/71/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208614354,MDU6SXNzdWUyMDg2MTQzNTQ=,72,Additional Friends Commands and Appear Offline,22650655,sbaum23,closed,0,22650655,sbaum23,,,0,2017-02-18T05:29:14Z,2017-02-18T13:14:26Z,2017-02-18T13:14:26Z,CONTRIBUTOR,,,,"Implement the following @friends commands:

1. @friends remove -all
2. @friends old (show a message that this command is no longer used)

Also implement the ""Appear Offline"" option so that it shows you as offline to your friends.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/72/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
208616825,MDExOlB1bGxSZXF1ZXN0MTA2ODUwMjA5,73,Network Refactor,12808515,Zegeger,closed,0,,,,,2,2017-02-18T06:02:43Z,2017-02-18T15:08:24Z,2017-02-18T15:08:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/73,"Created GameMessage class.  Currently GameEvent inherits from
GameMessage.
GameMessage just build MemoryStream for message.
Moved all opcodes that are outside of GameEvent in protocol over to be a
GameMessage.
Created some basic (test) functions in NetworkManager to send the
GameMessages.
Lots more to do, but this compiles and logs in successfully.
Need to move group to per message property.
Need to create per session packet queue.
Need to rewrite packet pipe to better process multifragment packets.
Need to finish testing multifragment packets and get working.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/73/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208624156,MDExOlB1bGxSZXF1ZXN0MTA2ODUzNzQw,74,"Implemented ""/friends remove -all"", ""/friends old"" and Appear Offline.",22650655,sbaum23,closed,0,,,,,0,2017-02-18T08:15:49Z,2017-02-18T13:14:27Z,2017-02-18T13:14:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/74,"/friends old just sends a chat packet saying that the command isn't used in the emu.

I also had to fix a bug in two WorldManager methods that I added in an earlier PR.  There was a scenario where the Session.Player was null and it was causing the LINQ query to throw an exception.

Appear Offline is actually part of a GameAction that is used for setting many different options.  The Handle method for it now just has a switch in it (there are ~52 options) for now but we may want to go to something else in the future as we add new features.

Resolves #72 ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/74/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208651560,MDExOlB1bGxSZXF1ZXN0MTA2ODY2ODY0,75,Fixed update .sql file names to conform to documented standard.,10608427,Mag-nus,closed,0,,,,,0,2017-02-18T16:20:28Z,2017-02-18T16:20:49Z,2017-02-18T16:20:49Z,MEMBER,,0,ACEmulator/ACE/pulls/75,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/75/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208656503,MDExOlB1bGxSZXF1ZXN0MTA2ODY5NjIw,76,Reworked Appear Offline functionality,22650655,sbaum23,closed,0,,,,,1,2017-02-18T17:33:27Z,2017-02-20T05:17:46Z,2017-02-20T05:17:46Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/76,"Reworked appear offline functionality so that it doesn't change IsOnline, which other things might depend on.

Also fixed issue with sending friends list updates that was introduced with the network refactor merge.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/76/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208701617,MDExOlB1bGxSZXF1ZXN0MTA2ODkyMzg3,77,Add AccessLevel to Accounts,11369233,LtRipley36706,closed,0,,,,,3,2017-02-19T07:51:49Z,2017-02-20T05:30:22Z,2017-02-20T05:09:09Z,MEMBER,,0,ACEmulator/ACE/pulls/77,"This addresses issue #44 and also contains some of PR #58 rolled in. 

Of note, CommandManager will now respect AccessLevels specified where previously it didn't care.

Set-AccountAccess will set the account's accesslevel
Set-CharacterAccess will set the character's accesslevel

CommandManager only cares about character's accesslevel as of this PR. Per discussion with @Mogwai-AC  I think we should code up a SUDO like command which then references to Account's AccessLevel for privileges. This way we emulate how it seemed to work on AC live (per character) in addition to then allowing accounts to self-promote characters, as they did with the admin button on character creation, as well as other admin functions on non-admin characters. 

Probably something along the lines of ""SUDO set-characteraccess [mynewcharacter] sentinel"" which just does a check back to session.accesslevel.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/77/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208755889,MDExOlB1bGxSZXF1ZXN0MTA2OTIyMTI5,78,"Chat enums added. Say/Tell work, but names not clickable. Network Mes…  …sage framework cosmetic cleanups.",10608427,Mag-nus,closed,0,,,,,0,2017-02-19T23:26:00Z,2017-02-19T23:27:05Z,2017-02-19T23:27:04Z,MEMBER,,0,ACEmulator/ACE/pulls/78,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/78/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208787114,MDExOlB1bGxSZXF1ZXN0MTA2OTQxODgz,79,Fixing changes to Fragment and Session.,11369233,LtRipley36706,closed,0,,,,,0,2017-02-20T05:27:58Z,2017-02-20T05:30:11Z,2017-02-20T05:28:12Z,MEMBER,,0,ACEmulator/ACE/pulls/79,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/79/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
208972136,MDU6SXNzdWUyMDg5NzIxMzY=,80,Saving and Loading Character Options,22650655,sbaum23,closed,0,22650655,sbaum23,,,0,2017-02-20T20:10:20Z,2017-03-02T13:51:44Z,2017-03-02T13:51:44Z,CONTRIBUTOR,,,,"1. Save options in the database
2. Load options from the database
3. Send options in the GameEventPlayerDescription packet
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/80/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
209030863,MDExOlB1bGxSZXF1ZXN0MTA3MTA4NjM1,81,Changed Find fn's in WorldManager from InWorld to IsOnline.. fixed pl…,10608427,Mag-nus,closed,0,,,,,0,2017-02-21T03:11:14Z,2017-02-21T03:11:34Z,2017-02-21T03:11:34Z,MEMBER,,0,ACEmulator/ACE/pulls/81,"…ayer GUID, added GameEventDisplay events.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/81/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
209050525,MDExOlB1bGxSZXF1ZXN0MTA3MTIyMjYx,82,Changed ParseCommand to support the use of quotes,11369233,LtRipley36706,closed,0,,,,,0,2017-02-21T06:06:33Z,2017-02-27T15:07:24Z,2017-02-21T12:31:10Z,MEMBER,,0,ACEmulator/ACE/pulls/82,"This change allows any command to work with quotes to better delimit some parameters.

An example of this would be for commands that require the use of a character name which has spaces in it such as Maia the Lawyer. 

The change results in the following command working as expected:

set-characteraccess ""maia the laywer"" admin

Another example this change would fix would be the eventual problem with teleto which it gets wired-up.
Without the change, the command reads like teleto maia the laywer and would try to teleport to the character named maia instead of the full name. teleto ""maia the lawyer"" then corrects this issue and finds the right player.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/82/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
209201688,MDU6SXNzdWUyMDkyMDE2ODg=,83,Add message buffering and send as multifragment packet,12808515,Zegeger,closed,0,12808515,Zegeger,,,1,2017-02-21T16:38:59Z,2017-02-27T14:41:27Z,2017-02-27T14:41:26Z,CONTRIBUTOR,,,,"Continue reworking network pipe to support message buffering and flushing from Session.Update to send as a multifragment packet.
 - NetworkBuffer class to queue messages during a timeslice
 - NetworkBuffer will have a current NetworkBundle which will contain all messages and optional flags.
 - On a session update, create new NetworkBundle and use the previous one to send packets.
 - Move certain packet flag responses (Echo, TimeSync, etc) to be sent with a NetworkBundle.
 - Create NetworkManager function to send a NetworkBundle, splitting large messages into two packets, or combining multiple messages into one packet.
 - - This function should take a NetworkBundle and create packets and fragments as appropriate to send all messages.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/83/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
209354215,MDExOlB1bGxSZXF1ZXN0MTA3MzM2NDQ4,84,"Skill spend upper bound check too prevent xp crash, also Max Skills!",37453,fantoms,closed,0,,,,,5,2017-02-22T05:09:25Z,2017-03-02T13:03:44Z,2017-03-02T13:03:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/84,"Added an Ability and Skill check in Source/ACE/Entity/Player.cs, too attempt in preventing server from crashing when spending XP points.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/84/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
209752794,MDExOlB1bGxSZXF1ZXN0MTA3NjE4MjA1,85,Network Channels + Player Effect to Test @effect 20,25387933,Forbiddenz,closed,0,,,,,0,2017-02-23T12:51:12Z,2017-02-23T13:41:57Z,2017-02-23T13:41:57Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/85,"Forgive my get newb..

I added a method of picking your channels on each message type..

Example of creating a message with channel can be found..
```
public class GameMessageEffect : GameMessageOnChannel

//using the ChannelMessages.
        //plays particle effect like spell casting or bleed etc..
        public void PlayParticleEffect(uint effectid)
        {
            var effectevent = new GameMessageEffect(this.Guid, effectid);
            NetworkManager.SendWorldChannelMessages(Session, new GameMessageOnChannel[] { effectevent });
        }
```","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/85/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
209787790,MDExOlB1bGxSZXF1ZXN0MTA3NjQyOTEy,86,Group chat code added. Chat channels are currently hard coded. Chat i…,10608427,Mag-nus,closed,0,,,,,0,2017-02-23T15:06:27Z,2017-02-23T15:06:44Z,2017-02-23T15:06:44Z,MEMBER,,0,ACEmulator/ACE/pulls/86,"…s sent to all players, even if they aren't subscribed to a channel.

Updated StatusMessageType enums. They need work still.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/86/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
209859327,MDExOlB1bGxSZXF1ZXN0MTA3Njk0Nzcy,87,DO NOT MERGE - for reviewing work in progress only,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-02-23T19:27:26Z,2017-02-24T02:57:35Z,2017-02-24T02:57:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/87,"work in progress, committing for others to review","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/87/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210208094,MDExOlB1bGxSZXF1ZXN0MTA3OTQ1MDM1,88,"DDD stub code, AllegianceUpdate stub, IdentifyObject stub",10608427,Mag-nus,closed,0,,,,,0,2017-02-25T03:51:39Z,2017-02-25T03:51:52Z,2017-02-25T03:51:52Z,MEMBER,,0,ACEmulator/ACE/pulls/88,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/88/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210217121,MDExOlB1bGxSZXF1ZXN0MTA3OTUwNDcz,89,Corrected Teleloc command to work with exact numbers,11369233,LtRipley36706,closed,0,,,,,0,2017-02-25T07:05:25Z,2017-02-26T06:03:15Z,2017-02-25T12:39:27Z,MEMBER,,0,ACEmulator/ACE/pulls/89, as provided by /loc command from client.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/89/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210217148,MDExOlB1bGxSZXF1ZXN0MTA3OTUwNDg4,90,Rewrote network stack,12808515,Zegeger,closed,0,,,,,3,2017-02-25T07:06:09Z,2017-02-27T11:28:37Z,2017-02-27T11:28:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/90,"Rewrote network stack to support buffering messages and then dispatching as 1 or more combined or split packets.  EncryptedChecksum seems to work across the board.  Sending Packets with fragments from different groups does not seem to cause an issue.
Packets are queued and sent based on calls from the Engine.  Configurable delay (5ms currently)
Reworked CachedPackets some, and now clear the list based on AckSeq packets from client.  Sending AckSeq packets to the client seems to cause issues currently, need more testing.
Moved some things around to fit this new model.
Put message Group as a property on each message. And send this in fragment.  Sounds now work again.
Created new packet classes to encapsulate data in AuthenticationManager and CharacterManager and allow them to be send through the same model (though packets will never be manipulated).
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/90/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210239879,MDU6SXNzdWUyMTAyMzk4Nzk=,91,StatusMessageType1 and StatusMessageType2 values need descriptive names,10608427,Mag-nus,closed,0,,,,,2,2017-02-25T15:06:49Z,2018-02-12T18:57:55Z,2018-02-12T18:57:37Z,MEMBER,,,,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/91/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
210289130,MDExOlB1bGxSZXF1ZXN0MTA3OTkyMTIw,92,Add in support for the old global Admin channels,11369233,LtRipley36706,closed,0,,,,,1,2017-02-26T06:00:53Z,2017-02-27T15:04:42Z,2017-02-27T14:38:23Z,MEMBER,,0,ACEmulator/ACE/pulls/92,"Resurrected the various Admin global channels used by the Advocates, Sentinels, Envoys, and Admins, stubbed the @on and @off commands and added support for @index and @clist commands.

Some TODOs have been put into the code for when we get a plan in place for for db loading/saving of channel subscriptions, as well as properly set subscriptions for that matter.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/92/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210350061,MDExOlB1bGxSZXF1ZXN0MTA4MDIyODE3,93,Support easy permissions in ACEmulator,11369233,LtRipley36706,closed,0,,,,,1,2017-02-26T21:25:56Z,2017-02-27T15:04:36Z,2017-02-27T13:51:26Z,MEMBER,,0,ACEmulator/ACE/pulls/93,"Improved best of both worlds scenario.

Server operators have the choice to emulate access permissions via more complicated system used on official worlds or they can choose to use simplified account based permissions which would become the default install option for ACEmulator.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/93/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210488807,MDExOlB1bGxSZXF1ZXN0MTA4MTE3NjQw,94,Support easy permissions in ACEmulator,11369233,LtRipley36706,closed,0,,,,,0,2017-02-27T13:51:09Z,2017-02-27T15:04:32Z,2017-02-27T14:04:24Z,MEMBER,,0,ACEmulator/ACE/pulls/94,"Improved best of both worlds scenario.

Server operators have the choice to emulate access permissions via more complicated system used on official worlds or they can choose to use simplified account based permissions which would become the default install option for ACEmulator.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/94/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210501772,MDExOlB1bGxSZXF1ZXN0MTA4MTI2NTQy,95,Add in support for the old global Admin channels,11369233,LtRipley36706,closed,0,,,,,0,2017-02-27T14:37:58Z,2017-02-27T15:04:28Z,2017-02-27T14:49:37Z,MEMBER,,0,ACEmulator/ACE/pulls/95,"Resurrected the various Admin global channels used by the Advocates, Sentinels, Envoys, and Admins, stubbed the @on and @off commands and added support for @index and @clist commands.

Some TODOs have been put into the code for when we get a plan in place for for db loading/saving of channel subscriptions, as well as properly set subscriptions for that matter.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/95/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210534535,MDU6SXNzdWUyMTA1MzQ1MzU=,96,Broadcasting chat to appropriate scope and loading landblocks,25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,0,2017-02-27T16:27:03Z,2017-03-20T14:31:11Z,2017-03-20T14:31:11Z,CONTRIBUTOR,,,,"placeholder issue for what i'm working on, really","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/96/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
210686564,MDExOlB1bGxSZXF1ZXN0MTA4MjU4Mjkx,97,Fix Account.Salt not being stored in DB,11369233,LtRipley36706,closed,0,,,,,0,2017-02-28T04:51:54Z,2017-03-01T06:05:39Z,2017-02-28T14:46:45Z,MEMBER,,0,ACEmulator/ACE/pulls/97,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/97/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210694590,MDExOlB1bGxSZXF1ZXN0MTA4MjYzOTI2,98,Correcting a few bugs with ChatChannel,11369233,LtRipley36706,closed,0,,,,,0,2017-02-28T05:59:37Z,2017-03-01T06:05:35Z,2017-02-28T13:24:10Z,MEMBER,,0,ACEmulator/ACE/pulls/98,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/98/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210974260,MDExOlB1bGxSZXF1ZXN0MTA4NDYzODEw,99,Character options are saving/loading from database.,22650655,sbaum23,closed,0,,,,,0,2017-03-01T04:04:17Z,2017-03-02T12:51:03Z,2017-03-02T12:51:03Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/99,Resolves issue #80 ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/99/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
210986292,MDExOlB1bGxSZXF1ZXN0MTA4NDcyMDY3,100,Option to send Internal IP as World Host to client,11369233,LtRipley36706,closed,0,,,,,0,2017-03-01T05:50:28Z,2017-03-06T06:38:50Z,2017-03-02T12:51:47Z,MEMBER,,0,ACEmulator/ACE/pulls/100,"Allows a server operator to configure their external IP for clients connecting from the internet as well as allowing clients connecting on the intranet to use the local network IP address of the server remaining on local network instead of going out to come back in.

The options are configurable via config.json and set to false by default.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/100/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211191210,MDExOlB1bGxSZXF1ZXN0MTA4NjE2NDIz,101,World object - Seralization with Example,25387933,Forbiddenz,closed,0,,,,,0,2017-03-01T19:59:23Z,2017-03-01T21:05:52Z,2017-03-01T21:05:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/101,"World Object with Example @spawntest.
This will only work one time because ACE dont have any real way to increment guids properly.
Still could use some cleanup, but this is a great start and very useful so I am PRing it now.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/101/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211242008,MDExOlB1bGxSZXF1ZXN0MTA4NjUzMzcy,102,World object - Improvement + Lifestone Test Object,25387933,Forbiddenz,closed,0,,,,,0,2017-03-01T23:28:15Z,2017-03-02T22:47:00Z,2017-03-02T12:55:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/102,"Use @spawntest to spawn a life stone.

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/102/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211490314,MDExOlB1bGxSZXF1ZXN0MTA4ODMxMjM4,103,Quick fixes 03022017,11369233,LtRipley36706,closed,0,,,,,0,2017-03-02T19:21:20Z,2017-03-02T20:08:23Z,2017-03-02T20:08:23Z,MEMBER,,0,ACEmulator/ACE/pulls/103,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/103/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211502816,MDExOlB1bGxSZXF1ZXN0MTA4ODQwNDU4,104,portal.dat and cell.dat loading (issue #3),25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-03-02T20:09:02Z,2017-05-30T15:34:36Z,2017-03-04T12:59:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/104,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/104/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211561301,MDExOlB1bGxSZXF1ZXN0MTA4ODgzMTEx,105,More WorldObject Fixes,11369233,LtRipley36706,closed,0,,,,,0,2017-03-03T00:32:57Z,2017-03-04T10:27:26Z,2017-03-03T14:05:09Z,MEMBER,,0,ACEmulator/ACE/pulls/105,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/105/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211886644,MDExOlB1bGxSZXF1ZXN0MTA5MTExNTA5,106,Continuing SO's WorldObject rework,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-03-04T15:39:17Z,2017-05-30T15:34:35Z,2017-03-06T12:33:26Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/106,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/106/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
211999671,MDExOlB1bGxSZXF1ZXN0MTA5MTc0Mzc1,107,Add DAT loading into main process,10137,ghost,closed,0,,,,,3,2017-03-06T00:43:14Z,2017-10-18T14:07:36Z,2017-03-07T01:30:51Z,NONE,,0,ACEmulator/ACE/pulls/107,Obtains the two DAT file locations from the config.json file.  Code also handles file not found exceptions and prints out an error.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/107/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212027453,MDExOlB1bGxSZXF1ZXN0MTA5MTkyMzk2,108,Time returns to Dereth,11369233,LtRipley36706,closed,0,,,,,0,2017-03-06T05:28:29Z,2017-03-10T04:55:10Z,2017-03-07T01:29:35Z,MEMBER,,0,ACEmulator/ACE/pulls/108,"Rain rain go away...

Added time to Dereth. Once the server starts, the clock is set and is hardcoded at this point to start at the current Lore corrected DerethDateTime. 

@time command wired up.

Time progresses as it did on retail and does not reset in between sessions as long as server remains running.

There are several functions within DerethDateTime that could help enable some interesting ideas in the future such as ""dynamic seasons"" and changing spawns based on TimeOfDay (like Graveyard) for examples. It would depend on if we're able to build in time-checking logic to spawnable/generator objects, which I assume we would be doing, especially once we get around to rebuilding the GY area.

TODO: Save the progression of ServerTime periodically to be recalled when server is offline'd/online'd.
TODO: Setup a variable in Config.json and ConfigManager to allow the server operator to pick a date to start the server from.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/108/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212215798,MDExOlB1bGxSZXF1ZXN0MTA5MzI0Mjc1,109,World Object Fix,25387933,Forbiddenz,closed,0,,,,,1,2017-03-06T18:55:41Z,2017-03-06T22:38:36Z,2017-03-06T22:38:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/109,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/109/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212240568,MDExOlB1bGxSZXF1ZXN0MTA5MzQyMDY2,110,A fix to Prevent Skill Spend server crash and allow for max Ranked Skills (Infinity!),37453,fantoms,closed,0,,,,,0,2017-03-06T20:30:18Z,2017-03-07T01:29:18Z,2017-03-07T01:29:18Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/110,"- Renamed abilityUpdate to skillUpdate, to reflect the correct function/variables.

- Refactored the SpendXp skills function to send a gamemessage on failed skill updates that prevents client from locking up the Rank Up interface buttons.

- Added an upper-bounds check to prevent skills from going out of bounds.

- Created an offset variable to prevent +10 from going out of bounds when the rank is to high.

- Changed the comment describing known issues on skillSpend","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/110/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212274507,MDExOlB1bGxSZXF1ZXN0MTA5MzY3MDc2,111,Life stone Fix = World Object Fix Usable,25387933,Forbiddenz,closed,0,,,,,0,2017-03-06T22:47:12Z,2017-03-07T09:40:25Z,2017-03-07T01:31:04Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/111,Adding proper flags to World Object Usable.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/111/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212324458,MDExOlB1bGxSZXF1ZXN0MTA5NDAyNDkw,112,Save default character options when creating a character.,22650655,sbaum23,closed,0,,,,,0,2017-03-07T04:00:31Z,2017-03-07T13:14:03Z,2017-03-07T13:14:03Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/112,"When creating a character this will set several character options to true and save to the database.

The options set to true are the same ones when you click the ""Default"" button in the options tab.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/112/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212333121,MDExOlB1bGxSZXF1ZXN0MTA5NDA4MzQz,113,Max Rank Fireworks and Correct Skill Rank Up text Color,37453,fantoms,closed,0,,,,,0,2017-03-07T05:17:04Z,2017-05-23T15:53:42Z,2017-03-07T13:45:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/113,"- I could not find a way to check the skill rank after it was set, so I added a function to check max rank. If the function returns a Boolean true, then the server will play fireworks when reached max rank

- Changed the message type to Advancement when increasing skills too reflect the correct skill advancement chat color.

- Added a few summary comments and fixed remarks/known issues.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/113/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212898925,MDExOlB1bGxSZXF1ZXN0MTA5ODE0OTQ4,114,Added GetClientCommands and GetConsoleCommands,25650194,Thwargle,closed,0,,,,,0,2017-03-09T00:22:27Z,2017-03-15T19:04:45Z,2017-03-15T19:04:45Z,NONE,,0,ACEmulator/ACE/pulls/114,"Added the ability to request a list of console commands and client commands from the console.
Added the ability to request a list of client commands from the game's chat window.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/114/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212905393,MDExOlB1bGxSZXF1ZXN0MTA5ODE5NTcw,115,Add host & port to connect messages,26289176,Zorgle,closed,0,,,,,0,2017-03-09T01:04:31Z,2017-03-09T01:26:45Z,2017-03-09T01:26:45Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/115,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/115/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
212958805,MDExOlB1bGxSZXF1ZXN0MTA5ODU2NTM5,116,Character Rename command added,11369233,LtRipley36706,closed,0,,,,,0,2017-03-09T07:43:33Z,2017-03-10T04:54:58Z,2017-03-09T13:34:36Z,MEMBER,,0,ACEmulator/ACE/pulls/116,Works via console and client.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/116/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213281968,MDExOlB1bGxSZXF1ZXN0MTEwMDg2MjA1,117,Marketplace Recall + some other changes,11369233,LtRipley36706,closed,0,,,,,2,2017-03-10T09:00:18Z,2017-03-20T02:58:24Z,2017-03-19T09:04:52Z,MEMBER,,0,ACEmulator/ACE/pulls/117,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/117/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213533094,MDExOlB1bGxSZXF1ZXN0MTEwMjYxODY3,118,Landblocks,26334665,lurker-mcdoogle,closed,0,,,,,9,2017-03-11T14:52:38Z,2017-03-13T01:57:25Z,2017-03-13T01:57:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/118,"there are a lot of // TODO comments all over this thing.

here's what I know works:
/telepoi town1
/createlifestone
/telepoi town2
/telepoi town1
... and the lifestone is still there.

Looked like Mogwai bailed yesterday so I figured I'd upload this stuff just in case you wanted it.

Local chat was started, but not done.  I may or may not have broken it - I didn't test.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/118/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213538178,MDExOlB1bGxSZXF1ZXN0MTEwMjY0MDY3,119,"Level up on xp change, PropertyInt Message Types and skill credits",37453,fantoms,closed,0,11369233,LtRipley36706,,,3,2017-03-11T16:08:42Z,2017-05-23T15:53:44Z,2017-03-18T13:59:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/119,"- Changed the Character.Level variable from an int to a uint.

- Added leveling up on grantxp. Since we don't get XP anywhere else, this is the only way so far.

- Added skill credits. You cannot spend them to add skills yet. AvailableSkillCredits.

- Changed the /grantxp command to allow up too 999,999,999,999 xp.

- Followed @Zegeger and created a Network Message Type for PropertyInt

- Allow for Max Level locking, set from the XP chart.

- Added effects on leveling up.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/119/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213652440,MDExOlB1bGxSZXF1ZXN0MTEwMzI1NjM2,120,Logoff works.,10608427,Mag-nus,closed,0,,,,,0,2017-03-13T01:22:21Z,2017-03-13T01:22:32Z,2017-03-13T01:22:32Z,MEMBER,,0,ACEmulator/ACE/pulls/120,Save character position implemented. Character position is not updated in-game yet.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/120/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213657914,MDExOlB1bGxSZXF1ZXN0MTEwMzI5MTQw,121,"Landblocks, logging, object factory prep work",26334665,lurker-mcdoogle,closed,0,25351661,Mogwai-TheFurry,,,3,2017-03-13T02:23:28Z,2017-03-18T18:42:28Z,2017-03-18T18:42:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/121,"there are a lot of // TODO comments all over this thing.

here's what I know works:
/telepoi town1
/createlifestone
/telepoi town2
/telepoi town1
... and the lifestone is still there.

Features:
* Landblock Management
* Landblock Handoff of teleporting objects
* Broadcasting of objects on a landblock based on existence
* Update of objects in a landblock based on Movement
* Landblock adjacency broadcasting
* basic object factories
* log4net - not having console output was killing me and we needed a logging framework anyway. nuget to the rescue.
* moved ""in front of"" calculations to hang off the Position object for better reuse
* PackedDWORD object
* Delayed update of position after entering portal space seems to have helped porting stability.

Known Issues
* Adjacency matrix has issues broadcasting to the correct adjacencies. Shouldn't be a big deal - I'll fix it later.
* local chat is untested and possibly/likely broken.

Mag is showing up in the commit log because I squashed a commit with his name on it when attempting a rebase.  Ended up just cherrypicking into a new branch.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/121/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213665597,MDExOlB1bGxSZXF1ZXN0MTEwMzM0MjU3,122,Minor tweaks 031217,11369233,LtRipley36706,closed,0,,,,,0,2017-03-13T03:35:35Z,2017-03-20T02:58:15Z,2017-03-13T12:30:54Z,MEMBER,,0,ACEmulator/ACE/pulls/122,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/122/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213666871,MDExOlB1bGxSZXF1ZXN0MTEwMzM1MTE0,123,GameActionType renamed from GameActionOpcode,11369233,LtRipley36706,closed,0,,,,,0,2017-03-13T03:47:58Z,2017-03-20T02:57:59Z,2017-03-13T12:24:25Z,MEMBER,,0,ACEmulator/ACE/pulls/123,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/123/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213667290,MDExOlB1bGxSZXF1ZXN0MTEwMzM1Mzcw,124,Bring Config.json.example into spec. ,11369233,LtRipley36706,closed,0,,,,,0,2017-03-13T03:51:36Z,2017-03-20T02:57:55Z,2017-03-13T12:26:40Z,MEMBER,,0,ACEmulator/ACE/pulls/124,Should fix powershell script problem because our config.json was not in spec due to my comments.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/124/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213680800,MDExOlB1bGxSZXF1ZXN0MTEwMzQ0MjIx,125,Save Player Properties to db,37453,fantoms,closed,0,11369233,LtRipley36706,,,2,2017-03-13T06:02:12Z,2017-05-23T15:53:47Z,2017-03-18T14:00:13Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/125,"-Saves every 60 ""ticks"". Please advise on the best stats saving interval.

-Implemented database update functions for character properties.

-Added a character save ticker. Please advise on the proper location for this, I did this quickly.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/125/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
213875928,MDExOlB1bGxSZXF1ZXN0MTEwNDgyMzkx,126,improved dat file content exporting,26334665,lurker-mcdoogle,closed,0,,,,,1,2017-03-13T19:42:02Z,2017-03-14T18:32:43Z,2017-03-14T18:32:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/126,"* improved cell.dat and portal.dat exporting
* created admin server commands for exporting
* unit tests that can be uncommented and run for exporting","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/126/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214166899,MDExOlB1bGxSZXF1ZXN0MTEwNjg5MzEy,127,Dat File parsing,26334665,lurker-mcdoogle,closed,0,,,,,0,2017-03-14T18:33:48Z,2017-03-15T12:12:22Z,2017-03-15T12:12:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/127,"* improved cell.dat and portal.dat exporting, created admin server commands for them as well as unit tests that can be uncommented.
* bug fix in DatFile with the FileOffset being wrong.  started detailed documentation on dat file contents.
* worked on some object parsing.  found a bunch more object types in the client - now categorizes ALL portal files.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/127/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214495718,MDExOlB1bGxSZXF1ZXN0MTEwOTIwNjg4,128,Implement @acehelp and @acecommands,25650194,Thwargle,closed,0,,,,,0,2017-03-15T19:10:41Z,2017-03-16T13:58:20Z,2017-03-16T13:58:20Z,NONE,,0,ACEmulator/ACE/pulls/128,"Implemented acehelp. Will work from console or client and inform the user of general help information.

Implemented acecommands which will iterate through the list of commands based on the current accessLevel and dynamically list them on both the client and the server console.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/128/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214566929,MDExOlB1bGxSZXF1ZXN0MTEwOTcxNzIy,129,Change ACE from clustered server to single server architecture.,10608427,Mag-nus,closed,0,,,,,0,2017-03-16T00:37:53Z,2017-03-16T00:38:19Z,2017-03-16T00:38:19Z,MEMBER,,0,ACEmulator/ACE/pulls/129,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/129/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214568342,MDExOlB1bGxSZXF1ZXN0MTEwOTcyNzQw,130,This removes Host from the config. Servers are differentiated by the …,10608427,Mag-nus,closed,0,,,,,0,2017-03-16T00:48:57Z,2017-03-16T00:49:04Z,2017-03-16T00:49:04Z,MEMBER,,0,ACEmulator/ACE/pulls/130,…Port.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/130/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214596925,MDExOlB1bGxSZXF1ZXN0MTEwOTkyMzE2,131,Create Training Wand,25460553,ogmage78,closed,0,,,,,1,2017-03-16T04:37:15Z,2017-03-16T05:13:40Z,2017-03-16T05:13:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/131,"Added some test code to create a training wand.   As part of this work, I put in some fixes in sizes, added AnimationFrame.   While this is not all that spectacular - it perfectly matches live server pcaps in every field.   

I would like to work on persisting this out to the database.  I assume we will need to implement a next object_id sequence as part of this.   In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted.   Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help.   Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch.   God this was fun.   I forgot how much I used to love coding.   ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/131/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214601610,MDExOlB1bGxSZXF1ZXN0MTEwOTk1NTMx,132,Fixed message fragmentation,12808515,Zegeger,closed,0,,,,,0,2017-03-16T05:19:55Z,2017-03-16T12:15:40Z,2017-03-16T12:15:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/132,Fixed fragmentation logic; we should not fragment messages that do not fill a full packet. Removed NetworkSession.Flush as this change fixed all cases where that seemed needed. Fixed NETWORKDEBUG section which was missed by network refactor,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/132/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214688687,MDExOlB1bGxSZXF1ZXN0MTExMDU2NzMx,133,Turbine Chat Channels description updates. ToD enabled.,10608427,Mag-nus,closed,0,,,,,0,2017-03-16T12:29:33Z,2017-03-16T12:29:41Z,2017-03-16T12:29:41Z,MEMBER,,0,ACEmulator/ACE/pulls/133,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/133/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214728678,MDExOlB1bGxSZXF1ZXN0MTExMDg0NjA1,134,Added attribute upper bounds check and max attribute fireworks and special text,37453,fantoms,closed,0,11369233,LtRipley36706,,,1,2017-03-16T14:46:16Z,2017-05-23T15:53:45Z,2017-03-18T14:00:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/134,"-Added upper bounds checks for the Ranks so that Attributes will not crash the server.

-Added fireworks and special text on max rank, too match skills.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/134/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214776568,MDExOlB1bGxSZXF1ZXN0MTExMTE5OTYy,135,Implement @acehelp and @acecommands,25650194,Thwargle,closed,0,,,,,0,2017-03-16T17:14:02Z,2017-03-17T13:32:54Z,2017-03-17T13:32:54Z,NONE,,0,ACEmulator/ACE/pulls/135,"Implement @acehelp which is a generic help command for use in the server console or client chat

Implement @acecommands which iterates through all commands and dynamically shows the user the possible commands based on their current accesslevel

Implemented a way to increase a characters accesslevel

Stubbed out chat log writeouts for commands that are not implemented rather than have no feedback.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/135/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214781043,MDExOlB1bGxSZXF1ZXN0MTExMTIzMjg3,136,Create Training Wand - Demo work for item creation.,25460553,ogmage78,closed,0,,,,,3,2017-03-16T17:28:59Z,2017-03-16T23:29:47Z,2017-03-16T23:29:38Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/136,"Added some test code to create a training wand. As part of this work, I put in some fixes in sizes, added AnimationFrame. While this is not all that spectacular - it perfectly matches live server pcaps in every field.

I would like to work on persisting this out to the database. I assume we will need to implement a next object_id sequence as part of this. In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted. Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help. Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch. God this was fun. I forgot how much I used to love coding.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/136/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214784803,MDExOlB1bGxSZXF1ZXN0MTExMTI2MDMz,137,World object fixes,25387933,Forbiddenz,closed,0,,,,,2,2017-03-16T17:41:46Z,2017-04-06T11:18:30Z,2017-03-16T18:50:26Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/137,World Object Fixes + Start of Global Guid Manager,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/137/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214820003,MDExOlB1bGxSZXF1ZXN0MTExMTUxODk2,138,police-mode /on,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-03-16T19:53:59Z,2017-05-30T15:34:35Z,2017-03-20T02:14:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/138,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/138/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214868377,MDExOlB1bGxSZXF1ZXN0MTExMTg2ODI0,139,Updated for new wo changes - Create Training wand test implementation,25460553,ogmage78,closed,0,,,,,0,2017-03-16T23:31:14Z,2017-03-19T03:28:36Z,2017-03-19T03:28:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/139,"Added some test code to create a training wand. As part of this work, I put in some fixes in sizes, added AnimationFrame. While this is not all that spectacular - it perfectly matches live server pcaps in every field.

I would like to work on persisting this out to the database. I assume we will need to implement a next object_id sequence as part of this. In the test code it just sets an arbitrary object_id for the wand since it is not yet persisted. Any feedback on the code would be appreciated - I am way out of date, but studying hard to get caught up so I can help. Pea gave me the final piece of the puzzle - without being able to set animation frame, setting the flag caused an alignment mismatch.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/139/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
214892739,MDExOlB1bGxSZXF1ZXN0MTExMjAzNjcy,140,"Fixed Hash32, which corrects Attribute raise issue",12808515,Zegeger,closed,0,,,,,0,2017-03-17T02:42:09Z,2017-03-17T12:10:41Z,2017-03-17T12:10:41Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/140,"Fixed error in shift logic of Hash32, preventing certain packets from calculating correct checksum","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/140/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215172361,MDExOlB1bGxSZXF1ZXN0MTExNDAwNDQ1,141,Saving Character to Database,11369233,LtRipley36706,closed,0,,,,,1,2017-03-18T07:16:07Z,2017-03-20T02:58:10Z,2017-03-18T19:47:13Z,MEMBER,,0,ACEmulator/ACE/pulls/141,"""Ripley has been saved.""

This PR includes commits from the following PRs:
#117 
#119 
#125 
#134 

This PR addresses issues:
#51
#52
#53 


Code work was done by @fantoms and myself

Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues.

Spending Skill Credits is not yet addressed.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/141/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215210864,MDExOlB1bGxSZXF1ZXN0MTExNDE5NDI5,142,Character will now level up on xp grants. Skill credits are also being assigned but are still not spendable.,4389226,damnubber,closed,0,,,,,0,2017-03-18T18:03:45Z,2017-03-21T03:47:34Z,2017-03-21T03:47:34Z,NONE,,0,ACEmulator/ACE/pulls/142,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/142/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215216326,MDExOlB1bGxSZXF1ZXN0MTExNDIyNTE4,143,Saving Character to Database,11369233,LtRipley36706,closed,0,,,,,0,2017-03-18T19:35:31Z,2017-03-20T02:57:39Z,2017-03-20T02:46:55Z,MEMBER,,0,ACEmulator/ACE/pulls/143,"""Ripley has been saved.""

This PR includes commits from the following PRs:
#117
#119
#125
#134
#141

This PR addresses issues:
#51
#52
#53

Code work was done by @fantoms and myself

Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues.

Spending Skill Credits is not yet addressed.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/143/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215224510,MDU6SXNzdWUyMTUyMjQ1MTA=,144,Add the Ability to drop an item from your backpack.,25460553,ogmage78,closed,0,25460553,ogmage78,,,1,2017-03-18T21:55:25Z,2017-04-03T12:05:30Z,2017-04-03T12:05:30Z,CONTRIBUTOR,,,,I am working on this at the moment.   Can it be assigned to me?,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/144/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
215229710,MDExOlB1bGxSZXF1ZXN0MTExNDMwMzg4,145,"Change the AdminObjectFactory to LifestoneObjectFactory, add PortalOb…",10137,ghost,closed,0,,,,,0,2017-03-18T23:42:13Z,2017-10-18T14:07:38Z,2017-03-20T01:44:37Z,NONE,,0,ACEmulator/ACE/pulls/145,"…jectFactory, add LifestoneType and PortalType Enums, remove unneeded GameMessageCreateLifestone, and remove the leftover DebugAssert command in ObjectGuid","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/145/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215238775,MDExOlB1bGxSZXF1ZXN0MTExNDM1NjA5,146,Create Training Wand Demo code and start inventory management Drop/Equip/pickup,25460553,ogmage78,closed,0,,,,,1,2017-03-19T03:36:14Z,2017-03-19T13:24:51Z,2017-03-19T13:24:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/146,"Added Test Code to create Training Wand
Updated for new wo and landblock changes
Started work to drop item.   I want to add this interum work which compiles and works so that I might could get some assistance with the correct way to implement the event animation.

Thanks

Charles / Og II","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/146/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215266773,MDExOlB1bGxSZXF1ZXN0MTExNDUxNTMy,147,Some minor cosmetic fixes.,10608427,Mag-nus,closed,0,,,,,0,2017-03-19T14:15:17Z,2017-03-20T20:05:49Z,2017-03-20T20:05:49Z,MEMBER,,0,ACEmulator/ACE/pulls/147,"Some possible threading issues fixed.
This also forces the build for ACE to x64 only.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/147/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215282644,MDExOlB1bGxSZXF1ZXN0MTExNDYwODg4,148,Add a link to ace-db docker image in the README,8466632,maxc0c0s,closed,0,,,,,3,2017-03-19T18:11:02Z,2017-03-21T03:14:49Z,2017-03-20T05:14:00Z,NONE,,0,ACEmulator/ACE/pulls/148,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/148/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215315873,MDExOlB1bGxSZXF1ZXN0MTExNDgwMjQ5,149,added code for palettes to work correctly.   PaletteGuid - corrected …,25460553,ogmage78,closed,0,,,,,0,2017-03-20T02:02:48Z,2017-04-14T19:37:38Z,2017-03-20T02:39:10Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/149,Small PR to fix bug with Palette method.   Added PaletteGuid and write it out as required.   Fixed Spelling.   The fix for this was originally implemented by @LytelthorpeThistledown     Getting this in sooner rather than later will help a lot of people as they are starting to work on this area of the code.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/149/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215324894,MDExOlB1bGxSZXF1ZXN0MTExNDg1ODQ2,150,Wired up @heal command and conformed admincommands to stylecop rules,11369233,LtRipley36706,closed,0,,,,,0,2017-03-20T03:45:59Z,2017-03-20T03:47:19Z,2017-03-20T03:47:19Z,MEMBER,,0,ACEmulator/ACE/pulls/150,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/150/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215325969,MDExOlB1bGxSZXF1ZXN0MTExNDg2NTky,151,AdminCommands Code Style change,11369233,LtRipley36706,closed,0,,,,,0,2017-03-20T03:58:36Z,2017-04-21T03:49:29Z,2017-03-20T05:09:12Z,MEMBER,,0,ACEmulator/ACE/pulls/151,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/151/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215328613,MDExOlB1bGxSZXF1ZXN0MTExNDg4Mzc1,152,Very basic animation,12808515,Zegeger,closed,0,,,,,0,2017-03-20T04:32:33Z,2017-03-21T02:55:11Z,2017-03-21T02:55:11Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/152,"Added basic animation message.  
Send logout animation when logging out.
Created a sequence manager and related classes, trying to better structure the numerous sequences we must store/track.  (Only started with animation sequences, but if we like this, can convert other sequences over)
General cleanup","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/152/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215337062,MDExOlB1bGxSZXF1ZXN0MTExNDkzODUz,153,Feature: Spend Skill Credits,37453,fantoms,closed,0,,,,,0,2017-03-20T06:11:56Z,2017-05-23T15:53:56Z,2017-03-20T12:08:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/153,"Within this request I've sent code that will allow the client to attempt too spend skill credits. If enough skill credits are available, the server will grant the skill to the the character. If the skill credits are not available or the skill has already been trained, then the server makes sure to send the correct game messages with Skill.None, to keep the client from locking up.

On the bottom of the Skill.cs, I've added an extension that allows for skills with proper names, example:
 `Sneak Attack` instead of `SneakAttack`.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/153/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215393441,MDExOlB1bGxSZXF1ZXN0MTExNTMyOTE1,154,complete stylecop cleanup,26334665,lurker-mcdoogle,closed,0,,,,,0,2017-03-20T11:32:10Z,2017-05-30T15:34:27Z,2017-03-20T12:05:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/154,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/154/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215438276,MDU6SXNzdWUyMTU0MzgyNzY=,155,Implement lifestone usage,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-03-20T14:30:48Z,2017-04-10T11:35:50Z,2017-04-10T11:35:50Z,CONTRIBUTOR,,,,"* Using a Lifestone
* Implement /die or whatever the command was
* Portal back to your position of the lifestone usage on death
* [Bonus points] Vitae","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/155/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
215484872,MDExOlB1bGxSZXF1ZXN0MTExNTk5MDcy,156,"Heal: Update Player object, then send its data",11369233,LtRipley36706,closed,0,,,,,1,2017-03-20T16:51:50Z,2017-04-21T03:49:12Z,2017-03-20T20:06:39Z,MEMBER,,0,ACEmulator/ACE/pulls/156,"Original code only made client aware of change, didn't update the server's player object.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/156/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215599908,MDExOlB1bGxSZXF1ZXN0MTExNjgzMDUy,157,Line ending fixes,10608427,Mag-nus,closed,0,,,,,0,2017-03-21T01:03:59Z,2017-03-21T01:04:04Z,2017-03-21T01:04:04Z,MEMBER,,0,ACEmulator/ACE/pulls/157,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/157/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215715644,MDExOlB1bGxSZXF1ZXN0MTExNzYyODI1,158,updating with documentation and a // TODO,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-03-21T12:06:10Z,2017-05-30T15:34:34Z,2017-03-21T12:06:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/158,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/158/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215784686,MDExOlB1bGxSZXF1ZXN0MTExODEwNTI5,159,Added Path support for Mono applications (Linux),37453,fantoms,closed,0,,,,,0,2017-03-21T15:44:06Z,2017-06-28T19:47:34Z,2017-03-22T04:49:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/159,"Added Mono Path compatibility (Linux support) to the following objects by removing the prefixed slashes in file paths:
- ConfigManager
- Charts
- Dat Loading

Note: This was tested and working correctly on `Ubuntu 16.04`. No bugs were observed when play testing.

Installation Hint: The server currently requires _at least_ installing `mono-complete` with the `apt-get` package manager.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/159/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215897071,MDExOlB1bGxSZXF1ZXN0MTExODkzNDI4,160,Monster factory,26508216,Lidefeath,closed,0,25351661,Mogwai-TheFurry,,,2,2017-03-21T22:24:40Z,2017-05-02T12:14:08Z,2017-03-27T19:06:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/160,This fleshes out MonsterFactory to read the object data for a Drudge Sneaker from the database and spawn it next to the player. Thanks a ton @LytelthorpeThistledown for his work which helped alot to get this done.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/160/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215950513,MDExOlB1bGxSZXF1ZXN0MTExOTMxMDAy,161,Animation fix,12808515,Zegeger,closed,0,,,,,0,2017-03-22T04:35:26Z,2017-03-22T04:53:02Z,2017-03-22T04:53:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/161,"Quick fix; had removed sequence initial value, but apparently it was needed. Testing fail.
Also moved Logout Enqueue to correct place per comment.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/161/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
215950727,MDU6SXNzdWUyMTU5NTA3Mjc=,162,"Inbound fragment combining, sequence reordering, checksum validation",12808515,Zegeger,closed,0,,,,,0,2017-03-22T04:37:23Z,2017-04-03T12:05:20Z,2017-04-03T12:05:20Z,CONTRIBUTOR,,,,"Additional work needed in Network code.
Please assign to me.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/162/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
215964624,MDExOlB1bGxSZXF1ZXN0MTExOTM5ODkx,163,Support for specific server host binding,4389226,damnubber,closed,0,,,,,1,2017-03-22T06:21:14Z,2017-03-22T12:42:14Z,2017-03-22T12:42:14Z,NONE,,0,ACEmulator/ACE/pulls/163,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/163/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
216098076,MDExOlB1bGxSZXF1ZXN0MTEyMDMzMTIy,164,Dat Path Updates,37453,fantoms,closed,0,,,,,0,2017-03-22T15:09:55Z,2017-05-23T15:50:58Z,2017-03-22T15:15:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/164,"Update to Yesterday's Path support PR. The path support push broke the loading of dats without trailing slashes in the config. Here are the changes in this PR that address this issue:

- Updated example DatFileDirectory with a trailing slash at the end of the value

- Changed DatLoader to use Path.Combine, trailing slash is no longer needed.

`ServerTime initialized to Date: Wintersebb 22, 28 P.Y.  Time: Warmtide
2017-03-22 10:04:22,672 INFO : Successfully opened C:\ACE\client_cell_1.dat file, containing 1 records
2017-03-22 10:04:22,781 INFO : Successfully opened C:\ACE\client_portal.dat file, containing 1 records`","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/164/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
216142365,MDExOlB1bGxSZXF1ZXN0MTEyMDYyOTU2,165,Changes to Host configuration,11369233,LtRipley36706,closed,0,,,,,0,2017-03-22T17:10:17Z,2017-04-21T03:49:09Z,2017-03-23T12:58:11Z,MEMBER,,0,ACEmulator/ACE/pulls/165,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/165/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
216250810,MDU6SXNzdWUyMTYyNTA4MTA=,166,Give Characters a set of positions,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-03-23T00:40:45Z,2017-04-03T12:05:11Z,2017-04-03T12:05:11Z,CONTRIBUTOR,,,,"Make an enum for the following positions types:
* Physical Location
* Lifestone Used
* Lifestone Tied
* Portal Recall
* Primary Portal Recall
* Secondary Portal Recall
* Allegiance Hometown (This should only apply to monarchs)
* Mansion Recall

Notes / Requirements
* The character database model will need to change so that players have a set of positions rather than a single position
* The character object will have 1 new property for each of the recall locations in the enumeration, where Allegiance Hometown will attempt to find the monarch's Allegiance Hometown.  If you can't do this yet, just slap a // TODO and return null.
* Each of these positions should save to the database whenever changed.
* Hook up the /lifestone and /ls commands to go to the Lifestone position.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/166/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
216282064,MDExOlB1bGxSZXF1ZXN0MTEyMTU2MTQ2,167,weenies weenies everywhere.  object structure pass for review.,25351661,Mogwai-TheFurry,closed,0,,,,,3,2017-03-23T03:34:09Z,2017-05-30T15:34:34Z,2017-03-25T05:22:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/167,"yeah, so this works....","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/167/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
216649386,MDExOlB1bGxSZXF1ZXN0MTEyMzg3ODA2,168,Item Management,25460553,ogmage78,closed,0,,,,,0,2017-03-24T04:52:10Z,2017-03-24T14:11:48Z,2017-03-24T14:11:48Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/168,"Not ready to be pulled.   

@ctw me - creates a training wand in your backpack
@ctw ground spawns a training wand on the ground

Drag wand to the ground.   It does drop the item and takes it out of the backpack.   It does register with the landblock.   I had the motion working (bending down to drop the wand and standing back up) but something I changed has got that not working.   
The wand does not appear in the visible field. - not sure why.

I am way out of date on coding - and I am sure I have done stuff incorrectly.   Any feedback on how to code this better or topics I should read up on will be greatly appreciated.   I feel like this is really really close to working.   Also, I know the hard coding of data will go away once we have the Weenie data in the database.   I put in a number of comments and TODO's to follow up on.

The PCAP is unless I am just blind - almost identical to this one I used as a template.   Any help will be appreciated. 

Here is a link to the live server PCAP https://www.dropbox.com/s/q0l3wi4mhx0n7ce/drop_item.pcap?dl=0





","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/168/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
216958720,MDExOlB1bGxSZXF1ZXN0MTEyNTc4MzY1,169,Updated Marketplace Recall,11369233,LtRipley36706,closed,0,,,,,1,2017-03-25T08:05:51Z,2017-04-21T03:49:06Z,2017-04-09T21:39:23Z,MEMBER,,0,ACEmulator/ACE/pulls/169,"@mp command better reflects how it worked in AC1Live. 

The movement check/cancel is not yet implemented.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/169/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217025656,MDExOlB1bGxSZXF1ZXN0MTEyNjEzNTg0,170,Fixed bug in F748: Set Position and Motion,25460553,ogmage78,closed,0,,,,,0,2017-03-26T04:07:03Z,2017-04-14T19:37:35Z,2017-03-27T12:29:07Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/170,"There has been a bug in this code that was keeping me from being able to drop an item.

- Fixed alignment problem and cleaned up the ability to report position with the correct flags

- I moved and expanded an enum flag list for correct scoping 

- I put the position flag in the position object and initialized the flags correctly on player create.

- Added another signature to Serialize - left the old one for backward compatibility - we may want to look at refactoring this. 

Please let me know if you anything that looks wrong.   I am still learning.   This is more of a plumbing fix.   You should not notice anything new or anything new broken :)    If this get's merged - I want to start looking at creating mutable objects next.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/170/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217028943,MDExOlB1bGxSZXF1ZXN0MTEyNjE1MjI4,171,Renamed the new db statement constructor label,37453,fantoms,closed,0,,,,,0,2017-03-26T05:29:12Z,2017-05-23T15:54:40Z,2017-03-26T12:16:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/171,- Renamed a function to cut down on confusion. Fixes an assumed typo in name for new function `ConstructStatement`.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/171/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217055250,MDExOlB1bGxSZXF1ZXN0MTEyNjI5MTAx,172,Implements GameAction/Event for Update Health,26508216,Lidefeath,closed,0,,,,,1,2017-03-26T14:21:05Z,2017-04-20T20:03:58Z,2017-03-28T20:45:21Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/172,This is limited for Players currently but should be adjustable once creatures are in.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/172/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217099846,MDExOlB1bGxSZXF1ZXN0MTEyNjUwMDA4,173,Fixed Model write order and some spelling errors,26606778,OptimShi,closed,0,,,,,0,2017-03-26T23:24:48Z,2017-03-27T01:03:46Z,2017-03-27T01:03:46Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/173,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/173/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217107233,MDExOlB1bGxSZXF1ZXN0MTEyNjUyOTM2,174,Update: Prevent Welcome Message/Motd when string is empty,37453,fantoms,closed,0,,,,,0,2017-03-27T00:37:32Z,2017-03-27T02:36:34Z,2017-03-27T01:06:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/174,"- Thanks to Miach for coding and testing this PR.

- If the `Config.json` file includes an EMPTY `Welcome` config variable, then the server will not send the Popup dialog box, upon logging into a server.

Example: 
```
{
    ""Server"": {
        ""WorldName"": ""Darktiphoid"",
        ""Welcome"": """",
        ""Network"": {
            ""Host"": ""0.0.0.0""
       },
    },
}
```","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/174/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217109932,MDExOlB1bGxSZXF1ZXN0MTEyNjUzNjY1,175,Created IF statement to remove Welcome popup box,24981658,MiachofTD,closed,0,,,,,0,2017-03-27T00:53:42Z,2017-04-28T03:29:56Z,2017-03-27T01:09:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/175,"When using this IF statement you can remove the Welcome to this ACE
server!\nFor more information visit http://www.acemulator.org. from
inside the quotes in the config.json file and the popup box does not
appear.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/175/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217123739,MDExOlB1bGxSZXF1ZXN0MTEyNjYwOTMy,176,Save Character Position to Database,37453,fantoms,closed,0,,,,,0,2017-03-27T02:56:31Z,2017-05-23T15:54:38Z,2017-03-27T12:34:05Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/176,"- Update Player.cs `SaveCharacter()` function to store the `Player.Position` in the Character data object, right before the object is is stored in the database. This allows the server to save the character's position on logout or after the player save interval has ended.

- Added a summary comment for `SaveCharacter`.

- Updated Code Style per StyleCop.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/176/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217338363,MDExOlB1bGxSZXF1ZXN0MTEyODExNzU2,177,Update: SQL Where Syntax for ConstructStatement,37453,fantoms,closed,0,,,,,0,2017-03-27T18:44:52Z,2017-05-23T15:54:36Z,2017-03-27T18:49:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/177,"- Updated the `wherelist` text to include the proper SQL syntax, for a WHERE clause.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/177/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217425388,MDU6SXNzdWUyMTc0MjUzODg=,178,Primary keys too restrictive on some weenie tables,25618389,LytelthorpeThistledown,closed,0,,,,,0,2017-03-28T01:56:16Z,2017-04-10T11:35:43Z,2017-04-10T11:35:43Z,CONTRIBUTOR,,,,"Proposed fix:

ALTER TABLE weenie_palette_changes DROP PRIMARY KEY, ADD PRIMARY KEY(weenieClassId, subPaletteId, offset, length);
ALTER TABLE weenie_texture_map_changes DROP PRIMARY KEY, ADD PRIMARY KEY(weenieClassId, index, oldId);

I think the weenie_palette_changes table needs a different primary index. Currently it is weenieClassId + subPaletteId.

Here is the palette data for Narg.

subPaletteId,offset,length
67116992,192,64
67109565,256,64
67114248,576,160
67114248,1088,192
67114248,320,192
67114248,928,160
67114248,0,192
67114248,768,96
67114248,928,96
67110336,2000,48

subPaletteId 67114248 appears 7 times, twice it has the same offset of 928


The same problem exists for weenie_texture_map_changes. Currently it is weenieClassId + index.

Here is the texture data for the Aluvian Mid-Stakes Gamesmaster

index,oldId,newId
16,83886232,83890685
16,83886668,83890262
16,83886837,83890287
16,83886684,83890353
9,83887070,83886781
9,83887062,83886686
0,83889072,83889072
0,83889342,83889342
5,83887064,83886241
1,83887064,83886241
3,83889344,83887054
7,83889344,83887054
4,83887068,83887054
8,83887068,83887054

index 16 apears 4 times","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/178/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
217443319,MDExOlB1bGxSZXF1ZXN0MTEyODg2NjM3,179,Fix remaining 6 StyleCop warnings,10137,ghost,closed,0,,,,,0,2017-03-28T04:13:55Z,2017-10-18T14:07:39Z,2017-03-28T11:55:01Z,NONE,,0,ACEmulator/ACE/pulls/179,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/179/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217470832,MDU6SXNzdWUyMTc0NzA4MzI=,180,Objects need to be re-sent to client if teleported within same landblock,11369233,LtRipley36706,closed,0,,,,,1,2017-03-28T07:29:04Z,2017-07-26T16:50:35Z,2017-07-26T16:50:35Z,MEMBER,,,,currently the client loses objects if teleported within same landblock,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/180/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
217539297,MDU6SXNzdWUyMTc1MzkyOTc=,181,Parse pcaps for Doors and add them!,25351661,Mogwai-TheFurry,closed,0,,,,,2,2017-03-28T12:12:58Z,2017-05-01T15:12:52Z,2017-05-01T15:12:52Z,CONTRIBUTOR,,,,"* Parse pcaps for doors and emit them as SQL
* Add the doors to the ace_world database
* Add landblock logic to close/open doors","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/181/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
217729589,MDExOlB1bGxSZXF1ZXN0MTEzMDk0MTU3,182,Drop Item - REVIEW ONLY Do not merge,25460553,ogmage78,closed,0,,,,,2,2017-03-29T00:16:43Z,2017-03-31T18:49:39Z,2017-03-29T21:53:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/182,"This runs and works.   If you want to test drop item do the following:

Log in 
@ctw me  (This will create a training wand in your backpack)
OR
@ctw ground (not very interesting - does the same thing but spawns it on the ground.

Once you have the wand in your backpack from calling the first command - drop that bad boy.   Down she goes with a thud and your radar lights up.   Up until about an hour ago, he would do the correct animation and put the damn wand on the ground.   I fell into git hell and between squash and revert - I am too tired to fix it.   You can see it on the ground.   I did not finish the complementary action to be able to pick it up.

The problem is - something I did is messing up the packet stream.   It looks like it all works, but I can't open the pcap file it creates.   That tells me something is amiss.   Hopefully someone can see it.

ALSO

Note - I started this a few weeks ago and I have learned a lot since then.   If any of this is in the wrong namespace or I have made some other noobie mistake - it is not by design it is just a lack of knowledge on my part.    Let me know the better way to do it and you won't have to tell me twice.   :)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/182/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
217957579,MDExOlB1bGxSZXF1ZXN0MTEzMjU3Mjk1,183,all the database things!,25351661,Mogwai-TheFurry,closed,0,,,,,2,2017-03-29T17:56:09Z,2017-05-30T15:34:32Z,2017-04-03T11:58:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/183,"From PCAPs..
* All weenie objects
* All static objects","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/183/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218060844,MDExOlB1bGxSZXF1ZXN0MTEzMzMyMzc2,184,Feature: ORM Driven Character Positions for Issue #166,37453,fantoms,closed,0,,,,,1,2017-03-30T02:10:18Z,2017-03-30T15:56:12Z,2017-03-30T15:56:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/184,"This huge PR is related to Issue #166. The code has been changed to allow more then one position type. A class was added for Character position types that match the requirements listed in the issue. A secondary Position Type class was added to match the client, provided by @LtRipley36706. 

To work with the ORM code introduced during the developer meeting, I've attempted to copy the pseudo 1:1 mapping into `CharacterPosition.cs`. In order to allow for more then one position, the `Character.Position` member was changed to dictionary containing a list of character positions by type. `Player.Position` was changed to `Player.PhysicalPosition` and when the server decides to save the positions to the database, the data is saved through the ORM object in `CharacterPosition.cs`. 

There were a few things left to do, that were not accomplished for Issue #166:
* Hook up /lifestone and /ls commands

ChangeLog:
* Changed the Player.Position to Player.PhysicalPosition to match the Developer meeting video and Issue #166.
* Created `CharacterPostion` and `CharacterPositionType` classes to store the Database types requested in Issue #166.
* Added `CharacterPostion` ORM logic.
* Built out helper extension functions to serve the `StartingLocation`, until we pull from the database. Also included an Invalid location as a default (0).
* Changed the `character_positions` table and Added `positionType` column.
* Set the primary key to include `positionType` column.
* Added `positionType` to required Critera for `character_positions`.
* Added `CharacterPositionInsert` and `CharacterPositionUpdate` to the Character Database.
* Created `CharacterPositionInsert` and `CharacterPositionUpdate` prepared SQL statements by utilizing the `ConstructStatement` function.
* Added the required `positionType` clause to the `CharacterPositionSelect` prepared statement.
* Added a position update statement for updating the player position.
* Reworked GetPosition to include the `CharacterPositionType`.
* Added function for getting a `CharacterPostion` from the database, requires a character Id and `CharacterPositionType`.
* Added logic to get location function to insert a location into the database, if not present.
* Reworked the UpdateCharacter and Update functions to save positions.
* Added functions for inserting new character positions on character creation.
* Added functions for saving/loading the character positions from the database on joining the World.
* Attempted to get log4net working properly and moved some code to logging.
* Added DBDEBUG project constant for debugging the database calls.
* Changed the `CharacterPositionSelect` prepared statement to a `ConstructStatement`.

GitLog:
- Changed position to phsysical/logical and added logical positions
- Updated comments on CharacterPositionType
- Added the sql for altering the positions table, to add the positionType
- Added ripleys Position Types
- Added Character Position Database Object
- Renamed Position types to Positions to Match Ripley's original code. Looks better in character, also.
- Changed to the correct function when Executing constructed statements
- Added another debug command
- Added Position update to the Character Data object
- Changed the positiontype to a keyed column in mysql
- DB Updates
- Morning updates - working position inserts at character creation
- Updated constructstatement, positions are saving to the right columns
- Load all available character positions from the database or create a new if missing
- Fixed unused GetCharacterPhysicalPosition
- Made the server use the correct insert function
- Fixed position save
- Cleaned up code and removed the unnecessary SQL statement
- Moved Character Prepared Statement for Selecting position to the ConstructedStatement Get function
- Updated changelog","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/184/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218226807,MDExOlB1bGxSZXF1ZXN0MTEzNDQ5OTk3,185,"Network updates for packet/fragment reorder, fragment combining",12808515,Zegeger,closed,0,,,,,0,2017-03-30T14:59:45Z,2017-04-02T01:01:50Z,2017-04-02T01:01:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/185,"Added network session ID to WorldManager to lookup user's sessions and updated related components to handle this.
Refactored GameAction handling to no longer used Activator instantiated objects, they are now delegates like the game message handlers.
Added packet/fragment reorder queues and handling.
Added fragment recombining.
A complete fragment is sent upstream as a new ClientMessage object. Updated all locations where ClientPacketFragment was used.
TODO checksum verification, improve some logging/comments","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/185/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218255708,MDExOlB1bGxSZXF1ZXN0MTEzNDcxNzg4,186,Animation - fix and enhancement,25460553,ogmage78,closed,0,,,,,2,2017-03-30T16:33:24Z,2017-03-31T18:49:25Z,2017-03-31T03:42:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/186,"In this PR - I extended on the work Zegeger did.   His work was for animations only.   The system supports a 0 to N animation sequence.   If 0, you are doing a basic motion.   Moving forward, sidestep, turnto.   They use the same message F74C but are intelligently coded depending on what you want to do.    
TODO: I have not looked to see if you can have a motion followed by an animation(s)   I coded it so it supports it, but I did not have a ready pcap to confirm.   Easy enough to fix if they are mutually exclusive.

I cleaned up some emums.   Still to do is to refactor the autonomous position message - I think we have some overlap and duplication there.    

To test - use the debug command @amimation <animation> to see that Zegeger's work still functions as expected.   

Use debug command @movement to see the drop sequence.   You can look at the produced pcaps and see the delta and that they match live servers. 

As usual - any coding faxpas are not by design.   Feedback is wanted and welcome.   If there is a better way to do what I did - please let me know.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/186/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218334549,MDExOlB1bGxSZXF1ZXN0MTEzNTI5NzQ0,187,World fix and fireball test,25387933,Forbiddenz,closed,0,,,,,4,2017-03-30T21:33:33Z,2017-04-01T13:00:44Z,2017-04-01T13:00:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/187,"World Object Fixes + My test Spell firewall - sorta.. so I could test it some more.
New AceVector Object.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/187/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218609267,MDExOlB1bGxSZXF1ZXN0MTEzNzI3MDA1,188,Feature: ORM Driven Character Positions for Issue #166,37453,fantoms,closed,0,,,,,0,2017-03-31T20:30:31Z,2017-04-02T01:46:20Z,2017-04-02T01:46:20Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/188,"This huge PR is related to Issue #166. The code has been changed to allow more then one position type. A class was added for Character position types that match the requirements listed in the issue. A secondary Position Type class was added to match the client, provided by @LtRipley36706.

To work with the ORM code introduced during the developer meeting, I've attempted to copy the pseudo 1:1 mapping into `CharacterPosition.cs`. In order to allow for more then one position, the `Character.Position` member was changed to dictionary containing a list of character positions by type. `Player.Position` was changed to `Player.PhysicalPosition` and when the server decides to save the positions to the database, the data is saved through the ORM object in `CharacterPosition.cs`. 

There were a few things left to do, that were not accomplished for Issue #166:
* Hook up /lifestone and /ls commands

Changelog with this PR: 

### 2017-03-31
[fantoms]
* Added debug command to test positions.
* Changed SQL syntax to use BEFORE instead of AFTER for the `positionType` column, in the `character_positions` table.
* Removed the github friendly enums from the `PositionTypes`.
* Changed a log4net debug line.
* Changed the name class name `CharacterPositionType` to `PositionType`
* Reworked `Position.cs` with ORM.

### 2017-03-29
[fantoms]
* Changed the Player.Position to Player.PhysicalPosition to match the Developer meeting video and Issue #166.
* Created `CharacterPostion` and `CharacterPositionType` classes to store the Database types requested in Issue #166.
* Added `CharacterPostion` ORM logic.
* Built out helper extension functions to serve the `StartingLocation`, until we pull from the database. Also included an Invalid location as a default (0).
* Changed the `character_positions` table and Added `positionType` column.
* Set the primary key to include `positionType` column.
* Added `positionType` to required Critera for `character_positions`.
* Added `CharacterPositionInsert` and `CharacterPositionUpdate` to the Character Database.
* Created `CharacterPositionInsert` and `CharacterPositionUpdate` prepared SQL statements by utilizing the `ConstructStatement` function.
* Added the required `positionType` clause to the `CharacterPositionSelect` prepared statement.
* Added a position update statement for updating the player position.
* Reworked GetPosition to include the `CharacterPositionType`.
* Added function for getting a `CharacterPostion` from the database, requires a character Id and `CharacterPositionType`.
* Added logic to get location function to insert a location into the database, if not present.
* Reworked the UpdateCharacter and Update functions to save positions.
* Added functions for inserting new character positions on character creation.
* Added functions for saving/loading the character positions from the database on joining the World.
* Attempted to get log4net working properly and moved some code to logging.
* Added DBDEBUG project constant for debugging the database calls.
* Changed the `CharacterPositionSelect` prepared statement to a `ConstructStatement`.
+ Updates after PR review: +
* Changed the `LoadCharacterPositions` to ORM OUT of the database.
* Changed the introduced @save command to @save-now to avoid conflict
* Changed CharacterPositionType to PositionTypes and merged in Ripley's enums
* Changed PhyiscalPosition to Location
* Removed plural in function name for position types; broke the character loading
* Added database view for all list positions
* Added GetList statement for all positions
* Migrated GetPosition to GetLocation, Seporated Logic, added ORM calls on selecting data
* Moved the Character.Location to Character.CharacterPositions[PositionType.Location] dictionary



### Git Log:
- Changed position to phsysical/logical and added logical positions
- Updated comments on CharacterPositionType
- Added the sql for altering the positions table, to add the positionType
- Added ripleys Position Types
- Added Character Position Database Object
- Renamed Position types to Positions to Match Ripley's original code. Looks better in character, also.
- Changed to the correct function when Executing constructed statements
- Added another debug command
- Added Position update to the Character Data object
- Changed the positiontype to a keyed column in mysql
- DB Updates
- Morning updates - working position inserts at character creation
- Updated constructstatement, positions are saving to the right columns
- Load all available character positions from the database or create a new if missing
- Fixed unused GetCharacterPhysicalPosition
- Made the server use the correct insert function
- Fixed position save
- Cleaned up code and removed the unnecessary SQL statement
- Moved Character Prepared Statement for Selecting position to the ConstructedStatement Get function
- Changed the LoadCharacterPositions to ORM OUT of the database.
- Changed the introduced @save command to @save-now to avoid conflict
- Changed CharacterPositionType to PositionTypes and moved in Ripley's code
- Changed PhyiscalPosition to Location
- Removed plural in function name for position types; broke the character loading
- Added GetList statement for all positions
- Migrated GetPosition to GetLocation, Seporated Logic, added ORM calls on selecting data
- Moved the Character.Location to Character.CharacterPositions[PositionType.Location] dictionary
- Added debug command to test positions
- Migrated enums to ripleys position only - took out the labels from github
- Updated SQL to use BEFORE instead of AFTER
- Changed DBDEBUG line to use log4net
- Began working on position
- Changed the name from CharacterPositionType to PositionType
- Converted Position to rely on floats instead of vectors and began adding ORM logic
- Renamed variables to go inline with code style
- Moved character helper extensions and migrated to Positions
- Migrated positions to orm
- Adding Character Positions view for the GetList query
- Swapped column order for Ripley
- Reworked landblock positions - there is some data loss happening that i would like help locating
- Fixed up comments and updated changelog","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/188/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218616162,MDExOlB1bGxSZXF1ZXN0MTEzNzMyMDEw,189,Inventory Phase 1 and Drop Item,25460553,ogmage78,closed,0,,,,,2,2017-03-31T21:01:27Z,2017-05-01T16:41:56Z,2017-04-03T03:00:33Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/189,"This is at a good place for code review and possible merge.   Once approved, this will allow others to start on the numerous tasks around inventory management.  You can spawn a Training wand in your backpack or on the ground.   That is just throw away code to test with.   It is in the debug handler.
usage:
@ctw me OR @ctw ground

Once the item is spawned, you can then drop it on the ground.   

Included in this PR.  Starts to address Issue #144 

World object now has inventory dictionary.   Added this here as anything that can be a container needs to have this ability.   Not all world objects are containers - so also added property IsContainer

Added methods to:

- Add to inventory
- Remove from inventory
- Lookup item in inventory
- Handle Drop item: 
     1. Calls lookup
     2. Update Container burden
     3. Sets some properties in preparation for going 3D
     4. GameMessageUpdatePosition.
     5. Alerts Landblock to new arrival
     6. Removes the item the player's inventory 
Added GameActionDropItem
This handles the client's request to drop an item.
Added GameMessagePutObjectIn3d
 
As usual - any coding faux pas are not by design. Feedback is wanted and welcome. If there is a better way to do what I did - please let me know.

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/189/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218690610,MDExOlB1bGxSZXF1ZXN0MTEzNzc2MTcz,190,Spawn creatures from DB,26508216,Lidefeath,closed,0,,,,,3,2017-04-01T11:45:45Z,2017-04-20T20:04:16Z,2017-04-04T17:49:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/190,Introduces a basic creature generator table layout with a static spawn of a Drudge Sneaker near the Holtburg Lifestone as a Test. The static spawns are loaded via the LandBlockManager from the DB.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/190/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218735283,MDExOlB1bGxSZXF1ZXN0MTEzODAxNzMy,191,Fixed bug / incomplete implementation of instance_time stamp,25460553,ogmage78,closed,0,,,,,2,2017-04-02T01:46:53Z,2017-04-14T19:37:28Z,2017-04-03T01:17:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/191,"Small fix, but an important one.   A lot of messages take an instance_sequence or timestamp.   it is called timestamp in the client.   I fixed the places where this was still being set to 1.   If the instance_timestamp does not agree between calls it can cause you to hang in portal space or other bad things.   The PhysicsData.Position structure passes 9 (0-8 ) unnamed timestamps.   These were in place - two were set to 0 - however, they were out of order.   I am not sure of the other 8, but the last one is the instance_timestamp.   I verified this with live server pcaps.   I have made it so with what we have implemented so far, we are consistent.    It will be important that we get this information out to all contributors as we need to set it for all player messages to totalLogins.   I also make the character load and save properly update the totalLogins value. ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/191/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218736918,MDExOlB1bGxSZXF1ZXN0MTEzODAyNTk2,192,World fix and fireball test,25387933,Forbiddenz,closed,0,,,,,0,2017-04-02T02:31:30Z,2017-04-02T12:11:56Z,2017-04-02T12:11:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/192,Spells - Cleaned up,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/192/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218737106,MDExOlB1bGxSZXF1ZXN0MTEzODAyNjkz,193,Fix: Include missing CharacterPositionExtensions.cs,37453,fantoms,closed,0,,,,,0,2017-04-02T02:37:13Z,2017-04-02T02:38:43Z,2017-04-02T02:38:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/193,"My last PR did not include a necessary file, so I am including it now.

The file is a helper for functions for positions that kept popping up everywhere.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/193/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218740683,MDExOlB1bGxSZXF1ZXN0MTEzODA0NjYx,194,"Fix: Reverted SQL syntax to use AFTER, instead of BEFORE",37453,fantoms,closed,0,,,,,1,2017-04-02T04:16:20Z,2017-05-23T15:53:18Z,2017-04-02T16:31:10Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/194,"- Changed `2017_03_27_character_positions_change.sql` and `2017_03_26_character_positions_positiontype.sql` to use AFTER instead of BEFORE, when aligning the column.  The `positionType` column has been moved after the `id` column.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/194/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218760696,MDExOlB1bGxSZXF1ZXN0MTEzODE1ODky,195,World fix and fireball test,25387933,Forbiddenz,closed,0,,,,,0,2017-04-02T12:13:13Z,2017-05-01T16:42:14Z,2017-04-03T17:21:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/195,Clean up - Synced with Latest Prs,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/195/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
218914985,MDU6SXNzdWUyMTg5MTQ5ODU=,196,Action queue for Player<->Landblock Interaction,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-03T12:16:42Z,2017-04-10T11:35:57Z,2017-04-10T11:35:57Z,CONTRIBUTOR,,,,"Use Cases:
* Picking up an item off the ground
* Casting a spell
* Getting health of a monster
* Using a Door
* Using a Lifestone
* Opening chests

Other necessary changes:
* Remove the exposure of WorldObjects from Landblock and LandblockManager

Design thoughts:
* The session/player object would have a List<Something> of queued actions.
* As Actions arrive.... If they don't require Landblock interaction, just handle them and be done with it.  If they do require Landblock / Object interaction, add them to the session/player queue.
* In the main Landblock server control loop, process the top X actions from each player's queue.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/196/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
218915428,MDU6SXNzdWUyMTg5MTU0Mjg=,197,"Continuous Integration, Code Analysis, and Unit Tests ",25351661,Mogwai-TheFurry,closed,0,25351661,Mogwai-TheFurry,,,0,2017-04-03T12:18:30Z,2017-04-10T11:35:31Z,2017-04-10T11:35:31Z,CONTRIBUTOR,,,,"We'll need an ACE admin to enable it for ACE, but somebody can get it working in their personal fork first.  I found this project as a tool for running StyleCop from within Travis.
https://github.com/Nylle/StyleCop.Console

Unit tests will require switching to NUnit as well.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/197/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
219018504,MDExOlB1bGxSZXF1ZXN0MTEzOTkxMDUz,198,Add portals to ACE_World tables,10137,ghost,closed,0,,,,,1,2017-04-03T18:18:18Z,2017-04-04T04:33:55Z,2017-04-04T04:33:43Z,NONE,,0,ACEmulator/ACE/pulls/198,"* Add a fix to the current master ACE_World tables for weenie and ace objects to loosen the index restrictions
* Add Portal weenie table data
* Add Portal object table data

---  Duplicate portal objects removed; Floating City, Orphanage, Golem Sanctum, and Humming Crystal portals removed as they are not static object placements
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/198/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219058062,MDExOlB1bGxSZXF1ZXN0MTE0MDIwMTI3,199,generic cleanup,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-03T20:51:38Z,2017-05-30T15:34:30Z,2017-04-03T20:53:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/199,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/199/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219115279,MDExOlB1bGxSZXF1ZXN0MTE0MDU0NzQ5,200,AppVeyor Implementation,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-04T01:24:41Z,2017-05-30T15:34:38Z,2017-04-04T21:48:11Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/200,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/200/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219138560,MDExOlB1bGxSZXF1ZXN0MTE0MDY5MjAw,201,Add portal objects to the ACE_World tables,10137,ghost,closed,0,,,,,0,2017-04-04T04:41:21Z,2017-10-18T14:07:42Z,2017-04-04T11:28:07Z,NONE,,0,ACEmulator/ACE/pulls/201,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/201/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219352933,MDExOlB1bGxSZXF1ZXN0MTE0MjIyMTI2,202,Fix for build error,26508216,Lidefeath,closed,0,,,,,0,2017-04-04T19:11:27Z,2017-04-04T19:24:29Z,2017-04-04T19:24:29Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/202,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/202/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219429224,MDExOlB1bGxSZXF1ZXN0MTE0MjczMjAy,203,This fixes the missing ACE.Datloader dependancy from ACE,10608427,Mag-nus,closed,0,,,,,0,2017-04-05T00:41:34Z,2017-04-05T00:42:23Z,2017-04-05T00:42:23Z,MEMBER,,0,ACEmulator/ACE/pulls/203,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/203/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219430321,MDExOlB1bGxSZXF1ZXN0MTE0MjczODg3,204,Adds accesslevel back to ace_auth,10608427,Mag-nus,closed,0,,,,,0,2017-04-05T00:49:47Z,2017-04-05T00:50:37Z,2017-04-05T00:50:37Z,MEMBER,,0,ACEmulator/ACE/pulls/204,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/204/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219436970,MDExOlB1bGxSZXF1ZXN0MTE0Mjc3OTUy,205,updated readme with stylecop error message,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-05T01:30:14Z,2017-05-30T15:34:38Z,2017-04-05T01:33:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/205,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/205/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219451481,MDExOlB1bGxSZXF1ZXN0MTE0Mjg1ODA3,206,Network fixes,12808515,Zegeger,closed,0,,,,,0,2017-04-05T02:54:49Z,2017-04-05T03:10:05Z,2017-04-05T03:02:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/206,"Fixed issue in InboundFragmentCombining, also fixed exception in ConnectionListener which would stop the server from accepting connections, finally added Logging statement in Main which seems to allow log4net to work","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/206/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219469439,MDExOlB1bGxSZXF1ZXN0MTE0Mjk2MzAx,207,REALLY fixed inbound packet combining,12808515,Zegeger,closed,0,,,,,0,2017-04-05T05:03:06Z,2017-04-06T00:08:59Z,2017-04-05T12:02:54Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/207,Have a test case now.  Confirmed it works.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/207/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219584507,MDExOlB1bGxSZXF1ZXN0MTE0Mzc3NzE1,208,"animations, palettes, and textures for world objects",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-05T13:35:00Z,2017-04-06T13:42:24Z,2017-04-06T13:42:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/208,"no data yet, still debugging my exports","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/208/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219614446,MDU6SXNzdWUyMTk2MTQ0NDY=,209,Character rotation,25460553,ogmage78,closed,0,,,,,3,2017-04-05T15:02:48Z,2017-04-09T18:31:16Z,2017-04-09T18:31:16Z,CONTRIBUTOR,,,,"I have not had a chance to look into it, but either on the save or the load, we are not saving or loading the character rotation (facing direction) correctly.   You log out facing one way, you log back in in the same spot rotated 90 degrees.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/209/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
219707108,MDExOlB1bGxSZXF1ZXN0MTE0NDY2ODU0,210,"Fix the creature data in worldbase.sql, so the Drudge can spawn.",26508216,Lidefeath,closed,0,,,,,0,2017-04-05T20:36:28Z,2017-04-20T20:05:00Z,2017-04-05T23:49:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/210,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/210/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219773627,MDExOlB1bGxSZXF1ZXN0MTE0NTEzNTIx,211,WIP Inventory - Good place for review - Do not merge yet,25460553,ogmage78,closed,0,,,,,1,2017-04-06T03:03:35Z,2017-04-06T21:47:06Z,2017-04-06T21:47:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/211,"With help from Zegeger - found the sequence issue that was keeping item pick up from working.   Not for merge - just posting for review.   You can create, pickup and drop.   There is a bug in a pick up then drop again - the item takes off.   Either still have a sequence or a position flag issue on multiple drops and pickups.   ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/211/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219776339,MDU6SXNzdWUyMTk3NzYzMzk=,212,Continue build out of inventory functions,25460553,ogmage78,closed,0,,,,,1,2017-04-06T03:25:57Z,2017-12-02T05:17:14Z,2017-12-02T05:17:14Z,CONTRIBUTOR,,,,"- [x] Fix bug with drop after pickup
- [x] create a pack and enable equip
- [x] add the ability to move to and from main pack
- [x] add tables (if needed)  and wire up inventory to persist with character save
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/212/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
219781989,MDExOlB1bGxSZXF1ZXN0MTE0NTE4OTM5,213,"Added lifestone attunment, @ls recall, and position fixes.",37453,fantoms,closed,0,,,,,0,2017-04-06T04:14:54Z,2017-05-23T15:54:21Z,2017-04-06T13:43:07Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/213,Also worked out the log4net problems for debugging databases,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/213/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219787721,MDExOlB1bGxSZXF1ZXN0MTE0NTIyNjU5,214,Sequences,12808515,Zegeger,closed,0,,,,,0,2017-04-06T05:07:25Z,2017-04-06T14:14:14Z,2017-04-06T13:58:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/214,"Got CreateObject sequences named correctly and ordered correctly.
Updated many sequences to use SequenceManager.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/214/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
219974920,MDExOlB1bGxSZXF1ZXN0MTE0NjU1NTgz,215,first pass of action queue,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-06T17:37:46Z,2017-04-06T20:07:50Z,2017-04-06T20:07:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/215,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/215/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220046814,MDExOlB1bGxSZXF1ZXN0MTE0NzA1MTM5,216,Feature: Death,37453,fantoms,closed,0,,,,,0,2017-04-06T22:03:04Z,2017-06-28T19:46:49Z,2017-04-07T12:28:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/216,"Simple player death that allows for @lifestone and @die functionality.

- Added YourDeath GameMessageEvent and interface
- Added suicide, killing, and death
- Added value checks on setcharposition

We currently do not yet have death messages or vitae penalties.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/216/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220115569,MDExOlB1bGxSZXF1ZXN0MTE0NzQ2MzYw,217,Reveresed the logic for the distance check on lifestone usage,37453,fantoms,closed,0,,,,,0,2017-04-07T05:32:33Z,2017-05-23T15:53:05Z,2017-04-07T18:45:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/217,"- After performing some empirical visual client testing with:
 `
float squaredDistance = player.Location.SquaredDistanceTo(obj.Location);
                                        player.Session.Network.EnqueueSend(new GameMessageSystemChat(squaredDistance.ToString(), ChatMessageType.Broadcast));
`, I found that a static use distance of at least `4.9f` worked _well_. I did not change this float, but I am noting it here.

- I also changed the `Lifestone Use` text to blue.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/217/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220357495,MDExOlB1bGxSZXF1ZXN0MTE0OTE5Nzc0,218,Creature stats,26508216,Lidefeath,closed,0,,,,,1,2017-04-07T23:44:58Z,2017-04-20T20:05:08Z,2017-04-08T10:26:18Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/218,"Creatures have stats now and answer the UpdateHealth action with the new ActionQueue. Creatures can be spawned with the debugcommand ""createstaticcreature weenieClassId"" and are then saved as a static spawn to the database.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/218/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220377264,MDExOlB1bGxSZXF1ZXN0MTE0OTMyNzAz,219,"Further Animation/Motion work, half-working combat stance changing",12808515,Zegeger,closed,0,,,,,0,2017-04-08T05:26:57Z,2017-04-09T02:55:52Z,2017-04-08T14:49:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/219,"Added basic motion classes.
Added current motion state to PhysicsData, which can now be sent in CreateObject messages.
Updated GameEventUpdateMotion to use these new classes.
Updated any areas that were affected.
Basic Combat Stance changing.  Can go into UA.  For some reason, you can't get out right now.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/219/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220391106,MDExOlB1bGxSZXF1ZXN0MTE0OTQwNDAz,220,Creature stats 01,26508216,Lidefeath,closed,0,,,,,0,2017-04-08T10:29:52Z,2017-05-02T12:14:13Z,2017-04-10T11:07:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/220,New PR so hopefully AppVeyor won't complain this time.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/220/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220488172,MDExOlB1bGxSZXF1ZXN0MTE0OTk1NzU4,221,Feature: Added sound and visual effect broadcasting landblocks,37453,fantoms,closed,0,,,,,0,2017-04-09T18:14:14Z,2017-05-23T15:52:49Z,2017-04-10T11:17:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/221,"- Utilizes player `ActionQueue`, to play sounds.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/221/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220496173,MDU6SXNzdWUyMjA0OTYxNzM=,222,Teleport no longer applies rotation to Position,11369233,LtRipley36706,closed,0,,,,,0,2017-04-09T20:21:37Z,2017-04-10T11:37:03Z,2017-04-10T11:37:03Z,MEMBER,,,,"Session.Player.Teleport always ends up with 1 0 0 0 for the Quaternion regardless of what the actual position sent in to it specified.

This is a recent change that was not present previously.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/222/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
220501245,MDExOlB1bGxSZXF1ZXN0MTE1MDAzMjc5,223,"Updated Marketplace, Lifestone Recalls + Lifestone animation",11369233,LtRipley36706,closed,0,,,,,0,2017-04-09T21:38:06Z,2017-04-21T03:49:01Z,2017-04-10T11:27:03Z,MEMBER,,0,ACEmulator/ACE/pulls/223,"If anyone can point me to a PCAP of using a lifestone outside of a training hall, I'd very much like to verify it against what I've seen so far. I feel like there could possibly be a message sent to the client that doesn't occur inside the training hall due to its unique nature, regarding lifestone attuning.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/223/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220517521,MDExOlB1bGxSZXF1ZXN0MTE1MDEyNDI4,224,"Inventory Part 2 - Create, Drop and Pickup",25460553,ogmage78,closed,0,,,,,1,2017-04-10T01:39:16Z,2017-04-14T19:37:14Z,2017-04-10T11:32:32Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/224,"This is a minor extension of the work I was doing previously, but it did turn up a number of good to know items.   

1.  When you are dropping an item, you have to increment the portal sequence - the client treats items being added to 3D space like a teleport.   It is on overloaded flag.   God, do I hate that.

1. There was some optimization code in player that was checking ""check for a short circuit.  if we don't need to update, don't!""   This has a bug in it that I could not quite fix.   I commented it out for now with a big TODO.   It never sends an update on object create or update after the initial object creation.   We are missing updating the LastUpdatedTicks somewhere.

1. In Landblock - I added a lambda expression to omit sending the stop tracking message if we are the one putting the item into our container.   Everyone else needs to forget about it, but it is still mine. 

Next steps:

- [ ] Put in code to move to the object being picked up.

- [ ] Check for success and respond to item no longer there

- [ ] Save off player inventory items to the database

- [ ] Load inventory items on player load.


","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/224/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220524540,MDExOlB1bGxSZXF1ZXN0MTE1MDE2OTIw,225,Changed Serialize to correct rotation problem,11369233,LtRipley36706,closed,0,,,,,0,2017-04-10T02:48:45Z,2017-04-21T03:48:58Z,2017-04-10T11:37:03Z,MEMBER,,0,ACEmulator/ACE/pulls/225,"Fixes #222

TBH, I don't totally feel I understand how flags work but two things seemed off to me in how Serialize was working.

For the ZeroQ[w,x,y,z] I changed != to == because I didn't get why when ZeroQx was set why we were sending 0s in for example and it also didn't make sense to me that RotationZ was coming after Placement... 

In making those changes, I resolved the rotation issue, but I'd very much like others to verify this didn't somehow break something else.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/225/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220709475,MDExOlB1bGxSZXF1ZXN0MTE1MTQ3Njg0,226,Fix for Animations,11369233,LtRipley36706,closed,0,,,,,1,2017-04-10T17:06:03Z,2017-04-21T03:48:55Z,2017-04-11T14:37:56Z,MEMBER,,0,ACEmulator/ACE/pulls/226,"Not sure why this sequence was changed, but this fixes the issue.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/226/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220749461,MDExOlB1bGxSZXF1ZXN0MTE1MTc2Nzkz,227,Fix GameActionType.QueryHealth for targets in adjacent landblocks and…,26508216,Lidefeath,closed,0,,,,,2,2017-04-10T19:43:38Z,2017-05-02T12:14:15Z,2017-04-12T11:16:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/227,… remove the old HandleUpdateHealth code which somehow was still in master.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/227/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220798868,MDU6SXNzdWUyMjA3OTg4Njg=,228,Better Handling for Disconnects,11369233,LtRipley36706,closed,0,12808515,Zegeger,,,2,2017-04-10T23:30:47Z,2017-07-31T18:51:43Z,2017-07-31T18:51:43Z,MEMBER,,,,Clients that disconnect do not always get removed from world and sessions.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/228/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
220806148,MDExOlB1bGxSZXF1ZXN0MTE1MjE4MjIw,229,Update to use Action Queue - Requested Changes Made 4/14/2017,25460553,ogmage78,closed,0,,,,,2,2017-04-11T00:23:15Z,2017-04-23T21:25:19Z,2017-04-18T00:46:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/229,Can someone with more experience with Action Queue take a look at the file Landblock and the  case GameActionType.DropItem:       I don't want to refactor all of my stuff until someone can tell me if this looks correct.   It complies and works fine.   I would just like a sanity check.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/229/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220807745,MDExOlB1bGxSZXF1ZXN0MTE1MjE5NDE2,230,MovementEvent Action Queue,11369233,LtRipley36706,closed,0,,,,,0,2017-04-11T00:36:20Z,2017-04-21T03:48:51Z,2017-04-12T13:00:39Z,MEMBER,,0,ACEmulator/ACE/pulls/230,Ideally this is merged after #226 if this acceptable for merging.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/230/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
220811945,MDU6SXNzdWUyMjA4MTE5NDU=,231,Teleporting players are not removed from client if player teleports to another dungeon,11369233,LtRipley36706,closed,0,,,,,3,2017-04-11T01:11:32Z,2018-03-06T20:03:14Z,2018-03-06T20:03:14Z,MEMBER,,,,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/231/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
220838658,MDU6SXNzdWUyMjA4Mzg2NTg=,232,Objects don't appear correctly until on top of them,11369233,LtRipley36706,closed,0,,,,,1,2017-04-11T04:47:35Z,2017-04-23T18:12:33Z,2017-04-23T18:12:33Z,MEMBER,,,,"Some portals/lifestones are not appearing until right on top of them or past them.

Repo:
@telepoi candeth keep
run straight to tree

note the very late appearance of some of the objects.. if you turn around and run back toward the entrance, one of the portals blinks and resets as well.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/232/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
220951042,MDU6SXNzdWUyMjA5NTEwNDI=,233,Issues with second client,25460553,ogmage78,closed,0,,,,,2,2017-04-11T13:26:22Z,2017-07-26T16:50:15Z,2017-07-26T16:50:15Z,CONTRIBUTOR,,,,"When more than one person is logged on to the server, the second person never comes out of portal space until they move.   This may be an incorrect setting of contact.   Also under the same use case - if 2 clients are logged in, from the perspective of each client - the other jumps and briefly does the falling animation with every movement.   In looking at live world pcaps, it looks like almost all movements have the contact flag set to true.   It looks to be that way in ours.   I am putting this here so it is documented - if anyone has time to look for this great - if not, I will try to see if I can debug it.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/233/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
220952882,MDU6SXNzdWUyMjA5NTI4ODI=,234,Create Test Script and add to project,25460553,ogmage78,open,0,,,,,3,2017-04-11T13:32:35Z,2019-08-27T00:11:54Z,,CONTRIBUTOR,,,,"As each of us is working on different parts at different times, it would be useful to have a document like our read me or change log where we could put tests and expected results for our areas.   That way prior to submitting a PR you could run through the test to make sure your change did not break the world.   

Quick example:   Test item pickup and drop
1. Log in on 2 characters ( we need to test what other clients are seeing)
2. On client 1 in the chat window type @ctw me
3. Take the wand and drop it to the ground.
a. Did both clients see and here the drop?   Do you see the wand on the ground from both clients.   Did client 1 do the animation to set the wand on the ground.   Is the item out of the backpack for client 1?
4. Pick up the wand.   Is the wand gone for client 2 and in the backpack of client 1.   Did you see the animation from both clients.   Did you hear the pickup sound.


","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/234/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,issue
220965499,MDExOlB1bGxSZXF1ZXN0MTE1MzMwMjg1,235,Dat reader - creating a PR so I can comment.,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-04-11T14:12:37Z,2017-04-23T02:03:21Z,2017-04-13T00:04:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/235,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/235/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221393225,MDExOlB1bGxSZXF1ZXN0MTE1NjM3ODc2,236,Concept review: Broadcast Generic Messages for Effects and Sounds,37453,fantoms,closed,0,,,,,2,2017-04-12T21:16:50Z,2017-06-28T19:46:54Z,2017-04-18T14:26:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/236,"Please comment and discuss the code below -

The code length was getting quite large for landblock action queue broadcasting, so I came up with a generic solution that packs any `GameMessage` inside of an `OutboundMessageArgs` object.

This allows for any `GameMessage` to potentially be sent over the `Landblock` `Broadcast` function.

I also implemented changes in landblock to broadcast the effects and sounds, with generic functions.

PLEASE NOTE: One obstacle that this method does not address, is per session sequences. If a Game Message has been extended into another message type (like `GameEventPlayerKilled`), then the initial sequence for the source session will be used. This does not matter for game messages that do not use sequences, like effects or sounds, but a solution will need to created to address this issue. This also means that the PlayerKilled message is currently bugged in this PR.

The functionality that was worked on to produce the proof of concept, are effects and sounds, so when reviewing you may find it useful to start your breakpoints at `ActionApplyVisualEffect`.

All discussion is welcome for this PR - Thanks!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/236/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221690158,MDExOlB1bGxSZXF1ZXN0MTE1ODQ4OTcw,237,Creature kill corpse - For review - NOT ready for a merge,26508216,Lidefeath,closed,0,,,,,1,2017-04-13T21:42:22Z,2017-04-13T22:20:45Z,2017-04-13T22:20:45Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/237,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/237/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221699510,MDExOlB1bGxSZXF1ZXN0MTE1ODU2MDA5,238,Creature kill and corpse spawn,26508216,Lidefeath,closed,0,,,,,1,2017-04-13T22:32:21Z,2017-04-15T15:09:00Z,2017-04-15T15:09:00Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/238,"As discussed with fantom, I'll resubmit it as a real PR so everyone can play around with it.
Usage: target drudge, type /smite -> drudge dead and corpse spawns","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/238/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221953958,MDExOlB1bGxSZXF1ZXN0MTE2MDI4MzQ5,239,Creature kill corpse v2,26508216,Lidefeath,closed,0,,,,,1,2017-04-15T15:12:02Z,2017-05-02T12:13:57Z,2017-04-18T11:20:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/239,This is the new version of the creature kill and corpse spawning with the smite command. Now the animations work without a sleep command but by introducing delays into the GameActionQueue. More details in the changelog.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/239/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221967995,MDExOlB1bGxSZXF1ZXN0MTE2MDM2MzM4,240,Feature update: Death - do not merge,37453,fantoms,closed,0,,,,,0,2017-04-15T19:34:32Z,2017-06-28T19:47:00Z,2017-04-21T12:47:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/240,"This is an update to the player death mechanics.

- Adding player death broadcasts initial code
- Adding the game message for player killed
- Added player messages and events
- Death messages are now on the action queue
- Added you have/name has to message
- Added queued teleport too landblocks
- Added properties to character and added to player kill
- Changed vitae till I find a the formula
- Update health to resurect
- Changed order of broadcasts
- Added game event for purgeing character enchantments on death
- Implemented a more Proper death, ie deathV2
- Limit death rebroadcast by landblock
- Used correct health update

Please take a good look at the action queue and tell me if you know of a better way to add the events to the queue, specifically line 439 of the landblocks.cs file.

- Also note that there were some CR:LF problems on a few files, from previous commits.

- Another known issue to note: if you use `/die` in a landblock adjacent to a lifestone, an adjacent player may see the death message multiple times.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/240/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221975663,MDExOlB1bGxSZXF1ZXN0MTE2MDQwNzEz,241,Add @acehelp and @acecommands,11369233,LtRipley36706,closed,0,,,,,0,2017-04-15T22:09:30Z,2017-04-21T03:48:46Z,2017-04-18T01:32:37Z,MEMBER,,0,ACEmulator/ACE/pulls/241,"Should this PR be accepted, I would expect going forward all commands added to or implemented by the CommandManager should be required to have Description and Usage attributes properly set to be accepted for PR merge.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/241/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
221993052,MDU6SXNzdWUyMjE5OTMwNTI=,242,Missing character position crashes server,11369233,LtRipley36706,closed,0,,,,,0,2017-04-16T06:05:17Z,2017-04-23T18:12:27Z,2017-04-23T18:12:27Z,MEMBER,,,,"Deleting a character's position of PositionType=1 causes server to crash when character is loaded.

Background for this:
I used @spacejump command which put me in an endless portal (command should probably be removed or fixed). I figured I'd just delete that character's current position and it would default back to fallback position but it did not work. Probably needs some logic built in the load-in if no current position is in the db to reset to a safe location, either lifestone if set and failing that probably holtburg drop (or race specific starter town drop).

cc: @fantoms ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/242/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
222023780,MDExOlB1bGxSZXF1ZXN0MTE2MDY2MDAw,243,Fix: Position missing update and LandblockId db object fix,37453,fantoms,closed,0,,,,,1,2017-04-16T18:03:36Z,2017-05-23T15:55:24Z,2017-04-18T01:28:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/243,"This code was created to address issue #242.

-Fixed bugs in `LandblockId` in position and server now resets the  position if missing.
-Added checks to prevent a missing location from crashing the server.
-Removed unnecessary `lastportal` recall position save, this is set on demand, this also prevents invalid data from entering the database.

Please give this a test by deleting a previously created character's position location (position type 1) and then try logging in, you should be at the current starting dungeon.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/243/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222246208,MDExOlB1bGxSZXF1ZXN0MTE2MjEzNzc2,244,SomeIdeas,25387933,Forbiddenz,closed,0,,,,,0,2017-04-17T22:12:37Z,2017-05-03T19:11:14Z,2017-04-17T22:13:58Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/244,"This is broken, don't merge..

Any one got any ideas to why this streaming is working with players but not static objects...
Also ideas to improve it are welcome.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/244/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222247006,MDExOlB1bGxSZXF1ZXN0MTE2MjE0MzM5,245,"Streaming Only seems to be working for players, within range of x.  S…",25387933,Forbiddenz,closed,0,,,,,0,2017-04-17T22:16:34Z,2017-05-03T19:11:08Z,2017-04-19T21:05:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/245,"Don't merge, looking for ideas on improving the landblock .
Adding in streaming, but it only seems to work for players..

Looking for some ideas on improvement also bugs..
Why it wont work for all objects.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/245/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222318272,MDU6SXNzdWUyMjIzMTgyNzI=,246,CreateObject message needs work,11369233,LtRipley36706,closed,0,,,,,0,2017-04-18T06:45:27Z,2017-04-19T11:41:16Z,2017-04-19T11:41:16Z,MEMBER,,,,"Jyrus pointed out a problem with portals in town network.

To comfirm, I loaded into ACE and issued teleloc command `/teleloc 00070145 70.10 -83.07 0.10 1.00 0.00 0.00 -0.01` to arrive in Town Network and found portals to be majorly flawed.

PCAPs filled will exceptions.

Attaching files of retail pcap, plus export scripts, plus pcap from ace
[output.zip](https://github.com/ACEmulator/ACE/files/927568/output.zip)

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/246/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
222409472,MDExOlB1bGxSZXF1ZXN0MTE2MzIyMTQ1,247,major restructuring of object heirarchy.  please review.,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-04-18T13:02:50Z,2017-04-18T17:09:52Z,2017-04-18T17:09:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/247,"major restructuring of objects.  verified login works, and that lifestones/portals appear.  can still use lifestones.  A lot of plumbing work to be done on new types.

Unfinished / TODO / Known uglies:
* Update Landblock to use new OnUse / OnCollide methods
* Remove previous ""Use"" code (I'm looking at you, Lifestones)
* Fix/Overhaul CreatureAbility shenanigans in Player/Character/Creature classes.  It's a hacky mess right now.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/247/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222454193,MDExOlB1bGxSZXF1ZXN0MTE2MzU0MzMw,248,"Creature respawn, corpse despawn, random spawns",26508216,Lidefeath,closed,0,,,,,0,2017-04-18T15:25:19Z,2017-05-02T12:14:04Z,2017-04-19T12:21:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/248,"Corpses will despawn after a set amount of time for testing. The retail calculation for the despawn time is currently commented out. Creatures will respawn after a set amount of time too.
Introduced loading randomly generated spawns from the database. See changelog on which table to edit to alter the location.

Please don't mind the Remove Whitespaces commit that was an attempt to get my git to do what I wanted :-)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/248/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222469087,MDExOlB1bGxSZXF1ZXN0MTE2MzY1Mzk5,249,Usable portals,10137,ghost,closed,0,,,,,0,2017-04-18T16:13:24Z,2017-10-18T14:07:43Z,2017-04-18T17:11:24Z,NONE,,0,ACEmulator/ACE/pulls/249,Includes the Drudge Hideout portal pair in the new portal destination DB table,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/249/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222487087,MDExOlB1bGxSZXF1ZXN0MTE2Mzc4Mjgz,250,Add Misc Object,11369233,LtRipley36706,closed,0,,,,,3,2017-04-18T17:20:40Z,2017-04-21T03:48:40Z,2017-04-19T06:53:58Z,MEMBER,,0,ACEmulator/ACE/pulls/250,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/250/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222524134,MDExOlB1bGxSZXF1ZXN0MTE2NDA1MjE1,251,Added Folders to Project Structure to make maintaining and developing easier,25387933,Forbiddenz,closed,0,,,,,4,2017-04-18T19:43:51Z,2017-05-03T19:10:42Z,2017-04-19T11:41:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/251,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/251/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222548211,MDExOlB1bGxSZXF1ZXN0MTE2NDIyNjQ5,252,F74C 0x0006 - MoveToObject - Not for merging Comment only,25460553,ogmage78,closed,0,,,,,0,2017-04-18T21:16:22Z,2017-04-19T21:01:19Z,2017-04-19T21:01:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/252,"The PCAP looks fine - if anyone can take a look and suggest where I am going wrong it would be appreciated.   To test - just log in and type @moveto   that will spawn a wand 10 meters in front of you.   Your guy will twitch and turn toward it - but he will not head over there.   I have commented where I have some hard coded values.   Thanks
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/252/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222586754,MDU6SXNzdWUyMjI1ODY3NTQ=,253,Regression:  New Characters are starting with vitals 0/XX,1765994,Gordian3,closed,0,,,,,1,2017-04-19T00:59:12Z,2017-04-26T16:38:11Z,2017-04-26T16:38:11Z,CONTRIBUTOR,,,,"When creating a character and entering the training hall, the characters should start at maximum current vitals for Health, Stamina and Mana.

This is a regression.  Seen 4/18 using origin\master and a fresh DB, account and character.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/253/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
222587429,MDU6SXNzdWUyMjI1ODc0Mjk=,254,Add support for vitals regeneration,1765994,Gordian3,closed,0,,,,,3,2017-04-19T01:04:44Z,2017-07-31T18:52:32Z,2017-07-31T18:52:32Z,CONTRIBUTOR,,,,"There is currently no support for a character to regenerate vitals to the current maximum values of the character.   This issue is asking for a mechanism to be added for the server to periodically increment these values and pass them along to the client session owning the character.

Mostly this would be visible after @grantxp and adding to any vital.

TBD:  Do we need to broadcast the vitals increases to other accounts on the landblock (or adjacent landblock)?

This regen mechanism can have the actual formula for the amount of regen or that can be left as a TBD and just use a default value.  If not done for this issue, then please create a new issue.

On logout or other client disconnect, the periodic vital increases should stop.

Do not increase beyond the current maximums (would account for debuffs or vitae if implemented)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/254/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
222597749,MDExOlB1bGxSZXF1ZXN0MTE2NDU3Mzk0,255,"Phase 1 Refactor of Session, NetworkSession, Action handlers",12808515,Zegeger,closed,0,,,,,2,2017-04-19T02:22:02Z,2017-04-21T03:40:54Z,2017-04-21T03:09:45Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/255,"Merged SocketManager into WorldManager
Made Session inherit from NetworkSession, flattening the model
Moved GameMessage handlers into Session class, partial classes
Moved GameAction handlers into Player class, partial classes
This move makes functionality encapsulated into these classes, allowing a move to fewer public members.
Phase 2 will be to build on WorldObject model to improve queued game actions, broadcast, and action ordering/timing.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/255/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222657582,MDExOlB1bGxSZXF1ZXN0MTE2NDkyOTMw,256,Updated PhysicsData,11369233,LtRipley36706,closed,0,,,,,0,2017-04-19T08:23:18Z,2017-04-21T03:48:26Z,2017-04-19T11:41:16Z,MEMBER,,0,ACEmulator/ACE/pulls/256,"Partially fixes #246.

Need to look further at the portals found here
`/teleloc 0x00070163 85.16493988 -39.95851898 0.005 0.78485435 -0.61968029 0 0`

which would carry over to Portal to Town Network portals found on surface in towns.

@Lidefeath pointed this fix resolve issues with his creature spawning so I applied it to the main serializer which then corrected a lot of the exception errors being show in ACLogView","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/256/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222844160,MDExOlB1bGxSZXF1ZXN0MTE2NjIyODI2,257,More CreateObject Fixes,11369233,LtRipley36706,closed,0,,,,,0,2017-04-19T19:25:39Z,2017-04-21T03:48:22Z,2017-04-19T23:00:47Z,MEMBER,,0,ACEmulator/ACE/pulls/257,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/257/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222871197,MDExOlB1bGxSZXF1ZXN0MTE2NjQxNjQw,258,Streaming objects,25387933,Forbiddenz,closed,0,,,,,1,2017-04-19T21:04:23Z,2017-05-03T19:10:38Z,2017-04-23T01:18:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/258,"Streaming Objects now seem to be fully working.
Needs testers!  could cause some code elsewhere to have some issues..

Maybe teleport needs to clear this, not to sure on that yet.
But working pretty good.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/258/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
222896954,MDExOlB1bGxSZXF1ZXN0MTE2NjU5NTAw,259,Bring WritePackedDWORD to ACE,11369233,LtRipley36706,closed,0,,,,,0,2017-04-19T23:00:37Z,2017-04-21T03:48:18Z,2017-04-19T23:03:08Z,MEMBER,,0,ACEmulator/ACE/pulls/259,"This continues to address issue #246 

More things will need to be converted to PackedDWORD to fully squash the createobject errors.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/259/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223074145,MDExOlB1bGxSZXF1ZXN0MTE2Nzc1ODQ4,260,Packed dword fixes,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-20T13:50:38Z,2017-04-20T13:54:37Z,2017-04-20T13:54:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/260,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/260/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223140331,MDExOlB1bGxSZXF1ZXN0MTE2ODIzMTI2,261,"packing known dword types (ie, Icons)",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-04-20T17:23:49Z,2017-04-20T17:26:55Z,2017-04-20T17:26:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/261,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/261/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223146984,MDExOlB1bGxSZXF1ZXN0MTE2ODI3OTg2,262,Changed IconOverlay and IconUnderlay to use WritePackedDwordOfKnownType.,11369233,LtRipley36706,closed,0,,,,,0,2017-04-20T17:50:13Z,2017-04-21T03:48:16Z,2017-04-20T17:53:25Z,MEMBER,,0,ACEmulator/ACE/pulls/262,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/262/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223153004,MDExOlB1bGxSZXF1ZXN0MTE2ODMyMTcy,263,Changed ModelData.Serialize to use WritePackedDwordOfKnownType,11369233,LtRipley36706,closed,0,,,,,0,2017-04-20T18:12:15Z,2017-04-21T03:48:12Z,2017-04-20T18:19:10Z,MEMBER,,0,ACEmulator/ACE/pulls/263,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/263/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223173577,MDExOlB1bGxSZXF1ZXN0MTE2ODQ2NTE3,264,"Removed the manual conversion for Model, Texture and PaletteData in …",26508216,Lidefeath,closed,0,,,,,0,2017-04-20T19:27:54Z,2018-05-31T12:20:31Z,2017-04-20T19:47:31Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/264,Creature.cs and fix the necessary code parts for it.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/264/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223225466,MDExOlB1bGxSZXF1ZXN0MTE2ODgxNDk1,265,Filled out Portal object and included ObjScale.,11369233,LtRipley36706,closed,0,,,,,0,2017-04-20T22:58:07Z,2017-04-21T16:23:16Z,2017-04-21T12:52:04Z,MEMBER,,0,ACEmulator/ACE/pulls/265,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/265/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223262843,MDExOlB1bGxSZXF1ZXN0MTE2OTA0MTY3,266,"Phase 1 Refactor of Session, NetworkSession, Action handlers",12808515,Zegeger,closed,0,,,,,0,2017-04-21T03:12:10Z,2017-04-21T03:40:33Z,2017-04-21T03:31:21Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/266,"Merged SocketManager into WorldManager
Made Session inherit from NetworkSession, flattening the model
Moved GameMessage handlers into Session class, partial classes
Moved GameAction handlers into Player class, partial classes
This move makes functionality encapsulated into these classes, allowing a move to fewer public members.
Phase 2 will be to build on WorldObject model to improve queued game actions, broadcast, and action ordering/timing.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/266/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223265469,MDExOlB1bGxSZXF1ZXN0MTE2OTA1NjY1,267,"Phase 1 Refactor of Session, NetworkSession, Action handlers",12808515,Zegeger,closed,0,,,,,0,2017-04-21T03:31:30Z,2017-04-24T01:58:02Z,2017-04-24T01:58:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/267,"Merged SocketManager into WorldManager
Made Session inherit from NetworkSession, flattening the model
Moved GameMessage handlers into Session class, partial classes
Moved GameAction handlers into Player class, partial classes
This move makes functionality encapsulated into these classes, allowing a move to fewer public members.
Phase 2 will be to build on WorldObject model to improve queued game actions, broadcast, and action ordering/timing.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/267/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223284662,MDExOlB1bGxSZXF1ZXN0MTE2OTE2NjYw,268,Kill UpdateObject sending until we use it right.,11369233,LtRipley36706,closed,0,,,,,1,2017-04-21T05:56:20Z,2017-04-21T16:23:08Z,2017-04-21T12:54:55Z,MEMBER,,0,ACEmulator/ACE/pulls/268,…y other things which leads to issues.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/268/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223364430,MDExOlB1bGxSZXF1ZXN0MTE2OTcxMTkz,269,Removed @reset-pos again,37453,fantoms,closed,0,,,,,0,2017-04-21T12:07:09Z,2017-05-23T15:55:21Z,2017-04-21T12:55:18Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/269,"The `@reset-pos` command was removed in pr #243, but was re-added back in with Ripley's command text update commit 679b0814. If this is needed, please close this request; but I would like to remove this command too prevent invalid positions from being set as the `Location` position in the database.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/269/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223427384,MDExOlB1bGxSZXF1ZXN0MTE3MDE3Mzc3,270,Fix IsDerivedPlayer logic to allow smite to work,37453,fantoms,closed,0,,,,,0,2017-04-21T16:02:26Z,2017-05-23T15:55:19Z,2017-04-23T17:32:14Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/270,"This was always true, due to a changes I made last night to the Creature Kill command. The changes made the Creatures also work like a player, but after I made this change, the types can now differentiate; allowing `@smite` and `@smite all` began to work correctly again. ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/270/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223472023,MDExOlB1bGxSZXF1ZXN0MTE3MDQ5NTYw,271,State machines,25387933,Forbiddenz,closed,0,,,,,2,2017-04-21T19:14:38Z,2017-05-01T09:24:17Z,2017-05-01T09:24:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/271,"State Machines - I built this off steaming, so it should go on top of that.
-- I got no way to tested it good yet, but it looks good from code point of view.

We need some things that use state machines, like doors!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/271/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223543981,MDExOlB1bGxSZXF1ZXN0MTE3MDk3OTU2,272,Fix the four Q variables to DB field mappings; Add 88 more working po…,10137,ghost,closed,0,,,,,0,2017-04-22T06:22:17Z,2017-10-18T14:07:45Z,2017-04-23T01:21:22Z,NONE,,0,ACEmulator/ACE/pulls/272,…rtals,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/272/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223578476,MDExOlB1bGxSZXF1ZXN0MTE3MTE3Mzg2,273,Read the Generators from portal.dat file 0x0E00000D and enhance DatRe…,26508216,Lidefeath,closed,0,,,,,1,2017-04-22T17:09:05Z,2017-05-01T16:41:02Z,2017-04-24T11:23:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/273,…ader to handle obfuscated strings.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/273/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223610703,MDExOlB1bGxSZXF1ZXN0MTE3MTM1Mzky,274,Added ClothingTable object and loaded Startup Gear on characters. ,26606778,OptimShi,closed,0,,,,,0,2017-04-23T03:58:00Z,2017-04-23T17:39:55Z,2017-04-23T17:39:55Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/274,"Other minor misc updates/fixes relating to character display.
Moved ""DatManager"" initialization earlier in the process to prevent folks attempting to login prior to the dat files being loaded (since they are required now).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/274/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223659394,MDExOlB1bGxSZXF1ZXN0MTE3MTYxMzkz,275,Added 65 more portals,24981658,MiachofTD,closed,0,,,,,1,2017-04-23T19:04:28Z,2017-04-23T20:50:42Z,2017-04-23T19:43:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/275,"Added portals for areas -
Yaraq - Starting Town
Zaikhal - Capital
Al-Arqas
Al-Jalima
Ayan Baqur
Khayyaban","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/275/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223666025,MDExOlB1bGxSZXF1ZXN0MTE3MTY1MTI0,276,Additional 64 portals,24981658,MiachofTD,closed,0,,,,,0,2017-04-23T20:45:57Z,2017-04-23T20:58:06Z,2017-04-23T20:58:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/276,"Added portals for Gharu areas Part 1-
Yaraq - Starting Town
Zaikhal - Capital
Al-Arqas
Al-Jalima
Ayan Baqur
Khayyaban","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/276/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223667554,MDExOlB1bGxSZXF1ZXN0MTE3MTY1OTkx,277,Added 64 portals for Gharu towns Part 1,24981658,MiachofTD,closed,0,,,,,0,2017-04-23T21:09:20Z,2017-04-28T03:29:50Z,2017-04-24T03:38:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/277,"Yaraq - Starting Town
Zaikhal - Capital
Al-Arqas
Al-Jalima
Ayan Baqur
Khayyaban","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/277/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223669620,MDExOlB1bGxSZXF1ZXN0MTE3MTY3MTYw,278,Initial work on MoveToObject & MoveToPosition.   Ready for merge,25460553,ogmage78,closed,0,,,,,2,2017-04-23T21:44:13Z,2017-04-25T11:51:16Z,2017-04-25T11:51:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/278,"* Added MoveToObject GameMessageUpdateMotion (F74C 0x006)   This is part of a total of 5 variants on the F74C message.
* Can be tested with the new debug command MoveTo <40>  - the parameter is optional.   The default is 30 if you do not put a parameter.   You can test the walk run
* by setting any distance for the wand to spawn under 15.  If you use moveto 10 - your character will walk to the wand.    If you type moveto 90 - he will run a long way.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/278/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223672535,MDExOlB1bGxSZXF1ZXN0MTE3MTY4NzYx,279,More portal work,10137,ghost,closed,0,,,,,0,2017-04-23T22:33:32Z,2017-04-24T04:09:50Z,2017-04-24T04:09:27Z,NONE,,0,ACEmulator/ACE/pulls/279,"Hope it isn't too much if-then'ing.  I did use some switch statements, where it looked appropriate.  Much of this UseItem for the portals, if not all, should eventually be moved into Portal.cs, within the OnCollide method.  However, it may take passing more than just the player object into the OnCollide method to make it work, as I have constructed the statement block for making portals work.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/279/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223686108,MDExOlB1bGxSZXF1ZXN0MTE3MTc2OTQ2,280,Update: Vitals,37453,fantoms,closed,0,,,,,1,2017-04-24T01:54:42Z,2017-05-23T15:51:15Z,2017-04-24T05:11:23Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/280,"* Working on Vitals, Changed `Current` to `UnbuffedValue` for the `ICreatureStats` interface within `Character.cs`

* Added a health update message for abilities, so endurance can properly change the health/steam, when increased.

* `@heal` should now work again.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/280/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223693997,MDExOlB1bGxSZXF1ZXN0MTE3MTgyMTcx,281,A few portals i did to make sure i understand github ect.,9624180,Jyard1,closed,0,,,,,2,2017-04-24T03:11:57Z,2017-04-25T09:32:52Z,2017-04-25T09:24:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/281,Banderling Hovel and Shou-zn settlement portal.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/281/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223699030,MDExOlB1bGxSZXF1ZXN0MTE3MTg1NDU0,282,Added information to changelog and appveyor,24981658,MiachofTD,closed,0,,,,,0,2017-04-24T04:01:48Z,2017-04-28T03:29:59Z,2017-04-24T04:05:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/282,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/282/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223702260,MDExOlB1bGxSZXF1ZXN0MTE3MTg3Njcx,283,More portal work,10137,ghost,closed,0,,,,,0,2017-04-24T04:37:59Z,2017-04-24T05:26:01Z,2017-04-24T05:25:22Z,NONE,,0,ACEmulator/ACE/pulls/283,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/283/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223708268,MDExOlB1bGxSZXF1ZXN0MTE3MTkxNTY5,284,"Add portals, portal routing, and updates to 2 previous portals",10137,ghost,closed,0,,,,,0,2017-04-24T05:36:34Z,2017-04-24T13:46:19Z,2017-04-24T13:45:56Z,NONE,,0,ACEmulator/ACE/pulls/284,"As noted in the changelog, PHPMYADMIN does not like the ON DUPLICATE KEY UPDATE statements in the sql file; however, I personnally had success using SQLyog.  From my reading MySQL ( MariaDB ) should be able to accept the commands, as they are valid MySQL statements, from its command line.  I would guess that HeidiSQL supports them, also.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/284/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223724477,MDExOlB1bGxSZXF1ZXN0MTE3MjAxNzgw,285,Add 16 more portals from around Shoushi,9624180,Jyard1,closed,0,,,,,2,2017-04-24T07:17:19Z,2017-04-25T10:25:39Z,2017-04-25T10:25:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/285,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/285/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223740276,MDExOlB1bGxSZXF1ZXN0MTE3MjExMzcw,286,Added currentMotionState and support within ACE,11369233,LtRipley36706,closed,0,,,,,0,2017-04-24T08:27:08Z,2017-06-17T04:04:34Z,2017-04-24T12:46:27Z,MEMBER,,0,ACEmulator/ACE/pulls/286,"* Added currentMotionState to base_ace_object in ace_world database.
* Changed location in base_ace_object to an INT(10) in ace_world database.
* Changed vw_ace_creature_object and vw_ace_object to include currentMotionState.
* Added CurrentMotionState to BaseAceObject and linked it to currentMotionState.
* Added a method to GeneralMotion to convert from a byte array to GeneralMotion object.
* Added DebugObject to assist with building and testing out real objects for world.
* Changed GenericObjectFactory to spawn DebugObjects as a default if running server in DEBUG.
* Fixed Code Style issues within ClothingTable.cs and ClothingBaseEffect.cs in ACE.DatLoader.
* Changed Position to set Z to 0 to fix @tele command.
* Removed PlayScript.Create from landblock respawn section. Players should not have that effect applied to them.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/286/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223894372,MDU6SXNzdWUyMjM4OTQzNzI=,287,Object streaming Issue,11369233,LtRipley36706,closed,0,,,,,7,2017-04-24T17:27:08Z,2018-03-25T07:29:46Z,2018-03-25T07:29:46Z,MEMBER,,,,"We need to key it off of more than just movement keys...

Example: @telepoi Holtburg
objects should already be there when you come out of portal, but don't appear until after you rematerialize.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/287/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
223952686,MDExOlB1bGxSZXF1ZXN0MTE3MzU4Nzc2,288,Land blocks - Diag Tools,25387933,Forbiddenz,closed,0,,,,,0,2017-04-24T21:12:21Z,2017-05-03T19:10:34Z,2017-05-02T17:41:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/288,"Type Diag from the console to start landblock diagnostics.
Start of loading, unloading landblocks.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/288/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223994300,MDExOlB1bGxSZXF1ZXN0MTE3Mzg4NTQ3,289,Move Portal and Lifestone logic into appropriate class; modify 3 port…,10137,ghost,closed,0,,,,,0,2017-04-25T01:29:02Z,2017-10-18T14:07:46Z,2017-04-25T12:04:21Z,NONE,,0,ACEmulator/ACE/pulls/289,…als; add 7 new portals,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/289/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
223998043,MDExOlB1bGxSZXF1ZXN0MTE3MzkxMDYx,290,Additional 30 portals,24981658,MiachofTD,closed,0,,,,,0,2017-04-25T02:00:05Z,2017-04-28T03:30:00Z,2017-04-25T12:11:32Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/290,"Qalaba'r 
Samsur 
Tufa
Uziz 
Xarabydun","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/290/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224031221,MDExOlB1bGxSZXF1ZXN0MTE3NDEwMDUw,291,Added XpTable class to ACE.DatLoader and removed the JSON Xp files. ,26606778,OptimShi,closed,0,,,,,0,2017-04-25T06:08:53Z,2017-04-27T03:33:42Z,2017-04-26T11:56:26Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/291,Some additional cleanup in the other DatLoader.FileTypes classes to make them easier to use.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/291/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224092899,MDExOlB1bGxSZXF1ZXN0MTE3NDUyMTc1,292,Added 16 portals around Shoushi.,9624180,Jyard1,closed,0,,,,,0,2017-04-25T10:32:51Z,2017-04-25T12:10:24Z,2017-04-25T12:10:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/292,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/292/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224153940,MDExOlB1bGxSZXF1ZXN0MTE3NDk1OTEx,293,Renamed 0010_2017_04_25_portal_destination.sql,24981658,MiachofTD,closed,0,,,,,0,2017-04-25T14:17:38Z,2017-04-25T15:08:52Z,2017-04-25T15:08:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/293,Renamed 0010_2017_04_25_portal_destination.sql to 010_2017_04_25_portal_destination.sql so that it would fall into the correct import order.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/293/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224174783,MDExOlB1bGxSZXF1ZXN0MTE3NTExMDYw,294,Renamed the last 3 SQL files to be in correct order,24981658,MiachofTD,closed,0,,,,,1,2017-04-25T15:17:29Z,2017-04-26T11:57:19Z,2017-04-26T11:57:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/294,Renamed the last 3 SQL files to be in correct order and made changes to changelog and MySqlInstall.bat file to reflect those changes.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/294/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224355414,MDExOlB1bGxSZXF1ZXN0MTE3NjM5MDUx,295,Rebased SQL scripts. World data will now be found in ACE-World.,11369233,LtRipley36706,closed,0,,,,,0,2017-04-26T06:19:22Z,2017-06-17T04:04:34Z,2017-04-26T12:05:20Z,MEMBER,,0,ACEmulator/ACE/pulls/295,See [ACE-World](https://github.com/ACEmulator/ACE-World/releases) for initial release of world database.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/295/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224529943,MDU6SXNzdWUyMjQ1Mjk5NDM=,296,Mana does not update when xp is spent on abilities that should increase it,11369233,LtRipley36706,closed,0,,,,,1,2017-04-26T16:39:33Z,2017-07-26T16:49:46Z,2017-07-26T16:49:46Z,MEMBER,,,,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/296/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
224594845,MDExOlB1bGxSZXF1ZXN0MTE3ODA2NTI2,297,Feature: Admin `@boot` command,37453,fantoms,closed,0,,,,,0,2017-04-26T20:49:05Z,2017-05-23T15:52:06Z,2017-05-01T12:00:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/297,"This request should allow a player or account holder, too be kicked from the server. There is an assumption that when the player is sent boot packet, the server will then receive a disconnect message from the client, where finally the server can process the session's finally ""log off"".","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/297/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224638870,MDExOlB1bGxSZXF1ZXN0MTE3ODM4ODk1,298,Display most recently used character as selected upon login.,26606778,OptimShi,closed,0,,,,,0,2017-04-27T00:49:48Z,2017-05-01T16:59:52Z,2017-04-27T19:25:55Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/298,"Renamed `character.birth` to `character.lastUpdate` and changed the Character list database function to use sort off of this field. 

Required SQL update file is in the Updates/Character folder. Also added it to the Appveyor mysql install.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/298/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224666901,MDExOlB1bGxSZXF1ZXN0MTE3ODU3OTg4,299,Feature: Admin `@teleto` command,37453,fantoms,closed,0,,,,,0,2017-04-27T04:39:59Z,2017-05-23T15:51:18Z,2017-04-27T19:22:59Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/299,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/299/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224928538,MDExOlB1bGxSZXF1ZXN0MTE4MDQzOTU5,300,Movement 2 - Ready for review and Merge,25460553,ogmage78,closed,0,,,,,1,2017-04-27T22:16:07Z,2017-05-01T03:45:57Z,2017-04-30T06:24:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/300,"* Added Turn to Object and Turn To Heading messages.
* Cleaned up earlier work
* You can now test move to object and put item in container.:
@ctw ground. 
Select wand
Move away from the area with the item still selected. Over 15f to see run under to see walk.
Press the use key - you will walk or run to the wand depending on your distance, then stop and pick it up.
Also implements the first use of StackOverflows state machine
Contains view for character - to start implementing orm for character
NOTE: There is a known bug if you create the training wand in your backpack and drop it, the move to does not work correctly yet. I think it is related to the landblock not doing updates atm.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/300/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
224988064,MDExOlB1bGxSZXF1ZXN0MTE4MDg1Nzk4,301,[WIP] feat: move project to dotnet core,595925,delasteve,closed,0,,,,,3,2017-04-28T06:05:14Z,2017-05-09T13:10:14Z,2017-05-09T13:10:14Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/301,"### Status
Work in progress

### Changes
- Replaced `Source` directory with `src` and `test`
- Moved respective projects into `src` and `test` directories
- Updated code to handle .NET Core, mainly `System.Reflection` changes
- Moved test projects to `Xunit`
- Moved `Database` into `scripts` directory

### To Do
- [ ] Re-enable `log4net`
- [ ] Re-enable StyleCop
- [ ] Fix MySql errors
- [ ] Fix up `scripts` dir
- [ ] Modify `appveyor.yml` to handle new build
- [ ] Add `.travis.yml` for linux and unix builds
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/301/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225222822,MDExOlB1bGxSZXF1ZXN0MTE4MjU2MjU2,302,chore: add github issue template,595925,delasteve,closed,0,,,,,0,2017-04-29T00:53:00Z,2017-04-30T11:48:13Z,2017-04-30T11:48:13Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/302,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/302/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225223417,MDExOlB1bGxSZXF1ZXN0MTE4MjU2NjU3,303,chore: update various git settings,595925,delasteve,closed,0,,,,,0,2017-04-29T01:02:02Z,2017-04-30T17:05:54Z,2017-04-30T14:23:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/303,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/303/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225223663,MDExOlB1bGxSZXF1ZXN0MTE4MjU2ODIz,304,chore: add editorconfig,595925,delasteve,closed,0,,,,,2,2017-04-29T01:05:58Z,2017-04-30T14:29:40Z,2017-04-30T14:29:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/304,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/304/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225231282,MDExOlB1bGxSZXF1ZXN0MTE4MjYxMzQ5,305,Hooked up the IdentifyObject event and returned a debug string.,26606778,OptimShi,closed,0,,,,,1,2017-04-29T03:55:11Z,2017-07-10T16:43:23Z,2017-05-02T13:09:30Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/305,Also added the flags for when we get to the point we are passing actual data.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/305/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225268144,MDExOlB1bGxSZXF1ZXN0MTE4MjgwNTg1,306,Portal class changes,10137,ghost,closed,0,,,,,2,2017-04-29T16:26:53Z,2017-05-02T14:04:12Z,2017-05-02T14:03:52Z,NONE,,0,ACEmulator/ACE/pulls/306,"* I did not combine base_ace_object, ace_object, ace_portal_object into one view at this juncture, as doing so would remove all portals that didn't have destinations set from the world, as the view would only show entries for portal objects that have data from all three tables present.

* In the portal object table restructuring, I added a foreign key constraint to the weenieClassId field that points to that field in the ace_object table.  This addition has the effect of not allowing the ace_portal_object table to be populated until the rest of the ace_world tables are filled.  I also included a portal object that was missing from the ACE-World DB release that was preventing the ace_portal_object table data from being imported.

* An apparent bug with the login position was revealed, when I added saving the PositionType.LastPortal position, when a portal was used.  When a player logs in, the PositionType.LastPortal position gets used, rather than the one saved during the character save action.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/306/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225285955,MDExOlB1bGxSZXF1ZXN0MTE4MjkwNjA1,307,Added Cloaking and simple open/close door usage.,11369233,LtRipley36706,closed,0,,,,,0,2017-04-29T21:19:03Z,2017-06-17T04:04:33Z,2017-05-01T12:16:46Z,MEMBER,,0,ACEmulator/ACE/pulls/307,"* Added @cloak command. Use this to bypass objects blocking your way. Partially implemented as was used in retail.
* Added Translucency to DebugObject. This fixes ghostly npcs.
* Changed GOF and Landblock to key off of ObjectDescriptionFlag first for at least some objects, made lots of changes to Door to allow for simple open/close usage.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/307/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225339586,MDExOlB1bGxSZXF1ZXN0MTE4MzE4ODgz,308,Re-added config.json to .gitignore,11369233,LtRipley36706,closed,0,,,,,0,2017-04-30T16:59:13Z,2017-06-17T04:04:31Z,2017-04-30T16:59:36Z,MEMBER,,0,ACEmulator/ACE/pulls/308,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/308/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225352372,MDExOlB1bGxSZXF1ZXN0MTE4MzI1Nzc4,309,Landblocks,26606778,OptimShi,closed,0,,,,,1,2017-04-30T20:32:10Z,2017-05-21T22:16:13Z,2017-05-01T12:20:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/309,"Added client_cell.dat reading for Landblocks and proper z value for @tele commands.

I attempted to add the client_cell.dat reading into the Position class itself, but this caused a cyclical reference. Not sure what the best way to address that is (or if there is even a need?)

Next step is to either complete the other sections of the client_cell.dat reading or to cache these. I don't like that it doesn't right now, since monsters & players & projectiles are going to generate an awful lot of file reads!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/309/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225379829,MDExOlB1bGxSZXF1ZXN0MTE4MzQyMTA5,310,Updated test code / Started initial work on character orm refactor,25460553,ogmage78,closed,0,,,,,1,2017-05-01T03:38:23Z,2017-05-01T05:07:02Z,2017-05-01T05:03:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/310,"2017-04-30
[Og II]

- Refactored ctw to cwo takes a new optional parameter of a weenieId. You can spawn anything in the database. @ctw me 21376 - will spawn Martine's Robe If no weenieId
is given, it gives you the old faithful training wand. 

- This does not include the turn to object code - I pulled that out due to a bug. I will submit via new PR.

- I cleaned up some unused using statements and refactored some misspelled works (US English) <apologies to our UK folks>   

- Magic numbers all gone - test code pulls from database.   ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/310/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225386094,MDExOlB1bGxSZXF1ZXN0MTE4MzQ2MTA0,311,"Reworked - Refactored debug commands, Expanded to spawn from weenie - started character orm.",25460553,ogmage78,closed,0,,,,,2,2017-05-01T05:07:13Z,2017-05-02T14:25:36Z,2017-05-02T14:25:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/311,"2017-04-30
[Og II]

Refactored ctw  ci and to create admin commands takes  parameter of a weenieId. You can spawn anything in the database. @ci 21376 - will spawn Martine's Robe 

This does not include the turn to object code - I pulled that out due to a bug. I will submit via new PR.

I cleaned up some unused using statements and refactored some misspelled works (US English)

Magic numbers all gone - test code pulls from database.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/311/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225473150,MDExOlB1bGxSZXF1ZXN0MTE4NDAyMjMx,312,Updated line endings to CRLF,11369233,LtRipley36706,closed,0,,,,,0,2017-05-01T17:02:41Z,2017-06-17T04:04:29Z,2017-05-03T04:24:57Z,MEMBER,,0,ACEmulator/ACE/pulls/312,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/312/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225514597,MDExOlB1bGxSZXF1ZXN0MTE4NDMyMDE0,313,Changed SetupModel.ReadFromDat function to be more user-friendly. ,26606778,OptimShi,closed,0,,,,,0,2017-05-01T20:10:17Z,2017-09-06T21:30:54Z,2017-05-02T13:26:20Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/313,"Added a functional example of its usage to Lifestone.OnUse to properly take the model's radius and the object's use-radius into account when determining if a player is ""close enough"".","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/313/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225753808,MDExOlB1bGxSZXF1ZXN0MTE4NTk3MjI3,314,Changed Create/CI to use DebugObject,11369233,LtRipley36706,closed,0,,,,,0,2017-05-02T16:44:54Z,2017-06-17T04:04:30Z,2017-05-03T17:15:09Z,MEMBER,,0,ACEmulator/ACE/pulls/314,This makes the object appear on the ground correctly as well as let you see the debug output on id,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/314/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225754076,MDExOlB1bGxSZXF1ZXN0MTE4NTk3NDI5,315,Feature: better position debug commands,37453,fantoms,closed,0,,,,,0,2017-05-02T16:45:50Z,2017-06-28T19:47:09Z,2017-05-02T16:57:05Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/315,"* Cleaned up a bit of line ending madness.
* Re-implemented position debug commands, now in a useful way.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/315/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225811556,MDExOlB1bGxSZXF1ZXN0MTE4NjM5Mjk1,316,Feature: `@save` Admin command,37453,fantoms,closed,0,,,,,0,2017-05-02T20:28:30Z,2017-06-28T19:45:43Z,2017-05-03T23:29:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/316,* Built out the functionality to the `@save` admin command.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/316/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225819621,MDExOlB1bGxSZXF1ZXN0MTE4NjQ1MzAz,317,Feature: `@home` admin command,37453,fantoms,closed,0,,,,,0,2017-05-02T20:58:59Z,2017-05-23T15:52:26Z,2017-05-03T23:32:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/317,"* Built out the functionality for the `@home` admin command.
* Fixed a bug in the `@teletype` command; the actual teleport function was missing/removed.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/317/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225846528,MDExOlB1bGxSZXF1ZXN0MTE4NjY1MDcz,318,Land block diag phase1,25387933,Forbiddenz,closed,0,,,,,1,2017-05-02T23:05:40Z,2017-05-03T19:10:04Z,2017-05-03T18:37:03Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/318,"Phase 1 of Landblock Dia Diag gui.
I need the tool to help improve the landblock loading and unloading code.

This is initial draft of a gui tool built right into ace that can be used to track the landblock activity in real time.  Future use will be to export diags out.

Usage type diag in the console window
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/318/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225871559,MDExOlB1bGxSZXF1ZXN0MTE4NjgyNzIw,319,Fix: Mana on XP Spend,37453,fantoms,closed,0,,,,,1,2017-05-03T02:38:13Z,2017-05-23T15:52:41Z,2017-05-04T17:03:41Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/319,"* Fixed character's total `Mana` points after spending experience points on `Self`.
* Noticed that the `@heal` command may prevent vitals increasing.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/319/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
225891091,MDExOlB1bGxSZXF1ZXN0MTE4Njk1NjEy,320,Portal class changes - Ready for review and possible merge,10137,ghost,closed,0,,,,,1,2017-05-03T06:04:11Z,2017-10-18T14:07:47Z,2017-05-03T22:12:31Z,NONE,,0,ACEmulator/ACE/pulls/320,"I need someone else(s) to look this code/SQL view over.  It results in a crash in Database.cs because of NULL fields, as a result of the left outer join.  System.DBNull cannot be converted to System.UInt32","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/320/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226055760,MDExOlB1bGxSZXF1ZXN0MTE4ODExNDc0,321,Changed Create/CI to use DebugObject,11369233,LtRipley36706,closed,0,,,,,0,2017-05-03T17:16:34Z,2017-06-17T04:04:27Z,2017-05-05T14:25:41Z,MEMBER,,0,ACEmulator/ACE/pulls/321,This makes the object appear on the ground correctly as well as let you see the debug output on id.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/321/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226085821,MDExOlB1bGxSZXF1ZXN0MTE4ODMzNTIz,322,fix built to set default x64,25387933,Forbiddenz,closed,0,,,,,0,2017-05-03T19:12:11Z,2017-05-19T11:40:56Z,2017-05-03T22:12:54Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/322,quick fix for build platform x64,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/322/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226165263,MDExOlB1bGxSZXF1ZXN0MTE4ODkxNTQy,323,Fix bug in Ace.Entity\Ace_portal_object.cs,10137,ghost,closed,0,,,,,0,2017-05-04T02:45:58Z,2017-10-18T14:07:49Z,2017-05-04T05:59:16Z,NONE,,0,ACEmulator/ACE/pulls/323,Having these variables changed to private was preventing the Position object from being created correctly.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/323/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226182192,MDExOlB1bGxSZXF1ZXN0MTE4OTAyNzkx,324,Cleaned up project and solution files.,11369233,LtRipley36706,closed,0,,,,,0,2017-05-04T05:39:59Z,2017-06-17T04:04:25Z,2017-05-04T05:54:04Z,MEMBER,,0,ACEmulator/ACE/pulls/324,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/324/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226292677,MDExOlB1bGxSZXF1ZXN0MTE4OTgxNjM1,325,database object factory,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-05-04T14:07:43Z,2017-05-04T14:35:51Z,2017-05-04T14:35:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/325,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/325/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226361877,MDExOlB1bGxSZXF1ZXN0MTE5MDMxOTQw,326,"Revert ""database object factory""",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-05-04T18:01:00Z,2017-05-04T18:03:13Z,2017-05-04T18:02:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/326,Reverts ACEmulator/ACE#325,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/326/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226441363,MDExOlB1bGxSZXF1ZXN0MTE5MDkwOTUw,327,Full reset of repo,11369233,LtRipley36706,closed,0,,,,,1,2017-05-05T00:06:01Z,2017-06-17T04:04:22Z,2017-05-05T14:26:35Z,MEMBER,,0,ACEmulator/ACE/pulls/327,This is an attempt at using the .gitattributes and .editorconfig settings to correct existing linefeed and whitespace issues.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/327/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226452388,MDExOlB1bGxSZXF1ZXN0MTE5MDk3OTEx,328,"Review Request / Merge : Move to Object, Move to Position, Turn to Object, Turn to Position",25460553,ogmage78,closed,0,,,,,7,2017-05-05T01:39:16Z,2017-05-10T11:53:10Z,2017-05-10T11:53:10Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/328,"This is 99% of the way there.   I have a bug I am having trouble tracking down.   I think this is solid code once we hit that last bug.   It does not break anything and we have a lot of people working on items related to this.   The sooner this is merged - the better.     In the absence of finding the bug, I would propose merging it anyway to get the core in.

To see the bug.   @ci 12748 will create a training wand in your back pack.   Drop it, move off - select it.   It should put your pick up item on hold, move you to the position, then once in range pick up the wand.   I was moving but now it is not.   It has to be something simple, it was working before.   Please advise.

One more thing - there are 4 files that show changes that I did nothing to - they show complete file replacements.   I did not even edit them.   Not sure why that is happening.   

SetModel.cs, Extensions.cs - the solutions files - no idea why they show complete replace and no idea how to stop it or fix it.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/328/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226473134,MDExOlB1bGxSZXF1ZXN0MTE5MTA5Mzc4,329,Dat Updates,26606778,OptimShi,closed,0,,,,,2,2017-05-05T04:46:55Z,2017-05-21T22:15:59Z,2017-05-07T01:20:42Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/329,"Added a caching system to .dat file reads. 
Added EnvCell FileType to ACE.DatLoader. This is dungeon blocks and indoor spaces (0x0100+ cell locations)
Updated the cell-export function to use DatReader class (if you previously exported these, delete them and start over--they are wrong!)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/329/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226722665,MDExOlB1bGxSZXF1ZXN0MTE5Mjc5NDU1,330,Fix for ci & create complete and tested.   Ready for merge if approved.  ,25460553,ogmage78,closed,0,,,,,2,2017-05-06T00:31:24Z,2017-05-07T02:51:23Z,2017-05-07T02:51:23Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/330,"Fixed
I fixed a lot of the issue with these two create object calls.    I modify some of the flags because the base ace object was made from a pcap - I think the logic is sound and it is how I had it working before.   I also put in some code to exclude the extra information from baseAceObject for portals, creatures and life stones.   We can expand that exclusion list if and when it is found necessary.

I added a new admin function cirand <typeId> that will allow you to easily test and exercise the ci function to insure it works for various itemTypes","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/330/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226731648,MDExOlB1bGxSZXF1ZXN0MTE5Mjg0MTE5,331,Add new Portal constructor,10137,ghost,closed,0,,,,,5,2017-05-06T02:37:56Z,2017-10-18T14:07:50Z,2017-05-07T19:37:52Z,NONE,,0,ACEmulator/ACE/pulls/331,"* Add new Portal consructor that accepts a weenieClassId and Position object
* Add PortalWeenie enum for Floating City, Golem Sanctum, Humming Crystal, and The Orphanage portals, for use with the new Portal constructor
* Modified the /createportal debug command to use the new Portal constructor and the Humming Crystal weenie as a PoC
TODO: add a TTL to the portal, so it gets removed after a length of time","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/331/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226811721,MDExOlB1bGxSZXF1ZXN0MTE5MzE5NTg2,332,"Added settlement portal drop for Yaraq, Zaikhal and Al-Arqas",24981658,MiachofTD,closed,0,,,,,0,2017-05-06T23:15:33Z,2017-05-06T23:21:38Z,2017-05-06T23:21:38Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/332,"Added settlement portal drop for Yaraq, Zaikhal and Al-Arqas","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/332/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226840862,MDExOlB1bGxSZXF1ZXN0MTE5MzMxMTEw,333,Review please: Very basic monster combat based on a statemachine.,26508216,Lidefeath,closed,0,,,,,0,2017-05-07T08:47:11Z,2017-05-15T18:27:01Z,2017-05-10T20:18:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/333,"This is not for merging, but only for review.

To test it, spawn a monster and walk near it: It will detect you, move to you and kill you and then return back to it's spawn point. 
It will need @ogmage78 's movement changes to finalize it, as you can currently bug the monster if you keep moving away from it. It will follow you for a while, but then not properly return to spawn point.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/333/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226874106,MDExOlB1bGxSZXF1ZXN0MTE5MzQ1MjY3,334,Correct DebugObject,11369233,LtRipley36706,closed,0,,,,,0,2017-05-07T16:38:34Z,2017-06-17T04:04:21Z,2017-05-11T16:57:27Z,MEMBER,,0,ACEmulator/ACE/pulls/334,"Changes fix spawning of various items across Dereth.

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/334/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
226891089,MDExOlB1bGxSZXF1ZXN0MTE5MzUzMDQ4,335,For Review: First pass at weenies as code objects.,11369233,LtRipley36706,closed,0,,,,,0,2017-05-07T20:25:25Z,2017-06-17T04:04:21Z,2017-05-11T16:57:36Z,MEMBER,,0,ACEmulator/ACE/pulls/335,"This is a sample of how I see setting up weenies in ACE.

It still pulls a lot of the data from the DB which in some of the cases I would think would actually by coded in the object itself and not in the DB.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/335/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
227499793,MDU6SXNzdWUyMjc0OTk3OTM=,336,Network Issue: Network connections may stay connected indefinitely,37453,fantoms,closed,0,12808515,Zegeger,,,3,2017-05-09T21:13:17Z,2017-07-31T18:51:15Z,2017-07-31T18:51:15Z,CONTRIBUTOR,,,,"### Bug Report or Feature Request
```
- [ x ] bug report 
- [ ] feature request
```

### Repro steps.
Connect more than the `MaximumAllowedSessions` (default 128) of concurrent clients to a server; or send the correct amount of create session packets.

### The log given by the failure.
ACE >> 2017-05-07 22:05:29,612 INFO : Creating new session for 192.168.7.7:61029 with id 0
2017-05-07 22:10:35,742 INFO : Creating new session for 192.168.7.7:65413 with id 1
2017-05-07 22:15:42,030 INFO : Creating new session for 192.168.7.7:57474 with id 2
2017-05-07 22:20:48,176 INFO : Creating new session for 192.168.7.7:58592 with id 3
2017-05-07 22:25:54,358 INFO : Creating new session for 192.168.7.7:60537 with id 4
2017-05-07 22:31:00,496 INFO : Creating new session for 192.168.7.7:59820 with id 5
2017-05-07 22:36:06,718 INFO : Creating new session for 192.168.7.7:64720 with id 6
2017-05-07 22:41:12,800 INFO : Creating new session for 192.168.7.7:51870 with id 7
2017-05-07 22:46:18,915 INFO : Creating new session for 192.168.7.7:62253 with id 8
2017-05-07 22:51:25,165 INFO : Creating new session for 192.168.7.7:53784 with id 9
2017-05-07 22:56:31,332 INFO : Creating new session for 192.168.7.7:58602 with id 10
2017-05-07 23:01:37,489 INFO : Creating new session for 192.168.7.7:64817 with id 11
2017-05-07 23:06:43,628 INFO : Creating new session for 192.168.7.7:63685 with id 12
2017-05-07 23:11:49,796 INFO : Creating new session for 192.168.7.7:54929 with id 13
2017-05-07 23:16:56,073 INFO : Creating new session for 192.168.7.7:65227 with id 14
2017-05-07 23:22:02,326 INFO : Creating new session for 192.168.7.7:58617 with id 15
2017-05-07 23:27:08,426 INFO : Creating new session for 192.168.7.7:56680 with id 16
2017-05-07 23:32:14,589 INFO : Creating new session for 192.168.7.7:50188 with id 17
2017-05-07 23:37:20,733 INFO : Creating new session for 192.168.7.7:57489 with id 18
2017-05-07 23:42:26,862 INFO : Creating new session for 192.168.7.7:52208 with id 19
2017-05-07 23:47:33,020 INFO : Creating new session for 192.168.7.7:55830 with id 20
2017-05-07 23:52:39,222 INFO : Creating new session for 192.168.7.7:54461 with id 21
2017-05-07 23:57:45,378 INFO : Creating new session for 192.168.7.7:50199 with id 22
2017-05-08 00:02:51,532 INFO : Creating new session for 192.168.7.7:59962 with id 23
2017-05-08 00:07:57,778 INFO : Creating new session for 192.168.7.7:53476 with id 24
2017-05-08 00:13:04,041 INFO : Creating new session for 192.168.7.7:50565 with id 25
2017-05-08 00:18:10,284 INFO : Creating new session for 192.168.7.7:65321 with id 26
2017-05-08 00:23:16,491 INFO : Creating new session for 192.168.7.7:62463 with id 27
2017-05-08 00:28:22,661 INFO : Creating new session for 192.168.7.7:62149 with id 28
2017-05-08 00:33:28,834 INFO : Creating new session for 192.168.7.7:53054 with id 29
2017-05-08 00:38:34,989 INFO : Creating new session for 192.168.7.7:56271 with id 30
2017-05-08 00:43:41,109 INFO : Creating new session for 192.168.7.7:51773 with id 31
2017-05-08 00:48:47,264 INFO : Creating new session for 192.168.7.7:62782 with id 32
2017-05-08 00:53:53,418 INFO : Creating new session for 192.168.7.7:64219 with id 33
2017-05-08 00:58:59,667 INFO : Creating new session for 192.168.7.7:56714 with id 34
2017-05-08 01:04:05,834 INFO : Creating new session for 192.168.7.7:63605 with id 35
2017-05-08 01:09:12,008 INFO : Creating new session for 192.168.7.7:62851 with id 36
2017-05-08 01:14:18,112 INFO : Creating new session for 192.168.7.7:62807 with id 37
2017-05-08 01:19:24,349 INFO : Creating new session for 192.168.7.7:53302 with id 38
2017-05-08 01:24:30,565 INFO : Creating new session for 192.168.7.7:55525 with id 39
2017-05-08 01:29:36,669 INFO : Creating new session for 192.168.7.7:62657 with id 40
2017-05-08 01:34:42,810 INFO : Creating new session for 192.168.7.7:63067 with id 41
2017-05-08 01:39:48,994 INFO : Creating new session for 192.168.7.7:55632 with id 42
2017-05-08 01:44:55,179 INFO : Creating new session for 192.168.7.7:56906 with id 43
2017-05-08 01:50:01,383 INFO : Creating new session for 192.168.7.7:60288 with id 44
2017-05-08 01:55:07,659 INFO : Creating new session for 192.168.7.7:50456 with id 45
2017-05-08 02:00:13,815 INFO : Creating new session for 192.168.7.7:58839 with id 46
2017-05-08 02:05:19,987 INFO : Creating new session for 192.168.7.7:65310 with id 47
2017-05-08 02:10:26,130 INFO : Creating new session for 192.168.7.7:49382 with id 48
2017-05-08 02:15:32,295 INFO : Creating new session for 192.168.7.7:64248 with id 49
2017-05-08 02:20:38,569 INFO : Creating new session for 192.168.7.7:51154 with id 50
2017-05-08 02:25:44,694 INFO : Creating new session for 192.168.7.7:63086 with id 51
2017-05-08 02:30:50,852 INFO : Creating new session for 192.168.7.7:53606 with id 52
2017-05-08 02:35:57,039 INFO : Creating new session for 192.168.7.7:54735 with id 53
2017-05-08 02:41:03,176 INFO : Creating new session for 192.168.7.7:62208 with id 54
2017-05-08 02:46:09,471 INFO : Creating new session for 192.168.7.7:49520 with id 55
2017-05-08 02:51:15,702 INFO : Creating new session for 192.168.7.7:51325 with id 56
2017-05-08 02:56:21,796 INFO : Creating new session for 192.168.7.7:59669 with id 57
2017-05-08 03:01:27,933 INFO : Creating new session for 192.168.7.7:65276 with id 58
2017-05-08 03:06:34,248 INFO : Creating new session for 192.168.7.7:62216 with id 59
2017-05-08 03:11:40,397 INFO : Creating new session for 192.168.7.7:64856 with id 60
2017-05-08 03:16:46,540 INFO : Creating new session for 192.168.7.7:62247 with id 61
2017-05-08 03:21:52,738 INFO : Creating new session for 192.168.7.7:55852 with id 62
2017-05-08 03:26:58,847 INFO : Creating new session for 192.168.7.7:64200 with id 63
2017-05-08 03:32:05,002 INFO : Creating new session for 192.168.7.7:62454 with id 64
2017-05-08 03:37:11,202 INFO : Creating new session for 192.168.7.7:60663 with id 65
2017-05-08 03:42:17,252 INFO : Creating new session for 192.168.7.7:53126 with id 66
2017-05-08 03:47:23,468 INFO : Creating new session for 192.168.7.7:62269 with id 67
2017-05-08 03:52:29,742 INFO : Creating new session for 192.168.7.7:64327 with id 68
2017-05-08 03:57:36,010 INFO : Creating new session for 192.168.7.7:63700 with id 69
2017-05-08 04:02:42,210 INFO : Creating new session for 192.168.7.7:62271 with id 70
2017-05-08 04:07:48,380 INFO : Creating new session for 192.168.7.7:57404 with id 71
2017-05-08 04:12:54,516 INFO : Creating new session for 192.168.7.7:63598 with id 72
2017-05-08 04:18:00,755 INFO : Creating new session for 192.168.7.7:53139 with id 73
2017-05-08 04:23:06,972 INFO : Creating new session for 192.168.7.7:62968 with id 74
2017-05-08 04:28:13,121 INFO : Creating new session for 192.168.7.7:54477 with id 75
2017-05-08 04:33:19,305 INFO : Creating new session for 192.168.7.7:63942 with id 76
2017-05-08 04:38:25,462 INFO : Creating new session for 192.168.7.7:52730 with id 77
2017-05-08 04:43:31,618 INFO : Creating new session for 192.168.7.7:57499 with id 78
2017-05-08 04:48:37,846 INFO : Creating new session for 192.168.7.7:51360 with id 79
2017-05-08 04:53:44,036 INFO : Creating new session for 192.168.7.7:56347 with id 80
2017-05-08 04:58:50,209 INFO : Creating new session for 192.168.7.7:49442 with id 81
2017-05-08 05:03:56,377 INFO : Creating new session for 192.168.7.7:62459 with id 82
2017-05-08 05:09:02,546 INFO : Creating new session for 192.168.7.7:51374 with id 83
2017-05-08 05:14:08,712 INFO : Creating new session for 192.168.7.7:54493 with id 84
2017-05-08 05:19:14,926 INFO : Creating new session for 192.168.7.7:62475 with id 85
2017-05-08 05:24:21,157 INFO : Creating new session for 192.168.7.7:59676 with id 86
2017-05-08 05:29:27,364 INFO : Creating new session for 192.168.7.7:57377 with id 87
2017-05-08 05:34:33,643 INFO : Creating new session for 192.168.7.7:58005 with id 88
2017-05-08 05:39:39,893 INFO : Creating new session for 192.168.7.7:54947 with id 89
2017-05-08 05:44:46,042 INFO : Creating new session for 192.168.7.7:51479 with id 90
2017-05-08 05:49:52,261 INFO : Creating new session for 192.168.7.7:54962 with id 91
2017-05-08 05:54:58,389 INFO : Creating new session for 192.168.7.7:55522 with id 92
2017-05-08 06:00:04,648 INFO : Creating new session for 192.168.7.7:62553 with id 93
2017-05-08 06:05:10,822 INFO : Creating new session for 192.168.7.7:51790 with id 94
2017-05-08 06:10:16,950 INFO : Creating new session for 192.168.7.7:56051 with id 95
2017-05-08 06:15:23,099 INFO : Creating new session for 192.168.7.7:53331 with id 96
2017-05-08 06:20:29,356 INFO : Creating new session for 192.168.7.7:51842 with id 97
2017-05-08 06:25:35,430 INFO : Creating new session for 192.168.7.7:62594 with id 98
2017-05-08 06:30:41,716 INFO : Creating new session for 192.168.7.7:51881 with id 99
2017-05-08 06:35:47,918 INFO : Creating new session for 192.168.7.7:62613 with id 100
2017-05-08 06:40:54,086 INFO : Creating new session for 192.168.7.7:62630 with id 101
2017-05-08 06:46:00,369 INFO : Creating new session for 192.168.7.7:62651 with id 102
2017-05-08 06:51:06,605 INFO : Creating new session for 192.168.7.7:62836 with id 103
2017-05-08 06:56:12,806 INFO : Creating new session for 192.168.7.7:54582 with id 104
2017-05-08 07:01:18,942 INFO : Creating new session for 192.168.7.7:56330 with id 105
2017-05-08 07:06:25,075 INFO : Creating new session for 192.168.7.7:62867 with id 106
2017-05-08 07:11:31,266 INFO : Creating new session for 192.168.7.7:57868 with id 107
2017-05-08 07:16:37,511 INFO : Creating new session for 192.168.7.7:53404 with id 108
2017-05-08 07:21:43,660 INFO : Creating new session for 192.168.7.7:59742 with id 109
2017-05-08 07:26:49,834 INFO : Creating new session for 192.168.7.7:53906 with id 110
2017-05-08 07:31:55,930 INFO : Creating new session for 192.168.7.7:59063 with id 111
2017-05-08 07:37:02,189 INFO : Creating new session for 192.168.7.7:52769 with id 112
2017-05-08 07:42:08,362 INFO : Creating new session for 192.168.7.7:63626 with id 113
2017-05-08 07:47:14,519 INFO : Creating new session for 192.168.7.7:59091 with id 114
2017-05-08 07:52:20,758 INFO : Creating new session for 192.168.7.7:53607 with id 115
2017-05-08 07:57:26,881 INFO : Creating new session for 192.168.7.7:53674 with id 116
2017-05-08 08:02:33,038 INFO : Creating new session for 192.168.7.7:59599 with id 117
2017-05-08 08:07:39,301 INFO : Creating new session for 192.168.7.7:59113 with id 118
2017-05-08 08:12:45,519 INFO : Creating new session for 192.168.7.7:53718 with id 119
2017-05-08 08:17:51,772 INFO : Creating new session for 192.168.7.7:63119 with id 120
2017-05-08 08:22:58,082 INFO : Creating new session for 192.168.7.7:55638 with id 121
2017-05-08 08:28:04,299 INFO : Creating new session for 192.168.7.7:59903 with id 122
2017-05-08 08:33:10,418 INFO : Creating new session for 192.168.7.7:53963 with id 123
2017-05-08 08:38:16,540 INFO : Creating new session for 192.168.7.7:54054 with id 124
2017-05-08 08:43:22,760 INFO : Creating new session for 192.168.7.7:64022 with id 125
2017-05-08 08:48:29,007 INFO : Creating new session for 192.168.7.7:54092 with id 126
2017-05-08 08:53:35,250 INFO : Creating new session for 192.168.7.7:54104 with id 127
2017-05-08 08:58:41,475 WARN : Failed to create a new session for 192.168.7.7:64296
2017-05-08 08:58:59,491 WARN : Failed to create a new session for 192.168.7.7:64369
etc...

### Desired functionality.
Disconnect after connection has timed out. 

### Mention any other details that might be useful.
I utilized the functionality currently present in Thwarglauncher 4.6.6.1 to create sessions with the server status check. Opening and closing the App 128 times with the default server config, should be sufficient.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/336/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
228441293,MDExOlB1bGxSZXF1ZXN0MTIwNDMwNjg5,337,Object overhaul - clean up enums,25460553,ogmage78,closed,0,,,,,0,2017-05-13T01:48:57Z,2017-05-14T01:04:04Z,2017-05-14T01:04:04Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/337,Started object Overhaul - added explicit values to properties enums.   Minor cleanup.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/337/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
228506681,MDExOlB1bGxSZXF1ZXN0MTIwNDY2NzU3,338,Time-based updates to creature vitals,5246554,ddevec,closed,0,,,,,3,2017-05-13T23:22:44Z,2017-05-17T11:07:42Z,2017-05-17T11:07:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/338,"Trying to take a small piece for my first commit -- hopefully this is reasonable.

Goal is to add basic functionality required for time based updates of creature's vitals (health, mana, stamina).  This is a subset of the challenge for issue #254 .  Current update rates do not reflect original game's update algorithm.

Summary of changes:
- Added setvital debug function -- sets a vital (hp mp stam) to a specified or relative value
- Added per-creature update function to landblock main loop
- Added vital update code per creature
- Added UI notification messages to player, so UI updates when vitals are changed.

I'm new to working on distributed teams via github, please let me know if there is anything I need to correct.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/338/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
228584921,MDExOlB1bGxSZXF1ZXN0MTIwNTEwOTYw,339,Review & Comment only || Object overhaul - POC ,25460553,ogmage78,closed,0,,,,,1,2017-05-15T01:14:55Z,2017-05-15T12:48:22Z,2017-05-15T12:48:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/339,"Ok - I have started this work and could really use a review before I get too far down the road.   Issues on the table:

We had 10 items still to determine a place for in the new db schema.   Four have been identified 6 remain.  You can look at and contribute to the ObjectXRef document here: https://goo.gl/mqRWST

Ok - have at it.   Let me know what needs to be changed or if this looks good.   

Link to latest ace_world ERD https://goo.gl/6lZ2wm  

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/339/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
228816942,MDExOlB1bGxSZXF1ZXN0MTIwNjc0ODAw,340,Rude Vendor,25387933,Forbiddenz,closed,0,,,,,0,2017-05-15T19:22:39Z,2017-05-19T11:42:49Z,2017-05-17T11:11:26Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/340,"Rude vendors, Rude Vendors everywhere!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/340/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
228898308,MDExOlB1bGxSZXF1ZXN0MTIwNzMzMDMx,341,Object Overhaul - ready for review and merge.    Still Work in Progress but a good spot.,25460553,ogmage78,closed,0,,,,,1,2017-05-16T02:32:04Z,2017-05-20T00:46:40Z,2017-05-20T00:46:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/341,"* Continued work on Overhaul 
* Created mapping cross reference file to facilitate documentation and cleaning up names - work in progress https://goo.gl/eaaNQb
* Created new database schema for world_object - modified mysqlinstall.bat to reflect new baseline
* created script to ETL old schema to new schema.   I have not included it as we will be refactoring the initial data load to use the new
* schema according to Ripley.   I have the script tested and posted on my dropbox if anyone wants it.   I also have a complete data dump that
* zips down to a manageable size.
* BaseAceObject is now using the new schema
* I re-hooked up telepoi to use the new schema.   Still to do, convert to constructed statement
* @moveto works which shows we can spawn world objects out of new data schema.
* Next steps - refactor AceObject and make sure world objects load again.
* re-enable and expand constructed statement test.   We have a constraint that the old test would fail.
* Once that is complete - start same process using clone of this schema for character as discussed.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/341/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
229513078,MDExOlB1bGxSZXF1ZXN0MTIxMTcxNzA4,342,QueuedGameActions Phase1,25387933,Forbiddenz,closed,0,,,,,0,2017-05-17T23:14:56Z,2017-10-12T15:38:40Z,2017-05-30T20:45:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/342,"Overhauled the QueuedGameActions .

Not sure how to properly implement the read only WO.
Could use a little help with that.

Added handlers, lots of room now to move the que out of player or even landblock.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/342/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
229548265,MDExOlB1bGxSZXF1ZXN0MTIxMTk2NDk0,343,Creature vitals updates -- changelog,5246554,ddevec,closed,0,,,,,0,2017-05-18T03:57:22Z,2017-06-12T14:46:48Z,2017-05-18T15:53:08Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/343,Here is the changelog.md entry I forgot.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/343/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
229792138,MDExOlB1bGxSZXF1ZXN0MTIxMzY4Mzk2,344,Event Handling Restructure,5246554,ddevec,closed,0,,,,,3,2017-05-18T20:16:07Z,2017-06-12T14:46:58Z,2017-05-22T15:44:59Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/344,"Hello.  My first commit was a small vital update change.  I've now broken out of my shell, and am looking at the bigger picture!  I hope this is useful, or inspires brainstorming future directions for this codebase!

This is an experimental and pretty major restructuring of our current event handling system.

This restructuring accomplishes several **goals**:

- A consistent and easily followed synchronization mechanism for cross-landblock operations
- A convenient mechanism to broadcast position based updates, without requiring objects maintain broadcast lists
- A simplification of the rapidly growing and complicated state machines used to manage character actions.

To achieve these goals I have restructured the **logical flow** of the code in the following ways:

- I have removed the prior player event queues.
- There is an ITickable interface, every landblock update loop all ITickables on the landblock are ""Ticked""
- It is the responsibility of the ITickable to manage any updates and broadcasts it needs within its tick.
- To aid in the management of these updates, I introduce ""ObjectActon"" co-routines which allow a convenient way to structure the traditionally event-based code in an Object-Oriented (as opposed to event-based) manner.
- I created a (hopefully) simple-to-follow synchronization pattern, which can allow complex behaviors within 

actions between objects.

**Smaller Bits**:
Flow of information:
Network packets -> session.Player.RequestAction(action) - (on landblock tick) -> action()

- On Tick() ITickables are given (lazy populating) broadcast lists, letting them know nearby players that need to be notified of global updates.  
- All ITickables are locked by the landblock before ticking.  If they need to interact with another object, they must lock that object before using it (but the common-case self locking is handled by the landblock).

Please take a look, try it out, tell me if you have any questions!

Important Parts to look at:
Actions are now handled much more simply.  For example: before delayed teleport required a messy state machine with tendrils all over the code.  Now the delayed teleport are implemented in ActDelayedTeleport, and encapsulated cleanly.

Feel free to try checking the branch out and building an event for yourself (e.g. proper animation delays when dropping/picking up items).  Hopefully you'll find it is significantly easier to use.

Finally, as far as I know, all functionality on the mainline ACE emulator (as well as some extra, particularly multi-client operations) functions.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/344/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
230036538,MDExOlB1bGxSZXF1ZXN0MTIxNTQ1NDMy,345,Added Configuration for Maximum Allowed Sessions,37453,fantoms,closed,0,,,,,0,2017-05-19T17:17:20Z,2017-05-23T15:52:30Z,2017-05-20T00:47:15Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/345,"* Changed the configuration sections to allow for the ""MaxSessions"" setting.
* There is a default value of 128.
* Check the Config.json.example for help.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/345/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
230064274,MDExOlB1bGxSZXF1ZXN0MTIxNTY0MTA5,346,Added debug command @listplayers,37453,fantoms,closed,0,,,,,0,2017-05-19T19:09:06Z,2017-05-23T15:52:32Z,2017-05-20T00:48:18Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/346,* Added a Helpful debug command for testing who is connected too your server.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/346/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
230115789,MDExOlB1bGxSZXF1ZXN0MTIxNjAxNTgy,347,Spell Tables,26606778,OptimShi,closed,0,,,,,1,2017-05-20T00:06:17Z,2017-06-17T03:22:57Z,2017-05-24T11:39:29Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/347,"Added SpellTable/SpellComponent parsing from portal.dat. Also added ""@learnspell"" debug command and corresponding UpdateSpell Event.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/347/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
230158293,MDU6SXNzdWUyMzAxNTgyOTM=,348,Accessing Objects Between Landblocks,5246554,ddevec,closed,0,,,,,2,2017-05-20T14:53:03Z,2017-06-22T19:14:46Z,2017-06-22T19:14:46Z,CONTRIBUTOR,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [x] bug report -> please search issues before submitting
- [ ] feature request
```

There is a corner-case atomicity violation within our Landblock system around the observation of transferring objects between Landblocks.

The best **example** I've found explaining the problem:

Note, I've often heard this problem described as ""Ships Passing in the Night"" if your looking for a shorthand to describe it.

Character Foo observes object Bar moving between two Landblocks.  Foo is on Landblock A, Bar is moving from B to C (so Foo is basically at the corner of a Landblock).  If Foo were to need to interact with Bar (e.g. IdentifyObject from Foo's client, with Bar's Guid as the argument), the Landblock system would have to fetch the Bar WorldObject off of the appropriate Landblock.

Unfortunately, our current design has no way of doing so reliably.  If Bar is in the act of transferring between two Landblocks, it may either be on A or B (or in our current system on neither).  Our only current recourse is to scan all adjacent Landblocks when searching by Guid.  If Bar is in the act of transferring when this scan happens we can miss it with this set of events:

Bar is on A.
We scan B for Bar.
Bar transfers from A to B
We scan A, never finding Bar.

The fundamental issue here is that the scanning of Landblocks is not atomic with respect to the transfer of objects between Landblocks and is additionally not atomic with executing an object's action on that Landblock.  Essentially we need an underlying system that allows us to find an object in nearby Landblocks by Guid, _and_ execute some action on that Landblock atomically.

There are several **possible solutions** to this problem:

**First** - adapting our current design:
Unfortunately, adapting our current design is not likely practical.  Landblocks operate asynchronously, so any operations which query adjacent landblocks for Guids would have to lock _all_ adjacent Landblocks during query (Landblocks would also have to be locked when updating object positions internally).  This will lead to high amounts of locking, and possible deadlock within the system (it is possible, but will be a very treacherous endeavor to create a non-deadlocking Landblock locking ordering).  Overall this design will be inefficient and error prone.

**Second** - Object Directories
The classic solution to this problem is to use an object directory.  We create a directory system (Dictionary with locks) which is essentially a mapping of Guid to current Landblock.  The directory system provides a key-value mapping from Guid to WorldObject, allowing safe lookup of an Object from its Guid to Landblock (this requires atomically updating the dictionary on any landblock transfer -- probably a global lock).  However, there are still other problems with this.  Once we have gotten the Landblock location of the object we must send our event (E.g. IdentifyObject) to _that_ Landblock to safely query the object.  This event send must happen atomically with respect to the directory lookup, _and_ guarantee that the event is run _before_ the object is transferred between Landblocks, otherwise the object may move between querying the dictionary and executing the event to the Landblock, recreating our original problem!

**Third** - Object Directories with Object Work Queues
Instead of having the Landblock perform all object updates, we can associate work with WorldObject.  This allows the work to travel with the object, so it is sufficient to have an object lookup directory.

**Fourth** - Reduction in landblock parallelism
This entire problem stems from the fact that each Landblock can move objects concurrently.  If we guaranteed that only one landblock moved objects at a time (e.g. running all of our landblock update loops sequentially instead of in parallel) that would resolve this issue.

Perhaps this is also a good time to revisit where we have asynchrony in the system, why its needed, and if we should in fact have it?","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/348/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
230240096,MDExOlB1bGxSZXF1ZXN0MTIxNjcxNjE1,349,Object overhaul - part two.   Review and Comment,25460553,ogmage78,closed,0,,,,,2,2017-05-21T18:54:26Z,2017-05-23T23:15:41Z,2017-05-23T23:15:41Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/349,"I am having to refactor and touch a LOT of stuff.   It is looking good to me - but I am concerned about how much I am modifying without review.   Below is where I am at.   
### 2017-05-21
* Continued work on Overhaul 
* re-enabled more constructed statements
* Most of the work to use existence of data to set flags for both physics and weenieHeaderFlags - some cleanup remains - either logic issues or bad data
* modified cirand to take an optional second parameter to spawn X items at a time.   This speeds up testing.   I set a default to 10 if you omit the second parameter.
* base_ace_object and ace_object both seem to be loading.
* updated or created several views.
* have not tested with Ripley's new data export - I did not want to add a second variable to testing.   
* Next steps - use Ripley's data, create needed views, re-enable door, portal, NPC --- all the world things.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/349/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
230256291,MDU6SXNzdWUyMzAyNTYyOTE=,350,DoubleCheck locking in LandblockManager::GetLandblock(),5246554,ddevec,closed,0,,,,,2,2017-05-21T23:23:03Z,2018-10-07T00:12:52Z,2018-10-07T00:12:52Z,CONTRIBUTOR,,,,"Putting this here so I don't forget about it -- its on a TODO list after solving other concurrency errors.  If someone else wants to take the lead on it though, feel free.

<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [X] bug report -> please search issues before submitting
- [ ] feature request
```

Currently LandblockManager makes use of double check locking to populate the landblocks array.  Naive double check locking is a known unsafe paradigm in the Java and C# memory models and should be avoided:

https://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html
http://csharpindepth.com/Articles/General/Singleton.aspx
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/350/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
230260795,MDExOlB1bGxSZXF1ZXN0MTIxNjgyOTU0,351,Read the CLandblockInfo file type from client_cell.dat,26606778,OptimShi,closed,0,,,,,0,2017-05-22T00:43:23Z,2017-06-26T01:14:11Z,2017-05-22T17:57:05Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/351,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/351/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
230261482,MDU6SXNzdWUyMzAyNjE0ODI=,352,Character creation when not using admin account access,24981658,MiachofTD,closed,0,,,,,1,2017-05-22T00:54:22Z,2017-05-28T00:47:59Z,2017-05-28T00:47:59Z,CONTRIBUTOR,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [x ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
Create an account without admin access and try to create a character and click the Finish button at the end.

### The log given by the failure.
No errors reported.

### Desired functionality.
All account levels should be able to create a character.

### Mention any other details that might be useful.
Tested all account levels and ONLY admin access is able to create a character completely.  All other levels of access you cannot click the finish button and never enter the server.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/352/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
231193972,MDExOlB1bGxSZXF1ZXN0MTIyMzQwMzMz,353,* Initial work done for new schema.   I think we are ready to merge.,25460553,ogmage78,closed,0,,,,,0,2017-05-24T22:53:24Z,2017-05-25T11:43:24Z,2017-05-25T11:43:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/353,"### 2017-05-21
[Og II]
* Initial work done for new schema.   Rebased and removed update sql files.

* Tested and the auto setting of Physics and Weenie Header Flags looks really solid.   Side note, the values we have
* in the database for weenieHeaderFlags and Physics Description Flag should probably be dropped we don't read them or use them now.
* Doors, portals NPC's and signs are all back in the world now.
* I would suggest we remerge with the main branch sooner rather than later - we can create another branch to introduce these
* changes into the character side.
* TODO items:
* Creature spawns need to be refactored - I left them commented out.   We need to ditch seperate tables that we have now, I think all
* creature can use what we have now, plus maybe two additional world tables.   Everything else fits into the current schema.
* Test Ripley data and update ACE_World.
* Refactor portals - I just left the old way in and faked it out with a view.
* Once this looks good and stable and we fix any found bugs - we need to clone this over to the character database and start refactoring
* That will get us to persisted inventory.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/353/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
231465512,MDExOlB1bGxSZXF1ZXN0MTIyNTMwMzU4,354,World Object Refactor & Code Cleanup.,25460553,ogmage78,closed,0,,,,,1,2017-05-25T21:30:53Z,2017-06-03T12:11:35Z,2017-05-26T15:45:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/354,"* Refactored World Object to have all of the properties and methods of Game Data, Physics Data and Model Data.

* Since I had to touch a ton of files, I cleaned up as much as I could.   Removed unneeded using statements,
* killed whitespace where I found it, removed this. where not needed and where the type was obvious switched to a more
* consistent use of var.
* Re-enabled the unit tests for database.   We don't have a delete = if you insert into the table, you have to manually kill
* the test data to avoid a duplicate key violation on a second running of the tests.    If those run in AppVeyor - will not be an issue as
* an fresh db is created each time.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/354/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
231713898,MDExOlB1bGxSZXF1ZXN0MTIyNzA0OTIz,355,Objects - Game data refactored - issue with character login,25460553,ogmage78,closed,0,,,,,1,2017-05-26T19:21:09Z,2017-06-07T19:24:51Z,2017-05-30T11:36:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/355,Added most of Ripley's new data export items and moved a lot of stuff to the new did and iid tables.   Code compiles but will not run.   I will bring in the few remaining new fields and fix the data error tomorrow.      ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/355/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
232376412,MDExOlB1bGxSZXF1ZXN0MTIzMTM5NTYy,356,Mediator pattern - Not for Merge - just here for review ,25387933,Forbiddenz,closed,0,,,,,0,2017-05-30T20:44:59Z,2017-10-12T15:37:13Z,2017-06-16T14:13:10Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/356,"Working basic ques, @effect  - basic loading..

Design Pattern Mediator, 
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/356/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
232421746,MDExOlB1bGxSZXF1ZXN0MTIzMTcxOTQz,357,Objects,25460553,ogmage78,closed,0,,,,,0,2017-05-31T00:40:31Z,2017-06-07T19:24:51Z,2017-05-31T00:43:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/357,This can log in - you will need to add the table and update the views with what I posted in discord.   I will put together a delta file.   ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/357/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233070984,MDExOlB1bGxSZXF1ZXN0MTIzNjM3OTY1,358,Best attempt stabbed,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-06-02T04:04:41Z,2017-06-02T04:23:24Z,2017-06-02T04:23:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/358,"Database implementation 100% not done.

Merge if you want to, not at all offended if you're not ready to do it yet.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/358/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233356327,MDExOlB1bGxSZXF1ZXN0MTIzODM1MjQ0,359,First corrections and commenting out so the start to command line works,26508216,Lidefeath,closed,0,,,,,1,2017-06-03T08:46:00Z,2017-06-03T18:19:38Z,2017-06-03T18:09:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/359,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/359/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233362354,MDExOlB1bGxSZXF1ZXN0MTIzODM4Njk2,360,Read cached characters and launch to char list,26508216,Lidefeath,closed,0,,,,,0,2017-06-03T10:56:17Z,2017-06-05T21:13:02Z,2017-06-03T17:34:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/360,"This further adds the ability to launch the client to the character list.

CAUTION: change your config.json to rename the ""Character"" section to ""Shard"". This only needs the view vw_ace_character, so as long as the basic fields in there are still provided this PR should work even with a new shard database.

This is the continued work from my first PR, so if you like this PR I'll close the first. If not then the first PR at least allows starting to the command line.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/360/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233388433,MDExOlB1bGxSZXF1ZXN0MTIzODUyNDYz,361,Rework Base SQL scripts.,11369233,LtRipley36706,closed,0,,,,,0,2017-06-03T18:55:04Z,2017-06-17T04:04:20Z,2017-06-03T18:59:30Z,MEMBER,,0,ACEmulator/ACE/pulls/361,Resetting the base SQL scripts to something closer to where they will end up. Views are still missing or WIP from both shard and world base. ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/361/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233390347,MDExOlB1bGxSZXF1ZXN0MTIzODUzNTUw,362,Cleaning up error list,11369233,LtRipley36706,closed,0,,,,,0,2017-06-03T19:28:56Z,2017-06-17T04:04:19Z,2017-06-03T19:30:54Z,MEMBER,,0,ACEmulator/ACE/pulls/362,More cleanup of the comment errors and Portal object errors.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/362/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233403602,MDExOlB1bGxSZXF1ZXN0MTIzODYwOTA2,363,ACE Enum adjustments,11369233,LtRipley36706,closed,0,,,,,0,2017-06-04T00:32:53Z,2017-06-04T00:33:02Z,2017-06-04T00:33:02Z,MEMBER,,0,ACEmulator/ACE/pulls/363,Additional enums for missing db columns,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/363/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233404050,MDExOlB1bGxSZXF1ZXN0MTIzODYxMTQy,364,More Enum Adjustments,11369233,LtRipley36706,closed,0,,,,,0,2017-06-04T00:45:38Z,2017-06-04T00:45:47Z,2017-06-04T00:45:47Z,MEMBER,,0,ACEmulator/ACE/pulls/364,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/364/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233407129,MDExOlB1bGxSZXF1ZXN0MTIzODYyODgy,365,More Enum and Object Realignment,11369233,LtRipley36706,closed,0,,,,,0,2017-06-04T02:21:59Z,2017-06-17T04:04:16Z,2017-06-04T02:22:06Z,MEMBER,,0,ACEmulator/ACE/pulls/365,"Adding two enums to bring them closer to client expectations, adjusting two objects to fit in to current enums","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/365/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233579213,MDExOlB1bGxSZXF1ZXN0MTIzOTcxMDA3,366,Extend ORM to allow aggregate functions i.e. MAX(column) and,26508216,Lidefeath,closed,0,,,,,1,2017-06-05T12:50:56Z,2017-06-10T15:22:53Z,2017-06-05T19:18:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/366,implemented GetNextCharacterId using the MAX aggregate,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/366/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
233729635,MDExOlB1bGxSZXF1ZXN0MTI0MDc0NzIw,367,Implements IsCharacterNameAvailable and fixes some errors,26508216,Lidefeath,closed,0,,,,,0,2017-06-05T22:32:02Z,2017-06-10T15:22:54Z,2017-06-06T11:49:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/367,… in the chargen code.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/367/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
234003582,MDExOlB1bGxSZXF1ZXN0MTI0MjczMDMw,368,Character Loading,25460553,ogmage78,closed,0,,,,,1,2017-06-06T19:47:22Z,2017-06-07T13:23:04Z,2017-06-07T13:23:04Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/368,"* Initial work done for loading character from ace_shard.   Rebased and removed update sql files.
* Tested up to position loading.   Made changes to position, but have not loaded the dictionary yet.
* Fixed a few bugs - attribute loading had a few.
* TODO items:
*	Finish up loading positions then see what is left. 
*	Work on saving as OptimShi - has character creation ready to go.   ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/368/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
234029220,MDExOlB1bGxSZXF1ZXN0MTI0MjkxNTM1,369,Read character creation values from client_portal.dat ,26606778,OptimShi,closed,0,,,,,1,2017-06-06T21:24:03Z,2017-06-26T01:13:55Z,2017-06-07T13:29:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/369,and assign to appropriate Character Properties,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/369/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
234384139,MDExOlB1bGxSZXF1ZXN0MTI0NTQ4NTI2,370,More fun in Zombieland - character loading.   ,25460553,ogmage78,closed,0,,,,,2,2017-06-08T01:08:06Z,2017-06-08T16:35:56Z,2017-06-08T16:09:15Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/370,"I am hoping you will give me a pass on what looks like massive changes to ShardBase.sql - I think Ripley is using mysqlworkbench for his export and I am using Sqlyog.   The changes are minor and have been tested to work.

* Continued work loading character from ace_shard.   Rebased
* Cleaned up whitespace issues where I found them.
* Added cascade delete to all child tables in ace_shard.
* Completed and tested up to skillz loading.   Made a few changes on the db side for key consistancy.
* TODO items:
* Finish up loading - spells, friends, allegiance info, spell comps, spell bars etc. etc....","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/370/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
234701434,MDExOlB1bGxSZXF1ZXN0MTI0Nzc3Njky,371,SaveObject implemented in ShardDatabase.cs,5246554,ddevec,closed,0,,,,,0,2017-06-09T01:56:55Z,2017-06-09T02:31:44Z,2017-06-09T02:31:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/371,"This is my first time doing reflection or ORM in C#, let me know if I made a complete mess out of it.

Otherwise, after an AceObject is passed to SaveObject() all relevant fields of the object appear in the database (as far as I can tell).
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/371/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
234719134,MDExOlB1bGxSZXF1ZXN0MTI0Nzg5Njkw,372,Cleanup of DbGetListAttribute,5246554,ddevec,closed,0,,,,,1,2017-06-09T04:34:00Z,2017-06-09T05:37:49Z,2017-06-09T05:37:49Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/372,"Adjusted DbGetList Attribute to be DbList.  Removed statementId from the attribute, it is now taken from the Id passed on ConstructStatement in ShardDatabase/Database.cs.  Cleaned up hacky Ids I committed earlier.

Also made minor changes to remove the tons of formatting warnings we were getting (one still remains on unimplemented async function).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/372/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
234962380,MDExOlB1bGxSZXF1ZXN0MTI0OTY4MDcy,373,"Fix the ""You do not own this character"" error.",26508216,Lidefeath,closed,0,,,,,0,2017-06-09T23:45:52Z,2018-05-31T12:20:07Z,2017-06-10T02:29:14Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/373,With this fixes the view vw_ace_character still works with inner joins.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/373/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235035072,MDExOlB1bGxSZXF1ZXN0MTI1MDA4OTk3,374,Character Login - continued,25460553,ogmage78,closed,0,,,,,0,2017-06-11T00:38:31Z,2017-06-12T17:14:31Z,2017-06-12T17:14:31Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/374,"* Continued work loading character from ace_shard.   Character reaches world now. 
* Fixed a number of null exception errors
* Outstanding issues:
* has an orm data load error 
* abilities and skills object issue not resolved
* palette, textures not being read or sent","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/374/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235048239,MDExOlB1bGxSZXF1ZXN0MTI1MDE2MjIy,375,"Refactoring, save/restore progress on object overhaul",5246554,ddevec,closed,0,,,,,0,2017-06-11T07:07:22Z,2017-06-30T01:55:42Z,2017-06-12T02:07:49Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/375,"This is an extension of Og II's current pull request.

Things I've added:
Separation of AceObjectProperties{Attribute, Attribute2nd, Skill} from CreatureAbility and CreatureSkill.
ORM Fixes.
Minor database fixes.
Fixes to character saving/updating.
Work getting landblock objects loading properly.
Character can now log-in and walk around, in-game objects don't appear (Although they do appear to pull properly from the DB now).

NOTE:  I've been using a separate ace_shard sql file Og sent me.  I didn't commit it, because a simple diff says its significantly different than the one in the current repo.  I also had to tweak it to get login working.  I'll submit it separately so we can figure out what to do with it.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/375/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235122597,MDExOlB1bGxSZXF1ZXN0MTI1MDU5NDI0,376,Object overhaul,5246554,ddevec,closed,0,,,,,1,2017-06-12T04:27:43Z,2017-06-21T22:58:46Z,2017-06-12T11:14:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/376,"Now successfully enters world, objects appear, and if you have the correct world data, you can even interact with the objects.

Getting close to prior functionality.

Refactored Position and CreatureAbility to front-end and back-end entities.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/376/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235382413,MDExOlB1bGxSZXF1ZXN0MTI1MjQyMTA0,377,Fear the Walking Dead - More work on our object overhaul - bug fixes and continued work,25460553,ogmage78,closed,0,,,,,0,2017-06-12T22:19:04Z,2017-06-13T01:50:15Z,2017-06-13T01:50:15Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/377,"* fixed issue with null exception
* Added OptimShi code to load the correct player appearance 
* Added sending the DataID and InstanceID fields on the player description event.
* Fixed assorted bugs.
* we can now go into and out of combat mode. 
* ci tested and working for all item types.
* telepoi tested and working.
* Trello board updated and cards moved into review - Pending Merge queue.
https://trello.com/b/DXQUfVHj/acemulator-server-project","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/377/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235719498,MDExOlB1bGxSZXF1ZXN0MTI1NDgxNjI0,378,Lord BucketHead - temp fix.   Added start of equipping items and POC code,25460553,ogmage78,closed,0,,,,,0,2017-06-13T23:15:39Z,2017-06-14T02:49:17Z,2017-06-14T02:49:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/378,"* Added getting and setting ContainerID and Wielder into AceObject and surfaced in worldObject
* Put in a hack to show how equipped weapons and shields work.   We will need to establish a place to store this data.
* I put in big TODO to identify the hack - it is benign and will not impact anything else other than to demo the placement
* of the spear in Rand the Game Hunters hand in Holtburg.
* Modified SetPhysicsDescriptionFlags so it can be container and weilder aware.
* Worked with OptimShi and we put in a temp fix for Lord BucketHead.   It is the hair - there is an issue loading hair.   I put a todo on it and commented it out.   Rest of the base model looks to be loading correctly.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/378/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235777044,MDExOlB1bGxSZXF1ZXN0MTI1NTIwODk4,379,SQL Scripts Re-based,11369233,LtRipley36706,closed,0,,,,,0,2017-06-14T06:40:56Z,2017-06-17T04:04:15Z,2017-06-15T04:02:20Z,MEMBER,,0,ACEmulator/ACE/pulls/379,Hopefully this should bring the base scripts into alignment and trim out unnecessary tables from each.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/379/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
235997200,MDExOlB1bGxSZXF1ZXN0MTI1NjgzNTcz,380,Code cleanup and a few bug fixes.  ,25460553,ogmage78,closed,0,,,,,0,2017-06-14T20:17:02Z,2017-06-15T13:18:49Z,2017-06-15T04:54:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/380,"* Trello card - General code clean up - look at all the TODO's -  add the most critical ones here
* Removed unused and replace weenie code that was deprecated with Object-Overhaul
* Fixed hair color bug with code from OptimShi - this should conclude our issues with character appearance.
* Removed unused files related to weenie.
* I spent about an hour trying to debug the position not saving.   None of the character save is working.   It does not error,
* but nothing is changed in the DB.    That is still to-do.
* Updated Trello board.
* I cleaned up the shard base script but I have left it out due to the contentious nature of the discussion in the apply named discord ;)
* added first step of equip item.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/380/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236049528,MDExOlB1bGxSZXF1ZXN0MTI1NzIyNTYx,381,Fixed Position Saving.,5246554,ddevec,closed,0,,,,,0,2017-06-15T01:00:25Z,2017-06-21T22:58:45Z,2017-06-15T04:56:03Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/381,"Positions save now.
Also fixed initial level ??? bug.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/381/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236333988,MDExOlB1bGxSZXF1ZXN0MTI1OTI3MTgx,382,Cleanup backing AceObject,5246554,ddevec,closed,0,,,,,0,2017-06-15T22:41:26Z,2017-06-21T22:58:52Z,2017-06-16T12:14:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/382,"Clean-up of backing state in game.  Primary focuses:

- Make persistent state of in-game objects to be backed by the AceObject
- Remove unneeded database fields from active state
- Stop in-game objects from redundantly writing to their AceObject.

Also fixes:
- Attribute2nd (vitals -- health/stam/mana) initializing incorrectly.

Still needs to be done:
- ORM interface cleanup.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/382/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236338716,MDExOlB1bGxSZXF1ZXN0MTI1OTMwNjYw,383,Fixed bug with player creation ,25460553,ogmage78,closed,0,,,,,0,2017-06-15T23:11:29Z,2017-06-16T23:08:59Z,2017-06-16T12:15:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/383,"* made a bunch of comments and notes…about things I discovered so they would not get lost.
Minor stuff, I can resubmit if it is not merge worthy.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/383/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236466345,MDExOlB1bGxSZXF1ZXN0MTI2MDIwNjUy,384,Object overhaul,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-06-16T12:16:10Z,2017-06-16T13:54:45Z,2017-06-16T13:54:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/384,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/384/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236557407,MDExOlB1bGxSZXF1ZXN0MTI2MDg3OTgw,385,asynchronous-object-saving outside game loop.,25387933,Forbiddenz,closed,0,,,,,2,2017-06-16T18:20:43Z,2017-10-12T15:36:27Z,2017-06-20T11:57:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/385,"Moved DB saving into its own game and implemented a blocking collection model.
Card - asynchronous-object-saving","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/385/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236604016,MDExOlB1bGxSZXF1ZXN0MTI2MTIwMjMz,386,Bug Fix - Delete Character Trello Card,25460553,ogmage78,closed,0,,,,,0,2017-06-16T21:39:39Z,2017-06-19T16:45:09Z,2017-06-17T22:21:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/386,"* Trello card task - delete character crashes server.   Fixed this issue.
* Added event code for database to do the actual house keeping to flip the flag once the hour restore period has expired.
* Minor code cleanup.
* Removed update directory for old character database.
* Fixed pickup and drop item.   Location was protected and not able to be set for loot (WorldObjects)   I temp set this to allow set.   Once we refactor physics data out this can go away.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/386/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236637738,MDExOlB1bGxSZXF1ZXN0MTI2MTQyNDU1,387,"Re-added SpellTable, CLandblockInfo and fixed some StyleCop issues.",26606778,OptimShi,closed,0,,,,,0,2017-06-17T04:21:01Z,2017-09-01T05:13:59Z,2017-06-17T22:23:32Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/387,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/387/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236638866,MDExOlB1bGxSZXF1ZXN0MTI2MTQzMDY1,388,"Fix ""Player"" name.",5246554,ddevec,closed,0,,,,,1,2017-06-17T04:49:01Z,2017-06-21T22:58:39Z,2017-06-19T12:08:30Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/388,"Cleaned up player initialization, and bugs related to player creation.  Player names now display properly.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/388/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236663650,MDExOlB1bGxSZXF1ZXN0MTI2MTU2Njg1,389,CreatureVital reintroduction,5246554,ddevec,closed,0,,,,,0,2017-06-17T14:27:32Z,2017-06-21T22:58:36Z,2017-06-19T12:13:30Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/389,"Reintroduces the separation between CreatureAbility and CreatureVital.  
Adds the ""Tick"" regeneration mechanic (which I'll hopefully introduce another merge request to remove :-P).
Creates the ""setvital"" debug function.

Minor comment cleanup.

NOTE: will conflict with player name branch.  First merge that branch, then this branch overwrites, or I'll submit another pull request after that branch is merged.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/389/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236675578,MDExOlB1bGxSZXF1ZXN0MTI2MTYzMzEz,390,Landlbock/Concurrency/Core Functionality Restructure,5246554,ddevec,closed,0,,,,,4,2017-06-17T18:09:03Z,2017-06-20T02:00:12Z,2017-06-20T01:54:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/390,"Note: This branch builds upon the ""Player"" name fix, and ""CreatureVital"" branches.  If they're merged I'll rebase and recreate this pull.

Note: This branch also includes Og's ""MoveTo"" operations.

The overall goal of this branch is to restructure our main-game logic in a manner that safely allows parallelism, without complex locking schemes.  The overall idea of this restructure can be summarized as follows:
- Physics, Movement, and Game Logic updates are done in their own phases, each phase is executed to completion before the next begins.
- Within the GameLogic phase, WorldObjects are updated in parallel, but updates lock-free operations with these mechanics:
   -- WorldObjects can only read/modify their own state on their own turn to ""Act""
   -- Communication between WorldObjects is allowed by having the Landblock forward ""Actions"" between the WorldObjects.

To facilitate this design I've added several classes (IActions, IActors, ActionChains) that encapsulate this functionality.  A more detailed list of the behaviors is below.

Overall summary:
All work happens from UpdateWorld() thread in WorldManager
Outline of framework for physics position updates.
Added work managing infrastructure: Actions -- Remove busy-waiting/polling

Parallelism handled as follows:
- All motion (will be) calculated by the physics engine (based on requests done in the object update phase)
- After calculated, all motion is updated sequentially in the UpdateWorld function
- All landblocks update any objects within them through Actions on an ActionQueue
  -- Landblocks are acted on in parallel
  -- Objects within landblocks act sequentially
- Any action on an object may only read/modify the object its acting on 
  -- Exception - position information - guaranteed not to change by above points
  -- Any cross-object interactions must be done by queueing an action on the other object with data passed (This is currently handled by delegate/lambda functions within the action infrastructure, but could be co-routines, or dedicated per-action classes)

Other improvements/notes:
- The ""DelayManager"" Handles waiting, removing the need for busy waiting.
- All asyncrhonous inputs (e.g. network communication) must delegate their work to the action handlers of objects (Designated by functions prefixed with HandleAction).
- There is an infrastructure for position-based broadcasting (although issues in our landblock adjacencies need to be fixed before this will actually work cross-landblocks)
- Landblocks are also ""Actors"" as they must manage object pick-ups/etc.
- The movement to the ""Actor/Action"" interface removes any need for polling -- If we have a world with 1 billion entries, but only 2 active, it will run as fast as a world with 2 entries

This is a huge change, I tried to segment it, but the races caused by restructuring the parallelism broke the server until I restructured how incoming network events happened -- The end result was this branch.

As far as I know the current branch does everything master does, plus has some minor bugfixes, and supports broadcasts for more things (like coming out of portal space, updating position, dropping/picking up items).

I'm looking forward to hear what you think of this structure.

Notable things removed:
Landblock.GeWorldObjectById
Landblock.Broadcast (handled by players now)
Landblock.UseTime

Things that still need to be done:
More robust object tracking
Asynchronous Landblock loading/prefetching.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/390/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236686254,MDExOlB1bGxSZXF1ZXN0MTI2MTY5MzE4,391,Dress-up,26606778,OptimShi,closed,0,,,,,0,2017-06-17T21:53:27Z,2017-06-26T01:13:51Z,2017-06-18T02:42:51Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/391,"Added functionality for the GameMessageObjDescEvent message (fired when a model changes, like when equipping new items). Also included a debug command ""@equiptest"" to expose the new functions which will cosmetically equip your character with a single piece of armor/clothing (only cosmetic, no actual ""equipping"" is being done at this time)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/391/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236698074,MDExOlB1bGxSZXF1ZXN0MTI2MTc1NzU4,392,Landblock Object Loading Fix,11369233,LtRipley36706,closed,0,,,,,0,2017-06-18T03:34:53Z,2017-06-18T03:56:14Z,2017-06-18T03:42:26Z,MEMBER,,0,ACEmulator/ACE/pulls/392,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/392/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236698638,MDExOlB1bGxSZXF1ZXN0MTI2MTc2MDcx,393,Re-Added Configuration for Maximum Allowed Sessions,37453,fantoms,closed,0,,,,,0,2017-06-18T03:52:41Z,2017-06-28T19:45:33Z,2017-06-19T12:14:08Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/393,"* Added a Config Setting and Max Allowed Sessions code, to allow configuration of the total concurrent connections.

This code was lost during the object-overhaul change: PR #345 -

* Changed the configuration sections to allow for the ""MaxSessions"" setting.
* There is a default value of 128.
* Check the Config.json.example for help.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/393/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236698696,MDExOlB1bGxSZXF1ZXN0MTI2MTc2MTA0,394,Setting ON DELETE CASCADE for ace_poi,11369233,LtRipley36706,closed,0,,,,,0,2017-06-18T03:54:45Z,2017-06-18T03:56:07Z,2017-06-18T03:55:58Z,MEMBER,,0,ACEmulator/ACE/pulls/394,Syncing ACE-World and ACEmulator.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/394/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236699270,MDExOlB1bGxSZXF1ZXN0MTI2MTc2NDAx,395,Re-Added a debug command to list all players connected to the server.,37453,fantoms,closed,0,,,,,0,2017-06-18T04:14:24Z,2017-06-28T19:45:31Z,2017-06-19T12:14:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/395,"This code was lost during the object-overhaul switchover, from the PR #346 and was altered slightly to allow use from within the server console.

* Added a Helpful debug command for testing who is connected too your server.
* Can now be used from the console.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/395/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
236738946,MDExOlB1bGxSZXF1ZXN0MTI2MTk4ODg2,396,Make NPCs in database wield items also in database,11369233,LtRipley36706,closed,0,,,,,0,2017-06-18T19:00:23Z,2017-07-08T23:55:20Z,2017-06-19T12:15:29Z,MEMBER,,0,ACEmulator/ACE/pulls/396,"This code change corrects issues with AceObject, PhysicsData, DebugObject and UsableObject to make wielded items in database appear in world and attach mostly correct to their wielders. I say mostly correct as visually they look good, but all of the NPCs are static at this point and we're not setting the children flag on NPCs as well so there could be issues laying in wait for us when we get to movement for them which will require us to get that part working.

This works with data found in the last two ACE-World releases, no new export was required, although the latest release would be suggested as it fixes issues with landblock loading.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/396/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237000873,MDExOlB1bGxSZXF1ZXN0MTI2MzgxMjU5,397,Fix CIRand admin function.,25460553,ogmage78,closed,0,,,,,0,2017-06-19T19:39:19Z,2017-06-21T20:47:38Z,2017-06-20T17:17:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/397,"* Trello card task - Extend ORM code to support multiple getLists or implement another method to query by alternate keys - re-implement cirand
* Many thanks to ddevec - he did the work on the ORM code revision.   I just tested and implemented for my use.
* Fixed undiscovered alignment bug at hook type we were sending as dword and it is a word.   That was shifting everything below it.
* Added priority to aceObject and set the aceObject priority field as a backing object for worldObject priority.
* Created function to calculate container burden.
* added view to world database that was needed for cirand and will be used in loot generation.
* updated position table to have a faster function for location per discord discussion.
* Updated trello board to reflect current project status.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/397/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237071858,MDExOlB1bGxSZXF1ZXN0MTI2NDMyODcz,398,Landblock/Concurrency/Core Functionality Restructure (attempt #2),5246554,ddevec,closed,0,,,,,7,2017-06-20T02:02:12Z,2017-06-21T22:58:33Z,2017-06-21T18:12:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/398,"Sorry about recreating the pull.  I accidentally borked my old branch and had to close the PR.

Note: This branch also includes Og's ""MoveTo"" operations.

The overall goal of this branch is to restructure our main-game logic in a manner that safely allows parallelism, without complex locking schemes.  The overall idea of this restructure can be summarized as follows:
- Physics, Movement, and Game Logic updates are done in their own phases, each phase is executed to completion before the next begins.
- Within the GameLogic phase, WorldObjects are updated in parallel, but updates lock-free operations with these mechanics:
   -- WorldObjects can only read/modify their own state on their own turn to ""Act""
   -- Communication between WorldObjects is allowed by having the Landblock forward ""Actions"" between the WorldObjects.

To facilitate this design I've added several classes (IActions, IActors, ActionChains) that encapsulate this functionality.  A more detailed list of the behaviors is below.

Overall summary:
All work happens from UpdateWorld() thread in WorldManager
Outline of framework for physics position updates.
Added work managing infrastructure: Actions -- Remove busy-waiting/polling

Parallelism handled as follows:
- All motion (will be) calculated by the physics engine (based on requests done in the object update phase)
- After calculated, all motion is updated sequentially in the UpdateWorld function
- All landblocks update any objects within them through Actions on an ActionQueue
  -- Landblocks are acted on in parallel
  -- Objects within landblocks act sequentially
- Any action on an object may only read/modify the object its acting on 
  -- Exception - position information - guaranteed not to change by above points
  -- Any cross-object interactions must be done by queueing an action on the other object with data passed (This is currently handled by delegate/lambda functions within the action infrastructure, but could be co-routines, or dedicated per-action classes)

Other improvements/notes:
- The ""DelayManager"" Handles waiting, removing the need for busy waiting.
- All asyncrhonous inputs (e.g. network communication) must delegate their work to the action handlers of objects (Designated by functions prefixed with HandleAction).
- There is an infrastructure for position-based broadcasting (although issues in our landblock adjacencies need to be fixed before this will actually work cross-landblocks)
- Landblocks are also ""Actors"" as they must manage object pick-ups/etc.
- The movement to the ""Actor/Action"" interface removes any need for polling -- If we have a world with 1 billion entries, but only 2 active, it will run as fast as a world with 2 entries

This is a huge change, I tried to segment it, but the races caused by restructuring the parallelism broke the server until I restructured how incoming network events happened -- The end result was this branch.

As far as I know the current branch does everything master does, plus has some minor bugfixes, and supports broadcasts for more things (like coming out of portal space, updating position, dropping/picking up items).

I'm looking forward to hear what you think of this structure.

Notable things removed:
Landblock.GeWorldObjectById
Landblock.Broadcast (handled by players now)
Landblock.UseTime

Things that still need to be done:
More robust object tracking
Asynchronous Landblock loading/prefetching.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/398/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237199300,MDExOlB1bGxSZXF1ZXN0MTI2NTI1MDkx,399,app voyer test,25387933,Forbiddenz,closed,0,,,,,0,2017-06-20T12:53:54Z,2017-10-12T15:38:07Z,2017-06-20T17:06:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/399,"test , don't merge me...","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/399/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237371719,MDExOlB1bGxSZXF1ZXN0MTI2NjUwMDU1,400,Fix to asynchronous saving bug on character creation.,5246554,ddevec,closed,0,,,,,0,2017-06-20T23:18:54Z,2017-06-21T22:58:30Z,2017-06-21T16:52:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/400,"There is a bug in one of our latest patches, in which asynchronous saving races with loading, causing the game to sometimes (frequently) crash on player creation.  This patch causes that function (run in session network handler, so can block) to wait for the initial character creation DB save to complete before attempting login/load.

Also fixes issue in prior code in which the asynchronous saving loop would not stop when server shutdown was requested.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/400/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237372335,MDExOlB1bGxSZXF1ZXN0MTI2NjUwNTI1,401,Equip and Unequip items,25460553,ogmage78,closed,0,,,,,3,2017-06-20T23:22:54Z,2017-06-22T00:28:33Z,2017-06-22T00:28:33Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/401,"* Added the ability to equip and unequip items and have it also update your visual appearance.
* We have some data work to do - to add clothing table did values, but we have added 30 or so for testing out of 150+ needed.   Thanks OptimShi for the script and the updates - also all the help on clothing!
* I am adding the script to load those testing values - they are the permanent solution just incomplete.   However, it properly goes in ace world.   The prerequisite to running the script is to have data loaded.   If you do it out of order, no harm, it just will not work.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/401/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237688190,MDExOlB1bGxSZXF1ZXN0MTI2ODc4Njky,402,Fixed logoff crashing bug,5246554,ddevec,closed,0,,,,,0,2017-06-21T23:01:02Z,2017-06-30T01:55:45Z,2017-06-22T03:48:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/402,"My branch was causing a racy bug on logoff because I had not synchronized those operations with the server.  Those operations are now synchronized, as well as properly adding broadcasting for the logoff animation, and a timeout before the player is removed from world (while the logoff animation plays).

And uncommented learnspell (which now broadcasts the animation, so all can see you learn a spell).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/402/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237758656,MDExOlB1bGxSZXF1ZXN0MTI2OTI4MzM3,403,Contributor Code of Conduct,11369233,LtRipley36706,closed,0,,,,,0,2017-06-22T07:45:58Z,2017-07-08T23:55:19Z,2017-06-22T07:47:20Z,MEMBER,,0,ACEmulator/ACE/pulls/403,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/403/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
237897401,MDExOlB1bGxSZXF1ZXN0MTI3MDMwOTI5,404,Inventory saving,25387933,Forbiddenz,closed,0,,,,,1,2017-06-22T16:09:56Z,2017-06-22T19:51:36Z,2017-06-22T19:51:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/404,"Ability to save inventory, no load..
But this shows us a bigger issue in our data model.

There also a rig job in here to allow up to 20 transactions conflicts before failing but there no transaction order, so its not the greatest method and could result in saved operations happening out of order due to deadlock failure on the database.

Overall there is a bigger issue in our data model that needs addressed.
This PR is just to allow anyone to see it live if they remove the generic error handling I put in to make this not crash ACE.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/404/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238002383,MDExOlB1bGxSZXF1ZXN0MTI3MTA5MTM3,405,"Serialized saves, added caching manager for saves.",5246554,ddevec,closed,0,,,,,1,2017-06-22T23:36:28Z,2017-06-23T04:15:44Z,2017-06-23T04:15:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/405,"Goal: resolve MySql deadlock exception caused by saving too much stuff at once.

Added serialization of ShardDatabase saves.
Added save-lots debug function.
Also fix bug in DbManger on shutdown.

TODO:  combine DbManager and ShardDatabase.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/405/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238030414,MDExOlB1bGxSZXF1ZXN0MTI3MTI3NjMz,406,Shutdown Controls,37453,fantoms,closed,0,,,,,0,2017-06-23T03:22:19Z,2017-06-28T19:45:30Z,2017-06-23T12:49:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/406,"With these changes, there is now a way to stop the server after an interval has passed.

Stop the server after the interval set in the Config has Passed:
`@shutdown <shutdown text>`
Stop the Server immediately:
`@stop-now`
Cancel an in progress shutdown:
`@cancel-shutdown`
Change the seconds to wait until shutdown:
`@set-shutdown-interval <0-99999>`

There is also now a config change that adds an additional variable called `ShutdownInterval`. The goal of the variable is to tell the server how many seconds it will need to wait until shutdown. The maximum seconds allowed is 99999 and the default is 60.

This request has been worked on and tested since April, please let me know if you spot any issues. Previous iteration can be found here with additional concepts/scenarios: (https://github.com/LtRipley36706/ACE/pull/13). 

Here is an updated log:
- Added `@set-shutdown-interval` command, to change the delay on the fly.
- Added `@shutdown`, `@stop-now`, and `@cancel-shutdown` commands.
- Added server shutdown command for admins - needed in consoles.
- Added shutdown text, logoff, admin shutdown message.
- Added `ShutdownInterval` to the `ConfigManager` Server Section, with a default of 60 seconds.
- Added `ShutdownInterval` to the example config
- Added some logging and moved the final exit too `ServerManager`.
- Added a message broadcast through Session, to announce server broadcast messages from `WorldManager`.
- Changed the case of the Config.json in the project build events, to match a Linux use case requirement for opening the Config file.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/406/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238036967,MDExOlB1bGxSZXF1ZXN0MTI3MTMxODk4,407,"General ShardDatabase cleanup, serialization, and caching layer",5246554,ddevec,closed,0,,,,,1,2017-06-23T04:19:12Z,2017-06-28T19:56:12Z,2017-06-28T19:56:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/407,"DbManager is now Integrated into ShardDatabase along with:

- Serial database writing.
- Caching layer to ensure latest data is always loaded
- Cleanup to ShardDatabase (replaced largely redundant functions with templated variants).
- Fix to shutdown of saving thread.
- Added multi-save debugging function save-logs (because who doesn't want to save their character 10k times right now?)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/407/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238061729,MDExOlB1bGxSZXF1ZXN0MTI3MTQ4NDkz,408,Quick fix for Portals to become functional,11369233,LtRipley36706,closed,0,,,,,1,2017-06-23T07:24:36Z,2017-07-08T23:55:18Z,2017-06-27T04:04:33Z,MEMBER,,0,ACEmulator/ACE/pulls/408,"Code provided by @ogmage78 successfully re-enables portals to work again on double click provided they have PositionType.Destination data in the ACE-World database. Latest release of database includes all previously submitted portal destination data.

Also corrected ObjectType issue in CollidableObject. It was not being set from data stored in database leading to aberrant behavior in OnUse in game.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/408/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238174164,MDExOlB1bGxSZXF1ZXN0MTI3MjMwNDcx,409,Fixed several movement related bugs,5246554,ddevec,closed,0,,,,,0,2017-06-23T15:21:04Z,2017-06-30T01:55:22Z,2017-06-23T15:23:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/409,"Bugs fixed:

- Player sticks when coming out of teleport (wasn't clearing requested positions properly from physics)
- Game sometimes crashes when transferring landblocks (Wasn't clearing player from old landblock properly)
- ""glitch"" in motion shortly after teleporting (was setting position after teleporting improperly).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/409/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238271678,MDExOlB1bGxSZXF1ZXN0MTI3MzAyMzk1,410,Monster generator refactored,26508216,Lidefeath,closed,0,,,,,1,2017-06-23T22:59:04Z,2018-05-31T12:21:00Z,2017-06-26T12:04:11Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/410,"Remove the old creatures spawning and unused generator stuff and implement a new generator logic with the new data model. Use the included sql script to import testdata 'Drudgeskulkergen' near Holtburg LS.

The spawned drudge doesn't show up on radar yet, this has to be fixed still.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/410/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238285891,MDExOlB1bGxSZXF1ZXN0MTI3MzEyMDY3,411,Pack Rat: Ready for review and merge.,25460553,ogmage78,closed,0,,,,,0,2017-06-24T01:47:10Z,2017-06-27T15:39:49Z,2017-06-27T14:43:05Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/411,"This has been extensively tested.   I am sure I have not followed all of the new action chain methodology correctly.   I would like to get this in as I think it moves us down the field.   I think as I get a better understanding of the action chain - I can refactor this with a minimum impact.   

* Added the ability to equip / unequip items and it will also update your visual appearance.
* We have some data work to do - finish add clothing table did values - a lot of these are done - thanks OptimShi and Ripley
* Tested - pack to pack, slot to slot, pack to ground, ground to pack, ground to wielded, wielded to ground
* move packs, move items. 
* Fixed save character options - this will need to be refactored - our character object needs some work.   
* UI changes still blows up - this fix just addressed the options1 and options2
* Fixed crash on lock or unlock UI
* TODO
1 clothing priority does not look to be right - somethings overlap incorrectly.
2 refactor for correct action chain pattern.
3 fix save for UI changes
4 refactor character save and load.   Talk to Mogwai on best way to do this.
5 UI positions still not saving - need to fix that next.

To test:  
@ci 136 (pack) or find a pack of your choice ( you can create several to test pack to pack and pack moves)
@ci 127 is a pair of pants

Extended testing
@cirand 2 (armor)
@cirand 4 (clothes)

Test items, if you get the message no clothing entry just drop and keep going until you have a nice selection to test.
Have fun.

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/411/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238299521,MDExOlB1bGxSZXF1ZXN0MTI3MzIwNDI1,412,Handle non-static spawning portals,10137,ghost,closed,0,,,,,0,2017-06-24T06:33:27Z,2017-10-18T14:07:33Z,2017-06-26T12:05:50Z,NONE,,0,ACEmulator/ACE/pulls/412,"* Remove unneeded debug command CreateLifestone
* Modified PortalObjectFactory class to create specialized portals that are temporary spawns, such as the Humming Crystal Portal
* Created enums for the weenieclassID's for the special portals
* Added the missing ObjectType to the CollidableObject class","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/412/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238350467,MDExOlB1bGxSZXF1ZXN0MTI3MzQ3NTU1,413,Rebased and synced SQL scripts.,11369233,LtRipley36706,closed,0,,,,,3,2017-06-24T23:58:50Z,2017-07-08T23:55:16Z,2017-06-26T12:06:51Z,MEMBER,,0,ACEmulator/ACE/pulls/413,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/413/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238413624,MDExOlB1bGxSZXF1ZXN0MTI3MzgyMzQ0,414,For Review: Expanded Generator Code/Scripting,11369233,LtRipley36706,closed,0,,,,,8,2017-06-25T23:15:22Z,2017-07-08T23:55:17Z,2017-06-27T04:06:40Z,MEMBER,,0,ACEmulator/ACE/pulls/414,Please review for discussion and brainstorming how best we implement going forward,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/414/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238421005,MDExOlB1bGxSZXF1ZXN0MTI3Mzg2NTg5,415,Re-enable the equiptest debug command,26606778,OptimShi,closed,0,,,,,0,2017-06-26T01:18:44Z,2017-07-10T16:43:25Z,2017-06-26T12:03:32Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/415,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/415/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238566912,MDExOlB1bGxSZXF1ZXN0MTI3NDg3NzE0,416,Add protection to SpawnPortal,10137,ghost,closed,0,,,,,0,2017-06-26T14:45:58Z,2017-10-18T14:07:31Z,2017-06-26T15:09:28Z,NONE,,0,ACEmulator/ACE/pulls/416,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/416/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238679342,MDExOlB1bGxSZXF1ZXN0MTI3NTcwOTQ4,417,Fix: Incorrect data type when changing a bigint property that has previously been set,37453,fantoms,closed,0,,,,,0,2017-06-26T21:47:19Z,2017-06-28T19:45:28Z,2017-06-27T01:14:49Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/417,"* Changed from uint to ulong, to match the bigint/int64 data types.

This fix allows characters to once again level up correctly, along with allowing other properties to work.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/417/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238711206,MDExOlB1bGxSZXF1ZXN0MTI3NTk0MTk3,418,Fix race in SpawnPortal when using ActionQueue and assign unique Id's to each Portal object,10137,ghost,closed,0,,,,,0,2017-06-27T01:12:26Z,2017-10-18T14:07:30Z,2017-06-27T01:15:22Z,NONE,,0,ACEmulator/ACE/pulls/418,"Someone other than me should check this PR in practice to see if it really is working, and that it isn't just a fluke that it works for me, before it is merged.  Should be able to summon multiple portals and they all should individually disappear in 15 seconds.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/418/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238721230,MDExOlB1bGxSZXF1ZXN0MTI3NjAxMDA4,419,Weenie caching to fix portals,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-06-27T02:32:14Z,2017-06-27T03:38:55Z,2017-06-27T03:38:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/419,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/419/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238732025,MDExOlB1bGxSZXF1ZXN0MTI3NjA4MzA5,420,Add Generator object,11369233,LtRipley36706,closed,0,,,,,0,2017-06-27T04:06:15Z,2017-07-08T23:55:15Z,2017-06-27T17:03:14Z,MEMBER,,0,ACEmulator/ACE/pulls/420,"Included test data for training dungeon part 1 which should provide a few objects to help with system build out, such as inventory, respawning, object tracking between clients...","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/420/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238824497,MDExOlB1bGxSZXF1ZXN0MTI3Njc0NzI4,421,Master Preload,25387933,Forbiddenz,closed,0,,,,,1,2017-06-27T11:48:49Z,2017-10-12T15:36:39Z,2017-06-27T15:02:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/421,"Added ability to preload all the landblocks in the game.
This is a massive process, but its a great tool for testing or even benchmarking in the near future.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/421/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238876547,MDExOlB1bGxSZXF1ZXN0MTI3NzEzMTUx,422,For Review and possible merge: Fix portal requirements,10137,ghost,closed,0,,,,,0,2017-06-27T14:45:33Z,2017-06-27T15:25:55Z,2017-06-27T14:47:55Z,NONE,,0,ACEmulator/ACE/pulls/422,"The code works during my functional test, but I don't know if it was the correct way to fix it.  Also, there seems to be a slight delay when using a another portal, after having failed a different portal's activation requirements.  Example, with a character that is lower than 80, try to use the Eastwatch portal in the TN Annex.  Player gets denied because of being too low a level.  Next use the Danby's Output portal next to the Eastwatch one.  There is a slight delay before teleport.  Subsequent portals that don't block do not have a delay, until the next time the player doesn't pass the requirements of another portal.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/422/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238895606,MDExOlB1bGxSZXF1ZXN0MTI3NzI3NTUy,423,Review and possible merge: Fix portal requirements,10137,ghost,closed,0,,,,,1,2017-06-27T15:42:32Z,2017-10-18T14:07:29Z,2017-06-28T18:34:40Z,NONE,,0,ACEmulator/ACE/pulls/423,"The code works during my functional test, but I don't know if it was the correct way to fix it. Also, there seems to be a slight delay when using a another portal, after having failed a different portal's activation requirements. Example, with a character that is lower than 80, try to use the Eastwatch portal in the TN Annex. Player gets denied because of being too low a level. Next use the Danby's Output portal next to the Eastwatch one. There is a slight delay before teleport. Subsequent portals that don't block do not have a delay, until the next time the player doesn't pass the requirements of another portal.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/423/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238903055,MDExOlB1bGxSZXF1ZXN0MTI3NzMzMjIy,424,quickfix,25387933,Forbiddenz,closed,0,,,,,1,2017-06-27T16:05:55Z,2017-06-27T16:54:57Z,2017-06-27T16:54:57Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/424,Quick fix for 0 index bug.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/424/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
238934847,MDExOlB1bGxSZXF1ZXN0MTI3NzU2ODc4,425,For Review Only: Added simple network session timeouts,37453,fantoms,closed,0,,,,,0,2017-06-27T18:04:16Z,2017-06-28T19:45:10Z,2017-06-28T18:37:59Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/425,"This is mostly for review, since @Zegeger has mentioned he created code to work with timeouts in issue #336, but I want to keep my server from crashing when 127 clients have connected, so I've implemented simple timeout testing code that is based on `ticks`.

In this code, sessions will timeout after 60 seconds of inactivity and be disconnected by the `WorldManager`.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/425/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239007601,MDExOlB1bGxSZXF1ZXN0MTI3ODEwOTU4,426,Physics Data & Model Data Flattened - code cleanup. Ready for review and Merge,25460553,ogmage78,closed,0,,,,,3,2017-06-27T23:01:29Z,2017-06-28T20:17:22Z,2017-06-28T19:25:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/426,"* Completed work on flattening Physics Data and Model Data
* Did work to align names of properties on aceObject and World Object using unabbreviated names used by the client.
* Put in comments for aclogviewer names
* Cleaned up initialization code for various descendants of world Object.   
* Cleaned up redundant using statements.
* Tested all of my pack work, equipping items, item drop and pick up, portal summoning, world portals, ci and cirand as well as The
* item generator work.   Could not test corpse.
* TODO could not test corpse creation as kill was broken before I started.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/426/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239054177,MDExOlB1bGxSZXF1ZXN0MTI3ODQzMjIy,427,Sequence and acks,12808515,Zegeger,closed,0,,,,,0,2017-06-28T05:08:42Z,2017-06-29T02:43:50Z,2017-06-28T20:28:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/427,"Updated Sequence objects to allow for direct access to value (as opposed to just the byte array)
Added MaxValue option to Sequence objects.
Enabled sending network acks to client.
Updated Motion sequence to set max value based on client source, MSB of the sequence is reserved.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/427/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239135102,MDExOlB1bGxSZXF1ZXN0MTI3OTAxMzg1,428,Load alb quick fix / diag fix,25387933,Forbiddenz,closed,0,,,,,1,2017-06-28T11:34:25Z,2017-10-12T15:37:04Z,2017-06-28T20:26:40Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/428,"Found small bug in diag tool + bug in load landblock.
should work now... hopefully..

Not the best at landblock understanding here.
But after talking with others.. it appears the landblock in ac are from 0 to 254 ?
I am still confused by this... and Honestly I am just tired of dealing with this... yet trying to fix it..

At this point.. someone else who is understands the landblock system better can patch it if its not right.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/428/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239252934,MDExOlB1bGxSZXF1ZXN0MTI3OTg4MzAy,429,Inventory save,25387933,Forbiddenz,closed,0,,,,,1,2017-06-28T18:24:38Z,2017-10-12T15:36:47Z,2017-06-30T17:39:33Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/429,"Ability to save inventory, code works but is not enabled due to deadlock issue with our main DB code.
I had some hack code to get around deadlock and it did save the items to the db correctly as far as I can tell.  We still will need load code of course..","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/429/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239317491,MDExOlB1bGxSZXF1ZXN0MTI4MDM0OTEw,430,Review: Extend generators to spawn linked generators,26508216,Lidefeath,closed,0,,,,,2,2017-06-28T22:35:51Z,2018-05-31T12:20:57Z,2017-07-07T15:12:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/430,"This introduces linked generators: install the sql script to be able to play with it.
With this you can spawn single monsters, spawn monster camps and have random spawns on a landblock.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/430/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239333845,MDExOlB1bGxSZXF1ZXN0MTI4MDQ3MDgw,431,Update readme with minimum required database versions,25460553,ogmage78,closed,0,,,,,0,2017-06-29T00:23:43Z,2017-07-03T15:35:18Z,2017-06-29T03:58:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/431,We have had some contributors as well as people trying to install have issues.   Our computed columns require a newer version of mysql or mariadb.   Updated to reflect that.   ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/431/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239359478,MDExOlB1bGxSZXF1ZXN0MTI4MDY0Nzk3,432,Database serialization - FOR REVIEW ONLY,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-06-29T03:55:12Z,2017-06-30T02:20:36Z,2017-06-30T02:20:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/432,"* database stuff works reliably
* getting a lot of ""Received unhandled fragment opcode: 0xF6EA"" messages
* logging in once works, and stuff seems to work.  after logging off or reconnecting a client and re-entering, the character leaves the tunnel but is stuck in purple bubble hangman state.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/432/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239508182,MDExOlB1bGxSZXF1ZXN0MTI4MTczMTAz,433,Auto closing Doors,10137,ghost,closed,0,,,,,0,2017-06-29T14:57:04Z,2017-10-18T14:07:27Z,2017-06-29T15:13:57Z,NONE,,0,ACEmulator/ACE/pulls/433,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/433/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239642796,MDExOlB1bGxSZXF1ZXN0MTI4MjcxMzI5,434,Appraise Items (Updated 7/2) READY FOR MERGE,25460553,ogmage78,closed,0,,,,,2,2017-06-29T23:58:44Z,2017-07-04T15:54:44Z,2017-07-04T15:54:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/434,"I switched tracks as I needed appraisal to work.   I have appraisal about 90% finished - it is functional and a good bit ahead of where we were.   I have put in the foundation for the correct combat stance - but I have more work to do as well as refactoring the code for stance.   However, this is a lot and a delayed merge could cause issues.   I would have separated them but I messed up and worked too much in the wrong branch.   I don't think anything I have done will regress us in anyway.   ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/434/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239655355,MDExOlB1bGxSZXF1ZXN0MTI4MjgwMzkz,435,Mogwai's db serialization,5246554,ddevec,closed,0,,,,,0,2017-06-30T01:38:26Z,2017-06-30T12:00:08Z,2017-06-30T12:00:08Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/435,"Fixed Mogwai's concurrency problems, based off: https://github.com/ACEmulator/ACE/pull/432","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/435/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239667444,MDExOlB1bGxSZXF1ZXN0MTI4Mjg4NzUx,436,Basic support for Animation Broadcasts,5246554,ddevec,closed,0,,,,,0,2017-06-30T03:21:32Z,2017-06-30T12:01:06Z,2017-06-30T12:01:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/436,"Basic support for animation broadcasts.  

- A client may now observe running/sidestepping/other animations/motion for another player
- FIXME: All animation speed data is just made-up.  Some of it appears correct, but I need to dig the formulas out of the client.
- FIXME/TODO: Some animations are broadcast multiple times (e.g. waving).  This is because we're receiving multiple requests form the client (possibly a networking error).  I should dedupe this, but I don't have animation timing information to do this.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/436/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239679766,MDExOlB1bGxSZXF1ZXN0MTI4Mjk3MjAz,437,Of Guids and Generators...,11369233,LtRipley36706,closed,0,,,,,0,2017-06-30T05:19:51Z,2017-07-08T23:55:13Z,2017-07-01T05:00:44Z,MEMBER,,0,ACEmulator/ACE/pulls/437,"* Changed WorldBase to allow for auto incrementing of aceObjectId and weenieClassId
* Changed WEENIE_MAX to be 199999 to account for ACE (re)created weenies starting at 100000
* Several changes to GuidManager and redirected CommonObjectFactory to use it instead of its own list
* Fixed some constructor issues related to Guids. Not sure if it is the right way to go about it but does seem to work in testing.
* Altered GameEventIdentifyObjectResponse to output debug stuff for more objects temporarily and fixed its output of Guids in decimal form.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/437/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239758612,MDExOlB1bGxSZXF1ZXN0MTI4MzU0ODQw,438,Shard database serialization with ddevec fixes,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-06-30T11:59:11Z,2017-06-30T12:08:44Z,2017-06-30T12:08:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/438,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/438/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239784834,MDExOlB1bGxSZXF1ZXN0MTI4Mzc0MzU4,439,Fixed serialization bug.,25460553,ogmage78,closed,0,,,,,1,2017-06-30T13:50:06Z,2017-07-03T15:35:03Z,2017-06-30T15:57:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/439,"* Fixed issue with the wrong data size being used in the weenie data serialization.
* Structure, Max Structure, StackSize and MaxStackSize were being sent as uint and they are ushort.  This caused intermittent alignment issues.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/439/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239792740,MDExOlB1bGxSZXF1ZXN0MTI4MzgwMTg4,440,"cleaned up compiler warnings, minor tweaks to shard db interface",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-06-30T14:18:25Z,2017-06-30T15:18:34Z,2017-06-30T15:18:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/440,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/440/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239845055,MDExOlB1bGxSZXF1ZXN0MTI4NDE4MzAz,441,SimpleCrudeInventorySave,25387933,Forbiddenz,closed,0,,,,,0,2017-06-30T17:42:17Z,2017-10-12T15:37:56Z,2017-07-20T11:29:54Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/441,"Seems to work, saves fine now with no deadlocks..

Only concern now is, how to do the checking and only update properties that are dirty.
Some guidance would be appreciated .","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/441/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
239978175,MDExOlB1bGxSZXF1ZXN0MTI4NTAzODQ4,442,PR 430 + Generator Instances + Monster Health fix,11369233,LtRipley36706,closed,0,,,,,2,2017-07-01T23:28:34Z,2018-02-10T19:56:29Z,2017-07-07T14:39:46Z,MEMBER,,0,ACEmulator/ACE/pulls/442,"PR ready for merge consideration...

This PR requires ACE-World v0.1.4 to work as expected.

* Rolled in PR #430 from @Lidefeath as starting base. 
* Added generator links table to WorldBase.
* Made changes to GuidManger and ObjectGuid in an effort to avoid collisions with guids already present in ACE-World. Does not persist or track, resets each server start.
* Above changes made IsCreature function, and smite works for at least the Sparring Golems found in the Academy, does not seem to work for Drudges in Holtburg.
* Speaking of Drudges, there is a drudge invasion south and west of Holtburg.
* Several changes to 06-06-30-2017-generator-chains-testdata.sql found in Database/Updates/World to set up for generator instances and show examples of them.
* Changed the way generators are classified to make use of some AceObject properties.
* Slightly adjusted debug output on ID panel.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/442/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240067801,MDExOlB1bGxSZXF1ZXN0MTI4NTU0NDk3,443,Fix for broken ankle syndrome.   Autonomous position flag was reversed.,25460553,ogmage78,closed,0,,,,,0,2017-07-03T05:02:05Z,2017-07-03T15:35:11Z,2017-07-03T05:12:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/443,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/443/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240276622,MDExOlB1bGxSZXF1ZXN0MTI4NzAyMjY1,444,Fixed issue with some old defaults overriding player properties,26606778,OptimShi,closed,0,,,,,0,2017-07-03T22:42:54Z,2017-07-10T16:43:26Z,2017-07-04T15:43:36Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/444,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/444/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240291215,MDExOlB1bGxSZXF1ZXN0MTI4NzEyMTE0,445,Object saving,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-07-04T01:36:27Z,2017-07-07T14:47:25Z,2017-07-07T14:47:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/445,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/445/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240304573,MDExOlB1bGxSZXF1ZXN0MTI4NzIwOTA4,446,Movement Speeds emulate properly,5246554,ddevec,closed,0,,,,,0,2017-07-04T03:48:35Z,2017-07-04T15:49:22Z,2017-07-04T15:49:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/446,"Log in a second character, and watch them run around.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/446/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240468902,MDExOlB1bGxSZXF1ZXN0MTI4ODM4NDAz,447,Fix Concurrency Issues and move items from admin to debug,25460553,ogmage78,closed,0,,,,,0,2017-07-04T17:01:38Z,2017-07-15T12:44:31Z,2017-07-06T17:20:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/447,Moved items out of admin that were not part of turbine admin functions over to debug commands.   Added actions to action chains for concurrency safety. ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/447/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240497866,MDExOlB1bGxSZXF1ZXN0MTI4ODU3MjI1,448,Barber,26606778,OptimShi,closed,0,,,,,2,2017-07-04T21:08:36Z,2017-07-10T16:43:46Z,2017-07-07T23:08:51Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/448,"Added ""@barbershop"" debug command and corresponding functionality to load the interface, and save and apply settings.
Changed some CharGen types that were ushort to uints. (They were short for legacy reasons no longer needed)

Not sure if the HandleActionFinishBarber() function is the ""correct"" method, so please feel free to point out what I may not be doing the ""proper way"".","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/448/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
240814991,MDExOlB1bGxSZXF1ZXN0MTI5MDgzNjE2,449,Skills,26606778,OptimShi,closed,0,,,,,0,2017-07-06T00:52:44Z,2017-07-10T16:43:43Z,2017-07-06T17:23:15Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/449,"Fixed an issue with skills not being set properly at character creation (no available credits to spend!)
Applied the +10 bonus to specialized skills","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/449/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241088595,MDExOlB1bGxSZXF1ZXN0MTI5MjgzMjI2,450,Modified @tele command to allow comma in coordinate pair,26606778,OptimShi,closed,0,,,,,0,2017-07-06T21:16:50Z,2017-07-10T16:43:48Z,2017-07-07T05:27:04Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/450,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/450/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241115167,MDExOlB1bGxSZXF1ZXN0MTI5MzAyMDgy,451,Wastin' away again in Splitsville ,25460553,ogmage78,closed,0,,,,,2,2017-07-06T23:29:06Z,2017-07-10T11:58:05Z,2017-07-07T23:11:49Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/451,"* Initial work on splitting a stackable item.   This is working and in an action chain.   Right now, it is only working for items in your possession.   I need to extend it to work with items in chests and off the ground.
* There is some new type of sequence that we need to research and implement.   I put a big todo in the code.
* I made some posts about getting guid manager going.   We are at a point where we need it.   I modified some of the ranges to reflect the current allocations .   This makes really poor use of our sequence space but resolution is TBD.
* I added in the method that @ddevec  wrote for player that we can propagate pattern for the other ranges.

* TODO - find out about sequence used in split message. Next implement stack which is the complement function from split.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/451/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241137628,MDExOlB1bGxSZXF1ZXN0MTI5MzE2NjE4,452,Character list will automatically select your last played character.,26606778,OptimShi,closed,0,,,,,1,2017-07-07T02:13:14Z,2017-07-10T16:43:47Z,2017-07-07T05:29:59Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/452,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/452/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241291387,MDU6SXNzdWUyNDEyOTEzODc=,453,Sending an unknown protocol to ACE causes a crash,10137,ghost,closed,0,,,,,0,2017-07-07T15:02:10Z,2018-02-10T04:55:31Z,2018-02-10T04:55:31Z,NONE,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [x] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
Send an unknown protocol to ACE, such as a SIP message

### The log given by the failure.
![clipboard01](https://user-images.githubusercontent.com/22699181/27963595-6b568442-62ea-11e7-8eaf-3d2322d9667e.jpg)

### Desired functionality.
ACE should disregard protocol messages that don't pertain to it.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/453/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
241339007,MDExOlB1bGxSZXF1ZXN0MTI5NDU4Mjkx,454,Debug Mode Assessment Panel Output,11369233,LtRipley36706,closed,0,,,,,0,2017-07-07T18:08:34Z,2017-07-23T02:31:33Z,2017-07-10T17:58:37Z,MEMBER,,0,ACEmulator/ACE/pulls/454,"Changed the way the assessment panel displays debug info once again, going for a catch all method which should be useful to developers/content contributors alike.

Ready for review/merge.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/454/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241430508,MDExOlB1bGxSZXF1ZXN0MTI5NTE5Mzcz,455,Fixed error on guid initialization if there are no players in sharddb.,5246554,ddevec,closed,0,,,,,0,2017-07-08T06:32:58Z,2017-07-08T06:35:02Z,2017-07-08T06:35:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/455,"Problem with pulls today, simple bugfix.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/455/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241459677,MDExOlB1bGxSZXF1ZXN0MTI5NTMyMDY2,456,Motion State Flags,25460553,ogmage78,closed,0,,,,,0,2017-07-08T15:20:06Z,2017-07-15T12:44:37Z,2017-07-10T18:01:29Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/456,* Fixed issue with MotionStateFlag - setting now by the existence of data like we do with all other flags.   This prevents data / flag mismatch,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/456/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241464092,MDExOlB1bGxSZXF1ZXN0MTI5NTM0MjI4,457,SQL Rebase  - 07082017,11369233,LtRipley36706,closed,0,,,,,0,2017-07-08T16:30:38Z,2017-07-23T02:31:24Z,2017-07-10T18:04:03Z,MEMBER,,0,ACEmulator/ACE/pulls/457,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/457/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241540224,MDExOlB1bGxSZXF1ZXN0MTI5NTcxNzE4,458,Guidmanager fix,5246554,ddevec,closed,0,,,,,0,2017-07-09T17:37:05Z,2017-07-10T18:11:30Z,2017-07-10T18:11:30Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/458,Allows Guids to be properly initialized and safely allocated from the GuidManager.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/458/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241546130,MDExOlB1bGxSZXF1ZXN0MTI5NTc0MjAx,459,Stopped active polling for SerializedShardDatabase requests.,5246554,ddevec,closed,0,,,,,0,2017-07-09T18:58:30Z,2017-07-11T00:49:46Z,2017-07-11T00:49:46Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/459,Changed SerializedShardDatabase to use BlockingCollection to stop polling of database requests (previously our server consumed a CPU core when idle it no longer does).,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/459/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241579498,MDExOlB1bGxSZXF1ZXN0MTI5NTg4OTE1,460,Character Delete,11369233,LtRipley36706,closed,0,,,,,0,2017-07-10T01:56:35Z,2017-07-23T02:31:25Z,2017-07-10T18:21:59Z,MEMBER,,0,ACEmulator/ACE/pulls/460,"Changed the way deleting a character works. Instead of having the SQL server poll, the act of connecting to the server checks the DeleteTime and then marks actual deletion if the character is past expiration..

So if character's delete timer is up, the next time you log in, the character is deleted before sending you received your character list, in effect, deleting it.

We don't actively resend the list when someone idles at the character list screen so as of current you could still restore a character that is past the restore window AND marked deleted.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/460/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241810897,MDExOlB1bGxSZXF1ZXN0MTI5NzQ4NTk1,461,Quick Fixes,11369233,LtRipley36706,closed,0,,,,,0,2017-07-10T18:54:11Z,2017-07-23T02:31:26Z,2017-07-10T18:54:32Z,MEMBER,,0,ACEmulator/ACE/pulls/461,"Missing NewLines due to merge
Updated WeenieMax to reflect ACE-World","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/461/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241886589,MDExOlB1bGxSZXF1ZXN0MTI5Nzk4NzE1,462,Update to fix animation.,25460553,ogmage78,closed,0,,,,,0,2017-07-11T00:05:03Z,2017-07-15T12:44:23Z,2017-07-11T00:52:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/462,"Found bug - it was introduced by me as part of the fix limping.   This fix should make it all work.   I have tested running, animations and combat stances.   Looks to be working correctly.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/462/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
241937011,MDExOlB1bGxSZXF1ZXN0MTI5ODMwNjk0,463,New Character Defaults + misc changes,11369233,LtRipley36706,closed,0,,,,,0,2017-07-11T06:14:56Z,2017-07-23T02:31:27Z,2017-07-12T04:42:26Z,MEMBER,,0,ACEmulator/ACE/pulls/463,"* Removed events from SQL scripts. No longer need them in current implementation.
* Renamed ObjectType to ItemType.
* Added Sequences for Health/Stamina/Mana for proper updating later.
* Set slew of initial values for new characters.
* Added PlayerKillerStatus, CreatureType, and WeenieType enums.

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/463/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
242279369,MDExOlB1bGxSZXF1ZXN0MTMwMDY4MDky,464,Enum Reshuffle,11369233,LtRipley36706,closed,0,,,,,0,2017-07-12T07:03:04Z,2017-07-23T02:31:28Z,2017-07-13T04:03:25Z,MEMBER,,0,ACEmulator/ACE/pulls/464,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/464/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
242613909,MDExOlB1bGxSZXF1ZXN0MTMwMzA2Mzg2,465,Restructuring AceObject and other objects,11369233,LtRipley36706,closed,0,,,,,6,2017-07-13T07:48:02Z,2018-02-10T19:56:28Z,2017-07-19T06:01:05Z,MEMBER,,0,ACEmulator/ACE/pulls/465,"Please review changes to objects and note any concerns with continuing down this road...

The idea is to clean up and strip down AceObject to let the property get/set functions handle most everything not DbField and start to move, keep stuff in their appropriate object classes.

I'd like to move the ICreatureStats out as well but not totally sure how to get that out and in to AceCharacter, as not every worldobject or aceobject needs those ability fields","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/465/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
243144060,MDExOlB1bGxSZXF1ZXN0MTMwNjk4MTQz,466,Fight Club - Initial working code - ready for review and merge. ,25460553,ogmage78,closed,0,,,,,0,2017-07-15T01:19:52Z,2017-07-26T22:15:07Z,2017-07-19T06:03:38Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/466,"* Initial work on combat mode.   System now will move into and out of the correct combat mode depending on what items you have equipped.
* TODO: There are some edge cases I still need to implement and additional testing.   I would like to get this in so that I do not run into huge merge issues later on.
* Testing - you can log in - run @weapons after log in.   This will get you various weapons based on weapon type.   You can go into and out of combat mode
* Melee, missile - both bow and xbow, thrown, sword, UA, two handed as well as dual wield.    I also implemented if you remove your weapon while in combat mode, 
* you will drop into unarmed.   If you equip an item and you are not in peace mode, you will assume the correct combat mode.   There may be some tweaking needed 
* for changing combat mode in combat mode - I think it did some slower animation - but the basics are in and I can tweak the sequence once I talk to players or If
* I can find a pcap with that behavior.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/466/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
243256590,MDExOlB1bGxSZXF1ZXN0MTMwNzYwNjUy,467,Added npcLooksLikeObject option in appraisal response,26606778,OptimShi,closed,0,,,,,0,2017-07-16T18:19:37Z,2017-09-01T05:13:49Z,2017-07-30T05:19:38Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/467,"* Added npcLooksLikeObject option in appraisal response (Note that no objects in ACE_World are currently set with this bool property)
* Replaced some ""unknown"" bitfields with proper variable names in PlayerDescription.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/467/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244281337,MDExOlB1bGxSZXF1ZXN0MTMxNDk1MDQy,468,WIP: WorldObject Reorganization + more,11369233,LtRipley36706,closed,0,,,,,1,2017-07-20T08:21:35Z,2018-02-10T19:56:24Z,2017-07-22T17:19:10Z,MEMBER,,0,ACEmulator/ACE/pulls/468,"* Reorganized folder structure for WorldObject and sub objects.
* Move chat to be handled by Player.
* Set up local chat to be landblock ranged.
* Wired up emotes and soul emotes, also landblock ranged.
* Moved ID functionality to be handled within WorldObject.
* Added PK Altar object.

@OptimShi There's some issues with the SetupModel and PK Altar objects. Would like your input on what is going on.. I swapped in a lifestone ID to let me progress through the code to test further but if you bring the real id back in, you'll find it crashes on reading.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/468/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244396915,MDExOlB1bGxSZXF1ZXN0MTMxNTc4NzUy,469,Fixes to raising attributes,26508216,Lidefeath,closed,0,,,,,0,2017-07-20T15:08:23Z,2018-05-31T12:21:06Z,2017-07-20T19:01:26Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/469,"Primary and secondary attributes can be raised correctly with xp again. Existing characters will have coord and quick exchanged as the enums for those abilities in the server are now aligned with the client.
Vital ticking wasn't touched yet, so it only starts during Player.Load","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/469/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244724119,MDExOlB1bGxSZXF1ZXN0MTMxODE0NTI5,470,Fix for SetupModel Crash,11369233,LtRipley36706,closed,0,,,,,1,2017-07-21T16:44:37Z,2017-07-23T02:31:14Z,2017-07-21T17:29:48Z,MEMBER,,0,ACEmulator/ACE/pulls/470,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/470/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244728939,MDExOlB1bGxSZXF1ZXN0MTMxODE3OTc5,471,"Broadcast Local Chat, Emotes and Soul Emotes",11369233,LtRipley36706,closed,0,,,,,0,2017-07-21T17:04:42Z,2017-07-23T02:31:13Z,2017-07-22T06:02:12Z,MEMBER,,0,ACEmulator/ACE/pulls/471,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/471/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244731111,MDExOlB1bGxSZXF1ZXN0MTMxODE5NjE4,472,Changed Workmanship,11369233,LtRipley36706,closed,0,,,,,4,2017-07-21T17:14:56Z,2017-07-23T02:31:11Z,2017-07-22T06:04:48Z,MEMBER,,0,ACEmulator/ACE/pulls/472,Changed the way Workmanship is set to not always be 0.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/472/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244734154,MDExOlB1bGxSZXF1ZXN0MTMxODIxODg5,473,Moved Identify to WorldObject,11369233,LtRipley36706,closed,0,,,,,1,2017-07-21T17:28:58Z,2017-07-23T02:31:10Z,2017-07-22T17:19:22Z,MEMBER,,0,ACEmulator/ACE/pulls/473,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/473/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
244889108,MDExOlB1bGxSZXF1ZXN0MTMxOTIyMjQ2,474,Flags and Bools,11369233,LtRipley36706,closed,0,,,,,5,2017-07-23T05:08:27Z,2018-02-10T19:56:23Z,2017-07-25T06:40:33Z,MEMBER,,0,ACEmulator/ACE/pulls/474,Setting up more bools intended to set flags for ObjectDescriptionFlag and PhysicsState,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/474/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
245257806,MDExOlB1bGxSZXF1ZXN0MTMyMTc2ODc0,475,Added the ability to learn spells / unlearn spells.,25460553,ogmage78,closed,0,,,,,1,2017-07-25T01:11:55Z,2017-07-26T22:14:53Z,2017-07-26T21:25:47Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/475,"* Refactored debug command learn spell.
* Made spells persist to the database.
* Added ability to delete spell from spell book and send that persist to the database on character save.
* Fixed minor bug in placement - this fixes items not dropping to the ground in the correct orientation.   
  This may not be a final fix, but it is better than a hard coded 0x65
* Fixed minor bug in burden - again this may not be the final fix, but it is accurate and better than the bug 
  that currently exists.
* TODO: Put in the ability to use scrolls to learn spells.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/475/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
245625646,MDExOlB1bGxSZXF1ZXN0MTMyNDQ0MzIy,476,WorldObject reclassification via WeenieType,11369233,LtRipley36706,closed,0,,,,,2,2017-07-26T07:05:21Z,2018-02-10T19:56:22Z,2017-07-29T16:58:20Z,MEMBER,,0,ACEmulator/ACE/pulls/476,"- NOTE: The following changes require ACE-World database v0.1.6 or greater...
- No longer setting WeenieHeaderFlag.Value if Value = 0.
- DebugObject, CollidableObject and UsableObject are removed.
- Moved OnUse/OnCollide to WorldObject virtuals for overriding.
- Added WeenieType to AceObject/WorldObject for weenie classification.
- Added Generic object which the default object for weenies.
- Reworked GenericObjectFactory to use WorldObject.GetObjectFromWeenieType.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/476/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
245844903,MDExOlB1bGxSZXF1ZXN0MTMyNjA2ODQw,477,Query Item Mana,26508216,Lidefeath,closed,0,,,,,0,2017-07-26T20:29:55Z,2018-05-31T12:21:16Z,2017-07-26T23:06:26Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/477,Add the GameAction for QueryItemMana and the corresponding GameEvent response.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/477/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
245934759,MDExOlB1bGxSZXF1ZXN0MTMyNjcxNzI0,478,Minor tweak to QueryItemMana,11369233,LtRipley36706,closed,0,,,,,0,2017-07-27T06:06:55Z,2017-07-27T06:07:54Z,2017-07-27T06:07:49Z,MEMBER,,0,ACEmulator/ACE/pulls/478,"`// TODO: Why does the client send a QueryItemMana action with a queryid of 0`

Looks like the client did this all the time, no reason seems apparent in retail pcaps, so killing this out for now","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/478/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
246498291,MDExOlB1bGxSZXF1ZXN0MTMzMDc5ODAy,479,Nothing could be finer than to be in perfect alignment in the morning .....,25460553,ogmage78,closed,0,,,,,0,2017-07-29T04:29:33Z,2017-07-29T04:48:55Z,2017-07-29T04:40:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/479,"Spent 5 or 6 hours tracking down an align bug in create object - Universal Motion section.   Damn it Jim, I am a high level programmer not a down in the bits and bytes weenie.... :)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/479/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
246501593,MDExOlB1bGxSZXF1ZXN0MTMzMDgxNTU0,480,Network fixes with inital Ack delay,12808515,Zegeger,closed,0,,,,,0,2017-07-29T05:46:23Z,2017-07-29T06:03:50Z,2017-07-29T06:03:50Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/480,Set Ack delay initially to be 2 seconds.  Having the acks sent too early seems to impact connection reliability.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/480/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
246603251,MDExOlB1bGxSZXF1ZXN0MTMzMTM5Njg1,481,Expecto Patronum - Spell bar managment,25460553,ogmage78,closed,0,,,,,1,2017-07-30T19:19:49Z,2017-08-15T01:20:50Z,2017-07-31T15:19:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/481,"### 2017-07-30
[Og II]
* Added spell bar management and persistence.   This continues the work for learning and persisting spells.   
* Cleaned up some of the duplication of enumerations in Game Event Player Description
* Added some debug code around universal motion.
* Added some debug asserts in Player Description 
* To test - use @learnspell to get some spells in your spell book if you do not have any.   They will persist with your character. 
* You can also unlearn them and they will be removed.
* Now, drag your spells into any configuration in your spell bars you like.   You can add them, remove them or reorder them.
* They will be saved on our periodic save, or when you log out or you can force a save with the debug command @save-now.
* Added table to allow for spell bar configuration persistence.
* Cleaned up Enumerations - Game Action Types
* That's all for this PR.   ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/481/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
246659317,MDExOlB1bGxSZXF1ZXN0MTMzMTc1MzEx,482,Add Cow object,11369233,LtRipley36706,closed,0,,,,,4,2017-07-31T06:44:19Z,2018-02-10T19:56:22Z,2017-08-06T21:27:04Z,MEMBER,,0,ACEmulator/ACE/pulls/482,"* NOTE: The following changes require ACE-World database v0.1.8 or newer...
* Added NpcLooksLikeObject check for Creature assessment profile fix provided by @OptimShi.
* Moved Default do nothing UseDone to WorldObject and removed it from GenericObject.
* Added Cow weenie object.
* Added Cow, Creature, and Container to the WorldObjectFactory.
* Say Hi to the cow in Holtburg.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/482/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
246938459,MDExOlB1bGxSZXF1ZXN0MTMzMzc2Njkx,483,Added check to ensure a player can't spend more attribute credits than they should at character creation.,26606778,OptimShi,closed,0,,,,,0,2017-08-01T02:33:50Z,2017-09-01T05:13:48Z,2017-08-02T18:26:22Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/483,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/483/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
247238263,MDExOlB1bGxSZXF1ZXN0MTMzNTk5MDM5,484,Inventory - Ready for Merge,25460553,ogmage78,closed,0,,,,,3,2017-08-02T00:15:42Z,2017-08-15T01:20:42Z,2017-08-14T12:55:36Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/484,"### 2017-08-01
[Og II]
##  Refactored again on Mogwai's feedback 

This is getting so large, I need to stop here - this is a good spot - adds significant functionality but with a few known bugs.   

* Inventory will save with the container and load again in the correct positions.   
* Character Description Event is now wired up for inventory.
* removed containers copy of aceObject Inventory - just make the list accessible.
* Updated Clone so it you pass a new guid, it resets all the associated child tables.
* implemented placement IntProperty 65 used to track slot in Container
* Created supporting methods to manage pack order
* Enhanced the debug log message for DBDEBUG 
* Small temp fix to stutter when attempting to shift walk or shift jump.   We still need to really understand autonomous
* Created new view  vw_ace_inventory_object to expose ability to pull by container.  
* general clean up comments and whitespace 
* Inventory loading - working
* TODO.   
* 1 Add in capacity checks
* 2 bug still in picking up items off the ground and saving to database. 
* 3 bug with reloaded items saved in a secondary side pack.

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/484/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
247866930,MDExOlB1bGxSZXF1ZXN0MTM0MDY1NjU2,485,Books - For Review Only,26606778,OptimShi,closed,0,,,,,0,2017-08-03T23:53:21Z,2017-08-09T00:16:07Z,2017-08-09T00:16:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/485,"Read Only book/page/note/etc support.

Requires the Shard/World Database update scripts and ACE-World 0.1.9 or later for DB data.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/485/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
248280385,MDExOlB1bGxSZXF1ZXN0MTM0MzQ1NTk0,486,Add Scroll Weenie,11369233,LtRipley36706,closed,0,,,,,0,2017-08-06T23:53:01Z,2018-02-10T19:56:21Z,2017-08-10T14:18:58Z,MEMBER,,0,ACEmulator/ACE/pulls/486,"* Added scrolls to WorldObjectFactory
* Spawn any scroll in the database to test
* Skill check is active for any scroll level 2-6
* Removed SpellObjectFactory and cleaned up some things relating to it until it can be reintroduced or refactored","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/486/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
248315823,MDExOlB1bGxSZXF1ZXN0MTM0MzY4MTky,487,Wired up World Broadcast Commands,11369233,LtRipley36706,closed,0,,,,,1,2017-08-07T06:10:37Z,2018-02-10T19:56:21Z,2017-08-11T11:17:18Z,MEMBER,,0,ACEmulator/ACE/pulls/487,"* Wired up World Broadcast commands.
* Cleaned up a few other commands that were not needed or found in other categories.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/487/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
248882678,MDExOlB1bGxSZXF1ZXN0MTM0Nzg1OTUy,488,Books,26606778,OptimShi,closed,0,,,,,1,2017-08-09T00:16:28Z,2017-09-01T05:13:46Z,2017-08-10T14:28:54Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/488,"Read Only book/page/note/etc support.

Requires the Shard/World Database update scripts and ACE-World 0.1.9 or later for DB data.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/488/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
249240981,MDExOlB1bGxSZXF1ZXN0MTM1MDQ2OTA0,489,Added MotionTable parsing and related classes,26606778,OptimShi,closed,0,,,,,0,2017-08-10T05:59:17Z,2017-09-01T05:13:45Z,2017-08-10T14:33:27Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/489,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/489/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
249430547,MDExOlB1bGxSZXF1ZXN0MTM1MTg3NjE0,490,Minor changes to Book weenie,11369233,LtRipley36706,closed,0,,,,,4,2017-08-10T18:08:11Z,2018-02-10T19:56:21Z,2017-08-11T18:43:53Z,MEMBER,,0,ACEmulator/ACE/pulls/490,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/490/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
249496237,MDExOlB1bGxSZXF1ZXN0MTM1MjM3NDU2,491,Spell Formula,26606778,OptimShi,closed,0,,,,,0,2017-08-10T22:38:12Z,2017-08-10T23:31:50Z,2017-08-10T23:31:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/491,"Added MotionTable note to changelog (accidentally omitted in corresponding PR)
Added GetSpellFormula() function to SpellTable. Will return component id's based on players account name for any given spell.
Fixed some logic issues in the SpellComponentsTable","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/491/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
249517913,MDExOlB1bGxSZXF1ZXN0MTM1MjUzMzEy,492,Refactor several Weenies,11369233,LtRipley36706,closed,0,,,,,0,2017-08-11T01:19:37Z,2018-02-10T19:56:20Z,2017-08-11T19:53:30Z,MEMBER,,0,ACEmulator/ACE/pulls/492,"* Made changes to Cow, Door, Lifestone, Portal weenies.
* Added plethora of timestamps for eventual use in WorldObject. 
  (Some of these likely will/can be move to more appropriate places after more weenie objects are built out.)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/492/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
249519682,MDExOlB1bGxSZXF1ZXN0MTM1MjU0NTIy,493,Spell Formula,26606778,OptimShi,closed,0,,,,,1,2017-08-11T01:37:31Z,2017-09-01T05:13:34Z,2017-08-14T13:01:39Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/493,"Added MotionTable parsing not to changelog (was left out of previous PR)
Added GetSpellFormula() function to SpellTable. Will return component id's based on players account name for any given spell.
Fixed some logic issues in the SpellComponentsTable
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/493/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
250468293,MDExOlB1bGxSZXF1ZXN0MTM1OTE0MDI1,494,Fixed book properties not cloning properly.,26606778,OptimShi,closed,0,,,,,0,2017-08-15T23:37:28Z,2017-09-01T05:13:33Z,2017-08-16T03:55:23Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/494,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/494/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
250506086,MDExOlB1bGxSZXF1ZXN0MTM1OTM3NTQx,495,Added Animation parsing from the client_portal.dat and all relevant hooks and properties.,26606778,OptimShi,closed,0,,,,,2,2017-08-16T04:11:15Z,2017-09-01T05:13:32Z,2017-08-18T12:22:45Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/495,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/495/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
250743171,MDExOlB1bGxSZXF1ZXN0MTM2MTEwMTI1,496,Fix multifragment packetization logic,12808515,Zegeger,closed,0,,,,,1,2017-08-16T20:03:25Z,2017-08-23T04:23:14Z,2017-08-23T04:23:14Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/496,"* Rewrote packetizer code to fix incorrect multi-fragment messages (basically we shouldn't send optional headers when a single fragment fills the full packet)  
* In general this made the packetizer much cleaner and more organized  
* In the process I added support for preemptive tail sending.  Essentially for multifragment packets, the last fragment will likely be much smaller then the full packet size, so it could fit in an earlier message among other fragments.  We see this can occur in production network traces (eg the last index arrives as the first fragment of the message). Previously we did not do this, but now we can.  
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/496/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
251505988,MDExOlB1bGxSZXF1ZXN0MTM2NjUzMzE5,497,"Some naive, simple fellowship code. Creating and leaving fellow works.",3664603,rtmruczek,closed,0,,,,,5,2017-08-20T18:31:26Z,2017-08-26T20:43:51Z,2017-08-26T20:43:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/497,I don't think Fellowship.cs is in the right place. Wasn't sure where to put it. Any and all feedback is great.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/497/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
252407985,MDExOlB1bGxSZXF1ZXN0MTM3MzExODYy,498,Updated Readme,26606778,OptimShi,closed,0,,,,,0,2017-08-23T20:35:12Z,2017-09-01T05:13:29Z,2017-08-23T21:14:33Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/498,"Changed aclogview link to ACEmulator fork.
Added link to Immortus' installation process.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/498/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
253194772,MDExOlB1bGxSZXF1ZXN0MTM3ODUxMTYz,499,Support for ACE-World 0.2.0+,11369233,LtRipley36706,closed,0,,,,,1,2017-08-27T22:33:49Z,2018-02-10T19:56:19Z,2017-09-02T15:33:50Z,MEMBER,,0,ACEmulator/ACE/pulls/499,"Download and import [ACE-World v0.2.0](https://github.com/ACEmulator/ACE-World/releases/tag/v0.2.0) prior to starting up ACE.
This shifts the world database away from ace_object instances to a more easily managed instance generated by weenies system.

Each time the server is started and when the landblock is first loaded it will generate new instances based on the weenies in the database. 

This new structure reduces database size and import times as well as makes it significantly easier to correct the flaws introduced by pulling weenies out of PCAP data.

This does not change the structure for objects stored in the shard database. Those objects should always remain copies of weenies saved in ace_object as a unique, complete instance.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/499/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
254753254,MDExOlB1bGxSZXF1ZXN0MTM4OTc0ODIy,500,Region & Scene,26606778,OptimShi,closed,0,,,,,0,2017-09-01T21:15:10Z,2018-03-27T03:35:03Z,2017-09-02T15:36:24Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/500,Added Region and Scene parsing from the client_portal.dat,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/500/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
254908674,MDExOlB1bGxSZXF1ZXN0MTM5MDY2MzE2,501,Quick fix for proper GUID assignment on objects from Generators,11369233,LtRipley36706,closed,0,,,,,0,2017-09-03T23:42:22Z,2018-02-10T19:56:15Z,2017-09-03T23:45:35Z,MEMBER,,0,ACEmulator/ACE/pulls/501,This fixes a crash bug associated with picking up objects generated by generators. GUID change wasn't propagating to properties.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/501/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
254931338,MDExOlB1bGxSZXF1ZXN0MTM5MDc5OTAx,502,Portal.dat Parsing Additions,26606778,OptimShi,closed,0,,,,,0,2017-09-04T04:10:21Z,2017-09-04T21:52:18Z,2017-09-04T14:04:14Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/502,"* Added Wave (0x0A...) parsing from the client_portal.dat and a ""wave-export"" console function to save as a playable .wav file.
* Added GfxObjDegradeInfo (0x11..) parsing from the client_portal.dat 
* Added CombatManeuverTable (0x30...) parsing from the client_portal.dat 
* Added ParticleEmitterInfo (0x32...) parsing from the client_portal.dat 
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/502/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
255456442,MDExOlB1bGxSZXF1ZXN0MTM5NDU1OTIw,503,More Dat Parsing Updates,26606778,OptimShi,closed,0,,,,,0,2017-09-06T01:47:33Z,2017-09-06T21:29:51Z,2017-09-06T14:16:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/503,"* Added Palette (0x04...) parsing from the client_portal.dat.
* Added PhysicsScript (0x33...) parsing from the client_portal.dat.
* Added PhysicsScriptTable (0x34...) parsing from the client_portal.dat.
* Added ContractTable (0x0E00001D) parsing from the client_portal.dat.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/503/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
256445697,MDExOlB1bGxSZXF1ZXN0MTQwMTczNTQ2,504,Added verbiage to the readme stating the projects educational purpose.,25460553,ogmage78,closed,0,,,,,0,2017-09-09T15:23:32Z,2017-09-15T18:19:16Z,2017-09-09T15:28:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/504,Based on discord pin yesterday - I thought this would be a good add to the readme.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/504/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
257494730,MDExOlB1bGxSZXF1ZXN0MTQwOTEwMjY2,505,Weenie editor & basic recipes,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-09-13T19:30:17Z,2017-09-14T01:32:53Z,2017-09-14T01:32:53Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/505,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/505/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
257531933,MDExOlB1bGxSZXF1ZXN0MTQwOTM4MjYz,506,Stubs and enums for crafting dialogs,25460553,ogmage78,closed,0,,,,,1,2017-09-13T21:49:22Z,2017-09-15T18:19:08Z,2017-09-14T01:24:15Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/506,"Added one new game action, and two new event message handlers - as well as the associated enums.   This work is around crafting dialogs.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/506/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
257931832,MDExOlB1bGxSZXF1ZXN0MTQxMjMxNjI3,507,Yet More client_portal.dat Parsing Updates,26606778,OptimShi,closed,0,,,,,0,2017-09-15T05:33:08Z,2018-03-27T03:34:58Z,2017-09-15T15:22:52Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/507,"* Added GfxObject (0x01...) parsing from the client_portal.dat.
* Added Surface (0x08...) parsing from the client_portal.dat.
* Added Environment (0x0D...) parsing from the client_portal.dat.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/507/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
258078737,MDExOlB1bGxSZXF1ZXN0MTQxMzM4NjYx,508,Healing kits!,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-09-15T15:27:34Z,2017-09-16T15:49:00Z,2017-09-16T15:49:00Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/508,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/508/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
258540255,MDExOlB1bGxSZXF1ZXN0MTQxNjQ2Mjk0,509,items from failed crafting,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-09-18T16:22:43Z,2017-09-19T16:25:46Z,2017-09-19T16:25:46Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/509,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/509/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
258617198,MDExOlB1bGxSZXF1ZXN0MTQxNzAxMjEz,510,Starter gear,25351661,Mogwai-TheFurry,closed,0,,,,,1,2017-09-18T20:51:26Z,2017-09-19T18:09:37Z,2017-09-19T18:09:37Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/510,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/510/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
258986168,MDExOlB1bGxSZXF1ZXN0MTQxOTczMjQ3,511,Don't bend the knee - Wielded items persisted  and a few old bugs squashed.   READY TO MERGE,25460553,ogmage78,closed,0,,,,,3,2017-09-19T22:40:02Z,2017-09-30T06:25:34Z,2017-09-29T23:26:08Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/511,"LATE UPDATE - all known bugs squashed via a workaround until we can enhance the ORM to deal with our inventory issue.
**Update 9/27/2017 PM  - I have tried everything - I must be missing something simple.   I it looks like it should work - but it still crashes on second save after moves. I really need some help here - I have looked at this so much I am going to just trash on it - maybe a fresh set of eyes?  
Steps to reproduce.   For simplicity's sake, I have a slimmed down set of test items, 1 wand and 1 pack. Make sure you start out with no items as it will make debugging much easier:

1.  login clean - ie neckid
2.   "" at sign weapons""
3.   "" at sign save-now""
4.    You can use the sql attached below to see what is going on in the db.   You will need to rename, it will not take sql attachments
5.  now move the wand to equipped and @save-now
6.  check db the db is not updated correctly at this point.   If you hit save again it works however, it is fubar from there.**  

[containerwieldedview.txt](https://github.com/ACEmulator/ACE/files/1338833/containerwieldedview.txt)


UPDATE 9/27/2017 - Fixed all of Morwai's feedback.   Bug progress - it looks like the duplicate key issue on save is that on a container to container move, the item still shows in both inventory lists.   Not sure how that is happening.   Still debugging.

UPDATED: 9/26/2017
* Implemented persisting of wielded items.   
* Changed inventory to manage a list of world objects instead of ace objects.   This was needed for sequence issues.
* fixed combat animation that had been broken for a while due to prior refactoring.
* fixed moving inventory from container to container with persistances which was broken due to prior refactoring.
* implemented the response message to send object description.
* cleaned up so code, aligned enums.
* TODO.   I have a dirty flag bug that causes issues when you do container to container moves and save.   
* I put in a hack to make this work, see around line 767 in Shard database. - it has changed a lot and is probably holding others up.   
* This seems to work in all cases.   I have spent hours on the dirty flag bug and this was the only way I could make it work.   Once someone @Mogwai-TheFurry  :) has time to look at this, we can take out the hack.   

BTW - since no one gets my humor, this is not about the NFL it is about it has taken me a month to get this close and I refused to ""bend the knee"" that it was over my head to fix.  ;)
![maxresdefault 1](https://user-images.githubusercontent.com/25460553/30835034-b7aa18e8-a21b-11e7-9de5-3b7afd327d15.jpg)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/511/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
259221254,MDExOlB1bGxSZXF1ZXN0MTQyMTQyNDM1,512,Added minimum UseRadius for Doors,11369233,LtRipley36706,closed,0,,,,,0,2017-09-20T16:14:26Z,2018-02-10T19:56:15Z,2017-09-20T18:14:57Z,MEMBER,,0,ACEmulator/ACE/pulls/512,Added a minimum UseRadius to Doors. This prevents the radius being so small as to require you to be inside the door to open/close it.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/512/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
261044865,MDExOlB1bGxSZXF1ZXN0MTQzNDQ1NjEx,513,Play time - Needs Work - For Comments,25387933,Forbiddenz,closed,0,,,,,1,2017-09-27T16:47:48Z,2017-10-12T15:37:32Z,2017-10-05T14:41:19Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/513,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/513/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
261849613,MDExOlB1bGxSZXF1ZXN0MTQ0MDMxNzMw,514,Enum all the things with attributes - Restrict send to the client based on enum attributes.,25460553,ogmage78,closed,0,,,,,0,2017-09-30T15:06:41Z,2017-10-03T03:53:02Z,2017-10-03T01:58:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/514,"# Ready for Review and Merge

**UPDATE 10/02/2017 - moved to static method per request and used generics to get rid of duplicate code.**

* Added enum attributes for all of our property enums per Mogwai using the data from OptimShi found here
* http://ac.yotesfan.com/ace_object/not_used_enums.php
* Filter out all property types sent to client based on them not being [ServerOnly] attributes.
* NOTE: the big gotcha with this is if we have any of the [ServerOnly] attributes set incorrectly, that data will not get sent to the client
* and if you don't remember that we are filtering by that attribute you will be going what the hell is wrong.   Just an FYI
* There is probably a better way to do this, if so, please let me know.
![image](https://user-images.githubusercontent.com/25460553/31046918-08124a7c-a5c7-11e7-92ff-b76e730875b4.png)

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/514/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
261871279,MDExOlB1bGxSZXF1ZXN0MTQ0MDQzOTIz,515,Misc Changes,11369233,LtRipley36706,closed,0,,,,,1,2017-09-30T20:49:42Z,2018-02-10T19:56:13Z,2017-10-02T19:52:59Z,MEMBER,,0,ACEmulator/ACE/pulls/515,"* WorldBase SQL merged
* Fix Books saving to Shard database
* README updated
* Add character wielded items upon creation

A note about the items you start with, there are bugs with our layering and model changes so some things do not quite look right. These issues should be addressed sooner rather than later.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/515/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
261950680,MDExOlB1bGxSZXF1ZXN0MTQ0MDkwOTY4,516,Turn right Round - Initial work on content,25460553,ogmage78,closed,0,,,,,0,2017-10-01T22:10:05Z,2017-10-03T03:52:55Z,2017-10-03T02:00:41Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/516,"* Initial work on content interactions.
* Cleaned up the using statements on several files.
* Aligned the enums to = sign
* Fixed bug in universal motion using the TurnToObject
* Moved a method from player to creature.   We need to access that method for the ancestor class

Normally, I would not submit this as a PR yet, but my PR's tend to get big and touch a lot of stuff.   I just put in the very start of this, and cleaned up a few files - and aligned some enums and squashed a bug.   It is functional and moves us forward, so I thought better to review in small functional chunks.   

You have to know 80's MTV to get the picture.... 
![image](https://user-images.githubusercontent.com/25460553/31059626-1813bf1e-a6cb-11e7-935c-694fdc910135.png)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/516/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
262231275,MDExOlB1bGxSZXF1ZXN0MTQ0Mjg1Nzg5,517,Movement Updates,26606778,OptimShi,closed,0,,,,,0,2017-10-02T21:15:25Z,2018-03-27T03:34:57Z,2017-10-03T02:41:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/517,"* Changed MotionCommand and MotionState enums to full uint instead of short and adjusted the movement serializing functions to work with these changes.
* Fixed bug when leaving CombatMode with no ammunition equipped (e.g. melee or magic mode)
* Added ""acecommands"" tip to console start up","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/517/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
262275105,MDExOlB1bGxSZXF1ZXN0MTQ0MzE3Nzgz,518,Overpowered,12262963,immortalbob,closed,0,,,,,1,2017-10-03T01:07:23Z,2017-10-03T01:54:41Z,2017-10-03T01:54:41Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/518,"I think I did this right. Thanks Og!

I identified what Unknown_386 was last night, wanted to get a pr in. :)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/518/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
262276344,MDExOlB1bGxSZXF1ZXN0MTQ0MzE4NjI2,519,Pull Up to head,25336212,derandark,closed,0,,,,,0,2017-10-03T01:16:21Z,2017-10-03T01:18:03Z,2017-10-03T01:18:03Z,NONE,,0,ACEmulator/ACE/pulls/519,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/519/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
262477907,MDExOlB1bGxSZXF1ZXN0MTQ0NDU3MDEz,520,Retreat!   Fix for peace mode from unarmed,25460553,ogmage78,closed,0,,,,,0,2017-10-03T15:40:07Z,2017-10-04T16:47:17Z,2017-10-04T12:28:46Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/520,"""These engines are the fastest in any tanks in the European Theater of Operations, forwards or backwards. You see, man, we like to feel we can get out of trouble, quicker than we got into it.""   Oddball - Kelly's Heroes.

### 2017-10-03
[Og II]
* Added update script to modify defaultCombatStance ace_object_properties_int to match change with @OptimShi changes of 10/02
* Rolled back [ServerOnly] attribute on enums.   I left the mechanism in place and tagged all over 9000 as such.   Our method for determining which of these are server only  this is not correct.   We can add these back when we fully understand which are truly not needed by the client.
![image](https://user-images.githubusercontent.com/25460553/31134257-32520b08-a827-11e7-84ae-353e346e262c.png)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/520/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
262640631,MDExOlB1bGxSZXF1ZXN0MTQ0NTY1NjM2,521,Animation Length,26606778,OptimShi,closed,0,,,,,0,2017-10-04T01:32:38Z,2018-03-27T03:34:54Z,2017-10-04T12:30:53Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/521,Added method to get animation timings out of MotionTable and updated several instances where we were faking it previously.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/521/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
262979060,MDExOlB1bGxSZXF1ZXN0MTQ0ODExNTk3,522,Portals update,10137,ghost,closed,0,,,,,0,2017-10-05T01:26:13Z,2017-10-18T14:07:24Z,2017-10-05T14:42:20Z,NONE,,0,ACEmulator/ACE/pulls/522,"Moved handling of Portals into the HandleOnCollide method and implemented MoveTo for OnUse for Portals.  Currently, OnUse also queues up portaling via a direct call to Portal.HandleOnCollide, which can be removed when collision is implemented.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/522/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
263191015,MDExOlB1bGxSZXF1ZXN0MTQ0OTY1MjEz,523,Vendor updates,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-05T16:36:57Z,2017-10-05T22:56:48Z,2017-10-05T22:56:48Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/523,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/523/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
263290706,MDExOlB1bGxSZXF1ZXN0MTQ1MDM5NTMx,524,Moar Enumz!,12262963,immortalbob,closed,0,,,,,0,2017-10-05T22:51:38Z,2017-10-05T22:56:56Z,2017-10-05T22:56:56Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/524,"Optim and I figured out some more of the unknown enums today, here they are!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/524/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
263334659,MDExOlB1bGxSZXF1ZXN0MTQ1MDcxMTkz,525,Added some chat enums that were found in the client.,19214857,Slushnas,closed,0,,,,,0,2017-10-06T04:42:35Z,2017-10-14T10:44:53Z,2017-10-06T12:05:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/525,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/525/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
263461655,MDExOlB1bGxSZXF1ZXN0MTQ1MTY0NDE4,526,Vendor improvements,25387933,Forbiddenz,closed,0,,,,,0,2017-10-06T14:17:25Z,2017-10-12T15:38:48Z,2017-10-10T18:47:20Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/526,"Simplified some of the vendor code.. little faster less action chains same result.
Fixed bug with purchasing multiple items of the same type with no max stack size.
Fixed Filter / Shop Only Items to support latest World DB changes of destinationTypes","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/526/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
263546446,MDExOlB1bGxSZXF1ZXN0MTQ1MjI3MTM5,527,Moar Enumz Again?,12262963,immortalbob,closed,0,,,,,0,2017-10-06T19:19:46Z,2017-10-09T12:37:15Z,2017-10-09T12:15:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/527,Equipment Set enum list added for future use.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/527/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
263621289,MDExOlB1bGxSZXF1ZXN0MTQ1Mjc5OTI2,528,Keys are key,10137,ghost,closed,0,,,,,0,2017-10-07T06:41:32Z,2017-10-18T14:07:56Z,2017-10-12T13:15:25Z,NONE,,0,ACEmulator/ACE/pulls/528,"An easy location to test is in the Training Academy Central Courtyard.  The first door encountered is locked.  Use @ci 30999, to spawn the Academy Library key.

- Keys will decrement their usages.  Examining the key shows the decreasing number of usages; usage icon overlay works.  Key will be removed from both the Shard DB and the player's inventory on last usage.

- KeyCode  and LockCode are used in the code, but no data is loaded into the DB, yet, resulting in all keys working with all locked door, ie. each key is a AC master key.

TODO:
- Not sure if there should be a sound played when the door re-locks, and if so, what it would be.
- The notification message for attempting to use a key on an open door needs to be corrected.  Enum defined in StatusMessageType1.cs is not correct.
- A notification message appropriate for using a key on an unlocked door that is closed does not appear to exist/defined in StatusMessageType1.cs.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/528/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
264336437,MDExOlB1bGxSZXF1ZXN0MTQ1NzcxNzA1,529,Vendor Improvements,25387933,Forbiddenz,closed,0,,,,,0,2017-10-10T18:49:13Z,2017-10-12T15:38:57Z,2017-10-11T21:08:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/529,"Fixed buy rates, sell rate math.
Added SetCoin debug cmd
Attempted to tighten up loops..
Reduced action chains down.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/529/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
264381932,MDExOlB1bGxSZXF1ZXN0MTQ1ODA1NTI5,530,"DDDInterrogation uses 32 bit quantities, not 64 bit.",274867,dworkin,closed,0,,,,,1,2017-10-10T21:26:06Z,2017-10-12T13:15:44Z,2017-10-12T13:15:44Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/530,Though the client doesn't seem to mind.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/530/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
264392328,MDExOlB1bGxSZXF1ZXN0MTQ1ODEzMTAy,531,Unique items Vendor Support,25387933,Forbiddenz,closed,0,,,,,0,2017-10-10T22:05:37Z,2017-10-12T15:38:15Z,2017-10-12T13:17:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/531,"Ready For Merge.
Added support for Vendor Buying and re-selling of unique items.
Added @setcoin debug cmd
Enjoy.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/531/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
264674192,MDExOlB1bGxSZXF1ZXN0MTQ2MDE1NDk3,532,"Add Tracking for Burden, Value, and CoinValue",11369233,LtRipley36706,closed,0,,,,,1,2017-10-11T17:39:00Z,2018-02-10T19:56:12Z,2017-10-14T01:56:53Z,MEMBER,,0,ACEmulator/ACE/pulls/532,"* Added Burden tracking to Players and Containers.
* Added CoinValue tracking via objects of WeenieType.Coin to Players and Containers.
* Added Value tracking to Containers. Force Players to always have Value of 0.
* Commented out areas related to above changes that were not implemented correctly.
* TODO: Update Value/Burden and track changes as StackSize adjustments occur.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/532/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
265359209,MDExOlB1bGxSZXF1ZXN0MTQ2NTA5MTk1,533,Vendor Item fixes,25387933,Forbiddenz,closed,0,,,,,1,2017-10-13T17:14:31Z,2017-10-26T16:44:59Z,2017-10-16T11:51:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/533,"Looks like it fixes vendor issues..
May need a little help testing it and fixing it..","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/533/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
265427519,MDExOlB1bGxSZXF1ZXN0MTQ2NTYxMDg5,534,"The Inscription is the thing, Wherein I’ll catch the conscience of the king.",25460553,ogmage78,closed,0,,,,,0,2017-10-13T21:46:18Z,2017-10-16T14:40:53Z,2017-10-14T02:00:24Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/534,"Apologies to Shakespeare
* Added processing for item inscription. Implemented Set Inscription and Inscription Response messages.
* Inscriptions persist to the database and can be removed.
* Implemented first pass of same inscriber check.   Sends error message and does not update the item.   This may need to be revisited, I thought it blocked you from changing it - not sure if that was a weenie error sent to client - I did not see a fail inscribe in live pcaps.   It does check the inscribable flag and will prevent any pre-inscribed items (quest items with inscriptions from being altered.   Thanks @LtRipley36706  for pointing that out.   

![inscription-said-not-dishwasher-safe-computermouse-still-works](https://user-images.githubusercontent.com/25460553/31567552-b18fbc38-b035-11e7-8f09-231575abdca1.jpg)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/534/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
265466415,MDExOlB1bGxSZXF1ZXN0MTQ2NTg4MjMw,535,Mergers and Inquisitions: Added stack-able merge REVIEW ONLY Work in progress,25460553,ogmage78,closed,0,,,,,0,2017-10-14T05:34:21Z,2017-10-16T14:40:49Z,2017-10-16T12:35:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/535,"* Added processing for merge items.
* Added script to update the burden, value and stack size of the weenie for MMD notes I used in testing.   20630 - value 250,000 burden 5 and stack size 1
* Cleaned up code, fixed a bug with drop item.
* This is work in progress, I have more to do, I am putting this up now so we StackOverflow or Ripley can take a look at the issue with vendor

Test steps:

- run update script on your WORLD database to set the values correctly, they are wrong.

- ""@ci 20630"" do this twice.   You will now have 2 MMD notes in your main pack that are not stacked.

- You can inspect each, you will see bu of 5, value of 250,000

- Stack them - check bu and value

- Split them - check bu and value

- You can log in or out, drop the notes and all saves as it should.

I have not tested merging in side packs yet, I am not dealing with more that max stack size yet, I just wanted to get this up for review as there was some thrashing around vendor and this may break that fix.   We need to run down the root cause for the extra save that I removed and was added to make the vendor stuff work.
**UPDATE 10/14/2017**
I have implemented the rest of the logic to respect max stack size.   I have one outstanding bug to run down.

![z2v6ig](https://user-images.githubusercontent.com/25460553/31572978-c984ddb8-b077-11e7-8b7e-677df7c77518.jpg)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/535/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
265743459,MDExOlB1bGxSZXF1ZXN0MTQ2NzY1MzA4,536,Inventory fixes,25387933,Forbiddenz,closed,0,,,,,0,2017-10-16T11:56:30Z,2017-10-26T16:44:57Z,2017-10-16T12:43:08Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/536,"update - for review / test
had to change a bunch of stuff because of ripleys recent merge that broke coins and corrected burdon.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/536/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
265852856,MDExOlB1bGxSZXF1ZXN0MTQ2ODQ0NDI3,537,Feed my people -- Ready for review and merge,10137,ghost,closed,0,,,,,0,2017-10-16T17:36:55Z,2018-03-11T14:34:54Z,2017-10-17T11:35:44Z,NONE,,0,ACEmulator/ACE/pulls/537,"* Implemented Food class for consuming food items
* Stub created for handling Buffing food but implementation is not complete, as spellcasting has not been completed, yet
* Implemented a method for removing an item from inventory that also handles item stacks.
* Included a fix for stack splitting to create proper WorldObject, instead of defaulting everything to GenericObjects","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/537/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
265914873,MDExOlB1bGxSZXF1ZXN0MTQ2ODg3Mzgw,538,Vendor currency,25387933,Forbiddenz,closed,0,,,,,0,2017-10-16T20:59:59Z,2017-10-26T16:44:56Z,2017-10-18T12:15:41Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/538,"Introducing Vendor and Currency
- There are bugs in inventory in regards to moving things around packs.
- I will be doing another PR spec to fix up inventory tracking but I did not feel like it was for this PR","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/538/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
266289590,MDExOlB1bGxSZXF1ZXN0MTQ3MTYxNDYy,539,Inventory Refractor / Bug fixes,25387933,Forbiddenz,closed,0,,,,,0,2017-10-17T21:44:54Z,2017-10-26T16:44:54Z,2017-10-19T13:21:31Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/539,"Up for Review
- Still some issues with max pack size trying to work out but this is far more solid then what is in ace master now.

Could use some help testing it out more.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/539/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
266347302,MDExOlB1bGxSZXF1ZXN0MTQ3MjAwNjQw,540,Read the fine print. - Ready for merge,25460553,ogmage78,closed,0,,,,,0,2017-10-18T03:17:50Z,2017-10-21T19:56:50Z,2017-10-21T17:21:33Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/540,"UPDATE 10/21
**Fixed all outstanding issues**

* Added processing for contract management add / abandon.
* Removed update script I added back on 10/14 to fix the burden of the weenie for the MMD note.   This is no longer needed - use Dereth v0.2.4 or greater the issue has been  resolved in the data and the script is no longer needed.
* Minor code cleanup and improved some method documentation.
* Added new table to store persisted tracked contracts (quests)
* Implemented two new game events / SendClientContractTrackerTable and SendClientContractTracker
* Implemented abandon quest - Game action - Social_AbandonContract
* Documented methods and updated trello.
*To test @ci 44163 -create a contract.   Use the contract and you are now tracking that quest.   You can create any contract using ci or buy one from a vendor if they are In I did not check vendors.   You can abandon the contract.   All management and the cool down delay of 2 seconds is respected.

![download](https://user-images.githubusercontent.com/25460553/31699458-d1b46012-b388-11e7-8dab-cd31ac6f0c57.jpg)


","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/540/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
266365347,MDExOlB1bGxSZXF1ZXN0MTQ3MjEzMDU4,541,Imbibing in the Starter Towns -- For review and merge,10137,ghost,closed,0,,,,,0,2017-10-18T05:39:03Z,2018-03-11T14:34:56Z,2017-10-18T12:56:41Z,NONE,,0,ACEmulator/ACE/pulls/541,"* Reconfigured and renamed functions to account for Potions being included in class Food
* Wired up applying the chosen starting town to the Training Academy path used
* Squashed some white space StyleCop warnings","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/541/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267033815,MDExOlB1bGxSZXF1ZXN0MTQ3Njk4NzY5,542,Fix to Value and Burden,10137,ghost,closed,0,,,,,0,2017-10-20T01:03:11Z,2018-03-11T14:35:01Z,2017-10-21T18:33:25Z,NONE,,0,ACEmulator/ACE/pulls/542,"* Created WO.StackUnitValue and WO.StackUnitBurden to be initialized by Weenie.{Value,EncumbranceVal}, with builtin null to zero initialization
* Moved WorldObject value and encumbrance calculations down to the WorldObject class, based upon WO.StackUnitValue and WO.StackUnitBurden vs WO.StackSize","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/542/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267348925,MDExOlB1bGxSZXF1ZXN0MTQ3OTI3MDgx,543,Authentication overhaul and API start,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-21T04:08:23Z,2017-10-21T17:32:06Z,2017-10-21T17:32:06Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/543,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/543/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267426458,MDExOlB1bGxSZXF1ZXN0MTQ3OTcwMjE5,544,Fix coin value and pickup of stack-able items from landblock,10137,ghost,closed,0,,,,,2,2017-10-22T01:10:04Z,2018-03-11T14:35:02Z,2017-10-23T13:10:49Z,NONE,,0,ACEmulator/ACE/pulls/544,"* Add the initial set of CoinValue in Container.cs to the value of contained Coins
* Modified item move, drop, and pickup methods to account for Pyreal changes, using StackOverflow's UpdateCurrencyClientCalculations();","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/544/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267474854,MDExOlB1bGxSZXF1ZXN0MTQ3OTk5MzI1,545,"* Api Updates, Cmdline Launcher update, Merged output build target, README updates",37453,fantoms,closed,0,,,,,1,2017-10-22T15:40:44Z,2017-10-23T13:14:28Z,2017-10-23T13:14:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/545,"~~* Added lines too Copy `Config.json` too the `Api Host` and `Auth Host` build target directoriess.~~
~~* Changed `*` to `+`, on the Api.Host and Api.Auth.Host startup for non-admins.~~
~~* Added simple service configurations for the Api services, `service_config.json` now requires 2 fields.~~
* Updated README.md to include the required instructions for Api host support.
* Added a few null checks to prevent crashes.
* Added a config error check on the cmd line launcher","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/545/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267869094,MDExOlB1bGxSZXF1ZXN0MTQ4Mjc4MTgz,546,"Fixed Authentication Handler to log and launch for JwtToken issues, added use to some sql update scripts",25650194,Thwargle,closed,0,,,,,1,2017-10-24T01:35:57Z,2017-10-24T11:59:29Z,2017-10-24T11:59:28Z,NONE,,0,ACEmulator/ACE/pulls/546,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/546/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267910444,MDExOlB1bGxSZXF1ZXN0MTQ4MzA2NTQw,547,Fix TypeO in AuthApi.Host/Program.cs,10137,ghost,closed,0,,,,,0,2017-10-24T06:19:59Z,2018-03-11T14:35:04Z,2017-10-24T11:40:14Z,NONE,,0,ACEmulator/ACE/pulls/547,"* Fix a typeo in ACE.AuthApi.Host, as it was attempting to start the API host in place of the AuthAPI host;
should be ""var server = WebApp.Start<Startup>(url: ConfigManager.Config.AuthServer.Url);"", not ""var server = WebApp.Start<ACE.Api.Startup>(url: ConfigManager.Config.AuthServer.Url);""

Credit to Slushnas","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/547/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
267930374,MDExOlB1bGxSZXF1ZXN0MTQ4MzIwNzcz,548,Fix for AuthServer external access,11369233,LtRipley36706,closed,0,,,,,0,2017-10-24T07:48:38Z,2018-02-10T19:56:11Z,2017-10-24T11:44:26Z,MEMBER,,0,ACEmulator/ACE/pulls/548,"* @Slushnas found WebApp.Start error in ACE.AuthApi.Host: Changed ACE.Api.Startup to ACE.AuthApi.Startup to fix domain error.
* AuthServer Changes:
  - AuthServer needs a publicly accessible address to point connecting clients if you're trying to use the server outside of a localhost/internal lan only environment.
  - The current defaults basically point everything to `http://+:8001` which fails to resolve. So the following changes have been made..
  - Changed AuthServer.Url to AuthServer.ListenUrl
  - Added AuthServer.PublicUrl
  - Typically, you'll leave the AuthServer.ListenUrl to the default, but you'll want to change AuthServer.PublicUrl to either of the following: 
    * The externally accessible address of the AuthServer so that clients from the internet can authenticate.

    OR

    * localhost or the internal lan address so only those inside the local network/local machine can authenticate.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/548/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
268003506,MDExOlB1bGxSZXF1ZXN0MTQ4Mzc1Mzkx,549,Auth fixes,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-24T11:58:30Z,2017-10-24T12:17:45Z,2017-10-24T12:17:45Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/549,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/549/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
268126006,MDExOlB1bGxSZXF1ZXN0MTQ4NDY3ODU1,550,"New api definitions, content api implementation",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-24T17:48:35Z,2017-10-25T12:53:02Z,2017-10-25T12:53:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/550,The deleted files are from an outdated web project I had that probably never should have been added.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/550/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
268195852,MDExOlB1bGxSZXF1ZXN0MTQ4NTIwNTE3,551,EquipMask Enum Fix,26606778,OptimShi,closed,0,,,,,0,2017-10-24T21:41:44Z,2018-03-27T03:34:52Z,2017-10-24T22:57:36Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/551,Fixed bug with EquipMask enum that was causing Greaves/Lower Leg Armor not to appear on character,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/551/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
268270761,MDExOlB1bGxSZXF1ZXN0MTQ4NTczNDUx,552,"Ready for review; AccessLevel from subscrptions, Api Auth update",37453,fantoms,closed,0,,,,,1,2017-10-25T05:28:17Z,2017-10-26T13:53:02Z,2017-10-26T13:53:02Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/552,"* first tests are successful.
* Api will take the first subscription's accesslevel, when checking roles; this should probably be set to take the highest level. AccessLevel of Player (0) is used when a subscription is missing.
* Adding Mogwai's objects in and credits to Mogwai for setting up the functions to test auth.
* Prevent crash and block user when password/username mismatched.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/552/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
268271982,MDExOlB1bGxSZXF1ZXN0MTQ4NTc0MzE4,553,Service Installer - Phase one - Implement for game server,10137,ghost,closed,0,,,,,1,2017-10-25T05:37:04Z,2018-03-11T14:35:17Z,2017-10-25T19:21:11Z,NONE,,0,ACEmulator/ACE/pulls/553,"* Implemented phase one of enabling ACE to support running as a Windows service
* Once this PR is accepted and merged, will work on converting the API Host and Auth API Host processes

* TODO: convert console processes to some other means, as the console is not accessible when running as a service
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/553/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
268374836,MDExOlB1bGxSZXF1ZXN0MTQ4NjUwNDIy,554,bug pulling subscriptions from the database,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-25T12:16:07Z,2017-10-25T15:39:52Z,2017-10-25T15:39:52Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/554,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/554/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
269181237,MDExOlB1bGxSZXF1ZXN0MTQ5MjQ1MjEy,555,"New api definitions, tagging properties for JSON naming standards",25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-27T17:32:20Z,2017-10-27T23:03:25Z,2017-10-27T23:03:25Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/555,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/555/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
269266176,MDExOlB1bGxSZXF1ZXN0MTQ5MzA3NDMw,556,Update SetupModel,26606778,OptimShi,closed,0,,,,,0,2017-10-27T23:56:54Z,2018-03-27T03:34:51Z,2017-10-28T05:55:53Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/556,Updated DatLoader.FileTypes.SetupModel to more closely represent what is in the client. Also added additional structures to this to fully read the file.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/556/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
269396346,MDExOlB1bGxSZXF1ZXN0MTQ5MzgzMzA3,557,OG's last physics checkin,10608427,Mag-nus,closed,0,5246554,ddevec,,,1,2017-10-29T12:45:10Z,2017-11-07T17:51:36Z,2017-11-07T17:51:36Z,MEMBER,,0,ACEmulator/ACE/pulls/557,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/557/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
269811687,MDExOlB1bGxSZXF1ZXN0MTQ5NjgwMzY4,558,Saving weenies in ace world,25351661,Mogwai-TheFurry,closed,0,,,,,0,2017-10-31T02:14:05Z,2017-11-02T03:53:09Z,2017-11-02T03:53:09Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/558,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/558/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
269835755,MDExOlB1bGxSZXF1ZXN0MTQ5Njk3MDI5,559,Convert PropertyInt properties from uint to int,11369233,LtRipley36706,closed,0,,,,,0,2017-10-31T05:01:29Z,2018-02-10T19:56:07Z,2017-11-01T17:53:08Z,MEMBER,,0,ACEmulator/ACE/pulls/559,"* Update EmoteCategory, EmoteType and SpellType enums
* Add CombatStyle enum
* Rebase SQL scripts
* Change uint to int in SQL
* Adjust SpellType
* Changed all PropertyInt properties from uint to int","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/559/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
270411537,MDExOlB1bGxSZXF1ZXN0MTUwMTE2MDI2,560,fixed web project auth to actually work.  *shrug*,33289759,Verbal-AC,closed,0,,,,,1,2017-11-01T18:48:39Z,2017-11-06T03:27:54Z,2017-11-06T03:27:54Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/560,"no idea where this was going, but at least the auth works now.  also updated nuget packages.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/560/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
270738820,MDExOlB1bGxSZXF1ZXN0MTUwMzU0NDMz,561,Fix Weenie Instance Position data load into AceObject,11369233,LtRipley36706,closed,0,,,,,0,2017-11-02T17:24:04Z,2018-02-10T19:56:03Z,2017-11-02T17:25:07Z,MEMBER,,0,ACEmulator/ACE/pulls/561,Forgot to recall the instance current location data and put it in AceObject.Location so that objects appear where they are supposed to.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/561/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
271151788,MDExOlB1bGxSZXF1ZXN0MTUwNjUzMTAx,562,Fix AppVeyor issues,11369233,LtRipley36706,closed,0,,,,,0,2017-11-04T00:29:07Z,2018-02-10T19:56:03Z,2017-11-04T00:45:51Z,MEMBER,,0,ACEmulator/ACE/pulls/562,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/562/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
271203381,MDExOlB1bGxSZXF1ZXN0MTUwNjgyODQy,563,Reducing threading in core & simplifying coding model,5246554,ddevec,closed,0,,,,,0,2017-11-04T16:12:43Z,2017-11-07T17:58:10Z,2017-11-07T17:58:10Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/563,"Landblocks no longer act in parallel.  Any game-content updates done from a landblock need not worry about synchronizing with other landblocks, this should simplify the coding of the core game logic.

NOTE: The network packet parsing still happens in its own thread, so ActionChains are still required to move work from the network thread onto the landblock.

ActionChains are also still included for their uses delaying work (e.g. when waiting for an animation, or to reach a destination).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/563/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
271342874,MDExOlB1bGxSZXF1ZXN0MTUwNzU5ODQy,564,Ready for Peer review and testing * Feature: database redeployment,37453,fantoms,closed,0,,,,,1,2017-11-06T02:36:26Z,2017-11-11T21:11:51Z,2017-11-11T21:11:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/564,"* Added redeployment functionality for Database Maintenance. This will download database files from Github and completely setup a database. These functions require a working database configuration before operation, but in the future this functionality will be used from API or ACE.Web App to setup or upgrade a database.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/564/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
273298657,MDExOlB1bGxSZXF1ZXN0MTUyMTQ0NjMx,565,added reading of xp sharing in fellowship creation,33289759,Verbal-AC,closed,0,,,,,0,2017-11-13T03:16:21Z,2017-11-14T16:46:51Z,2017-11-14T16:46:51Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/565,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/565/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
273307151,MDExOlB1bGxSZXF1ZXN0MTUyMTUwNTM4,566,Robustify API Hosts,11369233,LtRipley36706,closed,0,,,,,2,2017-11-13T04:26:31Z,2017-11-15T23:43:38Z,2017-11-15T23:43:38Z,MEMBER,,0,ACEmulator/ACE/pulls/566,"* Removed AnyCPU configuration.
* Removed second Database.Start from ACE main program.
* Changes made to Api.Host and AuthApi.Host to handle automatically fixing issues with urlacl and firewall.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/566/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
275116414,MDExOlB1bGxSZXF1ZXN0MTUzNDcxODU0,567,Add a few basic Chess elements,11369233,LtRipley36706,closed,0,,,,,0,2017-11-18T22:53:05Z,2018-02-10T19:55:44Z,2017-11-22T20:49:59Z,MEMBER,,0,ACEmulator/ACE/pulls/567,:),"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/567/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
275436599,MDExOlB1bGxSZXF1ZXN0MTUzNjg5NDkw,568,EquipTest Updates,26606778,OptimShi,closed,0,,,,,0,2017-11-20T17:27:37Z,2018-03-27T03:34:49Z,2017-11-22T20:55:40Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/568,Changed EquipTest debug command to utilize the index of a clothing table item and added an optional shade parameter,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/568/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
276805893,MDExOlB1bGxSZXF1ZXN0MTU0NjY4MjU4,569,Make Use Wield/Shop Lists,11369233,LtRipley36706,closed,0,,,,,0,2017-11-26T07:28:01Z,2018-02-10T19:55:41Z,2017-11-30T18:26:44Z,MEMBER,,0,ACEmulator/ACE/pulls/569,"Add AceObjectInventory class and make Vendors/Creatures/WO use it for shop/wield lists.

The WieldList is more hack than viable code likely but it does visually make the world closer to correct, and sets up a foundation for the objects having lists of things they need to generate.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/569/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
278464923,MDExOlB1bGxSZXF1ZXN0MTU1ODYwOTIw,570,Upgrade to VS 2017 and .net Framework 4.6.1,10608427,Mag-nus,closed,0,,,,,0,2017-12-01T13:23:50Z,2017-12-02T04:52:54Z,2017-12-02T04:52:54Z,MEMBER,,0,ACEmulator/ACE/pulls/570,"If we are to migrate the project to .net standard 2.0 and .net core 2.0, we must first migrate the projects to .net Framework 4.6.1.

.net Framework 4.5 will not reference .net standard 2.0. Thus, this phase 1 requirement.

Note: The only change I made was choosing a different target framework in project settings. All the other file changes were done by VS 2017 (latest release).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/570/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
278656337,MDExOlB1bGxSZXF1ZXN0MTU1OTk5NjEw,571,Some fixes,11369233,LtRipley36706,closed,0,,,,,0,2017-12-02T05:12:36Z,2018-02-10T19:55:37Z,2017-12-02T05:16:07Z,MEMBER,,0,ACEmulator/ACE/pulls/571,"* Updated README links relating to Protocol documentation.
* Fixed read issue with AnimationFrame in DatLoader. (Issue reported from Discord & confirmed by OptimShi)
* Rebased SQL scripts.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/571/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
278734333,MDExOlB1bGxSZXF1ZXN0MTU2MDQwNDI2,572,Remove files not referenced by their project (rogue files),10608427,Mag-nus,closed,0,,,,,0,2017-12-03T01:18:34Z,2017-12-03T02:35:17Z,2017-12-03T02:35:17Z,MEMBER,,0,ACEmulator/ACE/pulls/572,"These existed in the repo but weren't included in the ACE.Entity project:
ACE.Entity\ILandBlock.cs
ACE.Entity\WeenieAnimationOverride.cs
ACE.Entity\WeeniePalletOverride.cs
ACE.Entity\WeenieTextureMapOverride.cs

When converting to .net standard, these files will be included in the projects again due to the way .net core/standard project files behave. They include all files in the local paths. Unlike .net framework csproj files, there is no list of files the project maintains.

This PR also includes the removal of child Settings.StyleCop files.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/572/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
278839003,MDExOlB1bGxSZXF1ZXN0MTU2MDkwNzA3,573,Major migration from .net framework 4.6.1 to .net standard/core 2.0,10608427,Mag-nus,closed,0,,,,,0,2017-12-04T00:31:03Z,2017-12-05T00:10:33Z,2017-12-05T00:10:33Z,MEMBER,,0,ACEmulator/ACE/pulls/573,"# Assembly status:

**Should be switched to asp.net core 2.0 by a web dev:**
ACE.Api
ACE.Api.Common
ACE.Api.Host
ACE.AuthApi
ACE.AuthApi.Host
ACE.Web

**Still needs to be switched to .net core 2.0:**
ACE
- When this is converted, it will load .net core libraries and not .net framework libraries. The .net core libraries for system.data are not fully implemented and will throw an error in ACE.Database.Database.cs, line 1005 and line 1048, result.Load(commandReader). It is documented here: https://github.com/dotnet/corefx/issues/19748
- When using the .net standard version of log4net, the LogManager.GetLogger(string) fn no longer exists, and this will break ACE.Network.NetworkSession.cs and ACE.Network.ConnectionListener.cs

**Switched to .net core 2.0:**
ACE.CmdLineLauncher
ACE.Tests

**Switched to .net standard 2.0:**
ACE.Common
ACE.Database
ACE.Database.Tests
ACE.DatLoader
ACE.DatLoader.Tests
ACE.Entity

**This creates windows forms and thus cannot be converted.**
ACE.Diagnostics
- We need a better way to expose diagnostic information anyway. ACE should not be referencing ACE.Diagnostics


# Notes:

**ACE.CmdLineLauncher:**
- To launch it from a command line use: dotnet ACE.CmdLineLauncher.dll

**ACE.Database:**
- Redeploy.cs -> CheckLocalDataPath(): File permission checking has been commented out as it's not supported in .net standard/core.
- MySqlResult inherited from DataTable and added a property and a couple functions, but they were never used, thus, MySqlResult isn't needed.

**ACE.DatLoader:**
- Removal of ACE.DatLoader\default.ruleset which I believe to be a rogue file.


**Misc:**
- Test projects no longer have flask icons. I'm not sure if I broke them or if they still work.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/573/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
278995348,MDU6SXNzdWUyNzg5OTUzNDg=,574,ACE Web/API projects should be converted to .net standard/core 2.0,10608427,Mag-nus,closed,0,,,,,1,2017-12-04T13:27:39Z,2018-01-28T07:27:57Z,2018-01-28T07:27:57Z,MEMBER,,,,"Most of the non web libraries of ACE have been converted to either .net standard 2.0 or .net core 2.0, and soon ACE be converted to .net core 2.0 as well.

We need an experienced web developer to migrate our web/api stuff.

The following projects need to be migrated:
ACE.Api
ACE.Api.Common
ACE.Api.Host
ACE.AuthApi
ACE.AuthApi.Host
ACE.Web

ACE.Api.Common should be priority as it's referenced directly by ACE.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/574/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
278996371,MDU6SXNzdWUyNzg5OTYzNzE=,575,ACE.Diagnostics needs rework,10608427,Mag-nus,closed,0,,,,,0,2017-12-04T13:31:13Z,2018-02-22T06:59:09Z,2018-02-22T06:59:09Z,MEMBER,,,,"ACE references ACE.Diagnostics and loads a winform directly.

This is not cross-platform compatible nor is it compatible with .net core 2.0. Because of this, ACE.Diagnostics has been removed from ACE.

The landblock viewer in ACE.Diagnostics was pretty nice. We need a better way to expose diagnostic information via ACE for subscribers to consume.

Perhaps ACE.Diagnostics becomes a .net standard 2.0 library that simply collects/exposes data. Listeners could then use this data and present it various ways (winforms apps, web apps, etc..)

Alternatively, this information could be exposed via an API, or, it gets moved to ACE.Api.Common.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/575/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
279007199,MDU6SXNzdWUyNzkwMDcxOTk=,576,Improve database query performance,10608427,Mag-nus,closed,0,,,,,1,2017-12-04T14:05:39Z,2018-02-26T13:30:37Z,2018-02-26T13:30:37Z,MEMBER,,,,"The way we interact with the database isn't very efficient. It causes problems like stuck clients, server crashes, portaling in as pink bubbles..

Advice from Rawaho:
The queries should use less reflection. Use LINQ expressions instead.
Even with cached properties SetValue is SLOW","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/576/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
279835071,MDExOlB1bGxSZXF1ZXN0MTU2Nzg3OTg3,577,Account name check at creation,14854251,Nalindar,closed,0,,,,,3,2017-12-06T17:12:53Z,2018-01-26T17:51:00Z,2018-01-26T17:51:00Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/577,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/577/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
280840388,MDU6SXNzdWUyODA4NDAzODg=,578,Switch from log4net to LoggerFactory,10608427,Mag-nus,closed,0,,,,,2,2017-12-10T20:10:21Z,2018-03-25T07:30:06Z,2018-03-25T07:30:06Z,MEMBER,,,,"A suggestion from Rawaho.

Reference: https://stackify.com/net-core-loggerfactory-use-correctly/","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/578/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
280850106,MDExOlB1bGxSZXF1ZXN0MTU3NDUyNjQ1,579,ACE switched over to .net core 2.0,10608427,Mag-nus,closed,0,,,,,1,2017-12-10T22:09:17Z,2017-12-12T13:08:33Z,2017-12-12T13:08:33Z,MEMBER,,0,ACEmulator/ACE/pulls/579,"ACE.Database\Extensions\DataTableExtensions.cs has been changed. Comments have been added and the new manual method is now the only method used when loading data.

ACE.Database\Database.cs added a debug message before and after the time consuming InitializePreparedStatements()","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/579/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
281253897,MDExOlB1bGxSZXF1ZXN0MTU3NzM0MzU2,580,Reduced parallelism from network threads,5246554,ddevec,closed,0,,,,,0,2017-12-12T04:27:17Z,2017-12-14T04:48:28Z,2017-12-14T04:48:28Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/580,"Continued efforts to make coding on ACE easier by reducing unneeded parallelism in the core.

Network threads now hand their work off to the ActionChain system on the main thread before any handlers are called after data is gathered.  ActionChains are no longer required in code handling network data.

Also removed a vast majority of the no longer needed ActionChains in the code.  They are currently only needed for explicit thread communication (should be /very/ rare), and for delayed events (e.g. waiting for movement).

Next step is using ActionChains to handle delays from DB loading timeouts (e.g. landblock loading).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/580/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
283121688,MDExOlB1bGxSZXF1ZXN0MTU5MDkxMDIz,581,Generators generated,11369233,LtRipley36706,closed,0,,,,,2,2017-12-19T06:53:31Z,2018-02-10T19:55:36Z,2018-01-05T17:03:26Z,MEMBER,,0,ACEmulator/ACE/pulls/581,"* Overhauled Generator system to bring it more in line with how it operated on retail servers.
  * You'll need to load some test data included with this update in the Updates/World folder for this code to work.
  * Locations of the test generators are below. The creature generators do not support regeneration, while the item generators will regenerate.
  * /teleloc 0x7f0301ad [12.319899559021 -28.482000350952 0.0049999998882413] 0.33894598484039 0 0 0.94080585241318
  * /telepoi Holtburg

This is by no means the complete system but I think its a good step towards one than what is currently in ACE. Lots more to do no doubt.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/581/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
284993677,MDExOlB1bGxSZXF1ZXN0MTYwNDQ1MjMw,582,Tier 1 loot,10187880,dgatewood,closed,0,,,,,0,2017-12-28T21:31:53Z,2018-01-23T18:59:53Z,2018-01-23T18:59:53Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/582,"WIP Tier 1 loot, new classes for missing loot item, additions to AceObject and WorldObject for variables that needed to be added, command added in commandHandler, etc.  Much more work needs to be done to added all the necessary variables to WorldObject.

This should be discussed. I feel that my coding skills may not be on par with most others. I felt the million if/else statements and rnd numbers was excessive, but didn't know how else to do it since all items had different ranges for their stats, etc.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/582/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
285128338,MDExOlB1bGxSZXF1ZXN0MTYwNTQxNjc0,583,"Replace Explicit ""Action"" based event system with C#-style Task system",5246554,ddevec,closed,0,,,,,3,2017-12-29T17:30:25Z,2018-02-06T03:28:34Z,2018-02-06T03:28:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/583,"This is a major overhaul to the event system used by our code (sorry its so large).  Some of the highlights:

- No longer use Actions/ActionChains, events are now managed with ""coroutines"", enabled through C#'s TPL Task class, and a custom TaskScheduler.
- Database loads no longer block the main thread (this was trivial to do with the new task structure).
- TODO: Manage Tasks based on loaded/unloaded entities (e.g. stop player-bound tasks automatically when the player is unloaded, or corpse-decay tasks when a landblock is unloaded).

This is a huge change, that changes most of the files in the code... I couldn't really help it.  I would recommend trying to check it out, and see how its working.  IMO, its much cleaner, more efficient code than our prior system with more functionality.

I'm still debugging some of our fringe use-cases, so some bug fixes may be forthcoming, but figured I would get this up to let people review.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/583/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
286999819,MDExOlB1bGxSZXF1ZXN0MTYxODA1OTE2,584,First round of 16PY fixes,11369233,LtRipley36706,closed,0,,,,,1,2018-01-09T07:57:51Z,2018-01-31T10:07:25Z,2018-01-16T07:39:52Z,MEMBER,,0,ACEmulator/ACE/pulls/584,"These fixes based on obvious issues as of version 0.0.2 of 16PY.

* Corrected issue with objects spawning at xxxx0000 in landblock.
* Added expected object flags to currently implemented WeenieType classes.
* Adjusted Bool recalls for WorldObjects.
* Added Shade (and TryToBond, which appears unimportant) to Inventory.
* Added Shade and palette to create command for testing.
* Added ClothingBase and Palette lookup for object spawning so they look correct.
* Added proper wielding for clothing on weenies and fixed clothing priority for them.
* Added face randomization for Human based NPCs.

version 0.0.3 of 16PY to follow shortly with shade data included for inventory","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/584/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
287316274,MDExOlB1bGxSZXF1ZXN0MTYyMDM3MzE0,585,"GiveObjectRequest, HearDirectSpeech, and HandleGiveObjectRequest",10187880,dgatewood,closed,0,,,,,1,2018-01-10T05:04:35Z,2018-01-23T19:00:15Z,2018-01-23T19:00:15Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/585,The code for the collector is extra and can be taken out if necessary. I just thought it would be cool for the meantime while we are waiting on the emote tables.  People like to see a little flair.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/585/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
287961913,MDExOlB1bGxSZXF1ZXN0MTYyNTE1MjI4,586,Fix non-critical typo in hex constant.,24561337,cydrith,closed,0,,,,,0,2018-01-11T23:37:50Z,2018-01-15T03:58:03Z,2018-01-15T03:58:03Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/586,"Not important, just a little thing I noticed a while back,
Considering how C# handles constants, I don't think this could become an issue (even in the case system endian was reversed). Just a style issue, at most.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/586/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
288437623,MDExOlB1bGxSZXF1ZXN0MTYyODQyMTM0,587,Second attempt at 16PY fixes,11369233,LtRipley36706,closed,0,,,,,2,2018-01-14T20:37:23Z,2018-01-31T10:06:55Z,2018-01-25T04:13:54Z,MEMBER,,0,ACEmulator/ACE/pulls/587,"These fixes based on obvious issues as of version 0.0.2 of 16PY.

* Corrected issue with objects spawning at xxxx0000 in landblock.
* Added expected object flags to currently implemented WeenieType classes.
* Adjusted Bool recalls for WorldObjects.
* Added Shade (and TryToBond, which appears unimportant) to Inventory.
* Added Shade and palette to create command for testing.
* Added ClothingBase and Palette lookup for object spawning so they look correct.
* Added proper wielding for clothing on weenies and fixed clothing priority for them.
* Added face randomization for Human based NPCs.

version 0.0.3 of 16PY to follow shortly with shade data included for inventory
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/587/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
288465578,MDExOlB1bGxSZXF1ZXN0MTYyODU4OTc2,588,Fellowships,4855786,spazmodica,closed,0,,,,,0,2018-01-15T02:39:47Z,2018-01-16T07:05:39Z,2018-01-16T07:05:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/588,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/588/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
289810217,MDExOlB1bGxSZXF1ZXN0MTYzODQ4MjQy,589,Update Licence,24561337,cydrith,closed,0,,,,,2,2018-01-18T23:17:28Z,2018-01-20T02:59:56Z,2018-01-20T02:59:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/589,GPL V3 to AGPL V3,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/589/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
289811256,MDExOlB1bGxSZXF1ZXN0MTYzODQ5MDEw,590,Update Licence,24561337,cydrith,closed,0,,,,,0,2018-01-18T23:22:22Z,2018-01-19T00:13:56Z,2018-01-19T00:13:48Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/590,"GPL V3 to AGPL V3
[ci skip]","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/590/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
289819550,MDU6SXNzdWUyODk4MTk1NTA=,591,Agreement to change licence to AGPL V3.,24561337,cydrith,open,0,,,,,1,2018-01-19T00:04:55Z,2023-11-23T01:50:26Z,,CONTRIBUTOR,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [x] feature request
```

### Desired functionality.
Change licence to AGPL, from existing GPL.
Changes proposed in [this pull request](https://github.com/ACEmulator/ACE/pull/589).

### Express Consent from following contributors has been provided 
- [x] [LtRipley36706](https://github.com/LtRipley36706)
- [x] [Mogwai-TheFurry](https://github.com/Mogwai-TheFurry)
- [x] [ogmage78](https://github.com/ogmage78)
- [ ] [fantoms](https://github.com/fantoms)
- [x] [OptimShi](https://github.com/OptimShi)
- [x] [Rawaho](https://github.com/Rawaho)
- [x] [Zegeger](https://github.com/Zegeger)
- [x] [kdmxp256](https://github.com/kdmxp256)
- [x] [Forbiddenz](https://github.com/Forbiddenz)
- [ ] [Lidefeath](https://github.com/Lidefeath)
- [x] [ddevec](https://github.com/ddevec)
- [x] [BrainBucket](https://github.com/BrainBucket)
- [x] [TigrisOfGaul](https://github.com/TigrisOfGaul)
- [x] [Mag-nus](https://github.com/Mag-nus)
- [x] [lurker-mcdoogle](https://github.com/lurker-mcdoogle)
- [x] [MiachofTD](https://github.com/MiachofTD)
- [ ] [LytelthorpeThistledown](https://github.com/LytelthorpeThistledown)
- [ ] [ChrisAikman](https://github.com/ChrisAikman)
- [ ] [delasteve](https://github.com/delasteve)
- [x] [immortalbob](https://github.com/immortalbob)
- [ ] [kaos00723](https://github.com/kaos00723)
- [ ] [sbaum23](https://github.com/sbaum23)
- [x] [Verbal-AC](https://github.com/Verbal-AC)
- [x] [zbuc](https://github.com/zbuc)
- [ ] [TheMentor](https://github.com/TheMentor)
- [x] [Cydrith](https://github.com/Cydrith)
- [ ] [KochiroOfHG](https://github.com/KochiroOfHG)
- [x] [Zorgle](https://github.com/Zorgle)
- [x] [Jyard1](https://github.com/Jyard1)
- [x] [rtmruczek](https://github.com/rtmruczek)
- [x] [Slushnas](https://github.com/Slushnas)
- [x] [dworkin](https://github.com/dworkin)
- [x] [spazmodica](https://github.com/spazmodica)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/591/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,issue
289835052,MDExOlB1bGxSZXF1ZXN0MTYzODY2Njg1,592,Fellowships,4855786,spazmodica,closed,0,,,,,0,2018-01-19T01:36:33Z,2018-01-20T02:28:17Z,2018-01-20T02:28:17Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/592,"<= 2.5 map coord away = full share
2.5 to 5 = proportional by range so at 5 map coords away = 0%","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/592/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
290190571,MDExOlB1bGxSZXF1ZXN0MTY0MTI2NTU1,593,ACE.DatLoader flag fixes for Portals,10608427,Mag-nus,closed,0,,,,,0,2018-01-20T12:59:43Z,2018-01-21T13:19:13Z,2018-01-21T13:19:13Z,MEMBER,,0,ACEmulator/ACE/pulls/593,Cosmetic change pointed out by Rawaho.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/593/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
290324579,MDExOlB1bGxSZXF1ZXN0MTY0MjA1OTI4,594,ACE.DatLoader refactoring,10608427,Mag-nus,closed,0,,,,,0,2018-01-22T01:04:22Z,2018-01-23T10:02:39Z,2018-01-23T10:02:39Z,MEMBER,,0,ACEmulator/ACE/pulls/594,"This new code format uses extension methods to re-use code. It allows decouples object unpacking from DatReader and reduces the dependency to a simple BinaryReader.

There are also a few dat parsing bugs that were fixed.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/594/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
290698295,MDExOlB1bGxSZXF1ZXN0MTY0NDc1NTg2,595,GiveObjectRequest,10187880,dgatewood,closed,0,,,,,0,2018-01-23T03:36:57Z,2018-01-23T10:02:06Z,2018-01-23T10:02:06Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/595,"HearDirectSpeech  GameMessage added. Was not used here but was used for collector code I got rid of.
GiveObjectRequest GameAction added.
HandleGiveObjectRequest added to player.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/595/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
290720807,MDExOlB1bGxSZXF1ZXN0MTY0NDkxNzU5,596,Player teleporting away no longer leaves ghost of self.,4855786,spazmodica,closed,0,,,,,0,2018-01-23T06:15:42Z,2018-01-23T10:01:43Z,2018-01-23T10:01:43Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/596,"ActionChain null wrapper added to not crash server if teleporting player disconnects
Resolves 231","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/596/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
290964677,MDExOlB1bGxSZXF1ZXN0MTY0NjY4NDI0,597,Some quick changes.,11369233,LtRipley36706,closed,0,,,,,0,2018-01-23T19:31:08Z,2018-01-31T10:06:59Z,2018-01-23T19:38:01Z,MEMBER,,0,ACEmulator/ACE/pulls/597,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/597/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
291042594,MDExOlB1bGxSZXF1ZXN0MTY0NzI2ODYx,598,Add back Shade and TryToBond,11369233,LtRipley36706,closed,0,,,,,1,2018-01-24T00:27:35Z,2018-01-31T10:07:15Z,2018-01-25T03:16:52Z,MEMBER,,0,ACEmulator/ACE/pulls/598,Let's see what this does shall we?,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/598/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
291079550,MDExOlB1bGxSZXF1ZXN0MTY0NzUzMzY4,599,Gem OnUse and UpdateEnchantment,10187880,dgatewood,closed,0,,,,,0,2018-01-24T04:17:17Z,2018-01-24T04:38:24Z,2018-01-24T04:38:24Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/599,"Reworked GameEventMagicUpdateEnchantment. The way it was currently trying to pack spell data was garbling things up and the packet no longer matched a retail packet. Once I rewrote it, it now matches retail and also shows all spells in use in the active spell tab in the top left corner, with time remaining(client side).  This will be implemented server side soon.

To demonstrate this, I implemented non contract OnUse for gems. You can use Blackmoor's Favor, or the two gems that are available for sale at the gem shop in Holtburg.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/599/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
291082473,MDExOlB1bGxSZXF1ZXN0MTY0NzU1Mzgw,600,Typo with that last one,10187880,dgatewood,closed,0,,,,,1,2018-01-24T04:39:24Z,2018-01-25T04:33:17Z,2018-01-25T04:33:17Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/600,"Reworked GameEventMagicUpdateEnchantment. The way it was currently trying to pack spell data was garbling things up and the packet no longer matched a retail packet. Once I rewrote it, it now matches retail and also shows all spells in use in the active spell tab in the top left corner, with time remaining(client side).  This will be implemented server side soon.

To demonstrate this, I implemented non contract OnUse for gems. You can use Blackmoor's Favor, or the two gems that are available for sale at the gem shop in Holtburg.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/600/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
291792353,MDExOlB1bGxSZXF1ZXN0MTY1Mjg1MTMx,601,Update starterGear.json,32439087,CrimsonMage,closed,0,,,,,0,2018-01-26T03:47:21Z,2018-01-26T17:51:49Z,2018-01-26T17:51:49Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/601,Added Summoning to StarterGear.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/601/reactions"", ""total_count"": 2, ""+1"": 1, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
291799764,MDExOlB1bGxSZXF1ZXN0MTY1MjkwMzUw,602,UpdateEnchantment/Gem OnUse,10187880,dgatewood,closed,0,,,,,2,2018-01-26T04:52:50Z,2018-02-03T17:10:40Z,2018-02-03T17:10:40Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/602,"I used TortoiseGit to create branch/master. I tried it by git commands only, but it kept telling me no such git directory... Checked it multiple times. I hope I am getting close with Git in general.

Reworked GameEventMagicUpdateEnchantment. The way it was currently trying to pack spell data was garbling things up and the packet no longer matched a retail packet. Once I rewrote it, it now matches retail and also shows all spells in use in the active spell tab in the top left corner, with time remaining(client side). This will be implemented server side soon.

To demonstrate this, I implemented non contract OnUse for gems. You can use Blackmoor's Favor, or the two gems that are available for sale at the gem shop in Holtburg.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/602/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
292168551,MDExOlB1bGxSZXF1ZXN0MTY1NTQ2MTc4,603,"More dat refactoring, this time based on SetupModel and Hooks.",10608427,Mag-nus,closed,0,,,,,0,2018-01-28T01:34:56Z,2018-01-28T01:39:08Z,2018-01-28T01:39:08Z,MEMBER,,0,ACEmulator/ACE/pulls/603,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/603/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
292168991,MDExOlB1bGxSZXF1ZXN0MTY1NTQ2NDI2,604,Remove API and SecureAuth,11369233,LtRipley36706,closed,0,,,,,0,2018-01-28T01:45:04Z,2018-01-31T10:06:54Z,2018-01-28T12:46:16Z,MEMBER,,0,ACEmulator/ACE/pulls/604,"Per agreement, API and SecureAuth are being removed at this time.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/604/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
292223602,MDExOlB1bGxSZXF1ZXN0MTY1NTc4NTEy,605,"Adding NetAuthType, Password Verification and Auto Account Creation",11369233,LtRipley36706,closed,0,,,,,0,2018-01-28T17:50:00Z,2018-01-31T10:06:52Z,2018-01-28T18:58:31Z,MEMBER,,0,ACEmulator/ACE/pulls/605,"* Added some simple Authentication database tests.
* Added NetAuthType checking and password verification.
* GlsTicketDirect/GlsTicket checking is disabled until it can be reimplented in the future.
* **New ACClient launch command is in use now!**
  - ``` acclient.exe -a account_name_here -v password_here -h 127.0.0.1:9000 ```
  - The old command will not work.
* Auto Account creation now occurs for any successful connection for an account that does not currently exist. Default AccessLevel is based on config.json setting.
* Added some account password tests.
* Added AllowAutoAccountCreation to config.json. Set it to false to disable auto account creation.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/605/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
292230022,MDExOlB1bGxSZXF1ZXN0MTY1NTgyMjMw,606,"Oops, forgot to set AccessLevel on new account. Fixed.",11369233,LtRipley36706,closed,0,,,,,0,2018-01-28T19:15:50Z,2018-01-31T10:06:51Z,2018-01-28T19:20:31Z,MEMBER,,0,ACEmulator/ACE/pulls/606,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/606/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
292231460,MDExOlB1bGxSZXF1ZXN0MTY1NTgzMTQ2,607,ACE.DatLoader RegionDesc updated to the new format w/bug fixes,10608427,Mag-nus,closed,0,,,,,0,2018-01-28T19:35:19Z,2018-01-28T19:41:47Z,2018-01-28T19:41:47Z,MEMBER,,0,ACEmulator/ACE/pulls/607,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/607/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
292495143,MDExOlB1bGxSZXF1ZXN0MTY1NzY5NDAy,608,Rebased SQL scripts,11369233,LtRipley36706,closed,0,,,,,0,2018-01-29T17:33:43Z,2018-01-31T10:06:49Z,2018-01-29T17:58:43Z,MEMBER,,0,ACEmulator/ACE/pulls/608,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/608/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
293102357,MDExOlB1bGxSZXF1ZXN0MTY2MjE3MzU5,609,Update README.md,2572086,w4nn3s,closed,0,,,,,2,2018-01-31T10:17:52Z,2018-02-03T17:10:55Z,2018-02-03T17:10:55Z,NONE,,0,ACEmulator/ACE/pulls/609,spacing around links,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/609/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
293388061,MDExOlB1bGxSZXF1ZXN0MTY2NDMyNjM3,610,ACE.DatLoader more IUnpackable work,10608427,Mag-nus,closed,0,,,,,0,2018-02-01T03:04:27Z,2018-02-01T03:09:09Z,2018-02-01T03:09:09Z,MEMBER,,0,ACEmulator/ACE/pulls/610,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/610/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294086834,MDExOlB1bGxSZXF1ZXN0MTY2OTQ4Mjg3,611,Updated GameEventMagicUpdateEnchantment to write the info correctly. …,10187880,dgatewood,closed,0,,,,,0,2018-02-03T05:46:44Z,2018-02-03T12:36:12Z,2018-02-03T12:36:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/611,"* Updated GameEventMagicUpdateEnchantment to write the info correctly. This now matches retail. Also added session and target so that it will be flexible when applying spells from casting to self and other, not just for gems (per Morosity's review).
Added Gem OnUse functionality. Gems now cast spells on you when used and values are updated in client.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/611/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294139639,MDExOlB1bGxSZXF1ZXN0MTY2OTc3MzQ0,612,ACE.DatLoader IUnpackable progress,10608427,Mag-nus,closed,0,,,,,0,2018-02-03T19:47:36Z,2018-02-03T19:56:29Z,2018-02-03T19:56:29Z,MEMBER,,0,ACEmulator/ACE/pulls/612,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/612/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294141260,MDExOlB1bGxSZXF1ZXN0MTY2OTc4MzEz,613, ACE.DatLoader This removes the loc object,10608427,Mag-nus,closed,0,,,,,0,2018-02-03T20:11:57Z,2018-02-03T20:18:43Z,2018-02-03T20:18:43Z,MEMBER,,0,ACEmulator/ACE/pulls/613,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/613/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294155659,MDExOlB1bGxSZXF1ZXN0MTY2OTg2NjAx,614,ACE.DatLoader and ACE.DatLoader.Tests improvements,10608427,Mag-nus,closed,0,,,,,0,2018-02-03T23:51:42Z,2018-02-03T23:54:08Z,2018-02-03T23:54:08Z,MEMBER,,0,ACEmulator/ACE/pulls/614,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/614/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294164183,MDExOlB1bGxSZXF1ZXN0MTY2OTkxNjE5,615,ACE.DatLoader More IUnpackable progress,10608427,Mag-nus,closed,0,,,,,0,2018-02-04T02:38:28Z,2018-02-04T02:41:22Z,2018-02-04T02:41:22Z,MEMBER,,0,ACEmulator/ACE/pulls/615,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/615/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294211544,MDExOlB1bGxSZXF1ZXN0MTY3MDE4Njg5,616,ACE.DatLoader more IUnpackable refactoring,10608427,Mag-nus,closed,0,,,,,0,2018-02-04T16:52:29Z,2018-02-04T17:16:31Z,2018-02-04T17:16:31Z,MEMBER,,0,ACEmulator/ACE/pulls/616,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/616/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294216436,MDU6SXNzdWUyOTQyMTY0MzY=,617,ACE.DatLoader unsupported file types,10608427,Mag-nus,open,0,,,,,1,2018-02-04T17:59:57Z,2018-05-23T16:16:05Z,,MEMBER,,,,"We don't parse all the file types in the .dat files.

While the ones remaining likely aren't needed now, it might be a fun project for someone to take on, and may also prove useful for someone down the road.

You can see a list of incomplete file types here, in the UnpackPortalDatFiles_NoExceptions():
https://github.com/ACEmulator/ACE/blob/master/Source/ACE.DatLoader.Tests/DatTests.cs","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/617/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,issue
294231921,MDExOlB1bGxSZXF1ZXN0MTY3MDMwNjY3,618,Starter spells,19214857,Slushnas,closed,0,,,,,0,2018-02-04T21:21:30Z,2018-02-04T22:18:16Z,2018-02-04T22:18:16Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/618,This adds support for all of the starter spells during character creation. Visual Studio auto expanded JSON data in starterGear.json... I'm not sure if that is going to be a big deal or not.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/618/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294239324,MDExOlB1bGxSZXF1ZXN0MTY3MDM1MDM1,619,Some CharGen Fixes and Database lookup additions,11369233,LtRipley36706,closed,0,,,,,0,2018-02-04T22:53:32Z,2018-02-10T19:55:34Z,2018-02-05T17:31:33Z,MEMBER,,0,ACEmulator/ACE/pulls/619,"* Disable OlthoiPlay character creation for now. They're not really implemented yet and we'll need a lot more things implemented in regular players class before we can really get to these two object classes.
* Add Database lookup by WeenieClassDescription.
* Update Create and CI commands to support id or name search.
* Added catch for missing database objects in CharGen and IOU object creation for those missing.
 This fixes crashes on CharGen and prevents future missing items from database from causing same issue.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/619/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294417378,MDExOlB1bGxSZXF1ZXN0MTY3MTYyNDM5,620,ACE.DatLoader IUnpackable progress,10608427,Mag-nus,closed,0,,,,,0,2018-02-05T14:45:31Z,2018-02-05T14:48:02Z,2018-02-05T14:48:02Z,MEMBER,,0,ACEmulator/ACE/pulls/620,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/620/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294472008,MDExOlB1bGxSZXF1ZXN0MTY3MjAyOTkx,621,ACE.DatLoader IUnpackable work completed,10608427,Mag-nus,closed,0,,,,,0,2018-02-05T17:13:27Z,2018-02-05T17:17:58Z,2018-02-05T17:17:58Z,MEMBER,,0,ACEmulator/ACE/pulls/621,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/621/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294513564,MDExOlB1bGxSZXF1ZXN0MTY3MjMzMTY5,622,ACE.DatLoader bug fixes,10608427,Mag-nus,closed,0,,,,,0,2018-02-05T19:27:55Z,2018-02-05T19:34:13Z,2018-02-05T19:34:13Z,MEMBER,,0,ACEmulator/ACE/pulls/622,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/622/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294619696,MDExOlB1bGxSZXF1ZXN0MTY3MzExNjIw,623,ACE.DatLoader work,10608427,Mag-nus,closed,0,,,,,0,2018-02-06T03:23:38Z,2018-02-06T03:26:07Z,2018-02-06T03:26:07Z,MEMBER,,0,ACEmulator/ACE/pulls/623,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/623/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
294819381,MDExOlB1bGxSZXF1ZXN0MTY3NDU5MzUz,624,ACE.DatLoader DatDirectory reading cleaned up,10608427,Mag-nus,closed,0,,,,,0,2018-02-06T16:16:04Z,2018-02-06T16:18:39Z,2018-02-06T16:18:39Z,MEMBER,,0,ACEmulator/ACE/pulls/624,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/624/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
295168959,MDExOlB1bGxSZXF1ZXN0MTY3NzE1OTM5,625,ACE.DatLoader work,10608427,Mag-nus,closed,0,,,,,0,2018-02-07T14:59:23Z,2018-02-07T15:02:25Z,2018-02-07T15:02:25Z,MEMBER,,0,ACEmulator/ACE/pulls/625,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/625/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
295378460,MDExOlB1bGxSZXF1ZXN0MTY3ODcyNTU2,626,ACE.DatLoader improvements,10608427,Mag-nus,closed,0,,,,,0,2018-02-08T04:03:48Z,2018-02-08T04:14:51Z,2018-02-08T04:14:51Z,MEMBER,,0,ACEmulator/ACE/pulls/626,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/626/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
295521329,MDExOlB1bGxSZXF1ZXN0MTY3OTc4NjYx,627,few small things,10608427,Mag-nus,closed,0,,,,,0,2018-02-08T13:57:48Z,2018-02-08T14:00:14Z,2018-02-08T14:00:14Z,MEMBER,,0,ACEmulator/ACE/pulls/627,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/627/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
295530483,MDExOlB1bGxSZXF1ZXN0MTY3OTg1NTIw,628,ACE prj to ACE.Server rename,10608427,Mag-nus,closed,0,,,,,0,2018-02-08T14:24:25Z,2018-02-08T23:05:03Z,2018-02-08T23:05:03Z,MEMBER,,0,ACEmulator/ACE/pulls/628,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/628/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
295739710,MDExOlB1bGxSZXF1ZXN0MTY4MTQyODE0,629,All this does is cleanup a bunch of style issues that Resharper complains about,10608427,Mag-nus,closed,0,,,,,0,2018-02-09T03:01:52Z,2018-02-09T12:46:50Z,2018-02-09T12:46:50Z,MEMBER,,0,ACEmulator/ACE/pulls/629,"All of these things bug me every time I traverse through the src to new areas.

These things in most cases either:
Remove redundant code
Use less (and cleaner) code to accomplish the same tasks","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/629/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
295860010,MDU6SXNzdWUyOTU4NjAwMTA=,630,ACE.Entity.Position,10608427,Mag-nus,open,0,10608427,Mag-nus,,,0,2018-02-09T12:48:29Z,2019-04-01T17:58:06Z,,MEMBER,,,,"I think LandCell and Frame should be sub properties of ACE.Entity, similar to how it's done in ACE.DatLoader.

I haven't figured out the exact pattern yet, but this is something I'll be looking into.

It may end up that what we have now is ideal.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/630/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,issue
296066223,MDExOlB1bGxSZXF1ZXN0MTY4MzgxNzQz,631,Fix for issue #453: bad packet types crash server,4855786,spazmodica,closed,0,,,,,1,2018-02-10T02:40:31Z,2018-02-10T04:55:11Z,2018-02-10T04:55:11Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/631,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/631/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296095722,MDExOlB1bGxSZXF1ZXN0MTY4Mzk5MTA5,632,ACE.Database refactoring,10608427,Mag-nus,closed,0,,,,,0,2018-02-10T12:02:46Z,2018-02-10T12:05:13Z,2018-02-10T12:05:13Z,MEMBER,,0,ACEmulator/ACE/pulls/632,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/632/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296109051,MDExOlB1bGxSZXF1ZXN0MTY4NDA2NTAz,633,"WIP: Switch Database system to Entity Framework Core, DB First",10608427,Mag-nus,closed,0,,,,,1,2018-02-10T15:31:02Z,2018-02-14T18:06:26Z,2018-02-14T18:06:26Z,MEMBER,,0,ACEmulator/ACE/pulls/633,"This would simplify our DB model.
It should make it easier for new developers to get involved.
It would allow us to use async/await database queries.

Using the database first method, which this shows, we would simply design our tables in MySQL, then scaffold those changes into ACE. The scaffolding will completely rebuild/update the classes you see in ACE.Database.Models.

Scaffolding is done in visual studio, and is only needed if you make a database schema change.
Visual Studio -> View -> Other Windows -> Package Manager Console

Scaffold-DbContext ""server=localhost;port=3306;user=root;password=password;database=ace_auth"" -Project ACE.Database -OutputDir "".\Models\ace_auth"" -f Pomelo.EntityFrameworkCore.MySql

Scaffold-DbContext ""server=localhost;port=3306;user=root;password=password;database=ace_world"" -Project ACE.Database -OutputDir "".\Models\ace_world"" -f Pomelo.EntityFrameworkCore.MySql

Scaffold-DbContext ""server=localhost;port=3306;user=root;password=password;database=ace_shard"" -Project ACE.Database -OutputDir "".\Models\ace_shard"" -f Pomelo.EntityFrameworkCore.MySql

The scaffolding process will automatically create all of the POCOs. In the existing system, they need to be manually created in ACE.Entity with appropriate class and field attributes for mapping. Using Entity Framework needs none of that.

If you're wondering why I chose to use Pomelo instead of a MySql EF package from Oracle, the Oracle packages do not scaffold properly. Pomelo seems to be the go to framework for EF in .net core. I've used it before with success.

Lastly, I believe using Entity Framework will expose contributors to the project to patterns and practices that they're more likely to see out in the field.


I forgot to mention, EF does not support database views. We'll need to construct those objects in a different way. It's unlikely we even need views for performance at our scale.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/633/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296128384,MDExOlB1bGxSZXF1ZXN0MTY4NDE3ODUw,634,Renamed a couple GameMessageGroups (Queues),11369233,LtRipley36706,closed,0,,,,,0,2018-02-10T19:52:28Z,2018-02-10T19:55:32Z,2018-02-10T19:54:49Z,MEMBER,,0,ACEmulator/ACE/pulls/634,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/634/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296161559,MDU6SXNzdWUyOTYxNjE1NTk=,635,Purchasing a new skill throws Primary key violation inserting new skill row,4855786,spazmodica,closed,0,,,,,3,2018-02-11T05:10:47Z,2018-03-06T20:03:09Z,2018-03-06T20:03:09Z,CONTRIBUTOR,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [X] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
1. Create character
2. Grant experience enough to get enough skill points to purchase a new skill
3. Spend skill points on new skill
4. Wait a bit
5. Server throws exception

### The log given by the failure.
{MySql.Data.MySqlClient.MySqlException (0x80004005): Duplicate entry '1342177282-23' for key 'PRIMARY'
   at MySql.Data.MySqlClient.MySqlStream.ReadPacket()
   at MySql.Data.MySqlClient.NativeDriver.GetResult(Int32& affectedRow, Int64& insertedId)
   at MySql.Data.MySqlClient.Driver.NextResult(Int32 statementId, Boolean force)
   at MySql.Data.MySqlClient.MySqlDataReader.NextResult()
   at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior)
   at MySql.Data.MySqlClient.MySqlCommand.ExecuteNonQuery()
   at ACE.Database.Database.DatabaseTransaction.<>c__DisplayClass10_0.<Commit>b__0() in D:\Repos\spazmodica\ACE\Source\ACE.Database\Database.cs:line 200
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)}	MySql.Data.MySqlClient.MySqlException


### Desired functionality.
Purchasing new skill should not throw error.

### Mention any other details that might be useful.
Exception is in Task so does not crash server
Inserts vs Updates are determined by the IsDirty and HasEverBeenSavedToDatabase flags
Skills are all added to db upon creation, but purchasing does not set above flags correctly triggering error
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/635/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
296190357,MDExOlB1bGxSZXF1ZXN0MTY4NDUzNjk4,636,Fixing wave-export,8909245,gmriggs,closed,0,,,,,0,2018-02-11T13:33:43Z,2018-02-11T15:16:10Z,2018-02-11T15:16:10Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/636,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/636/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296192091,MDExOlB1bGxSZXF1ZXN0MTY4NDU0NzA0,637,StatusMessageType1 Descriptive Names for Issue #91,33205224,shawarma-golem,closed,0,,,,,1,2018-02-11T13:58:52Z,2018-02-11T19:53:23Z,2018-02-11T19:53:23Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/637,"- Added descriptive names to the first set of Enums for in-game messages to address Issue #91.
- These should allow developers to quickly identify the message represented.
- Many of these were kept to ~40 characters or less, following the nomenclature of the Enums named previously.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/637/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296484760,MDExOlB1bGxSZXF1ZXN0MTY4NjU5MDI5,638,StatusMessageType2 Descriptive Names for Issue #91,33205224,shawarma-golem,closed,0,,,,,0,2018-02-12T18:51:16Z,2018-02-12T18:56:56Z,2018-02-12T18:56:56Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/638,"(WIP)
- Added descriptive names to the 2nd set of in-game messages to address Issue #91.
- Enum_04CE is a duplicate of 001E. Other duplicates such as those on StatusMessageType1.cs will need to be looked at later on.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/638/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
296884200,MDExOlB1bGxSZXF1ZXN0MTY4OTU1MTAx,639,Implement CellLandblock geometry cache.,8909245,gmriggs,closed,0,,,,,0,2018-02-13T21:02:50Z,2018-02-14T04:56:18Z,2018-02-14T04:56:18Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/639,"This pull request is for the 2 Trello tasks:

https://trello.com/c/4ErxP7lc/90-implement-celllandblock-geometry-cache
https://trello.com/c/TxnqEnBH/85-celllandblockgetz-needs-rework

I'm still learning my way around the ACE project, so it's possible this code is not integrated in the correct location yet...

A LoadMesh() method has been added to Landblock.cs, which uses the Region file to determine the correct heights for the vertices. It loads the landblock grid as a triangle mesh, using a snippet of code from AC2D to ensure the cells are split between the correct vertices. I have verified in a few different locations that these splitters are being generated correctly, but I have no automated way of ensuring 100% accuracy across the entire map yet.

The GetZ() method has been implemented in Landblock.cs, which returns the correct Z-height information for any X/Y position on the map.

There are no unit tests yet, but here is a video of the landblock grid mesh visualization:

https://youtu.be/5yTTcMY-1Pw

The video quality was unfortunately degraded when uploaded to Youtube, but in the right corner is a 'current landblock height' stat that is updated every time the camera moves. This shows the information returned by GetZ().

Since this mesh data is to eventually be consumed by other classes, it can be tailored to provide whatever public API would be most useful to these other classes. For now it just has some of the basics, but more can be added as needed.


","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/639/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
297684246,MDExOlB1bGxSZXF1ZXN0MTY5NTUwMDI5,640,"Have Landblocks load all terrain, building, and generic obstacle data during start up and store it for use in the physics engine.",8909245,gmriggs,closed,0,,,,,0,2018-02-16T05:21:33Z,2018-02-16T06:53:36Z,2018-02-16T06:53:36Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/640,"This PR is for loading the landblock objects / obstacles, buildings, and landblock weenies stored in the database

A lot of the code from the last PR in Landblock.cs and Mesh.cs has been moved to a new LandblockMesh.cs class. Mesh.cs is now a base class for both the triangle-based landblock meshes, and the new ModelMesh.cs. Model meshes are polygonal based, and have most of their data stored in a StaticMesh object, which points to a global cache for efficiency.

https://www.youtube.com/watch?v=X4c7VHJ6DHE","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/640/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
297694186,MDExOlB1bGxSZXF1ZXN0MTY5NTU3MTk1,641,"Have Landblocks load all terrain, building, and generic obstacle data during start up and store it for use in the physics engine.",8909245,gmriggs,closed,0,,,,,1,2018-02-16T06:41:06Z,2018-02-16T14:56:52Z,2018-02-16T14:56:52Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/641,"This PR is for loading the landblock objects / obstacles, buildings, and landblock weenies stored in the database

A lot of the code from the last PR in Landblock.cs and Mesh.cs has been moved to a new LandblockMesh.cs class. Mesh.cs is now a base class for both the triangle-based landblock meshes, and the new ModelMesh.cs. Model meshes are polygonal based, and have most of their data stored in a StaticMesh object, which points to a global cache for efficiency.

https://www.youtube.com/watch?v=X4c7VHJ6DHE","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/641/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
298289014,MDExOlB1bGxSZXF1ZXN0MTY5OTcwNTc1,642,Have Landblocks load all scenery during start up and store it for use in the physics engine.,8909245,gmriggs,closed,0,,,,,0,2018-02-19T14:12:17Z,2018-02-19T16:26:44Z,2018-02-19T16:26:44Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/642,"Here is the first attempt at the landscape scenery generation. It's performing the same calculations that the original client does to build the scenery objects, although it's still not matched up perfectly yet.

The scenery is defined on a per-cell basis, which gets mapped through the region file to the actual scenery data. Instead of placing individual shrubs and trees on each cell though, the game uses something akin to perlin noise generation to move scenery objects around the grid in a non-uniform way.

https://imgur.com/a/wyQRt

Todo:

- It appears there is more scenery generated than the original game, even though the functions should be matched up exactly with the client. I will need to investigate more to find out what could be causing any differences.

- Scenery items should not spawn on roads or anywhere near other objects. The collision detection is currently just using a basic bounding box, but in acclient this is performed by the physics engine.

- Scenery items should also not be placed on steep terrain that can't be traversed by the player. This should ideally be done by storing normals for each triangle in the landscape mesh, and performing the slope checks based on that.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/642/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
298594469,MDExOlB1bGxSZXF1ZXN0MTcwMTkyNDY3,643,Initial data structures for physics and animation system,8909245,gmriggs,closed,0,,,,,0,2018-02-20T13:31:39Z,2018-02-20T13:38:35Z,2018-02-20T13:38:35Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/643,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/643/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299199387,MDExOlB1bGxSZXF1ZXN0MTcwNjQwOTkz,644,"Adding PartArray, PhysicsPart, Sphere, SphereTests",8909245,gmriggs,closed,0,,,,,0,2018-02-22T02:18:32Z,2018-02-23T00:03:59Z,2018-02-22T06:57:03Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/644,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/644/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299554051,MDExOlB1bGxSZXF1ZXN0MTcwOTAwOTEy,645,"Sphere refactoring, adding more SphereTests",8909245,gmriggs,closed,0,,,,,0,2018-02-23T00:05:17Z,2018-02-23T04:38:29Z,2018-02-23T02:06:21Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/645,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/645/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299602436,MDExOlB1bGxSZXF1ZXN0MTcwOTM1MzQw,646,"Finishing up Sphere, additional SphereTests",8909245,gmriggs,closed,0,,,,,0,2018-02-23T05:23:17Z,2018-02-23T19:13:01Z,2018-02-23T07:48:06Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/646,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/646/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299823294,MDExOlB1bGxSZXF1ZXN0MTcxMDk2MjAx,647,Adding SpherePath,8909245,gmriggs,closed,0,,,,,0,2018-02-23T19:26:47Z,2018-02-24T01:48:23Z,2018-02-23T20:15:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/647,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/647/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299899952,MDExOlB1bGxSZXF1ZXN0MTcxMTUzNzg5,648,Adding CylSphere,8909245,gmriggs,closed,0,,,,,0,2018-02-24T01:49:14Z,2018-02-24T09:05:08Z,2018-02-24T03:28:06Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/648,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/648/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299927173,MDExOlB1bGxSZXF1ZXN0MTcxMTcwNDQx,649,Adding PhysicsObj stubs,8909245,gmriggs,closed,0,,,,,0,2018-02-24T09:20:13Z,2018-02-24T20:40:56Z,2018-02-24T12:10:34Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/649,"There are a few different naming conventions for the methods used here - a mixture of standard CamelCase, with some underscores also thrown into the mix. I'm still digging into the rhyme and reason behind the various styles, but this is what was pulled from the original game.

For initial development and debugging purposes, it would much easier for me to match things up 100% to the original game, and then after everything has been completed it can be refactored and the naming conventions can be standardized to match the rest of the ACEmulator project.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/649/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299971310,MDExOlB1bGxSZXF1ZXN0MTcxMTk2NzE5,650,Adding initializers to PhysicsObj,8909245,gmriggs,closed,0,,,,,0,2018-02-24T20:44:51Z,2018-02-25T04:25:04Z,2018-02-24T20:52:45Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/650,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/650/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
299997097,MDExOlB1bGxSZXF1ZXN0MTcxMjEyNDM1,651,Adding PhysicsObj set_* methods,8909245,gmriggs,closed,0,,,,,0,2018-02-25T04:28:11Z,2018-02-25T20:00:40Z,2018-02-25T05:55:14Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/651,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/651/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300056569,MDExOlB1bGxSZXF1ZXN0MTcxMjQ4NTEy,652,Adding PhysicsObj Set* methods,8909245,gmriggs,closed,0,,,,,0,2018-02-25T20:09:28Z,2018-02-26T00:16:46Z,2018-02-25T23:17:22Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/652,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/652/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300112700,MDExOlB1bGxSZXF1ZXN0MTcxMjg0ODIz,653,"Adding PhysicsObj add, get, and calc methods",8909245,gmriggs,closed,0,,,,,0,2018-02-26T05:21:01Z,2018-02-26T08:32:42Z,2018-02-26T06:24:11Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/653,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/653/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300148788,MDExOlB1bGxSZXF1ZXN0MTcxMzEwMTcy,654,Adding PhysicsObj update methods,8909245,gmriggs,closed,0,,,,,0,2018-02-26T08:36:30Z,2018-02-26T20:46:07Z,2018-02-26T12:22:38Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/654,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/654/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300390353,MDExOlB1bGxSZXF1ZXN0MTcxNDg3NDI4,655,Adding methods to PhysicsObj,8909245,gmriggs,closed,0,,,,,0,2018-02-26T20:48:55Z,2018-02-27T04:22:54Z,2018-02-26T23:09:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/655,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/655/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300489885,MDExOlB1bGxSZXF1ZXN0MTcxNTYwOTg0,656,Adding methods to PhysicsObj,8909245,gmriggs,closed,0,,,,,0,2018-02-27T04:28:47Z,2018-02-27T19:54:56Z,2018-02-27T06:23:54Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/656,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/656/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300771227,MDExOlB1bGxSZXF1ZXN0MTcxNzY4MTIw,657,Adding more PhysicsObj methods,8909245,gmriggs,closed,0,,,,,0,2018-02-27T19:56:54Z,2018-02-28T02:10:53Z,2018-02-27T20:12:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/657,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/657/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
300865227,MDExOlB1bGxSZXF1ZXN0MTcxODM4NDQ4,658,Initial PhysicsObj implementation completed,8909245,gmriggs,closed,0,,,,,0,2018-02-28T02:15:33Z,2018-02-28T18:14:35Z,2018-02-28T02:45:39Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/658,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/658/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301128964,MDExOlB1bGxSZXF1ZXN0MTcyMDMxNzQ2,659,Adding PartArray methods,8909245,gmriggs,closed,0,,,,,0,2018-02-28T18:16:00Z,2018-02-28T22:24:26Z,2018-02-28T18:53:11Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/659,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/659/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301208204,MDExOlB1bGxSZXF1ZXN0MTcyMDkxODA3,660,Adding Setup and Transition,8909245,gmriggs,closed,0,,,,,0,2018-02-28T22:28:22Z,2018-03-01T02:11:03Z,2018-03-01T02:11:03Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/660,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/660/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301254793,MDExOlB1bGxSZXF1ZXN0MTcyMTI3MDU4,661, Adding Transition find and slide methods,8909245,gmriggs,closed,0,,,,,0,2018-03-01T02:20:31Z,2018-03-01T05:26:39Z,2018-03-01T03:45:47Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/661,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/661/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301283953,MDExOlB1bGxSZXF1ZXN0MTcyMTQ3ODQz,662,Finishing up Transition class implementation,8909245,gmriggs,closed,0,,,,,0,2018-03-01T05:37:29Z,2018-03-01T22:00:54Z,2018-03-01T06:15:02Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/662,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/662/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301553721,MDU6SXNzdWUzMDE1NTM3MjE=,663,Client does not send GameActionLoginComplete after Entering World,11369233,LtRipley36706,closed,0,,,,,2,2018-03-01T20:47:10Z,2018-08-17T21:38:15Z,2018-08-17T21:38:15Z,MEMBER,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [x] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
This does not happen with specifically reproducible steps for me but the sequence is to start the server and then connect with the client and enter world with a character. It will be apparent the issue is occurring if while portalling into the world you do not receive vital stats for Health/Stamina/Mana, other times vitals do send but you do not exit the purple bubble state.
### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->
The client no longer processes most messages it receives, sends nothing further outbound and network times out after about 2 minutes.
### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->
After character enters world and exits portal it sends GameActionLoginComplete 100% of the time,
### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
I suspect this issue is due to not fully handling the optional headers correctly in NetworkSession or something along those lines. Obviously the client is expecting something in either a certain order or a certain packet sequence is not being returned because the sending of the GameActionLoginComplete message is entirely automated from the client side and seemingly not triggered by a specific incoming event/message","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/663/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
301577083,MDExOlB1bGxSZXF1ZXN0MTcyMzY3MDY5,664,Adding Polygon,8909245,gmriggs,closed,0,,,,,0,2018-03-01T22:05:35Z,2018-03-01T23:28:37Z,2018-03-01T22:55:30Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/664,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/664/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301599624,MDExOlB1bGxSZXF1ZXN0MTcyMzg0MTI2,665,Adding BSP tree stubs,8909245,gmriggs,closed,0,,,,,0,2018-03-01T23:32:05Z,2018-03-02T04:51:49Z,2018-03-02T01:43:15Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/665,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/665/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301654061,MDExOlB1bGxSZXF1ZXN0MTcyNDIyOTQ3,666,Adding BSPTree methods,8909245,gmriggs,closed,0,,,,,0,2018-03-02T05:00:23Z,2018-03-02T07:50:11Z,2018-03-02T06:23:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/666,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/666/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301681462,MDExOlB1bGxSZXF1ZXN0MTcyNDQxMzI0,667,Adding BSPNode methods,8909245,gmriggs,closed,0,,,,,0,2018-03-02T07:52:51Z,2018-03-03T04:19:42Z,2018-03-02T19:32:01Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/667,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/667/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
301973505,MDExOlB1bGxSZXF1ZXN0MTcyNjUzMzQy,668,"Adding MovementManager methods, and MotionInterp stubs",8909245,gmriggs,closed,0,,,,,0,2018-03-03T06:25:43Z,2018-03-04T02:17:05Z,2018-03-04T02:13:24Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/668,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/668/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302050636,MDExOlB1bGxSZXF1ZXN0MTcyNjk4NDY1,669,Adding MoveToManager,8909245,gmriggs,closed,0,,,,,0,2018-03-04T02:18:53Z,2018-03-04T05:55:56Z,2018-03-04T04:39:51Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/669,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/669/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302060411,MDExOlB1bGxSZXF1ZXN0MTcyNzA0MzYx,670,"Adding PositionManager, InterpolationManager, ConstraintManager, and StickyManager",8909245,gmriggs,closed,0,,,,,0,2018-03-04T06:02:22Z,2018-03-04T11:24:18Z,2018-03-04T06:06:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/670,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/670/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302156072,MDExOlB1bGxSZXF1ZXN0MTcyNzYzMTY5,671,"Adding MotionTable, MotionTableManager",8909245,gmriggs,closed,0,,,,,0,2018-03-05T02:54:32Z,2018-03-05T05:07:36Z,2018-03-05T04:50:43Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/671,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/671/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302265563,MDExOlB1bGxSZXF1ZXN0MTcyODQxOTU5,672,Adding methods to animation system,8909245,gmriggs,closed,0,,,,,0,2018-03-05T11:31:26Z,2018-03-05T22:54:19Z,2018-03-05T13:04:54Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/672,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/672/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302498141,MDExOlB1bGxSZXF1ZXN0MTczMDExODYx,673,Adding Sequence methods,8909245,gmriggs,closed,0,,,,,0,2018-03-05T22:59:46Z,2018-03-06T09:15:56Z,2018-03-06T01:52:42Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/673,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/673/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302621046,MDExOlB1bGxSZXF1ZXN0MTczMDk4ODI0,674,Adding physics dependencies,8909245,gmriggs,closed,0,,,,,0,2018-03-06T09:20:43Z,2018-03-07T00:15:26Z,2018-03-06T09:24:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/674,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/674/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302651263,MDExOlB1bGxSZXF1ZXN0MTczMTIwODc5,675,"Entity Framework Core 2.0, Database First",11369233,LtRipley36706,closed,0,,,,,2,2018-03-06T10:47:54Z,2018-03-10T19:56:03Z,2018-03-06T19:58:44Z,MEMBER,,0,ACEmulator/ACE/pulls/675,"Just about ready for merging with master...

As a result of the rebase with current master the following error was introduced:

I noticed an issue with line 134 of Landblock.cs
`LandblockInfo = DatManager.CellDat.ReadFromDat<LandblockInfo>((uint)Id.Landblock << 16 | 0xFFFE);`

This line seems have an issue loading data from the dat file, I'm not 100% sure I know what the fileid its trying to load but seems what is there currently is incorrect.

`@telepoi Arwic` results in the following errors for example
```
2018-03-06 05:26:41,077 INFO : Unable to find object_id 3316318206 in Cell
2018-03-06 05:26:41,097 INFO : Unable to find object_id 3349807102 in Cell
2018-03-06 05:26:41,118 INFO : Unable to find object_id 3349741566 in Cell
2018-03-06 05:26:41,138 INFO : Unable to find object_id 3349872638 in Cell
2018-03-06 05:26:41,205 INFO : Unable to find object_id 3333095422 in Cell
```

These could be harmless and expected errors as maybe unlike CellLandblock files, there can be landblocks with LandblockInfo that don't load because they don't exist.. I manually tested 0xCE95FFFE and it loaded without error. Hopefully someone can confirm what is going on here before merging.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/675/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
302917847,MDExOlB1bGxSZXF1ZXN0MTczMzE5NTc1,676,"Adding LandCell, LostCell, ObjectMaint, Position",8909245,gmriggs,closed,0,,,,,0,2018-03-07T00:17:21Z,2018-03-07T09:27:39Z,2018-03-07T00:54:53Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/676,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/676/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
303002450,MDExOlB1bGxSZXF1ZXN0MTczMzgwMDE1,677,Fixing Issues with Skills and Vitals,11369233,LtRipley36706,closed,0,,,,,0,2018-03-07T08:16:57Z,2018-03-10T20:09:09Z,2018-03-07T12:04:25Z,MEMBER,,0,ACEmulator/ACE/pulls/677,"* Fixed Skills and Vital calculations when spending xp and potential sequence errors.
* Fixed issue with gitignore file. New files automatically are added to the project once again, YAY!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/677/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
303025052,MDExOlB1bGxSZXF1ZXN0MTczMzk2Mzkz,678,Preparing initial physics system for testing environment,8909245,gmriggs,closed,0,,,,,0,2018-03-07T09:34:19Z,2018-03-11T08:39:27Z,2018-03-07T12:02:39Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/678,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/678/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
304128017,MDExOlB1bGxSZXF1ZXN0MTc0MjAyOTM3,679,1000th Commit to ACE! Morph command for Admins/Liveops,11369233,LtRipley36706,closed,0,,,,,1,2018-03-11T03:53:00Z,2018-03-14T08:34:36Z,2018-03-11T12:38:36Z,MEMBER,,0,ACEmulator/ACE/pulls/679,"* Adding /morph command for admins.
  - The command was used to facilitate live ops by developers to play out story elements such as Martine wreaking havoc upon the lands.
  - For some samples, you can try `martinelo`, `baelzharon`, `asheronlo`, `ayanbaqurdrunkenscholar`, `rabbitwhite`, `monougapaul`, or even `golemmegamagma`.
  - Protip: If you do morph into a golem, press the b key ;)

The command usage is: `/morph [wcid or weenieClassName here]`
If successful, you will be logged out and when you enter the game again you'll be that creature","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/679/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
304141773,MDExOlB1bGxSZXF1ZXN0MTc0MjExMTc1,680,Physics testing adjustments,8909245,gmriggs,closed,0,,,,,0,2018-03-11T08:58:14Z,2018-03-11T23:29:49Z,2018-03-11T12:36:42Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/680,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/680/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
304189091,MDExOlB1bGxSZXF1ZXN0MTc0MjM5NTIz,681,Changing IID from INT to UINT,11369233,LtRipley36706,closed,0,,,,,0,2018-03-11T20:06:28Z,2018-03-14T08:34:34Z,2018-03-11T22:39:46Z,MEMBER,,0,ACEmulator/ACE/pulls/681,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/681/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
304464539,MDExOlB1bGxSZXF1ZXN0MTc0NDM3OTAy,682,Added batch file to start the server faster,37258378,roidzilla,closed,0,,,,,0,2018-03-12T17:18:55Z,2018-03-12T17:59:05Z,2018-03-12T17:59:05Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/682,Also updated Readme on how to start the server after NET core changes.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/682/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
304634358,MDU6SXNzdWUzMDQ2MzQzNTg=,683,"Using Thwarg-Launcher, Client is Killed when idle for over two minutes",11369233,LtRipley36706,closed,0,,,,,0,2018-03-13T05:38:24Z,2018-03-25T19:10:40Z,2018-03-25T19:10:40Z,MEMBER,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ x ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
Using Thwarg-Launcher, connect to ACE and then idle. Ideally lose focus of the window so that no protocol traffic is sent from the client. Client will be killed by launcher.
### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->
N/A
### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->
Implement a heartbeat or tracker and send some type of message, any type found in the protocol doc will do, when nothing has been sent by the server in 60 seconds to a session connected, but idle. This message should probably be something simple as to not effect client performance.
### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/683/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
304634741,MDU6SXNzdWUzMDQ2MzQ3NDE=,684,"When Thwarg-Launcher auto kills a client, Character is not removed from game world properly",11369233,LtRipley36706,closed,0,,,,,2,2018-03-13T05:41:03Z,2018-12-14T18:50:08Z,2018-12-14T18:50:07Z,MEMBER,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ x ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
See #683 to easily create this issue. Let the launcher time out a client and it will autoclose the client setting up this state
### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->
N/A
### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->
Character should logout as it does when other disconnects occur
### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/684/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
304836769,MDU6SXNzdWUzMDQ4MzY3Njk=,685,Server crashes when double clicking a chess table,20893344,crinkleskin,closed,0,,,,,0,2018-03-13T16:22:15Z,2018-03-14T10:34:11Z,2018-03-14T10:34:11Z,NONE,,,,"The server should not hard crash when clicking on a chess table.

It should return a not implemented error instead without crashing the entire thing.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/685/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
304878806,MDExOlB1bGxSZXF1ZXN0MTc0NzQ2NTgw,686,Add New Tables to Shard Database for Biota and proper Character Title Support,11369233,LtRipley36706,closed,0,,,,,0,2018-03-13T18:13:16Z,2018-03-14T08:34:33Z,2018-03-13T23:11:56Z,MEMBER,,0,ACEmulator/ACE/pulls/686,"Tables are for:
 * Title Registry
 * FillComp Registry
 * Enchantment Registry","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/686/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
305421818,MDExOlB1bGxSZXF1ZXN0MTc1MTUzMDgx,687,"Physics testing, player moving across landscape at correct speeds",8909245,gmriggs,closed,0,,,,,0,2018-03-15T05:36:56Z,2018-03-18T07:03:33Z,2018-03-15T07:34:02Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/687,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/687/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
305781080,MDExOlB1bGxSZXF1ZXN0MTc1NDI1MjMy,688,Smite + Corpse Spawning,11369233,LtRipley36706,closed,0,,,,,0,2018-03-16T02:23:00Z,2018-03-26T01:48:48Z,2018-03-16T08:29:35Z,MEMBER,,0,ACEmulator/ACE/pulls/688,"with assistance of @gmriggs and @OptimShi 
* Added Corpse class and basic framework for spawning a corpse at death of creature.
  * use /smite command when you have a creature selected.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/688/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
305970380,MDExOlB1bGxSZXF1ZXN0MTc1NTY1MjYz,689,Fix for allegiance update done message.,19214857,Slushnas,closed,0,,,,,0,2018-03-16T15:24:07Z,2018-03-16T16:03:55Z,2018-03-16T16:03:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/689,I noticed some parsing issues with this message when investigating the purple bubbles issue. This commit should fix it. I don't know if this will solve the purple bubble issue since I haven't been able to reproduce it with the current code.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/689/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
306218945,MDExOlB1bGxSZXF1ZXN0MTc1NzM4NjQ0,690,collision detection prereqs,8909245,gmriggs,closed,0,,,,,0,2018-03-18T07:18:52Z,2018-03-20T05:29:51Z,2018-03-18T08:11:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/690,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/690/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
306272888,MDU6SXNzdWUzMDYyNzI4ODg=,691,ACE doesn't restore the clients UI window positions,10608427,Mag-nus,closed,0,,,,,1,2018-03-18T19:21:27Z,2018-07-07T01:25:13Z,2018-07-07T01:25:13Z,MEMBER,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [x ] feature request
```

### Repro steps.
Move some windows around, log out, log back in. You'll notice your window positions aren't restored to your new locations.

### Desired functionality.
Server should save/restore a users desired window positions/sizes.

### Mention any other details that might be useful.
The restore happens in GameEventPlayerDescription.cs
            /*if ((optionFlags & DescriptionOptionFlag.WindowLayout) != 0)
            {
            }*/

I don't recall where the save happens, but you might need to modify that as well.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/691/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
306328094,MDExOlB1bGxSZXF1ZXN0MTc1ODAxMDk2,692,Added NameFilter to Character Creation,32439087,CrimsonMage,closed,0,,,,,3,2018-03-19T04:12:09Z,2018-04-08T00:01:30Z,2018-04-08T00:01:29Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/692,"Created TabooTable.json (Easily altered by users) to house the names of the filter list.

BannedWords.cs to handle the data of the json for the words

CharacterHandler.cs now includes a NameBanned message that will appear when someone tries to use a name from the list.

--Updated Changelog","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/692/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
306737412,MDExOlB1bGxSZXF1ZXN0MTc2MDk0OTIy,693,Basic collisions detected and exported,8909245,gmriggs,closed,0,,,,,0,2018-03-20T05:51:20Z,2018-03-21T23:41:29Z,2018-03-20T06:45:41Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/693,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/693/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
307545321,MDExOlB1bGxSZXF1ZXN0MTc2NzA0MDY3,694,Portal collisions from physics engine,8909245,gmriggs,closed,0,,,,,0,2018-03-22T08:23:20Z,2018-03-24T07:12:54Z,2018-03-23T01:54:44Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/694,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/694/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308227413,MDExOlB1bGxSZXF1ZXN0MTc3MjE5NDE0,695,Adding Weenie Error Messages,19214857,Slushnas,closed,0,,,,,0,2018-03-24T04:09:00Z,2018-03-24T04:25:01Z,2018-03-24T04:25:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/695,Added the error enum and changed a few messages to support its usage.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/695/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308236036,MDExOlB1bGxSZXF1ZXN0MTc3MjI0Nzk0,696,Fixing monsters despawning in dungeons,8909245,gmriggs,closed,0,,,,,0,2018-03-24T07:16:15Z,2018-03-24T21:40:20Z,2018-03-24T12:03:35Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/696,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/696/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308273826,MDExOlB1bGxSZXF1ZXN0MTc3MjQzOTU2,697,Enable MinMax Portal level enforcement,10137,ghost,closed,0,,,,,0,2018-03-24T15:52:54Z,2018-03-24T22:32:53Z,2018-03-24T18:36:27Z,NONE,,0,ACEmulator/ACE/pulls/697,Changes the variables used for Portal level enforcement to those that are set in the database and retrieves and sets their values on Portal creation.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/697/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308285006,MDExOlB1bGxSZXF1ZXN0MTc3MjUwMzgw,698,Init All The Physics!,11369233,LtRipley36706,closed,0,,,,,0,2018-03-24T18:02:51Z,2018-03-26T01:48:47Z,2018-03-25T01:45:09Z,MEMBER,,0,ACEmulator/ACE/pulls/698,This turns on physics for every WorldObject in game.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/698/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308301540,MDExOlB1bGxSZXF1ZXN0MTc3MjYwNTE4,699,Fixing object visibility across multiple landblocks,8909245,gmriggs,closed,0,,,,,0,2018-03-24T21:46:22Z,2018-03-25T04:11:22Z,2018-03-25T01:44:29Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/699,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/699/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308317167,MDExOlB1bGxSZXF1ZXN0MTc3MjY5NzQ1,700,Changes to Emote tables in preparation for incoming data,11369233,LtRipley36706,closed,0,,,,,0,2018-03-25T02:46:43Z,2018-03-26T01:48:46Z,2018-03-25T04:04:56Z,MEMBER,,0,ACEmulator/ACE/pulls/700,New ACE-World-16PY release imminent ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/700/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308321134,MDExOlB1bGxSZXF1ZXN0MTc3MjcyMTU0,701,Swanky portals,8909245,gmriggs,closed,0,,,,,0,2018-03-25T04:21:28Z,2018-03-27T01:32:11Z,2018-03-25T04:33:25Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/701,"Fixing the portals in Hotel Swank
https://i.imgur.com/sRCnXrU.jpg -- Keith#3971","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/701/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308376844,MDExOlB1bGxSZXF1ZXN0MTc3MzA1OTk3,702,Item decay,4855786,spazmodica,closed,0,,,,,1,2018-03-25T19:16:53Z,2018-03-26T18:10:57Z,2018-03-26T18:10:57Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/702,Items dropped on ground will now decay in 2.5 minutes.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/702/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308812859,MDExOlB1bGxSZXF1ZXN0MTc3NjI1MDg5,703,Renaming status message type enums.,19214857,Slushnas,closed,0,,,,,0,2018-03-27T03:51:39Z,2018-03-27T04:34:00Z,2018-03-27T04:33:59Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/703,This just renames the enums and message handlers to WeenieError and WeenieErrorWithString which are the naming conventions that were used by the client. Enum value fix ups are the next step.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/703/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
308815461,MDExOlB1bGxSZXF1ZXN0MTc3NjI2OTI2,704,Lets make some magic :: WIP,10137,ghost,closed,0,,,,,0,2018-03-27T04:08:52Z,2018-03-27T19:16:30Z,2018-03-27T19:16:08Z,NONE,,0,ACEmulator/ACE/pulls/704,"Implements the two magic casting messages from the client to server and a basic default response - Still not ready yet.  I will be closing this PR is favor of something a little bit different, ie. move the HandleAction methods into a partial Player class.  WorldObject_Magic will have a set of CreateSpell methods that should work for both creature and player.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/704/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
309037757,MDExOlB1bGxSZXF1ZXN0MTc3NzkyNDA3,705, Environment collision detection with PhysicsBSP,8909245,gmriggs,closed,0,,,,,0,2018-03-27T16:14:33Z,2018-03-29T16:30:42Z,2018-03-27T17:54:24Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/705,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/705/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
309100984,MDExOlB1bGxSZXF1ZXN0MTc3ODQwMzM1,706,Lets Make Some Magic,10137,ghost,closed,0,,,,,0,2018-03-27T19:23:52Z,2018-03-28T00:32:06Z,2018-03-27T23:27:05Z,NONE,,0,ACEmulator/ACE/pulls/706,"Implements the two magic casting GameAction messages from the client to server, with handlers in the Player class, and a spell casting method in the WorldObject class,, with two basic initial results.  All functions dealing the with player, such as movement, would stay within the Player class handler.  Any functions dealing with creating spells and their effects should stay within the CreateSpell method.  CreateSpell should remain generic enough that is can server for both Creature AI casting and player casting.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/706/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
309402390,MDExOlB1bGxSZXF1ZXN0MTc4MDY1NTQ1,707,Lets Make Some Magic Part 2,10137,ghost,closed,0,,,,,0,2018-03-28T14:52:37Z,2018-03-31T15:52:35Z,2018-03-28T20:15:58Z,NONE,,0,ACEmulator/ACE/pulls/707,"This code submission is primarily to prevent a server crash, when an inventory item is selected as the target.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/707/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
309665495,MDExOlB1bGxSZXF1ZXN0MTc4MjYwNjM0,708,Spellcasting Visuals,10137,ghost,closed,0,,,,,0,2018-03-29T08:34:13Z,2018-03-31T15:51:52Z,2018-03-29T22:54:30Z,NONE,,0,ACEmulator/ACE/pulls/708,"Creature, Life, and Item magic are included; no target verification implemented, yet","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/708/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
309828866,MDExOlB1bGxSZXF1ZXN0MTc4Mzg0NTg2,709,Sliding object fixes,8909245,gmriggs,closed,0,,,,,0,2018-03-29T16:52:13Z,2018-03-30T23:01:11Z,2018-03-29T22:54:47Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/709,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/709/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310098264,MDExOlB1bGxSZXF1ZXN0MTc4NTg0MDU4,710,Casting reorg and busy state,10137,ghost,closed,0,,,,,0,2018-03-30T15:45:02Z,2018-03-31T15:51:56Z,2018-03-30T18:49:50Z,NONE,,0,ACEmulator/ACE/pulls/710,Reorganize spell casting code and implement a busy casting state.  Divided casting methods into separate Player and Creature casting methods.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/710/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310191569,MDExOlB1bGxSZXF1ZXN0MTc4NjUyNTMx,711,Objects navigating dungeons and sliding along walls/obstacles,8909245,gmriggs,closed,0,,,,,0,2018-03-30T23:30:40Z,2018-03-31T10:30:36Z,2018-03-31T07:15:06Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/711,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/711/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310221998,MDExOlB1bGxSZXF1ZXN0MTc4NjcxNzA1,712,Error message fix ups etc.,19214857,Slushnas,closed,0,,,,,0,2018-03-31T07:59:10Z,2018-03-31T13:01:59Z,2018-03-31T13:01:59Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/712,"The error message enums should be complete and correct now. I also made a few changes to the Door and Key objects to fix sounds and use the correct error messages that were in retail pcaps.

We may want to add more states to doors like motionStateOpening and motionStateClosing. The animation appears to be close to 1.5 seconds long for opening/closing. If we had opening/closing states we could prevent the player from spamming use on the door while it is performing an animation.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/712/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310231423,MDExOlB1bGxSZXF1ZXN0MTc4Njc2ODk5,713,Adding rotation to scenery objects,8909245,gmriggs,closed,0,,,,,0,2018-03-31T10:40:50Z,2018-03-31T18:29:15Z,2018-03-31T13:02:28Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/713,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/713/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310286424,MDExOlB1bGxSZXF1ZXN0MTc4NzA4OTI4,714,Rebase SQL scripts,11369233,LtRipley36706,closed,0,,,,,0,2018-04-01T02:00:56Z,2018-04-21T23:18:27Z,2018-04-01T02:05:51Z,MEMBER,,0,ACEmulator/ACE/pulls/714,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/714/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310294878,MDExOlB1bGxSZXF1ZXN0MTc4NzEzNDMy,715,Magic Level 3,10137,ghost,closed,0,,,,,0,2018-04-01T05:01:27Z,2018-04-07T04:13:31Z,2018-04-01T18:55:50Z,NONE,,0,ACEmulator/ACE/pulls/715,"Turning to target, range checking, switched busyCasting state bool to a more generic busyState status, and spell damage for two Life Magic spells","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/715/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310443232,MDExOlB1bGxSZXF1ZXN0MTc4ODA4Mjkx,716, Adding Spell Table to World DB,11369233,LtRipley36706,closed,0,,,,,0,2018-04-02T09:46:23Z,2018-04-21T23:18:26Z,2018-04-02T09:55:36Z,MEMBER,,0,ACEmulator/ACE/pulls/716,This adds database support for spells in the game. New world release to follow shortly with complete spell data exported from GDL cache.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/716/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310635270,MDExOlB1bGxSZXF1ZXN0MTc4OTUxMzc1,717,"Smooth sliding between objects, fixed an issue getting stuck during sliding",8909245,gmriggs,closed,0,,,,,0,2018-04-02T22:43:22Z,2018-04-03T22:51:30Z,2018-04-03T00:49:37Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/717,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/717/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
310644605,MDU6SXNzdWUzMTA2NDQ2MDU=,718,ACE.Server needs to expose an API for diagnostics and other information,10608427,Mag-nus,open,0,8909245,gmriggs,,,7,2018-04-02T23:33:08Z,2021-10-02T16:41:40Z,,MEMBER,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [ X] feature request
```

### Desired functionality.
The ACE project is growing rapidly and we need the ability to expose diagnostic information from ACE.Server for 3rd party tools to access.

Such data exposed might be:
Number of players connected
Player locations
Landblock states
Chat
Physics Information
Debugging

We used to have an ACE.Diagnostics project that collected information from ACE.Server, but that was removed because the implementation required ACE.Server to have a direct reference to the ACE.Diagnostics project.

ACE.Server should not require a direct reference to the 3rd party tools collecting the information.

Perhaps an ACE.Diagnostics library is created that is used for the API.

We need someone to help us model the base implementation so that we can build on it as the project grows.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/718/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,issue
310960494,MDU6SXNzdWUzMTA5NjA0OTQ=,719,/grantxp,38050842,Warloxx01,closed,0,10608427,Mag-nus,,,1,2018-04-03T19:08:41Z,2018-04-03T23:25:13Z,2018-04-03T23:25:13Z,NONE,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
``
- [ x ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->

login (new or old) character look at the needed XP to gain the next level, type in ""/grantxp (amount needed - 1 ) and hit enter. the character will level and then type /grantxp 1 and they level again.

### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->

### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/719/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
311031204,MDExOlB1bGxSZXF1ZXN0MTc5MjQ0NzEy,720,"CylSphere testing, scenery collisions/sliding",8909245,gmriggs,closed,0,,,,,0,2018-04-03T23:18:13Z,2018-04-04T22:43:09Z,2018-04-04T00:42:51Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/720,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/720/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
311420178,MDExOlB1bGxSZXF1ZXN0MTc5NTM0Nzc3,721,"Transitions, collision detection, and sliding with building exteriors / interiors",8909245,gmriggs,closed,0,,,,,0,2018-04-04T23:02:33Z,2018-04-05T00:03:37Z,2018-04-05T00:03:37Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/721,Initial physics engine coding and testing completed :),"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/721/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
311862718,MDExOlB1bGxSZXF1ZXN0MTc5ODY1MzQ3,722,Adding EmoteManager,8909245,gmriggs,closed,0,,,,,0,2018-04-06T06:38:39Z,2018-04-07T13:25:39Z,2018-04-06T12:10:21Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/722,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/722/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312035447,MDExOlB1bGxSZXF1ZXN0MTc5OTkzMTYz,723,Move busy state flag from Creature to WO,10137,ghost,closed,0,,,,,0,2018-04-06T16:16:17Z,2018-04-07T04:13:33Z,2018-04-07T02:02:48Z,NONE,,0,ACEmulator/ACE/pulls/723,Switch Busy state flag from Creature level to WO level that was created in a recent pull request.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/723/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312208240,MDExOlB1bGxSZXF1ZXN0MTgwMTA2NDE2,724,Adding creature idle animations/sounds,8909245,gmriggs,closed,0,,,,,0,2018-04-07T13:48:15Z,2018-04-08T00:07:43Z,2018-04-08T00:07:43Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/724,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/724/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312349755,MDExOlB1bGxSZXF1ZXN0MTgwMTg1MDIw,725,Implemented StatMod World DB usage,10137,ghost,closed,0,,,,,0,2018-04-08T22:48:07Z,2018-04-09T03:44:13Z,2018-04-08T23:02:33Z,NONE,,0,ACEmulator/ACE/pulls/725,"All of the Boost type Life spells and the Transfer spells damage portion implemented using the data from the StatMod World DB entries; applying the Transfer spell's drain amount to caster and vital transfer spells still to be implemented.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/725/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312392900,MDExOlB1bGxSZXF1ZXN0MTgwMjEwNjAx,726,Basic melee combat,8909245,gmriggs,closed,0,,,,,0,2018-04-09T04:53:09Z,2018-04-09T13:03:44Z,2018-04-09T05:52:06Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/726,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/726/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312411417,MDExOlB1bGxSZXF1ZXN0MTgwMjIyNzU3,727,Add New Database Tables support,11369233,LtRipley36706,closed,0,,,,,0,2018-04-09T06:39:25Z,2018-04-21T23:18:24Z,2018-04-09T06:48:10Z,MEMBER,,0,ACEmulator/ACE/pulls/727,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/727/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312591663,MDExOlB1bGxSZXF1ZXN0MTgwMzU1OTMw,728,Adding per-damage type combat messages,8909245,gmriggs,closed,0,,,,,0,2018-04-09T16:05:50Z,2018-04-10T04:22:21Z,2018-04-09T18:25:33Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/728,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/728/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
312686324,MDExOlB1bGxSZXF1ZXN0MTgwNDI2NTU4,729,Transfer spells working,10137,ghost,closed,0,,,,,0,2018-04-09T21:02:10Z,2018-04-13T07:23:34Z,2018-04-10T05:25:40Z,NONE,,0,ACEmulator/ACE/pulls/729,Next on the TODO list are the Life Bolt spells.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/729/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
313116542,MDExOlB1bGxSZXF1ZXN0MTgwNzQ4ODM3,730,"Adding auto-attack, critical deaths, per-weapon swing animations, damage source tracking, and attack height / powerbar",8909245,gmriggs,closed,0,,,,,0,2018-04-10T22:52:14Z,2018-04-11T05:41:23Z,2018-04-10T23:20:45Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/730,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/730/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
313181629,MDExOlB1bGxSZXF1ZXN0MTgwNzk2MjAx,731,"Adding monster pain sounds, and splatter effects",8909245,gmriggs,closed,0,,,,,0,2018-04-11T05:48:17Z,2018-04-11T06:09:26Z,2018-04-11T06:09:26Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/731,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/731/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
313197679,MDExOlB1bGxSZXF1ZXN0MTgwODA3ODY2,732,Fixing sound events,8909245,gmriggs,closed,0,,,,,0,2018-04-11T07:05:48Z,2018-04-12T02:47:57Z,2018-04-11T15:03:03Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/732,Thanks to @Slushnas for the tremendous help with the recent PRs! =),"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/732/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
313440045,MDExOlB1bGxSZXF1ZXN0MTgwOTkxNjMw,733,Granting XP for killing with Magic,10137,ghost,closed,0,,,,,0,2018-04-11T18:35:59Z,2018-04-13T07:24:23Z,2018-04-11T19:21:09Z,NONE,,0,ACEmulator/ACE/pulls/733,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/733/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
313999052,MDExOlB1bGxSZXF1ZXN0MTgxNDA4MTg2,734,Magic :: Lesson 7,10137,ghost,closed,0,,,,,0,2018-04-13T07:36:58Z,2018-04-13T13:53:43Z,2018-04-13T12:46:08Z,NONE,,0,ACEmulator/ACE/pulls/734,Beginnings of casting projectile spells,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/734/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314039578,MDExOlB1bGxSZXF1ZXN0MTgxNDM3MDQ3,735,"Adding powerbar damage scaling, weapon skill vs. defense skill evasion, per-weapon damage, attribute damage scaling, per-body part armor/resistance scaling",8909245,gmriggs,closed,0,,,,,0,2018-04-13T09:44:27Z,2018-04-13T21:59:15Z,2018-04-13T12:47:00Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/735,Fixed a bug where spamming the attack button would trigger multiple monster death animations,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/735/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314265101,MDExOlB1bGxSZXF1ZXN0MTgxNjA2OTk0,736,Fixing unarmed combat,8909245,gmriggs,closed,0,,,,,0,2018-04-13T22:12:57Z,2018-04-14T00:48:57Z,2018-04-14T00:48:56Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/736,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/736/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314294979,MDExOlB1bGxSZXF1ZXN0MTgxNjI3OTY4,737,Magic :: Lesson 8,10137,ghost,closed,0,,,,,0,2018-04-14T03:23:59Z,2018-04-14T15:36:15Z,2018-04-14T11:10:47Z,NONE,,0,ACEmulator/ACE/pulls/737,Life and War projectiles now apply damage and XP,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/737/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314342233,MDExOlB1bGxSZXF1ZXN0MTgxNjU1NTc4,738,Magic :: Lesson 8.5,10137,ghost,closed,0,,,,,0,2018-04-14T16:30:15Z,2018-04-14T20:43:13Z,2018-04-14T17:19:09Z,NONE,,0,ACEmulator/ACE/pulls/738,"- Rename Resistance enum to ResistanceType to match other enums
- Rename Creature.GetResistance() to Creature.GetNaturalResistance() to differentiate between natural resistances with Armor resistance ratings
- Add Natural resistance scaling to War shell damage","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/738/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314373283,MDExOlB1bGxSZXF1ZXN0MTgxNjczNjI5,739,Magic :: Lesson 8.7,10137,ghost,closed,0,,,,,0,2018-04-15T00:19:43Z,2018-04-15T02:12:43Z,2018-04-15T00:40:10Z,NONE,,0,ACEmulator/ACE/pulls/739,"- Moved generic navigation functions from Player_Melee to a new Creature_Nagivation
- Adjusted Player spell cast timings to account for both self cast and short TurnTo()
- Added a temporary method for corpse cleanup, until more generalized cleanup management is implemented","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/739/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314376938,MDExOlB1bGxSZXF1ZXN0MTgxNjc1Njk4,740,Limit Portal Spam from multiple collisions,10137,ghost,closed,0,,,,,0,2018-04-15T01:34:05Z,2018-04-15T02:12:41Z,2018-04-15T01:56:28Z,NONE,,0,ACEmulator/ACE/pulls/740,- Use the Player.Teleporting flag to prevent Portal.HandleActionOnCollide() from doing any actions multiple times because of repeated collisions,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/740/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314383794,MDExOlB1bGxSZXF1ZXN0MTgxNjc5Njkw,741,Encounters,11369233,LtRipley36706,closed,0,,,,,0,2018-04-15T04:06:47Z,2018-04-21T23:18:23Z,2018-04-15T05:00:35Z,MEMBER,,0,ACEmulator/ACE/pulls/741,"This adds the landscape generator spawning to ACEmulator. Latest world database is required for the generators to spawn.

With much appreciation to Pea for the cache data and GDL for the initial coding. Thanks to @gmriggs for the assistance in understanding the original byte arrays and structuring them in to objects I could work with easier","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/741/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314391768,MDExOlB1bGxSZXF1ZXN0MTgxNjg0NTcy,742,Magic :: Lessen 9 :: Streaking,10137,ghost,closed,0,,,,,0,2018-04-15T07:05:20Z,2018-04-24T14:08:40Z,2018-04-15T12:49:33Z,NONE,,0,ACEmulator/ACE/pulls/742,"- Add fast casting
- Increase projectile velocity for Streak war spells","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/742/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314420385,MDExOlB1bGxSZXF1ZXN0MTgxNzAxODU1,743,Adding vitae and enchantment registry,8909245,gmriggs,closed,0,,,,,0,2018-04-15T14:28:46Z,2018-04-15T15:06:50Z,2018-04-15T15:06:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/743,Thanks to @Slushnas and everyone on the ACE team for helping with this latest update :),"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/743/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314423449,MDU6SXNzdWUzMTQ0MjM0NDk=,744,weapon movement between hands,3317737,fartwhif,closed,0,8909245,gmriggs,,,2,2018-04-15T15:06:53Z,2019-01-23T13:58:55Z,2019-01-23T13:58:55Z,COLLABORATOR,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [ X ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
1. equip swords in both hands.
2. try to drag a sword from one hand to the other.
### The log given by the failure.

sometimes:
ERROR: Player_Inventory PickupItemWithNetworking item == null

sometimes: 
ERROR: Player_Inventory PickupItemWithNetworking picking up items from world containers side pack WIP

result:  with either log message, the item move/use state is permanently active for the remainder of the session, all equipment changes are denied ""You can only move or use one item at a time"" and SHIFT+ESC doesn't work.  Relaunch of the client is necessary to synchronize.

### Desired functionality.
the weapons are swapped

### Mention any other details that might be useful.
/weapons command to generate the items
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/744/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
314705692,MDExOlB1bGxSZXF1ZXN0MTgxOTAzNDMw,745,Adding healing kit usage,8909245,gmriggs,closed,0,,,,,0,2018-04-16T15:25:59Z,2018-04-16T18:41:44Z,2018-04-16T18:41:44Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/745,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/745/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314873070,MDExOlB1bGxSZXF1ZXN0MTgyMDI5MTYw,746,Fixing landblock adjacency loading,8909245,gmriggs,closed,0,,,,,0,2018-04-17T01:32:35Z,2018-04-17T03:12:04Z,2018-04-17T03:12:04Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/746,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/746/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
314890288,MDExOlB1bGxSZXF1ZXN0MTgyMDQxMDA5,747,Fixing vitae % display bug,8909245,gmriggs,closed,0,,,,,0,2018-04-17T03:17:11Z,2018-04-17T10:46:41Z,2018-04-17T08:42:57Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/747,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/747/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
315011433,MDExOlB1bGxSZXF1ZXN0MTgyMTI5ODk0,748,Updating EnchantmentManager for handling all spells,8909245,gmriggs,closed,0,,,,,0,2018-04-17T11:06:38Z,2018-04-17T12:01:14Z,2018-04-17T12:01:14Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/748,"Thanks again to @Slushnas for helping with this patch!

- EnchantmentManager now supports adding/updating/removing all spells
- EnchantmentManager.HeartBeat() has been added, which maintains the spell duration in the database
- Gems added to enchantment registry for PoC

- Player health/stamina/mana updated on death","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/748/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
315627863,MDExOlB1bGxSZXF1ZXN0MTgyNTkxNzI3,749,Adding creature enchantment buffs/debuffs,8909245,gmriggs,closed,0,,,,,0,2018-04-18T20:20:06Z,2018-04-18T22:25:08Z,2018-04-18T22:25:08Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/749,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/749/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
315757054,MDExOlB1bGxSZXF1ZXN0MTgyNjg3NjAw,750,Adding shortcut manager,8909245,gmriggs,closed,0,,,,,0,2018-04-19T07:25:47Z,2018-04-19T07:30:18Z,2018-04-19T07:30:18Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/750,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/750/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
316061471,MDExOlB1bGxSZXF1ZXN0MTgyOTE0Mzgz,751,Adding life magic buffs / debuffs,8909245,gmriggs,closed,0,,,,,0,2018-04-19T22:21:59Z,2018-04-20T02:06:16Z,2018-04-20T02:06:16Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/751,"- Armor
- Imperil
- Vulns
- Prots","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/751/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
316186086,MDExOlB1bGxSZXF1ZXN0MTgzMDAwNTg1,752,"Adding item enchantments to registry, ie. Blood Drinker",8909245,gmriggs,closed,0,,,,,0,2018-04-20T09:02:21Z,2018-04-20T11:34:32Z,2018-04-20T11:34:32Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/752,"- Swift Killer
- Heart Seeker
- Defender
- Impenetrability
- Banes","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/752/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
316302961,MDU6SXNzdWUzMTYzMDI5NjE=,753,We need a way to create/restore server gameplay/configuration options/values in the db,10608427,Mag-nus,closed,0,,,,,3,2018-04-20T15:01:58Z,2018-06-23T16:58:52Z,2018-06-23T16:58:52Z,MEMBER,,,,"As we make more progress on the code, we're constantly coming across things that we're developing to replicate retail, but we know a server operator would prefer to tweak.

A couple examples:
- Player logout doesn't have to take 5 seconds. It could be configured to be 1 second (Integer)
- Bonus XP/Luminance (Float)
- Message Of The Day (String)
- Casting Impen/Bane on a player can act like an aura instead of affecting only equipped items. (Bool)

There are many many more things that players might want to configure. It would be great if they could just change a database value on a running server to have the change take effect.

We should have a DatabaseConfigurationManager (or similar) class that exposes all of these options.

Perhaps this class periodically (every minute, 5 minutes, ...?) checks the database for updated values.

We could even include an admin command to force resync of the variables.

We could even include admin commands to modify the variables from the command line, and from in-game.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/753/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
316557610,MDExOlB1bGxSZXF1ZXN0MTgzMjYwNjQ5,754,Adding bow/crossbow combat,8909245,gmriggs,closed,0,,,,,0,2018-04-22T07:52:12Z,2018-04-23T14:32:32Z,2018-04-22T11:36:32Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/754,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/754/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
316639348,MDExOlB1bGxSZXF1ZXN0MTgzMzExMTAz,755,"Changes to Links and Generators, misc other changes",11369233,LtRipley36706,closed,0,,,,,0,2018-04-23T02:17:52Z,2018-04-30T01:55:25Z,2018-04-23T17:28:28Z,MEMBER,,0,ACEmulator/ACE/pulls/755,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/755/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
316840871,MDExOlB1bGxSZXF1ZXN0MTgzNDU1Mzgy,756,Adding bow/crossbow combat polish,8909245,gmriggs,closed,0,,,,,0,2018-04-23T14:35:54Z,2018-04-23T22:54:11Z,2018-04-23T17:31:25Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/756,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/756/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
317028470,MDExOlB1bGxSZXF1ZXN0MTgzNTkxNzA3,757,Additional bow/crossbow polish,8909245,gmriggs,closed,0,,,,,0,2018-04-24T00:30:49Z,2018-04-24T04:21:11Z,2018-04-24T00:59:17Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/757,"- Adjust missile spawn location
- Attack height trajectory
- Adding collision sound effect

- Fixing cross-landblock projectiles
- Fixing ghost projectiles in dungeons","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/757/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
317065661,MDExOlB1bGxSZXF1ZXN0MTgzNjE3NDA3,758,Minor fixes,8909245,gmriggs,closed,0,,,,,0,2018-04-24T04:23:42Z,2018-04-24T16:39:06Z,2018-04-24T12:09:58Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/758,"- Removing delay when launching projectiles across multiple landblocks
- Removing Vitae from Life Spells category
- Adjusting player vitals on death","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/758/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
317251974,MDExOlB1bGxSZXF1ZXN0MTgzNzU1NDAy,759,Magic :: Lesson 10 :: Arc spells,10137,ghost,closed,0,,,,,0,2018-04-24T14:26:54Z,2018-04-25T00:30:21Z,2018-04-24T23:26:19Z,NONE,,0,ACEmulator/ACE/pulls/759,- Add Arc spells,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/759/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
317652694,MDExOlB1bGxSZXF1ZXN0MTg0MDU0ODE1,760,Magic : Lesson 11 : No cheaters allowed,10137,ghost,closed,0,,,,,0,2018-04-25T14:26:34Z,2018-04-26T13:58:26Z,2018-04-26T02:12:33Z,NONE,,0,ACEmulator/ACE/pulls/760,"- Implement a magic skill check for the spell being cast, with a chance for failure based upon said skill level","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/760/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318123541,MDExOlB1bGxSZXF1ZXN0MTg0NDA5MzA0,761,Magic :: Lesson 12 : Check PK status and implement Magic Defense,10137,ghost,closed,0,,,,,0,2018-04-26T17:19:15Z,2018-04-27T16:17:04Z,2018-04-26T21:14:29Z,NONE,,0,ACEmulator/ACE/pulls/761,"- If target is player, check for similar PK status before allowing casting of harmful spells
- Implement target's Magic Defense vs caster's Magic Skill level
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/761/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318251143,MDExOlB1bGxSZXF1ZXN0MTg0NTA1MTUw,762,Update Player.cs,10187880,dgatewood,closed,0,,,,,0,2018-04-27T01:49:05Z,2018-04-27T02:16:46Z,2018-04-27T02:16:46Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/762,"NullPointerException avoided.. If you  examine a monster as you kill it, the server would crash the second it died.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/762/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318258491,MDExOlB1bGxSZXF1ZXN0MTg0NTEwMjcy,763,Corpses had no value.,10187880,dgatewood,closed,0,,,,,0,2018-04-27T02:38:16Z,2018-04-27T02:54:55Z,2018-04-27T02:54:55Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/763,"Removed the value property from the corpse before it is added to the landblock. I don't know if this is an issue that most can see, but with loot, it is very noticeable.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/763/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318277782,MDExOlB1bGxSZXF1ZXN0MTg0NTI0MTA1,764,Can we get some loot?,10187880,dgatewood,closed,0,,,,,1,2018-04-27T04:57:17Z,2018-04-27T21:42:26Z,2018-04-27T21:30:10Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/764,"This creates working random loot for all tiers. There are some things that need to be added, or tweaked, but this is very much closer to being finished than not.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/764/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318282158,MDExOlB1bGxSZXF1ZXN0MTg0NTI3Mzk3,765,Magic :: Lesson 12.5 : Target validation and a few fixes,10137,ghost,closed,0,,,,,0,2018-04-27T05:28:53Z,2018-04-27T16:17:08Z,2018-04-27T08:25:25Z,NONE,,0,ACEmulator/ACE/pulls/765,"- Target validation : checks for hackery, even if the client disallows certain targets for specific spells
- Workaround for spell projectiles in dungeons
- Remove extra UseDone message in Enchantment code path
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/765/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318433845,MDExOlB1bGxSZXF1ZXN0MTg0NjQwNTk2,766,Adjust invalid target message,10137,ghost,closed,0,,,,,0,2018-04-27T14:36:32Z,2018-04-27T16:17:09Z,2018-04-27T15:42:48Z,NONE,,0,ACEmulator/ACE/pulls/766,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/766/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318468272,MDExOlB1bGxSZXF1ZXN0MTg0NjY2NTYw,767,Add a few checks and minor changes,10137,ghost,closed,0,,,,,0,2018-04-27T16:13:56Z,2018-04-27T21:55:26Z,2018-04-27T19:22:11Z,NONE,,0,ACEmulator/ACE/pulls/767,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/767/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318567103,MDExOlB1bGxSZXF1ZXN0MTg0NzQwODg1,768,Update fake collisions for magic :: WIP,10137,ghost,closed,0,,,,,0,2018-04-27T22:25:41Z,2018-04-28T01:05:43Z,2018-04-27T23:50:34Z,NONE,,0,ACEmulator/ACE/pulls/768,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/768/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318599779,MDExOlB1bGxSZXF1ZXN0MTg0NzYzNzk3,769,Implement the Attuned functionality,10137,ghost,closed,0,,,,,0,2018-04-28T04:38:35Z,2018-04-29T01:27:04Z,2018-04-28T16:59:11Z,NONE,,0,ACEmulator/ACE/pulls/769,"- Add new GameEvent message for InventoryServerSaveFailed
- Add attuned checking to HandleActionDropItem, with InventoryServerSaveFailed message response","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/769/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318664390,MDExOlB1bGxSZXF1ZXN0MTg0ODAyOTI3,770,"Proper weapon skills added, as well as deleting unnecessary code.",10187880,dgatewood,closed,0,,,,,0,2018-04-28T19:58:20Z,2018-04-28T19:58:50Z,2018-04-28T19:58:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/770,"Weapons were showing old weapon skills, such as dagger. This change allows them to show light weapon, heavy, etc.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/770/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318668562,MDExOlB1bGxSZXF1ZXN0MTg0ODA1NDM1,771,Updated weapon skill type.,10187880,dgatewood,closed,0,,,,,0,2018-04-28T21:03:21Z,2018-04-28T21:57:11Z,2018-04-28T21:57:11Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/771," Previously it was reading the old skill types from the database, such as dagger. Now it reads as light, heavy and finesse.

Also deleted unnecessary code.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/771/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318673671,MDExOlB1bGxSZXF1ZXN0MTg0ODA4NTE5,772,Fixing Skill Max Out,10187880,dgatewood,closed,0,,,,,0,2018-04-28T22:36:19Z,2018-04-29T00:26:59Z,2018-04-29T00:26:59Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/772,"Previously there was a difference between what the server thought was the skill max, and what the client thought. This fixing the issue.  Also, I know it is still showing my last commit with this PR. I apologize. I definitely need to spend  an hour learning git from the start.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/772/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318688380,MDExOlB1bGxSZXF1ZXN0MTg0ODE3MzIy,773,Can drop things on the ground once again!,10187880,dgatewood,closed,0,,,,,1,2018-04-29T04:11:02Z,2018-04-29T06:01:00Z,2018-04-29T05:59:55Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/773,"Nullable value was being cast as an int, but was not checked to see if the value was null, only if the object was null. This fixes that so that items can be removed from inventory once again.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/773/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318692465,MDExOlB1bGxSZXF1ZXN0MTg0ODE5NzA5,774,Fix IsAttuned method,10137,ghost,closed,0,,,,,0,2018-04-29T05:57:47Z,2018-05-04T07:19:28Z,2018-04-29T06:10:49Z,NONE,,0,ACEmulator/ACE/pulls/774,"As caught by Derrick, a null check was missing vs the Attuned property itself.  However, the fist null check should remain, as there is a possibility that GetInventoryItem() might return a null, which would need to be handled in a manner to avoid a null pointer exception.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/774/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318717501,MDExOlB1bGxSZXF1ZXN0MTg0ODM0OTM4,775,Change Log Catch-up (April 15 to April 29),33205224,shawarma-golem,closed,0,,,,,0,2018-04-29T13:34:31Z,2018-04-29T14:26:29Z,2018-04-29T14:26:29Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/775,"A lot of interesting features were added over the last 2 weeks, but were not added to the change log!
- Added Change Log entries for commits between 2018-04-15 to 2018-04-29, including ACE-World-16PY commits.
- Added prefixes to commits for specific features.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/775/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
318757150,MDExOlB1bGxSZXF1ZXN0MTg0ODU5NTA2,776,Add Crafting Framework to ACEmulator,11369233,LtRipley36706,closed,0,,,,,0,2018-04-29T22:51:00Z,2018-04-30T01:55:26Z,2018-04-29T23:30:00Z,MEMBER,,0,ACEmulator/ACE/pulls/776,"**ACE-World-16PY world db release v0.0.13+ required with this update**

**You will need to update world database with scripts in the respective update folders**

* Added New Crafting Tables to World Database.
* Removed old ace_recipe table.
* Scaffolded the new tables.
* Rewired RecipeManager to new data. 
  - Basic X + Y = Z crafting done. 
  - Dyeing and other object modifications via crafting are not handled properly yet.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/776/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
319384596,MDExOlB1bGxSZXF1ZXN0MTg1MzE3MDQw,777,Adding monster movement,8909245,gmriggs,closed,0,,,,,2,2018-05-02T01:50:45Z,2018-05-02T22:35:42Z,2018-05-02T22:35:41Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/777,"Thanks so much to @dgatewood, @Slushnas, and the entire ACE team for all the help with this PR","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/777/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
320137967,MDExOlB1bGxSZXF1ZXN0MTg1ODgxMjcw,778,Magic :: Lesson 14 :: Items casting spells,10137,ghost,closed,0,,,,,0,2018-05-04T02:34:04Z,2018-05-06T14:45:40Z,2018-05-05T04:58:08Z,NONE,,0,ACEmulator/ACE/pulls/778,"- Adds the ability for items with spells to cast them on players
- Fixes the player combat with no weapons equipped, which previously had the potential to create a null exception is two locations
- The refresh of spells in the Enchantment registry needs some work, as they currently don't work correctly, until the client is restarted.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/778/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
320527081,MDU6SXNzdWUzMjA1MjcwODE=,779,Splitting peas,38050842,Warloxx01,closed,0,10608427,Mag-nus,,,0,2018-05-05T17:31:09Z,2018-12-29T15:23:31Z,2018-12-29T15:23:31Z,NONE,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [x ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
When splitting peas in the main pack no issue. when placing the pea say a (copper pea) in a secondary pack with the splitting tool and splitting the pea, you get the message that the pea was spit, and the content is placed in the main pack, but the pea is never deleted allowing you to split endlessly.
 
### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->

### Desired functionality.
<!--
What would like to see implemented? the pea (after split) deleted
What is the use case? 1x split each pea
-->

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/779/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
320807124,MDU6SXNzdWUzMjA4MDcxMjQ=,780,Single cast Double damage/Attack,38050842,Warloxx01,closed,0,,,,,1,2018-05-07T13:35:36Z,2018-05-12T01:31:01Z,2018-05-12T01:31:01Z,NONE,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ x] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
I did /grantxp 1***** took him to lvl 241 made all his magic skills/stats 100 (no buff at all) used a lvl 1 fireball and started killing a silver tusker as i did i noticed 2 hits. so i looked closer and found it hit right away then 5 seconds later hit again even though i didnt cast a second time. Also its not a repeat of the same cast it a completely seprate cast. one will hit then the next will be resisted or has a different damage amount. on a side note my mana never dropped while cast either. Have a screenshot but unsure how to attach it.
### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->

### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->

did this all as a Admin.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/780/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
320827675,MDExOlB1bGxSZXF1ZXN0MTg2MzY4OTc2,781,Fix null cases and magic code rearrangement,10137,ghost,closed,0,,,,,0,2018-05-07T14:32:30Z,2018-07-04T19:42:37Z,2018-05-07T20:48:23Z,NONE,,0,ACEmulator/ACE/pulls/781,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/781/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
321517937,MDU6SXNzdWUzMjE1MTc5Mzc=,782,Shortcuts can cause db exceptions with foreign keys,10608427,Mag-nus,closed,0,10608427,Mag-nus,,,1,2018-05-09T10:34:56Z,2018-05-24T20:07:02Z,2018-05-24T20:07:02Z,MEMBER,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [X ] bug report -> please search issues before submitting
- [ ] feature request
```

2018-05-09 05:57:07,618 ERROR: SaveBiota failed with exception: Microsoft.EntityFrameworkCore.DbUpdateException: An error occurred while updating the entries. See the inner exception for details. ---> MySql.Data.MySqlClient.MySqlException: Cannot add or update a child row: a foreign key constraint fails (ace_shard.biota_properties_shortcut_bar, CONSTRAINT wcid_shortcut_objectId FOREIGN KEY (shortcut_Object_Id) REFERENCES biota (id) ON DELETE CASCADE ON UPDATE NO ACTION) ---> MySql.Data.MySqlClient.MySqlException: Cannot add or update a child row: a foreign key constraint fails (ace_shard.biota_properties_shortcut_bar, CONSTRAINT wcid_shortcut_objectId FOREIGN KEY (shortcut_Object_Id) REFERENCES biota (id) ON DELETE CASCADE ON UPDATE NO ACTION)

I think for the shortcut bar, it will make sense to remove the key constraint.

It's not critical if an item is deleted but it's shortcut is not. if it's not critical, the key constraint is not required.

Will have to test the scenario where a user adds a short cut, deletes the item, and relogs. Does the client still get sent the old item id? What does the client show? What happens to the shortcut list when a user drops a new item onto the bar?

I have a theory that we won't even have to manage removal of shortcut items when an item is removed from inventory (or destroyed). I think the client handles this all safely.

If that is the case (which I hope), we wouldn't have to check if an item exists as a shortcut at the time of inventory removal, which keeps this whole process very clean.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/782/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
321518868,MDU6SXNzdWUzMjE1MTg4Njg=,783,Player specific tables need to be moved from biota into character_,10608427,Mag-nus,closed,0,10608427,Mag-nus,,,0,2018-05-09T10:38:05Z,2018-05-24T20:07:02Z,2018-05-24T20:07:02Z,MEMBER,,,,"There are a handful of tables that only populate for players, ie: shortcut bar, friends, spell bar, etc..

These tables shouldn't be in the biota. Instead they should be moved to the character_ tables.

In addition, there are a few propertyints that were shoved into the PropetyInt list that only represent character info. These properties should also be moved to the character table.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/783/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
321519680,MDU6SXNzdWUzMjE1MTk2ODA=,784,Landblocks use a lot of memory,10608427,Mag-nus,closed,0,8909245,gmriggs,,,3,2018-05-09T10:40:57Z,2018-08-17T09:49:35Z,2018-08-17T09:49:35Z,MEMBER,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [X ] bug report -> please search issues before submitting
- [ ] feature request
```

I added a debug command (can't forget what it is specifically) that loads all landblocks.

Right now, on a 32GB machine, it's not possible to load all the landblocks. You'll run out of memory fast.

Some of the data in the landblock physics code is being duplicated often. This should be shared when possible.

Using Visual Studio memory profiler makes it easy to see what objects are the problem.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/784/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
321591583,MDExOlB1bGxSZXF1ZXN0MTg2OTM4MDQ2,785,Fix a null exception and a couple of if statements,10137,ghost,closed,0,,,,,0,2018-05-09T14:22:54Z,2018-07-04T19:42:36Z,2018-05-09T15:02:09Z,NONE,,0,ACEmulator/ACE/pulls/785,"- Have HandleActionCastTargetedSpell method be more granular is deciding the target type to determine whether player rotation is needed
- Change an two if statements in IsInvalidTarget, so the result is correct to allow casting Item enchants on valid targets","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/785/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
321809450,MDExOlB1bGxSZXF1ZXN0MTg3MTAwOTg1,786,Handing objects to other WO's,10187880,dgatewood,closed,0,,,,,0,2018-05-10T04:56:26Z,2019-04-08T19:47:03Z,2018-05-10T07:06:59Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/786,"GameEvent and Action changes, and re-implementation of the old code for HandleGiveObjectRequest.
Also, using branches now.... Trying to better use Git so I am more productive and more in line with team standards!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/786/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
321900570,MDExOlB1bGxSZXF1ZXN0MTg3MTY5MDc5,787,"Bolt, Streak and Arc updates",19214857,Slushnas,closed,0,,,,,2,2018-05-10T11:33:11Z,2018-05-11T15:06:13Z,2018-05-11T15:06:13Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/787,"Various bits of code have been added to make the existing spells line up with retail data and lay the groundwork for other spells. There is still more research to do but this is a step closer to retail based on the data I have gathered so far.

I am not sure if the code I added to WorldObjectFactory.cs is the best way to get the spell ID into the constructor (seems like one of the CreateWorldObject functions could be removed/integrated).

I had to add some code to be able to override some PhysicsDescription fields. I did a couple of searches through the pcaps and the fields that I set to false by default don't seem to have been used so I don't believe this will cause any problems.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/787/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
322481040,MDExOlB1bGxSZXF1ZXN0MTg3NjAzNTc2,788,Fix magic messaging and portal spells routing incorrectly,10137,ghost,closed,0,,,,,0,2018-05-12T04:14:51Z,2018-07-04T19:42:34Z,2018-05-12T04:58:13Z,NONE,,0,ACEmulator/ACE/pulls/788,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/788/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
322496552,MDExOlB1bGxSZXF1ZXN0MTg3NjEyNzMx,789,Adding monster melee combat,8909245,gmriggs,closed,0,,,,,1,2018-05-12T09:20:36Z,2018-07-01T00:55:11Z,2018-05-15T04:34:54Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/789,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/789/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
322522831,MDExOlB1bGxSZXF1ZXN0MTg3NjI3ODk5,790,"@nudge @nudge, got some @crack",3317737,fartwhif,closed,0,,,,,1,2018-05-12T16:07:05Z,2018-05-12T22:16:26Z,2018-05-12T22:16:26Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/790,"Use /crack to unlock/pick/open doors and chests. (don't do drugs)
Use /nudge to correct player position cell ID after teleporting into black space. (experimental, debug)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/790/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
322650543,MDExOlB1bGxSZXF1ZXN0MTg3NzA0ODgx,791,lockpicking doors,3317737,fartwhif,closed,0,,,,,1,2018-05-14T02:04:19Z,2018-05-14T16:30:14Z,2018-05-14T16:30:13Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/791,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/791/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
323060025,MDExOlB1bGxSZXF1ZXN0MTg4MDA5MDUw,792,Adding collector EmoteTable stuff..,10187880,dgatewood,closed,0,,,,,0,2018-05-15T04:09:54Z,2019-04-08T19:47:04Z,2018-05-15T18:08:13Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/792,"Added HandleReceive inside of WorldObject so the emote table can be checked to see if the item given should set off any emoteActions.
 And Minor fix for casters in Loot Factory, casters had no current mana field, this adds that.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/792/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
323325896,MDExOlB1bGxSZXF1ZXN0MTg4MjExNDQz,793,EmoteTable Stuff,10187880,dgatewood,closed,0,,,,,1,2018-05-15T18:09:22Z,2018-05-16T19:34:15Z,2018-05-16T19:34:15Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/793,"Added HandleReceive in WorldObjects
Checking within PlayerInventory if a HandleReceive is true.
Added new cases inside of ExecuteEmote.
Thiss allows all collectors and rng hand-ins, such as GamesMasters, to work.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/793/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
323359446,MDExOlB1bGxSZXF1ZXN0MTg4MjM3MjAy,794, Adding monster spell casting,8909245,gmriggs,closed,0,,,,,1,2018-05-15T19:52:56Z,2018-12-25T05:56:37Z,2018-05-18T13:37:47Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/794,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/794/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
324577273,MDExOlB1bGxSZXF1ZXN0MTg5MTU0NDU1,795,Adding monster ranged combat,8909245,gmriggs,closed,0,,,,,0,2018-05-18T23:15:52Z,2018-05-19T16:42:40Z,2018-05-19T16:42:40Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/795,"- Adding equipped items to Player_Tracking
- Fixed a bug where CombatState was broadcast to landblock","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/795/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
324593612,MDExOlB1bGxSZXF1ZXN0MTg5MTY2MjQy,796,Creating salvage from items...,10187880,dgatewood,closed,0,,,,,1,2018-05-19T02:19:54Z,2019-04-08T19:47:07Z,2018-05-19T16:40:23Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/796,"Created GameActionCreateTinkeringTool
Added HandleTinkeringTool
Formula for value is as stated on wiki, though amount salvaged was not found and done from memory where you could salvage 110% from a fully buffed salvage skill. This can be changed if an exact formula presents itself.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/796/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
324660707,MDExOlB1bGxSZXF1ZXN0MTg5MjA2OTcy,797,reduced some code duplication for lockable world objects,3317737,fartwhif,closed,0,,,,,0,2018-05-19T21:10:34Z,2018-05-23T00:45:04Z,2018-05-20T04:32:23Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/797,"added interface for unlocking lockable world objects
added missing sound for pick lock fail","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/797/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
324681949,MDExOlB1bGxSZXF1ZXN0MTg5MjE4MjYz,798,@addallspells dev command,25518589,mcreedjr,closed,0,,,,,2,2018-05-20T04:11:03Z,2018-08-11T04:32:20Z,2018-05-20T05:21:01Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/798,"Be gentle... I am a novice developer at best, and this is my first pull request ever, let alone first pull request on the ACE project.

I humbly submit a developer command to be used to learn all known spells on the current character.

I acknowledge this results in spells being learned that will never be castable by the player, and I also note that it asks the client to display way too many 'bubble' messages upon learning each spell, but the client seems to handle it more or less gracefully.

I had thought about learning all spells, except for the last spell with the AddKnownSpell() Method, and then just calling LearnSpellWithNetworking() on the last spell to update the client, but that seemed more hacky than having the client ingest lots of updateSpellEvent GameEvents.

Feedback is welcomed and encouraged.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/798/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
324684458,MDExOlB1bGxSZXF1ZXN0MTg5MjE5NzEy,799,Database Rebase and Table Rename,11369233,LtRipley36706,closed,0,,,,,3,2018-05-20T05:14:32Z,2018-05-26T06:07:02Z,2018-05-24T20:07:01Z,MEMBER,,0,ACEmulator/ACE/pulls/799,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/799/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
324945268,MDExOlB1bGxSZXF1ZXN0MTg5NDAxNzA3,800,On use emotes,10187880,dgatewood,closed,0,,,,,0,2018-05-21T14:51:30Z,2019-04-08T19:47:08Z,2018-05-22T16:10:27Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/800,"This code works for all collectors and should work for many more things. The only problem is is that there are emote tables missing. Also, with quest NPCs, the first emote for onUse is to update the quest. Once the quest is updated, It will then give dialogue about the quest. We do not have quest tables in to update it, so you will not see any information regarding quests.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/800/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
325374494,MDExOlB1bGxSZXF1ZXN0MTg5NzI0MzE0,801,Change Log Catch-up (April 29 to May 22),33205224,shawarma-golem,closed,0,,,,,0,2018-05-22T16:36:04Z,2018-05-23T13:54:32Z,2018-05-23T13:54:32Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/801,"Dear Devs, update changelog.md as you go!
* Added Change Log entries of ACE commits from 2018-04-29 to 2018-05-22.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/801/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
325546860,MDExOlB1bGxSZXF1ZXN0MTg5ODU0ODg3,802,added SurfaceTexture parser,3317737,fartwhif,closed,0,,,,,0,2018-05-23T04:39:22Z,2018-05-26T02:40:41Z,2018-05-24T02:50:09Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/802,"added Texture file and Texture file metadata getter
if a few things are mastered it might come in handy","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/802/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
325660510,MDExOlB1bGxSZXF1ZXN0MTg5OTQwMTYy,803,Rework addallspells debug handler,25518589,mcreedjr,closed,0,,,,,0,2018-05-23T11:19:14Z,2018-08-11T04:32:18Z,2018-05-23T14:13:35Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/803,"Based on feedback and a discussion in the #development Discord channel with @jyrus and @gmriggs, I modified the addallspells code submitted in a previous PR to lay the ground work for learning spells in bulk via the Arwic spell vendors.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/803/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
326372931,MDExOlB1bGxSZXF1ZXN0MTkwNDc1OTE0,804,Various missile combat fixes/additions,19214857,Slushnas,closed,0,,,,,0,2018-05-25T03:58:48Z,2018-05-25T17:34:55Z,2018-05-25T17:34:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/804,"* Renamed GameMessageRemoveObject to GameMessageDeleteObject to avoid confusion with other messages.
* Renamed TryDestroyFromInventoryWithNetworking() to TryRemoveFromInventoryWithNetworking() as that function sends InventoryRemoveObject messages.
* Cleaned up some stack merging code and added support for merging missile ammo to currently equipped ammo.
* Added the ability to set the stacksize of spawned items created with the /ci command.
* Fix for observed players improperly playing last combat mode animation when moving.
* Fixed missile ammo appearing in players hands on login.
* Fixed arrows being fired after switching to peace mode.
* Added ammo usage to player missile attacks.
* Added damageSource parameter to damage functions to better support edge cases.
* Various other minor tweaks to bring sent game messages more in line with retail pcaps.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/804/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
326690201,MDExOlB1bGxSZXF1ZXN0MTkwNzEzMzg1,805,fixed bug causing DefaultPaletteId to always be set,3317737,fartwhif,closed,0,,,,,0,2018-05-25T23:40:14Z,2018-05-26T02:40:11Z,2018-05-26T02:25:55Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/805,"no longer uses the stream length for parsing
more descriptive property name
moved DirectX texture formats enum to ACE.DatLoader.Entity namespace","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/805/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
326754237,MDExOlB1bGxSZXF1ZXN0MTkwNzUxNDkw,806,wells and pools revitalize you,3317737,fartwhif,closed,0,,,,,0,2018-05-26T17:26:03Z,2018-06-21T23:22:55Z,2018-05-26T19:33:47Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/806,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/806/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
326754834,MDU6SXNzdWUzMjY3NTQ4MzQ=,807,melee damage amount anomaly,3317737,fartwhif,closed,0,,,,,1,2018-05-26T17:34:54Z,2018-07-07T00:09:45Z,2018-07-07T00:09:18Z,COLLABORATOR,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [ X ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.

1. max everything out, level 275, all atts/skills
2. equip gear: 24611 sword 5893 robe 28323 shield 14594 helm 8670 orb 29525 gaunts
3. go into dark lair
4. start killing via the sword

### The log given by the failure.
You mangle Olthoi Gardener for -1042267392 points of slashing damage!

It buffs the Olthoi to have insane amount of hp.  crushed it eventually as the bug goes both ways, I think.
![resultant Olthoi](https://cdn.discordapp.com/attachments/417073903094202371/449971753612214282/unknown.png)


### Desired functionality.
normal damage numbers

### Mention any other details that might be useful.
Not sure if the gear makes a difference.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/807/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
326879709,MDExOlB1bGxSZXF1ZXN0MTkwODI0MDYw,808,Add support for Wielded/Death Treasure from database,11369233,LtRipley36706,closed,0,,,,,0,2018-05-28T02:48:48Z,2018-06-03T18:36:48Z,2018-05-30T16:30:08Z,MEMBER,,0,ACEmulator/ACE/pulls/808,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/808/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
326996576,MDExOlB1bGxSZXF1ZXN0MTkwOTA4MDE5,809,Fix Defender notification message length.,19214857,Slushnas,closed,0,,,,,0,2018-05-28T11:37:17Z,2018-05-29T03:41:42Z,2018-05-29T03:41:42Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/809,I noticed this message wasn't parsing correctly. This should fix it.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/809/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
327142346,MDExOlB1bGxSZXF1ZXN0MTkxMDEzNzYy,810,added Hotspot WorldObject,3317737,fartwhif,closed,0,,,,,1,2018-05-29T01:18:52Z,2018-06-21T23:22:53Z,2018-05-30T02:58:45Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/810,"changed Random to a thread-safe singleton
brought WorldObject.HandleActionOnCollideEnd up from physics engine","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/810/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
327815589,MDU6SXNzdWUzMjc4MTU1ODk=,811,Selling,38050842,Warloxx01,closed,0,,,,,1,2018-05-30T16:55:53Z,2018-12-15T19:17:34Z,2018-12-15T19:17:34Z,NONE,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ x] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
Go to any vendor and try to sell an item ( sword at the blacksmith / wand at the mage shop) you can drop it on the vendor or open the sell window, either way it shows up ready to be sold. but when you hit sell item or sell all it crashes.
<!-- Please list the steps to reproduce a bug here -->

### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->

### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/811/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
328370425,MDExOlB1bGxSZXF1ZXN0MTkxOTI2OTUw,812,spell traps,3317737,fartwhif,closed,0,,,,,0,2018-06-01T03:42:19Z,2018-06-21T23:22:51Z,2018-06-01T06:07:40Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/812,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/812/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
328710470,MDExOlB1bGxSZXF1ZXN0MTkyMTc3ODgz,813,Loot fixes/changes,10187880,dgatewood,closed,0,,,,,0,2018-06-02T03:56:40Z,2018-06-09T20:01:53Z,2018-06-04T03:57:21Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/813,"Long Descriptions work.
Fixed Casters not having a current mana and just showing up as stored mana.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/813/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
328864436,MDExOlB1bGxSZXF1ZXN0MTkyMjY4ODQz,814,implement server side request for retransmission,3317737,fartwhif,closed,0,,,,,0,2018-06-03T21:37:32Z,2018-06-21T23:22:56Z,2018-06-05T07:21:14Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/814,fixed bug in Player_Vitals.cs causing a crash upon player disconnect,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/814/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
328928199,MDExOlB1bGxSZXF1ZXN0MTkyMzEyMDY4,815,Switch Refactor,11369233,LtRipley36706,closed,0,,,,,1,2018-06-04T06:47:48Z,2018-06-04T17:12:55Z,2018-06-04T14:02:02Z,MEMBER,,0,ACEmulator/ACE/pulls/815,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/815/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
329187165,MDExOlB1bGxSZXF1ZXN0MTkyNTA1NzY1,816,Adding projectile physics,8909245,gmriggs,closed,0,,,,,0,2018-06-04T19:32:50Z,2018-07-19T10:09:08Z,2018-06-08T08:08:54Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/816,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/816/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
330562879,MDExOlB1bGxSZXF1ZXN0MTkzNTQwNDA0,817,Adding monster physics-based movement,8909245,gmriggs,closed,0,,,,,0,2018-06-08T08:18:12Z,2018-06-08T23:08:49Z,2018-06-08T23:08:49Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/817,Monsters should no longer move through walls or other impassable areas,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/817/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
330579942,MDExOlB1bGxSZXF1ZXN0MTkzNTUzMzE0,818,Adding shield combat,8909245,gmriggs,closed,0,,,,,0,2018-06-08T09:12:31Z,2018-06-08T23:09:23Z,2018-06-08T23:09:22Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/818,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/818/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
330921458,MDExOlB1bGxSZXF1ZXN0MTkzNzk3NjQ2,819,Tinkering for most things.,10187880,dgatewood,closed,0,,,,,0,2018-06-09T21:45:28Z,2018-07-03T05:27:02Z,2018-06-10T04:54:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/819,"Not all types were tested because we don't generate full bags of all salvage types. I could create a command that will generate the full bag, but it should work as is.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/819/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
330991743,MDExOlB1bGxSZXF1ZXN0MTkzODM5OTg3,820,Add a configurable property storing database to resolve issue #753,20762705,EvanMerlock,closed,0,,,,,4,2018-06-10T18:36:17Z,2018-06-21T01:58:32Z,2018-06-21T01:58:18Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/820,"This PR adds a fourth (optional) database that contains 4 tables - `bool_stat`, `int_stat`, `float_stat`, and `string_stat`, one for each type of property that can be implemented in the current model. The original issue ( #753 ) mentions a few options that could initially be configured. I have implemented properties for the vitae penalty on death, the minimum vitae value, a flat XP modifier applied to both `GainXP` and `EarnXP` and a flat luminance modifier applied to `GainLuminance`.

The fourth database is completely optional, with the server warning an owner that they should use the SQL provided to create a new database but not forcing the server owner to deal with it. It pulls default values for properties from a `Dictionary` for each property type that is stored in the `DefaultPropertyManager` class.

The server caches values from the database and updates them on a 5 minute timer, where it persists the variables modified from the console or in-game into the database before pulling variables from the database. 

This PR also adds admin commands and console commands `fetch<Type>` and `modify<Type>` to work with the properties while the server is running from the game, as well as `resyncvariables` which will pause the timer and resync the database and cached variables. 

Since I'm not completely well acquainted with the codebase yet, I put in the properties I thought were the easiest for me personally to implement, but the process for implementing new properties is:

1. Locate and extract the property into a `private` variable (preferably `static` as well)
2. Create a unique name for the property
3. In the `DefaultPropertyManager` class, add a tuple into the appropriate `ToDict` call for the datatype the property is that has the default value
4. Replace the `get` method on the property with one calling `PropertyManager.Get<Type>(propertyName)`

The approach I used in developing this patch was to avoid user intervention temporarily, and as such there are tradeoffs involved.

1. The database is completely optional, which means that default values must be placed within the program to prevent a fallback value that doesn't make sense from being hit (instead of blowing the whole server up with a NPE). This can be solved by having the database be non-optional, or making the database non-optional after more properties are added to it.
2. There is now a fourth database ACE would need to run completely after this PR. There are a few potential fixes for this, including using a flatfile for the configuration values (removes the ability to update the backend to cause changes), rolling the 4 tables already implemented into one of the other ACE databases (I wasn't confident in my knowledge of how the process for updates works in order to do this but I'd be willing to learn if necessary) or just simply not implementing this feature right now.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/820/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
331400340,MDExOlB1bGxSZXF1ZXN0MTk0MTQwNzM1,821,Updating cell transitions,8909245,gmriggs,closed,0,,,,,0,2018-06-12T00:58:28Z,2018-06-12T15:48:12Z,2018-06-12T15:48:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/821,- Fixed a bug where the current cell would be null after portal,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/821/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
331836327,MDExOlB1bGxSZXF1ZXN0MTk0NDY3MDgz,822,"WAN reliability, message queues, refactoring",3317737,fartwhif,closed,0,,,,,0,2018-06-13T04:18:30Z,2018-06-21T23:22:34Z,2018-06-15T16:56:23Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/822,"WAN sessions are now at least reliable enough to test with
message fragments are now grouped by queue
refactor PacketFragmentHeader.Queue to match aclogview
refactor Packet.Header.Iteration to match aclogview
included some missing header flags from aclogview
include aclogview packet header flag names as comments
refactor typo in packet header flag names","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/822/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
332229599,MDExOlB1bGxSZXF1ZXN0MTk0NzYzNDIy,823,add ability to /tele players by name,3317737,fartwhif,closed,0,,,,,2,2018-06-14T02:29:14Z,2018-06-21T23:22:25Z,2018-06-18T04:43:15Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/823,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/823/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
332651213,MDExOlB1bGxSZXF1ZXN0MTk1MDgxMTcw,824,Give Request fix,10187880,dgatewood,closed,0,,,,,1,2018-06-15T05:33:09Z,2018-06-18T10:58:17Z,2018-06-18T04:45:37Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/824,Selected Wielded Objects as well as Inventory Objects. This fixes crash of gioving wielded objects to the town crier.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/824/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
333031903,MDExOlB1bGxSZXF1ZXN0MTk1MzU5Mjk3,825,Adding Allegiance system,8909245,gmriggs,closed,0,,,,,1,2018-06-17T03:22:54Z,2018-06-23T00:33:07Z,2018-06-23T00:33:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/825,work in progress,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/825/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
333377752,MDExOlB1bGxSZXF1ZXN0MTk1NjA0OTE4,826,Unequip and burden correction,10187880,dgatewood,closed,0,,,,,1,2018-06-18T18:07:43Z,2018-06-23T20:13:30Z,2018-06-19T08:15:29Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/826,Unwield and RemoveWithNetworking added/moved to the first thing done.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/826/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
333394359,MDExOlB1bGxSZXF1ZXN0MTk1NjE3NDIy,827,Updating Fellowship system,8909245,gmriggs,closed,0,,,,,0,2018-06-18T18:58:17Z,2018-06-23T14:41:44Z,2018-06-23T14:41:44Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/827,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/827/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
333624829,MDExOlB1bGxSZXF1ZXN0MTk1NzkxMDcz,828,Update friends list,8909245,gmriggs,closed,0,,,,,0,2018-06-19T11:10:27Z,2018-06-23T14:48:56Z,2018-06-23T14:48:56Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/828,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/828/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
335136177,MDExOlB1bGxSZXF1ZXN0MTk2OTIzNjg2,829,Fix for Undead player characters not visually equipping clothing,26606778,OptimShi,closed,0,,,,,1,2018-06-23T22:43:53Z,2018-06-24T04:54:15Z,2018-06-24T00:33:47Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/829,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/829/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
335146691,MDExOlB1bGxSZXF1ZXN0MTk2OTMwMDEw,830,added sentinel command /buff [name],3317737,fartwhif,closed,0,,,,,0,2018-06-24T03:03:22Z,2018-12-07T02:14:56Z,2018-06-30T02:04:55Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/830,"/buff - Buffs you (or a player) with all beneficial spells.
Usage: /buff [name]
This command buffs yourself (or the specified character).

curate the spell enum a bit (the other and self counterparts need to be exactly the same except for 'Self' and 'Other')","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/830/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
335521398,MDExOlB1bGxSZXF1ZXN0MTk3MjAwNjg4,831,"Adding landblock unloading system, and player corpses",8909245,gmriggs,closed,0,,,,,0,2018-06-25T18:39:17Z,2018-06-29T19:35:58Z,2018-06-29T19:35:58Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/831,"- Adding landblock unloading / reloading system
- Fixed a bug where generators were spawning monsters too quickly
- Adding player corpses
- Adding dungeon/outdoor landblock detection
- Fixed a bug with spawning certain scenery (Redspire)
- Added player death items list calculation
- Added dropped items to corpse containers
- Added corpse looting permissions
- Added permaload flag for landblocks","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/831/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
335620592,MDExOlB1bGxSZXF1ZXN0MTk3Mjc1MDEz,832,Fixing specialized skill calcs,8909245,gmriggs,closed,0,,,,,0,2018-06-26T01:04:57Z,2018-06-28T07:19:42Z,2018-06-28T07:19:42Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/832,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/832/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
336837847,MDExOlB1bGxSZXF1ZXN0MTk4MTk3MTgw,833,Updating appraisal system / refactoring,8909245,gmriggs,closed,0,,,,,0,2018-06-29T02:04:49Z,2018-06-29T18:54:38Z,2018-06-29T18:54:38Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/833,"- Full appraisal info for all object types
- Enchantments are now shown in the appraisal window, colored green/red highlights
- Cleaned up and refactored existing code","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/833/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337175570,MDExOlB1bGxSZXF1ZXN0MTk4NDUyOTc4,834,Migrate Gem spell casting to Spell System,10137,ghost,closed,0,,,,,0,2018-06-30T01:25:49Z,2018-07-04T19:42:33Z,2018-06-30T02:05:28Z,NONE,,0,ACEmulator/ACE/pulls/834,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/834/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337182123,MDExOlB1bGxSZXF1ZXN0MTk4NDU3MTQw,835,Fixing merge,8909245,gmriggs,closed,0,,,,,0,2018-06-30T03:20:24Z,2018-06-30T04:56:10Z,2018-06-30T04:56:10Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/835,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/835/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337304322,MDExOlB1bGxSZXF1ZXN0MTk4NTMyMzQ4,836,Add spells and a couple of other fixes,10137,ghost,closed,0,,,,,0,2018-07-01T16:40:18Z,2018-07-04T19:42:32Z,2018-07-02T03:47:39Z,NONE,,0,ACEmulator/ACE/pulls/836,"- Modify LearnSpellsInBulk() to use an uint array of player allowed spellIDs
- Remove extra /addspell in DebugCommands, leaving renamed command in AdminCommands : use continue to use /addspell ( renamed to remove ambiguity about what is being added )
- Fix NPK vs other players, in regards to harmful spells
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/836/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337313318,MDExOlB1bGxSZXF1ZXN0MTk4NTM3NTYx,837,Improved monster movement,8909245,gmriggs,closed,0,,,,,0,2018-07-01T18:58:33Z,2018-07-02T22:01:58Z,2018-07-02T03:53:54Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/837,"- Updated animation system to loop through linked anims properly
- Fixing creature sliding
- Adjusted monster movement speed
- Fixed a possible crash looping through CellArray (todo: use standard for loop to check for newly added cells)
- Temporary fix with mages not being able to loot corpses (todo: Player_Magic should be calling WorldObject.TakeDamage)
- Various bug fixes","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/837/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337332025,MDExOlB1bGxSZXF1ZXN0MTk4NTQ4NTcz,838,Text Encoding Updates,26606778,OptimShi,closed,0,,,,,0,2018-07-01T23:28:36Z,2020-06-15T20:58:55Z,2018-07-02T03:47:04Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/838,"Added CP1252 text encoding. Fixes some issues with Spell Formulas when spells used non ANSI characters as well as in sending strings to the client. Did not test client-to-client communication/chat.

I had to add an NuGet reference, so might need to refresh your NuGet packages.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/838/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337354678,MDExOlB1bGxSZXF1ZXN0MTk4NTYyNDUx,839,mana stones,3317737,fartwhif,closed,0,,,,,0,2018-07-02T03:05:31Z,2018-12-07T02:14:15Z,2018-07-07T01:04:40Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/839,equipped and activated mana burning items periodically burn mana,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/839/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337681853,MDExOlB1bGxSZXF1ZXN0MTk4ODAyOTA2,840,Fixing monster turning speeds,8909245,gmriggs,closed,0,,,,,0,2018-07-02T22:14:42Z,2018-07-04T20:02:27Z,2018-07-03T02:58:23Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/840,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/840/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337735764,MDExOlB1bGxSZXF1ZXN0MTk4ODQyNTkx,841,Spell Set Reading,26606778,OptimShi,closed,0,,,,,0,2018-07-03T03:47:44Z,2020-06-15T20:58:56Z,2018-07-03T13:59:57Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/841,"Now fully reads the SpellTable out of the client_portal.dat. This adds data for Spell Sets (spells that are cast when you have multiple items equipped in a set or have leveled up an item in a set, such as a cloak or Paragon weapon)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/841/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337754401,MDExOlB1bGxSZXF1ZXN0MTk4ODU2MTcx,842,Save Window Position,26606778,OptimShi,closed,0,,,,,2,2018-07-03T05:51:00Z,2018-07-03T16:54:52Z,2018-07-03T16:54:52Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/842,"Saves window positions and restores them on login.

Note this requires a small SQL update in \Database\Updates\Shard\","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/842/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
337756214,MDExOlB1bGxSZXF1ZXN0MTk4ODU3NDgw,843,WIP   QuestManager and EmoteManager additions  (NOT FOR MERGE),10187880,dgatewood,closed,0,,,,,0,2018-07-03T06:01:03Z,2018-07-06T14:19:26Z,2018-07-06T14:19:26Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/843,"Create a new 22754 (for the specialization dungeon)

keep clicking through the replies and watch for Jevak...  when he asks for essence of jevak, give him @ci 777

The issue is that the give action is after the emoteActions are performed...

But this should be mergable very soon.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/843/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338184917,MDExOlB1bGxSZXF1ZXN0MTk5MTc5NDM3,844,Adding player/monster health instant updates,8909245,gmriggs,closed,0,,,,,0,2018-07-04T08:48:29Z,2018-07-04T19:41:38Z,2018-07-04T19:41:38Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/844,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/844/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338367575,MDExOlB1bGxSZXF1ZXN0MTk5MzE4MDQ5,845,"Linking monster aggro to player combat, adjusting tolerance",8909245,gmriggs,closed,0,,,,,0,2018-07-04T20:10:09Z,2018-07-06T22:17:49Z,2018-07-04T21:40:07Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/845,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/845/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338407407,MDExOlB1bGxSZXF1ZXN0MTk5MzQ1NzA4,846,Adjusted Magic code :: WIP :: Testing needed before merge,10137,ghost,closed,0,,,,,0,2018-07-05T02:25:03Z,2018-07-07T16:25:39Z,2018-07-06T00:58:20Z,NONE,,0,ACEmulator/ACE/pulls/846,"-Rearranged code flow to remove some redundant code
-Aligned Magic damage application with Physical damage
-Added Crit and War skill bonus
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/846/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338414810,MDExOlB1bGxSZXF1ZXN0MTk5MzUwODE5,847,Dat updates,26606778,OptimShi,closed,0,,,,,0,2018-07-05T03:20:46Z,2019-03-09T19:56:35Z,2018-07-05T12:50:43Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/847,"* Fixed an issue with the Replace DatLoader.Entity.AnimationHook
* Added SoundTable (0x20...) parsing from the client_portal.dat.
* Added support for client_highres.dat and client_local_English.dat to the DatManager, however these files are not required for server operation.
* Renamed DatLoader.Entity.Texture to DatLoader.FileType.RenderSurface and adjusted some structure to be consistent with the client.
* Adjusted DatLoader.FileType.SurfaceTexture to be consistent with the client.
* Added BadData (0x0E00001A) parsing from client_portal.dat
* Added ChatPoseTable (0x0E000007) parsing from client_portal.dat
* Added NameFilterTable (0x0E000020) parsing from client_portal.dat
* Added QualityFilter (0x0E01...) parsing from client_portal.dat
* Added SecondaryAttributeTable (0x0E000003) parsing from client_portal.dat
* Added SkillTable (0x0E000004) parsing from client_portal.dat","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/847/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338690945,MDExOlB1bGxSZXF1ZXN0MTk5NTYwMjU3,848,Dat fixes,26606778,OptimShi,closed,0,,,,,0,2018-07-05T19:03:21Z,2020-06-15T20:58:57Z,2018-07-05T20:09:20Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/848,Fixes some issues that arose with the last commit that may have broken a few things.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/848/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338794196,MDExOlB1bGxSZXF1ZXN0MTk5NjM3MTM1,849,Remove Vital to Vital Other spells from player allowed list,10137,ghost,closed,0,,,,,0,2018-07-06T03:36:07Z,2018-07-07T16:25:36Z,2018-07-06T21:20:19Z,NONE,,0,ACEmulator/ACE/pulls/849,"-Remove Health to {Stamina,Mana} Other spells
-Remove Stamina to {Health,Mana} Other spells
-Remove Mana to {Health,Stamina} Other spells
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/849/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
338900517,MDExOlB1bGxSZXF1ZXN0MTk5NzE3MTY2,850,Emote/Quests,10187880,dgatewood,closed,0,,,,,1,2018-07-06T11:12:19Z,2018-07-11T21:22:59Z,2018-07-11T21:22:59Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/850,"Quest Manager added to save/load to database.
Emotes filled out to do some basic quests.
There are some emotes that do need work, such as UpdateQuest, and all movement emotes.
Event  Manager was already in game, so I just wired the emotes that had already been filled for those.  Have not tested an event, but should work just like a quest but on a global scale.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/850/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339086874,MDExOlB1bGxSZXF1ZXN0MTk5ODU5MjE2,851,Improved monster transitions between landblocks and cell boundaries,8909245,gmriggs,closed,0,,,,,1,2018-07-06T22:23:16Z,2018-07-07T20:35:10Z,2018-07-07T20:35:10Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/851,"- Fixed various bugs with monsters crossing between landblock and cell boundaries.
- Monsters should be able to chase the player through dungeons and indoor areas more consistently
- Added monster movement debug commands
- Fixed the missing portals in Hotel Swank
- Fixed a bug with some dungeons having black screens on portal entry
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/851/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339118553,MDExOlB1bGxSZXF1ZXN0MTk5ODgxMjQw,852,Image Export,26606778,OptimShi,closed,0,,,,,2,2018-07-07T05:21:05Z,2020-06-15T20:59:00Z,2018-07-09T15:56:32Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/852,"Added ""image-export"" console function to extract textures from client_portal.dat and client_highres.dat. Run the command with no parameters for syntax.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/852/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339174733,MDExOlB1bGxSZXF1ZXN0MTk5OTEzNDY0,853,Fix Enchantment Registry duration,10137,ghost,closed,0,,,,,0,2018-07-07T21:03:02Z,2018-07-08T02:28:47Z,2018-07-08T02:28:32Z,NONE,,0,ACEmulator/ACE/pulls/853,"-Redirect Aura spells cast by items to the player
-Fix item cast spell timers in the player's Enchantment Registry","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/853/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339175508,MDExOlB1bGxSZXF1ZXN0MTk5OTEzOTQy,854,Updating ObjectMaint for multiplayer dungeons,8909245,gmriggs,closed,0,,,,,0,2018-07-07T21:17:22Z,2018-07-09T19:46:16Z,2018-07-09T19:46:16Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/854,"- Updated the Object Maintenance system from a server-wide instance to per-player. This should fix the disappearing monsters in dungeons for multiplayer.

- Added a call to handle_visible_cells() when an object enters the PVS for a player. This fixes a bug when players/creatures travel long distances to reach a player who has been standing in the same cell for awhile. It should also make the PVS system more consistent in general.

- Added a null check to all references to CurrentLandblock. There are many functions currently running in the ActionQueue after an object has been destroyed. TODO: revisit the object destruction system
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/854/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339185219,MDExOlB1bGxSZXF1ZXN0MTk5OTE5MTQ0,855,SpellCategory Enum,26606778,OptimShi,closed,0,,,,,0,2018-07-08T00:21:06Z,2020-06-15T20:59:01Z,2018-07-08T01:11:19Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/855,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/855/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339191091,MDExOlB1bGxSZXF1ZXN0MTk5OTIyMjc0,856,Fix Enchant Registry for duration and layering and Redirect Aura spells,10137,ghost,closed,0,,,,,0,2018-07-08T02:39:15Z,2018-07-10T03:51:25Z,2018-07-09T19:06:18Z,NONE,,0,ACEmulator/ACE/pulls/856,"-Redirect Aura spells cast by items to Player
-Fix Enchantment Registry timers
-Account for gems casting spells requiring a duration
-Initial pass at Enchantment layering

TODO: duplicate and overridden item enchants still show up on AppraisalInfo :: will fix in next PR","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/856/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339260691,MDExOlB1bGxSZXF1ZXN0MTk5OTYyNDEz,857,persistent tracking of item affectance,3317737,fartwhif,closed,0,,,,,2,2018-07-08T21:47:20Z,2018-12-07T02:14:38Z,2018-07-13T01:40:13Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/857,item affectance is restored at Player.EnterWorld,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/857/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339297380,MDExOlB1bGxSZXF1ZXN0MTk5OTg2MTM1,858,Remove the five unneeded start items,10137,ghost,closed,0,,,,,0,2018-07-09T03:59:05Z,2018-07-10T03:51:26Z,2018-07-09T17:43:02Z,NONE,,0,ACEmulator/ACE/pulls/858,-Remove the five unneeded start items from WeeniePropertiesCreateList that get generated for all characters.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/858/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339547333,MDExOlB1bGxSZXF1ZXN0MjAwMTczODc3,859,Cleaned up some console commands,26606778,OptimShi,closed,0,,,,,0,2018-07-09T17:51:23Z,2020-06-15T20:59:02Z,2018-07-09T19:46:34Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/859,"Some commands defined as console or none (which is basically ""any"") either should not have been or had no handling if they were. Just some tidying up, really.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/859/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339589529,MDExOlB1bGxSZXF1ZXN0MjAwMjA2MTc1,860,Fixing sliding along the edge of cliffs,8909245,gmriggs,closed,0,,,,,1,2018-07-09T20:09:10Z,2018-07-10T13:44:43Z,2018-07-10T13:44:43Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/860,"- Fixed a bug where StepUpHeight and StepDownHeight were reversed
- Fixed a conversion error between degrees and radians
- Fixed a bug with EdgeSlide/PrecipiceSlide where the player and creatures would get stuck at the edge of cliffs
- Updated CellArray iterators to check newly added cells
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/860/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339653615,MDExOlB1bGxSZXF1ZXN0MjAwMjU0ODU1,861,Fix missing null check,10137,ghost,closed,0,,,,,0,2018-07-10T00:39:58Z,2018-07-10T03:51:22Z,2018-07-10T01:50:50Z,NONE,,0,ACEmulator/ACE/pulls/861,-Add null check at end of CreateEnchantment(),"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/861/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339731800,MDExOlB1bGxSZXF1ZXN0MjAwMzEwNzI2,862,Fixing water depth,8909245,gmriggs,closed,0,,,,,0,2018-07-10T07:56:45Z,2018-07-10T22:01:33Z,2018-07-10T22:01:33Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/862,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/862/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339877453,MDExOlB1bGxSZXF1ZXN0MjAwNDIzMTc1,863, Fix spell reflection from Player to Item ,10137,ghost,closed,0,,,,,0,2018-07-10T14:49:14Z,2018-07-11T14:00:52Z,2018-07-11T01:04:36Z,NONE,,0,ACEmulator/ACE/pulls/863,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/863/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
339960989,MDU6SXNzdWUzMzk5NjA5ODk=,864,Inventory Functions Do Not Check for Burden,26606778,OptimShi,closed,0,10608427,Mag-nus,,,1,2018-07-10T18:37:57Z,2019-01-04T01:58:51Z,2019-01-04T01:58:51Z,COLLABORATOR,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ X ] bug report -> please search issues before submitting
- [ ] feature request
```
### Repro steps.
* Load up character to full 300% burden
* Pick up more items. 

### The log given by the failure.
n/a

### Desired functionality.
* Items should not be added/transferred.
* Should generate WeenieError.YouAreTooEncumbered or WeenieErrorWithString._CannotCarryAnymore


### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->

Probably easiest to adjust inventory functions and let those handle all errors, as opposed to adding functionality within each system (e.g. Recipes, Loot, etc)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/864/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
339967268,MDU6SXNzdWUzMzk5NjcyNjg=,865,Stacking Into Containers,26606778,OptimShi,closed,0,10608427,Mag-nus,,,1,2018-07-10T18:57:47Z,2019-01-04T01:58:54Z,2019-01-04T01:58:54Z,COLLABORATOR,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ X ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
* /ci 8327 (Gold Pea)
* /ci 8327 (Gold Pea)
* /ci 136 (Pack)
* Place one Gold Pea into the Pack.
* Place the other Gold Pea into the Pack
Peas stack and are placed into main backpack.

### Desired functionality.
The Gold Peas should be in the Pack, not the main backpack.

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/865/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
339984691,MDU6SXNzdWUzMzk5ODQ2OTE=,866,Picking Up Open Container,26606778,OptimShi,closed,0,10608427,Mag-nus,,,1,2018-07-10T19:55:38Z,2018-09-11T12:58:46Z,2018-09-11T12:58:46Z,COLLABORATOR,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [ X ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.

* /ci 136 (Pack)
* Drop pack into world.
* Open Pack
* Pick up pack without closing.

Packed will be placed into inventory, but is locked. If placed back on ground, user will be unable to open it. Not tested, but I assume you can also pick up a pack while another player is using it. YOINK!

### Desired functionality.

* If player picking up the pack is the one with it open, the pack will remove/set to false the IsOpen flag when picking it up.
* If another player has the pack open, generate error (Perhaps WeenieError.Frozen - ""The item is under someone else's control!"")
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/866/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
339985807,MDExOlB1bGxSZXF1ZXN0MjAwNTA3MDM0,867,Fix for using recipe items located in Packs,26606778,OptimShi,closed,0,,,,,4,2018-07-10T19:59:22Z,2020-06-15T20:59:02Z,2018-07-11T22:03:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/867,"This addresses Issue #779 

To test:

* /ci 8327 (Gold Pea)
* /ci 8283 (Splitting Tool)
* /ci 136 (Pack)
* Place these items in the Pack.
* Use the Splitting Tool on the Gold Pea in Pack.

Gold Pea should be removed and Gold Scarabs placed in main backpack.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/867/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
340465938,MDExOlB1bGxSZXF1ZXN0MjAwODcxNDY1,868,EmoteManager refactoring,8909245,gmriggs,closed,0,,,,,1,2018-07-12T02:17:43Z,2018-07-13T03:23:51Z,2018-07-13T03:23:51Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/868,"Tested:

Temple of Forgetfulness:
/create 22754
http://asheron.wikia.com/wiki/Attribute_and_Skill_Redistribution
Giving spell component to statue, correct emote actions are executed

Olthoi Hunter:
/create 3930
/ci helmolthoi
Giving classic Olthoi Helm to Olthoi Hunter, the new Olthoi Helm is received
There is a small issue with this one, and it probably existed before: the player give -> npc message is received at the end of the chain instead of the beginning","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/868/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
340657371,MDExOlB1bGxSZXF1ZXN0MjAxMDE2MzUw,869,Rework AppraisalInfo for Enchants,10137,ghost,closed,0,,,,,0,2018-07-12T14:15:40Z,2018-07-16T15:48:35Z,2018-07-13T01:35:57Z,NONE,,0,ACEmulator/ACE/pulls/869,"Rework AppraisalInfo to differentiate between intrinsic spells and applied spells
- ""spellbook"" data sent in AppraisalInfo packet uses highest bit of uint to indicated whether intrinsic spell of item or applied enchant
- WeenieType.Cothing enchants are applied to the item
- Account for debuffs applied to wielded weapons
- Enchants applied to armor affecting armor stats fixed to display correctly

![image](https://user-images.githubusercontent.com/22699181/42639077-0bbc2ce8-85a4-11e8-82c1-292c516b7f66.png)
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/869/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341000258,MDExOlB1bGxSZXF1ZXN0MjAxMjc2NTQz,870,Fixing RunRate,8909245,gmriggs,closed,0,,,,,0,2018-07-13T12:28:13Z,2018-07-13T14:12:58Z,2018-07-13T14:12:58Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/870,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/870/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341128088,MDExOlB1bGxSZXF1ZXN0MjAxMzc1NDkz,871,Misc. Fixes,10137,ghost,closed,0,,,,,0,2018-07-13T19:06:16Z,2018-07-16T15:48:32Z,2018-07-14T06:19:55Z,NONE,,0,ACEmulator/ACE/pulls/871,"-Fix vendor buying
-Change Enchantment removal type on item running out of mana from DispelEnchantment to RemoveEnchantment
-Added removal of Enchantments when dropping or giving an item away straight from being wielded
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/871/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341204805,MDExOlB1bGxSZXF1ZXN0MjAxNDMzNTYz,872,Fixed Spell Formulas,26606778,OptimShi,closed,0,,,,,0,2018-07-14T03:24:10Z,2020-06-15T20:59:03Z,2018-07-14T04:38:11Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/872,"In console, enter the following commands:
* getspellformula account 1
* getspellformula account 3452
* getspellformula account 3976
* getspellformula account 4024

All should generate appropriate looking results.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/872/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341293954,MDExOlB1bGxSZXF1ZXN0MjAxNDgyMDUx,873,Adding TargetManager,8909245,gmriggs,closed,0,,,,,0,2018-07-15T05:40:17Z,2018-07-16T06:52:32Z,2018-07-16T06:52:32Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/873,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/873/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341472629,MDExOlB1bGxSZXF1ZXN0MjAxNjAxNTM1,874,Fixing indoor->outdoor cell transitions,8909245,gmriggs,closed,0,,,,,0,2018-07-16T10:55:06Z,2018-07-16T20:50:27Z,2018-07-16T20:50:27Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/874,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/874/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341574678,MDExOlB1bGxSZXF1ZXN0MjAxNjgwMzY3,875,Redirect Impen/Banes from player to equipped armor and undergarments,10137,ghost,closed,0,,,,,1,2018-07-16T15:47:45Z,2018-07-23T03:28:18Z,2018-07-17T14:13:22Z,NONE,,0,ACEmulator/ACE/pulls/875,"- Adds functionality of redirecting Impen/Banes from a player to their equipped armor and undergarments.
- Mana consumption appropriate for number of WeenieType.Clothing items spells cast on
- Change damage calcs to point to armor pieces for enchants from the player wearing the items","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/875/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341726816,MDExOlB1bGxSZXF1ZXN0MjAxNzk2Nzk2,876,AdjusSpell Words,26606778,OptimShi,closed,0,,,,,0,2018-07-17T00:48:36Z,2020-06-15T20:59:03Z,2018-07-18T00:25:39Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/876,"Spell Words now load with the SpellTable to make them easier to reference.
Fixed case with certain spells that had no second word (so the resulting third word became the second word but was not properly capitalized)

To verify, in the ACE console type the following commands the resulting spell words that are displayed should appear correct. Note that the third test option below has no spell words, and returns an empty string.

* getspellformula account 1
* getspellformula account 5347
* getspellformula account 2028","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/876/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
341898141,MDU6SXNzdWUzNDE4OTgxNDE=,877,Transition from ActionChains for client ActionHandlers to a UseManager,10608427,Mag-nus,closed,0,,,,,1,2018-07-17T12:29:45Z,2018-08-06T08:26:08Z,2018-08-06T08:26:08Z,MEMBER,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [X ] feature request
```

During the multi-threading development of ACE, ddevec did some great work with ActionChains. They've taken us pretty far, but as we learn more, it appears they may not be the best fit for what we're trying to accomplish.

A few of the negatives we've faced with action chains are:

- Difficult to understand what's going on behind the scenes
- Difficult system to explain
- Even after months of using them, we still have questions
- Hard for new developers to use
- No easy mechanism for cancelling previous actions gracefully

With the release of the GDL source code, we can see a different take on solving this problem by Pea. His solution was UseManager.cpp:
https://github.com/GamesDeadLol/GDL/blob/510faa71f5da8c45c89a1def3c49b2de2fc85801/UseManager.cpp 

This seems to be a better fit for managing client actions. This also provides a more graceful way for cancelling previous client actions (this is a pretty big requirement).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/877/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
341951227,MDExOlB1bGxSZXF1ZXN0MjAxOTY2MjYy,878,Fix Aura redirection,10137,ghost,closed,0,,,,,0,2018-07-17T14:43:35Z,2018-07-23T03:28:19Z,2018-07-18T00:26:00Z,NONE,,0,ACEmulator/ACE/pulls/878,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/878/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
342339984,MDExOlB1bGxSZXF1ZXN0MjAyMjYyMTU3,879,ACE.Entity.Enum formatting and adding [Flags] where appropriate,10608427,Mag-nus,closed,0,,,,,0,2018-07-18T13:56:48Z,2018-07-19T02:19:12Z,2018-07-19T02:19:12Z,MEMBER,,0,ACEmulator/ACE/pulls/879,This is work I'm doing to prepare ACE.Entity to be the base library for other tools like ACLogView,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/879/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
342622099,MDExOlB1bGxSZXF1ZXN0MjAyNDc2OTgz,880,Enforce item wield requirements,10137,ghost,closed,0,,,,,0,2018-07-19T08:08:00Z,2018-07-23T03:28:20Z,2018-07-19T14:26:43Z,NONE,,0,ACEmulator/ACE/pulls/880,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/880/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
342666837,MDExOlB1bGxSZXF1ZXN0MjAyNTExMTEz,881,Fixing projectile velocity,8909245,gmriggs,closed,0,,,,,0,2018-07-19T10:16:00Z,2018-07-19T14:23:44Z,2018-07-19T14:23:43Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/881,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/881/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
342850522,MDExOlB1bGxSZXF1ZXN0MjAyNjUzNjgw,882,Adding scenery details,8909245,gmriggs,closed,0,,,,,0,2018-07-19T19:00:09Z,2018-07-19T23:42:08Z,2018-07-19T23:42:08Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/882,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/882/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343343308,MDExOlB1bGxSZXF1ZXN0MjAzMDE5NzU0,883,Fix wield requirements and item enchant removals,10137,ghost,closed,0,,,,,0,2018-07-21T17:44:41Z,2018-07-23T03:28:21Z,2018-07-22T01:00:16Z,NONE,,0,ACEmulator/ACE/pulls/883,"-Add different wield requirement scenarios
-Fix removal of impen/banes cast by items on themselves
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/883/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343401295,MDU6SXNzdWUzNDM0MDEyOTU=,884,Database schema oddities,10608427,Mag-nus,closed,0,10608427,Mag-nus,,,1,2018-07-22T12:13:22Z,2018-07-22T19:14:59Z,2018-07-22T19:14:59Z,MEMBER,,,,"WeenieClassId: Are we using int or uint
WeeniePropertiesEmoteAction.WeenieClassId is defined as a (int?)
WeeniePropertiesCreateList.WeenieClassId is defined as a (uint)

Properties that exist in PY16 source but not ACE EF models:
Recipe.Unknown4","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/884/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
343424750,MDExOlB1bGxSZXF1ZXN0MjAzMDY4MTk2,885,More enums added from the client/ACLogView to ACE.Entity.Enum,10608427,Mag-nus,closed,0,,,,,0,2018-07-22T17:43:31Z,2018-07-22T19:43:10Z,2018-07-22T19:10:49Z,MEMBER,,0,ACEmulator/ACE/pulls/885,"Note that HookType exists in both:
ACE.Entity.Enum
ACE.Server.Physics.Hooks

The one in Physics should probably be renamed to PhysicsHookType so that the more global one in ACE.Entity.Enum can maintain consistant naming with the client.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/885/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343427616,MDExOlB1bGxSZXF1ZXN0MjAzMDY5ODQ0,886,SQL Re-Base and EF Re-Scaffold,11369233,LtRipley36706,closed,0,,,,,0,2018-07-22T18:25:12Z,2019-01-05T23:23:06Z,2018-07-22T19:14:59Z,MEMBER,,0,ACEmulator/ACE/pulls/886,"Resolves #884 
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/886/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343428456,MDU6SXNzdWUzNDM0Mjg0NTY=,887,Landblock Double+ Spawns,11369233,LtRipley36706,closed,0,,,,,1,2018-07-22T18:37:50Z,2018-08-17T09:47:43Z,2018-08-17T09:47:43Z,MEMBER,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ x ] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
<!-- Please list the steps to reproduce a bug here -->
Load ACE
/telepoi Holtburg
run to Meeting Hall and enter portal
wait inside hall approx. 3 minutes
use exit portal
return to Holtburg to find duplicated spawns

### The log given by the failure.
<!-- Normally this include a stack trace and some other information about the failure. -->
N/A

### Desired functionality.
<!--
What would like to see implemented?
What is the use case?
-->
NPCs and other objects spawn once, or correctly.

### Mention any other details that might be useful.
<!-- Please include any information that can help clarify the request here -->
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/887/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
343433250,MDExOlB1bGxSZXF1ZXN0MjAzMDczMzA5,888,Rename the HookType in Physics to PhysicsHookType and rename the one …,10608427,Mag-nus,closed,0,,,,,0,2018-07-22T19:50:34Z,2018-07-22T20:07:43Z,2018-07-22T20:06:19Z,MEMBER,,0,ACEmulator/ACE/pulls/888,"…in ACE.Entity.Enum to HookType

This helps keep the pattern where objects in ACE.Entity.Enum match the client naming","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/888/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343438969,MDExOlB1bGxSZXF1ZXN0MjAzMDc2OTEw,889,This moves the .sql file generation code that Ripley has been using into ACE.Database,10608427,Mag-nus,closed,0,,,,,1,2018-07-22T21:09:44Z,2018-07-29T02:01:20Z,2018-07-29T02:01:20Z,MEMBER,,0,ACEmulator/ACE/pulls/889,"This will help us import data from any source into ACE EF objects, and then use these SQLWriters to create a unified output.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/889/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343475782,MDExOlB1bGxSZXF1ZXN0MjAzMTAwNjQ1,890,Add PortalSending and PortalSummon functionality,10137,ghost,closed,0,,,,,0,2018-07-23T03:30:02Z,2018-07-25T23:47:05Z,2018-07-23T07:57:46Z,NONE,,0,ACEmulator/ACE/pulls/890,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/890/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
343515731,MDExOlB1bGxSZXF1ZXN0MjAzMTI5NTky,891,Adding physics enums,8909245,gmriggs,closed,0,,,,,0,2018-07-23T07:21:02Z,2018-07-24T08:23:15Z,2018-07-24T08:23:15Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/891,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/891/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
344053574,MDExOlB1bGxSZXF1ZXN0MjAzNTM5NTYz,892,Three Emote Manager fixes/changes,10137,ghost,closed,0,,,,,0,2018-07-24T14:06:52Z,2018-07-25T23:47:03Z,2018-07-24T19:07:14Z,NONE,,0,ACEmulator/ACE/pulls/892,"-EmoteManager.Execute() moved to a new partial class of EmoteManager and Obsolete attribute and commenting added, as it may cause confusion as to which emote execute function to use
-Implement EmoteType.Act
-Change the target of the PlayScript in EmoteType.PhysScript from targetObject to the WorldObject that is using the emote
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/892/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
344598617,MDExOlB1bGxSZXF1ZXN0MjAzOTU2NjQ3,893,Add 2 second delay to Recall spells,10137,ghost,closed,0,,,,,0,2018-07-25T20:39:30Z,2018-07-27T23:47:01Z,2018-07-25T23:47:25Z,NONE,,0,ACEmulator/ACE/pulls/893,A 2 second delay was added to the casting of the recall spells in patch Thorns of the Hopeslayer,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/893/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
344796954,MDExOlB1bGxSZXF1ZXN0MjA0MTA1NDky,894,Adding full monster movement physics,8909245,gmriggs,closed,0,,,,,0,2018-07-26T11:02:19Z,2018-07-27T18:02:48Z,2018-07-27T18:02:48Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/894,"- Added MoveToManager, PositionManager, and StickyManager integration with ACE
- Enabled /forcepos as default setting
- Improved projectile physics. Projectiles should hit targets much more consistently now
- Added PostInit() system to WorldObjectFactory
- Fixed a bug in the animation system where objects were jumping to the last frame
- Fixed a crash with the static transitions","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/894/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345062436,MDExOlB1bGxSZXF1ZXN0MjA0MzA5ODIz,895,Adjust Emote item interactions and Player and item interactions,10137,ghost,closed,0,,,,,0,2018-07-27T01:50:27Z,2018-07-27T23:47:03Z,2018-07-27T13:48:57Z,NONE,,0,ACEmulator/ACE/pulls/895,Adjust Emote and Attuned item handling according to PCAP data findings,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/895/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345319126,MDExOlB1bGxSZXF1ZXN0MjA0NTAzMTgz,896,"Adding jump packet, EmoteManager cleanup",8909245,gmriggs,closed,0,,,,,0,2018-07-27T18:12:39Z,2018-07-28T16:15:08Z,2018-07-28T16:15:08Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/896,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/896/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345406420,MDExOlB1bGxSZXF1ZXN0MjA0NTY5NDM3,897,Fix Null exception of dropping an item,10137,ghost,closed,0,,,,,0,2018-07-28T01:34:51Z,2018-07-28T05:59:57Z,2018-07-28T01:41:49Z,NONE,,0,ACEmulator/ACE/pulls/897,"Fix the missing PhysicsObj for items that start life as non-world objects, when item is dropped onto the 3D world","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/897/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345409542,MDExOlB1bGxSZXF1ZXN0MjA0NTcxMjcz,898,Move InitPhysicsObj call to Landblock.AddWorldObjectInternal(),10137,ghost,closed,0,,,,,0,2018-07-28T02:21:08Z,2018-07-28T05:59:55Z,2018-07-28T02:23:51Z,NONE,,0,ACEmulator/ACE/pulls/898,"-Move the creation of a WorldObject's PhysicsObj to a singular location in Landblock.AddWorldObjectInternal(), with a check for a preexisting PhysicsObj, so it is created when an object is placed in the world","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/898/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345415484,MDExOlB1bGxSZXF1ZXN0MjA0NTc0NjY1,899,Revert Move InitPhysicsObj call to Landblock.AddWorldObjectInternal,8909245,gmriggs,closed,0,,,,,0,2018-07-28T03:52:58Z,2018-07-28T03:56:41Z,2018-07-28T03:56:41Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/899,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/899/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345415647,MDExOlB1bGxSZXF1ZXN0MjA0NTc0NzM3,900,Partial Revert previous commit,10137,ghost,closed,0,,,,,0,2018-07-28T03:55:08Z,2018-07-28T05:59:53Z,2018-07-28T03:58:39Z,NONE,,0,ACEmulator/ACE/pulls/900,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/900/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345421925,MDExOlB1bGxSZXF1ZXN0MjA0NTc4NTQz,901,Allow giving Attuned items to appropriate NPCs,10137,ghost,closed,0,,,,,0,2018-07-28T05:57:33Z,2018-07-30T02:40:20Z,2018-07-28T18:30:47Z,NONE,,0,ACEmulator/ACE/pulls/901,-Allow giving Attuned items to appropriate NPCs but still prevent passing attuned items to other players,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/901/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345460148,MDExOlB1bGxSZXF1ZXN0MjA0NTk5NzQy,902,Pending motion queue fix,8909245,gmriggs,closed,0,,,,,0,2018-07-28T16:14:51Z,2018-07-28T18:08:23Z,2018-07-28T18:08:23Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/902,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/902/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345461897,MDU6SXNzdWUzNDU0NjE4OTc=,903,landblock_instances and parent_link_slot,10608427,Mag-nus,closed,0,11369233,LtRipley36706,,,1,2018-07-28T16:38:36Z,2018-08-06T08:25:07Z,2018-08-06T08:25:06Z,MEMBER,,,,"First, landblock_instances should be renamed to landblock_instance.

Secondly, we don't have a provision to handle link slots that have a parent.

In this file:
https://github.com/ACEmulator/ACE-World-16PY/blob/master/Database/3-Core/6%20LandBlockExtendedData/SQL/0200.sql
Search for 1881145399.

You'll notice that the link_slot is first being set to 2, but then being overwritten and set to 1.

To fix this, we need to add a parentLinkSlot field.

""Mansion links to House Portal, House Portal links to Portal Linkspot"".

UPDATE `landblock_instances` SET `link_Slot`='2', `parent_Link_Slot`='1' WHERE `guid`='1881145410'; /* Mansion <- House Portal <- Portal Linkspot */

These files will also need to be adjusted:
ACE.Database.SQLFormatters.World.LandblockInstancesWriter.cs
 - Add the new field to the sql writer output
 - Rename it to LandblockInstanceWriter.cs
PhatACCacheBinParser.ACE Helpers.LandBlockExtendedDataExtensions.cs
 - Calculate parentLinkSlot and set it accordingly

This is not very well documented, but Ripley knows of the issue and how to fix it.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/903/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
345504242,MDExOlB1bGxSZXF1ZXN0MjA0NjI2MDYw,904,Add check for target death before process Magic Damage,10137,ghost,closed,0,,,,,0,2018-07-29T05:50:07Z,2018-07-30T02:40:18Z,2018-07-30T02:15:58Z,NONE,,0,ACEmulator/ACE/pulls/904,"-Add checks before Magic Damage is calculated to ensure target isn't already dead
-Change EarnXP on creature kill to sharable
-Rearranged the flow of player spell casting, predominately moving the out-of-mana fizzle to after the spell windup animation and the speaking of the spell words
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/904/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345532333,MDExOlB1bGxSZXF1ZXN0MjA0NjQzMTIw,905, TreasureDeath and TreasureWielded SQLWriters added and tested. ,10608427,Mag-nus,closed,0,,,,,0,2018-07-29T13:49:22Z,2018-07-29T13:50:52Z,2018-07-29T13:50:03Z,MEMBER,,0,ACEmulator/ACE/pulls/905,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/905/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345532571,MDExOlB1bGxSZXF1ZXN0MjA0NjQzMjgz,906,TreasureDeath and TreasureWielded SQL Writers added and tested,10608427,Mag-nus,closed,0,,,,,0,2018-07-29T13:52:53Z,2018-07-29T13:57:46Z,2018-07-29T13:56:51Z,MEMBER,,0,ACEmulator/ACE/pulls/906,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/906/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345544244,MDExOlB1bGxSZXF1ZXN0MjA0NjUwMzUw,907,"Improved vital regeneration, stamina usage",8909245,gmriggs,closed,0,,,,,0,2018-07-29T16:35:25Z,2018-07-30T05:35:49Z,2018-07-30T05:35:49Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/907,"- Updated EnchantmentManager queries to use the top layer for each SpellCategory
- Updated WeaponDefense and WeaponOffense enchantments to be additive floats
- Improved vital regeneration formulas / ticking
- Improved healing formulas
- Added stance and enchantments to vital regeneration (regeneration/rejuvenation/mana renewal)
- Added basic stamina usage on evasion / jumping
- Fixed a bug in Player_Use not picking up or using items correctly","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/907/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345586984,MDExOlB1bGxSZXF1ZXN0MjA0Njc3MDM1,908,"Auras, imp, and banes for @buff [player name] and @fellowbuff",3317737,fartwhif,closed,0,,,,,0,2018-07-30T02:05:27Z,2018-12-07T02:14:10Z,2018-08-12T15:40:06Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/908,"including auras and equipped item impenetrability and banes for sentinel commands /buff [player name] and /fellowbuff
fixing bug causing wielded item buffs not to work for shields in some situations
curating some elements of Ace.Server/Network/Enum/Spell.cs to follow uppercase/lowercase guidelines and self/other differentiation","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/908/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345643342,MDExOlB1bGxSZXF1ZXN0MjA0NzE3NTQ3,909,Various tweaks,10137,ghost,closed,0,,,,,0,2018-07-30T07:34:06Z,2018-08-04T17:29:37Z,2018-07-31T07:02:34Z,NONE,,0,ACEmulator/ACE/pulls/909,"-Add GameEventPopupString message function to EmoteType.PopUp, when no confirmation is requested, and finish the Confirmation functionality
-Adjust the Welcome message to match retail, with a twist
-Change two more Spell references to SpellBase, in EnchantmentManager.cs
-Add GameEventCommunicationTransientString to Chest.cs, when chests are in the locked condition

","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/909/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345745740,MDExOlB1bGxSZXF1ZXN0MjA0Nzk0OTc0,910,"Enum comments added, Material renamed to MaterialType",10608427,Mag-nus,closed,0,,,,,0,2018-07-30T12:55:36Z,2018-07-30T21:28:36Z,2018-07-30T21:28:36Z,MEMBER,,0,ACEmulator/ACE/pulls/910,"MaterialType is what the client uses, and follows the patter we've been using for other enum names as well.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/910/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
345987251,MDExOlB1bGxSZXF1ZXN0MjA0OTY0NzA3,911,Rename SkillStatus to SkillAdvancementClass,10608427,Mag-nus,closed,0,,,,,0,2018-07-31T00:21:13Z,2018-07-31T12:31:57Z,2018-07-31T12:16:25Z,MEMBER,,0,ACEmulator/ACE/pulls/911,"SkillStatus and SkillAdvancementClass are neither the perfect names for what this value represents.

However, the client calls it SkillAdvancementClass. We call it SAC in the database. And GDLE also uses the SAC naming.

I think switching this name helps align ACE with the pdb without adding any additional confusion, meaning, this new name is equally as confusing as the previous, but at last its aligned with the pdb and gdle.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/911/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
346017632,MDExOlB1bGxSZXF1ZXN0MjA0OTgzMzkz,912,GroupChatType enum removed and Channel enum cleaned up.,10608427,Mag-nus,closed,0,,,,,0,2018-07-31T03:03:05Z,2018-07-31T12:31:46Z,2018-07-31T12:30:27Z,MEMBER,,0,ACEmulator/ACE/pulls/912,"GroupChatType was a duplicate enum of Channel. It's name came from old protocol docs.

The client pdb calls this enum ChannelId.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/912/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
346359595,MDExOlB1bGxSZXF1ZXN0MjA1MjQzMzg2,913,Update changelog for June-July,8909245,gmriggs,closed,0,,,,,0,2018-07-31T21:10:52Z,2018-09-01T02:50:41Z,2018-07-31T23:15:04Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/913,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/913/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
346433953,MDExOlB1bGxSZXF1ZXN0MjA1Mjk4NjI4,914,Nuget packages update (EF Core 2.1) + Lazy loading database issue in Shard,10608427,Mag-nus,closed,0,,,,,0,2018-08-01T03:23:42Z,2018-08-01T13:33:40Z,2018-08-01T13:32:29Z,MEMBER,,0,ACEmulator/ACE/pulls/914,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/914/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
346612807,MDExOlB1bGxSZXF1ZXN0MjA1NDM1MDUx,915,All 3 databases rescaffolded,10608427,Mag-nus,closed,0,,,,,0,2018-08-01T13:59:25Z,2018-08-01T14:05:42Z,2018-08-01T14:05:22Z,MEMBER,,0,ACEmulator/ACE/pulls/915,"This simply updates the files to the latest formats generated by Pomelo.

This gets format changes out of the way so that future schema changes show only the fields changed, and not additional format changes.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/915/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
346652745,MDExOlB1bGxSZXF1ZXN0MjA1NDY1NzU3,916,"Improved stamina usage, added DamageHistory system, refactored death system, monster attributeMod",8909245,gmriggs,closed,0,,,,,0,2018-08-01T15:32:12Z,2018-08-02T23:20:33Z,2018-08-02T23:20:33Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/916,"- Added player stamina usage on melee / missile attack
- Refactored the death system
- Added Damage History system to track damage and healing sources - for corpse looting rights
- Fixed a bug where player death was removing enchantments on the client only
- Improved player exhaustion system. Both players and monsters now receive attack and defense penalties when stamina = 0
- Added attribute mod to monster damage. Some monsters now deal significantly more damage, so beware!
- Fixed a bug where a player autoattack could occur after death
- Fixed a bug where attributes could be debuffed below 10 on the server
- Fixed a bug with MaxVital calculation with vitae
- Updated shield effective angle to match retail

From Jyrus:

- Updated Life Magic code to properly utilize the DamageHistory for tracking damage through harm/drain/heals
- Fixed all compiler warnings
- Refactored spell resistance to common method for all creatures (players / monsters)
- Spell level now determined by Scarab instead of PowerLevel, as per retail servers and client","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/916/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
346717556,MDExOlB1bGxSZXF1ZXN0MjA1NTE0MjAx,917,Add support for Volley spells,19214857,Slushnas,closed,0,,,,,1,2018-08-01T18:33:03Z,2018-08-02T14:05:57Z,2018-08-02T14:05:57Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/917,"This adds initial support for Volley type spells. I just put static creation offsets in for now until the correct formula is know for finding them.

Thanks to @gmriggs for some pointers on some of the physics related errors I encountered after implementation that needed to be fixed/tweaked.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/917/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347501024,MDU6SXNzdWUzNDc1MDEwMjQ=,918,Improve ObjectGUID allocation,10608427,Mag-nus,closed,0,10608427,Mag-nus,,,3,2018-08-03T18:51:26Z,2019-03-08T02:18:12Z,2019-03-08T02:18:11Z,MEMBER,,,,"Here are some notes from Reefcull, thanks to Morosity.

Reefcull uses the same system currently implemented in ACE where ID's are generated in n+1 fashion, starting from 0x80000000 with no reclaiming.

Reefcull has been up for 8 months now, and used approximately 2.1 billion ID's.
Reefcull has an average active online count of around 400.
Reefcull consumes at peak about 125/s, and low times 50/s.
Reefcull is about to run out of ID's.

There are several possible solutions:

1. Use a specific small range for short lived (ephemeral) objects like arrows.
 - Can an arrow be picked up off the ground?
 - This still suffers from the eventual n+1 end of range issue
2. Recycle id's for ephemeral objects
 - Maybe on initial load, the server gathers a list of available id's from the database and enters these into a picker pool. If the pool gets used up, new id's will be generated adding to the n+1.
 - When an ephemeral item is destroyed, add it's id back into the pool.
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/918/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
347590172,MDExOlB1bGxSZXF1ZXN0MjA2MTc3MzI1,919,Resolve apparent logic error in learnspellsinbulk method which caused…,25518589,mcreedjr,closed,0,,,,,2,2018-08-04T05:39:10Z,2018-08-11T04:32:14Z,2018-08-04T06:06:39Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/919,… certain spells to not be learned as expected,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/919/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347592616,MDExOlB1bGxSZXF1ZXN0MjA2MTc4Njcx,920,physics state sync between WorldObject and PhysicsObj,8909245,gmriggs,closed,0,,,,,0,2018-08-04T06:24:12Z,2018-08-06T04:05:28Z,2018-08-06T04:05:28Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/920,"This patch synchronizes the physics state between WorldObject and PhysicsObj

PhysicsObj.State should be the backing store, with WorldObject having easily accessible bool properties, which also persist to PropertyBool for the appropriate fields

This patch also re-introduces Jyrus' change to move InitPhysicsObj() to LandblockManager.AddWorldObjectInternal(). This still needs additional testing, and it seems like we should be initting the PhysicsObjs before this method is called. It is a very convenient entrypoint at the moment though, as it ensures only PhysicsObjs are created for objects upon entry into the 3D world.

There could still be some possible issues though (multithreading?), for example the bug with players entering portals and re-appearing in their original location.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/920/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347674433,MDExOlB1bGxSZXF1ZXN0MjA2MjI1MTE5,921,Move PK checks and spell damage messages and implement SpellType.PortalLink,10137,ghost,closed,0,,,,,0,2018-08-05T06:50:14Z,2018-08-05T21:54:09Z,2018-08-05T14:44:01Z,NONE,,0,ACEmulator/ACE/pulls/921,"-Move PK checks to after start of spell cast and one spell projectile collision
-Move spell damage messages to be mutually exclusive with the death messages
-Implement SpellType.PortalLink (Primary Portal, Secondary Portal, and LIfestone Tie)","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/921/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347709959,MDExOlB1bGxSZXF1ZXN0MjA2MjQ1ODI0,922,Randomize spell death messages,10137,ghost,closed,0,,,,,0,2018-08-05T16:00:51Z,2018-08-05T23:47:35Z,2018-08-05T23:46:47Z,NONE,,0,ACEmulator/ACE/pulls/922,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/922/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347790778,MDExOlB1bGxSZXF1ZXN0MjA2Mjk3NTMz,923,Change spell casting busy and Spell words ChatMessageType,10137,ghost,closed,0,,,,,0,2018-08-06T06:09:57Z,2018-08-07T00:53:56Z,2018-08-06T07:14:32Z,NONE,,0,ACEmulator/ACE/pulls/923,"-Rearrange spell casting busy state notifications to match PCAPs
-Change ChatMessageType for spell words, allowing VT decal plugin to cast spells without any duplicate casts ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/923/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347799066,MDExOlB1bGxSZXF1ZXN0MjA2MzAzNjA5,924,"Major Schema Refactoring, Improvements, Changes",10608427,Mag-nus,closed,0,,,,,0,2018-08-06T06:48:11Z,2018-08-08T02:11:24Z,2018-08-06T07:36:19Z,MEMBER,,0,ACEmulator/ACE/pulls/924,"Please see individual commits for detailed changes.

** DO NOT MERGE ** until we publish a new PY16","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/924/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347939675,MDExOlB1bGxSZXF1ZXN0MjA2NDExMDAw,925,Update Readme.md with new minimum 16PY World DB version,10137,ghost,closed,0,,,,,0,2018-08-06T14:09:10Z,2018-08-07T00:58:30Z,2018-08-06T14:12:38Z,NONE,,0,ACEmulator/ACE/pulls/925,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/925/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
347939818,MDExOlB1bGxSZXF1ZXN0MjA2NDExMTEw,926,Target .NET Core 2.1 instead of 2.0,10608427,Mag-nus,closed,0,,,,,0,2018-08-06T14:09:34Z,2018-08-08T02:11:05Z,2018-08-07T03:16:32Z,MEMBER,,0,ACEmulator/ACE/pulls/926,"To develop, the .NET Core 2.1 x64 SDK is needed from here:
https://www.microsoft.com/net/download/visual-studio-sdks","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/926/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348073466,MDExOlB1bGxSZXF1ZXN0MjA2NTEwMTE1,927,Adding object spawning / initial placement system,8909245,gmriggs,closed,0,,,,,0,2018-08-06T20:37:49Z,2018-08-08T01:41:21Z,2018-08-08T01:41:21Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/927,"AddPhysicsObj() has been added, which calls PhysicsObj.enter_world() for proper initial placement","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/927/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348544043,MDExOlB1bGxSZXF1ZXN0MjA2ODcwMzIz,928,Character refactor,10608427,Mag-nus,closed,0,,,,,0,2018-08-08T01:40:53Z,2018-08-08T02:10:47Z,2018-08-08T02:08:22Z,MEMBER,,0,ACEmulator/ACE/pulls/928,"This removes Character as the parent of a Biota, and instead, makes them side by side objects that are owned by Player.

Session no longer owns Character.

Session maintains a list of the Characters for the account.

Session holds a reference to the current Player being used.

Player holds a reference to Biota and Character objects.

What I said in discord:

We have the Player object (our god class).

To put a player in the world, it requires a biota. It doesn't require a character or session.
To manipulate the player, we need a session (but not a character).
To give the player a user interface, we need a character.

The character holds all the user progress of the particular biota it's associated with.

So, a session holds a link to the current player the session is managing.

Player holds a link to the biota and character that represent the player.

The biota represents the player from the worlds pov.
The character represents the player from the users pov.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/928/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348544397,MDExOlB1bGxSZXF1ZXN0MjA2ODcwNTc1,929,Adding object spawning / initial placement system,8909245,gmriggs,closed,0,,,,,0,2018-08-08T01:43:03Z,2018-08-09T02:43:24Z,2018-08-09T02:43:24Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/929,"AddPhysicsObj() has been added, which calls PhysicsObj.enter_world() for proper initial placement","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/929/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348550681,MDU6SXNzdWUzNDg1NTA2ODE=,930,Alter Shard Schema to avoid record caps based on uint32,11369233,LtRipley36706,closed,0,10608427,Mag-nus,,,4,2018-08-08T02:20:28Z,2020-01-05T18:48:33Z,2020-01-05T18:48:32Z,MEMBER,,,,"As of writing in ACE the following tables for characters have a cap of UINT32.MaxValue
```
            CharacterPropertiesContract = new HashSet<CharacterPropertiesContract>();
            CharacterPropertiesFillCompBook = new HashSet<CharacterPropertiesFillCompBook>();
            CharacterPropertiesFriendList = new HashSet<CharacterPropertiesFriendList>();
            CharacterPropertiesQuestRegistry = new HashSet<CharacterPropertiesQuestRegistry>();
            CharacterPropertiesShortcutBar = new HashSet<CharacterPropertiesShortcutBar>();
            CharacterPropertiesSpellBar = new HashSet<CharacterPropertiesSpellBar>();
            CharacterPropertiesTitleBook = new HashSet<CharacterPropertiesTitleBook>();
```

Each of these tables has the following first column
```
`id` int(10) unsigned NOT NULL AUTO_INCREMENT COMMENT 'Unique Id of this Property',
```
and that column is the primary key
```
PRIMARY KEY (`id`),
```

A way to avoid that problem, assuming Entity Framework supports it, is to change the primary key to a composite of multiple columns within the table that could be used as a unique record identifier

For example, in contracts table
```
PRIMARY KEY (`character_Id`, `contract_Id`),
``` 

Ideally, any table in shard might want to convert to composite keys but the most critical to start with would be the enchantment registry table as that one as the most churn I believe.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/930/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
348555777,MDExOlB1bGxSZXF1ZXN0MjA2ODc4NTg5,931,Reference cleanup with Player.Session + /comps debug command,10608427,Mag-nus,closed,0,,,,,0,2018-08-08T02:50:25Z,2018-08-08T02:53:51Z,2018-08-08T02:53:10Z,MEMBER,,0,ACEmulator/ACE/pulls/931,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/931/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348662448,MDExOlB1bGxSZXF1ZXN0MjA2OTU4MTgx,932,Adding dungeon position adjustments,8909245,gmriggs,closed,0,,,,,0,2018-08-08T10:15:18Z,2018-08-10T07:01:09Z,2018-08-10T07:01:09Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/932,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/932/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348744905,MDExOlB1bGxSZXF1ZXN0MjA3MDIyMzI5,933,Minor cleanup. Nothing major,10608427,Mag-nus,closed,0,,,,,0,2018-08-08T14:13:03Z,2018-08-08T14:18:03Z,2018-08-08T14:17:04Z,MEMBER,,0,ACEmulator/ACE/pulls/933,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/933/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348889576,MDExOlB1bGxSZXF1ZXN0MjA3MTM1NjY2,934,Adding spell components to /comps debug command,8909245,gmriggs,closed,0,,,,,0,2018-08-08T20:58:28Z,2018-08-08T22:59:28Z,2018-08-08T22:59:28Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/934,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/934/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348974282,MDExOlB1bGxSZXF1ZXN0MjA3MTk4MjQz,935,WorldDatabase WeenieCache improvements and Character Spellbar/etc fixes,10608427,Mag-nus,closed,0,,,,,0,2018-08-09T04:33:44Z,2018-08-09T04:37:49Z,2018-08-09T04:36:26Z,MEMBER,,0,ACEmulator/ACE/pulls/935,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/935/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
348983053,MDExOlB1bGxSZXF1ZXN0MjA3MjA0NjMz,936,Adding physics entity cache system,8909245,gmriggs,closed,0,,,,,0,2018-08-09T05:30:09Z,2018-08-10T23:56:26Z,2018-08-10T23:56:26Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/936,"This patch starts to cache some of the important physics entities in memory. The entity constructors have been replaced with calls to this caching system, which returns existing references if they are already in RAM

The result is a massive improvement with reduced memory usage, especially over the course of a lifetime for long-running servers.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/936/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349351192,MDExOlB1bGxSZXF1ZXN0MjA3NDg5MjY1,937,Session class improvements,10608427,Mag-nus,closed,0,,,,,0,2018-08-10T02:08:52Z,2018-08-10T02:21:07Z,2018-08-10T02:20:39Z,MEMBER,,0,ACEmulator/ACE/pulls/937,"Characters list now only loads once, on initial connect.

Session is no longer an IActor. Actions enqueued directly to the WorldManager.InboundMessageQueue

Other WorldManager ActionQueues given more descriptive names","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/937/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349398939,MDExOlB1bGxSZXF1ZXN0MjA3NTIzNzYx,938,Adding dungeon position adjustments,8909245,gmriggs,closed,0,,,,,0,2018-08-10T07:01:59Z,2018-08-10T07:10:36Z,2018-08-10T07:10:36Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/938,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/938/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349593934,MDExOlB1bGxSZXF1ZXN0MjA3NjczMjc2,939,Various small cleanups,10608427,Mag-nus,closed,0,,,,,0,2018-08-10T17:17:28Z,2018-08-10T17:21:28Z,2018-08-10T17:21:07Z,MEMBER,,0,ACEmulator/ACE/pulls/939,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/939/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349620520,MDExOlB1bGxSZXF1ZXN0MjA3NjkzNzA0,940,PropertyManager Database Cleanup,10608427,Mag-nus,closed,0,,,,,0,2018-08-10T18:48:57Z,2018-08-10T18:52:42Z,2018-08-10T18:52:20Z,MEMBER,,0,ACEmulator/ACE/pulls/940,"Previously, PropertyManager used SerializedShardDatabase to wrap it's database calls.

This didn't make much sense because SerializedShardDatabase was basically just a wrapper that serialized calls to ShardDatabase.

So, instead, we now have a ShardConfigDatabase class as well that is held by DatabaseManager. This holds the property/config specific funcitons for the shard.

In addition, there were a couple bugs fixed in PropertyManager where a function migt have been GetLong() when it should have been GetDouble(), etc...","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/940/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349693656,MDExOlB1bGxSZXF1ZXN0MjA3NzQ5OTk4,941,Major Shard Performance Improvements,10608427,Mag-nus,closed,0,,,,,1,2018-08-11T01:04:42Z,2018-08-11T01:31:02Z,2018-08-11T01:30:22Z,MEMBER,,0,ACEmulator/ACE/pulls/941,"The base Biota record now holds a flags property that indicates what collections are populated, and thus, what should be queried from the database.

GetPlayerBiotas and it's associated functions GetInventory and GetWieldedItems now use Parallel.ForEach loops which significantly improve performance.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/941/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349700587,MDExOlB1bGxSZXF1ZXN0MjA3NzU0NDg0,942,Creature GetNewFace fix for enum values,10608427,Mag-nus,closed,0,,,,,0,2018-08-11T03:02:56Z,2018-08-11T03:03:41Z,2018-08-11T03:03:28Z,MEMBER,,0,ACEmulator/ACE/pulls/942,"In the world data, some property strings don't have the exact case we have in the enums. Thus, a simple ignoreCase bool is needed.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/942/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349706677,MDExOlB1bGxSZXF1ZXN0MjA3NzU4MzUw,943,Added missing comma in updated ShardBase.sql,25518589,mcreedjr,closed,0,,,,,0,2018-08-11T05:10:22Z,2018-08-11T05:14:10Z,2018-08-11T05:14:10Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/943,I was unable to create a fresh Shard DB after @Mag-nus' previous PR seemingly due to a missing comma in ShardBase.sql. Thought I'd correct it for others.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/943/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349725535,MDU6SXNzdWUzNDk3MjU1MzU=,944,Melee attack penalty is not accurate for zero stamina,42293969,elrubaqur,closed,0,8909245,gmriggs,,,3,2018-08-11T10:51:20Z,2018-12-28T19:41:39Z,2018-12-28T19:41:39Z,NONE,,,,"### Bug Report or Feature Request (mark with an `x`)
```
- [x] bug report -> please search issues before submitting
- [ ] feature request
```

### Repro steps.
Per discussion with gmriggs, attack penalty for zero stamina is capped at -50.

### The log given by the failure.
None.

### Desired functionality.
What would like to see implemented?

The stamina penalty for melees is a defense penalty only, not attack. This is also true for archers. Like with Melees, the penalty is that the attack is equivalent to what it would be if you set your attack bar all the way to the left. For Archers, they lose accuracy, but no more than they would had they set the bar to the left themselves. They even shoot faster in this state (due to decreased accuracy), I know this to be true because I've done this in retail.

What is the use case?

Accurate Melee and Archer behavior for zero stamina, however edge of a case that may be.

### Mention any other details that might be useful.
My assertion here is that there is no statistical difference in attack success rate for stamina and no stamina for melees. This is supported by my own experience and discussions with other melees on Discord. Zero stamina is a state that I often played in and is a tactic used by many shield-wielding melees. It is a known game mechanic to melees, but unfortunately there is mis-information stemming from a single ACWkiki article that has since migrated to ACPedia and copied by ACWikia. I have played melees since Beta and I know that this to attack penalty for zero stamina was never true, not even in Beta.

Below is objective proof of these scenarios:

Video: https://www.youtube.com/watch?v=CyzfhIgqsiU
Time: 5:59 to 6:22

- 	Fights a Hollow mob.
- 	25 swings/6 misses = 76%  success rate (Stamina)

Time: 6:22 to 6:40

- 	Continues fighting the same mob.
- 	21 swings/8 misses = 61%  success rate (No Stamina)

I will note here that the sample size is small, but this will be clearer by the other videos below. Yes, it is lower for no stamina, but consider the sample size. Overtime, I know that these two states (stamina vs. no stamina) will have no statistical variation. This was confirmed in the ACForums before, but unfortunately we no longer have that resource. 

Video: https://www.youtube.com/watch?v=fwb9fnv71UI
Time: 1:47 to 2:32

- 	Kills 3 Dark Leechs in 60 hits.
- 	60 swings/7 misses = 88.33%  success rate (Stamina)

Time: 4:17 to 4:27 

- 	Kills 1 Dark Leech in 12 hits.
- 	12 swings/2 misses = 83.33%  success rate (No Stamina)

Again, I believe this to be a statistical insignificance given the way AC's combat system works. Yes, it is lower, but again it is within an acceptable range variation for AC's combat system since even a character with stamina will produce the same variation. Later in the video, he attacks a Dark Magus and misses significantly. However, that mob has +50 MeleeD compared to the Dark Leech. I would have included those stats here, but there are no ""with stamina"" metrics to measure against. To measure them against the Dark Leech stats would not be accurate given the significant difference in MeleeD (Also, note how significant a -50 MeleeD impacts a melees attack success rate).

Video: https://www.youtube.com/watch?v=MUaD53D9c74
Time: 1:20 to 1: 49

- 	Fights a Drudge Skulker.
- 	21 swings/17 misses = 19.04% success rate (Stamina)

Time: 1:49 to: 2:31

- 	Continues fighting the same Drudge Skulker.
- 	32 swings/24 misses = 25% success rate (No stamina)

And finally, this video shows this same variation, but in the opposite direction. If there was an attack penalty for zero stamina of any kind, it would dramatically impact the hit rate for this character since his attack rate was already at 20%. Given the bell curve of ACs combat system, this would have been immediately measurable in the next 32 attacks. However, this user's attack success rate had actually increased. This shows the same statistical variation as the other two videos.

There is no attack penalty for zero stamina. Even as noted as far back as Nov. 2000 in this article: http://mu.ranter.net/asherons-call/aphonouss-melee-vs-mage-comparison ""Attacks at full skill but minimum power without stamina."" Mu was correct then and it was correct at the end of Jan. 2017. This has been confirmed with players on Discord who have actually played as melees throughout retail and at the end of retail.

I do understand how trustworthy the wikis have been (which has been earned) and believe that they are an excellent resource, but I **know** they are wrong in this case.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/944/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,79078680,ACE,issue
349748297,MDExOlB1bGxSZXF1ZXN0MjA3NzgzMjYw,945,Fix WorldObject_Magic IsInvalidTarget(),10137,ghost,closed,0,,,,,0,2018-08-11T16:57:05Z,2018-08-24T15:46:02Z,2018-08-11T19:58:38Z,NONE,,0,ACEmulator/ACE/pulls/945,"-Allow for non-Admin and non-Sentinel players, as the target, to correctly pass through IsInvalidTarget() method for beneficial spell casting","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/945/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349753548,MDExOlB1bGxSZXF1ZXN0MjA3Nzg2NDI1,946,Update SQL Writers for more comment output,11369233,LtRipley36706,closed,0,,,,,0,2018-08-11T18:16:44Z,2019-01-05T23:23:07Z,2018-08-11T20:12:09Z,MEMBER,,0,ACEmulator/ACE/pulls/946,Expanding comment data to restore lost output from conversion to ACE based SQL Writers,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/946/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349767775,MDExOlB1bGxSZXF1ZXN0MjA3Nzk0OTc3,947,Fix TargetType error in SQLWriter,11369233,LtRipley36706,closed,0,,,,,0,2018-08-11T22:19:08Z,2019-01-05T23:23:04Z,2018-08-11T22:21:55Z,MEMBER,,0,ACEmulator/ACE/pulls/947,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/947/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349775972,MDExOlB1bGxSZXF1ZXN0MjA3Nzk5ODYx,948,Changing Sort Order for Create List and Generators,11369233,LtRipley36706,closed,0,,,,,0,2018-08-12T01:24:53Z,2019-01-05T23:23:03Z,2018-08-12T01:40:08Z,MEMBER,,0,ACEmulator/ACE/pulls/948,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/948/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349826944,MDExOlB1bGxSZXF1ZXN0MjA3ODMwMDY3,949,Fix casting spells on other's wielded items,10137,ghost,closed,0,,,,,0,2018-08-12T16:51:21Z,2018-08-24T15:45:59Z,2018-08-12T22:14:37Z,NONE,,0,ACEmulator/ACE/pulls/949,-Fix casting spells on other's wielded items,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/949/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349837464,MDU6SXNzdWUzNDk4Mzc0NjQ=,950,Improve Player EnterWorld Process,10608427,Mag-nus,open,0,10608427,Mag-nus,,,0,2018-08-12T19:27:44Z,2019-04-01T17:58:06Z,,MEMBER,,,,"<!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
-->
### Bug Report or Feature Request (mark with an `x`)
```
- [ ] bug report -> please search issues before submitting
- [X ] feature request
```

### Repro steps.
Currently, when a user clicks the enter button on the client to enter the world with a selected player, before the users player enters portal space, first the server must gather the character object and all inventory biotas from the database.

While the recent improvements have improved this time greatly, there could still be observable latency in the future when the database is being used more heavily.

### Desired functionality.
When a user clicks the Enter button, the server should:

1. Request the Character object from the databases
2. Send enough info back to the user to enter the selected player into portal space
3. Request the full list of owned biotas from the database
4. If the player enters the world before the biotas are received, the user should stay in pink bubble state.
5. Once all the biotas are received and sent to the user, the player should exit pink bubbles and be playable.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/950/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,issue
349881972,MDExOlB1bGxSZXF1ZXN0MjA3ODY1ODE5,951,"Refactor generators a bit, fixing some bugs with spawning/respawning items",8909245,gmriggs,closed,0,,,,,0,2018-08-13T04:10:04Z,2018-08-13T22:07:22Z,2018-08-13T22:07:22Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/951,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/951/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
349895723,MDExOlB1bGxSZXF1ZXN0MjA3ODc1ODQ3,952,Added NpcLooksLikeObject usage in AppraiseInfo,26606778,OptimShi,closed,0,,,,,0,2018-08-13T05:52:52Z,2020-06-15T20:59:06Z,2018-08-13T14:56:24Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/952,"Test: @create 28973
Portrait of Asheron Realaidain

Even though the item is a technically creature (Int.ItemType = 16), it should ID as a regular object.

Examine should continue to work for creatures, NPCs, other objects as expected.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/952/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
350595778,MDExOlB1bGxSZXF1ZXN0MjA4NDA4OTM2,953,WIP - Add new spells and some refactoring,19214857,Slushnas,closed,0,,,,,1,2018-08-14T20:59:54Z,2018-08-21T17:25:27Z,2018-08-21T17:25:27Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/953,This PR includes some refactoring that should make it cleaner/easier to add the missing spell types. It should also fix issues with projectiles not spawning in the correct cell (previously they were assumed to be in the same cell as the caster).,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/953/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
350735171,MDExOlB1bGxSZXF1ZXN0MjA4NTA3NzE0,954,Major overhaul of player visibility / broadcast system,8909245,gmriggs,closed,0,,,,,0,2018-08-15T08:56:59Z,2018-08-19T01:58:50Z,2018-08-19T01:58:50Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/954,"- Major overhaul of broadcast system - now based on object visibility instead of landblocks
- Fixed a bug where portaling could keep the player at the original location
- Fixed a bug with player not appearing as pink bubbles on login / portal
- Fixed a bug with monster transitions between some landblocks

* Could use some help with multiplayer testing!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/954/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351636717,MDExOlB1bGxSZXF1ZXN0MjA5MTgxMDY4,955,Rename CommandHandlers to be more appropriate,10608427,Mag-nus,closed,0,,,,,0,2018-08-17T15:22:11Z,2018-08-17T22:40:44Z,2018-08-17T22:40:31Z,MEMBER,,0,ACEmulator/ACE/pulls/955,"This is in preparation for some DeveloperDatabaseCommands I plan to add.

The reason for the rename is the command handlers we have are all organized based on AccessLevel. Thus, this just aligns the file/class names to the access level commands it contains.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/955/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351771950,MDExOlB1bGxSZXF1ZXN0MjA5MjgyNjE3,956,"Adding weapon swapping between hands, and some basic dual wield combat",8909245,gmriggs,closed,0,,,,,0,2018-08-18T00:09:58Z,2018-08-19T01:47:13Z,2018-08-19T01:47:12Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/956,"- Added some dual wield combat formulas
- Fixed a bug where some untrained skills were marked as unusable
- Fixed an attribute formula bug for Item Tinkering","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/956/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351786996,MDExOlB1bGxSZXF1ZXN0MjA5MjkyNTc3,957,DatabasePerfTest developer command added,10608427,Mag-nus,closed,0,,,,,2,2018-08-18T03:39:11Z,2018-08-18T14:37:46Z,2018-08-18T14:35:27Z,MEMBER,,0,ACEmulator/ACE/pulls/957,"My test results:

Starting Database Performance Tests.
Biotas per test: 1000
This may take several minutes to complete...
1000 individual add   . Duration:  29.9 seconds. Successes: 1000, Failures:    0. Average:  30 ms
1000 individual save  . Duration:  23.9 seconds. Successes: 1000, Failures:    0. Average:  24 ms
1000 individual remove. Duration:  23.7 seconds. Successes: 1000, Failures:    0. Average:  24 ms
1000 bulk add         . Duration:   8.5 seconds. Successes:    1, Failures:    0. Average:   9 ms
1000 bulk save        . Duration:   6.2 seconds. Successes:    1, Failures:    0. Average:   6 ms
1000 bulk remove      . Duration:   7.0 seconds. Successes:    1, Failures:    0. Average:   7 ms
Database Performance Tests Completed

Next step is to modify the save to detect added/removed entities and only update changed records (not all).","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/957/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351799720,MDExOlB1bGxSZXF1ZXN0MjA5MzAwMDI0,958,Fixing PhysicsDesc bitflags,8909245,gmriggs,closed,0,,,,,0,2018-08-18T07:39:33Z,2018-08-19T01:46:46Z,2018-08-19T01:46:46Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/958,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/958/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351825880,MDExOlB1bGxSZXF1ZXN0MjA5MzE1MTkz,959,Network fatal exception recovery,8909245,gmriggs,closed,0,,,,,1,2018-08-18T14:46:10Z,2018-08-19T01:46:59Z,2018-08-19T01:46:59Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/959,"This patch recovers from fatal network errors, such as 'FATAL: Network Socket has thrown: An existing connection was forcibly closed by the remote host' which seems to be thrown often from ThwargLauncher connections

The ConnectionListener.Listen() function starts receiving data from a socket, calling OnDataReceive. At the end of OnDataReceive, the Listen() function is called again to resume listening for the next request

If an exception is thrown in Listen(), the exception handler needs to call Listen() again to recover gracefully and to start listening for the next request.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/959/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351871345,MDExOlB1bGxSZXF1ZXN0MjA5MzQxMzY4,960,Shard Biota Save & Threading Model Rework,10608427,Mag-nus,closed,0,,,,,1,2018-08-19T03:47:40Z,2018-08-20T23:31:05Z,2018-08-20T23:30:39Z,MEMBER,,0,ACEmulator/ACE/pulls/960,"This is a major change on how Biotas are added/saved to shard.

The AddBiota function is no more. Now, to add or save a biota, the same function is used, SaveBiota.

SaveBiota will pull (in full) the existing biota (if it exists) from the database. It will do a full diff between the new biota to save and the existing biota. It will copy over any differences, add any new rows, and delete from the database any rows that have been removed.

In addition, a ReadWriterLockSlim is passed to the Save/Remove functions in the database. This is necessary to prevent collection modification from the server while Entity Framework is processing the object.

There are still some bugs I need to fix.
BiotaPropertiesEnchantmentRegistry needs to be accessed through this new model for thread safety.
Character also needs to be converted to this new model for thread safety
_Save/Remove InParallel functions need to have ReadWriterLockSlims passed for each biota._ -Completed

The new model offers thread safety, and is much more performant.
The existing model would submit a database request every time a new record was removed from any biota collection. This was required because our biota is detached from the context. On an active server, this would hammer the database.

The new model offers a true X minute save for a biota where only the changed properties are submitted to the database via an sql statement.

This could use playtesting.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/960/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
351876389,MDExOlB1bGxSZXF1ZXN0MjA5MzQ0MTI3,961,Add alwaysshowwelcome config property,25518589,mcreedjr,closed,0,,,,,0,2018-08-19T05:45:02Z,2018-09-09T02:13:32Z,2018-08-19T07:20:33Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/961,"I'd like to propose the addition of this property. On the test server I've spun up, I'm communicating server build information in the Welcome message, and I'd like the ability to force the Welcome message to be shown at each logon, and not just the first logon. The option will default to off.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/961/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
352230782,MDExOlB1bGxSZXF1ZXN0MjA5NTkzMjc0,962,Fixing bug with monsters running away from players,8909245,gmriggs,closed,0,,,,,0,2018-08-20T17:39:37Z,2018-08-22T00:59:29Z,2018-08-22T00:59:29Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/962,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/962/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
352307420,MDExOlB1bGxSZXF1ZXN0MjA5NjUyMjkz,963,Update the 'accountcreate' command from Console only to Console and G…,33154637,acriaf,closed,0,,,,,1,2018-08-20T21:44:05Z,2018-08-21T09:39:35Z,2018-08-21T09:39:34Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/963,Update the 'accountcreate' command from Console only to Console and Game. This functionality will be added to the plug-in. ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/963/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
352336483,MDExOlB1bGxSZXF1ZXN0MjA5NjczOTUy,964,ShardDbContext caching. 1 for every Biota via a ConditionalWeakTable,10608427,Mag-nus,closed,0,,,,,1,2018-08-20T23:57:08Z,2018-08-25T19:36:03Z,2018-08-23T01:31:45Z,MEMBER,,0,ACEmulator/ACE/pulls/964,"I believe this to be the proper way to use EF with our application.
If we are able to improve db performance, it will be very marginal past this. This is near a best case scenario, if not already best case.

This utilizes Entity Frameworks tracking abilities for the life of the biota.

This does not suffer from context bloat because a single context only manages a single biota.

This does not suffer from data pollution because ACE does not support manipulating a biota via the database while it is currently used by the server.

When a biota is no longer used by ACE, the ConditionalWeakTable will release the reference to its cached DbContext. The garbage collector will dispose that for us.

If we want to explicitly dispose of the DbContext, we can use the FreeBiotaAndDisposeContext functions.

Comparing the current master method vs this method:
GetBiota and RemoveBiota are approximately the same performance.

Update via the current master:
1000 individual save   Duration:  36.3 s. Queue Wait Time:   0 ms. Average Execution Time:  36 ms. Success/Fail: 1000/0.
1000 bulk save         Duration:   5.6 s. Queue Wait Time:   0 ms. Average Execution Time:   6 ms. Success/Fail: 1/0.

Update via this PR:
1000 individual save   Duration:  10.0 s. Queue Wait Time:   0 ms. Average Execution Time:  10 ms. Success/Fail: 1000/0.
1000 bulk save         Duration:   2.7 s. Queue Wait Time:   0 ms. Average Execution Time:   3 ms. Success/Fail: 1/0.

The reason it is so much faster is because when the entity is tracked, only the changes need to be sent to the database. When the entity is disconnected (like in our current master), we must first get the entire biota from the database first to determine the changes.

There is an alternative to not caching the context. We could instead clone the biota and then diff the changes from the clone, however, there are some difficulties with this from an implementation pov, and it's much more prone to errors. In addition, it would not be as performant as this.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/964/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
352751776,MDExOlB1bGxSZXF1ZXN0MjA5OTg2ODEy,965,Fix biotas being falsely detected as changed,10608427,Mag-nus,closed,0,,,,,0,2018-08-21T23:55:28Z,2018-08-22T00:00:38Z,2018-08-22T00:00:19Z,MEMBER,,0,ACEmulator/ACE/pulls/965,"SetProperty now has an out bool biotaChanged argument that can help the caller know if an actual change was made.

In addition, setting the objects CreationTimestamp was in the wrong place","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/965/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
352787597,MDExOlB1bGxSZXF1ZXN0MjEwMDA5ODgz,966,EnchantmentRegistry improvements,10608427,Mag-nus,closed,0,,,,,0,2018-08-22T03:16:21Z,2018-08-25T19:36:14Z,2018-08-22T15:30:51Z,MEMBER,,0,ACEmulator/ACE/pulls/966,"Thread safety added to EnchantmentManager
Thread safety added to EnchantmentRegistry

The locks are required only when we iterate/insert/remove from the collections. EF accesses these collections on a separate thread and they cannot be modified while being iterated over.

Player save removed from EnchantmentManager. Saving a player should be a function of the player, not the enchantment manager. If we want to save a player on death, we can do that from the player.

Some minor cosmetic code improvements here and there.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/966/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
353367488,MDExOlB1bGxSZXF1ZXN0MjEwNDM4MTE5,967,Fixing some issues with stuck / falling monsters,8909245,gmriggs,closed,0,,,,,2,2018-08-23T12:54:56Z,2018-08-24T15:16:19Z,2018-08-24T15:16:19Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/967,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/967/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
353589588,MDExOlB1bGxSZXF1ZXN0MjEwNjAxNzEx,968,Player giving items to other players fix,10137,ghost,closed,0,,,,,0,2018-08-23T23:23:55Z,2018-08-24T19:07:54Z,2018-08-24T19:07:07Z,NONE,,0,ACEmulator/ACE/pulls/968,"-Implement unsecure ability, ie. without Trade_ protocols, to give items to other players, given the status of their ""Let Other Players Give You Items"" CharacterOption

-Bug fix by gmriggs in EmoteManager.cs for EmoteType.Turn and EmoteType.TurnToTarget
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/968/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
353825544,MDExOlB1bGxSZXF1ZXN0MjEwNzcxMDQ2,969,Improved body part / attack height formula,8909245,gmriggs,closed,0,,,,,0,2018-08-24T15:17:13Z,2018-08-25T00:59:10Z,2018-08-25T00:59:10Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/969,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/969/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
353992876,MDExOlB1bGxSZXF1ZXN0MjEwODkxMDk2,970,Adding monster combat maneuvers / special attacks,8909245,gmriggs,closed,0,,,,,0,2018-08-25T07:49:56Z,2018-08-26T14:43:59Z,2018-08-26T14:43:59Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/970,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/970/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354044490,MDExOlB1bGxSZXF1ZXN0MjEwOTIyMDAx,971,Couple of fixes,10137,ghost,closed,0,,,,,0,2018-08-25T21:23:51Z,2018-08-26T14:52:14Z,2018-08-26T03:40:31Z,NONE,,0,ACEmulator/ACE/pulls/971,"-Fix casting spells on WeenieType.Cow
-Add EmoteManager.Heartbeat() call to Creature.Heartbeat()","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/971/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354049028,MDExOlB1bGxSZXF1ZXN0MjEwOTI0Njg2,972,Threading improvement for WorldManager,10608427,Mag-nus,closed,0,,,,,0,2018-08-25T22:48:56Z,2018-08-26T01:32:33Z,2018-08-25T23:35:48Z,MEMBER,,0,ACEmulator/ACE/pulls/972,"Very simple functions should not be parallelized. It will actually be slower to do so.

In addition, it's unlikely there will be so many network sessions timed out in a single tick that would even require them to be parallelized.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/972/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354052086,MDExOlB1bGxSZXF1ZXN0MjEwOTI2NTI5,973,ActionChain AddDelaySeconds cleanup,10608427,Mag-nus,closed,0,,,,,0,2018-08-25T23:51:17Z,2018-08-26T01:32:43Z,2018-08-26T01:04:40Z,MEMBER,,0,ACEmulator/ACE/pulls/973,"WorldManager SecondsToTicks wasn't implemented correctly and simply returned the same value.

This was added long time ago. It likely had a purpose that doesn't exist anymore.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/973/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354061038,MDExOlB1bGxSZXF1ZXN0MjEwOTMxNjk1,974,Packets log level to separate configurable value via log4net.config file.,10608427,Mag-nus,closed,0,,,,,0,2018-08-26T03:14:16Z,2018-08-26T11:46:08Z,2018-08-26T11:45:48Z,MEMBER,,0,ACEmulator/ACE/pulls/974,"Using the DEBUG log level was basically useless due to all the packet level spam.

Now, you can keep packets at the log level of INFO and the main log setting at DEBUG. This will allow you to see common debug messages but not the actual packet data.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/974/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354090462,MDExOlB1bGxSZXF1ZXN0MjEwOTQ4ODE0,975,"Spell range check update, correct ring spell projectile destruction and a couple of small fixes.",19214857,Slushnas,closed,0,,,,,0,2018-08-26T12:21:06Z,2018-08-27T00:03:12Z,2018-08-27T00:03:12Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/975,"This PR includes:
1. Ring spell projectiles should now properly explode at their max range. Thanks to @gmriggs for the code.
2. Changed magic range check calculation to match the client code.
3. Added an unknown spell bitfield flag.
4. Fixed a typo with a Creature Magic starter spell.
5. Changed the out of range message for magic to match the retail message.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/975/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354091195,MDExOlB1bGxSZXF1ZXN0MjEwOTQ5MjUz,976,Adding broadcast max range,8909245,gmriggs,closed,0,,,,,0,2018-08-26T12:31:46Z,2018-08-26T16:10:48Z,2018-08-26T16:10:48Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/976,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/976/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354147261,MDExOlB1bGxSZXF1ZXN0MjEwOTgzMjA1,977,Ace admin plugin changes,33154637,acriaf,closed,0,,,,,3,2018-08-27T01:08:26Z,2018-09-03T22:23:38Z,2018-09-03T22:23:38Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/977,Some more changes for the plug-in. Including a new class/file for plug-in commands. ,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/977/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354183279,MDExOlB1bGxSZXF1ZXN0MjExMDA3OTcz,978,Weapon Bonuses,10137,ghost,closed,0,,,,,0,2018-08-27T05:21:13Z,2018-08-27T16:44:18Z,2018-08-27T16:43:56Z,NONE,,0,ACEmulator/ACE/pulls/978,"-Adds support for Biting Strike, Crushing Blow, Resistance Cleaving, Elemental Damage for casters, Mana conversion, and Melee Defense Mod bonuses
-Adds single spell casting method for Sentinal run spell and food buffs
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/978/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354333082,MDExOlB1bGxSZXF1ZXN0MjExMTIwNjQw,979,Migrate Character tables over to similar caching/threading model as Biota,10608427,Mag-nus,closed,0,,,,,0,2018-08-27T14:05:13Z,2018-08-30T12:11:56Z,2018-08-30T12:11:26Z,MEMBER,,0,ACEmulator/ACE/pulls/979,"This adds thread safety to Character in many places.

Performance is greatly improved by using same dbContext caching method used for Biotas.

A few ServerOnly properties (9000+) have been migrated over to the Character object.

Few bugs fixed here and there.

There are still some small thread safety issues to fix here and there in the code when accessing biota/character, but, I will address these after this is merged and I am synced up with the latest Master.

** NOTE **
This includes 2 schema changes to Shard. You will not need to recreate characters. Your existing character OPTIONS will be lost though.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/979/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354477071,MDExOlB1bGxSZXF1ZXN0MjExMjMwNDIz,980,"Adding thrown weapons, atlatls, and monster wielded weapons",8909245,gmriggs,closed,0,,,,,0,2018-08-27T21:02:03Z,2018-09-01T06:59:28Z,2018-09-01T06:59:28Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/980,"- Added thrown weapons for players and monsters
- Added atlatls for players and monsters
- Added monster wielded weapons
- Added monster melee weapon damage
- Implemented monster inventory / weapon switching
- Monster projectiles now dodgeable
- Fixed a bug with AmmoType not being enumerated as Flags","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/980/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354738611,MDExOlB1bGxSZXF1ZXN0MjExNDI4MzY1,981,Property manager logging tweaks + misc,10608427,Mag-nus,closed,0,,,,,0,2018-08-28T13:45:13Z,2018-08-30T12:11:45Z,2018-08-29T20:36:50Z,MEMBER,,0,ACEmulator/ACE/pulls/981,"UpdateWorld sleep/tickCalc should be last thing loop does

Don't show decimal places for debug logs that show time elapsed

 PropertyManager less debug output ","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/981/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
354939195,MDExOlB1bGxSZXF1ZXN0MjExNTg2MTE5,982,Weapon Bonuses,10137,ghost,closed,0,,,,,1,2018-08-28T23:21:29Z,2018-09-01T07:08:29Z,2018-09-01T06:19:12Z,NONE,,0,ACEmulator/ACE/pulls/982,"- Add support for bonuses on weapons: Melee Defense, Mana Conversion, Biting Strike, Crushing Blow, Resistance Cleaving, Elemental damage modifier on Casters, and Creature Slayer
- Add support for unrestricted single spell casts for use by Sentinal run and food buff/debuff","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/982/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356152665,MDExOlB1bGxSZXF1ZXN0MjEyNTE2MTMx,983,ActionChain Cleanup,10608427,Mag-nus,closed,0,,,,,0,2018-08-31T23:58:04Z,2018-09-02T00:43:03Z,2018-09-01T23:51:10Z,MEMBER,,0,ACEmulator/ACE/pulls/983,"This removes the unecessary ActionChains that were wrapping many of the HandleActionGameEvent functions.

ActionChains should only be used to enqueue work with delays, or, explicitly queue work for another WO that absolutely must be run on the landblock thread that owns the WO. (very rare, if any cases?)

We do not need to worry about out of order operations with HandleActionGameEvents. These handlers are enqueued when they are received on the network threads. They are then executed in a single thread in our UpdateWorld loop. This pattern is unlikely to change, and allows us to make the assumption that code executed from any HandleAction function (and not from an action chain) does not need to worry about thread safety, as it is the only thread modifying the world.

Parallelization will be added for Physics and Landblocks.Tick() at a future date.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/983/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356165156,MDExOlB1bGxSZXF1ZXN0MjEyNTI0Njgx,984,Update changelog for August,8909245,gmriggs,closed,0,,,,,0,2018-09-01T02:51:39Z,2018-09-30T17:32:06Z,2018-09-01T03:59:30Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/984,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/984/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356217203,MDExOlB1bGxSZXF1ZXN0MjEyNTU1MDU1,985,LandblockMotionQueue removed,10608427,Mag-nus,closed,0,,,,,0,2018-09-01T16:55:13Z,2018-09-02T00:43:18Z,2018-09-02T00:42:02Z,MEMBER,,0,ACEmulator/ACE/pulls/985,"The purpose of this queue was to make removing items from a landblock thread safe.

The assumption was that a worldObject and the landblock that owns it could be run on two separate threads.

Our initial implentation for multithreaded AC was that any Landblock or WO could be ticking on a completely separate thread.

We've since changed how we plan to multi-thread AC, with the assumption that a WO will be ticked/think on the same thread as it's parent Landblock, and furthermore that any adjacent landblock that has at least 1 player will also tick/think on the same thread.

This makes the design of ACE a lot more simple in the long run, and allows us to remove a lot of instances of excessive thread safety and action chain use.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/985/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356217937,MDExOlB1bGxSZXF1ZXN0MjEyNTU1NDk1,986,Copy CharacterOptions,10608427,Mag-nus,closed,0,,,,,0,2018-09-01T17:04:33Z,2018-09-01T19:36:59Z,2018-09-01T18:31:02Z,MEMBER,,0,ACEmulator/ACE/pulls/986,"If the Character.CharacterOptions are 0, this will try to pull the options from the Biota, or set them to default values.

This is a patch to fix the PR979 schema change.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/986/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356227307,MDExOlB1bGxSZXF1ZXN0MjEyNTYxMTY3,987,Character gameplay_Options fix,10608427,Mag-nus,closed,0,,,,,2,2018-09-01T19:35:20Z,2018-09-01T20:00:16Z,2018-09-01T19:59:58Z,MEMBER,,0,ACEmulator/ACE/pulls/987,"This has two fixes.

1) ACE logoff code runs before the final GameActionSetCharacterOption event from the client. Because of this order of operations, any changed options weren't being saved to the character on logoff.

2) Character was being modified while it was being saved by EF. This caused some change tracking mismatches.

I mentioned before, but there are still a few lingering places that need this type of locking. It's another thing on my todo list.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/987/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356232325,MDExOlB1bGxSZXF1ZXN0MjEyNTY0MTI3,988,LandblockBroadcastQueue is never used.,10608427,Mag-nus,closed,0,,,,,0,2018-09-01T21:01:48Z,2018-09-02T00:42:51Z,2018-09-01T23:50:25Z,MEMBER,,0,ACEmulator/ACE/pulls/988,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/988/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356248245,MDExOlB1bGxSZXF1ZXN0MjEyNTczMzEz,989,UpdateWorld improvements,10608427,Mag-nus,closed,0,,,,,0,2018-09-02T02:52:45Z,2018-09-02T14:11:40Z,2018-09-02T14:11:22Z,MEMBER,,0,ACEmulator/ACE/pulls/989,"Group the session maintenance together under the same lock.

Group the landblock functions closer together","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/989/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356249139,MDExOlB1bGxSZXF1ZXN0MjEyNTczODI3,990,More excessive ActionChains removed,10608427,Mag-nus,closed,0,,,,,0,2018-09-02T03:15:13Z,2018-09-02T14:11:50Z,2018-09-02T14:11:12Z,MEMBER,,0,ACEmulator/ACE/pulls/990,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/990/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356263084,MDExOlB1bGxSZXF1ZXN0MjEyNTgxODY2,991,Improved monster animations / timers for ranged attacks (xbow),8909245,gmriggs,closed,0,,,,,0,2018-09-02T08:26:02Z,2018-09-03T07:27:49Z,2018-09-03T07:27:49Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/991,,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/991/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356305186,MDExOlB1bGxSZXF1ZXN0MjEyNjA2MzE4,992,Fix Landblock multithreading,10608427,Mag-nus,closed,0,,,,,0,2018-09-02T18:51:06Z,2018-09-02T19:05:56Z,2018-09-02T19:04:46Z,MEMBER,,0,ACEmulator/ACE/pulls/992,"PlayerEnterWorld is a callback from a task created in the SerializedShardDatabase.

This callback can end up modifying the Landblock collections and data.

UpdateWorld also modifies Landblock collections and data.

We add UpdateWorldLandblockLock to make sure only a single thread accesses/modifies these collections.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/992/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356320062,MDExOlB1bGxSZXF1ZXN0MjEyNjE1Mzk4,993,Add missile launcher Elemental damage modifier,10137,ghost,closed,0,,,,,1,2018-09-02T22:45:49Z,2018-09-04T22:41:35Z,2018-09-04T06:32:11Z,NONE,,0,ACEmulator/ACE/pulls/993,"-Change 'Bonus' suffix to 'Modifier', in WorldObject_Weapons.cs
-Add missile launcher Elemental damage modifier","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/993/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356326342,MDExOlB1bGxSZXF1ZXN0MjEyNjE5MzE1,994,Chat functions,33154637,acriaf,closed,0,,,,,1,2018-09-03T00:27:29Z,2018-09-04T18:33:55Z,2018-09-04T18:33:55Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/994,"Most of the chat channels are coded. 
","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/994/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356345027,MDExOlB1bGxSZXF1ZXN0MjEyNjMxMzUw,995,First round of updates toward new threading model and less ActionChain usage,10608427,Mag-nus,closed,0,,,,,0,2018-09-03T03:11:31Z,2018-09-03T12:23:33Z,2018-09-03T12:23:10Z,MEMBER,,0,ACEmulator/ACE/pulls/995,"PlayerEnterWorld moved from LandblockManager to WorldManager
PlanerEnterWorld ActionQueue created so that the work isn't done on the returned Database task. This allows the SerializedShard worker to continue doing database work.

GameActions are now enqueued in an ActionQueue for session it came in on. This allows us to remove the nasty Session.WaitForPlayer() loop. This is a major fix that allows the server to continue running smoothly when a new player enters the world.

Sessions now have a Tick and TickInParallel.

Some cosmetic cleanups in ServerManager, WorldManager, LandblockManager and Landblock. This is mainly to make it easier to see the round two of updates to UpdateWorld and Landlbock/WorldObject tick functions.

EnqueueBroadcasts have been removed from Landblock. This is a system we've transitioned away from.","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/995/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356422598,MDExOlB1bGxSZXF1ZXN0MjEyNjg3NzQx,996,Implement secure trade,25518589,mcreedjr,closed,0,,,,,5,2018-09-03T09:19:24Z,2018-09-09T02:13:52Z,2018-09-04T00:06:58Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/996,"Some of this may be less than elegant, but it appears to work just fine!","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/996/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356534538,MDExOlB1bGxSZXF1ZXN0MjEyNzcxMTMy,997,Scroll additions to loot,10187880,dgatewood,closed,0,,,,,0,2018-09-03T14:51:57Z,2018-09-03T18:50:41Z,2018-09-03T18:50:41Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/997,Creates new spell scrolls in loot by their spell DID.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/997/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356595026,MDExOlB1bGxSZXF1ZXN0MjEyODE1NTI5,998,ActionQueue/Tick updates,10608427,Mag-nus,closed,0,,,,,4,2018-09-03T20:32:39Z,2018-09-06T11:37:29Z,2018-09-06T11:34:32Z,MEMBER,,0,ACEmulator/ACE/pulls/998,"The global LandblockActionQueue has been removed from WorldManager. This ran almost every action queue for all World Objects.

Landblocks are no longer IActors

Now, Landblocks Tick, and in turn, Tick the World Objects that they own.

WorldObjects contain their own ActionQueues. Previously, their action queue was a nested action queue. This just removes one of the layers.

The WorldObject.Tick will run it's own actions, and also check and run it's heartbeat.

Containers will propegate Ticks to it's contained items.

Creatures will propegate Ticks to it's equipped items.

Tick and Heartbeat are virtual. A player can add items to it's Heartbeat, then call it's base (creature), which calls its base (container) which calls it's base (world object).

** THIS IS A MAJOR CHANGE AND REQUIRES PLAY TESTING **

TODO in a following PR: Remove DelayManager from WorldManager","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/998/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356671827,MDExOlB1bGxSZXF1ZXN0MjEyODY5Njc5,999, Adding accuracyMod for missile weapons,8909245,gmriggs,closed,0,,,,,0,2018-09-04T06:40:42Z,2018-09-04T18:34:14Z,2018-09-04T18:34:14Z,COLLABORATOR,,0,ACEmulator/ACE/pulls/999,"This also improves the accuracy bar refilling when combat has ended, and when the player doesn't have the auto-attack option selected","{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/999/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull
356692682,MDExOlB1bGxSZXF1ZXN0MjEyODg1MzQ5,1000,Fix serialization of the critical hit field.,19214857,Slushnas,closed,0,,,,,0,2018-09-04T07:53:44Z,2018-09-04T14:04:22Z,2018-09-04T14:04:22Z,CONTRIBUTOR,,0,ACEmulator/ACE/pulls/1000,This fixes the serialization of the AttackerNotification message. Critical hit messages will now be displayed properly in the client.,"{""url"": ""https://api.github.com/repos/ACEmulator/ACE/issues/1000/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,79078680,ACE,pull