issue_comments
Data license: AGPL · Data source: ACEmulator Project
6 rows where issue = 539637907
This data as json, CSV (advanced)
Suggested facets: user, reactions, created_at (date), updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
567053644 | https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567053644 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | MDEyOklzc3VlQ29tbWVudDU2NzA1MzY0NA== | harliq 30803300 | 2019-12-18T14:26:36Z | 2019-12-18T14:26:36Z | COLLABORATOR | On a side note, while at it, is there any reason for the ElementalDamageBonusPvPReduction to be a static readonly in the class instead of a local var in that function? Its only used in that function. This has nothing to do with what dgarson submitted, but a quick refactor would remove a couple of vars | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed caster damage modifier to use appropriate PvP modifier instead of PvM 539637907 | |
567055392 | https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567055392 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | MDEyOklzc3VlQ29tbWVudDU2NzA1NTM5Mg== | gmriggs 8909245 | 2019-12-18T14:31:12Z | 2019-12-18T14:31:12Z | COLLABORATOR | I dunno, whoever wrote that code defined a lot of odd variables -- like 'defaultModifier 1.0', 'defaultBonus 0.0', things that will absolutely never be changed, but for some reason there are just named vars defined for them What you are saying is true from a scoping perspective, but unfortunately C# does not support static vars being declared from within a function. If a regular elementalDamageBonusPvPReduction = 0.5f were to be defined in that function, then it would be redundantly re-declaring it each and every time that function would be called | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed caster damage modifier to use appropriate PvP modifier instead of PvM 539637907 | |
567056903 | https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567056903 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | MDEyOklzc3VlQ29tbWVudDU2NzA1NjkwMw== | harliq 30803300 | 2019-12-18T14:34:51Z | 2019-12-18T14:34:51Z | COLLABORATOR | I guess the question would be does it even need to be defined? If it's always the same, no real reason to define it, unless someone wanted to make it server configurable. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed caster damage modifier to use appropriate PvP modifier instead of PvM 539637907 | |
567059166 | https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567059166 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | MDEyOklzc3VlQ29tbWVudDU2NzA1OTE2Ng== | gmriggs 8909245 | 2019-12-18T14:40:06Z | 2019-12-18T14:40:06Z | COLLABORATOR | Yes, that would be the question At one point, i started to remove a lot of those 'defaultModifier' and 'defaultBonus' references and justmake them 1.0 / 0.0, but I found a lot of cases it did improve the readability of the code somewhat So as it stands now, this really should be a completely non-issue This is literally using 4 bytes of extra memory across the entire server.. | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed caster damage modifier to use appropriate PvP modifier instead of PvM 539637907 | |
567059959 | https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567059959 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | MDEyOklzc3VlQ29tbWVudDU2NzA1OTk1OQ== | harliq 30803300 | 2019-12-18T14:42:07Z | 2019-12-18T14:42:07Z | COLLABORATOR | Agreed it's not an issue, just more of my own curiosity. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed caster damage modifier to use appropriate PvP modifier instead of PvM 539637907 | |
567060298 | https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567060298 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | MDEyOklzc3VlQ29tbWVudDU2NzA2MDI5OA== | gmriggs 8909245 | 2019-12-18T14:42:52Z | 2019-12-18T14:43:25Z | COLLABORATOR | "If it's always the same" it's always the same, until someone wants to modify it. bring pvp down from 50%->25%, in a custom mod, for example... the client display wouldn't match up, but someone is currently free to modify that var from a named var, instead of twiddling the constants in the formula also just because it's only referenced from within that function today, does not mean it could not be referenced from elsewhere in the future | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fixed caster damage modifier to use appropriate PvP modifier instead of PvM 539637907 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);