html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/ACEmulator/ACE/pull/1985#issuecomment-500415322,https://api.github.com/repos/ACEmulator/ACE/issues/1985,500415322,MDEyOklzc3VlQ29tbWVudDUwMDQxNTMyMg==,51647865,2019-06-10T13:24:20Z,2019-06-10T13:24:20Z,NONE,"> See my comments in this PR regarding storing IP addresses in a database: #1471

I strongly disagree with storing the IP fields in VARBINARY. I've never seen it used that way and it majorly over complicates things. VARCHAR works perfectly fine for any IP address and it's used to store an IP 99% of the time for servers.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454022098
https://github.com/ACEmulator/ACE/pull/1985#issuecomment-500433806,https://api.github.com/repos/ACEmulator/ACE/issues/1985,500433806,MDEyOklzc3VlQ29tbWVudDUwMDQzMzgwNg==,51647865,2019-06-10T14:19:19Z,2019-06-10T14:19:19Z,NONE,"The use case is that it makes both storing and reading the IP address easier. The performance gain from VARBINARY is negligible and makes the IP address unreadable when you want to simply look at the account table and see which IP belongs to which account.

I think it's silly to block this PR because it's not modern enough for you. Keeping things simple is the best approach, especially for a community driven open source emulator project.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,454022098
https://github.com/ACEmulator/ACE/pull/2412#issuecomment-552712772,https://api.github.com/repos/ACEmulator/ACE/issues/2412,552712772,MDEyOklzc3VlQ29tbWVudDU1MjcxMjc3Mg==,51647865,2019-11-12T03:01:53Z,2019-11-12T03:01:53Z,NONE,"It works, you need to run the sql so that existing account levels are converted to the new ones.

Also you can't simply update the rows in the accesslevel table due to one of them being a primary key. I see nothing wrong with dropping this table and remaking it but your call.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,521293376
https://github.com/ACEmulator/ACE/pull/2412#issuecomment-552914003,https://api.github.com/repos/ACEmulator/ACE/issues/2412,552914003,MDEyOklzc3VlQ29tbWVudDU1MjkxNDAwMw==,51647865,2019-11-12T14:22:06Z,2019-11-12T14:22:06Z,NONE,"I've tested this and it works perfectly. You're defeating the entire purpose of mandatory sql updates when they're made. Server owners always need to install them.

Also who cares about whether the sql is on one line or not? It's just a simple update script that will be eventually moved to the base anyway.

Anyway, I'll keep this to myself and make sure not to contribute to this project anymore.","{""total_count"": 1, ""+1"": 0, ""-1"": 1, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,521293376