# issues

node_id: MDExOlB1bGxSZXF1ZXN0MjkwODMwMDkx
title: Fix the inability to multicast impen/bane/brittlemail/lures on other characters
state: closed
created_at: 2019-06-22T15:24:03Z
updated_at: 2020-08-22T06:47:08Z
closed_at: 2019-06-22T19:50:28Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2028
type: pull
body:
  This PR resolves the problem where players are unable to cast beneficial item spells on others due to the error: "You fail to affect <<Name>> with <<Spell>>"

  I believe this functionality was permitted in retail, and was permitted in ACE up until a recent PR. If I am mis-remembering and this was not permitted in retail, then I will withdraw my PR.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2028/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODQxNzc1
title: Qst command expanded use + rng code fix for emote sets
state: closed
created_at: 2019-06-22T18:56:45Z
updated_at: 2019-06-23T18:16:08Z
closed_at: 2019-06-22T20:26:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2029
body:
  * Expand `qst` command.
  * Code fix for out of order emote sets.

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2029/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODQ2MDAx
title: Restore BaseDescriptionFlags to Food weenie class
state: closed
created_at: 2019-06-22T20:22:48Z
updated_at: 2019-06-23T18:16:08Z
closed_at: 2019-06-22T21:04:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2030
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2030/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODQ4NjI3
title: further adjusting food motions
state: closed
created_at: 2019-06-22T21:21:58Z
updated_at: 2019-06-23T03:02:48Z
closed_at: 2019-06-23T03:02:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2031
type: pull
body:
  this fix has been backported from 1991

  instead of trying to shoehorn the specific functionality that food motions need into the existing EnqueueMotion, this reverts EnqueueMotion to the original, and adds the food-specific functionality to EnqueueMotion_Force

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2031/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODUzMjg4
title: updating outdoor house references for unloaded landblocks
state: closed
created_at: 2019-06-22T23:18:56Z
updated_at: 2019-06-23T03:02:59Z
closed_at: 2019-06-23T03:02:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2032
type: pull
body:
  this fixes something that was working originally, but then was broken again when OnProperty and DungeonLandblockID were updated

  this updates those properties so everything works as expected with shallow references to outdoor houses on unloaded landblocks

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2032/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODYxNjY5
title: Update Healer.cs
state: closed
created_at: 2019-06-23T03:36:47Z
updated_at: 2019-06-23T05:10:01Z
closed_at: 2019-06-23T05:10:01Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2033
type: pull
body:
  Check if the healing target's attribute is at max, without assuming it's always health. Covers the rare, gauntlet, and casino Stamina/Mana kits.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2033/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODYyMDgz
title: Fix issue with doors that had ActivationResponse on them
state: closed
created_at: 2019-06-23T03:48:49Z
updated_at: 2019-06-23T18:16:07Z
closed_at: 2019-06-23T17:27:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2034
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2034/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODY5MDUx
title: additional healing kit refactoring
state: closed
created_at: 2019-06-23T07:08:48Z
updated_at: 2019-06-23T10:36:17Z
closed_at: 2019-06-23T10:36:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2035
type: pull
body:
  - removed duplicate BoostEnum/BoosterEnum properties in Food/Healer, moved to WorldObject_Properties using original name
  - refactored Food."BoostEnum - 1" and Healer.GetVitalsByKitType() into common GetCreatureVital(PropertyAttribute2nd)
  - left a note for Structure/MaxStructure ushort/int inconsistency for future refactoring
  - Added TransientMessages for '&lt;target&gt; is already at full &lt;vital&gt;!' for stamina/mana (doesn't appear to be werrors for those)
  - Added logic for UnlimitedUse kits
  - Updated remainingMsg to match retail: removed double space, '1 use', 'Your &lt;kitName&gt; is used up.' also sent on failure, omitting message for UnlimitedUse
  - Fixed a bug where Healer.DoSkillCheck() was using target.MissingHealth instead of target.MissingVital
  - Ensure UnlimitedUse kits are never consumed
  - Removed redundant GameMessagePrivateUpdateAttribute2ndLevel network message, already sent in UpdateVitalDelta
  - cleaned up comments

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2035/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwODg2NTI0
title: fix nullify item scroll drop
state: closed
created_at: 2019-06-23T12:40:31Z
updated_at: 2019-06-23T17:27:29Z
closed_at: 2019-06-23T17:27:29Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2036
body: never should have changed the spell ID for the drop, 1949 was working... just rare
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2036/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwOTEzMjI3
title: Fix some issues with CombatPets
state: closed
created_at: 2019-06-23T19:57:28Z
updated_at: 2019-07-01T08:14:54Z
closed_at: 2019-06-23T23:46:47Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2037
type: pull
body:
  * Fix issue of weenie cache corruption, setting the weenie's type instead of biota's weenietype
  * Ensure subbed combatpets are always melee by depriving them of inventory

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2037/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwOTE2OTg3
title: Generator system tweaks
state: closed
created_at: 2019-06-23T20:58:08Z
updated_at: 2019-07-01T08:14:53Z
closed_at: 2019-06-23T23:54:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2038
type: pull
body:
  * Generator system tweaks
    - Carry over Delay from profile template correctly.
    - Update RemoveQueue info in GeneratorDump.
    - Adjust CurrentCreate to be calculated to prevent out-of-sync issues.
       - Added GeneratedTreasureItem to GeneratorProfile to track when TreasureGenerator is used (random, mutated lootgen)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2038/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwOTE4NTcy
title: Add multi-homed internet support
state: closed
created_at: 2019-06-23T21:25:00Z
updated_at: 2019-06-25T23:34:02Z
closed_at: 2019-06-25T23:33:43Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2039
type: pull
body:
  This allows you to bind ACE to multiple interfaces via the Config.js.

  For most configurations, on a single-homed machine, your Config.js would have:
        "Host": "0.0.0.0",

  However, in the event you have a server with multiple NIC's, or, a software based VPN, you may want to expose your server to the internet via both of those ip addresses, using the VPN for your public clients and your actual address for your personal clients.

  You can now do something like this:
        "Host": "10.1.2.3,192.1.2.3",

  The PR seems like it's a lot of changes, but it's mainly just a few renamed. The difference now is we pass the ConnectionListener to the NetworkSession and use the ConnectionListener that was initially used to connect to transmit our return packets.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2039/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwOTMwNjc5
title: adding defense spec bonus
state: closed
created_at: 2019-06-24T00:32:10Z
updated_at: 2019-06-25T22:49:27Z
closed_at: 2019-06-25T22:49:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2040
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2040/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwOTgwMjUz
title: Update GetCachedInstancesByLandblock for external exporting
state: closed
created_at: 2019-06-24T05:51:52Z
updated_at: 2019-07-01T08:14:52Z
closed_at: 2019-06-24T05:55:52Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2041
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2041/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxMzM5ODIy
title: adding json import, live editing for content creators
state: closed
created_at: 2019-06-25T00:17:41Z
updated_at: 2019-07-01T07:36:57Z
closed_at: 2019-07-01T07:36:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2042
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2042/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxNDg2MTE2
title: fixing item proc sources and messages
state: closed
created_at: 2019-06-25T10:19:48Z
updated_at: 2019-06-25T22:49:46Z
closed_at: 2019-06-25T22:49:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2043
type: pull
body:
  this pr resolves https://github.com/ACEmulator/ACE/issues/1922

  the code in this pr got a little hairy, in particular the 'bool equipping' that EnchantmentManager seems to require, and the way it needs to be passed through many of the magic functions

  i think that maybe these -1 duration spells from equipping items could all be the SpellType.Enchantment, but with the way spells are first passed to Creature/Item/Life Magic, and each one handling SpellType.Enchantment and further passing to CreateEnchantment, required passing this 'equip' bool through many of these functions unfortunately.

  the logic in EnchantmentManager that determines if a duration should be -1 used to be a sticking point in the past, but it really seems to boil down to something simple: if i am equipping an item that casts a spell, that spell should most likely be duration -1 to my current understanding. if there are any exceptions to this, please let me know!

  Aetheria is an example of how this gets tricky -- it casts item set spells on the wielder when equipped, which are -1 duration. But it also procs spells on both the wielder and target. These procs have a duration. So the logic could be something tricky like a combination of checks like it was performing previously, but to do it the safest and clearest way, i think it really just boils down to this 'equipping' bool

  CreateItemSpell() is the function that gets called when an item is casting a spell from equipping it (and only for this case), so this is the only place equip bool gets set to true. Everywhere else in the system, it defaults to false (duration), so hopefully this should limit the types of 'infinite duration' errors that arose in the system awhile ago, and also make the logic much clearer

  ResistSpell() has been changed up very slightly, and is now being passed the additional 'caster' parameter that is common in many of the other magic methods. This is done for a few reasons, but now follows a consistent pattern as the other methods: when the current player has an item that casts a spell, instead of calling item.CastSpell() through the pipeline, player.CastSpell(itemSource) is instead used, which remains consistent with the current implementation of the rest of the magic system. The references to both the item caster and wielder are useful here, so it's useful to have references to them both. This could probably eventually be refactored / cleaned up further, but for now having ResistSpell() similar to the other magic methods is useful for consistency.

  so for the Phials (thrown weapons w/ item procs), throughout the magic casting pipeline, wielder.TryCastSpell(target, item) is the method used (last param updated), which then calls wielder.TryResistSpell(target, item). Item is being passed for the 'item caster' param, which is used for various operations if not null. For example, in ResistSpell(), it determines the caster from either the item caster or the wielder, and now has the appropriate logic to get magicSkill. If an item caster was passed in, it tries to use its ItemSpellcraft (this part was already there). One part that was missing, if an item caster's ItemSpellcraft is null, it checks if the item is being wielded by a creature, and if so, uses the wielder's magic skill for the spell.

  A clear distinction between player and item caster is also useful for determining all of the proper messages:

  ```
  Source:

  Target resists your spell
  Pyreal Phial of Imperil casts Imperil Other V on Target

  Target:

  You resist the spell cast by Source
  Pyreal Phial of Imperil cast Imperil Other V on you
  ```

  For resists, I think the player names are always used, but for the successful cast messages, i think the item names are used there. Haven't confirmed the resist messages yet, but using item names for resists could result in some odd messages

  Since these changes touched slightly on a lot of different methods, I went through and re-tested almost every possible magic casting setup, to ensure all the existing functionality was left intact. I tested all the Phials with both monster and player targets, Aetheria item set spells and both types of procs (self and target), item set spells for rare armor, casting all of the different types of magic school spells, a bunch of different wielded items with built-in spells, and also various spell traps. Everything appears to be functioning as expected, but careful review and feedback and additional playtesting is always a good thing

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2043/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxNTE2OTAx
title: fixing edge case for equipping thrown weapon w/ dual weapon wielded
state: closed
created_at: 2019-06-25T11:45:15Z
updated_at: 2019-06-25T22:49:37Z
closed_at: 2019-06-25T22:49:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2044
body: This fixes https://github.com/ACEmulator/ACE/issues/1921
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2044/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxNjMxNTU2
title: Log and Abort from SelectProfilesInit after 1000 tries
state: closed
created_at: 2019-06-25T16:10:55Z
updated_at: 2019-07-01T08:14:51Z
closed_at: 2019-06-26T03:58:04Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2045
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2045/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxNzk3MDE5
title: Few more very minor things
state: closed
created_at: 2019-06-26T02:37:45Z
updated_at: 2019-06-26T03:17:18Z
closed_at: 2019-06-26T03:17:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2046
body: Also fixed an exception in WorldObject_Set when an wo didn't have an ItemLevel value
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2046/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxNzk5MDg3
title: adding biota wcid idx
state: closed
created_at: 2019-06-26T02:50:03Z
updated_at: 2019-06-26T04:02:00Z
closed_at: 2019-06-26T04:02:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2047
type: pull
body:
  This improves House.SetLinkProperties() performance while loading into mansion/villa basement dungeons by a factor of ~2000% on current CE database

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2047/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxODA2NTEw
title: Fix CommandParser for Multiple Encapsulated Arguments
state: closed
created_at: 2019-06-26T03:35:03Z
updated_at: 2019-06-26T11:40:38Z
closed_at: 2019-06-26T11:40:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2048
body:
  Fixes for things like
  /command "Param1" "Param 2"

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2048/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkxODI4MDkw
title: do not resist irresistible spells
state: closed
created_at: 2019-06-26T05:39:35Z
updated_at: 2019-06-26T05:49:09Z
closed_at: 2019-06-26T05:49:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2049
body: This fixes the Portal Device bug introduced in https://github.com/ACEmulator/ACE/pull/2043
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2049/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyMjA0MTgy
title: Exception Catch
state: closed
created_at: 2019-06-26T23:55:31Z
updated_at: 2019-06-26T23:58:25Z
closed_at: 2019-06-26T23:58:12Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2050
type: pull
body:
  This code takes a different route from the base, so our normal packet handlers don't catch these exceptions.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2050/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyMjE1Mjg0
title: MoreNetworkFixes
state: closed
created_at: 2019-06-27T01:02:45Z
updated_at: 2019-06-27T02:07:09Z
closed_at: 2019-06-27T02:07:00Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2051
type: pull
body:
  Fix exceptions from account names that exceed the database column limit.

  Fix another exception caused by fragments that are too large

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2051/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyMjQxOTE3
title: fixing magic pickup issue
state: closed
created_at: 2019-06-27T03:19:56Z
updated_at: 2019-06-27T04:36:39Z
closed_at: 2019-06-27T04:36:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2052
type: pull
body:
  This fixes a bug that only appears while looting containers in magic combat mode:

  - Start in magic combat mode
  - Double click a landblock container (chest, corpse) while you are just outside the max looting range, so that your player walks (not runs) to the container
  - Attempt to loot an item from the container

  Expected:

  Item is successfully looted, and container inventory window stays up

  Actual:

  Item is looted, although with some odd client errors such as 'can only move 1 item at a time', and the most important bug: the container inventory window is automatically closed on the client

  This happens because magic combat mode appears to be the only stance where the player takes a small step back during the crouch down animation. This step back is just enough to move outside of max looting range, so the client automatically closes the window.

  This causes many issues for magic casters trying to loot, esp. when they are trying to loot important quest items, and the chests automatically close/lock on them

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2052/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyMjU4MDI1
title: log cleanup
state: closed
created_at: 2019-06-27T04:03:38Z
updated_at: 2019-06-27T04:37:00Z
closed_at: 2019-06-27T04:37:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2053
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2053/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyNDA4Njkx
title: fixing inventory stack bugs
state: closed
created_at: 2019-06-27T12:21:51Z
updated_at: 2019-06-28T23:57:58Z
closed_at: 2019-06-28T23:57:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2054
type: pull
body:
  This PR fixes 2 types of inventory stack bugs:

  Bug 1:

  - Have a partial stack of an item (249/250 stack size, for example) in your main pack
  - Have a partial stack of the same item in the landblock, where merging the stacks would exceed the MaxStackSize
  - Have the main pack full
  - Attempt to pick up the partial stack from the landblock

  Result before patch:

   - Error, and the landblock stack poofs completely

  Bug 2:

  - Have a partial stack of a wielded item, such as arrows or phials wielded
  - Have another partial stack of the same item in main pack, where merging the 2 stacks would still be < MaxStackSize
  - Try to dequip the wielded stack by double clicking on it

  Result before patch:

  The client sends a packet to try to merge the wielded stack into the inventory stack, which resulted in an error before, from the equipped source stack not being found in inventory

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2054/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyNTQzMDMx
title: Fixed issue with Recipe Manager CopyFromSourceToResult not using the player as the source.
state: closed
created_at: 2019-06-27T17:59:52Z
updated_at: 2020-06-15T20:59:18Z
closed_at: 2019-06-27T23:03:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2055
type: pull
body:
  Given the small handful of recipes that use this enum and based on the properties involved, it's apparent the "source" should always be the player/crafter and not the "source" per the Recipe.

  These are the only properties affected:
  * ALLOWED_ACTIVATOR_IID
  * ALLOWED_WIELDER_IID
  * CRAFTSMAN_NAME_STRING

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2055/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyNjY2MDUx
title: adding UpdateVisibleCells max interval
state: closed
created_at: 2019-06-28T02:35:04Z
updated_at: 2019-06-29T06:11:59Z
closed_at: 2019-06-29T06:11:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2056
body: This can fix some issues with objects re-entering visibility to a player who hasn't moved for 25s+
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2056/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkyNjc4Mzk1
title: fix some pklite logic, ensure player is alive when melee swing connects
state: closed
created_at: 2019-06-28T03:58:39Z
updated_at: 2019-06-29T06:12:19Z
closed_at: 2019-06-29T06:12:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2057
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2057/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMDEyMDQz
title: Fix remaining Weenie Cache corruption
state: closed
created_at: 2019-06-29T04:06:42Z
updated_at: 2019-07-01T08:14:50Z
closed_at: 2019-06-29T04:11:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2058
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2058/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMDE3NDQx
title: ObjMaint updates 1
state: closed
created_at: 2019-06-29T06:13:01Z
updated_at: 2019-07-04T06:31:49Z
closed_at: 2019-07-04T06:31:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2059
type: pull
body:
  This fixes some bugs and gaps in the object visibility system, without any major architectural changes

  - Instead of calling handle_visible_cells() in the Player heartbeats if it hasn't been run in the past 5 seconds, only the DestructionQueue needs to be called. This ensures that even if a player hasn't changes cells recently, their destruction queue is still accurately maintained.

  This prevents odd state situations where a previously known object re-enters visibility to a stationary player after 25s. This previously known object should be an unknown object at that time, and it should have been cleared out of the DestructionQueue (which it would on the next call to handle_visible_cells), but due to some odd state swapping with multiple operations happening on the same server frame, some logic was previously not running correctly in this situation.

  - Physics.Position needs to implement its own GetDistance2DSquared instead of ACE.Position. This was causing some object visibility errors while teleporting, where ACE.Position was still in the pre-teleport position, and hadn't been updated yet.

  These 2 relatively simple changes should fix a lot of the visibility errors that players have been finding

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2059/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMDE4Njg5
title: additional ObjMaint refactoring
state: closed
created_at: 2019-06-29T06:37:38Z
updated_at: 2019-07-07T20:14:11Z
closed_at: 2019-07-07T20:14:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2060
type: pull
body:
  This patch builds on 2059, and starts to make some core architectural changes. These changes are kept in a separate PR for easy testing

  With the previous design, there were a lot of scattered calls to handle_visible_cells / enqueue_objs / NotifyPlayers, trying to account for various gaps in the system in multiple places.

  The core of the new design starts in enter_cell_server(), which has always been the most important core function. The design here has been normalized so that it works consistently for everything, and removes a lot of the player-specific logic. Handling 'self' for this method has always been easy, and is simply a call to handle_visible_cells(). The tricky part has always been around handling 'inverse' updates for the other objects. This was the player-centric part before, with a bunch of logic that only ran for Players. It basically used to just call handle_visible_cells() for other players known to this player, and also an additional line of scattered logic to catch a voyeur edge case for players re-entering visibility.

  While this "worked", it was also not the most efficient way, and also didn't capture the core work being done by the inverse function. The core work is always just a function of the current object. The 2 key scenarios are the current object either becoming newly visible from the perspective of the other object, or the current object is becoming newly occluded. A function was added specifically to handle these cases, handle_visible_obj(), and the supporting ObjCell.IsVisible(otherCell), which returns a bool indicating if 1 cell is visible to another cell.

  With this new design, everything "just works" automatically, with all of the logic centralized and consistent for all object types. I also suspect this will fix the "invisible monster" bug that players have reported previously, which I believe to be caused by previously visible monsters moving outside visibility for 25s+, and then re-entering visibility, all the while the observing player does not change cells. This situation would have been caught for players before, but for monsters it still could have been a bug. I have confirmed that this scenario appears to be functioning properly now.

  This PR also removes the need for GetVisibleObjects() when a monster attempts to switch targets, which I believe to be one of the main cpu consumers in the FindNextTarget() function.

  I would still like to test the cpu difference between 2059 and 2060 on a live server to see if the cpu is truly lowered.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2060/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMDU5MDIz
title: More Generator Adjustments
state: closed
created_at: 2019-06-29T19:42:16Z
updated_at: 2019-07-01T08:14:49Z
closed_at: 2019-07-01T08:12:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2061
type: pull
body:
  * Adjust some debug output
  * Add overridden properties for region encounter generators
    - override_encounter_spawn_rates
       - encounter_regen_interval
       - encounter_delay
  * Allow camp generators to despawn 
    - When a full "camp" is wiped, if the camp has a parent generator, destroy it so the parent generator can roll the slot again

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2061/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMDc4NDUw
title: fix 'you can only move 1 item at a time' after giving equipped object to TC
state: closed
created_at: 2019-06-30T04:32:58Z
updated_at: 2019-06-30T06:36:31Z
closed_at: 2019-06-30T06:36:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2062
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2062/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMTM4NDc4
title: Convert Envoy use to Sentinel
state: closed
created_at: 2019-06-30T22:52:37Z
updated_at: 2019-07-01T00:50:26Z
closed_at: 2019-07-01T00:50:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2063
type: pull
body:
  This is just the first pass. More orgnization and work needs to be done to the entire AccessLevel and CommandManager system in the future.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2063/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMTc2MTQ3
title: updating june changelog
state: closed
created_at: 2019-07-01T04:43:22Z
updated_at: 2019-07-01T07:37:08Z
closed_at: 2019-07-01T07:37:07Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2064
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2064/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzMjQyMDU4
title: Fix issue with converting books from JSON to SQL
state: closed
created_at: 2019-07-01T08:52:16Z
updated_at: 2019-07-29T03:32:10Z
closed_at: 2019-07-01T09:09:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2065
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2065/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzNzY5NzA3
title: InventoryLoaded should auto set true for WO's created by weenie
state: closed
created_at: 2019-07-02T14:14:37Z
updated_at: 2019-07-08T13:05:13Z
closed_at: 2019-07-08T13:04:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2066
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2066/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkzOTkzNDAz
title: multihouse decommission
state: closed
created_at: 2019-07-03T04:05:11Z
updated_at: 2019-07-10T17:39:11Z
closed_at: 2019-07-10T17:39:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2067
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2067/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0MDQ4NTUz
title: additional handling for leveling up items casting new spells
state: closed
created_at: 2019-07-03T08:00:34Z
updated_at: 2019-07-04T06:29:25Z
closed_at: 2019-07-04T06:29:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2068
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2068/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0MjA5MjU3
title: PlacementPosition is not an enum type. It's an inventory order (index)
state: closed
created_at: 2019-07-03T14:58:39Z
updated_at: 2019-07-04T11:55:22Z
closed_at: 2019-07-04T11:54:51Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2069
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2069/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NjM5ODQwMTY=
title: Stuck in portal space on portal recall.
state: closed
created_at: 2019-07-03T22:46:40Z
updated_at: 2019-07-23T00:26:09Z
closed_at: 2019-07-23T00:26:09Z
author_association: CONTRIBUTOR
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [x ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  Character will occasionally get stuck in portal space when portal recalling. Just stays in the blue portal space indefinitely (e.g. it persisted for over 5 hours one night). Log off works, but the next time the character logs in it skips portal space and immediately shows up in the world, however the character is still _in_ portal space - can't enter combat mode or use items. A second relog will fix and return the character to normal.

  ### Repro steps.
  <!-- Please list the steps to reproduce a bug here -->
  Don't have any hard repro steps yet. So far it seems to happen randomly when using secondary portal recall.

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->
  Pcaps of the issue. I said "stuck" and "unstuck" in chat when I noticed.
  https://megaupload.nz/vbO7Odxfn2/pkt_2019-7-3_1562176100_log_pcap
  https://megaupload.nz/30GePcxen6/pkt_2019-7-3_1562190602_log_pcap
  https://megaupload.nz/GcMcQdx2n8/pkt_2019-7-3_1562212409_log_pcap
  https://megaupload.nz/z8D6fay3n2/pkt_2019-7-5_1562335790_log_pcap

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->
  Not get stuck? :-P

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->
  I can answer any questions in discord. I'll keep paying attention and try to pickup on a pattern.

  #2073 is an attempt to fix, ill continue to monitor when this goes live

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2070/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0NDI2MzE4
title: Aetheria LootGenerationFactory plus LootGen magic code refactor
state: closed
created_at: 2019-07-04T05:45:44Z
updated_at: 2019-07-07T16:38:43Z
closed_at: 2019-07-07T16:38:26Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2071
type: pull
body:
  - Add code to generate a Coealesced Aetheria, with a drop chance of 10% that seems a reasonable amount of chance for its appearance in loot, in my personal testing

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2071/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0NDY1MjEx
title: Add support for LocalSignal emotes
state: closed
created_at: 2019-07-04T07:58:45Z
updated_at: 2019-07-29T03:32:07Z
closed_at: 2019-07-04T08:26:17Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2072
type: pull
body:
  * Add DoNothing ActOnUse to CraftTool.
  * Adjust EmoteManager
    - Wire up EmoteType.LocalSignal.
    - Wire up EmoteCategory.ReceiveLocalSignal.
    - Adjust EmoteType.Activate to fall back to linked generator if no activation target is specified.
  * Add Landblock.EmitSignal to support localized object interaction.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2072/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0NTEwMTI3
title: additional decal teleport crash prevention [TEST]
state: closed
created_at: 2019-07-04T09:58:06Z
updated_at: 2019-07-07T20:13:57Z
closed_at: 2019-07-07T20:13:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2073
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2073/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0NTI3MjIz
title: refactoring healing ratings
state: closed
created_at: 2019-07-04T10:46:12Z
updated_at: 2019-07-05T07:36:23Z
closed_at: 2019-07-05T07:36:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2074
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2074/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0NTkzMjYx
title: additional IsBusy checks
state: closed
created_at: 2019-07-04T13:56:09Z
updated_at: 2019-07-05T07:36:10Z
closed_at: 2019-07-05T07:36:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2075
type: pull
body:
  This fixes additional bugs while reading scrolls, where it was possible to give the scroll to another player, move it to a landblock container, sell it to a vendor, or trade it to another player while the scroll was being read, thereby bypassing the original player's TryRemoveFromInventory

  This has been known about for some time, and was originally fixed with dropping into the landblock originally. IsBusy checks have been added for all of these possible scenarios. 

  /removespell <spell id> has been added to complement /addspell, and removes a spell from the player's  known spells / spellbook. This was used during testing to repeatedly learn/unlearn the same spell

  The client actually prevents an item from being used while it is in the trade window, but it was still possible to start reading the scoll, add it to the trade window, and then for both players to accept the trade before the scroll reading completed.

  Trade has also been refactored to remove the redundant 'session' parameters that were being passed to all of the functions.

  Some small changes to Scrolls were also backported from https://github.com/ACEmulator/ACE/pull/1991, notably reducing the scroll reading time from 2s -> 1s to match retail, and an additional bug fix for the IsBusy state ending early from the return stance time not being factored in, similar to issues with EnqueueMotion that Consumables had

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2075/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0NjU5NDcx
title: Misc. Aetheria updates
state: closed
created_at: 2019-07-04T18:12:56Z
updated_at: 2019-07-29T03:32:05Z
closed_at: 2019-07-07T05:36:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2076
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2076/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk0OTg0NjAy
title: fix trade typo
state: closed
created_at: 2019-07-05T21:19:57Z
updated_at: 2019-07-05T23:45:25Z
closed_at: 2019-07-05T23:45:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2077
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2077/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MDI2MDUy
title: ObjectDescriptionFlags cleanup
state: closed
created_at: 2019-07-06T09:01:00Z
updated_at: 2019-07-10T17:07:53Z
closed_at: 2019-07-10T17:07:53Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2078
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2078/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MDUxMDMz
title: Link to latest MySQL
state: closed
created_at: 2019-07-06T17:04:27Z
updated_at: 2019-07-06T17:47:50Z
closed_at: 2019-07-06T17:47:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2079
type: pull
body:
  The 8.0 branch has signifant performance improvements over the previously linked 5.7.

  The 5.7 is still listed as the minimum requirement

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2079/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MDYzNzcz
title: fixing HeritageMod appraisal for casters
state: closed
created_at: 2019-07-06T21:25:37Z
updated_at: 2019-07-06T21:45:51Z
closed_at: 2019-07-06T21:45:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2080
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2080/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MDgyOTkz
title: Fix several issues with hooks
state: closed
created_at: 2019-07-07T06:50:19Z
updated_at: 2019-07-29T03:32:04Z
closed_at: 2019-07-08T17:52:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2081
body: Only Hookers can be used on Hooks, everything else is not usable
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2081/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MTA4Mzc0
title: ensure consistency for PhysicsObj.Position
state: closed
created_at: 2019-07-07T14:32:36Z
updated_at: 2019-07-09T15:01:00Z
closed_at: 2019-07-09T15:01:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2082
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2082/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MTE1MTU2
title: HandleAugsForwardCompatiblity -> SetInnateAugs
state: closed
created_at: 2019-07-07T16:23:42Z
updated_at: 2019-07-08T12:45:33Z
closed_at: 2019-07-08T12:45:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2083
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2083/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MTE2MDc0
title: Aetheria LootGenerationFactory plus LootGen magic code refactor
state: closed
created_at: 2019-07-07T16:40:45Z
updated_at: 2019-07-13T02:37:55Z
closed_at: 2019-07-12T05:39:11Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2084
type: pull
body:
  - Add code to generate Coealesced Aetheria, with a drop chance of 1%, with a server option to mod the drop rate
  - Refactor LootGen magic code to consolidate redundant code
  - Current RNG chances for cantrips in master maintained but with a server option to mod the drop rates
  - Default of 1.0 for server option mods set drop rates to coded defaults; values greater than one decrease the drop rate and values less than one increase the drop rate.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2084/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MTI3MzI4
title: Add support for version command response
state: closed
created_at: 2019-07-07T20:07:53Z
updated_at: 2019-07-29T03:32:04Z
closed_at: 2019-07-08T16:49:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2085
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2085/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MTI3ODI2
title: ObjMaint v3
state: closed
created_at: 2019-07-07T20:15:39Z
updated_at: 2019-07-12T13:21:31Z
closed_at: 2019-07-12T13:21:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2086
type: pull
body:
  This PR supercedes https://github.com/ACEmulator/ACE/pull/2060 and https://github.com/ACEmulator/ACE/pull/2073

  Key architecture differences:

   - 'Voyeurs' has been renamed to 'KnownPlayers'
  - A new table called 'VisibleTargets' has been added for monsters and CombatPets. This greatly reduces the complexity of monster FindNextTarget()
  - The primary logic in enter_cell_server() has been significantly updated. It can be seen as much simpler in some ways, and most importantly, more accurately captures the requirements of the visibility system.
  The inverse/KnownPlayers part of the loop has replaced handle_visible_cells() with handle_visible_obj(), which should reduce unneeded complexity and processing there. The handle_visible_cells_non_player() is a new concept to cover some gaps that were previously there, so comparing v2 to v3 in this area is sort of like apples and oranges.
  - A key fix from the previous version, Player heartbeat now maintains the destruction queue every 5s. This can help clear up a lot of issues with object visibility from the perspective of an unmoving player. Specifically, previously visible objects re-entering visibility has always been an area with gaps
  - The TeleportCreateObjectDelay concept has been added as a test for some decal crashes / freezes
  - The objmaint debug commands (/knownobjs, /visibleobjs, /destructionqueue, /knownplayers, /visibletargets) have all been upgraded so the ObjMaint state for any object on the server can be queried. For example, /knownplayers target would show the known players to the last appraised target. /knownplayers &lt;guid&gt; also works

  Some key points:

  **Q:** Are KnownPlayers and VisibleTargets simply subsets of KnownObjects and VisibleObjects?

  **A:** No. KnownObjects and VisibleObjects are collections that are maintained only for players, and their primary purpose is to sync with the 25s DestructionQueue on the client. KnownPlayers are maintained for every object in the game. When an object broadcasts, it sends network messages to all of its KnownPlayers. VisibleTargets is a collection that is only populated for monsters and combat pets. For monsters, it contains Players and CombatPets. For CombatPets, it contains monsters.

  Another key difference is who maintains these collections. The object visibility system is mostly player-centric, and many times players will inform the other objects about the player.. ie. for KnownPlayers, the player is discovering the object, and adding itself to that object's KnownPlayers list. When the object exits the DestructionQueue for that player, and the player removes the object from its KnownObjects list, it also informs the object to remove the player from its KnownPlayers list. These inverse relationships are a lot of what ObjMaint manages, and it's an important distinction that Known/VisibleObjects are player-only collections, and which objects maintain inverse relationships with the other objects in their tables.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2086/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1MTMzODUy
title: Add Tether and Core Plating Recipes
state: closed
created_at: 2019-07-07T22:03:17Z
updated_at: 2019-07-10T14:17:14Z
closed_at: 2019-07-08T07:02:07Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2087
type: pull
body:
  - Add code to enable Left hand Tether/remover and Core Plating Integrator/Disintegrater to function; recipes are already present in the database

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2087/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1Mzg4MDE3
title: hotfix for objmaint v2 references
state: closed
created_at: 2019-07-08T15:28:24Z
updated_at: 2019-07-08T16:51:46Z
closed_at: 2019-07-08T16:51:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2088
type: pull
body:
  This is fixed in a much better way in https://github.com/ACEmulator/ACE/pull/2086, but this fixes the current memory leak in v2

  Thanks for @Mag-nus for tracking this bug down

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2088/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1NTE3ODIx
title: improved delete command, fixing bug w/ DropItem edge case
state: closed
created_at: 2019-07-08T22:23:55Z
updated_at: 2019-07-09T12:18:55Z
closed_at: 2019-07-09T12:18:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2089
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2089/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1NzI5NzY5
title: account house recall merge fix
state: closed
created_at: 2019-07-09T12:24:10Z
updated_at: 2019-07-09T15:01:13Z
closed_at: 2019-07-09T15:01:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2090
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2090/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk1Nzk1OTM4
title: some fixes for two-handed weaps
state: closed
created_at: 2019-07-09T15:00:07Z
updated_at: 2019-07-09T17:21:18Z
closed_at: 2019-07-09T17:21:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2091
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2091/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2Mjc4MjY3
title: commenting out debug lines
state: closed
created_at: 2019-07-10T17:47:56Z
updated_at: 2019-07-10T17:57:44Z
closed_at: 2019-07-10T17:57:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2092
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2092/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2MjkwMTA3
title: Adjust Sell to Vendor, Resolves #1639
state: closed
created_at: 2019-07-10T18:24:47Z
updated_at: 2019-07-29T03:32:02Z
closed_at: 2019-07-10T18:49:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2093
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2093/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2NjU0ODEy
title: Make Dat SubPalette and TextureMapChanges properties public
state: closed
created_at: 2019-07-11T13:37:35Z
updated_at: 2019-07-11T14:15:55Z
closed_at: 2019-07-11T14:15:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2094
type: pull
body:
  This allows other tools to instantiate these objects and set new values.

  This is used by OptimShis Palette decoder and my retail character importer.

  I was always on the fence about these dat properties being public. The risk is that a developer could modify a property in ACE. That property would then persist to the cached at object, and would be re-used until ACE was restarted.

  This happens because dat objects are cached, and that same instance is returned on subsequent requests.

  However, if we are ever to have 3rd party Dat editor tools, these properties will need to be public anyway.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2094/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2NzAwMDA4
title: adding /import-json all + /import-sql all
state: closed
created_at: 2019-07-11T15:11:48Z
updated_at: 2019-07-12T13:21:38Z
closed_at: 2019-07-12T13:21:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2095
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2095/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2NzYyMDY3
title: adding call to UpdateDescriptionFlags() to WeenieHeaderFlags2 setters
state: closed
created_at: 2019-07-11T17:56:59Z
updated_at: 2019-07-11T18:02:20Z
closed_at: 2019-07-11T18:02:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2096
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2096/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2ODg3NzYw
title: Add Unique Connection count to /serverstatus
state: closed
created_at: 2019-07-12T02:01:16Z
updated_at: 2019-07-12T12:15:56Z
closed_at: 2019-07-12T12:15:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2097
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2097/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk2OTM2OTk0
title: Fix issue with some recipe changes and ObjectDescriptionFlags
state: closed
created_at: 2019-07-12T06:40:48Z
updated_at: 2019-07-29T03:32:00Z
closed_at: 2019-07-12T12:32:11Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2098
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2098/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MTM1MjMw
title: Revert "Only track Player biotas (#1813)"
state: closed
created_at: 2019-07-12T16:10:14Z
updated_at: 2019-07-15T11:40:12Z
closed_at: 2019-07-15T11:39:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2099
type: pull
body:
  This reverts commit ce9791703b7acbaeea433bb1cbadff6e3cbf17e0.

  Don't merge just yet, I want to review it a little more thoroughly as well as add notes.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2099/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MTY2MDA4
title: aura code updates
state: closed
created_at: 2019-07-12T17:50:41Z
updated_at: 2019-07-13T16:56:47Z
closed_at: 2019-07-13T16:56:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2100
type: pull
body:
  This should only be merged after https://github.com/ACEmulator/ACE-World-16PY-Patches/pull/161/, and should only be installed after updating to that world DB

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2100/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MjUwNDc5
title: Fix unintentional change in cantrip RNG code
state: closed
created_at: 2019-07-12T23:14:28Z
updated_at: 2019-07-13T02:37:52Z
closed_at: 2019-07-12T23:16:58Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2101
body: - Fix unintentional change in cantrip RNG code for Epic and Legendary
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2101/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MjY1MDM2
title: Add dungeon landblock counts to /serverstatus
state: closed
created_at: 2019-07-13T01:13:19Z
updated_at: 2019-07-13T02:12:15Z
closed_at: 2019-07-13T02:11:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2102
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2102/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MjY2OTU1
title: WIP: Multi-thread landblock ticking (Landblock Groups)
state: closed
created_at: 2019-07-13T01:36:38Z
updated_at: 2019-09-18T13:28:52Z
closed_at: 2019-09-18T13:28:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2103
type: pull
body:
  This is the start of "landblock group" ticking.

  The idea behind the landblock groups are that each group may contain multiple landblocks that must be ticked on the same thread, but, each group itself can be ticked on independent threads.

  Landblock groups describe their area using a rectangle. As landblocks are added (and removed) the rectangle that contains all the landblocks in the group is adjusted.

  Landblocks are added to groups based on a minimum distance to the landblock groups rectangle.

  In the event a landblock needs to be added and is within range of multiple groups, those groups will be combined into one.

  Periodically, landblock groups are checked to see if they can be split. When a landblock group is split, it can result in a new group that has an overlapping rectangle to the parent group. This is not a problem because all the landblocks within each group meet the minimum distance requirements. In the event that a new landblock is added and is close to both rectangles, the groups will then be merged again.

  Adding landblocks to groups is a very efficient process
  Removing landblocks from groups is a very efficient process
  Checking landblock groups for split potential does incur some overhead (~0.5 ms) which is why it's only done on intervals that are twice the Landblock.UnloadInterval.  
    
    
  Changes we've had to made for thread safety
  - ACE.Server/Network/Sequence/SequenceManager

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MjcxMzA0
title: Update LootGenerationFactory_Aetheria.cs
state: closed
created_at: 2019-07-13T02:38:52Z
updated_at: 2019-07-13T02:51:07Z
closed_at: 2019-07-13T02:50:52Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2104
body: - Remove incorrectly added else
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3MjczOTcw
title: Update LootGenerationFactory_Aetheria.cs
state: closed
created_at: 2019-07-13T03:18:10Z
updated_at: 2019-07-17T13:37:11Z
closed_at: 2019-07-13T16:54:07Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2105
body: - Remove incorrect else
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NDIxMDQ1
title: adjust aetheria drop rates, fixing drop rate mods
state: closed
created_at: 2019-07-14T19:18:43Z
updated_at: 2019-07-15T05:15:42Z
closed_at: 2019-07-15T05:15:42Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2106
type: pull
body:
  This adjusts the Aetheria drop rates to be better aligned with retail data, and from community feedback from knowledgeable players

  Previously, level 1-3 Aetheria all had an equal chance of dropping, and level 4-5 Aetheria both had the same chance of dropping

  Some initial retail data (albeit very sparse, esp. for level 4-5) can be found here:

  https://cdn.discordapp.com/attachments/417074022237601802/600013535510003712/aetheria_stats.csv

  Drop chances for the previous code per magical item generated (100m simulated rolls):

  ```
  at least level 1: 1 in 10
  at least level 2: 1 in 10
  at least level 3: 1 in 10
  at least level 4: 1 in 100
  at least level 5: 1 in 100
  ```

  Drop chances for the updated code:

  ```
  at least level 1: 1 in 100
  at least level 2: 1 in 200
  at least level 3: 1 in 400
  at least level 4: 1 in 5000
  at least level 5: 1 in 25000
  ```

  These numbers can be continued to be further adjusted

  The server admin options for cantrip and Aetheria drop rates have also been adjusted. If the server admin sets a 2x drop rate, the items should drop at 2x the rate (previously > 1.0 was lower rate)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2106/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NDM0MzA1
title: Tweaks to LootGen
state: closed
created_at: 2019-07-14T22:53:55Z
updated_at: 2019-07-17T13:37:12Z
closed_at: 2019-07-15T05:06:09Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2107
body:
  - Add RandomizeColor() to Jewelry
  - Adjust GetElementalBonus() coding

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2107/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NDQwODAz
title: Various updates to House things
state: closed
created_at: 2019-07-15T00:32:03Z
updated_at: 2019-07-29T03:31:59Z
closed_at: 2019-07-15T08:07:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2108
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2108/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NDUxOTE1
title: fix missing ManaRate for existing items
state: closed
created_at: 2019-07-15T02:32:31Z
updated_at: 2021-06-07T07:19:01Z
closed_at: 2019-07-15T05:15:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2109
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2109/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NDUzNzE3
title: fix bug with level proportional xp
state: closed
created_at: 2019-07-15T02:48:12Z
updated_at: 2019-07-15T05:15:57Z
closed_at: 2019-07-15T05:15:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2110
type: pull
body:
  This fixes a bug where EmoteType.AwardLevelProportionalXP -> GrantLevelProportionalXp() doesn't award any XP for max level players

  This bug was fixed in GetXPBetweenLevels() awhile ago, where for max level players it uses the XP between 274-275, but there was still an if check in GrantLevelProportionalXp() lingering around

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2110/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NjA4MzYw
title: Add WO info to ActionQueue output
state: closed
created_at: 2019-07-15T12:58:27Z
updated_at: 2019-07-15T13:01:35Z
closed_at: 2019-07-15T13:01:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2111
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2111/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3NjQ5OTM3
title: Update Creature Combat Skills for MoA
state: closed
created_at: 2019-07-15T14:33:42Z
updated_at: 2019-07-17T13:37:13Z
closed_at: 2019-07-15T18:46:55Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2112
body: - Update Creature combat skills for MoA, authored by @gmriggs
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2112/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3ODA1MTEx
title: re-adjusting epic cantrip rates
state: closed
created_at: 2019-07-15T22:08:01Z
updated_at: 2019-07-17T02:33:24Z
closed_at: 2019-07-17T02:33:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2113
type: pull
body:
  When comparing https://github.com/ACEmulator/ACE/pull/1892 to current, there appears to be a 200x gap to cover here

  There appears to be a missing factor from 1892 where there would be a pre-roll, where T7 would have 25% chance to drop no epics. So that would reduce the gap to 150x

  Prior to https://github.com/ACEmulator/ACE/pull/2101, the rates were briefly bumped up, and this version was well-received from the CE player feedback. This version would further reduce the gap to 15x

  This PR sets the default rates back to the pre-2101 rates, which seem to be a good balance currently

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2113/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3ODE4MTUz
title: Some more House fixes
state: closed
created_at: 2019-07-15T23:07:43Z
updated_at: 2019-07-29T03:32:01Z
closed_at: 2019-07-16T03:53:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2114
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2114/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk3OTA5NjEz
title: fixing HousePortal OwnerId->HouseOwner
state: closed
created_at: 2019-07-16T07:26:29Z
updated_at: 2019-07-16T17:01:48Z
closed_at: 2019-07-16T17:01:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2115
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2115/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4MDI0MjU5
title: Add caching to World GetCachedWeenie by name
state: closed
created_at: 2019-07-16T12:46:51Z
updated_at: 2019-08-12T12:37:22Z
closed_at: 2019-08-12T02:51:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2116
body: This fixes the rare hiccups seen by CE
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2116/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4MTczMDE3
title: removing max velocity estimated, not found in pcaps
state: closed
created_at: 2019-07-16T19:08:13Z
updated_at: 2019-07-17T02:30:09Z
closed_at: 2019-07-17T02:30:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2117
type: pull
body:
  This removes the (based on STRENGTH 100) display in the client for missile weapons

  Searched the retail pcaps for any instances where MaxVelocityEstimated != 0, and couldn't find any examples. If this is supposed to be set for things like Thrown Weapons, not sure what values to place in here

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2117/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4MjAxNTc0
title: adding Spirit Thirst to Wand Cantrips
state: closed
created_at: 2019-07-16T20:37:27Z
updated_at: 2019-07-16T21:28:54Z
closed_at: 2019-07-16T21:28:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2118
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4MjQ3MDg1
title: update quest XP text notification to show actual amount of XP received
state: closed
created_at: 2019-07-16T23:00:08Z
updated_at: 2019-07-17T02:30:53Z
closed_at: 2019-07-17T02:30:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2119
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2119/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4MjYzODIx
title: prevent Aetheria from being wielded to unopen slots
state: closed
created_at: 2019-07-17T00:33:25Z
updated_at: 2019-07-17T02:31:21Z
closed_at: 2019-07-17T02:31:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2120
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2120/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4MjY5Njg3
title: add HealOverTime enchantments
state: closed
created_at: 2019-07-17T01:14:32Z
updated_at: 2019-07-17T02:32:58Z
closed_at: 2019-07-17T02:32:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2121
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2121/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4NjI3MTk5
title: Update Vendor Sell Fail Condition
state: closed
created_at: 2019-07-17T18:57:32Z
updated_at: 2019-07-29T03:31:57Z
closed_at: 2019-07-17T23:51:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2122
body: Update Vendor to send GameEventInventoryServerSaveFailed on selling 0 items
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2122/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4Njg5OTUw
title: updating enchantment messages
state: closed
created_at: 2019-07-17T22:17:46Z
updated_at: 2020-03-24T22:01:27Z
closed_at: 2019-07-17T23:24:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2123
type: pull
body:
  This fixes a last minute bug that snuck into https://github.com/ACEmulator/ACE/pull/2043, where throwing Phials at a target incorrectly sent the wrong message to the thrower (cast spell on you, instead of cast spell on target)

  The bug also had a side effect of hiding messages for the target when casting on their equipped items

  The code has been normalized a bit to better describe what is going on, and to reduce the chance for these types of errors

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2123/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4NzE5Mjg3
title: adding RemainingLifespan
state: closed
created_at: 2019-07-18T00:51:55Z
updated_at: 2019-07-25T05:21:33Z
closed_at: 2019-07-25T05:21:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2124
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2124/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4NzQ1ODIx
title: Ranks -> InitLevel
state: closed
created_at: 2019-07-18T03:49:16Z
updated_at: 2019-07-18T04:10:10Z
closed_at: 2019-07-18T04:10:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2125
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2125/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk4NzU5MzM2
title: Update @die command to End of Retail operation
state: closed
created_at: 2019-07-18T05:21:25Z
updated_at: 2019-07-29T03:31:56Z
closed_at: 2019-07-19T06:21:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2126
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2126/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MTM0MDI4
title: adding Surge of Regeneration tick messages
state: closed
created_at: 2019-07-18T23:50:04Z
updated_at: 2019-07-19T00:42:23Z
closed_at: 2019-07-19T00:42:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2127
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2127/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MTUwOTgx
title: suicide refactoring
state: closed
created_at: 2019-07-19T01:30:26Z
updated_at: 2019-07-19T16:27:04Z
closed_at: 2019-07-19T16:27:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2128
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2128/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MTYzMDkx
title: scale srcVital to destVital for life transfer spells
state: closed
created_at: 2019-07-19T02:41:45Z
updated_at: 2019-07-19T06:20:34Z
closed_at: 2019-07-19T06:20:34Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2129
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2129/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MTY1OTM1
title: adding medicated healing kits to rare t3, and elixirs to rare t2 tables
state: closed
created_at: 2019-07-19T02:59:19Z
updated_at: 2019-07-19T06:20:53Z
closed_at: 2019-07-19T06:20:53Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2130
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2130/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MTg1MTQ2
title: adding calcs/appraisal for Spirit Thirst
state: closed
created_at: 2019-07-19T05:03:39Z
updated_at: 2019-07-19T06:21:06Z
closed_at: 2019-07-19T06:21:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2131
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2131/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MTk0MzEy
title: fixing weapon swap client bug
state: closed
created_at: 2019-07-19T05:52:51Z
updated_at: 2019-07-19T06:21:31Z
closed_at: 2019-07-19T06:21:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2132
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2132/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5MjIyMzc2
title: optional debug info for RecipeMods
state: closed
created_at: 2019-07-19T07:45:08Z
updated_at: 2019-07-19T16:27:30Z
closed_at: 2019-07-19T16:27:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2133
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2133/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5Mjg3NDg4
title: updating mana conversion to better match retail
state: closed
created_at: 2019-07-19T11:00:54Z
updated_at: 2019-07-19T16:27:19Z
closed_at: 2019-07-19T16:27:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2134
type: pull
body:
  mana usage for over 15,000 level 8 bolt casts in retail:

  ```
  Total Casts: 16,520

  1: ***************************************************************************
  2: ***********************
  3: *********************
  4: ******************
  5: ******************
  6: ****************
  7: ***************
  8: ************
  9: *************
  10: ***********
  11: ***********
  12: **********
  13: *********
  14: ********
  15: *********
  16: *******
  17: ********
  18: *******
  19: *******
  20: ******
  21: ******
  22: *****
  23: ****
  24: ****
  25: ****
  26: ****
  27: ***
  28: ***
  29: **
  30: ***
  31: **
  32: **
  33: *
  34: **
  35: *
  36: *
  37: *
  38:
  39:
  40:
  ```

  profile of updated formula:

  ```
  1: ***************************************************************************
  2: ***********************************
  3: ******************************
  4: ***************************
  5: *************************
  6: **********************
  7: *********************
  8: ******************
  9: *****************
  10: ****************
  11: ***************
  12: *************
  13: *************
  14: ************
  15: ***********
  16: **********
  17: **********
  18: *********
  19: ********
  20: ********
  21: *******
  22: ******
  23: ******
  24: ******
  25: *****
  26: *****
  27: ****
  28: ****
  29: ****
  30: ***
  31: ***
  32: **
  33: **
  34: *
  35: *
  36: *
  37: *
  38:
  39:
  40:
  ```

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2134/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NTMzMzcz
title: fixing Thrungus special attack
state: closed
created_at: 2019-07-20T03:29:42Z
updated_at: 2019-07-20T22:47:02Z
closed_at: 2019-07-20T22:47:02Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2135
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2135/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NTM0MzUw
title: fixing ebon rifts / adding support for multiple damage types
state: closed
created_at: 2019-07-20T03:49:37Z
updated_at: 2019-07-20T05:39:47Z
closed_at: 2019-07-20T05:39:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2136
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NTM1MzE5
title: Save Item to DB in TryCreateInInventoryWithNetworking
state: closed
created_at: 2019-07-20T04:09:51Z
updated_at: 2019-07-29T03:31:55Z
closed_at: 2019-07-26T03:48:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2137
body: Attempt at preventing item rollback on crashes
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2137/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NTM4NjA4
title: Updated database instructions in README.md to prevent an error
state: closed
created_at: 2019-07-20T05:20:23Z
updated_at: 2019-07-20T22:47:13Z
closed_at: 2019-07-20T22:47:13Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2138
type: pull
body:
  The instructions in README.md now ask the reader to set up `ace_world`
  with WorldBase.sql before applying incremental updates. This prevents more
  recent `ace_shard` updates from producing an error due to a failed join with a non-existing table when `ace_world` hasn't been set up yet.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2138/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NTQ0NTQx
title: fixing StackSize 0 bug in WieldedTreasure
state: closed
created_at: 2019-07-20T07:28:25Z
updated_at: 2019-07-20T22:47:24Z
closed_at: 2019-07-20T22:47:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2139
type: pull
body:
  This fixes a bug that can occur with Throwing Clubs for example, where StackSize=4 and StackSizeVariance=0.1

  MinStackSize is set to Math.Round(0.4) in this case, which becomes 0. This ensures the minimum stack size cannot fall below 1

  This also points to another issue in the WieldedTreasure StackSizeVariance code, where MinStackSize should actually be defined as StackSize * (1.0f - StackSizeVariance). However, due to monsters lacking the logic where they decide to switch between ranged and melee, this code currently provides a reasonable counterbalance for now

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2139/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NTkzNDQ1
title: Add Curse of Raven Fury spell
state: closed
created_at: 2019-07-20T21:58:07Z
updated_at: 2019-07-22T05:41:28Z
closed_at: 2019-07-22T05:41:28Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2140
type: pull
body:
  This will likely need more testing to verify everything behaves like retail but from my own tests everything appears to work properly.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2140/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjE0NjQ2
title: updating spell projectile magic skill bonus to match retail
state: closed
created_at: 2019-07-21T06:42:34Z
updated_at: 2019-07-22T05:41:37Z
closed_at: 2019-07-22T05:41:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2141
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2141/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjE0NzA5
title: syncing kt share range with radar
state: closed
created_at: 2019-07-21T06:44:40Z
updated_at: 2019-07-22T05:41:08Z
closed_at: 2019-07-22T05:41:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2142
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2142/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjIxNTM5
title: Command to list runtime configuration properties
state: closed
created_at: 2019-07-21T09:06:05Z
updated_at: 2019-07-22T05:41:49Z
closed_at: 2019-07-22T05:41:49Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2143
type: pull
body:
  This PR seeks to improve the way properties are set and the visibility of the different properties.

  First is the addition of the "showprops" command which enumerates the different properties (in order by their data type) and then shows both their name, description and default value.

  Now validation is also done on values passed in when setting an option, ensuring that the user knows whether the value was successfully set, or whether no setting existed with the given key. It's worth noting that it will also complain a key does not exist if it exists but has a different data type (this could be improved if necessary).

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2143/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjU4ODE5
title: Include material in give item message
state: closed
created_at: 2019-07-21T19:20:36Z
updated_at: 2019-07-23T00:42:00Z
closed_at: 2019-07-23T00:41:59Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2144
type: pull
body:
  Right now whenever you give an item to a player or an NPC, it omits the material name prefix. This material name prefix should be present at all times when passing around or tinkering items with a material type. This PR adjusts the text to include the material name, but ensures that the item is neither stackable (which should never have a valid material) and that it has a material name specified, prior to including it in the output.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2144/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjU4OTg1
title: Remove attribute cantrips from jewelry.
state: closed
created_at: 2019-07-21T19:23:10Z
updated_at: 2019-07-23T00:42:10Z
closed_at: 2019-07-23T00:42:10Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2145
type: pull
body:
  Further refining of the epic cantrips that are eligible for dropping on items to align with retail. Attributes should never be dropping on jewelry with the exception of rares.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjY2NDY3
title: Added configurable 'player_save_interval' seconds property
state: closed
created_at: 2019-07-21T21:26:32Z
updated_at: 2019-07-31T06:05:26Z
closed_at: 2019-07-31T06:05:26Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2146
type: pull
body:
  Adds a new configuration property for the number of minutes between the automatic save of player characters. This is in response to the the feature request in https://github.com/ACEmulator/ACE/issues/1621

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2146/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NjcyNTI1
title: Unattackable until exited from portal space
state: closed
created_at: 2019-07-21T23:04:29Z
updated_at: 2019-07-23T00:42:23Z
closed_at: 2019-07-23T00:42:23Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2147
type: pull
body:
  Right now it is possible to attack players, and to gain aggro on mobs, while you are still in portal space. Retail behavior was that you were considered unattackable while in portal space, meaning nothing would aggro you and all attempts to attack would fail to do any damage.

  This PR adds a check for the Teleporting flag in a few places where we determine whether a target can be attacked, namely a player, since this is not applicable for mobs.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NzA4MzgyMDg=
title: String buffer overrun / leaked memory content in packet logger
state: closed
created_at: 2019-07-21T23:34:45Z
updated_at: 2019-07-22T22:52:24Z
closed_at: 2019-07-22T22:52:24Z
author_association: CONTRIBUTOR
state_reason: completed
type: issue
body:
  Looks like a string buffer overflow in the packet logger or sender. This is from a vanilla 9318d3 build, with the only change being to set log level for the Packets logger to DEBUG in log4net.config.

  Bytes 64 onward in the packet dump look like some array holding a database query.


  > 2019-07-21 16:26:10,413 [12] DEBUG (Packets) [Unverified] Enqueuing Message CharacterList
  > 2019-07-21 16:26:10,413 [12] DEBUG (Packets) [Unverified] Enqueuing Message ServerName
  > 2019-07-21 16:26:10,413 [12] DEBUG (Packets) [Unverified] Enqueuing Message DDD_Interrogation
  > 2019-07-21 16:26:10,414 [World Manager] DEBUG (Packets) [Unverified] Swapping bundle
  > 2019-07-21 16:26:10,414 [World Manager] DEBUG (Packets) [Unverified] Sending Bundle
  > 2019-07-21 16:26:10,415 [World Manager] DEBUG (Packets) Sequence 0, count 1, DataRemaining 28
  > 2019-07-21 16:26:10,416 [World Manager] DEBUG (Packets) [Unverified] Bundle Fragment Count: 1
  > 2019-07-21 16:26:10,416 [World Manager] DEBUG (Packets) [Unverified] Sending small message
  > 2019-07-21 16:26:10,418 [World Manager] DEBUG (Packets) Creating ServerFragment for index 0
  > 2019-07-21 16:26:10,419 [World Manager] DEBUG (Packets) Done creating ServerFragment for index 0. After reading 28 DataRemaining 0
  > 2019-07-21 16:26:10,419 [World Manager] DEBUG (Packets) [Unverified] Enqueuing Packet 13261889
  > 2019-07-21 16:26:10,419 [World Manager] DEBUG (Packets) [Unverified] Flushing packets, count 0
  > 2019-07-21 16:26:10,419 [World Manager] DEBUG (Packets) [Unverified] Sending packet 13261889
  > 2019-07-21 16:26:10,419 [World Manager] DEBUG (Packets) [Unverified] Setting Issac for packet 13261889 to 701586851
  > 2019-07-21 16:26:10,421 [World Manager] DEBUG (Packets) >>> Seq: 3 Id: 11 Iter: 20 XCRC: 1712135020 EncryptedChecksum | BlobFragments CRC: 1021208841 XOR: 701586851
  > 2019-07-21 16:26:10,421 [World Manager] DEBUG (Packets) [0] Sending Packet (Len: 512) [0.0.0.0:9001=>127.0.0.1:49264]
  >    x    0  1  2  3  4  5  6  7  8  9 10 11 12 13 14 15  |Text
  >    0   03 00 00 00 06 00 00 00 6C 1B 0D 66 0B 00 7B 01  |        l  f  { 
  >   16   2C 00 14 00 00 00 00 00 00 00 00 80 01 00 2C 00  |,             , 
  >   32   00 00 05 00 E5 F7 00 00 01 00 00 00 01 00 00 00  |    å÷          
  >   48   01 00 00 00 02 00 00 00 00 00 00 00 01 00 00 00  |                
  >   64   2C 20 60 72 60 2E 60 61 6E 67 6C 65 73 5F 5A 60  |, `r`.`angles_Z`
  >   80   2C 20 60 72 60 2E 60 64 65 6C 61 79 60 2C 20 60  |, `r`.`delay`, `
  >   96   72 60 2E 60 69 6E 69 74 5F 43 72 65 61 74 65 60  |r`.`init_Create`
  >  112   2C 20 60 72 60 2E 60 6D 61 78 5F 43 72 65 61 74  |, `r`.`max_Creat
  >  128   65 60 2C 20 60 72 60 2E 60 6F 62 6A 5F 43 65 6C  |e`, `r`.`obj_Cel
  >  144   6C 5F 49 64 60 2C 20 60 72 60 2E 60 6F 62 6A 65  |l_Id`, `r`.`obje
  >  160   63 74 5F 49 64 60 2C 20 60 72 60 2E 60 6F 72 69  |ct_Id`, `r`.`ori
  >  176   67 69 6E 5F 58 60 2C 20 60 72 60 2E 60 6F 72 69  |gin_X`, `r`.`ori
  >  192   67 69 6E 5F 59 60 2C 20 60 72 60 2E 60 6F 72 69  |gin_Y`, `r`.`ori
  >  208   67 69 6E 5F 5A 60 2C 20 60 72 60 2E 60 70 61 6C  |gin_Z`, `r`.`pal
  >  224   65 74 74 65 5F 49 64 60 2C 20 60 72 60 2E 60 70  |ette_Id`, `r`.`p
  >  240   72 6F 62 61 62 69 6C 69 74 79 60 2C 20 60 72 60  |robability`, `r`
  >  256   2E 60 73 68 61 64 65 60 2C 20 60 72 60 2E 60 73  |.`shade`, `r`.`s
  >  272   74 61 63 6B 5F 53 69 7A 65 60 2C 20 60 72 60 2E  |tack_Size`, `r`.
  >  288   60 77 65 65 6E 69 65 5F 43 6C 61 73 73 5F 49 64  |`weenie_Class_Id
  >  304   60 2C 20 60 72 60 2E 60 77 68 65 6E 5F 43 72 65  |`, `r`.`when_Cre
  >  320   61 74 65 60 2C 20 60 72 60 2E 60 77 68 65 72 65  |ate`, `r`.`where
  >  336   5F 43 72 65 61 74 65 60 0D 0A 46 52 4F 4D 20 60  |_Create`  FROM `
  >  352   77 65 65 6E 69 65 5F 70 72 6F 70 65 72 74 69 65  |weenie_propertie
  >  368   73 5F 67 65 6E 65 72 61 74 6F 72 60 20 41 53 20  |s_generator` AS 
  >  384   60 72 60 0D 0A 57 48 45 52 45 20 60 72 60 2E 60  |`r`  WHERE `r`.`
  >  400   6F 62 6A 65 63 74 5F 49 64 60 20 3D 20 31 30 38  |object_Id` = 108
  >  416   37 30 36 60 2E 60 63 6C 61 73 73 5F 49 64 60 0D  |706`.`class_Id` 
  >  432   0A 4F 52 44 45 52 20 42 59 20 60 74 36 60 2E 60  | ORDER BY `t6`.`
  >  448   63 6C 61 73 73 5F 49 64 60 5F 49 64 60 74 60 2E  |class_Id`_Id`t`.
  >  464   60 77 65 65 6E 69 65 5F 43 6C 61 73 73 5F 49 64  |`weenie_Class_Id
  >  480   60 0D 0A 57 48 45 52 45 20 60 77 65 65 6E 69 65  |`  WHERE `weenie
  >  496   60 2E 60 74 79 70 65 60 20 3D 20 35 33 00 00 00  |`.`type` = 53  
  ![image](https://user-images.githubusercontent.com/5247558/61598632-98b6a080-abd5-11e9-89dc-f11276d57557.png)
   

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5Njc2OTYz
title: Fix for string buffer overrun / leaked memory in packet logger
state: closed
created_at: 2019-07-22T00:09:36Z
updated_at: 2019-07-22T05:42:00Z
closed_at: 2019-07-22T05:42:00Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2149
type: pull
body:
  This is a fix for issue #2148 

  The debug packet logging code was logging the wrong size variables, and BuildPacketString() was ignoring its startPosition and bytesToOutput arguments.

  Tested locally by playing around with a retail client for a few minutes with packet debug logging on.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2149/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NzMxMDU4
title: Add full support for Contracts
state: closed
created_at: 2019-07-22T06:15:49Z
updated_at: 2019-07-29T03:31:54Z
closed_at: 2019-07-29T03:25:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2150
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NzU5Nzk5
title: fixing an issue with mansion accounts
state: closed
created_at: 2019-07-22T07:56:19Z
updated_at: 2019-07-22T08:19:51Z
closed_at: 2019-07-22T08:19:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2151
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5NzgwODk0
title: client capped to uint.MaxValue for allegiance xp display
state: closed
created_at: 2019-07-22T08:57:26Z
updated_at: 2019-07-22T10:40:27Z
closed_at: 2019-07-22T10:40:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2152
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2152/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjk5Nzk5MDE2
title: adding Critical Protection Augmentation message
state: closed
created_at: 2019-07-22T09:45:03Z
updated_at: 2019-07-23T00:42:38Z
closed_at: 2019-07-23T00:42:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2153
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAwMTI0OTIy
title: updating player.KillerId => corpse.KillerId for pk/pklite
state: closed
created_at: 2019-07-23T04:35:35Z
updated_at: 2019-07-23T04:59:39Z
closed_at: 2019-07-23T04:59:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2154
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2154/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAwMTU0ODQz
title: adding universal masteries
state: closed
created_at: 2019-07-23T07:05:54Z
updated_at: 2019-07-23T13:52:32Z
closed_at: 2019-07-23T13:52:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2155
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2155/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAwMzY2Mzcz
title: Add busy checks for recall/PKL commands
state: closed
created_at: 2019-07-23T16:00:33Z
updated_at: 2019-07-24T05:30:37Z
closed_at: 2019-07-24T05:30:37Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2156
type: pull
body:
  Right now it is possible to use multiple recall commands as well as the PKL command simultaneously. You can test on the master branch by typing /mp and then immediately typing /pkl. You will notice that you become PKL just before you teleport to marketplace. You can use these commands while teleporting in portal space which will begin the timer for the action concurrently with the current teleport/action.

  This PR adds a common check to determine whether a recall (or entering PKL) is possible at that time. It checks for whether the character is busy or is already teleporting.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2156/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAwNzcwMzA0
title: fixing unarmed combat animation for low power high attack
state: closed
created_at: 2019-07-24T15:09:38Z
updated_at: 2019-07-24T18:22:11Z
closed_at: 2019-07-24T18:22:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2157
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2157/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAwODkzNzY1
title: Layering
state: closed
created_at: 2019-07-24T21:00:19Z
updated_at: 2019-07-25T16:20:43Z
closed_at: 2019-07-25T16:20:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2158
type: pull
body:
  Added support for proper visual display of Layered Armor (Tailoring) and Reduced Armor (Tailoring) as well as future items such as Over-Robes.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2158/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxMDE0NTA2
title: fixing bug for multiple items leveling simultaneously
state: closed
created_at: 2019-07-25T07:21:54Z
updated_at: 2019-07-25T17:35:17Z
closed_at: 2019-07-25T17:35:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2159
type: pull
body:
  Repro steps:

  - set a bunch of aetheria in the same item set to ItemTotalXp 0, equip them
  - appraise player, /grantitemxp 5000000000
  - dequip aetheria

  Expected:

  no spells from aetheria item set active

  Actual:

  spells from aetheria item set active

  The error was placing OnItemLevelUp() inside of the ActionChain. Simply moving this method call outside of the action chain fixes the bug

  To fix existing players in this bugged state is a bit more complicated, and the AuditItemSpells() method was added to handle this

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxMDczNzcz
title: fixing transferring items from side packs -> main pack at max burden
state: closed
created_at: 2019-07-25T10:09:35Z
updated_at: 2019-07-25T16:02:30Z
closed_at: 2019-07-25T16:02:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2160
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2160/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxMTkzMzE4
title: adding prevention/debug code for spellbook probability 0
state: closed
created_at: 2019-07-25T15:17:51Z
updated_at: 2019-07-25T16:02:44Z
closed_at: 2019-07-25T16:02:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2161
body: Adding some code for https://github.com/ACEmulator/ACE/issues/1583
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2161/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxMzM0ODg0
title: Added ability to have a PKL server
state: closed
created_at: 2019-07-25T22:39:26Z
updated_at: 2019-07-26T03:49:43Z
closed_at: 2019-07-26T03:49:43Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2162
type: pull
body:
  A few people mentioned interest in this and since it seemed like an easy enough task, I've attempted to add a PKL-mode to servers, so that people can be permanently killable but need not incur vitae or drop items.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2162/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxMzQ1MTky
title: Picking up null Burden items
state: closed
created_at: 2019-07-25T23:32:15Z
updated_at: 2019-08-04T02:19:49Z
closed_at: 2019-07-26T03:49:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2163
type: pull
body:
  Fixes an issue where you were unable to pick up null EncumberanceVal items. Specifically, the Gelidite Dais, but possibly others, too.
  Testing Steps: 
  -	Proceed to 0x546302A5 [216.357574 -70.013016 -5.995000] 0.667876 0.000000 0.000000 -0.744273
  -	Pick up the Gelidite Dais.
  -	Pick up another. And another. BECAUSE YOU CAN!
  -	Reference: https://asheron.fandom.com/wiki/Gelidite_Dais

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2163/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxMzU4NDEx
title: update audit item spells
state: closed
created_at: 2019-07-26T00:54:39Z
updated_at: 2019-07-26T03:47:41Z
closed_at: 2019-07-26T03:47:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2164
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2164/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxNTA5MzQ1
title: persisting squelches to db
state: closed
created_at: 2019-07-26T11:48:26Z
updated_at: 2019-07-31T06:05:00Z
closed_at: 2019-07-31T06:05:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2165
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2165/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxNzU1OTQ3
title: adding epic / legendary cantrip logging
state: closed
created_at: 2019-07-27T12:25:41Z
updated_at: 2019-07-27T16:29:27Z
closed_at: 2019-07-27T16:29:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2166
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2166/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxNzY3ODM5
title: clamping local broadcast range for pklite messages
state: closed
created_at: 2019-07-27T15:51:18Z
updated_at: 2019-07-27T16:29:36Z
closed_at: 2019-07-27T16:29:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2167
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2167/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxNzg0ODU2
title: RestrictionDB null prevention
state: closed
created_at: 2019-07-27T20:56:06Z
updated_at: 2019-08-22T17:55:05Z
closed_at: 2019-07-27T21:50:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2168
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2168/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxODAxNTk2
title: Layering - Boot Fix
state: closed
created_at: 2019-07-28T03:30:15Z
updated_at: 2020-06-15T20:59:23Z
closed_at: 2019-07-28T04:17:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2169
body: Small fix for boots that were not layering properly with the recent layering/objdesc updates.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2169/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxODI4OTA5
title: filtering Houses from /create and /ci
state: closed
created_at: 2019-07-28T12:50:14Z
updated_at: 2019-07-28T13:37:37Z
closed_at: 2019-07-28T13:37:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2170
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2170/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAxOTA4ODA1
title: Fix issue with NoCorpse crashing
state: closed
created_at: 2019-07-29T05:05:41Z
updated_at: 2019-08-21T00:03:07Z
closed_at: 2019-07-29T05:08:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2171
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2171/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAyNDgxMTU2
title: adding pk arenas
state: closed
created_at: 2019-07-30T12:42:53Z
updated_at: 2019-07-31T04:44:06Z
closed_at: 2019-07-31T04:44:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2172
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2172/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAyNjA2Mzcy
title: fixing some redundant broadcasts for soul emotes
state: closed
created_at: 2019-07-30T17:46:25Z
updated_at: 2019-07-31T04:44:13Z
closed_at: 2019-07-31T04:44:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2173
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2173/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAyNzk1Mjk2
title: allegiance passup xp earn -> grant
state: closed
created_at: 2019-07-31T05:44:25Z
updated_at: 2019-07-31T06:05:09Z
closed_at: 2019-07-31T06:05:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2174
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2174/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzMDM1NDMz
title: persisting allegiance bans / approved vassals
state: closed
created_at: 2019-07-31T16:31:56Z
updated_at: 2019-08-04T18:42:20Z
closed_at: 2019-08-04T18:42:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2175
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2175/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzMzEwMTc1
title: improved player melee attack animations
state: closed
created_at: 2019-08-01T10:00:54Z
updated_at: 2019-08-02T14:25:28Z
closed_at: 2019-08-02T14:25:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2176
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzMzQ1Mzgz
title: updating July changelog
state: closed
created_at: 2019-08-01T11:40:34Z
updated_at: 2019-08-01T12:20:00Z
closed_at: 2019-08-01T12:20:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2177
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2177/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzNjM0NTcz
title: Update for HearLocalSignal specific properties usage
state: closed
created_at: 2019-08-02T04:22:43Z
updated_at: 2019-08-21T00:03:09Z
closed_at: 2019-08-02T16:54:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2178
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2178/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzODU5MDI1
title: handle weapon AttackType offhand malformed data
state: closed
created_at: 2019-08-02T16:46:28Z
updated_at: 2019-08-03T15:50:53Z
closed_at: 2019-08-03T15:50:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2179
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2179/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzODkwOTMx
title: fix various vital enchantment calc errors
state: closed
created_at: 2019-08-02T18:40:40Z
updated_at: 2019-08-03T15:51:02Z
closed_at: 2019-08-03T15:51:01Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2180
type: pull
body:
  - float.Round() should be used instead of Math.Round(), to avoid possible off-by-1 errors
  - additives should be applied after all multipliers, including vitae

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2180/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzAzOTY1NDQ1
title: fixing player -> targetPlayer
state: closed
created_at: 2019-08-03T00:56:20Z
updated_at: 2019-08-03T15:51:11Z
closed_at: 2019-08-03T15:51:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2181
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2181/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDIzMjAw
title: adding house barrier protections for pk/pkl
state: closed
created_at: 2019-08-03T20:16:53Z
updated_at: 2019-08-05T20:38:49Z
closed_at: 2019-08-05T20:38:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2182
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDM0MzE5
title: Add support for AdminEnvirons
state: closed
created_at: 2019-08-04T00:53:55Z
updated_at: 2019-08-21T00:03:10Z
closed_at: 2019-08-04T04:47:34Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2183
type: pull
body:
  Add support for AdminEnvirons
    - Wired up support commands `setlbenviron` and `setglobalenviron`
    - `setglobalenviron` is operates exactly as seen in retail worlds. in that it affects all players globally throughout the world, including bug with dungeons.
    - `setlbenviron` operates differently in that it localizes effect to landblock and immediate adjacents for area-based events.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2183/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDM4NjUz
title: fixing GetDamageType() for UAC low power attacks
state: closed
created_at: 2019-08-04T03:08:48Z
updated_at: 2019-08-04T05:55:03Z
closed_at: 2019-08-04T05:55:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2184
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDQxOTMw
title: Add refresh from world db scripts
state: closed
created_at: 2019-08-04T04:46:22Z
updated_at: 2019-08-21T00:03:10Z
closed_at: 2019-08-04T06:17:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2185
body: Server operators can run these scripts to periodically re-sync with newer database changes.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2185/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDQyMDgy
title: adding support for HomeRadius
state: closed
created_at: 2019-08-04T04:51:39Z
updated_at: 2019-08-04T05:55:11Z
closed_at: 2019-08-04T05:55:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2186
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2186/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDQ1MTA4
title: refining HandArmor / FootArmor selector
state: closed
created_at: 2019-08-04T06:14:05Z
updated_at: 2019-08-04T06:24:59Z
closed_at: 2019-08-04T06:24:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2187
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2187/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDQ3NjIz
title: fixing monster location desync after MoveHome
state: closed
created_at: 2019-08-04T07:14:46Z
updated_at: 2019-08-04T15:57:06Z
closed_at: 2019-08-04T15:57:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2188
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDg0Mjg4
title: fixing untrained msg
state: closed
created_at: 2019-08-04T17:52:43Z
updated_at: 2019-08-04T18:18:15Z
closed_at: 2019-08-04T18:18:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2189
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2189/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDg3ODI4
title: Account In Use changes
state: closed
created_at: 2019-08-04T18:56:50Z
updated_at: 2019-08-21T00:03:12Z
closed_at: 2019-08-04T19:02:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2190
type: pull
body:
  * Update AuthenticationHandler to boot oldest connection to account when new one connects with valid login/password.
     - Added new server configurable property `account_login_boots_in_use`, enabled by default retail rule.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2190/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDg5MjA4
title: pk -> npk only from pk battles
state: closed
created_at: 2019-08-04T19:19:21Z
updated_at: 2019-08-05T07:25:11Z
closed_at: 2019-08-05T07:25:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2191
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2191/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MDkyMTgy
title: handling gauntlets/boots without damage stats
state: closed
created_at: 2019-08-04T20:12:34Z
updated_at: 2019-08-05T07:25:20Z
closed_at: 2019-08-05T07:25:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2192
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2192/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0MTM5MDI4
title: Tailoring
state: closed
created_at: 2019-08-05T04:45:27Z
updated_at: 2020-06-15T20:59:22Z
closed_at: 2019-08-08T03:42:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2193
type: pull
body:
  Some tailoring cleanup. Verified all the properties and text from the (limited number) of pcaps and added in some support to try to clean up potential IconOverlay issues. Also removed the ability to reduce chest armor to places they're not supposed to go (e.g. anywhere but chest)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2193/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NDIxNTk4
title: updating start-server version
state: closed
created_at: 2019-08-05T18:59:00Z
updated_at: 2019-08-05T20:28:16Z
closed_at: 2019-08-05T20:28:16Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2194
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2194/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NDQwNTk1
title: Save Items coming from player corpses
state: closed
created_at: 2019-08-05T20:01:47Z
updated_at: 2019-08-21T00:02:58Z
closed_at: 2019-08-05T20:32:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2195
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2195/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NDgyODcy
title: Several changes related to NPK, PK, PKL switching for players and world type changes for admins
state: closed
created_at: 2019-08-05T22:29:13Z
updated_at: 2019-08-21T00:02:57Z
closed_at: 2019-08-09T07:19:06Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2196
body:
  - No PKing allowed in Training Dungeon.
  - Extra time to get character out of starter town.

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2196/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NDk4MzUx
title: adding RestrictionDB to house combat barriers
state: closed
created_at: 2019-08-05T23:52:29Z
updated_at: 2019-08-06T23:00:45Z
closed_at: 2019-08-06T23:00:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2197
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2197/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NTA3NDE3
title: log4net.config.example
state: closed
created_at: 2019-08-06T00:51:41Z
updated_at: 2019-08-06T10:44:40Z
closed_at: 2019-08-06T10:44:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2198
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2198/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NTU1NzA0
title: [WIP] fix olthoi armor AL for existing shard
state: closed
created_at: 2019-08-06T05:41:19Z
updated_at: 2020-04-18T20:14:45Z
closed_at: 2020-04-18T20:14:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2199
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2199/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA0NTY2MTgw
title: add tinkering log
state: closed
created_at: 2019-08-06T06:27:20Z
updated_at: 2019-08-06T18:25:21Z
closed_at: 2019-08-06T18:25:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2200
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA1MzcyMjM2
title: Mine
state: closed
created_at: 2019-08-08T01:12:16Z
updated_at: 2019-08-08T01:15:51Z
closed_at: 2019-08-08T01:12:28Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2201
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2201/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MTcyMDc5
title: Misc. Advocate System Updates
state: closed
created_at: 2019-08-10T00:41:25Z
updated_at: 2019-08-21T00:02:57Z
closed_at: 2019-08-10T06:15:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2202
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2202/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MTg0ODU1
title: adding trophy drop rate config option
state: closed
created_at: 2019-08-10T04:46:28Z
updated_at: 2019-08-10T08:07:57Z
closed_at: 2019-08-10T08:07:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2203
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2203/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MTkyNDAw
title: adding SyncLocation for enter_world()
state: closed
created_at: 2019-08-10T07:12:04Z
updated_at: 2019-08-10T08:08:06Z
closed_at: 2019-08-10T08:08:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2204
body: This fixes the bug with scatter generator position broadcasting
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2204/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MTk1NzYz
title: Fix issue with encounter overrides
state: closed
created_at: 2019-08-10T08:16:00Z
updated_at: 2019-08-21T00:02:54Z
closed_at: 2019-08-10T08:18:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2205
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2205/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjAzNDQz
title: Some Fixes for IsDecayable, VendorService, ManaStones
state: closed
created_at: 2019-08-10T10:43:19Z
updated_at: 2019-08-21T00:02:53Z
closed_at: 2019-08-11T04:08:14Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2206
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2206/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NzkyODc3MTA=
title: Eternal Mana Stone not functioning correctly
state: closed
created_at: 2019-08-10T17:11:24Z
updated_at: 2019-08-11T04:08:16Z
closed_at: 2019-08-11T04:08:16Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Eternal Mana Stone works correctly the first time; however, subsequent uses do not apply any mana but function like an empty mana stone.  The stone won't destroy other items and doesn't get destroyed itself; however, the stored mana is getting consumed on the first use.

  ### The log given by the failure.
  No log messages

  ### Desired functionality.
  The store mana should not be consumed on use.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2207/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NzkyOTAyMDk=
title: Ability to modify creatures vitals/attributes/skills in game.
state: closed
created_at: 2019-08-10T17:39:37Z
updated_at: 2022-02-19T20:34:52Z
closed_at: 2022-02-19T20:34:52Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```

  ### Desired functionality.

  Would like the ability to modify a creatures vitals/attributes/skills in game. 

  Example usage, use the command /create to spawn a mob. Then select that mob and increase it's max health and attack/defense skills. 

  This would allow creating unique one time creatures in game without having to create new weenies or restarting the server. 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2208/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NzkyOTA0NTE=
title: Ability to modify character vitals/attributes/skills in game.
state: closed
created_at: 2019-08-10T17:42:11Z
updated_at: 2022-02-19T20:34:55Z
closed_at: 2022-02-19T20:34:55Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```


  ### Desired functionality.
  Currently modifying a character's vitals/attributes/skills through the db, requires restarting ACE to apply. 

  Some sort of command that would force a reload of a character from the db would allow changes to be made and used without restarting the entire ACE server. 

  Or an ingame command that would allow changing vitals/attributes/skills on a character in real time.

  This could be used in conjunction with the /morph command to create player controlled monsters. 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2209/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjQzNjg4
title: adding IsDead check to falling damage
state: closed
created_at: 2019-08-10T22:57:25Z
updated_at: 2019-08-11T07:24:50Z
closed_at: 2019-08-11T07:24:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2210
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2210/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjU1MTM2
title: Fix issue with spell book probabilities
state: closed
created_at: 2019-08-11T04:15:38Z
updated_at: 2019-08-21T00:02:55Z
closed_at: 2019-08-11T07:28:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2211
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2211/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjYxMzg0
title: fixing issue with tenacity/blight
state: closed
created_at: 2019-08-11T07:05:56Z
updated_at: 2019-08-11T07:25:12Z
closed_at: 2019-08-11T07:25:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2212
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2212/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjYzNjcw
title: adding support for spell projectile traps
state: closed
created_at: 2019-08-11T07:56:30Z
updated_at: 2019-08-11T09:05:54Z
closed_at: 2019-08-11T09:05:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2213
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2213/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjY0MzQ0
title: fixing weapon cast gesture
state: closed
created_at: 2019-08-11T08:09:51Z
updated_at: 2019-08-11T09:06:05Z
closed_at: 2019-08-11T09:06:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2214
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MjY4NDc5
title: updating Martyr's Tenacity / Blight messages to match retail
state: closed
created_at: 2019-08-11T09:33:54Z
updated_at: 2019-08-12T02:51:25Z
closed_at: 2019-08-12T02:51:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2215
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2215/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2Mjc1MDcy
title: Revert "prototype: GfxObjCache + WeakReference (#1692)"
state: closed
created_at: 2019-08-11T11:49:13Z
updated_at: 2019-08-21T01:03:53Z
closed_at: 2019-08-21T01:03:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2216
body:
  This reverts commit 509ebd6148fb71ef4d884333924eb1d0a7284ef1.

  Not needed anymore.

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2216/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2Mjc1Njgy
title: Cleanup log.Info level messages
state: closed
created_at: 2019-08-11T12:00:40Z
updated_at: 2019-08-31T00:30:12Z
closed_at: 2019-08-31T00:25:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2217
type: pull
body:
  Log.info is the default console output and is intended for:
  server startup
  connection/disconnections
  admin initiated command output
  server shutdown

  Log.Debug is the appropriate level for debug-type messages that are to be logged and audited at a later date, but not output to the console.

  To filter specific messages to a separate file for easy auditing, see log4net.config.example

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2217/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2Mjk2NTAz
title: Minor coinstack / PreCheckItem refactor
state: closed
created_at: 2019-08-11T17:45:33Z
updated_at: 2019-08-21T00:02:50Z
closed_at: 2019-08-12T04:44:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2218
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2218/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzA0Njk5
title: Commands to modify max-vitals and skills
state: closed
created_at: 2019-08-11T20:02:30Z
updated_at: 2019-09-15T03:44:40Z
closed_at: 2019-09-15T03:44:40Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2219
type: pull
body:
  Adds two new admin commands for (1) modifying the max vitals for an NPC or player, (2) modifying the skill levels for an NPC or player

  https://github.com/ACEmulator/ACE/issues/2209 and https://github.com/ACEmulator/ACE/issues/2208

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2219/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0Nzk0MTYzNTg=
title: Remove deleted chars and associated entries from shard db
state: closed
created_at: 2019-08-11T21:44:42Z
updated_at: 2019-09-28T04:01:26Z
closed_at: 2019-09-28T04:01:26Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```


  ### Desired functionality.

  This is not a high priority item. More of a wish list sort of feature. 

  Currently when a character is deleted, the character is marked as deleted in the shard db and that's it. The actual entries in the db aren't removed/deleted.

  What I propose would be a way to remove these deleted characters along with any other associated db entries like biotas / inventory items. 

  This could be done through an SQL file (ran manually against the db by the server operator) or a function builtin to ACE. Being built into ACE, would allow automatic clean up. 

  This would be a configurable option in days that would default to off. So you could set the configuration to say 30 to remove any deleted characters from the db older than 30 days. This would still allow being able to look back at recently deleted characters. 

  The function in ACE would cleanly and properly delete the character and all related entries from the shard db by the date of deletion set by the configurable option. This could either run on server startup or a set interval while the server is running. 

  One thing to consider would be ACE has builtin GUID recycling. So when these entries are deleted from the database, would their GUIDs then be freed to use again?

  Main reason for this feature would be to reduce the growing size of shard db's on high population servers and to keep the db as efficient as possible. 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2220/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzE0NDE1
title: fix parse types
state: closed
created_at: 2019-08-11T21:57:24Z
updated_at: 2019-08-12T02:49:44Z
closed_at: 2019-08-12T02:49:44Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2221
type: pull
body:
  some types were parsed as an int, but needed to be a long and would cause an exception causing the player to be stuck in godmode

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2221/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzI5OTQ3
title: Fix Mana Stone bug
state: closed
created_at: 2019-08-12T01:29:59Z
updated_at: 2019-08-21T00:02:52Z
closed_at: 2019-08-12T01:58:17Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2222
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2222/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzQyNzY2
title: Support Purging of deleted Characters from database
state: closed
created_at: 2019-08-12T03:42:10Z
updated_at: 2019-10-21T02:33:56Z
closed_at: 2019-09-28T04:01:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2223
body: Resolves #2220
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2223/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzQ5NDUw
title: fix stiletto animations
state: closed
created_at: 2019-08-12T04:37:46Z
updated_at: 2019-08-12T23:23:44Z
closed_at: 2019-08-12T23:23:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2224
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2224/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzU0MzY5
title: Added command to create named object, with count specified
state: closed
created_at: 2019-08-12T05:14:14Z
updated_at: 2019-08-12T23:23:56Z
closed_at: 2019-08-12T23:23:56Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2225
type: pull
body:
  Adds the ability to create objects with a specified name. This primarily exists for the creation of new mobs, from a biota/template, with a different name, for live events / custom content for server operators. Another sample use case is to spawn an obscure portal with a new name.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2225/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2MzYyODYw
title: able to create stacks and multiple objects with /create
state: closed
created_at: 2019-08-12T06:09:11Z
updated_at: 2019-08-15T01:46:15Z
closed_at: 2019-08-15T01:46:15Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2226
type: pull
body:
  /create now takes a second argument (defaults to one) and will create a stack if possible or spawn that many of the weenie you specify 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2226/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2Mzg5MTE2
title: fixing some minor house issues
state: closed
created_at: 2019-08-12T08:03:17Z
updated_at: 2019-08-12T23:23:33Z
closed_at: 2019-08-12T23:23:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2227
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2227/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2NzAyMjI4
title: Obj desc update
state: closed
created_at: 2019-08-13T00:09:30Z
updated_at: 2020-06-15T20:58:52Z
closed_at: 2019-08-13T02:52:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2228
type: pull
body:
  Fixes some small issues that were reported with armor layering (things appearing that shouldn't, things covering up things they shouldn't, etc)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2228/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2NzE1Mjkx
title: Update rares
state: closed
created_at: 2019-08-13T01:35:23Z
updated_at: 2019-08-18T04:48:47Z
closed_at: 2019-08-13T02:51:01Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2229
body: - Remove a few retired rares and updated one that changed wcids
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2229/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA2NzE2MzMx
title: adding DamageType.Undefined protection / logging
state: closed
created_at: 2019-08-13T01:42:38Z
updated_at: 2019-08-13T04:15:36Z
closed_at: 2019-08-13T04:15:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2230
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2230/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA3MTUyMTEw
title: improved collision detection for archers
state: closed
created_at: 2019-08-14T03:13:31Z
updated_at: 2019-08-15T02:57:15Z
closed_at: 2019-08-15T02:57:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2231
type: pull
body:
  this fixes the bug with 'missile attack hit the environment' mis-detection

  repro steps:

  /create 42670
  make sure /attackable on
  let it start attacking you
  equip yumi/arrows, go into missile combat stance, attack low

  expected:

  the crystalline wisp evades (it has no low body parts)

  actual:

  missile attack hit the environment

  This is a multi-faceted bug, but one of the core issues is that when standing within point-blank range of a target, missile projectiles are being collision adjusted by that hittable target during spawn. This is counter-intuitive; the collision should be detected, and returned immediately. The desired functionality can be enabled by using enter_world(slide = false) instead of the default true.

  Projectiles sliding during spawn also had other unintended side effects, such as archers being able to stand directly behind trees/corners, and being able to launch their projectiles around the side of the obstructions.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2231/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA3MjIyNTEz
title: fixing some teleport issues
state: closed
created_at: 2019-08-14T08:29:06Z
updated_at: 2019-08-15T03:02:58Z
closed_at: 2019-08-15T03:02:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2232
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2232/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA3NTYxMzEx
title: random null checks
state: closed
created_at: 2019-08-15T02:35:44Z
updated_at: 2019-08-15T03:03:13Z
closed_at: 2019-08-15T03:03:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2233
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2233/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA3Nzk5MTEy
title: Hook & House Fixes
state: closed
created_at: 2019-08-15T18:00:20Z
updated_at: 2019-08-21T00:02:49Z
closed_at: 2019-08-16T05:34:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2234
type: pull
body:
  - Fix issue with invisible hooks on relinks (buy/abandon): bool/physicsstate mis-matches
  - Fix issue with RDB on house buy: missing InstanceIID update
  - Fix issue with logging into open houses: missing IsOpen check

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2234/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA3OTQ1NjE2
title: Destroy Items on Give to NPC
state: closed
created_at: 2019-08-16T05:33:26Z
updated_at: 2019-08-21T00:02:48Z
closed_at: 2019-08-16T06:45:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2235
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2235/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MDE0MzM2
title: adding content export commands
state: closed
created_at: 2019-08-16T09:56:24Z
updated_at: 2019-08-19T08:57:42Z
closed_at: 2019-08-19T08:57:42Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2236
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2236/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MDk5NTc5
title: Switch TickOutbound back to parallel
state: closed
created_at: 2019-08-16T14:33:11Z
updated_at: 2019-08-18T12:40:22Z
closed_at: 2019-08-18T12:40:11Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2237
type: pull
body:
  On CE this is using ~3 - ~6 ms, this should drop it down to ~1 ms

  On my local test env, this drops it down from 3 ms to 0.8 ms

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2237/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MjY3MjY1
title: adding /createinst for content creators to spawn landblock_instances in-game
state: closed
created_at: 2019-08-17T05:03:24Z
updated_at: 2020-01-10T07:53:21Z
closed_at: 2019-08-20T20:01:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2238
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2238/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MjcxOTQ3
title: Three changes
state: closed
created_at: 2019-08-17T06:50:11Z
updated_at: 2019-08-18T04:48:46Z
closed_at: 2019-08-17T16:48:34Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2239
type: pull
body:
  - Fix a possible array out of bounds exception in LootGenerationFactory_Magic.cs that could happen with tier 8
  - Add OverRobes to clothing drops
  - Remove unneeded return for OlthoiKoujiaArmor AL assignment

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2239/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MjczOTI3
title: reducing log spam for dynamic projectiles unable to enter world
state: closed
created_at: 2019-08-17T07:33:02Z
updated_at: 2019-08-17T08:44:38Z
closed_at: 2019-08-17T08:44:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2240
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2240/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4Mjk0NTU3
title: adding pathwarden salvage for new items
state: closed
created_at: 2019-08-17T14:13:26Z
updated_at: 2019-08-18T10:41:20Z
closed_at: 2019-08-18T10:41:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2241
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2241/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MzA5OTg0
title: Add some config.js.example comments
state: closed
created_at: 2019-08-17T18:23:00Z
updated_at: 2019-08-19T12:46:58Z
closed_at: 2019-08-19T12:46:48Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2242
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2242/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MzI5NDM5
title: Add support for Day/Night Generators
state: closed
created_at: 2019-08-18T01:29:26Z
updated_at: 2019-08-21T00:02:45Z
closed_at: 2019-08-18T05:59:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2243
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2243/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MzQxMjE3
title: Allow Account Characters to Swear Allegiance
state: closed
created_at: 2019-08-18T06:23:43Z
updated_at: 2019-08-21T00:02:44Z
closed_at: 2019-08-18T07:48:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2244
type: pull
body:
  Allow characters of accounts that have monarch-only housing on another character to be able to swear allegiance

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MzUwNjc1
title: Add StuckGuidAllocator
state: closed
created_at: 2019-08-18T09:35:03Z
updated_at: 2019-10-21T02:34:27Z
closed_at: 2019-08-19T05:30:32Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2245
type: pull
body:
  StuckGuidAllocator:
  - StuckGuidAllocator is used for any object that cannot be picked up/owned by a player.
  - It restarts at Max and the range is 0x60000000 to 0x6FFFFFFF.

  - Fixed an issue with creatures dropping wielded treasure to their corpses.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2245/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MzY0MDE5
title: Add some debug messages to GuidManager
state: closed
created_at: 2019-08-18T13:25:09Z
updated_at: 2019-08-18T21:48:33Z
closed_at: 2019-08-18T21:48:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2246
body: This also adds dynamic guid information to /serverstatus
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4Mzc4NTIw
title: Fix issue with creatures dropping their wieldables to corpses
state: closed
created_at: 2019-08-18T16:57:44Z
updated_at: 2019-08-21T00:02:41Z
closed_at: 2019-08-18T21:21:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2247
type: pull
body:
  This fixes the unable to move errors that occur for 25 seconds after death, as well as requiring reloading the corpse to see the items after they disappear the first time

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2247/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4Mzg4Nzky
title: warning for regen interval < 0 / lockup prevention
state: closed
created_at: 2019-08-18T19:44:30Z
updated_at: 2019-08-18T21:07:35Z
closed_at: 2019-08-18T21:07:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2248
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2248/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4MzkyOTI4
title: tele update
state: closed
created_at: 2019-08-18T20:50:29Z
updated_at: 2019-08-19T09:05:24Z
closed_at: 2019-08-19T09:05:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2249
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NDM2MDQy
title: Fix some issues with Pickup and Wield
state: closed
created_at: 2019-08-19T04:08:09Z
updated_at: 2019-08-21T00:02:40Z
closed_at: 2019-08-19T07:51:43Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2250
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2250/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NTc3NjQz
title: fixing dual wielding
state: closed
created_at: 2019-08-19T12:02:08Z
updated_at: 2019-08-19T18:50:27Z
closed_at: 2019-08-19T18:50:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2251
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2251/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NTg2NDEw
title: fixing some gaps for swapping weapons after launching a projectile
state: closed
created_at: 2019-08-19T12:26:12Z
updated_at: 2019-08-21T00:28:20Z
closed_at: 2019-08-21T00:28:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2252
type: pull
body:
  This bug is showing up in the logs as DamageType.Undef when a monster launches its last projectile, and switches to melee combat while the projectile is in-flight, before it hits the target

  A similar bug can also be reproed by the player, where you launch a prismatic arrow, and then dequip bow before the arrow hits the target

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2252/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NjI2MzAz
title: Relocate landblock tick code and add more detailed landblock tick performance measurements
state: closed
created_at: 2019-08-19T14:04:04Z
updated_at: 2019-08-19T23:08:35Z
closed_at: 2019-08-19T23:08:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2253
type: pull
body:
  Landblock tick management has been moved from WorldManager to LandblockManager

  Individual landblock physics ticking has been moved all the way down to Landblock

  Landblock now includes a 5m rate monitor in addition to the 1hr it already had

  landblockperformance /allstats now reports a combined report from both 5m and 1hr rate monitoring.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2253/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4Njg3NDAx
title: ensure GetCleaveTargets() doesn't return targets in dying state
state: closed
created_at: 2019-08-19T16:25:45Z
updated_at: 2019-08-19T19:01:24Z
closed_at: 2019-08-19T19:01:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2254
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2254/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NzA5NzU1
title: update steel and covenant armor
state: closed
created_at: 2019-08-19T17:30:10Z
updated_at: 2019-08-19T19:01:40Z
closed_at: 2019-08-19T19:01:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2255
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2255/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NzMxODkw
title: Fix bug with wielding and ValidLocations
state: closed
created_at: 2019-08-19T18:35:29Z
updated_at: 2019-08-21T00:02:39Z
closed_at: 2019-08-19T18:50:18Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2256
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2256/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NzMzNTUx
title: finesse attribute mod
state: closed
created_at: 2019-08-19T18:40:17Z
updated_at: 2019-08-20T20:01:38Z
closed_at: 2019-08-20T20:01:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2257
type: pull
body:
  This updates the Finesse Weapons attribute mod to use Coordination instead of Strength

  It also keeps the same attribute mod factor as the other melee weapons

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2257/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4NzUzNzMy
title: Revert "Switch TickOutbound back to parallel"
state: closed
created_at: 2019-08-19T19:41:24Z
updated_at: 2019-08-19T23:38:20Z
closed_at: 2019-08-19T19:44:53Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2258
type: pull
body:
  Reverts ACEmulator/ACE#2237

  Rolling this back until I can come up with a better thread sharing plan.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2258/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4ODE4MDAz
title: Add OS and vCPU to serverstatus
state: closed
created_at: 2019-08-19T23:16:33Z
updated_at: 2019-08-19T23:36:43Z
closed_at: 2019-08-19T23:36:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2259
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4ODI5NjQx
title: Add global configuration for SpellComponentsRequired
state: closed
created_at: 2019-08-20T00:16:04Z
updated_at: 2019-08-21T00:02:35Z
closed_at: 2019-08-20T23:58:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2260
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2260/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4ODQ0MTMy
title: Limit database from taking all the threads
state: closed
created_at: 2019-08-20T01:50:30Z
updated_at: 2019-09-08T21:27:27Z
closed_at: 2019-09-08T21:27:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2261
type: pull
body:
  This adds limits to the database thread consumption.

  It also should allow the world to now consume threads easier.

  The way it is done is as follows.

  - We determine the number of available threads using Environment.ProcessCount
  - We allocate (int)Math.Max(Environment.ProcessorCount * .34, 1) to the World, and the remainder tothe database.

  It breaks down as follows
  1 vCPU = ACE will not start
  2 vCPU = 1 thread world, 1 thread database
  3 vCPU = 1 thread world, 2 thread database
  4 vCPU = 1 thread world, 3 thread database
  5 vCPU = 1 thread world, 4 thread database
  6 vCPU = 2 thread world, 4 thread database
  7 vCPU = 2 thread world, 5 thread database
  8 vCPU = 2 thread world, 6 thread database
  9 vCPU = 3 thread world, 6 thread database
  10 vCPU = 3 thread world, 7 thread database
  11 vCPU = 3 thread world, 8 thread database
  12 vCPU = 4 thread world, 8 thread database

  I'd like to get some feedback from this PR on various sized servers.

  What you may notice is that loading a player may take slightly longer (very slightly).

  What you will probably notice is no discernible difference in-game.

  What I want to make sure happens is that the world doesn't end up feeling more choppy due to the parallel processing of outbound network traffic. Hopefully the more fair thread distribution will help prevent thread starvation.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4ODc2ODk0
title: Add UseCreateItem + UseCreateQuantity support to Gems
state: closed
created_at: 2019-08-20T05:05:07Z
updated_at: 2019-08-21T00:02:38Z
closed_at: 2019-08-20T23:52:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2262
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2262/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA4ODg3OTc4
title: Update TakeItems msg to match retail messaging
state: closed
created_at: 2019-08-20T06:01:23Z
updated_at: 2019-08-21T00:02:37Z
closed_at: 2019-08-20T23:58:24Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2263
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2263/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5MDM1OTI2
title: adding EmoteType.RemoveVitaePenalty
state: closed
created_at: 2019-08-20T12:53:13Z
updated_at: 2019-08-20T23:53:33Z
closed_at: 2019-08-20T23:53:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2264
type: pull
body:
  - Replaces the EmoteType.RemoveVitaePenalty stub with the correct call
  - Adds /remove-vitae developer command
  - Fixes a bug where death was clearing cooldowns

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2264/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5Mjk3ODEx
title: Fix Landblock Monitors
state: closed
created_at: 2019-08-21T02:27:25Z
updated_at: 2019-08-21T02:29:32Z
closed_at: 2019-08-21T02:29:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2265
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2265/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5MzExMTc0
title: fixing aetheria crash
state: closed
created_at: 2019-08-21T03:46:36Z
updated_at: 2019-08-21T05:45:01Z
closed_at: 2019-08-21T05:45:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2266
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2266/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5MzI1NzY3
title: ProcSpell Changes
state: closed
created_at: 2019-08-21T05:09:52Z
updated_at: 2019-10-21T02:34:28Z
closed_at: 2019-08-21T08:05:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2267
body:
  - Skip adding ProcSpell to Aetheria's spellbook
  - Add ProcSpell to appraisal messages

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2267/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5NDE1NjA0
title: updating salvaging formula to match retail
state: closed
created_at: 2019-08-21T09:47:38Z
updated_at: 2019-08-21T19:46:53Z
closed_at: 2019-08-21T19:46:53Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2268
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2268/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5NjQwODIz
title: Update PortalSending and FellowPortalSending
state: closed
created_at: 2019-08-21T18:57:02Z
updated_at: 2019-10-21T02:34:30Z
closed_at: 2019-08-22T03:51:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2269
body: Update code to magic retail messaging
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2269/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5NjQyODQ1
title: Allow Hooks to be used by roommates
state: closed
created_at: 2019-08-21T18:59:59Z
updated_at: 2019-10-21T02:34:29Z
closed_at: 2019-08-22T03:52:46Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2270
body: Per retail, after 03-2006 all characters of an account could manage hook contents
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5Njc2NDYx
title: starting to clean up /acecommands a bit
state: closed
created_at: 2019-08-21T20:35:01Z
updated_at: 2019-08-25T05:05:50Z
closed_at: 2019-08-25T05:05:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2271
type: pull
body:
  - Added an optional &lt;access level&gt; parameter to filter /acecommands
  If this is specified, and the current user's access level is at least the requested level, the output will show the commands specifically for that access level.
  ie., if an Admin types /acecommands developer, it will show them just the commands with AccessLevel.Developer
  if a regular player types /acecommands developer, it will not show them the developer commands, and will just show them the regular commands they would see from /acecommands

  - Added the ability search /acecommands by keyword. Ex., /acecommands house

  - Started to clean up the text for all of the descriptions for display in-game. Some parameters that were directly in the descriptions were moved to the "parameters" section of the command.
  The commands from the admin client that are still unimplemented were left with blank descriptions, to a) indicate in acecommands that these are still unimplemented, and b) make it easier for developers to see which commands still need to be implemented

  - Fixed a few AccessLevels and CommandHandlerFlags, so typing acecommands from the console shows clean output again

  TODO:

  - Ensure the commands in the &lt;AccessLevel&gt;Commands.cs files match the actual AccessLevel of the command
  - Review with the team the AccessLevels for some of the commands, and make sure the AccessLevels are set appropriately

  Currently the 'Developer' AccessLevel has the most commands, and it is possible many of these commands could be moved to lower access levels

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2271/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5NzY2MjMw
title: LootTable Clothing Fix-Up
state: closed
created_at: 2019-08-22T03:31:14Z
updated_at: 2019-08-23T05:19:22Z
closed_at: 2019-08-22T04:43:42Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2272
body: - Remove weenies that don't belong in loot and add some missing ones, per ac.yotesfan.com data
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2272/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5NzczNjc0
title: Tweak IOU code
state: closed
created_at: 2019-08-22T04:17:03Z
updated_at: 2019-10-21T02:34:31Z
closed_at: 2019-08-22T18:57:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2273
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5ODAwNjM0
title: Fix issue with CoinValue desync
state: closed
created_at: 2019-08-22T06:30:11Z
updated_at: 2019-10-21T02:34:31Z
closed_at: 2019-08-22T18:57:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2274
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2274/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5OTMyMzU5
title: removing officer titles from allegiance info packet
state: closed
created_at: 2019-08-22T12:17:51Z
updated_at: 2019-08-22T18:44:45Z
closed_at: 2019-08-22T18:44:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2275
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2275/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5OTk2MTY1
title: setting IsBusy while dying
state: closed
created_at: 2019-08-22T14:42:32Z
updated_at: 2019-08-22T18:44:54Z
closed_at: 2019-08-22T18:44:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2276
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2276/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzA5OTk4NjE0
title: adjusting WEENIE_MAX for custom content
state: closed
created_at: 2019-08-22T14:47:33Z
updated_at: 2019-08-24T04:40:16Z
closed_at: 2019-08-24T04:40:16Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2277
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2277/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwMDc0NjYx
title: fix restriction db null
state: closed
created_at: 2019-08-22T17:55:36Z
updated_at: 2019-08-22T18:44:19Z
closed_at: 2019-08-22T18:44:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2278
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2278/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwMDc4NDE4
title: Housing: Basements and Hooks changes
state: closed
created_at: 2019-08-22T18:06:00Z
updated_at: 2019-10-21T02:34:20Z
closed_at: 2019-09-15T03:46:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2279
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2279/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwMjI3MTY1
title: Fix the GetWield method for magic casters
state: closed
created_at: 2019-08-23T04:34:09Z
updated_at: 2019-08-23T05:19:21Z
closed_at: 2019-08-23T04:52:00Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2280
type: pull
body:
  - According to loot tier breakdowns, tiers 1 through 3 should not have a chance for a wield requirement on the caster; ref. http://acpedia.org/wiki/Loot

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2280/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNTI4ODcy
title: filling a gap with item spell redirects
state: closed
created_at: 2019-08-23T20:46:05Z
updated_at: 2019-08-24T02:03:20Z
closed_at: 2019-08-24T02:03:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2281
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2281/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNTM4NjUw
title: fixing issue with thrown goblets
state: closed
created_at: 2019-08-23T21:23:50Z
updated_at: 2019-08-24T04:40:28Z
closed_at: 2019-08-24T04:40:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2282
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2282/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNTY0MDgw
title: Fix Pickup and Wield crash
state: closed
created_at: 2019-08-23T23:44:58Z
updated_at: 2019-10-21T02:34:32Z
closed_at: 2019-08-24T04:46:39Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2283
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2283/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNTgzOTgw
title: Fix selling no value items to vendors
state: closed
created_at: 2019-08-24T04:53:15Z
updated_at: 2019-10-21T02:34:25Z
closed_at: 2019-08-24T04:55:49Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2284
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2284/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNjU0NTE3
title: Update Landblock.cs
state: closed
created_at: 2019-08-25T03:12:57Z
updated_at: 2019-10-21T02:34:24Z
closed_at: 2019-09-15T03:44:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2285
body:
  - Update Logging messages
  - Notify Generator of spawn failure for regen retry

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2285/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNjU3NzY3
title: fixing loot generator null crashes, cleanup
state: closed
created_at: 2019-08-25T04:40:08Z
updated_at: 2019-08-25T06:57:48Z
closed_at: 2019-08-25T06:57:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2286
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2286/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNjY2NTA2
title: adding server option for aetheria healing over time message color
state: closed
created_at: 2019-08-25T08:02:48Z
updated_at: 2019-09-15T03:45:50Z
closed_at: 2019-09-15T03:45:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2287
type: pull
body:
  This option was requested, it seems that a number of players (including myself) would like an option for the aetheria / healing over time message color to be green or blue, instead of the red combat text color

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2287/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEwNzcxOTI0
title: Guid Recycle Redux
state: closed
created_at: 2019-08-26T05:42:41Z
updated_at: 2019-10-21T02:34:22Z
closed_at: 2019-09-15T03:45:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2288
type: pull
body:
  - Added code to send DestroyObject messages from objects being destroyed to those that know about it when it is not on a landblock (Corpse/Chest/Container)
  - Re-enabled Guid Recycling

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2288/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEyMzA3MjIx
title: Log4 net async and color
state: closed
created_at: 2019-08-29T13:01:59Z
updated_at: 2019-08-31T00:29:42Z
closed_at: 2019-08-31T00:28:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2289
type: pull
body:
  This builds on the existing log4net PR in queue.

  This add:
   - Color to the console output
   - Log4Net.Async support, which should improve performance of ACE in general. Previously, every log.X() call was a blocking call. Now, the async appender (if used) will buffer the event and ACE can continue ticking.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2289/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEyOTA4OTgz
title: Log Failed Transitions
state: closed
created_at: 2019-08-30T23:24:35Z
updated_at: 2019-08-31T00:29:53Z
closed_at: 2019-08-31T00:29:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2290
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2290/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEyOTgyMjI1
title: Fix Katars in LootTables.LightWeaponsMatrix
state: closed
created_at: 2019-08-31T21:08:00Z
updated_at: 2019-10-21T02:34:21Z
closed_at: 2019-08-31T21:51:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2291
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2291/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEzMDA0Mzg4
title: Update logging with some missing tags.
state: closed
created_at: 2019-09-01T05:25:58Z
updated_at: 2019-10-21T02:34:23Z
closed_at: 2019-09-01T06:52:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2292
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2292/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEzMDcyNzgw
title: Updating Changelog for August
state: closed
created_at: 2019-09-01T23:24:28Z
updated_at: 2019-09-02T01:05:05Z
closed_at: 2019-09-02T01:05:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2293
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2293/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEzMTM5Mzgw
title: Revert "PlacementPosition is not an enum type. It's an inventory order (index)"
state: closed
created_at: 2019-09-02T07:06:08Z
updated_at: 2019-09-02T07:09:45Z
closed_at: 2019-09-02T07:09:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2294
type: pull
body:
  Reverts ACEmulator/ACE#2069

  PlacementPosition references enum Placement, See [LongBow](https://github.com/ACEmulator/ACE-World-16PY/blob/master/Database/3-Core/9%20WeenieDefaults/SQL/MissileLauncher/MissileWeapon/00306%20Longbow.sql) and other MissileLaunchers for example.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2294/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzEzNTYxNzI5
title: Remove the \n at the end of the failed transition message
state: closed
created_at: 2019-09-03T12:11:21Z
updated_at: 2019-09-03T12:14:10Z
closed_at: 2019-09-03T12:13:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2295
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2295/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE1NzU0NDAx
title: Create ServerObjectManager
state: closed
created_at: 2019-09-09T23:27:43Z
updated_at: 2019-09-16T00:42:49Z
closed_at: 2019-09-16T00:42:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2296
type: pull
body:
  This removes the ServerObjects collection out of ObjectMaint into it's own class.

  This paves the way for thread safety that will need to be added to ObjectMaint for the multi-threaded landblock groups.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2296/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE1OTQ1NTE2
title: LandblockManager/Landblock now manages Physics Landblocks
state: closed
created_at: 2019-09-10T11:25:14Z
updated_at: 2019-09-22T21:23:20Z
closed_at: 2019-09-22T21:23:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2297
type: pull
body:
  LandblockManager:
  - Improved locks
  - Only sets adjacents on GetLandblock if the landblock was just loaded, or, if loadAdjacents was set
  - Now passes the adjacents to the physics landblock instead of asking the physics landblock to recalculate their own adjacents
    
    
  ACE.Server.Entity.Landblock:
  - _landblock renamed to PhysicsLandblock
  - contructs the phyics landblock directly instead of using LScape.get_landblock
  - Has a new Init() function that should be called after ctor to actually init the landblock
    
    
  ACE.Server.Physics.Common.LScape:
  - local landblock management is only used if Physics.Engine.Instance.Server is set to false
    
    
  ACE.Server.Physics.Common.Landblock:
  - Local adjacent calculation has been removed. IIRC, the 3rd party tools do not deal with adjacents.
    
    
  ACE.Server.Physics.Common.ObjectMaint:
  - To get a list of ServerObjects in the area, the work (funciton) has been added to the physics landblock class where it can more easily be made thread safe

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2297/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE2OTk2NTYy
title: Fix Creature ObjDesc issues
state: closed
created_at: 2019-09-12T16:43:49Z
updated_at: 2019-10-21T02:34:19Z
closed_at: 2019-09-12T17:48:50Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2298
type: pull
body:
  - Fix issue with AlternateSetup for certain non-human models
  - Fix issue with Umbraen Males and Female crown options

  Co-Authored-By: OptimShi <optimshi@users.noreply.github.com>

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE3NTEzNjI1
title: Add configuration for number of threads
state: closed
created_at: 2019-09-13T23:45:58Z
updated_at: 2019-09-15T12:15:12Z
closed_at: 2019-09-15T12:14:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2299
type: pull
body:
  This doesn't persist to the actual .config yet, but still provides a local way to manage thread count allocation.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2299/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0OTM1ODI3NjY=
title: Impious Staff Quest
state: closed
created_at: 2019-09-14T04:35:39Z
updated_at: 2019-10-02T20:27:40Z
closed_at: 2019-10-02T20:27:40Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  1) Goto Roderick in the Mitemaze... 

  /teleloc  0x01F80374 [94.233902 -12.049300 6.005000] -0.721084 0.000000 0.000000 -0.692848
  2) Create a Broken Imp staff ( /ci 5936 )
  3) Create Iron Ore (/ci 5938 )
  4) Hand the Broken Staff to Roderick, he will go thru his speech then hand you a Smelting Pot.
  5) use the pot on the Iron Ore (Producing slag)
  6) hand the slag to Roderick, he in turn gives you the Impious Staff.

  Now Reset you computers date/time to 1 Month in the future and and repeat steps 2 thru 6.
  He will except the Broken staff and Hand you the Smelting pot again.
  Now for the Glitch. He will return the Slag and say...
  "That is nice and all, but I need a staff to fix before that slag is of any use."
  I have tried to adjust the timer in the DB as well as resetting my computers date/time (up to 2 months later) and still get the same reply.
  Now im not 100% sure Im right but the WiKi shows a 1 month timer on this quest. I did try to hand in another broke staff RIGHT after I did the quest before changing the date/time and he simply returned the Broken staff to me. That is when I reset the date/time to see if the timer was working, it is.

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  To be able to repeat the Quest every Month.

  ### Mention any other details that might be useful.
  I don't know if it is a DB issue or a Server code issue. so I posted here. If im wrong sorry.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2300/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE3NTczNjI2
title: Rebase SQL scripts
state: closed
created_at: 2019-09-14T16:41:57Z
updated_at: 2019-10-21T02:34:11Z
closed_at: 2019-09-15T03:46:04Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2301
body: Archived previous scripts for legacy servers not yet upgraded
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2301/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE3NjE5NDUx
title: Generate Random Faces for CreatureType.Empyrean
state: closed
created_at: 2019-09-15T08:23:11Z
updated_at: 2019-10-21T02:34:09Z
closed_at: 2019-09-16T01:28:47Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2302
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2302/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE3Njg3NjY4
title: Multi-thread landblock ticking (Landblock Groups w/Thread Safety)
state: closed
created_at: 2019-09-16T01:00:10Z
updated_at: 2019-10-09T01:26:43Z
closed_at: 2019-10-09T01:25:50Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2303
type: pull
body:
  This is the start of "landblock group" ticking.

  The idea behind the landblock groups are that each group may contain multiple landblocks that must be ticked on the same thread, but, each group itself can be ticked on independent threads.

  Landblock groups describe their area using a rectangle. As landblocks are added (and removed) the rectangle that contains all the landblocks in the group is adjusted.

  Landblocks are added to groups based on a minimum distance to the landblock groups rectangle.

  In the event a landblock needs to be added and is within range of multiple groups, those groups will be combined into one.

  Periodically, landblock groups are checked to see if they can be split. When a landblock group is split, it can result in a new group that has an overlapping rectangle to the parent group. This is not a problem because all the landblocks within each group meet the minimum distance requirements. In the event that a new landblock is added and is close to both rectangles, the groups will then be merged again.

  Adding landblocks to groups is a very efficient process
  Removing landblocks from groups is a very efficient process
  Checking landblock groups for split potential does incur some overhead (~0.5 ms) which is why it's only done on intervals that are twice the Landblock.UnloadInterval.


    
    
  Things still to do: Investigate more thread safety in the following scenarios
  - Actions that come in from the client do not need to be checked for thread safety. Client actions are processed in a single thread.
  - Actions are the result of a landblock tick, or world object tick need to be checked for thread safety.
  - World actions that result in fellowship adjustments should be investigated
  - World actions that result in allegiance adjustments should be investigated

  Creature OnDeath needs to examined.
  - Players in the DamageHistory list can be on separate threads.
  - This includes player xp, fellowship xp, allegiance xp.
  - The target actor of an emote action can be on a separate thread.
    
  Additional Changes we've had to made for thread safety
  - ACE.Server/Network/Sequence/SequenceManager
  - Source/ACE.Server/Physics/Common/ObjectMaint (Need to safely manage/maintain relationships)

  ToDo:
  - ACE\Source\ACE.Server\Entity\Fellowship.cs
  - ACE\Source\ACE.Server\Managers\AllegianceManager.cs
  - ACE\Source\ACE.Server\WorldObjects\Allegiance.cs
  - ACE\Source\ACE.Server\Managers\QuestManager.cs
  - ACE\Source\ACE.Server\Managers\HouseManager.cs

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2303/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE3Njg4NzQ1
title: GuidManager comments
state: closed
created_at: 2019-09-16T01:14:30Z
updated_at: 2019-09-16T02:07:30Z
closed_at: 2019-09-16T02:07:18Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2304
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2304/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE4MzU5MjQz
title: Move WorldObject specific managers to a different folder
state: closed
created_at: 2019-09-17T14:08:48Z
updated_at: 2019-09-22T21:20:20Z
closed_at: 2019-09-22T21:20:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2305
type: pull
body:
  This helps better visualize the manager usage between
  - server wide
  - world object localized

  I'm doing this because as I travel down the rabbit hole of server-wide thread safety, these types of separations help make it easier to understand what managers need more attention for thread safety vs world object localized managers that sould be thread safe because their parent wo should be thread safe (key word *should*)

  I'll be adding thread safety to these server-wide managers and want to organize them better first to reduce the size of the multi-threading PR. This makes it easier to read, and easier to roll back if needed.

  QuestManager remains in the server wide folder because it is used for both WorldObjects and Fellowships.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2305/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE4NjIxOTgz
title: Fix a couple of hook issues
state: closed
created_at: 2019-09-18T04:27:54Z
updated_at: 2019-10-21T02:34:08Z
closed_at: 2019-09-18T22:46:18Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2306
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2306/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE5MDQyODc0
title: Fix incorrectly wielded left hand weapons
state: closed
created_at: 2019-09-18T23:55:44Z
updated_at: 2019-10-21T02:34:08Z
closed_at: 2019-09-19T17:39:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2307
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2307/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE5Mzg2ODEx
title: Update Killed by misadventure conditions
state: closed
created_at: 2019-09-19T17:34:04Z
updated_at: 2019-10-21T02:34:12Z
closed_at: 2019-09-20T17:32:48Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2308
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2308/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzE5OTgzMjY1
title: Add logging to HousePortal nulls
state: closed
created_at: 2019-09-21T19:12:14Z
updated_at: 2019-10-21T02:34:05Z
closed_at: 2019-09-21T19:27:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2309
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2309/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwMDEzMzIw
title: Adjust Split StackSize Checks
state: closed
created_at: 2019-09-22T04:39:59Z
updated_at: 2019-10-21T02:34:04Z
closed_at: 2019-09-22T04:43:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2310
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2310/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwMDg2NzQ3
title: Remove coded North Glenden Prison position adjustments
state: closed
created_at: 2019-09-22T21:55:05Z
updated_at: 2019-10-21T02:34:02Z
closed_at: 2019-09-22T22:38:04Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2311
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2311/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwMDg5Njg5
title: Validate int data for GenerateNewFace
state: closed
created_at: 2019-09-22T22:37:31Z
updated_at: 2019-10-21T02:34:01Z
closed_at: 2019-09-22T22:39:54Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2312
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2312/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwMTAyMzEw
title: Remove old DbAttribute classes
state: closed
created_at: 2019-09-23T01:20:31Z
updated_at: 2019-09-23T01:22:42Z
closed_at: 2019-09-23T01:22:32Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2313
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2313/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0OTY4ODUxODI=
title: ItemSet spells applied to armor do not cast
state: closed
created_at: 2019-09-23T04:08:34Z
updated_at: 2019-09-24T16:53:57Z
closed_at: 2019-09-24T16:53:57Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Add an EquipmentSetID value from 13 to 29 to a loot armor item piece.  Debug 'level' at location https://github.com/ACEmulator/ACE/blob/master/Source/ACE.Server/WorldObjects/WorldObject_Set.cs#L157, when equipping armor piece with an EquipmentSetID. One will notice that 'level' is always zero, so spells that should be cast by the item set are never get applied.

  ### The log given by the failure.
  No log given by the failure

  ### Desired functionality.
  A given spell's level from an Armor EquipmentSetID should be based upon the count of the pieces equipped with a given EquipmentSetID.

  ### Mention any other details that might be useful.
  The code at the location linked above works for Aetheria.  However, it does not work for armor spell sets.  While Aetheria spell set spells base their level on the cumulative ItemLevel of similar Aetheria equipped, armor spell set level are based upon the count of armor pieces equipped that contain the same spell set.

  Whether correct or not, I found that changing the line of code at 157 to the following, allows the set spells to cast, and their spell level increase and decrease, as pieces with the same EquipmentSetID are added or removed.
              uint level;
              if (equipmentSet >= EquipmentSet.Soldiers && equipmentSet <= EquipmentSet.Lightningproof)
                  level = (uint)setItems.Count;
              else
                  level = (uint)(setItems.Sum(i => i.ItemLevel ?? 0) + levelDiff);

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2314/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwMTcwNTkw
title: Support SpellSets for Items that don't level
state: closed
created_at: 2019-09-23T07:56:17Z
updated_at: 2019-10-21T02:34:00Z
closed_at: 2019-09-24T16:53:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2315
body: Resolves #2314
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2315/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwMjk3MDcx
title: ServerPerformanceMonitor Refactor
state: closed
created_at: 2019-09-23T13:33:48Z
updated_at: 2019-09-23T23:25:44Z
closed_at: 2019-09-23T23:25:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2316
type: pull
body:
  This mainly refactors the performance monitoring like RateMonitor.

  This will allow monitoring of systems that function under multiple threads simultaneously.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2316/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwNDUzMTI4
title: adding luminance award for kills
state: closed
created_at: 2019-09-23T19:51:07Z
updated_at: 2019-09-27T04:56:22Z
closed_at: 2019-09-27T04:56:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2317
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2317/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIwNzY1MTM2
title: HandleActionDropItem_Inner fix
state: closed
created_at: 2019-09-24T13:17:50Z
updated_at: 2019-09-24T23:46:48Z
closed_at: 2019-09-24T23:46:39Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2318
body: Dont' replace the item object with a possible null reference on failure
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2318/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0OTg0NTI2MjU=
title: Whispering Blade Infiltration Quest Broken
state: closed
created_at: 2019-09-25T18:31:30Z
updated_at: 2020-07-21T05:24:47Z
closed_at: 2020-07-21T05:24:47Z
author_association: NONE
state_reason: completed
type: issue
body:
  ```
  - [X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
   Please list the steps to reproduce a bug here
  Quest: Whispering Blade Infiltration
  Issue: 2 Missing NPCs
  1. Garmasi - should be located within Royal Hall @ 70.0N 52.4W
  2. Hashina - should be located in Siylun @ 87.3N 70.5W
  Build: v0.9.128



  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.

  What would like to see implemented?
  What is the use case?

  Please include these NPC's, and any required mechanics for the quest

  ### Mention any other details that might be useful.

  https://asheron.fandom.com/wiki/Whispering_Blade_Infiltration

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2319/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIxNTQzNTMx
title: Some Give/Trade Wielded Adjustments
state: closed
created_at: 2019-09-26T05:29:53Z
updated_at: 2019-10-21T02:34:00Z
closed_at: 2019-09-26T17:34:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2320
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2320/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIxODI5NjQw
title: Adjustments to Guid Recycling
state: closed
created_at: 2019-09-26T17:31:50Z
updated_at: 2019-10-21T02:33:59Z
closed_at: 2019-09-26T17:37:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2321
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2321/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIxOTIxNzQ0
title: fixing missile defense bug
state: closed
created_at: 2019-09-26T21:50:42Z
updated_at: 2019-09-27T02:18:19Z
closed_at: 2019-09-27T02:18:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2322
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2322/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIxOTcxNTU1
title: Adding /config command for players
state: closed
created_at: 2019-09-27T02:13:41Z
updated_at: 2019-10-20T19:50:14Z
closed_at: 2019-10-20T19:50:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2323
body: This command matches the one found in GDLE, and was requested by people running decal
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2323/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIxOTczMjcy
title: cleaup guid debug info
state: closed
created_at: 2019-09-27T02:23:54Z
updated_at: 2019-09-27T11:47:23Z
closed_at: 2019-09-27T11:46:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2324
type: pull
body:
  revert /serverstatus to how it was
  improve the output of /idlist

  add comments to help describe some functions and properties

  remove public properties that could be misused by a developer that doesn't read the summary

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2324/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIxOTkzMzIz
title: Support Dark Idol recipe DataId mods
state: closed
created_at: 2019-09-27T04:25:23Z
updated_at: 2019-10-21T02:33:57Z
closed_at: 2019-09-27T04:44:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2325
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2325/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIyNDQzMjg0
title: PurgeOrphanedBiotas
state: closed
created_at: 2019-09-28T20:08:44Z
updated_at: 2019-11-24T22:51:23Z
closed_at: 2019-11-24T22:50:51Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2326
type: pull
body:
  Need to verify that all the proper WeenieTypes that CAN exist without a wielder, container, or location are not being pruned.

  Currently, that list only includes:
  WeenieType.Allegiance,

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2326/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIzODUwODc0
title: Update changelog.md
state: closed
created_at: 2019-10-02T16:59:34Z
updated_at: 2019-10-21T02:33:56Z
closed_at: 2019-10-02T17:06:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2327
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2327/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzIzOTE3MzQz
title: Fix issue with EmoteType.Give and non-stackable objects
state: closed
created_at: 2019-10-02T19:53:31Z
updated_at: 2019-10-21T02:33:52Z
closed_at: 2019-10-13T18:34:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2328
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2328/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI2OTYxNTQy
title: .NET Core 3.1
state: closed
created_at: 2019-10-10T22:54:42Z
updated_at: 2020-01-06T12:02:14Z
closed_at: 2020-01-06T12:00:01Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2329
type: pull
body:
  All NuGet packages have also been updated to latest stable.

  EF Core 3.0 update will have to wait. On my dev environment, simply getting a weenie using FirstOrDefault is very slow. Will investigate this at a later date.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2329/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI3NTcyNDQ2
title: Switch to ObjCell thread safety
state: closed
created_at: 2019-10-13T16:51:40Z
updated_at: 2019-10-23T23:54:08Z
closed_at: 2019-10-23T23:53:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2330
type: pull
body:
  This is an alternative way to make parallel physics processing thread-safe.

  The version that is currently in master processes players in a single thread.
  This version allows parallel processing of player physics.

  This should allow better performance with multi-threading physics with the movement PR.

  In the future I want to switch physics processing to a different architecture where:
  - ObjCell no longer needs a ReaderWriterLockSlim
  - Because we use LandblockGroups,
  -- Removing items from an ObjCell should be a thread safe process
  -- Adding items to an ObjCell that cross LandblockGroup (and thus thread) boundaries should be an enqueued action that happens in a single thread process at the end of the Physics_Tick processing.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2330/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI4MDA0MzM2
title: adding luminance sharing to fellowships
state: closed
created_at: 2019-10-14T23:01:07Z
updated_at: 2019-10-17T16:49:10Z
closed_at: 2019-10-17T16:49:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2331
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2331/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI4ODEwNjM3
title: atlatl and thrown weaps have accuracy bar instead of power
state: closed
created_at: 2019-10-16T15:04:30Z
updated_at: 2019-10-17T16:57:34Z
closed_at: 2019-10-17T16:57:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2332
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2332/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI4ODU3NDQx
title: Fix issue with pickup/merge into a full container
state: closed
created_at: 2019-10-16T16:47:16Z
updated_at: 2019-10-21T02:33:51Z
closed_at: 2019-10-17T17:16:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2333
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2333/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI4OTEyMTE4
title: adding support for monsters with PropertyBool.NonProjectileMagicImmune
state: closed
created_at: 2019-10-16T19:07:08Z
updated_at: 2019-10-17T17:04:35Z
closed_at: 2019-10-17T17:04:34Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2334
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2334/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzI5NTkyMTIy
title: allow neutral casters and missile launchers to be tailored onto weapons with DamageType
state: closed
created_at: 2019-10-18T07:06:03Z
updated_at: 2019-10-19T20:54:48Z
closed_at: 2019-10-19T20:54:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2335
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2335/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMDU3NDMw
title: Fixing some gaps with nested emote chains and EmoteManager.IsBusy
state: closed
created_at: 2019-10-19T20:56:33Z
updated_at: 2019-10-20T19:18:15Z
closed_at: 2019-10-20T19:18:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2336
type: pull
body:
  Repro steps:
  1. Start the cow tipping quest by speaking with Dwennon in Holtburg. If you've already completed the cow tipping quest, you can erase it with /qst erase cowtip beforehand.
  2. Level up your cowtipcounter quest to 300 tips. If you need a quick function to do this:
  ```
          [CommandHandler("cow", AccessLevel.Developer, CommandHandlerFlag.RequiresWorld)]
          public static void HandleCow(Session session, params string[] parameters)
          {
              for (var i = 0; i < 300; i++)
                  session.Player.QuestManager.Stamp("cowtipcounter");
          }
  ```
  3. Approach Dwennon, and then repeatedly spam the R key on him

  Expected:
  The 'award' emote chain only happens once

  Actual:
  The 'award' emote chain happens multiple times

  Resolution:
  EmoteManager.Enqueue() was not taking nested emote chains into account properly for setting IsBusy=false. Now the Nested level is tracked properly, and IsBusy is only set to false at the very end of the emote chain.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2336/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMDc0MjU5
title: adding support for monster casting untargeted spells (rings spells etc.)
state: closed
created_at: 2019-10-20T01:47:55Z
updated_at: 2019-10-20T19:25:17Z
closed_at: 2019-10-20T19:25:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2337
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2337/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMDg4MzU1
title: Adjust ApproachVendor to track last AltCurrency Spent
state: closed
created_at: 2019-10-20T06:27:41Z
updated_at: 2019-10-21T02:33:49Z
closed_at: 2019-10-20T06:30:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2338
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2338/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMDg4MzY1
title: updated monster spellbook probabilities
state: closed
created_at: 2019-10-20T06:27:58Z
updated_at: 2019-10-21T00:11:48Z
closed_at: 2019-10-20T19:25:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2339
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2339/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMTQ4MDQ1
title: Changes to GiveObjectToNPC
state: closed
created_at: 2019-10-20T19:17:21Z
updated_at: 2019-10-21T02:33:47Z
closed_at: 2019-10-20T19:24:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2340
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2340/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMTUxNTc1
title: Add inform about disabled commands
state: closed
created_at: 2019-10-20T19:54:45Z
updated_at: 2019-10-21T02:33:46Z
closed_at: 2019-10-21T00:04:11Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2341
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2341/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMTY4Mzgz
title: removing debug logging for unknown death item types
state: closed
created_at: 2019-10-20T23:07:02Z
updated_at: 2019-10-20T23:59:02Z
closed_at: 2019-10-20T23:59:02Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2342
body: confirmed working as expected
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2342/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwMTk1MjE3
title: minor QoL updates to luminance
state: closed
created_at: 2019-10-21T02:51:16Z
updated_at: 2019-10-21T07:32:00Z
closed_at: 2019-10-21T07:32:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2343
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2343/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwNzM2ODkx
title: fixing some gaps with pk logout timer
state: closed
created_at: 2019-10-21T23:10:39Z
updated_at: 2019-10-22T11:03:08Z
closed_at: 2019-10-22T11:03:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2344
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2344/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwNzc2NzQ4
title: [WIP] adding preliminary calcs for allegiance passup xp realtime and gametime factors
state: open
created_at: 2019-10-22T02:25:44Z
updated_at: 2019-10-22T10:33:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2345
type: pull
body:
  Still left to solve: how to best handle players who have already been sworn for quite some time, but no swear timestamps were saved for

  Setting the current timestamp/age would be easy, but also would also not be beneficial to players who have been in established allegiances. I would give these players the benefit of the doubt, and set their data to the server established timestamp.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2345/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwODc4ODgy
title: improved monster position sync and corpse sync
state: closed
created_at: 2019-10-22T08:59:23Z
updated_at: 2019-10-22T10:34:08Z
closed_at: 2019-10-22T10:34:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2346
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2346/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMwOTE2NjU2
title: improved /teledungeon name search
state: closed
created_at: 2019-10-22T10:29:33Z
updated_at: 2019-10-22T10:34:18Z
closed_at: 2019-10-22T10:34:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2347
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2347/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMxMzQyOTI1
title: allowing Dispel Item Magic to be cast on items
state: closed
created_at: 2019-10-23T05:14:06Z
updated_at: 2019-10-23T23:58:56Z
closed_at: 2019-10-23T23:58:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2348
body: Also fixes a bug in dispel trap variances
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2348/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMxNDM1NjIw
title: Refactor SpendCurrency
state: closed
created_at: 2019-10-23T09:24:28Z
updated_at: 2020-01-15T04:48:53Z
closed_at: 2019-10-25T03:43:31Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2349
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2349/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMxNzg2MjUy
title: backporting max iterations to melee temp fix
state: closed
created_at: 2019-10-23T23:22:27Z
updated_at: 2019-10-23T23:58:31Z
closed_at: 2019-10-23T23:58:31Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2350
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2350/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMxODExNDI2
title: add a check before entering godmode
state: closed
created_at: 2019-10-24T01:32:41Z
updated_at: 2019-10-24T21:23:30Z
closed_at: 2019-10-24T21:23:30Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2351
type: pull
body:
  recently players were reporting errors with their godString... after examining the strings it seems as if sometimes an extra blank 'skill' is inserted into the string

  i havent worked out exactly why but i added a check to the process so you wont be able to enter godmode if the string is not the proper length. this should prevent characters being stuck in godmode after entering with an incorrect string length

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMxOTAzMjI0
title: Partial revert of #2333
state: closed
created_at: 2019-10-24T07:44:29Z
updated_at: 2020-01-15T04:48:52Z
closed_at: 2019-10-24T07:55:17Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2352
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2352/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMxOTU3MTM3
title: updated monster spellbook probabilities
state: closed
created_at: 2019-10-24T09:51:01Z
updated_at: 2019-10-25T04:00:09Z
closed_at: 2019-10-25T04:00:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2353
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2353/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyMjQwOTQw
title: updating GetProjectileSpellType
state: closed
created_at: 2019-10-24T21:02:31Z
updated_at: 2019-10-25T04:00:19Z
closed_at: 2019-10-25T04:00:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2354
type: pull
body:
  This function has been verified as producing the same results as the original, while updating it to make it clearer / more readable, and fixing some gaps for spells that were being miscategorized

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2354/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyMzU4NDg1
title: fixing monster corpses again from 2330
state: closed
created_at: 2019-10-25T06:21:28Z
updated_at: 2019-10-25T18:04:10Z
closed_at: 2019-10-25T18:04:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2355
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2355/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyNjEyODQ4
title: Adjustments for guid recycling
state: closed
created_at: 2019-10-25T17:45:00Z
updated_at: 2020-01-15T04:49:14Z
closed_at: 2019-10-25T18:05:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2356
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2356/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyNjkxNDUx
title: fixing monster idle emote update sync
state: closed
created_at: 2019-10-25T21:45:14Z
updated_at: 2019-10-26T01:09:03Z
closed_at: 2019-10-26T01:09:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2357
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2357/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyNzAzNTk1
title: update EmoteType.AwardLuminance to use HeroXP64
state: closed
created_at: 2019-10-25T22:43:52Z
updated_at: 2019-10-27T00:45:07Z
closed_at: 2019-10-27T00:45:07Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2358
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2358/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyNzM2Nzk2
title: Ensure that Impen spell is present on magical Covenant Armor
state: closed
created_at: 2019-10-26T05:07:35Z
updated_at: 2019-11-06T01:57:49Z
closed_at: 2019-10-30T17:31:22Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2359
type: pull
body:
  Per a discussion on LSD discord, it was determined that Covenant Armor that contains spells will have Impenetrability as one of them.  While I tested the added code in game, it should probably be tested by others before merging to ensure that I didn't miss something, especially in regards to array indexing, if the added code is deemed acceptable.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2359/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyNzU2MjUx
title: adding support for ai immobile
state: closed
created_at: 2019-10-26T10:29:48Z
updated_at: 2019-10-27T21:40:45Z
closed_at: 2019-10-27T21:40:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2360
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2360/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyNzkxODQy
title: Some quick Fixes
state: closed
created_at: 2019-10-26T18:51:08Z
updated_at: 2020-01-15T04:49:14Z
closed_at: 2019-10-26T18:57:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2361
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODA2NTM2
title: adding checks for combat mode
state: closed
created_at: 2019-10-26T22:24:19Z
updated_at: 2019-10-27T00:44:57Z
closed_at: 2019-10-27T00:44:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2362
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2362/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODI2OTAw
title: Allow items that proc to cast untargeted spells.
state: closed
created_at: 2019-10-27T05:35:52Z
updated_at: 2019-10-27T21:47:01Z
closed_at: 2019-10-27T21:47:01Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2363
type: pull
body:
  This allows items like WCID 35555 - Burning Bow to cast untargeted spells when they proc. Thanks to Cyberkiller for reporting.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2363/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODM1NjIz
title: backporting hotspot accuracy from 1991
state: closed
created_at: 2019-10-27T08:39:35Z
updated_at: 2019-10-27T21:40:55Z
closed_at: 2019-10-27T21:40:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2364
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2364/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODM5NzY1
title: adding support for PropertyBool.AffectsAis
state: closed
created_at: 2019-10-27T09:41:50Z
updated_at: 2019-10-27T21:47:48Z
closed_at: 2019-10-27T21:47:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2365
body: This PR builds on top of https://github.com/ACEmulator/ACE/pull/2364
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2365/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODQwODUw
title: adding support for PropertyBool.PortalIgnoresPkAttackTimer
state: closed
created_at: 2019-10-27T09:58:26Z
updated_at: 2019-10-27T21:41:15Z
closed_at: 2019-10-27T21:41:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2366
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2366/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODQzMDAw
title: adding support for PropertyBool.OpensAnyLock
state: closed
created_at: 2019-10-27T10:29:50Z
updated_at: 2019-10-28T00:59:47Z
closed_at: 2019-10-28T00:59:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2367
body: also fixes a crash when using keyrarevolatileuniversal in current master
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMyODQzNzY1
title: updating give item sound to broadcast to match retail
state: closed
created_at: 2019-10-27T10:42:08Z
updated_at: 2019-10-28T00:59:57Z
closed_at: 2019-10-28T00:59:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2368
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2368/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMzMTE0MDM3
title: Revert limitAvailableIDsReturnedInGetSequenceGaps with comment
state: closed
created_at: 2019-10-28T13:25:34Z
updated_at: 2019-10-30T12:51:15Z
closed_at: 2019-10-30T12:51:06Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2369
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2369/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMzNDExNjU3
title: Fixing some gaps for DST
state: closed
created_at: 2019-10-29T03:08:59Z
updated_at: 2019-10-29T16:59:49Z
closed_at: 2019-10-29T16:59:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2370
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2370/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzMzNzMyODk5
title: better handling for attack sequences
state: closed
created_at: 2019-10-29T16:31:27Z
updated_at: 2019-10-30T06:08:29Z
closed_at: 2019-10-30T06:08:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2371
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2371/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM0MDM4Nzg0
title: Support connection limits per IP Address
state: closed
created_at: 2019-10-30T05:51:44Z
updated_at: 2020-01-15T04:49:15Z
closed_at: 2019-10-30T15:55:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2372
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2372/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU1MTQ5MjIwNjY=
title: Magic Absorbing (Fetish of Dark Idols)
state: closed
created_at: 2019-10-30T19:19:39Z
updated_at: 2019-10-31T18:26:09Z
closed_at: 2019-10-31T18:26:09Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [x ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  <!-- Please list the steps to reproduce a bug here -->

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

  Currently on ACE, the Magic Absorbing property is not functioning for Fetish of the Dark Idols. It may be safe to assume it's also not functioning correctly for wands as well. As far as I know, it is working for Shields.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2373/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM0NTg4Njk2
title: Fix issue with BuyItems_ValidateTransaction using AltCurrency
state: closed
created_at: 2019-10-31T00:32:36Z
updated_at: 2020-01-15T04:49:18Z
closed_at: 2019-10-31T03:43:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2374
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM0NjYwNjk2
title: Cleanup ActOnUse for Ammunition
state: closed
created_at: 2019-10-31T04:29:01Z
updated_at: 2020-01-15T04:49:19Z
closed_at: 2019-10-31T17:32:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2375
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2375/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM0NzI4MDgz
title: enabling magic absorption for missile/magic weapons
state: closed
created_at: 2019-10-31T07:54:22Z
updated_at: 2019-10-31T18:39:15Z
closed_at: 2019-10-31T18:26:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2376
type: pull
body:
  Warning: there are currently items in the database that incorrectly have PropertyFloat.AbsorbMagicDamage=1.0, instead of the correct percentage for magic damage they can absorb. These items need to be fixed in sync with this code update -- ie. for any existing players on the servers that already have items with AbsorbMagicDamage=1.0, the data for these items needs to be fixed in tandem with this code change.

  Please do not check in this code change before all of the data corrections have been added

  Database/Updates/Shard/2019-10-31-00-Fix-Magic-Absorption.sql

  Updated: this PR now contains recipe fix (was code-based instead of data-based), and the above-mentioned SQL fix. Please notify server operators to be sure to run the sql shard update when they update to this version of the code.

  This fixes https://github.com/ACEmulator/ACE/issues/2373

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2376/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM0OTM2NTk4
title: fixing value typos
state: closed
created_at: 2019-10-31T14:31:47Z
updated_at: 2019-10-31T17:30:50Z
closed_at: 2019-10-31T17:30:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2377
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2377/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM1MDQ4MjE4
title: adding shield cantrips
state: closed
created_at: 2019-10-31T17:30:33Z
updated_at: 2019-11-03T03:44:48Z
closed_at: 2019-11-03T03:44:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2378
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2378/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM1MDU5NjMy
title: adjusting material probability
state: closed
created_at: 2019-10-31T17:51:14Z
updated_at: 2019-11-03T03:45:03Z
closed_at: 2019-11-03T03:45:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2379
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2379/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM1ODY2NTc2
title: adding support for overpower / overpower resist
state: closed
created_at: 2019-11-02T15:43:49Z
updated_at: 2019-11-03T03:45:15Z
closed_at: 2019-11-03T03:45:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2380
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2380/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM1ODgyMTc1
title: no resistance check for monsters casting beneficial spells on player
state: closed
created_at: 2019-11-02T16:42:30Z
updated_at: 2019-11-03T03:45:27Z
closed_at: 2019-11-03T03:45:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2381
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2381/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM1OTQ1Njk5
title: Adjusting AddPickupChainToMoveToChain
state: closed
created_at: 2019-11-02T21:16:53Z
updated_at: 2020-01-15T04:49:21Z
closed_at: 2019-11-03T19:48:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2382
body: aka contributing nothing
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM2MjU0MzU2
title: Improve Multi-threaded landblock group ticking (non-physics)
state: closed
created_at: 2019-11-04T12:37:33Z
updated_at: 2019-11-17T12:55:44Z
closed_at: 2019-11-17T12:54:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2383
type: pull
body:
  This splits up the previous Landblock Tick() work into two functions:
  TickMultiThreadedWork()
  TickSingleThreadedWork()

  Mainly, this allows multi-threading of the following work:
  Landblock.actionQueue.RunActions();
  Landblock creatures Monster_Tick()
  Landblock Heartbeat
  Landblock Database Save

  The first two of which are the biggest CPU consumers from the previous Tick(), and, fortunately enough are pretty safe to multi-thread.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM2MzAzMzI2
title: AddPickupChainToMoveToChain null fix
state: closed
created_at: 2019-11-04T14:22:59Z
updated_at: 2019-11-04T14:43:12Z
closed_at: 2019-11-04T14:42:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2384
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2384/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM2MzQ3NTY1
title: fixing dark idols items created before sept. 27
state: closed
created_at: 2019-11-04T15:48:47Z
updated_at: 2019-11-04T19:33:56Z
closed_at: 2019-11-04T19:33:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2385
body: ran on CE, fixes both pre and post sept 27 items
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2385/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM2MzkxMjc5
title: update changelog
state: closed
created_at: 2019-11-04T17:21:33Z
updated_at: 2019-11-04T19:34:31Z
closed_at: 2019-11-04T19:34:31Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2386
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM2NTY4MDE4
title: AddPickupChainToMoveToChain fix 2
state: closed
created_at: 2019-11-05T02:29:24Z
updated_at: 2019-11-05T03:39:24Z
closed_at: 2019-11-05T03:39:12Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2387
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2387/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM2NTc4MDE5
title: add valid skills hashset, check valid skills entering godmode
state: closed
created_at: 2019-11-05T03:18:48Z
updated_at: 2019-11-09T11:54:21Z
closed_at: 2019-11-09T11:54:21Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2388
type: pull
body:
  added a valid skills hashset to the skillhelper so that it could be checked against when entering godmode. also added hard coded checks against the attribute and attribute 2nd types... figured they didnt need a helper

  this change will only add entries to the godstring if they are valid. 

  According to ripley, the bug is with the GetOrAddSkill function that adds a skill to a players biota_properties_skill table when checking for invalid skill types. if a player had an invalid skill (typically this was a skill with type 0) the string would be too long and cause the error. now when entering godmode invalid skill and attribute values will be ignored and everything should work as intended

  the only way an error when attempting to god/ungod should happen now is if the db is externally corrupted or manually changed... or until the next bug is uncovered :)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM3MTg1NzQz
title: Add DestinationType.Wield to corpse object selection
state: closed
created_at: 2019-11-06T06:03:17Z
updated_at: 2020-01-15T04:49:20Z
closed_at: 2019-11-06T06:29:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2389
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2389/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM3ODQ3MzIw
title: adding missing luminance emote msg
state: closed
created_at: 2019-11-07T04:23:43Z
updated_at: 2019-11-07T06:38:13Z
closed_at: 2019-11-07T06:38:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2390
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2390/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4MjA0MjIy
title: Assign armor level
state: closed
created_at: 2019-11-07T19:30:52Z
updated_at: 2020-01-18T21:00:05Z
closed_at: 2019-12-15T16:31:57Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2391
type: pull
body:
  - Update AssignArmorLevel() to account for updated base AL weenie values and align AL mod with armor type, ie, cloth, leather, chainmail, metal, etc.
  - Maintains original AssignArmorLevel code for a compatibility layer for databases that have not been updated, yet
  - Should be paired with an [update](https://github.com/ACEmulator/ACE-World-16PY-Patches/pull/253) to ACE-World-Patches but should be safe to use without updated armor objects

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4NDY5MTYx
title: Allow long running OnDeath emotes to complete
state: closed
created_at: 2019-11-08T05:16:27Z
updated_at: 2020-01-15T04:49:27Z
closed_at: 2019-11-24T22:10:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2392
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2392/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4NTY5ODA4
title: damagemod enchantments = additive to base multiplier
state: closed
created_at: 2019-11-08T08:41:38Z
updated_at: 2019-11-08T19:20:23Z
closed_at: 2019-11-08T19:20:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2393
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2393/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4NzA5NjQ5
title: EmoteManager AddDelaySeconds() only when > 0
state: closed
created_at: 2019-11-08T14:46:53Z
updated_at: 2019-11-09T01:35:37Z
closed_at: 2019-11-09T01:35:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2394
type: pull
body:
  This will help OnDeath emotes with 0 delay run on the next tick. This also has the added benefit of not deferring action chains 1 tick when delays are 0. For that specific scenario, another stub function has been added.

  It's more difficult to run them on the same tick due to the way Emotes tick. If you want to ensure OnDeath emotes are run on the same tick, you can modify EmoteManager (ExecuteEmoteSet or Enqueue) to execute the emote right away instead of enqueueing it.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4NzE5MDU1
title: Separate Armor from MiscClothing in loot gen
state: closed
created_at: 2019-11-08T15:07:43Z
updated_at: 2019-11-24T20:28:26Z
closed_at: 2019-11-08T19:58:43Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2395
type: pull
body:
  Separate MiscClothing items out from being lumped into armor in general, without creating code duplication, by adding a flag to CreateArmor() that specifies either one or the other.  MiscClothing items should now have a fixed one in five chances of being generated, instead of a variable 1 in 6 to 1 in 28 chances, depending upon loot tier.

  Code compiles but have not run/play tested

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4ODgyOTUy
title: adding t6 rares for two-handed weapons
state: closed
created_at: 2019-11-08T22:26:19Z
updated_at: 2019-11-09T11:37:24Z
closed_at: 2019-11-09T11:37:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2396
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4OTMwNDg0
title: Execute no-delay emotes immediately
state: closed
created_at: 2019-11-09T02:58:29Z
updated_at: 2019-11-24T22:48:46Z
closed_at: 2019-11-24T22:48:32Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2397
type: pull
body:
  For example, on Jive Turkey, this will execute all OnDeath emotes when OnDeath is raised. No deffered work or delayed execution takes place.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2397/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4OTMzMjQ3
title: Removing unused pattern from CryptoSystem for slightly better performance.
state: closed
created_at: 2019-11-09T03:29:19Z
updated_at: 2019-12-21T13:29:06Z
closed_at: 2019-12-21T13:29:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2398
type: pull
body:
  Adding .NET IDisposable pattern to CryptoSystem
  Slightly improved CryptoSystem documentation

  After considering the theory more it seems that the preventing of the search window from changing upon finding a key isn't actually needed by the system's current implementation, especially since it's been **well tested**.

  Removing the unneeded parameter.  [This will reduce the memory usage on the stack and improve performance.](https://www.dotnetperls.com/parameter-optimization)  The modified source code is clearer and the new implementation more direct further improving performance as fewer stack frames are needed.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2398/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM4OTQ0MTY4
title: Update GameEventInscriptionResponse
state: closed
created_at: 2019-11-09T05:45:05Z
updated_at: 2020-01-15T04:49:22Z
closed_at: 2019-11-09T23:34:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2399
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MDA3MTY1
title: adding defense imbues to effective defense calculation
state: closed
created_at: 2019-11-09T12:43:49Z
updated_at: 2019-11-10T00:46:54Z
closed_at: 2019-11-10T00:46:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2400
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MDgwNjE1
title: adjusting critical strike for magic to be consistent with 5x bonus for melee/missile
state: closed
created_at: 2019-11-09T19:24:57Z
updated_at: 2019-11-10T00:46:46Z
closed_at: 2019-11-10T00:46:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2401
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2401/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MTA1OTQ0
title: improved pk/pklite top damager detection
state: closed
created_at: 2019-11-10T01:29:23Z
updated_at: 2019-11-10T12:47:13Z
closed_at: 2019-11-10T12:47:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2402
type: pull
body:
  a new function has been added, DamageHistory.GetTopDamager(bool includeSelf)

  new logic has been added to prevent the following scenarios:
  - a player should not be able to suicide during a pk battle and have themselves detected as the top damager (jumping off a cliff, harm self to death).
  if a player is pk / pklite, and they are their own TopDamager, GetTopDamager(includeSelf = false) is called, to check if it is another player. If so, that player becomes the effective TopDamager, and is awarded the looting rights.
  - if a pk / pklite is their own top damager, and the next highest damager is not another player, then the player remains their own effective top damager.

  after this 'effective top damager' is determined, the IsPKDeath(topDamager) / IsPKLiteDeath(topDamager) calls also have logic added to ensure a true suicide is not considered death from a PK/PKLite battle

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2402/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MTQ5NjEy
title: backporting /damagehistory dev command
state: closed
created_at: 2019-11-10T13:17:57Z
updated_at: 2019-11-11T10:20:09Z
closed_at: 2019-11-11T10:20:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2403
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2403/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MTU1Njcx
title: backporting Player_Magic refactoring from 1991
state: closed
created_at: 2019-11-10T14:27:37Z
updated_at: 2019-11-16T02:46:06Z
closed_at: 2019-11-16T02:46:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2404
type: pull
body:
  minus the physics ticking / motion callbacks

  this should keep the exact same functionality from current master, with the following improvements:

  - cleaned up and refactored architecture
  - the player will now be able to visually break their cast animation on their client, although technically it will not be a fastcast
  - the 2nd 'turnto' motion will be applied if needed

  Update: after player feedback from CE testing, the post-windup turnto (which is on a static timer in this branch, unlike in 1991, where it can be interrupted or added into) has been commented out in this branch.

  Other small differences that were found, that I had forgotten about, or was not aware of at first:

  - The IsBusy=false timer at the end of the cast was updated to be more accurate, which again is nice in theory, but again is an incomplete version of what's in 1991. Reverted to master static timer there until full implementation.

  - EnqueueMotion() bugs were discovered if there are simultaneous ActionChains running for a player that call this function (picking up objects pre-2409, and still in SwitchCombatStance). This has been updated to make magic casting immune to this EnqueueMotion() bug, similar to how magic casting in current master is unaffected by only calling EnqueueBroadcastMotion() instead.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2404/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MTYzNDg5
title: applying TransferCap to both srcVital and destVital for life transfer spells
state: closed
created_at: 2019-11-10T15:54:21Z
updated_at: 2019-11-11T10:20:18Z
closed_at: 2019-11-11T10:20:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2405
type: pull
body:
  thanks to Yeonan for spotting this one:

  https://asheron.fandom.com/wiki/Announcements_-_2003/01_-_The_Slumbering_Giant#Letter_to_the_Players

  Example 1 - A mage is taking damage and would like to recover some health quickly. Using the level 1 health transfer spell, he takes 30 points away from a monster attacking him and receives 60 points in return. He does this a few times to help keep him alive while he tries to make a speedy retreat.

  Example 2 - A mage has taken some damage, but well within what she can handle. She targets a nearby creature that has quite a bit of health. Using the level 7 health transfer spell, she takes 180 points of health away from the creature, and receives 90 in return.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2405/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MTc5NzM5
title: Update EmoteType.DeleteSelf
state: closed
created_at: 2019-11-10T19:01:39Z
updated_at: 2020-01-15T04:49:23Z
closed_at: 2019-11-10T20:00:20Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2406
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MTkwMDYy
title: Add option for CreateList wield dropping to corpse
state: closed
created_at: 2019-11-10T20:57:01Z
updated_at: 2020-01-15T04:49:24Z
closed_at: 2019-11-10T21:09:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2407
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5MjE0ODU4
title: Log and Protect against basements missing location data
state: closed
created_at: 2019-11-11T01:08:46Z
updated_at: 2020-01-15T04:49:24Z
closed_at: 2019-11-11T17:52:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2408
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2408/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5NDAwMDc2
title: backporting pickup busy state from 1991
state: closed
created_at: 2019-11-11T12:03:56Z
updated_at: 2019-11-15T15:35:25Z
closed_at: 2019-11-15T15:35:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2409
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2409/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5NTczMjcw
title: ensuring resistanceMod never goes below 0
state: closed
created_at: 2019-11-11T19:05:47Z
updated_at: 2019-11-11T19:08:33Z
closed_at: 2019-11-11T19:08:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2410
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5NjMwNTg0
title: Drop Rates adjusted for equipment and Test loot generator
state: closed
created_at: 2019-11-11T21:46:55Z
updated_at: 2019-11-16T02:54:03Z
closed_at: 2019-11-16T02:54:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2411
type: pull
body:
  Adjusted drop rates to better align them with End of Retail.  Adjustments were made based on Magnus's data from retail.  I didn't align them exactly, just a good nudge to get them closer.  This fixes the issue with clothing dropping at less than 1%  This includes the utility for testing LootFactory drop rates for equipment.
  **Before
   Drop Rates**
   Armor= 22.84404%
   MeleeWeapon= 8.634048%
   Caster= 8.287462%
   MissileWeapon= 8.012232%
   Jewelry= 25.72885%
   Gem= 25.85117%
   Clothing= 0.6422018%
   Other=0%

  **After
   Drop Rates**
   Armor= 23.93276%
   MeleeWeapon= 12.93938%
   Caster= 6.897606%
   MissileWeapon= 10.77942%
   Jewelry= 18.03362%
   Gem= 14.10087%
   Clothing= 13.31635%
   Other=0%

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2411/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzM5Njk5Mzc4
title: Added NoAccess as an AccessLevel
state: closed
created_at: 2019-11-12T02:37:57Z
updated_at: 2019-11-12T14:22:06Z
closed_at: 2019-11-12T14:22:06Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/2412
type: pull
body:
  Accounts set to AccessLevel 0 will now be rejected.

  0 - NoAccess
  1 - Player
  2 - Advocate
  3 - Sentinel
  4 - Envoy
  5 - Developer
  6 - Admin

  Useful for servers that require email validation before a player can login.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQwMjI4MDg4
title: fixing some gaps for ranged missile mobs
state: closed
created_at: 2019-11-13T03:58:16Z
updated_at: 2019-11-15T15:37:35Z
closed_at: 2019-11-15T15:37:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2413
type: pull
body:
  This patch updates the monsters in CombatMode.Missile (bow/crossbow/thrown weapons) to fix some gaps in their logic, and to bring them closer to retail.

  Currently in ACE, monsters are depleting ammo for their ranged weapons, and stand their ground until they run out of ammo.

  In retail, monsters appeared to have infinite ammo for their ranged weapons, and they decided to switch to melee mode based on other criteria:

  - A monster will switch from ranged to melee if their target is beyond their MaxRange. They will then run in to close the gap.

  - A monster will switch from ranged to melee if it has too many attacks that miss the target completely, and hit the environment.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQwMjYxOTM0
title: Support standard and non-standard usage of %tqt and custom %CDtime
state: closed
created_at: 2019-11-13T06:20:04Z
updated_at: 2020-01-15T04:49:25Z
closed_at: 2019-11-14T05:30:46Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2414
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQwNzUxNTI4
title: broadcast correct runrate for overburdened players
state: closed
created_at: 2019-11-14T02:01:16Z
updated_at: 2019-11-15T15:37:53Z
closed_at: 2019-11-15T15:37:53Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2415
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2415/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQwNzc0NTU3
title: Wiki
state: closed
created_at: 2019-11-14T03:51:41Z
updated_at: 2019-11-16T06:17:17Z
closed_at: 2019-11-16T06:17:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2416
body: Creating Wiki folder and adding documents for the wiki
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2416/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxMTA1ODcz
title: improved RunRate handling for players
state: closed
created_at: 2019-11-14T18:04:11Z
updated_at: 2019-11-15T15:39:05Z
closed_at: 2019-11-15T15:39:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2417
type: pull
body:
  this PR builds on top of https://github.com/ACEmulator/ACE/pull/2415

  key scenario: if i cast Slowness on another player who is running, that player's RunRate should be affected immediately on both the server and client

  currently in master, the player will continue to run at the same speed, until they release/re-press a movement key on their client

  some temporary developer debug commands have been added to help test this, /fast and /slow, which invisibly cast QuicknessSelf8 and SlownessSelf8, respectively. The /dispel command is also useful.

  Other scenarios handled: any spells which affect quickness/run/strength, and the player raising their quickness/run/strength while running/sidestepping

  The previous Exhaustion detection system has been updated with this, and hooks have been added for both the player going into and out of stamina==0. The exact behavior for stamina in retail when exhausted/burdened needs to be confirmed.

  Update: it appears retail had the runrate update hooks for spells which affected quickness/run/strength, and for 'exhaustion start', but it was missing the automatic hooks for 'exhaustion done' and player clicking button to raise quickness/run/strength attributes/skills while running.

  The server now defaults to retail runrate hooks by default (spells and exhaustion start), and a custom server option 'runrate_add_hooks' can be enabled if the server operators wants to add the missing events.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2417/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxMTU4MDc5
title: fixing a possible lockup during physical combat when auto repeat attacks is disabled
state: closed
created_at: 2019-11-14T20:18:58Z
updated_at: 2019-11-15T15:39:20Z
closed_at: 2019-11-15T15:39:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2418
type: pull
body:
  This bug can happen when the target creature dies from something else in the world, at just the right time in the melee chain. Only happens when repeat attacks is disabled (usually players running with vtank)

  Repro steps:

  I was able to repro this bug with Dirty Fighting middle melee attacks (bleed dot when it lands). Set repeat attacks to disabled, and run with vtank

  (also throwing in some random spellcasting helper functions that have been sitting around for awhile, currently just used for debugging / uncalled otherwise)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2418/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxMjMwNDc2
title: adding Storage.Default_ChestResetInterval override
state: closed
created_at: 2019-11-14T23:57:36Z
updated_at: 2019-11-16T02:46:26Z
closed_at: 2019-11-16T02:46:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2419
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2419/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxNTU1MDQw
title: improved NaN handling for projectiles
state: closed
created_at: 2019-11-15T16:54:41Z
updated_at: 2019-11-16T02:46:43Z
closed_at: 2019-11-16T02:46:42Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2420
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2420/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxNTk1NTg4
title: Update Instance IDs upon swearing in Allegiance
state: closed
created_at: 2019-11-15T18:57:07Z
updated_at: 2020-01-15T04:49:26Z
closed_at: 2019-11-16T04:51:24Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2421
body: Boot from housing on break
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2421/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxNzI4MDE2
title: send updates to Monarch ID over network, and adding some missing calls to allegiance house boot
state: closed
created_at: 2019-11-16T06:22:59Z
updated_at: 2019-11-18T21:33:03Z
closed_at: 2019-11-18T21:33:02Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2422
type: pull
body:
  This builds on https://github.com/ACEmulator/ACE/pull/2421 from @LtRipley36706 

  The core scenario for this: join an allegiance, and then recall to allegiance housing with /hom. You will end up with a black screen.

  You can also join an allegiance, and if you try to run into the allegiance house, you will run into a barrier still (not sure how this was missed..)

  A similar situation, if you break allegiance to your patron while standing outside of the Allegiance house, you will still be able to run into it afterwards. Similarly, if you were standing inside the Allegiance house at the time of the break, you will not be booted.

  The core issue for this was the client needs to be sent the MonarchID, and it uses this to determine / update the barrier protections.

  This PR also fixes a bunch of possible scenarios that can arise from players swearing allegiance / breaking allegiance / booting players / deleting players, where all the vassals involved need to also have their Monarch ID updates broadcast, and the server needs to check if any of these online vassals are on any house property that they no longer have access to.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2422/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxODA4MTk5
title: fixing DamageHistory static bug
state: closed
created_at: 2019-11-17T01:06:16Z
updated_at: 2019-11-18T21:32:31Z
closed_at: 2019-11-18T21:32:31Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2423
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2423/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxODI0ODQz
title: minimizing DamageHistory.WeakReference
state: closed
created_at: 2019-11-17T06:20:49Z
updated_at: 2019-11-18T21:32:44Z
closed_at: 2019-11-18T21:32:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2424
type: pull
body:
  This patch minimizes the reliance on DamageHistory WeakReferences

  The main purpose of this patch is to fix the effects of a long-standing bug where DamageHistory WeakReferences to valid Players and WorldObjects are somehow going null.

  In current master, this results in PKDeaths not being detected as PKDeaths, and causes a bug where players drop their items and accumulate vitae in PKLite mode

  This patch also fixes some other bugs with over-reliance on WeakReferences, such as:

  - A monster damages a player for 75% of their health, and then the player kills the monster. Another monster then kills the player. In this scenario, the TopDamager for the 'Killed by' message on the player's corpse was reading 'Killed by misadventure.', since it was relying on a full reference to the TopDamager WeakReference (which had correctly expired)

  - A summoning player spawns a CombatPet, and that pet deals 75% damage to a nearby monster. The CombatPet then despawns, and the player kills the monster. In this scenario, awarding XP was relying on a WeakReference to all the attackers to divy up the XP, and the WeakReference to the CombatPet had (correctly) expired. In this scenario, this was resulting in the player only getting 25% of the monster's XP, instead of the full amount.

  Note that the root cause of DamageHistory WeakReferences to valid objects going null has still not been identified, but this patch minimizes the effect of that bug.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2424/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxODU3MDg2
title: EnchantmentManagerWithCaching Player Null Fix
state: closed
created_at: 2019-11-17T14:07:18Z
updated_at: 2019-11-17T15:35:02Z
closed_at: 2019-11-17T15:34:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2425
body: This fixes the player null exception
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxODU5MjAz
title: CurrentMovementData.Invalid null fix
state: closed
created_at: 2019-11-17T14:31:29Z
updated_at: 2019-11-17T18:55:49Z
closed_at: 2019-11-17T15:34:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2426
body: Fixes an exception
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2426/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxOTM3NTM0
title: Support QuestManager on Creatures
state: closed
created_at: 2019-11-18T02:41:35Z
updated_at: 2019-11-27T00:01:42Z
closed_at: 2019-11-27T00:01:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2427
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2427/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxOTQwNDQ3
title: ThreadSafeRandom Cleanup
state: closed
created_at: 2019-11-18T02:55:21Z
updated_at: 2019-11-21T13:22:35Z
closed_at: 2019-11-21T13:22:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2428
type: pull
body:
  This fixes the namespace for ThreadSafeRandom, from ACE -> ACE.Common.

  It also adds better Summary descriptions.

  The rest of the file changes are simply adding ACE.Common references.

  This is mainly commenting and namespace preparation for adding a non-thread safe random class, in effort to reduce lock contention.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2428/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQxOTU0OTEw
title: Fix for Missile Weapons and Extendend Stats for Weapons
state: closed
created_at: 2019-11-18T04:12:06Z
updated_at: 2019-11-22T02:15:36Z
closed_at: 2019-11-22T02:15:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2429
type: pull
body:
  **Missile Updates**
  If tier is 4 or 5  then a chance for non elemental missile weapon with wield reqs
  Tier 6 and up, Only elemental missile weapons are supposed to drop per retail.
  Added 10% varaiance for Damage Modifier.  Full Modifier was rare in retail
  Added +19 Elemental (like retail) and readjusted odds (odds are approximate, no hard data).  
  Made MeleeDefenseMod appropiate to Bow Reqs.  Data is supports 375 wields should go upto +20, however I left them at +18 for now
  Added Class TestLootGenerationFactory.cs for finding cantrips

  **Added more stats for weapons in testlootgen command**
  Shows Most important Modifiers/Bonuses

  Example:
  -----Melee Weapons----
   Wield   Damage          Variance        DefenseMod
   370     46              0.58            1.13
   370     37              0.5             1.17
   400     50              0.6             1.14
   370     37              0.35            1.13
   370     48              0.47            1.13
   400     50              0.52            1.15
   370     35              0.4             1.14
   370     57              0.45            1.19
   400     50              0.45            1.18
   370     31              0.45            1.17
   370     47              0.325           1.18
   400     43              0.4             1.11

  -----Missile Weapons----
  Thrown   Wield=335       Modifier=2.54   ElementalBonus=9        DefenseMod=1.1
  Thrown   Wield=335       Modifier=2.51   ElementalBonus=5        DefenseMod=1.11
  Thrown   Wield=375       Modifier=2.57   ElementalBonus=15       DefenseMod=1.15
  Thrown   Wield=335       Modifier=2.51   ElementalBonus=7        DefenseMod=1.1
  Bow      Wield=335       Modifier=2.39   ElementalBonus=6        DefenseMod=1.12
  Thrown   Wield=335       Modifier=2.59   ElementalBonus=8        DefenseMod=1.14
  X Bow    Wield=335       Modifier=2.56   ElementalBonus=7        DefenseMod=1.15
  Bow      Wield=360       Modifier=2.36   ElementalBonus=15       DefenseMod=1.13
  Bow      Wield=375       Modifier=2.34   ElementalBonus=16       DefenseMod=1.17
  Thrown   Wield=360       Modifier=2.55   ElementalBonus=11       DefenseMod=1.13
  Thrown   Wield=335       Modifier=2.59   ElementalBonus=7        DefenseMod=1.15

  -----Caster Weapons----
  Wield=150        ElementalDamageMod= 0.00        DefenseMod=1.15
  Wield=375        ElementalDamageMod=1.15         DefenseMod=1.18
  Wield=355        ElementalDamageMod=1.15         DefenseMod=1.15
  Wield=355        ElementalDamageMod=1.15         DefenseMod=1.15
  Wield=150        ElementalDamageMod= 0.00        DefenseMod=1.15
  Wield=355        ElementalDamageMod=1.15         DefenseMod=1
  Wield=150        ElementalDamageMod= 0.00        DefenseMod=1.18

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2429/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyMDE0NjI1
title: WorldObject_Weapon / imbue refactoring
state: closed
created_at: 2019-11-18T07:54:04Z
updated_at: 2019-11-21T03:41:59Z
closed_at: 2019-11-21T03:41:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2430
type: pull
body:
  So this started with digging into an off-by-1 error for Crippling Blow, and then went down the rabbit hole of fixing some issues with Critical Strike, and figuring out more of the details with that, which eventually lead to finding some scaling issues that mostly affect people who aren't at the caps for imbues yet.

  Along the way, I ended up cleaning up a lot of WorldObject_Weapon, and moving around some of the functions in that file for better organization / readability. The moving around of some function positions in the file unfortunately makes the git diff a bit confusing to read through, but all of the functionality is the same there, just moved around and refactored a bit.

  Tested the 4 key imbues: Critical Strike, Crippling Blow, Elemental Rend, and Armor Rend, and verified that all of the new functions are working as expected.

  More details to follow..

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2430/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyMDgwODU5
title: fixing /buff <target> for life spells
state: closed
created_at: 2019-11-18T10:36:20Z
updated_at: 2019-11-21T03:42:14Z
closed_at: 2019-11-21T03:42:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2431
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2431/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyMTU3NTkw
title: Switch ThreadSafeRandom from lock to ThreadLocal<Random>
state: closed
created_at: 2019-11-18T13:32:21Z
updated_at: 2019-12-08T14:53:02Z
closed_at: 2019-12-08T14:52:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2432
body: This builds on the ThreadSafeRandom cleanup, which should be merged first, to allow easy rollback.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyMTg0MDc0
title: Another CurrentMovementData.Invalid is null fix
state: closed
created_at: 2019-11-18T14:28:44Z
updated_at: 2019-11-19T01:06:17Z
closed_at: 2019-11-19T01:05:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2433
body:
  This fixes an exception.

  This does not fix the root issue

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2433/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyMTkxNzc5
title: SequenceManager tweak
state: closed
created_at: 2019-11-18T14:44:23Z
updated_at: 2019-11-19T01:05:26Z
closed_at: 2019-11-19T01:05:16Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2434
type: pull
body:
  This really doesn't do much, just rearranges some chairs on the titanic really.

  Next up, investigate any thread safety requirements on the different sequence classes, or possibly make that a function of SequenceManager.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2434/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyNDU5ODUx
title: adding support for WeaponMissileDefense and WeaponMagicDefense
state: closed
created_at: 2019-11-19T02:48:54Z
updated_at: 2019-11-21T03:42:27Z
closed_at: 2019-11-21T03:42:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2435
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2435/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyODY1MjA2
title: fixing a double message bug for archers
state: closed
created_at: 2019-11-19T20:03:46Z
updated_at: 2019-11-21T03:42:38Z
closed_at: 2019-11-21T03:42:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2436
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2436/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQyOTgwMTA3
title: Rare Crystal update
state: closed
created_at: 2019-11-20T02:08:44Z
updated_at: 2019-11-21T03:43:42Z
closed_at: 2019-11-21T03:43:42Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2437
type: pull
body:
  Added the following missing rare crystals:
  ```
  Void	43407
  2H	41257 
  DualW	45367 
  Reck	45368 	
  Sneak	45360
  Dirty	45366
  Shield	45369
  ```
  Removed the following rare WCIDs (they are the ones that gave weird icon and wouldn't stack)  I confirmed the correct rares (Light Weapons & Missile Weapons) are in rare table.  
  ```
  Anadil's	30238 - Light Weapons
  Tanua's		30236 - Light Weapons
  Krau Li's	30223 - Light Weapons
  Hamid's		30244 - Light Weapons
  Asmolum's	30243 - Missile Weapons
  ```
  Tested on personal server (set rare drop 1:1) to make sure they dropped and were usable.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzMjQ2MTkw
title: reversing exemption checks, adding missing WeenieObject.IsTypes
state: closed
created_at: 2019-11-20T09:12:11Z
updated_at: 2019-11-21T03:42:49Z
closed_at: 2019-11-21T03:42:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2438
body: This fixes the bug with TA char positions getting bumped around
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2438/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzNzEzMTQ5
title: adding debug logging for failed player transitions
state: closed
created_at: 2019-11-20T20:53:58Z
updated_at: 2019-11-21T03:43:00Z
closed_at: 2019-11-21T03:43:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2439
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2439/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzNzMzODM0
title: CreateCaster (wand/staff/obs) refactored, TestLootGen Updated
state: closed
created_at: 2019-11-20T21:34:28Z
updated_at: 2019-11-22T02:14:37Z
closed_at: 2019-11-22T02:14:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2440
type: pull
body:
  LootFactory CreateCaster refactored.  Items now created via wields not tier.  Updated values for the correct wields (values are based off of data from Optim and Magnus).

  TestLootGen added more details for casters, and the format.

  PR has been tested on private server without issue.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2440/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzNzM2MDcx
title: do not set PKTimer for bael'zharon battles
state: closed
created_at: 2019-11-20T21:40:24Z
updated_at: 2019-11-21T03:43:10Z
closed_at: 2019-11-21T03:43:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2441
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2441/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzNzgxOTAy
title: removing player.rotate during looting that wasnt in retail
state: closed
created_at: 2019-11-21T00:06:43Z
updated_at: 2019-11-21T03:43:20Z
closed_at: 2019-11-21T03:43:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2442
type: pull
body:
  When a corpse or a chest is double clicked, the server always performs a MoveTo and waits for it to successfully complete, before showing the container inventory

  If the player then rotates their character away from the container, but stays within UseRadius range, and then loots an item, they should NOT be doing a 2nd MoveTo / rotate in this case.

  See retail video:

  https://youtu.be/JApdqG-oJps?t=155

  Thanks to Damage Master for reporting this issue!

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2442/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzNzkxODcy
title: EnchantmentManagerWithCaching Null Exception Fix
state: closed
created_at: 2019-11-21T00:49:32Z
updated_at: 2019-11-21T01:25:16Z
closed_at: 2019-11-21T01:24:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2443
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2443/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzODMxMDQy
title: fixing merge error
state: closed
created_at: 2019-11-21T03:51:24Z
updated_at: 2020-09-13T09:49:15Z
closed_at: 2019-11-21T04:52:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2444
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2444/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzODQyNDQw
title: Update ACE.Adapter to support spawn maps
state: closed
created_at: 2019-11-21T04:49:43Z
updated_at: 2020-01-15T04:49:28Z
closed_at: 2019-11-21T06:01:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2445
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2445/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzODU2MzIw
title: Update Setups for Creature Dressups
state: closed
created_at: 2019-11-21T05:52:23Z
updated_at: 2020-01-15T04:49:28Z
closed_at: 2019-11-22T05:01:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2446
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQzODU5NzA5
title: handle special case for PKType deaths + Enduring Enchantment + DoTs
state: closed
created_at: 2019-11-21T06:05:36Z
updated_at: 2019-11-22T06:09:43Z
closed_at: 2019-11-22T06:09:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2447
body: Thanks @dgarson for discovering this
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0Mjc1MDc2
title: fixing monster resleep -> wakeup cycle for combat mode
state: closed
created_at: 2019-11-21T23:06:28Z
updated_at: 2019-11-22T01:36:50Z
closed_at: 2019-11-22T01:36:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2448
type: pull
body:
  This fixes a bug where a monster that wakes up from spotting a player, then the player goes out of range and the monster returns to home / falls back asleep, then another player wakes the monster up again, the monster was not returning to the correct combat state again.

  Repro steps:
  /teleloc 0x654A011E [54.633018 -31.307457 0.005000] 0.672991 0.000000 0.000000 -0.739651
  Note any rock-throwing lugians and archer tumeroks are behaving correctly
  Run back to the entrance portal of the dungeon, and exit the dungeon
  Re-enter the dungeon portal
  Run back to those same monsters

  Expected: same as before
  Actual: monster will be in non-combat mode, but launching projectiles without doing any animations. The tumeroks are especially bugged, where they are launching arrows faster than normal

  This patch fixes that bug, and has the monsters re-enter the correct combat stance after re-awakening

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0MzIwMDQx
title: Test Loot Generator
state: closed
created_at: 2019-11-22T02:24:00Z
updated_at: 2019-11-23T00:49:07Z
closed_at: 2019-11-23T00:49:07Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2449
type: pull
body:
  Moved Test Loot Generator (Loot Simulator) to its own class (LootGenerationFactory_Test.cs) and moved Test Loot Gen console commands to its own class (DeveloperLootCommands.cs)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2449/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0MzIzMTgx
title: allowing obsidian chittick spines to do DamageType.Undef, as per py16 data
state: closed
created_at: 2019-11-22T02:39:30Z
updated_at: 2019-11-22T06:09:15Z
closed_at: 2019-11-22T06:09:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2450
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0MzIzNzU1
title: Caster update
state: closed
created_at: 2019-11-22T02:42:19Z
updated_at: 2019-12-02T00:47:09Z
closed_at: 2019-12-02T00:47:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2451
type: pull
body:
  LootFactory CreateCaster refactored. Items now created via wields not tier. Updated values for the correct wields (values are based off of data from Optim and Magnus).

  PR has been tested on private server without issue.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0MzI0OTc2
title: Missile weapon updates
state: closed
created_at: 2019-11-22T02:48:10Z
updated_at: 2019-12-02T00:30:48Z
closed_at: 2019-12-02T00:30:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2452
type: pull
body:
  Missile Updates
  If tier is 4 or 5 then a chance for non elemental missile weapon with wield reqs
  Tier 6 and up, Only elemental missile weapons are supposed to drop per retail.
  Added 10% variance for Damage Modifier. Full Modifier was rare in retail
  Added +19 Elemental (like retail) and readjusted odds (odds are approximate, no hard data).
  Made MeleeDefenseMod appropriate to Bow Reqs.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0MzMwNzgw
title: fixing 2 tailoring bugs
state: closed
created_at: 2019-11-22T03:18:15Z
updated_at: 2019-11-23T00:35:41Z
closed_at: 2019-11-23T00:35:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2453
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0MzQ1MDgx
title: fixing death items for players < level 35
state: closed
created_at: 2019-11-22T04:31:14Z
updated_at: 2019-11-22T06:09:24Z
closed_at: 2019-11-22T06:09:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2454
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0Mzc4OTk4
title: adding post-windup range check to spellcasting
state: closed
created_at: 2019-11-22T07:00:25Z
updated_at: 2019-11-23T00:35:59Z
closed_at: 2019-11-23T00:35:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2455
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0NDIzMTY3
title: enabling retail behavior for trade bots
state: closed
created_at: 2019-11-22T09:22:41Z
updated_at: 2019-11-25T22:02:50Z
closed_at: 2019-11-25T22:02:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2456
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0NDYxMzEz
title: refactoring house permissions
state: closed
created_at: 2019-11-22T10:57:14Z
updated_at: 2019-11-25T22:02:59Z
closed_at: 2019-11-25T22:02:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2457
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0NTUzOTY3
title: xp divvy accuracy
state: closed
created_at: 2019-11-22T14:48:39Z
updated_at: 2019-11-23T00:36:13Z
closed_at: 2019-11-23T00:36:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2458
type: pull
body:
  This fixes some subtle errors that were possible when divvying up XP earned from killing a creature

  Example mob in all of these scenarios has 100/100 health

  Scenario A:

  Player deals 90 direct damage to monster, and then lands a DF bleed attack. The DF bleed deals 30 damage to the monster, resulting in 120 in the damage history. The player was earning 120% of the xp for the monster in this case.

  Scenario B:

  Player deals 90 damage to monster. Monster is now at 10/100 health.

  Monster than casts a spell which raises its MaxHealth by 20. Monster is now at 10/120 health.

  Player then kills the monster. In this case, the player was only earning ~83% of the XP for the mob.

  Scenario C:

  Player deals 90 damage to monster. Monster is now at 10/100 health.

  In this case, the monster had a MaxHealth-raising spell in effect, and it now expires. Monster is now at 10/80 health.

  Player then kills the monster. In this case, Player was receiving 125% of the XP for the mob.

  For Scenario A, the DoT pre-tick where it adds up all of the damage from the individual sources, and adds them each to the DamageHistory separately, could simply be amended to cap to the monster's currently remaining health, similar to regular damage.

  However, for Scenarios B & C, these are subtler issues where the monster's MaxHealth can change over the course of a battle. The best way to handle all 3 of these scenarios is to simply divide by the total damage in the history (which should equal their MaxHealth in *most* instances, but not always)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0NzYzNjM1
title: Set all Shard non-zero defaults to zero
state: closed
created_at: 2019-11-23T01:57:19Z
updated_at: 2019-11-27T03:50:05Z
closed_at: 2019-11-26T21:28:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2459
type: pull
body:
  There appears to be a bug in EF where, if the models value is not nullab,e and is 0, and the SQL columns default is not 0, the EF.SaveChanges() command will INSERT the record but omit the columns that are 0 value.

  The DB will then add default values for the omitted columns.

  The entire record is then returned as a result, and EF uses this to update the model, now setting those fields that were 0 to the new non-zero default.

  This is the cause for the Jive Turkey emote delay issues.

  The next step will be to create an update script that will set existing shard objects to their weenie defaults. The following tables will need to be investigated:
  biota_properties_create_list
  biota_properties_emote
  biota_properties_emote_action

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0ODEyMDA4
title: Move ThreadSafeTeleport to WorldManager
state: closed
created_at: 2019-11-23T14:13:52Z
updated_at: 2019-11-24T22:49:16Z
closed_at: 2019-11-24T22:49:06Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2460
body: Moving objets across thread boundaries is a funciton of the WorldManager, not a Player
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0ODI5Mzc2
title: [WIP] ObjectMaint doesn't need a static ReaderWriterLockSlim
state: closed
created_at: 2019-11-23T17:52:26Z
updated_at: 2019-11-29T03:32:33Z
closed_at: 2019-11-23T23:31:43Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2461
body: Still needs thread safety though.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0ODU1NTQ3
title: adding fix-biota-emote-delay server console command
state: closed
created_at: 2019-11-23T23:42:58Z
updated_at: 2019-11-26T21:28:56Z
closed_at: 2019-11-26T21:28:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2462
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0ODc0OTg5
title: Remove dungeons in AdjustPos
state: closed
created_at: 2019-11-24T05:28:47Z
updated_at: 2020-01-15T04:49:29Z
closed_at: 2019-12-05T07:18:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2463
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ0OTM0MjAz
title: including viewer name in container already opened message
state: closed
created_at: 2019-11-24T18:24:15Z
updated_at: 2019-11-25T22:03:31Z
closed_at: 2019-11-25T22:03:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2464
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1MDAwMjM4
title: EquipmentSetID
state: closed
created_at: 2019-11-25T03:47:35Z
updated_at: 2020-01-18T21:00:03Z
closed_at: 2019-12-15T16:31:44Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2465
type: pull
body:
  - Add method to apply a random EquipmentSetID to tier 7 & 8 armor, with a modifiable base line of 10% chance
  - Initial introduction controlled via server property, which is set to false by default, allowing server ops to decide for themselves to enable it
  - Added option to add Set name to item name

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1MzY2Mjkw
title: fix stance swap state thrashing
state: closed
created_at: 2019-11-25T18:53:30Z
updated_at: 2019-11-26T00:18:43Z
closed_at: 2019-11-26T00:18:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2466
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2466/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1NDMzNjAz
title: setting default CultureInfo en-US
state: closed
created_at: 2019-11-25T21:48:11Z
updated_at: 2019-12-05T07:46:05Z
closed_at: 2019-12-05T07:46:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2467
type: pull
body:
  Bug: many game functions that don't explicitly specify InvariantCulture are breaking with other cultures

  Repro steps:

  Change the CultureInfo in the PR to sv-SE

  ```
  /grantxp 1000
  1 000 experience granted.
  /tele 74.3S, 21.9E
  North/South coordinate is not a valid number.
  ```

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2467/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1NDQ3ODI4
title: ensuring HealingOverTime does not tick up health for dead creatures
state: closed
created_at: 2019-11-25T22:25:34Z
updated_at: 2019-11-26T00:18:57Z
closed_at: 2019-11-26T00:18:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2468
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1NDY0NzY3
title: additional checks for IsDead
state: closed
created_at: 2019-11-25T23:18:12Z
updated_at: 2019-11-26T00:19:07Z
closed_at: 2019-11-26T00:19:07Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2469
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1NDkzNTgz
title: Test loot gen
state: closed
created_at: 2019-11-26T01:19:00Z
updated_at: 2019-12-02T00:59:04Z
closed_at: 2019-12-02T00:59:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2470
body: Added SkillType and weapon name for Melee weapons stats
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2470/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1OTIwMDMw
title: add check to damagehistory.checkinternal
state: closed
created_at: 2019-11-26T20:24:02Z
updated_at: 2019-11-27T03:27:47Z
closed_at: 2019-11-27T03:27:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2471
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ1OTQ5MTU4
title: adding preliminary support for fast missiles
state: closed
created_at: 2019-11-26T21:44:27Z
updated_at: 2020-04-06T13:41:10Z
closed_at: 2020-04-06T13:41:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2472
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2MDEyNDg5
title: adding more IsDead checks to magic casting
state: closed
created_at: 2019-11-27T01:51:11Z
updated_at: 2019-11-27T03:27:56Z
closed_at: 2019-11-27T03:27:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2473
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2473/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2MDE0NTcw
title: fix ThreadSafeTeleportOnDeath -> SetLifestoneProtection
state: closed
created_at: 2019-11-27T02:01:49Z
updated_at: 2019-11-27T03:28:04Z
closed_at: 2019-11-27T03:28:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2474
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2NDM4OTQ5
title: CharacterExporter fixes
state: closed
created_at: 2019-11-27T21:55:09Z
updated_at: 2019-11-27T22:06:39Z
closed_at: 2019-11-27T22:06:29Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2475
type: pull
body:
  Fix CharacterSQLWriter for CharacterPropertiesContractRegistry

  PropertyInt, add comments for PlacementPosition and add InventoryOrder for future use.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2475/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2NDcyNjUw
title: Add a few late game recall spells to Player_AllowedSpellID.cs
state: closed
created_at: 2019-11-28T00:29:26Z
updated_at: 2019-11-28T00:34:20Z
closed_at: 2019-11-28T00:34:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2476
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2476/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2NTE4NjUw
title: Update Player_AllowedSpellID.cs
state: closed
created_at: 2019-11-28T04:44:57Z
updated_at: 2019-12-02T03:24:29Z
closed_at: 2019-12-02T03:24:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2477
type: pull
body:
  This takes the previous list, as well as every spell id found in retail pcaps player spellbooks, and combines them into a new list.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2NTkwODk2
title: adding support for 'confirm use of rare gems'
state: closed
created_at: 2019-11-28T09:05:16Z
updated_at: 2019-11-28T16:14:21Z
closed_at: 2019-11-28T16:14:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2478
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2NjE1NDI2
title: fixing tailor shield
state: closed
created_at: 2019-11-28T10:00:23Z
updated_at: 2019-12-05T07:46:23Z
closed_at: 2019-12-05T07:46:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2479
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ2OTUyMDg3
title: cleanup playscript
state: closed
created_at: 2019-11-29T08:58:35Z
updated_at: 2019-11-30T00:56:09Z
closed_at: 2019-11-30T00:56:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2480
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2480/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MDQ2OTkz
title: Add server option for adjusting quest timers
state: closed
created_at: 2019-11-29T13:26:36Z
updated_at: 2019-12-02T03:24:10Z
closed_at: 2019-12-02T03:23:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2481
body: quest_mindelta_rate
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2481/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MDkyNzM1
title: Rare fix
state: closed
created_at: 2019-11-29T15:34:23Z
updated_at: 2019-11-30T02:38:45Z
closed_at: 2019-11-30T02:38:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2482
type: pull
body:
  Removed weenie 30198 (Arbelist's Crystal) from rare table.  It is a bugged rare for Missile Weapons.  Correct Rare weenie for Missile Weapons is 30194 (Elysa's) and is already in game.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2482/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MTgwODE3
title: refactoring raise attribute/vital/skill, fixing security issues with them
state: closed
created_at: 2019-11-30T01:00:55Z
updated_at: 2019-12-05T07:54:59Z
closed_at: 2019-12-05T07:54:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2483
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MTg3OTUw
title: Update QuestManager to support creatures with quests
state: closed
created_at: 2019-11-30T03:19:57Z
updated_at: 2019-12-05T23:19:41Z
closed_at: 2019-12-05T08:49:52Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2484
type: pull
body:
  - Adapted from [PR#2427](https://github.com/ACEmulator/ACE/pull/2427); moved QuestManager scope from Player down to Creature
  - Basic example of creatures using their own QuestManager is "The Chicken" at @teleloc 0xA9B3000E [33.351970 125.221100 93.992000] 0.707107 0.000000 0.000000 0.707107, down the road from the Lifestone in Holburg, toward the Drudge Hideout

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2484/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MzEyNjgw
title: adding verify* console commands for admins
state: closed
created_at: 2019-12-01T10:12:25Z
updated_at: 2019-12-05T08:02:58Z
closed_at: 2019-12-05T08:02:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2485
type: pull
body:
  This PR builds on top of https://github.com/ACEmulator/ACE/pull/2483. That PR fixes a bunch of issues that were causing this bad data, so that one should be checked in first.

  This adds a bunch of console commands for server admins to verify all of the player data on their server, and optionally fix any issues.

  verify-attributes
  verify-vitals
  verify-skills
  verify-skill-credits
  verify-heritage-augs
  verify-max-augs
  verify-xp

  These commands have all been tested on the ce shard.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MzMyNTI4
title: preventing crash in EnvCell constructor from other state in the system
state: closed
created_at: 2019-12-01T14:03:20Z
updated_at: 2019-12-01T16:06:12Z
closed_at: 2019-12-01T16:06:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2486
type: pull
body:
  Repro steps:

  ```
  DatManager.PortalDat.ReadFromDat<MotionTable>(0);
  DatManager.PortalDat.ReadFromDat<ACE.DatLoader.FileTypes.Environment>(0);
  ```

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2486/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3MzQwMzcw
title: adding support for Creature.QuestManager
state: closed
created_at: 2019-12-01T15:25:35Z
updated_at: 2019-12-05T07:46:55Z
closed_at: 2019-12-05T07:46:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2487
body: This builds on Ripley's PR https://github.com/ACEmulator/ACE/pull/2427
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2487/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3Mzk0ODA0
title: Melee overdamage fix
state: closed
created_at: 2019-12-02T00:59:51Z
updated_at: 2019-12-08T15:39:50Z
closed_at: 2019-12-08T15:39:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2488
body: Fixes Melee Weapons being created that over max damage for that wield.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ3NDUyNDA5
title: moving UpdatePlayerPhysics to Player_Tick.cs
state: closed
created_at: 2019-12-02T06:01:04Z
updated_at: 2019-12-03T17:13:46Z
closed_at: 2019-12-03T17:13:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2489
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ4MTU0MzM3
title: Move* emotes use default WalkRunThreshold
state: closed
created_at: 2019-12-03T06:45:26Z
updated_at: 2019-12-05T07:47:13Z
closed_at: 2019-12-05T07:47:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2490
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2490/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ4MzM4NTQy
title: mana conversion mod tweaks
state: closed
created_at: 2019-12-03T13:46:02Z
updated_at: 2019-12-05T08:03:22Z
closed_at: 2019-12-05T08:03:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2491
type: pull
body:
  The main purpose of this patch was to fix a bug where appraisal was showing Mana Conversion Bonus: +0% for a many casting items

  At first I thought this was a bug in the loot generator, but after discussing it with @harliq, it turns out there are actually many casting items with base weenies that have PropertyFloat.ManaConversionMod=0 in the data

  So to account for this, Appraisal is now checking if ManaConversionMod exists, but is 0, it removes it.

  I also noticed some possible bugs with Hermetic Void, which sounds like it is cast on the wand, similar to the other item debuffs. The logic for ManaConversionMod enchantments should be taking both auras and spells cast directly on the item into account for this.

  Update: it has been discovered from retail pcaps that retail also had this bug.

  Retail also didn't normalize ManaConversionMod on the items -- some of the base weenies have 0, some of them have null. The retail pcaps had ManaConversionMod=0 in many instances (even while unbuffed), but there were also a few rare instances of ManaConversionMod not being sent.

  The 'show_mana_conv_bonus_0' server option has been added, which defaults to true to match retail behavior.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2491/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ4NjQyMjE4
title: Null mana c
state: closed
created_at: 2019-12-04T01:29:59Z
updated_at: 2019-12-10T23:29:34Z
closed_at: 2019-12-10T23:29:34Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2492
body: Nulling ManaC for appraisal
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2492/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ4NzM4Njgy
title: adding support for creeping mobs
state: closed
created_at: 2019-12-04T07:41:00Z
updated_at: 2019-12-05T07:54:35Z
closed_at: 2019-12-05T07:54:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2493
body: This PR builds on top of https://github.com/ACEmulator/ACE/pull/2490
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2493/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5MTg1NjYz
title: Support RelativeDestination on Portals
state: closed
created_at: 2019-12-05T00:33:31Z
updated_at: 2020-01-15T04:49:30Z
closed_at: 2019-12-05T07:18:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2494
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2494/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5MTg3OTc5
title: Expand scope for generator wipe condition
state: closed
created_at: 2019-12-05T00:37:57Z
updated_at: 2020-01-15T04:48:33Z
closed_at: 2019-12-14T20:53:48Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2495
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2495/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5MTkyNzE1
title: Support Emote branching with Events
state: closed
created_at: 2019-12-05T00:47:13Z
updated_at: 2020-01-15T04:48:49Z
closed_at: 2019-12-05T07:18:47Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2496
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5MjUxMzI4
title: enabling post-windup turn for pve
state: closed
created_at: 2019-12-05T04:43:37Z
updated_at: 2020-01-22T22:55:14Z
closed_at: 2020-01-22T22:55:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2497
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2497/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5Mjk2NTkx
title: Update EmoteManager Replace
state: closed
created_at: 2019-12-05T07:32:24Z
updated_at: 2020-01-15T04:48:39Z
closed_at: 2019-12-06T05:56:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2498
body: Builds upon #2487
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2498/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5MzI1NzEz
title: fixing some minor bugs in AwardSkillXP emotes
state: closed
created_at: 2019-12-05T08:59:08Z
updated_at: 2019-12-05T09:19:09Z
closed_at: 2019-12-05T09:19:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2499
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2499/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5NDQ2MjQz
title: adding /resist-info command
state: closed
created_at: 2019-12-05T13:39:47Z
updated_at: 2019-12-05T22:57:51Z
closed_at: 2019-12-05T22:57:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2500
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2500/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5NDYwMzcy
title: pre-validating envcell transitions
state: closed
created_at: 2019-12-05T14:09:37Z
updated_at: 2019-12-08T00:59:40Z
closed_at: 2019-12-08T00:59:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2501
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzQ5NTEyOTY3
title: additional check for verify-skill
state: closed
created_at: 2019-12-05T15:54:47Z
updated_at: 2019-12-05T22:58:01Z
closed_at: 2019-12-05T22:58:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2502
type: pull
body:
  Adding this check just for completeness

  I ran this additional check on the ce shard, and it found no instances of players having untrained skills where xp/ranks > 0

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2502/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMDg2NTQ4
title: adding some CurrentLandblock checks to Slumlord
state: closed
created_at: 2019-12-06T16:31:51Z
updated_at: 2019-12-08T00:59:49Z
closed_at: 2019-12-08T00:59:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2503
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMDk5MDQx
title: improved speed for import-json all
state: closed
created_at: 2019-12-06T16:52:16Z
updated_at: 2019-12-08T00:59:59Z
closed_at: 2019-12-08T00:59:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2504
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2504/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMTc4NjU0
title: fixing client hourglass for applying encapsulated essence while in busy state
state: closed
created_at: 2019-12-06T20:01:03Z
updated_at: 2019-12-08T01:00:06Z
closed_at: 2019-12-08T01:00:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2505
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2505/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMjYyODMw
title: Fix issue with nulls in Replace
state: closed
created_at: 2019-12-07T01:42:13Z
updated_at: 2020-01-15T04:48:38Z
closed_at: 2019-12-07T03:30:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2506
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2506/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU1MzQzOTExNjg=
title: Criticals don't work with Martyr's hecatomb like they did in retail.
state: closed
created_at: 2019-12-07T11:39:22Z
updated_at: 2019-12-14T20:54:33Z
closed_at: 2019-12-14T20:54:33Z
author_association: CONTRIBUTOR
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  <!-- Please list the steps to reproduce a bug here -->

  Have 3 wands:
  plain wand
  Critical strike wand made with opal
  Biting strike quest wand (such as Branith's staff)

  Tested on Coldeve, against target drudges in Yanshi
  1. Use Martyr's Hecatomb (VII in this case) repeatedly
  2. Count the number of critical strikes made.
  3. Observe that 
  (a) normal wands never give critical hits, but should give 5% like retail
  (b) critical strike don't give > 5% - 50% critical hits
  (c) biting strike does seem to work 33% critical from Branith's quest wand

  Please see example below
  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->
  Here is the summary of the results:

  refs:
  https://asheron.fandom.com/wiki/Combat


  Critical hits should happen at least 5% of the time for magic
  ------------------------------------------------------------
  jason@firestorm MSYS /c/temp
  $ grep -i hecatomb starter_wand.log  | wc -l
  37

  jason@firestorm MSYS /c/temp
  $ grep -i hecatomb starter_wand.log  | grep -i crit | wc -l
  0



  Critial hits should happen higher than 5% of the time up to a 50%? based on skill
  -----------------------------------------------------------------------------------------------
  $ grep -i hecatomb critical_strike.log  | wc -l
  34

  jason@firestorm MSYS /c/temp
  $ grep -i hecatomb critical_strike.log  | grep -i critical | wc -l
  0

  Biting strike is probably working at 8 / 33 = 33%
  -------------------------------------------------------------------

  $ grep -i hecatomb biting_strike.log  | wc -l
  33

  jason@firestorm MSYS /c/temp
  $ grep -i hecatomb biting_strike.log  | grep -i critical | wc -l
  8



  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->
  Work as in retail, with the magic criticals all working the same for each school

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->
  I have the raw logs if interested

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2507/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMzcxMjcx
title: recipe manager additions
state: closed
created_at: 2019-12-08T03:11:10Z
updated_at: 2019-12-08T10:31:12Z
closed_at: 2019-12-08T10:31:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2508
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2508/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMzc0MzA2
title: /addenc command for content creators to create encounters
state: closed
created_at: 2019-12-08T04:09:45Z
updated_at: 2019-12-09T18:05:49Z
closed_at: 2019-12-09T18:05:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2509
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2509/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMzc0OTQ3
title: Buy or maintain house transaction: split item & note stacks when needed.
state: closed
created_at: 2019-12-08T04:20:52Z
updated_at: 2019-12-08T23:00:11Z
closed_at: 2019-12-08T23:00:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2510
type: pull
body:
  Both trade note stacks and other types of stacks are split when necessary and extras remain in player inventory for the buy or maintain house transaction.  No coin change is given.  Smallest notes favored over Largest.  Splits note stacks and other item stacks when needed.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2510/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwMzgxMTQ0
title: matching DoT ticks up with retail heartbeats
state: closed
created_at: 2019-12-08T06:17:27Z
updated_at: 2019-12-09T18:05:40Z
closed_at: 2019-12-09T18:05:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2511
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwNDUxMTUz
title: PlayerFactory Improvements
state: closed
created_at: 2019-12-08T20:28:24Z
updated_at: 2019-12-11T13:57:42Z
closed_at: 2019-12-11T13:57:29Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2512
type: pull
body:
  Remove all of the custom character create stuff out of PlayerFactory and into PlayerFactoryEx.

  Fix a few other minor issues like SpendAllXp.

  Make LootGenerationFactory functions public to make them easier to consume, as well as adding some options. These functions will need to be cleaned up eventually as the loot generation system transitions to one backed by a database.

  None of these changes affect ACE unless you're using some of the auto create character stuff I've templated in one of my branches. This just updates Master with some of my latest stuff.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2512/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwNDYxMTYz
title: improved handling for overages for house payments
state: closed
created_at: 2019-12-08T22:08:09Z
updated_at: 2019-12-10T06:27:04Z
closed_at: 2019-12-10T06:27:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2513
type: pull
body:
  This builds on fartwhif's https://github.com/ACEmulator/ACE/pull/2510 pr, and also fixes some pipelining issues in the original housing functions, for consuming that data w/ full logging for players trying to send any invalid data to the server

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2513/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwNjk4NTg5
title: suppress some incorrect log / chat messages for SpellComponentsRequired
state: closed
created_at: 2019-12-09T12:54:16Z
updated_at: 2019-12-09T20:17:01Z
closed_at: 2019-12-09T20:17:01Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2514
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2514/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwNzM0Njk2
title: Network improvements
state: closed
created_at: 2019-12-09T14:08:56Z
updated_at: 2019-12-31T01:10:43Z
closed_at: 2019-12-31T01:10:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2515
type: pull
body:
  Disregard the commit where I was testing Fartwhifs CryptoSystem changes. That work is not in this PR.

  The objective here, which is still on going

  - Reduce "new byte[]"
  -- At least two "new byte[]" have been reduced per client packet

  - Make the ClientPacket and ServerPacket objects easier to reuse outside of ACE, in either a client or server side app
  -- Move "Pack" and "Unpack" work out of the ctor and into public functions

  - Clean up some of the variable and function names
  -- "Pack", "Unpack", "Payload" -> "DataReader"

  This PR is good to go and offers improvements over current master. There are still improvements to be had, and I will likely work on those in the near future and submit them in follow up PR's.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2515/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwNzg1MTc3
title: PlayerManager GetOnlineCount() and GetOfflineCount()
state: closed
created_at: 2019-12-09T15:46:48Z
updated_at: 2019-12-10T00:57:12Z
closed_at: 2019-12-10T00:57:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2516
body: This returns the count, when required, without having to create new lists.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2516/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwODQxNTE3
title: update enlightenment vitality formula for max health
state: closed
created_at: 2019-12-09T17:47:13Z
updated_at: 2019-12-09T20:17:33Z
closed_at: 2019-12-09T20:17:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2517
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUwOTg5OTQw
title: adding missing function for physics @ plateau
state: closed
created_at: 2019-12-09T20:08:19Z
updated_at: 2019-12-10T06:27:15Z
closed_at: 2019-12-10T06:27:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2518
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2518/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUxMTQyMDA1
title: Add a few pcap properties
state: closed
created_at: 2019-12-10T00:33:30Z
updated_at: 2020-01-15T04:48:35Z
closed_at: 2019-12-10T05:44:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2519
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2519/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUxMzU3OTc5
title: fixing scatter generators for neftet plateaus
state: closed
created_at: 2019-12-10T12:13:37Z
updated_at: 2019-12-11T11:19:11Z
closed_at: 2019-12-11T11:19:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2520
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2520/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUxMzc1MzAw
title: adding lifestone_broadcast_death server option, clamping to local chat range
state: closed
created_at: 2019-12-10T12:54:02Z
updated_at: 2019-12-11T11:19:49Z
closed_at: 2019-12-11T11:19:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2521
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2521/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUxNjcwNDg5
title: update summoning mobs
state: closed
created_at: 2019-12-11T00:38:47Z
updated_at: 2019-12-21T07:06:00Z
closed_at: 2019-12-21T07:06:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2522
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUxNzI1Mjkx
title: PetClass commenting for SQL Writer
state: closed
created_at: 2019-12-11T04:53:09Z
updated_at: 2020-01-15T04:48:33Z
closed_at: 2019-12-11T18:49:01Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2523
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2523/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUxOTkzNDY2
title: adding verifications for source.Usable flags
state: closed
created_at: 2019-12-11T16:08:01Z
updated_at: 2019-12-11T19:13:05Z
closed_at: 2019-12-11T19:13:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2524
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2524/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyMzg5Nzc3
title: re-verify client checks for GameAction 0x35 - UseWithTarget
state: closed
created_at: 2019-12-12T12:28:31Z
updated_at: 2019-12-13T03:14:22Z
closed_at: 2019-12-13T03:14:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2525
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2525/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyNDAwMzY1
title: fixing armor tailoring intermediate kit TargetType
state: closed
created_at: 2019-12-12T12:55:16Z
updated_at: 2019-12-12T20:18:54Z
closed_at: 2019-12-12T20:18:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2526
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyNTE0MjI1
title: tailoring - do not copy UIEffects to destination item
state: closed
created_at: 2019-12-12T16:53:25Z
updated_at: 2019-12-12T20:19:05Z
closed_at: 2019-12-12T20:19:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2527
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyNTk4Mjc1
title: ensure level 8 item self spells take precedence over level 8 item other spells
state: closed
created_at: 2019-12-12T20:32:10Z
updated_at: 2019-12-14T20:54:19Z
closed_at: 2019-12-14T20:54:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2528
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2528/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyNjM3NDIy
title: fixing AwardLevelProportionalXP when Max64==0
state: closed
created_at: 2019-12-12T22:21:55Z
updated_at: 2019-12-14T20:54:26Z
closed_at: 2019-12-14T20:54:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2529
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2529/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyNzI2NjUy
title: Support FirstEnterWorldDone on Players
state: closed
created_at: 2019-12-13T05:24:12Z
updated_at: 2019-12-13T05:39:25Z
closed_at: 2019-12-13T05:39:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2530
type: pull
body:
  * Switch `FirstEnterWorldDone` to ephemeral property
  * Add SQL script to remove all `FirstEnterWorldDone` properties from shard DB
  * Set FirstEnterWorldDone to false in Player ctor if previous script is not run
  * Existing code already sets to true appropriately, when client reports a successfully completed login.
  * Add a check in GameActionSetCharacterOptions for FirstEnterWorldDone being completed before processing and persisting.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2530/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUyNzMwMTMy
title: Support FirstEnterWorldDone on Players
state: closed
created_at: 2019-12-13T05:41:38Z
updated_at: 2020-01-15T04:48:28Z
closed_at: 2019-12-14T20:49:29Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2531
type: pull
body:
  * Switch `FirstEnterWorldDone` to ephemeral property
  * Add SQL script to remove all `FirstEnterWorldDone` properties from shard DB
  * Set FirstEnterWorldDone to false in Player ctor if previous script is not run
  * Existing code already sets to true appropriately, when client reports a successfully completed login.
  * Add a check in GameActionSetCharacterOptions for FirstEnterWorldDone being completed before processing and persisting.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2531/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMTA5NjUw
title: adding CS support for Martyr's Hecatomb
state: closed
created_at: 2019-12-13T23:22:25Z
updated_at: 2019-12-14T20:54:33Z
closed_at: 2019-12-14T20:54:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2532
body: This fixes https://github.com/ACEmulator/ACE/issues/2507
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2532/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMTI3NzEz
title: Update generatordump spew
state: closed
created_at: 2019-12-14T01:22:23Z
updated_at: 2020-01-15T04:48:30Z
closed_at: 2019-12-14T05:39:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2533
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2533/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMTQwNzU1
title: fix CharacterOption to match acclient PlayerOption ordering
state: closed
created_at: 2019-12-14T04:22:08Z
updated_at: 2019-12-14T19:37:55Z
closed_at: 2019-12-14T19:37:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2534
type: pull
body:
  This is an update from Yonneh, to fix an issue with decal plugins calling GameAction 5 - SetSingleCharacterOption for various options

  Whoever originally wrote CharacterOption did not match up the names and ordering of this enum with PlayerOption in acclient. It looks like they started to, but then jumped around to use the ordering in the UI options display, and did not properly set all of the # values.

  I have verified that this fix does not break any of the existing character options / db ordering in ace

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2534/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMTk4ODk5
title: Update House.OnProperty HasDungeon boot condition
state: closed
created_at: 2019-12-14T18:12:19Z
updated_at: 2020-01-15T04:48:29Z
closed_at: 2019-12-14T18:18:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2535
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2535/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMjAzNTc2
title: Add Item in Trade Checks
state: closed
created_at: 2019-12-14T19:12:30Z
updated_at: 2020-01-15T04:48:26Z
closed_at: 2019-12-14T20:51:44Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2536
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2536/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMjEzNzc0
title: backporting support functions from 1991
state: closed
created_at: 2019-12-14T21:16:35Z
updated_at: 2019-12-15T14:54:17Z
closed_at: 2019-12-15T14:54:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2537
type: pull
body:
  This PR is to help bridge the gap between master branch and https://github.com/ACEmulator/ACE/pull/1991

  All of the support functions and non-critical functions that can be ported from 1991 -> master branch are included here. These updates should provide 0 noticeable difference to current master branch, but helps pave the way for integrating these 2 branches

  This will bring the line count in 1991 down to about ~900, which is much more manageable, and contains only the core functions needed for advanced player movement / spellcasting

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2537/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMjE3Nzg2
title: Swap mundane and item usage for Treasure loot profiles
state: closed
created_at: 2019-12-14T22:13:06Z
updated_at: 2020-01-18T21:00:01Z
closed_at: 2019-12-15T16:31:19Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2538
type: pull
body:
  - Found that MundaneItem and Item loot profile usages were opposite the descriptions of loot categories described on the wiki; swapped their usage, so MundaneItem loot profile classifies loot gear with no magical properties and Item loot profile classifies non-mutable items
  - Separated Dinnerware out of generic item category
  - Modified individual loot generation methods to accept the whole DeathTreasure profile object, rather than just the tier value
  - Add usage of LootQualityMod for spell assignment, such that float values greater than 0 will give higher chances as cantrips, given the Death Treasure loot profiles that contain a value greater than 0

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2538/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMjE4NzYz
title: Support No Drop on Death Landblocks
state: closed
created_at: 2019-12-14T22:27:36Z
updated_at: 2020-01-15T04:48:24Z
closed_at: 2019-12-14T22:42:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2539
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2539/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMjMyODA5
title: Update AugmentationDevice to use WeenieErrorWithString
state: closed
created_at: 2019-12-15T02:41:52Z
updated_at: 2020-01-15T04:48:24Z
closed_at: 2019-12-16T19:01:18Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2540
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2540/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMjQ3NzEy
title: fix for ignored C2S NAK
state: closed
created_at: 2019-12-15T07:13:14Z
updated_at: 2019-12-16T17:06:23Z
closed_at: 2019-12-16T17:06:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2541
type: pull
body:
  Fixed bug that occurs when client sends only a cleartext CRC NAK and ACE ignoring them, switch from honoring only ciphertext CRC NAK to honoring only cleartext CRC NAK

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2541/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMzEzMDA5
title: Miser Aug does not affect items for PK and PKL deaths
state: closed
created_at: 2019-12-15T20:49:21Z
updated_at: 2020-01-15T04:48:23Z
closed_at: 2019-12-15T21:11:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2542
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2542/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMzIxODIy
title: Switch Lifespan to RealTime instead of GameTime
state: closed
created_at: 2019-12-15T22:29:33Z
updated_at: 2020-01-15T04:48:22Z
closed_at: 2019-12-19T08:53:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2543
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzMzU0MTkz
title: Add time limit to Portal Space
state: closed
created_at: 2019-12-16T03:05:00Z
updated_at: 2020-01-15T04:48:21Z
closed_at: 2020-01-15T04:46:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2544
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2544/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzUzNjA5NTY3
title: continued porting of 1991 to master branch
state: closed
created_at: 2019-12-16T15:04:29Z
updated_at: 2019-12-17T14:21:08Z
closed_at: 2019-12-17T14:21:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2545
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2545/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU0MzgxNTU5
title: preliminary merge of branches
state: closed
created_at: 2019-12-18T01:19:30Z
updated_at: 2019-12-31T03:18:10Z
closed_at: 2019-12-31T03:18:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2546
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2546/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU0NDQ5MzU2
title: do not add cross-landblock references for calc_cross_cells_static
state: closed
created_at: 2019-12-18T06:37:18Z
updated_at: 2019-12-18T14:25:07Z
closed_at: 2019-12-18T14:25:07Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2547
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2547/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU0NTc3NDE3
title: Fixed caster damage modifier to use appropriate PvP modifier instead of PvM
state: closed
created_at: 2019-12-18T11:59:34Z
updated_at: 2019-12-18T14:43:25Z
closed_at: 2019-12-18T14:22:28Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2548
type: pull
body:
  It appears that the casting damage modifier being used for PvP mode is in fact unaffected by the PvP modifier for weapon damage, so it is using the PvM caster modifier instead. This patch includes the `modifier` which is the piece that includes reduction of the caster modifier for PK purposes.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2548/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU0NjUxNDQw
title: minor math optimization
state: closed
created_at: 2019-12-18T14:46:48Z
updated_at: 2019-12-22T07:53:26Z
closed_at: 2019-12-22T07:53:25Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2549
body: pre-calculate the ISAAC key
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2549/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU0ODgyNzQw
title: only apply NetherDotDamageRating to direct damage
state: closed
created_at: 2019-12-19T00:29:03Z
updated_at: 2020-08-24T21:37:23Z
closed_at: 2019-12-19T09:20:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2550
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2550/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU1MzMyNDQx
title: LootFactory Simulator
state: closed
created_at: 2019-12-19T20:15:07Z
updated_at: 2019-12-30T19:05:13Z
closed_at: 2019-12-30T19:05:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2551
type: pull
body:
  This update now has a new command to simulate corpses based on a DID.  New Command is 
  ```testlootgencorpse <DID> <# of Corpses to generate>```
  Example:
  ```testlootgencorpse 998 1099```
  Following is a list of DeathTreasure DID's for all creatures in ACE database currently (thanks Optim)
  [DeathTreasureDIDs](https://github.com/harliq/AceWiki/blob/master/other/Monster%20DeathTreasure%20DIDs.txt)
  or here:
  [Optim's Death Treasure DID List](http://ac.yotesfan.com/loot/death_treasure_did.php)

  Also stats have a new format, and now the summary is below the weapons tables  
  Example of Summary Table
  ```
   Treasure Items
   ----
   Armor=546
   MeleeWeapon=321
   Caster=157
   MissileWeapon=259
   Jewelry=441
   Gem=370
   Clothing=320

   Generic Items
   ----
   Food=520
   SpellComps=70
   Keys=75
   ManaStones=50
   Pets=179
   EncapSpirits=21
   Scrolls=128
   Potions=220
   Healing Kits=66
   Level 8 Comps=107
   DinnerWare=264
   Misc=0
   Other=252
   NullCount=0
   Total Found=4366
   TotalGenerated=4366

   Drop Rates
   ----
   Armor= 12.50573%
   MeleeWeapon= 7.352267%
   Caster= 3.595969%
   MissileWeapon= 5.932203%
   Jewelry= 10.10078%
   Gem= 8.474577%
   Clothing= 7.329363%
   Other=5.771873%

   Pets Ratings Stats
   ----
   Over 100 = 0
   Over  90 = 0
   Over  80 = 0
   Over  70 = 1
   Over  60 = 10
   Total Pets Generated = 179

   Mana capacity across all items Min=300  Max=14247 Avg Mana=8442
   Min Items on a corpse = 2, Max Items on coprse = 7


   LootFactory Simulator
   ---------------------
   Loot profile 228 (a Tier 7 profile) from DID 998 was used for creating 1000 corpses.
   A total of 4366 unique items were generated.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2551/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU1NzkyNTYz
title: Magic and Missile Defense Modifier Bonus simplifcation/fix
state: closed
created_at: 2019-12-20T16:07:11Z
updated_at: 2019-12-30T19:33:10Z
closed_at: 2019-12-30T19:33:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2552
type: pull
body:
  Made getting MagicD and MissileD modifier the same across all weapon types.  Also fixes Missile Weapons not receiving a chance of getting a MagicD modifier bonus.

  Also neatened up Melee Factory to comply with StyleCop

  Tested with loot sim to make sure drops are correct.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2552/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU1Nzk4NTI2
title: Removed Regen Cantrips (Retail data doesn't support Regen Cantrips on…
state: closed
created_at: 2019-12-20T16:22:32Z
updated_at: 2019-12-30T19:05:28Z
closed_at: 2019-12-30T19:05:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2553
type: pull
body:
  Removing Regen Cantrips for Health, Stamina, and Mana.  Loot generated Armor should not have them (according to data from retail).

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2553/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU1ODgyNzcx
title: slightly improved corpse positioning for creeping mobs
state: closed
created_at: 2019-12-20T20:03:45Z
updated_at: 2019-12-21T07:05:37Z
closed_at: 2019-12-21T07:05:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2554
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2554/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU1OTgwMzIy
title: fixing issue with Sphere.FindPlacementPos
state: closed
created_at: 2019-12-21T07:49:50Z
updated_at: 2019-12-21T11:23:22Z
closed_at: 2019-12-21T11:23:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2555
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2555/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU1OTg4NTc0
title: fixing generator respawn retries
state: closed
created_at: 2019-12-21T10:08:01Z
updated_at: 2019-12-21T11:28:19Z
closed_at: 2019-12-21T11:28:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2556
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2556/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MDIwMDIy
title: Fix Spell IDs from CreateRandomScroll
state: closed
created_at: 2019-12-21T18:08:38Z
updated_at: 2019-12-22T07:53:03Z
closed_at: 2019-12-22T07:53:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2557
type: pull
body:
  Fixed the following Spell IDs to look up the correct scroll.  The last 2 errors are from invalid weenies (can't create weenie)

  Spell IDs Errors from CreateRandomScroll
  --
  Old Spell ID | Spell | New Spell ID
  1886 | Evaporate Creature Magic Self | 1888
  1892 | Extinguish Creature Magic Self | 1894
  1898 | Cleanse Creature Magic Self | 1900
  1904 | Devour Creature Magic Self | 1906
  1910 | Purge Creature Magic Self | 1912
  1916 | Scroll of Nullify Creature Magic Self | 1918
  1919 | Evaporate Item Magic | 1921
  1925 | Extinguish Item Magic | 1927
  1931 | Cleanse Item Magic | 1933
  1937 | Devour Item Magic | 1939
  1943 | Purge Item Magic | 1945
  1949 | Scroll of Nullify Item Magic | 1951
  1958 | Evaporate Life Magic Self | 1960
  1964 | Extinguish Life Magic Self | 1966
  1970 | Cleanse Life Magic Self | 1972
  1976 | Devour Life Magic Self | 1978
  1982 | Purge Life Magic Self | 1984
  1988 | Scroll of Nullify Life Magic Self | 1990
  5476 | Festering Curse VI | 5376
  5477 | Festering Curse VII | 5377
  5403 | Void Magic Mastery Other I | Bad Weenie 43356
  6110 | Summoning Mastery Other III | Bad Weenie 49465

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2557/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MDMzNDIx
title: adding preliminary support for dual-wielding monsters
state: closed
created_at: 2019-12-21T21:47:48Z
updated_at: 2019-12-31T06:38:39Z
closed_at: 2019-12-31T06:38:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2558
body: This PR builds on https://github.com/ACEmulator/ACE/pull/2560
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2558/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MDQ3ODEz
title: fixing monster special attack fx
state: closed
created_at: 2019-12-22T02:07:11Z
updated_at: 2019-12-22T07:50:11Z
closed_at: 2019-12-22T07:50:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2559
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2559/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MDUxNDEz
title: improved monster combat maneuvers table
state: closed
created_at: 2019-12-22T03:20:53Z
updated_at: 2019-12-31T06:31:32Z
closed_at: 2019-12-31T06:31:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2560
type: pull
body:
  this PR is the base for adding dual wield support for monsters

  also probably fixes a bunch of small issues with monster attack animations

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2560/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MDU1MzYz
title: fixing mobs casting flame wave
state: closed
created_at: 2019-12-22T04:53:41Z
updated_at: 2019-12-26T21:35:13Z
closed_at: 2019-12-26T21:35:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2561
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2561/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MDYwOTk2
title: adding support for EmoteManager.CastSpell untargeted spell projectiles
state: closed
created_at: 2019-12-22T06:47:53Z
updated_at: 2020-11-16T15:04:08Z
closed_at: 2019-12-31T06:39:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2562
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2562/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MTA4Mjgx
title: switch BiotaPropertiesInt to Composite Key
state: closed
created_at: 2019-12-22T17:54:38Z
updated_at: 2020-01-13T13:56:06Z
closed_at: 2020-01-13T13:53:14Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2563
type: pull
body:
  To use ShardDatabaseWIthoutCaching (not recommended unless you really really need this due to EF tracking memory consumption issues)...

  in DatabaseManager.cs
  change this: var shardDb = new ShardDatabase();
  to this: var shardDb = new ShardDatabaseWithoutCaching();

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2563/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2MTY5NDQw
title: re-adding null check for generators
state: closed
created_at: 2019-12-23T04:15:40Z
updated_at: 2019-12-24T00:18:13Z
closed_at: 2019-12-24T00:18:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2564
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2564/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2NTA0OTEw
title: revert creeping mobs
state: closed
created_at: 2019-12-24T03:04:20Z
updated_at: 2019-12-24T04:58:11Z
closed_at: 2019-12-24T04:58:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2565
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2565/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2NTMxMDcy
title: re-add Emote.Move* physics position sync w/ valid rotation check
state: closed
created_at: 2019-12-24T06:00:02Z
updated_at: 2019-12-31T06:39:25Z
closed_at: 2019-12-31T06:39:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2566
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2566/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2NzE3MzY2
title: update spell projectile to use more spell / weenie data
state: closed
created_at: 2019-12-25T01:52:23Z
updated_at: 2019-12-31T06:45:45Z
closed_at: 2019-12-31T06:45:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2567
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2567/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2ODM2NTE0
title: refactoring spell projectiles
state: closed
created_at: 2019-12-25T20:52:18Z
updated_at: 2019-12-31T06:51:41Z
closed_at: 2019-12-31T06:51:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2568
type: pull
body:
  This builds on the previous spell projectile PRs

  This PR refactors and normalizes all of the spell projectile logic into 3 functions: GetProjectileOrigins, GetProjectileVelocity, and LaunchSpellProjectiles

  These functions work for all spell projectile types, and will support spells like 3948 - Flame Wave, which are Ring spells that work more like wall spells, but have a dissipation like Ring spells.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2568/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU2ODY5MTgy
title: ShardDatabaseWithoutCaching
state: closed
created_at: 2019-12-26T04:35:26Z
updated_at: 2019-12-31T13:45:43Z
closed_at: 2019-12-31T13:45:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2569
type: pull
body:
  This makes the legacy code for bypassing EF tracking for non player biotas back into master, and optional.

  This will make it easier for ACE devs to update this legacy code for those servers that still require it, reducing the amount of work they'll have to do to merge to latest when certain schema changes happen.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2569/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU3MTE2MjUw
title: fixing boost variance
state: closed
created_at: 2019-12-27T03:48:35Z
updated_at: 2019-12-28T05:20:47Z
closed_at: 2019-12-28T05:20:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2570
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2570/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU3Mzg5NjYx
title: better usage of body part quadrants for physical attacks
state: closed
created_at: 2019-12-28T04:39:24Z
updated_at: 2019-12-31T06:56:08Z
closed_at: 2019-12-31T06:56:07Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2571
body: Thanks to Moro for helping to figure out some of the data for the body parts tables
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2571/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU3NjE0NDkz
title: improved handling for json weenie metadata
state: closed
created_at: 2019-12-29T05:57:42Z
updated_at: 2019-12-31T07:01:20Z
closed_at: 2019-12-31T07:01:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2572
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2572/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU3NjE5MDU3
title: for built-in weapon spells, use weapon.ItemSpellcraft for target resistance check
state: closed
created_at: 2019-12-29T07:00:19Z
updated_at: 2019-12-31T07:00:40Z
closed_at: 2019-12-31T07:00:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2573
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2573/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4MTk0Nzc3
title: improved /targetloc
state: closed
created_at: 2019-12-30T19:22:47Z
updated_at: 2019-12-31T01:16:51Z
closed_at: 2019-12-31T01:16:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2574
type: pull
body:
  /targetloc developer command now supports specifying an exact guid, in addition to the default mode of last appraised object

  This guid can be a landblock object that is anywhere on the server, and it will find it

  PhysicsObj.CurCell has also been added to the output, and these 2 features will help debug some of the generator issues that CE has been seeing

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2574/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU1NDQwNjY1MjI=
title: Died twice in a row from a single encounter
state: closed
created_at: 2019-12-31T02:17:32Z
updated_at: 2020-08-31T06:30:16Z
closed_at: 2020-08-31T06:30:16Z
author_association: CONTRIBUTOR
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  <!-- Please list the steps to reproduce a bug here -->
  3 Gold Phantos wasps that attacked at once.

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  Chat log:

  Blistered by Gold Phyntos Wasp's lightning, you die!
  You've lost 16,173 Pyreals, your Atlatl, your Diforsa Sollerets, your Ring, and your Great Mana Charge!
  Your corpse is located at (20.5N, 63.9E).
  You've lost 8,087 Pyreals, your Ring, your Gauntlets of Marksmanship, your Bracelet, and your Ring!
  Your corpse is located at (33.5S, 72.7E).


  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->
  In retail sometimes after dying you would end up with a corpse at the lifestone. In this case, one corpse was on the Eastham beach; another the other was at the lifestone. The bad bit here is two deaths, two penalties and two losses of everything. 

  Would like to die only once, and only loose one set of equipment/one vitae. 

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->
  Found on the Levistras server. 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2575/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4MjYwNzA1
title: Removed Unused Pet Var that was causing LinuxCompile Warning
state: closed
created_at: 2019-12-31T02:33:52Z
updated_at: 2019-12-31T02:40:43Z
closed_at: 2019-12-31T02:40:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2576
body: Pet Var removed
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2576/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NDMyMDg4
title: additional logic for repeated appraisals
state: closed
created_at: 2019-12-31T23:03:02Z
updated_at: 2020-01-01T06:10:56Z
closed_at: 2020-01-01T06:10:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2577
type: pull
body:
  This fixes a bug where a successful appraisal could then blip off to an unsuccessful attempt again (possibly automatically, for appraised combat targets)

  With this change, some rate limiting for unsuccessful attempts also needs to be introduced. If a player were to be allowed to spam the server with unsuccessful appraisal attempts in a non-throttled manner, they would be able to get that '1 successful attempt' near instantly, negating most of the appraisal skill check

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2577/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NDQ0NTk2
title: monster combat maneuvers table updates
state: closed
created_at: 2020-01-01T02:35:09Z
updated_at: 2020-01-01T06:11:05Z
closed_at: 2020-01-01T06:11:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2578
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2578/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NDQ5MTIw
title: fixing npk spellcasting lockups
state: closed
created_at: 2020-01-01T04:22:09Z
updated_at: 2020-01-01T06:11:13Z
closed_at: 2020-01-01T06:11:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2579
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2579/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NTE4Njkx
title: updating changelog
state: closed
created_at: 2020-01-01T21:21:24Z
updated_at: 2020-01-01T22:56:05Z
closed_at: 2020-01-01T22:56:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2580
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2580/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NTMwNTg0
title: Change Project order in SLN file
state: closed
created_at: 2020-01-02T00:45:02Z
updated_at: 2020-01-02T00:48:54Z
closed_at: 2020-01-02T00:48:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2581
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2581/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NTYxNDM1
title: adding HasDungeon criteria
state: closed
created_at: 2020-01-02T06:07:19Z
updated_at: 2020-01-02T08:50:57Z
closed_at: 2020-01-02T08:50:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2582
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2582/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4NTY1OTEz
title: re-adding missing .EnqueueAction() to EmoteType.CastSpell
state: closed
created_at: 2020-01-02T06:39:23Z
updated_at: 2020-01-02T07:42:20Z
closed_at: 2020-01-02T07:42:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2583
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4ODczNjg1
title: improved rolling balls of death
state: closed
created_at: 2020-01-03T05:03:14Z
updated_at: 2020-01-04T00:24:21Z
closed_at: 2020-01-04T00:24:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2584
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2584/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4ODkzNzE0
title: update casting negative item spells on items wielded by others
state: closed
created_at: 2020-01-03T07:08:12Z
updated_at: 2020-01-04T00:25:03Z
closed_at: 2020-01-04T00:25:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2585
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2585/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4OTE2NTY4
title: fixing run-around technique in pk spellcasting
state: closed
created_at: 2020-01-03T09:00:05Z
updated_at: 2020-01-04T00:25:22Z
closed_at: 2020-01-04T00:25:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2586
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2586/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU4OTI3Nzk1
title: fixing combat pet maneuvers
state: closed
created_at: 2020-01-03T09:42:53Z
updated_at: 2020-01-04T00:25:33Z
closed_at: 2020-01-04T00:25:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2587
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2587/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5MDE2OTQ4
title: Support application startup from outside directory
state: closed
created_at: 2020-01-03T15:00:43Z
updated_at: 2020-01-04T02:06:23Z
closed_at: 2020-01-04T02:05:52Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2588
type: pull
body:
  In current master, on a windows platform, ACE requires the current environment directory to be the same location that the ACE.Server.exe (.NET core 3.1) exists.

  If you try to startup the application from an outside directory, the Config.js and log4net.config will not be found as only the Environment.CurrentDirectory were searched.

  Now, that directory is searched first. If the files are not found, the ExecutingAssembly Location is searched next.

  This needs to be tested on Linux.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5MTc0MTU5
title: update ring projectile spawn position to match retail
state: closed
created_at: 2020-01-04T02:16:19Z
updated_at: 2020-01-04T07:29:19Z
closed_at: 2020-01-04T07:29:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2589
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2589/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5MzA4Mzk1
title: Fix user supplied path for Config.js
state: closed
created_at: 2020-01-05T14:52:15Z
updated_at: 2020-01-05T23:27:49Z
closed_at: 2020-01-05T23:25:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2590
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2590/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5MzE4NjYx
title: More verbose retransmit logging
state: closed
created_at: 2020-01-05T17:04:00Z
updated_at: 2020-01-06T13:58:31Z
closed_at: 2020-01-06T13:57:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2591
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5MzY4MDc5
title: [WIP] .NET Entity Framework Core 3.1 support
state: closed
created_at: 2020-01-06T02:39:46Z
updated_at: 2020-11-15T15:58:33Z
closed_at: 2020-11-15T15:42:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2592
type: pull
body:
  This builds on #2329 and #2563 
  When the above PR's are merged, the Files changed in this PR will shrink.

  One of the biggest breaking changes in EF Core 3.0+ is existing LINQ queries like .Include() are no longer evaluated client-side. They now can result in explosive joins. This issue is documented here: https://github.com/aspnet/EntityFrameworkCore/issues/18022

  For the above reason, many heavy .Include() queries have now been rewritten per the updated advice from one of the core EF Contributors using this example: https://gist.github.com/smitpatel/d4cb3619e5b33e8d9ea24d3f2a88333a

  Furthermore, this PR has the following changes.

  Resilient Connections have been added.
  https://docs.microsoft.com/en-us/dotnet/architecture/microservices/implement-resilient-applications/implement-resilient-entity-framework-core-sql-connections
  https://docs.microsoft.com/en-us/ef/core/miscellaneous/connection-resiliency

  PlayerManager Initialize now uses Parallel. This will greatly speed up PlayerManager loading on larger servers.

  This PR needs some testing on development servers.
  I do NOT recommend this be run on production yet.

  There are still more raw sql statements that must be tested, and other systems that use dbcontexts must also be examined.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2592/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5NTIwNTYx
title: _spell was null Error -> Debug
state: closed
created_at: 2020-01-06T12:19:55Z
updated_at: 2020-01-06T12:58:17Z
closed_at: 2020-01-06T12:58:01Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2593
body: 0x8000+ cooldown spells
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2593/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5NTIwNjA5
title: Update default dats path on windows
state: closed
created_at: 2020-01-06T12:20:04Z
updated_at: 2020-01-22T20:43:28Z
closed_at: 2020-01-22T20:43:16Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2594
type: pull
body:
  This lines up with the ACE install on windows wiki. I've seen others using the same directory structure as well before this documentation update:

  https://github.com/ACEmulator/ACE/wiki/ACE-Hosting-Windows

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2594/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5NTIwNjU2
title: Update Readmes
state: closed
created_at: 2020-01-06T12:20:16Z
updated_at: 2020-01-22T20:42:56Z
closed_at: 2020-01-22T20:42:48Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2595
type: pull
body:
  With the Wiki updated, we can condense the readme and link to appropriate wiki sections.

  The wiki has pages separate for windows/linux, so a linux specific readme is no longer required.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2595/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5NTI1MTA1
title: Database Logging
state: closed
created_at: 2020-01-06T12:35:02Z
updated_at: 2020-01-06T12:58:27Z
closed_at: 2020-01-06T12:57:46Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2596
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2596/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzU5NTQyNDA2
title: adding NumProjectiles verification
state: closed
created_at: 2020-01-06T13:26:16Z
updated_at: 2020-01-06T23:46:05Z
closed_at: 2020-01-06T23:46:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2597
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYwMjg1MDA3
title: spell casting accuracy improvements for pk/pkl
state: closed
created_at: 2020-01-08T05:12:18Z
updated_at: 2020-03-09T09:11:05Z
closed_at: 2020-03-09T09:11:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2598
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2598/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYwNjEzNjE5
title: Fix issue with VerifyUse
state: closed
created_at: 2020-01-08T19:17:52Z
updated_at: 2020-01-15T04:48:20Z
closed_at: 2020-01-15T04:47:16Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2599
type: pull
body:
  http://acpedia.org/wiki/The_Moars

  Use the Emerald Clasp on the Adjanite Gem to create Decorated Adjanite Gem.

  Both objects are contained but Clasp has ItemUseable.SourceContainedTargetRemote flag, was also this way EoR

  https://github.com/ACEmulator/ACE-World-16PY/blob/master/Database/3-Core/4%20CraftTable/SQL/04774%20Decorated%20Adjanite%20Gem.sql

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2599/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYxMDg4MTE4
title: adding /getinfo command to get basic weenie info
state: closed
created_at: 2020-01-09T18:04:20Z
updated_at: 2020-01-17T09:36:53Z
closed_at: 2020-01-17T09:36:53Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2600
type: pull
body:
  This command was requested by content devs, so they don't have to go searching through /propertydump

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2600/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYxMzIxNjQw
title: improving /createinst command for content dev
state: closed
created_at: 2020-01-10T07:54:30Z
updated_at: 2020-01-17T09:39:40Z
closed_at: 2020-01-17T09:39:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2601
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2601/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYxNzYyODc2
title: Reorder Contract Flag staging
state: closed
created_at: 2020-01-11T20:36:23Z
updated_at: 2020-01-15T04:48:19Z
closed_at: 2020-01-13T08:28:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2602
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2602/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYxODcwNTk2
title: remove network test helpers
state: closed
created_at: 2020-01-12T21:01:14Z
updated_at: 2020-01-19T17:52:59Z
closed_at: 2020-01-19T17:52:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2603
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2603/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYxOTc5MTMz
title: Enforce quest timers for Portal.QuestRestriction
state: closed
created_at: 2020-01-13T07:53:10Z
updated_at: 2020-01-15T04:48:18Z
closed_at: 2020-01-15T04:47:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2604
type: pull
body:
  Some portals have quests that require reflagging after the flag "expires" based on quest definitions for max solves and min delta

  Haunted Mansion, Aug Gem/Bellas are examples

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2604/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYxOTgxOTAx
title: Add/Adjust some Emote handling
state: closed
created_at: 2020-01-13T08:00:37Z
updated_at: 2020-01-15T04:49:35Z
closed_at: 2020-01-13T08:29:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2605
type: pull
body:
  - Wired up AdminSpam and BLog for assumed alert/logging
  - Wired up InqBoolStat based on emote tester npc from 16py

  Not sure if TestNoQuality is used for any other Inqs, seems like if it is, it would have to be cascading based on existing emotes: 

  InqXStat
  Success, goto TestSuccess
  Fail, If null goto TestNoQuality only if defined, else goto TestFailure?

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2605/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyMDQxMjA3
title: removing cooldown spell message from log during dispel
state: closed
created_at: 2020-01-13T10:29:30Z
updated_at: 2020-01-14T07:38:03Z
closed_at: 2020-01-14T07:38:02Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2606
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2606/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyMDc0Mzg2
title: matching TakeItems stackSize default value up to other emotes
state: closed
created_at: 2020-01-13T11:43:10Z
updated_at: 2020-01-16T08:29:52Z
closed_at: 2020-01-16T08:29:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2607
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2607/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyMDgzNTU0
title: updating default values for range and increment/decrement
state: closed
created_at: 2020-01-13T12:07:07Z
updated_at: 2020-01-21T11:01:30Z
closed_at: 2020-01-21T11:01:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2608
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2608/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyMDgzNjIy
title: updating SpendLuminance to use HeroXP64
state: closed
created_at: 2020-01-13T12:07:17Z
updated_at: 2020-01-14T07:38:19Z
closed_at: 2020-01-14T07:38:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2609
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2609/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyNDM4OTQ3
title: adding support for SpellFlags.IgnoresManaConversion
state: closed
created_at: 2020-01-14T04:33:31Z
updated_at: 2020-01-14T07:38:32Z
closed_at: 2020-01-14T07:38:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2610
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2610/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyNDQ1NzY3
title: adding support for SpellFlags.NotIndoor / SpellFlags.NotOutdoor
state: closed
created_at: 2020-01-14T05:02:36Z
updated_at: 2020-01-15T11:56:06Z
closed_at: 2020-01-15T11:56:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2611
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2611/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MzYyNDcyNjE0
title: improved peturbation formula
state: closed
created_at: 2020-01-14T06:46:23Z
updated_at: 2020-01-15T11:56:15Z
closed_at: 2020-01-15T11:56:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2612
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2612/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


