# issues

node_id: MDExOlB1bGxSZXF1ZXN0MjU0NDI2MjAw
title: Fix bugs in showstats and RemoveItemSpell
state: closed
created_at: 2019-02-19T22:05:24Z
updated_at: 2019-02-22T14:58:33Z
closed_at: 2019-02-19T23:05:45Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1454
type: pull
body:
  - Add three null checks in EnchantmentManager.cs
  - Add null check to showstats, in DeveloperCommands.cs
  - Correct the enchantments sent for removal from items, in Creature_Magic.cs, to those of on items

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTI2OTk2NjU=
title: Sentry NPC runs in quick circles
state: closed
created_at: 2019-02-21T00:58:29Z
updated_at: 2019-03-29T07:48:40Z
closed_at: 2019-03-29T07:48:40Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Sentry NPC run's in quick circles, abnormal behavior

  https://megaupload.nz/AdG495u4bc/Asheron_s_Call_2019-02-20_19-51-16_mp4

  Your location is: 0xAAB30004 [4.926544 83.786240 116.005005] 0.756161 0.000000 0.000000 -0.654385

  ### The log given by the failure.

  ### Desired functionality.

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTI2OTk5OTE=
title: Translator Aun Loakhe wrong emote
state: closed
created_at: 2019-02-21T01:00:02Z
updated_at: 2019-02-22T05:35:19Z
closed_at: 2019-02-22T05:35:19Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Translator Aun Loakhe

  https://imgur.com/a/4W6roJE

  Your location is: 0xC6A9001B [94.144722 62.909084 71.173004] 0.636468 0.000000 0.000000 0.77130

  ### The log given by the failure.

  ### Desired functionality.
  He should be banging his drum, not doing snowflake emote

  ### Mention any other details that might be useful.
  https://asheron.fandom.com/wiki/Translator_Aun_Laokhe

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTI3MDEyNTM=
title: Spell/Healing Movement Changes to Match Retail
state: closed
created_at: 2019-02-21T01:06:00Z
updated_at: 2019-03-02T08:16:35Z
closed_at: 2019-03-02T08:16:35Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [] bug report -> please search issues before submitting
  - [X] feature request
  ```

  ### Repro steps.

  ### The log given by the failure.

  ### Desired functionality.

  Spell / Healing movement checks should only be done when a player is pk/pkl. Not when npk

  Instead of saying you have moved too far in yellow at the top, this should be removed and the text "Your movement disrupted spellcasting!" or "Your movement disrupted healing!" should display in blue chat. 

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU0ODc2MTY0
title: unknown creature part -> evade
state: closed
created_at: 2019-02-21T03:39:53Z
updated_at: 2019-02-22T05:31:41Z
closed_at: 2019-02-22T05:31:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1458
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTI3NDg0NjI=
title: Configurable Chat Message On Login
state: closed
created_at: 2019-02-21T04:53:47Z
updated_at: 2019-04-02T09:49:56Z
closed_at: 2019-03-07T03:56:08Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```

  ### Repro steps.

  ### The log given by the failure.

  ### Desired functionality.

  The configurable 'Welcome' variable in config.js currently allows you to set a custom message in the welcome pop-up message that is displayed the first time a new character logs into the world. 

  I propose a new configurable variable in config.js that would allow the server operator to set a message to displayed in the chat box for existing users when they login to the world. This would replace or append the current hard coded message of "Welcome to Asheron's Call powered by ACEmulator For more information on commands supported by this server, type @acehelp"

  The use case for this would allow a server operator to set varying messages such as server version, scheduled downtime notices/news and any other pertinent information they would want existing characters to see in the chat box upon first logging into the world.

  Another option would be to use the current 'Welcome' variable, but to change it's functionality from displaying the custom message in the welcome pop-up message to the chat box so that existing users would also see it.

  Thanks for your consideration

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTI5NjE1MzY=
title: Server Crash - Object reference not set to an instance of an object
state: closed
created_at: 2019-02-21T14:47:29Z
updated_at: 2019-03-01T15:22:38Z
closed_at: 2019-03-01T15:22:38Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Drudge Hideout

  Your location is: 0x019E0118 [10.002605 -35.423862 0.005000] 1.000000 0.000000 0.000000 0.000000

  ### The log given by the failure.
  DEBUG (ACE.Server.Managers.WorldManager) GetPossessedBiotasInParallel for Ohai took 1,069 ms
  2019-02-21 09:41:40,958 [World Manager] ERROR (ACE.Server.Program) System.NullReferenceException: Object reference not set to an instance of an object.
     at ACE.Server.Managers.EnchantmentManager.GetEnchantments(MagicSchool magicSchool) in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Managers\EnchantmentManager.cs:line 87
     at ACE.Server.Network.Structure.AppraiseInfo.AddSpells(List`1 activeSpells, WorldObject worldObject, WorldObject wielder) in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Network\Structure\AppraiseInfo.cs:line 233
     at ACE.Server.Network.Structure.AppraiseInfo..ctor(WorldObject wo, Player examiner, Boolean success) in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Network\Structure\AppraiseInfo.cs:line 89
     at ACE.Server.Network.GameEvent.Events.GameEventIdentifyObjectResponse..ctor(Session session, WorldObject obj, Boolean success) in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Network\GameEvent\Events\GameEventIdentifyObjectResponse.cs:line 10
     at ACE.Server.WorldObjects.Player.Examine(WorldObject obj) in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\WorldObjects\Player.cs:line 356
     at ACE.Server.WorldObjects.Player.ExamineObject(UInt32 objectGuid) in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\WorldObjects\Player.cs:line 334
     at ACE.Server.Entity.Actions.ActionEventDelegate.Act() in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Entity\Actions\ActionEventDelegate.cs:line 16
     at ACE.Server.Entity.Actions.ActionQueue.RunActions() in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Entity\Actions\ActionQueue.cs:line 21
     at ACE.Server.Managers.WorldManager.DoSessionWork() in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:line 587
     at ACE.Server.Managers.WorldManager.UpdateWorld() in C:\Users\vmware\Downloads\ACE-master (3)\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:line 416
     at System.Threading.Thread.ThreadMain_ThreadStart()
     at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  --- End of stack trace from previous location where exception was thrown ---
     at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  2019-02-21 09:41:59,221 [47] INFO  (ACE.Server.Network.Session) Session dropped. Account: censored, Player: +Ohai, Reason: PacketHeader Disconnect
  2019-02-21 09:41:59,224 [47] DEBUG (ACE.Server.Managers.WorldManager) Removing session for censoredip:60641 with id 0

  ### Desired functionality.

  ### Mention any other details that might be useful.
  Video of crash, can reproduce on demand
  https://megaupload.nz/R8n7D0u0b3/Asheron_s_Call_2019-02-21_09-41-27_mp4

  Tested on commit #1454 and ACE World Database v0.9.18

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU1NDI3NzYw
title: February Changelog Updates
state: closed
created_at: 2019-02-22T15:10:07Z
updated_at: 2019-02-23T07:04:45Z
closed_at: 2019-02-23T01:14:14Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1461
body: - Update changelog
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU1NTc1NDY1
title: ensuring monsters can damage target
state: closed
created_at: 2019-02-23T00:50:49Z
updated_at: 2019-02-28T06:45:17Z
closed_at: 2019-02-28T06:45:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1462
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU1NTkzMjg1
title: Enable InqOwnItems
state: closed
created_at: 2019-02-23T05:51:58Z
updated_at: 2019-02-27T23:18:40Z
closed_at: 2019-02-23T07:55:45Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1463
type: pull
body:
  - Enable basic functionality for InqOwnItems in EmoteManager, with code suggested by gmriggs
  - Fix array indexing in LootHelper ( array indexes begin with 0 )

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTM3MDE2ODk=
title: No message when salvaging
state: closed
created_at: 2019-02-23T14:36:28Z
updated_at: 2019-03-02T08:16:19Z
closed_at: 2019-03-02T08:16:19Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Salvage an item
  No message about the salvaging taking place

  ### The log given by the failure.

  ### Desired functionality.
  When you salvage an item/items you should receive a green message in the chat box similar to, 

  "You obtain 11 Bronze (ws 9.00) using your knowledge of Salvaging."

  If a tinkering skill is used instead of salvaging, it should say something similar to, 

  "You obtain 11 Bronze (ws 9.00) using your knowledge of Weapon Tinkering."

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU1NjI2Mzkw
title: LootGenFactory exception fixes
state: closed
created_at: 2019-02-23T17:12:20Z
updated_at: 2019-02-23T19:25:39Z
closed_at: 2019-02-23T19:25:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1465
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU1NjQwNjc5
title: DirectBroadcast Update
state: closed
created_at: 2019-02-23T21:24:28Z
updated_at: 2019-02-27T23:18:39Z
closed_at: 2019-02-24T16:58:34Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1466
type: pull
body:
  - Update EmoteType.DirectBroadcast to support "&lt;questname&gt;@You must wait %CDtime to collect the &lt;quest item&gt; again."

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1466/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU1NzU1NDEw
title: updating item dispel
state: closed
created_at: 2019-02-25T04:42:28Z
updated_at: 2019-10-23T05:12:57Z
closed_at: 2019-02-25T07:32:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1467
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1467/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU2MTE1MjM2
title: Update account authentication to use BCrypt.
state: closed
created_at: 2019-02-26T02:06:07Z
updated_at: 2019-03-08T19:41:24Z
closed_at: 2019-03-08T19:41:24Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1468
type: pull
body:
  This updates/simplifies account authentication to use the BCrypt hashing algorithm in place of SHA512 and the need for a separate password salt.

  Not only is BCrypt more secure than SHA512 since it uses a "Work Factor" to discourage password brute force attacks but the implementation is much cleaner overall since the salt is randomly generated and added as part of the password hash itself, effectively protecting against rainbow table attacks.

  The default Work Factor is set to 10 which is considered the current industry standard. A server owner can easily increase this value to whatever level of security they desire which in turn will make password verification slower and much harder to crack if ever brute forced by a hacker.

  Furthermore, BCrypt is used in PHP's passwordHash() function so this change will open up many more account management possibilities through PHP registration scripts, especially CMS's and database bridging.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU2Mjg5NTI4
title: Mag-nus changelogs
state: closed
created_at: 2019-02-26T13:47:25Z
updated_at: 2019-02-26T16:37:39Z
closed_at: 2019-02-26T14:21:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1469
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTQ3NTQwNzY=
title: Restored admin characters don't display "+" in character list
state: closed
created_at: 2019-02-26T18:27:53Z
updated_at: 2019-03-11T03:23:31Z
closed_at: 2019-03-11T03:23:31Z
author_association: COLLABORATOR
state_reason: completed
type: issue
body:
  ### Bug Report

  ### Repro steps.
  - Create an admin character (that is, a character with a PLUS in front of their name)
  - Delete the character in the character select screen.
  - Restore the character. The name will not display the "+" until you logout/log back in. (Verified with logs that the CharacterGenerationVerificationResponseEvent / 0xF643 does not send the "+" in the response)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1470/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU2NDAyMzU2
title: Add created IP address and time data for accounts.
state: closed
created_at: 2019-02-26T18:48:10Z
updated_at: 2019-06-12T02:44:04Z
closed_at: 2019-06-12T02:44:04Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1471
body: This adds the clients IP address and creation time to the Auth DB account table.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU2NTk3MDYw
title: Adding Linux installation instructions
state: closed
created_at: 2019-02-27T09:16:59Z
updated_at: 2019-03-01T08:33:00Z
closed_at: 2019-03-01T08:33:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1472
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTUyMDY1NjI=
title: Mobs don't aggro if you don't move
state: closed
created_at: 2019-02-27T16:16:01Z
updated_at: 2019-03-02T08:16:04Z
closed_at: 2019-03-02T08:16:04Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Kill a spawn of mobs
  Stand still while waiting for respawn
  Mobs will respawn and not attack you until you move or attack them.

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  Mobs should aggro/attack regardless if you are standing still or not

  ### Mention any other details that might be useful.
  https://imgur.com/a/wCNVpsn

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1473/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3MzYyNjk4
title: Updating February changelog
state: closed
created_at: 2019-03-01T08:47:04Z
updated_at: 2019-03-01T14:06:11Z
closed_at: 2019-03-01T14:06:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1474
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTYwMDE5MDY=
title: Reproducible Hour Glass - Spellbook
state: closed
created_at: 2019-03-01T08:56:00Z
updated_at: 2019-03-01T15:10:40Z
closed_at: 2019-03-01T15:10:40Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Login with any character that has spells
  Open spellbook
  Right click a spell to ID it
  ID window works correctly, however your cursor will turn into a permanent hourglass until you relog. 

  ### The log given by the failure.

  ### Desired functionality.
  IDing a spell in your spellbook shouldn't give you hourglass

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1475/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3MzkzNjk0
title: Fix appraisal when objectGuid = 0
state: closed
created_at: 2019-03-01T10:30:49Z
updated_at: 2019-03-01T15:10:41Z
closed_at: 2019-03-01T15:10:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1476
body: This resolves https://github.com/ACEmulator/ACE/issues/1475
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1476/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NDE0MjAz
title: Adding monster spawning aggro
state: closed
created_at: 2019-03-01T11:39:49Z
updated_at: 2019-03-02T08:16:04Z
closed_at: 2019-03-02T08:16:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1477
body: This resolves https://github.com/ACEmulator/ACE/issues/1473
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NDIyODEz
title: fixed logic of the configuration file format runtime upgrade/patcher
state: closed
created_at: 2019-03-01T12:12:18Z
updated_at: 2019-03-01T20:29:18Z
closed_at: 2019-03-01T14:17:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1478
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NDc0OTM3
title: Adding salvaging output messages
state: closed
created_at: 2019-03-01T15:03:48Z
updated_at: 2019-03-02T08:16:19Z
closed_at: 2019-03-02T08:16:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1479
body: This resolves https://github.com/ACEmulator/ACE/issues/1464
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NDc2MDM0
title: checking for unknown spells in EnchantmentManager
state: closed
created_at: 2019-03-01T15:06:53Z
updated_at: 2019-03-01T15:22:38Z
closed_at: 2019-03-01T15:22:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1480
type: pull
body:
  This resolves https://github.com/ACEmulator/ACE/issues/1460 and prevents the crash from a possible data issue, although we have been unable to repro the bug to find how it happened

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1480/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NTg4NTE4
title: Updating spellcasting / healing movement check messages to match retail
state: closed
created_at: 2019-03-01T21:31:45Z
updated_at: 2019-03-02T08:16:27Z
closed_at: 2019-03-02T08:16:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1481
body: This addresses https://github.com/ACEmulator/ACE/issues/1457
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1481/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NjUyMjg5
title: Add War/Void Scrolls and Essences to loot gen
state: closed
created_at: 2019-03-02T08:53:42Z
updated_at: 2019-03-12T22:46:03Z
closed_at: 2019-03-03T22:47:46Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1482
type: pull
body:
  - Add War/Void scrolls to loot gen
  - Remove spell scroll loot gen from Mundane loot creation
  - Add summoning Essences

  - Note: Should be paired with World database v0.9.21 to not corrupt Shard database from bad PetDevice weenies https://ci.appveyor.com/api/buildjobs/e5llg8rhlgyoqu89/artifacts/ACE-World-Database-v0.9.21-thjmgojj.sql.zip

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1482/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NjU0Njk3
title: Adding magic professor emotes
state: closed
created_at: 2019-03-02T09:46:20Z
updated_at: 2019-03-02T19:51:15Z
closed_at: 2019-03-02T19:51:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1483
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTYzODE2NzQ=
title: Teleporting to a player in a different landblock always shows them standing
state: closed
created_at: 2019-03-02T10:06:02Z
updated_at: 2019-03-05T13:20:41Z
closed_at: 2019-03-05T13:20:41Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Create a character in shoushi
  Lay down
  Create a character on a second account/client in Holtburg
  Teleto player in shoushi

  The character in shoushi will appear standing instead of laying down

  On the second character if you do any sort of interaction or even just type a message in the chat, the first character will appear laying down like it should. This also seems to not happen if you teleto a player in the same landblock or if you had interacted with the player before. Only reproducible if the characters are in different landblocks to start.

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  Character should display laying down when you first teleport to them instead of standing

  ### Mention any other details that might be useful.
  Character 1: https://imgur.com/a/fMWhPXl
  Character 2: https://imgur.com/a/1HJKdtg

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1484/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NjU2ODQ0
title: Cleaning up welcome message / server motd
state: closed
created_at: 2019-03-02T10:32:18Z
updated_at: 2019-03-05T20:15:46Z
closed_at: 2019-03-05T20:15:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1485
type: pull
body:
  This addresses https://github.com/ACEmulator/ACE/issues/1459

  This normalizes some of the config settings for welcome message / server motd

  Note that 'Welcome' stored in Config.js is now deprecated, as Config.js should only be used to store config settings that are required to start the server

  The declaration and default values for runtime config properties are shown in PropertyManager.cs. If the server operator would like to change the welcome_msg or server_motd, the following commands should be used:

  /modifystring server_motd "Welcome to the custom server!\nHave fun"

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTY0MjM5MDc=
title: character death results in character corpse appearing at the lifestone
state: closed
created_at: 2019-03-02T18:07:25Z
updated_at: 2019-03-02T19:53:02Z
closed_at: 2019-03-02T19:52:11Z
author_association: COLLABORATOR
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro Steps

  1. create a new melee character starting in Shoushi
  2. pick up and equip all the leather freebie/tutorial items, quick exit the TA
  3. equip the academy coat
  4. upgrade and equip the starter melee weapon
  5. murder "a few" mobs in the immediate newb area
  6. enter Shreth Hive [32.4S, 71.0E], immediate newb area,
  7. character slain while responding via starter melee weapon to an attacking drudge at the hot drop

  ### Mention any other details that might be useful.
  * It happened once during the conditions resulting from the repro steps.
  * Subsequent reproduction attempt failed with the same character.
  * Reproduction attempt failed with a new character.
  * Bug appears to be rare.
  * It's possible that most of the repro sequence detail can be reduced away.
  * Latest master branch
  * Latest bleeding edge World DB has Arwic professors of Magic and facility hub spawns: https://ci.appveyor.com/api/buildjobs/g8s0xyq9q03a7rr5/artifacts/ACE-World-Database-v0.9.20-nvjslhbk.sql.zip


  "Did you get express corpse delivery with your insurance package?"

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1486/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3Njg2NzUy
title: removing debug code for untargeted spell casts
state: closed
created_at: 2019-03-02T19:31:33Z
updated_at: 2019-03-02T19:39:30Z
closed_at: 2019-03-02T19:39:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1487
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1487/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3Njg3ODk0
title: ensuring player death sequence
state: closed
created_at: 2019-03-02T19:49:22Z
updated_at: 2019-03-02T19:52:00Z
closed_at: 2019-03-02T19:52:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1488
body: This patch addresses https://github.com/ACEmulator/ACE/issues/1486
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3NzI3NzY3
title: cleaning up scatter position after initial spawn
state: closed
created_at: 2019-03-03T10:51:19Z
updated_at: 2019-03-04T03:43:58Z
closed_at: 2019-03-04T03:43:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1489
body: This fixes a bug with picking up items spawned by scatter generators, and then later dropping them
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3Nzc3ODk0
title: Disable Portal Debbuging Messages and two fixes
state: closed
created_at: 2019-03-03T23:34:48Z
updated_at: 2019-03-12T22:46:00Z
closed_at: 2019-03-05T18:30:49Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1490
type: pull
body:
  - Disable Portal Debugging Messages
  - Fix Loot Array Matrices for weapon type selection 
  - Add six null protections in LootGen code
  - Adjust down the drop percentages for essences and spell scrolls

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1490/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU3OTA5ODk3
title: Adding substates to CurrentMotionState
state: closed
created_at: 2019-03-04T11:37:36Z
updated_at: 2019-03-05T13:20:41Z
closed_at: 2019-03-05T13:20:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1491
body: This resolves https://github.com/ACEmulator/ACE/issues/1484
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1491/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU4MDczMTAy
title: Adding summoned creature ratings
state: closed
created_at: 2019-03-04T20:08:35Z
updated_at: 2019-03-05T13:20:49Z
closed_at: 2019-03-05T13:20:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1492
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1492/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU4Mzg4NTU5
title: Reuse available Dynamic GUIDs
state: closed
created_at: 2019-03-05T16:16:02Z
updated_at: 2019-03-08T02:18:44Z
closed_at: 2019-03-08T02:17:43Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1493
type: pull
body:
  On ACE startup, the shard database is queried for available id's in the dynamic guid range.

  This helps further reduce (max + 1) id allocation.

  It's a bit premature, but, based on current architecture, I don't know if we'll ever need to do a id defragment.

  A requirement of this method is that ace_world may only contain guids in the static range.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1493/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU4NDUzMjIw
title: Adding AugmentationDevice
state: closed
created_at: 2019-03-05T19:17:47Z
updated_at: 2019-03-07T03:48:15Z
closed_at: 2019-03-07T03:48:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1494
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1494/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU4Nzc5NDQw
title: Adding ready substate
state: closed
created_at: 2019-03-06T16:02:01Z
updated_at: 2019-03-07T03:48:26Z
closed_at: 2019-03-07T03:48:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1495
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1495/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTc5MDIxMjA=
title: Teleport player to you command request
state: closed
created_at: 2019-03-06T16:41:35Z
updated_at: 2019-03-07T03:48:35Z
closed_at: 2019-03-07T03:48:35Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```

  ### Repro steps.
  I would like to request that a command to teleport a player to you be added.

  Right now we have /teleto which teleports you to a player
  and
  /teleallto which teleports all players on the server to you.

  Would like to a see a command that would teleport a singler player to you. Could be something like, /teletome

  ### The log given by the failure.


  ### Desired functionality.


  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU4ODA1MzM1
title: Adding /teletome
state: closed
created_at: 2019-03-06T17:07:49Z
updated_at: 2019-03-07T03:48:35Z
closed_at: 2019-03-07T03:48:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1497
body: This resolves https://github.com/ACEmulator/ACE/issues/1496
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1497/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU4OTQ5MjYx
title: Adding natural resistances for players
state: closed
created_at: 2019-03-07T02:18:10Z
updated_at: 2019-03-09T21:11:02Z
closed_at: 2019-03-09T21:11:02Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1498
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1498/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5MTczNjQx
title: Dont persist missiles to shard
state: closed
created_at: 2019-03-07T16:07:17Z
updated_at: 2019-03-08T02:18:32Z
closed_at: 2019-03-08T02:17:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1499
body: Also adds logging to detect other missiles that are getting around the WeenieType check.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1499/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTg1NTE3NTU=
title: Items show +0% Mana Conversion
state: closed
created_at: 2019-03-07T22:52:04Z
updated_at: 2019-12-14T23:10:15Z
closed_at: 2019-12-14T23:05:17Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  https://imgur.com/a/g40X3wA

  ### The log given by the failure.

  ### Desired functionality.
  Item should just not have a mana conversion bonus at all instead of displaying +0%

  ### Mention any other details that might be useful.
  Commit #1497 ACEWorldDatabase v0.9.22

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1500/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTg1NjA1MzU=
title: Level 1 Scrolls Should Not Require Trained Skill
state: closed
created_at: 2019-03-07T23:20:35Z
updated_at: 2019-03-08T05:27:37Z
closed_at: 2019-03-08T05:27:37Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Try to learn a level 1 scroll that you don't have the magic school trained

  ### The log given by the failure.

  ### Desired functionality.
  Level 1 scrolls should not require the magic school to be trained to learn. Just as level 7 and 8 scrolls.

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5MzI1NDY4
title: Adjusting training check for reading scrolls
state: closed
created_at: 2019-03-08T00:57:11Z
updated_at: 2019-03-26T15:44:49Z
closed_at: 2019-03-08T05:27:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1502
body: This resolves https://github.com/ACEmulator/ACE/issues/1501
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1502/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5Mzg0NTM5
title: LootGenerationFactory Pass 4
state: closed
created_at: 2019-03-08T07:18:48Z
updated_at: 2019-03-12T22:45:58Z
closed_at: 2019-03-11T00:40:18Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1503
body: - More refactoring of LootGenerationFactory code
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NTQ3NzU4
title: Corrected DatDatabaseType values
state: closed
created_at: 2019-03-08T17:23:11Z
updated_at: 2020-06-15T20:59:09Z
closed_at: 2019-03-09T00:05:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1504
body: Language and Highres were incorrectly set in DatDatabaseType
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1504/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NTg5MzI2
title: Exclude GamePiece from Shard DB
state: closed
created_at: 2019-03-08T19:56:27Z
updated_at: 2019-03-30T18:03:18Z
closed_at: 2019-03-09T01:15:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1505
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1505/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NjQxNzAx
title: Change BCrypt WorkFactor to configurable Option in Config.js
state: closed
created_at: 2019-03-08T23:49:07Z
updated_at: 2019-03-30T18:03:17Z
closed_at: 2019-03-10T01:52:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1506
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1506/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MTkwMTU5MzU=
title: Server Crash - Logging off while in fellowship
state: closed
created_at: 2019-03-09T01:14:56Z
updated_at: 2019-03-09T21:11:19Z
closed_at: 2019-03-09T21:11:19Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Login character 1, create fellow and turn on vtank
  Login character 2, turn on vtank, message character 1 'xp' to be accepted into fellow
  Close client on character 1
  Server crashes

  ### The log given by the failure.
  2019-03-09 04:10:18,128 ERROR: System.ArgumentException: An item with the same key has already been added. Key: 1342177300
     at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
     at ACE.Server.Entity.Fellowship.QuitFellowship(Player player, Boolean disband) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Entity\Fellowship.cs:line 162
     at ACE.Server.WorldObjects.Player.LogOut(Boolean clientSessionTerminatedAbruptly) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\WorldObjects\Player.cs:line 519
     at ACE.Server.Network.Session.LogOffPlayer() in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Network\Session.cs:line 190
     at ACE.Server.Network.Session.DropSession(String reason) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Network\Session.cs:line 247
     at ACE.Server.Managers.WorldManager.ProcessPacket(ClientPacket packet, IPEndPoint endPoint, IPEndPoint listenerEndpoint) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:line 165
     at ACE.Server.Network.ConnectionListener.OnDataReceieve(IAsyncResult result) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Network\ConnectionListener.cs:line 101
     at System.Net.LazyAsyncResult.Complete(IntPtr userToken)
     at System.Net.ContextAwareResult.CompleteCallback()
     at System.Net.ContextAwareResult.<>c.<Complete>b__15_0(Object s)
     at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  --- End of stack trace from previous location where exception was thrown ---
     at System.Net.ContextAwareResult.Complete(IntPtr userToken)
     at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result, IntPtr userToken)
     at System.Net.Sockets.BaseOverlappedAsyncResult.CompletionCallback(Int32 numBytes, SocketError errorCode)
     at System.Net.Sockets.OverlappedAsyncResult.CompletionCallback(Int32 numBytes, Byte[] socketAddress, Int32 socketAddressSize, SocketFlags receivedFlags, SocketError errorCode)
     at System.Net.Sockets.SocketAsyncContext.BufferMemoryReceiveOperation.InvokeCallback(Boolean allowPooling)
     at System.Net.Sockets.SocketAsyncContext.OperationQueue`1.ProcessAsyncOperation(TOperation op)
     at System.Net.Sockets.SocketAsyncContext.OperationQueue`1.<>c.<.cctor>b__18_0(Object op)
     at System.Threading.ThreadPoolWorkQueue.Dispatch()

  Unhandled Exception: System.ArgumentException: An item with the same key has already been added. Key: 1342177300
     at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
     at ACE.Server.Entity.Fellowship.QuitFellowship(Player player, Boolean disband) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Entity\Fellowship.cs:line 162
     at ACE.Server.WorldObjects.Player.LogOut(Boolean clientSessionTerminatedAbruptly) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\WorldObjects\Player.cs:line 519
     at ACE.Server.Network.Session.LogOffPlayer() in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Network\Session.cs:line 190
     at ACE.Server.Network.Session.DropSession(String reason) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Network\Session.cs:line 247
     at ACE.Server.Managers.WorldManager.ProcessPacket(ClientPacket packet, IPEndPoint endPoint, IPEndPoint listenerEndpoint) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Managers\WorldManager.cs:line 165
     at ACE.Server.Network.ConnectionListener.OnDataReceieve(IAsyncResult result) in C:\Users\vmware\Downloads\ACE-master (1)\ACE-master\Source\ACE.Server\Network\ConnectionListener.cs:line 101
     at System.Net.LazyAsyncResult.Complete(IntPtr userToken)
     at System.Net.ContextAwareResult.CompleteCallback()
     at System.Net.ContextAwareResult.<>c.<Complete>b__15_0(Object s)
     at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
  --- End of stack trace from previous location where exception was thrown ---
     at System.Net.ContextAwareResult.Complete(IntPtr userToken)
     at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result, IntPtr userToken)
     at System.Net.Sockets.BaseOverlappedAsyncResult.CompletionCallback(Int32 numBytes, SocketError errorCode)
     at System.Net.Sockets.OverlappedAsyncResult.CompletionCallback(Int32 numBytes, Byte[] socketAddress, Int32 socketAddressSize, SocketFlags receivedFlags, SocketError errorCode)
     at System.Net.Sockets.SocketAsyncContext.BufferMemoryReceiveOperation.InvokeCallback(Boolean allowPooling)
     at System.Net.Sockets.SocketAsyncContext.OperationQueue`1.ProcessAsyncOperation(TOperation op)
     at System.Net.Sockets.SocketAsyncContext.OperationQueue`1.<>c.<.cctor>b__18_0(Object op)
     at System.Threading.ThreadPoolWorkQueue.Dispatch()

  ### Desired functionality.
  Character 1 logs off, leaves fellow, server doesn't crash.

  ### Mention any other details that might be useful.
  Vtank seems to be a key component in this. I tried without vtank on and the crash didn't happen. I was able to reproduce multiple times using the above steps. 

  Commit #1502 ACEWorldDatabase v0.9.22

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1507/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NjY5MjI2
title: logging off while in fellowship
state: closed
created_at: 2019-03-09T06:14:47Z
updated_at: 2019-03-09T21:11:19Z
closed_at: 2019-03-09T21:11:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1508
body: This resolves https://github.com/ACEmulator/ACE/issues/1507
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1508/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NzEyNjky
title: Dat update
state: closed
created_at: 2019-03-09T20:01:35Z
updated_at: 2020-06-15T20:59:10Z
closed_at: 2019-03-10T01:51:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1509
type: pull
body:
  Added LanguageInfo to DatLoader (0x41 in client_local_English.dat)
  Added improved feedback when issuing invalid console commands or using incorrect syntax

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1509/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NzM1OTQ0
title: Rework Name and IsPlussed
state: closed
created_at: 2019-03-10T05:05:04Z
updated_at: 2019-03-30T18:03:17Z
closed_at: 2019-03-11T03:15:44Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1510
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1510/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NzQ3NTE5
title: network stability
state: closed
created_at: 2019-03-10T09:44:27Z
updated_at: 2019-03-10T21:40:24Z
closed_at: 2019-03-10T21:40:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1511
type: pull
body:
  - fixed bug causing disconnects due to NAK requests being ignored.
  - fixed bug causing session to enter an unspecified state after connect request packet sent to the client is corrupted in transit
  - fixed bug during handshake causing defunct session to linger
  - fixed bug whenever a bad handshake occurs causing crash
  - added asynchronous verification of encrypted CRCs
  - added checksum caching to ClientPacket
  - added handling of trusted packet with ClientSentNetErrorDisconnect flag
  - added parsing of optional "flow" header data
  - added more network logging
  - removed "generational ISAAC" debugging tools

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5NzY3MDQ1
title: Cleanup UseWithTarget and fix GameMessageInventoryRemoveObject
state: closed
created_at: 2019-03-10T15:24:53Z
updated_at: 2019-03-10T19:46:07Z
closed_at: 2019-03-10T19:45:47Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1512
type: pull
body:
  GameMessageInventoryRemoveObject was completely malformed. Not even sure how it was working before, if it was working at all.

  The combination of the mana stone fixes and the malformed packet now fix mana management plugins like Mag-Tools and vtank.

  Fixing the malformed packet may also fix other decal related issues.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1512/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5ODE2OTEw
title: Fixing combat pet aggro and despawning while idle
state: closed
created_at: 2019-03-11T02:49:49Z
updated_at: 2019-03-11T22:34:06Z
closed_at: 2019-03-11T22:34:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1513
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1513/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjU5ODI0OTE3
title: Fix FindByName: Strip + from searches
state: closed
created_at: 2019-03-11T03:55:58Z
updated_at: 2019-03-30T18:03:15Z
closed_at: 2019-03-11T04:02:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1514
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1514/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwMTk3NjIy
title: WIP: character migrate/backup/import and web API
state: closed
created_at: 2019-03-12T02:24:41Z
updated_at: 2019-04-02T02:42:56Z
closed_at: 2019-04-02T02:42:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1515
type: pull
body:
  **Authentication**:<br>
  The Web API uses [basic access authentication](https://en.wikipedia.org/wiki/Basic_access_authentication) and to access some of the data resources requires a valid account username and password for the underlying ACEmulator server.

  If using CURL then the `-k` option is needed since certificates are self-signed, unless a valid cert is configured for web API.  For authenticated resources CURL needs `-u myusername:mypassword`.

  If a resource is marked Anonymous then authorization isn't needed.  If you attempt to access a resource that isn't marked Anonymous without supplying valid credentials then you will get a `401 Unauthorized` response.

  Authenticated requests assume the accesslevel of the account authenticated as a series of claims.

  If a resource is marked `Requires: [Admin]`, that means unless your account includes the `Admin` claim then you won't be able to access the resource and you will get a `403 Forbidden` response.

  If a resource is marked `RequiresAny: [Admin,Advocate,Developer,Envoy,Player,Sentinel]` then unless your authenticated account claims at least one of the required claims you won't be able to access the resource and you will get a `403 Forbidden` response.

  **Web API**<br>
  [documentation](https://documenter.getpostman.com/view/6422801/RznLHGgq)<br>
  The Web API server listens at the base ACE port + 2, TCP, TLS, HTTPS, JSON, REST, depends on CryptoManager within ACE.Server project that Generates and saves self-signed certificates when it can't find them.  One for WebApi, and one for signing character transfers, in `C:\Users\<user>\AppData\Roaming\ACEmulator_<WorldName>\Certificates` on Windows or `/home/<user>/.config/ACEmulator_<WorldName>/Certificates` on Linux.  Place or replace webapi.pfx with a "valid" web server certificate if needed.  Self-Hosting using NancyFX/OWIN/Kestrel in its own project that depends on and wraps around ACE.Server.  WebSockets is a future possibility.  To run ACE with web API capability start the batch file: `\Source\ACE.Server.WebApi\bin\x64\Debug\netcoreapp2.1\start_server+webapi.bat`

  **To enable and run ACEmulator with WebAPI:**<br>
  1) Change the applicable setting to true in the configuration file, it should look like this after:

  ```
     "WebApi": {
         "Enabled": true
     },
  ```

  2) Build the solution. 
  3) Run the file `start_server+webapi.bat` in the output folder, which should be located somewhere like: `\Source\ACE.WebApiServer\bin\x64\Debug\netcoreapp2.1`

  A postman collection is included in the source: `WebApi.postman_collection.json` - just import that into postman for a working test suite.

  **Warning**<br>
  If the world name in the server configuration is changed then the current transfers and certificate are lost unless the files are moved to the new location.  To mitigate this move or copy the contents of `C:\Users\<user>\AppData\Roaming\ACEmulator_<OldWorldName>\` to `C:\Users\<user>\AppData\Roaming\ACEmulator_<NewWorldName>\` replacing `<user>` with the applicable username, and `<OldWorldName>` and `<NewWorldName>` with applicable names.  For linux the path will usually be: `/home/<user>/.config/ACEmulator_<WorldName>/`.  If your world name contains special characters then the folder names will have them stripped out, allowed world name to folder name characters are: `abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789`.

  **Migrations**:<br>

  1. Via Web API, a request is made to migrate a character to another server.
  2. Character snapshot is packaged and character is  placed in a "frozen" state.
  3. Requester makes an API call to get the list of characters, of which is the migrating character in frozen state.
  * At any time before the next step is initiated, or if the target server rejects the source server, an API request can be made to the source server to unfreeze the character and cancel the migration.
  4. Requester makes a request to the target server (the character's new home).
  5. Target server makes sure source server is trusted before downloading and rejects the request if it doesn't.
  6. Target server downloads packaged snapshot from source server.
  7. Source server permanently deletes character upon package download completion.
  8. Target server performs cryptographic verification of the snapshot, and rejects it if it's been forged.
  9. Target server adds the character to the requester's account.

  Note:  Allowing migrations from itself enables cross account transfers and character renaming.

  **Backups**:<br>
  Via Web API, a request is made to backup a character.
  Character snapshot is packaged and returned in the response to the requester.

  **Imports**:<br>
  **with imports enabled the exploitation flood gates are essentially open**<br>
  requester makes a request to the target server API including in the request the snapshot package encoded in base64 and the new character name.
  target server adds the character to the requester's account.

  **Recommended settings for flawless contract groups:**<br>
  allow backup: yes<br>
  allow migrate: yes<br>
  allow import: no<br>

  **Limitations**:<br>
  - ACE specific data constructs such as character options are not exported/imported.  This is to keep it as compatible as possible with LSD.

  **Disclaimer**<br>
  The migration feature requires the assumption that all server operators involved are non defectors.  A defector is someone in the trust group who does malicious or negligent action of any kind.  Providing a system that works for flawless trust groups is easy, but as soon as an attempt is made to eliminate the human element and commission the possibility of defectors the entire system breaks.  Manual approval process and/or central "antivirus" server may be something that someone might want to come up with in the future, but that's NOT what this is meant for.  **_As a server operator, DO NOT blame anyone but yourself upon defection(s) when using this system.  NOBODY BUT YOURSELF IS LIABLE_**

  I'm currently converting this into two different plugins: `ACE.Plugin.Transfer` and `ACE.Plugin.WebAPI`

  **TO-DO:**

  - add friends list status getter
  - add server pop limit to server info

  <hr>

  @esoterick commented Jan 21: (copied from old PR)

  Couple of concerns...

  Generally speaking API's are meant to be utilized by machines not users. Therefor Basic Authentication isn't usually the best form of Auth for them. Not to mention Basic Auth provides no Authorization components. So if you plan on adding multiple administrative components directly to the server I would recommend also adding a proper RBAC and some sort of API token.

  The following concerns me
  6. Target server downloads packaged snapshot from source server.
  7. Source server permanently deletes character upon package download completion.
  8. Target server performs cryptographic verification of the snapshot, and rejects it if it's been forged.
  9. Target server adds the character to the requester's account.

  If there is any issue in steps 7 and 8 the user is out of luck. The origin server deleted the origin char and the destination server failed to extract the snapshot of the user's migration. I feel like before anything is deleted both sites are checked for consistency. Once verified drop origin, and toggle/enabled destination.

  It also seems like there are numerous requests made to both servers for the migration. It seems like there shouldn't need to be. If trust is established between the two servers, the client should only have to make one a single request origin or destination it doesn't matter. The servers can then communicate across their own common api and handle the workflow themselfs.

  <hr>

  @Mag-nus submitted proposal and clarification Feb 3: (copied from old PR)

  ### Character Backup/Export/Import:
  ### [Definitions]
  Player - Person that exists in real life
  Character - In-game avatar created/controlled by the player
  Source - Server that the character in question resides on at the start of the action
  Target - Server or location that the caracter in question resides on at the end of the action
  Backup - Action involving a user storing a local copy of a character
  Transfer - Action involving a user migrating a character from a source to a target in which after the action, the character is no longer available on the source.
  Copy - Action involving a user copying a character from a source to a target in which after the action, the character is available on both locations.

  ### [Objectives]
      * Allow players to backup their characters
      * Allow server operators to maintain a trust network to transfer characters safely, and without external manipulation
      * Allow players (developers, sandbox, etc..) to copy their characters to an untrusted target.

  ### [Facts]
      * A server maintains a private RSA key and distributes their public RSA key.
      * These keys can be provided by the server owner via the config file
      * If the user is unable to provide their own keys, ACE can generate them automatically
      * The private key is used to sign character packages to provide proof of origin
      * The private key should not be shared, and should be kept secure
      * The public key should be available via the api and is used to verify authenticity
      * A server operator can use the same RSA key pairs for multiple servers in their control
      * A server can maintain separate options for import vs export.
      * In most cases, import will be more restrited than export.

  ### [Character Snapshot Format]
      * Should be the same format no matter what the export scenario
      * Includes the entire player biota as it exists in the database
      * TODO: Describe serilization process.
      * Character records are not included (these describe UI settings, etc..)
      * Includes a copy of the public key
      * TODO: Describe signature process
      * Entire payload should be compressed in a zip named with the following format: YYYY-MM-DD HH:MM:SS [Server Name] - [Character Name].zip
      * Compressed .zip payload should be able to be opened using windows explorer.

  ### [Requirements]
      * Character must be in logged off state on source server, and must be owned by player

  ### [Backup]
      * Allows a player to backup a character onto their local storage

  **Configured by:**
      * bool AllowCharacterBackup

  **Process:**
      * User opens up a web browser to the source api server and nagivates to backup character
      * The "Character Snapshot" is downloaded
      * This can be consumed from a web browser, plugin, or application

  ### [Export/Import]
      * Allows a player to copy a character onto a target server
      * Allows a player to transfer a character from the source server to the target server
      * Preventing exploit is managed by configuration using trusted servers

  **Configured by:**
      * List TrustedServers
      * bool AllowUntrustExport
      * bool AllowUntrustImport

  **Process inside trust:**
      1. Via Web API, player makes a request on the source server to start a character transfer
         1a. A unique token is generated for this request
         1b. A character transfer request record is created
         1c. Character is placed into a "frozen" state
         1d. Character snapshot is packaged
         1e. Unique token is supplied as a result
      2. Via Web API, player makes a request to the target server to complete the character transfer
      * Player must include source server: address, user name, user password, unique token
      * Player may provide new character name. If none provided, existing character name is used as default
        2a. Character slot count and name collision checks are run. On failure, request is rejected (with error message)
        2b. If source server is not listed as trust, request is rejected (with error message)
        2c. Target queries source and downloads packaged snapshot
        2c.1. Source server verifies target is in trusted list
        2d. Cryptographic verification of the snapshot is performed. On failure, request is rejected (with error message)
        2e. Target server adds the character to the players account in a (locked pending deletion) state
        == AT ANY POINT BEFORE NOW, CHARACTER CAN STILL BE UNLOCKED ON SOURCE ==
        2f. Target queries source server to delete character identified by token.
        2f.1. Source server verifies target is in trusted list
        2f.2. Source server permanently deletes character and responds with result
        2g. If deletion success, character is unlocked

  **Process outside trust (untrust):**
      1. Via Web API, player makes a request on the source server to start a character copy
         1a. A unique token is generated for this request
         1b. A character transfer request record is created
         1c.
         1d. Character snapshot is packaged
         1e. Unique token is supplied as a result
      2. Via Web API, player makes a request to the target server to complete the character copy
      * Player must include source server: address, user name, user password, unique token
      * Player may provide new character name. If none provided, existing character name is used as default
        2a. Character slot count and name collision checks are run. On failure, request is rejected (with error message)
        2b.
        2c. Target queries source and downloads packaged snapshot
        2d. Cryptographic verification of the snapshot is performed. On failure, request is rejected (with error message)
        2e. Target server adds the character to the players account
        2f.
        2g.

  Difference between trust and untrust:
  Untrust removes 1c
  Untrust removes 2b
  Untrust changes 2c
  Untrust changes 2e
  Untrust removes 2f
  Untrust removes 2g

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1515/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwMjU2MzUw
title: Fix healing
state: closed
created_at: 2019-03-12T08:06:59Z
updated_at: 2019-03-12T22:45:55Z
closed_at: 2019-03-12T16:30:07Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1516
type: pull
body:
  - Rework and simplify slightly Player.HandleActionUseWithTarget to allow healing to work, again, and add an allowed target check into ManaStone.HandleActionUseOnTarget()

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1516/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwMzU2NDM3
title: Make sure prior container is closed when using a new one
state: closed
created_at: 2019-03-12T13:11:51Z
updated_at: 2019-03-13T00:14:38Z
closed_at: 2019-03-12T21:43:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1517
type: pull
body:
  I noticed that in some cases, under load, corpses were remaining on the landblock (not decaying), because the IsOpen flag remained true. This was because either the closing ActOnUse message was being lost, or, VTank was not sending these when extra server load was present.

  Now, when we ActOnUse on a new container, and our previous container is still IsOpen by us, we close it.

  Also, LastUsedContainer has been changed to LastOpenedContainer which is more descriptive of its actual function.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjAxMzg5MzQ=
title: Fellowship doesn't display in player examine panel
state: closed
created_at: 2019-03-12T18:22:14Z
updated_at: 2019-03-12T21:14:38Z
closed_at: 2019-03-12T21:14:38Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Create a fellow, 
  Id yourself. 
  Doesn't show that you are in a fellow, it should. 
  Same for iding other players, if they are in a fellow it should show the name of it in the id window

  ### The log given by the failure.

  ### Desired functionality.

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1518/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNTIzOTAy
title: Adding Chess
state: closed
created_at: 2019-03-12T20:25:21Z
updated_at: 2019-03-19T07:10:57Z
closed_at: 2019-03-19T07:10:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1519
body: Thanks to Anahera for this implementation!
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1519/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNTMyMjIy
title: Adding fellowship name to player appraisal window
state: closed
created_at: 2019-03-12T20:50:42Z
updated_at: 2019-03-12T21:14:39Z
closed_at: 2019-03-12T21:14:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1520
body: This resolves https://github.com/ACEmulator/ACE/issues/1518
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1520/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNTM2NjY0
title: temporarily disabling recycled guids
state: closed
created_at: 2019-03-12T21:04:34Z
updated_at: 2019-03-12T21:43:32Z
closed_at: 2019-03-12T21:43:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1521
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1521/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNTY2ODgw
title: Fixing invisible player bug
state: closed
created_at: 2019-03-12T22:58:48Z
updated_at: 2019-03-12T23:24:04Z
closed_at: 2019-03-12T23:24:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1522
body: This bug occurs when players re-enter visibility to an unmoving player
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNTY2ODk4
title: Fix for vendors selling and/or buying items with Value of 0
state: closed
created_at: 2019-03-12T22:58:53Z
updated_at: 2019-03-30T18:03:15Z
closed_at: 2019-03-13T03:47:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1523
type: pull
body:
  Items sold or bought by vendors that report Value of 0 are treated as if they were Value of 1.

  This is seen with the vendor in training academy, Oil of Rendering is meant to cost 1p, while its value is 0.

  In practice this is rare, and client tends to not allow player to sale to vendors items of 0 value items

  Co-Authored-By: gmriggs <gmriggs@gmail.com>

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1523/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjAyNTY2MzM=
title: Hooked items do not display all relevant information on appraisal
state: closed
created_at: 2019-03-12T23:55:50Z
updated_at: 2019-03-26T23:45:26Z
closed_at: 2019-03-26T23:45:26Z
author_association: COLLABORATOR
state_reason: completed
type: issue
body:
  ```
  - [ X ] bug report -> please search issues before submitting
  ```

  ### Repro steps.
  * Inscribe a hookable item.
  * Buy a house.
  * Hook the item on the house in an appropriate hook.
  * Appraise the hooked item.

  The appraised hook item is missing information.

  ### Desired functionality.
  * The Use String should be copied from the source item, if any.
  * The Long Desc should read "This hook is owned by [HouseOwnerName]. It contains: \n[Item.LongDesc]"
  * The hooked item should pass a hookProfile field in the appraisal info event if the item is inscribed (HookProfile.Flags |= HookFlags.Inscribable) Unsure if this should always be sent for a hook or not. Needs more investigation.
  * The Inscription + ScribeName should be displayed, if any, in the appropriate area on the examine UI.
  * Name, Burden and Value are all properly set.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1524/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNTg4NTUy
title: Fix the legacy Open/Close virtual functions in WorldObject base
state: closed
created_at: 2019-03-13T00:59:36Z
updated_at: 2020-01-24T04:58:23Z
closed_at: 2019-03-14T00:48:47Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1525
type: pull
body:
  I don't understand the emote system, but it seems odd to me that
  CloseMe does **targetObject**.Close()
  and
  OpenMe does **WorldObject**.Open()

  Shouldn't they be performing the action on the same object?

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1525/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNjEzNTM2
title: continued refactoring of HandleUseOnTarget
state: closed
created_at: 2019-03-13T03:48:30Z
updated_at: 2019-03-13T21:28:57Z
closed_at: 2019-03-13T21:28:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1526
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwNjIzNjEy
title: Revising indoor fellowship distances
state: closed
created_at: 2019-03-13T04:55:42Z
updated_at: 2020-02-02T01:39:01Z
closed_at: 2019-03-13T21:29:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1527
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjA0MjQ2MjE=
title: You can not swear to monarch after breaking from patron in same allegiance
state: closed
created_at: 2019-03-13T10:31:30Z
updated_at: 2019-03-13T21:29:30Z
closed_at: 2019-03-13T21:29:30Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Create new character, swear to patron, break allegiance, unable to swear to new patron. In my instance it was my previous monarch. 

  ### The log given by the failure.
  no server side log was created for this issue.

  ### Desired functionality.
  You should be able to break from patron and then swear allegiance to the monarch of the chain.

  ### Mention any other details that might be useful.
  The break appears to work cleanly because patron and monarch info are removed from character, and the prompt to swear allegiance does come up. However, clicking the button does not appear to do anything. No onscreen error/feedback given. This is on a fresh pull/build as of 2019-03-13, but happened in prior build from last week also

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1528/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwODU1Nzgx
title: Adding local broadcast range to spell words
state: closed
created_at: 2019-03-13T17:00:13Z
updated_at: 2019-03-13T21:29:21Z
closed_at: 2019-03-13T21:29:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1529
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1529/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwODgwNjI4
title: additional error messages for allegiance swearing
state: closed
created_at: 2019-03-13T18:06:58Z
updated_at: 2019-03-13T21:29:30Z
closed_at: 2019-03-13T21:29:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1530
body: This resolves https://github.com/ACEmulator/ACE/issues/1528
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1530/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwOTUzMDUx
title: Adding some missing types / info to login
state: closed
created_at: 2019-03-13T21:54:59Z
updated_at: 2019-03-14T23:29:56Z
closed_at: 2019-03-14T23:29:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1531
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1531/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwOTUzMTMx
title: Adding rare timers
state: closed
created_at: 2019-03-13T21:55:15Z
updated_at: 2019-03-14T23:30:11Z
closed_at: 2019-03-14T23:30:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1532
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1532/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYwOTU4NzY2
title: Additional checks for built-in weapon spells
state: closed
created_at: 2019-03-13T22:17:15Z
updated_at: 2019-03-14T23:30:24Z
closed_at: 2019-03-14T23:30:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1533
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1533/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjA3OTMzMzA=
title: When giving a player a stack of items it fails to say the number
state: closed
created_at: 2019-03-14T01:38:57Z
updated_at: 2019-03-14T23:30:45Z
closed_at: 2019-03-14T23:30:45Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Give another player 50 Prismatic Tapers
  Chat window says, You give Character Prismatic Taper.

  It should say, 

  You give Character 50 Prismatic Tapers.

  ### The log given by the failure.

  ### Desired functionality.

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1534/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjA3OTM4NTk=
title: Player Death drops half of each stack of pyreals, pyreals dropped not on corpse
state: closed
created_at: 2019-03-14T01:41:43Z
updated_at: 2019-03-14T23:30:34Z
closed_at: 2019-03-14T23:30:34Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Create a character
  Create three stacks of 100k pyreals
  Die.

  Instead of dropping 150k pyreals, you will drop 50k pyreals, 50k pyreals and 50k pyreals. Also the pyreals will vanish instead of being on your player's corpse.

  ### The log given by the failure.

  ### Desired functionality.
  You should drop one stack of 150k pyreals and they should be located on the player's corpse

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1535/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxMDM3MzAz
title: consolidating pyreals in death message, adding corpse_destroy_pyreals option
state: closed
created_at: 2019-03-14T06:15:09Z
updated_at: 2019-03-14T23:30:35Z
closed_at: 2019-03-14T23:30:34Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1536
type: pull
body:
  This resolves https://github.com/ACEmulator/ACE/issues/1535

  Some notes:

  - The max size for a pyreal stack is 25k, so tested with 3x stacks of 10k pyreals each, instead of the 100k pyreal stacks in the original issue

  - The exact message printed by this scenario was: You've lost 10,000 Pyreals, 5,000 Pyreals, your Leather Boots, your Pants, and your Jerkin!

  So not exactly splitting each of the 3x 10k stacks in half, but this is the way the SpendCurrency() function works... it sorts all of the Pyreal stacks in order from smallest to largest, and then starts consuming the amount of coins

  The death message has been consolidated, so the total amount of pyreals dropped is listed, instead of each of the individual stacks that were consumed from.

  After much discussion about whether or not pyreals were destroyed on death, or dropped on the corpse (with people certain it seemed to work both ways), it was learned that pyreals originally dropped on death, but at some point during retail, this was changed to destroyed.

  The server defaults to end of retail settings (destroyed on death), but a new config option has been added, if the server admin wishes to run with coins dropped on player corpses, similar to the earlier days

  To enable this setting: /modifybool corpse_destroy_pyreals false

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1536/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxMDM5MjEx
title: pluralizing give messages w/ stacksizes
state: closed
created_at: 2019-03-14T06:25:47Z
updated_at: 2019-03-14T23:30:45Z
closed_at: 2019-03-14T23:30:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1537
body: This resolves https://github.com/ACEmulator/ACE/issues/1534
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1537/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxMTgyMzQ3
title: Enqueue action message cleanup
state: closed
created_at: 2019-03-14T14:04:56Z
updated_at: 2019-03-15T00:41:54Z
closed_at: 2019-03-15T00:41:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1538
type: pull
body:
  Changed the order a bit for performance.

  No need to enqueue on isDestroyed and decayCompleted WO's.

  Don't display messages for containers that are loading their inventories async

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1538/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxMjk1NjU5
title: Allow passthrough of permaload flag to landblocks loaded by adjacent load
state: closed
created_at: 2019-03-14T18:48:12Z
updated_at: 2019-03-30T18:03:11Z
closed_at: 2019-03-14T19:39:00Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1539
type: pull
body:
  If landblock is set to permaload and it also set to load its adajcents, those landblocks should also be marked as permaload

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1539/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxMzIxOTUz
title: cleaning up create list / moving corpse items
state: closed
created_at: 2019-03-14T20:11:45Z
updated_at: 2019-03-14T23:30:59Z
closed_at: 2019-03-14T23:30:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1540
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1540/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxMzU5Nzgz
title: Improving 'out of missile ammo' animation state / feedback
state: closed
created_at: 2019-03-14T22:19:17Z
updated_at: 2019-03-14T23:31:06Z
closed_at: 2019-03-14T23:31:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1541
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1541/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxNDE0MTQ2
title: plugin system
state: closed
created_at: 2019-03-15T03:54:44Z
updated_at: 2024-01-04T04:40:59Z
closed_at: 2023-12-11T14:04:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1542
type: pull
body:
  Allows loading instances of foreign assemblies into the primary execution context.

  [Here](https://github.com/fartwhif/ACE-Plugins) are some examples of plugins.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1542/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxNDQ2MzQ4
title: Odds and Ends
state: closed
created_at: 2019-03-15T07:20:51Z
updated_at: 2019-03-30T18:03:10Z
closed_at: 2019-03-16T07:40:12Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1543
type: pull
body:
  * Skip Burden in CreateObject if object is Creature
  * Update PlayerDescriptionEvent for pulling correct WeenieType and HasHealth bool
  * Stop sending all children equipped items

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxNDU3MjA4
title: Adding items that can be leveled up
state: closed
created_at: 2019-03-15T08:10:37Z
updated_at: 2019-03-19T02:50:01Z
closed_at: 2019-03-19T02:50:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1544
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1544/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxNTQ2MjU2
title: AddWorldObjectInternal Fix
state: closed
created_at: 2019-03-15T13:14:12Z
updated_at: 2019-03-27T01:58:23Z
closed_at: 2019-03-16T07:40:51Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1545
type: pull
body:
  Check to see if AddPhysicsObj failed first, before we actually add the object to the landblock.

  I did not actually play test this...

  Edit: Play tested it. Seems normal to me.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1545/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjE2MjY3NzQ=
title: Weakness 2 caused burden to go to 0 and can no longer pickup items
state: closed
created_at: 2019-03-15T17:26:05Z
updated_at: 2019-12-14T23:07:48Z
closed_at: 2019-12-14T23:07:48Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Was in Glenden Wood jails. Lich hit me with weakness 2, i could not pick up a gem from mob corpse. Waited for it to expire, but it did not fix the issue. Increased STR, didnt fix the issue. Re-log fixed the issue.

  ### The log given by the failure.
  No server side log noted

  ### Desired functionality.
  Spell should weaken and crease burden, not set it to 0. Player should still be able to pickup item if under max burden.

  ### Mention any other details that might be useful.
  Not sure if it is repeatable only got hit with spell once.This was with a fresh pull/build on 20190315

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1546/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjE2NDI5MjY=
title: Item bonus removed on death
state: closed
created_at: 2019-03-15T18:06:58Z
updated_at: 2019-03-19T02:50:28Z
closed_at: 2019-03-19T02:50:28Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Wield an item with bonus, then die. Bonuses still display, but are not actually applied. You must remove item and re-equip for bonus to work again

  ### The log given by the failure.
  no server side log noted

  ### Desired functionality.
  Item bonus should persist even in death

  ### Mention any other details that might be useful.
  Bug repeated multiple times today because i wanted to make sure it was happening, not because im a bad player ;)
  Fresh pull/build on 20190315

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1547/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxNzYxMzc1
title: Four changes
state: closed
created_at: 2019-03-16T09:41:38Z
updated_at: 2019-03-25T05:05:46Z
closed_at: 2019-03-25T05:05:16Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1548
type: pull
body:
  - Expand the usage of CreateIOU, namely for EmoteType.Give
  - Change InqAttributeStat, InqSecondaryAttributeStat, and InqSkillStat to use Current; Raw versions of these three inquiries continue to check against Base, per Morosity
  - Move cooldown processing into base OnActivate and CheckUseRequirements
  - Support Active equaling 0xffff on chests with spells, which should only cast their spell on opening the chest

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1548/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxODU3Nzk4
title: Update barber shop
state: closed
created_at: 2019-03-17T17:12:16Z
updated_at: 2019-03-19T02:50:11Z
closed_at: 2019-03-19T02:50:11Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1549
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1549/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxODY0ODY3
title: more visual updates for dye recipes
state: closed
created_at: 2019-03-17T19:06:51Z
updated_at: 2019-03-19T02:50:20Z
closed_at: 2019-03-19T02:50:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1550
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1550/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxODcyODQx
title: retaining item enchantments on death
state: closed
created_at: 2019-03-17T21:12:07Z
updated_at: 2019-03-19T02:50:28Z
closed_at: 2019-03-19T02:50:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1551
body: This resolves https://github.com/ACEmulator/ACE/issues/1547
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1551/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYxODg3Mjkz
title: Adding proc spells / cast on strike
state: closed
created_at: 2019-03-18T00:44:23Z
updated_at: 2019-03-19T02:50:36Z
closed_at: 2019-03-19T02:50:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1552
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1552/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYyMjQ3NDI1
title: Adding tailoring
state: closed
created_at: 2019-03-18T22:20:01Z
updated_at: 2019-03-19T07:11:16Z
closed_at: 2019-03-19T07:11:16Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1553
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1553/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYyMzM3Mzgx
title: Adding aetheria
state: closed
created_at: 2019-03-19T07:21:38Z
updated_at: 2019-03-21T01:28:49Z
closed_at: 2019-03-21T01:28:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1554
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1554/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYyNzEwNDUy
title: Preliminary fields for Luminance augs
state: closed
created_at: 2019-03-20T03:53:27Z
updated_at: 2019-03-20T20:22:09Z
closed_at: 2019-03-20T20:22:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1555
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1555/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYyNzIxMzA2
title: Additional ratings on appraisal panel
state: closed
created_at: 2019-03-20T05:04:53Z
updated_at: 2019-03-21T01:49:22Z
closed_at: 2019-03-21T01:49:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1556
type: pull
body:
  This PR contains a refactoring of some of the ratings code, and also adds support for all of the Luminance Augmentations

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1556/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzMDEwNzc1
title: Fixing item XP bug
state: closed
created_at: 2019-03-20T19:42:50Z
updated_at: 2019-03-20T19:55:52Z
closed_at: 2019-03-20T19:55:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1557
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1557/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzMDUyNDkz
title: Adding enlightenment
state: closed
created_at: 2019-03-20T21:55:58Z
updated_at: 2019-03-22T22:21:33Z
closed_at: 2019-03-22T22:21:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1558
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1558/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzMTAyMjgw
title: Improved chess piece movement
state: closed
created_at: 2019-03-21T02:55:57Z
updated_at: 2019-03-21T08:43:23Z
closed_at: 2019-03-21T08:43:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1559
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1559/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzMTM2Njk1
title: handling edge cases for refreshing spells w/ augs
state: closed
created_at: 2019-03-21T07:27:37Z
updated_at: 2019-03-21T08:43:41Z
closed_at: 2019-03-21T08:43:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1560
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1560/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjM3NTM5MTE=
title: House access for same account not working
state: closed
created_at: 2019-03-21T14:20:14Z
updated_at: 2019-07-25T04:11:33Z
closed_at: 2019-07-25T04:11:33Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Have one of your characters buy a house, Create a new or use an existing character on the same account and try to recall to the players house. It tells you that you must own a house to use that command. All character on the same account should be able to use the house freely. Also I ran the second character to the house on foot and he could not get past the barrier.

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  All characters on the "Same" account should have equal access to the house.
  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1561/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzNDA3MTMz
title: fixing spell trap duration
state: closed
created_at: 2019-03-21T21:15:11Z
updated_at: 2019-03-21T21:45:29Z
closed_at: 2019-03-21T21:45:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1562
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1562/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzNDQ2MDAx
title: Fixing run backwards state / jump frozen bug
state: closed
created_at: 2019-03-22T00:11:08Z
updated_at: 2019-03-22T04:22:15Z
closed_at: 2019-03-22T04:22:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1563
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1563/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzNDgxNjMz
title: updating burden from ammo / spell component
state: closed
created_at: 2019-03-22T04:21:27Z
updated_at: 2019-03-22T22:21:22Z
closed_at: 2019-03-22T22:21:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1564
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1564/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzODczNjgw
title: adding option to enable chess ai
state: closed
created_at: 2019-03-24T01:31:27Z
updated_at: 2019-03-25T08:22:32Z
closed_at: 2019-03-25T08:22:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1565
body: /modifydouble chess_ai_start_time 30
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1565/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzODc3NzU2
title: fixing xarabydun object visibility
state: closed
created_at: 2019-03-24T03:25:21Z
updated_at: 2019-03-24T12:32:59Z
closed_at: 2019-03-24T12:32:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1566
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1566/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzOTQ1Nzc1
title: Fix Chests casting permanent spells
state: closed
created_at: 2019-03-24T23:25:03Z
updated_at: 2019-03-25T05:05:44Z
closed_at: 2019-03-25T05:05:26Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1567
body: - Add WeenieType.Chests to list of item objects that retain a timed spell duration
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1567/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjYzOTg2ODU4
title: ensure monsters have a targeting tactic
state: closed
created_at: 2019-03-25T05:31:19Z
updated_at: 2019-03-25T08:22:40Z
closed_at: 2019-03-25T08:22:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1568
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1568/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0MzA4OTQy
title: Hook appraisals
state: closed
created_at: 2019-03-25T22:21:39Z
updated_at: 2020-06-15T20:59:11Z
closed_at: 2019-03-26T22:57:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1569
body:
  * Appraised items on housing hooks now show the details on the hooked item.

  Fixes Issue #1524

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1569/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0MzU0ODYy
state: closed
created_at: 2019-03-26T02:51:15Z
updated_at: 2019-03-28T06:18:19Z
closed_at: 2019-03-28T06:18:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1570
body: patch originally authored by @kdmxp256
type: pull
title:
  Adding IOUs for EmoteType.Give w/ missing wcids, emote skill check raw->current, move cooldown processing to base, update Active flag and chest logic, spell duration

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1570/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0NTc5ODA4
title: setting IsBusy for scroll usage, updating trained skill requirement message
state: closed
created_at: 2019-03-26T15:45:37Z
updated_at: 2019-03-28T04:25:59Z
closed_at: 2019-03-28T04:25:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1571
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1571/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0Njc1NjEw
title: adding /teledungeon
state: closed
created_at: 2019-03-26T20:07:27Z
updated_at: 2019-03-28T04:26:08Z
closed_at: 2019-03-28T04:26:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1572
body:
  /teledungeon A Red Rat Lair
  /teledungeon 103
  /teledungeon 0x103
  /teledungeon 0x103FFFF

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1572/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0NzU1OTk2
title: adding encapsulated spirit
state: closed
created_at: 2019-03-27T02:17:04Z
updated_at: 2019-03-28T04:26:17Z
closed_at: 2019-03-28T04:26:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1573
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1573/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjU3NDQ0MDg=
title: Alternate Currency not working
state: closed
created_at: 2019-03-27T03:20:43Z
updated_at: 2019-03-28T04:26:26Z
closed_at: 2019-03-28T04:26:26Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  The four tailor vendors have been added to the four starter towns, in ACE World Database release v0.9.30.  They make use of PropertyDataId.AlternateCurrency to change from the default currency used to the one specific in the property.  20630, Trade Note (250,000), in the case of these four tailor vendors.

  ### The log given by the failure.
  Vendor process not detecting the presence of required currency.

  ### Desired functionality.
  Vendor should detect the presence of the required currency and be able to use it in their transactions.

  ### Mention any other details that might be useful.
  Ianto, Master Tailor works inside the Holtburg building across the road from the Redspire portal, on lower town level

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1574/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0ODAxNTQ0
title: Adding alternate currency for vendors
state: closed
created_at: 2019-03-27T07:01:27Z
updated_at: 2019-03-28T04:26:26Z
closed_at: 2019-03-28T04:26:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1575
body: This resolves https://github.com/ACEmulator/ACE/issues/1574
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1575/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY0ODE0ODQ1
title: Support AdvocateItem RadarBlipColor changes
state: closed
created_at: 2019-03-27T07:59:20Z
updated_at: 2019-03-30T18:03:09Z
closed_at: 2019-03-28T06:16:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1576
type: pull
body:
  When Advocates equipped their Aegis (AdvocateItem) RadarBlipColor changed from White (Default) to Pink (Advocate) and the reverse occurred on unequip.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1576/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjYyMDg0NTk=
title: Extra data is sent during appraisals
state: open
created_at: 2019-03-27T22:18:40Z
updated_at: 2020-07-14T21:55:05Z
author_association: COLLABORATOR
type: issue
body:
  ```
  - [ X ] bug report -> please search issues before submitting
  ```
  ### Repro steps.
  When appraising an item, the resulting APPRAISAL_INFO_EVENT is sending back more properties than the client needs.

  ### Desired functionality.
  Reduce the size of the message and only send data that the client needs/wants/expects.

  ### Mention any other details that might be useful.
  Create a new attribute on the different property enums to signify if the property is sent directly during appraisals. (Note that some data is sent via a different list, e.g. PropertyInt.Damage is not sent with the intStats, but within the weaponProfile list.)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1577/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1MTQ0NDI4
title: updates for chest objects
state: closed
created_at: 2019-03-28T00:14:13Z
updated_at: 2019-03-28T06:17:17Z
closed_at: 2019-03-28T06:17:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1578
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1578/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1MTkyMzU5
title: Faster teleporting, further fixes for decal crashes
state: closed
created_at: 2019-03-28T05:32:05Z
updated_at: 2019-03-28T05:47:10Z
closed_at: 2019-03-28T05:47:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1579
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1579/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1MjIzNjky
title: Improved jump w/ low stamina
state: closed
created_at: 2019-03-28T08:03:43Z
updated_at: 2019-03-29T07:48:24Z
closed_at: 2019-03-29T07:48:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1580
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1580/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1MzAwNTg5
title: fixing sentries running in circles
state: closed
created_at: 2019-03-28T11:57:49Z
updated_at: 2019-03-29T07:48:40Z
closed_at: 2019-03-29T07:48:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1581
body: This fixes https://github.com/ACEmulator/ACE/issues/1455
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1581/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjY1NTc4NTg=
title: Cottage Storage Not working Correctly anymore.
state: closed
created_at: 2019-03-28T15:28:25Z
updated_at: 2019-03-29T07:48:48Z
closed_at: 2019-03-29T07:48:48Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Purchase a Cottage (Only Building I tried it in) go down and open the chest (Works) Double click the chest (won't Close) Close the Storage window (Closes) Chest remains open. Double Click the chest again, Nothing Happens at all. Appears to have started after the last patch (Not the DB update one, the one JUST before that one.) After working with this abit more it Looks like it maybe on a timer? Chest Closes by itself after a minuet or so. You can get the chest to close if you double click a house hook to.

  ### The log given by the failure.
  No Error Log Given.

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1582/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjY2NTQ5MzA=
title: Spell appraisal and activation on items
state: closed
created_at: 2019-03-28T18:51:09Z
updated_at: 2019-09-15T03:48:37Z
closed_at: 2019-09-15T03:48:37Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Equip an item that was converted from LSD that has both a SpellDID (28) or ProcSpell (55) and the same spell listed in properties_spell_book but with a probablility of zero.  ACE is casting all spells in properties_spell_book on the wielder.  Additionally, spells defined as such are duplicated in the appraisal.

  ### The log given by the failure.
  No log of failure

  ### Desired functionality.
  Appraisal should only list unique spellIDs, if duplicated between those three properties.  This change should be applied to more than just wielded items.  Properties_spell_book listed spells with a probability value of zero should not be cast on the wielder.  Even though possibly improper, as examples from PY16 data don't have spells from property DID 28 also listed in properties_spell_book,  making this change would increase compatibility with LSD created weenie files.

  ### Mention any other details that might be useful.
  Royal Runed Slashing Baton (https://github.com/ACEmulator/ACE-World-16PY-Patches/blob/51b6d017e931ff4f03558cca7929a7a3a34b29cc/Database/Patches/2005-07-ThroneOfDestiny/9%20WeenieDefaults/Caster/33206%20Royal%20Runed%20Slashing%20Baton.sql) from Patches release 0.30 or earlier for an example of SpellDID duplication
  Royal Runed Flamberge (https://github.com/ACEmulator/ACE-World-16PY-Patches/blob/51b6d017e931ff4f03558cca7929a7a3a34b29cc/Database/Patches/2005-07-ThroneOfDestiny/9%20WeenieDefaults/MeleeWeapon/33212%20Royal%20Runed%20Flamberge.sql) from Patches release 0.30 or earlier for an example of ProcDID duplication

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NTM5NzU4
title: updated house storage for Chest.CheckUseRequirements()
state: closed
created_at: 2019-03-28T23:43:04Z
updated_at: 2019-03-29T07:48:49Z
closed_at: 2019-03-29T07:48:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1584
body: This resolves https://github.com/ACEmulator/ACE/issues/1582
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1584/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NTUwNjQy
title: fixing chests stuck in open state
state: closed
created_at: 2019-03-29T00:51:11Z
updated_at: 2019-03-29T07:48:58Z
closed_at: 2019-03-29T07:48:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1585
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1585/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjY3NzU5ODY=
title: Using the cloak on command still shows player's dot on radar
state: closed
created_at: 2019-03-29T01:36:04Z
updated_at: 2019-05-07T04:02:42Z
closed_at: 2019-05-07T04:02:41Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Create an admin character
  Use the admin command, /cloak on
  Other players can't see your player model, but they will still see your dot on their radar.

  ### The log given by the failure.

  ### Desired functionality.
  /cloak on should hide the player model and hide the radar dot so a regular player cannot tell the cloaked admin is there. 

  ### Mention any other details that might be useful.

  "cloak needs to delete the cloaked admin and stop sending updates as well probably (remove that player from the visibility list of others)"

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1586/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NTc4NTYz
title: Updating allegiance login
state: closed
created_at: 2019-03-29T04:06:51Z
updated_at: 2019-03-29T09:32:52Z
closed_at: 2019-03-29T09:32:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1587
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1587/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjY4MTE5Njc=
title: Blue Coral Reef not spawning its full generate payload
state: closed
created_at: 2019-03-29T04:31:38Z
updated_at: 2019-06-21T08:44:36Z
closed_at: 2019-06-21T08:44:36Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Blue Coral Reef object at 0xBADD0008 [14.846939 171.967148 -0.895000] 0.994559 0.000000 0.000000 0.104175 is only spawning one Guardian Blue Coral Golem, when it should be spawning 4.  Generator property indicates that it should be spawning 4 of 4: https://github.com/ACEmulator/ACE-World-16PY-Patches/blob/master/Database/Patches/2005-08-FriendAndFoe/9%20WeenieDefaults/Creature/Unsorted/31329%20Blue%20Coral%20Reef.sql

  ### The log given by the failure.
  No log of failure

  ### Desired functionality.
  Should be spawning four mobs, and they should be spaced a little farther away from the object that creates them.  Currently, the one golem that does spawn is almost embedded in the Coral Reef.

  * Object and mob are present in current release of World database

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NTgzMjc2
title: Fix Cow Tipping issue
state: closed
created_at: 2019-03-29T04:39:36Z
updated_at: 2019-03-30T18:03:08Z
closed_at: 2019-03-29T05:26:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1589
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1589/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NTgzOTE4
title: fixing cow tipping quest
state: closed
created_at: 2019-03-29T04:43:54Z
updated_at: 2019-03-29T09:32:58Z
closed_at: 2019-03-29T09:32:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1590
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1590/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NjIxODU1
title: Update Vendor to use MerchandiseItemTypes field
state: closed
created_at: 2019-03-29T08:12:37Z
updated_at: 2019-03-30T18:03:05Z
closed_at: 2019-03-29T09:33:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1591
body: Only items of matching ItemType are allowed to be sold to/bought by vendor
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NjMwNTM5
title: Prevent HotSpot instant-kill
state: closed
created_at: 2019-03-29T08:48:26Z
updated_at: 2019-03-30T18:03:06Z
closed_at: 2019-03-29T08:52:31Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1592
body: No more hot spot of doom in Frore
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1592/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NjQwMzUw
title: updating war magic projectile spell messages
state: closed
created_at: 2019-03-29T09:22:46Z
updated_at: 2019-03-29T09:32:28Z
closed_at: 2019-03-29T09:32:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1593
body: this fixes the issue w/ vtank casting delays
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1593/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1NzY3NzUz
title: spell resistance message and doc updates
state: closed
created_at: 2019-03-29T15:44:59Z
updated_at: 2019-03-29T19:27:17Z
closed_at: 2019-03-29T19:27:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1594
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1594/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1ODA3MDE4
title: Change Message Sent for Vendor Sell Item
state: closed
created_at: 2019-03-29T17:40:23Z
updated_at: 2019-03-30T18:01:11Z
closed_at: 2019-03-29T17:52:12Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1595
body: Server should send 0x0022 to remove item from player's inventory and place it in vendor's
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1595/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTA4ODIw
title: updating allegiance for better syncing
state: closed
created_at: 2019-03-30T02:59:47Z
updated_at: 2019-03-30T05:57:20Z
closed_at: 2019-03-30T05:17:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1596
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1596/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTEwMzU5
title: updating PKLite messages, preventing spellcasting while teleporting
state: closed
created_at: 2019-03-30T03:28:47Z
updated_at: 2019-03-30T05:17:31Z
closed_at: 2019-03-30T05:17:31Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1597
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTExNzQ1
title: adding option to enable/disable DoT messages
state: closed
created_at: 2019-03-30T03:56:49Z
updated_at: 2019-03-30T05:17:44Z
closed_at: 2019-03-30T05:17:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1598
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1598/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTE4MzEw
title: additional allegiance fix
state: closed
created_at: 2019-03-30T06:11:29Z
updated_at: 2019-03-30T07:10:30Z
closed_at: 2019-03-30T07:10:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1599
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1599/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTIwMTA3
title: Adding IsBusy checks to healing and recipes / crafting
state: closed
created_at: 2019-03-30T06:49:11Z
updated_at: 2019-03-30T07:10:49Z
closed_at: 2019-03-30T07:10:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1600
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1600/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTIwMzQ0
title: Create a second Melee Weapon for players that train or specialize Dual Wield skill
state: closed
created_at: 2019-03-30T06:53:23Z
updated_at: 2019-03-30T18:00:49Z
closed_at: 2019-03-30T07:12:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1601
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1601/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTMwMzI5
title: misc fixes: container checks, fellowship disband button, allegiance login messages
state: closed
created_at: 2019-03-30T10:31:33Z
updated_at: 2019-03-30T17:56:20Z
closed_at: 2019-03-30T17:56:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1602
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1602/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTM2NDI5
title: Additional null checks for fellowships
state: closed
created_at: 2019-03-30T12:37:00Z
updated_at: 2019-03-30T17:56:27Z
closed_at: 2019-03-30T17:56:27Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1603
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1603/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTQwMjg0
title: omitting UpdateObject from hotkeyed recipe targets
state: closed
created_at: 2019-03-30T13:48:47Z
updated_at: 2019-03-30T17:56:33Z
closed_at: 2019-03-30T17:56:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1604
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1604/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTU3NDk5
title: Update ShardDB Enchantment Registry Composite Key
state: closed
created_at: 2019-03-30T18:09:45Z
updated_at: 2019-04-04T16:28:57Z
closed_at: 2019-03-30T19:15:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1605
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1605/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTU4ODEy
title: Additional null checks for allegiances
state: closed
created_at: 2019-03-30T18:28:36Z
updated_at: 2019-03-30T18:52:24Z
closed_at: 2019-03-30T18:52:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1606
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1606/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjczNDU0Nzk=
title: Asheron's Lesser Benediction spell doesn't fully work
state: closed
created_at: 2019-03-31T01:11:03Z
updated_at: 2019-03-31T19:28:51Z
closed_at: 2019-03-31T19:28:51Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  /ci 34257 and use.  Spell is cast and max health increases.  However, current health won't regen or heal above previous max amount.  Verified spell data is present.

  ### The log given by the failure.
  No log of failure

  ### Desired functionality.
  While spell is active, the current health of a character should be able to increase to the spell'd maximum.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1607/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjczNTU0NjE=
title: Stacking items causes permanent hour glass
state: closed
created_at: 2019-03-31T04:04:57Z
updated_at: 2019-12-14T23:07:18Z
closed_at: 2019-12-14T23:07:18Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Create a character in holtburg
  Go to archmage
  Buy hematites until pack is full
  Select hematite and press F repeatedly to stack it
  Permanent hourglass occurs

  ### The log given by the failure.


  ### Desired functionality.
  No permanent hourglass from stacking items

  ### Mention any other details that might be useful.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1608/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTg3MzY1
title: fixing salvaging infinite loop bug
state: closed
created_at: 2019-03-31T04:24:19Z
updated_at: 2019-03-31T09:15:47Z
closed_at: 2019-03-31T09:15:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1609
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1609/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTg4NjYy
title: Gear Knight display fixes
state: closed
created_at: 2019-03-31T05:00:28Z
updated_at: 2020-06-15T20:59:12Z
closed_at: 2019-03-31T13:11:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1610
type: pull
body:
  This corrects the appearance of Gear Knights. (And should also apply to Olthoi characters, once enabled).

  There is a work around for older Gear Knight players, as well, so they should look normal (but may not have accurate colors as chosen by player, and they never will due to missing data)

  This addresses issue #1294 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1610/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTk0MTIx
title: Fixing vitae bug, player multideaths, and skills appearing extremely buffed from vitae
state: closed
created_at: 2019-03-31T07:14:58Z
updated_at: 2019-03-31T09:16:06Z
closed_at: 2019-03-31T09:16:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1611
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1611/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MjczNjgyOTY=
title: Monster Corpse Permissions
state: closed
created_at: 2019-03-31T07:38:18Z
updated_at: 2019-03-31T09:16:14Z
closed_at: 2019-03-31T09:16:14Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Kill a mob on Player A
  Open mob corpse and then close it on Player A
  Try to open mob corpse on Player B
  You don't have permission to loot the Corpse of mob

  ### The log given by the failure.

  ### Desired functionality.
  When a mob is killed by Player A and Player A opens and closes it's corpse. The mob corpse should no longer be attuned to Player A and should be able to be opened by any other player

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1612/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTk2Mzgy
title: updating monster corpse looting permissions
state: closed
created_at: 2019-03-31T08:03:09Z
updated_at: 2019-03-31T09:16:14Z
closed_at: 2019-03-31T09:16:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1613
body: This fixes https://github.com/ACEmulator/ACE/issues/1612
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1613/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY1OTk4NzA2
title: Several Command Updates
state: closed
created_at: 2019-03-31T08:50:57Z
updated_at: 2019-04-04T16:28:56Z
closed_at: 2019-03-31T09:52:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1614
type: pull
body:
  * Update Logout to include server population and limits when character list is resent.
  * Updated @acehelp and @acecommands to not be individual messages, so not to be broken up by other chat spew.
  * Added @pop command -- Tells you how many players are online.
  * Added @watchmen command -- Displays accounts of a specific access level.
  * Added @finger command -- Displays information about a character and/or account.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1614/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 1}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDAyMTgw
title: Adding support for Asheron's Benediction
state: closed
created_at: 2019-03-31T09:57:15Z
updated_at: 2019-03-31T19:28:52Z
closed_at: 2019-03-31T19:28:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1615
type: pull
body:
  This adds support for vital multiplier enchantments, such as Asheron's Benediction

  For adding and removing enchantments which affect MaxVitals, an UpdateVital packet is also now sent much quicker, instead of on the next VitalTick update

  This resolves https://github.com/ACEmulator/ACE/issues/1607

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1615/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDA2Mjc2
title: Adding support for Augmented Understanding spell
state: closed
created_at: 2019-03-31T11:19:04Z
updated_at: 2019-03-31T19:29:00Z
closed_at: 2019-03-31T19:29:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1616
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1616/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDIzNzIz
title: Allegiance fixes
state: closed
created_at: 2019-03-31T15:52:24Z
updated_at: 2019-03-31T19:29:08Z
closed_at: 2019-03-31T19:29:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1617
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1617/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDM3MDAz
title: Add null account check to finger command
state: closed
created_at: 2019-03-31T19:10:01Z
updated_at: 2019-04-04T16:28:55Z
closed_at: 2019-03-31T19:29:37Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1618
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1618/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDU5MTQ0
title: Updating March changelog
state: closed
created_at: 2019-04-01T00:29:25Z
updated_at: 2019-04-01T02:11:33Z
closed_at: 2019-04-01T02:11:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1619
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1619/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDY5NTgx
title: Multiple Pet Fixes
state: closed
created_at: 2019-04-01T02:17:06Z
updated_at: 2019-04-04T16:28:54Z
closed_at: 2019-04-01T04:51:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1620
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1620/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0Mjc0ODgxNDk=
title: Configurable Option For Character Save Time
state: closed
created_at: 2019-04-01T02:51:29Z
updated_at: 2020-01-05T18:44:33Z
closed_at: 2020-01-05T18:44:33Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```


  ### Desired functionality.
  Would like to request a configurable option for character save time. Allow server operators to specify/change the default 5 minute character save time to x amount of minutes they choose.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1621/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MDk2MDUw
title: Add null checks for SelectDispel/Spell.Init
state: closed
created_at: 2019-04-01T05:26:15Z
updated_at: 2019-04-04T16:28:53Z
closed_at: 2019-04-01T05:45:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1622
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1622/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MTEzMzgw
title: Add warning for when SaveBiota fails for online player
state: closed
created_at: 2019-04-01T06:54:54Z
updated_at: 2019-04-04T16:28:45Z
closed_at: 2019-04-01T07:54:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1623
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1623/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MTI0MDAy
title: applying some out-of-band patches
state: closed
created_at: 2019-04-01T07:35:51Z
updated_at: 2019-04-01T07:58:30Z
closed_at: 2019-04-01T07:58:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1624
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1624/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MzIyMDQ5
title: Adding null check to kill tasks and CombatPets
state: closed
created_at: 2019-04-01T16:48:59Z
updated_at: 2019-04-09T05:53:23Z
closed_at: 2019-04-09T05:53:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1625
type: pull
body:
  These are the latest patches running on Coldeve currently

  This PR is not necessarly merge-ready (particularly the try/catch bit), but just posting here to have this reference on-hand

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1625/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2MzM2NTc0
title: Fixing skill credit refunds for untraining skills in Temple of Forgetfulness
state: closed
created_at: 2019-04-01T17:35:57Z
updated_at: 2019-04-02T17:27:03Z
closed_at: 2019-04-02T17:27:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1626
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1626/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0Mjc5NzY0NTk=
title: Stop-now should prevent players from being able to join
state: closed
created_at: 2019-04-02T01:06:13Z
updated_at: 2019-04-04T16:33:34Z
closed_at: 2019-04-04T16:33:34Z
author_association: MEMBER
state_reason: completed
type: issue
body:
  Players can still join after stop-now is run, this, causing stop-now to delay or fail.

  Also, verify that stop-now works with players in portal space as well.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1627/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NDYzOTcy
title: Use ServerGarbageCollection instead of Workstation GC
state: closed
created_at: 2019-04-02T02:23:30Z
updated_at: 2019-04-02T11:58:04Z
closed_at: 2019-04-02T10:14:29Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1628
type: pull
body:
  This prevents all threads from being blocked while GC runs (Workstation mode).

  Server allows the game threads to continue to operate while GC performs. This is also what is done in web applications and other server based applications.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1628/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NDY0NzAw
title: Support for ACE.Plugin.API
state: closed
created_at: 2019-04-02T02:27:41Z
updated_at: 2022-08-05T00:23:19Z
closed_at: 2022-08-05T00:23:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1629
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1629/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NDY2NzI5
title: Support for ACE.Plugin.Transfer
state: closed
created_at: 2019-04-02T02:40:25Z
updated_at: 2023-12-11T14:04:43Z
closed_at: 2023-12-11T14:04:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1630
body: Requisite changes allowing for the use of the transfer plugin.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1630/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NTMyODM4
title: Update how NPCs handle give/refuse emotes
state: closed
created_at: 2019-04-02T08:12:37Z
updated_at: 2019-04-04T16:28:43Z
closed_at: 2019-04-02T10:48:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1631
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1631/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NTU0Nzk0
title: Add Coelesced Aetheria to loot drops
state: closed
created_at: 2019-04-02T09:16:01Z
updated_at: 2019-04-11T05:12:28Z
closed_at: 2019-04-11T05:11:33Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1632
type: pull
body:
  - Add Coelesced Aetheria to loot drops
  - Adjust LootGenerationFactory.GetValue() to take the inherent weenie value of items into account, rather than a seemingly arbitrary random value

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NjM4NTgz
title: Fixing allegiance bug
state: closed
created_at: 2019-04-02T13:14:30Z
updated_at: 2019-04-06T05:51:41Z
closed_at: 2019-04-06T05:51:41Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1633
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2NjgzNDY2
title: Inventory Fixes
state: closed
created_at: 2019-04-02T14:56:37Z
updated_at: 2019-04-04T11:54:26Z
closed_at: 2019-04-04T11:54:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1634
type: pull
body:
  Fix the merge exploit.

  Remove some broadcast messages on errors that weren't needed

  Fixed an issue when picking up and merging a partial stack using the R key.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1634/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2ODg3ODE2
title: Update CreateList output to not sort by weenie class id
state: closed
created_at: 2019-04-03T04:22:16Z
updated_at: 2019-04-04T16:28:41Z
closed_at: 2019-04-03T04:42:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1635
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1635/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2ODkxOTc4
title: Update SummonPortal for Gateways
state: closed
created_at: 2019-04-03T04:51:00Z
updated_at: 2019-04-18T17:02:24Z
closed_at: 2019-04-06T05:51:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1636
type: pull
body:
  Add disable_gateway_ties_to_be_summonable configurable option.

  When enabled, players will not be able to summon gateways from ties of other gateways. This is not default behavior

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1636/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY2OTEzNzA0
title: Turbine chat fixes
state: closed
created_at: 2019-04-03T06:52:14Z
updated_at: 2019-04-03T07:08:50Z
closed_at: 2019-04-03T07:08:50Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1637
type: pull
body:
  * Fix issue with long chat messages.
  * Fix issue with chat type being sent improperly to the client.
  * Shuffled some enum stuff around to better match values used in the retail client.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1637/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3MTQ5MDkz
title: Random Colors in Loot
state: closed
created_at: 2019-04-03T17:50:04Z
updated_at: 2019-04-04T00:45:04Z
closed_at: 2019-04-04T00:45:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1638
body: Added color randomization to loot generated items.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1638/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0Mjg5NTc2MzE=
title: Unable to move to object error when trying to sell item to vendor
state: closed
created_at: 2019-04-03T20:22:53Z
updated_at: 2019-07-10T18:49:15Z
closed_at: 2019-07-10T18:49:15Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Buy hematite from archmage in holtburg
  Try to sell back the hematite
  Get an unexpected Unable to move to object error in yellow at top of screen

  Decal Off

  ### The log given by the failure.


  ### Desired functionality.
  Should either be able to sell the item or get an error message saying the vendor doesn't purchase that item. 

  ### Mention any other details that might be useful.
  Video demonstration
  https://megaupload.nz/wfz2p5Y4md/Asheron_s_Call_2019-04-03_16-14-37_mp4

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3MjExNjEw
title: updating spell component burn rate, and mana conversion for item spells
state: closed
created_at: 2019-04-03T21:06:08Z
updated_at: 2019-04-04T15:52:53Z
closed_at: 2019-04-04T15:52:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1640
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1640/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3MjQyMzE2
title: Updating 2-handed weapon skill check
state: closed
created_at: 2019-04-03T23:10:30Z
updated_at: 2019-04-04T15:52:44Z
closed_at: 2019-04-04T15:52:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1641
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1641/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3MjYxMTA5
title: /serverperformance command (Server Performance Monitor)
state: closed
created_at: 2019-04-04T01:06:08Z
updated_at: 2019-04-04T23:00:33Z
closed_at: 2019-04-04T18:38:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1642
type: pull
body:
  Optional parameters are:
  start
  stop
  reset

  If no parameters are present, the current performance metrics are spit out.

  When disabled, overhead is the cost of some simple function calls and a bool check. When enabled, the additional cost is stopwatch events. In comparisson to the work that ACE does for normal processing, the work done when serverperformance is enabled is nearly 0.

  Default is disabled.

  Enable it to start up automatically in the config.js. This is recommend for most servers. Enable it at runtime using /serverperformance start

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1642/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3NDE4NTE5
title: Reject new connections when shutting down
state: closed
created_at: 2019-04-04T12:05:44Z
updated_at: 2019-04-04T23:00:23Z
closed_at: 2019-04-04T16:17:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1643
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1643/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3NDYxNDkx
title: Adding rollback mitigation for players receiving items from NPCs
state: closed
created_at: 2019-04-04T13:57:23Z
updated_at: 2019-04-04T15:51:33Z
closed_at: 2019-04-04T15:51:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1644
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1644/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3NTAxNzAw
title: Save Player Corpses if dropped.count > 0
state: closed
created_at: 2019-04-04T15:29:24Z
updated_at: 2019-04-04T16:00:59Z
closed_at: 2019-04-04T15:51:22Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1645
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1645/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3NTA1NDU3
title: Fix for multi-death stacking
state: closed
created_at: 2019-04-04T15:38:20Z
updated_at: 2019-04-04T16:28:38Z
closed_at: 2019-04-04T15:50:11Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1646
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1646/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3Njg5NjQ5
title: move order-insensitive items earlier in packet processing pipeline
state: closed
created_at: 2019-04-05T04:52:17Z
updated_at: 2019-04-06T05:52:09Z
closed_at: 2019-04-06T05:52:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1647
body: added adaptive resiliency to CryptoSystem
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1647/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3NjkyMzIx
title: Add support for Barber NPCs
state: closed
created_at: 2019-04-05T05:12:36Z
updated_at: 2019-04-18T17:02:25Z
closed_at: 2019-04-05T05:36:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1648
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1648/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3ODg4OTE3
title: Add debug msg to tell block
state: closed
created_at: 2019-04-05T16:30:28Z
updated_at: 2019-04-18T17:02:24Z
closed_at: 2019-04-05T18:24:17Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1649
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1649/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY3OTUzNjcy
title: rares
state: closed
created_at: 2019-04-05T20:23:32Z
updated_at: 2019-04-06T17:56:00Z
closed_at: 2019-04-06T09:31:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1650
type: pull
body:
  sounds not working, but wont have time to work on it this weekend. We can merge this and somebody else can fix sounds. or I can get it on Monday.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1650/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDE1MDI0
title: Fix crash from null targetobject in OnDeath
state: closed
created_at: 2019-04-06T05:47:17Z
updated_at: 2019-04-18T17:02:22Z
closed_at: 2019-04-06T05:52:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1651
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1651/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDI5NTA4
title: adding support for prismatic arrows
state: closed
created_at: 2019-04-06T11:18:14Z
updated_at: 2019-04-07T03:03:44Z
closed_at: 2019-04-07T03:03:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1652
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1652/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDQ4Njk3
title: session termination and boot command enhancement
state: closed
created_at: 2019-04-06T17:07:14Z
updated_at: 2019-04-12T22:07:46Z
closed_at: 2019-04-12T22:07:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1653
type: pull
body:
  - added base system needed for more involved graceful session termination
  - centralized termination reasons
  - command parameter parsing tooling/framework, will make it easier to continue work, especially for implementation of graceful in-world account boot.
  - added optional reason parameter to boot command

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1653/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDUyNjg1
title: Retry failed shard db queries
state: closed
created_at: 2019-04-06T18:12:28Z
updated_at: 2019-04-09T00:13:08Z
closed_at: 2019-04-09T00:12:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1654
type: pull
body:
  On my load test server, occasionally I would see SaveBiota SSL exceptions. With this PR, it passes on the second attempt.

  This may also work for many other db related exceptions.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1654/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDU2MzE1
title: Fix tells via client gui (TalkDirect) to players.
state: closed
created_at: 2019-04-06T19:12:42Z
updated_at: 2019-04-18T17:02:21Z
closed_at: 2019-04-06T19:34:19Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1655
type: pull
body:
  This resolves the missing tells issue players are seeing. Some were using the `@tell player, message` form which worked, some were using TalkDirect form that comes from client GUI, which did not work.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1655/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDU4MTQ4
title: SpellbookCache
state: closed
created_at: 2019-04-06T19:43:01Z
updated_at: 2019-04-07T13:05:50Z
closed_at: 2019-04-07T13:05:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1656
type: pull
body:
  This uses a dictionary to check if spells are known instead of having to iterate over every record of BiotaPropertiesSpellBook every time a player casts a spell.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1656/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDYxMTk0
title: Landblock Dormancy after 1min of no player activity
state: closed
created_at: 2019-04-06T20:34:57Z
updated_at: 2019-04-18T12:45:43Z
closed_at: 2019-04-18T11:57:44Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1657
type: pull
body:
  This is a quick pass at adding dormancy to landblocks.

  Currently, the dormancy timer is set to 1m of idle. The existing unload timer is still 5m.

  When a landblock is dormant
  - Monsters don't tick AI
  - Physics aren't handled

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1657/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDcyMjAy
title: prevent items from being dropped into / through walls
state: closed
created_at: 2019-04-07T00:31:46Z
updated_at: 2019-04-07T03:04:08Z
closed_at: 2019-04-07T03:04:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1658
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1658/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDc4MDI0
title: ce patches
state: closed
created_at: 2019-04-07T03:11:52Z
updated_at: 2019-04-07T05:44:56Z
closed_at: 2019-04-07T05:44:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1659
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1659/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDc4MjMx
title: ProcessPacket performance added to /serverperformance
state: closed
created_at: 2019-04-07T03:17:24Z
updated_at: 2019-04-09T00:13:58Z
closed_at: 2019-04-09T00:13:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1660
type: pull
body:
  In addition, a Total Seconds (Tot) column has been added to /serverperformance.

  This new column is a much easier way to see how much resources a particular system is consuming.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1660/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDgxMTgx
title: Adding rares to server logs
state: closed
created_at: 2019-04-07T04:44:09Z
updated_at: 2019-04-08T19:00:56Z
closed_at: 2019-04-08T19:00:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1661
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1661/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDg1MTEy
title: Contingent: consolidated the session collections
state: closed
created_at: 2019-04-07T06:38:23Z
updated_at: 2019-04-13T22:54:56Z
closed_at: 2019-04-13T22:54:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1662
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1662/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MDg3NjAw
title: Adding branch
state: closed
created_at: 2019-04-07T07:37:50Z
updated_at: 2019-04-07T08:21:04Z
closed_at: 2019-04-07T08:21:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1663
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1663/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzAxNDg2NDE=
title: StopConditionsMax console output
state: closed
created_at: 2019-04-07T13:56:48Z
updated_at: 2019-04-09T00:25:09Z
closed_at: 2019-04-09T00:25:08Z
author_association: MEMBER
state_reason: completed
type: issue
body:
  I'm seeing a lot of lines like the following:
  Sturdy Steel Chest.StopConditionsMax(): CurrentCreate(4) > MaxCreate(3)

  It's my understanding that these are issues caused by content.

  How can we better log these issues in a better manner that gives us the necessary information to the content developers to resolve the issue.

  See WorldObject_Generator.cs, line 294 and 312

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1664/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzAxNDkwNzU=
title: AddWorldObjectInternal: couldn't spawn X
state: closed
created_at: 2019-04-07T14:00:58Z
updated_at: 2019-04-09T00:14:21Z
closed_at: 2019-04-09T00:14:21Z
author_association: MEMBER
state_reason: completed
type: issue
body:
  In Landblock.cs, line 564 in function AddWorldObjectInternal(),

  If the item fails to add, a WARN message is logged.

  I think we should change this to DEBUG for landscape/scatter placements and leave WARN for all else.

  Is this something that would be possible?

  Can we detect if the wo is from a scatter generator by accessing the wo directly, or should we include an argument to the function to indicate adds as a result of a scatter generator?

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1665/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MTMwNTk3
title: Update LSD converter to support enum shifting
state: closed
created_at: 2019-04-07T19:20:52Z
updated_at: 2019-04-18T17:02:21Z
closed_at: 2019-04-08T00:56:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1666
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1666/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MTQzODA2
title: fixing temple spec
state: closed
created_at: 2019-04-07T22:43:26Z
updated_at: 2019-04-08T19:01:06Z
closed_at: 2019-04-08T19:01:06Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1667
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1667/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MTU2OTgx
title: Fix issue with ClassName writer
state: closed
created_at: 2019-04-08T01:37:00Z
updated_at: 2019-04-18T17:02:19Z
closed_at: 2019-04-08T01:41:11Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1668
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1668/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MTY4OTM1
title: Remove sorting on Generator list
state: closed
created_at: 2019-04-08T03:14:26Z
updated_at: 2019-04-18T17:02:18Z
closed_at: 2019-04-08T06:36:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1669
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1669/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MjQ4NTQx
title: fixing landblock adjacency sync / visible objs
state: closed
created_at: 2019-04-08T09:15:56Z
updated_at: 2019-04-08T19:01:28Z
closed_at: 2019-04-08T19:01:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1670
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1670/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MjQ5NjI5
title: Rapid fix test
state: closed
created_at: 2019-04-08T09:18:50Z
updated_at: 2019-04-09T05:59:06Z
closed_at: 2019-04-09T05:57:52Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1671
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1671/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MzE3NTU1
title: Change generator AddWorldObjectInternal failures to Debug
state: closed
created_at: 2019-04-08T12:39:34Z
updated_at: 2019-04-09T00:14:42Z
closed_at: 2019-04-09T00:14:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1672
body: resolves #1665
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1672/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4MzMxNzM5
title: Change StopConditionsInit and StopConditionsMax to log.Warn
state: closed
created_at: 2019-04-08T13:17:22Z
updated_at: 2019-04-09T00:15:18Z
closed_at: 2019-04-09T00:15:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1673
body: Also added WCID and guid
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1673/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NDM3NDA2
title: Fix issue with radar on PK worlds
state: closed
created_at: 2019-04-08T17:53:47Z
updated_at: 2019-04-18T17:02:16Z
closed_at: 2019-04-09T03:51:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1674
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1674/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NTU2MzM0
title: GetVariance fix maybe?
state: closed
created_at: 2019-04-09T02:03:14Z
updated_at: 2019-04-09T11:51:02Z
closed_at: 2019-04-09T11:50:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1675
type: pull
body:
  The way these if statements were written, only two variances were actually being used for a given weapon type. The final if/else for each block.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1675/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NTU4Mzgw
title: MemoryStream ToArray() -> GetBuffer()
state: closed
created_at: 2019-04-09T02:16:32Z
updated_at: 2019-04-09T11:50:53Z
closed_at: 2019-04-09T11:50:34Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1676
type: pull
body:
  ToArray does a copy where GetBuffer gets the underlying backing array.

  Thanks Paradox for the tip.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1676/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NTczNzE0
title: updating Fellowship to WeakReference<Player>
state: closed
created_at: 2019-04-09T03:58:50Z
updated_at: 2020-10-30T18:09:48Z
closed_at: 2019-04-11T04:35:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1677
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1677/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NjI0MTk0
title: Fix issue with GeneratorTimeType - RealTime and defaulting start or end times.
state: closed
created_at: 2019-04-09T07:58:28Z
updated_at: 2019-04-18T17:02:15Z
closed_at: 2019-04-09T08:04:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1678
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1678/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NjMwOTM0
title: Change Shard Biota Palette table
state: closed
created_at: 2019-04-09T08:19:49Z
updated_at: 2019-04-18T17:02:14Z
closed_at: 2019-04-09T08:34:49Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1679
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1679/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NjM4NjU1
title: Update 2019-04-09-00-Biota_Palette_Change.sql
state: closed
created_at: 2019-04-09T08:43:12Z
updated_at: 2019-04-10T06:08:51Z
closed_at: 2019-04-09T08:51:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1680
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1680/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4NzMxNTc4
title: Code cleanup
state: closed
created_at: 2019-04-09T13:10:20Z
updated_at: 2019-04-11T01:48:56Z
closed_at: 2019-04-11T01:48:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1681
type: pull
body:
  Just a lot of little Resharper inspired optimizations.

  I tried to stick to ones that would improve performance.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1681/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4Nzc4MTk1
title: Revert "MemoryStream ToArray() -> GetBuffer() (#1676)"
state: closed
created_at: 2019-04-09T14:59:31Z
updated_at: 2019-04-09T15:03:26Z
closed_at: 2019-04-09T15:02:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1682
body: This reverts commit 2b9618cb9b46548adedbf0251bffe77dc2d2d13d.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1682/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4ODQ5ODcx
title: adding lifestone sending
state: closed
created_at: 2019-04-09T18:14:35Z
updated_at: 2019-04-10T04:33:14Z
closed_at: 2019-04-10T04:33:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1683
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1683/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTM4MTg4
title: adding AttributeTransferDevice
state: closed
created_at: 2019-04-09T21:53:13Z
updated_at: 2019-04-11T04:35:55Z
closed_at: 2019-04-11T04:35:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1684
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1684/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTUzMTE5
title: updating harm spell message color
state: closed
created_at: 2019-04-09T22:58:41Z
updated_at: 2019-04-10T04:33:33Z
closed_at: 2019-04-10T04:33:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1685
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1685/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTYxNzc4
title: Adding support for non-house owner rent payments
state: closed
created_at: 2019-04-09T23:45:27Z
updated_at: 2019-04-10T04:34:04Z
closed_at: 2019-04-10T04:34:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1686
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1686/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTY5NTAz
title: Contingent: This (should) fixe the threading issue with sessions and still be performant
state: closed
created_at: 2019-04-10T00:32:44Z
updated_at: 2019-04-11T12:18:45Z
closed_at: 2019-04-11T12:18:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1687
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1687/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTcxNDU4
title: preventing players from deceiving themselves
state: closed
created_at: 2019-04-10T00:46:42Z
updated_at: 2019-04-10T04:34:25Z
closed_at: 2019-04-10T04:34:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1688
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1688/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTg1MTcz
title: MemoryStream.ToArray() -> GetBuffer()
state: closed
created_at: 2019-04-10T02:23:20Z
updated_at: 2019-04-11T13:09:42Z
closed_at: 2019-04-11T13:09:29Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1689
type: pull
body:
  This is the partial implementation of the previous PR.

  There is still one more MemoryStream.ToArray() in the code, but, the usage of MemoryStream in that area is a bit complex and will take some further work to get away from ToArray()

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1689/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY4OTg4MjU5
title: Process inbound GameAction packets in order received
state: closed
created_at: 2019-04-10T02:43:51Z
updated_at: 2019-04-12T11:34:41Z
closed_at: 2019-04-12T11:34:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1690
type: pull
body:
  This does not change the performance of ACE. It just shifts the processing to a different order in UpdateWorld()

  It changes from an ActionQueue per session for these types of messages to a single action queue per world.

  It also changes the order in which messages are processed.

  Now, they are processed in the order in which they were received. Before, they were processed session by session, starting with the sessions with lower id's first.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1690/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5MDE4OTMx
title: Add support for GDLe recipe conversions
state: closed
created_at: 2019-04-10T06:05:14Z
updated_at: 2019-04-18T17:02:13Z
closed_at: 2019-04-10T17:42:34Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1691
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1691/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5MjM4OTI4
title: GfxObjCache + WeakReference
state: closed
created_at: 2019-04-10T16:30:24Z
updated_at: 2019-04-21T04:00:50Z
closed_at: 2019-04-21T04:00:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1692
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1692/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5MjY4Nzcx
title: More fixes for player corpse appearance issue
state: closed
created_at: 2019-04-10T18:02:16Z
updated_at: 2019-04-18T17:02:13Z
closed_at: 2019-04-11T04:06:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1693
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1693/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5MjY5NTk0
title: Adjusting two handed stance swapping / slots
state: closed
created_at: 2019-04-10T18:04:45Z
updated_at: 2019-04-11T04:36:12Z
closed_at: 2019-04-11T04:36:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1694
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1694/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5MjgwNzA2
title: Loot value updates
state: closed
created_at: 2019-04-10T18:38:49Z
updated_at: 2019-04-11T04:56:21Z
closed_at: 2019-04-11T04:56:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1695
type: pull
body:
  Updated loot values to use material types and gem types when determining the value. This is getting closer to what it should, but it isn't perfect.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1695/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzE2NjY4NTc=
title: couldn't find object &
state: closed
created_at: 2019-04-10T19:09:29Z
updated_at: 2020-08-28T17:52:13Z
closed_at: 2020-08-28T17:52:13Z
author_association: NONE
state_reason: completed
type: issue
body:
  2019-04-10 11:54:40,816 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A65FFFFE in Cell
  2019-04-10 11:54:40,816 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A660FFFE in Cell
  2019-04-10 11:54:40,817 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A65EFFFE in Cell
  2019-04-10 11:54:40,818 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A55FFFFE in Cell
  2019-04-10 11:54:40,819 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A75FFFFE in Cell
  2019-04-10 11:54:40,821 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A560FFFE in Cell
  2019-04-10 11:54:40,821 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A760FFFE in Cell
  2019-04-10 11:54:40,823 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A55EFFFE in Cell
  2019-04-10 11:54:40,824 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A75EFFFE in Cell
  2019-04-10 11:54:45,742 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(8602FFFF)
  2019-04-10 11:54:52,506 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A65DFFFE in Cell
  2019-04-10 11:54:52,507 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A55DFFFE in Cell
  2019-04-10 11:54:52,507 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id A75DFFFE in Cell
  2019-04-10 11:55:09,722 [124] DEBUG (ACE.Server.Managers.WorldManager) Login Request from 83.216.125.227:55727
  2019-04-10 11:55:09,722 [124] DEBUG (ACE.Server.Managers.WorldManager) Creating new session for 83.216.125.227:55727 with id 2
  2019-04-10 11:55:09,728 [125] DEBUG (ACE.Server.Network.Handlers.AuthenticationHandler) new client connected: acservertracker:jj9h26hcsggc. setting session properties
  2019-04-10 11:55:09,728 [World Manager] DEBUG (ACE.Server.Managers.WorldManager) Removing session for 83.216.125.227:55727 with id 2
  2019-04-10 11:55:13,885 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id 0F36FFFE in Cell
  2019-04-10 11:55:13,887 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id 1136FFFE in Cell
  2019-04-10 11:56:29,282 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CE41FFFE in Cell
  2019-04-10 11:56:29,357 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CF41FFFE in Cell
  2019-04-10 11:56:29,360 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CD42FFFE in Cell
  2019-04-10 11:56:29,361 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CF42FFFE in Cell
  2019-04-10 11:56:29,373 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CF40FFFE in Cell
  2019-04-10 11:56:30,336 [138] DEBUG (ACE.Server.Managers.WorldManager) Login Request from 74.199.43.198:61732
  2019-04-10 11:56:30,336 [138] DEBUG (ACE.Server.Managers.WorldManager) Creating new session for 74.199.43.198:61732 with id 2
  2019-04-10 11:56:30,342 [139] DEBUG (ACE.Server.Network.Handlers.AuthenticationHandler) new client connected: acservertracker:jj9h26hcsggc. setting session properties
  2019-04-10 11:56:30,343 [World Manager] DEBUG (ACE.Server.Managers.WorldManager) Removing session for 74.199.43.198:61732 with id 2
  2019-04-10 11:56:39,825 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CC42FFFE in Cell
  2019-04-10 11:56:39,827 [World Manager] DEBUG (ACE.DatLoader.DatDatabase) Unable to find object_id CC40FFFE in Cell
  2019-04-10 11:56:43,768 [145] DEBUG (ACE.Server.Managers.WorldManager) GetPossessedBiotasInParallel for Kaz took 29 ms
  2019-04-10 11:57:13,105 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x800005C6:Leather Gauntlets has enqueued an action but is not attached to a landblock.
  2019-04-10 11:57:13,107 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x800005C6:Leather Gauntlets has enqueued an action but is not attached to a landblock.
  2019-04-10 11:57:21,710 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x800005C5:Leather Leggings has enqueued an action but is not attached to a landblock.
  2019-04-10 11:57:21,712 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x800005C5:Leather Leggings has enqueued an action but is not attached to a landblock.
  2019-04-10 11:57:27,104 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x800005C8:Leather Cap has enqueued an action but is not attached to a landblock.
  2019-04-10 11:57:27,106 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x800005C8:Leather Cap has enqueued an action but is not attached to a landblock.
  2019-04-10 11:57:50,798 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 800004B3<!--

  2019-04-10 12:00:55,278 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x80000601:Bellows has enqueued an action but is not attached to a landblock.
  2019-04-10 12:00:55,280 [World Manager] WARN  (ACE.Server.WorldObjects.WorldObject) Item 0x80000601:Bellows has enqueued an action but is not attached to a landblock.
  2019-04-10 12:01:29,533 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(1134FFFF)
  2019-04-10 12:01:29,535 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(F34FFFF)
  2019-04-10 12:01:29,535 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(1136FFFF)
  2019-04-10 12:01:29,535 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(F36FFFF)
  2019-04-10 12:01:29,535 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(1135FFFF)
  2019-04-10 12:01:29,536 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(F35FFFF)
  2019-04-10 12:01:29,536 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(1034FFFF)
  2019-04-10 12:01:29,536 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(1036FFFF)
  2019-04-10 12:01:29,536 [World Manager] DEBUG (ACE.Server.Entity.Landblock) Landblock.Unload(1035FFFF)
  2019-04-10 12:01:37,472 [33] DEBUG (ACE.Server.Managers.WorldManager) Login Request from 74.199.43.198:50827
  2019-04-10 12:01:37,472 [33] DEBUG (ACE.Server.Managers.WorldManager) Creating new session for 74.199.43.198:50827 with id 2
  2019-04-10 12:01:37,474 [48] DEBUG (ACE.Server.Network.Handlers.AuthenticationHandler) new client connected: acservertracker:jj9h26hcsggc. setting session properties
  2019-04-10 12:01:37,475 [World Manager] DEBUG (ACE.Server.Managers.WorldManager) Removing session for 74.199.43.198:50827 with id 2

  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661010
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661011
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661012
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661013
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661014
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661015
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661016
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 75661017
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 7566100A
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 7566100B
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 7566100E
  2019-04-10 12:02:31,761 [World Manager] DEBUG (ACE.Server.WorldObjects.Player) HandleActionForceObjDescSend() - couldn't find object 7566100F
  2019-04-10 12:02:44,818 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(8000060D): couldn't find object
  2019-04-10 12:02:45,412 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(8000060D): couldn't find object
  2019-04-10 12:02:46,026 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(8000060D): couldn't find object
  2019-04-10 12:02:46,630 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(8000060D): couldn't find object
  2019-04-10 12:02:47,240 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(80000611): couldn't find object
  2019-04-10 12:02:47,845 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(80000611): couldn't find object
  2019-04-10 12:02:48,461 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(80000611): couldn't find object
  2019-04-10 12:02:49,063 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(80000612): couldn't find object
  2019-04-10 12:02:49,672 [World Manager] WARN  (ACE.Server.WorldObjects.Player) Kaz.ExamineObject(80000611): couldn't find object

  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  I was just running around and going into random portals.  Dunno if this helps or not.

  ### The log given by the failure.
  https://drive.google.com/open?id=1LPlCTZgrChlUjxqwfJ8D90kxOxB4riia

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1696/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5Mzc5ODIy
title: Change a few log messages to Debug level
state: closed
created_at: 2019-04-11T00:12:12Z
updated_at: 2019-04-11T01:49:14Z
closed_at: 2019-04-11T01:49:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1697
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1697/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NDAyMTIx
title: adjusting grant level proportional xp
state: closed
created_at: 2019-04-11T02:45:57Z
updated_at: 2019-07-15T02:47:57Z
closed_at: 2019-04-11T04:36:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1698
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1698/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NDEwMDU3
title: removing slash animation from thrust weapons
state: closed
created_at: 2019-04-11T03:39:00Z
updated_at: 2019-04-11T04:36:32Z
closed_at: 2019-04-11T04:36:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1699
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1699/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NDE2NDMw
title: cleaning up log messages for monster-wielded inventory
state: closed
created_at: 2019-04-11T04:22:17Z
updated_at: 2019-04-12T06:16:35Z
closed_at: 2019-04-12T06:16:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1700
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1700/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NDI2MjE3
title: adding fellowship sharing to KTs
state: closed
created_at: 2019-04-11T05:30:04Z
updated_at: 2019-04-12T06:16:46Z
closed_at: 2019-04-12T06:16:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1701
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1701/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NDM3NTI1
title: ensuring impen/bane applies to enchantable items
state: closed
created_at: 2019-04-11T06:29:59Z
updated_at: 2020-10-12T04:38:59Z
closed_at: 2019-04-11T13:37:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1702
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1702/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NDQ3NzY0
title: Adding quest restrictions to summoned portals
state: closed
created_at: 2019-04-11T07:10:33Z
updated_at: 2019-04-11T07:13:05Z
closed_at: 2019-04-11T07:13:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1703
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1703/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NTY0MTY4
title: Generator Console.WriteLine -> log.Debug
state: closed
created_at: 2019-04-11T13:05:03Z
updated_at: 2019-04-11T13:08:49Z
closed_at: 2019-04-11T13:08:36Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1704
body: Further efforts to reduce console output chatter
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1704/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzIxMDQ2MTQ=
title: Add biota ID to shard exceptions to help tracking
state: closed
created_at: 2019-04-11T16:03:41Z
updated_at: 2019-04-12T01:25:49Z
closed_at: 2019-04-12T01:25:49Z
author_association: MEMBER
state_reason: completed
type: issue
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1705/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5NzExOTA3
title: fixing blank allegiance officer title crash w/ decal
state: closed
created_at: 2019-04-11T19:02:33Z
updated_at: 2019-04-12T06:17:09Z
closed_at: 2019-04-12T06:17:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1706
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1706/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5ODQyNDQz
title: Add biota id:name to db exceptions
state: closed
created_at: 2019-04-12T01:29:30Z
updated_at: 2019-04-12T11:33:16Z
closed_at: 2019-04-12T11:32:53Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1707
body: Also fix a HouseManager exception
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1707/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5ODYwMTg0
title: fixing hotspots
state: closed
created_at: 2019-04-12T03:32:57Z
updated_at: 2019-04-12T06:17:20Z
closed_at: 2019-04-12T06:17:20Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1708
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1708/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5ODY4MzM3
title: fixing RestrictionDB table size
state: closed
created_at: 2019-04-12T04:33:31Z
updated_at: 2019-04-12T06:17:28Z
closed_at: 2019-04-12T06:17:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1709
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1709/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5OTAyNjc3
title: restriction db again
state: closed
created_at: 2019-04-12T07:36:36Z
updated_at: 2019-04-13T23:55:03Z
closed_at: 2019-04-13T23:55:03Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1710
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1710/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5OTE0NDI3
title: adding IsBusy check in TryRemoveFromInventoryWithNetworking
state: closed
created_at: 2019-04-12T08:17:40Z
updated_at: 2019-04-13T05:07:56Z
closed_at: 2019-04-13T05:07:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1711
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1711/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjY5OTQ2NzUx
title: updating kill tasks in fellowships
state: closed
created_at: 2019-04-12T09:56:37Z
updated_at: 2019-06-12T02:45:31Z
closed_at: 2019-04-13T23:19:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1712
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1712/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMDAyNzM1
title: Add physics cache counts to /ServerStatus
state: closed
created_at: 2019-04-12T13:01:23Z
updated_at: 2019-04-13T14:20:44Z
closed_at: 2019-04-13T14:20:31Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1713
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1713/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMTAxMTQ4
title: Minor fixes
state: closed
created_at: 2019-04-12T17:57:54Z
updated_at: 2019-04-18T17:02:10Z
closed_at: 2019-04-13T20:07:31Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1714
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1714/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMTgzNjAz
title: Adding support for new recipe formats
state: closed
created_at: 2019-04-12T23:48:49Z
updated_at: 2019-04-14T17:49:43Z
closed_at: 2019-04-14T17:49:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1715
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1715/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMTkyNjEz
title: hotspot / corpse fixes
state: closed
created_at: 2019-04-13T01:41:48Z
updated_at: 2019-04-13T23:19:13Z
closed_at: 2019-04-13T23:19:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1716
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1716/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjAyMTAz
title: moving IsBusy check
state: closed
created_at: 2019-04-13T05:08:51Z
updated_at: 2019-04-13T23:19:21Z
closed_at: 2019-04-13T23:19:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1717
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1717/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjExMzc3
title: Fixing dispel filters
state: closed
created_at: 2019-04-13T08:23:08Z
updated_at: 2019-04-13T23:19:28Z
closed_at: 2019-04-13T23:19:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1718
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1718/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzI4MzI1NDQ=
title: Admin characters should ignore house barriers / permissions
state: closed
created_at: 2019-04-13T10:24:59Z
updated_at: 2019-04-13T13:55:30Z
closed_at: 2019-04-13T13:55:29Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```

  ### Desired functionality.
  Admin characters should be able to bypass housing barriers / restrictions. 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1719/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjMwMDc5
title: Physics memory related additions
state: closed
created_at: 2019-04-13T14:25:36Z
updated_at: 2019-04-15T11:25:56Z
closed_at: 2019-04-15T11:23:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1720
type: pull
body:
  Reduce size of GfxObj by commenting out unused variables

  Added the following developer commands
  /clearphysicscaches
  /forcegc

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1720/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjM0ODI1
title: Fix Recipe Issue
state: closed
created_at: 2019-04-13T15:43:23Z
updated_at: 2019-04-18T17:02:10Z
closed_at: 2019-04-13T20:07:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1721
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1721/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzI4NjU0Nzk=
title: Burden Check when buying
state: closed
created_at: 2019-04-13T16:14:35Z
updated_at: 2019-06-21T08:46:39Z
closed_at: 2019-06-21T08:45:51Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Buy till your burden is at max, Buy again and the money is removed but the item is not placed in you backpack

  ### The log given by the failure.
  Found no log.

  ### Desired functionality.
  When burden reaches max (or close to it) there should be a check as to if the item being purched is to heavy for the buyer to carry and if it is there should be a message letting the player know. Also no money should be removed.

  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1722/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzI4NjYxNzA=
title: no check for overpay on house buying
state: closed
created_at: 2019-04-13T16:19:20Z
updated_at: 2019-12-14T23:04:20Z
closed_at: 2019-12-14T23:04:19Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  when buying a house place the special item, Writ and 10 M note or any amount larger then the exact amount in the buy window. it will take all the items, including all 10 M Notes. 

  ### The log given by the failure.
  No log Found

  ### Desired functionality.
  Should be able to buy a house and drop any amount say 2 MMDs and have it return the unused/unneeded amount.

  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1723/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjUyNzQz
title: added try/catch to prevent crashing server during FlushPackets
state: closed
created_at: 2019-04-13T20:38:07Z
updated_at: 2019-04-13T22:55:44Z
closed_at: 2019-04-13T22:55:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1724
type: pull
body:
  added null inspection to FlushPackets after dequeueing the next packet, to aid in identifying cause of

  ```
  Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
     at ACE.Server.Network.NetworkSession.FlushPackets() in /home/gmriggs/ACE/ACE/Source/ACE.Server/Network/NetworkSession.cs:line 593
     at ACE.Server.Network.NetworkSession.Update() in /home/gmriggs/ACE/ACE/Source/ACE.Server/Network/NetworkSession.cs:line 202
     at ACE.Server.Network.Session.TickOutbound() in /home/gmriggs/ACE/ACE/Source/ACE.Server/Network/Session.cs:line 126
  ```

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1724/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzI5MDIzNzY=
title: Creatures are opening doors when they shouldn't be.
state: closed
created_at: 2019-04-13T21:25:44Z
updated_at: 2019-04-13T22:41:19Z
closed_at: 2019-04-13T22:40:33Z
author_association: COLLABORATOR
state_reason: completed
type: issue
body:
  With exception, like olthoi opening "squishy doors", monsters are not to be opening doors for themselves.  See: https://youtu.be/2WPBcSMj5-8?t=559 and https://youtu.be/2WPBcSMj5-8?t=892  ,at least in Glenden Wood Dungeon


  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Enter Glenden Wood Dungeon, approach any of the doors featured in the video.
  Gather a situation involving monsters trying to go through a door.

  ### Actual result
  door is opened by monster, monster now has an easier path or clear line of sight to the player character and approaches the player character while in melee attack mode.

  ### Desired result
  Monster is stuck behind the door, sort of running against it after its target if its target is far enough away, or striking at its target on the other side of the door if its target is close enough.

  ### Mention any other details that might be useful.
  12/20 conversation in dev channel exhibits some clues, correct or not I don't know:
  AiOptions = 1 opens doors
  an olthoi door that can't be opened by olthoi, an exceptional exception, "IgnoreCollisions turns it off" <https://github.com/ACEmulator/ACE-World-16PY/blob/master/Database/3-Core/9%20WeenieDefaults/SQL/Door/MISC/25465%20Olthoi%20Door.sql>

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1725/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjU5MDgz
title: replace session array and lock with concurrent collection
state: closed
created_at: 2019-04-13T22:50:37Z
updated_at: 2019-05-07T17:17:29Z
closed_at: 2019-05-07T17:17:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1726
type: pull
body:
  consolidated session mechanisms and collections into a single concurrent collection
  heavyweight concurrency for session collection
  additional try/catch for FlushPackets

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1726/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjYyODky
title: misc updates
state: closed
created_at: 2019-04-14T00:32:17Z
updated_at: 2019-04-14T01:24:32Z
closed_at: 2019-04-14T01:24:32Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1727
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1727/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjY1NTcx
title: Update for quest changes
state: closed
created_at: 2019-04-14T01:48:02Z
updated_at: 2019-04-18T17:02:08Z
closed_at: 2019-04-15T07:15:19Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1728
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1728/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMjY1NzIy
title: Improved fellowship vital update rate / sync
state: closed
created_at: 2019-04-14T01:52:41Z
updated_at: 2019-04-15T04:35:00Z
closed_at: 2019-04-15T04:35:00Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1729
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1729/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMzE3MTE3
title: Fixing player DoT damage history
state: closed
created_at: 2019-04-14T18:31:53Z
updated_at: 2019-04-15T04:35:46Z
closed_at: 2019-04-15T04:35:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1730
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1730/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMzIyMzY4
title: adding CanAddToInventory / pre-check for Player.Give
state: closed
created_at: 2019-04-14T19:54:15Z
updated_at: 2019-04-18T10:38:55Z
closed_at: 2019-04-18T10:38:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1731
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1731/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMzI2NTAz
title: removing deprecated skill check formula
state: closed
created_at: 2019-04-14T20:54:31Z
updated_at: 2019-04-15T04:36:42Z
closed_at: 2019-04-15T04:36:42Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1732
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1732/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzMwNTU1MDc=
title: Monsters fall off ledges when they should not.
state: closed
created_at: 2019-04-15T00:54:46Z
updated_at: 2019-11-16T01:03:51Z
closed_at: 2019-11-16T01:03:51Z
author_association: COLLABORATOR
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  - Enter OP BSD with any character.
  - Drill your way to the bottom
  - get to the end
  - destroy a horde of cats

  ### Expected result
  -  Most if not all cats are to be restrained to their upper perches

  ### Actual result
  - A gigantic horde of cats all funnel towards you, either from bottom level or from top level, falling off their ledges, the ones on top level are not restrained by their upper level edges.

  ### Other details

  - i may be remembering wrong, don't remember fighting them, and mistook the virindi forbeing restrained, for the cats
  - i remember being relieved that some of them are restrained by the ledge
  - i could be mistaken about which crew was the restrained one, might have been the virindi

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1733/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzMwNTgyMDQ=
title: combat uninterrupted by heal
state: open
created_at: 2019-04-15T01:16:25Z
updated_at: 2019-05-22T00:49:39Z
author_association: COLLABORATOR
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  during melee combat heal after the blade swing animation before the next "power-up"

  ### Visualized result
  after heal combat has resumed as if no heal has taken place

  ### Expected result
  combat interrupted and player forced to re-initiate combat after the heal

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1734/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMzU2MTUx
title: fix salvaging workmanship bug
state: closed
created_at: 2019-04-15T02:59:02Z
updated_at: 2019-04-15T04:36:51Z
closed_at: 2019-04-15T04:36:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1735
body: also adds "salvage_handle_overages" property, which defaults to retail behavior
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1735/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMzYwMzQw
title: Fixing some apartment bugs
state: closed
created_at: 2019-04-15T03:32:15Z
updated_at: 2019-04-15T06:30:29Z
closed_at: 2019-04-15T06:30:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1736
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1736/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzMwODExMTI=
title: Blackmire quests won't successfully complete
state: closed
created_at: 2019-04-15T03:35:30Z
updated_at: 2019-05-27T04:58:33Z
closed_at: 2019-05-27T04:58:33Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  http://acpedia.org/wiki/Blackmire
  Quests do not function correctly.

  ### The log given by the failure.
  No log generated

  ### Mention any other details that might be useful.
  Fellowship driven emotes and portal spells need code to be completed for quests to work successfully.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1737/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwMzg2MDkz
title: ensuring BF_OPENABLE flag for inventory containers
state: closed
created_at: 2019-04-15T06:30:16Z
updated_at: 2019-04-15T07:15:37Z
closed_at: 2019-04-15T07:15:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1738
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1738/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNDE5NjM0
title: couple of minor code errors
state: closed
created_at: 2019-04-15T08:33:15Z
updated_at: 2019-04-18T17:02:06Z
closed_at: 2019-04-15T08:35:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1739
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1739/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNDc4NTMz
title: Fix session timeout values (basically adds 45s to timeout value)
state: closed
created_at: 2019-04-15T11:35:48Z
updated_at: 2019-04-16T01:20:28Z
closed_at: 2019-04-16T01:19:40Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1740
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1740/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNTE2MjI2
title: Network Stability Improvements
state: closed
created_at: 2019-04-15T13:26:21Z
updated_at: 2019-04-16T01:20:18Z
closed_at: 2019-04-16T01:19:50Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1741
type: pull
body:
  It was possible for packetQueue to get corrupt when clients request packet retransmits. At that point, multiple threads could be enqueing work.

  This adds slight overhead by converting it to a ConcurrentQueue, but, should also (hopefully) fix the "corrupt sessions" issue people were seeing.

  This should also fix the exception that was reported in NetowrkSession.FlushPackets()

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1741/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNzA2NzYy
title: nuking 2 files for possible EOL fix
state: closed
created_at: 2019-04-15T23:35:41Z
updated_at: 2019-04-15T23:39:40Z
closed_at: 2019-04-15T23:39:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1742
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1742/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNzA3NTY1
title: restore files w/ corrected line endings
state: closed
created_at: 2019-04-15T23:40:49Z
updated_at: 2019-04-15T23:41:49Z
closed_at: 2019-04-15T23:41:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1743
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1743/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNzMyNjc4
title: Too many overloads... VendorFix
state: closed
created_at: 2019-04-16T02:30:07Z
updated_at: 2019-04-16T02:35:27Z
closed_at: 2019-04-16T02:34:32Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1744
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1744/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwNzcwNzc1
title: Fix some issues with secure trade.
state: closed
created_at: 2019-04-16T06:32:10Z
updated_at: 2019-04-18T17:02:05Z
closed_at: 2019-04-17T04:44:20Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1745
body:
  * Can ID items in trade window properly
  * Only initiator does MoveTo/Rotate now

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1745/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcwODU1MTcw
title: send RestrictionDB in order of client hash
state: closed
created_at: 2019-04-16T10:48:38Z
updated_at: 2019-04-17T05:07:49Z
closed_at: 2019-04-17T05:07:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1746
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1746/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxMTQ1NTg5
title: Fixing Allegiance ranks
state: closed
created_at: 2019-04-17T03:35:49Z
updated_at: 2019-04-17T05:08:04Z
closed_at: 2019-04-17T05:08:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1747
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1747/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxMTYyMzkw
title: Shortcut Fix Stage 2
state: closed
created_at: 2019-04-17T05:35:00Z
updated_at: 2019-05-20T16:46:54Z
closed_at: 2019-04-20T17:57:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1748
type: pull
body:
  * Change character_properties_shortcut_bar to use Composite key
  * Update table to fix unique key issue allowing for multiple issues with collisions on slot ids and object ids
  * Update Add/Remove code to reflect comp key index requirement
  * Change AddShortcut to TryAddOrUpdateShortcut

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1748/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxMjk3NzA4
title: Reduce rogue physics landblocks loaded by portal desitnation parsing
state: closed
created_at: 2019-04-17T13:02:52Z
updated_at: 2019-04-18T12:45:52Z
closed_at: 2019-04-18T11:56:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1749
type: pull
body:
  On my test of 1000 landblocks, x: 0x20-0x40, y: 0x20-0x40,

  After all landblocks load usign "loadalllandblocks" and unload, there were still ~36 physics landblocks remaining.

  This reduces it to ~15.

  I've also commented out the landblock unload debug message.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1749/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxMzM4MjA1
title: Dispose ShardContext on RemoveBiota
state: closed
created_at: 2019-04-17T14:40:47Z
updated_at: 2019-04-18T12:46:02Z
closed_at: 2019-04-18T10:39:37Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1750
type: pull
body:
  This is just a partial fix for dispoing contexts properly.

  The contexts that are released from BiotaContexts as biotas go out of scope are never disposed. They are only finalized when the GC collects them. I plan to come up with a solution for that as well.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1750/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxNDg2NjY5
title: fixing landblock leak
state: closed
created_at: 2019-04-17T22:09:57Z
updated_at: 2019-04-19T03:53:29Z
closed_at: 2019-04-19T03:53:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1751
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1751/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxNTQ1MjYz
title: Fixing summon portal spawning
state: closed
created_at: 2019-04-18T04:26:00Z
updated_at: 2019-04-18T10:31:18Z
closed_at: 2019-04-18T10:31:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1752
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1752/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxNTQ5OTY5
title: Fixes for Quest Items/Corpses
state: closed
created_at: 2019-04-18T04:59:43Z
updated_at: 2019-04-18T17:02:00Z
closed_at: 2019-04-18T06:12:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1753
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1753/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxNTYwODIz
title: fixing equipped item overlap
state: closed
created_at: 2019-04-18T06:07:47Z
updated_at: 2019-04-18T06:12:26Z
closed_at: 2019-04-18T06:12:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1754
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1754/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxNjM2ODc5
title: Fixing inventory give equipped bug
state: closed
created_at: 2019-04-18T10:36:16Z
updated_at: 2019-04-21T01:20:33Z
closed_at: 2019-04-21T01:20:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1755
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1755/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxNzIyNDU1
title: Add missing WieldSkillType to loot melee weapons
state: closed
created_at: 2019-04-18T14:55:50Z
updated_at: 2019-04-20T18:42:42Z
closed_at: 2019-04-19T03:43:48Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1756
type: pull
body:
  - Remove other Magic skill types from elemental casters; only Void and War Magic skill used for wield requirements
  - Allow for non-elemental casters to have wield requirements
  - Add wieldSkillType to loot melee weapons
  - Add Level wield requirement for tier 7 & 8 jewelry
  - Correctly apply the Level wield requirement for tier 7 & 8 on armor/clothing

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1756/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxODg1NjUw
title: Fixing corpse null exception
state: closed
created_at: 2019-04-19T02:03:23Z
updated_at: 2019-04-19T03:53:39Z
closed_at: 2019-04-19T03:53:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1757
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1757/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxODg3MjQ4
title: Adding busy check to food/consumables
state: closed
created_at: 2019-04-19T02:16:57Z
updated_at: 2019-04-19T03:53:47Z
closed_at: 2019-04-19T03:53:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1758
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1758/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxOTEzODg4
title: Shortcut Fix Stage 1
state: closed
created_at: 2019-04-19T06:06:24Z
updated_at: 2019-05-20T16:46:57Z
closed_at: 2019-04-19T06:58:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1759
type: pull
body:
  - Update to latest master
  - Start ACE and close world using `world close boot`
  - Run `fix-shortcut-bars` command
    - if there are bugged players, issue `fix-shortcut-bars execute` command
  - Once that is finished, world is ready for stage two update

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1759/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxOTE0NTYz
title: Adding /quests command
state: closed
created_at: 2019-04-19T06:11:01Z
updated_at: 2019-04-20T15:55:04Z
closed_at: 2019-04-20T15:55:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1760
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1760/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxOTE4MTQ3
title: Adding more code protection for TOD salvage data
state: closed
created_at: 2019-04-19T06:34:36Z
updated_at: 2019-04-19T06:58:59Z
closed_at: 2019-04-19T06:58:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1761
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1761/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcxOTQzNTUx
title: Improved monster ReturnHome logic
state: closed
created_at: 2019-04-19T08:49:50Z
updated_at: 2019-04-20T15:55:35Z
closed_at: 2019-04-20T15:55:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1762
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1762/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMDU3NjE1
title: Fix issue with Activate emote
state: closed
created_at: 2019-04-19T18:06:05Z
updated_at: 2019-05-20T16:46:55Z
closed_at: 2019-04-20T04:14:19Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1763
type: pull
body:
  Non player objects, activating other non player objects

  Example: Scold @teleloc 0x64480106 [47.215000 -14.227200 -30.000000] 0.000000 0.000000 0.000000 -1.000000

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1763/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTE0NDk0
title: syncing WieldSkillType with WeaponType
state: closed
created_at: 2019-04-19T23:34:14Z
updated_at: 2019-04-21T01:20:25Z
closed_at: 2019-04-21T01:20:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1764
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1764/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTIwMDQ4
title: clamping broadcast range on some recalls
state: closed
created_at: 2019-04-20T00:39:47Z
updated_at: 2019-04-20T15:55:46Z
closed_at: 2019-04-20T15:55:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1765
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1765/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTMzNjE0
title: Loot fixes/additions
state: closed
created_at: 2019-04-20T05:44:17Z
updated_at: 2019-04-21T00:26:13Z
closed_at: 2019-04-21T00:25:53Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1766
type: pull
body:
  - Add shirts and pants to loot drop
  - Change weapon damage to be based upon wield difficulty, instead of tier number
  - Lower Essence drop rate to ~17%
  - Convert a number of magic numbers to descriptive, enum based values

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1766/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTUzNTk3
title: physics gc cleanup
state: closed
created_at: 2019-04-20T13:33:19Z
updated_at: 2019-04-20T22:14:08Z
closed_at: 2019-04-20T22:14:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1767
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1767/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTUzODk4
title: DamageHistory no longer holds references to WorldObjects
state: closed
created_at: 2019-04-20T13:39:54Z
updated_at: 2019-04-23T02:31:18Z
closed_at: 2019-04-23T02:31:01Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1768
type: pull
body:
  This still needs more testing, mainly with healing, spells that cause self harm, etc..

  This fixes the issue where DamageHistory was holding onto strong references to WorldObjects. This was mostly a problem when they were holding onto references to a Player. That would prevent the Player (and their session) from being cleaned up.

  This is further a problem because a monster could hold onto these references indefinitely if they are never attacked again, but kept alive.

  Attacking a monster is what causes DamageHistory pruning. It's possible that this could be switched to a check on creature Tick(). I'm not sure what is more performant.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1768/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTcxMzA4
title: Loot Colors
state: closed
created_at: 2019-04-20T19:06:51Z
updated_at: 2019-04-20T22:17:28Z
closed_at: 2019-04-20T22:17:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1769
type: pull
body:
  Added loot color randomization and proper material generation to LootGenerationFactory

  **Note that this update requires _Database/Updates/World/2019-04-20-00-Treasure-Materials.sql_ to be applied.**

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1769/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTcyMTAw
title: Fix Quest, corpse and chest issues
state: closed
created_at: 2019-04-20T19:22:56Z
updated_at: 2019-05-20T16:46:54Z
closed_at: 2019-04-20T22:12:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1770
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1770/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTg0MDEz
title: Revert "Loot Colors (#1769)"
state: closed
created_at: 2019-04-20T23:53:01Z
updated_at: 2019-05-20T16:47:23Z
closed_at: 2019-04-20T23:54:53Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1771
body: This reverts commit 5acf14c78770eb0d26a7f48fbfded97603582843.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1771/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTg0MDU1
title: Revert "Loot Colors"
state: closed
created_at: 2019-04-20T23:54:14Z
updated_at: 2019-04-20T23:57:58Z
closed_at: 2019-04-20T23:54:34Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1772
body: Reverts ACEmulator/ACE#1769
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1772/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTg2MjIz
title: LootGen Changes/fixes
state: closed
created_at: 2019-04-21T00:54:25Z
updated_at: 2019-04-21T03:13:54Z
closed_at: 2019-04-21T02:15:21Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1773
type: pull
body:
  - Add shirts and pants to loot drop
  - Change weapon damage to be based upon wield difficulty, instead of tier number
  - Lower Essence drop rate to ~17%
  - Convert a number of magic numbers to descriptive, enum based values

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1773/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTg4OTMx
title: Fix some issues with hotspots
state: closed
created_at: 2019-04-21T02:15:12Z
updated_at: 2019-05-20T16:47:21Z
closed_at: 2019-04-21T04:02:04Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1774
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1774/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTkzMDk5
title: Loot colors
state: closed
created_at: 2019-04-21T04:23:04Z
updated_at: 2020-06-15T20:59:12Z
closed_at: 2019-04-21T07:01:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1775
body: Colors 2: Electric Boogaloo
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1775/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMTk5ODQ1
title: Add missing Missile DamageMod property for loot gen
state: closed
created_at: 2019-04-21T07:43:51Z
updated_at: 2019-04-23T20:10:58Z
closed_at: 2019-04-21T20:57:50Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1776
type: pull
body:
  - Add missing Missile DamageMod property for loot gen missile weapons
  - Rearrange some methods to align with their intended focus
  - Add new CreateWeapon() method that gives, as of this PR, equal chance for a melee, missile weapon, or caster, instead of casters and missile weapons being an afterthought for selection against the high numbers of melee weapons

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1776/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMjQwNDc1
title: Misc changes to scribe functions
state: closed
created_at: 2019-04-21T20:49:57Z
updated_at: 2019-05-20T16:47:20Z
closed_at: 2019-04-22T03:32:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1777
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1777/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMzAyMjcz
title: fixing /hr for some apartments
state: closed
created_at: 2019-04-22T07:33:18Z
updated_at: 2019-04-23T00:49:18Z
closed_at: 2019-04-23T00:49:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1778
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1778/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMzMzMTM4
title: updating tinkering message to match retail, adding /cisalvage
state: closed
created_at: 2019-04-22T10:05:22Z
updated_at: 2019-04-23T06:19:00Z
closed_at: 2019-04-23T06:18:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1779
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1779/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMzY5OTY3
title: AdjustCells cleanup
state: closed
created_at: 2019-04-22T13:14:04Z
updated_at: 2019-04-23T05:16:44Z
closed_at: 2019-04-23T05:16:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1780
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1780/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyMzk1NTYz
title: Change switch statement, as light daggers are multistrike
state: closed
created_at: 2019-04-22T14:50:46Z
updated_at: 2019-04-23T20:10:56Z
closed_at: 2019-04-23T00:49:25Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1781
body: - Correct switch statement in Loot gen code, as Light daggers currently in ACE are multi-strike
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1781/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNTMyNDMz
title: Shade adjustments
state: closed
created_at: 2019-04-22T23:05:28Z
updated_at: 2020-06-15T20:59:13Z
closed_at: 2019-04-22T23:51:22Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1782
type: pull
body:
  * Fixed shade/palette calculation and validated against retail pcap logs
  * Added Shade2, Shade3, Shade4 support (nothing in the data currently uses these)
  * Removed "(based on STRENGTH 100)" from missile weapons. 

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1782/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNTUxNjU1
title: Fixing spirit essence busy state
state: closed
created_at: 2019-04-23T01:12:21Z
updated_at: 2019-04-23T05:16:54Z
closed_at: 2019-04-23T05:16:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1783
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1783/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNTYyNDQ0
title: Initial fix for item heartbeats
state: closed
created_at: 2019-04-23T02:28:46Z
updated_at: 2019-04-24T03:58:20Z
closed_at: 2019-04-24T03:58:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1784
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1784/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNTc1NDkz
title: network layer reduction
state: closed
created_at: 2019-04-23T04:01:32Z
updated_at: 2019-04-23T23:11:35Z
closed_at: 2019-04-23T23:11:35Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1785
type: pull
body:
  - [x] Combine as many classes as possible without violating KISS or "the pattern"
  - [x] Implement I/O queues
  - [ ] Test mass connections and correct shortcomings of the implementation during extreme conditions 
  - [ ] To prevent flooding, Implement inbound session packet governor and find threshold
      -  proportionate to number of sessions?
  - [ ] To prevent flooding, Implement `ProcessFragment` governor and find threshold
      -  proportionate to number of sessions?
  - [ ] `ProcessFragment` needs to be a producer for game loop consumer, game loop consumer pull X number of messages to keep server loop tight (500? 1000? more?)
  - [ ] S2C Retransmission request fulfillment, or C2S NAK, needs to have complexity added
      - if the packet being retransmitted contains physics data, that physics data needs to be replaced with the latest version sent if the latest version is not the one in the original packet.
  - [ ] Outbound queue needs an independent consumer thread, there should be no reason to send via game loop in bursts every game iteration, outbound can be constant
      - process outbound messages to players
      - add messages to outbound packets until 484 size reached or every 66ms
      - continue creating packets until outbound cleared
      - Outbound fragment bundling needs to be reduced to a single collection, as it adds unnecessary complexity at the cost of readability, understandability, and changeability without actually adding any benefit or working towards a required specification or towards an architectural norm.  Since outbound queue will be sent by the fluidity of the independent consumer thread combined with the capabilities of the average modern internet connection fragment prioritization by queue or any other need for grouping them together is probably not needed, but I could be mistaken.  Comments about this are most welcome.
  - [ ] Sessions should only be created upon authentication success, reducing the abuse potential and increasing network layer fitness.
      - the cookie in the cookie exchange can be a constant, eliminating the need for a state machine during authentication, it doesn't actually provide any security or stability related benefits.
      - port 9001 listener can/should be omitted as it adds unnecessary complexity at the cost of readability, understandability, and changeability.
          - without the 9001 listener the client will time out trying to send `ConnectionResponse` to 9001 at the routing level almost immediately, and the client will enter port 9000 only mode, and then sends it to 9000
      - session keys should consist of `IP Address | Port` combined into a Unt64, `Uint64 where the top32 is the IP and bottom 32 is the port` 
          - prevents problems observed during authentication due to the race conditions provided by pre-authenticated connections
      - first packet analysis consists of the following:

          1. a 1 btye packet from an IP to port 9000 or 9001 is a valid request.  but the parsing of that packet shows its bad so the whole thing is to be tossed
          2. a mutliple connection packet attack from the same clientfrom same port should be ignored and/or flagged for spamming to be banned
          3. a mutliple connection packet attack from the same client on different ports for same account should be flagged for spamming to be banned, but most recent should be honored
          4. bans are IP as well as account based
          5. you check IP ban first then account
          6. before the server acknowodges anything to client it has to run through those checks
          7. and only when the server considers everything ok, then the session is added and the S2C is sent

  - [ ] `FindOrCreateSession` needs to have a lock around the entire body of the function
      - Allows seamless handling of single account, multiple session, during times of great contention

  misc fixes:

  - boot command via console causes exception because session is not null in audit call
  - abnormal sequence detection
      - terminate session upon detection

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1785/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNTc4NTY2
title: Add IOU trade in support
state: closed
created_at: 2019-04-23T04:23:55Z
updated_at: 2019-05-20T16:47:20Z
closed_at: 2019-04-23T18:39:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1786
type: pull
body:
  * `iou_trades` property must be enabled (true)
  * Hand any IOU to a Town Crier and it will turn it into real item if that item is now in DB
  * also fix corpse decay for empty corpses

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1786/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNjI5MjU3
title: Adjust wield requirements and method used
state: closed
created_at: 2019-04-23T08:23:41Z
updated_at: 2019-04-23T20:10:55Z
closed_at: 2019-04-23T18:38:05Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1787
type: pull
body:
  - Adjust wield requirement RNG roll from 0, 100 to 1, 100
  - Remove extra, unneeded ThreadSafeRandom.Next(), as it only gets called once per run of GetWield()
  - Tweak magic caster requirement chances per tier, especially to remove lesser wield requirement values from higher tier loot

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1787/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyNzg3OTM1
title: fixing disappearing items for giving partial stacks
state: closed
created_at: 2019-04-23T15:42:26Z
updated_at: 2019-04-23T18:39:23Z
closed_at: 2019-04-23T18:39:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1788
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1788/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyODQ5MjM0
title: Changes related to Event Generators
state: closed
created_at: 2019-04-23T18:46:32Z
updated_at: 2019-05-20T16:47:18Z
closed_at: 2019-04-24T03:51:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1789
type: pull
body:
  * Changed loot to drop to ground if NoCorpse is true for creatures
  * Broadcast CasterEffect if spell has one for all to see (if creature is visible)
  * Change Generators enable/disable to staged: change occurs on 2nd heartbeat, 1st detects the change and arms.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1789/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTA0NDk1
title: Re-add random colors to clothing loot gen
state: closed
created_at: 2019-04-23T21:46:11Z
updated_at: 2020-06-15T20:59:16Z
closed_at: 2019-04-24T01:32:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1790
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1790/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTQxOTY5
title: sequence validation and negative response
state: closed
created_at: 2019-04-24T01:09:58Z
updated_at: 2019-04-24T01:47:46Z
closed_at: 2019-04-24T01:47:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1791
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1791/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTQ1NjY3
title: fixed during great stress stack overflow exception at listener thread
state: closed
created_at: 2019-04-24T01:36:22Z
updated_at: 2019-07-08T13:38:18Z
closed_at: 2019-07-08T13:38:18Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1792
body:
  exception destroys the listener and crashes the server
  added ignorance for certain socket errors

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1792/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTQ3MDA3
title: fixed boot command throwing exception when used at console
state: closed
created_at: 2019-04-24T01:45:39Z
updated_at: 2019-04-24T06:27:51Z
closed_at: 2019-04-24T06:27:51Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1793
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1793/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTQ5ODUw
title: replaced character errors with confirmed working list
state: closed
created_at: 2019-04-24T02:05:23Z
updated_at: 2019-04-24T06:25:24Z
closed_at: 2019-04-24T06:25:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1794
type: pull
body:
  added element descriptions copied from old comments
  confirmed AccountInUse and Undefined are not real character errors

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1794/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTU1MzMw
title: adding allegiance name to appraisals
state: closed
created_at: 2019-04-24T02:42:27Z
updated_at: 2019-04-24T03:58:46Z
closed_at: 2019-04-24T03:58:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1795
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1795/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTcyNTY0
title: Adding /ciloot dev command
state: closed
created_at: 2019-04-24T04:40:19Z
updated_at: 2019-04-24T06:03:08Z
closed_at: 2019-04-24T06:03:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1796
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1796/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzY0OTQwMTQ=
title: Loot generator is failing to spawn many items
state: closed
created_at: 2019-04-24T04:41:13Z
updated_at: 2019-04-26T05:48:45Z
closed_at: 2019-04-26T05:48:45Z
author_association: COLLABORATOR
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [x ] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  With https://github.com/ACEmulator/ACE/pull/1796 installed, /ciloot &lt;tier&gt; &lt;# of items&gt;

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->
  - LootGenerationFactory.CreateRandomLootObjects should never return null object

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1797/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTc2OTE3
title: GiveObjectToPlayer fixes
state: closed
created_at: 2019-04-24T05:10:39Z
updated_at: 2019-05-20T16:47:17Z
closed_at: 2019-04-24T05:24:31Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1798
type: pull
body:
  * Send contents of container when given one by a player
  * Attempt to return failed given item back to giver

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1798/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTc3NDc0
title: adding GetBlockDist
state: closed
created_at: 2019-04-24T05:14:19Z
updated_at: 2019-04-24T05:21:59Z
closed_at: 2019-04-24T05:21:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1799
type: pull
body:
  This adds some protection against some extreme transition scenarios / feeding bad transitions to the physics engine

  This can prevent some CPU lockups for ranged monsters taking aim at the player, and then the player portals away

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1799/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTgzMzk5
title: Fixed Gems not dropping in loot
state: closed
created_at: 2019-04-24T05:49:07Z
updated_at: 2020-06-15T20:59:16Z
closed_at: 2019-04-24T06:03:16Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1800
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1800/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTg2OTAx
title: Fix wonky mana on Missile weapons in LootGen
state: closed
created_at: 2019-04-24T06:07:42Z
updated_at: 2019-05-20T16:47:16Z
closed_at: 2019-04-24T06:11:02Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1801
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1801/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjcyOTk3MTE1
title: Fix crash on null CurrentMotionState
state: closed
created_at: 2019-04-24T06:52:25Z
updated_at: 2019-05-20T16:47:16Z
closed_at: 2019-04-24T07:08:00Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1802
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1802/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczMDI1NTU3
title: Loot refactoring - Clothing
state: closed
created_at: 2019-04-24T08:27:35Z
updated_at: 2019-04-25T18:11:03Z
closed_at: 2019-04-25T05:43:56Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1803
type: pull
body:
  - Refactored LootGenerationFactory_Clothing.cs
  - Attempt to normalize AL values
  - Use builtin clothing/armor ArmorModVs values
  - Remove Incantation of Defenselessness Self from loot and replace with Incantation of Missile Mastery Self

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1803/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczMDkzODQz
title: Testing: ShardDbContextWithFinalize Test
state: closed
created_at: 2019-04-24T11:45:31Z
updated_at: 2019-06-19T01:08:57Z
closed_at: 2019-04-28T17:17:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1804
type: pull
body:
  DbContext does not implement a finalizer, so nothing to call Dipose() for us if we fail to do so ourselves (which we are currentlyl...)

  This is just a test to see if it helps CE memory usage

  This might actually be good for master, but, on windows server core 2016, i haven't noticed the need to explicitly add the finalizer. Even without it, my objects seem to get cleaned up. Could just be my test environment isn't exaggerating the underlying issue though.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1804/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczMjM5NDU1
title: Add support for AwardXP "spending" xp
state: closed
created_at: 2019-04-24T17:56:46Z
updated_at: 2019-05-20T16:47:13Z
closed_at: 2019-04-25T05:43:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1805
body:
  Only known use case:
  Blank Augmentation Gem -> Donatello Linante -> Asheron's Lesser Benediction

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1805/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0MzcyMDgzNDY=
title: Spells on Stave of Palenqual and Puppeteer's Skull not implemented yet
state: open
created_at: 2019-04-25T13:45:41Z
updated_at: 2019-05-21T05:19:08Z
author_association: NONE
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [x] bug report -> please search issues before submitting
  - [x] feature request
  ```

  The [Stave of Palenqual](http://acpedia.org/wiki/Stave_of_Palenqual) (using the version with Avalanche added) and [Puppeteer's Skull](http://acpedia.org/wiki/Puppeteer's_Skull) both throw "Avalanche/Wrath of the Puppeteer not implemented, yet!" errors on attempting to use their respective built in spells.

  The Stave of Palenqual also seems to fizzle when attempting to cast it on monsters or NPCs. It only follows through to the "* not implemented, yet!" when attempting to cast it on another player character. 

  The [Virindi Implant (Purple)](http://acpedia.org/wiki/Virindi_Implant_(Purple)) seems to have a similar problem with fizzling on targets other than players.

  ### Repro steps.
  <!-- Please list the steps to reproduce a bug here -->

  ### The log given by the failure.
  <!-- Normally this include a stack trace and some other information about the failure. -->

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  <!-- Please include any information that can help clarify the request here -->

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1806/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczNTYwODg3
title: Covenant Armor, default Material Type, and thrown weapons
state: closed
created_at: 2019-04-25T14:53:43Z
updated_at: 2019-04-29T20:44:43Z
closed_at: 2019-04-27T05:37:42Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1807
type: pull
body:
  - Add Covenant Armor
  - Add setting of a default Material Type
  - Add Thrown weapons

  **Caveat: flatware won't appraise correctly and are currently infinite usage**

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1807/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczNzQ5MTc5
title: Fix some issues with crafting
state: closed
created_at: 2019-04-26T03:27:10Z
updated_at: 2019-05-20T16:47:14Z
closed_at: 2019-04-26T17:06:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1808
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1808/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczNzU0NDk0
title: sorting appraisal properties to better match up with client hashtables
state: closed
created_at: 2019-04-26T04:05:06Z
updated_at: 2019-04-27T05:37:59Z
closed_at: 2019-04-27T05:37:59Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1809
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1809/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczODEzNzQx
title: ensuring self spells are never resisted
state: closed
created_at: 2019-04-26T08:51:35Z
updated_at: 2019-04-27T05:38:09Z
closed_at: 2019-04-27T05:38:09Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1810
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1810/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczODQwOTk1
title: fixing slippery item drop / rares popping when looted
state: closed
created_at: 2019-04-26T10:14:40Z
updated_at: 2019-04-27T05:38:19Z
closed_at: 2019-04-27T05:38:19Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1811
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1811/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczODQxNzk0
title: possible cheap fix for IsBusy state OnDeath
state: closed
created_at: 2019-04-26T10:17:12Z
updated_at: 2019-04-27T05:38:30Z
closed_at: 2019-04-27T05:38:30Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1812
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1812/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjczOTEwMzky
title: Testing: Only track Player biotas
state: closed
created_at: 2019-04-26T14:03:04Z
updated_at: 2019-05-01T12:56:27Z
closed_at: 2019-05-01T12:56:17Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1813
type: pull
body:
  This should free up a lot of the EF tracking resources that we're seeing being consumed by CE

  ** THIS NEEDS TESTING **

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1813/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MDMyMTk5
title: Add check for RecallsDisabled to command recalls
state: closed
created_at: 2019-04-26T20:49:34Z
updated_at: 2019-05-20T16:47:12Z
closed_at: 2019-04-27T05:44:51Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1814
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1814/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MDkzOTk1
title: elemental damage bonus refactoring
state: closed
created_at: 2019-04-27T09:09:35Z
updated_at: 2019-04-28T06:52:50Z
closed_at: 2019-04-28T06:52:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1815
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1815/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTE2NzQ0
title: Yoroi Sleeves
state: closed
created_at: 2019-04-27T16:17:06Z
updated_at: 2019-04-29T20:44:45Z
closed_at: 2019-04-27T20:23:18Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1816
body: - Updated loot table with correct weenie to drop Yoroi Sleeves
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1816/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTE5OTY4
title: Fixing monster retired skill #s
state: closed
created_at: 2019-04-27T17:08:36Z
updated_at: 2019-04-28T05:30:46Z
closed_at: 2019-04-28T05:30:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1817
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1817/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTIyOTI4
title: more apartment fixes for empyreans
state: closed
created_at: 2019-04-27T17:59:50Z
updated_at: 2019-04-28T05:30:55Z
closed_at: 2019-04-28T05:30:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1818
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1818/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTIzMjk1
title: removing leader from disbanded fellowship
state: closed
created_at: 2019-04-27T18:05:37Z
updated_at: 2019-04-28T05:31:08Z
closed_at: 2019-04-28T05:31:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1819
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1819/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTI0NDY0
title: Misc updates
state: closed
created_at: 2019-04-27T18:27:36Z
updated_at: 2019-05-20T16:47:11Z
closed_at: 2019-04-28T06:02:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1820
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1820/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTUyMjE4
title: Remove incorrectly added thrown weapons from loot gen
state: closed
created_at: 2019-04-28T04:58:45Z
updated_at: 2019-04-29T20:44:46Z
closed_at: 2019-04-28T06:16:38Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1821
type: pull
body:
  - Remove throwing spikes, daggers, axes, etc, that are stackable items from loot generator, as they were only obtainable by crafting, store bought, or as trophy drops

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1821/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTU3MTYx
title: improving /debugdamage for admins
state: closed
created_at: 2019-04-28T06:50:11Z
updated_at: 2019-04-28T06:59:26Z
closed_at: 2019-04-28T06:59:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1822
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1822/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTU5MzM1
title: fix combining older bags of mahogany salvage
state: closed
created_at: 2019-04-28T07:31:51Z
updated_at: 2019-04-28T07:37:10Z
closed_at: 2019-04-28T07:37:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1823
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1823/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MTc1MzM4
title: fixing some combat lockups after healing, particularly with vtank + missile
state: closed
created_at: 2019-04-28T12:06:56Z
updated_at: 2019-04-28T22:34:31Z
closed_at: 2019-04-28T22:34:31Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1824
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1824/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MjA4MzE4
title: fixing mods for various recipes (keyrings)
state: closed
created_at: 2019-04-28T20:57:27Z
updated_at: 2019-04-28T22:34:38Z
closed_at: 2019-04-28T22:34:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1825
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1825/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MjM1NDg5
title: Fix Some Container Issues
state: closed
created_at: 2019-04-29T03:28:54Z
updated_at: 2019-05-20T16:47:09Z
closed_at: 2019-04-29T03:33:18Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1826
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1826/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0MjU1NzM5
title: Rebase SQL files
state: closed
created_at: 2019-04-29T06:23:00Z
updated_at: 2019-05-20T16:47:06Z
closed_at: 2019-04-29T09:56:34Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1827
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1827/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0NDYxNDUw
title: Align Scroll loot with wiki
state: closed
created_at: 2019-04-29T17:38:49Z
updated_at: 2019-04-29T20:44:48Z
closed_at: 2019-04-29T18:53:21Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1828
body: - Align Scroll loot with wiki
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1828/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0NDcxNjc4
title: Add support for preloading landblock groups
state: closed
created_at: 2019-04-29T18:12:55Z
updated_at: 2019-05-20T16:47:05Z
closed_at: 2019-04-29T18:53:07Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1829
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1829/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0NDkxMzg1
title: fix apartment loading
state: closed
created_at: 2019-04-29T19:17:47Z
updated_at: 2019-04-29T19:33:44Z
closed_at: 2019-04-29T19:33:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1830
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1830/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0NTQyMzkx
title: fixing stack values for death items
state: closed
created_at: 2019-04-29T22:16:48Z
updated_at: 2019-05-01T09:38:50Z
closed_at: 2019-05-01T09:38:50Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1831
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1831/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0NjE2MTE4
title: Wire up Ivory salvage application
state: closed
created_at: 2019-04-30T06:56:31Z
updated_at: 2019-05-01T00:54:36Z
closed_at: 2019-05-01T00:50:18Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1832
body: - Add ability to apply Ivory salvage to Attuned items
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1832/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0NzA5NDQ5
title: Upgrade to .NET Core 2.2.1 (VS 2017 compatible)
state: closed
created_at: 2019-04-30T12:25:19Z
updated_at: 2019-07-10T11:24:23Z
closed_at: 2019-07-10T11:24:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1833
type: pull
body:
  This also updates all other nuget packages to latest.

  The EF database packages are updated to 2.2.0 because that is the latest pomelo (our database driver) currently supports.

  This is an effort to help fix the CE issues

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1833/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0Nzc5ODIw
title: Release NetworkSession resources when a session drops
state: closed
created_at: 2019-04-30T15:28:56Z
updated_at: 2019-05-01T12:55:57Z
closed_at: 2019-05-01T12:55:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1834
type: pull
body:
  This is a simple patch to help CE mem usage. The proper fix is to funnel NetworkSession work through Session, so that Session can manage it's state directly.

  What is happening now, and can/will happen in the future, is that Player references are being held, and thus, their Session and NetworkSession objects aren't being released.

  Even after a Session drops, work can still be enqueued onto NetworkSession through ActionChains and other means. This PR will now ignore that work. Currently, in master, that work is received and held indefinitely (until Player/Session are released)

  This also fixes the case where NetworkSession work was being enqueued after a session dropped, but before the Player was fully logged out of the world. Now, that work will be ignored.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1834/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0ODM2NjM4
title: update changelog for april
state: closed
created_at: 2019-04-30T18:20:42Z
updated_at: 2019-04-30T20:39:49Z
closed_at: 2019-04-30T20:39:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1835
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1835/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0OTUxNjgz
title: Adjustments for matching retail corpse rare generation notifications
state: closed
created_at: 2019-05-01T04:02:42Z
updated_at: 2019-05-20T16:47:04Z
closed_at: 2019-05-01T15:19:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1836
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1836/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0OTU2NDk5
title: Change RecipeManager.ModifyX to follow rules of operation
state: closed
created_at: 2019-05-01T04:56:01Z
updated_at: 2019-05-20T16:46:49Z
closed_at: 2019-05-02T00:44:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1837
body: This swap fixes mods for dyeing
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1837/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc0OTgyOTQ2
title: excluding combat pets from some cleave damage
state: closed
created_at: 2019-05-01T08:40:50Z
updated_at: 2019-05-02T09:34:21Z
closed_at: 2019-05-02T09:34:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1838
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1838/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1MDEwOTg3
title: fixing extra pack slot
state: closed
created_at: 2019-05-01T11:42:52Z
updated_at: 2019-05-02T09:34:29Z
closed_at: 2019-05-02T09:34:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1839
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1839/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1MDU2Mzc0
title: updating enchantment masks
state: closed
created_at: 2019-05-01T15:08:42Z
updated_at: 2019-05-02T09:34:36Z
closed_at: 2019-05-02T09:34:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1840
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1840/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1MDk0OTI3
title: updating trade for some decal plugins
state: closed
created_at: 2019-05-01T17:29:23Z
updated_at: 2019-07-05T21:19:41Z
closed_at: 2019-05-04T15:16:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1841
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1841/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1MTIwMTQx
title: fix summoning loc
state: closed
created_at: 2019-05-01T18:54:46Z
updated_at: 2019-05-02T09:37:43Z
closed_at: 2019-05-02T09:37:43Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1842
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1842/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1MjIyNzE3
title: Some CombatPet tweaks
state: closed
created_at: 2019-05-02T03:11:53Z
updated_at: 2019-05-20T16:46:47Z
closed_at: 2019-05-03T04:47:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1843
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1843/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1MjYzMDY4
title: Some Housing Changes
state: closed
created_at: 2019-05-02T07:47:30Z
updated_at: 2019-05-20T16:46:48Z
closed_at: 2019-05-02T16:24:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1844
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1844/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1Mjk4OTU1
title: possible fix for rare damage spikes
state: closed
created_at: 2019-05-02T09:56:11Z
updated_at: 2019-05-03T20:40:16Z
closed_at: 2019-05-03T20:40:16Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1845
type: pull
body:
  This looks like it might fix the bug where some players were occasionally getting hit in rare instances for 400+ by Olthoi Rippers and Biakas

  GetArmorLayers() is a very old function, and was originally written to use the current AttackTarget of the monster. I left a comment in DamageEvent when I realized this might be unsafe, but now we might see some possible ramifications of this

  When the monster AI was updated much later for switching targets in functions like FindNextTarget(), the current execution of this target switching might need to be more tightly clamped to certain states. What I think is happening is, monsters are switching targets in the middle of an attack (ie. maybe they start swinging at a player, and then maybe they re-target a nearby summoned mob before their attack hits the player). DamageEvent.PlayerDefender would still be the original intended target in this case, but Monster.AttackTarget would be pointing to the new target, and this discrepancy might lead to errors

  The monster AI code should eventually be reviewed to see anywhere else it might use AttackTarget after an actionchain delay, and either update those portions, or have more state conditions in FindNextTarget, as mention previously

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1845/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1Mzc4Njkw
title: Testing: /corpsedebuginfo
state: closed
created_at: 2019-05-02T14:07:28Z
updated_at: 2019-05-12T22:51:13Z
closed_at: 2019-05-03T13:31:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1846
body: PR to help find out what's going on with corpses and why they're not being released.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1846/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1NTc5MDQ0
title: Fix free inventory slot count
state: closed
created_at: 2019-05-03T02:57:47Z
updated_at: 2019-05-03T03:18:38Z
closed_at: 2019-05-03T03:18:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1847
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1847/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1Nzk2NDY1
title: Fix Existing Jewelry objects in Shard DB
state: closed
created_at: 2019-05-03T17:49:13Z
updated_at: 2019-05-20T16:46:46Z
closed_at: 2019-05-04T00:01:44Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1848
type: pull
body:
  * Add fix up SQL script (2019-05-03-00-Fix_Biota_Jewelry_WeenieType.sql) for existing servers to run to correct jewelry WeenieType on existing items.
    - This script will only need to be run once and only fixes incorrect objects.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1848/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1ODk0NjI0
title: Updates for CombatPet
state: closed
created_at: 2019-05-04T04:10:59Z
updated_at: 2019-05-06T01:42:06Z
closed_at: 2019-05-04T15:36:27Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1849
type: pull
body:
  - Update Geomancer Golems to actual weenies
  - Add option to enable CombatPets to cast spells, as a first step for Advanced Combat Pets, that is defaulted to off

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1849/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1OTAyODM5
title: Update Appraisal Output
state: closed
created_at: 2019-05-04T07:26:34Z
updated_at: 2019-05-20T16:46:45Z
closed_at: 2019-05-04T15:38:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1850
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1850/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1OTA1NTQ4
title: Set player masteries at character creation
state: closed
created_at: 2019-05-04T08:23:52Z
updated_at: 2019-05-06T01:42:04Z
closed_at: 2019-05-05T04:35:21Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1851
type: pull
body:
  - Set player masteries at character creation for melee and ranged
  - Add ability for summoning mastery to be displayed in client but not set at character creation, as that should be controlled by player choice, starting at level 50

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1851/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1OTI5ODE1
title: fixing AddToTrade delay for decal plugins
state: closed
created_at: 2019-05-04T15:46:14Z
updated_at: 2019-05-05T16:40:47Z
closed_at: 2019-05-05T16:40:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1852
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1852/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc1OTM4Mjgw
title: Fixing appraisal display for items with built-in defender spells
state: closed
created_at: 2019-05-04T18:03:35Z
updated_at: 2019-05-05T16:40:58Z
closed_at: 2019-05-05T16:40:57Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1853
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1853/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MDA5Mjc1
title: updating accept/reset trade guids for skunkworks
state: closed
created_at: 2019-05-05T16:36:07Z
updated_at: 2019-05-07T04:10:17Z
closed_at: 2019-05-07T04:10:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1854
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1854/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MDIwMzgw
title: prototype: adding account-wide house recall / permissions
state: closed
created_at: 2019-05-05T19:35:30Z
updated_at: 2019-07-09T12:23:48Z
closed_at: 2019-07-01T07:36:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1855
body: needs more research into 'roommates' structure next...
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1855/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MDIxMzQ5
title: misspelling
state: closed
created_at: 2019-05-05T19:51:19Z
updated_at: 2019-05-07T04:10:47Z
closed_at: 2019-05-07T04:10:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1856
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1856/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MDI0NTQ4
title: adjusting some aug bonus calcs
state: closed
created_at: 2019-05-05T20:40:23Z
updated_at: 2019-05-07T04:10:56Z
closed_at: 2019-05-07T04:10:55Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1857
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1857/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MDUzNDM2
title: updating fellowship hashtable to match client
state: closed
created_at: 2019-05-06T03:33:13Z
updated_at: 2019-05-07T04:11:04Z
closed_at: 2019-05-07T04:11:04Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1858
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1858/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MDYwNDA2
title: Add ACE Weenie to LSD Weenie converter
state: closed
created_at: 2019-05-06T04:41:16Z
updated_at: 2019-05-20T16:46:44Z
closed_at: 2019-05-07T03:48:51Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1859
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1859/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MzA3Nzky
title: Add missing new skill spells and cantrips for loot drops
state: closed
created_at: 2019-05-06T19:41:14Z
updated_at: 2019-05-08T02:24:36Z
closed_at: 2019-05-07T01:26:30Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1860
body: - Add missing new skill spells and cantrips to appropriate spell tables for armor item loot drops
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1860/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2MzE3OTM4
title: fixing AllegianceUpdate parsing for decal
state: closed
created_at: 2019-05-06T20:14:01Z
updated_at: 2019-05-07T04:22:12Z
closed_at: 2019-05-07T04:22:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1861
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1861/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2NDM5MjAy
title: Rein In Excessive Max Mana on items
state: closed
created_at: 2019-05-07T04:58:16Z
updated_at: 2019-05-08T02:24:35Z
closed_at: 2019-05-07T14:04:45Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1862
body: - Rein In Excessive Max Mana on items
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1862/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDE0MjE0NTY=
title: Add missing armor cantrip spells
state: closed
created_at: 2019-05-07T20:02:51Z
updated_at: 2019-05-12T20:25:31Z
closed_at: 2019-05-12T20:25:31Z
author_association: CONTRIBUTOR
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [x] feature request
  ```

  ### Desired functionality.
  There are currently many missing cantrip spells from armor pieces. For example, only head/gaunts can come with cantrips for war magic, or have focus on them. All of the armor pieces should be eligible for all of the spells that can come on any armor coverage, rather than select spells being candidates for only some armor coverage.

  ### Mention any other details that might be useful.
  See LootTables.cs and compare HeadCantrips vs. UpperLegCantrips

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1863/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2NzU0MzA2
title: standardized spells and cantrips for armor pieces
state: closed
created_at: 2019-05-07T20:09:59Z
updated_at: 2019-05-08T00:10:55Z
closed_at: 2019-05-08T00:10:55Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1864
type: pull
body:
  There are currently many missing cantrip spells from armor pieces. For example, only head/gaunts can come with cantrips for war magic, or have focus on them. All of the armor pieces should be eligible for all of the spells that can come on any armor coverage, rather than select spells being candidates for only some armor coverage.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1864/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc2ODE3NTgw
title: Little bit of LootGen code cleanup
state: closed
created_at: 2019-05-08T00:46:44Z
updated_at: 2019-05-08T02:24:29Z
closed_at: 2019-05-08T02:18:45Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1865
body: - Remove some extra unneeded code from the clothing/armor loot gen
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1865/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3MDc5Njk2
title: excluding augs from SkillAlterationDevice spec count
state: closed
created_at: 2019-05-08T17:11:03Z
updated_at: 2019-05-11T18:07:34Z
closed_at: 2019-05-11T18:07:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1866
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1866/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3MDk0Nzg1
title: adding in missing scroll drops
state: closed
created_at: 2019-05-08T17:59:05Z
updated_at: 2019-05-08T18:43:06Z
closed_at: 2019-05-08T18:43:06Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1867
type: pull
body:
  life vulns, heals, stams, s2m, infuses, item aura others

  still need the inepts for creature and maybe a few more stragglers

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1867/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3MTk5Njcz
title: add rest of scrolls in loot
state: closed
created_at: 2019-05-08T23:41:32Z
updated_at: 2019-05-10T17:23:43Z
closed_at: 2019-05-10T17:23:43Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1868
body: fix what errors i did find and add rest of the scrolls to the loot table
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1868/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3MjA1NDQx
title: Adjust Compare in Fellowship Full Update
state: closed
created_at: 2019-05-09T00:15:26Z
updated_at: 2019-05-20T16:46:40Z
closed_at: 2019-05-09T05:53:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1869
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1869/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3NDU0OTcy
title: Fix concurrency issue in DelayAction
state: closed
created_at: 2019-05-09T16:07:13Z
updated_at: 2019-05-09T23:51:27Z
closed_at: 2019-05-09T23:50:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1870
body: volatile is not the proper way to handle this, interlocked is.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1870/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3NjAyNTcx
title: Generators shouldn't hold strong references to their spawn
state: closed
created_at: 2019-05-10T01:35:22Z
updated_at: 2019-05-10T10:33:39Z
closed_at: 2019-05-10T10:31:37Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1871
type: pull
body:
  This changes the spawn references generators hold to WeakReferences.

  Generators should not hold strong (concrete) references to their spawn. Nor should their spawn be required to clear their existence from their parent generator on destruction.

  Here is what was happening:

  Generators are queuing delayed actions for themselves. These actions can be several to many minutes out depending on the emote. These actions sit in WorldManager.DelayManager until they are run. Because they sit in that queue, they hold onto the underlying GenericWorldObject, and, because that's being held, the generator holds onto all their spawn.

  This fix allows those spawn to be garbage collected.

  The GenericWorldObjects are still held onto until their actions are run. There are ways to fix that as well, but, it comes at a performance cost. I'd like to see how this impacts CE before investigating further optimizations here.

  Overall, this should provide a big boost to CE.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1871/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3NjQ3MzQ1
title: Skill XP Rank increases
state: closed
created_at: 2019-05-10T06:33:14Z
updated_at: 2019-05-10T19:53:31Z
closed_at: 2019-05-10T19:53:02Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1872
body: - Rough fix to SpendSkillXP for arbitrary Rank increases
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1872/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3NjU4ODY1
title: Change Item Pickup From Generators
state: closed
created_at: 2019-05-10T07:21:19Z
updated_at: 2019-05-20T16:46:40Z
closed_at: 2019-05-10T17:37:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1873
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1873/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3NzY0OTE4
title: Switch Generators from DelayManager to local queue using the existing 5s HeartBeat
state: closed
created_at: 2019-05-10T13:13:08Z
updated_at: 2019-05-10T23:38:40Z
closed_at: 2019-05-10T23:38:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1874
type: pull
body:
  This is the second part of the Generator fix which allows Generators to be garbage collected as soon as the landblock unloads.

  When a Generator receives a NotifyGenerator event, it waits "Delay" before that spawn is actually released.

  Currently, that work is enqueued using DelayManager.

  In this PR, that work is enqueued in a local Queue that is checked every ~5s HeartBeat.

  - Without this fix, generators must wait until their delayed actions are run via DelayManager, and then can be collected.
  - With this fix, generators can now be garbage collected as soon as the landblock is unloaded.

  This also merges the Delay calculation code into a single property.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1874/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3ODY0NjQz
title: Change CreateListSelect to be more inclusive
state: closed
created_at: 2019-05-10T18:16:21Z
updated_at: 2019-05-20T16:46:39Z
closed_at: 2019-05-10T23:56:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1875
body: Allow DestinationType.Treasure, Shade 0 items drop to corpse
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1875/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3OTQ3Nzk3
title: Loot Generation Changes
state: closed
created_at: 2019-05-11T01:54:36Z
updated_at: 2019-08-26T00:09:51Z
closed_at: 2019-05-12T04:14:42Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1876
body: - Consolidate assignment of spells
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1876/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc3OTk5NDA0
title: fixing recipe skill check for pre-moa skills
state: closed
created_at: 2019-05-11T18:04:53Z
updated_at: 2019-05-12T16:05:56Z
closed_at: 2019-05-12T16:05:56Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1877
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1877/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDAxMDU3
title: Switch Physics WeenieObject to hold a weak reference to WorldObject
state: closed
created_at: 2019-05-11T18:32:40Z
updated_at: 2019-06-11T00:59:56Z
closed_at: 2019-06-11T00:59:43Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1878
type: pull
body:
  This is mainly just a test to see if it's the physics engine that's holding into references, or something else.

  This *should* allow WorldObjects to be garbage collected even if their physics counterparts haven't been released.

  This is a test mainly for CE.

  NOTE: This appears to be stable on my environment, however, it may throw exceptions on CE due to the leaks that CE is seeing. If this does throw an exception, it may also help point us in the right direction.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1878/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDIyNjk1
title: Fix some issues with finger command
state: closed
created_at: 2019-05-12T02:36:13Z
updated_at: 2019-05-20T16:46:38Z
closed_at: 2019-05-12T22:06:20Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1879
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1879/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDI2MDMz
title: updating to ACE master
state: closed
created_at: 2019-05-12T04:06:09Z
updated_at: 2019-05-12T04:06:28Z
closed_at: 2019-05-12T04:06:28Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1880
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDM1NjUz
title: Add OnGeneration Emote handling
state: closed
created_at: 2019-05-12T08:02:37Z
updated_at: 2019-05-20T16:46:34Z
closed_at: 2019-05-13T03:48:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1881
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1881/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDU0MjE3
title: Add ObjectMaint.ServerObjects.Count to serverstatus
state: closed
created_at: 2019-05-12T13:38:05Z
updated_at: 2019-05-12T17:39:59Z
closed_at: 2019-05-12T17:39:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1882
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1882/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDYzNTA0
title: adding item material to tinkering broadcast message
state: closed
created_at: 2019-05-12T16:05:22Z
updated_at: 2019-05-12T22:21:26Z
closed_at: 2019-05-12T22:21:26Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1883
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1883/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDY0ODYz
title: updating fellowship death msg
state: closed
created_at: 2019-05-12T16:28:08Z
updated_at: 2019-05-12T22:21:33Z
closed_at: 2019-05-12T22:21:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1884
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1884/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDMxNDM3MjU=
title: Cannot apply lower reduction kit to leggings
state: closed
created_at: 2019-05-12T20:29:13Z
updated_at: 2019-05-20T20:06:36Z
closed_at: 2019-05-20T20:06:36Z
author_association: CONTRIBUTOR
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [x] bug report
  - [ ] feature request
  ```

  ### Repro steps.
  Attempt to apply an Armor Lower Reduction Kit to any leg armor, it will say that it cannot be applied.

  ### The log given by the failure.
  N/A

  ### Desired functionality.
  The leg armor should be reduced so that it only covers greaves.

  ### Mention any other details that might be useful.
  The code all lives in Tailoring.cs and is identical to the code used for upper arm reduction.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1885/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDc4ODg2
title: Add support for lower armor reduction kit applied to leggings
state: closed
created_at: 2019-05-12T20:32:09Z
updated_at: 2019-05-12T21:24:42Z
closed_at: 2019-05-12T21:24:42Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1886
type: pull
body:
  This adds support for the Armor Lower Reduction Kit to reduce leggings to lower legs (greaves) only. It currently only works for Arms -> Lower Arms (bracers).

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1886/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDMxNDcyNjI=
title: Add account level flag to listplayers cmd
state: closed
created_at: 2019-05-12T21:09:52Z
updated_at: 2019-05-20T06:07:39Z
closed_at: 2019-05-20T06:07:39Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ ] bug report -> please search issues before submitting
  - [X] feature request
  ```

  ### Desired functionality.
  Add a flag to the /listplayers command to only list characters of a certain account level that are online. This way you could do a /listplayers 5 to only see admins that are online.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1887/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDgxNDc1
title: fixing some issues with chest regen
state: closed
created_at: 2019-05-12T21:15:39Z
updated_at: 2019-05-12T22:21:40Z
closed_at: 2019-05-12T22:21:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1888
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1888/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDgyNDA2
title: Fix house hook items with emotes
state: closed
created_at: 2019-05-12T21:30:15Z
updated_at: 2019-05-14T14:06:46Z
closed_at: 2019-05-12T22:07:16Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1889
body: - Fix house hook items with emotes
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1889/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MDg4NDc4
title: PhysicsObj.Destroy on AddPhsyicsObj failure
state: closed
created_at: 2019-05-12T23:19:36Z
updated_at: 2019-05-14T01:19:57Z
closed_at: 2019-05-14T01:19:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1890
body: This could be a leak.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1890/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MTA5NzIz
title: Revert "Loot Generation Changes (#1876)"
state: closed
created_at: 2019-05-13T03:17:41Z
updated_at: 2019-06-17T16:07:18Z
closed_at: 2019-05-14T22:54:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1891
body: This reverts commit ade60a03c412f1473876fb69ffedd698ae19ad46.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1891/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4MzU4NTI2
title: Adjustment to loot percentages
state: closed
created_at: 2019-05-13T17:00:53Z
updated_at: 2019-05-14T14:06:47Z
closed_at: 2019-05-14T14:05:20Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1892
type: pull
body:
  If my math is correct and the code is doing what I expect it should be doing with the comparisons, this PR should match Epic drop rates to the rough estimates provided by Mag-nus in dev.  I somewhat matched the rarity of multi-majors to be similar to Epics. If further adjustments or refinements are needed, they can be performed in SpellDistribution(), GetNumMajorCantrips(), GetNumEpicCantrips, and GetNumLegendayCantrips().

  Currently, there isn't any other kind of ordering for cantrip spell additions than minor, major, epic, and lastly legendary, nor is there any coding to preclude lesser or greater cantrip or adjusting their percentages based upon what was rolled beforehand, if that type of process was performed.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1892/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4NDc0NzQx
title: fixing dispel layers
state: closed
created_at: 2019-05-13T23:56:03Z
updated_at: 2019-05-15T14:53:48Z
closed_at: 2019-05-15T14:53:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1893
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1893/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4NDg4Njgw
title: PlayerManagerFix as discussed
state: closed
created_at: 2019-05-14T01:28:16Z
updated_at: 2019-05-14T11:12:09Z
closed_at: 2019-05-14T10:58:32Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1894
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1894/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4NDkwNzIy
title: /auditobjectmaint
state: closed
created_at: 2019-05-14T01:42:41Z
updated_at: 2019-06-03T01:03:00Z
closed_at: 2019-06-03T01:02:50Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1895
body: Very crude command to test/audit/clear object maintenance sync issues
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1895/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4NTUyNzk4
title: fixing player give equipped item to npc
state: closed
created_at: 2019-05-14T07:27:26Z
updated_at: 2019-05-15T14:53:13Z
closed_at: 2019-05-15T14:53:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1896
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1896/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4NzAwNzE4
title: Coelesced Aetheria
state: closed
created_at: 2019-05-14T14:08:29Z
updated_at: 2019-05-16T00:26:27Z
closed_at: 2019-05-16T00:26:27Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1897
type: pull
body:
  - Add function for creating coelesced Aetheria in loot drops : disabled for now, as the quest to start using them is not present, yet

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1897/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4NzY3ODc4
title: Optional assess creature mod
state: closed
created_at: 2019-05-14T16:50:10Z
updated_at: 2019-05-15T00:01:19Z
closed_at: 2019-05-14T23:03:07Z
author_association: NONE
pull_request: ACEmulator/ACE/pulls/1898
type: pull
body:
  - Add option for re-enabling the former skill formula for Assess Creature skill, when skill is untrained

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1898/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc4OTQ0NDIz
title: Add Biota Update Script for Shields
state: closed
created_at: 2019-05-15T05:42:01Z
updated_at: 2019-05-20T16:46:32Z
closed_at: 2019-05-15T08:04:48Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1899
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1899/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc5MDE3NTQ2
state: closed
created_at: 2019-05-15T09:44:55Z
updated_at: 2019-05-17T22:32:19Z
closed_at: 2019-05-17T22:32:18Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1900
type: pull
title:
   adding dispells, summon inepts, calming gaze, flame bolts to scroll loot table, also fix raise vital message

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1900/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc5MzAyMzMx
title: Revert #1876 & #1892
state: closed
created_at: 2019-05-15T23:55:28Z
updated_at: 2019-06-17T16:07:19Z
closed_at: 2019-05-23T03:46:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1901
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1901/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc5MzM3NzE4
title: Adjust Stack Split/Merge Handling
state: closed
created_at: 2019-05-16T03:54:57Z
updated_at: 2019-05-20T16:46:33Z
closed_at: 2019-05-16T04:08:56Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1902
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1902/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc5MzQwMjYy
title: vendor updates
state: closed
created_at: 2019-05-16T04:12:37Z
updated_at: 2019-05-16T04:15:17Z
closed_at: 2019-05-16T04:15:17Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1903
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1903/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc5NzQ4ODYx
title: Adjust Stackable Merge Handling
state: closed
created_at: 2019-05-17T04:40:28Z
updated_at: 2019-05-20T16:46:27Z
closed_at: 2019-05-17T16:26:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1904
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1904/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjc5OTY3NDcx
title: Add AdjustDungeon to teleports via magic
state: closed
created_at: 2019-05-17T17:06:47Z
updated_at: 2019-05-20T16:46:26Z
closed_at: 2019-05-18T00:46:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1905
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1905/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMDcwNDc0
title: fix house dungeon portal landblock
state: closed
created_at: 2019-05-18T01:56:58Z
updated_at: 2019-05-18T08:38:36Z
closed_at: 2019-05-18T08:38:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1906
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1906/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMDcwNDgy
title: fix weapon tailor
state: closed
created_at: 2019-05-18T01:57:08Z
updated_at: 2019-05-18T08:38:45Z
closed_at: 2019-05-18T08:38:45Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1907
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1907/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMDgzMTAz
title: reverting 1874 for RegenOnClose chest generators
state: closed
created_at: 2019-05-18T06:51:04Z
updated_at: 2019-05-21T20:43:47Z
closed_at: 2019-05-21T20:43:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1908
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1908/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMTE0OTQy
title: Readme reorganizing
state: closed
created_at: 2019-05-18T17:28:30Z
updated_at: 2019-05-18T18:59:07Z
closed_at: 2019-05-18T18:59:07Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1909
type: pull
body:
  To alleviate many common setup errors, the Getting Started section has been broken down into 3 sections and the bullet points have been changed to numbers. This should allow easier referencing of specific steps to help others when they have a problem.

  Also updated the Linux instructions to have the same format as well as the disclaimers.

  Note, none of the instructions have been changed, only reorganized and slightly clarified.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1909/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMjA1MDgy
title: Update LootTables.cs
state: closed
created_at: 2019-05-19T23:08:31Z
updated_at: 2019-05-22T05:01:34Z
closed_at: 2019-05-22T05:01:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1910
body: Remove Mana Scarab from loot table
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1910/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMjA4MjM3
title: Adjust Item Pickup Code
state: closed
created_at: 2019-05-20T00:01:30Z
updated_at: 2019-05-20T16:46:24Z
closed_at: 2019-05-20T00:06:49Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1911
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1911/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMjEwODI0
title: Adjust Stack Split/Merge
state: closed
created_at: 2019-05-20T00:36:23Z
updated_at: 2019-05-20T16:46:21Z
closed_at: 2019-05-20T00:38:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1912
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1912/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMjM2MjY3
title: Add optional AccessLevel parameter to /listplayers
state: closed
created_at: 2019-05-20T04:31:52Z
updated_at: 2019-05-20T06:07:36Z
closed_at: 2019-05-20T06:07:36Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1913
type: pull
body:
  As requested in #1887, adds optional parameter to /listplayers, supporting either the name or value from `AccessLevel` 

  i.e.
  ```
  /listplayers
  /listplayers 5
  /listplayers admin
  ```


  Attaching a screenshot with the tests I ran locally:
  ![image](https://user-images.githubusercontent.com/121500/57996594-39c19780-7a7d-11e9-81bf-96b64983fce1.png)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1913/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMjUxNDg2
title: Confirm both parties can accept traded items
state: closed
created_at: 2019-05-20T06:11:40Z
updated_at: 2019-06-17T16:07:20Z
closed_at: 2019-05-23T03:46:35Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1914
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1914/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDU5MzkwODA=
title: Alchemical Throwing Phials
state: closed
created_at: 2019-05-20T06:13:55Z
updated_at: 2019-05-21T18:29:45Z
closed_at: 2019-05-21T18:29:45Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  https://pastebin.com/DcafTyRt
  Add above to World DB, spawn /ci 33917 11, and attempt to throw the phial at a mob.  The Phial's Accuracy spell cast by this item bolsters a player's missile weapon skill by +800, so it can be used effectively by a player without Missile trained.  Upon striking the target, the ProcSpell gets resisted, especially on a non-magic wielder, as the wielder's magic skill is being used for the spell cast resist check.

  ### The log given by the failure.
  no logs of failure provided by server

  ### Desired functionality.
  The spell resist should use the ItemSpellcraft of the Phial for the skill to measure against.

  ### Mention any other details that might be useful.
  Melee Def mod is -10%, so the float values is set to 0.90.  That value is translated to a -10% in the appraisal.  However, when Cragstone's Will spell line is applied, the field turns green; yet, the value doesn't change.  My guess is that the bonus from the spell should be adding to the Melee Def mod on the phial, and thereby decreasing the negative affect of the debuff on the stat.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1915/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMjgzMzI5
title: godmode for admins
state: closed
created_at: 2019-05-20T08:14:11Z
updated_at: 2019-05-21T21:56:29Z
closed_at: 2019-05-21T21:56:29Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1916
body: just having fun
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1916/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwMzkxNzM4
title: Fix RegenOnClose
state: closed
created_at: 2019-05-20T13:27:27Z
updated_at: 2019-05-21T00:03:57Z
closed_at: 2019-05-21T00:03:46Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1917
type: pull
body:
  This fixes the issue were chests weren't calling their profiles generator.HeartBeat() because chest.ResetGenerator was false.

  The fix is to process maintenance for generator profiles always, but only the spawn heartbeats conditionally.

  This was tested using /crack and the pathwarden chest.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1917/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwNDA5MDQ0
title: Partial #1902 Revert
state: closed
created_at: 2019-05-20T14:10:39Z
updated_at: 2019-05-27T18:16:40Z
closed_at: 2019-05-27T18:16:06Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1918
type: pull
body:
  Switch back to int to avoid the type casting.

  We now check to see if amount is <= 0 instead of just == 0 to avoid packet crafting exploits.

  The additional messages remain.

  A new logging message has been added for <= 0 events detected.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1918/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwNDQ3ODg5
title: Monster_Tick profiling additions
state: closed
created_at: 2019-05-20T15:47:41Z
updated_at: 2019-05-21T13:04:14Z
closed_at: 2019-05-21T12:55:42Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1919
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1919/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwNjEwNjEz
title: negative skill clamp
state: closed
created_at: 2019-05-21T03:32:44Z
updated_at: 2019-05-23T04:03:05Z
closed_at: 2019-05-23T04:03:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1920
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1920/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDY2NTMxNzk=
title: Thrown weapon vs dual wielding
state: closed
created_at: 2019-05-21T14:30:04Z
updated_at: 2019-06-25T22:49:36Z
closed_at: 2019-06-25T22:49:36Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Equipping a thrown weapon, such as wcid 304, while dual wielding, doesn't remove the second weapon

  ### The log given by the failure.
  No logs given by the failure

  ### Desired functionality.
  When a thrown weapon is equipped, the secondary weapon should be removed, also.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1921/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDY3NjYzMTI=
title: Item Proc'ing - Needs to be corrected for Alchemical Throwning Phials to work
state: closed
created_at: 2019-05-21T18:38:51Z
updated_at: 2019-06-25T22:49:45Z
closed_at: 2019-06-25T22:49:45Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Use a weapon with a ProcSpell that is a debuff with a character that doesn't have the associated magic skill trained.  Item ProcSpell will most likely be resisted, in current master.

  ### The log given by the failure.
  No server log given by the failure

  ### Desired functionality.
  wielder.TryCastSpell(spell, target, wielder) in TryProcItem() in WorldObject_Weapon.cs should be changed to TryCastSpell(spell, target, this) to allow the the proc'ed spell to be cast from the perspective of the item and its own ItemSpellCraft, rather than the item's wielder.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1922/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwOTY4OTY5
title: Fix food overuse when player is busy
state: closed
created_at: 2019-05-21T22:17:37Z
updated_at: 2019-05-29T07:15:01Z
closed_at: 2019-05-21T22:27:39Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1923
type: pull
body:
  moved the player.IsBusy check to the action function instead of the consume function for food items (vital pots), also set the weenie error type for "You're too busy!"

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1923/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwOTc2MDQ4
title: add god admin command
state: closed
created_at: 2019-05-21T22:48:47Z
updated_at: 2019-06-09T05:35:01Z
closed_at: 2019-06-09T02:14:12Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1924
type: pull
body:
  add /god admin command functionality

  - sets level to 999
  - specializes every skill
  - sets attributes to 9999
  - level up and BZ particle effects

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1924/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwOTc3ODE0
title: move IsBusy check to action, not consume
state: closed
created_at: 2019-05-21T22:57:38Z
updated_at: 2019-05-30T19:21:50Z
closed_at: 2019-05-22T19:10:39Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1925
type: pull
body:
  moving the player.IsBusy check to the ActOnUse function prevents multiple food items in a stack from being used while the player is in a busy state

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1925/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgwOTk5NDA0
title: Catch and Log Exceptions in InboundMessageManager
state: closed
created_at: 2019-05-22T01:09:18Z
updated_at: 2019-05-22T13:04:51Z
closed_at: 2019-05-22T13:04:37Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1926
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1926/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxMDMzMTM2
title: Some Loot Updates
state: closed
created_at: 2019-05-22T04:58:13Z
updated_at: 2020-06-15T20:59:17Z
closed_at: 2019-05-22T19:13:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1927
type: pull
body:
  * Added Dinnerware to Mundane lootgen. 
  * Removed Mana Scarabs from lootgen.
  * Added SetAppraisalLongDescDecoration() function to LootGen (mostly for future use)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1927/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxMTQ1NzM0
title: Fixing AL on loot-generated clothing
state: closed
created_at: 2019-05-22T11:14:27Z
updated_at: 2019-05-26T05:41:48Z
closed_at: 2019-05-26T05:41:48Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1928
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1928/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxMTk1MDQ3
title: Move network/packet work from WorldManager to NetworkManager
state: closed
created_at: 2019-05-22T13:29:06Z
updated_at: 2019-06-03T02:04:27Z
closed_at: 2019-06-03T02:04:16Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1929
type: pull
body:
  Something we've talked about for a long time.

  This cleans up WorldManager and moves all of the network/packet/session specific code to a new NetworkManager.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1929/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxMjU1Mzcz
title: Change GetObjectsByLandblock from bit shift to min/max
state: closed
created_at: 2019-05-22T15:45:30Z
updated_at: 2019-05-23T00:42:50Z
closed_at: 2019-05-23T00:42:40Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1930
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1930/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxNDEzMTMz
title: Top 10 landblocks by average tick and by longest tick
state: closed
created_at: 2019-05-23T01:33:45Z
updated_at: 2019-05-23T02:10:13Z
closed_at: 2019-05-23T02:10:00Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1931
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1931/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxNDM1MTM3
title: Fix some revert merge errors
state: closed
created_at: 2019-05-23T03:59:12Z
updated_at: 2019-06-17T16:07:22Z
closed_at: 2019-05-23T04:02:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1932
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1932/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxNDU2MTM3
title: Add type_value_idx to BiotaPropertiesIID table and Rescaffold
state: closed
created_at: 2019-05-23T06:13:11Z
updated_at: 2019-06-17T16:07:24Z
closed_at: 2019-05-24T06:13:31Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1933
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1933/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxNzg2NTc5
title: renaming file, removing some minor casts
state: closed
created_at: 2019-05-23T21:14:32Z
updated_at: 2019-05-24T07:19:14Z
closed_at: 2019-05-24T07:19:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1934
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1934/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxODk0MTUz
title: Tweak MinimumTimeSincePk
state: closed
created_at: 2019-05-24T07:14:17Z
updated_at: 2019-06-17T16:07:25Z
closed_at: 2019-05-24T07:35:01Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1935
body: Fix issue that allowed recovering PKs to attack other recovering PKs on PK worlds.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1935/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgxOTQ0NDYw
title: add percentages for jewelry slot drops, move jewelry items to LootTables.cs
state: closed
created_at: 2019-05-24T09:47:10Z
updated_at: 2019-05-30T19:21:00Z
closed_at: 2019-05-29T04:30:45Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1936
type: pull
body:
  adds percentage chance for jewelry drops based on slot, not type of jewelry

  as of right now i set 35% rings, 35% bracelets, 30% necklaces.... this can easily be adjusted by altering the percentage variables

  there are more types of necklaces and they were dropping at a higher percentage

  also adds gorgets and the second type of ring to loot

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1936/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMDQzNDEz
title: swap underlay colors for pierce/slash rends to match retail
state: closed
created_at: 2019-05-24T14:38:41Z
updated_at: 2019-05-26T05:41:58Z
closed_at: 2019-05-26T05:41:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1937
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1937/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMjY5OTI1
title: Add forcelogoff command
state: closed
created_at: 2019-05-26T04:13:30Z
updated_at: 2019-06-17T16:07:28Z
closed_at: 2019-05-26T05:49:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1938
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1938/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMjcxNzQ0
title: Add log messages to track corpse decay
state: closed
created_at: 2019-05-26T05:05:24Z
updated_at: 2019-06-17T16:07:10Z
closed_at: 2019-05-26T05:51:04Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1939
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1939/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMjczMzMw
title: Add log messages to track corpse decay
state: closed
created_at: 2019-05-26T05:51:09Z
updated_at: 2019-06-17T16:07:09Z
closed_at: 2019-05-26T07:19:26Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1940
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1940/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NDg1NjY2OTQ=
title: Old Chest for Healing Machine Hook in Ruschk Iceberg missing.
state: closed
created_at: 2019-05-26T13:21:31Z
updated_at: 2019-07-25T04:11:04Z
closed_at: 2019-07-25T04:11:04Z
author_association: NONE
state_reason: completed
type: issue
body:
  ```
  - [X] bug report -> please search issues before submitting (Done)
  - [ ] feature request
  ```

  ### Repro steps.
  Enter Ruschk Iceberg at 96.3N, 60.0W
  Proceed through dungeon.
  The door that requires the Ruschk Iceberk Key will open without using it, but you may use the key. I have repeated these steps in both cases.
  At the end of the dungeon, the Old Chest that should be there is missing.

  ### The log given by the failure.
  Given the simplicity and easy duplication of this bug, I did not think a log or packet capture was necessary. I would be happy to provide one on request. 

  ### Desired functionality.
  There should be an Old Chest near the exit portal. 

  ### Mention any other details that might be useful.
  This was the only item in the quest line with this issue. All those before and after seem to work as intended. 
  This item is required for the Fiun Healing Machine quest: https://asheron.fandom.com/wiki/Fiun_Healing_Machine_Quest
  EDIT: I have included a screenshot and described the behavior using Vsense further below.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1941/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMzExNjA3
title: add /allstats, make /delete safer
state: closed
created_at: 2019-05-26T17:42:29Z
updated_at: 2019-06-03T01:02:37Z
closed_at: 2019-06-03T01:02:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1942
type: pull
body:
  stat commands have been moved to AdminStatCommands.cs, and an /allstats command has been added.

  /delete command has been given an option argument to help avoid deleting the wrong things (possibly due decal plugins, or mis click).

  Now you can do "/delete creature" to make sure that you don't accidentally delete something else.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1942/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMzI2MzE1
title: Add expanded support for Fellowship quests
state: closed
created_at: 2019-05-26T22:03:34Z
updated_at: 2019-06-17T16:07:09Z
closed_at: 2019-05-27T04:58:33Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1943
body: Resolves #1737
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1943/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMzkzNTY4
title: Update showsession output for correct target
state: closed
created_at: 2019-05-27T07:12:54Z
updated_at: 2019-06-17T16:07:07Z
closed_at: 2019-05-27T07:16:18Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1944
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1944/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyMzk3ODM4
title: Change GeneratorHeartbeat to every 5 seconds
state: closed
created_at: 2019-05-27T07:28:36Z
updated_at: 2019-06-17T16:07:05Z
closed_at: 2019-05-30T05:15:12Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1945
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1945/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgyNDc1NDkx
title: Create database index for GetDynamicObjectsByLandblock
state: closed
created_at: 2019-05-27T11:27:03Z
updated_at: 2019-05-27T18:17:27Z
closed_at: 2019-05-27T18:16:53Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1946
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1946/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgzNDkzMzQ2
title: Remove unused code from GameActionPacket
state: closed
created_at: 2019-05-30T02:26:50Z
updated_at: 2019-06-03T01:02:23Z
closed_at: 2019-06-03T01:02:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1947
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1947/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgzNTk1MDcz
title: update mace of the explorer emote weenie prop
state: closed
created_at: 2019-05-30T10:12:15Z
updated_at: 2019-05-30T16:48:55Z
closed_at: 2019-05-30T16:21:57Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1948
type: pull
body:
  sql command to update the mace of the explorer weenie_property_emote from 6 (give) to 1 (refuse) so that the warden in the nubhub no longer takes them

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1948/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgzNjUyMDc1
title: Mag-nus changelog
state: closed
created_at: 2019-05-30T13:21:16Z
updated_at: 2019-05-30T13:28:11Z
closed_at: 2019-05-30T13:27:58Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1949
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1949/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgzNzgyOTMw
title: fix deception self 7, salvaging self 7 scrolls in loot
state: closed
created_at: 2019-05-30T19:32:01Z
updated_at: 2019-06-08T20:42:18Z
closed_at: 2019-05-31T04:46:34Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1950
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1950/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgzOTA4OTA0
title: Misc changes attempting to prevent lost corpses
state: closed
created_at: 2019-05-31T06:03:34Z
updated_at: 2019-06-17T16:06:57Z
closed_at: 2019-05-31T09:54:00Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1951
type: pull
body:
  Adds more logging for decay information

  Fixes issues with corpses loading on fresh load of landblock and decay issues

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1951/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjgzOTY4NzMx
title: Add ResetSkill and change EmoteManager
state: closed
created_at: 2019-05-31T09:28:26Z
updated_at: 2019-06-17T16:06:55Z
closed_at: 2019-05-31T10:05:47Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1952
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1952/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MDI5Njk0
title: update house eviction for unloaded landblocks
state: closed
created_at: 2019-05-31T12:36:32Z
updated_at: 2019-06-01T08:54:12Z
closed_at: 2019-06-01T08:54:12Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1953
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1953/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MDc3ODg2
title: adding verify-skill-credits
state: closed
created_at: 2019-05-31T14:48:52Z
updated_at: 2019-06-09T02:14:21Z
closed_at: 2019-06-09T02:14:21Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1954
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1954/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MTMzNTc0
title: Add check for Augs in ResetSkill
state: closed
created_at: 2019-05-31T17:35:49Z
updated_at: 2019-06-17T16:06:49Z
closed_at: 2019-05-31T17:39:41Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1955
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1955/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MTkyNzE1
title: Updating May Changelog
state: closed
created_at: 2019-05-31T21:03:36Z
updated_at: 2019-06-01T08:54:24Z
closed_at: 2019-06-01T08:54:24Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1956
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1956/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MTk3NDk2
title: updating tailoring pauldrons
state: closed
created_at: 2019-05-31T21:22:26Z
updated_at: 2019-06-01T08:54:37Z
closed_at: 2019-06-01T08:54:37Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1957
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1957/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MzAxMTEx
title: More updates for Corpses
state: closed
created_at: 2019-06-01T22:13:02Z
updated_at: 2019-06-17T16:06:48Z
closed_at: 2019-06-02T01:17:45Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1958
type: pull
body:
  * Prevent items being added to corpses by players
  * Changed Landblock.Tick to not decay on first tick
  * Update logging for decay of corpses

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1958/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0MzUyMDMy
title: fixing emote table rng
state: closed
created_at: 2019-06-02T15:54:11Z
updated_at: 2019-06-05T00:46:25Z
closed_at: 2019-06-05T00:46:25Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1959
type: pull
body:
  In the previous version, ThreadSafeRandom.Next was being called for each entry in the emoteSet list, increasing the chances of some of the rarer events from occurring

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1959/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0NjMyMzU5
title: Fixing leather salvage
state: closed
created_at: 2019-06-03T16:06:58Z
updated_at: 2019-06-05T00:46:33Z
closed_at: 2019-06-05T00:46:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1960
type: pull
body:
  This fixes bugs from leather/ivory salvage:

  - If a player tried to apply leather/ivory salvage to an item that has already been tinkered 10 times, the server would crash when trying to index into TinkeringDifficulty

  - The server would also crash with a null recipe exception after the item has been modified. It appears after the item has been modified, re-getting the recipe returns null, so the original recipe is passed in instead.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1960/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0Nzc5MTg3
title: Fixing hollow damage for chorizite missile weapons
state: closed
created_at: 2019-06-04T00:56:55Z
updated_at: 2019-06-05T00:46:42Z
closed_at: 2019-06-05T00:46:42Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1961
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1961/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg0ODMwMjYy
title: Fix GetPaletteID function
state: closed
created_at: 2019-06-04T06:20:25Z
updated_at: 2020-06-15T20:59:17Z
closed_at: 2019-06-04T16:14:13Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1962
type: pull
body:
  Made a small adjustment to the GetPaletteID function that was, in certain circumstances, returning the wrong palette.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1962/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg1MDc1MDk5
title: fixing items not ticking in sub containers
state: closed
created_at: 2019-06-04T17:38:43Z
updated_at: 2019-06-09T02:14:29Z
closed_at: 2019-06-09T02:14:29Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1963
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1963/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg1MDc1ODk1
title: Generator system revamp
state: closed
created_at: 2019-06-04T17:41:09Z
updated_at: 2019-06-23T18:16:10Z
closed_at: 2019-06-21T08:16:06Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1964
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1964/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg1MDg0MDY3
title: updating crafting chance of success dialog
state: closed
created_at: 2019-06-04T18:04:54Z
updated_at: 2019-06-05T00:46:54Z
closed_at: 2019-06-05T00:46:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1965
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1965/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg1MTczMzI1
title: adding tailoring retained error msg
state: closed
created_at: 2019-06-04T22:59:15Z
updated_at: 2019-06-05T00:47:02Z
closed_at: 2019-06-05T00:47:02Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1966
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1966/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NTI4MjcxOTQ=
title: EmoteType.TeleportTarget not complete
state: closed
created_at: 2019-06-06T04:33:17Z
updated_at: 2019-06-06T18:45:19Z
closed_at: 2019-06-06T18:45:19Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Attempt to use the Portal NPCLooksLikeObject at location @teleloc 0xA1A30131 [88.865700 149.142000 48.737000] 0.000000 0.000000 0.000000 -1.000000 that requires Fletching Spec'ed to use.  On successfully usage, nothing happens.

  ### The log given by the failure.
  No logs

  ### Desired functionality.
  EmoteType.TeleportTarget needs to be completed for the Cavern "portal" (44075) in the cave in Glendon Wood to work.

  Cavern object has Use and LongDescription strings that are not displaying in the appraisal, also.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1967/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg1NjQ3MzQ0
title: Support EmoteType.TeleportTarget
state: closed
created_at: 2019-06-06T05:25:04Z
updated_at: 2019-06-17T16:06:48Z
closed_at: 2019-06-06T18:45:15Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1968
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1968/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2MDQ3MzI1
title: Wire up EmoteType.CreateTreasure
state: closed
created_at: 2019-06-07T04:46:21Z
updated_at: 2019-06-17T16:06:46Z
closed_at: 2019-06-07T06:25:57Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1969
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1969/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2MzExNDkw
title: fixing hollow missile damage in other places
state: closed
created_at: 2019-06-07T19:43:54Z
updated_at: 2019-06-08T06:25:52Z
closed_at: 2019-06-08T06:25:52Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1970
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1970/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2MzU3Nzk5
title: Use Spell.Link instead of Spell.Name for SpellType.PortalSummon ItemMagic
state: closed
created_at: 2019-06-07T23:14:03Z
updated_at: 2019-06-17T16:06:45Z
closed_at: 2019-06-08T00:37:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1971
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1971/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2Mzc0Mzkw
title: Features debug
state: closed
created_at: 2019-06-08T02:42:24Z
updated_at: 2019-06-08T06:12:09Z
closed_at: 2019-06-08T06:12:08Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1972
body: Added MissileWeaponModifier
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1972/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2MzgyOTcw
title: Add LightSource weenie class
state: closed
created_at: 2019-06-08T06:10:41Z
updated_at: 2019-06-17T16:06:44Z
closed_at: 2019-06-08T06:26:51Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1973
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1973/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDE1Mzkx
title: add lock resistance enchantments
state: closed
created_at: 2019-06-08T16:28:26Z
updated_at: 2019-06-09T02:14:41Z
closed_at: 2019-06-09T02:14:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1974
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1974/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDE3NDAx
title: Features debug
state: closed
created_at: 2019-06-08T17:01:13Z
updated_at: 2019-06-08T18:26:39Z
closed_at: 2019-06-08T18:26:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1975
type: pull
body:
  Added !null checks to ShowInfo in DamageEvent on BaseDamageMod.  Solves issue with server crashing if "Attacker" is not specified with /debugdamage.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1975/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDQzNTE1
title: add missing using
state: closed
created_at: 2019-06-09T02:32:39Z
updated_at: 2019-06-09T02:45:15Z
closed_at: 2019-06-09T02:45:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1976
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1976/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDU2MDE0
title: Fix Use Contained Container bug
state: closed
created_at: 2019-06-09T08:13:50Z
updated_at: 2019-06-17T16:06:43Z
closed_at: 2019-06-09T22:45:21Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1977
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1977/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDYwMTQx
title: Add ComponentCheck to player spell casting
state: closed
created_at: 2019-06-09T09:48:39Z
updated_at: 2019-06-17T16:06:41Z
closed_at: 2019-06-09T22:53:13Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1978
type: pull
body:
  * Add `requirecomps` command.
  * Add SpellComponentsRequired property.
  * Add HasComponentsForSpell.
  * Add HasComponentsForSpell checks to Player.CreatePlayerSpell for targeted and untargeted spells.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1978/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDkyOTYy
title: adding sandstone to RecipeManager
state: closed
created_at: 2019-06-09T19:40:17Z
updated_at: 2019-06-09T20:07:54Z
closed_at: 2019-06-09T20:07:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1979
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1979/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NDk4NTQ5
title: further cleanup for ignoremagic*
state: closed
created_at: 2019-06-09T21:08:29Z
updated_at: 2019-06-09T22:57:39Z
closed_at: 2019-06-09T22:57:38Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1980
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1980/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NTIyNjYy
title: NetworkSession.cachedPackets pruning
state: closed
created_at: 2019-06-10T02:36:10Z
updated_at: 2019-06-10T10:42:16Z
closed_at: 2019-06-10T10:42:05Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1981
type: pull
body:
  This should fix cachedPacket retention from clients with poor connections. Packet retention is now capped at 60s.

  This also removes the SessionConnectionData wrapper:
  public double ServerTime => Timers.PortalYearTicks;

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1981/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NTI2NTM4
title: Fix issue with createlist RNG and shade 0
state: closed
created_at: 2019-06-10T03:08:52Z
updated_at: 2019-06-17T16:06:39Z
closed_at: 2019-06-10T03:57:28Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1982
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1982/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NTQ5MDc5
title: add sandstone for new items, updating existing sandstone bags
state: closed
created_at: 2019-06-10T05:56:55Z
updated_at: 2019-06-10T07:14:14Z
closed_at: 2019-06-10T07:14:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1983
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1983/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NTU0MzYy
title: add characters to be deleted to name in use check
state: closed
created_at: 2019-06-10T06:26:16Z
updated_at: 2019-06-10T06:37:46Z
closed_at: 2019-06-10T06:37:46Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1984
type: pull
body:
  prevent character creation with names of characters that are not fully deleted and subsequently restoring those characters for a duplicate name

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1984/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2NTU4ODQ4
title: Add Creation/LastLogin IP/DateTime
state: closed
created_at: 2019-06-10T06:47:12Z
updated_at: 2019-07-29T03:32:05Z
closed_at: 2019-07-06T21:12:25Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1985
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1985/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NTQyNjAzNDY=
title: Wield requirement checks aren't being enforced for equipping ammunition
state: closed
created_at: 2019-06-10T16:40:27Z
updated_at: 2019-06-11T14:33:23Z
closed_at: 2019-06-11T14:33:23Z
author_association: NONE
state_reason: completed
type: issue
body:
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Player is able to equip Deadly Prismatic Arrow, /ci 43951, without satisfying the three wield requirement checks

  ### The log given by the failure.
  No log of failure

  ### Desired functionality.
  To match retail, wield requirement checks should probably be enforced for ammunition equipping

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1986/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2ODg1MzY5
title: adding multiple wield requirements
state: closed
created_at: 2019-06-11T00:54:33Z
updated_at: 2019-06-11T14:33:24Z
closed_at: 2019-06-11T14:33:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1987
body: This fixes https://github.com/ACEmulator/ACE/issues/1986
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1987/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2ODk1Mjg5
title: Features debug
state: closed
created_at: 2019-06-11T02:02:52Z
updated_at: 2019-06-14T06:58:36Z
closed_at: 2019-06-14T06:58:36Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1988
body: Added Blood Drinker/Thirst Total to DamageDebug
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1988/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg2OTIwMDkz
title: Feature additemspell
state: closed
created_at: 2019-06-11T04:46:04Z
updated_at: 2019-06-11T19:17:44Z
closed_at: 2019-06-11T19:17:44Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1989
type: pull
body:
  Added the command /additemspell to Developer Commands.  
  /additemspell <spell id> - adds a spell to the last appraised item. Ex /additemspell 6089 - adds Legendary Bloodthirst

  This is to add spells to items (whether loot or quest generated).  For making weapons to check damage from pcaps or other sources

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1989/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3MTA1NTQw
title: LandblockDecay Code Cleanup
state: closed
created_at: 2019-06-11T14:02:00Z
updated_at: 2019-06-11T23:31:10Z
closed_at: 2019-06-11T23:30:55Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1990
body: Bit cleaner, doesn't need the warn message.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1990/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3MjAwMTI2
title: [WIP] New player movement, advanced spellcasting
state: closed
created_at: 2019-06-11T17:58:19Z
updated_at: 2020-01-14T10:16:32Z
closed_at: 2020-01-14T10:15:33Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1991
type: pull
body:
  - To enable detailed runtime state info, set DebugPlayerMoveToStatePhysics=true
  - All of the advanced spellcasting techniques should now be available (accurate slidecasting, fastcast, holdcast)
  - Server physics / motion system now has precise hooks into the current state, which should match up closely with the client (minus lag)
  - Server positioning should be more accurate, and should match the client closely at any given point in time
  - Fall damage should now be more accurate and consistent
  - Hotspot and pressure plate collision detection should now be more accurate

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1991/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3MzAwMzQ3
title: WRAP_AND_MEASURE_ACT_WITH_STOPWATCH
state: closed
created_at: 2019-06-11T23:45:20Z
updated_at: 2019-06-13T22:40:36Z
closed_at: 2019-06-13T22:40:27Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1992
body: default is off
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1992/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3MzI3Njcx
title: updating fellowship kts
state: closed
created_at: 2019-06-12T02:46:05Z
updated_at: 2019-06-16T23:06:10Z
closed_at: 2019-06-16T23:06:10Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1993
type: pull
body:
  relevant patch notes:

  http://acpedia.org/wiki/Announcements_-_2012/12_-_A_Growing_Twilight#Release_Notes

  - kt shareable range = killer's radar range by default (as per patch notes). a server config option has also been added (/modifybool fellow_kt_landblock true) which will increase this up to landblock range (192 distance, or current dungeon landblock)

  - fellowship members who don't meet the requirements for receiving XP in the fellowship can still earn shared KTs

  - another server option has been added (/modifybool fellow_kt_killer false) that indicates if the fellowship member who killed a monster is required to have the killtask quest, in order to share the kill credit with other fellows who might have the quest. by default, in retail, it appeared the killer was required to have the quest at least started, so this option remains matched up to retail by default (true)

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1993/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3NTEwOTU1
title: Buy/Sell input validation
state: closed
created_at: 2019-06-12T13:34:11Z
updated_at: 2019-08-21T01:09:13Z
closed_at: 2019-07-16T18:36:23Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1994
type: pull
body:
  Selling is limited to 20 unique items per transaction

  Selling is limited to 5,000 total items per transaction
  - think a transaction of 1 stack of 1000 tapers plus other stacks of 100 scarabs

  Buying is limited to 40 unique items per transaction
  - think players selling junk for pyreals

  Selling is limited to 10,000 total items per transaction
  - think a transaction of 10 stacks of 1000 tapers

  This also changes the existing VerifySellItems function that would prune corrupt/invalid entries to now being a hard fail on the total transaction if any errors are detected.

  Logging is added for transactions that fail these conditions, and these numbers may need to be modified if players exceed them during normal play.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1994/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3NTI5NjA3
title: More descriptive exceptions in ConnectionListener
state: closed
created_at: 2019-06-12T14:16:12Z
updated_at: 2019-06-13T22:40:56Z
closed_at: 2019-06-13T22:40:46Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1995
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1995/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg3NzE5NDQ4
title: Guid.Full:X8 to Guid
state: closed
created_at: 2019-06-13T00:19:42Z
updated_at: 2019-06-13T10:37:11Z
closed_at: 2019-06-13T10:36:59Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1996
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1996/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4MDIxMTQ2
title: Update Vendor Buy/Sell to validate item amounts before creation
state: closed
created_at: 2019-06-13T17:16:42Z
updated_at: 2019-06-17T16:06:27Z
closed_at: 2019-06-17T15:59:09Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/1997
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1997/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4MDgyODg0
title: ConfirmationManager refactoring
state: closed
created_at: 2019-06-13T20:25:11Z
updated_at: 2019-06-15T19:17:55Z
closed_at: 2019-06-15T19:17:54Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/1998
type: pull
body:
  This adds some missing confirmation types (swear allegiance, skill alteration, attribute transfer) and is in preparation for adding some other missing features to swearing allegiance

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1998/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4MTE5OTg0
title: Some small fixes
state: closed
created_at: 2019-06-13T22:35:08Z
updated_at: 2019-06-14T05:16:02Z
closed_at: 2019-06-14T05:16:02Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/1999
body:
  Some small changes to Allegiance code.
  Make Drudges the white player in chess.

type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1999/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4MTkwMzg2
title: fixing oak salvage
state: closed
created_at: 2019-06-14T05:50:16Z
updated_at: 2019-06-15T19:17:46Z
closed_at: 2019-06-15T19:17:46Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2000
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2000/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4MTk1MTYx
title: adding burden modifier
state: closed
created_at: 2019-06-14T06:14:31Z
updated_at: 2020-04-22T19:52:55Z
closed_at: 2019-06-15T07:16:40Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2001
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2001/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4MjE2Mzgy
title: phantom weapons
state: closed
created_at: 2019-06-14T07:39:36Z
updated_at: 2019-06-15T07:16:49Z
closed_at: 2019-06-15T07:16:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2002
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2002/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NDU4NzY3
title: adding missile reload anim speed
state: closed
created_at: 2019-06-14T19:47:42Z
updated_at: 2019-06-15T07:16:58Z
closed_at: 2019-06-15T07:16:58Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2003
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2003/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NTgxODA4
title: update allegiance chat channel when breaking from vassals
state: closed
created_at: 2019-06-15T21:01:43Z
updated_at: 2019-06-16T22:50:23Z
closed_at: 2019-06-16T22:50:23Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2004
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2004/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NjA1NzI4
title: limiting some actions during teleporting
state: closed
created_at: 2019-06-16T07:39:50Z
updated_at: 2019-06-16T22:50:39Z
closed_at: 2019-06-16T22:50:39Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2005
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2005/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NjA2MjE3
title: Change the activator for triggered Doors
state: closed
created_at: 2019-06-16T07:49:35Z
updated_at: 2019-06-16T17:45:38Z
closed_at: 2019-06-16T17:45:38Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2006
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2006/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NTY2NTU2NDU=
title: Armor/Item Sets throwing Errors
state: closed
created_at: 2019-06-16T15:54:48Z
updated_at: 2020-08-28T17:51:53Z
closed_at: 2020-08-28T17:51:53Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [ X] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  Load the Empyrean Ring Set and the Prismatic Shadow Armor Set into your DB. the /ci any of the items ( /ci 34706 = Red Empyrean Ring or /ci 49921 = Prismatic Shadow Helm 

  WARNING: Once equipped they CAN NOT BE REMOVED. 

  ### The log given by the failure.
  Just uploading the whole thing.
  [Item-Armor-Error text.zip](https://github.com/ACEmulator/ACE/files/3294273/Item-Armor-Error.text.zip)

  ### Desired functionality.
  <!--
  What would like to see implemented?
  What is the use case?
  -->

  ### Mention any other details that might be useful.
  it appears that it only is the "sets" that have the trouble.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2007/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NjU5NDEz
title: consumables refactoring
state: closed
created_at: 2019-06-16T23:21:17Z
updated_at: 2019-06-17T04:02:14Z
closed_at: 2019-06-17T04:02:14Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2008
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2008/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NjgzMTEx
title: adding ShareType
state: closed
created_at: 2019-06-17T03:30:30Z
updated_at: 2019-06-17T06:36:49Z
closed_at: 2019-06-17T06:36:49Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2009
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2009/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4Njk4NTI4
title: adding PK timers
state: closed
created_at: 2019-06-17T05:23:33Z
updated_at: 2019-06-20T07:16:15Z
closed_at: 2019-06-20T07:16:15Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2010
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2010/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4NzMzNzE3
title: updating fellowship level proportional xp sharing
state: closed
created_at: 2019-06-17T07:56:42Z
updated_at: 2019-06-18T04:32:05Z
closed_at: 2019-06-18T04:32:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2011
type: pull
body:
  This also has the fixes for lever motion, and also fixes https://github.com/ACEmulator/ACE/issues/2015

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2011/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg4OTY1Mzcy
title: Hookers can only be used on Hooks
state: closed
created_at: 2019-06-17T18:15:20Z
updated_at: 2019-06-23T18:16:20Z
closed_at: 2019-06-18T04:30:30Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2012
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2012/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5MDY2NDMy
title: Add CMS setting if MotionTableId is present
state: closed
created_at: 2019-06-18T00:33:41Z
updated_at: 2019-06-23T18:16:18Z
closed_at: 2019-06-18T05:47:50Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2013
body: Fixes crashes, errors on Switches, Levers, random things with motion that aren't creatures
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2013/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5MDc5MjQ2
title: ConnectionListener: Add NetworkReset error handling
state: closed
created_at: 2019-06-18T02:00:14Z
updated_at: 2019-06-18T11:17:22Z
closed_at: 2019-06-18T11:17:03Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2014
body: This was reported by a user.
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2014/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDU6SXNzdWU0NTcyMjU1MTk=
title: Potions filling up the wrong resource pool.
state: closed
created_at: 2019-06-18T02:13:25Z
updated_at: 2019-06-18T04:32:05Z
closed_at: 2019-06-18T04:32:05Z
author_association: NONE
state_reason: completed
type: issue
body:
  <!--
  IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING
  -->
  ### Bug Report or Feature Request (mark with an `x`)
  ```
  - [x] bug report -> please search issues before submitting
  - [ ] feature request
  ```

  ### Repro steps.
  - Stamina potions display that it is restoring stamina but it erroneously refills the mana pool.
  - Health potions display that it is restoring health but it erroneously refills the stamina pool.
  - Mana potions just don't work at all. The message displayed reads: '_Mana Elixir (8002470E) contains invalid vital Mana_'

  ### The log given by the failure.
  The server does not report any errors or warnings.

  ### Desired functionality.
  Potions should refill the appropriate resource type.

  ### Mention any other details that might be useful.
  This was tested with the Stamina Tincture, Stamina Brew, Health Elixir, and Mana Elixir. I've restarted ACEmulator, and the Windows 10 VM that runs it, neither made any difference.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2015/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5MTAyNzAx
title: fix revit other VI
state: closed
created_at: 2019-06-18T04:34:04Z
updated_at: 2019-06-18T04:36:42Z
closed_at: 2019-06-18T04:34:44Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2016
body: fix revit other VI and switch up nullify item magic id
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2016/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5MzY1ODc5
title: Fix issue with gems casting recall spells
state: closed
created_at: 2019-06-18T16:44:16Z
updated_at: 2019-06-23T18:16:19Z
closed_at: 2019-06-20T03:56:44Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2017
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2017/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5MzgzMDY4
title: Added handler if no ClothingBase exists for an equipped item
state: closed
created_at: 2019-06-18T17:36:12Z
updated_at: 2020-06-15T20:59:18Z
closed_at: 2019-06-19T07:09:28Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2018
type: pull
body:
  Added code to use the Setup of a piece of clothing to visually equip it if no ClothingBase exists. This specifically applies to Ursuin Guise, WCID 32155, but may apply to others items in the future.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2018/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5Mzg3MDM0
title: More Hooker permissions changes
state: closed
created_at: 2019-06-18T17:48:18Z
updated_at: 2019-06-23T18:16:19Z
closed_at: 2019-06-19T05:33:08Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2019
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2019/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5NDQ3MDUy
title: fixing house payments for offline allegiances
state: closed
created_at: 2019-06-18T20:48:04Z
updated_at: 2019-06-19T20:01:05Z
closed_at: 2019-06-19T20:01:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2020
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2020/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5NTY3MzMw
title: Add EmoteManager.OnDrop for dropping items to landblock
state: closed
created_at: 2019-06-19T07:07:06Z
updated_at: 2019-06-23T18:16:14Z
closed_at: 2019-06-19T18:09:48Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2021
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2021/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0Mjg5OTE3MTI3
title: Further refinement for Hookers
state: closed
created_at: 2019-06-19T23:50:25Z
updated_at: 2019-06-23T18:16:13Z
closed_at: 2019-06-19T23:54:37Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2022
body: This also, as a byproduct, fixes character creation for accounts with player or advocate access
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2022/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwNDA1NTgw
title: fixing highframe bug
state: closed
created_at: 2019-06-20T22:49:15Z
updated_at: 2019-06-21T08:14:47Z
closed_at: 2019-06-21T08:14:47Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2023
body: Thanks @OptimShi for finding this
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2023/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwNTQxNzkz
title: fixing some vitae bugs
state: closed
created_at: 2019-06-21T09:53:45Z
updated_at: 2019-06-22T20:24:16Z
closed_at: 2019-06-22T20:24:16Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2024
type: pull
body:
  - Vitae should not be lowered by Allegiance passup xp
  - Possible fix for the remaining vitae > 1.0 bug

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2024/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwNTYwOTYz
title: refactor drop item
state: closed
created_at: 2019-06-21T10:53:06Z
updated_at: 2021-07-05T21:16:32Z
closed_at: 2019-06-22T20:24:05Z
author_association: COLLABORATOR
pull_request: ACEmulator/ACE/pulls/2025
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2025/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwNjQ0MTcw
title: Biota and Character SQL Writers
state: closed
created_at: 2019-06-21T15:05:13Z
updated_at: 2019-06-21T15:10:22Z
closed_at: 2019-06-21T15:10:10Z
author_association: MEMBER
pull_request: ACEmulator/ACE/pulls/2026
type: pull
reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2026/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


node_id: MDExOlB1bGxSZXF1ZXN0MjkwNzgzMzky
title: add /ungod command
state: closed
created_at: 2019-06-22T01:06:51Z
updated_at: 2019-08-11T20:43:10Z
closed_at: 2019-07-23T13:52:47Z
author_association: CONTRIBUTOR
pull_request: ACEmulator/ACE/pulls/2027
type: pull
body:
  The god command now only lasts until you log out. When you relog you will be at lifestone and any items you obtained while a god will be lost.

  This works by saving to the db and flagging the character as 'DoNotSave' before altering the stats. When the player logs out the stats are reloaded from the db before adding to the offline players list.

  Definitely open to feedback and suggestions.

reactions:
  {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2027/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0}


