github
Data license: AGPL · Data source: ACEmulator Project
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/ACEmulator/ACE/pull/2395#issuecomment-551921922 | https://api.github.com/repos/ACEmulator/ACE/issues/2395 | 551921922 | MDEyOklzc3VlQ29tbWVudDU1MTkyMTkyMg== | 30803300 | 2019-11-08T17:38:16Z | 2019-11-08T17:38:16Z | COLLABORATOR | From Magnus's data, clothing has a 5.1-7.8% chance of dropping depending on tier, its basically half of armor drop chance. By adding clothing chance to this roll, it will greatly reduce the number of drops of armor/weapons, and overflowing the server with a lot of clothing. This one of the main area's (lootbias) that needs to be updated and aligned with what drop rate data we have. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 520065924 | |
https://github.com/ACEmulator/ACE/pull/2440#issuecomment-557356500 | https://api.github.com/repos/ACEmulator/ACE/issues/2440 | 557356500 | MDEyOklzc3VlQ29tbWVudDU1NzM1NjUwMA== | 30803300 | 2019-11-22T02:14:37Z | 2019-11-22T02:14:37Z | COLLABORATOR | Pulling TestLootGen updates out, closing this PR, will create a new PR | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 526228420 | |
https://github.com/ACEmulator/ACE/pull/2429#issuecomment-557356730 | https://api.github.com/repos/ACEmulator/ACE/issues/2429 | 557356730 | MDEyOklzc3VlQ29tbWVudDU1NzM1NjczMA== | 30803300 | 2019-11-22T02:15:36Z | 2019-11-22T02:15:36Z | COLLABORATOR | Pulling out TestLootGen Update, will open a new PR | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 524123347 | |
https://github.com/ACEmulator/ACE/pull/2449#issuecomment-557361548 | https://api.github.com/repos/ACEmulator/ACE/issues/2449 | 557361548 | MDEyOklzc3VlQ29tbWVudDU1NzM2MTU0OA== | 30803300 | 2019-11-22T02:37:15Z | 2019-11-22T02:37:15Z | COLLABORATOR | Just seen I left ConsoleCommands as a partial class (forgot to change it back to just a static class). Fixed | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 526948524 | |
https://github.com/ACEmulator/ACE/pull/2451#issuecomment-557592238 | https://api.github.com/repos/ACEmulator/ACE/issues/2451 | 557592238 | MDEyOklzc3VlQ29tbWVudDU1NzU5MjIzOA== | 30803300 | 2019-11-22T16:08:00Z | 2019-11-22T16:08:00Z | COLLABORATOR | > > > PR isn't really presenting clean. There appears to still be code changes from the Test Loot Generator PR, along with changes that are duplicated in the Missile Loot gen PR. This one should really only have just the two files being touched, IMO. Still gives the appearance of being all inclusive... Once the new PR is merged, then those should issues should resolve. This is how I was instructed to do this, per Magnus and Gmriggs. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 526953607 | |
https://github.com/ACEmulator/ACE/pull/2492#issuecomment-564307156 | https://api.github.com/repos/ACEmulator/ACE/issues/2492 | 564307156 | MDEyOklzc3VlQ29tbWVudDU2NDMwNzE1Ng== | 30803300 | 2019-12-10T23:29:34Z | 2019-12-10T23:29:34Z | COLLABORATOR | No longer needed | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 532381289 | |
https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567053644 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | 567053644 | MDEyOklzc3VlQ29tbWVudDU2NzA1MzY0NA== | 30803300 | 2019-12-18T14:26:36Z | 2019-12-18T14:26:36Z | COLLABORATOR | On a side note, while at it, is there any reason for the ElementalDamageBonusPvPReduction to be a static readonly in the class instead of a local var in that function? Its only used in that function. This has nothing to do with what dgarson submitted, but a quick refactor would remove a couple of vars | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 539637907 | |
https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567056903 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | 567056903 | MDEyOklzc3VlQ29tbWVudDU2NzA1NjkwMw== | 30803300 | 2019-12-18T14:34:51Z | 2019-12-18T14:34:51Z | COLLABORATOR | I guess the question would be does it even need to be defined? If it's always the same, no real reason to define it, unless someone wanted to make it server configurable. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 539637907 | |
https://github.com/ACEmulator/ACE/pull/2548#issuecomment-567059959 | https://api.github.com/repos/ACEmulator/ACE/issues/2548 | 567059959 | MDEyOklzc3VlQ29tbWVudDU2NzA1OTk1OQ== | 30803300 | 2019-12-18T14:42:07Z | 2019-12-18T14:42:07Z | COLLABORATOR | Agreed it's not an issue, just more of my own curiosity. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 539637907 | |
https://github.com/ACEmulator/ACE/pull/2551#issuecomment-568313961 | https://api.github.com/repos/ACEmulator/ACE/issues/2551 | 568313961 | MDEyOklzc3VlQ29tbWVudDU2ODMxMzk2MQ== | 30803300 | 2019-12-22T23:55:01Z | 2019-12-22T23:55:01Z | COLLABORATOR | Added Armor Stats, see below ``` -----Melee Weapons---- Skill Wield Damage MStrike Variance DefenseMod MagicDBonus MissileDBonus Value Type LightWeapons 370 48 N 0.85 1.16 1.01 1 18368 Frost Dolabra TwoHandedCombat 370 31 N 0.4 1.13 1 1 39915 Lightning Nodachi TwoHandedCombat 370 33 N 0.45 1.11 1 1 37700 Lightning Pike TwoHandedCombat 370 32 N 0.4 1.14 1 1 41847 Frost Spadone HeavyWeapons 400 66 N 0.97 1.17 1 1 18109 Frost War Axe FinesseWeapons 370 44 N 0.5 1.14 1 1 20062 Frost Jitte LightWeapons 370 47 N 0.71 1.12 1 1 26175 Yari -----Missile Weapons---- Type Wield Modifier ElementBonus DefenseMod MagicDBonus MissileDBonus Value X Bow 335 2.59 8 1.14 0 1 13220 X Bow 335 2.59 9 1.15 0 1 4670 Thrown 360 2.53 14 1.14 0 1 17376 Thrown 360 2.56 11 1.17 0 1.01 19151 Thrown 360 2.53 10 1.14 0 1 29950 X Bow 360 2.56 15 1.12 0 1 12669 Bow 360 2.37 1… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 540537311 | |
https://github.com/ACEmulator/ACE/pull/2551#issuecomment-568562616 | https://api.github.com/repos/ACEmulator/ACE/issues/2551 | 568562616 | MDEyOklzc3VlQ29tbWVudDU2ODU2MjYxNg== | 30803300 | 2019-12-23T19:34:11Z | 2019-12-23T19:34:11Z | COLLABORATOR | Added Pet Table ``` -----Pet Devices---- Dmg DmgR Crit CritD CDR CritR Total 0 0 0 0 0 3 3 0 13 0 4 17 0 34 0 0 4 0 10 6 20 0 0 0 10 0 1 11 13 0 0 3 13 0 29 0 13 0 0 12 0 25 0 8 0 10 5 0 23 0 4 0 2 0 0 6 11 11 0 14 0 5 41 0 13 13 12 5 0 43 0 0 3 0 6 0 9 15 16 0 15 4 0 50 5 11 0 14 15 0 45 5 0 7 4 0 4 20``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 540537311 | |
https://github.com/ACEmulator/ACE/pull/2551#issuecomment-568566619 | https://api.github.com/repos/ACEmulator/ACE/issues/2551 | 568566619 | MDEyOklzc3VlQ29tbWVudDU2ODU2NjYxOQ== | 30803300 | 2019-12-23T19:52:51Z | 2019-12-23T19:52:51Z | COLLABORATOR | Added options for seeing specific tables. syntax ``` testlootgen <# of items generate> <tier> <table to display> testlootgencorpse <deathtreasure DID> <# of corpses to generate> <table to display> ``` Table Options ``` melee, missile, caster, armor, pet ``` Example of command to generate 158 items in tier 7 and display caster table ``` testlootgen 158 7 caster ``` Example of command to generate 200 corpses with deathtreasure DID 998 and display pet table ``` testlootgencorpse 998 200 pet ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 540537311 | |
https://github.com/ACEmulator/ACE/pull/2551#issuecomment-569292215 | https://api.github.com/repos/ACEmulator/ACE/issues/2551 | 569292215 | MDEyOklzc3VlQ29tbWVudDU2OTI5MjIxNQ== | 30803300 | 2019-12-27T15:33:29Z | 2019-12-27T15:33:29Z | COLLABORATOR | Ok Done adding stuff now, its ready to merge | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 540537311 | |
https://github.com/ACEmulator/ACE/pull/2631#issuecomment-577878203 | https://api.github.com/repos/ACEmulator/ACE/issues/2631 | 577878203 | MDEyOklzc3VlQ29tbWVudDU3Nzg3ODIwMw== | 30803300 | 2020-01-23T21:10:05Z | 2020-01-23T21:10:05Z | COLLABORATOR | > > > for the actual lootgen parts, @harliq would probably be the best person to review that I will pull it and run it through loot sim tonight | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 552417258 | |
https://github.com/ACEmulator/ACE/pull/2631#issuecomment-582175469 | https://api.github.com/repos/ACEmulator/ACE/issues/2631 | 582175469 | MDEyOklzc3VlQ29tbWVudDU4MjE3NTQ2OQ== | 30803300 | 2020-02-05T00:00:33Z | 2020-02-05T00:00:33Z | COLLABORATOR | I pulled and tested with @ziang4891 updated weenies. Loot Sim shows correct armor levels, and weapons appear to be fine. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 552417258 | |
https://github.com/ACEmulator/ACE/pull/2684#issuecomment-583063348 | https://api.github.com/repos/ACEmulator/ACE/issues/2684 | 583063348 | MDEyOklzc3VlQ29tbWVudDU4MzA2MzM0OA== | 30803300 | 2020-02-06T19:12:16Z | 2020-02-06T19:12:16Z | COLLABORATOR | Closing | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 559280433 | |
https://github.com/ACEmulator/ACE/pull/2828#issuecomment-600219981 | https://api.github.com/repos/ACEmulator/ACE/issues/2828 | 600219981 | MDEyOklzc3VlQ29tbWVudDYwMDIxOTk4MQ== | 30803300 | 2020-03-17T18:09:11Z | 2020-03-17T18:09:11Z | COLLABORATOR | I agree, this just for DnF at the moment for helping find issues in their stuff. Not really meant for master | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 583196681 | |
https://github.com/ACEmulator/ACE/pull/2828#issuecomment-602734498 | https://api.github.com/repos/ACEmulator/ACE/issues/2828 | 602734498 | MDEyOklzc3VlQ29tbWVudDYwMjczNDQ5OA== | 30803300 | 2020-03-23T17:09:55Z | 2020-03-23T17:09:55Z | COLLABORATOR | no need for this PR, closing | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 583196681 | |
https://github.com/ACEmulator/ACE/pull/2828#issuecomment-602734563 | https://api.github.com/repos/ACEmulator/ACE/issues/2828 | 602734563 | MDEyOklzc3VlQ29tbWVudDYwMjczNDU2Mw== | 30803300 | 2020-03-23T17:10:02Z | 2020-03-23T17:10:02Z | COLLABORATOR | close | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 583196681 | |
https://github.com/ACEmulator/ACE/issues/2906#issuecomment-612313335 | https://api.github.com/repos/ACEmulator/ACE/issues/2906 | 612313335 | MDEyOklzc3VlQ29tbWVudDYxMjMxMzMzNQ== | 30803300 | 2020-04-11T03:31:11Z | 2020-04-11T03:31:11Z | COLLABORATOR | Rank can't be 0, everyone starts as rank 1. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 598168976 | |
https://github.com/ACEmulator/ACE/pull/2950#issuecomment-618398199 | https://api.github.com/repos/ACEmulator/ACE/issues/2950 | 618398199 | MDEyOklzc3VlQ29tbWVudDYxODM5ODE5OQ== | 30803300 | 2020-04-23T13:31:23Z | 2020-04-23T13:31:23Z | COLLABORATOR | Closing | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 602552660 | |
https://github.com/ACEmulator/ACE/pull/2950#issuecomment-618398590 | https://api.github.com/repos/ACEmulator/ACE/issues/2950 | 618398590 | MDEyOklzc3VlQ29tbWVudDYxODM5ODU5MA== | 30803300 | 2020-04-23T13:33:10Z | 2020-04-23T13:33:10Z | COLLABORATOR | Closing | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 602552660 | |
https://github.com/ACEmulator/ACE/pull/2998#issuecomment-635607225 | https://api.github.com/repos/ACEmulator/ACE/issues/2998 | 635607225 | MDEyOklzc3VlQ29tbWVudDYzNTYwNzIyNQ== | 30803300 | 2020-05-28T21:05:09Z | 2020-05-28T21:06:29Z | COLLABORATOR | I would change 0 to a 1 and leave the 100, since if lowering to 99, the higher end roll chance is decreasing. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 624472389 | |
https://github.com/ACEmulator/ACE/pull/2998#issuecomment-635984490 | https://api.github.com/repos/ACEmulator/ACE/issues/2998 | 635984490 | MDEyOklzc3VlQ29tbWVudDYzNTk4NDQ5MA== | 30803300 | 2020-05-29T13:53:03Z | 2020-05-29T13:53:03Z | COLLABORATOR | You are right, I was looking at it from a >= stand point and not a > stand point. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 624472389 | |
https://github.com/ACEmulator/ACE/pull/3019#issuecomment-642064524 | https://api.github.com/repos/ACEmulator/ACE/issues/3019 | 642064524 | MDEyOklzc3VlQ29tbWVudDY0MjA2NDUyNA== | 30803300 | 2020-06-10T14:56:34Z | 2020-06-10T14:56:34Z | COLLABORATOR | > > > this is probably going to break... all of crafting Fixed | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 635892747 | |
https://github.com/ACEmulator/ACE/pull/3027#issuecomment-645596889 | https://api.github.com/repos/ACEmulator/ACE/issues/3027 | 645596889 | MDEyOklzc3VlQ29tbWVudDY0NTU5Njg4OQ== | 30803300 | 2020-06-17T20:09:39Z | 2020-06-17T20:09:39Z | COLLABORATOR | I have tested this, and it works. Of note, you have to reload the landblock for the changes to take effect. If you remove the child instance, it will continue to spawn till you reload. This is a given, but just to avoid confusion for others. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 639978885 | |
https://github.com/ACEmulator/ACE/pull/3160#issuecomment-687284850 | https://api.github.com/repos/ACEmulator/ACE/issues/3160 | 687284850 | MDEyOklzc3VlQ29tbWVudDY4NzI4NDg1MA== | 30803300 | 2020-09-04T17:30:36Z | 2020-09-04T17:30:36Z | COLLABORATOR | I still do not agree with some of the changes for damage. No hard proof was given for those changes. Just data from others that can not be verified. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 684198032 |