github
Data license: AGPL · Data source: ACEmulator Project
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
441857482 | MDExOlB1bGxSZXF1ZXN0Mjc3MDk0Nzg1 | 1867 | adding in missing scroll drops | 26235642 | closed | 0 | 0 | 2019-05-08T17:59:05Z | 2019-05-08T18:43:06Z | 2019-05-08T18:43:06Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1867 | life vulns, heals, stams, s2m, infuses, item aura others still need the inepts for creature and maybe a few more stragglers | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1867/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
441988689 | MDExOlB1bGxSZXF1ZXN0Mjc3MTk5Njcz | 1868 | add rest of scrolls in loot | 26235642 | closed | 0 | 0 | 2019-05-08T23:41:32Z | 2019-05-10T17:23:43Z | 2019-05-10T17:23:43Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1868 | fix what errors i did find and add rest of the scrolls to the loot table | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1868/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
443062157 | MDExOlB1bGxSZXF1ZXN0Mjc4MDI2MDMz | 1880 | updating to ACE master | 26235642 | closed | 0 | 0 | 2019-05-12T04:06:09Z | 2019-05-12T04:06:28Z | 2019-05-12T04:06:28Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1880 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
444339108 | MDExOlB1bGxSZXF1ZXN0Mjc5MDE3NTQ2 | 1900 | adding dispells, summon inepts, calming gaze, flame bolts to scroll loot table, also fix raise vital message | 26235642 | closed | 0 | 0 | 2019-05-15T09:44:55Z | 2019-05-17T22:32:19Z | 2019-05-17T22:32:18Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1900 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1900/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
445979776 | MDExOlB1bGxSZXF1ZXN0MjgwMjgzMzI5 | 1916 | godmode for admins | 26235642 | closed | 0 | 1 | 2019-05-20T08:14:11Z | 2019-05-21T21:56:29Z | 2019-05-21T21:56:29Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1916 | just having fun | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1916/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
446849664 | MDExOlB1bGxSZXF1ZXN0MjgwOTY4OTY5 | 1923 | Fix food overuse when player is busy | 26235642 | closed | 0 | 0 | 2019-05-21T22:17:37Z | 2019-05-29T07:15:01Z | 2019-05-21T22:27:39Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1923 | moved the player.IsBusy check to the action function instead of the consume function for food items (vital pots), also set the weenie error type for "You're too busy!" | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1923/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
446858263 | MDExOlB1bGxSZXF1ZXN0MjgwOTc2MDQ4 | 1924 | add god admin command | 26235642 | closed | 0 | 3 | 2019-05-21T22:48:47Z | 2019-06-09T05:35:01Z | 2019-06-09T02:14:12Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1924 | add /god admin command functionality - sets level to 999 - specializes every skill - sets attributes to 9999 - level up and BZ particle effects | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1924/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
446860496 | MDExOlB1bGxSZXF1ZXN0MjgwOTc3ODE0 | 1925 | move IsBusy check to action, not consume | 26235642 | closed | 0 | 0 | 2019-05-21T22:57:38Z | 2019-05-30T19:21:50Z | 2019-05-22T19:10:39Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1925 | moving the player.IsBusy check to the ActOnUse function prevents multiple food items in a stack from being used while the player is in a busy state | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1925/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
448078013 | MDExOlB1bGxSZXF1ZXN0MjgxOTQ0NDYw | 1936 | add percentages for jewelry slot drops, move jewelry items to LootTables.cs | 26235642 | closed | 0 | 0 | 2019-05-24T09:47:10Z | 2019-05-30T19:21:00Z | 2019-05-29T04:30:45Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1936 | adds percentage chance for jewelry drops based on slot, not type of jewelry as of right now i set 35% rings, 35% bracelets, 30% necklaces.... this can easily be adjusted by altering the percentage variables there are more types of necklaces and they were dropping at a higher percentage also adds gorgets and the second type of ring to loot | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1936/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
450231941 | MDExOlB1bGxSZXF1ZXN0MjgzNTk1MDcz | 1948 | update mace of the explorer emote weenie prop | 26235642 | closed | 0 | 2 | 2019-05-30T10:12:15Z | 2019-05-30T16:48:55Z | 2019-05-30T16:21:57Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1948 | sql command to update the mace of the explorer weenie_property_emote from 6 (give) to 1 (refuse) so that the warden in the nubhub no longer takes them | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1948/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
450469911 | MDExOlB1bGxSZXF1ZXN0MjgzNzgyOTMw | 1950 | fix deception self 7, salvaging self 7 scrolls in loot | 26235642 | closed | 0 | 0 | 2019-05-30T19:32:01Z | 2019-06-08T20:42:18Z | 2019-05-31T04:46:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1950 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1950/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
454016320 | MDExOlB1bGxSZXF1ZXN0Mjg2NTU0MzYy | 1984 | add characters to be deleted to name in use check | 26235642 | closed | 0 | 1 | 2019-06-10T06:26:16Z | 2019-06-10T06:37:46Z | 2019-06-10T06:37:46Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/1984 | prevent character creation with names of characters that are not fully deleted and subsequently restoring those characters for a duplicate name | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1984/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
457256895 | MDExOlB1bGxSZXF1ZXN0Mjg5MTAyNzAx | 2016 | fix revit other VI | 26235642 | closed | 0 | 0 | 2019-06-18T04:34:04Z | 2019-06-18T04:36:42Z | 2019-06-18T04:34:44Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2016 | fix revit other VI and switch up nullify item magic id | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2016/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
459416589 | MDExOlB1bGxSZXF1ZXN0MjkwNzgzMzky | 2027 | add /ungod command | 26235642 | closed | 0 | 9 | 2019-06-22T01:06:51Z | 2019-08-11T20:43:10Z | 2019-07-23T13:52:47Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2027 | The god command now only lasts until you log out. When you relog you will be at lifestone and any items you obtained while a god will be lost. This works by saving to the db and flagging the character as 'DoNotSave' before altering the stats. When the player logs out the stats are reloaded from the db before adding to the offline players list. Definitely open to feedback and suggestions. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2027/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
459571569 | MDExOlB1bGxSZXF1ZXN0MjkwODg2NTI0 | 2036 | fix nullify item scroll drop | 26235642 | closed | 0 | 0 | 2019-06-23T12:40:31Z | 2019-06-23T17:27:29Z | 2019-06-23T17:27:29Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2036 | never should have changed the spell ID for the drop, 1949 was working... just rare | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2036/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
463984016 | MDU6SXNzdWU0NjM5ODQwMTY= | 2070 | Stuck in portal space on portal recall. | 26235642 | closed | 0 | 8909245 | 3 | 2019-07-03T22:46:40Z | 2019-07-23T00:26:09Z | 2019-07-23T00:26:09Z | CONTRIBUTOR | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [x ] bug report -> please search issues before submitting - [ ] feature request ``` Character will occasionally get stuck in portal space when portal recalling. Just stays in the blue portal space indefinitely (e.g. it persisted for over 5 hours one night). Log off works, but the next time the character logs in it skips portal space and immediately shows up in the world, however the character is still _in_ portal space - can't enter combat mode or use items. A second relog will fix and return the character to normal. ### Repro steps. <!-- Please list the steps to reproduce a bug here --> Don't have any hard repro steps yet. So far it seems to happen randomly when using secondary portal recall. ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> Pcaps of the issue. I said "stuck" and "unstuck" in chat when I noticed. https://megaupload.nz/vbO7Odxfn2/pkt_2019-7-3_1562176100_log_pcap https://megaupload.nz/30GePcxen6/pkt_2019-7-3_1562190602_log_pcap https://megaupload.nz/GcMcQdx2n8/pkt_2019-7-3_1562212409_log_pcap https://megaupload.nz/z8D6fay3n2/pkt_2019-7-5_1562335790_log_pcap ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> Not get stuck? :-P ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> I can answer any questions in discord. I'll keep paying attention and try to pickup on a pattern. #2073 is an attempt to fix, ill continue to monitor when this goes live | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2070/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | |||||
479417989 | MDExOlB1bGxSZXF1ZXN0MzA2MzE0NDE1 | 2221 | fix parse types | 26235642 | closed | 0 | 0 | 2019-08-11T21:57:24Z | 2019-08-12T02:49:44Z | 2019-08-12T02:49:44Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2221 | some types were parsed as an int, but needed to be a long and would cause an exception causing the player to be stuck in godmode | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2221/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
479481294 | MDExOlB1bGxSZXF1ZXN0MzA2MzYyODYw | 2226 | able to create stacks and multiple objects with /create | 26235642 | closed | 0 | 0 | 2019-08-12T06:09:11Z | 2019-08-15T01:46:15Z | 2019-08-15T01:46:15Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2226 | /create now takes a second argument (defaults to one) and will create a stack if possible or spawn that many of the weenie you specify | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2226/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
511652689 | MDExOlB1bGxSZXF1ZXN0MzMxODExNDI2 | 2351 | add a check before entering godmode | 26235642 | closed | 0 | 0 | 2019-10-24T01:32:41Z | 2019-10-24T21:23:30Z | 2019-10-24T21:23:30Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2351 | recently players were reporting errors with their godString... after examining the strings it seems as if sometimes an extra blank 'skill' is inserted into the string i havent worked out exactly why but i added a check to the process so you wont be able to enter godmode if the string is not the proper length. this should prevent characters being stuck in godmode after entering with an incorrect string length | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
517525522 | MDExOlB1bGxSZXF1ZXN0MzM2NTc4MDE5 | 2388 | add valid skills hashset, check valid skills entering godmode | 26235642 | closed | 0 | 2 | 2019-11-05T03:18:48Z | 2019-11-09T11:54:21Z | 2019-11-09T11:54:21Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/2388 | added a valid skills hashset to the skillhelper so that it could be checked against when entering godmode. also added hard coded checks against the attribute and attribute 2nd types... figured they didnt need a helper this change will only add entries to the godstring if they are valid. According to ripley, the bug is with the GetOrAddSkill function that adds a skill to a players biota_properties_skill table when checking for invalid skill types. if a player had an invalid skill (typically this was a skill with type 0) the string would be too long and cause the error. now when entering godmode invalid skill and attribute values will be ignored and everything should work as intended the only way an error when attempting to god/ungod should happen now is if the db is externally corrupted or manually changed... or until the next bug is uncovered :) | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/2388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |