github
Data license: AGPL · Data source: ACEmulator Project
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
436452465 | MDExOlB1bGxSZXF1ZXN0MjcyOTQxOTY5 | 1791 | sequence validation and negative response | 3317737 | closed | 0 | 0 | 2019-04-24T01:09:58Z | 2019-04-24T01:47:46Z | 2019-04-24T01:47:46Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1791 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1791/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436457516 | MDExOlB1bGxSZXF1ZXN0MjcyOTQ1NjY3 | 1792 | fixed during great stress stack overflow exception at listener thread | 3317737 | closed | 0 | 2 | 2019-04-24T01:36:22Z | 2019-07-08T13:38:18Z | 2019-07-08T13:38:18Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1792 | exception destroys the listener and crashes the server added ignorance for certain socket errors | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1792/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
436459325 | MDExOlB1bGxSZXF1ZXN0MjcyOTQ3MDA3 | 1793 | fixed boot command throwing exception when used at console | 3317737 | closed | 0 | 0 | 2019-04-24T01:45:39Z | 2019-04-24T06:27:51Z | 2019-04-24T06:27:51Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1793 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1793/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436463214 | MDExOlB1bGxSZXF1ZXN0MjcyOTQ5ODUw | 1794 | replaced character errors with confirmed working list | 3317737 | closed | 0 | 0 | 2019-04-24T02:05:23Z | 2019-04-24T06:25:24Z | 2019-04-24T06:25:24Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1794 | added element descriptions copied from old comments confirmed AccountInUse and Undefined are not real character errors | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1794/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
436470710 | MDExOlB1bGxSZXF1ZXN0MjcyOTU1MzMw | 1795 | adding allegiance name to appraisals | 8909245 | closed | 0 | 0 | 2019-04-24T02:42:27Z | 2019-04-24T03:58:46Z | 2019-04-24T03:58:46Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1795 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1795/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436493854 | MDExOlB1bGxSZXF1ZXN0MjcyOTcyNTY0 | 1796 | Adding /ciloot dev command | 8909245 | closed | 0 | 0 | 2019-04-24T04:40:19Z | 2019-04-24T06:03:08Z | 2019-04-24T06:03:08Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1796 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1796/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436494014 | MDU6SXNzdWU0MzY0OTQwMTQ= | 1797 | Loot generator is failing to spawn many items | 8909245 | closed | 0 | 1 | 2019-04-24T04:41:13Z | 2019-04-26T05:48:45Z | 2019-04-26T05:48:45Z | COLLABORATOR | <!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING --> ### Bug Report or Feature Request (mark with an `x`) ``` - [x ] bug report -> please search issues before submitting - [ ] feature request ``` ### Repro steps. With https://github.com/ACEmulator/ACE/pull/1796 installed, /ciloot <tier> <# of items> ### The log given by the failure. <!-- Normally this include a stack trace and some other information about the failure. --> ### Desired functionality. <!-- What would like to see implemented? What is the use case? --> - LootGenerationFactory.CreateRandomLootObjects should never return null object ### Mention any other details that might be useful. <!-- Please include any information that can help clarify the request here --> | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1797/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | ||||||
436499594 | MDExOlB1bGxSZXF1ZXN0MjcyOTc2OTE3 | 1798 | GiveObjectToPlayer fixes | 11369233 | closed | 0 | 0 | 2019-04-24T05:10:39Z | 2019-05-20T16:47:17Z | 2019-04-24T05:24:31Z | MEMBER | 0 | ACEmulator/ACE/pulls/1798 | * Send contents of container when given one by a player * Attempt to return failed given item back to giver | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1798/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
436500324 | MDExOlB1bGxSZXF1ZXN0MjcyOTc3NDc0 | 1799 | adding GetBlockDist | 8909245 | closed | 0 | 0 | 2019-04-24T05:14:19Z | 2019-04-24T05:21:59Z | 2019-04-24T05:21:59Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1799 | This adds some protection against some extreme transition scenarios / feeding bad transitions to the physics engine This can prevent some CPU lockups for ranged monsters taking aim at the player, and then the player portals away | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1799/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
436507918 | MDExOlB1bGxSZXF1ZXN0MjcyOTgzMzk5 | 1800 | Fixed Gems not dropping in loot | 26606778 | closed | 0 | 0 | 2019-04-24T05:49:07Z | 2020-06-15T20:59:16Z | 2019-04-24T06:03:16Z | COLLABORATOR | 0 | ACEmulator/ACE/pulls/1800 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1800/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436512417 | MDExOlB1bGxSZXF1ZXN0MjcyOTg2OTAx | 1801 | Fix wonky mana on Missile weapons in LootGen | 11369233 | closed | 0 | 0 | 2019-04-24T06:07:42Z | 2019-05-20T16:47:16Z | 2019-04-24T06:11:02Z | MEMBER | 0 | ACEmulator/ACE/pulls/1801 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1801/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436525668 | MDExOlB1bGxSZXF1ZXN0MjcyOTk3MTE1 | 1802 | Fix crash on null CurrentMotionState | 11369233 | closed | 0 | 0 | 2019-04-24T06:52:25Z | 2019-05-20T16:47:16Z | 2019-04-24T07:08:00Z | MEMBER | 0 | ACEmulator/ACE/pulls/1802 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1802/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
436562963 | MDExOlB1bGxSZXF1ZXN0MjczMDI1NTU3 | 1803 | Loot refactoring - Clothing | 10137 | closed | 0 | 0 | 2019-04-24T08:27:35Z | 2019-04-25T18:11:03Z | 2019-04-25T05:43:56Z | NONE | 0 | ACEmulator/ACE/pulls/1803 | - Refactored LootGenerationFactory_Clothing.cs - Attempt to normalize AL values - Use builtin clothing/armor ArmorModVs values - Remove Incantation of Defenselessness Self from loot and replace with Incantation of Missile Mastery Self | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1803/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
436649864 | MDExOlB1bGxSZXF1ZXN0MjczMDkzODQz | 1804 | Testing: ShardDbContextWithFinalize Test | 10608427 | closed | 0 | 0 | 2019-04-24T11:45:31Z | 2019-06-19T01:08:57Z | 2019-04-28T17:17:38Z | MEMBER | 0 | ACEmulator/ACE/pulls/1804 | DbContext does not implement a finalizer, so nothing to call Dipose() for us if we fail to do so ourselves (which we are currentlyl...) This is just a test to see if it helps CE memory usage This might actually be good for master, but, on windows server core 2016, i haven't noticed the need to explicitly add the finalizer. Even without it, my objects seem to get cleaned up. Could just be my test environment isn't exaggerating the underlying issue though. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1804/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
436831419 | MDExOlB1bGxSZXF1ZXN0MjczMjM5NDU1 | 1805 | Add support for AwardXP "spending" xp | 11369233 | closed | 0 | 0 | 2019-04-24T17:56:46Z | 2019-05-20T16:47:13Z | 2019-04-25T05:43:33Z | MEMBER | 0 | ACEmulator/ACE/pulls/1805 | Only known use case: Blank Augmentation Gem -> Donatello Linante -> Asheron's Lesser Benediction | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/1805/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |