github
Data license: AGPL · Data source: ACEmulator Project
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
205361124 | MDExOlB1bGxSZXF1ZXN0MTA0NjY4MTI0 | 21 | Change password hashing to use scrypt | 570040 | closed | 0 | 4 | 2017-02-04T17:28:50Z | 2017-03-20T02:20:14Z | 2017-03-20T02:20:14Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/21 | I switched the password hashing over to use libsodium's scrypt implementation. This involved adding a new migration. I noticed that currently the password isn't checked. I started looking into how to implement password checking and it looks like we will probably need to have a launcher to do so. The reason the commit touches so many files is because it also cleans up the files with mixed line endings. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/21/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
206403228 | MDU6SXNzdWUyMDY0MDMyMjg= | 51 | Saving a Character to the DB | 25351661 | closed | 0 | 25351661 | 5 | 2017-02-09T04:47:27Z | 2017-03-20T02:53:25Z | 2017-03-20T02:53:25Z | CONTRIBUTOR | intermittently? on logout? by command? something | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/51/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | |||||
206403292 | MDU6SXNzdWUyMDY0MDMyOTI= | 52 | Leveling up when granted xp | 25351661 | closed | 0 | 25351661 | 2 | 2017-02-09T04:47:53Z | 2017-03-20T02:54:03Z | 2017-03-20T02:54:03Z | CONTRIBUTOR | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/52/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | ||||||
206403348 | MDU6SXNzdWUyMDY0MDMzNDg= | 53 | Skill Credits: saving, loading, spending | 25351661 | closed | 0 | 25351661 | 2 | 2017-02-09T04:48:15Z | 2017-03-20T14:32:29Z | 2017-03-20T14:31:26Z | CONTRIBUTOR | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/53/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | ||||||
210534535 | MDU6SXNzdWUyMTA1MzQ1MzU= | 96 | Broadcasting chat to appropriate scope and loading landblocks | 25351661 | closed | 0 | 25351661 | 0 | 2017-02-27T16:27:03Z | 2017-03-20T14:31:11Z | 2017-03-20T14:31:11Z | CONTRIBUTOR | placeholder issue for what i'm working on, really | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/96/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | completed | 79078680 | issue | |||||
214820003 | MDExOlB1bGxSZXF1ZXN0MTExMTUxODk2 | 138 | police-mode /on | 25351661 | closed | 0 | 0 | 2017-03-16T19:53:59Z | 2017-05-30T15:34:35Z | 2017-03-20T02:14:56Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/138 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/138/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
215216326 | MDExOlB1bGxSZXF1ZXN0MTExNDIyNTE4 | 143 | Saving Character to Database | 11369233 | closed | 0 | 0 | 2017-03-18T19:35:31Z | 2017-03-20T02:57:39Z | 2017-03-20T02:46:55Z | MEMBER | 0 | ACEmulator/ACE/pulls/143 | "Ripley has been saved." This PR includes commits from the following PRs: #117 #119 #125 #134 #141 This PR addresses issues: #51 #52 #53 Code work was done by @fantoms and myself Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues. Spending Skill Credits is not yet addressed. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/143/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
215229710 | MDExOlB1bGxSZXF1ZXN0MTExNDMwMzg4 | 145 | Change the AdminObjectFactory to LifestoneObjectFactory, add PortalOb… | 10137 | closed | 0 | 0 | 2017-03-18T23:42:13Z | 2017-10-18T14:07:38Z | 2017-03-20T01:44:37Z | NONE | 0 | ACEmulator/ACE/pulls/145 | …jectFactory, add LifestoneType and PortalType Enums, remove unneeded GameMessageCreateLifestone, and remove the leftover DebugAssert command in ObjectGuid | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/145/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
215266773 | MDExOlB1bGxSZXF1ZXN0MTExNDUxNTMy | 147 | Some minor cosmetic fixes. | 10608427 | closed | 0 | 0 | 2017-03-19T14:15:17Z | 2017-03-20T20:05:49Z | 2017-03-20T20:05:49Z | MEMBER | 0 | ACEmulator/ACE/pulls/147 | Some possible threading issues fixed. This also forces the build for ACE to x64 only. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
215282644 | MDExOlB1bGxSZXF1ZXN0MTExNDYwODg4 | 148 | Add a link to ace-db docker image in the README | 8466632 | closed | 0 | 3 | 2017-03-19T18:11:02Z | 2017-03-21T03:14:49Z | 2017-03-20T05:14:00Z | NONE | 0 | ACEmulator/ACE/pulls/148 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
215315873 | MDExOlB1bGxSZXF1ZXN0MTExNDgwMjQ5 | 149 | added code for palettes to work correctly. PaletteGuid - corrected … | 25460553 | closed | 0 | 0 | 2017-03-20T02:02:48Z | 2017-04-14T19:37:38Z | 2017-03-20T02:39:10Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/149 | Small PR to fix bug with Palette method. Added PaletteGuid and write it out as required. Fixed Spelling. The fix for this was originally implemented by @LytelthorpeThistledown Getting this in sooner rather than later will help a lot of people as they are starting to work on this area of the code. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/149/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
215324894 | MDExOlB1bGxSZXF1ZXN0MTExNDg1ODQ2 | 150 | Wired up @heal command and conformed admincommands to stylecop rules | 11369233 | closed | 0 | 0 | 2017-03-20T03:45:59Z | 2017-03-20T03:47:19Z | 2017-03-20T03:47:19Z | MEMBER | 0 | ACEmulator/ACE/pulls/150 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
215325969 | MDExOlB1bGxSZXF1ZXN0MTExNDg2NTky | 151 | AdminCommands Code Style change | 11369233 | closed | 0 | 0 | 2017-03-20T03:58:36Z | 2017-04-21T03:49:29Z | 2017-03-20T05:09:12Z | MEMBER | 0 | ACEmulator/ACE/pulls/151 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
215337062 | MDExOlB1bGxSZXF1ZXN0MTExNDkzODUz | 153 | Feature: Spend Skill Credits | 37453 | closed | 0 | 0 | 2017-03-20T06:11:56Z | 2017-05-23T15:53:56Z | 2017-03-20T12:08:34Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/153 | Within this request I've sent code that will allow the client to attempt too spend skill credits. If enough skill credits are available, the server will grant the skill to the the character. If the skill credits are not available or the skill has already been trained, then the server makes sure to send the correct game messages with Skill.None, to keep the client from locking up. On the bottom of the Skill.cs, I've added an extension that allows for skills with proper names, example: `Sneak Attack` instead of `SneakAttack`. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | |||||
215393441 | MDExOlB1bGxSZXF1ZXN0MTExNTMyOTE1 | 154 | complete stylecop cleanup | 26334665 | closed | 0 | 0 | 2017-03-20T11:32:10Z | 2017-05-30T15:34:27Z | 2017-03-20T12:05:51Z | CONTRIBUTOR | 0 | ACEmulator/ACE/pulls/154 | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/154/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull | ||||||
215484872 | MDExOlB1bGxSZXF1ZXN0MTExNTk5MDcy | 156 | Heal: Update Player object, then send its data | 11369233 | closed | 0 | 1 | 2017-03-20T16:51:50Z | 2017-04-21T03:49:12Z | 2017-03-20T20:06:39Z | MEMBER | 0 | ACEmulator/ACE/pulls/156 | Original code only made client aware of change, didn't update the server's player object. | {"url": "https://api.github.com/repos/ACEmulator/ACE/issues/156/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 79078680 | pull |