pull_requests: 706086880
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
706086880 | MDExOlB1bGxSZXF1ZXN0NzA2MDg2ODgw | 3644 | closed | 0 | Add automatic timeout to Confirmations | 11369233 | Confirmations had 30 second timeouts in retail. Retail also seemingly could queue multiple confirmations up at the same time, however the client would only display the first one received. The others it would appear timed out. Since ACE doesn't really need to emulate stacking, instead we'll send feedback to initiator if confirmation would have been stacked. Self contained confirmations (Using an Gem, or similar from player inventory) likely do not need feedback on stacking, so continuing to ignore those duplicates for now. Example would be two different characters (Player A and Player B) attempting to recruit a third character (Player C) into a fellowship. Player A's confirmation request is sent. Player B would get a Player C is busy message. This also resolves issues with InqYesNo emotes, ensuring a response branch is always triggered, either TestSuccess if player accepts, or TestFailure if they decline, timeout, or somehow trigger stacking. | 2021-08-08T18:28:43Z | 2021-09-25T15:16:32Z | 2021-08-08T23:02:08Z | 2021-08-08T23:02:08Z | 1ac064c6a62078f757d22f4f1d90a49ee40e12de | 0 | 82b0486eb7b2cd61647c92103ce8c4502721348d | f5da7616c29db53539cba7c4a1a0bc4077bb9285 | MEMBER | 79078680 | https://github.com/ACEmulator/ACE/pull/3644 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests