pull_requests: 392557589
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
392557589 | MDExOlB1bGxSZXF1ZXN0MzkyNTU3NTg5 | 2848 | closed | 0 | fix corpses spawning frozen in mid-air | 8909245 | Repro steps: - /god (for mega jump) - /pk pk - do a standing jump forward, @ full jump power - type /rip in chat window immediately after leaving the ground Expected: - corpse spawns in midair, near the apex of the jump, and continues the previous trajectory of the jumping player, eventually falling back to the ground Actual: - corpse spawns frozen in midair, near the apex of the jump This PR persists the physics velocity (used only for jumping) of the dying creature to the corpse, causing the expected behavior I have confirmed that ACE is correctly / automatically updating the latest position of the corpse to the database, after it lands. This can be seen with using /reload-landblock after the corpse falls to the ground. One caveat is: since Velocity is a runtime-only field, and not persisted to the database, corpses that are restored from the database with a position in the air will still not fall to the ground. This can be reproed with the previous steps, and then doing an unsafe shutdown of the server immediately after respawning. In this situation, the corpse was saved immediately to the database when created, but the unsafe shutdown prevents the server from saving the latest landblock state after the corpse has reached the ground position. Some additional admin / dev commands have been added to aid in these scenarios. /movetome moves the last appraised object to the admin player. This can be useful for corpse retrieval. A /bumpvelocity command has also been added, which gives the last appraised object a tiny bit of upwards velocity, which also has the amusing effect of causing floating corpses to visually fall to the ground. | 2020-03-23T18:19:44Z | 2020-03-24T00:56:35Z | 2020-03-24T00:56:35Z | 2020-03-24T00:56:35Z | 56255472e47387fa3198c1895248a30be8239ca9 | 0 | 4370a8bf63fe4312138def9311c1f6e85a1b6765 | ace0fc230f76a5488b6ead4907149442a74d44dc | COLLABORATOR | 79078680 | https://github.com/ACEmulator/ACE/pull/2848 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests