pull_requests: 342014625
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
342014625 | MDExOlB1bGxSZXF1ZXN0MzQyMDE0NjI1 | 2430 | closed | 0 | WorldObject_Weapon / imbue refactoring | 8909245 | So this started with digging into an off-by-1 error for Crippling Blow, and then went down the rabbit hole of fixing some issues with Critical Strike, and figuring out more of the details with that, which eventually lead to finding some scaling issues that mostly affect people who aren't at the caps for imbues yet. Along the way, I ended up cleaning up a lot of WorldObject_Weapon, and moving around some of the functions in that file for better organization / readability. The moving around of some function positions in the file unfortunately makes the git diff a bit confusing to read through, but all of the functionality is the same there, just moved around and refactored a bit. Tested the 4 key imbues: Critical Strike, Crippling Blow, Elemental Rend, and Armor Rend, and verified that all of the new functions are working as expected. More details to follow.. | 2019-11-18T07:54:04Z | 2019-11-21T03:41:59Z | 2019-11-21T03:41:58Z | 2019-11-21T03:41:58Z | c20a580890d614f155826f5d465981baf69b87cf | 0 | 1a82876198578558e6bd43f329056d117bf070fd | 0c9eb14766dceb90a4c828a056cf3350ef9437ff | COLLABORATOR | 79078680 | https://github.com/ACEmulator/ACE/pull/2430 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests