pull_requests: 290869051
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
290869051 | MDExOlB1bGxSZXF1ZXN0MjkwODY5MDUx | 2035 | closed | 0 | additional healing kit refactoring | 8909245 | - removed duplicate BoostEnum/BoosterEnum properties in Food/Healer, moved to WorldObject_Properties using original name - refactored Food."BoostEnum - 1" and Healer.GetVitalsByKitType() into common GetCreatureVital(PropertyAttribute2nd) - left a note for Structure/MaxStructure ushort/int inconsistency for future refactoring - Added TransientMessages for '<target> is already at full <vital>!' for stamina/mana (doesn't appear to be werrors for those) - Added logic for UnlimitedUse kits - Updated remainingMsg to match retail: removed double space, '1 use', 'Your <kitName> is used up.' also sent on failure, omitting message for UnlimitedUse - Fixed a bug where Healer.DoSkillCheck() was using target.MissingHealth instead of target.MissingVital - Ensure UnlimitedUse kits are never consumed - Removed redundant GameMessagePrivateUpdateAttribute2ndLevel network message, already sent in UpdateVitalDelta - cleaned up comments | 2019-06-23T07:08:48Z | 2019-06-23T10:36:17Z | 2019-06-23T10:36:17Z | 2019-06-23T10:36:17Z | a4c985811559c1ae20ac5aea5bbc4cfe2d39e52d | 0 | b555c764517714da4a74ca98b713e86dfa5c5a03 | df8ff08c626513e8150beab10eb3a374593669bf | COLLABORATOR | 79078680 | https://github.com/ACEmulator/ACE/pull/2035 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests