pull_requests: 242204060
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
242204060 | MDExOlB1bGxSZXF1ZXN0MjQyMjA0MDYw | 1230 | closed | 0 | Adding built-in spells to casting items | 8909245 | This starts to address https://github.com/ACEmulator/ACE/issues/1225 This is not a full solution, but it does fix the crashing, and gets the spell to cast Open questions: - Should there be a windup animation when casting spells built into the wand? - Should those spells use the 'Spellcraft' from the wand for the attack skill level, instead of the player's magic skill? - Should those spells use mana from the wand, instead of from the player's mana? | 2019-01-04T08:48:52Z | 2019-01-05T15:29:38Z | 2019-01-05T15:29:37Z | 2019-01-05T15:29:37Z | 3974e2e2bc47ee3b51a225ddceecb88619f9bd1b | 0 | 9d2cde40742baf851956bb9258ecb4b97f453cd9 | 5620d0a5d3126e12cc200306110e94950b448be4 | COLLABORATOR | 79078680 | https://github.com/ACEmulator/ACE/pull/1230 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests